Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-25 Thread Stephen Boyd
On 08/25, Masahiro Yamada wrote: > > Good. > Could you post it as a patch file? > Sure. I'll write up some commit text. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-25 Thread Stephen Boyd
On 08/25, Masahiro Yamada wrote: > > Good. > Could you post it as a patch file? > Sure. I'll write up some commit text. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-24 Thread Masahiro Yamada
Hi Stephen, 2016-08-25 3:08 GMT+09:00 Stephen Boyd : > (Please trim replies) > > On 08/24, Masahiro Yamada wrote: >> >> Looks like the whole of my series was rejected, >> but I was not sure why the following one was rejected. >> https://patchwork.kernel.org/patch/9236563/

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-24 Thread Masahiro Yamada
Hi Stephen, 2016-08-25 3:08 GMT+09:00 Stephen Boyd : > (Please trim replies) > > On 08/24, Masahiro Yamada wrote: >> >> Looks like the whole of my series was rejected, >> but I was not sure why the following one was rejected. >> https://patchwork.kernel.org/patch/9236563/ >> > > Replying to that

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-24 Thread Stephen Boyd
(Please trim replies) On 08/24, Masahiro Yamada wrote: > > Looks like the whole of my series was rejected, > but I was not sure why the following one was rejected. > https://patchwork.kernel.org/patch/9236563/ > Replying to that patch would have been better. > > Could you explain why

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-24 Thread Stephen Boyd
(Please trim replies) On 08/24, Masahiro Yamada wrote: > > Looks like the whole of my series was rejected, > but I was not sure why the following one was rejected. > https://patchwork.kernel.org/patch/9236563/ > Replying to that patch would have been better. > > Could you explain why

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-24 Thread Masahiro Yamada
Hi Stephen, 2016-08-12 16:04 GMT+09:00 Masahiro Yamada : > 2016-08-11 8:08 GMT+09:00 Stephen Boyd : >> On 08/10, Masahiro Yamada wrote: >>> Hi Stephen, >>> >>> >>> >>> 2016-08-09 8:37 GMT+09:00 Stephen Boyd : >>> > On

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-24 Thread Masahiro Yamada
Hi Stephen, 2016-08-12 16:04 GMT+09:00 Masahiro Yamada : > 2016-08-11 8:08 GMT+09:00 Stephen Boyd : >> On 08/10, Masahiro Yamada wrote: >>> Hi Stephen, >>> >>> >>> >>> 2016-08-09 8:37 GMT+09:00 Stephen Boyd : >>> > On 08/08, Masahiro Yamada wrote: >>> >> Hi Stephen, >>> >> >>> >> >>> >>

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-12 Thread Masahiro Yamada
2016-08-11 8:08 GMT+09:00 Stephen Boyd : > On 08/10, Masahiro Yamada wrote: >> Hi Stephen, >> >> >> >> 2016-08-09 8:37 GMT+09:00 Stephen Boyd : >> > On 08/08, Masahiro Yamada wrote: >> >> Hi Stephen, >> >> >> >> >> >> 2016-08-05 6:25 GMT+09:00 Stephen

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-12 Thread Masahiro Yamada
2016-08-11 8:08 GMT+09:00 Stephen Boyd : > On 08/10, Masahiro Yamada wrote: >> Hi Stephen, >> >> >> >> 2016-08-09 8:37 GMT+09:00 Stephen Boyd : >> > On 08/08, Masahiro Yamada wrote: >> >> Hi Stephen, >> >> >> >> >> >> 2016-08-05 6:25 GMT+09:00 Stephen Boyd : >> > >> >> >> >> of_clk_add_provider()

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-10 Thread Stephen Boyd
On 08/10, Masahiro Yamada wrote: > Hi Stephen, > > > > 2016-08-09 8:37 GMT+09:00 Stephen Boyd : > > On 08/08, Masahiro Yamada wrote: > >> Hi Stephen, > >> > >> > >> 2016-08-05 6:25 GMT+09:00 Stephen Boyd : > > > >> > >> of_clk_add_provider() calls

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-10 Thread Stephen Boyd
On 08/10, Masahiro Yamada wrote: > Hi Stephen, > > > > 2016-08-09 8:37 GMT+09:00 Stephen Boyd : > > On 08/08, Masahiro Yamada wrote: > >> Hi Stephen, > >> > >> > >> 2016-08-05 6:25 GMT+09:00 Stephen Boyd : > > > >> > >> of_clk_add_provider() calls of_clk_del_provider() > >> in its failure path.

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-10 Thread Masahiro Yamada
Hi Stephen, 2016-08-09 8:37 GMT+09:00 Stephen Boyd : > On 08/08, Masahiro Yamada wrote: >> Hi Stephen, >> >> >> 2016-08-05 6:25 GMT+09:00 Stephen Boyd : >> > +Rob in case he has any insight >> > >> > On 07/09, Masahiro Yamada wrote: >> >> Hi. >> >> >>

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-10 Thread Masahiro Yamada
Hi Stephen, 2016-08-09 8:37 GMT+09:00 Stephen Boyd : > On 08/08, Masahiro Yamada wrote: >> Hi Stephen, >> >> >> 2016-08-05 6:25 GMT+09:00 Stephen Boyd : >> > +Rob in case he has any insight >> > >> > On 07/09, Masahiro Yamada wrote: >> >> Hi. >> >> >> >> I think the current code allows to add

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-08 Thread Stephen Boyd
On 08/08, Masahiro Yamada wrote: > Hi Stephen, > > > 2016-08-05 6:25 GMT+09:00 Stephen Boyd : > > +Rob in case he has any insight > > > > On 07/09, Masahiro Yamada wrote: > >> Hi. > >> > >> I think the current code allows to add > >> clk_providers multiple times against one

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-08 Thread Stephen Boyd
On 08/08, Masahiro Yamada wrote: > Hi Stephen, > > > 2016-08-05 6:25 GMT+09:00 Stephen Boyd : > > +Rob in case he has any insight > > > > On 07/09, Masahiro Yamada wrote: > >> Hi. > >> > >> I think the current code allows to add > >> clk_providers multiple times against one DT node. > >> > >>

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-08 Thread Geert Uytterhoeven
On Sun, Aug 7, 2016 at 6:54 PM, Masahiro Yamada wrote: > 2016-08-05 6:25 GMT+09:00 Stephen Boyd : >> +Rob in case he has any insight >> >> On 07/09, Masahiro Yamada wrote: >>> I think the current code allows to add >>> clk_providers multiple

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-08 Thread Geert Uytterhoeven
On Sun, Aug 7, 2016 at 6:54 PM, Masahiro Yamada wrote: > 2016-08-05 6:25 GMT+09:00 Stephen Boyd : >> +Rob in case he has any insight >> >> On 07/09, Masahiro Yamada wrote: >>> I think the current code allows to add >>> clk_providers multiple times against one DT node. >>> >>> Are there cases that

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-07 Thread Masahiro Yamada
Hi Stephen, 2016-08-05 6:25 GMT+09:00 Stephen Boyd : > +Rob in case he has any insight > > On 07/09, Masahiro Yamada wrote: >> Hi. >> >> I think the current code allows to add >> clk_providers multiple times against one DT node. >> >> Are there cases that really need to do

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-07 Thread Masahiro Yamada
Hi Stephen, 2016-08-05 6:25 GMT+09:00 Stephen Boyd : > +Rob in case he has any insight > > On 07/09, Masahiro Yamada wrote: >> Hi. >> >> I think the current code allows to add >> clk_providers multiple times against one DT node. >> >> Are there cases that really need to do so? > > If we have clk

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-04 Thread Rob Herring
On Thu, Aug 4, 2016 at 4:25 PM, Stephen Boyd wrote: > +Rob in case he has any insight > > On 07/09, Masahiro Yamada wrote: >> Hi. >> >> I think the current code allows to add >> clk_providers multiple times against one DT node. >> >> Are there cases that really need to do

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-04 Thread Rob Herring
On Thu, Aug 4, 2016 at 4:25 PM, Stephen Boyd wrote: > +Rob in case he has any insight > > On 07/09, Masahiro Yamada wrote: >> Hi. >> >> I think the current code allows to add >> clk_providers multiple times against one DT node. >> >> Are there cases that really need to do so? > > If we have clk

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-04 Thread Stephen Boyd
+Rob in case he has any insight On 07/09, Masahiro Yamada wrote: > Hi. > > I think the current code allows to add > clk_providers multiple times against one DT node. > > Are there cases that really need to do so? If we have clk drivers that have a device driver structure and also use

Re: of_clk_add_(hw_)providers multipule times for one node?

2016-08-04 Thread Stephen Boyd
+Rob in case he has any insight On 07/09, Masahiro Yamada wrote: > Hi. > > I think the current code allows to add > clk_providers multiple times against one DT node. > > Are there cases that really need to do so? If we have clk drivers that have a device driver structure and also use

of_clk_add_(hw_)providers multipule times for one node?

2016-07-08 Thread Masahiro Yamada
Hi. I think the current code allows to add clk_providers multiple times against one DT node. Are there cases that really need to do so? I am thinking the behavior of __of_clk_get_from_provider() is strange. The result of __of_clk_get_from_provider() has three patterns: [1] success [2]

of_clk_add_(hw_)providers multipule times for one node?

2016-07-08 Thread Masahiro Yamada
Hi. I think the current code allows to add clk_providers multiple times against one DT node. Are there cases that really need to do so? I am thinking the behavior of __of_clk_get_from_provider() is strange. The result of __of_clk_get_from_provider() has three patterns: [1] success [2]