RE: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

2014-09-09 Thread Anish Bhatt
mley > Subject: RE: randconfig build error with next-20140909, in > drivers/net/ethernet/broadcom/cnic.c > > On Tue, 2014-09-09 at 23:16 +, Anish Bhatt wrote: > > > It would be really good if SCSI_NETLINK depended on NET instead of > selected NET. > > > We shouldn

RE: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

2014-09-09 Thread Michael Chan
On Tue, 2014-09-09 at 23:16 +, Anish Bhatt wrote: > > It would be really good if SCSI_NETLINK depended on NET instead of selected > > NET. > > We shouldn't have kconfig symbols that use 'select' on entire subsystems. > > As a test, I was able to fix this by this approach : change

RE: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

2014-09-09 Thread Anish Bhatt
> It would be really good if SCSI_NETLINK depended on NET instead of selected > NET. > We shouldn't have kconfig symbols that use 'select' on entire subsystems. As a test, I was able to fix this by this approach : change SCSI_NETLINK to depend on NET instead of selecting NET, and replacing

Re: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

2014-09-09 Thread Randy Dunlap
On 09/09/14 14:08, Anish Bhatt wrote: > >> Adding depends on IPV6 || IPV6=n doesn't work for SCSI_BNX2X_FCOE, but >> works for SCSI_BNX2_ISCSI? > > It fixes the config issue for both, but with FCOE; make scripts will complain > about recursive dependencies with the following : > >

RE: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

2014-09-09 Thread Anish Bhatt
> Adding depends on IPV6 || IPV6=n doesn't work for SCSI_BNX2X_FCOE, but > works for SCSI_BNX2_ISCSI? It fixes the config issue for both, but with FCOE; make scripts will complain about recursive dependencies with the following : scripts/kconfig/conf --silentoldconfig Kconfig

RE: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

2014-09-09 Thread Michael Chan
On Tue, 2014-09-09 at 20:24 +, Anish Bhatt wrote: > This is caused by c99d667e8527 ("cnic : Cleanup CONFIG_IPV6 & VLAN check") > > So I'm not really sure what the fix for this is. CNIC will properly only > support > [m] or [n] when IPV6 is compiled as a module, but if you set

RE: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

2014-09-09 Thread Anish Bhatt
ch a situation. -Anish From: Jim Davis [jim.ep...@gmail.com] Sent: Tuesday, September 09, 2014 7:38 AM To: Stephen Rothwell; linux-next; linux-kernel; Anish Bhatt; mc...@broadcom.com; David S. Miller; netdev Subject: randconfig build error with next-20140909, i

randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

2014-09-09 Thread Jim Davis
Building with the attached random configuration file, drivers/built-in.o: In function `cnic_get_v6_route': cnic.c:(.text+0x3a4168): undefined reference to `ip6_route_output' make: *** [vmlinux] Error 1 # # Automatically generated file; DO NOT EDIT. # Linux/x86 3.17.0-rc4 Kernel Configuration #

randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

2014-09-09 Thread Jim Davis
Building with the attached random configuration file, drivers/built-in.o: In function `cnic_get_v6_route': cnic.c:(.text+0x3a4168): undefined reference to `ip6_route_output' make: *** [vmlinux] Error 1 # # Automatically generated file; DO NOT EDIT. # Linux/x86 3.17.0-rc4 Kernel Configuration #

RE: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

2014-09-09 Thread Anish Bhatt
From: Jim Davis [jim.ep...@gmail.com] Sent: Tuesday, September 09, 2014 7:38 AM To: Stephen Rothwell; linux-next; linux-kernel; Anish Bhatt; mc...@broadcom.com; David S. Miller; netdev Subject: randconfig build error with next-20140909, in drivers/net

RE: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

2014-09-09 Thread Michael Chan
On Tue, 2014-09-09 at 20:24 +, Anish Bhatt wrote: This is caused by c99d667e8527 (cnic : Cleanup CONFIG_IPV6 VLAN check) So I'm not really sure what the fix for this is. CNIC will properly only support [m] or [n] when IPV6 is compiled as a module, but if you set SCSI_BNX2X_FCOE or

RE: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

2014-09-09 Thread Anish Bhatt
Adding depends on IPV6 || IPV6=n doesn't work for SCSI_BNX2X_FCOE, but works for SCSI_BNX2_ISCSI? It fixes the config issue for both, but with FCOE; make scripts will complain about recursive dependencies with the following : scripts/kconfig/conf --silentoldconfig Kconfig

Re: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

2014-09-09 Thread Randy Dunlap
On 09/09/14 14:08, Anish Bhatt wrote: Adding depends on IPV6 || IPV6=n doesn't work for SCSI_BNX2X_FCOE, but works for SCSI_BNX2_ISCSI? It fixes the config issue for both, but with FCOE; make scripts will complain about recursive dependencies with the following : scripts/kconfig/conf

RE: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

2014-09-09 Thread Anish Bhatt
It would be really good if SCSI_NETLINK depended on NET instead of selected NET. We shouldn't have kconfig symbols that use 'select' on entire subsystems. As a test, I was able to fix this by this approach : change SCSI_NETLINK to depend on NET instead of selecting NET, and replacing

RE: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

2014-09-09 Thread Michael Chan
On Tue, 2014-09-09 at 23:16 +, Anish Bhatt wrote: It would be really good if SCSI_NETLINK depended on NET instead of selected NET. We shouldn't have kconfig symbols that use 'select' on entire subsystems. As a test, I was able to fix this by this approach : change SCSI_NETLINK to

RE: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

2014-09-09 Thread Anish Bhatt
: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c On Tue, 2014-09-09 at 23:16 +, Anish Bhatt wrote: It would be really good if SCSI_NETLINK depended on NET instead of selected NET. We shouldn't have kconfig symbols that use 'select' on entire subsystems