Re: [PATCH] net: sis: sis190: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Mon, 27 Feb 2017 23:06:41 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: sis: sis190: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Mon, 27 Feb 2017 23:06:41 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > > Signed-off-by: Philippe Reynes

[PATCH] net: sis: sis190: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes <trem...@gmail.com> --- drivers/net/ethernet/sis/sis190.c

[PATCH] net: sis: sis190: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/sis/sis190.c | 14 -- 1 files

Potential data race in drivers/net/ethernet/sis/sis190.ko

Hi! There is a potential data race in drivers/net/ethernet/sis/sis190.ko. Regard such situation: CPU 1 CPU 2 ... ->sis190_open - registers interrupts ... ->sis190_tx_timeout - is called at some point ->sis190_tx_clear skb = tp->Tx_skbuff[i

Potential data race in drivers/net/ethernet/sis/sis190.ko

Hi! There is a potential data race in drivers/net/ethernet/sis/sis190.ko. Regard such situation: CPU 1 CPU 2 ... ->sis190_open - registers interrupts ... ->sis190_tx_timeout - is called at some point ->sis190_tx_clear skb = tp->Tx_skbuff[i

[PATCH 05/19] net/ethernet/sis/sis190: Use module_pci_driver to register driver

Removing some boilerplate by using module_pci_driver instead of calling register and unregister in the otherwise empty init/exit functions. Signed-off-by: Peter Huewe --- drivers/net/ethernet/sis/sis190.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers

[PATCH 05/19] net/ethernet/sis/sis190: Use module_pci_driver to register driver

Removing some boilerplate by using module_pci_driver instead of calling register and unregister in the otherwise empty init/exit functions. Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/net/ethernet/sis/sis190.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff

[PATCH] drivers/net/sis190: fix section mismatch warning in sis190_get_mac_addr

Fix following warnings: WARNING: drivers/net/sis190.o(.text+0x103): Section mismatch in reference from the function sis190_get_mac_addr() to the function .devinit.text:sis190_get_mac_addr_from_apc() WARNING: drivers/net/sis190.o(.text+0x10e): Section mismatch in reference from the function

[PATCH] drivers/net/sis190: fix section mismatch warning in sis190_get_mac_addr

Fix following warnings: WARNING: drivers/net/sis190.o(.text+0x103): Section mismatch in reference from the function sis190_get_mac_addr() to the function .devinit.text:sis190_get_mac_addr_from_apc() WARNING: drivers/net/sis190.o(.text+0x10e): Section mismatch in reference from the function

Re: [PATCH] sis190: fix compile error section type conflict

On Sat, Feb 02, 2008 at 03:34:58PM +0100, Francois Romieu wrote: > Li Zefan <[EMAIL PROTECTED]> : > > Fix the following compile error: > > I am not sure that it is the right fix. Please read the archive of > this week on l-k. > > I'll submit the patch below to Jeff once I have tested it with

Re: [PATCH] sis190: fix compile error section type conflict

On Sat, Feb 02, 2008 at 03:34:58PM +0100, Francois Romieu wrote: Li Zefan [EMAIL PROTECTED] : Fix the following compile error: I am not sure that it is the right fix. Please read the archive of this week on l-k. I'll submit the patch below to Jeff once I have tested it with real

[PATCH] sis190: fix compile error section type conflict

Fix the following compile error: drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[2]: *** [drivers/net/sis190.o] Error 1 make[1]: *** [drivers/net] Error 2 make: *** [drivers] Error 2 Signed-off-by: Li Zefan <[EMAIL PROTECTED]> --- drivers/net/si

[PATCH] sis190: fix compile error section type conflict

Fix the following compile error: drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[2]: *** [drivers/net/sis190.o] Error 1 make[1]: *** [drivers/net] Error 2 make: *** [drivers] Error 2 Signed-off-by: Li Zefan [EMAIL PROTECTED] --- drivers/net/sis190.c |2

[PATCH] [SIS190] Use __devinitconst for const devinit data

Mixing const and __section was previously not allowed. New __devinitconst tag allows this. This fixes a gcc "section type mismatch" build error. --- drivers/net/sis190.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/sis190.c b/drivers/net/sis1

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

On Wed, Jan 30, 2008 at 02:31:05PM +0100, Jan Engelhardt wrote: > > On Jan 30 2008 12:25, Sam Ravnborg wrote: > > > >We have just introduced __initconst, __cpuinitconst, __meminitconst > >for const data. > >So the patch is wrong. > > Oh joy, more tags. Is it actually possible to combine const >

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

On Jan 30 2008 12:25, Sam Ravnborg wrote: > >We have just introduced __initconst, __cpuinitconst, __meminitconst >for const data. >So the patch is wrong. Oh joy, more tags. Is it actually possible to combine const with __devinitconst now? static const uint16_t foo[] __devinitconst = { ... }; --

Re: [PATCH] [SIS190] Use _devinitconst for const data

On Wed, Jan 30, 2008 at 12:57:16PM +0100, Jonas Bonn wrote: > This fixes build error as gcc complains about a "section type conflict" > due to the mixing of const and non-const data in same section. > --- > drivers/net/sis190.c |4 ++-- > 1 files changed, 2 i

[PATCH] [SIS190] Use _devinitconst for const data

This fixes build error as gcc complains about a "section type conflict" due to the mixing of const and non-const data in same section. --- drivers/net/sis190.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c ind

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

instead? Because AFAIK, const *and* __sectionmarker does not mix. > You're right... it's documented in linux/init.h that const and __sectionmarker do not mix. The compile error is due to the use of const and __section marker in the function sis190_get_mac_addr_from_apc(). -- To

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

On Wed, Jan 30, 2008 at 12:23:23PM +0100, Jan Engelhardt wrote: > > On Jan 30 2008 11:53, Jonas Bonn wrote: > > > >This fixes build error as gcc complains about a "section type conflict" > >due to the const __devinitdata in sis190_get_mac_addr_from_apc(). > > >-static struct pci_device_id

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

On Jan 30 2008 11:53, Jonas Bonn wrote: > >This fixes build error as gcc complains about a "section type conflict" >due to the const __devinitdata in sis190_get_mac_addr_from_apc(). >-static struct pci_device_id sis190_pci_tbl[] __devinitdata = { >+static const struct pci_device_id

[PATCH] [SIS190] Constify data marked as __devinitdata

This fixes build error as gcc complains about a "section type conflict" due to the const __devinitdata in sis190_get_mac_addr_from_apc(). --- drivers/net/sis190.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c ind

Re: [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver

Sam Ravnborg wrote: > On Wed, Jan 30, 2008 at 09:11:36AM +0530, Kamalesh Babulal wrote: >> Hi, >> >> The 2.6.24-git6 kernel build fails on various x86_64 machines with the build >> failure >> >> drivers/net/sis190.c:329: error: sis190_pci_tbl cause

Re: [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver

Gabriel C wrote: > Kamalesh Babulal wrote: >> Hi, >> >> The 2.6.24-git6 kernel build fails on various x86_64 machines with the build >> failure >> >> drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type >> conflict >> make

Re: [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver

Gabriel C wrote: Kamalesh Babulal wrote: Hi, The 2.6.24-git6 kernel build fails on various x86_64 machines with the build failure drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[2]: *** [drivers/net/sis190.o] Error 1 # gcc --version (machine1) gcc

Re: [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver

Sam Ravnborg wrote: On Wed, Jan 30, 2008 at 09:11:36AM +0530, Kamalesh Babulal wrote: Hi, The 2.6.24-git6 kernel build fails on various x86_64 machines with the build failure drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[2]: *** [drivers/net/sis190

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

On Jan 30 2008 11:53, Jonas Bonn wrote: This fixes build error as gcc complains about a section type conflict due to the const __devinitdata in sis190_get_mac_addr_from_apc(). -static struct pci_device_id sis190_pci_tbl[] __devinitdata = { +static const struct pci_device_id sis190_pci_tbl[]

[PATCH] [SIS190] Constify data marked as __devinitdata

This fixes build error as gcc complains about a section type conflict due to the const __devinitdata in sis190_get_mac_addr_from_apc(). --- drivers/net/sis190.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index b570402

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

On Wed, Jan 30, 2008 at 12:23:23PM +0100, Jan Engelhardt wrote: On Jan 30 2008 11:53, Jonas Bonn wrote: This fixes build error as gcc complains about a section type conflict due to the const __devinitdata in sis190_get_mac_addr_from_apc(). -static struct pci_device_id sis190_pci_tbl[]

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

instead? Because AFAIK, const *and* __sectionmarker does not mix. You're right... it's documented in linux/init.h that const and __sectionmarker do not mix. The compile error is due to the use of const and __section marker in the function sis190_get_mac_addr_from_apc(). -- To unsubscribe

[PATCH] [SIS190] Use _devinitconst for const data

This fixes build error as gcc complains about a section type conflict due to the mixing of const and non-const data in same section. --- drivers/net/sis190.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index b570402

Re: [PATCH] [SIS190] Use _devinitconst for const data

On Wed, Jan 30, 2008 at 12:57:16PM +0100, Jonas Bonn wrote: This fixes build error as gcc complains about a section type conflict due to the mixing of const and non-const data in same section. --- drivers/net/sis190.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

[PATCH] [SIS190] Use __devinitconst for const devinit data

Mixing const and __section was previously not allowed. New __devinitconst tag allows this. This fixes a gcc section type mismatch build error. --- drivers/net/sis190.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

On Wed, Jan 30, 2008 at 02:31:05PM +0100, Jan Engelhardt wrote: On Jan 30 2008 12:25, Sam Ravnborg wrote: We have just introduced __initconst, __cpuinitconst, __meminitconst for const data. So the patch is wrong. Oh joy, more tags. Is it actually possible to combine const with

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

On Jan 30 2008 12:25, Sam Ravnborg wrote: We have just introduced __initconst, __cpuinitconst, __meminitconst for const data. So the patch is wrong. Oh joy, more tags. Is it actually possible to combine const with __devinitconst now? static const uint16_t foo[] __devinitconst = { ... }; -- To

Re: [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver

On Wed, Jan 30, 2008 at 09:11:36AM +0530, Kamalesh Babulal wrote: > Hi, > > The 2.6.24-git6 kernel build fails on various x86_64 machines with the build > failure > > drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict > make[2]: *** [drivers/

Re: [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver

Kamalesh Babulal wrote: > Hi, > > The 2.6.24-git6 kernel build fails on various x86_64 machines with the build > failure > > drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict > make[2]: *** [drivers/net/sis190.o] Error 1 > > # gcc --ve

[BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver

Hi, The 2.6.24-git6 kernel build fails on various x86_64 machines with the build failure drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[2]: *** [drivers/net/sis190.o] Error 1 # gcc --version (machine1) gcc (GCC) 4.1.1 20070105 (Red Hat 4.1.1-52) # gcc

[BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver

Hi, The 2.6.24-git6 kernel build fails on various x86_64 machines with the build failure drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[2]: *** [drivers/net/sis190.o] Error 1 # gcc --version (machine1) gcc (GCC) 4.1.1 20070105 (Red Hat 4.1.1-52) # gcc

Re: [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver

On Wed, Jan 30, 2008 at 09:11:36AM +0530, Kamalesh Babulal wrote: Hi, The 2.6.24-git6 kernel build fails on various x86_64 machines with the build failure drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[2]: *** [drivers/net/sis190.o] Error 1 # gcc

Re: [2.6 patch] drivers/net/sis190.c section fix

Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 29fae057ba15a552a7cad1e731d3238d567032ba diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index 7200883..49f767b 100644 --- a/drivers/net/sis190.c +++ b/drivers/net/sis190.c @@ -1381,7 +1381,7 @@ out: return rc; } -sta

Re: [2.6 patch] drivers/net/sis190.c section fix

-by: Adrian Bunk [EMAIL PROTECTED] --- 29fae057ba15a552a7cad1e731d3238d567032ba diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index 7200883..49f767b 100644 --- a/drivers/net/sis190.c +++ b/drivers/net/sis190.c @@ -1381,7 +1381,7 @@ out: return rc; } -static void __devexit

Re: [2.6 patch] drivers/net/sis190.c section fix

pplied at: git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git sis190 -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Ple

Re: [2.6 patch] drivers/net/sis190.c section fix

://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git sis190 -- Ueimor -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

[2.6 patch] drivers/net/sis190.c section fix

Bunk <[EMAIL PROTECTED]> --- 29fae057ba15a552a7cad1e731d3238d567032ba diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index 7200883..49f767b 100644 --- a/drivers/net/sis190.c +++ b/drivers/net/sis190.c @@ -1381,7 +1381,7 @@ out: return rc; } -static void __devexit sis190

[2.6 patch] drivers/net/sis190.c section fix

PROTECTED] --- 29fae057ba15a552a7cad1e731d3238d567032ba diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index 7200883..49f767b 100644 --- a/drivers/net/sis190.c +++ b/drivers/net/sis190.c @@ -1381,7 +1381,7 @@ out: return rc; } -static void __devexit sis190_mii_remove(struct

Re: SIS190.c

.24-rc2 ? diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index 7200883..51bbb60 100644 --- a/drivers/net/sis190.c +++ b/drivers/net/sis190.c @@ -1549,28 +1549,31 @@ static int __devinit sis190_get_mac_addr_from_eeprom(struct pci_dev *pdev, } /** - * sis190_get_mac_addr_from_apc -

Re: SIS190.c

a/drivers/net/sis190.c b/drivers/net/sis190.c index 7200883..51bbb60 100644 --- a/drivers/net/sis190.c +++ b/drivers/net/sis190.c @@ -1549,28 +1549,31 @@ static int __devinit sis190_get_mac_addr_from_eeprom(struct pci_dev *pdev, } /** - * sis190_get_mac_addr_from_apc - Get MAC address

[patch 33/59] sis190: failure to set the MAC address from EEPROM

y: Francois Romieu <[EMAIL PROTECTED]> Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Chris Wright <[EMAIL PROTECTED]> --- drivers/net/sis190.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.6.19.2.orig/drivers/net/sis190.c +++ linux-2.6.

[patch 33/59] sis190: failure to set the MAC address from EEPROM

PROTECTED] Signed-off-by: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Chris Wright [EMAIL PROTECTED] --- drivers/net/sis190.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.6.19.2.orig/drivers/net/sis190.c +++ linux-2.6.19.2/drivers/net/sis190.c @@ -1559,7 +1559,7 @@ static

[patch 2.6.13-git3 2/5] sis190: recent chipsets from SiS include a RGMII

Extracted from SiS's GPLed driver. From the few pdf available at SiS's, it seems that the 965 and the 966 south bridge include this interface whereas the 965L (and anything below) does not. It is expected to be a sis191 related feature and should not hurt the existing sis190 driver. Signed-off

[patch 2.6.13-git3 1/5] sis190: unmask the link change events

link changes reporting does not work when the driver masks its irq event Signed-off-by: Arnaud Patard <[EMAIL PROTECTED]> Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> diff -puN a/drivers/net/sis190.c~sis190-170 b/drivers/net/sis190.c --- a/drivers/net/sis190.c~sis190-170 2005

[patch 2.6.13-git3 5/5] sis190: basic sis191 support

The sis191 is the gigabit brother of the sis190. SiS's driver suggests that the register set is backward compatible: this should hopefully give a basic driver. The device should allow the usual features from a modern ethernet adapter (802.1q, SG, Jumbo frames, TSO, checksum offload). So far

[patch 2.6.13-git3 4/5] sis190: RGMII Tx internal delay fiddling

Don't ask. The patch is based on SiS's GPLed driver. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> diff -puN a/drivers/net/sis190.c~sis190-200 b/drivers/net/sis190.c --- a/drivers/net/sis190.c~sis190-200 2005-09-02 23:27:58.126761637 +0200 +++ b/drivers/net/sis190.c 2005-09-02

[patch 2.6.13-git3 3/5] sis190: make 10Mbps the default when handling the StationControl register

mon denominator when everything else failed. Btw it works better than the current code. :o) - remove some enums: they do not document anymore. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> diff -puN a/drivers/net/sis190.c~sis190-190 b/drivers/net/sis190.c --- a/drivers/net/sis190.c~sis190-190

sis190/sis191 driver

start at sis190-170.patch since anything else is already merged. The patches against 2.6.13-git3 (hello Jeff) will be posted in the upcoming messages in a few minutes. Single file patch (for plain 2.6.13): http://www.zoreil.com/~romieu/sis190/20050902-2.6.13-sis190-test.patch Patch-kit (sic): http

sis190/sis191 driver

start at sis190-170.patch since anything else is already merged. The patches against 2.6.13-git3 (hello Jeff) will be posted in the upcoming messages in a few minutes. Single file patch (for plain 2.6.13): http://www.zoreil.com/~romieu/sis190/20050902-2.6.13-sis190-test.patch Patch-kit (sic): http

[patch 2.6.13-git3 4/5] sis190: RGMII Tx internal delay fiddling

Don't ask. The patch is based on SiS's GPLed driver. Signed-off-by: Francois Romieu [EMAIL PROTECTED] diff -puN a/drivers/net/sis190.c~sis190-200 b/drivers/net/sis190.c --- a/drivers/net/sis190.c~sis190-200 2005-09-02 23:27:58.126761637 +0200 +++ b/drivers/net/sis190.c 2005-09-02 23:27

[patch 2.6.13-git3 3/5] sis190: make 10Mbps the default when handling the StationControl register

when everything else failed. Btw it works better than the current code. :o) - remove some enums: they do not document anymore. Signed-off-by: Francois Romieu [EMAIL PROTECTED] diff -puN a/drivers/net/sis190.c~sis190-190 b/drivers/net/sis190.c --- a/drivers/net/sis190.c~sis190-190 2005-09-02

[patch 2.6.13-git3 5/5] sis190: basic sis191 support

The sis191 is the gigabit brother of the sis190. SiS's driver suggests that the register set is backward compatible: this should hopefully give a basic driver. The device should allow the usual features from a modern ethernet adapter (802.1q, SG, Jumbo frames, TSO, checksum offload). So far

[patch 2.6.13-git3 2/5] sis190: recent chipsets from SiS include a RGMII

Extracted from SiS's GPLed driver. From the few pdf available at SiS's, it seems that the 965 and the 966 south bridge include this interface whereas the 965L (and anything below) does not. It is expected to be a sis191 related feature and should not hurt the existing sis190 driver. Signed-off

[patch 2.6.13-git3 1/5] sis190: unmask the link change events

link changes reporting does not work when the driver masks its irq event Signed-off-by: Arnaud Patard [EMAIL PROTECTED] Signed-off-by: Francois Romieu [EMAIL PROTECTED] diff -puN a/drivers/net/sis190.c~sis190-170 b/drivers/net/sis190.c --- a/drivers/net/sis190.c~sis190-170 2005-09-02 23:27

[-mm patch] SIS190 must select MII

On Tue, Aug 09, 2005 at 02:26:31AM +0200, Jiri Slaby wrote: > Hello, i find out this problem: > #make O=../bu allmodconfig > ... > #make O=../bu all > ... > LD .tmp_vmlinux1 > drivers/built-in.o(.text+0x63c87): In function `sis190_get_settings': > /l/latest/xxx/d

[-mm patch] SIS190 must select MII

On Tue, Aug 09, 2005 at 02:26:31AM +0200, Jiri Slaby wrote: Hello, i find out this problem: #make O=../bu allmodconfig ... #make O=../bu all ... LD .tmp_vmlinux1 drivers/built-in.o(.text+0x63c87): In function `sis190_get_settings': /l/latest/xxx/drivers/net/sis190.c:1656: undefined

Re: [patch 2.6.13-rc3] sis190 driver

Pascal CHAPPERON <[EMAIL PROTECTED]> : [...] > By the way, i still can not force speed/mode/autoneg (ethtool or mii-tool); > ethtool reports correctly the changes, but autoneg is not really disabled, > and the driver falls back to 100 Full... > > Had Lars better results with autoneg off? I

Re: [patch 2.6.13-rc3] sis190 driver

> Message du 30/07/05 12:13 > De : "Francois Romieu" <[EMAIL PROTECTED]> [...] > Lars noticed that the link status is not correctly reported and suggested > a few changes. Can you check if the version below works better ? > I was precisely modifying mii_chip_table[

Re: [patch 2.6.13-rc3] sis190 driver

Pascal CHAPPERON <[EMAIL PROTECTED]> : [...] > sis190-120 compiles, loads but does not work (sis190_init_phy() function). > > # service network start > Bringing up loopback interface:[ OK ] > Bringing up interface eth0: > Determining IP inform

Re: [patch 2.6.13-rc3] sis190 driver

> Message du 29/07/05 00:13 > De : "Francois Romieu" <[EMAIL PROTECTED]> [...] > Changes from previous version (20050722) [...] > o Minor round of mii/phy related changes. May crash. > > Testing reports/review/patches are always appreciated. > sis190-

Re: [patch 2.6.13-rc3] sis190 driver

Pascal CHAPPERON [EMAIL PROTECTED] : [...] sis190-120 compiles, loads but does not work (sis190_init_phy() function). # service network start Bringing up loopback interface:[ OK ] Bringing up interface eth0: Determining IP information for eth0... failed

Re: sis190 driver

Erior <[EMAIL PROTECTED]> : [...] > Is there any kind of test or information I can provid to help you fixing > this ? It could help to know if the device reports a link event interrupt or such. (ethtool allow to modify the log level of the driver if required). Don't hesitate to publish a complete

Re: sis190 driver

Erior <[EMAIL PROTECTED]> : [...] > Added PHY identifier for the Asus K8S-MX motherboard. - is it ok to add a Signed-off-by: Lars Vahlenberg <[EMAIL PROTECTED]> ? - how the whole driver work now ? -- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: sis190 driver

this ? /Lars On 7/29/05, Erior <[EMAIL PROTECTED]> wrote: > This will get the driver to aknowledge mii-tool reported mode, > without this the drivers always says "100BaseTx-FD" while my switch > shows 10BaseT-HD as the selected mode. > > /Lars > --- sis190.new 2

Re: sis190 driver

This will get the driver to aknowledge mii-tool reported mode, without this the drivers always says "100BaseTx-FD" while my switch shows 10BaseT-HD as the selected mode. /Lars --- sis190.new 2005-07-29 23:26:39.0 + +++ sis190.c2005-07-29 23:38:39.0 + @@ -95

Re: sis190 driver

Hi Added PHY identifier for the Asus K8S-MX motherboard. --- sis190.old 2005-07-29 23:16:07.0 + +++ sis190.c2005-07-29 23:15:37.0 + @@ -325,6 +325,7 @@ static struct mii_chip_info { { "Broadcom PHY BCM5461", { 0x0020, 0x60c0 }, LAN }, {

Re: sis190 driver

Hi Added PHY identifier for the Asus K8S-MX motherboard. --- sis190.old 2005-07-29 23:16:07.0 + +++ sis190.c2005-07-29 23:15:37.0 + @@ -325,6 +325,7 @@ static struct mii_chip_info { { Broadcom PHY BCM5461, { 0x0020, 0x60c0 }, LAN }, { Agere PHY

Re: sis190 driver

This will get the driver to aknowledge mii-tool reported mode, without this the drivers always says 100BaseTx-FD while my switch shows 10BaseT-HD as the selected mode. /Lars --- sis190.new 2005-07-29 23:26:39.0 + +++ sis190.c2005-07-29 23:38:39.0 + @@ -956,7 +956,8

Re: sis190 driver

this ? /Lars On 7/29/05, Erior [EMAIL PROTECTED] wrote: This will get the driver to aknowledge mii-tool reported mode, without this the drivers always says 100BaseTx-FD while my switch shows 10BaseT-HD as the selected mode. /Lars --- sis190.new 2005-07-29 23:26:39.0 +

Re: sis190 driver

Erior [EMAIL PROTECTED] : [...] Added PHY identifier for the Asus K8S-MX motherboard. - is it ok to add a Signed-off-by: Lars Vahlenberg [EMAIL PROTECTED] ? - how the whole driver work now ? -- Ueimor - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: sis190 driver

Erior [EMAIL PROTECTED] : [...] Is there any kind of test or information I can provid to help you fixing this ? It could help to know if the device reports a link event interrupt or such. (ethtool allow to modify the log level of the driver if required). Don't hesitate to publish a complete

[patch 2.6.13-rc3] sis190 driver

Single file patch: http://www.zoreil.com/~romieu/sis190/20050728-2.6.13-rc3-sis190-test.patch Patch-kit: http://www.zoreil.com/~romieu/sis190/20050728-2.6.13-rc3/patches Tarball: http://www.zoreil.com/~romieu/sis190/20050728-2.6.13-rc3.tar.bz2 Changes from previous version (20050722) o Add

[patch 2.6.13-rc3] sis190 driver

Single file patch: http://www.zoreil.com/~romieu/sis190/20050728-2.6.13-rc3-sis190-test.patch Patch-kit: http://www.zoreil.com/~romieu/sis190/20050728-2.6.13-rc3/patches Tarball: http://www.zoreil.com/~romieu/sis190/20050728-2.6.13-rc3.tar.bz2 Changes from previous version (20050722) o Add

Re: sis190 driver

[bouncing @sis.com address removed from the Cc:] Lars Vahlenberg <[EMAIL PROTECTED]> : [...] > I can get mii-tool to work with this patch, but if I have > a ping command running and changing to another speed I > stop receiving or get 1 - 3 sek pings. ei x000ms. The current SiS driver is way more

Re: sis190 driver

[bouncing @sis.com address removed from the Cc:] Lars Vahlenberg [EMAIL PROTECTED] : [...] I can get mii-tool to work with this patch, but if I have a ping command running and changing to another speed I stop receiving or get 1 - 3 sek pings. ei x000ms. The current SiS driver is way more

Re: sis190 driver

to regressions and/or netconsole testing. > > Single file patch: > http://www.zoreil.com/~romieu/sis190/20050722-2.6.13-rc2-sis190-test.patch MAINTAINERS chunk isn't -p1 applicable. ;-) sparse asks whether you have endianness bugs here: ---

sis190 driver

No major change from previous version. I'm quietly merging bits from the SiS driver that Lars kindly pointed out. The detection of the mac address is done differently. I'll welcome feedback related to regressions and/or netconsole testing. Single file patch: http://www.zoreil.com/~romieu/sis190

sis190 driver

No major change from previous version. I'm quietly merging bits from the SiS driver that Lars kindly pointed out. The detection of the mac address is done differently. I'll welcome feedback related to regressions and/or netconsole testing. Single file patch: http://www.zoreil.com/~romieu/sis190

Re: sis190 driver

and/or netconsole testing. Single file patch: http://www.zoreil.com/~romieu/sis190/20050722-2.6.13-rc2-sis190-test.patch MAINTAINERS chunk isn't -p1 applicable. ;-) sparse asks whether you have endianness bugs here: 450 static

Re: sis190

> Message du 09/07/05 23:02 > De : "Francois Romieu" <[EMAIL PROTECTED]> [...] > Can you do the same test but send the traffic from the host which > embeds the r8169 ? > > The sis190 should not be responsive during the flow. I expect that it > will

Re: sis190

Message du 09/07/05 23:02 De : Francois Romieu [EMAIL PROTECTED] [...] Can you do the same test but send the traffic from the host which embeds the r8169 ? The sis190 should not be responsive during the flow. I expect that it will happily return to a normal state once the traffic stops

Re: sis190

ast enough :o) Can you do the same test but send the traffic from the host which embeds the r8169 ? The sis190 should not be responsive during the flow. I expect that it will happily return to a normal state once the traffic stops. If it behaves correctly, I'll send a first version for inclu

Re: sis190

> Date: Wed, 6 Jul 2005 23:29:25 +0200 > From: Francois Romieu <[EMAIL PROTECTED]> [...] > The patchkit of the day should fix these issues: > http://www.zoreil.com/~romieu/sis190/20050706-2.6.13-rc1/patches [...] > I'd appreciate if you could check the allowed frame size rang

Re: sis190

Date: Wed, 6 Jul 2005 23:29:25 +0200 From: Francois Romieu [EMAIL PROTECTED] [...] The patchkit of the day should fix these issues: http://www.zoreil.com/~romieu/sis190/20050706-2.6.13-rc1/patches [...] I'd appreciate if you could check the allowed frame size range, say ping -s 1468 ... ping

Re: sis190

the r8169 ? The sis190 should not be responsive during the flow. I expect that it will happily return to a normal state once the traffic stops. If it behaves correctly, I'll send a first version for inclusion. ethtool -s eth0 ... does not freeze the station anymore, but autoneg off does not work

Re: sis190

> Message du 05/07/05 01:34 > De : "Francois Romieu" <[EMAIL PROTECTED]> [...] > Can you check if there is a regression in sis190-000.patch available at > http://www.zoreil.com/~romieu/sis190/20050704-2.6.13-rc1/patches ? > That one works perfectly; i

Re: sis190

Pascal CHAPPERON <[EMAIL PROTECTED]> : [...] > That one works perfectly; i tried it in the same conditions as > the previous patch, and i don't notice a regression. Nice. [...] > sis190-010.patch does not compile properly : Point taken. Thanks. [...] > But i get those trac

Re: sis190

Pascal CHAPPERON [EMAIL PROTECTED] : [...] That one works perfectly; i tried it in the same conditions as the previous patch, and i don't notice a regression. Nice. [...] sis190-010.patch does not compile properly : Point taken. Thanks. [...] But i get those traces in syslog, when

Re: sis190

Message du 05/07/05 01:34 De : Francois Romieu [EMAIL PROTECTED] [...] Can you check if there is a regression in sis190-000.patch available at http://www.zoreil.com/~romieu/sis190/20050704-2.6.13-rc1/patches ? That one works perfectly; i tried it in the same conditions as the previous patch

Re: sis190

ble, > and the stuff in sis190_get_drvinfo triggers a kernel oops > when the module is loaded (null pointer assignment). Done. Can you check if there is a regression in sis190-000.patch available at http://www.zoreil.com/~romieu/sis190/20050704-2.6.13-rc1/patches ? If it works and you want some entertai

Re: sis190

triggers a kernel oops when the module is loaded (null pointer assignment). Done. Can you check if there is a regression in sis190-000.patch available at http://www.zoreil.com/~romieu/sis190/20050704-2.6.13-rc1/patches ? If it works and you want some entertainment, you can apply sis190-010

  1   2   >