Re: threads-max observe limits

2019-09-24 Thread Michal Hocko
On Mon 23-09-19 16:23:40, Eric W. Biederman wrote: > > Michal, > > Thinking about this I have a hunch about what changed. I think at some > point we changed from 4k to 8k kernel stacks. So I suspect if your > client is seeing a lower threads-max it is because the size of the > kernel data

Re: threads-max observe limits

2019-09-23 Thread Eric W. Biederman
Michal, Thinking about this I have a hunch about what changed. I think at some point we changed from 4k to 8k kernel stacks. So I suspect if your client is seeing a lower threads-max it is because the size of the kernel data structures increased. Eric

Re: threads-max observe limits

2019-09-23 Thread Michal Hocko
Sep 2019 08:45:28 +0200 > > Subject: [PATCH] kernel/sysctl.c: do not override max_threads provided by > > userspace > > > > Partially revert 16db3d3f1170 ("kernel/sysctl.c: threads-max observe > > limits") > > because the patch is causing a regression to

Re: threads-max observe limits

2019-09-22 Thread Eric W. Biederman
170 ("kernel/sysctl.c: threads-max observe limits") > because the patch is causing a regression to any workload which needs to > override the auto-tuning of the limit provided by kernel. > > set_max_threads is implementing a boot time guesstimate to provide a > sensibl

Re: threads-max observe limits

2019-09-22 Thread Eric W. Biederman
Heinrich Schuchardt writes: > Did this patch when applied to the customer's kernel solve any problem? > > WebSphere MQ is a messaging application. If it hits the current limits > of threads-max, there is a bug in the software or in the way that it has > been set up at the customer. Instead of

Re: threads-max observe limits

2019-09-22 Thread Heinrich Schuchardt
its which he should adhere to. So expect a lot of systems to be downed this way. Best regards Heinrich > >>From 711000fdc243b6bc68a92f9ef0017ae495086d39 Mon Sep 17 00:00:00 2001 > From: Michal Hocko > Date: Sun, 22 Sep 2019 08:45:28 +0200 > Subject: [PATCH] kernel/sysctl.c: do not ov

Re: threads-max observe limits

2019-09-22 Thread Michal Hocko
bootable system. I do not think we should jump into the admin call on the lower bound. There might be a good reason to restrict the number of threads to 1. So here is what I would like to go with. >From 711000fdc243b6bc68a92f9ef0017ae495086d39 Mon Sep 17 00:00:00 2001 From: Michal Hocko Date:

Re: threads-max observe limits

2019-09-19 Thread Andrew Morton
trong reasoning about > the restricting user input then I will suggest reverting 16db3d3f1170 > ("kernel/sysctl.c: threads-max observe limits") I agree, based on what I'm seeing in this thread.

Re: threads-max observe limits

2019-09-19 Thread Eric W. Biederman
gt;> >> > I have just stumbled over 16db3d3f1170 ("kernel/sysctl.c: threads-max >> >> > observe limits") and I am really wondering what is the motivation behind >> >> > the patch. We've had a customer noticing the threads_max autoscaling >> >

Re: threads-max observe limits

2019-09-19 Thread Michal Hocko
pective patch doesn't > really exaplain why it is needed except of "it sounds like a good idea > to be consistent". Any take on this Heinrich? If there really is not strong reasoning about the restricting user input then I will suggest reverting 16db3d3f1170 ("kernel/sysctl.c: thre

Re: threads-max observe limits

2019-09-18 Thread Michal Hocko
On Tue 17-09-19 12:26:18, Eric W. Biederman wrote: > Michal Hocko writes: > > > On Tue 17-09-19 17:28:02, Heinrich Schuchardt wrote: > >> > >> On 9/17/19 12:03 PM, Michal Hocko wrote: > >> > Hi, > >> > I have just stumbled over 16db3d3f117

Re: threads-max observe limits

2019-09-17 Thread Eric W. Biederman
Michal Hocko writes: > On Tue 17-09-19 17:28:02, Heinrich Schuchardt wrote: >> >> On 9/17/19 12:03 PM, Michal Hocko wrote: >> > Hi, >> > I have just stumbled over 16db3d3f1170 ("kernel/sysctl.c: threads-max >> > observe limits") and

Re: threads-max observe limits

2019-09-17 Thread Michal Hocko
On Tue 17-09-19 17:28:02, Heinrich Schuchardt wrote: > > On 9/17/19 12:03 PM, Michal Hocko wrote: > > Hi, > > I have just stumbled over 16db3d3f1170 ("kernel/sysctl.c: threads-max > > observe limits") and I am really wondering what is the motivation behind &

Re: threads-max observe limits

2019-09-17 Thread Heinrich Schuchardt
On 9/17/19 12:03 PM, Michal Hocko wrote: > Hi, > I have just stumbled over 16db3d3f1170 ("kernel/sysctl.c: threads-max > observe limits") and I am really wondering what is the motivation behind > the patch. We've had a customer noticing the threads_max autoscaling >

threads-max observe limits

2019-09-17 Thread Michal Hocko
Hi, I have just stmbled over 16db3d3f1170 ("kernel/sysctl.c: threads-max observe limits") and I am really wondering what is the motivation behind the patch. We've had a customer noticing the threads_max autoscaling differences btween 3.12 and 4.4 kernels and wanted to override the auto t

[PATCH 3/4 v6] kernel/sysctl.c: threads-max observe limits

2015-03-15 Thread Heinrich Schuchardt
Users can change the maximum number of threads by writing to /proc/sys/kernel/threads-max. With the patch the value entered is checked against the same limits that apply when fork_init is called. Signed-off-by: Heinrich Schuchardt --- include/linux/sysctl.h | 3 +++ kernel/fork.c |

[PATCH 3/4 v6] kernel/sysctl.c: threads-max observe limits

2015-03-15 Thread Heinrich Schuchardt
Users can change the maximum number of threads by writing to /proc/sys/kernel/threads-max. With the patch the value entered is checked against the same limits that apply when fork_init is called. Signed-off-by: Heinrich Schuchardt xypron.g...@gmx.de --- include/linux/sysctl.h | 3 +++

Re: [PATCH 3/3] kernel/sysctl.c: threads-max observe limits

2015-02-25 Thread David Rientjes
On Wed, 25 Feb 2015, Heinrich Schuchardt wrote: > > I believe this information should be added to the documentation cited > > above which mentions threads-max since users will otherwise be unfamiliar > > with the limits imposed. > > Hello David, > > I guess the documentation fix should be put

Re: [PATCH 3/3] kernel/sysctl.c: threads-max observe limits

2015-02-25 Thread Heinrich Schuchardt
On 24.02.2015 23:20, David Rientjes wrote: > On Tue, 24 Feb 2015, Heinrich Schuchardt wrote: > Users can change the maximum number of threads by writing to /proc/sys/kernel/threads-max. With the patch the value entered is checked against the same limits that apply when

Re: [PATCH 3/3] kernel/sysctl.c: threads-max observe limits

2015-02-25 Thread Heinrich Schuchardt
On 24.02.2015 23:20, David Rientjes wrote: On Tue, 24 Feb 2015, Heinrich Schuchardt wrote: Users can change the maximum number of threads by writing to /proc/sys/kernel/threads-max. With the patch the value entered is checked against the same limits that apply when fork_init is called.

Re: [PATCH 3/3] kernel/sysctl.c: threads-max observe limits

2015-02-25 Thread David Rientjes
On Wed, 25 Feb 2015, Heinrich Schuchardt wrote: I believe this information should be added to the documentation cited above which mentions threads-max since users will otherwise be unfamiliar with the limits imposed. Hello David, I guess the documentation fix should be put into a

Re: [PATCH 3/3] kernel/sysctl.c: threads-max observe limits

2015-02-24 Thread David Rientjes
On Tue, 24 Feb 2015, Heinrich Schuchardt wrote: > >> Users can change the maximum number of threads by writing to > >> /proc/sys/kernel/threads-max. > >> > >> With the patch the value entered is checked against the same > >> limits that apply when fork_init is called. > >> > > > > Correct me if

Re: [PATCH 3/3] kernel/sysctl.c: threads-max observe limits

2015-02-24 Thread Heinrich Schuchardt
On 24.02.2015 22:17, David Rientjes wrote: > On Tue, 24 Feb 2015, Heinrich Schuchardt wrote: > >> Users can change the maximum number of threads by writing to >> /proc/sys/kernel/threads-max. >> >> With the patch the value entered is checked against the same >> limits that apply when fork_init is

Re: [PATCH 3/3] kernel/sysctl.c: threads-max observe limits

2015-02-24 Thread David Rientjes
On Tue, 24 Feb 2015, Heinrich Schuchardt wrote: > Users can change the maximum number of threads by writing to > /proc/sys/kernel/threads-max. > > With the patch the value entered is checked against the same > limits that apply when fork_init is called. > Correct me if I'm wrong, but this is a

[PATCH 3/3] kernel/sysctl.c: threads-max observe limits

2015-02-24 Thread Heinrich Schuchardt
Users can change the maximum number of threads by writing to /proc/sys/kernel/threads-max. With the patch the value entered is checked against the same limits that apply when fork_init is called. Signed-off-by: Heinrich Schuchardt --- include/linux/sysctl.h | 3 +++ kernel/fork.c |

[PATCH 3/3] kernel/sysctl.c: threads-max observe limits

2015-02-24 Thread Heinrich Schuchardt
Users can change the maximum number of threads by writing to /proc/sys/kernel/threads-max. With the patch the value entered is checked against the same limits that apply when fork_init is called. Signed-off-by: Heinrich Schuchardt xypron.g...@gmx.de --- include/linux/sysctl.h | 3 +++

Re: [PATCH 3/3] kernel/sysctl.c: threads-max observe limits

2015-02-24 Thread David Rientjes
On Tue, 24 Feb 2015, Heinrich Schuchardt wrote: Users can change the maximum number of threads by writing to /proc/sys/kernel/threads-max. With the patch the value entered is checked against the same limits that apply when fork_init is called. Correct me if I'm wrong, but this is a

Re: [PATCH 3/3] kernel/sysctl.c: threads-max observe limits

2015-02-24 Thread Heinrich Schuchardt
On 24.02.2015 22:17, David Rientjes wrote: On Tue, 24 Feb 2015, Heinrich Schuchardt wrote: Users can change the maximum number of threads by writing to /proc/sys/kernel/threads-max. With the patch the value entered is checked against the same limits that apply when fork_init is called.

Re: [PATCH 3/3] kernel/sysctl.c: threads-max observe limits

2015-02-24 Thread David Rientjes
On Tue, 24 Feb 2015, Heinrich Schuchardt wrote: Users can change the maximum number of threads by writing to /proc/sys/kernel/threads-max. With the patch the value entered is checked against the same limits that apply when fork_init is called. Correct me if I'm wrong, but this is

[PATCH 3/4 v4] kernel/sysctl.c: threads-max observe limits

2015-02-23 Thread Heinrich Schuchardt
Users can change the maximum number of threads by writing to /proc/sys/kernel/threads-max. With the patch the value entered is checked according to the same limits that apply when fork_init is called. Furthermore the limits of the init process are adjusted. This will not update limits of any

[PATCH 3/4 v4] kernel/sysctl.c: threads-max observe limits

2015-02-23 Thread Heinrich Schuchardt
Users can change the maximum number of threads by writing to /proc/sys/kernel/threads-max. With the patch the value entered is checked according to the same limits that apply when fork_init is called. Furthermore the limits of the init process are adjusted. This will not update limits of any

[PATCH 2/3 v3] kernel/sysctl.c: threads-max observe limits

2015-02-21 Thread Heinrich Schuchardt
Users can change the maximum number of threads by writing to /proc/sys/kernel/threads-max. With the patch the value entered is checked according to the same limits that apply when fork_init is called. Furthermore the limits of the init process are adjusted. This will not update limits of any

[PATCH 2/3 v3] kernel/sysctl.c: threads-max observe limits

2015-02-21 Thread Heinrich Schuchardt
Users can change the maximum number of threads by writing to /proc/sys/kernel/threads-max. With the patch the value entered is checked according to the same limits that apply when fork_init is called. Furthermore the limits of the init process are adjusted. This will not update limits of any