tracing: don't stuff stale pointers in filp->private_data

2013-09-25 Thread Dave Jones
Probably harmless, but still not a nice thing to do. Signed-off-by: Dave Jones diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 368a4d5..27aa16e 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -1124,10 +1124,10 @@ static int system_tr_ope

Re: tracing: don't stuff stale pointers in filp->private_data

2013-09-21 Thread Steven Rostedt
Or make the assignment in an else block. -- Steve Al Viro wrote: >On Fri, Sep 20, 2013 at 12:47:32PM -0400, Dave Jones wrote: >> Probably harmless, but still not a nice thing to do. >> >> Signed-off-by: Dave Jones >> >> diff --git a/kernel/trace/trace_events.c >b/kernel/trace/trace_events.c

Re: tracing: don't stuff stale pointers in filp->private_data

2013-09-21 Thread Al Viro
On Fri, Sep 20, 2013 at 12:47:32PM -0400, Dave Jones wrote: > Probably harmless, but still not a nice thing to do. > > Signed-off-by: Dave Jones > > diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c > index 368a4d5..75d3556 100644 > --- a/kernel/trace/trace_events.c > +++ b/

tracing: don't stuff stale pointers in filp->private_data

2013-09-20 Thread Dave Jones
Probably harmless, but still not a nice thing to do. Signed-off-by: Dave Jones diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 368a4d5..75d3556 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -1124,6 +1124,7 @@ static int system_tr_open(