Re: [PATCH] watchdog: add Nano 7240 driver

2007-10-07 Thread Andrey Panin
On 280, 10 07, 2007 at 01:39:28AM +1000, Gilles Gigan wrote: > from: Gilles Gigan <[EMAIL PROTECTED]> > > Adds watchdog driver for EPIC Nano 7240 boards from IEI > > Signed-off-by: Gilles Gigan <[EMAIL PROTECTED]> > --- > > diff -uprN -X linux-2.6.23-rc9/Documentation/dontdiff > linux-2.6.23-rc9/d

Re: Network slowdown due to CFS

2007-10-07 Thread Ingo Molnar
* Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > [...] The timeslices of tasks (i.e. the time they spend on a CPU > > without scheduling away) is _not_ maintained directly in CFS as a > > per-task variable that can be "cleared", it's not the metric that > > drives scheduling. Yes, of course CF

Re: OHCI root_port_reset() deadly loop...

2007-10-07 Thread David Brownell
> From [EMAIL PROTECTED] Sat Oct 6 23:56:49 2007 > > When root_port_reset() in ohci-hub.c polls for the end of the reset, > it puts no limit on the loop and will only exit the loop when either > the RH_PS_PRS bit clears or the register returns all 1's (the latter > condition is a recent addition)

Re: OHCI root_port_reset() deadly loop...

2007-10-07 Thread David Miller
From: David Brownell <[EMAIL PROTECTED]> Date: Sun, 07 Oct 2007 00:31:41 -0700 > Is this SPARC, or is ACPI potentially in play? PCI, or non-PCI? It's sparc64 on PCI. > Are the other ports still behaving? Is EHCI maybe trying to switch > ownership of that port? Is maybe the (newish) autosuspen

Re: lockdep: how to tell it multiple pte locks is OK?

2007-10-07 Thread Peter Zijlstra
On Sat, 2007-10-06 at 23:31 -0700, Jeremy Fitzhardinge wrote: > I'm writing some code which is doing some batch processing on pte pages, > and so wants to hold multiple pte locks at once. This seems OK, but > lockdep is giving me the warning: > > = > [

Re: [PATCH] Cute feature: colored printk output

2007-10-07 Thread Jan Engelhardt
On Oct 6 2007 20:50, Bill Davidsen wrote: >> >>> I start my root xterm in white on blue for identification, so color coding >>> sounds like a great idea to me. >> >> This has nothing to do with xterms, this is "VGA color console" only. >> xterm config is in /usr/share/X11/app-defaults/XTerm-colo

Re: sata_sil24 broken since 2.6.23-rc4-mm1

2007-10-07 Thread Torsten Kaiser
On 10/5/07, Torsten Kaiser <[EMAIL PROTECTED]> wrote: > So I will use the weekend to see if I can find out who issues this > command and add more debug to that place... I added some DPRINTK to sil24_qc_issue and sil24_fill_sg, but I only found one suspicious thing. My sil24_fill_sg now looks like

Re: [PATCH 2/5] forcedeth: interrupt handling cleanup

2007-10-07 Thread Ingo Molnar
* Jeff Garzik <[EMAIL PROTECTED]> wrote: > - spin_unlock(&np->lock); > - printk(KERN_DEBUG "%s: too many iterations (%d) in > nv_nic_irq.\n", dev->name, i); > - break; i like that! One forcedeth annoyance that triggers frequently on on

Re: [PATCH 0/5] forcedeth: several proposed updates for testing

2007-10-07 Thread Ingo Molnar
* Jeff Garzik <[EMAIL PROTECTED]> wrote: > * I feel TX NAPI is a useful tool, because it provides an independent TX > process control point and system load feedback point. > Thus I felt this was slightly superior to tasklets. /me agrees violently btw., when i played with this tunable under

Re: A bit of kconfig rewrite (Re: [PATCH] 9p: fix compile error if !CONFIG_SYSCTL)

2007-10-07 Thread Geert Uytterhoeven
On Sun, 7 Oct 2007, Oleg Verych wrote: > On Sat, Oct 06, 2007 at 11:10:48PM +0200, Sam Ravnborg wrote: > > On Sat, Oct 06, 2007 at 10:47:21PM +0200, Oleg Verych wrote: > > > On Sat, Oct 06, 2007 at 08:59:20PM +0200, Sam Ravnborg wrote: > > > > > Maintenance and acceptance of the m4/make/perl/C/ncur

Re: [patch 8/9] compat_ioctl: call disk->fops->compat_ioctl without BKL

2007-10-07 Thread Al Viro
On Sat, Oct 06, 2007 at 08:19:10PM +0200, Arnd Bergmann wrote: > Normally, all compat_ioctl operations are called without the BKL, the > block device operations are an exception to this rule. > > Make this work the same as the other handlers. > > Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]> >

Re: [patch 9/9] compat_ioctl: fix compat_fd_ioctl pointer access

2007-10-07 Thread Al Viro
On Sat, Oct 06, 2007 at 08:19:11PM +0200, Arnd Bergmann wrote: > As found by sparse, a user space pointer is assigned to a kernel > data structure while calling other code with set_fs(KERNEL_DS), > which could lead to leaking kernel data if that pointer is > ever accessed. > > I could not find any

Re: Revert "intel_agp: fix stolen mem range on G33"

2007-10-07 Thread Jiri Slaby
On 10/06/2007 09:29 PM, Keith Packard wrote: > On Sat, 2007-10-06 at 08:59 -0700, Linus Torvalds wrote: > >> We do have a rule about "no regressions", so I think we'll have to do the >> revert, but it would be nice to hear what the consequences for the revert >> is for the affected hardware and

Re: [PATCH] [RFC] Time-based RFC 4122 UUID generator

2007-10-07 Thread Helge Deller
Hello Valdis, On Sunday 07 October 2007, [EMAIL PROTECTED] wrote: > On Sat, 06 Oct 2007 15:53:37 +0200, Helge Deller said: > > --- a/drivers/char/random.c > > +++ b/drivers/char/random.c > > @@ -1157,6 +1158,8 @@ void generate_random_uuid(unsigned char uuid_out[16]) > > uuid_out[6] = (uuid_out

libertas and endianness

2007-10-07 Thread Geert Uytterhoeven
Somehow (haven't found out why it suddenly got compiled, no .config changes) this showed up in the list of warnings in 2.6.23-rc9 compared to -rc8 on one of my m68k builds: | drivers/net/wireless/libertas/cmd.c:189: warning: large integer implicitly truncated to unsigned type | drivers/net/wirele

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-07 Thread Miguel Ojeda
On 10/6/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > On Sat, 6 Oct 2007 01:01:10 +0200 > "Miguel Ojeda" <[EMAIL PROTECTED]> wrote: > > > On 10/5/07, Rob Landley <[EMAIL PROTECTED]> wrote: > > > On Friday 05 October 2007 2:01:08 am Miguel Ojeda wrote: > > > > > > > > I think we all are trying

[PATCH] firewire: point to migration document

2007-10-07 Thread Stefan Richter
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/firewire/Kconfig |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: linux/drivers/firewire/Kconfig === --- linux.orig/drivers/firewire/Kconfig +++ linux/dri

Sleeping in RCU list traversal

2007-10-07 Thread Tetsuo Handa
Hello. Peter Zijlstra wrote: > > Can I sleep between rcu_read_lock() and rcu_read_unlock() ? > > As far as I saw, rcu_read_lock() makes in_atomic() true, so I think I can't > > sleep. > You can indeed not sleep in an rcu_read_lock() section. However, you > could grab a reference on an item, stop

Re: [patch 8/9] compat_ioctl: call disk->fops->compat_ioctl without BKL

2007-10-07 Thread Arnd Bergmann
On Sunday 07 October 2007, Al Viro wrote: > On Sat, Oct 06, 2007 at 08:19:10PM +0200, Arnd Bergmann wrote: > > It would be good to find out whether it has been using the BKL > > on purpose or by accident, before this patch gets applied. > > Leave it alone, for now - I'm rebasing my series on top

Re:Sleeping in RCU list traversal

2007-10-07 Thread Jun WANG
Hi >Something like this? > >rcu_read_lock(); >list_for_each_rcu(p, ...) { > ptr = list_entry(p, struct ..., list); > /* Grab a reference to "ptr". */ > rcu_read_unlock(); > my_task_that_may_sleep(ptr); > rcu_read_lock(); > /* Drop a reference to "ptr". */ >} >rcu_read_unlock(); >Rega

[PATCH 6/n] forcedeth: protect slow path with mutex

2007-10-07 Thread Jeff Garzik
commit abca163a14b28c234df9bf38034bc967ff81c3aa Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Sun Oct 7 07:22:14 2007 -0400 [netdrvr] forcedeth: wrap slow path hw manipulation inside hw_mutex * This makes sure everybody who wants to start/stop the RX and TX engines first acqu

"Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Oleg Verych
Hallo, Ingo. On Sun, Oct 07, 2007 at 08:07:07AM +0200, Ingo Molnar wrote: > > * Oleg Verych <[EMAIL PROTECTED]> wrote: > > > > > * completely useless, if properly implemented in userspace (with > > > > much reacher functionality). > > > > > > that's hogwash. No user-space runs during early b

Re: [PATCH 0/5] forcedeth: several proposed updates for testing

2007-10-07 Thread Jeff Garzik
Ingo Molnar wrote: * Jeff Garzik <[EMAIL PROTECTED]> wrote: * I feel TX NAPI is a useful tool, because it provides an independent TX process control point and system load feedback point. Thus I felt this was slightly superior to tasklets. /me agrees violently btw., when i played with thi

Re: [PATCH 2/5] forcedeth: interrupt handling cleanup

2007-10-07 Thread Jeff Garzik
Yinghai Lu wrote: On 10/6/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: commit a606d2a111cdf948da5d69eb1de5526c5c2dafef Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri Oct 5 22:56:05 2007 -0400 [netdrvr] forcedeth: interrupt handling cleanup * nv_nic_irq_optimized() and nv_nic_irq_oth

[GIT PULL] last minute FireWire update

2007-10-07 Thread Stefan Richter
Linus, please pull from the for-linus branch at git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6.git for-linus to receive the following simple but hopefully effective update. drivers/firewire/Kconfig |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) commit a

Re: Revert "intel_agp: fix stolen mem range on G33"

2007-10-07 Thread Daniel Stone
On Sat, Oct 06, 2007 at 12:41:21PM +0200, Jiri Slaby wrote: > On 10/06/2007 07:42 AM, Kyle McMartin wrote: > > This reverts commit f443675affe3f16dd428e46f0f7fd3f4d703eeab, which > > breaks horribly if you aren't running an unreleased xf86-video-intel > > driver out of git. > > I guess, this will

Re: [PATCH] watchdog: add Nano 7240 driver

2007-10-07 Thread Gilles Gigan
Andrey Panin wrote: +#ifdef CONFIG_WATCHDOG_NOWAYOUT +#define NOWAYOUT 1 +#else +#define NOWAYOUT 0 +#endif +static int nowayout = NOWAYOUT; You don't need this #ifdef crap. Just use WATCHDOG_NOWAYOUT instead. done + if ((_IOC_DIR(cmd) & _I

[NET] IPv6 oops bisected

2007-10-07 Thread Jeff Garzik
The commit commit 5f5dace1ce001b24fb8286e09ffd3c4d2b547e09 Author: Denis V. Lunev <[EMAIL PROTECTED]> Date: Thu Sep 27 12:41:26 2007 -0700 [NET]: Various dst_ifdown routines to catch refcounting bugs causes a 100% reproducible oops in net-2.6.24.git, in ip6_route_add(). Platform: x86-64

Re: Sleeping in RCU list traversal

2007-10-07 Thread Tetsuo Handa
Hello. Thank you for pointing out. Jun WANG wrote: > >rcu_read_lock(); > >list_for_each_rcu(p, ...) { > > ptr = list_entry(p, struct ..., list); > > /* Grab a reference to "ptr". */ > > rcu_read_unlock(); > > my_task_that_may_sleep(ptr); > > rcu_read_lock(); > > /* Drop a reference to

Re: [NET] IPv6 oops bisected

2007-10-07 Thread Jeff Garzik
Jeff Garzik wrote: The commit commit 5f5dace1ce001b24fb8286e09ffd3c4d2b547e09 Author: Denis V. Lunev <[EMAIL PROTECTED]> Date: Thu Sep 27 12:41:26 2007 -0700 [NET]: Various dst_ifdown routines to catch refcounting bugs causes a 100% reproducible oops in net-2.6.24.git, in ip6_route_add()

Re: 2.6.23-rc9-rt2

2007-10-07 Thread Jaswinder Singh
Hello Steve, Do you have any plans to support nested or reentrant Interrupt Handling schemes. Thank you, Jaswinder SIngh. On 10/5/07, Steven Rostedt <[EMAIL PROTECTED]> wrote: > We are pleased to announce the 2.6.23-rc9-rt2 tree, which can be > downloaded from the new location: > > http://www.

Re: [NET] IPv6 oops bisected

2007-10-07 Thread Denis V. Lunev
Jeff Garzik wrote: > Jeff Garzik wrote: >> The commit >> >> commit 5f5dace1ce001b24fb8286e09ffd3c4d2b547e09 >> Author: Denis V. Lunev <[EMAIL PROTECTED]> >> Date: Thu Sep 27 12:41:26 2007 -0700 >> >> [NET]: Various dst_ifdown routines to catch refcounting bugs >> >> causes a 100% reproducible

Re: [PATCH] [RFC] Time-based RFC 4122 UUID generator

2007-10-07 Thread Valdis . Kletnieks
On Sun, 07 Oct 2007 12:08:10 +0200, you said: > Thanks that you ask! > I really should have mentioned it in my initial posting. > > Yes, this change was intentional, as it in fact fixes a possible bug in the > original code. > Section 4.1.6 in RFC 4122 states regarding the "NodeID": > : For sy

NAK nettiquete (was Re: "Re: [PATCH 0/2] Colored kernel output (run2)"

2007-10-07 Thread Valdis . Kletnieks
On Sun, 07 Oct 2007 13:10:35 +0200, Oleg Verych said: > > > I added comment (like this), so anyone can skip reading body, if > > > headers are "Oleg Verych && NAK". In case if `NAK' have a magic > > > meaning in the LKML, like control characters in the tty, i'm sorry. > > > > yes, a 'NAK' has a

Re: Sleeping in RCU list traversal

2007-10-07 Thread Jun WANG
> Hello. > > Thank you for pointing out. > > Jun WANG wrote: > > >rcu_read_lock(); > > >list_for_each_rcu(p, ...) { > > > ptr = list_entry(p, struct ..., list); > > > /* Grab a reference to "ptr". */ > > > rcu_read_unlock(); > > > my_task_that_may_sleep(ptr); > > > rcu_read_lock(); > >

Re: sata_sil24 broken since 2.6.23-rc4-mm1

2007-10-07 Thread Torsten Kaiser
[Adding Jens Axboe, the author of what looks like the probable cause] On 10/7/07, Torsten Kaiser <[EMAIL PROTECTED]> wrote: > My sil24_fill_sg now looks like this: > static inline void sil24_fill_sg(struct ata_queued_cmd *qc, > struct sil24_sge *sge) > { > s

Re: [PATCH 3/5] forcedeth: process TX completions using NAPI

2007-10-07 Thread Jeff Garzik
Jeff Garzik wrote: commit 57cbfacc00d69be2ba02b65d1021442273b76263 Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri Oct 5 23:25:56 2007 -0400 [netdrvr] forcedeth: process TX completions using NAPI Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> drivers/net/forcedeth.c | 143 ++

Re: [PATCH 6/n] forcedeth: protect slow path with mutex

2007-10-07 Thread Jeff Garzik
Jeff Garzik wrote: commit abca163a14b28c234df9bf38034bc967ff81c3aa Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Sun Oct 7 07:22:14 2007 -0400 [netdrvr] forcedeth: wrap slow path hw manipulation inside hw_mutex * This makes sure everybody who wants to start/stop the RX and TX engi

Re: [PATCH 0/5] forcedeth: several proposed updates for testing

2007-10-07 Thread Jeff Garzik
Jeff Garzik wrote: The 'fe-lock' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git fe-lock contains the following changes that I would like to get tested: [netdrvr] forcedeth: make NAPI unconditional [netdrvr] forcedeth: interrupt handling cleanup

Re: [NET] IPv6 oops bisected

2007-10-07 Thread Jeff Garzik
Denis V. Lunev wrote: Jeff Garzik wrote: Jeff Garzik wrote: The commit commit 5f5dace1ce001b24fb8286e09ffd3c4d2b547e09 Author: Denis V. Lunev <[EMAIL PROTECTED]> Date: Thu Sep 27 12:41:26 2007 -0700 [NET]: Various dst_ifdown routines to catch refcounting bugs causes a 100% reproducible

Re: NAK nettiquete (was Re: "Re: [PATCH 0/2] Colored kernel output (run2)"

2007-10-07 Thread Alan Cox
> The few times I've tried to NAK something outright, I've always tried to > attach > plenty of technical explanation Fair comment to my "silly" response The problems I see are - We run on a lot more than VGA PC consoles - We have serial consoles (which may or may not be VT132/ANSI compliant)

Re: NAK nettiquete (was Re: "Re: [PATCH 0/2] Colored kernel output (run2)"

2007-10-07 Thread Jan Engelhardt
On Oct 7 2007 16:12, Alan Cox wrote: > >- We run on a lot more than VGA PC consoles >- We have serial consoles (which may or may not be VT132/ANSI compliant) Yes, and the serial driver does not usually pass on vc->vc_color to the real hardware. If it did, it would have to transform it back into a

Re: lockdep: how to tell it multiple pte locks is OK?

2007-10-07 Thread Jeremy Fitzhardinge
Peter Zijlstra wrote: >> >> I presume this is because I'm holding multiple pte locks (class >> "__pte_lockptr(new)"). Is there some way I can tell lockdep this is OK? >> > > Yeah, the typical way is to use spin_lock_nested(lock, nesting_level), > this allows one to annotate these nestings. Ho

Re: "Re: [PATCH 0/2] Colored kernel output (run2)"

2007-10-07 Thread Valdis . Kletnieks
(changing Subject: back again, since Alan's returning to that topic...) On Sun, 07 Oct 2007 16:12:22 BST, Alan Cox said: > What I would much rather people thought about was > > - Marker modes for translation (so you know which bits of a message are > formatted up) > - More consistency on the use

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Ingo Molnar
* Oleg Verych <[EMAIL PROTECTED]> wrote: > > even if it were true (which it isnt), that is not an argument > > against including a useful change that exists now and that people > > are interested in. > > Coloring isn't useful. If it was, it would be implemented ~16 years > ago. Congratulation

Re: [ofa-general] Updated InfiniBand/RDMA merge plans for 2.6.24

2007-10-07 Thread Steve Wise
No mention about the iwarp port space issue? Here is the status of the current proposed patch: - needs another round of changes based on Sean's feedback - Arkady raised issues about the pain this puts on admins - it forces services like nfs-rdma, which already separates the nfs-rdma server by

Re: NAK nettiquete (was Re: "Re: [PATCH 0/2] Colored kernel output (run2)"

2007-10-07 Thread Alan Cox
> >- If you want to do "pretty" boot up you do it in X or frame buffer > >(which is going to get easier and easier with the X shift to kernel side > >video support) > > fb is slow. Feels like a 9600bps serial line. So fix your fb. There is enough information to cover 2D scrolling for most modern

[PATCH for 2.6.23] Driver core: fix regression with SYSFS_DEPRECTATED

2007-10-07 Thread Dmitry Torokhov
Subject: Driver core: fix SYSF_DEPRECATED breakage for nested classdevs From: Dmitry Torokhov <[EMAIL PROTECTED]> We should only reparent to a class former class devices that form the base of class hierarchy. Nested devices should still grow from their real parents. Signed-off-by: Dmitry Torokhov

Linux 2.6.16.54

2007-10-07 Thread Adrian Bunk
Location: ftp://ftp.kernel.org/pub/linux/kernel/v2.6/ git tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.16.y.git RSS feed of the git tree: http://www.kernel.org/git/?p=linux/kernel/git/stable/linux-2.6.16.y.git;a=rss Changes since 2.6.16.53: Adrian Bunk (2): Linux

Re: [PATCH] sysfs: backport of sysfs_readdir fix from 2.6.22.y to 2.6.16.y (CVE-2007-3104)

2007-10-07 Thread Adrian Bunk
> This patch solves CVE-2007-3104 - sysfs_readdir oops. >... Thanks, I've applied a similar but slightly different fix in 2.6.16.55-rc1. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days.

Linux 2.6.16.55-rc1

2007-10-07 Thread Adrian Bunk
Security fixes since 2.6.16.54: - CVE-2005-0504: fix buffer overflow in the moxa driver - CVE-2007-2453: random fixes - CVE-2007-3104: store sysfs inode nrs in s_ino to avoid readdir oopses - CVE-2007-3105: random: fix bound check ordering - CVE-2007-3848: Reset current->pdeath_signal on SUID binar

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Jan Engelhardt
On Oct 7 2007 13:10, Oleg Verych wrote: >This `scrollback' is usual late boot / console one. If fact useful, >until first tty switch or if `screen` cannot be used. But for some >reason if scrolling region (DECSTBM) is less than whole screen, nothing >works. Actually, scrolling begins to work onc

Re: [PATCH 1/2] Colored kernel output (run3)

2007-10-07 Thread Ingo Molnar
* Jan Engelhardt <[EMAIL PROTECTED]> wrote: > Colored kernel message output (1/2) > > This patch makes it possible to give kernel messages a selectable > color. It can be chosen at compile time, overridden at boot time, and > changed at run time. minor fix: i had to use the slightly modified

Re: [PATCH 1/2] Colored kernel output (run3)

2007-10-07 Thread Jan Engelhardt
On Oct 7 2007 18:38, Ingo Molnar wrote: > >minor fix: i had to use the slightly modified patch below instead of the >one you posted, so that the second patch applies fine. What is it that you changed? The printk patches are right at the front, so there should not be any fuzz or offsets (might va

Re: [PATCH 1/2] Colored kernel output (run3)

2007-10-07 Thread Ingo Molnar
Jan, > This patch makes it possible to give kernel messages a selectable > color. It can be chosen at compile time, overridden at boot time, and > changed at run time. here's some (good) text footprint data: with the feature disabled (which is the default), the text size difference with patc

Strange network related data corruption

2007-10-07 Thread Malte Schröder
Hello, I am encountering some strange data corruption when transferring data from one of my PCs that I use as a file-server. on the server: FILE=; | cut -d" " -f1 | nc -lp5000 -q0; while nc -lp5000 -q0 < $FILE; do : ; done on the client: H=; SUM=$(nc -q0 $H 5000);sleep 1s; while nc -q0 $H 5000 |

Re: can't change euid 0 to uid != running user

2007-10-07 Thread Luciano Rocha
On Fri, Oct 05, 2007 at 08:28:50AM -0700, Ray Lee wrote: > On 10/5/07, Luciano Rocha <[EMAIL PROTECTED]> wrote: > > I have the following problem: > > $ sudo -u ie -s # or sudo su ie > > unable to change to runas uid: Resource temporarily unavailable > > > > Works: > > $ sudo su, followed by su ie >

[PATCH] Fix Oops in toshiba_acpi error return path

2007-10-07 Thread Andrey Borzenkov
This fixes oops when registering backlight device fails. Attached as I still cannot convince kmail to not mangle long lines ... -andrey Subject: [PATCH] Fix Oops in toshiba_acpi error return path From: Andrey Borzenkov <[EMAIL PROTECTED]> When backlight_device_register() fails, return after undo

Re: [PATCH 1/2] Colored kernel output (run3)

2007-10-07 Thread Jan Engelhardt
On Oct 7 2007 18:44, Ingo Molnar wrote: >> This patch makes it possible to give kernel messages a selectable >> color. It can be chosen at compile time, overridden at boot time, and >> changed at run time. > >here's some (good) text footprint data: > >with the feature disabled (which is the defa

Re: MSI interrupts and disable_irq

2007-10-07 Thread Manfred Spraul
Jeff Garzik wrote: Interested parties should try the forcedeth patches I just posted :) The patches look good, but I would still prefer to understand why the current implementation causes crashes before rewriting everything. I've just noticed that netpoll_send_skb() calls ->hard_start_xmit()

Re: Sleeping in RCU list traversal

2007-10-07 Thread Tetsuo Handa
Hello. Jun WANG wrote: > I'm sorry,I think I got your idea, if you do not need ptr in > my_task_that_may_sleep(), why you need to grab a reference to "ptr". If > your my_task_that_may_sleep() needs ptr, and according to the > "memory region pointed by "ptr" never be removed." you say, > it is ok

Re: lockdep: how to tell it multiple pte locks is OK?

2007-10-07 Thread Arjan van de Ven
On Sat, 06 Oct 2007 23:31:33 -0700 > I'm presume I'm the first person to try holding multiple pte locks at > once, so there's no existing locking order for these locks. I'm > always traversing and locking the pagetable in virtual address order > (and this seems like a sane-enough rule for anyone

Re: [PATCH 1/2] Colored kernel output (run3)

2007-10-07 Thread Ingo Molnar
* Jan Engelhardt <[EMAIL PROTECTED]> wrote: > > vmlinux: > > textdata bss dec hex filename > > 7732358 1157269 401408 9291035 8dc51b vmlinux.before > > 7732374 1157269 401408 9291051 8dc52b vmlinux.after > > > >16 bytes, or 0.0002% of the total text size. So there's in

Re: [PATCH 1/2] Colored kernel output (run3)

2007-10-07 Thread Jan Engelhardt
On Oct 7 2007 18:59, Ingo Molnar wrote: >> > vmlinux: >> > textdata bss dec hex filename >> > 7732358 1157269 401408 9291035 8dc51b vmlinux.before >> > 7732374 1157269 401408 9291051 8dc52b vmlinux.after >> > >> >16 bytes, or 0.0002% of the total text size. So there's in

Re: [PATCH 1/2] Colored kernel output (run3)

2007-10-07 Thread Ingo Molnar
* Jan Engelhardt <[EMAIL PROTECTED]> wrote: > > On Oct 7 2007 18:59, Ingo Molnar wrote: > >> > vmlinux: > >> > textdata bss dec hex filename > >> > 7732358 1157269 401408 9291035 8dc51b vmlinux.before > >> > 7732374 1157269 401408 9291051 8dc52b vmlinux.after > >> > >

Re: lockdep: how to tell it multiple pte locks is OK?

2007-10-07 Thread Jeremy Fitzhardinge
On Oct 7, 2007, at 9:58 AM, Arjan van de Ven wrote: On Sat, 06 Oct 2007 23:31:33 -0700 I'm presume I'm the first person to try holding multiple pte locks at once, so there's no existing locking order for these locks. I'm always traversing and locking the pagetable in virtual address order (a

Re: Memory controller merge (was Re: -mm merge plans for 2.6.24)

2007-10-07 Thread Hugh Dickins
On Fri, 5 Oct 2007, Balbir Singh wrote: > Hugh Dickins wrote: > > > > That's where it should happen, yes; but my point is that it very > > often does not. Because the swap cache page (read in as part of > > the readaround cluster of some other cgroup, or in swapoff by some > > other cgroup) is al

Re: lockdep: how to tell it multiple pte locks is OK?

2007-10-07 Thread Arjan van de Ven
On Sun, 7 Oct 2007 10:17:47 -0700 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > On Oct 7, 2007, at 9:58 AM, Arjan van de Ven wrote: > > > On Sat, 06 Oct 2007 23:31:33 -0700 > > > >> I'm presume I'm the first person to try holding multiple pte locks > >> at once, so there's no existing locki

Re: NAK nettiquete (was Re: "Re: [PATCH 0/2] Colored kernel output (run2)"

2007-10-07 Thread Arnaldo Carvalho de Melo
Em Sun, Oct 07, 2007 at 04:12:22PM +0100, Alan Cox escreveu: > > The few times I've tried to NAK something outright, I've always tried to > > attach > > plenty of technical explanation > > Fair comment to my "silly" response > > The problems I see are > > - We run on a lot more than VGA PC con

Re: Sleeping in RCU list traversal

2007-10-07 Thread Peter Zijlstra
On Mon, 2007-10-08 at 01:56 +0900, Tetsuo Handa wrote: > So, I don't need to grab a reference to "ptr" > because memory region pointed by "ptr" will never be kfree()ed. > And it is legal to use "ptr" after rcu_read_unlock() > because memory region pointed by "ptr" will never be kfree()ed. Still

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Rene Herman
On 10/07/2007 06:12 PM, Ingo Molnar wrote: * Oleg Verych <[EMAIL PROTECTED]> wrote: Coloring isn't useful. If it was, it would be implemented ~16 years ago. Congratulations, this is the most stupid argument i've ever read on lkml. "Ay. World is finished. Everyone can go home and watch Fr

Re: [PATCH] Fix Oops in toshiba_acpi error return path

2007-10-07 Thread Dmitry Torokhov
On Sunday 07 October 2007, Andrey Borzenkov wrote: > This fixes oops when registering backlight device fails. Attached as I still > cannot convince kmail to not mangle long lines ... > > -andrey > Re: kmail - it usually behaves well with the patches as long as you turn off word wrapping and use

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Jan Engelhardt
On Oct 7 2007 20:47, Rene Herman wrote: > >> > Coloring isn't useful. If it was, it would be implemented ~16 years >> > ago. >> >> Congratulations, this is the most stupid argument i've ever read on lkml. > > "Ay. World is finished. Everyone can go home and watch Friends reruns now." > > But well

Re: [PATCH] 0/3 checkpatch updates, new checkfiles script

2007-10-07 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Ingo Molnar writes: > > * Erez Zadok <[EMAIL PROTECTED]> wrote: > > > So, I ran the above script and it found nearly 1.5 million reported > > warnings/errors, with drivers being the largest abuser, not > > surprisingly. [...] > > have you tried that with the lat

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Willy Tarreau
On Sun, Oct 07, 2007 at 08:47:52PM +0200, Rene Herman wrote: > On 10/07/2007 06:12 PM, Ingo Molnar wrote: > > >* Oleg Verych <[EMAIL PROTECTED]> wrote: > > >>Coloring isn't useful. If it was, it would be implemented ~16 years > >>ago. > > > >Congratulations, this is the most stupid argument i've

msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

2007-10-07 Thread Erez Zadok
According to vfs.txt, ->writepage() may return AOP_WRITEPAGE_ACTIVATE back to the VFS/VM. Indeed some filesystems such as tmpfs can return AOP_WRITEPAGE_ACTIVATE; and stackable file systems (e.g., Unionfs) also return AOP_WRITEPAGE_ACTIVATE if the lower f/s returned it. Anyway, some Ubuntu users

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Rene Herman
On 10/07/2007 08:58 PM, Jan Engelhardt wrote: On Oct 7 2007 20:47, Rene Herman wrote: Coloring isn't useful. If it was, it would be implemented ~16 years ago. Congratulations, this is the most stupid argument i've ever read on lkml. "Ay. World is finished. Everyone can go home and watch Fri

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Oleg Verych
On Sun, Oct 07, 2007 at 09:13:09PM +0200, Willy Tarreau wrote: > On Sun, Oct 07, 2007 at 08:47:52PM +0200, Rene Herman wrote: > > On 10/07/2007 06:12 PM, Ingo Molnar wrote: > > > > >* Oleg Verych <[EMAIL PROTECTED]> wrote: > > > > >>Coloring isn't useful. If it was, it would be implemented ~16 ye

Re: Linux Kernel Markers - performance characterization with large IO load on large-ish system

2007-10-07 Thread Ingo Molnar
* Alan D. Brunelle <[EMAIL PROTECTED]> wrote: > o All kernels start off with Linux 2.6.23-rc6 + 2.6.23-rc6-mm1 > > o '- bt cfg' or '+ bt cfg' means a kernel without or with blktrace > configured respectively. > > o '- markers' or '+ markers' means a kernel without or with the > 11-patch

Re: [PATCH 2/5] forcedeth: interrupt handling cleanup

2007-10-07 Thread Yinghai Lu
On 10/7/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Yinghai Lu wrote: > > On 10/6/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > >> commit a606d2a111cdf948da5d69eb1de5526c5c2dafef > >> Author: Jeff Garzik <[EMAIL PROTECTED]> > >> Date: Fri Oct 5 22:56:05 2007 -0400 > >> > >> [netdrvr] forcedet

Re: [PATCH 0/5] forcedeth: several proposed updates for testing

2007-10-07 Thread Yinghai Lu
On 10/7/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Jeff Garzik wrote: > > The 'fe-lock' branch of > > git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git fe-lock > OK, I've successfully tested patches 1-5 on an AMD64 system with > > 00:0a.0 Bridge: nVidia Corporation CK804 Ethern

Re: [Oops] on 2.6.23-rc9 sysRq Show Tasks (t)

2007-10-07 Thread Ahmed S. Darwish
On Sun, Oct 07, 2007 at 01:12:38AM +0400, Alexey Dobriyan wrote: > On Sat, Oct 06, 2007 at 10:14:06PM +0200, Ahmed S. Darwish wrote: > > Pressing sysRq+T always produce an Oops for every running system task (94 > > Oopses, that's a record ;)). > > uh-oh. For every sleeping task, I think. > > > T

[TRIVIAL PATCH] Remove unused variable in drivers/dma/ioatdma.c

2007-10-07 Thread Johannes Weiner
Hi, I found this in an `allyesconfig' build: CC drivers/dma/ioatdma.o drivers/dma/ioatdma.c: In function #ioat_dma_free_chan_resources#: drivers/dma/ioatdma.c:247: warning: unused variable #chanctrl# Hannes Signed-off-by: Johannes Weiner <[EMAIL PROTECTED]> diff --git a/driv

2.6.23-rc9-git5: Known regressions from 2.6.22

2007-10-07 Thread Rafael J. Wysocki
This message contains a list of some known regressions from 2.6.22 for which there are no fixes in the mainline that I know of.  If any of them have been fixed already, please let me know. If you know of any other unresolved regressions from 2.6.22, please let me know either and I'll add them to

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Rene Herman
On 10/07/2007 09:13 PM, Willy Tarreau wrote: On Sun, Oct 07, 2007 at 08:47:52PM +0200, Rene Herman wrote: But well, there actually have been worse arguments given that VGA console is getting less and less important. I recently did a perusal of alternative distributions and didn't find a sing

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Jan Engelhardt
On Oct 7 2007 21:13, Willy Tarreau wrote: >There are two distinct populations : > - those [...] >who would never have imagined that pressing Escape >during the boot of windows 3.1/95 provided them with the full text >messages. This is news to me. DOS always showed messages, and under

Re: Sleeping in RCU list traversal

2007-10-07 Thread Tetsuo Handa
Hello. Peter Zijlstra wrote: > > So, I don't need to grab a reference to "ptr" > > because memory region pointed by "ptr" will never be kfree()ed. > > And it is legal to use "ptr" after rcu_read_unlock() > > because memory region pointed by "ptr" will never be kfree()ed. > > Still think that is a

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

2007-10-07 Thread Pekka J Enberg
Hi Erez, On 10/7/07, Erez Zadok <[EMAIL PROTECTED]> wrote: > Anyway, some Ubuntu users of Unionfs reported that msync(2) sometimes > returns AOP_WRITEPAGE_ACTIVATE (decimal 524288) back to userland. > Therefore, some user programs fail, esp. if they're written such as > this: [snip] On 10/7/07,

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Rene Herman
On 10/07/2007 09:56 PM, Jan Engelhardt wrote: Some is good, as long as it is not excessive. While I could imagine that Knoppix will abuse the feature and use vt.printk_color=9,9,9,9,11,10,12, this is not what serious people would do. [1] http://tinyurl.com/yr9zgq [2] http://tinyurl.com/234ba3

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Jan Engelhardt
On Oct 7 2007 21:27, Rene Herman wrote: > > I saw you remark on FB console in a reply to Alan just now and I > quite agree with you. The (current) FB console is slow and I'll add > "dumb" myself. When you have a 1280x1024 screen available, you get > to do cool things like put up nice little window

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Jan Engelhardt
On Oct 7 2007 22:00, Rene Herman wrote: > On 10/07/2007 09:56 PM, Jan Engelhardt wrote: > >> Some is good, as long as it is not excessive. While I could imagine that >> Knoppix will abuse the feature and use vt.printk_color=9,9,9,9,11,10,12, this >> is not what serious people would do. >> >> [1]

Re: [PATCH 0/5] forcedeth: several proposed updates for testing

2007-10-07 Thread Jeff Garzik
Yinghai Lu wrote: On 10/7/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: Jeff Garzik wrote: The 'fe-lock' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git fe-lock OK, I've successfully tested patches 1-5 on an AMD64 system with 00:0a.0 Bridge: nVidia Corporation CK80

Re: [PATCH 2/5] forcedeth: interrupt handling cleanup

2007-10-07 Thread Jeff Garzik
Yinghai Lu wrote: On 10/7/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: Yinghai Lu wrote: On 10/6/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: commit a606d2a111cdf948da5d69eb1de5526c5c2dafef Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri Oct 5 22:56:05 2007 -0400 [netdrvr] forcedeth: inte

Re: "Re: [PATCH 0/2] Colored kernel output (run2)" + "`Subject:' usage"

2007-10-07 Thread Rene Herman
On 10/07/2007 10:04 PM, Jan Engelhardt wrote: On Oct 7 2007 22:00, Rene Herman wrote: On 10/07/2007 09:56 PM, Jan Engelhardt wrote: Some is good, as long as it is not excessive. While I could imagine that Knoppix will abuse the feature and use vt.printk_color=9,9,9,9,11,10,12, this is not wha

Re: [PATCH] Fix SH4 DMAC API

2007-10-07 Thread Paul Mundt
On Sat, Oct 06, 2007 at 02:52:43PM +0100, Adrian McMenamin wrote: > This patch fixes the DMA cascade by masking the correct bits. > > Tested and working with Dreamcast PVR2 DMA. With this patch applied > the existing mainline code in arch/sh/drivers/dma/dma-sh.c works, > whereas before I was patch

tty UI (Re: [PATCH 0/2] Colored kernel output (run2))

2007-10-07 Thread Oleg Verych
On Sun, Oct 07, 2007 at 10:04:44PM +0200, Jan Engelhardt wrote: > > On Oct 7 2007 22:00, Rene Herman wrote: > > On 10/07/2007 09:56 PM, Jan Engelhardt wrote: > > > >> Some is good, as long as it is not excessive. While I could imagine that > >> Knoppix will abuse the feature and use vt.printk_colo

Re: tty UI (Re: [PATCH 0/2] Colored kernel output (run2))

2007-10-07 Thread Jan Engelhardt
On Oct 7 2007 22:50, Oleg Verych wrote: > >In fact mc config (ini) section is a better way. Yes, for the default colors. But /usr/share/mc/syntax/ specifies more of them. >I use default blue (which is very annoying) If blue were annoying, it would not be the default Windows background (since Wi

[PATCH] [0/6] Some scheduler changes for sched-devel

2007-10-07 Thread Andi Kleen
- Various source code cleanups (no functional changes) - Shrink binary size by refactoring some code - One K8 optimization that is unfortunately not measurable. But it sounded good in theory! @) (if you have a better scheduling latency benchmark than lmbench3 it would be cool to try) - One real

[PATCH] [1/6] scheduler: Remove some unnecessary gotos in sched.c

2007-10-07 Thread Andi Kleen
No need to be more spagetti than absolutely necessary. Replace loops implemented with gotos with real loops. Replace err = ...; goto x; x: return err; with return ...; No functional changes. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> Index: linux-2.6-sched-devel/kernel/sched.c

[PATCH] [2/6] scheduler: Refactor common code of sleep_on / wait_for_completion

2007-10-07 Thread Andi Kleen
These functions were largely cut'n'pasted. This moves the common code into single helpers instead. Advantage is about 1k less code on x86-64 and 91 lines of code removed. It adds one function call to the non timeout version of the functions; i don't expect this to be measurable. Signed-off-by: A

  1   2   >