[RFC] cpuset update_cgroup_cpus_allowed

2007-10-15 Thread Paul Jackson
Paul M, David R, others -- how does this look? From: Paul Jackson <[EMAIL PROTECTED]> Update the per-task cpus_allowed of each task in a cgroup whenever it has a cpuset whose 'cpus' mask changes. The change to basing cpusets on the cgroup (aka container) infrastructure broke an essential cpuset

Re: [lm-sensors] [ patch .24-rc0 0/5 ] SuperIO locks coordinator

2007-10-15 Thread Hans de Goede
Jim Cromie wrote: this patchset (on hwmon-git) re-introduces superio_locks module, previously RFC'd here, where I 'borrowed' another thread.. http://marc.info/?l=linux-kernel&m=115821759424601&w=2 The module shares out slots/shared-reservations containing a mutex, so that multiple modules can

[PATCH] zd1211rw, fix oops when ejecting install media

2007-10-15 Thread Marc Pignat
The disconnect function can dereference the net_device structure before it is allocated. This is the case when ejecting the device installer. Signed-off-by: Marc Pignat <[EMAIL PROTECTED]> --- Hello! Patch against 2.6.23. This patch fixes the bug I've submitted to linux-wireless friday in the "

Re: ARCH_FREE_PTE_NR 5350 on x86_64

2007-10-15 Thread Nick Piggin
On Monday 15 October 2007 16:54, Alok kataria wrote: > Hi, > > Looking at the tlb_flush code path and its co-relation with > ARCH_FREE_PTE_NR, on x86-64 architecture. I think we still don't use > the ARCH_FREE_PTE_NR of 5350 as the caching value for the mmu_gathers > structure, instead fallback to

Re: [PATCH] Rework hrtimer_nanosleep to make sys_compat_nanosleep easier

2007-10-15 Thread Arnd Bergmann
On Monday 15 October 2007, Anton Blanchard wrote: > Pull the copy_to_user out of hrtimer_nanosleep and into the callers > (common_nsleep, sys_nanosleep) in preparation for converting > compat_sys_nanosleep to use hrtimers. Looks good, except for two micro-optimization: > Signed-off-by: Anton Blan

Re: 2.6.23-mm1

2007-10-15 Thread Neil Brown
On Monday October 15, [EMAIL PROTECTED] wrote: > On Mon, Oct 15 2007, Milan Broz wrote: > > > > clone->bi_size is zero here now, so crypt_free_buffer_pages will not > > work correctly (previously there was count of processed bytes). > > > > But because it seems that bio cannot be processed partia

Re: [2.6.24 PATCH 02/25] dm io:ctl use constant struct size

2007-10-15 Thread Arnd Bergmann
On Monday 15 October 2007, Alasdair G Kergon wrote: > The underlying ABI is not changing, I hope - the trailing padding in the > struct should not affect the processing of the data by dm, and I see no > reason to continue maintaining the fiction that the 32-bit and 64-bit > ioctls are in some way i

Re: [PATCH] hptiop: avoid buffer overflow when returning sense data

2007-10-15 Thread HighPoint Linux Team
Andrew Morton wrote: > > > > avoid buffer overflow when returning sense data. > > > > That's really not enough information, sorry. > > > index 8b384fa..d32a4a9 100644 > > --- a/drivers/scsi/hptiop.c > > +++ b/drivers/scsi/hptiop.c > > @@ -375,8 +375,9 @@ static void hptiop_host_request_callback >

Re: [rfc][patch 3/3] x86: optimise barriers

2007-10-15 Thread Jarek Poplawski
On Fri, Oct 12, 2007 at 08:13:52AM -0700, Linus Torvalds wrote: > > > On Fri, 12 Oct 2007, Jarek Poplawski wrote: ... > So no, there's no way a software person could have afforded to say "it > seems to work on my setup even without the barrier". On a dual-socket > setup with s shared bus, that

Re: [irda-users] [PATCH] irlmp_unregister_link needs to free lsaps hashbin

2007-10-15 Thread [EMAIL PROTECTED]
Samuel Ortiz wrote: > Hi Hinko, > > On Fri, Oct 12, 2007 at 02:56:27PM +0200, [EMAIL PROTECTED] wrote: >> Hi, >> >> While testing the mcs7780 based IrDA USB dongle I've stumbled upon >> memory leak in irlmp_unregister_link(). Hashbin for lsaps is created in >> irlmp_register_link and should probab

Re: 2.6.23-mm1

2007-10-15 Thread Jens Axboe
On Mon, Oct 15 2007, Neil Brown wrote: > On Monday October 15, [EMAIL PROTECTED] wrote: > > On Mon, Oct 15 2007, Milan Broz wrote: > > > > > > clone->bi_size is zero here now, so crypt_free_buffer_pages will not > > > work correctly (previously there was count of processed bytes). > > > > > > But

Re: [PATCH] sched domain debug sysctl fixes

2007-10-15 Thread Ingo Molnar
* Milton Miller <[EMAIL PROTECTED]> wrote: > The following 5 patches provide fixes for the sysctl code added under > CONFIG_DEBUG_SCHED. After debugging a boot failure dereferencing not > per-cpu data for an impossible cpu, I found the other issues by > inspection. > > Following these fixes,

Re: [PATCH] drivers/block/cpqarray,cciss: kill unused var

2007-10-15 Thread Jens Axboe
On Sat, Oct 13 2007, Jeff Garzik wrote: > The recent bio work and subsequent fixups created unused variables. > > Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> > --- > drivers/block/cciss.c|1 - > drivers/block/cpqarray.c |3 +-- > 2 files changed, 1 insertion(+), 3 deletions(-) Tha

Re: What still uses the block layer?

2007-10-15 Thread Rob Landley
On Sunday 14 October 2007 8:45:03 pm Theodore Tso wrote: > On Sun, Oct 14, 2007 at 06:45:44PM -0500, Rob Landley wrote: > > I admit a certain amount of personal annoyance that once the SCSI > > layer consumes a category of device (USB, SATA, PATA), they can > > often _only_ be used by going through

Re: 2.6.23.1 x86 hardware monitoring bug?

2007-10-15 Thread Justin Piszcz
On Sun, 14 Oct 2007, Mark M. Hoffman wrote: Hi Justin: (added some CCs) * Justin Piszcz <[EMAIL PROTECTED]> [2007-10-14 15:30:18 -0400]: As a regular user, I cannot see the sensors on the A-bit board, but I can see the CPU temperature, how come I can see one but not the other? Kernel: $ un

Re: [PATCH RFC REPOST 1/2] paravirt: refactor struct paravirt_ops into smaller pv_*_ops

2007-10-15 Thread Rusty Russell
On Saturday 13 October 2007 05:16:04 Jeremy Fitzhardinge wrote: > Are you otherwise happy with the patch in its current form? And are you > happy with the lazymode changes? No, and yes. This applies on top of your 1/2. Boots here, runs lguest. It also exports pv_info: lg.ko checks it to avoid

Re: 2.6.23.1 x86 hardware monitoring bug?

2007-10-15 Thread Justin Piszcz
On Mon, 15 Oct 2007, Hans de Goede wrote: Mark M. Hoffman wrote: Hi Justin: (added some CCs) * Justin Piszcz <[EMAIL PROTECTED]> [2007-10-14 15:30:18 -0400]: As a regular user, I cannot see the sensors on the A-bit board, but I can see the CPU temperature, how come I can see one but not th

OOM killer gripe (was Re: What still uses the block layer?)

2007-10-15 Thread Nick Piggin
On Monday 15 October 2007 18:04, Rob Landley wrote: > On Sunday 14 October 2007 8:45:03 pm Theodore Tso wrote: > > > excuse for conflating different categories of devices in the first > > > place. > > > > See the thinkpad Ultrabay drive example above. > > Last week I drove my laptop so deep into s

Re: [rfc][patch 3/3] x86: optimise barriers

2007-10-15 Thread Nick Piggin
On Mon, Oct 15, 2007 at 09:44:05AM +0200, Jarek Poplawski wrote: > On Fri, Oct 12, 2007 at 08:13:52AM -0700, Linus Torvalds wrote: > > > > > > On Fri, 12 Oct 2007, Jarek Poplawski wrote: > ... > > So no, there's no way a software person could have afforded to say "it > > seems to work on my setu

[PATCH resend] ramdisk: fix zeroed ramdisk pages on memory pressure

2007-10-15 Thread Christian Borntraeger
Andrew, this is a resend of a bugfix patch. Ramdisk seems a bit unmaintained, so decided to sent the patch to you :-). I have CCed Ted, who did work on the code in the 90s. I found no current email address of Chad Page. We have seen ramdisk based install systems, where some pages of mapped librar

Re: [xfs-masters] Re: Interaction between Xen and XFS: stray RW mappings

2007-10-15 Thread Christoph Hellwig
On Mon, Oct 15, 2007 at 02:25:46PM +1000, David Chinner wrote: > > Hm, well I saw the problem with a filesystem made with mkfs.xfs with no > > options, so there must be at least *some* vmapping going on there. > > Sorry - I should have been more precise - vmap should never be used in > performance

Re: drivers/net/niu.c: possible array overflows

2007-10-15 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Sun, 14 Oct 2007 19:50:24 +0200 > The Coverity checker spotted the following in drivers/net/niu.c: Thanks for the report Adrian, I'll fix it like this: commit 503211a947ab13fb44d920f78f1e19057efc277f Author: David S. Miller <[EMAIL PROTECTED]> Date:

Re: What still uses the block layer?

2007-10-15 Thread Luben Tuikov
--- Rob Landley <[EMAIL PROTECTED]> wrote: > On Sunday 14 October 2007 7:45:46 pm Luben Tuikov wrote: > > Matthew's expletive and extremely rude response really shows > > the general attitude of the linux-scsi people. > > No, it doesn't. James Bottomley has been exceedingly polite and helpful, as

Re: Don't leak 'listeners' in netlink_kernel_create()

2007-10-15 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sun, 14 Oct 2007 16:30:06 -0600 > Jesper Juhl <[EMAIL PROTECTED]> writes: > > > From: Jesper Juhl <[EMAIL PROTECTED]> > > Subject: Don't leak 'listeners' in netlink_kernel_create() > > > > The Coverity checker spotted that we'll leak the storage a

Re: 2.6.23-mm1: BUG in reiserfs_delete_xattrs

2007-10-15 Thread Christoph Hellwig
On Mon, Oct 15, 2007 at 12:34:58AM +0200, Laurent Riffard wrote: > reiserfs_delete_xattrs > reiserfs_delete_inode > generic_delete_inode > generic_drop_inode > iput > do_unlinkat > sys_unlink > sys_enter_past_esp > > I reported a similar BUG in 2.6.22-rc8-mm2 (see > http://lkml.org/lkml/2007/9/27/

Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use

2007-10-15 Thread David Miller
From: Noriaki TAKAMIYA <[EMAIL PROTECTED]> Date: Mon, 15 Oct 2007 12:37:49 +0900 (JST) > > > > On Sun, 14 Oct 2007 19:52:12 +0200 > > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > > The Coverity checker spotted that we have already oops'ed if "dst" > > > was NULL. > > > > > > Since "dst" being

Re: What still uses the block layer?

2007-10-15 Thread Christoph Hellwig
On Sun, Oct 14, 2007 at 11:00:15PM -0700, Greg KH wrote: > If you hate USB storage devices using scsi, please use the ub driver, > that is what it was written for. The ub driver is a really dumb piece of shit. It only drivers usb storage devices using a scsi protocol set, and duplicates the scsi

Re: [PATCH resend] ramdisk: fix zeroed ramdisk pages on memory pressure

2007-10-15 Thread Nick Piggin
On Monday 15 October 2007 18:28, Christian Borntraeger wrote: > Andrew, this is a resend of a bugfix patch. Ramdisk seems a bit > unmaintained, so decided to sent the patch to you :-). > I have CCed Ted, who did work on the code in the 90s. I found no current > email address of Chad Page. This rea

Re: [PATCH resend] ramdisk: fix zeroed ramdisk pages on memory pressure

2007-10-15 Thread Christian Borntraeger
Am Montag, 15. Oktober 2007 schrieb Nick Piggin: > On Monday 15 October 2007 18:28, Christian Borntraeger wrote: > > Andrew, this is a resend of a bugfix patch. Ramdisk seems a bit > > unmaintained, so decided to sent the patch to you :-). > > I have CCed Ted, who did work on the code in the 90s. I

Re: What still uses the block layer?

2007-10-15 Thread Julian Calaby
On 10/15/07, Rob Landley <[EMAIL PROTECTED]> wrote: > I note that the eth0 and eth1 names are dynamically assigned on a first come > first serve basis (like scsi). This never causes me a problem because the > driver loading order is constant, and once you figure out that eth0 is > gigabit and eth1

Re: [rfc][patch 3/3] x86: optimise barriers

2007-10-15 Thread Jarek Poplawski
On Mon, Oct 15, 2007 at 10:09:24AM +0200, Nick Piggin wrote: ... > Has performance really been much problem for you? (even before the > lfence instruction, when you theoretically had to use a locked op)? > I mean, I'd struggle to find a place in the Linux kernel where there > is actually a measurab

Re: [PATCH resend] ramdisk: fix zeroed ramdisk pages on memory pressure

2007-10-15 Thread Andrew Morton
On Tue, 16 Oct 2007 00:06:19 +1000 Nick Piggin <[EMAIL PROTECTED]> wrote: > On Monday 15 October 2007 18:28, Christian Borntraeger wrote: > > Andrew, this is a resend of a bugfix patch. Ramdisk seems a bit > > unmaintained, so decided to sent the patch to you :-). > > I have CCed Ted, who did work

Re: [lm-sensors] 2.6.23.1 x86 hardware monitoring bug?

2007-10-15 Thread Rudolf Marek
Hi, Most likely you have distro and custom libsensors installed on the system. (and different PATH for root) Please check how many of libsensors libraries is installed. Thanks, Rudolf - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [rfc][patch 3/3] x86: optimise barriers

2007-10-15 Thread Jarek Poplawski
On Mon, Oct 15, 2007 at 11:09:59AM +0200, Jarek Poplawski wrote: ... > I'm not performance-words at all, so I can't help you, sorry. But, I ...performance-wards?! Looks like serious: I don't even now who I'm not now! Jarek P. - To unsubscribe from this list: send the line "unsubscribe linux-kern

Re: What still uses the block layer?

2007-10-15 Thread Rob Landley
On Monday 15 October 2007 1:00:15 am Greg KH wrote: > If you hate USB storage devices using scsi, please use the ub driver, > that is what it was written for. For the embedded space, the ability to configure out the scsi layer is interesting from a size perspective. I bookmarked that a while bac

Re: What still uses the block layer?

2007-10-15 Thread Rob Landley
On Monday 15 October 2007 12:44:19 am Stefan Richter wrote: > Rob Landley wrote: > > I was at least attempting to ask a serious question. > > ... > > > Actually, I was going through Documentation/block thinking about making a > > 00-INDEX for it, but my earlier questions of the scsi guys left me wi

Re: [PATCH resend] ramdisk: fix zeroed ramdisk pages on memory pressure

2007-10-15 Thread Nick Piggin
On Monday 15 October 2007 19:05, Christian Borntraeger wrote: > Am Montag, 15. Oktober 2007 schrieb Nick Piggin: > > On Monday 15 October 2007 18:28, Christian Borntraeger wrote: > > > Andrew, this is a resend of a bugfix patch. Ramdisk seems a bit > > > unmaintained, so decided to sent the patch t

Re: Interaction between Xen and XFS: stray RW mappings

2007-10-15 Thread Andi Kleen
David Chinner <[EMAIL PROTECTED]> writes: > > And yes, we delay unmapping pages until we have a batch of them > to unmap. vmap and vunmap do not scale, so this is batching helps > alleviate some of the worst of the problems. You're keeping vmaps around for already freed pages? That will be a big

Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.

2007-10-15 Thread Ingo Molnar
* Laurent Vivier <[EMAIL PROTECTED]> wrote: > [PATCH 4/4] Modify KVM to update guest time accounting. FYI, KVM abstracted its guest-mode entry code recently so this did not apply - find below the reworked patch. Ingo ---> Subject: sched: guest CPU accounting: maintain

Re: [PATCH] Update Jens Axboe's email in Documentation/*

2007-10-15 Thread Jens Axboe
On Sat, Oct 13 2007, Rob Landley wrote: > From: Rob Landley <[EMAIL PROTECTED]> > > Jens Axboe's old email address bounces. > > Signed-off-by: Rob Landley <[EMAIL PROTECTED]> Thanks, I'll add it to the patch list. I guess people often look in the documentation for email addresses, so it's nice t

Re: Interaction between Xen and XFS: stray RW mappings

2007-10-15 Thread Nick Piggin
On Monday 15 October 2007 19:36, Andi Kleen wrote: > David Chinner <[EMAIL PROTECTED]> writes: > > And yes, we delay unmapping pages until we have a batch of them > > to unmap. vmap and vunmap do not scale, so this is batching helps > > alleviate some of the worst of the problems. > > You're keepin

Re: Hitachi disk: spurious completions during NCQ

2007-10-15 Thread Luca
On 10/15/07, Don Mullis <[EMAIL PROTECTED]> wrote: > > > ata3.00: spurious completions during NCQ issue=0x0 SAct=0x407fd > > FIS=005040a1:0002 > > ata3.00: cmd 61/08:00:c7:5a:82/00:00:1b:00:00/40 tag 0 cdb 0x0 data 4096 out > > res 50/00:10:07:5b:82/00:00:1b:00:00/40 Emask 0x2 (HSM vi

Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.

2007-10-15 Thread Avi Kivity
Ingo Molnar wrote: int kvm_hypercall(struct kvm_vcpu *vcpu, struct kvm_run *run); +/* + * Compatibility define - PF_VCPU is only available in v2.6.24+ kernels: + */ +#ifndef PF_VCPU +# define PF_VCPU 0 +#endif + This bit can go; for the external module I can add it back in externa

Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.

2007-10-15 Thread Ingo Molnar
* Avi Kivity <[EMAIL PROTECTED]> wrote: > Ingo Molnar wrote: > > int kvm_hypercall(struct kvm_vcpu *vcpu, struct kvm_run *run); > > > >+/* > >+ * Compatibility define - PF_VCPU is only available in v2.6.24+ kernels: > >+ */ > >+#ifndef PF_VCPU > >+# define PF_VCPU0 > >+#endif > >+ > > > >

[PATCH] PS3 system bus add_uevent_var() fallout

2007-10-15 Thread Geert Uytterhoeven
PS3 system bus add_uevent_var() fallout: kill unused variables Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> --- arch/powerpc/platforms/ps3/system-bus.c |1 - 1 files changed, 1 deletion(-) --- a/arch/powerpc/platforms/ps3/system-bus.c +++ b/arch/powerpc/platforms/ps3/system-bus.c @@

Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.

2007-10-15 Thread Ingo Molnar
* Avi Kivity <[EMAIL PROTECTED]> wrote: > This bit can go; for the external module I can add it back in > external-module-compat.h. No need to pollute mainline with backward > compatibility stuff. hm: static inline void kvm_guest_enter(void) { current->flags |= PF_VCPU; } static inl

Re: OOM killer gripe (was Re: What still uses the block layer?)

2007-10-15 Thread Rob Landley
On Monday 15 October 2007 8:37:44 am Nick Piggin wrote: > > Virtual memory isn't perfect. I've _always_ been able to come up with > > examples where it just doesn't work for me. This doesn't mean VM > > overcommit should be abolished, because it's useful more often than not. > > I hate to go comp

[PATCH] Add Documentation/block/00-INDEX

2007-10-15 Thread Rob Landley
From: Rob Landley <[EMAIL PROTECTED]> Add Documentation/block/00-INDEX Signed-off-by: Rob Landley <[EMAIL PROTECTED]> --- By the way, shouldn't request.txt be in htmldocs somewhere? Documentation/block/00-INDEX | 20 1 file changed, 20 insertions(+) --- /dev/null 2007

Re: -git mips defconfig compile error

2007-10-15 Thread Ralf Baechle
On Sun, Oct 14, 2007 at 03:19:48PM +0200, Adrian Bunk wrote: > Commit 05dc8c02bf40090e9ed23932b1980ead48eb8870 causes the following > compile error with the mips defconfig: > > <-- snip --> > > ... > CC drivers/video/logo/logo.o > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video

Re: OOM killer gripe (was Re: What still uses the block layer?)

2007-10-15 Thread Nick Piggin
On Monday 15 October 2007 19:52, Rob Landley wrote: > On Monday 15 October 2007 8:37:44 am Nick Piggin wrote: > > > Virtual memory isn't perfect. I've _always_ been able to come up with > > > examples where it just doesn't work for me. This doesn't mean VM > > > overcommit should be abolished, be

Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.

2007-10-15 Thread Avi Kivity
Ingo Molnar wrote: * Avi Kivity <[EMAIL PROTECTED]> wrote: This bit can go; for the external module I can add it back in external-module-compat.h. No need to pollute mainline with backward compatibility stuff. hm: static inline void kvm_guest_enter(void) { current->flags |=

Re: [PATCH] frv: missing casts in cmpxchg()

2007-10-15 Thread David Howells
Al Viro <[EMAIL PROTECTED]> wrote: > Signed-off-by: Al Viro <[EMAIL PROTECTED]> Acked-by: David Howells <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majord

Re: What still uses the block layer?

2007-10-15 Thread Rob Landley
On Monday 15 October 2007 4:06:20 am Julian Calaby wrote: > On 10/15/07, Rob Landley <[EMAIL PROTECTED]> wrote: > > I note that the eth0 and eth1 names are dynamically assigned on a first > > come first serve basis (like scsi). This never causes me a problem > > because the driver loading order is

Re: [PATCH resend] ramdisk: fix zeroed ramdisk pages on memory pressure

2007-10-15 Thread Nick Piggin
On Monday 15 October 2007 19:16, Andrew Morton wrote: > On Tue, 16 Oct 2007 00:06:19 +1000 Nick Piggin <[EMAIL PROTECTED]> wrote: > > On Monday 15 October 2007 18:28, Christian Borntraeger wrote: > > > Andrew, this is a resend of a bugfix patch. Ramdisk seems a bit > > > unmaintained, so decided t

Re: [PATCH 3/3] faster workaround

2007-10-15 Thread Bernd Schubert
On Friday 12 October 2007 23:08:21 Jeff Garzik wrote: > Bernd Schubert wrote: > > a) 2.6.23 + sil-patch I posted, this is on a customer system (though my > > former group), I wouldn't like to use -mm there. > > > > b) .config is attached > > > > c) attached > > > > d) attached (don't get irritaded

Re: [rfc][patch 3/3] x86: optimise barriers

2007-10-15 Thread Helge Hafting
Jarek Poplawski wrote: On Fri, Oct 12, 2007 at 02:44:51PM +0200, Helge Hafting wrote: ... The point is that we _trust_ intel when they says "this will work". Therefore, we can use the optimizations. It was never about legal matters. If we didn't trust intel, then we couldn't use their process

Re: [lm-sensors] 2.6.23.1 x86 hardware monitoring bug?

2007-10-15 Thread Justin Piszcz
On Mon, 15 Oct 2007, Rudolf Marek wrote: Hi, Most likely you have distro and custom libsensors installed on the system. (and different PATH for root) Please check how many of libsensors libraries is installed. Thanks, Rudolf I only had one, in /app (lm-sensors-2.10.2) -- which has bee

RocketPort Linux driver errors on module reload

2007-10-15 Thread Ferenc Wagner
Hi, A few days ago I sent the enclosed bug report to the address advertised in Documentation/rocket.txt. Till now I got no reply. While they think about it, I decided to air the problem here, too. In a nutshell, the rocket module doesn't deregister its devices during removal, they stay in /sys/c

Re: What still uses the block layer?

2007-10-15 Thread Loïc Grenié
2007/10/15, Rob Landley <[EMAIL PROTECTED]>: > On Sunday 14 October 2007 8:45:03 pm Theodore Tso wrote: >> On Sun, Oct 14, 2007 at 06:45:44PM -0500, Rob Landley wrote: >>> I admit a certain amount of personal annoyance that once the SCSI >>> layer consumes a category of device (USB, SATA, PATA), th

Re: halt does not shut the system down

2007-10-15 Thread John Sigler
John Sigler wrote: Alexey Starikovskiy wrote: Could you please open bug at bugzilla.kernel.org and put all these files there? http://bugzilla.kernel.org/show_bug.cgi?id=9148 Writing 15361 (i.e. 0x3C01) to ACPI_REGISTER_PM1A_CONTROL appears to hang my system in acpi_os_write_port(). What c

Re: WANTED: kernel projects for CS students

2007-10-15 Thread WANG Cong
On Sun, Oct 14, 2007 at 07:01:28PM -0400, Rik van Riel wrote: >The kernel newbies community often gets inquiries from CS students who >need a project for their studies and would like to do something with >the Linux kernel, but would also like their code to be useful to the >community afterwards. >

Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting

2007-10-15 Thread Christian Borntraeger
Am Montag, 10. September 2007 schrieb Laurent Vivier: > The aim of these four patches is to introduce Virtual Machine time accounting. I would move this line    if (p->flags & PF_VCPU) {    account_guest_time(p, cputime); -->   p->flags &= ~PF_VCPU; <-    

Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.

2007-10-15 Thread Laurent Vivier
Avi Kivity wrote: > Ingo Molnar wrote: >> * Avi Kivity <[EMAIL PROTECTED]> wrote: >> >> >>> This bit can go; for the external module I can add it back in >>> external-module-compat.h. No need to pollute mainline with backward >>> compatibility stuff. >>> >> >> hm: >> >> static inline void k

Re: [bug] usb build failure, latest -git

2007-10-15 Thread Ingo Molnar
* Al Viro <[EMAIL PROTECTED]> wrote: > On Sun, Oct 14, 2007 at 05:29:48AM +0200, Ingo Molnar wrote: > > > > FYI, the attached config fails to build on most recent -git with: > > > > In file included from drivers/usb/host/ohci-hcd.c:1038: > > drivers/usb/host/ohci-ssb.c:120: error: 'ohci_bus_s

2.6.23-rt1 trouble

2007-10-15 Thread Rui Nuno Capela
On Fri, October 12, 2007 03:04, Steven Rostedt wrote: > We are pleased to announce the 2.6.23-rt1 tree, which can be > downloaded from the location: > > http://www.kernel.org/pub/linux/kernel/projects/rt/ > > Changes since 2.6.23-rc9-rt2 > > - updated to 2.6.23 > > - spin_trylock_irqsave macro fix

Re: Interaction between Xen and XFS: stray RW mappings

2007-10-15 Thread Andi Kleen
On Tue, Oct 16, 2007 at 12:56:46AM +1000, Nick Piggin wrote: > Is this true even if you don't write through those old mappings? I think it happened for reads too. It is a little counter intuitive because in theory the CPU doesn't need to write back non dirty lines, but in the one case which took

Re: [PATCH] sched: Rationalize sys_sched_rr_get_interval()

2007-10-15 Thread Jarek Poplawski
On 13-10-2007 03:29, Peter Williams wrote: > Jarek Poplawski wrote: >> On 12-10-2007 00:23, Peter Williams wrote: >> ... >>> The reason I was going that route was for modularity (which helps >>> when adding plugsched patches). I'll submit a revised patch for >>> consideration. >> ... >> >> IMHO,

[BUG] Linux 2.6.23.1 - Open Firmware exception handler invoked

2007-10-15 Thread Kamalesh Babulal
Hi, The Open Firmware exception handler is begin invoked, on power5 lpar. boot: 2.6.23.1 Please wait, loading kernel... Allocated 0350 bytes for kernel @ 01c0 Elf64 kernel loaded... Loading ramdisk... ramdisk loaded 0020d000 @ 06b0 DEFAULT CATCH!, exception-handler=fff00300 at %

Re: halt does not shut the system down

2007-10-15 Thread Alexey Starikovskiy
John Sigler wrote: > John Sigler wrote: > >> Alexey Starikovskiy wrote: >> >>> Could you please open bug at bugzilla.kernel.org and put all these >>> files there? >> >> http://bugzilla.kernel.org/show_bug.cgi?id=9148 > > Writing 15361 (i.e. 0x3C01) to ACPI_REGISTER_PM1A_CONTROL appears to > hang

[PATCH take2] [POWERPC] i2c: adds support for i2c bus on 8xx

2007-10-15 Thread Jochen Friedrich
Using the port of 2.4 code from Vitaly Bordug <[EMAIL PROTECTED]> and the actual algorithm used by the i2c driver of the DBox code on cvs.tuxboc.org from Tmbinc, Gillem ([EMAIL PROTECTED]). Renamed i2c-algo-8xx.c to i2c-algo-cpm.c and i2c-rpx.c to i2c-8xx.c. Added original i2c-rpx.c as i2c-8xx-pp

[build bug] error: 'VID_HARDWARE_GEMTEK' undeclared

2007-10-15 Thread Ingo Molnar
randconfig testing of latest -git found this build bug: drivers/media/radio/radio-gemtek.c:557: error: 'VID_HARDWARE_GEMTEK' undeclared here (not in a function) config attached. Ingo # # Automatically generated make config: don't edit # Linux kernel version: 2.6.23 # Mon Oct 15 13:06:5

Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.

2007-10-15 Thread Avi Kivity
Laurent Vivier wrote: Avi Kivity wrote: Ingo Molnar wrote: * Avi Kivity <[EMAIL PROTECTED]> wrote: This bit can go; for the external module I can add it back in external-module-compat.h. No need to pollute mainline with backward compatibility stuff. hm: stati

Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.

2007-10-15 Thread Christian Borntraeger
forgot to CC everybody besides Laurent: Am Montag, 15. Oktober 2007 schrieben Sie: > No, It must not be cleared here because we can't enter in the accounting code > between kvm_guest_enter(void) and kvm_guest_exit(void). > > This is why the accounting code clears it. > > I put a kvm_guest_exit()

Re: What still uses the block layer?

2007-10-15 Thread Neil Brown
On Monday October 15, [EMAIL PROTECTED] wrote: > > This is my objection. Even when enumerating multiple devices of the same > type > is tricky, enumerating multiple devices of _different_ types should not be. > There's a great big type indicator that is being _deliberately_ ignored, and > la

Re: RocketPort Linux driver errors on module reload

2007-10-15 Thread Jiri Slaby
> Start of forwarded message > From: Ferenc Wagner <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED] > Subject: RocketPort Linux driver errors on module reload > Date: Fri, 12 Oct 2007 00:22:17 +0200 > Message-ID: <[EMAIL PROTECTED]> > > Hi, > > I hope I send t

Re: [PATCH 0/3] debloat aic7xxx and aic79xx drivers

2007-10-15 Thread Denys Vlasenko
On Sunday 14 October 2007 18:47, Gabriel C wrote: > > Compile tested and applies cleanly to 2.6.23. > > I don't have this hardware anymore and cannot run test these patches. > > I can test these patches on an aic7892 controller later on today if you want. I'd appreciate that. Do you, by any chan

Re: WARNING: at net/core/dev.c:2161 net_rx_action()

2007-10-15 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > got this warning with Linus' latest -git tree: > > WARNING: at net/core/dev.c:2161 net_rx_action() >[<80564db4>] net_rx_action+0xce/0x186 >[<8011ba98>] __do_softirq+0x6c/0xcf >[<8011bb2d>] do_softirq+0x32/0x36 >[<8011bcae>] irq_exit+0x

Re: Interaction between Xen and XFS: stray RW mappings

2007-10-15 Thread Nick Piggin
On Monday 15 October 2007 21:07, Andi Kleen wrote: > On Tue, Oct 16, 2007 at 12:56:46AM +1000, Nick Piggin wrote: > > Is this true even if you don't write through those old mappings? > > I think it happened for reads too. It is a little counter intuitive > because in theory the CPU doesn't need to

Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.

2007-10-15 Thread Christian Borntraeger
Am Montag, 15. Oktober 2007 schrieb Avi Kivity: > We can clear it a bit later, after local_irq_enable() in __vcpu_run(). > However we need a nop instruction first because "sti" keeps interrupts > disabled for one more instruction. Ah, I see. The host interrupt behaves different and instead of

[-mm Patch] drivers/net/wireless/b43/main.c: fix an uninitialized variable

2007-10-15 Thread WANG Cong
Fix an uninitialized variable in drivers/net/wireless/b43/main.c::b43_start(). From: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: WANG Cong <[EMAIL PROTECTED]> --- drivers/net/wireless/b43/main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.23-mm1/drivers/net/wir

Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.

2007-10-15 Thread Laurent Vivier
Avi Kivity wrote: > Laurent Vivier wrote: >> Avi Kivity wrote: >> >>> Ingo Molnar wrote: >>> * Avi Kivity <[EMAIL PROTECTED]> wrote: > This bit can go; for the external module I can add it back in > external-module-compat.h. No need to pollute mainline wit

Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.

2007-10-15 Thread Laurent Vivier
Christian Borntraeger wrote: > Am Montag, 15. Oktober 2007 schrieb Avi Kivity: >> We can clear it a bit later, after local_irq_enable() in __vcpu_run(). >> However we need a nop instruction first because "sti" keeps interrupts >> disabled for one more instruction. > > Ah, I see. The host interr

Re: OOM killer gripe (was Re: What still uses the block layer?)

2007-10-15 Thread Theodore Tso
On Mon, Oct 15, 2007 at 11:37:44PM +1000, Nick Piggin wrote: > I hate to go completely offtopic here, but disks are so incredibly > slow when compared to RAM that there is really nothing the kernel > can do about this. Presumably the job will finish, given infinite > time. About 6 weeks ago, on a

Re: How to find slab\'s usage?

2007-10-15 Thread Tetsuo Handa
Hello. Eric Dumazet wrote: > > Yes. There is /sys/slab/ . > > But are there any tools for browsing like /usr/bin/slabtop ? > > Is > > cd /sys/slab/; for i in *; do echo -n $i " "; cat $i/slabs; done > > the only way currently available? > > Grab kernel sources, you'll find inside : Documentatio

Re: [TOMOYO 05/15](repost) Domain transition handler functions.

2007-10-15 Thread Tetsuo Handa
Hello. Peter Zijlstra wrote: > > append_function() { > > > > down(semaphore_for_write_protect); > > ... > > ptr = head; > > while (ptr->next) ptr = ptr->next; > > ptr->next = new_entry; > > ... > > up(semaphore_for_write_protect); > > > > } > > If at all possible, use struct mutex

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

2007-10-15 Thread Pekka Enberg
Hi, On 10/15/07, Erez Zadok <[EMAIL PROTECTED]> wrote: > Pekka, with a small change to your patch (to handle time-based cache > coherency), your patch worked well and passed all my tests. Thanks. > > So now I wonder if we still need the patch to prevent AOP_WRITEPAGE_ACTIVATE > from being returne

[patch 0/2] Protect crashkernel against BSS overlap

2007-10-15 Thread Bernhard Walle
I observed the problem that even when you choose the default 16M as crashkernel base address and the kernel is very big, the reserved area may overlap with the kernel BSS. Currently, this is not checked at runtime, so the kernel just crashes when you load the panic kernel in the sys_kexec call. Th

[patch 1/2] Add BSS to resource tree

2007-10-15 Thread Bernhard Walle
This patch adds the BSS to the resource tree just as kernel text and kernel data are in the resource tree. The main reason behind this is to avoid crashkernel reservation in that area. Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]> --- arch/x86/kernel/e820_32.c |8 arch/x86/ker

[patch 2/2] Check if the crashkernel area is behind BSS

2007-10-15 Thread Bernhard Walle
This patch checks if the crashkernel base address is after the end of BSS on i386 and x86_64. Having "Kernel bss" in the resource tree is not sufficient since that only prevents "crash kernel" from appearing in the resource tree and therefore kexec from loading the crashdump kernel since it checks

Re: [rfc][patch 3/3] x86: optimise barriers

2007-10-15 Thread Jarek Poplawski
On Mon, Oct 15, 2007 at 12:17:40PM +0200, Helge Hafting wrote: > Jarek Poplawski wrote: > >On Fri, Oct 12, 2007 at 02:44:51PM +0200, Helge Hafting wrote: > >... > > > >>The point is that we _trust_ intel when they says "this will work". > >>Therefore, we can use the optimizations. It was never ab

Re: [PATCH] zd1211rw, fix oops when ejecting install media

2007-10-15 Thread Daniel Drake
Marc Pignat wrote: The disconnect function can dereference the net_device structure before it is allocated. This is the case when ejecting the device installer. Signed-off-by: Marc Pignat <[EMAIL PROTECTED]> s/before it is allocated/when it is never allocated/ Acked-by: Daniel Drake <[EMAIL P

[-mm Patch] drivers/net/wireless/b43legacy/main.c: initialize the correct return value

2007-10-15 Thread WANG Cong
Initialize "err" in drivers/net/wireless/b43legacy/main.c::b43legacy_start() in case of returning an uninitialized value. From: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: WANG Cong <[EMAIL PROTECTED]> --- drivers/net/wireless/b43/main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.

2007-10-15 Thread Avi Kivity
Laurent Vivier wrote: But if we didn't get an interrupt in that time? We can clear it a bit later, after local_irq_enable() in __vcpu_run(). However we need a nop instruction first because "sti" keeps interrupts disabled for one more instruction. IMHO, I think it is better to let kv

Re: [TOMOYO 05/15](repost) Domain transition handler functions.

2007-10-15 Thread Tetsuo Handa
Hello. James Morris wrote: > > > It seems that standard kernel list API does not have singly-linked list > > > manipulation. > > > I'm considering the following list manipulation API. > > I'm pretty sure that the singly linked list idea has been rejected a few > times. Just use the existing AP

[PATCH 0/2 try#4] x86: MCE optimization and cleanups

2007-10-15 Thread Joerg Roedel
This patchset includes two patches. 1. Checks for the MCA fetures as early as possible and signedness fixup. 2. Minor coding style cleanup. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vge

[PATCH 1/2] x86: MCE optimization/refactoring

2007-10-15 Thread Joerg Roedel
MCG_CAP never reports a negative count of available error-reporting banks. Therefore, make nr_mce_banks unsigned. Check for MCE feature bit as early as possible and clean up the extra _MCE checks in the various cpu init type functions per request from Thomas Gleixner. Signed-off-by: Christoph Egge

[PATCH 2/2] x86: mce minor indent cleanup

2007-10-15 Thread Joerg Roedel
remove one indent level Signed-off-by: Christoph Egger <[EMAIL PROTECTED]> Signed-off-by: Joerg Roedel <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/mcheck/mce.c | 40 +++--- 1 files changed, 20 insertions(+), 20 deletions(-) diff --git a/arch/x86/kernel/cpu/mchec

nfs mmap adventure (was: 2.6.23-mm1)

2007-10-15 Thread Peter Zijlstra
I get funny SIGBUS' like so: fault if (->page_mkwrite() < 0) nfs_vm_page_mkwrite() nfs_write_begin() nfs_flush_incompatible() nfs_wb_page() nfs_wb_page_priority() nfs_sync_mapping_wait() nfs_wait_on_request_locked()

Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting.

2007-10-15 Thread Laurent Vivier
Avi Kivity wrote: > Laurent Vivier wrote: > > > >>> But if we didn't get an interrupt in that time? >>> >>> We can clear it a bit later, after local_irq_enable() in >>> __vcpu_run(). However we need a nop instruction first because "sti" >>> keeps interrupts >>> disabled for one more instruction

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

2007-10-15 Thread Jarek Poplawski
On 19-09-2007 16:38, Maciej W. Rozycki wrote: ... > @@ -661,13 +664,22 @@ int phy_stop_interrupts(struct phy_devic > if (err) > phy_error(phydev); > > + free_irq(phydev->irq, phydev); > + > /* > - * Finish any pending work; we might have been scheduled to be cal

  1   2   3   4   5   6   >