Re: Kernel panic at boot with ondemand governor as default (2.6.24-rc2)

2007-11-11 Thread Arjan van de Ven
On Sun, 11 Nov 2007 20:10:23 +0100 Eric Piel <[EMAIL PROTECTED]> wrote: > Hello, > > I've tried kernel 2.6.24-rc2 and I have a problem with the new option > for setting up the cpufreq ondemand governor as default: a kernel > panic happens early at boot time. If I boot first with performance > go

Re: 2.6.24-rc2: Reported regressions from 2.6.23 (updated)

2007-11-11 Thread Alan Cox
> [PATCH] pata_amd/pata_via: de-couple programming of PIO/MWDMA and UDMA timings > > * Don't program UDMA timings when programming PIO or MWDMA modes. > > This has also a nice side-effect of fixing regression added by commit > 681c80b5d96076f447e8101ac4325c82d8dce508 ("libata: correct handlin

Re: [PATCH] Improve cgroup printks

2007-11-11 Thread Jan Engelhardt
>When I boot with the 'quiet' parameter, I see on the screen: > >[0.00] Initializing cgroup subsys cpuset >[0.00] Initializing cgroup subsys cpu >[ 39.036026] Initializing cgroup subsys cpuacct >[ 39.036080] Initializing cgroup subsys debug >[ 39.036118] Initializing cgroup s

Re: [PATCH] Include header required for INT_MAX

2007-11-11 Thread Jan Engelhardt
>> Nack, we shoiuld never include userspace headers in kernel headers, >> an even more never add !__KERNEL__ ifdefs. Just make sure your >> programs include limit.h before including linux/cdrom.h. > >I think header files should be complete, and should not use undefined >macros, picking up every r

[PATCH] Fix memory leak in discard case of sctp_sf_abort_violation()

2007-11-11 Thread Jesper Juhl
From: Jesper Juhl <[EMAIL PROTECTED]> In net/sctp/sm_statefuns.c::sctp_sf_abort_violation() we may leak the storage allocated for 'abort' by returning from the function without using or freeing it. This happens in case "sctp_auth_recv_cid(SCTP_CID_ABORT, asoc)" is true and we jump to the 'disc

Re: [PATCH] markers: modpost

2007-11-11 Thread Mathieu Desnoyers
* David Smith ([EMAIL PROTECTED]) wrote: > Mathieu Desnoyers wrote: > > Hrm, what would happen if a gcc optimization eventually decides to mix > > the memory layout of the strings ? Is there something that specifies > > that they won't ? > > Here's another patch that Roland wrote and I tested that

[PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread Jesper Juhl
From: Jesper Juhl <[EMAIL PROTECTED]> in sas_get_phy_change_count(), the line disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE); will allocate 56 bytes due to this define: #define DISCOVER_RESP_SIZE 56 But, the struct is actually 60 bytes in size. So change the define to be

mm_release() call in exit_mm() looks dangerous

2007-11-11 Thread Jesper Juhl
In kernel/exit.c we have this code : static void exit_mm(struct task_struct * tsk) { struct mm_struct *mm = tsk->mm; mm_release(tsk, mm); if (!mm) return; ... But, mm_release() may dereference it's second argument ('mm'), so shouldn't we be doing the "!mm

Re: Bind mount bug?

2007-11-11 Thread Frans Pop
On Sunday 11 November 2007, Jan Engelhardt wrote: > >This mounts the bindtest/ tree on test/ _without_ copying the mount > >points which are found on subtrees. This is necessary to avoid loops > >in the filesystem (bind mounts are somewhat like hardlinks on > >directories, just without the headache

Re: PCI card initialisation at boot

2007-11-11 Thread Matt Domsch
On Sun, Nov 11, 2007 at 04:46:44PM +, Alan Cox wrote: > Linux by default uses the BIOS resource assignments. It doesn't know > where those came from other than "the BIOS". Slightly tangential, but I'm starting to hear requests to have the OS re-assign resources when it might make better sense.

Re: [PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread James Bottomley
On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote: > From: Jesper Juhl <[EMAIL PROTECTED]> > > in sas_get_phy_change_count(), the line > disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE); > will allocate 56 bytes due to this define: > #define DISCOVER_RESP_SIZE 56 > But, the struct is

[PATCH] Let 'make help' output info about includecheck

2007-11-11 Thread Jesper Juhl
From: Jesper Juhl <[EMAIL PROTECTED]> 'make includecheck' is useful and we want people to run it, so let 'make help' output information about its existence. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- Makefile |1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile i

Re: [PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread Jesper Juhl
On 12/11/2007, James Bottomley <[EMAIL PROTECTED]> wrote: > On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote: > > From: Jesper Juhl <[EMAIL PROTECTED]> > > > > in sas_get_phy_change_count(), the line > > disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE); > > will allocate 56 bytes due to thi

Re: PCI card initialisation at boot

2007-11-11 Thread H. Peter Anvin
Matt Domsch wrote: On Sun, Nov 11, 2007 at 04:46:44PM +, Alan Cox wrote: Linux by default uses the BIOS resource assignments. It doesn't know where those came from other than "the BIOS". Slightly tangential, but I'm starting to hear requests to have the OS re-assign resources when it might

Re: [PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread Douglas Gilbert
James Bottomley wrote: > On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote: >> From: Jesper Juhl <[EMAIL PROTECTED]> >> >> in sas_get_phy_change_count(), the line >> disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE); >> will allocate 56 bytes due to this define: >> #define DISCOVER_RESP_S

Re: [PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread James Bottomley
On Mon, 2007-11-12 at 01:13 +0100, Jesper Juhl wrote: > On 12/11/2007, James Bottomley <[EMAIL PROTECTED]> wrote: > > On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote: > > > From: Jesper Juhl <[EMAIL PROTECTED]> > > > > > > in sas_get_phy_change_count(), the line > > > disc_resp = alloc_s

Re: Kernel panic at boot with ondemand governor as default (2.6.24-rc2)

2007-11-11 Thread Eric Piel
2007年11月11日 23:45, Arjan van de Ven wrote/a écrit: On Sun, 11 Nov 2007 20:10:23 +0100 Eric Piel <[EMAIL PROTECTED]> wrote: Hello, I've tried kernel 2.6.24-rc2 and I have a problem with the new option for setting up the cpufreq ondemand governor as default: a kernel panic happens early at boo

Re: [PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread James Bottomley
On Sun, 2007-11-11 at 19:33 -0500, Douglas Gilbert wrote: > James Bottomley wrote: > > On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote: > >> From: Jesper Juhl <[EMAIL PROTECTED]> > >> > >> in sas_get_phy_change_count(), the line > >>disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE); > >> will

Re: iozone write 50% regression in kernel 2.6.24-rc1

2007-11-11 Thread Zhang, Yanmin
On Fri, 2007-11-09 at 04:36 -0800, Martin Knoblauch wrote: > - Original Message > > From: "Zhang, Yanmin" <[EMAIL PROTECTED]> > > To: [EMAIL PROTECTED] > > Cc: LKML > > Sent: Friday, November 9, 2007 10:47:52 AM > > Subject: iozone write 50% regression in kernel 2.6.24-rc1 > > > > Compar

Re: [PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread Jesper Juhl
On 12/11/2007, James Bottomley <[EMAIL PROTECTED]> wrote: > On Mon, 2007-11-12 at 01:13 +0100, Jesper Juhl wrote: > > On 12/11/2007, James Bottomley <[EMAIL PROTECTED]> wrote: > > > On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote: > > > > From: Jesper Juhl <[EMAIL PROTECTED]> > > > > > > > > i

[PATCH] SCSI: Fix bugs and canonicalize irq handler usage in NCR5380 drivers

2007-11-11 Thread Jeff Garzik
* Always pass the same value to free_irq() that we pass to request_irq(). This fixes several bugs. * Always call NCR5380_intr() with 'irq' and 'dev_id' arguments. Note, scsi_falcon_intr() is the only case now where dev_id is not the scsi_host. * Always pass Scsi_Host to request_irq(). Fo

Re: [PATCH] iwlwifi: Remove unnecessary code in iwl3945 and iwl4965 drivers

2007-11-11 Thread Zhu Yi
On Sat, 2007-11-10 at 20:49 +0100, Miguel Botón wrote: > Remove unnecesary code in iwl3945 and iwl4965 drivers. > > "final_mode" variable is already initialized with the value of the > "mode" variable. > > Signed-off-by: Miguel Boton <[EMAIL PROTECTED]> ACK. Or you can do "u32 uninitialized_var

Could you please merge the x86_64 EFI boot support patchset?

2007-11-11 Thread Huang, Ying
Hi, Linus, Could you please merge the following patchset: [PATCH 0/2 -v3] x86_64 EFI boot support [PATCH 1/2 -v3] x86_64 EFI boot support: EFI frame buffer driver [PATCH 2/2 -v3] x86_64 EFI boot support: EFI boot document The patchset has been in -mm tree from 2.6.23-rc2-mm2 on. Andrew Moton had

[PATCH] IA64 efi: make full use of macro efi_md_size

2007-11-11 Thread Li Zefan
Macro efi_md_size is defined in efi.c, and here we apply it throughout efi.c. Signed-off-by: Li Zefan <[EMAIL PROTECTED]> --- arch/ia64/kernel/efi.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/ia64/kernel/efi.c b/arch/ia64/kernel/efi.c index 0e4ef20..73

[rfc][patch] remove nopage

2007-11-11 Thread Nick Piggin
Hi all, This is a patch to remove 'nopage' from the tree. I've gone through all the drivers and converted them to use fault as best I can. When using fault, I've also tried to use vmf->pgoff rather than the virtual address to find the page (which is much preferred). Mostly it has been OK, but DR

Re: [rfc][patch] remove nopage

2007-11-11 Thread Jeff Garzik
Nick Piggin wrote: Index: linux-2.6/sound/oss/via82cxxx_audio.c === --- linux-2.6.orig/sound/oss/via82cxxx_audio.c +++ linux-2.6/sound/oss/via82cxxx_audio.c @@ -2099,8 +2099,7 @@ static void via_dsp_cleanup (struct via_ } -stati

Re: iozone write 50% regression in kernel 2.6.24-rc1

2007-11-11 Thread Zhang, Yanmin
On Fri, 2007-11-09 at 10:54 +0100, Peter Zijlstra wrote: > On Fri, 2007-11-09 at 17:47 +0800, Zhang, Yanmin wrote: > > Comparing with 2.6.23, iozone sequential write/rewrite (512M) has 50% > > regression > > in kernel 2.6.24-rc1. 2.6.24-rc2 has the same regression. > > > > My machine has 8 proces

Re: [PATCH 0/5] introduce K64BIT=y and backward compatibility ARCH={i386,x86_64} for x86

2007-11-11 Thread Roman Zippel
Hi, On Sat, 10 Nov 2007, Sam Ravnborg wrote: > As discussed in another thread the right thing is to add a generic solution > to select between 32 and 64 bit - useable for powerpc, s390, ppc et al. Could you please point me to this discussion? Thanks. bye, Roman - To unsubscribe from this list:

[PATCH] core dump: remain dumpable

2007-11-11 Thread Roland McGrath
The coredump code always calls set_dumpable(0) when it starts (even if RLIMIT_CORE prevents any core from being dumped). The effect of this (via task_dumpable) is to make /proc/pid/* files owned by root instead of the user, so the user can no longer examine his own process--in a case where there

Re: 2.6.24-rc1: pata_amd fails to detect 80-pin wire

2007-11-11 Thread Tejun Heo
Hello, Cable detection has always been broken for pata_amd. Recent changes seem to have broken some other subset tho. The following patchset to get it fixed once and for all is pending. http://thread.gmane.org/gmane.linux.ide/24524 Thanks. -- tejun - To unsubscribe from this list: send the

[PULL] lguest and virtio fixes

2007-11-11 Thread Rusty Russell
The following changes since commit 6e800af233e0bdf108efb7bd23c11ea6fa34cdeb: Jerome Pinot (1): ACPI: add documentation for deprecated /proc/acpi/battery in ACPI_PROCFS are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-virtio.git for

Re: SATA eating my disk, port reset, destroying unrelated data

2007-11-11 Thread Tejun Heo
Robert Hancock wrote: > Norbert Preining wrote: >> ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x40 action 0x2 > > Serror 0x40 means a handshake error. Usually Serror indications are > due to a hardware problem (bad SATA cable, power or drive problem). > >> ata1.00: (BMDMA stat 0x25) >> at

Re: [rfc][patch] remove nopage

2007-11-11 Thread Nick Piggin
On Sun, Nov 11, 2007 at 09:04:29PM -0500, Jeff Garzik wrote: > Nick Piggin wrote: > >Index: linux-2.6/sound/oss/via82cxxx_audio.c > >=== > >--- linux-2.6.orig/sound/oss/via82cxxx_audio.c > >+++ linux-2.6/sound/oss/via82cxxx_audio.c > >

[patch] ia64: Guard elfcorehdr_addr with #if CONFIG_PROC_FS

2007-11-11 Thread Simon Horman
Access to elfcorehdr_addr needs to be guarded by #if CONFIG_PROC_FS as well as the existing #if guards. Fixes the following build problem: arch/ia64/hp/common/built-in.o: In function `sba_init':arch/ia64/hp/common/sba_iommu.c:2043: undefined reference to `elfcorehdr_addr' :arch/ia64/hp/common/sb

[PATCH 2/3] voyager: fix voyager_cat_init section

2007-11-11 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix Voyager section mismatches: voyager_cat_init() should be __init. WARNING: vmlinux.o(.text+0xee83): Section mismatch: reference to .init.data:eprom_buf (between 'voyager_cat_init' and 'aes_enc_blk') WARNING: vmlinux.o(.text+0xeea6): Section mismatch: re

[PATCH 1/3] voyager: use correct header file name

2007-11-11 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix header file name for Voyager build. In file included from arch/x86/kernel/setup_32.c:61: include/asm-x86/mach-voyager/setup_arch.h:2:26: error: asm/setup_32.h: No such file or directory make[1]: *** [arch/x86/kernel/setup_32.o] Error 1 Signed-off-by: R

[PATCH 3/3] voyager: fix smp init sections

2007-11-11 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix Voyager section mismatch due to using __devinit instead of __cpuinit. WARNING: vmlinux.o(.text+0xd943): Section mismatch: reference to .init.text:init_gdt (between 'voyager_smp_prepare_boot_cpu' and 'smp_vic_cmn_interrupt') Signed-off-by: Randy Dunlap

Re: [PATCH 0/5] introduce K64BIT=y and backward compatibility ARCH={i386,x86_64} for x86

2007-11-11 Thread Sam Ravnborg
On Mon, Nov 12, 2007 at 03:47:02AM +0100, Roman Zippel wrote: > Hi, > > On Sat, 10 Nov 2007, Sam Ravnborg wrote: > > > As discussed in another thread the right thing is to add a generic solution > > to select between 32 and 64 bit - useable for powerpc, s390, ppc et al. > > Could you please poin

[RFC/PATCH] Export force_sig_info

2007-11-11 Thread Jeremy Kerr
This change allows force_sig_info to be called from modules. Signed-off-by: Jeremy Kerr <[EMAIL PROTECTED]> -- Any objections to exporting this symbol? I'm planning to move some SPU fault-handling code from the kernel to the spufs.ko object. --- kernel/signal.c |1 + 1 file changed, 1 in

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

2007-11-11 Thread Hugh Dickins
On Fri, 9 Nov 2007, Erez Zadok wrote: > In message <[EMAIL PROTECTED]>, Hugh Dickins writes: > > > > One, I think you would be safer to do a set_page_dirty(lower_page) > > before your clear_page_dirty_for_io(lower_page). I know that sounds > > silly, but see Linus' "Yes, Virginia" comment in clea

Re: cd/dvd inaccessible in 2.6.24-rc2

2007-11-11 Thread Will Trives
Hello, My mistake, it looks like the issue is to do with writing only. Mounting a standard DVD works fine with 2.6.24-rc2-git2. As soon as I try to use wodim or load k3b, that's when drive gets locked up. The issue was still there with 2.6.23-git15 , I will continue to test with previous ones.

the kernel, gcc and libgcc

2007-11-11 Thread Adrian Bunk
[ linux-arch added to the Cc, a copy of my original email is at the bottom ] On Sun, Nov 11, 2007 at 04:34:22PM +0900, Paul Mundt wrote: > On Sun, Nov 11, 2007 at 07:48:29AM +0100, Adrian Bunk wrote: > > But the kernel does (at least on some architectures) not link with > > libgcc or ship other

DMA descriptor alignment

2007-11-11 Thread Larry Finger
For those variants of BCM43xx cards that use 64-bit DMA, there is a requirement that all descriptor rings must be aligned on an 8K boundary and must fit within an 8K page. On the x86_64 architecture where the page size is 4K, I was getting addresses like 0x67AF000 when using dma_alloc_coherent c

Re: [PATCH 4/6] scsi: megaraid_sas - call cmd completion from reset

2007-11-11 Thread Jon Masters
On Fri, 2007-11-09 at 04:35 -0500, bo yang wrote: > Driver will call cmd completion routine from Reset path without waiting for > cmd completion from isr context. Thanks. I'm going to take a look at this, as well as the other recent 2 patches for a couple of test kernels we have that are based o

XFS related Oops

2007-11-11 Thread Tino Keitel
Hi, after resume from suspend with 2.6.23.1, I got the following Oops: BUG: unable to handle kernel paging request at virtual address 3e0d204c printing eip: c022807f *pde = Oops: [#1] SMP Modules linked in: dvb_usb_cinergyT2 i915 drm cpufreq_stats usblp firewire_ohci firewire_core

Re: [PATCH] module: fix and elaborate comments

2007-11-11 Thread Rusty Russell
On Friday 09 November 2007 03:37:38 Matti Linnanvuori wrote: > From: Matti Linnanvuori <[EMAIL PROTECTED]> > > Fix and elaborate comments. Thanks, applied. Rusty. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH] log2.h: Define order_base_2() macro for convenience.

2007-11-11 Thread Robert P. J. Day
On Sun, 11 Nov 2007, Randy Dunlap wrote: > On Sat, 10 Nov 2007 22:53:36 -0500 (EST) Robert P. J. Day wrote: > > > > +/** > > + * order_base_2 - calculate the (rounded up) base 2 order of the argument > > + * @n - parameter > > * @n: argument > > (mostly changing - to :) ah, yes, fix coming shor

[PATCH] log2.h: Define order_base_2() macro for convenience.

2007-11-11 Thread Robert P. J. Day
Given a number of places in the tree that need to calculate this value explicitly, might as well just create a macro for it. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- run-time tested for the first several values. note that this macro is defined strictly in terms of rounding *up

Re: [PATCH 5/6] MN10300: Add the MN10300/AM33 architecture to the kernel [try #5]

2007-11-11 Thread Adrian Bunk
On Sat, Nov 10, 2007 at 11:43:20AM -0800, Andrew Morton wrote: > On Sat, 10 Nov 2007 12:18:50 + David Howells <[EMAIL PROTECTED]> wrote: >... > > has a couple of examples on it's front page. If you work through the menus > > of > > modern Panasonic tellies, you might find a URL pointing somew

Re: [RFC 13/13] Char: nozomi, cleanup read and write

2007-11-11 Thread Adrian Bunk
On Sat, Nov 10, 2007 at 11:04:41PM +0100, Jiri Slaby wrote: > On 11/10/2007 05:15 PM, Adrian Bunk wrote: > > On Fri, Nov 09, 2007 at 06:51:35PM -0500, Jiri Slaby wrote: > >> ... > >> --- a/drivers/char/nozomi.c > >> +++ b/drivers/char/nozomi.c > >> ... > >> - if (size_bytes - i == 2) { > >

Re: [2.6 patch] net/ipv4/ipvs/: remove unused exports

2007-11-11 Thread Adrian Bunk
On Sun, Nov 11, 2007 at 04:09:40PM +0900, Simon Horman wrote: > On Sun, Nov 11, 2007 at 07:48:40AM +0100, Adrian Bunk wrote: > > This patch removes the following unused EXPORT_SYMBOL's: > > - ip_vs_try_bind_dest > > - ip_vs_find_dest > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > Look

<    1   2