Re: [PATCH] x86: Use wrmsrl in kprobes.c, step.c

2008-01-10 Thread H. Peter Anvin
Harvey Harrison wrote: Where x86_32 passed zero in the high 32 bits, use wrmsrl which will zero extend for us. This allows ifdefs for 32/64 bit to be eliminated. Eliminate ifdef in step.c. Similar cleanup was done when unifying kprobes_32|64.c and wrmsr() was chosen there over wrmsrl(). This

Re: [RFC PATCH] greatly reduce SLOB external fragmentation

2008-01-10 Thread Andi Kleen
- huge pages (superpages for those crazy db people) Just a simple linked list of these things is fine, we'd never care about coalescing large pages together anyway. I did essentially that for my GBpages hugetlbfs patchkit. GB pages are already beyond MAX_ORDER and increasing

Re: [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to unlocked_ioctl

2008-01-10 Thread James Bottomley
On Thu, 2008-01-10 at 20:45 +0100, Andre Noll wrote: On 20:29, Andi Kleen wrote: Sure, I can do that if James likes the idea. Since not all case statements need the BKL, we could add it only to those for which it isn't clear that it is unnecessary. And this would actually

Re: [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to unlocked_ioctl

2008-01-10 Thread Boaz Harrosh
On Thu, Jan 10 2008 at 21:45 +0200, Andre Noll [EMAIL PROTECTED] wrote: On 20:29, Andi Kleen wrote: Sure, I can do that if James likes the idea. Since not all case statements need the BKL, we could add it only to those for which it isn't clear that it is unnecessary. And this would

[PATCHv2] x86: Use wrmsrl in kprobes.c, step.c

2008-01-10 Thread Harvey Harrison
Where x86_32 passed zero in the high 32 bits, use wrmsrl which will zero extend for us. This allows ifdefs for 32/64 bit to be eliminated. Eliminate ifdef in step.c. Similar cleanup was done when unifying kprobes_32|64.c and wrmsr() was chosen there over wrmsrl(). This patch changes these to

Re: [RFC PATCH 13/22 -v2] handle accurate time keeping over long delays

2008-01-10 Thread Steven Rostedt
I'm trying to figure out all the ramifications of the new cycle_accumulated field. Does it really need to be John, Before we hardcode these names, can we change them? Later in the series I use something called 'cycle_raw' which really should be called 'cycle_accumulated'. Since

[PATCH] macintosh: fix fabrication of caplock key events

2008-01-10 Thread Andy Wingo
If the user has turned on the restore_caplock_events parameter, the code mangles the capslock events correctly, then erroneously ignores those events. Fix logic to allow correct fallthrough. Signed-off-by: Andy Wingo [EMAIL PROTECTED] --- diff --git a/drivers/macintosh/adbhid.c

Re: CONFIG_NO_HZ breaks blktrace timestamps

2008-01-10 Thread David Dillow
Ingo, Thomas added as I think this is related to sched.c:__update_rq_clock()'s checking for forward time warps. On Wed, 2008-01-09 at 17:48 -0500, David Dillow wrote: While trying to gain some insight into a disk issue, I found that blktrace/blkparse was giving me bogus traces -- I was seeing

Re: [RFC PATCH 13/22 -v2] handle accurate time keeping over long delays

2008-01-10 Thread john stultz
On Thu, 2008-01-10 at 11:54 -0800, Tony Luck wrote: Tony: ia64 also needs something like this, but I found the fsyscall asm bits a little difficult to grasp. So I'll need some assistance on how to include the accumulated cycles into the final calculation. I'm trying to figure out all

Re: [PATCH wireless/arlan] Replace logical- by bit-and

2008-01-10 Thread Randy Dunlap
On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote: Totally untested patch below from linus' git tree. The is incorrect, right? from drivers/net/wireless/arlan.h:390: #define ARLAN_POWER 0x40 #define ARLAN_ACCESS0x80 Replace logical and by bit-and

[x86] list of style offenders

2008-01-10 Thread Daniel Walker
I was playing with checkpatch.pl ;) .. I made a list of style offenders inside the arch/x86/ sub-directory. I thought it might be helpful to prioritize any style clean ups that people might want to do for x86 .. OTOH some of these might show imperfections in checkpatch.pl .. Either way I thought

Re: [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to unlocked_ioctl

2008-01-10 Thread Andre Noll
On 22:13, Boaz Harrosh wrote: All the scsi calls do not need any locks. The scsi LLDS never see these threads since commands are queued through the block layer. That's what everybody believes, but nobody seems to know for sure. Therefore I did what Andi suggested: Make a zero-semantics change

major NFSv4 client regression (-rc7)

2008-01-10 Thread Jeff Garzik
Server: Linux 2.6.24-rc6 (x86-64/Fedora 8) Good client:Linux 2.6.24-rc6-ge697789d (x86-64/Fedora 7) Bad client: Linux 2.6.24-rc7-gfd0b45df (x86-64/Fedora 7) Situation: home dir via NFS My home setup is a standard homedir-over-NFS setup, using NFSv4 on both client and server.

Re: major NFSv4 client regression (-rc7)

2008-01-10 Thread Jeff Garzik
Further data point: Eventually the client degraded into a state when -any- file access on NFS-mounted volume /g would hang. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: major NFSv4 client regression (-rc7)

2008-01-10 Thread Andrew Morton
On Thu, 10 Jan 2008 15:41:19 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: Server: Linux 2.6.24-rc6 (x86-64/Fedora 8) Good client: Linux 2.6.24-rc6-ge697789d (x86-64/Fedora 7) Bad client: Linux 2.6.24-rc7-gfd0b45df (x86-64/Fedora 7) Situation:home dir via NFS My home

RE: [patch 02/11] PAT x86: Map only usable memory in x86_64 identity map and kernel text

2008-01-10 Thread Pallipadi, Venkatesh
-Original Message- From: Andi Kleen [mailto:[EMAIL PROTECTED] Sent: Thursday, January 10, 2008 11:28 AM To: Pallipadi, Venkatesh Cc: Andi Kleen; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED];

Re: major NFSv4 client regression (-rc7)

2008-01-10 Thread Trond Myklebust
On Thu, 2008-01-10 at 15:41 -0500, Jeff Garzik wrote: Server: Linux 2.6.24-rc6 (x86-64/Fedora 8) Good client: Linux 2.6.24-rc6-ge697789d (x86-64/Fedora 7) Bad client: Linux 2.6.24-rc7-gfd0b45df (x86-64/Fedora 7) Situation:home dir via NFS My home setup is a standard

[PATCH] remove task_ppid_nr_ns

2008-01-10 Thread Roland McGrath
task_ppid_nr_ns is called in three places. One of these should never have called it. In the other two, using it broke the existing semantics. This was presumably accidental. If the function had not been there, it would have been much more obvious to the eye that those patches were changing the

RE: [patch 11/11] PAT x86: Expose uc and wc interfaces in /sysfsvor pci_mmap_resource

2008-01-10 Thread Pallipadi, Venkatesh
-Original Message- From: Greg KH [mailto:[EMAIL PROTECTED] Sent: Thursday, January 10, 2008 11:43 AM To: Pallipadi, Venkatesh Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED];

Re: [PATCH] bsg : Add support for io vectors in bsg

2008-01-10 Thread James Bottomley
On Thu, 2008-01-10 at 15:43 -0500, Pete Wyckoff wrote: [EMAIL PROTECTED] wrote on Wed, 09 Jan 2008 09:11 +0900: On Tue, 8 Jan 2008 17:09:18 -0500 Pete Wyckoff [EMAIL PROTECTED] wrote: I took another look at the compat approach, to see if it is feasible to keep the compat handling

Re: [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl

2008-01-10 Thread Alan Cox
On Thu, 10 Jan 2008 16:01:44 +0100 (CET) Jiri Kosina [EMAIL PROTECTED] wrote: On Wed, 9 Jan 2008, Alan Cox wrote: default: printk(%s: Unimplemented ioctl 0x%x\n, tape-name, cmd); + unlock_kernel(); return -EINVAL;

Re: [PATCH wireless/arlan] Replace logical- by bit-and

2008-01-10 Thread Chuck Ebbert
On 01/10/2008 03:28 PM, Randy Dunlap wrote: On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote: Totally untested patch below from linus' git tree. The is incorrect, right? from drivers/net/wireless/arlan.h:390: #define ARLAN_POWER 0x40 #define ARLAN_ACCESS0x80

Re: [PATCH][RFC][BUG] updating the ctime and mtime time stamps in msync()

2008-01-10 Thread Valdis . Kletnieks
On Wed, 09 Jan 2008 18:41:41 EST, Rik van Riel said: I guess a third possible time (if we want to minimize the number of updates) would be when natural syncing of the file data to disk, by other things in the VM, would be about to clear the I_DIRTY_PAGES flag on the inode. That way we do not

RE: [patch 07/11] PAT x86: pat-conflict resolution using linear list

2008-01-10 Thread Pallipadi, Venkatesh
-Original Message- From: Andi Kleen [mailto:[EMAIL PROTECTED] Sent: Thursday, January 10, 2008 11:13 AM To: Pallipadi, Venkatesh Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED];

Re: [PATCH] bsg : Add support for io vectors in bsg

2008-01-10 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Wed, 09 Jan 2008 09:11 +0900: On Tue, 8 Jan 2008 17:09:18 -0500 Pete Wyckoff [EMAIL PROTECTED] wrote: I took another look at the compat approach, to see if it is feasible to keep the compat handling somewhere else, without the use of #ifdef CONFIG_COMPAT and

Re: [PATCH] serial: speed setup failure reporting

2008-01-10 Thread Alan Cox
It only causes a problem if you set a completely bogus baud rate (out of range) and that baud rate was not a standard one and you were using the new tty ioctls - so its fairly low priority 8) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [RFC PATCH 13/22 -v2] handle accurate time keeping over long delays

2008-01-10 Thread Mathieu Desnoyers
* john stultz ([EMAIL PROTECTED]) wrote: On Thu, 2008-01-10 at 11:54 -0800, Tony Luck wrote: Tony: ia64 also needs something like this, but I found the fsyscall asm bits a little difficult to grasp. So I'll need some assistance on how to include the accumulated cycles into the final

Re: [RFC PATCH 13/22 -v2] handle accurate time keeping over long delays

2008-01-10 Thread john stultz
On Thu, 2008-01-10 at 15:15 -0500, Steven Rostedt wrote: I'm trying to figure out all the ramifications of the new cycle_accumulated field. Does it really need to be John, Before we hardcode these names, can we change them? Later in the series I use something called 'cycle_raw' which

Re: LRW/XTS + Via Padlock Bug in 2.6.24-rc7?

2008-01-10 Thread Herbert Xu
Torben Viets [EMAIL PROTECTED] wrote: After rebuilding the kernel, I tried: cryptsetup -c aes-xts-plain -s 256 luksFormat /dev/raid/test It does the same as before, dmesg says: general protection fault: [#1] Modules linked in: xt_TCPMSS xt_tcpmss iptable_mangle ipt_MASQUERADE

Re: [PATCH] [Coding Style]: fs/ext{3,4}/ext{3,4}_jbd{,2}.c

2008-01-10 Thread Roel Kluin
Al Viro wrote: __func__ is C99, but it's not what __FUNCTION__ used to be - it's not a string literal. 6.4.2.2(1): The identifier __func__ shall be implicitly declared by the translator as if, immediately following the opening brace of each function definition, the declaration

Re: major NFSv4 client regression (-rc7)

2008-01-10 Thread Jeff Garzik
Trond Myklebust wrote: This looks as if it might be the same issue that was reported as bug 9712 in bugzilla (http://bugzilla.kernel.org/show_bug.cgi?id=9712). The fix is attached. Please could you confirm that it fixes the hang? Indeed, it looks fixed here, thanks... Jeff (now

NFSv4: Give the lock stateid its own sequence queue

2008-01-10 Thread Trond Myklebust
Sharing the open sequence queue causes a deadlock when we try to take both a lock sequence id and and open sequence id. This fixes the regression reported by Dimitri Puzin and Jeff Garzik: See http://bugzilla.kernel.org/show_bug.cgi?id=9712 Signed-off-by: Trond Myklebust [EMAIL PROTECTED] ---

Re: Fwd: Fwd: laptop / computer hardlocks during execution of 32bit applications(binaries) on 64bit system (Gentoo)

2008-01-10 Thread Matthew
If you *do* reproduce the problem that way, it would be extremely helpful if you could enable CONFIG_DEBUG_INFO and provide the vmlinux (not vmlinuz/bzImage) file that goes with the crash dump screenshot. I *did* reproduce it that way and enabled the above mentioned option and the

Re: [patch 02/11] PAT x86: Map only usable memory in x86_64 identity map and kernel text

2008-01-10 Thread Linus Torvalds
On Thu, 10 Jan 2008, [EMAIL PROTECTED] wrote: x86_64: Map only usable memory in identity map. All reserved memory maps to a zero page. I don't mind this horribly per se, but why a zero page? Accessing that page without mapping it explicitly would be a bug with your change - if only because

Re: r8169 and out of space

2008-01-10 Thread Francois Romieu
Alistair John Strachan [EMAIL PROTECTED] : [..] No, we have not diagnosed the cause of the problem, beyond the swiotlb usage. I'm adding the r8169 maintainer, linux-net and linux-kernel to CC, to pass on your information, I hope you don't mind. swiotlb fragmentation perhaps ? Switching the

Re: [patch 02/11] PAT x86: Map only usable memory in x86_64 identity map and kernel text

2008-01-10 Thread Andi Kleen
I think it is unsafe to access any reserved areas through WB not just mmio regions. In the above case 0xe000-0xf000 is one such region. That is 2MB aligned. Also, relying on MTRR, is like giving more importance to BIOS writer Let's call it double checking. Besides MTRRs will not

Re: Fwd: Fwd: laptop / computer hardlocks during execution of 32bit applications(binaries) on 64bit system (Gentoo)

2008-01-10 Thread H. Peter Anvin
Matthew wrote: If you *do* reproduce the problem that way, it would be extremely helpful if you could enable CONFIG_DEBUG_INFO and provide the vmlinux (not vmlinuz/bzImage) file that goes with the crash dump screenshot. I *did* reproduce it that way and enabled the above mentioned option and

Re: [PATCH wireless/arlan] Replace logical- by bit-and

2008-01-10 Thread Randy Dunlap
Chuck Ebbert wrote: On 01/10/2008 03:28 PM, Randy Dunlap wrote: 0x80 0x40 - 0 1 duh. ack. -- ~Randy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 13/22 -v2] handle accurate time keeping over long delays

2008-01-10 Thread john stultz
On Thu, 2008-01-10 at 15:42 -0500, Mathieu Desnoyers wrote: I think it's about time I introduce the approach I have taken for LTTng timestamping. Basically, one of the main issues with the clock sources is the xtime lock : having a read seqlock nested over a write seqlock is a really, really

Re: NFSv4: Give the lock stateid its own sequence queue

2008-01-10 Thread Jeff Garzik
Trond Myklebust wrote: Sharing the open sequence queue causes a deadlock when we try to take both a lock sequence id and and open sequence id. This fixes the regression reported by Dimitri Puzin and Jeff Garzik: See http://bugzilla.kernel.org/show_bug.cgi?id=9712 Signed-off-by: Trond Myklebust

Re: questions on NAPI processing latency and dropped network packets

2008-01-10 Thread Chris Friesen
James Chapman wrote: What's changed in your application? Any real-time threads in there? From the top output below, looks like SigtranServices is consuming all your CPU... There are two cpus, and SigtranServices is multithreaded with many threads. Most of these threads are affined to

Re: [RFC PATCH] greatly reduce SLOB external fragmentation

2008-01-10 Thread Jörn Engel
On Thu, 10 January 2008 11:49:25 -0600, Matt Mackall wrote: b) grouping objects of the same -type- (not size) together should mean they have similar lifetimes and thereby keep fragmentation low (b) is known to be false, you just have to look at our dcache and icache pinning. (b) is

RE: [RFC PATCH 13/22 -v2] handle accurate time keeping over longdelays

2008-01-10 Thread Luck, Tony
If you noticed in my email, the fix for ppc was a bit easier, as it has only a 64bit counter that is quite unlikely to wrap twice between calls to update_wall_time(). quite unlikely ... Hmmm just how fast are you driving the clocks on your ppc? Even at 100GHz It is almost SIX YEARS between

Re: [PATCH 2/3] ptrace_stop: remove the wrong -group_stop_count bookkeeping

2008-01-10 Thread Oleg Nesterov
On 01/10, Petr Tesarik wrote: I can actually see a bug which may be related: 1. a process creates a thread (or more threads) 2. I attach/detach to that thread with strace several times (each time pressing CTRL-C to quit strace) 3. the whole thread group (except the traced thread)

Re: [PATCH] bsg : Add support for io vectors in bsg

2008-01-10 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Thu, 10 Jan 2008 14:55 -0600: On Thu, 2008-01-10 at 15:43 -0500, Pete Wyckoff wrote: [EMAIL PROTECTED] wrote on Wed, 09 Jan 2008 09:11 +0900: On Tue, 8 Jan 2008 17:09:18 -0500 Pete Wyckoff [EMAIL PROTECTED] wrote: I took another look at the compat approach,

Re: [RFC][PATCH 0/4] kill open files traverse on remount ro

2008-01-10 Thread Serge E. Hallyn
Quoting Dave Hansen ([EMAIL PROTECTED]): This is just RFC for now. I'm tracking down a wee bit of list corruption. But, I wanted to send out so you could compare to the last approach. Looks reasonable to me, and quite readable. So after this set, you'd be able to remove s_files altogether?

Re: r8169 and out of space

2008-01-10 Thread Nathan Grennan
Francois Romieu wrote: Alistair John Strachan [EMAIL PROTECTED] : [..] No, we have not diagnosed the cause of the problem, beyond the swiotlb usage. I'm adding the r8169 maintainer, linux-net and linux-kernel to CC, to pass on your information, I hope you don't mind. swiotlb

Re: [PATCH wireless/arlan] Replace logical- by bit-and

2008-01-10 Thread John W. Linville
On Thu, Jan 10, 2008 at 01:16:33PM -0800, Randy Dunlap wrote: Chuck Ebbert wrote: On 01/10/2008 03:28 PM, Randy Dunlap wrote: 0x80 0x40 - 0 1 duh. ack. Well it still seems wrong, changing from an | 1 to an | 0. Anyone still using Arlan that can verify the proper fix (which I'd guess is

Re: Fwd: Fwd: laptop / computer hardlocks during execution of 32bit applications(binaries) on 64bit system (Gentoo)

2008-01-10 Thread Matthew
Do you have the error dump output to go along with this, too? no, unfortunately no kernel crash dump on disk ;( (I hope I understood it right, I'm pretty noobish concerning collection of error data ;) ) I only have the console-output of the hardlock in:

Re: [PATCH] bsg : Add support for io vectors in bsg

2008-01-10 Thread James Bottomley
On Thu, 2008-01-10 at 16:46 -0500, Pete Wyckoff wrote: [EMAIL PROTECTED] wrote on Thu, 10 Jan 2008 14:55 -0600: On Thu, 2008-01-10 at 15:43 -0500, Pete Wyckoff wrote: [EMAIL PROTECTED] wrote on Wed, 09 Jan 2008 09:11 +0900: On Tue, 8 Jan 2008 17:09:18 -0500 Pete Wyckoff [EMAIL

Re: [PATCH] Re: Forcing modes in libata

2008-01-10 Thread Jeff Garzik
FD Cami wrote: Revised patch attached. Best, François applied. please include signed-off-by lines in the future... -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

RE: [patch 02/11] PAT x86: Map only usable memory in x86_64 identity map and kernel text

2008-01-10 Thread Pallipadi, Venkatesh
-Original Message- From: Linus Torvalds [mailto:[EMAIL PROTECTED] Sent: Thursday, January 10, 2008 1:05 PM To: Pallipadi, Venkatesh Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL

Re: Fwd: Fwd: laptop / computer hardlocks during execution of 32bit applications(binaries) on 64bit system (Gentoo)

2008-01-10 Thread H. Peter Anvin
Matthew wrote: Do you have the error dump output to go along with this, too? no, unfortunately no kernel crash dump on disk ;( (I hope I understood it right, I'm pretty noobish concerning collection of error data ;) ) I only have the console-output of the hardlock in:

Re: 2.6.24-rc7, intel audio: alsa doesn't say a beep

2008-01-10 Thread Harald Dunkel
Takashi Iwai wrote: Hm... Just to be sure, try the patch below. It's a clean up patch that I'd like to apply later. Sorry, no sound. The perex/alsa.git mm branch on kernel.org has many fixes. Could you give it a try, too? This version seems to work. But AFAICS it just reverts

[PATCH 00/16] udf: cleanup

2008-01-10 Thread marcin . slusarz
Hi This patchset contains various UDF fs cleanups. It deprecates two patchsets I sent lately: http://lkml.org/lkml/2008/1/5/196 [PATCH 0/6] udf: improve code related to super_block v3 http://lkml.org/lkml/2008/1/5/211 [PATCH 0/7] udf: more cleanups I hope I addressed all comments sent by

Re: [RFC PATCH 13/22 -v2] handle accurate time keeping over long delays

2008-01-10 Thread Mathieu Desnoyers
* john stultz ([EMAIL PROTECTED]) wrote: On Thu, 2008-01-10 at 15:42 -0500, Mathieu Desnoyers wrote: I think it's about time I introduce the approach I have taken for LTTng timestamping. Basically, one of the main issues with the clock sources is the xtime lock : having a read seqlock

[PATCH 01/16] udf: fix coding style of super.c

2008-01-10 Thread marcin . slusarz
fix coding style errors found by checkpatch: - assignments in if conditions - braces {} around single statement blocks - no spaces after commas - printks without KERN_* - lines longer than 80 characters before: total: 50 errors, 207 warnings, 1835 lines checked after: total: 0 errors, 164

[PATCH 03/16] udf: convert UDF_SB_ALLOC_PARTMAPS macro to udf_sb_alloc_partition_maps function

2008-01-10 Thread marcin . slusarz
- convert UDF_SB_ALLOC_PARTMAPS macro to udf_sb_alloc_partition_maps function - convert kmalloc + memset to kcalloc - check if kcalloc failed (partially) Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Ben Fennema [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] Acked-by: Christoph Hellwig

[PATCH 04/16] udf: check if udf_load_logicalvol failed

2008-01-10 Thread marcin . slusarz
udf_load_logicalvol may fail eg in out of memory conditions - check it and propagate error further Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Ben Fennema [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] CC: Christoph Hellwig [EMAIL PROTECTED] --- fs/udf/super.c |5 - 1 files

[PATCH 05/16] udf: convert macros related to bitmaps to functions

2008-01-10 Thread marcin . slusarz
convert UDF_SB_ALLOC_BITMAP macro to udf_sb_alloc_bitmap function convert UDF_SB_FREE_BITMAP macro to udf_sb_free_bitmap function Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Ben Fennema [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] CC: Christoph Hellwig [EMAIL PROTECTED] ---

[PATCH 06/16] udf: move calculating of nr_groups into helper function

2008-01-10 Thread marcin . slusarz
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Ben Fennema [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] CC: Christoph Hellwig [EMAIL PROTECTED] --- fs/udf/balloc.c |4 +--- fs/udf/super.c | 16 ++-- fs/udf/udf_sb.h |2 ++ 3 files changed, 13 insertions(+), 9

[PATCH 07/16] udf: fix sparse warnings (shadowing mismatch between declaration and definition)

2008-01-10 Thread marcin . slusarz
fix sparse warnings: fs/udf/super.c:1431:24: warning: symbol 'bh' shadows an earlier one fs/udf/super.c:1347:21: originally declared here fs/udf/super.c:472:6: warning: symbol 'udf_write_super' was not declared. Should it be static? Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Ben Fennema

[PATCH 08/16] udf: fix coding style

2008-01-10 Thread marcin . slusarz
fix coding style errors found by checkpatch: - assignments in if conditions - braces {} around single statement blocks - no spaces after commas - printks without KERN_* - lines longer than 80 characters - spaces between type * and variable name before: 192 errors, 561 warnings, 8987 lines checked

[PATCH 09/16] udf: create common function for tag checksumming

2008-01-10 Thread marcin . slusarz
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] CC: Christoph Hellwig [EMAIL PROTECTED] --- fs/udf/inode.c | 15 ++- fs/udf/misc.c| 35 ++- fs/udf/namei.c |9 + fs/udf/super.c | 16

[PATCH 10/16] udf: create common function for changing free space counter

2008-01-10 Thread marcin . slusarz
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] CC: Christoph Hellwig [EMAIL PROTECTED] --- fs/udf/balloc.c | 49 - 1 files changed, 20 insertions(+), 29 deletions(-) diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c

[PATCH 11/16] udf: replace loops coded with goto to real loops

2008-01-10 Thread marcin . slusarz
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] CC: Christoph Hellwig [EMAIL PROTECTED] --- fs/udf/balloc.c | 118 +++--- 1 files changed, 59 insertions(+), 59 deletions(-) diff --git a/fs/udf/balloc.c

[PATCH 12/16] udf: convert byte order of constant instead of variable

2008-01-10 Thread marcin . slusarz
convert byte order of constant instead of variable, which can be done at compile time (vs run time) Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] Acked-by: Jan Kara [EMAIL PROTECTED] --- fs/udf/directory.c |4 ++-- fs/udf/inode.c | 16 fs/udf/misc.c | 12

[PATCH 15/16] udf: fix udf_debug macro

2008-01-10 Thread marcin . slusarz
udf_debug should be enclosed with do { } while (0) to be safely used in code like below: if (something) udf_debug(); else anything; (Otherwise compiler will not compile it with: error: expected expression before 'else') Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Jan Kara

[PATCH 16/16] udf: improve readability of udf_load_partition

2008-01-10 Thread marcin . slusarz
Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] CC: Christoph Hellwig [EMAIL PROTECTED] --- fs/udf/super.c | 59 --- 1 files changed, 30 insertions(+), 29 deletions(-) diff --git a/fs/udf/super.c

[git patches] IDE fixes

2008-01-10 Thread Bartlomiej Zolnierkiewicz
Hopefully the final IDE update for 2.6.24. Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/bart/ide-2.6.git/ to receive the following updates: drivers/ide/ide-acpi.c | 36 +++- drivers/ide/ide-iops.c |6 +++--- drivers/ide/pci/trm290.c

RE: [patch 02/11] PAT x86: Map only usable memory in x86_64 identity map and kernel text

2008-01-10 Thread Linus Torvalds
On Thu, 10 Jan 2008, Pallipadi, Venkatesh wrote: Yes. I had those pages not mapped at all earlier. The reason I switched to zero page is to continue support cases like: BIOS-e820: - 0009cc00 (usable) BIOS-e820: 0009cc00 - 000a (reserved)

Re: [PATCH wireless/arlan] Replace logical- by bit-and

2008-01-10 Thread Roel Kluin
Randy Dunlap wrote: On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote: diff --git a/drivers/net/wireless/arlan.h b/drivers/net/wireless/arlan.h index 3ed1df7..7b7498f 100644 --- a/drivers/net/wireless/arlan.h +++ b/drivers/net/wireless/arlan.h @@ -485,7 +485,7 @@ struct arlan_private {

Re: [PATCH] libata and starting/stopping ATAPI floppy devices

2008-01-10 Thread Jeff Garzik
Tejun Heo wrote: From: Ondrej Zary [EMAIL PROTECTED] Prevent libata from starting/stopping non-ATA devices (like ATAPI floppy drives) as they don't seem to like it: sd 1:0:1:0: [sdb] Starting disk ata2.01: configured for PIO2 sd 1:0:1:0: [sdb] Result: hostbyte=0x00 driverbyte=0x08 sd

RE: [patch 02/11] PAT x86: Map only usable memory in x86_64 identity map and kernel text

2008-01-10 Thread Pallipadi, Venkatesh
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Andi Kleen Sent: Thursday, January 10, 2008 1:17 PM To: Pallipadi, Venkatesh Cc: Andi Kleen; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL

RE: [patch 02/11] PAT x86: Map only usable memory in x86_64 identity map and kernel text

2008-01-10 Thread Pallipadi, Venkatesh
-Original Message- From: Linus Torvalds [mailto:[EMAIL PROTECTED] Sent: Thursday, January 10, 2008 2:15 PM To: Pallipadi, Venkatesh Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL

Re: Fwd: Fwd: laptop / computer hardlocks during execution of 32bit applications(binaries) on 64bit system (Gentoo)

2008-01-10 Thread Matthew
That's fine, but that was collected with the vmlinux image you sent me, right? no, but now it is: http://kerneloftruth.neucode.org/other/crash_ia32_64/not_tainted/latest/ (the other one was taken before I added/selected the demanded features) what puzzles me is that it doesn't say tainted

Re: Fwd: Fwd: laptop / computer hardlocks during execution of 32bit applications(binaries) on 64bit system (Gentoo)

2008-01-10 Thread H. Peter Anvin
Matthew wrote: That's fine, but that was collected with the vmlinux image you sent me, right? no, but now it is: http://kerneloftruth.neucode.org/other/crash_ia32_64/not_tainted/latest/ (the other one was taken before I added/selected the demanded features) what puzzles me is that it doesn't

Re: [patch 02/11] PAT x86: Map only usable memory in x86_64 identity map and kernel text

2008-01-10 Thread Andi Kleen
On Thu, Jan 10, 2008 at 02:25:29PM -0800, Pallipadi, Venkatesh wrote: -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Andi Kleen Sent: Thursday, January 10, 2008 1:17 PM To: Pallipadi, Venkatesh Cc: Andi Kleen; [EMAIL PROTECTED]; [EMAIL

Re: [PATCH] bsg : Add support for io vectors in bsg

2008-01-10 Thread Mark Rustad
On Jan 10, 2008, at 3:46 PM, Pete Wyckoff wrote: I'm fine with read/write, except Tomo is against handling iovecs because of the compat complexity with struct iovec being different on 32- vs 64-bit. There is a standard way to do compat ioctl that hides this handling in a different file (not

[PATCH] tpm: infineon section mismatch

2008-01-10 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix section mismatch by making the driver template variable name match one of the whitelisted variable names in modpost. WARNING: vmlinux.o(.data+0x7a9e8): Section mismatch: reference to .init.text:tpm_inf_pnp_probe (between 'tpm_inf_pnp' and 'cn_idx')

[PATCH] dvb/av7110: fix section mismatch

2008-01-10 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix driver data name to match whitelist of acceptable names that contain pointers init data so that section mismatch warning is placated. WARNING: vmlinux.o(.data+0x141288): Section mismatch: reference to .init.text:av7110_attach (between 'av7110_extension'

[PATCH] x86: discover_ebda section mismatch

2008-01-10 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix section mismatches. discover_ebda() can be __init. WARNING: vmlinux.o(.text+0x738a): Section mismatch: reference to .init.data:ebda_addr (between 'discover_ebda' and 'get_model_name') WARNING: vmlinux.o(.text+0x73c4): Section mismatch: reference to

Re: [x86] list of style offenders

2008-01-10 Thread Paolo Ciarrocchi
On Jan 10, 2008 9:03 PM, Daniel Walker [EMAIL PROTECTED] wrote: I was playing with checkpatch.pl ;) .. I made a list of style offenders inside the arch/x86/ sub-directory. I thought it might be helpful to prioritize any style clean ups that people might want to do for x86 .. OTOH some of

Re: AF_UNIX MSG_PEEK bug?

2008-01-10 Thread Brent Casavant
Here's what I think is a better patch. Or maybe just simpler. However, I'm still unsure what the effect of this patch on file descriptor passing might be. Reading the prior code, and the parallel portions/comments in unix_dgram_recvmsg(), it looks like there's been a lot of uncertainty as to

Re: AF_UNIX MSG_PEEK bug?

2008-01-10 Thread Alan Cox
and the parallel portions/comments in unix_dgram_recvmsg(), it looks like there's been a lot of uncertainty as to how file descriptor passing should be handled durning MSG_PEEK operations. To quote: The specs basically don't answer the question. What is critical is that the behaviour does

Re: [RFC PATCH 13/22 -v2] handle accurate time keeping over long delays

2008-01-10 Thread Steven Rostedt
On Thu, 10 Jan 2008, Mathieu Desnoyers wrote: Am I only partially crazy ? ;) Not at all, you should just do some more shopping! -- Steve -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [x86] list of style offenders

2008-01-10 Thread Daniel Walker
On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote: On Jan 10, 2008 9:03 PM, Daniel Walker [EMAIL PROTECTED] wrote: I was playing with checkpatch.pl ;) .. I made a list of style offenders inside the arch/x86/ sub-directory. I thought it might be helpful to prioritize any style

[git patches] libata fixes

2008-01-10 Thread Jeff Garzik
Still working through the backlog, but this is most of the immediate libata stuff. I asked DaveM to help out with netdev fixes, so there shouldn't be much of a 2.6.24-rc backlog at all there (thanks again David). Please pull from 'upstream-linus' branch of

Re: CONFIG_NO_HZ breaks blktrace timestamps

2008-01-10 Thread Guillaume Chazarain
David Dillow [EMAIL PROTECTED] wrote: At the moment, I'm not sure how to track this farther, or how to fix it properly. Any advice would be appreciated. Just out of curiosity, could you try the appended cumulative patch and report .clock_warps, .clock_overflows and .clock_underflows as you

Re: [x86] list of style offenders

2008-01-10 Thread Paolo Ciarrocchi
On Jan 10, 2008 11:41 PM, Daniel Walker [EMAIL PROTECTED] wrote: On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote: On Jan 10, 2008 9:03 PM, Daniel Walker [EMAIL PROTECTED] wrote: I was playing with checkpatch.pl ;) .. I made a list of style offenders inside the arch/x86/

Re: [x86] list of style offenders

2008-01-10 Thread Daniel Walker
On Thu, 2008-01-10 at 23:47 +0100, Paolo Ciarrocchi wrote: On Jan 10, 2008 11:41 PM, Daniel Walker [EMAIL PROTECTED] wrote: On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote: On Jan 10, 2008 9:03 PM, Daniel Walker [EMAIL PROTECTED] wrote: I was playing with

Re: [RFC PATCH 13/22 -v2] handle accurate time keeping over long delays

2008-01-10 Thread john stultz
On Thu, 2008-01-10 at 17:00 -0500, Mathieu Desnoyers wrote: * john stultz ([EMAIL PROTECTED]) wrote: On Thu, 2008-01-10 at 15:42 -0500, Mathieu Desnoyers wrote: I think it's about time I introduce the approach I have taken for LTTng timestamping. Basically, one of the main issues with

Re: [patch 02/11] PAT x86: Map only usable memory in x86_64 identity map and kernel text

2008-01-10 Thread Valdis . Kletnieks
On Thu, 10 Jan 2008 14:15:25 PST, Linus Torvalds said: Well, I think that /dev/mem should simply give them the right info. That's what people use /dev/mem for - doing things like reading BIOS images etc. So returning *either* a zero page *or* stopping at the first hole is both equally

Re: Fwd: Fwd: laptop / computer hardlocks during execution of 32bit applications(binaries) on 64bit system (Gentoo)

2008-01-10 Thread Matthew
I just managed to reproduce the bug in simulation. I believe we should be able to resolve this. That's great news! Keep up the good work :) I hope that you guys'll be able to do so since it (indirectly) more or less leads to data corruption (at least with thunderbird-bin firefox-bin - both

Re: [JANITOR PROPOSAL] Switch ioctl functions to -unlocked_ioctl

2008-01-10 Thread Daniel Phillips
On Thursday 10 January 2008 03:39, Alasdair G Kergon wrote: On Thu, Jan 10, 2008 at 01:49:15AM -0800, Daniel Phillips wrote: So what stops you from changing to unlocked_ioctl for the main device mapper ctl_ioctl? Nothing - patches to do this are queued for 2.6.25: Nice. This removes a

[PATCH] x86: codying style fixes in ./arch/x86/math-emu/

2008-01-10 Thread Paolo Ciarrocchi
Fix some codying style errors in ./arch/x86/math-emu/reg_ld_str.c total: 4 errors, 31 warnings, 1223 lines checked patch is against a x86 which I pulled a few minutes ago. Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED] --- arch/x86/math-emu/reg_ld_str.c | 25 - 1

Re: [PATCH][RFC] fast file mapping for loop

2008-01-10 Thread Neil Brown
On Thursday January 10, [EMAIL PROTECTED] wrote: On Thu, Jan 10 2008, Chris Mason wrote: On Thu, 10 Jan 2008 09:31:31 +0100 Jens Axboe [EMAIL PROTECTED] wrote: On Wed, Jan 09 2008, Alasdair G Kergon wrote: Here's the latest version of dm-loop, for comparison. To try it out,

Re: [RFC PATCH 01/22 -v2] Add basic support for gcc profiler instrumentation

2008-01-10 Thread Steven Rostedt
On Thu, 10 Jan 2008, Jan Kiszka wrote: === --- /dev/null 1970-01-01 00:00:00.0 + +++ linux-compile-i386.git/arch/x86/kernel/mcount-wrapper.S 2008-01-09 14:10:07.0 -0500 @@ -0,0 +1,25 @@ +/* + *

Re: [PATCH 04/16] udf: check if udf_load_logicalvol failed

2008-01-10 Thread Jan Kara
On Thu 10-01-08 23:06:20, [EMAIL PROTECTED] wrote: udf_load_logicalvol may fail eg in out of memory conditions - check it and propagate error further Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Ben Fennema [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] CC: Christoph Hellwig

Re: [x86] list of style offenders

2008-01-10 Thread Daniel Walker
On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote: On Jan 10, 2008 9:03 PM, Daniel Walker [EMAIL PROTECTED] wrote: I was playing with checkpatch.pl ;) .. I made a list of style offenders inside the arch/x86/ sub-directory. I thought it might be helpful to prioritize any style

<    1   2   3   4   5   6   7   8   9   10   >