[PATCH 0/3 v2] Trivial code clean for procfs

2012-09-05 Thread yan
Changed from v1 : Add detailed changelog (suggested by Andrew Morton) yan (3): proc: return -ENOMEM when inode allocation failed proc: no need to initialize proc_inode->fd in proc_get_inode proc: use kzalloc instead of kmalloc and memset fs/proc/generic.c |5 ++--- fs/proc/inod

[PATCH 1/3 v2] proc: return -ENOMEM when inode allocation failed

2012-09-05 Thread yan
If proc_get_inode() returns NULL then presumably it encountered memory exhaustion. proc_lookup_de() should return -ENOMEM in this case, not -EINVAL. Signed-off-by: yan --- fs/proc/generic.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/generic.c b/fs/proc/gener

[PATCH 3/3 v2] proc: use kzalloc instead of kmalloc and memset

2012-09-05 Thread yan
Part of the memory will be written twice after this change, but that should be negligible. Signed-off-by: yan --- fs/proc/generic.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/proc/generic.c b/fs/proc/generic.c index 9e8f631..38de015 100644 --- a/fs/proc/generic.

[PATCH 2/3 v2] proc : no need to initialize proc_inode->fd in proc_get_inode

2012-09-05 Thread yan
proc_get_inode() obtains the inode via a call to iget_locked(). iget_locked() calls alloc_inode() which will call proc_alloc_inode() which clears proc_inode.fd, so there is no need to clear this field in proc_get_inode(). If iget_locked() instead found the inode via find_inode_fast(), that inode w

Re: [PATCH] Chinese translation of Documentation/gpio.txt

2012-09-05 Thread Dong Aisheng
Hi Wei, On Tue, Aug 28, 2012 at 10:03:13PM +0800, Ninja Tekkaman wrote: > This is a Chinese translated version of Documentation/gpio.txt > > Signed-off-by: Fu Wei > --- > Documentation/zh_CN/gpio.txt | 662 > ++ > 1 file changed, 662 insertions(+) > cr

[patch] da9052-battery: don't free IRQ that wasn't requested

2012-09-05 Thread Dan Carpenter
We should decrement "i" before doing the free_irq(). If we call this because request_threaded_irq() failed then we don't want to free the thing which failed. Or in the case where we get here because power_supply_register() failed then the original codes does a read past the end of the array. Sig

Re: [tip:sched/core] sched: Fix load avg vs cpu-hotplug

2012-09-05 Thread Peter Zijlstra
On Tue, 2012-09-04 at 11:43 -0700, tip-bot for Peter Zijlstra wrote: > Commit-ID: f319da0c6894fcf55e21320e40506418a2aad629 > Gitweb: http://git.kernel.org/tip/f319da0c6894fcf55e21320e40506418a2aad629 > Author: Peter Zijlstra > AuthorDate: Mon, 20 Aug 2012 11:26:57 +0200 > Committer: Ingo

Re: [Drbd-dev] [PATCH] drbd: use list_move_tail instead of list_del/list_add_tail

2012-09-05 Thread Philipp Reisner
Thanks, applied. Best regards, Phil > From: Wei Yongjun > > Using list_move_tail() instead of list_del() + list_add_tail(). > > spatch with a semantic match is used to found this problem. > (http://coccinelle.lip6.fr/) > > Signed-off-by: Wei Yongjun > --- > drivers/block/drbd/drbd_worker.c

Re: [st-ericsson] [PATCH 15/17] mfd: dbx540-prcmu creation

2012-09-05 Thread Linus Walleij
On Wed, Sep 5, 2012 at 2:10 PM, Arnd Bergmann wrote: > On Wednesday 05 September 2012, Loic Pallardy wrote: >> >> Signed-off-by: Loic Pallardy >> Acked-by: Linus Walleij > > This makes me doubt the quality of Linus' Ack on other patches... Basically the rationale is that to me the driver looks

Re: [st-ericsson] [PATCH 02/17] arm: ux500: add ccu9540 board support

2012-09-05 Thread Linus Walleij
On Wed, Sep 5, 2012 at 2:11 PM, Arnd Bergmann wrote: > On Wednesday 05 September 2012, Loic PALLARDY wrote: >> >> On 09/05/2012 12:42 PM, Arnd Bergmann wrote: >> > On Wednesday 05 September 2012, Loic Pallardy wrote: >> >> +MACHINE_START(U9540, "ST-Ericsson 9540 platform") >> >> + .atag_offs

Re: [PATCH 1/2] mm: change enum migrate_mode with bitwise type

2012-09-05 Thread Michal Nazarewicz
On Wed, Sep 05 2012, Minchan Kim wrote: > This patch changes migrate_mode type to bitwise type because > next patch will add MIGRATE_DISCARD and it could be ORed with other > attributes so it would be better to change it with bitwise type. > > Cc: Rik van Riel > Cc: Mel Gorman > Suggested-by: Mic

Re: [PATCH V3 3/4] PCI: Add support for non-BAR ROMs

2012-09-05 Thread Alan Cox
On Wed, 5 Sep 2012 03:29:32 +0100 Matthew Garrett wrote: > On Tue, Sep 04, 2012 at 10:18:48PM -0400, Don Dutile wrote: > > > /* > > >+ * Some devices may provide ROMs via a source other than the BAR > > >+ */ > > >+ if (pdev->rom&& pdev->romlen) { > > >+ *size = pdev->romlen; > >

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-05 Thread Michal Nazarewicz
On Wed, Sep 05 2012, Minchan Kim wrote: > This patch introudes MIGRATE_DISCARD mode in migration. > It drops *clean cache pages* instead of migration so that > migration latency could be reduced by avoiding (memcpy + page remapping). > It's useful for CMA because latency of migration is very import

Re: [Patch 0/1]drm_irq: Introducing the irq_thread support

2012-09-05 Thread Alan Cox
On Wed, 5 Sep 2012 01:53:44 + "Liu, Chuansheng" wrote: > This patch is for introducing the irq thread support in drm_irq. > > Why we need irq thread in drm_irq code? > In our GPU system, the gpu interrupt handler need some time even > 1ms to > finish, > in that case, the whole system will s

Re: [st-ericsson] [PATCH 15/17] mfd: dbx540-prcmu creation

2012-09-05 Thread Arnd Bergmann
On Wednesday 05 September 2012, Linus Walleij wrote: > On Wed, Sep 5, 2012 at 2:10 PM, Arnd Bergmann wrote: > > On Wednesday 05 September 2012, Loic Pallardy wrote: > >> +#define PRCM_PLLDSITV_FREQ (_PRCMU_BASE + 0x500) > >> +#define PRCM_PLLDSITV_ENABLE (_PRCMU_BASE + 0x504) > >> +

RE: [PATCH v2] usb: move phy driver from mach-tegra to drivers/usb

2012-09-05 Thread Venu Byravarasu
> -Original Message- > From: Stephen Warren [mailto:swar...@wwwdotorg.org] > Sent: Wednesday, September 05, 2012 3:19 AM > To: ba...@ti.com > Cc: Venu Byravarasu; ccr...@android.com; o...@lixom.net; > li...@arm.linux.org.uk; st...@rowland.harvard.edu; > gre...@linuxfoundation.org; linux-ke

Re: [PATCH v3] UDF: Add support for O_DIRECT

2012-09-05 Thread Jan Kara
On Wed 05-09-12 14:05:20, Jan Kara wrote: > On Tue 04-09-12 16:11:32, Ian Abbott wrote: > > >>1. Small files stored in the ICB (inode control block?): just return 0 > > >>from the new udf_adinicb_direct_IO() handler to fall back to buffered > > >>I/O. For direct writes, there is a "gotcha" to deal

Re: [PATCH v2] usb: move phy driver from mach-tegra to drivers/usb

2012-09-05 Thread Felipe Balbi
Hi, On Wed, Sep 05, 2012 at 06:24:13PM +0530, Venu Byravarasu wrote: > > > -Original Message- > > From: Stephen Warren [mailto:swar...@wwwdotorg.org] > > Sent: Wednesday, September 05, 2012 3:19 AM > > To: ba...@ti.com > > Cc: Venu Byravarasu; ccr...@android.com; o...@lixom.net; > > li...

Re: WARNING: cpu_is_offline() at native_smp_send_reschedule()

2012-09-05 Thread Fengguang Wu
On Wed, Sep 05, 2012 at 12:54:40PM +0200, Peter Zijlstra wrote: > On Wed, 2012-09-05 at 12:35 +0800, Michael Wang wrote: > > > [ 10.968565] reboot: machine restart > > > [ 10.983510] [ cut here ] > > > [ 10.984218] WARNING: at > > > /c/kernel-tests/src/stable/arch/x86

Re: A workaround for request_firmware() stuck in module_init

2012-09-05 Thread Alan Cox
> If the driver is built in kernel, the request_firmware in .probe() may > prolong kernel init, and it might be a problem. But looks it is not a > big deal since most of drivers are built as module. Doing it by deferring the load also fixes that. The built in ones will defer their final probe unti

Re: [RFC 1/2] virtio_console: Add support for DMA memory allocation

2012-09-05 Thread Sjur Brændeland
> The driver certainly shouldn't offer VIRTIO_CONSOLE_F_DMA_MEM if you > don't have DMA! OK, so the feature table could be done like this: static unsigned int features[] = { VIRTIO_CONSOLE_F_SIZE, VIRTIO_CONSOLE_F_MULTIPORT, #if VIRTIO_CONSOLE_HAS_DMA VIRTIO_CONSOLE_F_DMA

Re: [PATCH] builddeb: remove unneeded explicit Architecture

2012-09-05 Thread Tzafrir Cohen
Hi, Thanks for your reply, On Fri, Aug 31, 2012 at 03:50:10PM +0200, Michal Marek wrote: > Adding Max to CC. > > On 14.8.2012 12:44, Tzafrir Cohen wrote: > > Architecture was set explicitly in debian/control for one of the three > > packages (linux-libc-dev) but not for the other two. When cross

Re: [Xen-devel] [PATCH 1/1] XEN: Use correct masking in xen_swiotlb_alloc_coherent.

2012-09-05 Thread Stefano Panella
On 09/04/2012 05:40 PM, Konrad Rzeszutek Wilk wrote: On Tue, Sep 04, 2012 at 05:44:46PM +0100, David Vrabel wrote: On 04/09/12 16:12, Stefano Panella wrote: On 09/04/2012 03:55 PM, David Vrabel wrote: On 04/09/12 15:37, Konrad Rzeszutek Wilk wrote: On Tue, Sep 04, 2012 at 03:07:42PM +0100, St

Re: [PATCH V3 3/4] PCI: Add support for non-BAR ROMs

2012-09-05 Thread Matthew Garrett
On Wed, Sep 05, 2012 at 01:46:21PM +0100, Alan Cox wrote: > On Wed, 5 Sep 2012 03:29:32 +0100 > Matthew Garrett wrote: > > > On Tue, Sep 04, 2012 at 10:18:48PM -0400, Don Dutile wrote: > > > > /* > > > >+ * Some devices may provide ROMs via a source other than the BAR > > > >+

Re: [PATCH V3 3/4] PCI: Add support for non-BAR ROMs

2012-09-05 Thread Alan Cox
On Wed, 5 Sep 2012 14:20:07 +0100 Matthew Garrett wrote: > On Wed, Sep 05, 2012 at 01:46:21PM +0100, Alan Cox wrote: > > On Wed, 5 Sep 2012 03:29:32 +0100 > > Matthew Garrett wrote: > > > > > On Tue, Sep 04, 2012 at 10:18:48PM -0400, Don Dutile wrote: > > > > > /* > > > > >+ * Some

Re: [PATCH] builddeb: remove unneeded explicit Architecture

2012-09-05 Thread Michal Marek
On 5.9.2012 15:05, Tzafrir Cohen wrote: > Hi, > > Thanks for your reply, > > On Fri, Aug 31, 2012 at 03:50:10PM +0200, Michal Marek wrote: >> Adding Max to CC. >> >> On 14.8.2012 12:44, Tzafrir Cohen wrote: >>> Architecture was set explicitly in debian/control for one of the three >>> packages (l

Re: [Patch 0/1]drm_irq: Introducing the irq_thread support

2012-09-05 Thread Daniel Vetter
On Wed, Sep 05, 2012 at 01:53:44AM +, Liu, Chuansheng wrote: > This patch is for introducing the irq thread support in drm_irq. > > Why we need irq thread in drm_irq code? > In our GPU system, the gpu interrupt handler need some time even > 1ms to > finish, > in that case, the whole system wi

Re: [tip:sched/core] sched: Fix load avg vs cpu-hotplug

2012-09-05 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Tue, 2012-09-04 at 11:43 -0700, tip-bot for Peter Zijlstra wrote: > > Commit-ID: f319da0c6894fcf55e21320e40506418a2aad629 > > Gitweb: > > http://git.kernel.org/tip/f319da0c6894fcf55e21320e40506418a2aad629 > > Author: Peter Zijlstra > > AuthorDate: Mon, 20

Re: [PATCH] Add mach-specific includes

2012-09-05 Thread Tzafrir Cohen
On Fri, Aug 31, 2012 at 03:45:23PM +0200, Michal Marek wrote: > > On 12.8.2012 11:47, Tzafrir Cohen wrote: > > +if echo arch/$SRCARCH/mach-*/include | grep q -v '*'; then > > This should probably be grep -q, but it's quite ugly anyway. You can > simply run the find command and redirect it's stde

[PATCH] Add mach-specific includes

2012-09-05 Thread Tzafrir Cohen
When building a deb package, the linux-headers package should also add arch/$ARCH/mach-*/include Required for arm and probably some other architectures: avr32 and blackfin. This is needed to allow building modules using the headers package. Signed-off-by: Tzafrir Cohen --- scripts/package/build

[PATCH] usb: move phy driver from mach-tegra to drivers/usb

2012-09-05 Thread Venu Byravarasu
As part of this patch: 1. Moved existing tegra phy driver to drivers/USB directory. 2. Added standard USB phy driver APIs to tegra phy driver. Signed-off-by: Venu Byravarasu --- arch/arm/mach-tegra/Makefile |1 - arch/arm/mach-tegra/devices.c

[PATCH 7/8] pwm i.MX: fix clock lookup

2012-09-05 Thread Sascha Hauer
From: Philipp Zabel The i.MX pwm core has two clocks: The ipg clock and the ipg highfreq (peripheral) clock. The ipg clock has to be enabled for this hardware to work. The actual pwm output can either be driven by the ipg clock or the ipg highfreq. The ipg highfreq has the advantage that it runs

[PATCH 3/8] pwm i.MX: add functions to enable/disable pwm.

2012-09-05 Thread Sascha Hauer
We used to enable/disable the pwm only by switching the clock on or off. Instead, use the dedicated register bits. These differ on different SoCs, so introduce a SoC specific function for this. Signed-off-by: Sascha Hauer --- drivers/pwm/pwm-imx.c | 48 +

[PATCH 2/8] pwm i.MX: remove unnecessary if in pwm_[en|dis]able

2012-09-05 Thread Sascha Hauer
The pwm core makes sure that pwm_enable/disable are called only once. Still keep the enabled state since we will need it in pwm_config. Signed-off-by: Sascha Hauer --- drivers/pwm/pwm-imx.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/

[PATCH 5/8] pwm i.MX: add devicetree support

2012-09-05 Thread Sascha Hauer
From: Philipp Zabel At the same time remove platform based support. No user for this driver has made it into mainline so far, so all we break is out of tree stuff. Signed-off-by: Philipp Zabel Signed-off-by: Sascha Hauer --- Documentation/devicetree/bindings/pwm/imx-pwm.txt | 17 d

Re: [RFC] module: signature infrastructure

2012-09-05 Thread Mimi Zohar
On Wed, 2012-09-05 at 09:59 +0930, Rusty Russell wrote: > "Kasatkin, Dmitry" writes: > > Hi, > > > > Please read bellow... > > > > On Tue, Sep 4, 2012 at 8:55 AM, Rusty Russell wrote: > >> OK, I took a look at the module.c parts of David and Dmitry's patchsets, > >> and didn't really like either,

[PATCH 8/8] ARM i.MX53: Add pwm support

2012-09-05 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- arch/arm/boot/dts/imx53.dtsi| 14 ++ arch/arm/mach-imx/clk-imx51-imx53.c |4 2 files changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi index cd37165..18b9fc3 100644 --- a/arch/arm/boot

[PATCH 1/8] pwm i.MX: factor out SoC specific functions

2012-09-05 Thread Sascha Hauer
To make the code more flexible. Signed-off-by: Sascha Hauer --- drivers/pwm/pwm-imx.c | 145 - 1 file changed, 82 insertions(+), 63 deletions(-) diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c index 2a0b353..38270f4 100644 --- a/driver

[PATCH 6/8] pwm i.MX: use per clock unconditionally

2012-09-05 Thread Sascha Hauer
The i.MX pwm core has two clocks: The ipg clock and the ipg highfreq (peripheral) clock. The ipg clock has to be enabled for this hardware to work. The actual pwm output can either be driven by the ipg clock or the ipg highfreq. The ipg highfreq has the advantage that it runs even when the SoC is i

[PATCH v2] pwm i.MX: add devicetree support

2012-09-05 Thread Sascha Hauer
Changes since v1: - Add devicetree binding documentation - Merge 5/9 and 9/9 - fix #pwm-cells (must be 2 instead of 3) - fix wrong name in MODULE_DEVICE_TABLE - drop platform based probing while introducing devicetree based probe P

RE: [PATCH v2] usb: move phy driver from mach-tegra to drivers/usb

2012-09-05 Thread Venu Byravarasu
Hi Felipe, > -Original Message- > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Wednesday, September 05, 2012 6:22 PM > To: Venu Byravarasu > Cc: Stephen Warren; ba...@ti.com; ccr...@android.com; o...@lixom.net; > li...@arm.linux.org.uk; st...@rowland.harvard.edu; > gre...@linuxfoundati

Re: [PATCH v2 4/5] fat: eliminate orphaned inode number allocation

2012-09-05 Thread Namjae Jeon
2012/9/5, OGAWA Hirofumi : > OGAWA Hirofumi writes: > >> Namjae Jeon writes: >> >>> From: Namjae Jeon >>> >>> Maintain a list of inode(i_pos) numbers of orphaned inodes (i.e the >>> inodes that have been unlinked but still having open file >>> descriptors).At file/directory creation time, skip u

[PATCH 4/8] pwm i.MX: Use module_platform_driver

2012-09-05 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- drivers/pwm/pwm-imx.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c index 3fc4ae8..a689144 100644 --- a/drivers/pwm/pwm-imx.c +++ b/drivers/pwm/pwm-imx.c @@ -270,17 +270,7 @@ static

Re: [PATCH 0/8 v2] acpi-cpufreq: Move modern AMD cpufreq support to acpi-cpufreq

2012-09-05 Thread Rafael J. Wysocki
On Tuesday, September 04, 2012, Andre Przywara wrote: > Hi, > > now the second, revised version of the patch set. I now tested loading > both drivers after each other in several combinations, after two bug > fixes this now works as expected. > I added a patch to move messages from powernow-k8 afte

Re: [PATCH V3 3/4] PCI: Add support for non-BAR ROMs

2012-09-05 Thread Matthew Garrett
On Wed, Sep 05, 2012 at 02:30:10PM +0100, Alan Cox wrote: > On Wed, 5 Sep 2012 14:20:07 +0100 > Matthew Garrett wrote: > > We've no good way of knowing what the firmware's giving us - we copy it > > to RAM in the EFI init process, so by the time we're here it certainly > > shouldn't be on the PC

Re: when the MTU interface is modified, the promiscuous mode is reset in gianfar driver

2012-09-05 Thread Claudiu Manoil
On 09/03/2012 10:53 PM, David Miller wrote: > From: chikazawa.ak...@jp.fujitsu.com (近沢 哲史) > Date: Mon, 27 Aug 2012 17:38:34 +0900 > >> I am using the gianfar ethernet driver. I am having a problem with the >> interface settings. >> Under promiscuous mode, when the MTU interface is modified, the

Re: kexec/kdump kernel fails to start

2012-09-05 Thread Flavio Leitner
On Tue, 4 Sep 2012 18:15:25 -0700 Yinghai Lu wrote: > assume when we have good_end setting for 64 bit, page table for [4g, > TOMH) will be just under 512M, and later when first > first 2M lines changes, will push that page table range a little low, > and will make kdump not happy. > > BTW the fir

[PATCH] perf tool: fix trivial memory leak while calling system_path()

2012-09-05 Thread liang xie
A trivial memory leak fix while calling system_path Signed-off-by: Liang Xie --- tools/perf/util/exec_cmd.c |6 -- tools/perf/util/help.c |1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/exec_cmd.c b/tools/perf/util/exec_cmd.c index 7adf4ad..79

Re: Linux 3.6-rc4

2012-09-05 Thread Dave Jones
On Sat, Sep 01, 2012 at 03:10:58PM -0700, Linus Torvalds wrote: > The kernel summit is over, and most people have either returned or are > returning from San Diego. Still seeing this, that I started seeing just before leaving for San Diego.. Dave ==

Re: [PATCH] perf tool: fix trivial memory leak while calling system_path()

2012-09-05 Thread Felipe Balbi
Hi, On Wed, Sep 05, 2012 at 09:48:54PM +0800, liang xie wrote: > A trivial memory leak fix while calling system_path > > Signed-off-by: Liang Xie > --- > tools/perf/util/exec_cmd.c |6 -- > tools/perf/util/help.c |1 + > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff

Re: [PATCH] slab: fix the DEADLOCK issue on l3 alien lock

2012-09-05 Thread Christoph Lameter
On Wed, 5 Sep 2012, Michael Wang wrote: > Since the cachep and cachep->slabp_cache's l3 alien are in the same lock > class, > fake report generated. Ahh... That is a key insight into why this occurs. > This should not happen since we already have init_lock_keys() which will > reassign the lock

Re: [PATCH v2 4/5] fat: eliminate orphaned inode number allocation

2012-09-05 Thread OGAWA Hirofumi
Namjae Jeon writes: > 2012/9/5, OGAWA Hirofumi : >> OGAWA Hirofumi writes: >> >>> Namjae Jeon writes: >>> From: Namjae Jeon Maintain a list of inode(i_pos) numbers of orphaned inodes (i.e the inodes that have been unlinked but still having open file descriptors).At fil

Re: [PATCH v3 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-09-05 Thread Tomasz Figa
Hi Thomas, Thomas Abraham wrote: > Add a new device tree enabled pinctrl and gpiolib driver for Samsung > SoC's. This driver provides a common and extensible framework for all > Samsung SoC's to interface with the pinctrl and gpiolib subsystems. This > driver supports only device tree based instan

Re: A workaround for request_firmware() stuck in module_init

2012-09-05 Thread Takashi Iwai
At Wed, 5 Sep 2012 14:03:04 +0100, Alan Cox wrote: > > > If the driver is built in kernel, the request_firmware in .probe() may > > prolong kernel init, and it might be a problem. But looks it is not a > > big deal since most of drivers are built as module. > > Doing it by deferring the load also

[BUG] perf: perf_swevent PMU should not be on rotation_list

2012-09-05 Thread Stephane Eranian
Hi, I was looking at the rotation code and I found out that when I monitor a SW event (in my case a probe), I end up having two PMUs on the rotation list on Intel Core: cpu and software. I thought there was no multiplexing needed for SW events. So why is the SW PMU on the rotation list causing e

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-05 Thread Namjae Jeon
2012/9/5, Al Viro : > On Wed, Sep 05, 2012 at 12:57:44AM +0900, Namjae Jeon wrote: >> From: Namjae Jeon >> >> All the files on a FAT partition have an on-disk directory entry. >> The location of these entries, i_pos, is unique and is constructed by the >> fat_make_i_pos() function.We can use this

Re: [PATCH] perf tool: fix trivial memory leak while calling system_path()

2012-09-05 Thread liang xie
Hi Felipe, Thanks for reviewing! yeh, the check could be removed safely . For casting, it'll complain like this if removed: cc1: warnings being treated as errors util/help.c: In function ‘load_command_list’: util/help.c:190: error: passing argument 1 of ‘free’ discards qualifiers from pointer targ

Re: [patch] da9052-battery: don't free IRQ that wasn't requested

2012-09-05 Thread walter harms
Am 05.09.2012 14:34, schrieb Dan Carpenter: > We should decrement "i" before doing the free_irq(). If we call this > because request_threaded_irq() failed then we don't want to free the > thing which failed. Or in the case where we get here because > power_supply_register() failed then the orig

Re: lockdep WARNING for run_timer_softirq()

2012-09-05 Thread Steven Rostedt
On Wed, 2012-09-05 at 13:47 +0200, Peter Zijlstra wrote: > On Fri, 2012-08-31 at 00:21 -0700, Fengguang Wu wrote: > > [3.267585] Testing tracer function: [4.282931] tsc: Refined TSC > > clocksource calibration: 2833.332 MHz > > PASSED > > [ 13.392541] Testing tracer irqsoff: PASSED > > [

Re: [PATCH v3 2/2] virtio-ring: Allocate indirect buffers from cache when possible

2012-09-05 Thread Avi Kivity
On 09/04/2012 09:41 PM, Michael S. Tsirkin wrote: > On Tue, Sep 04, 2012 at 07:34:19PM +0300, Avi Kivity wrote: >> On 08/31/2012 12:56 PM, Michael S. Tsirkin wrote: >> > On Fri, Aug 31, 2012 at 11:36:07AM +0200, Sasha Levin wrote: >> >> On 08/30/2012 03:38 PM, Michael S. Tsirkin wrote: >> >> >> +st

Re: [PATCH 0/7] Add support for Freescale's mc34708 to mc13xxx driver

2012-09-05 Thread Fabio Estevam
Hi Samuel, On Thu, Jul 12, 2012 at 8:02 PM, Marc Reilly wrote: > Hi Uwe, > >> This series was tested on a Phytec pcm038 (mc13783 on spi) using >> traditional boot (i.e. not dt) and on a i.MX53 based machine (mc34708 on >> i2c) using dt boot. >> >> Philippe's patches are already in next, they are

Re: [PATCH 0/8 v2] acpi-cpufreq: Move modern AMD cpufreq support to acpi-cpufreq

2012-09-05 Thread Thomas Renninger
On Wednesday, September 05, 2012 03:46:22 PM Rafael J. Wysocki wrote: > On Tuesday, September 04, 2012, Andre Przywara wrote: > > Hi, > > > > now the second, revised version of the patch set. I now tested loading > > both drivers after each other in several combinations, after two bug > > fixes th

Re: [PATCH v3 2/2] virtio-ring: Allocate indirect buffers from cache when possible

2012-09-05 Thread Michael S. Tsirkin
On Wed, Sep 05, 2012 at 05:21:12PM +0300, Avi Kivity wrote: > On 09/04/2012 09:41 PM, Michael S. Tsirkin wrote: > > On Tue, Sep 04, 2012 at 07:34:19PM +0300, Avi Kivity wrote: > >> On 08/31/2012 12:56 PM, Michael S. Tsirkin wrote: > >> > On Fri, Aug 31, 2012 at 11:36:07AM +0200, Sasha Levin wrote:

Re: [PATCH] trace: Don't declare trace_*_rcuidle functions in modules

2012-09-05 Thread Mathieu Desnoyers
* Josh Triplett (j...@joshtriplett.org) wrote: > Tracepoints declare a static inline trace_*_rcuidle variant of the trace > function, to support safely generating trace events from the idle loop. > Module code never actually uses that variant of trace functions, because > modules don't run code tha

[PATCH -tip 0/4][BUGFIX] Fix ftrace-based kprobes

2012-09-05 Thread Masami Hiramatsu
Hi, This series of patches fixes some bugs and corrects behaviors of ftrace and ftrace-based kprobe. As Fengguang reported at https://lkml.org/lkml/2012/8/24/45 ftrace-based kprobes and -mfentry option caused failures on kprobe smoke test. This basically comes from the initial design of ftrace-ba

[PATCH -tip 1/4] [BUGFIX] ftrace/x86: Adjust x86 regs.ip as like as x86-64

2012-09-05 Thread Masami Hiramatsu
Adjust x86 regs.ip to ip + MCOUNT_INSN_SIZE as like as on x86-64. This helps us to consolidate codes which use regs->ip on both of x86/x86-64. Signed-off-by: Masami Hiramatsu Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: Steven Rostedt --- arch/x86/kernel/entry_32.S |3 +-

[PATCH -tip 2/4] [BUGFIX] kprobes/x86: Fix kprobes to collectly handle IP on ftrace

2012-09-05 Thread Masami Hiramatsu
Current kprobe_ftrace_handler expects regs->ip == ip, but it is incorrect (originally on x86-64). Actually, ftrace handler sets regs->ip = ip + MCOUNT_INSN_SIZE. kprobe_ftrace_handler must take care for that. Signed-off-by: Masami Hiramatsu Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvi

[PATCH -tip 3/4] ftrace/x86-64: Allow to change RIP in handlers

2012-09-05 Thread Masami Hiramatsu
From: Steven Rostedt Allow ftrace handlers to change RIP register (regs->ip) in handlers. This will allow handlers to call another function instead of original function. Signed-off-by: Steven Rostedt Signed-off-by: Masami Hiramatsu Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" --

[PATCH -tip 4/4] [BUGFIX] kprobes/x86: Fix to support jprobes on ftrace-based kprobe

2012-09-05 Thread Masami Hiramatsu
Fix kprobes/x86 to support jprobes on ftrace-based kprobes. Because of -mfentry support of ftrace, ftrace is now put on the beginning of function where jprobes are put. Originally ftrace-based kprobes doesn't support jprobe because it will change regs->ip and ftrace doesn't support changing IP and

Re: [RFC 1/2] virtio_console: Add support for DMA memory allocation

2012-09-05 Thread Michael S. Tsirkin
On Wed, Sep 05, 2012 at 03:00:20PM +0200, Sjur Brændeland wrote: > > The driver certainly shouldn't offer VIRTIO_CONSOLE_F_DMA_MEM if you > > don't have DMA! > > OK, so the feature table could be done like this: > > static unsigned int features[] = { > VIRTIO_CONSOLE_F_SIZE, > VIRTIO

Re: [PATCH] dma-debug: Add dma map/unmap error tracking support

2012-09-05 Thread Shuah Khan
On Wed, 2012-09-05 at 07:57 -0400, Konrad Rzeszutek Wilk wrote: > On Tue, Sep 04, 2012 at 04:57:56PM -0600, Shuah Khan wrote: > > On Tue, 2012-09-04 at 17:05 -0400, Konrad Rzeszutek Wilk wrote: > > > On Sun, Sep 02, 2012 at 08:14:17AM -0600, Shuah Khan wrote: > > > > A recent dma mapping error anal

Re: [PATCH v9 1/2] kvm: Use a reserved IRQ source ID for irqfd

2012-09-05 Thread Avi Kivity
On 08/22/2012 03:41 AM, Michael S. Tsirkin wrote: >> >> I assumed you were pointing out the level vs edge interaction. If we >> call that a userspace bug, I can just drop this. Thanks, >> >> Alex > > level is userspace bug I think :) I don't see how it's a bug. Suppose we have a vfio device

Re: [PATCH] swiotlb: add kernel error message to track iobtlb overflow buffer usage

2012-09-05 Thread Shuah Khan
On Tue, 2012-09-04 at 16:28 -0700, Andrew Morton wrote: > On Fri, 31 Aug 2012 18:55:59 -0600 > Shuah Khan wrote: > > > Add kernel error message to track iotlb overflow buffer triggers to > > understand > > how often the overflow buffer gets used. > > > > Signed-off-by: Shuah Khan > > --- > >

[Ping^3] Re: [PATCH] sg_io: allow UNMAP and WRITE SAME without CAP_SYS_RAWIO

2012-09-05 Thread Paolo Bonzini
Il 28/08/2012 13:04, Paolo Bonzini ha scritto: > Il 01/08/2012 17:53, Paolo Bonzini ha scritto: >> Il 20/07/2012 18:30, Paolo Bonzini ha scritto: >>> These commands cannot be issued right now without giving CAP_SYS_RAWIO to >>> the process who wishes to send them. These commands can be useful also

Re: [PATCH v9 0/2] kvm: level irqfd support

2012-09-05 Thread Avi Kivity
On 08/21/2012 10:28 PM, Alex Williamson wrote: > Here's the much anticipated re-write of support for level irqfds. As > Michael suggested, I've rolled the eoi/ack notification fd into > KVM_IRQFD as a new mode. For lack of a better name, as there seems to > be objections to associating this speci

Re: [Xen-devel] [PATCH 1/1] XEN: Use correct masking in xen_swiotlb_alloc_coherent.

2012-09-05 Thread Konrad Rzeszutek Wilk
On Tue, Sep 04, 2012 at 03:07:42PM +0100, Stefano Panella wrote: > On 08/31/2012 05:40 PM, Konrad Rzeszutek Wilk wrote: > >On Fri, Aug 31, 2012 at 01:47:05PM +0100, David Vrabel wrote: > >>On 31/08/12 10:57, Stefano Panella wrote: > >>>When running 32-bit pvops-dom0 and a driver tries to allocate a

Re: [PATCH] xen: fix logical error in tlb flushing

2012-09-05 Thread Konrad Rzeszutek Wilk
On Wed, Sep 05, 2012 at 05:41:37AM +, Ren, Yongjie wrote: > > -Original Message- > > From: Shi, Alex > > Sent: Wednesday, September 05, 2012 1:35 PM > > To: Jan Beulich > > Cc: Konrad Rzeszutek Wilk; t...@linutronix.de; mi...@redhat.com; > > linux-kernel@vger.kernel.org; h...@zytor.com;

Re: [PATCH v9 1/2] kvm: Use a reserved IRQ source ID for irqfd

2012-09-05 Thread Avi Kivity
On 08/21/2012 10:29 PM, Alex Williamson wrote: > KVM_IRQFD currently uses the reserved KVM_USERSPACE_IRQ_SOURCE_ID > which is also shared with userspace injection methods like > KVM_IRQ_LINE. This can cause a conflict if an irqfd triggers on > a GSI asserted through KVM_IRQ_LINE. Move irqfd to it

Re: [PATCH v2] memcg: first step towards hierarchical controller

2012-09-05 Thread Michal Hocko
On Wed 05-09-12 12:14:12, Glauber Costa wrote: > On 09/04/2012 08:25 PM, Michal Hocko wrote: > > On Tue 04-09-12 18:54:08, Glauber Costa wrote: > > [...] > I'd personally believe merging both our patches together would achieve a > good result. > >>> > >>> I am still not sure we want to ad

Re: [PATCH v9 1/2] kvm: Use a reserved IRQ source ID for irqfd

2012-09-05 Thread Michael S. Tsirkin
On Wed, Sep 05, 2012 at 05:35:43PM +0300, Avi Kivity wrote: > On 08/22/2012 03:41 AM, Michael S. Tsirkin wrote: > >> > >> I assumed you were pointing out the level vs edge interaction. If we > >> call that a userspace bug, I can just drop this. Thanks, > >> > >> Alex > > > > level is userspace

Re: [PATCH v9 0/2] kvm: level irqfd support

2012-09-05 Thread Michael S. Tsirkin
On Wed, Sep 05, 2012 at 05:42:38PM +0300, Avi Kivity wrote: > On 08/21/2012 10:28 PM, Alex Williamson wrote: > > Here's the much anticipated re-write of support for level irqfds. As > > Michael suggested, I've rolled the eoi/ack notification fd into > > KVM_IRQFD as a new mode. For lack of a bett

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-05 Thread OGAWA Hirofumi
Namjae Jeon writes: > In this long discusstion about the FAT acceptance over NFS, our belief > is still that the objective should be to reduce errors as much as > possible and then if there are certain scenarios - at least that could > be highlighted as a limitation in Documentation instead of co

Re: [PATCH v9 2/2] kvm: On Ack, De-assert & Notify KVM_IRQFD extension

2012-09-05 Thread Avi Kivity
On 08/21/2012 10:29 PM, Alex Williamson wrote: > For VFIO based device assignment we'd like a mechanism to allow level > triggered interrutps to be directly injected into KVM. KVM_IRQFD > already allows this for edge triggered interrupts, but for level, we > need to watch for acknowledgement of th

Re: [PATCH v9 1/2] kvm: Use a reserved IRQ source ID for irqfd

2012-09-05 Thread Avi Kivity
On 09/05/2012 05:51 PM, Michael S. Tsirkin wrote: > On Wed, Sep 05, 2012 at 05:35:43PM +0300, Avi Kivity wrote: >> On 08/22/2012 03:41 AM, Michael S. Tsirkin wrote: >> >> >> >> I assumed you were pointing out the level vs edge interaction. If we >> >> call that a userspace bug, I can just drop th

[PATCH v2 20/20] HID: hid-multitouch: Fix contact count on 3M panels

2012-09-05 Thread Henrik Rydberg
Some devices report the number of contacts via the unreliable CONTACTCOUNT usage, rather than using the CONTACTMAX feature. Without this patch, the 3M devices are constrained to the default maximum of ten fingers. Cc: Benjamin Tissoires Signed-off-by: Henrik Rydberg --- Benjamin, are you ok with

Re: [PATCH v9 1/2] kvm: Use a reserved IRQ source ID for irqfd

2012-09-05 Thread Michael S. Tsirkin
On Wed, Sep 05, 2012 at 05:46:17PM +0300, Avi Kivity wrote: > On 08/21/2012 10:29 PM, Alex Williamson wrote: > > KVM_IRQFD currently uses the reserved KVM_USERSPACE_IRQ_SOURCE_ID > > which is also shared with userspace injection methods like > > KVM_IRQ_LINE. This can cause a conflict if an irqfd

Re: [PATCH v9 1/2] kvm: Use a reserved IRQ source ID for irqfd

2012-09-05 Thread Michael S. Tsirkin
On Wed, Sep 05, 2012 at 05:51:53PM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 05, 2012 at 05:35:43PM +0300, Avi Kivity wrote: > > On 08/22/2012 03:41 AM, Michael S. Tsirkin wrote: > > >> > > >> I assumed you were pointing out the level vs edge interaction. If we > > >> call that a userspace b

Re: [PATCH 0/8 v2] acpi-cpufreq: Move modern AMD cpufreq support to acpi-cpufreq

2012-09-05 Thread Andre Przywara
On 09/05/2012 04:25 PM, Thomas Renninger wrote: On Wednesday, September 05, 2012 03:46:22 PM Rafael J. Wysocki wrote: On Tuesday, September 04, 2012, Andre Przywara wrote: Hi, I have applied the whole series to the linux-next branch of the linux-pm.git Thanks! tree, but I'm quite unsure

[PATCH 3.6 0/3] Fix use-after-free in PSCSI

2012-09-05 Thread Paolo Bonzini
Hi, this series fixes the bug I reported with wrong sense data. The memory corruption is caused by using the sense data after freeing it. The series corrects it by moving the copy of the sense data earlier, to the transport_complete callback. Please review and be kind on my first lio patches! :

[PATCH 3.6 1/3] target: move transport_get_sense_data

2012-09-05 Thread Paolo Bonzini
We will be calling it from transport_complete_cmd, avoid forward declarations. No semantic change. Signed-off-by: Paolo Bonzini --- drivers/target/target_core_transport.c | 110 1 files changed, 55 insertions(+), 55 deletions(-) diff --git a/drivers/target/tar

[PATCH 3.6 3/3] target: fix use-after-free with PSCSI sense data

2012-09-05 Thread Paolo Bonzini
The pointer to the sense buffer is fetched by transport_get_sense_data, but this is called by target_complete_ok_work long after pscsi_req_done has freed the struct that contains it. Pass instead the fabric's sense buffer to transport_complete, and copy the data to it directly in transport_complet

[PATCH 3.6 2/3] target: simplify code around transport_get_sense_data

2012-09-05 Thread Paolo Bonzini
The error conditions in transport_get_sense_data are superfluous and complicate the code unnecessarily: * SCF_TRANSPORT_TASK_SENSE is checked in the caller; * it's simply part of the invariants of dev->transport->get_sense_buffer that it must be there if transport_complete ever returns 1, and t

Re: [PATCH v9 1/2] kvm: Use a reserved IRQ source ID for irqfd

2012-09-05 Thread Avi Kivity
On 09/05/2012 06:09 PM, Michael S. Tsirkin wrote: > On Wed, Sep 05, 2012 at 05:51:53PM +0300, Michael S. Tsirkin wrote: >> On Wed, Sep 05, 2012 at 05:35:43PM +0300, Avi Kivity wrote: >> > On 08/22/2012 03:41 AM, Michael S. Tsirkin wrote: >> > >> >> > >> I assumed you were pointing out the level vs

Re: [PATCH v9 1/2] kvm: Use a reserved IRQ source ID for irqfd

2012-09-05 Thread Michael S. Tsirkin
On Wed, Sep 05, 2012 at 05:59:46PM +0300, Avi Kivity wrote: > On 09/05/2012 05:51 PM, Michael S. Tsirkin wrote: > > On Wed, Sep 05, 2012 at 05:35:43PM +0300, Avi Kivity wrote: > >> On 08/22/2012 03:41 AM, Michael S. Tsirkin wrote: > >> >> > >> >> I assumed you were pointing out the level vs edge i

RE: [Patch 0/1]drm_irq: Introducing the irq_thread support

2012-09-05 Thread Shi, Yang A
Hi Vetter: Do you mean we can just not use drm_irq_install, and make request_irq in our kernel driver pre-install or post-install interface? Best Regards. Yang Shi PSI,System Integration, SH E-mail:yang.a@intel.com Tel:88215666-4239 -Original Message- From: Daniel Vetter

[RFC PATCH 0/3] target: try satisfying memory requests with higher-order allocations

2012-09-05 Thread Paolo Bonzini
Hi all, while testing PSCSI I noticed that even requests for a smallish amount of data (approximately 700 KB) failed due to an excessive number of segments in the request. In fact, using alloc_page resulted in a completely fragmented request, with no merging of consecutive pages at all. This pat

Re: [PATCH v9 1/2] kvm: Use a reserved IRQ source ID for irqfd

2012-09-05 Thread Michael S. Tsirkin
On Wed, Sep 05, 2012 at 06:12:04PM +0300, Avi Kivity wrote: > On 09/05/2012 06:09 PM, Michael S. Tsirkin wrote: > > On Wed, Sep 05, 2012 at 05:51:53PM +0300, Michael S. Tsirkin wrote: > >> On Wed, Sep 05, 2012 at 05:35:43PM +0300, Avi Kivity wrote: > >> > On 08/22/2012 03:41 AM, Michael S. Tsirkin

[RFC PATCH 3/3] target: try satisfying memory requests with contiguous blocks

2012-09-05 Thread Paolo Bonzini
transport_generic_get_mem's strategy of allocating pages one-by-one for the data scatterlist may fail for even not-so-big data transfers if the underlying device poses a small limit on the number of segments. This patch fixes this problem by trying to allocate pages in relatively large groups (at

[RFC PATCH 1/3] tcm_iscsi: warn on incorrect precondition for iscsit_do_crypto_hash_sg

2012-09-05 Thread Paolo Bonzini
While iscsit_do_crypto_hash_sg does look at cmd->first_data_sg_off when computing cur_len, it ignores it completely when computing the hash. As a result, the first cmd->first_data_sg_off bytes are included in the hash even though they should not. Warn if this happens. Signed-off-by: Paolo Bonzin

Re: [PATCH] builddeb: remove unneeded explicit Architecture

2012-09-05 Thread maximilian attems
On Wed, 05 Sep 2012, Michal Marek wrote: > On 5.9.2012 15:05, Tzafrir Cohen wrote: > > Hi, > > > > Thanks for your reply, > > > > On Fri, Aug 31, 2012 at 03:50:10PM +0200, Michal Marek wrote: > >> Adding Max to CC. > >> > >> On 14.8.2012 12:44, Tzafrir Cohen wrote: > >>> Architecture was set exp

<    1   2   3   4   5   6   7   >