[PATCH v2] ALSA: korg1212: cleanup of printk

2014-11-23 Thread Sudip Mukherjee
From: Sudip Mukherjee replaced all references of the debug messages via printk with dev_* macro (mostly dev_dbg). one reference was changed to pr_err as there the card might have been uninitialized. this patch will generate warning from checkpatch about broken quoted strings. but that was not fi

Re: [CFT PATCH 0/2] KVM: support XSAVES usage in the host

2014-11-23 Thread Nadav Amit
I’ll try to check it tomorrow (I don’t have access to the failing machine at the moment). Thanks for the quick response. Nadav > On Nov 21, 2014, at 20:31, Paolo Bonzini wrote: > > The first patch ensures that XSAVES is not exposed in the guest until > we emulate MSR_IA32_XSS. The second exp

Re: [CFT PATCH 0/2] KVM: support XSAVES usage in the host

2014-11-23 Thread Wanpeng Li
Hi Nadav, On 11/23/14, 4:16 PM, Nadav Amit wrote: I’ll try to check it tomorrow (I don’t have access to the failing machine at the moment). If the machine you mentioned support xsaves and what's machine you are using? Regards, Wanpeng Li Thanks for the quick response. Nadav On Nov 21,

Re: [PATCH] ARM: dts: imx6q-tbs2910: Enable snvs-poweroff

2014-11-23 Thread Shawn Guo
On Thu, Nov 20, 2014 at 09:14:30PM +0100, Soeren Moch wrote: > On 11/19/14 07:54, Soeren Moch wrote: > >This patch enables snvs-poweroff for TBS2910 boards. > > > >Signed-off-by: Soeren Moch > >-- > >Cc: Shawn Guo > >Cc: Sascha Hauer > >Cc: linux-kernel@vger.kernel.org > >--- > > arch/arm/boot/

Re: [CFT PATCH 0/2] KVM: support XSAVES usage in the host

2014-11-23 Thread Nadav Amit
> On Nov 23, 2014, at 10:24, Wanpeng Li wrote: > > Hi Nadav, > On 11/23/14, 4:16 PM, Nadav Amit wrote: >> I’ll try to check it tomorrow (I don’t have access to the failing machine at >> the moment). > > If the machine you mentioned support xsaves and what's machine you are using? It supports

Re: [CFT PATCH 0/2] KVM: support XSAVES usage in the host

2014-11-23 Thread Wanpeng Li
On 11/23/14, 4:31 PM, Nadav Amit wrote: On Nov 23, 2014, at 10:24, Wanpeng Li wrote: Hi Nadav, On 11/23/14, 4:16 PM, Nadav Amit wrote: I’ll try to check it tomorrow (I don’t have access to the failing machine at the moment). If the machine you mentioned support xsaves and what's machine you

Re: [RFC] The SIGINFO signal from BSD

2014-11-23 Thread Pavel Machek
On Mon 2014-11-10 14:22:00, One Thousand Gnomes wrote: > > wouldn't be accepted. (BTW, if you're going to do this, note that ^T > > could be remapped to any control character via stty; so to do this we > > would need to define an extra index in c_cc[] array in the struct > > termios.) > > We have

[PATCH] Drivers:staging:wlan-ng: Fixed line over 80 characters warning

2014-11-23 Thread Lekshmi
The following chaeckpatch warning was fixed: WARNING: line over 80 characters Signed-off-by: Lekshmi --- drivers/staging/wlan-ng/prism2fw.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c index

Re: [f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-23 Thread Simon Baatz
Hi Changman, Jaegeuk, On Thu, Nov 20, 2014 at 05:47:29PM +0900, Changman Lee wrote: > On Wed, Nov 19, 2014 at 10:45:33PM -0800, Jaegeuk Kim wrote: > > On Thu, Nov 20, 2014 at 03:04:10PM +0900, Changman Lee wrote: > > > Hi Jaegeuk, > > > > > > We should call flush_dcache_page before kunmap because

[PATCH 1/1] video: uvesafb: Deletion of an unnecessary check before the function call "uvesafb_free"

2014-11-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 23 Nov 2014 11:00:26 +0100 The uvesafb_free() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- driv

Re: [PATCH v4 01/12] sched: fix imbalance flag reset

2014-11-23 Thread Wanpeng Li
Hi Vincent, On 7/29/14, 1:51 AM, Vincent Guittot wrote: The imbalance flag can stay set whereas there is no imbalance. Let assume that we have 3 tasks that run on a dual cores /dual cluster system. We will have some idle load balance which are triggered during tick. Unfortunately, the tick is al

Re: [Patch irqdomain: Enhance irq_domain_free_irqs_common() to support parentless irqdomain

2014-11-23 Thread Thomas Gleixner
On Fri, 21 Nov 2014, Jiang Liu wrote: > Originally irq_domain_free_irqs_common() is designed to be used by > irqdomains with parent. But there are desires to reuse for parentless > irqdomains for code reduction. > So check domain->parent before invoking irq_domain_free_irqs_parent(). > > Signed-o

Re: [Patch irqdomain: Enhance irq_domain_free_irqs_common() to support parentless irqdomain

2014-11-23 Thread Thomas Gleixner
On Sun, 23 Nov 2014, Thomas Gleixner wrote: > On Fri, 21 Nov 2014, Jiang Liu wrote: > > > Originally irq_domain_free_irqs_common() is designed to be used by > > irqdomains with parent. But there are desires to reuse for parentless > > irqdomains for code reduction. > > So check domain->parent bef

[PATCH 1/1] video: udlfb: Deletion of unnecessary checks before the function call "vfree"

2014-11-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 23 Nov 2014 11:40:47 +0100 The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/udlfb.c | 9 ++

Re: [PATCH net-net 0/4] Increase the limit of tuntap queues

2014-11-23 Thread Michael S. Tsirkin
On Wed, Nov 19, 2014 at 10:44:27PM +0200, Michael S. Tsirkin wrote: > On Wed, Nov 19, 2014 at 03:16:28PM -0500, David Miller wrote: > > From: Pankaj Gupta > > Date: Tue, 18 Nov 2014 21:52:54 +0530 > > > > > - Accept maximum number of queues as sysctl param so that any user space > > > applicat

[RFC] proc interface to show file page cache usage details

2014-11-23 Thread Vladimir Shebordaev
Hi, I would like to suggest an interface to list inodes that currently occupy page cache in human readable form. A piece of code below creates a dedicated proc entry, namely, /proc/kpagecache. Upon read request it traverses all the inodes of each superblock and shows their page cache usage summar

task_stat splat

2014-11-23 Thread Borislav Petkov
Hi, so I'm seeing the oops below on rc5 + tip/master from the 17th merged ontop. I've seen it twice already after resuming the box so maybe not a glitch. So from looking at the splat I *think* I can see conky trying to read /proc/.../stat and we end up in proc_tgid_stat |-> do_task_stat |->

[PATCH 1/1] video: smscufx: Deletion of unnecessary checks before the function call "vfree"

2014-11-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 23 Nov 2014 12:30:33 +0100 The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/smscufx.c | 6

Re: [Cocci] [PATCH 1/1] kernel-audit: Deletion of an unnecessary check before the function call "audit_log_end"

2014-11-23 Thread Julia Lawall
> > No, it's not. You should just try to write the most readable software > > you can instead of removing if statements because you can. > > Additional safety checks have also got an effect on source code readability, > haven't they? Normally, tests only hurt readability if they cannot be false

[PATCH 1/1] video: fbdev-SIS: Deletion of unnecessary checks before the function call "pci_dev_put"

2014-11-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 23 Nov 2014 12:55:25 +0100 The pci_dev_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drive

[PATCH] 8139too: The maximum MTU should allow for VLAN headers

2014-11-23 Thread Alban Bedel
As pointed out by Ben Hutchings drivers that allow using VLAN have to provide enough headroom for the VLAN tags. Signed-off-by: Alban Bedel --- drivers/net/ethernet/realtek/8139too.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/realtek/8139too.c

Re: [PATCH v3] ath3k: Add support of MCI 13d3:3408 bt device

2014-11-23 Thread Dmitry Tunin
After some testing on a few laptops it looks like the firmware loads always correctly only using AR3012 variant. So the correct patch follows --- diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c index d85ced2..086240c 100644 --- a/drivers/bluetooth/ath3k.c +++ b/drivers/blueto

[PATCH v4] ath3k: Add support of MCI 13d3:3408 bt device

2014-11-23 Thread Dmitry Tunin
Add support for bluetooth MCI WB335 (AR9565) Wi-Fi+bt module. This bluetooth module requires loading patch and sysconfig by ath3k driver. /sys/kernel/debug/usb/devices T: Bus=01 Lev=02 Prnt=03 Port=00 Cnt=01 Dev#= 20 Spd=12 MxCh= 0 D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P:

Re: [PATCH tip/core/rcu 3/9] drivers/md: Use rcu_dereference() for accessing rcu pointer

2014-11-23 Thread Pranith Kumar
On Fri, Nov 21, 2014 at 9:58 AM, Kirill A. Shutemov wrote: > On Fri, Nov 21, 2014 at 09:30:36AM -0500, Pranith Kumar wrote: >> On 11/21/2014 08:31 AM, Kirill A. Shutemov wrote: >> > On Tue, Oct 28, 2014 at 03:09:56PM -0700, Paul E. McKenney wrote: >> >> From: Pranith Kumar >> >> >> >> Got Paul's

[PATCH 0/10] fix error return code

2014-11-23 Thread Julia Lawall
These patches fix cases where the return code appears to be unintentially nonnegative. The complete semantic match that finds the problem is as follows: (http://coccinelle.lip6.fr/) // @ok exists@ identifier f,ret,i; expression e; constant c; @@ f(...) { <+... ( return -c@i; | ret = -c@i; ... w

[PATCH 4/9] sound/soc/omap/am3517evm.c: fix error return code

2014-11-23 Thread Julia Lawall
From: Julia Lawall It was forgotten to initialize ret to the result of calling snd_soc_dai_set_sysclk, unlike at the other calls in the same function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\

[PATCH 3/10] sound/atmel/abdac.c: fix error return code

2014-11-23 Thread Julia Lawall
From: Julia Lawall Initialize retval before returning from a failed call to ioremap. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 wh

[PATCH 8/9] sound/pci/rme9652/hdspm.c: fix error return code

2014-11-23 Thread Julia Lawall
From: Julia Lawall Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 =

[PATCH 1/10] sound/soc/ux500/ux500_msp_i2s.c: better use devm functions and fix error return code

2014-11-23 Thread Julia Lawall
From: Julia Lawall Remove unnecessary calls to devm_kfree and replace iounmap by devm_iounmap (and use resource_size for the third argument). These changes make it possible to remove the error-handling code at the end of ux500_msp_i2s_init_msp, and all of the gotos become direct returns. In the

[PATCH 9/9] sound/ppc/snd_ps3.c: fix error return code

2014-11-23 Thread Julia Lawall
From: Julia Lawall Initialize ret before returning on failure, as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != re

[PATCH 7/9] sound/pci/sis7019.c: fix error return code

2014-11-23 Thread Julia Lawall
From: Julia Lawall Initialize rc before returning on failure, as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret

[PATCH 5/9] sound/atmel/ac97c.c: fix error return code

2014-11-23 Thread Julia Lawall
From: Julia Lawall In the first case, the second test of whether retval is negative is redundant. It is dropped and the previous and subsequent tests are combined. In the second case, add an initialization of retval on failure of ioremap. A simplified version of the semantic match that finds t

[PATCH 6/9] sound/pci/ctxfi/ctatc.c: fix error return code

2014-11-23 Thread Julia Lawall
From: Julia Lawall Initialize err before returning on failure, as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != re

[PATCH 2/10] sound/soc/fsl/imx-sgtl5000.c: fix error return code

2014-11-23 Thread Julia Lawall
From: Julia Lawall Initialize ret on the second call to imx_audmux_v2_configure_port so that the subsequent test checks that result and not the previous one. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|re

[PATCH 1/1] video: fbdev-OMAP2: Deletion of unnecessary checks before the function call "i2c_put_adapter"

2014-11-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 23 Nov 2014 14:07:22 +0100 The i2c_put_adapter() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- d

Re: [PATCH 0/10] fix error return code

2014-11-23 Thread Julia Lawall
Oops!!! These are ancient patches. I meant to send something else. Sorry for the noise. julia On Sun, 23 Nov 2014, Julia Lawall wrote: > These patches fix cases where the return code appears to be unintentially > nonnegative. > > The complete semantic match that finds the problem is as foll

[PATCH 4/5] drm/rcar-du: fix error return code

2014-11-23 Thread Julia Lawall
From: Julia Lawall Propagate the error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = e1

[PATCH 5/5] drivers/gpu/drm: fix error return code

2014-11-23 Thread Julia Lawall
From: Julia Lawall Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret =

[PATCH 2/5] drm/exynos/ipp: fix error return code

2014-11-23 Thread Julia Lawall
From: Julia Lawall Propagate the returned error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != r

[PATCH 3/5] electra_cf: fix error return code

2014-11-23 Thread Julia Lawall
From: Julia Lawall Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret =

[PATCH 0/5] fix error return code

2014-11-23 Thread Julia Lawall
The complate semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @ok exists@ identifier f,ret,i; expression e; constant c; @@ // identify a function that returns a negative return value at least once. f(...) { ... when any ( return -c@i; | ret = -c@i; ... when !

[PATCH 1/5] mptfusion: fix error return code

2014-11-23 Thread Julia Lawall
From: Julia Lawall Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret =

Re: [PATCH 2/4] i2c: omap: implement workaround for handling invalid BB-bit values

2014-11-23 Thread Alexander Kochetkov
23 нояб. 2014 г., в 7:43, Felipe Balbi написал(а): > maybe there was a typo? I tested on v3.18-rc3 :-) I do my tests on kernel from angstrom with almost all i2c-omap patches backported from linux/master. Then I rebased them to wrong (old) kernel version and posted to the list. Angstrom kernel

Re: kernel-audit: Deletion of an unnecessary check before the function call "audit_log_end"

2014-11-23 Thread SF Markus Elfring
> Normally, tests only hurt readability if they cannot be false or cannot be > true. > Making a choice apparent when there really is a choice would seem > to aid understanding. I agree also to such facts. > Program analysis tools can also potentially exploit this information, The published s

[PATCH V3] ACPI: Add _DEP(Operation Region Dependencies) support to fix battery issue on the Asus T100TA

2014-11-23 Thread Lan Tianyu
ACPI 5.0 introduces _DEP to designate device objects that OSPM should assign a higher priority in start ordering due to future operation region accesses. On Asus T100TA, ACPI battery info are read from a I2C slave device via I2C operation region. Before I2C operation region handler is installed, b

Re: [Patch irqdomain: Enhance irq_domain_free_irqs_common() to support parentless irqdomain

2014-11-23 Thread Jiang Liu
On 2014/11/23 18:36, Thomas Gleixner wrote: > On Sun, 23 Nov 2014, Thomas Gleixner wrote: > >> On Fri, 21 Nov 2014, Jiang Liu wrote: >> >>> Originally irq_domain_free_irqs_common() is designed to be used by >>> irqdomains with parent. But there are desires to reuse for parentless >>> irqdomains fo

Side effect of pressing special keys

2014-11-23 Thread Pali Rohár
Hello, pressing some keys on laptops could cause some side effects. Example scenario 1: Laptop has Fn key for enabling/disabling WIFI and when that key is pressed BIOS is doing two things: 1) Switch hard rfkill state of WIFI 2) Report that Fn key was pressed to kernel (either via i8042 bus

Re: thunderbolt: Deletion of unnecessary checks before the function call "ring_free"

2014-11-23 Thread SF Markus Elfring
>> 2. Are any additional prefixes appropriate so that further name space >>conflicts can be better avoided? > > To avoid possible external naming conflicts, add tb_ prefix to > various ring_ structs and functions. Do you imagine that any XEN software developers need also to reconsider this im

[PATCH 1/1] video: mx3fb: Deletion of an unnecessary check before the function call "backlight_device_unregister"

2014-11-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 23 Nov 2014 15:15:29 +0100 The backlight_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elf

[PATCH 1/6] fs: move sendfile syscall into fs/splice

2014-11-23 Thread Pieter Smith
sendfile functionally forms part of the splice group of syscalls (splice, vmsplice and tee). Grouping sendfile with splice paves the way to compiling out the splice group of syscalls for embedded systems that do not need these. add/remove: 0/0 grow/shrink: 7/2 up/down: 86/-61 (25) function

[PATCH 5/6] net/core: support compiling out splice

2014-11-23 Thread Pieter Smith
To implement splice support, net/core makes use of nosteal_pipe_buf_ops. This struct is exported by fs/splice. The goal of the larger patch set is to completely compile out fs/splice, so uses of the exported struct need to be compiled out along with fs/splice. This patch therefore compiles out spl

[PATCH 2/6] fs: moved kernel_write to fs/read_write

2014-11-23 Thread Pieter Smith
kernel_write shares infrastructure with the read_write translation unit but not with the splice translation unit. Grouping kernel_write with the read_write translation unit is more logical. It also paves the way to compiling out the splice group of syscalls for embedded systems that do not need the

[PATCH 0/6] kernel tinification: optionally compile out splice family of syscalls (splice, vmsplice, tee and sendfile)

2014-11-23 Thread Pieter Smith
REPO: https://github.com/smipi1/linux-tinification.git BRANCH: tiny/config-syscall-splice BACKGROUND: This patch-set forms part of the Linux Kernel Tinification effort ( https://tiny.wiki.kernel.org/). GOAL: Support compiling out the splice family of syscalls (splice, vmsplice, tee and sendf

[PATCH 3/6] fs/splice: support compiling out splice-family syscalls

2014-11-23 Thread Pieter Smith
Many embedded systems will not need the splice-family syscalls (splice, vmsplice, tee and sendfile). Omitting them saves space. This adds a new EXPERT config option CONFIG_SYSCALL_SPLICE (default y) to support compiling them out. The goal is to completely compile out fs/splice. To achieve this, t

[PATCH 4/6] fs/fuse: support compiling out splice

2014-11-23 Thread Pieter Smith
To implement splice support, fs/fuse makes use of nosteal_pipe_buf_ops. This struct is exported by fs/splice. The goal of the larger patch set is to completely compile out fs/splice, so uses of the exported struct need to be compiled out along with fs/splice. This patch therefore compiles out spli

[PATCH 6/6] fs/splice: full support for compiling out splice

2014-11-23 Thread Pieter Smith
Entirely compile out splice translation unit when the system is configured without splice family of syscalls (i.e. CONFIG_SYSCALL_SPLICE is undefined). Exported fs/splice functions are transparently mocked out with static inlines. Because userspace support for splice has already been removed by th

[PATCH 1/3] carma-fpga-program.c: fix compile errors

2014-11-23 Thread Hans Verkuil
From: Hans Verkuil drivers/misc/carma/carma-fpga-program.c: In function 'fpga_program_dma': drivers/misc/carma/carma-fpga-program.c:529:2: error: expected ';' before 'if' if (ret) { ^ drivers/misc/carma/carma-fpga-program.c: In function 'fpga_read': drivers/misc/carma/carma-fpga-program.c:752

[PATCH 3/3] carma-fpga-program: drop videobuf dependency

2014-11-23 Thread Hans Verkuil
From: Hans Verkuil This driver abuses videobuf helper functions. This is a bad idea because: 1) this driver is completely unrelated to media drivers 2) the videobuf API is deprecated and will be removed eventually This patch replaces the videobuf functions with the normal DMA kernel API. Signe

[PATCH 0/3] carma-fpga: remove videobuf dependency

2014-11-23 Thread Hans Verkuil
While checking which drivers were still abusing internal videobuf API functions I came across these carma fpga misc drivers. These drivers have absolutely nothing to do with videobuf or the media subsystem. Drivers shouldn't use those low-level functions in the first place, and in fact in the long

[PATCH 2/3] carma-fpga: drop videobuf dependency

2014-11-23 Thread Hans Verkuil
From: Hans Verkuil This driver abuses videobuf helper functions. This is a bad idea because: 1) this driver is completely unrelated to media drivers 2) the videobuf API is deprecated and will be removed eventually This patch replaces the videobuf functions with the normal DMA kernel API. Signe

Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight

2014-11-23 Thread Pali Rohár
On Friday 21 November 2014 23:09:40 Darren Hart wrote: > On Sat, Nov 22, 2014 at 07:46:25PM +0100, Pali Rohár wrote: > > > > 0 Completed successfully > > > > -1 Completed with error > > > > -2 Function not supported > > > > > > > > So we can return something other too (not always > > > > -EINV

[PATCH v2] platform: x86: dell-laptop: Add support for keyboard backlight

2014-11-23 Thread Pali Rohár
This patch adds support for configuring keyboard backlight settings on supported Dell laptops. It exports kernel leds interface and uses Dell SMBIOS tokens or keyboard class interface. With this patch it is possible to set: * keyboard backlight level * timeout after which will be backlight automat

Re: [PATCH v4] ath3k: Add support of MCI 13d3:3408 bt device

2014-11-23 Thread Marcel Holtmann
Hi Dmitry, > Add support for bluetooth MCI WB335 (AR9565) Wi-Fi+bt module. > This bluetooth module requires loading patch and sysconfig by ath3k driver. > > /sys/kernel/debug/usb/devices > > T: Bus=01 Lev=02 Prnt=03 Port=00 Cnt=01 Dev#= 20 Spd=12 MxCh= 0 > D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Pro

[PATCH 1/1] video: fbdev-MMP: Deletion of an unnecessary check before the function call "mmp_unregister_path"

2014-11-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 23 Nov 2014 15:45:03 +0100 The mmp_unregister_path() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --

New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
Hi everyone, I was running some tests on Saturday before my pull, and I'm now hitting this consistently across two boxes. One box has plain linus git: commit cb95413971d605b0d152d3ceecc47ba8991d66fb Merge: ecde006 6bab4a8 Author: Linus Torvalds Date: Sat Nov 22 14:33:11 2014 -0800 The other

[PATCH 0/3] Dell Airplane Mode Switch driver

2014-11-23 Thread Pali Rohár
This patch series add new acpi Dell Airplane Mode Switch driver (DELLABCE and DELRBTN acpi devices). It provides radio HW switch events (together with current state of radio devices) and export them via rfkill interface. These events are also used in dell-laptop driver instead i8042 filter hook fun

[PATCH 3/3] platform: x86: dell-laptop: Use dell-rbtn instead i8042 filter when possible

2014-11-23 Thread Pali Rohár
Until now module dell-laptop registered rfkill device which used i8042 filter function for receiving HW switch rfkill events (handling special keycode). But for some dell laptops there is native ACPI driver dell-rbtn which can receive rfkill events (without i8042 hacks). On some machines it can al

[PATCH 2/3] platform: x86: dell-rbtn: Export notifier for other kernel modules

2014-11-23 Thread Pali Rohár
This patch exports notifier functions so other modules can receive HW switch events. By default when some module register notifier, dell-rbtn driver automatically remove rfkill interfaces from system (it is expected that other module will use events for other rfkill interface). This behaviour can b

[PATCH 1/3] platform: x86: dell-rbtn: Dell Airplane Mode Switch driver

2014-11-23 Thread Pali Rohár
This is an ACPI driver for Dell laptops which receive HW switch events. It exports rfkill device dell-rbtn which provide correct hard rfkill state. It does not provide support for setting soft rfkill state yet. Signed-off-by: Pali Rohár --- drivers/platform/x86/Kconfig | 13 +++ drivers/p

[GIT PULL] Btrfs deadlock fix

2014-11-23 Thread Chris Mason
Hi Linus, My for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Has a fix for a long standing deadlock that we've been trying to nail down for a while. It ended up being a bad interaction with the fair reader/writer locks and the order btrfs reacquir

Re: thunderbolt: Deletion of unnecessary checks before the function call "ring_free"

2014-11-23 Thread Joe Perches
On Sun, 2014-11-23 at 15:14 +0100, SF Markus Elfring wrote: > >> 2. Are any additional prefixes appropriate so that further name space > >>conflicts can be better avoided? > > > > To avoid possible external naming conflicts, add tb_ prefix to > > various ring_ structs and functions. > > Do yo

Re: [PATCH v4] ath3k: Add support of MCI 13d3:3408 bt device

2014-11-23 Thread Dmitry Tunin
Finally I figured out how to set up the mailer not to spoil everything. Add support for bluetooth MCI WB335 (AR9565) Wi-Fi+bt module. This bluetooth module requires loading patch and sysconfig by ath3k driver. Signed-off-by: Dmitry Tunin --- diff --git a/drivers/bluetooth/ath3k.c b/drivers/bl

[PATCH 1/1] video: fbdev-VIA: Deletion of an unnecessary check before the function call "framebuffer_release"

2014-11-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 23 Nov 2014 16:30:05 +0100 The framebuffer_release() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --

Re: thunderbolt: Deletion of unnecessary checks before the function call "ring_free"

2014-11-23 Thread SF Markus Elfring
>> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/char/tpm/xen-tpmfront.c?id=fc14f9c1272f62c3e8d01300f52467c0d9af50f9#n268 > > I think static functions can be named whatever > the developer chooses. I agree also that this implementation detail is correct in prin

Re: thunderbolt: Deletion of unnecessary checks before the function call "ring_free"

2014-11-23 Thread Andreas Noever
On Sun, Nov 23, 2014 at 4:20 PM, Joe Perches wrote: > On Sun, 2014-11-23 at 15:14 +0100, SF Markus Elfring wrote: >> >> 2. Are any additional prefixes appropriate so that further name space >> >>conflicts can be better avoided? >> > >> > To avoid possible external naming conflicts, add tb_ pre

Re: thunderbolt: Deletion of unnecessary checks before the function call "ring_free"

2014-11-23 Thread Julia Lawall
On Sun, 23 Nov 2014, SF Markus Elfring wrote: > >> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/char/tpm/xen-tpmfront.c?id=fc14f9c1272f62c3e8d01300f52467c0d9af50f9#n268 > > > > I think static functions can be named whatever > > the developer chooses. > > I

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 10:02 AM, Chris Mason wrote: Since it looks like a race between process exit and /proc, I'll try to hammer on that for a better reproduction. But, here's hoping that someone has already seen this one: It falls over in less than 5 minutes with a fork bomb going. I'll t

Re: thunderbolt: Deletion of unnecessary checks before the function call "ring_free"

2014-11-23 Thread Joe Perches
On Sun, 2014-11-23 at 16:45 +0100, Andreas Noever wrote: > On Sun, Nov 23, 2014 at 4:20 PM, Joe Perches wrote: > > On Sun, 2014-11-23 at 15:14 +0100, SF Markus Elfring wrote: > >> >> 2. Are any additional prefixes appropriate so that further name space > >> >>conflicts can be better avoided? >

[PATCH 1/1] video: uvesafb: Deletion of an unnecessary check before the function call "platform_device_put"

2014-11-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 23 Nov 2014 17:05:18 +0100 The platform_device_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --

[PATCH] ARM: dts: meson: enable Ethernet controller

2014-11-23 Thread Beniamino Galvani
Add a node for the Ethernet controller to Meson DTS file and enable it on the Geniatech ATV1200 board. Signed-off-by: Beniamino Galvani --- arch/arm/boot/dts/meson.dtsi | 11 +++ arch/arm/boot/dts/meson6-atv1200.dts | 4 2 files changed, 15 insertions(+) diff --git a/arch/

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Borislav Petkov
On Sun, Nov 23, 2014 at 10:56:27AM -0500, Chris Mason wrote: > On Sun, Nov 23, 2014 at 10:02 AM, Chris Mason wrote: > >Since it looks like a race between process exit and /proc, I'll try to > >hammer on that for a better reproduction. But, here's hoping that > >someone has already seen this one:

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 11:11 AM, Borislav Petkov wrote: On Sun, Nov 23, 2014 at 10:56:27AM -0500, Chris Mason wrote: On Sun, Nov 23, 2014 at 10:02 AM, Chris Mason wrote: >Since it looks like a race between process exit and /proc, I'll try to >hammer on that for a better reproduction.

Re: [PATCH v8 5/8] of: i2c: Export single device registration method

2014-11-23 Thread Wolfram Sang
On Fri, Nov 21, 2014 at 01:46:31AM +, Grant Likely wrote: > On Tue, 28 Oct 2014 22:36:02 +0200 > , Pantelis Antoniou > wrote: > > Dynamically inserting i2c client device nodes requires the use > > of a single device registration method. Rework and export it. > > > > Signed-off-by: Pantelis A

Re: [PATCH v8 6/8] OF: i2c: Add OF notifier handler

2014-11-23 Thread Wolfram Sang
> I picked up the patch into my tree and made the above changes because > they're pretty trivial. If Wolfram is okay with it then I can take the > whole series through my tree. Otherwise I'll put the of_reconfig_* empty > stubs into a separate branch that he and broonie can both pull. With your f

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Borislav Petkov
On Sun, Nov 23, 2014 at 11:16:51AM -0500, Chris Mason wrote: > It must be: > > commit 6e998916dfe327e785e7c2447959b2c1a3ea4930 > Author: Stanislaw Gruszka > Date: Wed Nov 12 16:58:44 2014 +0100 > >sched/cputime: Fix clock_nanosleep()/clock_gettime() inconsistency > > I'll do two runs to c

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 11:32 AM, Borislav Petkov wrote: On Sun, Nov 23, 2014 at 11:16:51AM -0500, Chris Mason wrote: It must be: commit 6e998916dfe327e785e7c2447959b2c1a3ea4930 Author: Stanislaw Gruszka Date: Wed Nov 12 16:58:44 2014 +0100 sched/cputime: Fix clock_nanosleep()/cloc

Re: [PATCH tip/core/rcu 3/9] drivers/md: Use rcu_dereference() for accessing rcu pointer

2014-11-23 Thread Eric Dumazet
On Sun, 2014-11-23 at 07:21 -0500, Pranith Kumar wrote: > I am not sure we should be taking rcu_read_lock() there as I am not > sure how long that critical section might last. Can someone who is > more familiar with the code take a look? > > I will try to look for a solution too in the mean time.

[PATCH ] drivers/md: use proper rcu accessor

2014-11-23 Thread Eric Dumazet
From: Eric Dumazet rcu_dereference() should be used in sections protected by rcu_read_lock. For writers, holding some kind of mutex or lock, rcu_dereference_protected() is the way to go, adding explicit lockdep bits. In __unbind(), although there is no mutex or lock held, we are about to free t

[PATCH 1/1] backlight: lp8788: Deletion of an unnecessary check before the function call "backlight_device_unregister"

2014-11-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 23 Nov 2014 17:33:08 +0100 The backlight_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elf

Re: [PATCH 1/2 v2] scripts/coccinelle: catch freeing cryptographic structures via kfree

2014-11-23 Thread Julia Lawall
On Wed, 19 Nov 2014, Konstantin Khlebnikov wrote: > On Wed, Nov 19, 2014 at 12:41 PM, Julia Lawall wrote: > >> +// Comments: There are false positives in crypto/ where they are > >> actually freed. > > > > I didn't really understand this comment. I ran the semantic patch and got > > around 10

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 11:32 AM, Borislav Petkov wrote: On Sun, Nov 23, 2014 at 11:16:51AM -0500, Chris Mason wrote: It must be: commit 6e998916dfe327e785e7c2447959b2c1a3ea4930 Author: Stanislaw Gruszka Date: Wed Nov 12 16:58:44 2014 +0100 sched/cputime: Fix clock_nanosleep()/cloc

Re: [PATCH ] drivers/md: use proper rcu accessor

2014-11-23 Thread Mike Snitzer
On Sun, Nov 23, 2014 at 11:40 AM, Eric Dumazet wrote: > From: Eric Dumazet > > rcu_dereference() should be used in sections protected by rcu_read_lock. > > For writers, holding some kind of mutex or lock, > rcu_dereference_protected() is the way to go, adding explicit lockdep > bits. > > In __unb

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Borislav Petkov
On Sun, Nov 23, 2014 at 11:49:02AM -0500, Chris Mason wrote: > I've adding Ingo and Stanislaw to the cc. With > 6e998916dfe327e785e7c2447959b2c1a3ea4930 reverted, I'm no longer crashing. Ok, reverting here too, to confirm. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my de

Re: [5/5] i2c: davinci: use ICPFUNC to toggle I2C as gpio for bus recovery

2014-11-23 Thread Uwe Kleine-König
Hello, On Thu, Nov 20, 2014 at 12:03:08PM +0200, Grygorii Strashko wrote: > @@ -664,6 +759,7 @@ static int davinci_i2c_probe(struct platform_device *pdev) > if (!of_property_read_u32(pdev->dev.of_node, "clock-frequency", > &prop)) > dev->pd

Re: [PATCH 6/9] sound/pci/ctxfi/ctatc.c: fix error return code

2014-11-23 Thread Sudip Mukherjee
On Sun, Nov 23, 2014 at 01:48:06PM +0100, Julia Lawall wrote: > From: Julia Lawall > > Initialize err before returning on failure, as done elsewhere in the > function. > > Signed-off-by: Julia Lawall > > --- > sound/pci/ctxfi/ctatc.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion

Re: [PATCH v2 4/5] ARM: dts: add pinctrl support to Exynos5410

2014-11-23 Thread Andreas Färber
Am 22.11.2014 um 21:26 schrieb Andreas Färber: > From: Hakjoo Kim > > Add the required pin configuration support to Exynos5410 using pinctrl > interface. > > Signed-off-by: Hakjoo Kim > [AF: Rebased, style changes] > Signed-off-by: Andreas Färber > --- > v1 -> v2: > * Filled in Sob from Hakjoo

[PATCH v3 4/5] ARM: dts: add pinctrl support to Exynos5410

2014-11-23 Thread Andreas Färber
From: Hakjoo Kim Add the required pin configuration support to Exynos5410 using pinctrl interface. Signed-off-by: Hakjoo Kim [AF: Rebased, style changes] Signed-off-by: Andreas Färber --- v2 -> v3: * Added wake-up IRQ controller node (Tomasz Figa) v1 -> v2: * Filled in Sob from Hakjoo Ki

Re: task_stat splat

2014-11-23 Thread Oleg Nesterov
On 11/23, Borislav Petkov wrote: > > where we end up with a zero PMD. RIP is corrupted too so we're somewhere > off in the fields. PMD = 0 is fine I guess, addr == 0 is not mapped. > Comment over thread_group_cputime() talks about dead tasks accounting This comment simply means that we also need

Re: [PATCH] Drivers:staging:wlan-ng: Fixed line over 80 characters warning

2014-11-23 Thread Sudip Mukherjee
On Sun, Nov 23, 2014 at 03:26:54PM +0530, Lekshmi wrote: > The following chaeckpatch warning was fixed: > WARNING: line over 80 characters > > Signed-off-by: Lekshmi > --- > drivers/staging/wlan-ng/prism2fw.c |6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/driv

Re: [PATCH ] drivers/md: use proper rcu accessor

2014-11-23 Thread Eric Dumazet
On Sun, 2014-11-23 at 11:53 -0500, Mike Snitzer wrote: > On Sun, Nov 23, 2014 at 11:40 AM, Eric Dumazet wrote: > > From: Eric Dumazet > > > > rcu_dereference() should be used in sections protected by rcu_read_lock. > > > > For writers, holding some kind of mutex or lock, > > rcu_dereference_prote

  1   2   3   4   >