Re: [PATCH v2 1/3] vt: add cursor blink interval escape sequence

2015-03-28 Thread Pavel Machek
On Fri 2015-03-27 20:35:03, Mike Frysinger wrote: > On 26 Mar 2015 13:54, Scot Doyle wrote: > > Add an escape sequence to specify the current console's cursor blink > > interval. The interval is specified as a number of milliseconds until > > the next cursor display state toggle, from 50 to 65535.

Re: [PATCH v2 3/3] console_codes.4: Add CSI sequence for cursor blink interval

2015-03-28 Thread Pavel Machek
On Thu 2015-03-26 13:57:44, Scot Doyle wrote: > Add a Console Private CSI sequence to specify the current console's > cursor blink interval. The interval is specified as a number of > milliseconds until the next cursor display state toggle, from 50 to > 65535. > > Signed-off-by: Scot Doyle Acked

Re: [PATCH v2 0/3] add cursor blink interval terminal escape sequence

2015-03-28 Thread Pavel Machek
On Thu 2015-03-26 13:51:04, Scot Doyle wrote: > v2: Add documentation to console_codes man page (man-pages repo) > > This patch series adds an escape sequence to specify the current console's > cursor blink interval. The default interval is set to fbcon's currently > hardcoded 200 msecs. Actuall

Re: [PATCH] perf, record: Add clockid parameter

2015-03-28 Thread Peter Zijlstra
On Fri, Mar 27, 2015 at 03:37:47PM -0700, Stephane Eranian wrote: > > + OPT_INTEGER('k', "clockid", &record.opts.clockid, > > + "clockid to use for events"), > > I think you'd want a symbolic name for the clock to make this easier > on the user. Sure, here goes. -- Subjec

Re: [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"

2015-03-28 Thread Piotr Witosławski
On Sat, Mar 28, 2015 at 11:56:40AM +0530, Sudip Mukherjee wrote: > On Fri, Mar 27, 2015 at 09:36:07PM +0100, Witos wrote: > > Changed bool to u8 to get rid of sparse warning. > but i am not getting this warning. which version of sparse are you > using? sparse 0.5.0, see: http://yarchive.net/comp/l

Re: d63e2e1f3df breaks sparc/T5-8

2015-03-28 Thread Sam Ravnborg
> >> config ARM_THUMB > >> bool "Support Thumb user binaries" if !CPU_THUMBONLY > >> depends on CPU_ARM720T || CPU_ARM740T || CPU_ARM920T || CPU_ARM922T > >> || \ > >> Index: linux-2.6/arch/arm64/Kconfig > >> === > >> ---

Re: [PATCH v4 2/4] mfd: lubbock_cplds: add lubbock IO board

2015-03-28 Thread Robert Jarzmik
Arnd Bergmann writes: > On Thursday 26 March 2015, Robert Jarzmik wrote: >> >> Greg Kroah-Hartman writes: >> >> > On Fri, Feb 20, 2015 at 05:02:57PM +0100, Robert Jarzmik wrote: >> >> If there is no solution, I'll fallback through arch/arm/plat-pxa, not >> >> very nice, >> >> but it has to la

Re: [RFC] x86, ia32entry: Use sysretl to return from sysenter

2015-03-28 Thread Ingo Molnar
* Andy Lutomirski wrote: > Sysexit is scary on 64-bit kernels -- sysexit must be invoked with > usergs and IRQs on. That means that we rely on sti to correctly > mask interrupts for one instruction. This is okay by itself, but > the semantics with respect to NMIs are unclear. At least judging

[tip:x86/asm] x86/asm/entry/32: Update "interrupt off" comments

2015-03-28 Thread tip-bot for Denys Vlasenko
Commit-ID: a232e3d558eef421fbb539ede5483dfb668e38f2 Gitweb: http://git.kernel.org/tip/a232e3d558eef421fbb539ede5483dfb668e38f2 Author: Denys Vlasenko AuthorDate: Fri, 27 Mar 2015 11:36:20 +0100 Committer: Ingo Molnar CommitDate: Fri, 27 Mar 2015 12:27:57 +0100 x86/asm/entry/32: Update

[tip:x86/asm] x86/asm/entry/64: Add missing CFI annotation

2015-03-28 Thread tip-bot for Denys Vlasenko
Commit-ID: 27be87c5d53117f048d590d6fc6febb21176c3e9 Gitweb: http://git.kernel.org/tip/27be87c5d53117f048d590d6fc6febb21176c3e9 Author: Denys Vlasenko AuthorDate: Fri, 27 Mar 2015 11:36:19 +0100 Committer: Ingo Molnar CommitDate: Fri, 27 Mar 2015 12:27:57 +0100 x86/asm/entry/64: Add mis

[tip:x86/asm] x86/asm/entry/32: Make register zero-extension more prominent

2015-03-28 Thread tip-bot for Denys Vlasenko
Commit-ID: 4ee8ec17ba00fce4af042543771f996fb9d98d34 Gitweb: http://git.kernel.org/tip/4ee8ec17ba00fce4af042543771f996fb9d98d34 Author: Denys Vlasenko AuthorDate: Fri, 27 Mar 2015 11:36:21 +0100 Committer: Ingo Molnar CommitDate: Fri, 27 Mar 2015 12:27:57 +0100 x86/asm/entry/32: Make re

Re: [PATCH 15/17] x86, mpx: do 32-bit-only cmpxchg for 32-bit apps

2015-03-28 Thread Borislav Petkov
On Fri, Mar 27, 2015 at 11:16:41AM -0700, Dave Hansen wrote: > That would have saved creating 'u32 __user *bd_entry_32' so that we > could implicitly do sizeof(*bd_entry_32). But, what else does it buy us? Well, you could misappropriate futex_atomic_cmpxchg_inatomic() which takes u32s already - y

Re: [PATCH] Input: ALPS - Detect trackstick presence for v7 protocol

2015-03-28 Thread Pali Rohár
On Saturday 28 March 2015 04:43:35 Dmitry Torokhov wrote: > On Sat, Mar 28, 2015 at 01:30:58AM +, Santiago Gala wrote: > > The behaviour is the same with 3.19.1 as with 4.0.0-rc5 + > > the patched psmouse you give me. The difference in lsinput > > is just name and current position: > > > > $ d

Revised futex(2) man page for review

2015-03-28 Thread Michael Kerrisk (man-pages)
Hello all, As becomes quickly obvious upon reading it, the current futex(2) man page is in a sorry state, lacking many important details, and also the various additions that have been made to the interface over the last years. I've been working on revising it, first of all based on input I got in

Re: Revised futex(2) man page for review

2015-03-28 Thread Michael Kerrisk (man-pages)
On 03/28/2015 09:53 AM, Michael Kerrisk (man-pages) wrote: > Hello all, [...] > So, please take a look at the page below. At this point, > I would most especially appreciate help with the FIXMEs. One more point I should have added. The revised page currently sits in a Git branch, here: http://git.

Re: [PATCH] perf build: Suppress warning about missing libbabeltrace

2015-03-28 Thread Ingo Molnar
* Jiri Olsa wrote: > On Fri, Mar 27, 2015 at 12:18:55PM +0100, Ingo Molnar wrote: > > > > * Jiri Olsa wrote: > > > > > Be silent about missing babeltrace library until the needed > > > version (1.3) is pushed into most common distros. > > > > > > Requested-by: Ingo Molnar > > > Signed-off-b

[PATCH 2/2] staging: sm7xxfb: disable pci device

2015-03-28 Thread Sudip Mukherjee
disable the pci device when the module exits. Signed-off-by: Sudip Mukherjee --- drivers/staging/sm7xxfb/sm7xxfb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c index 149286e..77f51a0 100644 --- a/drivers/staging/sm7xxf

[PATCH 1/2] staging: sm7xxfb: reserve PCI resource

2015-03-28 Thread Sudip Mukherjee
before starting to access any address inside the PCI region we should reserve the resource and release the resource when the module exits. Signed-off-by: Sudip Mukherjee --- drivers/staging/sm7xxfb/sm7xxfb.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/staging/sm7xxfb/

Re: [PATCH] x86/asm/entry/64: better check for canonical address

2015-03-28 Thread Ingo Molnar
* Denys Vlasenko wrote: > On 03/27/2015 01:16 PM, Ingo Molnar wrote: > >>> Indeed, an IRET ought to be pretty cheap for same-ring interrupt > >>> returns in any case. > >> > >> Unfortunately, it is not. Try attached program. > >> > >> On this CPU, 1 ns ~= 3 cycles. > >> > >> $ ./timing_test64 c

Re: ia32_sysenter_target does not preserve EFLAGS

2015-03-28 Thread Ingo Molnar
* Linus Torvalds wrote: > On Fri, Mar 27, 2015 at 1:53 PM, Brian Gerst wrote: > >> <-- IRQ. Boom > > > > The sti will delay interrupts for one instruction, and that should include > > NMIs. > > Nope. Intel explicitly documents the NMI case only for mov->ss and popss. Interestingly, I still

Re: ia32_sysenter_target does not preserve EFLAGS

2015-03-28 Thread Olivier Galibert
Hi, Beware that could be opening the door to information leaks for a very small gain (most syscalls are not getuid). Best, OG. On Sat, Mar 28, 2015 at 1:34 AM, Denys Vlasenko wrote: > On Fri, Mar 27, 2015 at 9:00 PM, Linus Torvalds > wrote: >> On Fri, Mar 27, 2015 at 7:25 AM, Denys Vlase

Re: ia32_sysenter_target does not preserve EFLAGS

2015-03-28 Thread Ingo Molnar
* Linus Torvalds wrote: > On Fri, Mar 27, 2015 at 1:53 PM, Brian Gerst wrote: > >> <-- IRQ. Boom > > > > The sti will delay interrupts for one instruction, and that should include > > NMIs. > > Nope. Intel explicitly documents the NMI case only for mov->ss and popss. > > > The Intel SDM sta

Re: ia32_sysenter_target does not preserve EFLAGS

2015-03-28 Thread Borislav Petkov
On Fri, Mar 27, 2015 at 01:09:34PM -0700, Linus Torvalds wrote: > I think AMD documented that the sti "interrupt shadow" shadows even > NMI. Hmm, official docs says this: "15.21.5 Interrupt Shadows The x86 architecture defines the notion of an interrupt shadow—a single-instruction window during

Re: ia32_sysenter_target does not preserve EFLAGS

2015-03-28 Thread Ingo Molnar
* Denys Vlasenko wrote: > On Fri, Mar 27, 2015 at 9:00 PM, Linus Torvalds > wrote: > > On Fri, Mar 27, 2015 at 7:25 AM, Denys Vlasenko wrote: > >> > >> Apparently, users *don't* depend on arithmetic flags > >> to survive over syscall. They also okay with DF flag > >> being cleared. > > > > Gen

Re: [RFC] vmstat: Avoid waking up idle-cpu to service shepherd work

2015-03-28 Thread Peter Zijlstra
On Sat, Mar 28, 2015 at 09:48:28AM +0530, Viresh Kumar wrote: > On Fri, Mar 27, 2015 at 3:00 PM, Peter Zijlstra wrote: > > On Fri, Mar 27, 2015 at 10:16:13AM +0100, Peter Zijlstra wrote: > > >> So the issue seems to be that we need base->running_timer in order to > >> tell if a callback is runnin

[GIT PULL] locking fix

2015-03-28 Thread Ingo Molnar
Linus, Please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus # HEAD: 35a9393c95b31870a74f51a3e7455f33f5657b6f lockdep: Fix the module unload key range freeing logic A module unload lockdep race f

[GIT PULL] perf fix

2015-03-28 Thread Ingo Molnar
Linus, Please pull the latest perf-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf-urgent-for-linus # HEAD: d525211f9d1be8b523ec7633f080f2116f5ea536 perf: Fix irq_work 'tail' recursion A perf kernel side fix for a fuzzer triggered lockup.

[PATCH 0/2] i8k.c => dell-smm-hwmon.c

2015-03-28 Thread Pali Rohár
This patch series moves drivers/char/i8k.c to drivers/hwmon/dell-smm-hwmon.c and allows to compile hwmon driver without /proc/i8k file. Pali Rohár (2): hwmon: Rename i8k driver to dell-smm-hwmon and move it to hwmon tree hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k MAINTAI

[PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Pali Rohár
This patch splits CONFIG_I8K compile option to SENSORS_DELL_SMM and CONFIG_I8K. Option SENSORS_DELL_SMM is now used to enable compilation of dell-smm-hwmon driver and old CONFIG_I8K option to enable /proc/i8k interface in driver. So this change allows to compile dell-smm-hwmon driver without legac

[PATCH 1/2] hwmon: Rename i8k driver to dell-smm-hwmon and move it to hwmon tree

2015-03-28 Thread Pali Rohár
This commit moves i8k driver to hwmon tree under name dell-smm-hwmon which is better name then abbreviation i8k. For backward compatibility is added macro MODULE_ALIAS("i8k") so modprobe will load driver also old name i8k. CONFIG_I8K compile option was not changed. This commit also adds me as main

[PATCH] perf build: Disable libbabeltrace check by default

2015-03-28 Thread Jiri Olsa
On Sat, Mar 28, 2015 at 10:03:28AM +0100, Ingo Molnar wrote: SNIP > > > > I thought about this as of generic feature for all checks, but given > > that this is the only case so far, how about attached patch? > > > > it's changing the NO_LIBBABELTRACE to LIBBABELTRACE so the libbabeltrace > > ch

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-03-28 Thread Paul E. McKenney
On Wed, Mar 25, 2015 at 04:01:24PM +0100, Patrick Marlier wrote: > On 03/25/2015 03:30 PM, Paul E. McKenney wrote: > >On Tue, Mar 24, 2015 at 11:31:38AM +0100, Patrick Marlier wrote: > >>Change to read effectively ptr with rcu_dereference_raw and not the > >>__ptr variable on the stack. > >> > >>Si

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

2015-03-28 Thread Paul E. McKenney
On Sat, Mar 28, 2015 at 03:42:10AM -0700, Paul E. McKenney wrote: > On Wed, Mar 25, 2015 at 04:01:24PM +0100, Patrick Marlier wrote: > > On 03/25/2015 03:30 PM, Paul E. McKenney wrote: > > >On Tue, Mar 24, 2015 at 11:31:38AM +0100, Patrick Marlier wrote: > > >>Change to read effectively ptr with rc

[PATCH] btrfs: unlock i_mutex after attempting to delete subvolume during send

2015-03-28 Thread Omar Sandoval
Whenever the check for a send in progress introduced in commit 521e0546c970 (btrfs: protect snapshots from deleting during send) is hit, we return without unlocking inode->i_mutex. This is easy to see with lockdep enabled: [ +0.59] [ +0.28

Re: ia32_sysenter_target does not preserve EFLAGS

2015-03-28 Thread Denys Vlasenko
On Sat, Mar 28, 2015 at 1:39 AM, Linus Torvalds wrote: > What part of "don't leak kernel data" did you have trouble understanding? > > IOW, this is a *security* issue. Stop arguing for crazy shit. We can zero the registers instead of saving/restoring them. push/pop pair takes 1-2 cycles at best,

Re: [PATCH] tools: iio: generic_buffer: Fix generic scale extraction

2015-03-28 Thread Jonathan Cameron
On 27/03/15 12:57, Daniel Baluta wrote: > On Fri, Mar 27, 2015 at 1:53 PM, Irina Tirdea wrote: >> When using generic_buffer to read data, the scale is not properly >> detected for scale shared by type. This is caused by a problem >> with the generation of generic name out of the full name. >> E.g.

Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Paul Bolle
On Sat, 2015-03-28 at 11:24 +0100, Pali Rohár wrote: > --- a/drivers/hwmon/Kconfig > +++ b/drivers/hwmon/Kconfig > @@ -1703,6 +1703,17 @@ config SENSORS_ULTRA45 > This driver provides support for the Ultra45 workstation environmental > sensors. > > +config SENSORS_DELL_SMM > +

Re: [PATCH] tools: iio: Add help option for generic_buffer

2015-03-28 Thread Jonathan Cameron
On 27/03/15 12:42, Alin Arhip wrote: > From: Alin Gabriel Arhip > > This patch adds usage instructions and -h parameter to view available > command line parameters. > > Signed-off-by: Alin Gabriel Arhip Good in principal, but I wonder if we can't make it more informative. Some of the help is ta

Re: [PATCH] IIO: Add support for L3GD20H gyroscope

2015-03-28 Thread Jonathan Cameron
On 24/03/15 10:29, Linus Walleij wrote: > On Mon, Mar 23, 2015 at 2:40 PM, Robert Dolca wrote: > >> It can be used exactly like L3GD20 but it has a different WhoAmI >> register value. >> >> Signed-off-by: Robert Dolca > > Reviewed-by: Linus Walleij > > Yours, > Linus Walleij > Applied to the

Re: ia32_sysenter_target does not preserve EFLAGS

2015-03-28 Thread Denys Vlasenko
On Sat, Mar 28, 2015 at 10:46 AM, Ingo Molnar wrote: > * Denys Vlasenko wrote: >> This is a C function. [...] > > Arguably that's a self-inflicted wound of uclibc: nothing keeps it > from taking advantage of the syscall ABI and avoiding the double > save/restores. It's not uclibc who calls write

Re: [PATCH] btrfs: unlock i_mutex after attempting to delete subvolume during send

2015-03-28 Thread Filipe David Manana
On Sat, Mar 28, 2015 at 11:02 AM, Omar Sandoval wrote: > Whenever the check for a send in progress introduced in commit > 521e0546c970 (btrfs: protect snapshots from deleting during send) is > hit, we return without unlocking inode->i_mutex. This is easy to see > with lockdep enabled: > > [ +0.00

[RFC] bpf: Suggestion on bpf syscall interface

2015-03-28 Thread He Kuang
Hi, Alexei In our end-end IO module project, we use bpf maps to record configurations. According to current bpf syscall interface, we should specify map_fd to lookup/update bpf maps, so we are restricted to do config in the same user program. My suggestion is to export this kind of operations to

Re: [RFC] vmstat: Avoid waking up idle-cpu to service shepherd work

2015-03-28 Thread Peter Zijlstra
On Sat, Mar 28, 2015 at 09:58:38AM +0530, Viresh Kumar wrote: > On 27 March 2015 at 17:32, Peter Zijlstra wrote: > > What's not clear to me is why that thing is allocated at all, AFAICT > > something like: > > > > static DEFINE_PER_CPU(struct tvec_base, tvec_bases); > > > > Should do the right thi

Re: Revised futex(2) man page for review

2015-03-28 Thread Peter Zijlstra
On Sat, Mar 28, 2015 at 09:53:21AM +0100, Michael Kerrisk (man-pages) wrote: > So, please take a look at the page below. At this point, > I would most especially appreciate help with the FIXMEs. For people who cannot read that troff gibberish (me).. --- FUTEX(2) Linux Programmer

Re: [PATCH 1/3] iio: configfs: Add configfs support to IIO

2015-03-28 Thread Jonathan Cameron
On 27/03/15 17:17, Lars-Peter Clausen wrote: > On 03/25/2015 06:00 PM, Daniel Baluta wrote: >> This creates an IIO configfs subsystem named "iio", which has one default >> group named "triggers". This allows us to easily create/destroy software >> triggers. One must create a driver which implements

Re: [PATCH 3/3] iio: Documentation: Add initial documentaton for IIO

2015-03-28 Thread Jonathan Cameron
On 25/03/15 19:28, Daniel Baluta wrote: > On Wed, Mar 25, 2015 at 7:22 PM, Peter Meerwald wrote: >> On Wed, 25 Mar 2015, Daniel Baluta wrote: >> >>> This file wants to be a starting point document for anyone wanting >>> to use IIO configfs support or adding new IIO configfs functionality. >> >> ty

Re: [PATCH 3/3] iio: Documentation: Add initial documentaton for IIO

2015-03-28 Thread Jonathan Cameron
On 25/03/15 17:00, Daniel Baluta wrote: > This file wants to be a starting point document for anyone wanting > to use IIO configfs support or adding new IIO configfs functionality. > > Signed-off-by: Daniel Baluta Looks like a good flexible structure to me. Thanks! > --- > Documentation/iio/iio

Re: [RFC] vmstat: Avoid waking up idle-cpu to service shepherd work

2015-03-28 Thread viresh kumar
On 28 March 2015 at 15:23, Peter Zijlstra wrote: > Well, for one your patch is indeed disgusting. Yeah, I agree :) > But yes I'm aware Thomas > wants to rewrite the timer thing. But Thomas is away for a little while > and if this really needs to happen then it does. Sometime back I was trying

Re: [Patch 1/5] dt: unittest: early return from test skips tests

2015-03-28 Thread Grant Likely
On Fri, 13 Mar 2015 23:57:40 -0700 , Frank Rowand wrote: > From: Frank Rowand > > Fix bugs pointed out by checkpatch. > > Mis-coding of two if statements caused early return from function. > > Number of tests completed increased from 102 to 107. > Number of tests failed increased from 0 to 2.

Re: [Patch] dt: OF_UNITTEST make dependency broken

2015-03-28 Thread Grant Likely
On Fri, 13 Mar 2015 12:21:46 -0700 , Frank Rowand wrote: > From: Frank Rowand > > If CONFIG_OF_UNITTEST=y then a kernel image make will always cause .version to > be incremented, even if there are not source changes. This is caused by > a lack of dependency tracking and checking for > drivers/

Re: Revised futex(2) man page for review

2015-03-28 Thread Peter Zijlstra
On Sat, Mar 28, 2015 at 12:47:25PM +0100, Peter Zijlstra wrote: >FUTEX_WAIT (since Linux 2.6.0) > This operation tests that the value at the futex word pointed to > by the address uaddr still contains the expected value val, and > if so, then sle

Re: [PATCH v3 1/3] of/unittest: replace 'selftest' with 'unittest'

2015-03-28 Thread Grant Likely
On Tue, 17 Mar 2015 03:19:58 + , Wang Long wrote: > This patch just replace the string 'selftest' with 'unittest' > in OF unittest and data and binding file. > > I have tested it successfully on ARM. > > Signed-off-by: Gaurav Minocha > Signed-off-by: Wang Long Unfortunately, this is goin

Re: [PATCH v4 1/3] iio: adc: vf610: use ADC clock within specification

2015-03-28 Thread Jonathan Cameron
On 24/03/15 12:47, Stefan Agner wrote: > Depending on conversion mode used, the ADC clock (ADCK) needs > to be below a maximum frequency. According to Vybrid's data > sheet this is 20MHz for the low power conversion mode. > > The ADC clock is depending on input clock, which is the bus > clock by d

Re: [PATCH v2 1/2] Documentation: update the of_selftest.txt

2015-03-28 Thread Grant Likely
On Tue, 10 Mar 2015 09:50:58 -0500 , Rob Herring wrote: > On Tue, Mar 10, 2015 at 9:44 AM, Rob Herring wrote: > > On Sun, Mar 8, 2015 at 9:35 PM, Wang Long wrote: > >> Since the directory "drivers/of/testcase-data" is renamed > >> to "drivers/of/unittest-data". so we should update the path > >>

[PATCH] of/unittest: Fix of_platform_depopulate test case

2015-03-28 Thread Grant Likely
The previous commit, "of/unittest: early return from test skips tests" exposed broken tests for the of_platform_unpopulate() function. The problem was the populate and depopulate calls were not symmetrical like they were intended to be, and unpopulate depends on the parent device to have it's of_no

Re: [PATCH v3 3/3] Documentation: update the of_unittest.txt

2015-03-28 Thread Grant Likely
On Tue, 17 Mar 2015 03:20:00 + , Wang Long wrote: > Since the directory "drivers/of/testcase-data" is renamed > to "drivers/of/unittest-data". so we should update the path > in the of_selftest.txt. > > When the kernel is built with OF_UNITTEST enabled, the output > dtb is testcases.dtb inste

Re: [RFC] vmstat: Avoid waking up idle-cpu to service shepherd work

2015-03-28 Thread Viresh Kumar
On 28 March 2015 at 17:27, viresh kumar wrote: > On 28 March 2015 at 15:23, Peter Zijlstra wrote: > >> Well, for one your patch is indeed disgusting. > > Yeah, I agree :) Sigh.. Sorry for the series of *nonsense* mails before the last one. Its some thunderbird *BUG* which did that, I was acces

Re: [PATCH v3 2/3] Documentation: rename of_selftest.txt to of_unittest.txt

2015-03-28 Thread Grant Likely
On Tue, 17 Mar 2015 03:19:59 + , Wang Long wrote: > Since the test of the devicetree's OF api use unittest as > its name. so we should rename of_selftest.txt to of_unittest.txt. > > Signed-off-by: Wang Long Applied, thanks. g. > --- > Documentation/devicetree/{of_selftest.txt => of_unit

Re: [Patch 0/5] dt: unittest: fix breakage and warnings

2015-03-28 Thread Grant Likely
On Fri, 13 Mar 2015 22:25:51 -0700 , Frank Rowand wrote: > Running checkpatch on early versions of my patchset to fix the devicetree > make dependency issues exposed a large number of warnings, including some that > are actual bugs. http://lkml.iu.edu/hypermail/linux/kernel/1503.1/03335.html >

Re: [PATCH v4 2/3] iio: adc: vf610: implement configurable conversion modes

2015-03-28 Thread Jonathan Cameron
On 24/03/15 12:47, Stefan Agner wrote: > Support configurable conversion mode through sysfs. So far, the > mode used was low-power, which is enabled by default now. Beside > that, the modes normal and high-speed are selectable as well. > > Use the new device tree property which specifies the maxim

[PATCH] x86, doc: Remove cmdline_size from list of fields to be filled in for EFI handover

2015-03-28 Thread Alex Smith
The cmdline_size field in setup_header is listed as read-only, and is never read by the kernel. Therefore, there is no need for it to be set by a boot loader implementing the EFI handover protocol, so remove it from the list of fields required to be set by a boot loader. Signed-off-by: Alex Smith

Re: [PATCH v1 09/47] vidoe: fbdev: atyfb: remove and fix MTRR MMIO "hole" work around

2015-03-28 Thread Ville Syrjälä
On Sat, Mar 28, 2015 at 01:28:18AM +0100, Luis R. Rodriguez wrote: > On Fri, Mar 27, 2015 at 03:02:10PM -0700, Andy Lutomirski wrote: > > On Fri, Mar 27, 2015 at 2:56 PM, Ville Syrjälä wrote: > > > On Fri, Mar 27, 2015 at 08:57:59PM +0100, Luis R. Rodriguez wrote: > > >> On Fri, Mar 27, 2015 at 12

Re: [PATCH v3 01/15] staging: rtl8723au: Reformat whitespace to increase readability

2015-03-28 Thread M. Vefa Bicakci
On 26/03/15 08:18 AM, Greg KH wrote: > On Thu, Mar 19, 2015 at 12:39:04AM -0400, M. Vefa Bicakci wrote: >> Adjust the whitespace in the signature, local variable declaration and >> initialization parts of a number of functions to increase readability >> in rtl8723au's rtw_security.c. >> >> v2: Make

Re: mm: lru_add_drain_all hangs

2015-03-28 Thread Vlastimil Babka
On 27.3.2015 22:36, Sasha Levin wrote: > On 03/27/2015 06:07 AM, Vlastimil Babka wrote: >>> [ 3614.918852] trinity-c7 D 8802f4487b58 26976 16252 9410 >>> 0x1000 [ 3614.919580] 8802f4487b58 8802f6b98ca8 [ 3614.920435] 88

Re: [PATCH v4 2/3] iio: adc: vf610: implement configurable conversion modes

2015-03-28 Thread Stefan Agner
On 2015-03-28 13:07, Jonathan Cameron wrote: > On 24/03/15 12:47, Stefan Agner wrote: >> Support configurable conversion mode through sysfs. So far, the >> mode used was low-power, which is enabled by default now. Beside >> that, the modes normal and high-speed are selectable as well. >> >> Use the

[PATCH v4 00/15] checkpatch clean-up of rtl8723au's rtw_security.c

2015-03-28 Thread M. Vefa Bicakci
These commits address a number of checkpatch.pl warnings and errors in rtl8723au's rtw_security.c. Prior to this set of commits, checkpatch.pl reported the following: total: 76 errors, 138 warnings, 1621 lines checked After applying this set of commits, checkpatch.pl reports the following

[PATCH v4 10/15] staging: rtl8723au: No spaces at the start of a line

2015-03-28 Thread M. Vefa Bicakci
Prior to this commit, a large block of constants used to represent an AES S-box table were indented with spaces in rtl8723au's rtw_security.c. Correct the checkpatch.pl warnings indicating that spaces should not be used to indent lines: WARNING: please, no spaces at the start of a line Sig

[PATCH v4 01/15] staging: rtl8723au: Reformat whitespace to increase readability

2015-03-28 Thread M. Vefa Bicakci
Adjust the whitespace in the signature, local variable declaration and initialization parts of a number of functions to increase readability in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- v2: Make sure that the arcfour_encrypt function's argument list is split according t

[PATCH v4 12/15] staging: rtl8723au: suspect code indent for conditional statements

2015-03-28 Thread M. Vefa Bicakci
Correct a number of indentation-with-spaces-and-tabs issues in rtl8723au's rtw_security.c, according to checkpatch.pl: WARNING: suspect code indent for conditional statements Signed-off-by: M. Vefa Bicakci --- v3: Make sure that all edited lines are at most 80 characters wide. --- driv

[PATCH v4 15/15] staging: rtl8723au: Remove unneeded comments

2015-03-28 Thread M. Vefa Bicakci
This commit removes a number of unneeded comments. Two of the aforementioned comments were most likely meant to aid with version control, whereas the remaining two comments relate to (now unused) local variable names. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security

[PATCH v4 11/15] staging: rtl8723au: Adjust whitespace in and around comments

2015-03-28 Thread M. Vefa Bicakci
As the subject indicates, adjust whitespace in and around comments in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 114 +- 1 file changed, 57 insertions(+), 57 deletions(-) diff --git a/drivers/staging/rtl

[PATCH v4 04/15] staging: rtl8723au: Fix the indentation of two lines

2015-03-28 Thread M. Vefa Bicakci
Correct the indentation of two lines in rtw_tkip_encrypt23a function in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security

Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Steven Honeyman
On 28 March 2015 at 11:04, Paul Bolle wrote: > On Sat, 2015-03-28 at 11:24 +0100, Pali Rohár wrote: >> --- a/drivers/hwmon/Kconfig >> +++ b/drivers/hwmon/Kconfig >> @@ -1703,6 +1703,17 @@ config SENSORS_ULTRA45 >> This driver provides support for the Ultra45 workstation >> environmental >

[PATCH v4 14/15] staging: rtl8723au: Use __func__ in trace logs

2015-03-28 Thread M. Vefa Bicakci
Rework the trace log-related lines in rtl8723au's rtw_security.c to use the __func__ GCC magic variable instead of hardcoding the function names into the trace log strings. This also corrects a copy-paste-related typo in the function named rtw_tkip_decrypt23a. Thanks to Jes Sorensen for the sugges

[PATCH v4 07/15] staging: rtl8723au: Remove unneeded curly braces

2015-03-28 Thread M. Vefa Bicakci
Correct a number of checkpatch.pl warnings in rtl8723au's rtw_security.c related to the existence of unnecessary curly braces around single statement blocks: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core

[PATCH v4 02/15] staging: rtl8723au: Fix "before/around/after" whitespace issues

2015-03-28 Thread M. Vefa Bicakci
Correct a number of "space(s) required before/around/after" checkpatch.pl issues in a number of functions in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- v2: Correct one more whitespace issue ("length-4") in rtw_tkip_decrypt23a. --- drivers/staging/rtl8723au/core/rtw_secu

[PATCH v4 13/15] staging: rtl8723au: Rework two byte array comparisons

2015-03-28 Thread M. Vefa Bicakci
Prior to this commit, rtl8723au's rtw_security.c had two instances of byte array comparisons (for CRC checks) where the individual elements of the byte arrays were compared one by one and an error trace would be output if the byte arrays were determined to be different. This commit improves the re

[PATCH v4 09/15] staging: rtl8723au: that open brace should be on the previous line

2015-03-28 Thread M. Vefa Bicakci
Correct two instances of the checkpatch.pl error indicating that the opening curly braces should not be on new lines: ERROR: that open brace { should be on the previous line Signed-off-by: M. Vefa Bicakci --- v3: Make sure that all edited lines are at most 80 characters wide. --- drive

[PATCH v4 05/15] staging: rtl8723au: Reorganize a few functions to remove indentation

2015-03-28 Thread M. Vefa Bicakci
Prior to this commit, functions rtw_tkip_encrypt23a and rtw_tkip_decrypt23a had large if blocks which contained the majority of the logic in the functions. Rework these functions so that if the negated version of the aforementioned if blocks' conditions are true, we return from the function with _

[PATCH v4 03/15] staging: rtl8723au: else should follow close brace

2015-03-28 Thread M. Vefa Bicakci
Correct checkpatch.pl errors in rtl8723au's rtw_security.c indicating that an else statement should follow the closing brace of the previous if/else if code block: ERROR: else should follow close brace '}' Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c |

[PATCH v4 08/15] staging: rtl8723au: trailing statements should be on next line

2015-03-28 Thread M. Vefa Bicakci
Correct a number of checkpatch.pl errors in rtl8723au's rtw_security.c related to trailing statements: ERROR: trailing statements should be on next line Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 25 + 1 file changed, 17 ins

[PATCH v4 06/15] staging: rtl8723au: else is not generally useful after a return

2015-03-28 Thread M. Vefa Bicakci
Correct a checkpatch.pl warning regarding rtl8723au's rtw_security.c::crc32_init pointing out that having an else statement after a break or a return is not useful. drivers/staging/rtl8723au/core/rtw_security.c:105: WARNING: else is not generally useful after a break or return Signed-off-

Re: [RFC][PATCH 09/10] v4l: Export enums used by tracepoints to user space

2015-03-28 Thread Xie XiuQi
On 2015/3/28 5:37, Steven Rostedt wrote: > #define show_field(field)\ > - __print_symbolic(field, \ > - { V4L2_FIELD_ANY, "ANY" },\ > - { V4L2_FIELD_NONE,

Re: security problem with seccomp-filter

2015-03-28 Thread Kees Cook
On Thu, Mar 26, 2015 at 11:39 PM, Richard Weinberger wrote: > Cc'ing seccomp folks. > > On Fri, Mar 27, 2015 at 6:56 AM, Felix von Leitner > wrote: >> Hi, >> >> I have had some great success with seccomp-filter a while ago, so I >> decided to use it to add some defense in depth to a ping program

Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

2015-03-28 Thread Kees Cook
On Fri, Mar 27, 2015 at 7:44 AM, Borislav Petkov wrote: > On Fri, Mar 27, 2015 at 12:38:21PM +0100, Hector Marco-Gisbert wrote: >> A bug in Linux ASLR implementation which affects some AMD processors has been >> found. The issue affects to all Linux process even if they are not using >> shared lib

Re: [PATCH v4 2/4] mfd: lubbock_cplds: add lubbock IO board

2015-03-28 Thread Arnd Bergmann
On Saturday 28 March 2015, Robert Jarzmik wrote: > It's not as much a problem as a generic question : does a driver belong to > arch/* ? > > Personaly it would have been far simpler for me to have it through the pxa > tree, > but I want to be sure it's the right place. Others will follow, pxa mai

Re: [PATCH 2/2] show nohz_full cpus in sysfs

2015-03-28 Thread Rik van Riel
On 03/28/2015 12:18 AM, Mike Galbraith wrote: > On Fri, 2015-03-27 at 17:50 -0400, r...@redhat.com wrote: >> From: Rik van Riel >> >> Currently there is no way to query which CPUs are in nohz_full >> mode from userspace. > > Hm, they're both (as of your last set) invariant. So are most of the o

[PATCH] Documentation: usb: serial: fixed how to provide vendor and product id

2015-03-28 Thread Marek Belisko
From: "H. Nikolaus Schaller" While trying to test the Pyra GSM/GPS/3G module I had reconfigured the USB interface by mistake and therefore needed to run a different USB driver than CSC-ACM. It turned out that I need the "usbserial" driver. This file is an official description how to use it: Docu

Re: [RFC] vmstat: Avoid waking up idle-cpu to service shepherd work

2015-03-28 Thread Peter Zijlstra
On Sat, Mar 28, 2015 at 05:27:23PM +0530, viresh kumar wrote: > So probably we need to make 'base' aligned to 8 bytes ? Yeah, something like the below (at the very end) should ensure the thing is cacheline aligned, that should give us a fair few bits. > So, what you are suggesting is something li

[GIT PULL] scheduler fix

2015-03-28 Thread Ingo Molnar
Linus, Please pull the latest sched-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched-urgent-for-linus # HEAD: 746db9443ea57fd9c059f62c4bfbf41cf224fe13 sched: Fix RLIMIT_RTTIME when PI-boosting to RT A single sched/rt corner case fix for RLI

[GIT PULL] timer fixes

2015-03-28 Thread Ingo Molnar
Linus, Please pull the latest timers-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers-urgent-for-linus # HEAD: 6e206020324c50a95486f6b279a53512febed92d clocksource/drivers/sun5i: Fix cpufreq interaction with sched_clock() Two clocksource d

[GIT PULL] x86 fix

2015-03-28 Thread Ingo Molnar
Linus, Please pull the latest x86-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-urgent-for-linus # HEAD: b3494a4ab20f6bdf74cdf2badf7918bb65ee8a00 x86/asm/entry: Check for syscall exit work with IRQs disabled Fix x86 syscall exit code bug t

Re: [PATCH 2/2] Input: Add driver for a generic ADC keypad

2015-03-28 Thread Jonathan Cameron
On 28/03/15 00:43, Andrew Bresticker wrote: > Add a polled input driver for a keypad in which the buttons are connected > in resistor ladders to an ADC. The IIO framework is used to claim and > read the ADC channels. > > Signed-off-by: Andrew Bresticker The IIO side of things looks fine. > --- >

Re: [PATCH 1/2] Input: Add binding document for a generic ADC keypad

2015-03-28 Thread Jonathan Cameron
On 28/03/15 00:43, Andrew Bresticker wrote: > Add a binding document for a generic ADC keypad. Buttons on an ADC > keypad are connected in a resistor ladder to an ADC. The binding > describes the mapping of ADC channel and voltage ranges to buttons. > > Signed-off-by: Andrew Bresticker > Cc: Ro

Re: [PATCH 2/2] show nohz_full cpus in sysfs

2015-03-28 Thread Mike Galbraith
On Sat, 2015-03-28 at 09:35 -0400, Rik van Riel wrote: > It can be used by programs like irqbalance to avoid binding IRQs > to isolated or nohz_full CPUs, by libvirt to know which CPUs do > not get load balancing of SCHED_OTHER tasks, etc... Ok, other system packages learning to avoid these does

Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Guenter Roeck
On 03/28/2015 05:54 AM, Steven Honeyman wrote: On 28 March 2015 at 11:04, Paul Bolle wrote: On Sat, 2015-03-28 at 11:24 +0100, Pali Rohár wrote: --- a/drivers/hwmon/Kconfig +++ b/drivers/hwmon/Kconfig @@ -1703,6 +1703,17 @@ config SENSORS_ULTRA45 This driver provides support for the U

Re: [PATCH 1/4] [SMB3] Fix warning on uninitialized buftype

2015-03-28 Thread Shirish Pargaonkar
Looks correct. Acked-by: Shirish Pargaonkar On Fri, Mar 27, 2015 at 12:27 AM, Steve French wrote: > Pointed out by coverity analyzer. resp_buftype is > not initialized in one path which can rarely log > a spurious warning (buf is null so there will > not be a problem with freeing data, but if

kcalloc/kmalloc_array could BUILD_BUG_ON for too-big constant arguments (was Re: [PATCH] [RESEND] aic7xxx: replace kmalloc/memset by kzalloc)

2015-03-28 Thread Jeff Epler
The following is a sketch of how a macro kcalloc could BUILD_BUG_ON for overflows of two compile-time operands, or call "kcalloc_variable" for nonconstant arguments. Tested on gcc 4.7.2 only, since it's what I had to hand. I didn't do any testing beyond checking that fn2 didn't build, and that fn

Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Guenter Roeck
On 03/28/2015 03:24 AM, Pali Rohár wrote: This patch splits CONFIG_I8K compile option to SENSORS_DELL_SMM and CONFIG_I8K. Option SENSORS_DELL_SMM is now used to enable compilation of dell-smm-hwmon driver and old CONFIG_I8K option to enable /proc/i8k interface in driver. So this change allows to

Re: [PATCH 2/4] [CIFS] Don't ignore errors on encrypting password in SMBTcon

2015-03-28 Thread Shirish Pargaonkar
Looks correct, although we could just goto a label at the end of this function which does the same. Acked-by: Shirish Pargaonkar On Fri, Mar 27, 2015 at 12:28 AM, Steve French wrote: > Although unlikely to fail (and tree connect does not commonly send > a password since SECMODE_USER is the def

  1   2   >