Re: [PATCH] pinctrl: rockchip: don't disable clk when irq mask is already set

2016-09-24 Thread 陈豪
2016-09-24 18:24 GMT+08:00 Shawn Lin : > On 2016/9/24 2:26, Jacob Chen wrote: >> >> From: Jacob Chen >> >> In some drivers, disable_irq() call don't be symmetric with enable_irq() >> , disable_irq() will be called before call free_irq(). > > >

Re: [PATCH v3] gpio: Added zynq specific check for special pins on bank zero

2016-09-24 Thread Vesa Jääskeläinen
On 23/09/2016 14.26, Nava kishore Manne wrote: From: Nava kishore Manne This patch adds zynq specific check for bank 0 pins 7 and 8 are special and cannot be used as inputs Signed-off-by: Nava kishore Manne Reported-by: Jonas Karlsson

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Jean Delvare
Hi Joe, Larry, On Fri, 23 Sep 2016 12:02:43 -0700, Joe Perches wrote: > On Fri, 2016-09-23 at 13:59 -0500, Larry Finger wrote: > > I'm not familiar with the %#x format. What does it do? > > Outputs SPECIAL prefix, it's the same as "0x%x" > > lib/vsprintf.c: > #define SPECIAL 64

Re: [PATCH 4/4] Input-gameport: Replace some printk() calls by pr_info() in joydump_connect()

2016-09-24 Thread Joe Perches
On Sat, 2016-09-24 at 15:50 +0200, SF Markus Elfring wrote: > * Prefer usage of the macro "pr_info" over the interface "printk" >  in this function. > * Reduce number of output function calls. Did you test this? I doubt it. > diff --git a/drivers/input/joystick/joydump.c >

[tip:x86/asm] x86/alternatives: Add stack frame dependency to alternative_call_2()

2016-09-24 Thread tip-bot for Josh Poimboeuf
Commit-ID: 317c2ce77d8ab73c24f4fb9c75e5bb441fbe3e30 Gitweb: http://git.kernel.org/tip/317c2ce77d8ab73c24f4fb9c75e5bb441fbe3e30 Author: Josh Poimboeuf AuthorDate: Fri, 23 Sep 2016 16:49:39 -0500 Committer: Ingo Molnar CommitDate: Sat, 24 Sep 2016

[tip:x86/asm] thread_info: Use unsigned long for flags

2016-09-24 Thread tip-bot for Mark Rutland
Commit-ID: 907241dccb4ce5d9413cf3c030b32b0cfc184914 Gitweb: http://git.kernel.org/tip/907241dccb4ce5d9413cf3c030b32b0cfc184914 Author: Mark Rutland AuthorDate: Fri, 23 Sep 2016 18:24:07 +0100 Committer: Ingo Molnar CommitDate: Sat, 24 Sep 2016

Re: [PATCH] MAINTAINERS: Update open-iscsi maintainers

2016-09-24 Thread Lee Duncan
[Added linux-scsi to the cc list.] I will resubmit an updated version of this patch. On 09/23/2016 02:34 PM, Lee Duncan wrote: > Chris Leech and I are taking over open-iscsi > maintenance from Mike Christie. > > Signed-off-by: Lee Duncan > --- > MAINTAINERS | 3 ++- > 1 file

Re: [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump"

2016-09-24 Thread SF Markus Elfring
>> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt >> + > > Why did you split it off from the patch where you attempt to use it? I chose a special patch granularity once again. > What good does this change do on its own? I find that it is a preparation. - If this addition could not be accepted,

Re: [PATCH v4 0/3] nvme power saving

2016-09-24 Thread Jens Axboe
On 09/23/2016 05:42 PM, Christoph Hellwig wrote: Jens, can we at least get patches 1 and 2 in while pondering the fate of the right interface for patch 3? Yes definitely, I have no beef with the first two patches. I'll add them for 4.9. -- Jens Axboe

Re: [PATCH v3 3/8] drivers:input:tsc2007: add iio interface to read external ADC input, temperature and raw conversion values

2016-09-24 Thread H. Nikolaus Schaller
Hi Jonathan, > Am 24.09.2016 um 18:07 schrieb Jonathan Cameron : > > On 23/09/16 13:41, H. Nikolaus Schaller wrote: >> The tsc2007 chip not only has a resistive touch screen controller but >> also an external AUX adc imput which can be used for an ambient >> light sensor,

Re: [PATCH v4 2/2] iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8

2016-09-24 Thread Jonathan Cameron
On 21/09/16 21:16, William Breathitt Gray wrote: > The ACCES 104-QUAD-8 is a general purpose quadrature encoder > counter/interface board. The 104-QUAD-8 is capable of monitoring the > outputs of eight encoders via four on-board LSI/CSI LS7266R1 24-bit > dual-axis quadrature counter chips. Core

Re: [PATCH] f2fs: remove dirty inode pages in error path

2016-09-24 Thread Jaegeuk Kim
On Sat, Sep 24, 2016 at 09:02:02AM +0800, Chao Yu wrote: > On 2016/9/24 5:11, Jaegeuk Kim wrote: > > When getting EIO while handling orphan inodes, we can get some dirty node > > pages. Then, f2fs_write_node_pages() called by iput(node_inode) will try > > to flush node pages. But in this case, we

Re: [PATCH 2/2] Input-evdev: Rename a jump label in two functions

2016-09-24 Thread Dmitry Torokhov
On Sat, Sep 24, 2016 at 4:10 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 24 Sep 2016 12:50:31 +0200 > > Adjust a jump label according to the current Linux coding style convention. > Thus replace the identifier

Re: [PATCH 1/2] Input-evdev: Use kmalloc_array() in evdev_handle_get_val()

2016-09-24 Thread Dmitry Torokhov
On Sat, Sep 24, 2016 at 4:08 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 24 Sep 2016 12:42:45 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data

Re: Input-evdev: Use kmalloc_array() in evdev_handle_get_val()

2016-09-24 Thread SF Markus Elfring
> So we have to multiply twice now, once in kmalloc_array, the second > time in memcpy(). It looks so in the source code after the suggested refactoring. > No, thank you. Would you like to check any further if a specific compiler implementation will still optimise common subexpressions as you

[PATCH 1/4] Input-gameport: Use kmalloc_array() in joydump_connect()

2016-09-24 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 24 Sep 2016 13:50:20 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was

[PATCH] mos7840: fix chars_in_buffer() return value

2016-09-24 Thread Stas Sergeev
The TIOCOUTQ ioctl calls chars_in_buffer(), and some apps depend on a correct behaviour of that. mos7840 implements it wrongly: if you write just one char, TIOCOUTQ will return 32. This patch should fix it by accounting the number of chars actually writCaylan Van Larson ten. This

Re: [PATCH] mos7840: fix chars_in_buffer() return value

2016-09-24 Thread Sergei Shtylyov
Hello. On 9/24/2016 4:47 PM, Stas Sergeev wrote: The TIOCOUTQ ioctl calls chars_in_buffer(), and some apps depend on a correct behaviour of that. mos7840 implements it wrongly: if you write just one char, TIOCOUTQ will return 32. This patch should fix it by accounting the number of chars

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Joe Perches
On Sat, 2016-09-24 at 17:55 +0200, Jean Delvare wrote: > Would it make sense to explicitly set the enum values, or add them as > comments, to make such look-ups easier? If you want to create enum->#ENUM structs and "const char *" lookup functions, please be my guest. otherwise, hex is at least a

Re: [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump"

2016-09-24 Thread Joe Perches
On Sat, 2016-09-24 at 18:55 +0200, SF Markus Elfring wrote: > > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > Why did you split it off from the patch where you attempt to use it? > I chose a special patch granularity once again. > > What good does this change do on its own? > I find that it

Re: Input-gameport: Use kmalloc_array() in joydump_connect()

2016-09-24 Thread SF Markus Elfring
>> * A multiplication for the size determination of a memory allocation >> indicated that an array data structure should be processed. >> Thus use the corresponding function "kmalloc_array". >> > > -ENOPARSE. Do you find an other wording better? The script "checkpatch.pl" can point

Re: [PATCH v4 1/2] iio: Implement counter channel type and info constants

2016-09-24 Thread Jonathan Cameron
On 21/09/16 21:15, William Breathitt Gray wrote: > Quadrature encoders, such as rotary encoders and linear encoders, are > devices which are capable of encoding the relative position and > direction of motion of a shaft. This patch introduces several IIO > constants for supporting quadrature

Re: [PATCH v3 3/8] drivers:input:tsc2007: add iio interface to read external ADC input, temperature and raw conversion values

2016-09-24 Thread Jonathan Cameron
On 24/09/16 18:07, H. Nikolaus Schaller wrote: > Hi Jonathan, > >> Am 24.09.2016 um 18:07 schrieb Jonathan Cameron : >> >> On 23/09/16 13:41, H. Nikolaus Schaller wrote: >>> The tsc2007 chip not only has a resistive touch screen controller but >>> also an external AUX adc imput

Re: Input-gameport: Add the macro "pr_fmt" for module "joydump"

2016-09-24 Thread SF Markus Elfring
>> I find that it is a preparation. - If this addition could not be accepted, >> the following update step would also be discussed under an other perspective, >> wouldn't it? > > It's purposeless, creates unnecessary patches to review > and generally wastes other people's time. I have got an

Re: [PATCH v3 3/8] drivers:input:tsc2007: add iio interface to read external ADC input, temperature and raw conversion values

2016-09-24 Thread Dmitry Torokhov
On Sat, Sep 24, 2016 at 10:07 AM, H. Nikolaus Schaller wrote: > Hi Jonathan, > >> Am 24.09.2016 um 18:07 schrieb Jonathan Cameron : >> >> On 23/09/16 13:41, H. Nikolaus Schaller wrote: >>> The tsc2007 chip not only has a resistive touch screen controller but

Re: [PATCH v3 3/8] drivers:input:tsc2007: add iio interface to read external ADC input, temperature and raw conversion values

2016-09-24 Thread H. Nikolaus Schaller
Hi Dmitry, > Am 24.09.2016 um 19:44 schrieb Dmitry Torokhov : > > On Sat, Sep 24, 2016 at 10:07 AM, H. Nikolaus Schaller > wrote: >> Hi Jonathan, >> >>> Am 24.09.2016 um 18:07 schrieb Jonathan Cameron : >>> >>> On 23/09/16

Re: [PATCH] mm: warn about allocations which stall for too long

2016-09-24 Thread Balbir Singh
On 24/09/16 03:34, Dave Hansen wrote: > On 09/23/2016 01:15 AM, Michal Hocko wrote: >> +/* Make sure we know about allocations which stall for too long */ >> +if (!(gfp_mask & __GFP_NOWARN) && time_after(jiffies, alloc_start + >> stall_timeout)) { >> +pr_warn("%s: page

[PATCH 0/4] Input-gameport: Fine-tuning for joydump_connect()

2016-09-24 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 24 Sep 2016 15:34:15 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Use kmalloc_array() Delete an error message for a failed memory allocation Add the macro

Fwd: Re: Patchwork [1/1] staging: ks7010: Attempt to structure and format to standards

2016-09-24 Thread Marcel Xubuntu
Code formatting and structuring. Signed-off-by: Marcel Ricquier --- Tested-by: Marcel Ricquier Mostly code formatting, unapologetically a stepping stone for a potential refactoring with a knowledge seeking, following complete disclosure,

Re: [PATCH] mos7840: fix chars_in_buffer() return value

2016-09-24 Thread Stas Sergeev
24.09.2016 16:57, Sergei Shtylyov пишет: Hello. On 9/24/2016 4:47 PM, Stas Sergeev wrote: The TIOCOUTQ ioctl calls chars_in_buffer(), and some apps depend on a correct behaviour of that. mos7840 implements it wrongly: if you write just one char, TIOCOUTQ will return 32. This patch should fix

Re: [PATCH 01/10] firewire-net: Use kmalloc_array() in fwnet_broadcast_start()

2016-09-24 Thread SF Markus Elfring
>> @@ -1103,8 +1103,7 @@ static int fwnet_broadcast_start(struct fwnet_device >> *dev) >> >> max_receive = 1U << (dev->card->max_receive + 1); >> num_packets = (FWNET_ISO_PAGE_COUNT * PAGE_SIZE) / max_receive; >> - >> -ptrptr = kmalloc(sizeof(void *) * num_packets, GFP_KERNEL); >>

Re: [PATCH 1/7] iio: Use kmalloc_array() in iio_scan_mask_set()

2016-09-24 Thread Jonathan Cameron
On 24/09/16 07:24, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 23 Sep 2016 22:30:32 +0200 > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the

[PATCH v3] add u64 number parser

2016-09-24 Thread James Smart
add u64 number parser Prior patch revised to use kasprintf. Modified match_number to use kasprintf as well Signed-off-by: James Smart --- include/linux/parser.h | 1 + lib/parser.c | 51 ++ 2 files changed,

Re: [PATCH v3 3/8] drivers:input:tsc2007: add iio interface to read external ADC input, temperature and raw conversion values

2016-09-24 Thread Jonathan Cameron
On 23/09/16 13:41, H. Nikolaus Schaller wrote: > The tsc2007 chip not only has a resistive touch screen controller but > also an external AUX adc imput which can be used for an ambient > light sensor, battery voltage monitoring or any general purpose. > > Additionally it can measure the chip

Warning from free_init_pages with large initrd

2016-09-24 Thread Sitsofe Wheeler
Hi, While trying to PXE boot a Fedora LiveISO on VMware ESXi the kernel throws the following warning: [0.955216] Unpacking initramfs... [5.391977] [ cut here ] [5.391986] WARNING: CPU: 0 PID: 1 at arch/x86/mm/init.c:671 free_init_pages+0x94/0xa0 [

Re: [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump"

2016-09-24 Thread Dmitry Torokhov
On Sat, Sep 24, 2016 at 03:48:54PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 24 Sep 2016 14:30:44 +0200 > > Add a definition for the macro "pr_fmt" so that its information can be used > for consistent message output. > > Signed-off-by:

Re: [PATCH 4/4] Input-gameport: Replace some printk() calls by pr_info() in joydump_connect()

2016-09-24 Thread SF Markus Elfring
>> @@ -57,27 +57,29 @@ static int joydump_connect(struct gameport *gameport, >> struct gameport_driver *dr >>> unsigned long flags; >>> unsigned char u; >> >>> - printk(KERN_INFO "joydump: ,-- START >>> .\n"); >>> - printk(KERN_INFO "joydump: |

Re: [PATCH 1/4] Input-gameport: Use kmalloc_array() in joydump_connect()

2016-09-24 Thread Dmitry Torokhov
On Sat, Sep 24, 2016 at 03:46:21PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 24 Sep 2016 13:50:20 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be

[PATCH v3] bpf: Set register type according to is_valid_access()

2016-09-24 Thread Mickaël Salaün
This prevent future potential pointer leaks when an unprivileged eBPF program will read a pointer value from its context. Even if is_valid_access() returns a pointer type, the eBPF verifier replace it with UNKNOWN_VALUE. The register value that contains a kernel address is then allowed to leak.

Re: [f2fs-dev] [PATCH 1/2] f2fs: use crc and cp version to determine roll-forward recovery

2016-09-24 Thread Jaegeuk Kim
On Sat, Sep 24, 2016 at 02:00:41PM +0800, Chao Yu wrote: > On 2016/9/21 8:45, Jaegeuk Kim wrote: > > @@ -259,40 +290,26 @@ static inline void fill_node_footer_blkaddr(struct > > page *page, block_t blkaddr) > > { > > struct f2fs_checkpoint *ckpt = F2FS_CKPT(F2FS_P_SB(page)); > > struct

[PATCH 2/4] Input-gameport: Delete an error message for a failed memory allocation

2016-09-24 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 24 Sep 2016 14:18:48 +0200 Omit an extra message for a memory allocation failure in this function. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring

[PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump"

2016-09-24 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 24 Sep 2016 14:30:44 +0200 Add a definition for the macro "pr_fmt" so that its information can be used for consistent message output. Signed-off-by: Markus Elfring ---

[PATCH] mos7840: fix chars_in_buffer() return value

2016-09-24 Thread Stas Sergeev
The TIOCOUTQ ioctl calls chars_in_buffer(), and some apps depend on a correct behaviour of that. mos7840 implements it wrongly: if you write just one char, TIOCOUTQ will return 32. This patch should fix it by accounting the number of chars actually written. This patch, unfortunately, misses the

Re: [PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up

2016-09-24 Thread Sergei Shtylyov
Hello. On 9/24/2016 8:24 AM, Baoyou Xie wrote: We get 1 warning when building kernel with W=1: drivers/isdn/hisax/hscx.c:175:1: warning: no previous prototype for 'open_hscxstate' [-Wmissing-prototypes] In fact, this function is declared in drivers/isdn/hisax/elsa_ser.c, but should be

Re: [PATCH 00/14] perf clang: Support compiling BPF script use builtin clang

2016-09-24 Thread Alexei Starovoitov
On Fri, Sep 23, 2016 at 12:49:47PM +, Wang Nan wrote: > This patch set is the first step to implement features I announced > in LinuxCon NA 2016. See page 31 of: > > >

Re: [PATCH 2/7] iio: Rename a jump label in iio_buffer_store_watermark()

2016-09-24 Thread Jonathan Cameron
On 24/09/16 07:25, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 24 Sep 2016 06:54:49 +0200 > > Adjust jump labels according to the current Linux coding style convention. > > Signed-off-by: Markus Elfring I'm not

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Larry Finger
On 09/24/2016 11:15 AM, Joe Perches wrote: On Sat, 2016-09-24 at 17:55 +0200, Jean Delvare wrote: Would it make sense to explicitly set the enum values, or add them as comments, to make such look-ups easier? If you want to create enum->#ENUM structs and "const char *" lookup functions, please

Re: [PATCH] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

2016-09-24 Thread Chris Roth
Due to my lack of familiarity with the how git send-email works, I've unintentionally had my name listed as the first 'from' whereas I intended Allan Chou to be listed as the first 'from' in the patch. If anyone can correct this on my behalf, I would appreciate it. Regards, Chris On Sat, Sep 24,

Re: Input-gameport: Replace some printk() calls by pr_info() in joydump_connect()

2016-09-24 Thread SF Markus Elfring
> The desired output should not be broken in conversion, which you did. I dared to change another source code place a bit too much perhaps. > Do you know how syslog works and why the transformation is not correct. I imagine that there are chances to improve the software situation a bit more,

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Joe Perches
On Sat, 2016-09-24 at 14:06 -0500, Larry Finger wrote: > On 09/24/2016 12:32 PM, Joe Perches wrote: [] > o Reindent all the switch/case blocks to a more normal > kernel style (git diff -w would show no changes here) > That sounds like busy work to me, but if you want to do it, go ahead. It's

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Jes Sorensen
Joe Perches writes: > On Sat, 2016-09-24 at 14:06 -0500, Larry Finger wrote: >> On 09/24/2016 12:32 PM, Joe Perches wrote: > [] >> o Reindent all the switch/case blocks to a more normal >> kernel style (git diff -w would show no changes here) >> That sounds like busy work to

[PATCH 1/2] brcmfmac: initialize fws(ignal) for BCDC protocol only

2016-09-24 Thread Rafał Miłecki
From: Rafał Miłecki There are two protocols used by Broadcom FullMAC devices: BCDC and msgbuf. They use different ways for (some part of) communication with the firmware. Firmware Signaling is required for the first one only (BCDC). So far we were always initializing fws and

[PATCH 2/2] brcmfmac: compile fws(ignal) code only with BCDC support enabled

2016-09-24 Thread Rafał Miłecki
From: Rafał Miłecki It's not needed by the other (msgbuf) protocol, so let's save some size and compile it conditionally. Signed-off-by: Rafał Miłecki --- .../wireless/broadcom/brcm80211/brcmfmac/Makefile | 4 +- .../broadcom/brcm80211/brcmfmac/fwsignal.h

[PATCH] libnvdimm, region: fix flush hint table thinko

2016-09-24 Thread Dan Williams
The definition of the flush hint table as: void __iomem *flush_wpq[0][0]; ...passed the unit test, but is broken as flush_wpq[0][1] and flush_wpq[1][0] refer to the same entry. Fix this to use a helper that calculates a slot in the table based on the geometry of flush hints in the

Re: [PATCH 2/2] radix-tree: Fix optimisation problem

2016-09-24 Thread Linus Torvalds
On Sat, Sep 24, 2016 at 2:04 PM, Kirill A. Shutemov wrote: > > Well, my ext4-with-huge-pages patchset[1] uses multi-order entries. > It also converts shmem-with-huge-pages and hugetlb to them. Ok, so that code actually has a chance of being used. I guess we'll

Re: [PATCH 2/2] radix-tree: Fix optimisation problem

2016-09-24 Thread Cedric Blancher
On 22 September 2016 at 20:53, Matthew Wilcox wrote: > From: Matthew Wilcox > > When compiling the radix tree with -O2, GCC thinks it can optimise: > > void *entry = parent->slots[offset]; > int siboff = entry - parent->slots;

Re: [PATCH] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

2016-09-24 Thread David Miller
From: Chris Roth Date: Sat, 24 Sep 2016 10:59:04 -0600 > Due to my lack of familiarity with the how git send-email works, I've > unintentionally had my name listed as the first 'from' whereas I > intended Allan Chou to be listed as the first 'from' in the patch. If > anyone

Re: RK3288 USB Issues

2016-09-24 Thread ayaka
On 09/23/2016 03:10 PM, Norbert Lange wrote: Hi, I wanted to reply to the Linux mailing List (your patch thread), I dont know exactly where since the addresses are blanked out. Just tell me where I should move this discussion. The board can use both USB peripherals (haven`t tested the OTG

[PATCH 1/3] g_NCR5380: Remove deprecated __setup

2016-09-24 Thread Ondrej Zary
Remove deprecated __setup for parsing command line parameters. g_NCR5380.* parameters could be used instead. Signed-off-by: Ondrej Zary --- drivers/scsi/g_NCR5380.c | 135 -- 1 file changed, 135 deletions(-) diff --git

[PATCH 2/3] g_NCR5380: Reduce overrides[] from array to struct

2016-09-24 Thread Ondrej Zary
Remove compile-time card type definition GENERIC_NCR5380_OVERRIDE. Then remove all code iterating the overrides[] array and reduce it to struct card. Signed-off-by: Ondrej Zary --- drivers/scsi/g_NCR5380.c | 351 ++ 1 file

[PATCH 0/3] g_NCR5380: Modernization

2016-09-24 Thread Ondrej Zary
This small patch series removes deprecated code from g_NCR5380 driver and converts it from scsi_module.c to scsi_add_host(). Tested with: HP C2502 (53C400A chip) Canon FG2-5202 (53C400 chip, memory-mapped) DTC-3181L (DTCT-436P chip, PnP) P.S. I don't like the ifdef mess needed for

Huge static buffer in liquidio

2016-09-24 Thread Denys Vlasenko
Hello, I would like to discuss this commit: commit d3d7e6c65f75de18ced10a98595a847f9f95f0ce Author: Raghu Vatsavayi Date: Tue Jun 21 22:53:07 2016 -0700 liquidio: Firmware image download This patch has firmware image related changes for: firmware

[PATCH] firewire: nosy: do not ignore errors in ioremap_nocache()

2016-09-24 Thread Alexey Khoroshilov
There is no check if ioremap_nocache() returns a valid pointer. Potentially it can lead to null pointer dereference. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/firewire/nosy.c | 7 +++ 1 file changed,

[PATCH net-next 4/8] rxrpc: Reinitialise the call ACK and timer state for client reply phase

2016-09-24 Thread David Howells
Clear the ACK reason, ACK timer and resend timer when entering the client reply phase when the first DATA packet is received. New ACKs will be proposed once the data is queued. The resend timer is no longer relevant and we need to cancel ACKs scheduled to probe for a lost reply. Signed-off-by:

Re: [PATCH 1/3] devicetree: bindings: scsi: hisi_sas hip07 support

2016-09-24 Thread John Garry
On 23/09/2016 19:36, Rob Herring wrote: On Tue, Sep 20, 2016 at 06:48:58PM +0800, John Garry wrote: Add support for hip07 chipset to bindings. Chipset hip07 has v2 hw. The sas-v2 quirk amt is expanded to cover hip07. Signed-off-by: John Garry Signed-off-by: Xiang Chen

[GIT pull] irq fixes for 4.8

2016-09-24 Thread Thomas Gleixner
Linus, please pull the latest irq-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq-urgent-for-linus Three fixes for irq core and irq chip drivers - Do not set the irq type if type is NONE. Fixes a boot regression on various SoCs - Use

[GIT pull] efi fixes for 4.8

2016-09-24 Thread Thomas Gleixner
Linus, please pull the latest efi-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git efi-urgent-for-linus Two fixes for EFI/PAT: - A 32bit overflow bug in the PAT code which was unearthed by the large EFI mappings - Prevent a boot hang on large

[PATCH v6 2/3] ASoC: sun4i-codec: Rename some sun7i-only registers

2016-09-24 Thread Danny Milosavljevic
Some of the registers defined in the driver are only usable on the A20. Rename these registers. Signed-off-by: Danny Milosavljevic --- sound/soc/sunxi/sun4i-codec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/sunxi/sun4i-codec.c

[PATCH v6 3/3] ASoC: sun4i-codec: Add custom regmap configs

2016-09-24 Thread Danny Milosavljevic
The A20 has a few extra registers that the A10 doesn't have. Therefore, use different regmaps for A10 as compared to A20. Signed-off-by: Danny Milosavljevic --- sound/soc/sunxi/sun4i-codec.c | 38 +++--- 1 file changed, 35 insertions(+), 3

[PATCH v6 0/3] ASoC: sun4i-codec: Distinguish sun4i from sun7i

2016-09-24 Thread Danny Milosavljevic
Introduce mechanism to detect sun7i and provide a different regmap (different compared to sun4i Allwinner A10). The controls will be extended in a forthcoming patch - it is necessary to distinguish between sun4i and sun7i controls because they have different registers. Rename

Re: [PATCH 2/2] radix-tree: Fix optimisation problem

2016-09-24 Thread Kirill A. Shutemov
On Sat, Sep 24, 2016 at 01:21:36PM -0700, Linus Torvalds wrote: > On Fri, Sep 23, 2016 at 1:16 PM, Matthew Wilcox > wrote: > > > > #ifdef CONFIG_RADIX_TREE_MULTIORDER > > if (radix_tree_is_internal_node(entry)) { > > - unsigned long siboff =

Re: [RFC] remove unnecessary condition in remove_inode_hugepages

2016-09-24 Thread Mike Kravetz
On 09/23/2016 07:56 PM, zhong jiang wrote: > On 2016/9/24 1:19, Mike Kravetz wrote: >> On 09/22/2016 06:53 PM, zhong jiang wrote: >>> At present, we need to call hugetlb_fix_reserve_count when >>> hugetlb_unrserve_pages fails, >>> and PagePrivate will decide hugetlb reserves counts. >>> >>> we

Re: [PATCH v3] add u64 number parser

2016-09-24 Thread Linus Torvalds
On Sat, Sep 24, 2016 at 8:27 AM, James Smart wrote: > > add u64 number parser > > Prior patch revised to use kasprintf. > Modified match_number to use kasprintf as well Why would you do this? It's insane. kasprintf() is not the right thing at all to use for anything

Re: Input-evdev: Use kmalloc_array() in evdev_handle_get_val()

2016-09-24 Thread SF Markus Elfring
> Again, what is the purpose of the changes? I came also along a few source code places where their maintainers requested the usage of a function like "kmalloc_array". How do you think about to clarify the consistent use of programming interfaces for Linux a bit more? > Are you working on the

[PATCH 3/3] g_NCR5380: Stop using scsi_module.c

2016-09-24 Thread Ondrej Zary
Convert g_NCR5380 to use scsi_add_host instead of scsi_module.c Use pnp_driver and isa_driver to manage cards. Signed-off-by: Ondrej Zary --- drivers/scsi/g_NCR5380.c | 310 +- drivers/scsi/g_NCR5380.h |8 -- 2 files

Re: Input-gameport: Replace some printk() calls by pr_info() in joydump_connect()

2016-09-24 Thread SF Markus Elfring
>> Should the desired output be the same when the relevant data are passed by a >> single function call >> (instead of three as before)? > > Adding a singleton for a pr_fmt #define constant string and > updating the printk subsystem to prepend that constant string > to each use of a pr_ at

Re: [PATCH 2/2] radix-tree: Fix optimisation problem

2016-09-24 Thread Linus Torvalds
On Fri, Sep 23, 2016 at 1:16 PM, Matthew Wilcox wrote: > > #ifdef CONFIG_RADIX_TREE_MULTIORDER > if (radix_tree_is_internal_node(entry)) { > - unsigned long siboff = get_slot_offset(parent, entry); > + unsigned long siboff =

RE: [PATCH v6 1/9] rpmb: add Replay Protected Memory Block (RPMB) subsystem

2016-09-24 Thread Winkler, Tomas
> > > > > > Signed-off-by: Tomas Winkler > > Signed-off-by: Alexander Usyskin > Tested-by: Avri Altman > > - mmc - full functionality. One issue found that was fixed on V6: patch V6 > 2/9. > - ufs - read & read

Re: [PATCH 4/5] input: touchscreen: support Allwinner SoCs' touchscreen

2016-09-24 Thread Dmitry Torokhov
Hi Quentin, On Sat, Sep 24, 2016 at 08:26:08PM +0200, Quentin Schulz wrote: > Hi Dimitry, > > Sorry for the (long) delay, I did not have time to work on it. I'll > mainly work in my free time now. > > On 20/07/2016 19:25, Dmitry Torokhov wrote: > > Hi Quentin, > > > > On Wed, Jul 20, 2016 at

Re: iio: Rename a jump label in iio_buffer_store_watermark()

2016-09-24 Thread SF Markus Elfring
> I'm not necessarily against this change which does perhaps clarify the code > ever so slightly, Thanks for another bit of positive feedback. > but I am interested to know where 'current Linux coding style convention' > comes from? How often do you check the status of a document like

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Jes Sorensen
Larry Finger writes: > On 09/24/2016 12:32 PM, Joe Perches wrote: >> Is there any value in that or is Jes' work going to make >> doing any or all of this unnecessary and futile? > > That is not yet determined. The only driver that is to be replaced at > this point is

Re: RK3288 USB Issues

2016-09-24 Thread Norbert Lange
Hello, did you try without your patches, to see if you can reproduce the problem? I can fix my issues if I disable usb autosuspend To narrow down the causes I can think of: *) Some hardware issue only on my side -> please try to reproduce it with an unpached kernel *) Some other stuff I modified

Re: [PATCH V3 2/4] ARM64 LPC: LPC driver implementation on Hip06

2016-09-24 Thread Arnd Bergmann
On Saturday, September 24, 2016 4:14:15 PM CEST zhichang wrote: > > In V3, the outb is : > > void outb(u8 value, unsigned long addr) > { > if (!arm64_extio_ops || arm64_extio_ops->start > addr || > arm64_extio_ops->end < addr) > writeb(value,

Re: [PATCH] ARM: dts: exynos: Add reboot reason support for Trats2

2016-09-24 Thread Wolfgang Wiedmeyer
Krzysztof Kozlowski writes: > On Thu, Sep 22, 2016 at 08:59:03PM +0200, Wolfgang Wiedmeyer wrote: >> >> Krzysztof Kozlowski writes: >> >> > On Thu, Sep 22, 2016 at 06:48:35PM +0200, Wolfgang Wiedmeyer wrote: >> >> This allows to reboot the device into recovery mode and into the download >> >>

[PATCH] clk: at91: Fix a return value in case of error

2016-09-24 Thread Christophe JAILLET
If 'clk_hw_register()' fails, it is likely that we expect to return an error instead of a valid pointer (which would mean success). 'clk_hw_register()' returns a bool, so we don't have the detail of the error. Return -ENOMEM instead, as it seems to be the most common error returned by

[PATCH net-next 3/8] rxrpc: Include the last reply DATA serial number in the final ACK

2016-09-24 Thread David Howells
In a client call, include the serial number of the last DATA packet of the reply in the final ACK. Signed-off-by: David Howells --- net/rxrpc/recvmsg.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/rxrpc/recvmsg.c b/net/rxrpc/recvmsg.c

[PATCH net-next 6/8] rxrpc: Generate a summary of the ACK state for later use

2016-09-24 Thread David Howells
Generate a summary of the Tx buffer packet state when an ACK is received for use in a later patch that does congestion management. Signed-off-by: David Howells --- net/rxrpc/ar-internal.h | 14 ++ net/rxrpc/input.c | 45

[PATCH net-next 8/8] rxrpc: Implement slow-start

2016-09-24 Thread David Howells
Implement RxRPC slow-start, which is similar to RFC 5681 for TCP. A tracepoint is added to log the state of the congestion management algorithm and the decisions it makes. Notes: (1) Since we send fixed-size DATA packets (apart from the final packet in each phase), counters and

[PATCH net-next 7/8] rxrpc: Schedule an ACK if the reply to a client call appears overdue

2016-09-24 Thread David Howells
If we've sent all the request data in a client call but haven't seen any sign of the reply data yet, schedule an ACK to be sent to the server to find out if the reply data got lost. If the server hasn't yet hard-ACK'd the request data, we send a PING ACK to demand a response to find out whether

[PATCH net-next 5/8] rxrpc: Delay the resend timer to allow for nsec->jiffies conv error

2016-09-24 Thread David Howells
When determining the resend timer value, we have a value in nsec but the timer is in jiffies which may be a million or more times more coarse. nsecs_to_jiffies() rounds down - which means that the resend timeout expressed as jiffies is very likely earlier than the one expressed as nanoseconds from

Re: Input-evdev: Use kmalloc_array() in evdev_handle_get_val()

2016-09-24 Thread Dmitry Torokhov
On Sat, Sep 24, 2016 at 08:16:16PM +0200, SF Markus Elfring wrote: > > So we have to multiply twice now, once in kmalloc_array, the second > > time in memcpy(). > > It looks so in the source code after the suggested refactoring. > > > > No, thank you. > > Would you like to check any further if

Re: Input-gameport: Add the macro "pr_fmt" for module "joydump"

2016-09-24 Thread SF Markus Elfring
> When a chorus of voices says to you that you are wasting > their time, perhaps you listen to their song. I am listening to some degree. - I guess that I am making some decisions and conclusions in a way that you would prefer to be different. I know that my update suggestions won't be liked by

Re: [PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-24 Thread Jacek Anaszewski
On 09/24/2016 02:00 PM, Pavel Machek wrote: Hi! Instead I propose the following: n_iled_max = 31 - (priv->led_iref * 2400 / priv->leds_max_current + !!(priv->led_iref * 2400 % priv->leds_max_current)) div_round_up? Exactly. Thanks. -- Best regards, Jacek Anaszewski

[PATCH v8 1/3] phy: Add reset callback for not generic phy

2016-09-24 Thread Randy Li
I forget to add a dummy function in case the CONFIG_GENERIC_PHY is disabled. Signed-off-by: Randy Li --- include/linux/phy/phy.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h index ee1bed7..78bb0d7 100644 ---

[PATCH v8 3/3] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset

2016-09-24 Thread Randy Li
The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288 has a hardware errata that causes everything to get confused when we get a remote wakeup. We'll use the reset that's in the CRU to reset the port when it's in a bad state. Note that we add the reset to both dwc2 controllers

[PATCH v8 2/3] usb: dwc2: assert phy reset when waking up in rk3288 platform

2016-09-24 Thread Randy Li
On the rk3288 USB host-only port (the one that's not the OTG-enabled port) the PHY can get into a bad state when a wakeup is asserted (not just a wakeup from full system suspend but also a wakeup from autosuspend). We can get the PHY out of its bad state by asserting its "port reset", but

[PATCH v8 0/3] the fixup for the USB HOST1 at rk3288 platform

2016-09-24 Thread Randy Li
At this stage it is the only "full features" and well verified USB EHCI controller in this platform. More review is always necessary. Although V7 is almost fine but a forget a dummy function for the phy system. changelog: v7 add the forgot dummy phy_reset() for the generic phy is disabled.

Re: [PATCH v3 1/2] leds: ncp5623: Add device tree binding documentation

2016-09-24 Thread Jacek Anaszewski
On 09/24/2016 01:58 PM, Pavel Machek wrote: Hi! +Example +=== + +led1: ncp5623@38 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "onnn,ncp5623"; + reg = <0x38>; + onnn,led-iref-microamp = <10>; + + led1r@0 { + label =

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Larry Finger
On 09/24/2016 12:32 PM, Joe Perches wrote: (adding Jes Sorensen to recipients) On Sat, 2016-09-24 at 11:35 -0500, Larry Finger wrote: I have patches that makes HAL_DEF_WOWLAN be a no-op for the rest of the drivers, and one that sets the enum values for that particular statement to hex values.

[GIT pull] locking fixes for 4.8

2016-09-24 Thread Thomas Gleixner
Linus, please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus Two smallish fixes: - Use the proper asm constraint in the Super-H atomic_fetch_ops - A trivial typo fix in the Kconfig help text

<    1   2   3   4   5   >