Re: [PATCH 1/7] Documentation: DT: bindings: iio: adc: add documentation for Allwinner SoCs' GPADC driver

2016-12-21 Thread Maxime Ripard
Hi, On Tue, Dec 20, 2016 at 04:43:58PM +0100, Quentin Schulz wrote: > >> + > >> +Optional properties: > >> +(for use with thermal framework for CPU thermal throttling for example, > >> and/or > >> + IIO consumers) > >> + - #thermal-sensor-cells = <0>; (see > >> +Documentation/devicetree/bindings/

Re: [PATCH] pci: add kernel config option for disabling common PCI quirks

2016-12-21 Thread Christoph Hellwig
On Wed, Dec 21, 2016 at 08:53:04AM +0100, John Crispin wrote: > This patch has been lingering inside the OpenWrt for some years. I am not > sure if this is the best way to remove the quirks from the build. Let me > know if you prefer a different way of solving this. As a start negative options (_D

Re: [PATCH v3] net: macb: Added PCI wrapper for Platform Driver.

2016-12-21 Thread Andy Shevchenko
On Wed, Dec 21, 2016 at 2:16 PM, Andy Shevchenko wrote: > On Wed, Dec 21, 2016 at 1:53 PM, Bartosz Folta wrote: >> I think that there is a delay on some mailing lists (marc.info and >> mail-archive.com). Latest messages I found there are from December >> 16th 2016. > > You may refer to > https:/

Re: at86rf230: Allow slow GPIO pins for "rstn"

2016-12-21 Thread Nikita Yushchenko
> Driver code never touches "rstn" signal in atomic context, so there's > no need to implicitly put such restriction on it by using gpio_set_value > to manipulate it. Replace gpio_set_value to gpio_set_value_cansleep to > fix that. > > As a an example of where such restriction might be inconvenien

Re: [RFC][PATCH] make global bitlock waitqueues per-node

2016-12-21 Thread Nicholas Piggin
On Mon, 19 Dec 2016 14:58:26 -0800 Dave Hansen wrote: > I saw a 4.8->4.9 regression (details below) that I attributed to: > > 9dcb8b685f mm: remove per-zone hashtable of bitlock waitqueues > > That commit took the bitlock waitqueues from being dynamically-allocated > per-zone to being sta

Re: [RFC PATCH 4/7] HW Filter Initialization code and register access APIs

2016-12-21 Thread Sunil Kovvuri
On Wed, Dec 21, 2016 at 2:16 PM, Satha Koteswara Rao wrote: > --- > drivers/net/ethernet/cavium/thunder/pf_reg.c | 660 > +++ > 1 file changed, 660 insertions(+) > create mode 100644 drivers/net/ethernet/cavium/thunder/pf_reg.c > > diff --git a/drivers/net/ethernet/caviu

Re: [PATCH V2 1/2] mm/memblock.c: trivial code refine in memblock_is_region_memory()

2016-12-21 Thread Wei Yang
On Wed, Dec 21, 2016 at 08:48:09AM +0100, Michal Hocko wrote: >On Tue 20-12-16 16:35:40, Wei Yang wrote: >> On Mon, Dec 19, 2016 at 04:15:14PM +0100, Michal Hocko wrote: >> >On Sun 18-12-16 14:47:49, Wei Yang wrote: >> >> The base address is already guaranteed to be in the region by >> >> memblock_

Re: [RFC PATCH 5/7] Multiple VF's grouped together under single physical port called PF group PF Group maintainance API's

2016-12-21 Thread Sunil Kovvuri
On Wed, Dec 21, 2016 at 2:16 PM, Satha Koteswara Rao wrote: > +struct tns_global_st { > + u64 magic; > + char version[16]; > + u64 reg_cnt; > + struct table_static_s tbl_info[TNS_MAX_TABLE]; > +}; > + > +#define PF_COUNT 3 > +#define PF_1 0 > +#define PF_2 64 > +#de

Re: [PATCH] KVM: x86: check for pic and ioapic presence before use

2016-12-21 Thread Radim Krčmář
2016-12-20 19:59+0800, Wanpeng Li: > 2016-11-24 20:42 GMT+08:00 Radim Krčmář : >> 2016-11-23 22:58+0100, Paolo Bonzini: >>> On 23/11/2016 21:25, Radim Krčmář wrote: diff --git a/arch/x86/kvm/irq_comm.c b/arch/x86/kvm/irq_comm.c index 25810b144b58..ddd63b8b176e 100644 --- a/arch/x86/k

Re: BQ27xxx registers

2016-12-21 Thread Pali Rohár
On Wednesday 21 December 2016 03:49:10 Chris Lapa wrote: > On 20/12/16 10:34 pm, Pali Rohár wrote: > > On Tuesday 20 December 2016 07:00:41 Chris Lapa wrote: > >> I can generate a patch to fix this issue, however the bigger > >> problem exists as to which revision fuel gauge the > >> bq27xxx_batter

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-21 Thread Mathias Nyman
On 21.12.2016 08:17, Lu Baolu wrote: Hi Mathias, I have some comments for the implementation of xhci_abort_cmd_ring() below. On 12/20/2016 11:13 PM, Mathias Nyman wrote: On 20.12.2016 09:30, Baolin Wang wrote: ... Alright, I gathered all current work related to xhci races and timeouts and put

Re: dm-crypt optimization

2016-12-21 Thread Milan Broz
On 12/20/2016 10:41 AM, Binoy Jayan wrote: > At a high level the goal is to maximize the size of data blocks that get > passed > to hardware accelerators, minimizing the overhead from setting up and tearing > down operations in the hardware. Currently dm-crypt itself is a big blocker as > it manua

Re: [PATCH V2 1/2] mm/memblock.c: trivial code refine in memblock_is_region_memory()

2016-12-21 Thread Michal Hocko
On Wed 21-12-16 12:43:20, Wei Yang wrote: > On Wed, Dec 21, 2016 at 08:48:09AM +0100, Michal Hocko wrote: > >On Tue 20-12-16 16:35:40, Wei Yang wrote: > >> On Mon, Dec 19, 2016 at 04:15:14PM +0100, Michal Hocko wrote: > >> >On Sun 18-12-16 14:47:49, Wei Yang wrote: > >> >> The base address is alrea

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-21 Thread Mathias Nyman
On 21.12.2016 08:57, Lu Baolu wrote: Hi Mathias, I have some comments for the implementation of xhci_handle_command_timeout() as well. On 12/20/2016 11:13 PM, Mathias Nyman wrote: On 20.12.2016 09:30, Baolin Wang wrote: ... Alright, I gathered all current work related to xhci races and timeou

Re: [v4, 3/3] ARM: dts: vf610-zii-dev-rev-b: Remove 'fixed-link' from DSA ports

2016-12-21 Thread Nikita Yushchenko
> Remove 'fixed-link' nodes from DSA ports since they are not needed (they > are not limiting link's speed and the ports will be configured to their > maximux speed as a default) > > Suggested-by: Andrew Lunn > Signed-off-by: Andrey Smirnov With this patch, ports connected to revB's second switc

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-21 Thread Mathias Nyman
On 21.12.2016 04:22, Baolin Wang wrote: Hi Mathias, On 20 December 2016 at 23:13, Mathias Nyman wrote: On 20.12.2016 09:30, Baolin Wang wrote: ... Alright, I gathered all current work related to xhci races and timeouts and put them into a branch: git://git.kernel.org/pub/scm/linux/kernel/git

[PATCH v2] net: macb: Applied changes according to review made by Andy Shevchenko.

2016-12-21 Thread Bartosz Folta
This patch is sent in regard to recently applied patch Commit 83a77e9ec4150ee4acc635638f7dedd9da523a26 net: macb: Added PCI wrapper for Platform Driver. Signed-off-by: Bartosz Folta --- Changed in v2: Size of DMA mask is set based on value held by PCI device. --- drivers/net/ethernet/cadence/mac

Re: [RFC PATCH 1/7] PF driver modified to enable HW filter support, changes works in backward compatibility mode Enable required things in Makefile Enable LZ4 dependecy inside config file

2016-12-21 Thread Sunil Kovvuri
> > #define NIC_MAX_RSS_HASH_BITS 8 > #define NIC_MAX_RSS_IDR_TBL_SIZE (1 << NIC_MAX_RSS_HASH_BITS) > +#define NIC_TNS_RSS_IDR_TBL_SIZE 5 So you want to use only 5 queues per VF when TNS is enabled, is it ?? There are 4096 RSS indices in total, for each VF you can use max 32

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

2016-12-21 Thread Hari Bathini
Hi Peter, On Saturday 17 December 2016 01:35 AM, Peter Zijlstra wrote: On Fri, Dec 16, 2016 at 11:51:20PM +0530, Hari Bathini wrote: Hi Peter, On Friday 16 December 2016 01:27 PM, Peter Zijlstra wrote: On Fri, Dec 16, 2016 at 11:57:47AM +0530, Hari Bathini wrote: On Friday 16 December 2016

Re: [RFC 10/10] kmod: add a sanity check on module loading

2016-12-21 Thread Luis R. Rodriguez
On Tue, Dec 20, 2016 at 8:21 PM, Rusty Russell wrote: > "Luis R. Rodriguez" writes: >> OK -- if userspace messes up again it may be a bit hard to prove >> unless we have a validation debug thing in place, would such a thing >> in debug form be reasonable ? > > That makes perfect sense. Untested

Re: [PATCH] pci: add kernel config option for disabling common PCI quirks

2016-12-21 Thread John Crispin
On 21/12/2016 13:22, Christoph Hellwig wrote: > On Wed, Dec 21, 2016 at 08:53:04AM +0100, John Crispin wrote: >> This patch has been lingering inside the OpenWrt for some years. I am not >> sure if this is the best way to remove the quirks from the build. Let me >> know if you prefer a different

[PATCH] x86/efi Fix regression in efi_arch_mem_reserve

2016-12-21 Thread Petr Oros
Booting on EFI with ESRT table has been stop since commit: 8e80632 efi/esrt: Use efi_mem_reserve() and avoid a kmalloc() This is caused by this commit: 816e761 efi: Allow drivers to reserve boot services forever Problem is, that efi_memmap_insert need memory aligned on EFI_PAGE_SI

Re: [PATCH] at86rf230: Allow slow GPIO pins for "rstn"

2016-12-21 Thread Stefan Schmidt
Hello. On 19/12/16 00:25, Andrey Smirnov wrote: Driver code never touches "rstn" signal in atomic context, so there's no need to implicitly put such restriction on it by using gpio_set_value to manipulate it. Replace gpio_set_value to gpio_set_value_cansleep to fix that. We need to make sure w

Re: [PATCH V2 2/2] mm/memblock.c: check return value of memblock_reserve() in memblock_virt_alloc_internal()

2016-12-21 Thread Wei Yang
On Wed, Dec 21, 2016 at 08:51:16AM +0100, Michal Hocko wrote: >On Tue 20-12-16 16:48:23, Wei Yang wrote: >> On Mon, Dec 19, 2016 at 04:21:57PM +0100, Michal Hocko wrote: >> >On Sun 18-12-16 14:47:50, Wei Yang wrote: >> >> memblock_reserve() may fail in case there is not enough regions. >> > >> >Hav

Re: [PATCH V2 1/2] mm/memblock.c: trivial code refine in memblock_is_region_memory()

2016-12-21 Thread Wei Yang
On Wed, Dec 21, 2016 at 01:48:17PM +0100, Michal Hocko wrote: >On Wed 21-12-16 12:43:20, Wei Yang wrote: >> On Wed, Dec 21, 2016 at 08:48:09AM +0100, Michal Hocko wrote: >> >On Tue 20-12-16 16:35:40, Wei Yang wrote: >> >> On Mon, Dec 19, 2016 at 04:15:14PM +0100, Michal Hocko wrote: >> >> >On Sun 1

Re: [PATCH V2 2/3] mtd: spi-nor: add support for macronix mx25u3235f

2016-12-21 Thread John Crispin
On 21/12/2016 11:27, Cyrille Pitchen wrote: > Hi all, > > Le 21/12/2016 à 08:23, John Crispin a écrit : >> From: André Valentin >> >> This patch adds support for a new macronix spi flash chip. We have had this >> patch inside our tree for a while and people are actively using routers >> with th

Re: [PATCH v4 2/3] perf tool: add PERF_RECORD_NAMESPACES to include namespaces related info

2016-12-21 Thread Hari Bathini
Hi Jiri, On Saturday 17 December 2016 11:10 PM, Jiri Olsa wrote: On Fri, Dec 16, 2016 at 12:07:20AM +0530, Hari Bathini wrote: SNIP + +int thread__set_namespaces(struct thread *thread, u64 timestamp, + struct namespaces_event *event) +{ + struct namespaces *new

Re: BQ27xxx registers

2016-12-21 Thread Sebastian Reichel
Hi, On Wed, Dec 21, 2016 at 01:46:17PM +0100, Pali Rohár wrote: > On Wednesday 21 December 2016 03:49:10 Chris Lapa wrote: > > On 20/12/16 10:34 pm, Pali Rohár wrote: > > > On Tuesday 20 December 2016 07:00:41 Chris Lapa wrote: > > >> I can generate a patch to fix this issue, however the bigger >

Re: [PATCH v6] media: et8ek8: add device tree binding documentation

2016-12-21 Thread Pavel Machek
On Tue 2016-12-20 15:05:39, Sakari Ailus wrote: > Hi Pavel, > > > +Endpoint node mandatory properties > > +-- > > + > > +- remote-endpoint: A phandle to the bus receiver's endpoint node. > > + > > +Endpoint node optional properties > > +-

Re: [PATCH V2 2/2] mm/memblock.c: check return value of memblock_reserve() in memblock_virt_alloc_internal()

2016-12-21 Thread Michal Hocko
On Wed 21-12-16 13:13:32, Wei Yang wrote: > On Wed, Dec 21, 2016 at 08:51:16AM +0100, Michal Hocko wrote: > >On Tue 20-12-16 16:48:23, Wei Yang wrote: > >> On Mon, Dec 19, 2016 at 04:21:57PM +0100, Michal Hocko wrote: > >> >On Sun 18-12-16 14:47:50, Wei Yang wrote: > >> >> memblock_reserve() may fa

Re: [PATCH v3 1/3] drivers: crypto: Add Support for Octeon-tx CPT Engine

2016-12-21 Thread Corentin Labbe
Hello I have some comment inline On Wed, Dec 21, 2016 at 11:56:11AM +, george.cher...@cavium.com wrote: > From: George Cherian > > Enable the Physical Function diver for the Cavium Crypto Engine (CPT) typo driver > found in Octeon-tx series of SoC's. CPT is the Cryptographic Acceleration

Re: [PATCH 03/15] hyperv: use standard bitops

2016-12-21 Thread Roman Kagan
On Wed, Dec 21, 2016 at 01:00:44PM +0100, Olaf Hering wrote: > On Tue, Dec 20, Roman Kagan wrote: > > Reverting commit 22356585712d ("staging: hv: use sync_bitops when > interacting with the hypervisor") is save because ... > > > - sync_set_bit(channel->monitor_bit, > > +

Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

2016-12-21 Thread Peter Zijlstra
On Wed, Dec 21, 2016 at 06:39:01PM +0530, Hari Bathini wrote: > Hi Peter, > >I don't see how the tool can parse old records (with NAMESPACES_MAX == > >7) if you set its NAMESPACES_MAX to say 10. > > > >Then it will expect the link_info array to be 10 entries and either read > >past the end of the

Re: [v4, 3/3] ARM: dts: vf610-zii-dev-rev-b: Remove 'fixed-link' from DSA ports

2016-12-21 Thread Uwe Kleine-König
On Wed, Dec 21, 2016 at 03:58:45PM +0300, Nikita Yushchenko wrote: > > Remove 'fixed-link' nodes from DSA ports since they are not needed (they > > are not limiting link's speed and the ports will be configured to their > > maximux speed as a default) > > > > Suggested-by: Andrew Lunn > > Signed-o

Re: [v4,1/3] ARM: dts: vf610-zii-dev-rev-b: Remove leftover PWM pingroup

2016-12-21 Thread Nikita Yushchenko
> Remove pwm0grp since it is: > > a) Not referenced anywhere in the DTS file (unlike Tower board it > is based on, this board does not use/expose FTM0) > > b) Configures PTB2 and PTB3 in a way that contradicts > pinctrl-mdio-mux > > Signed-off-by: Andrey Smirnov Tested-by:

Re: [PATCH] usbip: vudc: check for NULL before use

2016-12-21 Thread Sudip Mukherjee
-EINVAL; > > Hmm. Linus's latest checks _ep and _req. Are you sure you are working > with the latest tree? I checked with next-20161221 and its still there. regards sudip

Re: [PATCH V2 2/3] mtd: spi-nor: add support for macronix mx25u3235f

2016-12-21 Thread Cyrille Pitchen
Le 21/12/2016 à 14:16, John Crispin a écrit : > > > On 21/12/2016 11:27, Cyrille Pitchen wrote: >> Hi all, >> >> Le 21/12/2016 à 08:23, John Crispin a écrit : >>> From: André Valentin >>> >>> This patch adds support for a new macronix spi flash chip. We have had this >>> patch inside our tree fo

Re: [PATCH 2/3] drivers/perf: arm_pmu: add arm_pmu_device_remove

2016-12-21 Thread Peter Zijlstra
On Wed, Dec 21, 2016 at 11:19:34AM +0100, Alexander Stein wrote: > Add ARM PMU removal function. This will be required by perf event drivers > when option DEBUG_TEST_DRIVER_REMOVE is enabled. > > Signed-off-by: Alexander Stein > --- > drivers/perf/arm_pmu.c | 14 ++ > include/l

Re: [PATCH v5] media: Driver for Toshiba et8ek8 5MP sensor

2016-12-21 Thread Sakari Ailus
Hi Pavel, Thanks for the update. On Wed, Dec 14, 2016 at 01:24:51PM +0100, Pavel Machek wrote: ... > +static int et8ek8_set_ctrl(struct v4l2_ctrl *ctrl) > +{ > + struct et8ek8_sensor *sensor = > + container_of(ctrl->handler, struct et8ek8_sensor, ctrl_handler); > + > + switch

Re: [PATCH v3 04/15] livepatch/x86: add TIF_PATCH_PENDING thread flag

2016-12-21 Thread Miroslav Benes
On Thu, 8 Dec 2016, Josh Poimboeuf wrote: > Add the TIF_PATCH_PENDING thread flag to enable the new livepatch > per-task consistency model for x86_64. The bit getting set indicates > the thread has a pending patch which needs to be applied when the thread > exits the kernel. > > The bit is place

[PATCH] snic: Return error code on memory allocation failure

2016-12-21 Thread Burak Ok
If a call to mempool_create_slab_pool() in snic_probe() returns NULL, return -ENOMEM to indicate failure. mempool_creat_slab_pool() only fails if it cannot allocate memory. https://bugzilla.kernel.org/show_bug.cgi?id=189061 Reported-by: bianpan2...@ruc.edu.cn Signed-off-by: Burak Ok Signed-off-b

Re: [PATCH] scsi: do not requeue requests unaligned with device sector size

2016-12-21 Thread Martin K. Petersen
> "Mauricio" == Mauricio Faria de Oliveira > writes: Mauricio, Mauricio> When a SCSI command (e.g., read operation) is partially Mauricio> completed with good status and residual bytes (i.e., not all Mauricio> the bytes from the specified transfer length were transferred) Mauricio> the

Re: [PATCH v3 2/3] drivers: crypto: Add the Virtual Function driver for CPT

2016-12-21 Thread Corentin Labbe
Hello I have some comment inline On Wed, Dec 21, 2016 at 11:56:12AM +, george.cher...@cavium.com wrote: > From: George Cherian > > Enable the CPT VF driver. CPT is the cryptographic Accelaration Unit typo acceleration [...] > +static inline void update_input_data(struct cpt_request_info *

[GIT PULL] Please pull Linux client updates

2016-12-21 Thread Trond Myklebust
Hi Linus, This pull request is on overtime, I know, but the contents should be fairly uncontroversial. The main reason for pushing them now rather than next week is that technically, the attribute cache improvements are a performance improvement and so ought to be pushed during the merge window.

Re: OOM: Better, but still there on

2016-12-21 Thread Chris Mason
On Wed, Dec 21, 2016 at 12:16:53PM +0100, Michal Hocko wrote: On Wed 21-12-16 20:00:38, Tetsuo Handa wrote: One thing to note here, when we are talking about 32b kernel, things have changed in 4.8 when we moved from the zone based to node based reclaim (see b2e18757f2c9 ("mm, vmscan: begin recla

Re: [PATCH 1/2] btrfs: drop trace_btrfs_all_work_done() from normal_work_helper()

2016-12-21 Thread David Sterba
On Wed, Dec 21, 2016 at 04:45:06PM +0800, Qu Wenruo wrote: > > > At 12/21/2016 04:28 PM, Sebastian Andrzej Siewior wrote: > > On 2016-12-21 08:33:03 [+0800], Qu Wenruo wrote: > >> The trace point only uses the pointer, and this helps us to pair with > >> btrfs_work_queued/sched. > > > > | /* For

RE: [PATCH v3] net: macb: Added PCI wrapper for Platform Driver.

2016-12-21 Thread Bartosz Folta
> And one more > > + plat_info.dma_mask = DMA_BIT_MASK(32); > > Perhaps > plat_info.dma_mask = pdev->dma_mask; > ? Thank you. I tested your suggestion. I have sent second version of patch. https://patchwork.ozlabs.org/patch/707800/ Regards, Bartosz Folta

Re: [PATCH v4 0/9] Implement clocksource for rockchip SoC using rockchip timer

2016-12-21 Thread Alexander Kochetkov
Hello Heiko, Daniel! Are there any reasons why the patches [1][2] are not applied yet into kernel? How can I help in applying patches? Regards, Alexander. [1] http://lists.infradead.org/pipermail/linux-rockchip/2016-November/thread.html#13236 [PATCH v4 0/9] Implement clocksource for rockch

Re: [PATCH 7/8] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

2016-12-21 Thread Jens Axboe
On 12/21/2016 04:59 AM, Bart Van Assche wrote: > Since this patch is the first patch that introduces a call to > blk_queue_exit() from a module other than the block layer core, > shouldn't this patch export the blk_queue_exit() function? An attempt > to build mq-deadline as a module resulted in the

Re: HalfSipHash Acceptable Usage

2016-12-21 Thread Jason A. Donenfeld
Hi George, On Wed, Dec 21, 2016 at 7:34 AM, George Spelvin wrote: > In fact, I have an idea. Allow me to make the following concrete > suggestion for using HalfSipHash with 128 bits of key material: > > - 64 bits are used as the key. > - The other 64 bits are used as an IV which is prepended to

Re: [PATCH] pci: add kernel config option for disabling common PCI quirks

2016-12-21 Thread Christoph Hellwig
On Wed, Dec 21, 2016 at 02:11:25PM +0100, John Crispin wrote: > I can turn it into an enable patch that is selected by default. > > The current patch disables all those quirks that are used for x86/PC > style machines and hence are not required in the embedded world. Maybe we'll just need to reor

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Christoph Hellwig
On Wed, Dec 21, 2016 at 03:59:20PM +0300, Roman Kagan wrote: > That's fine by me. > > I guess the series should then start with a complete move > arch/x86/include/uapi/asm/hyperv.h -> > arch/x86/include/asm/hyperv_proto.h, and the remaining patches have to > change the latter instead of the former

Re: [PATCH][V2] qed: fix memory leak of a qed_spq_entry on error failure paths

2016-12-21 Thread Colin Ian King
On 21/12/16 13:29, Mintz, Yuval wrote: >> From: Colin Ian King >> >> A qed_spq_entry entry is allocated by qed_sp_init_request but is not kfree'd >> if an error occurs, causing a memory leak. Fix this by returning the >> previously >> allocated spq entry and also setting *pp_ent to NULL to be saf

Re: [v2] ath9k: do not return early to fix rcu unlocking

2016-12-21 Thread Kalle Valo
Tobias Klausmann wrote: > Starting with commit d94a461d7a7d ("ath9k: use ieee80211_tx_status_noskb > where possible") the driver uses rcu_read_lock() && rcu_read_unlock(), yet on > returning early in ath_tx_edma_tasklet() the unlock is missing leading to > stalls > and suspicious RCU usage: > >

Re: [PATCH v3 05/15] livepatch/powerpc: add TIF_PATCH_PENDING thread flag

2016-12-21 Thread Miroslav Benes
On Thu, 8 Dec 2016, Josh Poimboeuf wrote: > Add the TIF_PATCH_PENDING thread flag to enable the new livepatch > per-task consistency model for powerpc. The bit getting set indicates > the thread has a pending patch which needs to be applied when the thread > exits the kernel. > > The bit is incl

Re: rtlwifi: Fix kernel oops introduced with commit e49656147359

2016-12-21 Thread Kalle Valo
Larry Finger wrote: > With commit e49656147359 {"rtlwifi: Use dev_kfree_skb_irq instead of > kfree_skb"), the method used to free an skb was changed because the > kfree_skb() was inside a spinlock. What was forgotten is that kfree_skb() > guards against a NULL value for the argument. Routine dev_k

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-21 Thread OGAWA Hirofumi
Mathias Nyman writes: >> Below is the latest code. I put my comments in line. >> >> 322 static int xhci_abort_cmd_ring(struct xhci_hcd *xhci) >> 323 { >> 324 u64 temp_64; >> 325 int ret; >> 326 >> 327 xhci_dbg(xhci, "Abort command ring\n"); >> 328 >> 329

[PATCHv6 1/7] printk: use vprintk_func in vprintk()

2016-12-21 Thread Sergey Senozhatsky
vprintk(), just like printk(), better be using per-cpu printk_func instead of direct vprintk_emit() call. Just in case if vprintk() will ever be called from NMI, or from any other context that can deadlock in printk(). Signed-off-by: Sergey Senozhatsky Reviewed-by: Steven Rostedt Reviewed-by: Pe

[PATCHv6 2/7] printk: rename nmi.c and exported api

2016-12-21 Thread Sergey Senozhatsky
A preparation patch for printk_safe work. No functional change. - rename nmi.c to print_safe.c - rename exported functions to have a `printk_safe' prefix. Signed-off-by: Sergey Senozhatsky Acked-by: Steven Rostedt Reviewed-by: Petr Mladek --- arch/arm/kernel/smp.c | 4 +- inc

[PATCHv6 0/7] printk: use printk_safe to handle printk() recursive calls

2016-12-21 Thread Sergey Senozhatsky
Hello, This patch set extends a lock-less NMI per-cpu buffers idea to handle recursive printk() calls. The basic mechanism is pretty much the same -- at the beginning of a deadlock-prone section we switch to lock-less printk callback, and return back to a default printk implementation at t

[PATCH v2 04/12] power: supply: axp288_charger: Register extcon notifers after power_supply

2016-12-21 Thread Hans de Goede
The extcon notifier work calls power_supply_changed on the power_supply we register, so the extcon notifiers should be registered after we register the power_supply. While touching this code anyways, refactor the code for the 3 cable types into a loop to avoid code repetition. Signed-off-by: Hans

[PATCH v2 08/12] power: supply: axp288_charger: Some minor cleanups

2016-12-21 Thread Hans de Goede
Remove info->health, info->present and info->online caching, as no code is reading the cached values. Remove if (changed) check before calling power_supply_changed(), we return early from axp288_charger_extcon_evt_worker if nothing has changed, so the check is not needed. Signed-off-by: Hans de G

[PATCHv6 6/7] printk: use printk_safe buffers in printk

2016-12-21 Thread Sergey Senozhatsky
Use printk_safe per-CPU buffers in printk recursion-prone blocks: -- around logbuf_lock protected sections in vprintk_emit() and console_unlock() -- around down_trylock_console_sem() and up_console_sem() Note that this solution addresses deadlocks caused by printk() recursive calls only. That i

[PATCH v2 11/12] power: supply: axp288_charger: Remove unnecessary irq?_en register writes

2016-12-21 Thread Hans de Goede
Setting the irq_enable bits is taken care of by the irq chip when we request the irqs and the driver should not be meddling with the irq?_en registers itself. Signed-off-by: Hans de Goede --- drivers/power/supply/axp288_charger.c | 32 1 file changed, 32 deletion

[PATCH v2 10/12] power: supply: axp288_charger: Fix wrong regmap_update_bits

2016-12-21 Thread Hans de Goede
To set a bit to 1 one needs to pass the mask for the bit to set as second argument into regmap_update_bits, not "1". Signed-off-by: Hans de Goede --- drivers/power/supply/axp288_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/axp288_charger.c b

Re: [PATCH] usbip: vudc: check for NULL before use

2016-12-21 Thread Shuah Khan
long flags; >> > int ret = 0; >> > >> > - ep = to_vep(_ep); >> > if (!_ep) >> > return -EINVAL; >> >> Hmm. Linus's latest checks _ep and _req. Are you sure you are working >> with the latest tree? > > I ch

[PATCH v2 07/12] power: supply: axp288_charger: Handle charger type changing without disconnect

2016-12-21 Thread Hans de Goede
Deal with the charger type changing without a vbus-disconnect being reported in between the 2 charger type states: -Do not return from axp288_charger_extcon_evt_worker early in this case (track old_chg_type) -Make calling axp288_charger_enable_charger with the same value as before a nop, to avoi

[PATCH v2 09/12] power: supply: axp288_charger: Get and process initial hardware-state

2016-12-21 Thread Hans de Goede
Do not wait for an extcon notification before processing the cable states, instead queue the otg / cable work on probe to make sure we immediately process the initial hardware state. Note this also requiree moving the getting of the USB_HOST cable state from the extcon notifier to the workqueue fu

Re: [PATCH 2/2] net: sfc: falcon: use new api ethtool_{get|set}_link_ksettings

2016-12-21 Thread Bert Kenward
On 20/12/16 22:24, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes > --- > drivers/net/ethernet/sfc/falcon/efx.c |2 +- > drivers/net/ethernet/sfc/falcon/ethtool.

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Roman Kagan
On Wed, Dec 21, 2016 at 06:26:54AM -0800, Christoph Hellwig wrote: > On Wed, Dec 21, 2016 at 03:59:20PM +0300, Roman Kagan wrote: > > That's fine by me. > > > > I guess the series should then start with a complete move > > arch/x86/include/uapi/asm/hyperv.h -> > > arch/x86/include/asm/hyperv_proto

Re: [PATCH V2 2/2] mm/memblock.c: check return value of memblock_reserve() in memblock_virt_alloc_internal()

2016-12-21 Thread Wei Yang
On Wed, Dec 21, 2016 at 02:22:01PM +0100, Michal Hocko wrote: >On Wed 21-12-16 13:13:32, Wei Yang wrote: >> On Wed, Dec 21, 2016 at 08:51:16AM +0100, Michal Hocko wrote: >> >On Tue 20-12-16 16:48:23, Wei Yang wrote: >> >> On Mon, Dec 19, 2016 at 04:21:57PM +0100, Michal Hocko wrote: >> >> >On Sun 1

[PATCH v2 05/12] power: supply: axp288_charger: Move init_hw_regs call before supply registration

2016-12-21 Thread Hans de Goede
Move the charger_init_hw_regs() above the power_supply_register call, the axp288_charger_usb_set_property() uses axp288_chrg_info.max_cv and .max_cc which get set by charger_init_hw_regs(). Signed-off-by: Hans de Goede --- drivers/power/supply/axp288_charger.c | 8 1 file changed, 4 ins

[PATCH v2 00/12] power: supply: axp288_charger: Various fixes

2016-12-21 Thread Hans de Goede
Hi All, Here is v2 of my axp288_charger series, which fixup the axp288_charger code to actually work. This implements the suggestion by Chanwoo Choi on how we can use the existing extcon_get_extcon_dev instead of introducing a new extcon_get_extcon_dev_by_id. So this series no longer depends on a

[PATCH v2 03/12] power: supply: axp288_charger: Use devm_power_supply_register

2016-12-21 Thread Hans de Goede
Use devm_power_supply_register instead of power_supply_register, this avoids the need to do manual cleanup and results in quite a nice code cleanup. Note it may seem excessive to add a "struct device *dev" helper local variable for the 1 time it is used in this patch, but future patches in this se

[PATCH] input: synaptics-rmi4: remove redundant null check on rmi_dev

2016-12-21 Thread Colin King
From: Colin Ian King rmi_dev is currently being dereferenced before it null checked, however, after deeper inspecting, rmi_dev can never be null, so just remove this redundant check. Thanks to Dmitry Torokhov for noticing that we can remove the null check. Fixes CoverityScan CID 1391218 ("Derefe

[PATCH v2 01/12] power: supply: axp288_charger: Make charger_init_hw_regs propagate i2c errors

2016-12-21 Thread Hans de Goede
Make charger_init_hw_regs propagate i2c errors, instead of only warning about them and then ignoring them. Signed-off-by: Hans de Goede --- drivers/power/supply/axp288_charger.c | 62 --- 1 file changed, 42 insertions(+), 20 deletions(-) diff --git a/drivers/powe

[PATCHv6 4/7] printk: always use deferred printk when flush printk_safe lines

2016-12-21 Thread Sergey Senozhatsky
Always use printk_deferred() in printk_safe_flush_line(). Flushing can be done from NMI or printk_safe contexts (when we are in panic), so we can't call console drivers, yet still want to store the messages in the logbuf buffer. Therefore we use a deferred printk version. Signed-off-by: Sergey Sen

[PATCH v2 02/12] power: supply: axp288_charger: Drop platform_data dependency

2016-12-21 Thread Hans de Goede
When the axp288_charger driver was originally merged, it was merged with a dependency on some other driver providing platform data for it. However the battery-data-framework which should provide that data never got merged, so the axp288_charger as merged upstream has never worked, its probe method

[PATCH v2 06/12] power: supply: axp288_charger: Actually get and use the USB_HOST extcon device

2016-12-21 Thread Hans de Goede
Nothing was setting info->otg.cable, so the extcon_get_cable_state_ calls on it would always return -EINVAL. This commit fixes this by actually setting info->otg.cable using the new extcon_get_extcon_dev_by_cable_id function. This commit also makes failing to register the extcon notifier for the

[PATCHv6 3/7] printk: introduce per-cpu safe_print seq buffer

2016-12-21 Thread Sergey Senozhatsky
This patch extends the idea of NMI per-cpu buffers to regions that may cause recursive printk() calls and possible deadlocks. Namely, printk() can't handle printk calls from schedule code or printk() calls from lock debugging code (spin_dump() for instance); because those may be called with `sem->l

Re: A small window for a race condition in mm/rmap.c:page_lock_anon_vma_read

2016-12-21 Thread Michal Hocko
anon_vma locking is clever^Wsubtle as hell. CC Peter... On Tue 20-12-16 09:32:27, Dashi DS1 Cao wrote: > I've collected four crash dumps with similar backtrace. > > PID: 247TASK: 881fcfad8000 CPU: 14 COMMAND: "kswapd1" > #0 [881fcfad7978] machine_kexec at 81051e9b > #1 [f

Re: [PATCH] input: synaptics-rmi4: check for null rmi_dev before it is dereferenced

2016-12-21 Thread Colin Ian King
On 20/12/16 21:22, Dmitry Torokhov wrote: > Hi Colin, > > On Tue, Dec 20, 2016 at 10:07:50AM +, Colin King wrote: >> From: Colin Ian King >> >> rmi_dev is currently being dereferenced before it null checked, so we >> have a potential null pointer dereference issue with this. Fix this >> by d

Re: HalfSipHash Acceptable Usage

2016-12-21 Thread Jason A. Donenfeld
Hi Eric, I computed performance numbers for both 32-bit and 64-bit using the actual functions in which talking about replacing MD5 with SipHash. The basic harness is here [1] if you're curious. SipHash was a pretty clear winner for both cases. x86_64: [1.714302] secure_tcpv6_sequence_number_m

Re: [PATCH v3 15/15] livepatch: allow removal of a disabled patch

2016-12-21 Thread Petr Mladek
On Thu 2016-12-08 12:08:40, Josh Poimboeuf wrote: > From: Miroslav Benes > > Currently we do not allow patch module to unload since there is no > method to determine if a task is still running in the patched code. > > The consistency model gives us the way because when the unpatching > finishes

Re: [PATCH 12/15] hyperv: move VMBus connection ids to uapi

2016-12-21 Thread Roman Kagan
On Wed, Dec 21, 2016 at 04:18:58AM -0800, Christoph Hellwig wrote: > On Wed, Dec 21, 2016 at 09:29:39AM +0300, Roman Kagan wrote: > > QEMU in particular. We're planning to implement VMBus devices in QEMU > > and would like to have the definitions shared with the Linux guest > > drivers for Hyper-V

[PATCH] Staging: vt6656: checkpatch: fix identifier name in wcmd.h

2016-12-21 Thread Tobias Heineken
This is a patch to the wcmd.h file that fixes up two identifier name warnings found by the checkpatch.pl tool at lines 54 and 56 Signed-off-by: Tobias Heineken Signed-off-by: Florian Schleicher CC: linux-ker...@i4.cs.fau.de --- drivers/staging/vt6656/wcmd.h | 4 ++-- 1 file changed, 2 insertion

Re: [PATCH V2 2/2] mm/memblock.c: check return value of memblock_reserve() in memblock_virt_alloc_internal()

2016-12-21 Thread Michal Hocko
On Wed 21-12-16 14:39:56, Wei Yang wrote: > On Wed, Dec 21, 2016 at 02:22:01PM +0100, Michal Hocko wrote: [...] > >Anyway this all should be part of the changelog. > > Ok, let me add this in changelog in next version. Then make sure to document how it could happen and how realistic such a scenari

Re: [PATCH 2/3] drivers/perf: arm_pmu: add arm_pmu_device_remove

2016-12-21 Thread Alexander Stein
On Wednesday 21 December 2016 14:38:54, Peter Zijlstra wrote: > On Wed, Dec 21, 2016 at 11:19:34AM +0100, Alexander Stein wrote: > > Add ARM PMU removal function. This will be required by perf event drivers > > when option DEBUG_TEST_DRIVER_REMOVE is enabled. > > > > Signed-off-by: Alexander Stein

[PATCHv6 7/7] printk: remove zap_locks() function

2016-12-21 Thread Sergey Senozhatsky
We use printk-safe now which makes printk-recursion detection code in vprintk_emit() unreachable. The tricky thing here is that, apart from detecting and reporting printk recursions, that code also used to zap_locks() in case of panic() from the same CPU. However, zap_locks() does not look to be ne

[PATCHv6 5/7] printk: report lost messages in printk safe/nmi contexts

2016-12-21 Thread Sergey Senozhatsky
Account lost messages in pritk-safe and printk-safe-nmi contexts and report those numbers during printk_safe_flush(). The patch also moves lost message counter to struct `printk_safe_seq_buf' instead of having dedicated static counters - this simplifies the code. Signed-off-by: Sergey Senozhatsky

[PATCH v2 12/12] power: supply: axp288_charger: Fix the module not auto-loading

2016-12-21 Thread Hans de Goede
Add a MODULE_DEVICE_TABLE to fix the module not auto-loading. Signed-off-by: Hans de Goede --- drivers/power/supply/axp288_charger.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/power/supply/axp288_charger.c b/drivers/power/supply/axp288_charger.c index 6e588e6..ca4fa51 10

Re: [PATCH] usbip: vudc: check for NULL before use

2016-12-21 Thread Krzysztof Opasiak
,10 @@ static int vep_dequeue(struct usb_ep *_ep, struct >>>> usb_request *_req) >>>> unsigned long flags; >>>> int ret = 0; >>>> >>>> - ep = to_vep(_ep); >>>> if (!_ep) >>>> return -EINV

RE: [PATCH][V2] qed: fix memory leak of a qed_spq_entry on error failure paths

2016-12-21 Thread Mintz, Yuval
> From: Colin Ian King > > A qed_spq_entry entry is allocated by qed_sp_init_request but is not kfree'd > if an error occurs, causing a memory leak. Fix this by returning the > previously > allocated spq entry and also setting *pp_ent to NULL to be safe. > > Thanks to Yuval Mintz for suggestion

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-21 Thread Mathias Nyman
On 21.12.2016 16:10, OGAWA Hirofumi wrote: Mathias Nyman writes: Below is the latest code. I put my comments in line. 322 static int xhci_abort_cmd_ring(struct xhci_hcd *xhci) 323 { 324 u64 temp_64; 325 int ret; 326 327 xhci_dbg(xhci, "Abort command r

[PATCH v2 2/2] arm: perf: Mark as non-removable

2016-12-21 Thread Alexander Stein
This driver can only built into the kernel. So disallow driver bind/unbind and also prevent a kernel error in case DEBUG_TEST_DRIVER_REMOVE is enabled. Signed-off-by: Alexander Stein --- arch/arm/kernel/perf_event_v7.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/kernel/perf_even

[PATCH v2 1/2] drivers/perf: arm_pmu: Use devm_ allocators

2016-12-21 Thread Alexander Stein
This eliminates several calls to kfree. Signed-off-by: Alexander Stein --- drivers/perf/arm_pmu.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c index b37b572..a9bbdbf 100644 --- a/drivers/perf/arm_pmu.c +++ b/d

[PATCH v2 0/2] mark driver as non-removable

2016-12-21 Thread Alexander Stein
Changes in v2; * Instead of adding a remove function which is unused otherwise, mark the driver as non-remoable Using DEBUG_TEST_DRIVER_REMOVE every driver gets probed, removed and probed again. This breaks drivers without removal function, e.g. arm perf resulting in the following dump:

Re: [PATCH] MAINTAINERS: add myself as maintainer of fbdev

2016-12-21 Thread Sudip Mukherjee
On Thu, Dec 15, 2016 at 03:45:47PM +0100, Bartlomiej Zolnierkiewicz wrote: > I would like to help with fbdev maintenance. I can dedicate some time > for reviewing and handling patches but won't have time for much more. > I thought usually someone takes over the maintainer role after proving that

Re: [PATCH] snic: Return error code on memory allocation failure

2016-12-21 Thread Narsimhulu Musini (nmusini)
On 21/12/16 7:15 pm, "Burak Ok" wrote: >If a call to mempool_create_slab_pool() in snic_probe() returns NULL, >return -ENOMEM to indicate failure. mempool_creat_slab_pool() only fails >if >it cannot allocate memory. > >https://bugzilla.kernel.org/show_bug.cgi?id=189061 > >Reported-by: bianpan2..

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-21 Thread OGAWA Hirofumi
Mathias Nyman writes: >> We set CMD_RING_STATE_ABORTED state under locking. I'm not checking what >> is for taking lock for register though, I guess it should be enough just >> lock around of read=>write of ->cmd_ring if need lock. > > After your patch it should be enough to have the lock only wh

<    1   2   3   4   5   6   7   >