Re: [PATCH 8/8] KVM: x86: add SPEC_CTRL and IBPB_SUPPORT to MSR and CPUID lists

2018-01-13 Thread Paolo Bonzini
Just add the new MSR at the end of the array. Paolo - Eric Wheeler ha scritto: > On Tue, 9 Jan 2018, Paolo Bonzini wrote: > > > Expose them to userspace, now that guests can use them. > > I am not adding cpufeatures here to avoid having a kernel > > that shows spec_ctrl in /proc/cpuinfo and

[PATCH] bcache: Use seq_putc() in debug_seq_show()

2018-01-13 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 13 Jan 2018 09:05:03 +0100 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/md/bcache/closure.c | 2

Re: [PATCH v2] delayacct: Account blkio completion on the correct task

2018-01-13 Thread Balbir Singh
On Mon, Dec 18, 2017 at 9:45 PM, Josh Snyder wrote: > Before commit e33a9bba85a8 ("sched/core: move IO scheduling accounting from > io_schedule_timeout() into scheduler"), delayacct_blkio_end was called after > context-switching into the task which completed I/O. This resulted in double > counting

Re: [alsa-devel] [RESEND PATCH v2 08/15] ASoC: qcom: q6asm: add support to audio stream apis

2018-01-13 Thread Rohit Kumar
On 12/14/2017 11:03 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to open, write and media format commands in the q6asm module. [..] +static int32_t q6asm_callback(struct apr_device *adev, + struct apr_client_data *da

Re: [alsa-devel] [RESEND PATCH v2 12/15] ASoC: qcom: qdsp6: Add support to q6asm dai driver

2018-01-13 Thread Rohit Kumar
On 12/14/2017 11:03 PM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch adds support to q6asm dai driver which configures Q6ASM streams to pass pcm data. Currently the driver only exposes 2 playback streams for hdmi playback support, it can be easily extended to add

[PATCH v2] md-multipath: Use seq_putc() in multipath_status()

2018-01-13 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 13 Jan 2018 09:49:03 +0100 A single character (closing square bracket) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/md/md-multi

Re: [PATCH v2 10/19] ipv4: prevent bounds-check bypass via speculative execution

2018-01-13 Thread Greg KH
On Fri, Jan 12, 2018 at 10:47:44AM -0800, Dan Williams wrote: > On Thu, Jan 11, 2018 at 11:59 PM, Greg KH wrote: > >> Cc: "David S. Miller" > >> Cc: Alexey Kuznetsov > >> Cc: Hideaki YOSHIFUJI > >> Cc: net...@vger.kernel.org > >> Signed-off-by: Elena Reshetova > >> Signed-off-by: Dan Williams

Re: dvb usb issues since kernel 4.9

2018-01-13 Thread Mauro Carvalho Chehab
Em Fri, 12 Jan 2018 13:48:46 -0800 Eric Dumazet escreveu: > On Fri, 2018-01-12 at 19:13 -0200, Mauro Carvalho Chehab wrote: > > > > > > The .config file used to build the Kernel is at: > > https://pastebin.com/wpZghann > > > > Hi Mauro > > Any chance you can try CONFIG_HZ_1000=y, CONFIG_

Re: [PATCH] iio: adc: driver for ti adc081s/adc101s/adc121s

2018-01-13 Thread Lars-Peter Clausen
On 01/12/2018 09:38 PM, Milan Stevanovic wrote: > From cb437dd49444fb12897f88ccf485369e6ed3184e Mon Sep 17 00:00:00 2001 > From: Milan Stevanovic > Date: Sun, 7 Jan 2018 21:44:33 +0100 > Subject: [PATCH] iio: adc: driver for ti adc081s/adc101s/adc121s > >     Add Linux device driver for TI single

Re: [PATCH] elf: fix NT_FILE integer overflow

2018-01-13 Thread Alexey Dobriyan
On Fri, Jan 12, 2018 at 02:52:08PM -0800, Andrew Morton wrote: > On Fri, 12 Jan 2018 23:34:27 +0300 Alexey Dobriyan > wrote: > > > If vm.max_map_count bumped above 2^26 (67+ mil) and system has enough > > RAM to allocate all the VMAs (~12.8 GB on Fedora 27 with 200-byte VMAs), > > then it should

Re: [PATCH] kconfig: Sync zconf.y with zconf.tab.c_shipped

2018-01-13 Thread Ulf Magnusson
On Fri, Jan 12, 2018 at 8:38 PM, Sam Ravnborg wrote: > Hi Ulf, Masahiro > >> > >> > BTW, I do not know the historical reason >> > why zconf instead of kconf in the first place... >> >> I have no idea either. kconfig.{l,y} and kconfig_*() would be a lot >> less confusing. > > zconf was the name ori

[PATCH] memory-EMIF: Use seq_putc() in emif_regdump_show()

2018-01-13 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 13 Jan 2018 10:24:03 +0100 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/memory/emif.c | 2 +- 1

I Am Intereted In You.

2018-01-13 Thread Aniccet Ibrahim
Greeting to you and how is your family? sorry for my way of approach to you, it is because i do not have choice. I am Aniccet Ibrahim From Ivory Coast. My story is connected to the fight with the Republican Forces. I have a business proposals for you. If your interested i want you to reply me

AW: [alsa-devel] [PATCH] ASoC: sgtl5000: fix powerup/down of micbias-voltage

2018-01-13 Thread Fischer, Christian
>> What about using simple audio card binding in your device tree instead? >> >> You could pass the simple-audio-card,routing property as described in >> Documentation/devicetree/bindings/sound/simple-card.txt >> >> A dts where sgtl5000 is used with simple audio card is >> arch/arm/boot/dts/imx7s-w

Re: stable-rc build: 0 warnings 5 failures (stable-rc/v3.18.91-23-g72813f7)

2018-01-13 Thread gregkh
On Fri, Jan 12, 2018 at 12:02:10PM +0100, Boris Brezillon wrote: > On Fri, 12 Jan 2018 11:57:55 +0100 > Arnd Bergmann wrote: > > > On Fri, Jan 12, 2018 at 11:49 AM, Olof's autobuilder > > wrote: > > > Here are the build results from automated periodic testing. > > > > > > The tree being built w

[PATCH] pinctrl/nomadik/abx500: Use seq_putc() in abx500_gpio_dbg_show()

2018-01-13 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 13 Jan 2018 11:04:29 +0100 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/pinctrl/nomadik/pinctrl

Re: [PATCH 3/8] kvm: vmx: pass MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD down to the guest

2018-01-13 Thread Longpeng (Mike)
On 2018/1/9 20:03, Paolo Bonzini wrote: > Direct access to MSR_IA32_SPEC_CTRL and MSR_IA32_PRED_CMD is important > for performance. Allow load/store of MSR_IA32_SPEC_CTRL, restore guest > IBRS on VM entry and set it to 0 on VM exit (because Linux does not use > it yet). > > Signed-off-by: Paol

Re: [PATCH] selftests/x86: Add test_vsyscall

2018-01-13 Thread Ingo Molnar
* Andy Lutomirski wrote: > On Fri, Jan 12, 2018 at 4:57 AM, Ingo Molnar wrote: > > > > * Andy Lutomirski wrote: > > > >> tools/testing/selftests/x86/Makefile| 2 +- > >> tools/testing/selftests/x86/test_vsyscall.c | 500 > >> > >> 2 files changed, 501 in

Re: [PATCH 4/8] kvm: vmx: Set IBPB when running a different VCPU

2018-01-13 Thread Woodhouse, David
On Fri, 2018-01-12 at 09:03 -0800, Jim Mattson wrote: > The point behind the IPBP in vmx_vcpu_load is to prevent one VCPU from > steering the speculative execution of the next. If the VMCS address is > recycled, vmx_vcpu_load doesn't realize that the VCPUs are different, > and so it won't issue the

Re: [PATCH 4.4 020/115] userfaultfd: selftest: vm: allow to build in vm/ directory

2018-01-13 Thread Greg Kroah-Hartman
On Thu, Jan 11, 2018 at 07:42:48PM +, Ben Hutchings wrote: > On Mon, 2017-12-18 at 16:48 +0100, Greg Kroah-Hartman wrote: > > 4.4-stable review patch.  If anyone has any objections, please let me know. > > > > -- > > > > From: Andrea Arcangeli > > > > > > [ Upstream commit

pull-request: wireless-drivers-next 2018-01-13

2018-01-13 Thread Kalle Valo
Hi Dave, this is a pull request to net-next tree for 4.16, more info in the signed tag below. I'm not expecting any problems but please let me know if you have any. Kalle The following changes since commit f66faae2f80a45feafc04ce63ef744ac4b6e8c05: Merge branch 'ipv6-ipv4-nexthop-align' (2018-

[tip:x86/pti] selftests/x86: Add test_vsyscall

2018-01-13 Thread tip-bot for Andy Lutomirski
Commit-ID: 352909b49ba0d74929b96af6dfbefc854ab6ebb5 Gitweb: https://git.kernel.org/tip/352909b49ba0d74929b96af6dfbefc854ab6ebb5 Author: Andy Lutomirski AuthorDate: Thu, 11 Jan 2018 17:16:51 -0800 Committer: Ingo Molnar CommitDate: Sat, 13 Jan 2018 11:23:03 +0100 selftests/x86: Add test

[tip:x86/pti] x86/retpoline: Use LFENCE instead of PAUSE in the retpoline/RSB filling RSB macros

2018-01-13 Thread tip-bot for Tom Lendacky
Commit-ID: 2eb9137c8744f9adf1670e9aa52850948a30112b Gitweb: https://git.kernel.org/tip/2eb9137c8744f9adf1670e9aa52850948a30112b Author: Tom Lendacky AuthorDate: Fri, 12 Jan 2018 19:07:28 -0600 Committer: Ingo Molnar CommitDate: Sat, 13 Jan 2018 11:28:50 +0100 x86/retpoline: Use LFENCE

Re: dvb usb issues since kernel 4.9

2018-01-13 Thread Mauro Carvalho Chehab
Em Sat, 13 Jan 2018 07:09:20 -0200 Mauro Carvalho Chehab escreveu: > Em Fri, 12 Jan 2018 13:48:46 -0800 > Eric Dumazet escreveu: > > > On Fri, 2018-01-12 at 19:13 -0200, Mauro Carvalho Chehab wrote: > > > > > > > > > The .config file used to build the Kernel is at: > > > https://pastebin.co

Re: [PATCH v1] x86/retpoline: Use lfence in the retpoline/RSB filling RSB macros

2018-01-13 Thread Woodhouse, David
On Fri, 2018-01-12 at 19:07 -0600, Tom Lendacky wrote: > The pause instruction is currently used in the retpoline and RSB filling > macros as a speculation trap.  The use of pause was originally suggested > because it showed a very, very small difference in the amount of > cycles/time used to execu

[PATCH] pinctrl: pinmux: Use seq_putc() in pinmux_pins_show()

2018-01-13 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 13 Jan 2018 11:33:47 +0100 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/pinctrl/pinmux.c | 2 +-

Re: [PATCH] kdump: Write a correct address of mem_section into vmcoreinfo

2018-01-13 Thread Ingo Molnar
* Kirill A. Shutemov wrote: > Depending on configuration mem_section can now be an array or a pointer > to an array allocated dynamically. In most cases, we can continue to refer > to it as 'mem_section' regardless of what it is. > > But there's one exception: '&mem_section' means "address of t

[tip:x86/urgent] kdump: Write the correct address of mem_section into vmcoreinfo

2018-01-13 Thread tip-bot for Kirill A. Shutemov
Commit-ID: 9f15b9120f562ae0bf0a836c96f4dafb33ae426a Gitweb: https://git.kernel.org/tip/9f15b9120f562ae0bf0a836c96f4dafb33ae426a Author: Kirill A. Shutemov AuthorDate: Fri, 12 Jan 2018 19:25:32 +0300 Committer: Ingo Molnar CommitDate: Sat, 13 Jan 2018 11:48:06 +0100 kdump: Write the cor

[PATCH BUGFIX/IMPROVEMENT 2/2] block, bfq: limit sectors served with interactive weight raising

2018-01-13 Thread Paolo Valente
To maximise responsiveness, BFQ raises the weight, and performs device idling, for bfq_queues associated with processes deemed as interactive. In particular, weight raising has a maximum duration, equal to the time needed to start a large application. If a weight-raised process goes on doing I/O be

[PATCH BUGFIX/IMPROVEMENT 0/2] block, bfq: two pending patches

2018-01-13 Thread Paolo Valente
Hi Jens, here are again the two pending patches you asked me to resend [1]. One of them, fixing read-starvation problems, was accompanied by a cover letter. I'm pasting the content of that cover letter below. The patch addresses (serious) starvation problems caused by request-tag exhaustion, as ex

[PATCH BUGFIX/IMPROVEMENT 1/2] block, bfq: limit tags for writes and async I/O

2018-01-13 Thread Paolo Valente
Asynchronous I/O can easily starve synchronous I/O (both sync reads and sync writes), by consuming all request tags. Similarly, storms of synchronous writes, such as those that sync(2) may trigger, can starve synchronous reads. In their turn, these two problems may also cause BFQ to loose control o

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-13 Thread QingFeng Hao
在 2018/1/6 9:09, Dan Williams 写道: Quoting Mark's original RFC: "Recently, Google Project Zero discovered several classes of attack against speculative execution. One of these, known as variant-1, allows explicit bounds checks to be bypassed under speculation, providing an arbitrary read gadget

[PATCH] pinctrl: sprd: Use seq_putc() in sprd_pinconf_group_dbg_show()

2018-01-13 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 13 Jan 2018 12:42:14 +0100 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/pinctrl/sprd/pinctrl-sp

Re: [PATCH] serial: 8250_dw: Avoid overflow in dw8250_set_termios

2018-01-13 Thread Nuno Gonçalves
Dear Ed, Thanks. Tested-by: Nuno Goncalves I just would like to report a aditional issue I find, which I am not sure if it is intend behaviour or not. If I set bauds 1152000, 150, 200, 250, 300, I always get a actually set baud of 150, because it appears to be the closest ba

Re: Yet another KPTI regression with 4.14.x series in a VM

2018-01-13 Thread Peter Zijlstra
On Fri, Jan 12, 2018 at 10:08:20PM -0800, Andy Lutomirski wrote: > Now this is quite a strange value to write to CR3. The 0x800 part > means that we're using the "user" variant of the address space that > would have ASID=0 and the 0x1000 bit being set corresponds to the user > pgdir, but this is n

Re: [PATCH v3] arm64: cpu_errata: Add Kryo to Falkor 1003 errata

2018-01-13 Thread Catalin Marinas
On Tue, Jan 09, 2018 at 01:22:12PM -0800, Stephen Boyd wrote: > On 12/14, Will Deacon wrote: > > On Wed, Dec 13, 2017 at 02:19:37PM -0800, Stephen Boyd wrote: > > > The Kryo CPUs are also affected by the Falkor 1003 errata, so > > > we need to do the same workaround on Kryo CPUs. The MIDR is > > >

[PATCH] usb/host/imx21: Use seq_putc() in debug_etd_show()

2018-01-13 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 13 Jan 2018 13:12:06 +0100 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/usb/host/imx21-dbg.c |

Re: Yet another KPTI regression with 4.14.x series in a VM

2018-01-13 Thread David Woodhouse
On Sat, 2018-01-13 at 13:08 +0100, Peter Zijlstra wrote: > > ALTERNATIVE "orq $(PTI_SWITCH_PGTABLE_MASK), \scratch_reg", >     "orq $(PTI_SWITCH_MASK), \scratch_reg", X86_FEATURE_PCID > > Is not wanting to compile though; probably that whole alternative vs > macro thing ag

Re: [PATCHSET v5] blk-mq: reimplement timeout handling

2018-01-13 Thread Ming Lei
On Fri, Jan 12, 2018 at 04:55:34PM -0500, Laurence Oberman wrote: > On Fri, 2018-01-12 at 20:57 +, Bart Van Assche wrote: > > On Tue, 2018-01-09 at 08:29 -0800, Tejun Heo wrote: > > > Currently, blk-mq timeout path synchronizes against the usual > > > issue/completion path using a complex schem

bpf: Change structure passing and assignment

2018-01-13 Thread Karim Eshapa
I noticed that most of functions here have structure arguements and return structure, all these structures passed and returned are delt in passing and assignment like memcpy a structure.In addition it takes size in stack while passing. so why not we use pointers to structure as argumentsor there

Re: Yet another KPTI regression with 4.14.x series in a VM

2018-01-13 Thread Thomas Gleixner
On Sat, 13 Jan 2018, Peter Zijlstra wrote: > On Fri, Jan 12, 2018 at 10:08:20PM -0800, Andy Lutomirski wrote: > > Now this is quite a strange value to write to CR3. The 0x800 part > > means that we're using the "user" variant of the address space that > > would have ASID=0 and the 0x1000 bit bein

kernel page table isolation for x86-32 was Re: Linux 4.15-rc7

2018-01-13 Thread Pavel Machek
Hi! > > I'll try to do the right thing. OTOH... I don't like the fact that > > kernel memory on my machine is currently readable, probably even from > > javascript. > > Oh, absolutely. I'm just saying that it's probably best to try to > start from the x86-64 KPTI model, and see how that works for

[PATCH] watchdog/ie6xx_wdt: Combine two seq_printf() calls into one call in ie6xx_wdt_dbg_show()

2018-01-13 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 13 Jan 2018 13:45:35 +0100 Some data were printed into a sequence by two separate function calls. Print the same data by a single function call instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/watchdog

Re: [PATCH BUGFIX/IMPROVEMENT 0/2] block, bfq: two pending patches

2018-01-13 Thread Oleksandr Natalenko
Hi. 13.01.2018 12:05, Paolo Valente wrote: Hi Jens, here are again the two pending patches you asked me to resend [1]. One of them, fixing read-starvation problems, was accompanied by a cover letter. I'm pasting the content of that cover letter below. The patch addresses (serious) starvation pr

[GIT PULL] Kbuild fixes for v4.15-rc8

2018-01-13 Thread Masahiro Yamada
Hi Linus, Here are some Kbuild fixes for v4.15. Please pull! The following changes since commit ae64f9bd1d3621b5e60d7363bc20afb46aede215: Linux 4.15-rc2 (2017-12-03 11:01:47 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild

Re: Yet another KPTI regression with 4.14.x series in a VM

2018-01-13 Thread Peter Zijlstra
On Sat, Jan 13, 2018 at 12:30:11PM +, David Woodhouse wrote: > On Sat, 2018-01-13 at 13:08 +0100, Peter Zijlstra wrote: > > > > ALTERNATIVE "orq $(PTI_SWITCH_PGTABLE_MASK), \scratch_reg", > >     "orq $(PTI_SWITCH_MASK), \scratch_reg", X86_FEATURE_PCID > > > > Is not w

Re: [PATCH 4.9] x86/pti/efi: broken conversion from efi to kernel page table

2018-01-13 Thread Greg KH
On Fri, Jan 12, 2018 at 03:27:32PM +0100, Jiri Kosina wrote: > On Thu, 11 Jan 2018, Pavel Tatashin wrote: > > > The page table order must be increased for EFI table in order to avoid a > > bug where NMI tries to change the page table to kernel page table, while > > efi page table is active. > > >

Re: [PATCH] genksyms: drop *.hash.c from .gitignore

2018-01-13 Thread Masahiro Yamada
2018-01-11 18:28 GMT+09:00 Masahiro Yamada : > This is a left-over of commit bb3290d91695 ("Remove gperf usage from > toolchain"). > > We do not generate a hash function any more. > > Signed-off-by: Masahiro Yamada > --- > Applied to linux-kbuild/fixes. -- Best Regards Masahiro Yamada

Re: [PATCH 4.9] x86/pti/efi: broken conversion from efi to kernel page table

2018-01-13 Thread Greg KH
On Thu, Jan 11, 2018 at 04:58:20PM -0500, Pavel Tatashin wrote: > The page table order must be increased for EFI table in order to avoid a > bug where NMI tries to change the page table to kernel page table, while > efi page table is active. > > For more disccussion about this bug, see this thread

Re: [4.4] broken conversion from efi to kernel page table

2018-01-13 Thread Greg KH
On Thu, Jan 11, 2018 at 02:07:45PM -0500, Pavel Tatashin wrote: > This fixes boot panics, hangs which I reported in this thread: > > http://lkml.iu.edu/hypermail/linux/kernel/1801.1/00951.html > > I have not yet verified if similar issue is applicable to newer > kernels. > > Re-sending it as a p

Re: [PATCH] kconfig: Warn if there is more than one help text

2018-01-13 Thread Masahiro Yamada
2018-01-12 15:47 GMT+09:00 Ulf Magnusson : > Avoids mistakes like in the following real-world example, where only the > final help string ("Say Y...") was used. This particular example was > fixed in commit 561b29e4ec8d ("media: fix media Kconfig help syntax > issues"). > > config DVB_NETUP_UNIDV

Re: [PATCH 1/7] staging: ccree: remove ccree from staging tree

2018-01-13 Thread Greg Kroah-Hartman
On Thu, Jan 11, 2018 at 09:17:08AM +, Gilad Ben-Yossef wrote: > Remove the ccree driver from the staging tree in preparation to > introducing it in the crypto tree. > > Signed-off-by: Gilad Ben-Yossef Heh, no, just make a patch series that adds the driver to the correct location in the crypt

Re: [PATCH bpf-next v5 5/5] error-injection: Support fault injection framework

2018-01-13 Thread Akinobu Mita
2018-01-13 2:56 GMT+09:00 Masami Hiramatsu : > Support in-kernel fault-injection framework via debugfs. > This allows you to inject a conditional error to specified > function using debugfs interfaces. > > Here is the result of test script described in > Documentation/fault-injection/fault-injectio

Re: [4.4] broken conversion from efi to kernel page table

2018-01-13 Thread Pavel Tatashin
Hi Greg, Make sure you apply: [PATCH 4.4 v2] x86/pti/efi: broken conversion from efi to kernel page table It is the same patch but fixes a compiling issue when compiled without: CONFIG_PAGE_TABLE_ISOLATION On Sat, Jan 13, 2018 at 8:18 AM, Greg KH wrote: > On Thu, Jan 11, 2018 at 02:07:45PM -05

[PATCH v7 1/4] i2c-smbus : Add client discovered ARA support

2018-01-13 Thread Marc CAPDEVILLE
This is from rfc by Alan Cox : https://patchwork.ozlabs.org/patch/381773 The idea is as follows (extract from above rfc) : - If an adapter knows about its ARA and smbus alerts then the adapter creates its own interrupt handler as before - If a client knows it needs smbus alerts it calls i2c_r

[PATCH v7 4/4] iio : cm32181 : cosmetic cleanup

2018-01-13 Thread Marc CAPDEVILLE
Somme cosmetic cleanup suggested by Peter Meerwald-Stadler. Macro name : MLUX_PER_LUX => CM32181_MLUX_PER_LUX Constante name : als_it_bits => cm32181_als_it_bits als_it_value => cm32181_als_it_value Comment : Registers Address => Register Addresses Suggested-by: Peter Meerwald-Stadl

[PATCH v7 3/4] iio : Add cm3218 smbus ARA and ACPI support

2018-01-13 Thread Marc CAPDEVILLE
On asus T100, Capella cm3218 chip is implemented as ambiant light sensor. This chip expose an smbus ARA protocol device on standard address 0x0c. The chip is not functional before all alerts are acknowledged. The driver call i2c_require_smbus_alert() to set the smbus alert protocol driver on its a

[PATCH v7 2/4] i2c-acpi : exclude ARA address for smbus device

2018-01-13 Thread Marc CAPDEVILLE
Somme ACPI enumerated devices are known to support smbus alert protocol. Theses devices may be miss-enumerated with the reserved smbus ARA address. This is the case on Asus T100 tablet where cm3218 ambiant light sensor expose two i2c serial bus connections, with the first one being the alert respo

Re: Yet another KPTI regression with 4.14.x series in a VM

2018-01-13 Thread David Woodhouse
On Sat, 2018-01-13 at 14:10 +0100, Peter Zijlstra wrote: > On Sat, Jan 13, 2018 at 12:30:11PM +, David Woodhouse wrote: > > > > On Sat, 2018-01-13 at 13:08 +0100, Peter Zijlstra wrote: > > > > > > > > > ALTERNATIVE "orq $(PTI_SWITCH_PGTABLE_MASK), \scratch_reg", > > >    

Re: Yet another KPTI regression with 4.14.x series in a VM

2018-01-13 Thread Borislav Petkov
On Sat, Jan 13, 2018 at 01:50:55PM +0100, Thomas Gleixner wrote: > 2:0 Ignored >3 PWT >4 PCD Btw, those last two are "(implies PCD=PWT=0)" according to http://www.sandpile.org/x86/crx.htm with PCID. I was wondering recently what happens with those bits when PCID is enabled and CR3[11:0] i

RE: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl

2018-01-13 Thread Van De Ven, Arjan
> > We were also worried about the indirect calls that are part of the > > paravirt interfaces when retpolines are not in place. > > > > How could those possibly be any worse than any other indirect call in > the kernel? they're worse if they happen before you write the MSR that then protects th

Re: [4.4] broken conversion from efi to kernel page table

2018-01-13 Thread Greg KH
On Sat, Jan 13, 2018 at 08:35:05AM -0500, Pavel Tatashin wrote: > Hi Greg, > > Make sure you apply: > [PATCH 4.4 v2] x86/pti/efi: broken conversion from efi to kernel page table > > It is the same patch but fixes a compiling issue when compiled > without: CONFIG_PAGE_TABLE_ISOLATION Ah, thanks,

Re: [PATCH 4.4 v2] x86/pti/efi: broken conversion from efi to kernel page table

2018-01-13 Thread Greg KH
On Fri, Jan 12, 2018 at 03:00:02PM -0500, Pavel Tatashin wrote: > In entry_64.S we have code like this: > > /* Unconditionally use kernel CR3 for do_nmi() */ > /* %rax is saved above, so OK to clobber here */ > ALTERNATIVE "jmp 2f", "movq %cr3, %rax", X86_FEATURE_KAISER > /* If PCI

[PATCH 0/2] NFSD: Adjustments for six function implementations

2018-01-13 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 13 Jan 2018 15:00:15 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Use seq_putc() in four functions Adjust four function calls together with a variable assignment fs/nfsd/export.c| 19 +

[PATCH 1/2] nfsd: Use seq_putc() in four functions

2018-01-13 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 13 Jan 2018 14:20:27 +0100 Five single characters should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/nfsd/export.c| 6 +++--- fs/nfsd/

[PATCH 2/2] nfsd: Adjust four function calls together with a variable assignment

2018-01-13 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 13 Jan 2018 14:40:44 +0100 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code places. Signed-off-by: Markus Elfring --- fs/nfsd/export.c | 13 + 1 fi

Re: AF_ALG: skb limits

2018-01-13 Thread Stephan Müller
Am Dienstag, 12. Dezember 2017, 14:59:21 CET schrieb Jonathan Cameron: Hi Jonathan, > On Fri, 8 Dec 2017 13:43:20 +0100 > > Stephan Mueller wrote: > > Am Freitag, 8. Dezember 2017, 12:39:06 CET schrieb Jonathan Cameron: > > > > Hi Jonathan, > > > > > As a heads up, the other nasties we've fou

RE: [PATCH v1] x86/retpoline: Use lfence in the retpoline/RSB filling RSB macros

2018-01-13 Thread Van De Ven, Arjan
> > The RSB filling macro is applicable to AMD, and, if software is unable to > > verify that lfence is serializing on AMD (possible when running under a > > hypervisor), the generic retpoline support will be used and, so, is also > > applicable to AMD.  Change the use of pause to lfence. > > > > S

Re: [PATCH] retpoline/module: Taint kernel for missing retpoline in module

2018-01-13 Thread Greg KH
On Fri, Jan 12, 2018 at 09:55:07AM -0800, Andi Kleen wrote: > From: Andi Kleen > > There's a risk that a kernel that has full retpoline mitigations > becomes vulnerable when a module gets loaded that hasn't been > compiled with the right compiler or the right option. > > We cannot fix it, but sh

Re: Yet another KPTI regression with 4.14.x series in a VM

2018-01-13 Thread David Woodhouse
On Sat, 2018-01-13 at 14:10 +0100, Peter Zijlstra wrote: > On Sat, Jan 13, 2018 at 12:30:11PM +, David Woodhouse wrote: > > > > On Sat, 2018-01-13 at 13:08 +0100, Peter Zijlstra wrote: > > > > > > > > > ALTERNATIVE "orq $(PTI_SWITCH_PGTABLE_MASK), \scratch_reg", > > >    

Re: [PATCH] EDAC, mv64x60: Remove some code duplication

2018-01-13 Thread Borislav Petkov
+ Chris Packham who's been fixing some stuff in here too. On Sat, Jan 13, 2018 at 08:28:21AM +0100, Christophe JAILLET wrote: > Reorder the error handling code in order to release the resources in > reverse order than allocation. > > Introduce a new 'release_group' label in the error handling pat

RE: [PATCH] retpoline/module: Taint kernel for missing retpoline in module

2018-01-13 Thread Van De Ven, Arjan
> > When the a module hasn't been compiled with a retpoline > > aware compiler, print a warning and set a taint flag. > > Isn't that caught by the "build with a different compiler/version" check > that we have? Or used to have? If not, can't we just make it into that > type of check to catch thi

Re: [PATCHSET v5] blk-mq: reimplement timeout handling

2018-01-13 Thread Ming Lei
On Fri, Jan 12, 2018 at 04:55:34PM -0500, Laurence Oberman wrote: > On Fri, 2018-01-12 at 20:57 +, Bart Van Assche wrote: > > On Tue, 2018-01-09 at 08:29 -0800, Tejun Heo wrote: > > > Currently, blk-mq timeout path synchronizes against the usual > > > issue/completion path using a complex schem

Re: [PATCH] retpoline/module: Taint kernel for missing retpoline in module

2018-01-13 Thread Andi Kleen
> > When the a module hasn't been compiled with a retpoline > > aware compiler, print a warning and set a taint flag. > > Isn't that caught by the "build with a different compiler/version" check > that we have? Or used to have? If not, can't we just make it into that - the compiler version numb

Re: [PATCH 1/5] x86/ibrs: Introduce native_rdmsrl, and native_wrmsrl

2018-01-13 Thread Andy Lutomirski
> On Jan 13, 2018, at 5:52 AM, Van De Ven, Arjan > wrote: > > >>> We were also worried about the indirect calls that are part of the >>> paravirt interfaces when retpolines are not in place. >>> >> >> How could those possibly be any worse than any other indirect call in >> the kernel? > >

Re: [PATCH] retpoline/module: Taint kernel for missing retpoline in module

2018-01-13 Thread Greg KH
On Sat, Jan 13, 2018 at 06:53:00AM -0800, Andi Kleen wrote: > > > When the a module hasn't been compiled with a retpoline > > > aware compiler, print a warning and set a taint flag. > > > > Isn't that caught by the "build with a different compiler/version" check > > that we have? Or used to have?

Re: [PATCH] retpoline/module: Taint kernel for missing retpoline in module

2018-01-13 Thread Greg KH
On Sat, Jan 13, 2018 at 02:38:51PM +, Van De Ven, Arjan wrote: > > > When the a module hasn't been compiled with a retpoline > > > aware compiler, print a warning and set a taint flag. > > > > Isn't that caught by the "build with a different compiler/version" check > > that we have? Or used t

[PATCH] ocfs2: Combine two seq_printf() calls into one call in ocfs2_dlm_seq_show()

2018-01-13 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 13 Jan 2018 16:36:51 +0100 Some data were printed into a sequence by two separate function calls. Print almost the same data by a single function call instead. (Omit a tab character at the line end within a format string.) This issue was detected by using the Cocc

[PATCH] Coccinelle: alloc_cast: Add more memory allocating functions to the list

2018-01-13 Thread Himanshu Jha
Add more memory allocating functions that are frequently used in the kernel code to the existing list and remove the useless casts where it is unnecessary. But preserve those casts having __attribute__ such as __force, __iomem, etc which are used by Sparse in the static analysis of the code. Also

[PATCH] Coccinelle: kzalloc-simple: Rename kzalloc-simple to zalloc-simple

2018-01-13 Thread Himanshu Jha
Rename kzalloc-simple to zalloc-simple since now the rule is not specific to kzalloc function only, but also to many other zero memory allocating functions specified in the rule. Signed-off-by: Himanshu Jha --- scripts/coccinelle/api/alloc/kzalloc-simple.cocci | 448 -- scrip

[PATCH] Coccinelle: ifnullfree: Trim the warning reported in report mode

2018-01-13 Thread Himanshu Jha
Remove the unncessary part of the warning reported, in the report mode, so that a single warning produced does not exceed more than line and hence improve readability of the warnings produced in the subsequent reports to a file. Signed-off-by: Himanshu Jha --- scripts/coccinelle/free/ifnullfree.

Re: bpf: Change structure passing and assignment

2018-01-13 Thread Alexei Starovoitov
On Sat, Jan 13, 2018 at 02:42:19PM +0200, Karim Eshapa wrote: > I noticed that most of functions here have structure arguements and return > structure, all these structures passed and returned are delt in passing and > assignment like memcpy a structure.In addition it takes size in stack while >

Re: [PATCH] Coccinelle: alloc_cast: Add more memory allocating functions to the list

2018-01-13 Thread Julia Lawall
On Sat, 13 Jan 2018, Himanshu Jha wrote: > Add more memory allocating functions that are frequently used in the kernel > code to the existing list and remove the useless casts where it is > unnecessary. > > But preserve those casts having __attribute__ such as __force, __iomem, > etc which are u

[PATCH] fs/proc: Use seq_putc() in show_console_dev()

2018-01-13 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 13 Jan 2018 17:17:59 +0100 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/proc/consoles.c | 3 +-- 1 f

Re: [PATCH] Coccinelle: kzalloc-simple: Rename kzalloc-simple to zalloc-simple

2018-01-13 Thread Julia Lawall
On Sat, 13 Jan 2018, Himanshu Jha wrote: > Rename kzalloc-simple to zalloc-simple since now the rule is not > specific to kzalloc function only, but also to many other zero memory > allocating functions specified in the rule. > > Signed-off-by: Himanshu Jha Acked-by: Julia Lawall > --- > sc

Re: [PATCH] Coccinelle: ifnullfree: Trim the warning reported in report mode

2018-01-13 Thread Julia Lawall
On Sat, 13 Jan 2018, Himanshu Jha wrote: > Remove the unncessary part of the warning reported, in the report > mode, so that a single warning produced does not exceed more than line > and hence improve readability of the warnings produced in the subsequent > reports to a file. > > Signed-off-by:

Re: [PATCH v4] devres: combine function devm_ioremap*

2018-01-13 Thread christophe leroy
Hi Yisheng, Le 12/01/2018 à 12:51, Yisheng Xie a écrit : When I tried to use devm_ioremap function and review related code, I found devm_ioremap_* almost have the similar realize with each other, which can be combined. In the former versions, I have tried to kill ioremap_cache to reduce the siz

[PATCH] mtd: onenand: samsung: remove incorrect __iomem annotation

2018-01-13 Thread Christophe JAILLET
'page_buf' and 'oob_buf' are allocated with 'devm_kzalloc()' and should not have __iommem decoration. Remove these decorations and some useless casting. Signed-off-by: Christophe JAILLET --- drivers/mtd/onenand/samsung.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff -

Re: [Cocci] [PATCH] Coccinelle: kzalloc-simple: Rename kzalloc-simple to zalloc-simple

2018-01-13 Thread Fabio Estevam
On Sat, Jan 13, 2018 at 1:57 PM, Himanshu Jha wrote: > Rename kzalloc-simple to zalloc-simple since now the rule is not > specific to kzalloc function only, but also to many other zero memory > allocating functions specified in the rule. > > Signed-off-by: Himanshu Jha > --- > scripts/coccinelle

Re: [PATCH] firewire-ohci: work around oversized DMA reads on JMicron controllers

2018-01-13 Thread Stefan Richter
On Jan 11 Hector Martin 'marcan' wrote: > On 2017-11-13 06:05, Stefan Richter wrote: > > Thanks Hector for the troubleshooting and for the patch. > > Thanks Clemens for the review. > > > > It's been a while since I last reviewed and tested kernel patches, and > > also my main FireWire equipped PC

Re: [PATCH] EDAC, mv64x60: Remove some code duplication

2018-01-13 Thread Christophe JAILLET
Le 13/01/2018 à 15:22, Borislav Petkov a écrit : + Chris Packham who's been fixing some stuff in here too. On Sat, Jan 13, 2018 at 08:28:21AM +0100, Christophe JAILLET wrote: Reorder the error handling code in order to release the resources in reverse order than allocation. Introduce a new 're

Re: [PATCH 4.9] x86/pti/efi: broken conversion from efi to kernel page table

2018-01-13 Thread Greg KH
On Thu, Jan 11, 2018 at 04:58:20PM -0500, Pavel Tatashin wrote: > The page table order must be increased for EFI table in order to avoid a > bug where NMI tries to change the page table to kernel page table, while > efi page table is active. > > For more disccussion about this bug, see this thread

Re: [PATCH v13 0/7] cgroup-aware OOM killer

2018-01-13 Thread Johannes Weiner
On Wed, Jan 10, 2018 at 11:33:45AM -0800, Andrew Morton wrote: > On Wed, 10 Jan 2018 05:11:44 -0800 Roman Gushchin wrote: > > On Tue, Jan 09, 2018 at 04:57:53PM -0800, David Rientjes wrote: > > > On Thu, 30 Nov 2017, Andrew Morton wrote: > > > > > This patchset makes the OOM killer cgroup-aware. >

Re

2018-01-13 Thread Alex
-- Hello, I have a project i want to bring to you.. please respond for details Alex

Re: [PATCH 4.9] x86/pti/efi: broken conversion from efi to kernel page table

2018-01-13 Thread Pavel Tatashin
Hi Greg, Yeah, the one in pgtable.c needs to be removed, I wonder how it compiled... I will submit a new patch for 4.9 sometime later. Thank you, Pavel On Sat, Jan 13, 2018 at 12:12 PM, Greg KH wrote: > On Thu, Jan 11, 2018 at 04:58:20PM -0500, Pavel Tatashin wrote: >> The page table order must

Re: [Cocci] [PATCH] Coccinelle: kzalloc-simple: Rename kzalloc-simple to zalloc-simple

2018-01-13 Thread Himanshu Jha
On Sat, Jan 13, 2018 at 03:02:10PM -0200, Fabio Estevam wrote: > On Sat, Jan 13, 2018 at 1:57 PM, Himanshu Jha > wrote: > > Rename kzalloc-simple to zalloc-simple since now the rule is not > > specific to kzalloc function only, but also to many other zero memory > > allocating functions specified

Re: [PATCHSET v5] blk-mq: reimplement timeout handling

2018-01-13 Thread Ming Lei
On Sat, Jan 13, 2018 at 10:45:14PM +0800, Ming Lei wrote: > On Fri, Jan 12, 2018 at 04:55:34PM -0500, Laurence Oberman wrote: > > On Fri, 2018-01-12 at 20:57 +, Bart Van Assche wrote: > > > On Tue, 2018-01-09 at 08:29 -0800, Tejun Heo wrote: > > > > Currently, blk-mq timeout path synchronizes a

Re: [PATCH 4/8] irqchip/gic-v3: add ability to save/restore GIC/ITS state

2018-01-13 Thread Marc Zyngier
[I remember asking you to copy Sudeep Hola on this. Please do so the next time around] On Fri, 12 Jan 2018 21:24:18 +, Derek Basehore wrote: > > Some platforms power off GIC logic in S3, so we need to save/restore S3 is a not a GIC concept, and is only vaguely mentioned in terms of the rk339

Re: [PATCH 4.9] x86/pti/efi: broken conversion from efi to kernel page table

2018-01-13 Thread Greg KH
On Sat, Jan 13, 2018 at 12:40:10PM -0500, Pavel Tatashin wrote: > Hi Greg, > > Yeah, the one in pgtable.c needs to be removed, I wonder how it > compiled... I will submit a new patch for 4.9 sometime later. It builds, just gives a warning, easy to miss if you aren't looking for it :)

Re: [PATCH] retpoline/module: Taint kernel for missing retpoline in module

2018-01-13 Thread Andi Kleen
> > Also what's the point of putting this information into every symbol? > > It makes it easy to check :) Easier than nm? Per symbol still doesn't make any sense to me. > > > Once per module is good enough. > > > > We already have similar checks for staging etc. > > Sure, but this is more of

  1   2   >