Re: [PATCH v3] KVM: VMX: Don't halt vcpu when L1 is injecting events to L2

2018-02-11 Thread Liran Alon
- chao@intel.com wrote: > Although L2 is in halt state, it will be in the active state after > VM entry if the VM entry is vectoring according to SDM 26.6.2 > Activity > State. Halting the vcpu here means the event won't be injected to L2 > and this decision isn't reported to L1. Thus L0

Re: [PATCH] PCI/portdrv: Remove "pcie_hp=nomsi" kernel parameter

2018-02-11 Thread Lukas Wunner
On Sat, Feb 10, 2018 at 08:48:15PM -0600, Bjorn Helgaas wrote: > 7570a333d8b0 ("PCI: Add pcie_hp=nomsi to disable MSI/MSI-X for pciehp > driver") added the "pcie_hp=nomsi" kernel parameter to work around this > error on shutdown: > > irq 16: nobody cared (try booting with the "irqpoll" option)

Re: Regression after commit 19809c2da28a ("mm, vmalloc: use __GFP_HIGHMEM implicitly")

2018-02-11 Thread Michal Hocko
On Thu 08-02-18 15:20:04, Matthew Wilcox wrote: > On Thu, Feb 08, 2018 at 05:06:49AM -0800, Matthew Wilcox wrote: > > On Thu, Feb 08, 2018 at 02:29:57PM +0800, Kai Heng Feng wrote: > > > A user with i386 instead of AMD64 machine reports [1] that commit > > > 19809c2da28a ("mm, vmalloc: use

[PATCH 8/9] nvme-pci: break up nvme_timeout and nvme_dev_disable

2018-02-11 Thread Jianchao Wang
Currently, the complicated relationship between nvme_dev_disable and nvme_timeout has become a devil that will introduce many circular pattern which may trigger deadlock or IO hang. Let's enumerate the tangles between them: - nvme_timeout has to invoke nvme_dev_disable to stop the controller

[PATCH 4/5] drm/radeon: Fix deadlock on runtime suspend

2018-02-11 Thread Lukas Wunner
radeon's ->runtime_suspend hook calls drm_kms_helper_poll_disable(), which waits for the output poll worker to finish if it's running. The output poll worker meanwhile calls pm_runtime_get_sync() in radeon's ->detect hooks, which waits for the ongoing suspend to finish, causing a deadlock. Fix

[PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

2018-02-11 Thread Lukas Wunner
Fix a deadlock on hybrid graphics laptops that's been present since 2013: DRM drivers poll connectors in 10 sec intervals. The poll worker is stopped on ->runtime_suspend with cancel_delayed_work_sync(). However the poll worker invokes the DRM drivers' ->detect callbacks, which call

[PATCH 1/5] workqueue: Allow retrieval of current task's work struct

2018-02-11 Thread Lukas Wunner
Introduce a helper to retrieve the current task's work struct if it is a workqueue worker. This allows us to fix a long-standing deadlock in several DRM drivers wherein the ->runtime_suspend callback waits for a specific worker to finish and that worker in turn calls a function which waits for

[PATCH 6/9] nvme-pci: drain the entered requests after ctrl is shutdown

2018-02-11 Thread Jianchao Wang
Currently, we will unquiesce the queues after the controller is shutdown to avoid residual requests to be stuck. In fact, we can do it more cleanly, just wait freeze and drain them before nvme_dev_disable return. Signed-off-by: Jianchao Wang ---

[PATCH] proc/kpageflags: add KPF_WAITERS

2018-02-11 Thread Konstantin Khlebnikov
KPF_WAITERS indicates tasks are waiting for a page lock or writeback. This might be false-positive, in this case next unlock will clear it. This looks like worth information not only for kernel hacking. In tool page-types in non-raw mode treat KPF_WAITERS without KPF_LOCKED and KPF_WRITEBACK as

[PATCH v3 8/7] TESTING_ONLY x86/entry: reduce static footprint of idtentry

2018-02-11 Thread Dominik Brodowski
Play a little trick in the generic PUSH_AND_CLEAR_REGS macro to insert the GP registers "above" the original return address. This allows us to (re-)insert the macro in error_entry() and paranoid_entry() and to remove it from the idtentry macro. This reduces the static footprint significantly.

[PATCH v3 3/7] x86/entry: interleave XOR register clearing with PUSH instructions

2018-02-11 Thread Dominik Brodowski
Same as is done for syscalls, interleave XOR with PUSH instructions for exceptions/interrupts, in order to minimize the cost of the additional instructions required for register clearing. Signed-off-by: Dominik Brodowski --- arch/x86/entry/calling.h | 40

[PATCH v3 6/7] x86/entry: get rid of ALLOC_PT_GPREGS_ON_STACK and SAVE_AND_CLEAR_REGS

2018-02-11 Thread Dominik Brodowski
Previously, error_entry() and paranoid_entry() saved the GP registers onto stack space previously allocated by its callers. Combine these two steps in the callers, and use the generic PUSH_AND_CLEAR_REGS macro for that. This adds a significant amount ot text size. However, Ingo Molnar points out

[PATCH v3 5/7] x86/entry: use PUSH_AND_CLEAN_REGS in more cases

2018-02-11 Thread Dominik Brodowski
entry_SYSCALL_64_after_hwframe and nmi can be converted to use PUSH_AND_CLEAN_REGS instead of opencoded variants thereof. Due to the interleaving, the additional XOR-based clearing of r8 and r9 in entry_SYSCALL_64_after_hwframe should not have any noticeable negative implications. Suggested-by:

[PATCH 5/5] selftests/x86: disable tests requiring 32bit support on pure 64bit systems

2018-02-11 Thread Dominik Brodowski
The ldt_gdt and ptrace_syscall selftests, even in their 64bit variant, use hard-coded 32bit syscall numbers and call int $0x80. This will fail on 64bit systems with CONFIG_IA32_EMULATION disabled. Therefore, do not build these tests if we cannot build 32bit binaries (which should be a good

[PATCH 0/5] selftests/x86: fixes for !CONFIG_IA32_EMULATION and vsyscall=none

2018-02-11 Thread Dominik Brodowski
On systems with CONFIG_IA32_EMULATION disabled and vsyscall disabled, a couple of selftests fail spectacularly. Also throw in a fix for the Makefile, which still wants to build the moved 5lvl test. Dominik Brodowski (5): selftests/x86: 5lvl test has been moved selftests/x86: fix vDSO

[PATCH] selftest/vDSO: fix O=

2018-02-11 Thread Dominik Brodowski
The vDSO selftests ignored the O= or KBUILD_OUTPUT= parameters. Fix it. Signed-off-by: Dominik Brodowski --- tools/testing/selftests/vDSO/Makefile | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/testing/selftests/vDSO/Makefile

[PATCH 4/5] selftests/x86: do not rely on int $0x80 in single_step_syscall.c

2018-02-11 Thread Dominik Brodowski
On 64bit builds, we should not rely on int $0x80 working (it only does if CONFIG_IA32_EMULATION is enabled). To keep the "Set TF and check int80" test running on 64bit installs with CONFIG_IA32_EMULATION enabled, build this test only if we can also build 32bit binaries (which should be a good

[PATCH 2/5] selftests/x86: fix vDSO selftest segfault for vsyscall=none

2018-02-11 Thread Dominik Brodowski
The vDSO selftest tries to execute a vsyscall unconditionally, even if it is not present on the test system (e.g. if booted with vsyscall=none or with CONFIG_LEGACY_VSYSCALL_NONE=y set. Fix this by copying (and tweaking) the vsyscall check from test_vsyscall.c CC: Andrew Lutomirski

[PATCH 1/5] selftests/x86: 5lvl test has been moved

2018-02-11 Thread Dominik Brodowski
Fixes: 235266b8e11c "selftests/vm: move 128TB mmap boundary test to generic directory" Signed-off-by: Dominik Brodowski --- tools/testing/selftests/x86/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/x86/Makefile

Re: [PATCH 9/9] nvme-pci: discard wait timeout when delete cq/sq

2018-02-11 Thread Sagi Grimberg
This looks ok to me, unless we have some quirks that need it? Reviewed-by: Sagi Grimberg

Re: Regression after commit 19809c2da28a ("mm, vmalloc: use __GFP_HIGHMEM implicitly")

2018-02-11 Thread Matthew Wilcox
On Sun, Feb 11, 2018 at 03:28:08AM -0800, Matthew Wilcox wrote: > Now, longer-term, perhaps we should do the following: > > #ifdef CONFIG_ZONE_DMA32 > #define OPT_ZONE_DMA32ZONE_DMA32 > #elif defined(CONFIG_64BIT) > #define OPT_ZONE_DMA OPT_ZONE_DMA > #else > #define OPT_ZONE_DMA32

[no subject]

2018-02-11 Thread Alfred Cheuk Chow
Good Day, I am Mr. Alfred Cheuk Yu Chow, the Director for Credit & Marketing Chong Hing Bank, Hong Kong, Chong Hing Bank Center, 24 Des Voeux Road Central, Hong Kong. I have a business proposal of $ 38,980,369.00. All confirmable documents to back up the claims will be made available to you

Re: [PATCH 2/5] selftests/x86: fix vDSO selftest segfault for vsyscall=none

2018-02-11 Thread Dominik Brodowski
On Sun, Feb 11, 2018 at 12:21:53PM +0100, Ingo Molnar wrote: > > * Dominik Brodowski wrote: > > > + char name[128]; > > + if (sscanf(line, "%p-%p %c-%cp %*x %*x:%*x %*u %s", > > + , , , , name) != 5) > > So that's a buffer

[PATCH 3/5] drm/nouveau: Fix deadlock on runtime suspend

2018-02-11 Thread Lukas Wunner
nouveau's ->runtime_suspend hook calls drm_kms_helper_poll_disable(), which waits for the output poll worker to finish if it's running. The output poll worker meanwhile calls pm_runtime_get_sync() in nouveau_connector_detect() which waits for the ongoing suspend to finish, causing a deadlock.

[PATCH 2/5] drm: Allow determining if current task is output poll worker

2018-02-11 Thread Lukas Wunner
Introduce a helper to determine if the current task is an output poll worker. This allows us to fix a long-standing deadlock in several DRM drivers wherein the ->runtime_suspend callback waits for the output poll worker to finish and the worker in turn calls a ->detect callback which waits for

[PATCH 4/9] nvme-pci: quiesce IO queues prior to disabling device HMB accesses

2018-02-11 Thread Jianchao Wang
Quiesce IO queues prior to disabling device HMB accesses. A controller using HMB may relay on it to efficiently complete IO commands. Reviewed-by: Keith Busch Signed-off-by: Jianchao Wang --- drivers/nvme/host/pci.c | 8 +++- 1 file

[PATCH 1/9] nvme: fix the dangerous reference of namespaces list

2018-02-11 Thread Jianchao Wang
nvme_remove_namespaces and nvme_remove_invalid_namespaces reference the ctrl->namespaces list w/o holding namespaces_mutext. It is ok to invoke nvme_ns_remove there, but what if there is others. To be safer, reference the ctrl->namespaces list under namespaces_mutext. Signed-off-by: Jianchao

[PATCH 7/9] blk-mq: make blk_mq_rq_update_aborted_gstate a external interface

2018-02-11 Thread Jianchao Wang
No functional change, just make blk_mq_rq_update_aborted_gstate a external interface. Signed-off-by: Jianchao Wang --- block/blk-mq.c | 3 ++- include/linux/blk-mq.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/block/blk-mq.c

[PATCH 5/5] drm/amdgpu: Fix deadlock on runtime suspend

2018-02-11 Thread Lukas Wunner
amdgpu's ->runtime_suspend hook calls drm_kms_helper_poll_disable(), which waits for the output poll worker to finish if it's running. The output poll worker meanwhile calls pm_runtime_get_sync() in amdgpu's ->detect hooks, which waits for the ongoing suspend to finish, causing a deadlock. Fix

[PATCH 9/9] nvme-pci: discard wait timeout when delete cq/sq

2018-02-11 Thread Jianchao Wang
Currently, nvme_disable_io_queues could be wakeup by both request completion and wait timeout path. This is unnecessary and could introduce race between nvme_dev_disable and request timeout path. When delete cq/sq command expires, the nvme_disable_io_queues will also be wakeup and return to

[PATCH 2/9] nvme: fix the deadlock in nvme_update_formats

2018-02-11 Thread Jianchao Wang
nvme_update_formats will invoke nvme_ns_remove under namespaces_mutext. The will cause deadlock because nvme_ns_remove will also require the namespaces_mutext. Fix it by getting the ns entries which should be removed under namespaces_mutext and invoke nvme_ns_remove out of namespaces_mutext.

Re: [PATCH v2 5/6] KVM/nVMX: Set the CPU_BASED_USE_MSR_BITMAPS if we have a valid L02 MSR bitmap

2018-02-11 Thread Ingo Molnar
* David Woodhouse wrote: > From: KarimAllah Ahmed > > We either clear the CPU_BASED_USE_MSR_BITMAPS and end up intercepting all > MSR accesses or create a valid L02 MSR bitmap and use that. This decision > has to be made every time we evaluate whether we

Re: [PATCH 00/31 v2] PTI support for x86_32

2018-02-11 Thread Adam Borowski
On Sat, Feb 10, 2018 at 12:22:59PM -0800, Linus Torvalds wrote: > On Sat, Feb 10, 2018 at 1:15 AM, Adam Borowski wrote: > > > > Alas, we got some data: > > https://popcon.debian.org/ says 20% of x86 users have i386 as their main ABI > > (current; people with popcon

[PATCH 3/5] selftests/x86: do not rely on int $0x80 in test_mremap_vdso.c

2018-02-11 Thread Dominik Brodowski
On 64bit builds, we should not rely on int $0x80 working (it only does if CONFIG_IA32_EMULATION is enabled). Without this patch, the move test may succeed, but the int $0x80 cause a segfault, resulting in a false negative output of this selftest. CC: Dmitry Safonov CC:

Re: [PATCH v2 6/6] x86/speculation: Use IBRS if available before calling into firmware

2018-02-11 Thread Ingo Molnar
* David Woodhouse wrote: > Retpoline means the kernel is safe because it has no indirect branches. > But firmware isn't, so use IBRS for firmware calls if it's available. Ok, this approach looks good to me in principle, but: > --- a/arch/x86/include/asm/apm.h > +++

Re: [PATCH 1/6] genalloc: track beginning of allocations

2018-02-11 Thread Mike Rapoport
On Sun, Feb 11, 2018 at 05:19:15AM +0200, Igor Stoppa wrote: > The genalloc library is only capable of tracking if a certain unit of > allocation is in use or not. > > It is not capable of discerning where the memory associated to an > allocation request begins and where it ends. > > The reason

Re: [GIT PULL] Integrity: IMA FUSE fixes

2018-02-11 Thread Mimi Zohar
On Mon, 2018-02-12 at 00:19 +1100, James Morris wrote: > On Sat, 10 Feb 2018, Mimi Zohar wrote: > > Custom policy rules could be defined to disable measurement, > > appraisal, and audit for files on fuse.  However, I don't think we > > want to automatically disable measurement, even meaningless >

[PATCH 5/9] nvme-pci: suspend queues based on online_queues

2018-02-11 Thread Jianchao Wang
nvme cq irq is freed based on queue_count. When the sq/cq creation fails, irq will not be setup. free_irq will warn 'Try to free already-free irq'. To fix it, we only increase online_queues when adminq/sq/cq are created and associated irq is setup. Then suspend queues based on online_queues.

Re: [PATCH] drm: Print the pid when debug logging an ioctl error.

2018-02-11 Thread Eric Anholt
Daniel Vetter writes: > On Tue, Jan 30, 2018 at 01:56:43PM -0800, Eric Anholt wrote: >> When we debug print what ioctl we're calling into, we include the pid. >> If you have multiple processes rendering simulataneously, the error >> return also needs the pid so you can see which

Re: [PATCH] xtensa: fix build with KASAN

2018-02-11 Thread Andrey Konovalov
On Sun, Feb 11, 2018 at 10:15 AM, Max Filippov wrote: > The commit 917538e212a2 ("kasan: clean up KASAN_SHADOW_SCALE_SHIFT > usage") removed KASAN_SHADOW_SCALE_SHIFT definition from > include/linux/kasan.h and added it to architecture-specific headers, > except for xtensa.

Re: [PATCH] x86/Kconfig: Further simplify the NR_CPUS config

2018-02-11 Thread Ingo Molnar
* Randy Dunlap wrote: > On 02/10/2018 02:19 PM, Linus Torvalds wrote: > > Looks good to me. > > > > At the risk of bike-shedding, we could remove all the > > > > default1 if !SMP > > > > from the BEGIN/END/DEFAULT things, and perhaps just keep that part in

Re: [PATCH] KVM: X86: Fix SMRAM accessing even if VM is shutdown

2018-02-11 Thread Wanpeng Li
2018-02-09 20:42 GMT+08:00 Paolo Bonzini : > On 09/02/2018 04:22, Xiao Guangrong wrote: >>> >> >> That is a good question... :) >> >> This case (with KVM_MEMSLOT_INVALID is set) can be easily constructed, >> userspace should avoid this case by itself (avoiding vCPU accessing

Re: [PATCH] drm/edid: drop the dcc probe before drm_do_get_edid

2018-02-11 Thread Lubomir Rintel
On Sat, 2018-02-10 at 19:03 +0100, Lubomir Rintel wrote: > Now that drm_do_get_edid() handles override and firmware EDIDs it makes > no sense to conditionalize it with a DCC probe. On the contrary -- the > overrides are useful specifically when DCC is not functioning. > > drm_do_get_edid()

Re: [PATCH 4/9] nvme-pci: quiesce IO queues prior to disabling device HMB accesses

2018-02-11 Thread Sagi Grimberg
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 6fe7af0..00cffed 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -2186,7 +2186,10 @@ static void nvme_dev_disable(struct nvme_dev *dev, bool shutdown) if (!dead) { if (shutdown)

Re: [PATCH 3.16 000/136] 3.16.54-rc1 review

2018-02-11 Thread Guenter Roeck
On 02/10/2018 08:31 PM, Ben Hutchings wrote: This is the start of the stable review cycle for the 3.16.54 release. There are 136 patches in this series, which will be posted as responses to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH 3/9] nvme: change namespaces_mutext to namespaces_rwsem

2018-02-11 Thread Sagi Grimberg
namespaces_mutext is used to synchronize the operations on ctrl namespaces list. Most of the time, it is a read operation. It is better to change it from mutex to rwsem. On the other hand, the namespaces mutex could introduce circular dependency easily. On the other hand of what? Also, can

Re: [PATCH 3.2 00/79] 3.2.99-rc1 review

2018-02-11 Thread Guenter Roeck
On 02/10/2018 08:20 PM, Ben Hutchings wrote: This is the start of the stable review cycle for the 3.2.99 release. There are 79 patches in this series, which will be posted as responses to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: [PATCH 0/3] Fix broken bananapi m2 devicetree/regulators

2018-02-11 Thread Philipp Rossak
Am Sonntag, den 11.02.2018, 10:55 +0300 schrieb Sergey Suloev: > On 02/11/2018 01:07 AM, Philipp Rossak wrote: > > > > > > On 10.02.2018 22:08, Sergey Suloev wrote: > > > On 02/11/2018 12:01 AM, Philipp Rossak wrote: > > > > Hey Sergey, > > > > > > > > Thanks for mentioning, but I think the

Re: Regression after commit 19809c2da28a ("mm, vmalloc: use __GFP_HIGHMEM implicitly")

2018-02-11 Thread Matthew Wilcox
On Sun, Feb 11, 2018 at 10:26:52AM +0100, Michal Hocko wrote: > On Thu 08-02-18 15:20:04, Matthew Wilcox wrote: > > ... nevertheless, 19809c2da28a does in fact break vmalloc_32 on 32-bit. > > Look: > > > > #if defined(CONFIG_64BIT) && defined(CONFIG_ZONE_DMA32) > > #define GFP_VMALLOC32

Re: [PATCH 8/9] nvme-pci: break up nvme_timeout and nvme_dev_disable

2018-02-11 Thread Sagi Grimberg
Jianchao, Currently, the complicated relationship between nvme_dev_disable and nvme_timeout has become a devil that will introduce many circular pattern which may trigger deadlock or IO hang. Let's enumerate the tangles between them: - nvme_timeout has to invoke nvme_dev_disable to stop the

Re: [PATCH 0/3] Fix broken bananapi m2 devicetree/regulators

2018-02-11 Thread Sergey Suloev
On 02/11/2018 02:30 PM, Philipp Rossak wrote: Am Sonntag, den 11.02.2018, 10:55 +0300 schrieb Sergey Suloev: On 02/11/2018 01:07 AM, Philipp Rossak wrote: On 10.02.2018 22:08, Sergey Suloev wrote: On 02/11/2018 12:01 AM, Philipp Rossak wrote: Hey Sergey, Thanks for mentioning, but I think

Re: [PATCH v2] tools/memory-model: Make compat with herd7 7.47 ("-" -> "_")

2018-02-11 Thread Ingo Molnar
* Paul E. McKenney wrote: > On Sat, Feb 10, 2018 at 08:46:25AM +0900, Akira Yokosawa wrote: > > >From 7c1f497a9a51e8db1a94c8a7ef0b74b235aaab88 Mon Sep 17 00:00:00 2001 > > From: Akira Yokosawa > > Date: Fri, 9 Feb 2018 04:51:05 -0800 > > Subject:

[PATCH] gpio: merrifield: Delete an error message for a failed memory allocation in mrfld_gpio_probe()

2018-02-11 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 11 Feb 2018 13:30:14 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[tip:x86/pti 8/11] Warning: ffffffff812c4dd8: f7 0f 1f 80 00 00 testl $0x801f,(%rdi)

2018-02-11 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/pti head: ff37dc0cd96c266c7700386b7ba48abc32a91b1f commit: 930ce1a7a55bc0eb8917f453ee22f1b6d67df5cd [8/11] Revert "x86/speculation: Simplify indirect_branch_prediction_barrier()" config: x86_64-rhel (attached as .config)

Re: [PATCH] KVM: X86: Fix SMRAM accessing even if VM is shutdown

2018-02-11 Thread Wanpeng Li
2018-02-11 11:20 GMT+08:00 Xiao Guangrong : > > > On 02/09/2018 08:42 PM, Paolo Bonzini wrote: >> >> On 09/02/2018 04:22, Xiao Guangrong wrote: >>> >>> That is a good question... :) >>> >>> This case (with KVM_MEMSLOT_INVALID is set) can be easily constructed,

RE: [PATCH] dmaengine: dmatest: fix container_of member in dmatest_callback

2018-02-11 Thread Wen He
Thanks for you, Shunyong. Best Regards, Wen He > -Original Message- > From: dmaengine-ow...@vger.kernel.org > [mailto:dmaengine-ow...@vger.kernel.org] On Behalf Of Adam Wallis > Sent: 2018年1月23日 22:32 > To: Yang Shunyong ; > vinod.k...@intel.com > Cc:

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

2018-02-11 Thread Ulf Magnusson
Looks to me like there's a few unrelated issues here: 1. The stack protector support test scripts Worthwhile IMO if they (*in practice*) prevent hard-to-debug build errors or a subtly broken kernel from being built. A few questions: - How do things fail with a broken stack protector

[PATCH] mm/huge_memory.c: split should clone page flags before unfreezing pageref

2018-02-11 Thread Konstantin Khlebnikov
THP split makes non-atomic change of tail page flags. This is almost ok because tail pages are locked and isolated but this breaks recent changes in page locking: non-atomic operation could clear bit PG_waiters. As a result concurrent sequence get_page_unless_zero() -> lock_page() might block

Re: [PATCH v2 0/6] Spectre v2 updates

2018-02-11 Thread Ingo Molnar
Paolo, Radim, * David Woodhouse wrote: > David Woodhouse (4): > KVM: x86: Reduce retpoline performance impact in slot_handle_level_range() > KarimAllah Ahmed (2): > X86/nVMX: Properly set spec_ctrl and pred_cmd before merging MSRs > KVM/nVMX: Set the

Re: [PATCH 1/9] nvme: fix the dangerous reference of namespaces list

2018-02-11 Thread Sagi Grimberg
Reviewed-by: Sagi Grimberg

Re: [PATCH 2/5] selftests/x86: fix vDSO selftest segfault for vsyscall=none

2018-02-11 Thread Ingo Molnar
* Dominik Brodowski wrote: > + char name[128]; > + if (sscanf(line, "%p-%p %c-%cp %*x %*x:%*x %*u %s", > +, , , , name) != 5) So that's a buffer overflow waiting to happen, if a line in 'maps' gets too large, right?

Re: [PATCH 0/3] Fix broken bananapi m2 devicetree/regulators

2018-02-11 Thread Sergey Suloev
On 02/11/2018 02:30 PM, Philipp Rossak wrote: Am Sonntag, den 11.02.2018, 10:55 +0300 schrieb Sergey Suloev: On 02/11/2018 01:07 AM, Philipp Rossak wrote: On 10.02.2018 22:08, Sergey Suloev wrote: On 02/11/2018 12:01 AM, Philipp Rossak wrote: Hey Sergey, Thanks for mentioning, but I think

Re: [PATCH] MAINTAINERS: auxdisplay: remove obsolete webpages

2018-02-11 Thread Miguel Ojeda
On Sat, Feb 10, 2018 at 10:31 PM, Joe Perches wrote: > On Sat, 2018-02-10 at 09:32 -0800, Randy Dunlap wrote: >> On 02/10/2018 01:56 AM, Miguel Ojeda wrote: >> > Cc: Randy Dunlap >> > Signed-off-by: Miguel Ojeda >> >>

Re: [PATCH 4/6] Protectable Memory

2018-02-11 Thread Mike Rapoport
On Sun, Feb 11, 2018 at 05:19:18AM +0200, Igor Stoppa wrote: > The MMU available in many systems running Linux can often provide R/O > protection to the memory pages it handles. > > However, the MMU-based protection works efficiently only when said pages > contain exclusively data that will not

Re: [PATCH 2/5] selftests/x86: fix vDSO selftest segfault for vsyscall=none

2018-02-11 Thread Dominik Brodowski
On Sun, Feb 11, 2018 at 01:17:14PM +0100, Dominik Brodowski wrote: > On Sun, Feb 11, 2018 at 12:21:53PM +0100, Ingo Molnar wrote: > > > > * Dominik Brodowski wrote: > > > > > + char name[128]; > > > + if (sscanf(line, "%p-%p %c-%cp %*x %*x:%*x %*u

Re: [PATCH] mm/huge_memory.c: split should clone page flags before unfreezing pageref

2018-02-11 Thread Konstantin Khlebnikov
On 11.02.2018 14:07, Kirill A. Shutemov wrote: On Sun, Feb 11, 2018 at 01:35:17PM +0300, Konstantin Khlebnikov wrote: THP split makes non-atomic change of tail page flags. This is almost ok because tail pages are locked and isolated but this breaks recent changes in page locking: non-atomic

Re: [GIT PULL] Integrity: IMA FUSE fixes

2018-02-11 Thread James Morris
On Sat, 10 Feb 2018, Mimi Zohar wrote: > > Which seems *worse* than what we do now, in that it wastes time and > > effort on re-creating those pointless measurements because it disables > > the caching of them. > > > > So honestly, the only sane thing seems to be to disable IMA on fuse, > > not

[PATCH] kbuild: process mixture of clean/build targets one by one

2018-02-11 Thread Masahiro Yamada
I sometimes receive a question why "make -j clean all" does not work. It is actually possible to make it work by handling targets one by one. Signed-off-by: Masahiro Yamada --- Makefile | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff

[PATCH] xtensa: fix build with KASAN

2018-02-11 Thread Max Filippov
The commit 917538e212a2 ("kasan: clean up KASAN_SHADOW_SCALE_SHIFT usage") removed KASAN_SHADOW_SCALE_SHIFT definition from include/linux/kasan.h and added it to architecture-specific headers, except for xtensa. This broke the xtensa build with KASAN enabled. Define KASAN_SHADOW_SCALE_SHIFT in

Re: Kconfig:12: can't open file "arch/powerpc64/Kconfig"

2018-02-11 Thread Fengguang Wu
Hi Masahiro, Sorry it looks like a regression in the robot. CC Shun for looking into this. Thanks, Fengguang On Sun, Feb 11, 2018 at 01:07:32PM +0900, Masahiro Yamada wrote: Hi test robot, 2018-02-11 12:41 GMT+09:00 kbuild test robot : tree:

[PATCH 3/9] nvme: change namespaces_mutext to namespaces_rwsem

2018-02-11 Thread Jianchao Wang
namespaces_mutext is used to synchronize the operations on ctrl namespaces list. Most of the time, it is a read operation. It is better to change it from mutex to rwsem. On the other hand, the namespaces mutex could introduce circular dependency easily. Signed-off-by: Jianchao Wang

[PATCH V3 0/6]nvme-pci: fixes on nvme_timeout and nvme_dev_disable

2018-02-11 Thread Jianchao Wang
Hi Christoph, Keith and Sagi Please consider and comment on the following patchset. That's really appreciated. There is a complicated relationship between nvme_timeout and nvme_dev_disable. - nvme_timeout has to invoke nvme_dev_disable to stop the controller doing DMA access before free the

[PATCH] .gitignore: ignore ANS.1 auto generated files

2018-02-11 Thread Zhu Lingshan
when build kernel with default configure, files: generatenet/ipv4/netfilter/nf_nat_snmp_basic-asn1.c net/ipv4/netfilter/nf_nat_snmp_basic-asn1.h will be automatically generated by ASN.1 compiler, so No need to track them in git, it's better to ignore them. Signed-off-by: Zhu Lingshan

[PATCH v3 7/7] x86/entry: indent PUSH_AND_CLEAR_REGS and POP_REGS properly

2018-02-11 Thread Dominik Brodowski
... same as the other macros in arch/x86/entry/calling.h Signed-off-by: Dominik Brodowski --- arch/x86/entry/calling.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h index

[PATCH v3 2/7] x86/entry: merge POP_C_REGS and POP_EXTRA_REGS

2018-02-11 Thread Dominik Brodowski
The two special, opencoded cases for POP_C_REGS can be handled by ASM macros. Signed-off-by: Dominik Brodowski --- arch/x86/entry/calling.h | 15 +++ arch/x86/entry/entry_64.S | 26 -- 2 files changed, 15 insertions(+), 26

[PATCH v3 0/7] x86/entry: simplify and unify SAVE/POP_REGS

2018-02-11 Thread Dominik Brodowski
The starting point for this series was the intention to interleave the register clearing with register PUSH or MOV instructions, in order to minimize the cost of the additional instructions required for the register clearing. While at it, I noticed that a couple of macros in

[PATCH v3 1/7] x86/entry: merge SAVE_C_REGS and SAVE_EXTRA_REGS, remove unused extensions

2018-02-11 Thread Dominik Brodowski
All current code paths call SAVE_C_REGS and then immediately SAVE_EXTRA_REGS. Therefore, merge these two macros and order the MOV sequeneces properly. While at it, remove the macros to save all except specific registers, as these macros have been unused for a long time. Suggested-by: Linus

[PATCH v3 4/7] x86/entry: introduce PUSH_AND_CLEAN_REGS

2018-02-11 Thread Dominik Brodowski
Those instances where ALLOC_PT_GPREGS_ON_STACK is called just before SAVE_AND_CLEAR_REGS can trivially be replaced by PUSH_AND_CLEAN_REGS. This macro uses PUSH instead of MOV and should therefore be faster, at least on newer CPUs. Suggested-by: Linus Torvalds

Re: [PATCH] x86/Kconfig: Further simplify the NR_CPUS config

2018-02-11 Thread Ingo Molnar
* Linus Torvalds wrote: > But regardless, that least version looks perfectly fine to me even > without that random tweak. Thanks, I turned this into: Acked-by: Linus Torvalds Ingo

Re: [PATCH] tracing/power: Don't share template for cpu_idle and cpu_frequency

2018-02-11 Thread Du, Changbin
On Fri, Feb 09, 2018 at 09:44:58PM -0500, Steven Rostedt wrote: > On Sat, 10 Feb 2018 09:37:04 +0800 > changbin...@intel.com wrote: > > > From: Changbin Du > > > > The type of state is signed int, convert it to unsigned int looks weird. > > (-1 become 4294967295) > >

Re: [PATCH] tracing/fgraph: Missed irq return mark for leaf entry

2018-02-11 Thread Du, Changbin
Hi Rostedt, What abount this fix? Thanks! On Wed, Jan 31, 2018 at 11:48:49PM +0800, changbin...@intel.com wrote: > From: Changbin Du > > The fgraph forget to print irq return mark for leaf entry. Then we can see > unbalanced irq mark in the trace. This patch fix this. >

Re: [PATCH] mm/huge_memory.c: split should clone page flags before unfreezing pageref

2018-02-11 Thread Kirill A. Shutemov
On Sun, Feb 11, 2018 at 01:35:17PM +0300, Konstantin Khlebnikov wrote: > THP split makes non-atomic change of tail page flags. This is almost ok > because tail pages are locked and isolated but this breaks recent changes > in page locking: non-atomic operation could clear bit PG_waiters. > > As a

Re: [PATCH 1/9] nvme: fix the dangerous reference of namespaces list

2018-02-11 Thread Sagi Grimberg
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index e810487..bc05bc4 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -3092,11 +3092,20 @@ static void nvme_remove_invalid_namespaces(struct nvme_ctrl *ctrl, unsigned

Re: [PATCH v2 5/7] watchdog: mtk: allow setting timeout in devicetree

2018-02-11 Thread Guenter Roeck
On 02/10/2018 11:46 PM, Sean Wang wrote: On Sat, 2018-02-10 at 17:52 -0800, Guenter Roeck wrote: On 02/10/2018 12:12 PM, Marcus Folkesson wrote: Hello Sean, On Sat, Feb 10, 2018 at 01:43:28PM +0100, Marcus Folkesson wrote: Hello Sean, On Sat, Feb 10, 2018 at 07:10:02PM +0800, Sean Wang

Re: [PATCH 2/9] nvme: fix the deadlock in nvme_update_formats

2018-02-11 Thread Sagi Grimberg
mutex_lock(>namespaces_mutex); list_for_each_entry(ns, >namespaces, list) { - if (ns->disk && nvme_revalidate_disk(ns->disk)) - nvme_ns_remove(ns); + if (ns->disk && nvme_revalidate_disk(ns->disk)) { +

Re: [PATCHv9 0/4] x86: 5-level related changes into decompression code

2018-02-11 Thread Ingo Molnar
* Kirill A. Shutemov wrote: > These patcheset is a preparation for boot-time switching between paging > modes. Please apply. > > The first patch is pure cosmetic change: it gives file with KASLR helpers > a proper name. > > The last three patches bring support

Re: VMs freezing when host is running 4.14

2018-02-11 Thread Marc Haber
Hi, after in total nine weeks of bisecting, broken filesystems, service outages (thankfully on unportant systems), 4.15 seems to have fixed the issue. After going to 4.15, the crashes never happened again. They have, however, happened with each and every 4.14 release I tried, which I stopped

Re: [PATCH v4 2/5] powerpc/mm/slice: Enhance for supporting PPC32

2018-02-11 Thread Nicholas Piggin
On Sat, 10 Feb 2018 13:54:27 +0100 (CET) Christophe Leroy wrote: > In preparation for the following patch which will fix an issue on > the 8xx by re-using the 'slices', this patch enhances the > 'slices' implementation to support 32 bits CPUs. > > On PPC32, the address

[PATCH v2.1] x86/speculation: Use IBRS if available before calling into firmware

2018-02-11 Thread David Woodhouse
Retpoline means the kernel is safe because it has no indirect branches. But firmware isn't, so use IBRS for firmware calls if it's available. Signed-off-by: David Woodhouse --- Helps to include the right header file. arch/x86/include/asm/apm.h | 6 ++

Re: [PATCH 3.16 000/136] 3.16.54-rc1 review

2018-02-11 Thread Ben Hutchings
On Sun, 2018-02-11 at 03:19 -0800, Guenter Roeck wrote: > On 02/10/2018 08:31 PM, Ben Hutchings wrote: > > This is the start of the stable review cycle for the 3.16.54 release. > > There are 136 patches in this series, which will be posted as responses > > to this one. If anyone has any issues

investment

2018-02-11 Thread askaninvestm...@gmail.com
Dear Entrepreneur, Askan Investments Management Group is venture capital firm specializing in growth capital investments.It seeks to invest in public and private securities in a broad range of areas including real estate, energy, oil and gas, emerging markets, and high-technology. Within the

[PATCH 1/2] f2fs: introduce sb_lock to make encrypt pwsalt update exclusive

2018-02-11 Thread Chao Yu
From: Chao Yu f2fs_super_block.encrypt_pw_salt can be udpated and persisted concurrently, result in getting different pwsalt in separated threads, so let's introduce sb_lock to exclude concurrent accessers. Signed-off-by: Chao Yu --- fs/f2fs/f2fs.h |

[PATCH 2/2] f2fs: expose extension_list sysfs entry

2018-02-11 Thread Chao Yu
From: Chao Yu This patch adds a sysfs entry 'extension_list' to support lookup/ add/delete item in extension list. Lookup: cat /sys/fs/f2fs//extentsion_list Add: echo 'extension' > /sys/fs/f2fs//extentsion_list Delete: echo '!extension' > /sys/fs/f2fs//extentsion_list

Re: [PATCH v2] mm/huge_memory.c: reorder operations in __split_huge_page_tail()

2018-02-11 Thread Kirill A. Shutemov
On Sun, Feb 11, 2018 at 05:29:37PM +0300, Konstantin Khlebnikov wrote: > And replace page_ref_inc()/page_ref_add() with page_ref_unfreeze() which > is made especially for that and has semantic of smp_store_release(). Nak on this part. page_ref_unfreeze() uses atomic_set() which neglects the

Re: [PATCH 2/5] selftests/x86: fix vDSO selftest segfault for vsyscall=none

2018-02-11 Thread Ingo Molnar
* Dominik Brodowski wrote: > On Sun, Feb 11, 2018 at 01:17:14PM +0100, Dominik Brodowski wrote: > > On Sun, Feb 11, 2018 at 12:21:53PM +0100, Ingo Molnar wrote: > > > > > > * Dominik Brodowski wrote: > > > > > > > + char

[PATCH v3] pstore: add lz4hc and 842 compression support

2018-02-11 Thread Geliang Tang
Currently, pstore has supported three compression algorithms: zlib, lzo and lz4. This patch added two more compression algorithms: lz4hc and 842. Signed-off-by: Geliang Tang --- Changes in v3: -fix outlen in 842 Changes in v2: -fix checkpatch.pl WARNING: please write a

Re: [PATCH] pstore: add lz4hc and 842 compression support

2018-02-11 Thread Geliang Tang
On Tue, Nov 28, 2017 at 05:44:52PM -0800, Kees Cook wrote: > > + > > + ret = LZ4_compress_default(in, out, inlen, outlen, workspace); > > + if (!ret) { > > + pr_err("LZ4_compress_default error; compression failed!\n"); > > + return -EIO; > > + } > > +

Re: [RFC][PATCH] : fix end_name_hash() for 64bit long

2018-02-11 Thread Amir Goldstein
On Fri, Feb 9, 2018 at 8:33 PM, Linus Torvalds wrote: > > I *would* love to get some kind of estimate on how this changes the > hash distribution. Do you have anything like that? The way this > function is designed to be used, the upper bits should be used for the

[kmemleak] unreferenced object 0xcd9c1a80 (size 192):

2018-02-11 Thread Mathieu Malaterre
Alexei, Could you please comment on why I am seeing those memleaks being reported on my ppc32 system ? Should they be marked as false positive ? System is Mac Mini G4, git/master (4.15.0+), ppc. Thanks for your time $ dmesg ... [ 1281.504173] kmemleak: 36 new suspected memory leaks (see

Re: [PATCH v4 2/5] powerpc/mm/slice: Enhance for supporting PPC32

2018-02-11 Thread Aneesh Kumar K.V
On 02/11/2018 07:29 PM, Nicholas Piggin wrote: On Sat, 10 Feb 2018 13:54:27 +0100 (CET) Christophe Leroy wrote: In preparation for the following patch which will fix an issue on the 8xx by re-using the 'slices', this patch enhances the 'slices' implementation to

  1   2   3   4   5   6   7   8   >