RE: [PATCH V2] pwm: tegra: dynamic clk freq configuration by PWM driver

2020-05-22 Thread Sandipan Patra
Thanks Jonathan, Please help reviewing further with my replies inline. Thanks & Regards, Sandipan > -Original Message- > From: Jonathan Hunter > Sent: Friday, May 22, 2020 3:54 PM > To: Sandipan Patra ; Thierry Reding > ; robh...@kernel.org; u.kleine-koe...@pengutronix.de > Cc: Bibek

[PATCH] net: Fix return value about devm_platform_ioremap_resource()

2020-05-22 Thread Tiezhu Yang
When call function devm_platform_ioremap_resource(), we should use IS_ERR() to check the return value and return PTR_ERR() if failed. Signed-off-by: Tiezhu Yang --- drivers/net/can/ifi_canfd/ifi_canfd.c | 5 - drivers/net/can/sun4i_can.c | 2 +-

Re: [PATCH 00/13] Reconcile NUMA balancing decisions with the load balancer v6

2020-05-22 Thread Mel Gorman
On Fri, May 22, 2020 at 09:09:50AM +0800, Hillf Danton wrote: > > On Thu, 21 May 2020 17:04:08 +0100 Mel Gorman wrote: > > On Thu, May 21, 2020 at 10:09:31PM +0800, Hillf Danton wrote: > > > > I'm ignoring the coding style of c++ comments but minimally that should > > > > be fixed. More

Re: [PATCH v4 06/16] spi: dw: Parameterize the DMA Rx/Tx burst length

2020-05-22 Thread Andy Shevchenko
On Fri, May 22, 2020 at 03:07:55AM +0300, Serge Semin wrote: > It isn't good to have numeric literals in the code especially if there > are multiple of them and they are related. Let's replace the Tx and Rx > burst level literals with the corresponding constants. You missed my tag. >

Re: [PATCH 1/8] locking: Introduce local_lock()

2020-05-22 Thread Sebastian Andrzej Siewior
On 2020-05-20 14:04:50 [+0200], Peter Zijlstra wrote: > On Tue, May 19, 2020 at 10:19:05PM +0200, Sebastian Andrzej Siewior wrote: > > +/** > > + * DEFINE_LOCAL_LOCK - Define and initialize a per CPU local lock > > + * @lock: Name of the lock instance > > + */ > > +#define DEFINE_LOCAL_LOCK(lvar)

Re: [PATCH] staging: vchiq_arm: cast with __force as needed

2020-05-22 Thread Dan Carpenter
On Mon, May 18, 2020 at 08:45:31PM -0400, Mitchell Tasman wrote: > In several cases where a pointer marked as __user is > (intentionally) assigned or passed to a non-marked target, > cast to the target pointer type with a __force directive > to quiet warnings from sparse. > > Signed-off-by:

Re: [PATCH v4 12/16] spi: dw: Add DW SPI DMA/PCI/MMIO dependency on the DW SPI core

2020-05-22 Thread Andy Shevchenko
On Fri, May 22, 2020 at 02:07:38PM +0300, Andy Shevchenko wrote: > On Fri, May 22, 2020 at 03:08:01AM +0300, Serge Semin wrote: > > Seeing all of the DW SPI driver components like DW SPI DMA/PCI/MMIO > > depend on the DW SPI core code it's better to use the if-endif > > conditional kernel config

Re: [PATCH v4 12/16] spi: dw: Add DW SPI DMA/PCI/MMIO dependency on the DW SPI core

2020-05-22 Thread Andy Shevchenko
On Fri, May 22, 2020 at 03:08:01AM +0300, Serge Semin wrote: > Seeing all of the DW SPI driver components like DW SPI DMA/PCI/MMIO > depend on the DW SPI core code it's better to use the if-endif > conditional kernel config statement to signify that common dependency. > > Co-developed-by: Georgy

[PATCH] extcon: arizona: Fix runtime PM imbalance on error

2020-05-22 Thread Dinghao Liu
When arizona_request_irq() returns an error code, a pairing runtime PM usage counter decrement is needed to keep the counter balanced. For error paths after this function, things are the same. Signed-off-by: Dinghao Liu --- drivers/extcon/extcon-arizona.c | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH v3 1/3] regulator: max14577: Add proper dt-compatible strings

2020-05-22 Thread Mark Brown
On Fri, May 22, 2020 at 12:24:46PM +0200, Marek Szyprowski wrote: > Add device tree compatible strings and create proper modalias structures > to let this driver load automatically if compiled as module, because > max14577 MFD driver creates MFD cells with such compatible strings. Same issue as

[PATCH] media: venus: vdec: Fix runtime PM imbalance in vdec_open

2020-05-22 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/media/platform/qcom/venus/vdec.c | 3 +-- 1 file changed, 1

Re: [PATCH v4 01/16] spi: dw: Add Tx/Rx finish wait methods to the MID DMA

2020-05-22 Thread Andy Shevchenko
On Fri, May 22, 2020 at 03:07:50AM +0300, Serge Semin wrote: > Since DMA transfers are performed asynchronously with actual SPI > transaction, then even if DMA transfers are finished it doesn't mean > all data is actually pushed to the SPI bus. Some data might still be > in the controller FIFO.

Re: [PATCH v6 09/10] arm64: efi: Export screen_info

2020-05-22 Thread Nikhil Mahale
On 5/18/20 6:21 PM, Ard Biesheuvel wrote: > External email: Use caution opening links or attachments > > > On Mon, 18 May 2020 at 06:25, Nikhil Mahale wrote: >> >> On 5/13/20 7:56 PM, Nikhil Mahale wrote: >>> On 3/20/20 3:16 AM, Michael Kelley wrote: From: Arnd Bergmann Sent: Wednesday,

Re: [PATCH] i2c: core: fix NULL pointer dereference in suspend/resume callbacks

2020-05-22 Thread Marek Szyprowski
Hi All, On 22.05.2020 12:13, Marek Szyprowski wrote: > Commit 6fe12cdbcfe3 ("i2c: core: support bus regulator controlling in > adapter") added generic suspend and resume functions for i2c devices. > Those functions unconditionally access an i2c_client structure assigned > to the given i2c device.

Re: [PATCH v13 00/11] Convert PWM period and duty cycle to u64

2020-05-22 Thread Thierry Reding
On Thu, May 21, 2020 at 08:15:05AM +0100, Lee Jones wrote: > On Wed, 20 May 2020, Guru Das Srinagesh wrote: > > > On Mon, Apr 27, 2020 at 07:44:34AM +0100, Lee Jones wrote: > > > On Fri, 24 Apr 2020, Guru Das Srinagesh wrote: > > > > > > > On Fri, Apr 24, 2020 at 07:43:03AM +0100, Lee Jones

Re: [RFC v1 2/3] drivers: nvmem: Add driver for QTI qfprom-efuse support

2020-05-22 Thread Srinivas Kandagatla
On 21/05/2020 22:28, Doug Anderson wrote: Hi, On Thu, May 21, 2020 at 8:56 AM Srinivas Kandagatla wrote: On 21/05/2020 16:10, Doug Anderson wrote: On 20/05/2020 23:48, Doug Anderson wrote: Is this only applicable for corrected address space? I guess I was proposing a two dts-node / two

Re: [PATCH] bitops: Move test_bit() into bitops/atomic.h

2020-05-22 Thread kbuild test robot
/torvalds/linux.git b85051e755b0e9d6dd8f17ef1da083851b83287d config: arm-randconfig-r021-20200522 (attached as .config) compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 3393cc4cebf9969db94dc424b7a2b6195589c33b) reproduce: wget https://raw.githubusercontent.com/intel/lkp

Re: [PATCH v3 5/5] nand: brcmnand: support v2.1-v2.2 controllers

2020-05-22 Thread Miquel Raynal
Hi Álvaro, Álvaro Fernández Rojas wrote on Fri, 22 May 2020 09:25:25 +0200: > v2.1: tested on Netgear DGND3700v1 (BCM6368) > v2.2: tested on Netgear DGND3700v2 (BCM6362) > > Signed-off-by: Álvaro Fernández Rojas > --- > v3: fix page size shift for v2.1 controllers. You changed the subject

Re: [PATCH v2] i2c: cadence: Add an error handling for platform_get_irq()

2020-05-22 Thread Michal Simek
On 20. 05. 20 16:48, Dejin Zheng wrote: > The driver initialization should be end immediately after found > the platform_get_irq() function return an error. > > Fixes: df8eb5691c48d3b0 ("i2c: Add driver for Cadence I2C controller") I wouldn't really consider this as bug. Driver is likely not

Re: [PATCH] ceph: show max caps in debugfs caps file

2020-05-22 Thread Jeff Layton
On Fri, 2020-05-22 at 16:27 +0800, Yanhu Cao wrote: > On Thu, May 21, 2020 at 8:51 PM Jeff Layton wrote: > > On Thu, 2020-05-21 at 20:19 +0800, Yanhu Cao wrote: > > > On Thu, May 21, 2020 at 7:09 PM Jeff Layton wrote: > > > > On Thu, 2020-05-21 at 17:38 +0800, Yanhu Cao wrote: > > > > >

Re: [PATCH] dmaengine: tegra210-adma: Fix runtime PM imbalance on error

2020-05-22 Thread Jon Hunter
On 22/05/2020 11:57, dinghao@zju.edu.cn wrote: >> >> On 22/05/2020 08:58, Dinghao Liu wrote: >>> pm_runtime_get_sync() increments the runtime PM usage counter even >>> when it returns an error code. Thus a pairing decrement is needed on >>> the error handling path to keep the counter

Re: [PATCH] PCI: dwc: Use private data pointer of "struct irq_domain" to get pcie_port

2020-05-22 Thread Lorenzo Pieralisi
On Fri, Dec 20, 2019 at 03:35:50PM +0530, Kishon Vijay Abraham I wrote: > No functional change. Get "struct pcie_port *" from private data > pointer of "struct irq_domain" in dw_pcie_irq_domain_free() to make > it look similar to how "struct pcie_port *" is obtained in > dw_pcie_irq_domain_alloc()

Re: [PATCH v13 00/11] Convert PWM period and duty cycle to u64

2020-05-22 Thread Lee Jones
On Fri, 22 May 2020, Thierry Reding wrote: > On Thu, May 21, 2020 at 08:15:05AM +0100, Lee Jones wrote: > > On Wed, 20 May 2020, Guru Das Srinagesh wrote: > > > > > On Mon, Apr 27, 2020 at 07:44:34AM +0100, Lee Jones wrote: > > > > On Fri, 24 Apr 2020, Guru Das Srinagesh wrote: > > > > > > > >

Re: [PATCH v6 09/10] arm64: efi: Export screen_info

2020-05-22 Thread Ard Biesheuvel
On Fri, 22 May 2020 at 13:15, Nikhil Mahale wrote: > > On 5/18/20 6:21 PM, Ard Biesheuvel wrote: > > External email: Use caution opening links or attachments > > > > > > On Mon, 18 May 2020 at 06:25, Nikhil Mahale wrote: > >> > >> On 5/13/20 7:56 PM, Nikhil Mahale wrote: > >>> On 3/20/20 3:16

linux-next: build failure after merge of the block tree

2020-05-22 Thread Stephen Rothwell
Hi all, After merging the block tree, today's linux-next build (x86_64 allnoconfig) failed like this: fs/libfs.c: In function 'generic_file_fsync': fs/libfs.c:1116:9: error: too few arguments to function 'blkdev_issue_flush' 1116 | return blkdev_issue_flush(inode->i_sb->s_bdev, GFP_KERNEL);

Re: Re: [PATCH] dmaengine: tegra210-adma: Fix runtime PM imbalance on error

2020-05-22 Thread dinghao . liu
> > On 22/05/2020 11:57, dinghao@zju.edu.cn wrote: > >> > >> On 22/05/2020 08:58, Dinghao Liu wrote: > >>> pm_runtime_get_sync() increments the runtime PM usage counter even > >>> when it returns an error code. Thus a pairing decrement is needed on > >>> the error handling path to keep the

Re: [PATCH v3 01/16] spi: dw: Add Tx/Rx finish wait methods to the MID DMA

2020-05-22 Thread Serge Semin
On Fri, May 22, 2020 at 03:58:44PM +0800, Feng Tang wrote: > Hi Serge, > > On Thu, May 21, 2020 at 06:33:17PM +0300, Serge Semin wrote: > > > > > > + dw_spi_dma_wait_rx_done(dws); > > > > > > > > > > I can understand the problem about TX, but I don't see how RX > > > > > will get hurt, can you

[PATCH] nvmem: qfprom: remove incorrect write support

2020-05-22 Thread Srinivas Kandagatla
qfprom has different address spaces for read and write. Reads are always done from corrected address space, where as writes are done on raw address space. Writing to corrected address space is invalid and ignored, so it does not make sense to have this support in the driver which only supports

[PATCH v13 2/3] i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver

2020-05-22 Thread Tali Perry
Add Nuvoton NPCM BMC I2C controller driver. Signed-off-by: Tali Perry Reviewed-by: Andy Shevchenko --- drivers/i2c/busses/Kconfig |9 + drivers/i2c/busses/Makefile |1 + drivers/i2c/busses/i2c-npcm7xx.c | 1804 ++ 3 files changed, 1814

[PATCH v13 3/3] i2c: npcm7xx: Add support for slave mode for Nuvoton

2020-05-22 Thread Tali Perry
Add support for slave mode for Nuvoton NPCM BMC I2C controller driver. Signed-off-by: Tali Perry Reviewed-by: Andy Shevchenko --- drivers/i2c/busses/i2c-npcm7xx.c | 609 ++- 1 file changed, 608 insertions(+), 1 deletion(-) diff --git

[PATCH v13 1/3] dt-bindings: i2c: npcm7xx: add NPCM I2C controller

2020-05-22 Thread Tali Perry
Added device tree binding documentation for Nuvoton BMC NPCM I2C controller. Signed-off-by: Tali Perry --- .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 60 +++ 1 file changed, 60 insertions(+) create mode 100644 Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml

Re: [PATCH 0/2] Fix some issues about NVMEM

2020-05-22 Thread Srinivas Kandagatla
On 22/05/2020 08:50, Tiezhu Yang wrote: This patch series is based on the latest Linus' tree. Tiezhu Yang (2): nvmem: sprd: Fix return value of sprd_efuse_probe() MAINTAINERS: Add git tree for NVMEM FRAMEWORK MAINTAINERS| 1 + drivers/nvmem/sprd-efuse.c | 4 ++-- 2

Re: [PATCH v4 3/8] spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4

2020-05-22 Thread Mark Brown
On Mon, May 18, 2020 at 07:09:20PM +0800, dillon.min...@gmail.com wrote: > 2, use stm32 spi's "In full-duplex (BIDIMODE=0 and RXONLY=0)", as tx_buf is > null, we must add dummy data sent out before read data. > so, add stm32f4_spi_tx_dummy() to handle this situation. There are flags

[PATCH v13 0/3] i2c: npcm7xx: add NPCM i2c controller driver

2020-05-22 Thread Tali Perry
This patch set adds i2c controller support for the Nuvoton NPCM Baseboard Management Controller (BMC). NPCM7xx includes 16 I2C controllers. This driver operates the controller. This module also includes a slave mode. --- v13 -> v12: - Fix yaml example. Issue found by an updated

Re: [PATCH] PCI: endpoint: Fix epc windows allocation in pci_epc_multi_mem_init()

2020-05-22 Thread Lorenzo Pieralisi
On Tue, May 19, 2020 at 04:11:20PM +0100, Lad Prabhakar wrote: > Fix allocation of epc windows with the correct size, this also fix smatch > warning: > > drivers/pci/endpoint/pci-epc-mem.c:65 pci_epc_multi_mem_init() > warn: double check that we're allocating correct size: 4 vs 112 > > Fixes:

Re: [PATCH -tip v3 00/11] Fix KCSAN for new ONCE (require Clang 11)

2020-05-22 Thread Peter Zijlstra
On Thu, May 21, 2020 at 04:20:36PM +0200, Marco Elver wrote: > Arnd Bergmann (1): > ubsan, kcsan: don't combine sanitizer with kcov on clang > > Marco Elver (10): > kcsan: Avoid inserting __tsan_func_entry/exit if possible > kcsan: Support distinguishing volatile accesses > kcsan: Pass

Re: [PATCH 0/4] mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-22 Thread Souptick Joarder
Hi John, On Tue, May 19, 2020 at 5:51 AM John Hubbard wrote: > > This needs to go through Andrew's -mm tree, due to adding a new gup.c > routine. However, I would really love to have some testing from the > drm/i915 folks, because I haven't been able to run-time test that part > of it. > >

Re: [PATCHv2 1/2] optee: do drivers initialization before and after tee-supplicant run

2020-05-22 Thread Sumit Garg
Hi Maxim, On Thu, 21 May 2020 at 12:17, Maxim Uvarov wrote: > > Some drivers (like ftpm) can operate only after tee-supplicant > runs becase of tee-supplicant provides things like storage > services. This patch splits probe of non tee-supplicant dependable > drivers to early stage, and after

Re: [External] Re: [PATCH] files: Use rcu lock to get the file structures for better performance

2020-05-22 Thread Matthew Wilcox
On Fri, May 22, 2020 at 03:52:39PM +0800, Muchun Song wrote: > On Fri, May 22, 2020 at 12:47 AM Matthew Wilcox wrote: > > > @@ -160,14 +168,23 @@ static int proc_fd_link(struct dentry *dentry, > > > struct path *path) > > > unsigned int fd = proc_fd(d_inode(dentry)); > > >

[PATCH v3 0/2] Add cold interrupt support to tsens driver

2020-05-22 Thread Manaf Meethalavalappu Pallikunhi
The changes have dependency on merging tsens-common.c into tsens.c [1] to merge first. Dependencies: [1] https://lkml.org/lkml/2020/4/29/1028 Changes in v3: * Add cold interrupt support to tsens driver * Update cold interrupt support in yaml *** BLURB HERE *** Manaf Meethalavalappu Pallikunhi

[PATCH v3 2/2] dt-bindings: thermal: tsens: Add cold interrupt support in yaml

2020-05-22 Thread Manaf Meethalavalappu Pallikunhi
Add cold interrupt support for tsens in yaml. Signed-off-by: Manaf Meethalavalappu Pallikunhi --- .../bindings/thermal/qcom-tsens.yaml | 42 +++ 1 file changed, 42 insertions(+) diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml

Re: [PATCH v3 2/2] mm, memcg: Decouple e{low,min} state mutations from protection checks

2020-05-22 Thread Chris Down
Naresh Kamboju writes: This patch is causing oom-killer while running mkfs -t ext4 on i386 kernel running on x86_64 machine version linux-next 5.7.0-rc6-next-20200521. I think I see what's wrong here -- if we bail out early, memory.e{min,low} might be uninitialised. Does this patch fix it,

[PATCH v3 1/2] drivers: thermal: tsens: Add cold interrupt support

2020-05-22 Thread Manaf Meethalavalappu Pallikunhi
TSENS IP v2.6+ adds cold interrupt support. It triggers set interrupt when aggregated minimum temperature of all TSENS falls below cold preset threshold, 5 degree Celsius and triggers reset interrupt when aggregated minimum temperature of all TSENS crosses above reset threshold, 10 degree Celsius.

[PATCH v3 2/2] dt-bindings: thermal: tsens: Add cold interrupt support in yaml

2020-05-22 Thread Manaf Meethalavalappu Pallikunhi
Add cold interrupt support for tsens in yaml. Signed-off-by: Manaf Meethalavalappu Pallikunhi --- .../bindings/thermal/qcom-tsens.yaml | 42 +++ 1 file changed, 42 insertions(+) diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml

[PATCH v3 1/2] drivers: thermal: tsens: Add cold interrupt support

2020-05-22 Thread Manaf Meethalavalappu Pallikunhi
TSENS IP v2.6+ adds cold interrupt support. It triggers set interrupt when aggregated minimum temperature of all TSENS falls below cold preset threshold, 5 degree Celsius and triggers reset interrupt when aggregated minimum temperature of all TSENS crosses above reset threshold, 10 degree Celsius.

[PATCH v3 0/2] Add cold interrupt support to tsens driver

2020-05-22 Thread Manaf Meethalavalappu Pallikunhi
The changes have dependency on merging tsens-common.c into tsens.c [1] to merge first. Dependencies: [1] https://lkml.org/lkml/2020/4/29/1028 Changes in v3: * Add cold interrupt support to tsens driver * Update cold interrupt support in yaml Manaf Meethalavalappu Pallikunhi (2): drivers:

Re: [PATCH V4 7/8] fs/ext4: Introduce DAX inode flag

2020-05-22 Thread Jan Kara
On Thu 21-05-20 12:13:12, ira.we...@intel.com wrote: > From: Ira Weiny > > Add a flag to preserve FS_XFLAG_DAX in the ext4 inode. > > Set the flag to be user visible and changeable. Set the flag to be > inherited. Allow applications to change the flag at any time with the > exception of if

[PATCH] [v2] dmaengine: tegra210-adma: Fix runtime PM imbalance on error

2020-05-22 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- Changelog: v2: - Merge two patches that fix runtime PM imbalance in

Re: [PATCH V2] pwm: tegra: dynamic clk freq configuration by PWM driver

2020-05-22 Thread Jon Hunter
On 22/05/2020 12:01, Sandipan Patra wrote: > Thanks Jonathan, > Please help reviewing further with my replies inline. > > > Thanks & Regards, > Sandipan > >> -Original Message- >> From: Jonathan Hunter >> Sent: Friday, May 22, 2020 3:54 PM >> To: Sandipan Patra ; Thierry Reding >> ;

Re: [PATCH] drivers/virt/fsl_hypervisor: Correcting error handling path

2020-05-22 Thread Souptick Joarder
On Thu, May 14, 2020 at 1:45 AM Souptick Joarder wrote: > > First, when memory allocation for sg_list_unaligned failed, there > is no point of calling put_pages() as we haven't pinned any pages. > > Second, if get_user_pages_fast() failed we should unpinned num_pinned > pages, no point of

linux-next: manual merge of the akpm-current tree with the userns tree

2020-05-22 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the akpm-current tree got a conflict in: fs/binfmt_script.c between commit: ccbb18b67323 ("exec/binfmt_script: Don't modify bprm->buf and then return -ENOEXEC") from the userns tree and commit: e20ecf0e2723 ("exec: simplify the copy_strings_kernel

Re: [PATCH v3] Makefile: support compressed debug info

2020-05-22 Thread Sedat Dilek
On Fri, May 22, 2020 at 12:00 AM Nick Desaulniers wrote: > > As debug information gets larger and larger, it helps significantly save > the size of vmlinux images to compress the information in the debug > information sections. Note: this debug info is typically split off from > the final

Re: [PATCH V4 3/5] iio: adc: Add support for PMIC7 ADC

2020-05-22 Thread Jishnu Prakash
Hi Andy, On 5/13/2020 3:18 PM, Andy Shevchenko wrote: On Wed, May 13, 2020 at 12:23 PM Jishnu Prakash wrote: The ADC architecture on PMIC7 is changed as compared to PMIC5. The major change from PMIC5 is that all SW communication to ADC goes through PMK8350, which communicates with other PMICs

Re: [PATCH V4 5/5] iio: adc: Clean up ADC code common to PMIC5 and PMIC7

2020-05-22 Thread Jishnu Prakash
Hi Andy, On 5/13/2020 3:21 PM, Andy Shevchenko wrote: On Wed, May 13, 2020 at 12:24 PM Jishnu Prakash wrote: This commit includes the following changes: Add a common function used for read_raw callback for both PMIC5 and PMIC7 ADCs. Add exit function for ADC. Add info_property under adc_data

Re: [PATCH V4 4/5] iio: adc: Update error checks and debug prints

2020-05-22 Thread Jishnu Prakash
Hi Andy, On 5/13/2020 3:19 PM, Andy Shevchenko wrote: On Wed, May 13, 2020 at 12:23 PM Jishnu Prakash wrote: Change pr_err/pr_debug statements to dev_err/dev_dbg for increased clarity. Also clean up some return value checks. 'Also' on the commit message == 'split this to two'. I'll do the

Re: [PATCH v3 01/16] spi: dw: Add Tx/Rx finish wait methods to the MID DMA

2020-05-22 Thread Feng Tang
On Fri, May 22, 2020 at 02:32:35PM +0300, Serge Semin wrote: > On Fri, May 22, 2020 at 03:58:44PM +0800, Feng Tang wrote: > > Hi Serge, > > > > On Thu, May 21, 2020 at 06:33:17PM +0300, Serge Semin wrote: > > > > > > > + dw_spi_dma_wait_rx_done(dws); > > > > > > > > > > > > I can understand the

[PATCH v5 00/11] mediatek: add support for MediaTek Ethernet MAC

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This series adds support for the STAR Ethernet Controller present on MediaTeK SoCs from the MT8* family. First we convert the existing DT bindings for the PERICFG controller to YAML and add a new compatible string for mt8516 variant of it. Then we add the DT bindings

Re: Re: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-22 Thread Thierry Reding
On Wed, May 20, 2020 at 04:48:16PM -0600, Rob Herring wrote: > On Wed, May 20, 2020 at 11:16:32PM +0530, Vidya Sagar wrote: > > > > > > On 20-May-20 4:47 PM, Thierry Reding wrote: > > > On Tue, May 19, 2020 at 10:08:54PM +, Gustavo Pimentel wrote: > > > > On Tue, May 19, 2020 at 15:58:16,

[PATCH v5 08/11] ARM64: dts: mediatek: add the ethernet node to mt8516.dtsi

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add the Ethernet MAC node to mt8516.dtsi. This defines parameters common to all the boards based on this SoC. Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/mediatek/mt8516.dtsi | 12 1 file changed, 12 insertions(+) diff --git

[PATCH v5 05/11] net: ethernet: mediatek: remove unnecessary spaces from Makefile

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The Makefile formatting in the kernel tree usually doesn't use tabs, so remove them before we add a second driver. Signed-off-by: Bartosz Golaszewski --- drivers/net/ethernet/mediatek/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v5 04/11] net: ethernet: mediatek: rename Kconfig prompt

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski We'll soon by adding a second MediaTek Ethernet driver so modify the Kconfig prompt. Signed-off-by: Bartosz Golaszewski --- drivers/net/ethernet/mediatek/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mediatek/Kconfig

[PATCH v5 09/11] ARM64: dts: mediatek: add an alias for ethernet0 for pumpkin boards

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add the ethernet0 alias for ethernet so that u-boot can find this node and fill in the MAC address. Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v5 10/11] ARM64: dts: mediatek: add ethernet pins for pumpkin boards

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Setup the pin control for the Ethernet MAC. Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi

[PATCH v5 06/11] net: ethernet: mtk-star-emac: new driver

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This adds the driver for the MediaTek STAR Ethernet MAC currently used on the MT8* SoC family. For now we only support full-duplex. Signed-off-by: Bartosz Golaszewski --- drivers/net/ethernet/mediatek/Kconfig |7 + drivers/net/ethernet/mediatek/Makefile

[PATCH v5 07/11] ARM64: dts: mediatek: add pericfg syscon to mt8516.dtsi

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This adds support for the PERICFG register range as a syscon. This will soon be used by the MediaTek Ethernet MAC driver for NIC configuration. Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/mediatek/mt8516.dtsi | 5 + 1 file changed, 5 insertions(+)

[PATCH v5 11/11] ARM64: dts: mediatek: enable ethernet on pumpkin boards

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add remaining properties to the ethernet node and enable it. Signed-off-by: Bartosz Golaszewski --- .../boot/dts/mediatek/pumpkin-common.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi

[PATCH v5 02/11] dt-bindings: add new compatible to mediatek,pericfg

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The PERICFG controller is present on the MT8516 SoC. Add an appropriate compatible variant. Signed-off-by: Bartosz Golaszewski --- .../devicetree/bindings/arm/mediatek/mediatek,pericfg.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v5 03/11] dt-bindings: net: add a binding document for MediaTek STAR Ethernet MAC

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This adds yaml DT bindings for the MediaTek STAR Ethernet MAC present on the mt8* family of SoCs. Signed-off-by: Bartosz Golaszewski --- .../bindings/net/mediatek,eth-mac.yaml| 89 +++ 1 file changed, 89 insertions(+) create mode 100644

[PATCH v5 01/11] dt-bindings: convert the binding document for mediatek PERICFG to yaml

2020-05-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Convert the DT binding .txt file for MediaTek's peripheral configuration controller to YAML. There's one special case where the compatible has three positions. Otherwise, it's a pretty normal syscon. Signed-off-by: Bartosz Golaszewski ---

Re: [PATCH v4 01/16] spi: dw: Add Tx/Rx finish wait methods to the MID DMA

2020-05-22 Thread Mark Brown
On Fri, May 22, 2020 at 02:52:35PM +0300, Serge Semin wrote: > On Fri, May 22, 2020 at 02:13:40PM +0300, Andy Shevchenko wrote: > > > Changelog v4: > > > - Get back ndelay() method to wait for an SPI transfer completion. > > > spi_delay_exec() isn't suitable for the atomic context. > > OTOH we

Re: [PATCH v3 5/5] nand: brcmnand: support v2.1-v2.2 controllers

2020-05-22 Thread Álvaro Fernández Rojas
Hello Miquel, No, nothing else changed. I will change it again with the proper subject, sorry for that. Best regards, Álvaro. > El 22 may 2020, a las 13:22, Miquel Raynal > escribió: > >> v2.1: tested on Netgear DGND3700v1 (BCM6368)

Re: [PATCH v4 01/16] spi: dw: Add Tx/Rx finish wait methods to the MID DMA

2020-05-22 Thread Andy Shevchenko
On Fri, May 22, 2020 at 02:52:35PM +0300, Serge Semin wrote: > On Fri, May 22, 2020 at 02:13:40PM +0300, Andy Shevchenko wrote: > > On Fri, May 22, 2020 at 03:07:50AM +0300, Serge Semin wrote: > > > Since DMA transfers are performed asynchronously with actual SPI > > > transaction, then even if

RE: [PATCH V2] pwm: tegra: dynamic clk freq configuration by PWM driver

2020-05-22 Thread Sandipan Patra
Hi Jon, > -Original Message- > From: Jonathan Hunter > Sent: Friday, May 22, 2020 5:20 PM > To: Sandipan Patra ; Thierry Reding > ; robh...@kernel.org; u.kleine-koe...@pengutronix.de > Cc: Bibek Basu ; Laxman Dewangan > ; linux-...@vger.kernel.org; > devicet...@vger.kernel.org;

Re: [PATCH v1] sdhci: tegra: Remove warnings about missing device-tree properties

2020-05-22 Thread Thierry Reding
On Wed, May 20, 2020 at 09:09:33AM -0700, Sowjanya Komatineni wrote: > > On 5/20/20 4:26 AM, Ulf Hansson wrote: > > On Wed, 20 May 2020 at 04:00, Dmitry Osipenko wrote: > > > 19.05.2020 23:44, Sowjanya Komatineni пишет: > > > > On 5/19/20 12:07 PM, Sowjanya Komatineni wrote: > > > > > On 5/19/20

[PATCH v4 0/5] mtd: rawnand: brcmnand: support v2.1-v2.2 controllers

2020-05-22 Thread Álvaro Fernández Rojas
Add support for v2.1 and v2.2 NAND controllers. v4: fix commit subject. v3: fix v2.1 page size shift v2: introduce changes suggested by Miquèl. Álvaro Fernández Rojas (5): mtd: rawnand: brcmnand: rename v4 registers mtd: rawnand: brcmnand: fix CS0 layout mtd: rawnand: brcmnand: rename page

[PATCH v4 5/5] mtd: rawnand: brcmnand: support v2.1-v2.2 controllers

2020-05-22 Thread Álvaro Fernández Rojas
v2.1: tested on Netgear DGND3700v1 (BCM6368) v2.2: tested on Netgear DGND3700v2 (BCM6362) Signed-off-by: Álvaro Fernández Rojas --- v4: use proper commit subject. v3: fix page size shift for v2.1 controllers. v2: split page sizes rename into a different patch. name all block and page

[PATCH v4 1/5] mtd: rawnand: brcmnand: rename v4 registers

2020-05-22 Thread Álvaro Fernández Rojas
These registers are also used on v3.3. Signed-off-by: Álvaro Fernández Rojas Reviewed-by: Miquel Raynal --- v4: no changes. v3: no changes. v2: fix commit title. drivers/mtd/nand/raw/brcmnand/brcmnand.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v4 3/5] mtd: rawnand: brcmnand: rename page sizes

2020-05-22 Thread Álvaro Fernández Rojas
Current pages sizes apply to controllers after v3.4 Signed-off-by: Álvaro Fernández Rojas --- v4: no changes. v3: no changes. v2: add new patch. drivers/mtd/nand/raw/brcmnand/brcmnand.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v4 2/5] mtd: rawnand: brcmnand: fix CS0 layout

2020-05-22 Thread Álvaro Fernández Rojas
Only v3.3-v5.0 have a different CS0 layout. Controllers before v3.3 use the same layout for every CS. Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB NAND controller") Signed-off-by: Álvaro Fernández Rojas --- v4: no changes. v3: no changes. v2: fix commit log.

[PATCH v4 4/5] dt: bindings: brcmnand: add v2.1 and v2.2 support

2020-05-22 Thread Álvaro Fernández Rojas
Added brcm,brcmnand-v2.1 and brcm,brcmnand-v2.2 as possible compatible strings to support brcmnand controllers v2.1 and v2.2. Signed-off-by: Álvaro Fernández Rojas --- v4: no changes. v3: no changes. v2: add new patch. Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt | 2 ++ 1 file

Re: [PATCH v4 01/16] spi: dw: Add Tx/Rx finish wait methods to the MID DMA

2020-05-22 Thread Mark Brown
On Fri, May 22, 2020 at 03:12:21PM +0300, Andy Shevchenko wrote: > On Fri, May 22, 2020 at 02:52:35PM +0300, Serge Semin wrote: > > Please, see it's implementation. It does atomic delay when the delay value > > is less than 10us. But selectively gets to the usleep_range() if value is > > greater

[PATCH v1 3/3] scsi: ufs-mediatek: Introduce low-power mode for device power supply

2020-05-22 Thread Stanley Chu
Allow device power supply to enter low-power mode if device will do nothing to save more power. Signed-off-by: Stanley Chu Reviewed-by: Pengshun Zhao --- drivers/scsi/ufs/ufs-mediatek.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/scsi/ufs/ufs-mediatek.c

[PATCH v1 0/3] scsi: ufs-mediatek: Fix clk-gating and introduce low-power mode for vccq2

2020-05-22 Thread Stanley Chu
Hi, This patchset fixes a clk-gating issue and introduces low-power mode for vccq2 in MediaTek platforms. Stanley Chu (3): scsi: ufs-mediatek: Fix imprecise waiting time for ref-clk control scsi: ufs-mediatek: Do not gate clocks if auto-hibern8 is not entered yet scsi: ufs-mediatek:

[PATCH v1 2/3] scsi: ufs-mediatek: Do not gate clocks if auto-hibern8 is not entered yet

2020-05-22 Thread Stanley Chu
There are some chances that link enters hibern8 lately by auto-hibern8 scheme during the clock-gating flow. Clocks shall not be gated if link is still active otherwise host or device may hang. Fix this by returning error code to the caller __ufshcd_setup_clocks() to skip gating clocks there if

[PATCH v1 1/3] scsi: ufs-mediatek: Fix imprecise waiting time for ref-clk control

2020-05-22 Thread Stanley Chu
Currently ref-clk control timeout is implemented by Jiffies. However jiffies is not accurate enough thus "false timeout" may happen. Use more accurate delay mechanism instead, for example, ktime. Signed-off-by: Stanley Chu Reviewed-by: Andy Teng --- drivers/scsi/ufs/ufs-mediatek.c | 7 ---

Re: [PATCH v1] sdhci: tegra: Remove warnings about missing device-tree properties

2020-05-22 Thread Dmitry Osipenko
22.05.2020 15:13, Thierry Reding пишет: > On Wed, May 20, 2020 at 09:09:33AM -0700, Sowjanya Komatineni wrote: >> >> On 5/20/20 4:26 AM, Ulf Hansson wrote: >>> On Wed, 20 May 2020 at 04:00, Dmitry Osipenko wrote: 19.05.2020 23:44, Sowjanya Komatineni пишет: > On 5/19/20 12:07 PM,

Re: [PATCH v3 2/2] mm, memcg: Decouple e{low,min} state mutations from protection checks

2020-05-22 Thread Yafang Shao
On Fri, May 22, 2020 at 7:01 PM Naresh Kamboju wrote: > > On Tue, 5 May 2020 at 14:12, Yafang Shao wrote: > > > > From: Chris Down > > > > mem_cgroup_protected currently is both used to set effective low and min > > and return a mem_cgroup_protection based on the result. As a user, this > >

Re: [PATCHv2 1/2] optee: do drivers initialization before and after tee-supplicant run

2020-05-22 Thread Maxim Uvarov
On Fri, 22 May 2020 at 14:40, Sumit Garg wrote: > > Hi Maxim, > > On Thu, 21 May 2020 at 12:17, Maxim Uvarov wrote: > > > > Some drivers (like ftpm) can operate only after tee-supplicant > > runs becase of tee-supplicant provides things like storage > > services. This patch splits probe of non

drivers/ide/ide-ioctls.c:15:24: sparse: sparse: incorrect type in initializer (different address spaces)

2020-05-22 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 051143e1602d90ea71887d92363edd539d411de5 commit: 1df23c6fe5b0654ece219985a0c32e40b100bd9a compat_ioctl: move HDIO ioctl handling into drivers/ide date: 5 months ago config: xtensa-randconfig-s002-20200522

Re: [PATCH v3 01/16] spi: dw: Add Tx/Rx finish wait methods to the MID DMA

2020-05-22 Thread Serge Semin
On Fri, May 22, 2020 at 08:03:25PM +0800, Feng Tang wrote: > On Fri, May 22, 2020 at 02:32:35PM +0300, Serge Semin wrote: > > On Fri, May 22, 2020 at 03:58:44PM +0800, Feng Tang wrote: > > > Hi Serge, > > > > > > On Thu, May 21, 2020 at 06:33:17PM +0300, Serge Semin wrote: > > > > > > > > +

[PATCH net-next v2 1/4] dt-bindings: net: Add tx and rx internal delays

2020-05-22 Thread Dan Murphy
tx-internal-delays and rx-internal-delays are a common setting for RGMII capable devices. These properties are used when the phy-mode or phy-controller is set to rgmii-id, rgmii-rxid or rgmii-txid. These modes indicate to the controller that the PHY will add the internal delay for the

[PATCH net-next v2 0/4] RGMII Internal delay common property

2020-05-22 Thread Dan Murphy
Hello The RGMII internal delay is a common setting found in most RGMII capable PHY devices. It was found that many vendor specific device tree properties exist to do the same function. This creates a common property to be used for PHY's that have tunable internal delays for the Rx and Tx paths.

[PATCH net-next v2 4/4] net: dp83869: Add RGMII internal delay configuration

2020-05-22 Thread Dan Murphy
Add RGMII internal delay configuration for Rx and Tx. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 101 ++ 1 file changed, 101 insertions(+) diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c index cfb22a21a2e6..a9008d32e2b6

[PATCH net-next v2 3/4] dt-bindings: net: Add RGMII internal delay for DP83869

2020-05-22 Thread Dan Murphy
Add the internal delay values into the header and update the binding with the internal delay properties. Signed-off-by: Dan Murphy --- .../devicetree/bindings/net/ti,dp83869.yaml | 16 1 file changed, 16 insertions(+) diff --git

[PATCH net-next v2 2/4] net: phy: Add a helper to return the index for of the internal delay

2020-05-22 Thread Dan Murphy
Add a helper function that will return the index in the array for the passed in internal delay value. The helper requires the array, size and delay value. The helper will then return the index for the exact match or return the index for the index to the closest smaller value. Signed-off-by: Dan

Re: [PATCH] sdhci: tegra: Avoid reading autocal timeout values when not applicable

2020-05-22 Thread Thierry Reding
On Wed, May 20, 2020 at 01:08:57PM -0700, Sowjanya Komatineni wrote: > When auto calibration timeouts, calibration is disabled and fail-safe > drive strength values are programmed based on the signal voltage. > > Different fail-safe drive strength values based on voltage are > applicable only for

Re: [PATCH v13 2/3] i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver

2020-05-22 Thread Andy Shevchenko
On Fri, May 22, 2020 at 02:33:11PM +0300, Tali Perry wrote: > Add Nuvoton NPCM BMC I2C controller driver. I thought we are waiting for Wolfram finishing his review... In any case see couple of comments below. ... > +#ifdef CONFIG_DEBUG_FS Now, do we need the rest of DEBUG_FS guards? > +

Re: [PATCH V2] pwm: tegra: dynamic clk freq configuration by PWM driver

2020-05-22 Thread Jon Hunter
On 22/05/2020 13:12, Sandipan Patra wrote: ... > /* >* Compute the prescaler value for which (1 << PWM_DUTY_WIDTH) >* cycles at the PWM clock rate will take period_ns nanoseconds. >*/ > - rate = pc->clk_rate >> PWM_DUTY_WIDTH; > + if (pc->soc->num_channels

Re: [PATCH] sdhci: tegra: Avoid reading autocal timeout values when not applicable

2020-05-22 Thread Dmitry Osipenko
20.05.2020 23:08, Sowjanya Komatineni пишет: > When auto calibration timeouts, calibration is disabled and fail-safe > drive strength values are programmed based on the signal voltage. > > Different fail-safe drive strength values based on voltage are > applicable only for SoCs supporting 3V3 and

Re: [PATCH v13 3/3] i2c: npcm7xx: Add support for slave mode for Nuvoton

2020-05-22 Thread Andy Shevchenko
On Fri, May 22, 2020 at 02:33:12PM +0300, Tali Perry wrote: > Add support for slave mode for Nuvoton > NPCM BMC I2C controller driver. I guess it will require v14, so, few nits below. ... > +const int npcm_i2caddr[I2C_NUM_OWN_ADDR] = { > + NPCM_I2CADDR1,

  1   2   3   4   5   6   7   8   9   10   >