Re: [PATCH] rcu: Fixup noinstr warnings

2020-06-03 Thread Paul E. McKenney
On Wed, Jun 03, 2020 at 12:52:06PM +0200, Peter Zijlstra wrote: > On Wed, Jun 03, 2020 at 02:59:32AM -0700, Paul E. McKenney wrote: > > On Wed, Jun 03, 2020 at 10:48:18AM +0200, Peter Zijlstra wrote: > > > On Tue, Jun 02, 2020 at 09:38:53PM +0200, Peter Zijlstra wrote: > > > > > > > That said;

Re: [PATCH] lan743x: Added fixed link and RGMII support / debugging

2020-06-03 Thread Roelof Berg
Ok, let's proceed :) The code runs well, dmesg looks good, ip addr shows me a link up, speed/duplex looks ok. But it does not transfer any data. Debugging steps (A/B versions): - Check clocks with oscilloscope (10/100/1000) - Dump actual register settings - Trace Phy-Phy autonegotiation and

Re: [PATCH] lan743x: Added fixed link and RGMII support / debugging

2020-06-03 Thread Roelof Berg
If I find a fix, would I need to submit a delta patch (to our last one) or a full patch ? Thanks. > So lets try to fix it. > >Thanks > Andrew >

[PATCH v2] media: marvell-ccic: Add missed v4l2_async_notifier_cleanup()

2020-06-03 Thread Chuhong Yuan
mccic_register() forgets to cleanup the notifier in its error handler. mccic_shutdown() also misses calling v4l2_async_notifier_cleanup(). Add the missed calls to fix them. Fixes: 3eefe36cc00c ("media: marvell-ccic: use async notifier to get the sensor") Signed-off-by: Chuhong Yuan --- Changes

[PATCH v2] media: omap3isp: Add missed v4l2_ctrl_handler_free() for preview_init_entities()

2020-06-03 Thread Chuhong Yuan
preview_init_entities() does not call v4l2_ctrl_handler_free() when it fails. Add the missed function to fix it. Fixes: de1135d44f4f ("[media] omap3isp: CCDC, preview engine and resizer]") Signed-off-by: Chuhong Yuan --- Changes in v2: - Fix the typo.

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-03 Thread Paul E. McKenney
On Wed, Jun 03, 2020 at 01:40:16PM +0200, Peter Zijlstra wrote: > A KCSAN build revealed we have explicit annoations through atomic_*() > usage, switch to arch_atomic_*() for the respective functions. > > vmlinux.o: warning: objtool: rcu_nmi_exit()+0x4d: call to > __kcsan_check_access() leaves

Re: BUG: unable to handle kernel paging request in rb_erase

2020-06-03 Thread J. Bruce Fields
On Wed, Jun 03, 2020 at 10:43:26AM -0400, J. Bruce Fields wrote: > On Wed, Jun 03, 2020 at 12:34:35PM +0800, Hillf Danton wrote: > > > > On Tue, 2 Jun 2020 17:55:17 -0400 "J. Bruce Fields" wrote: > > > > > > As far as I know, this one's still unresolved. I can't see the bug from > > > code

Re: [PATCH] fbdev: geocode: Add the missed pci_disable_device() in gx1fb_map_video_memory()

2020-06-03 Thread Markus Elfring
> Add the missed function call to fix the bug. … > +++ b/drivers/video/fbdev/geode/gx1fb_core.c > @@ -208,29 +208,44 @@ static int gx1fb_map_video_memory(struct fb_info > *info, struct pci_dev *dev) … > return 0; > + > +err: > + pci_disable_device(dev); > + return ret; > } … I

Re: [PATCH RFC] uaccess: user_access_begin_after_access_ok()

2020-06-03 Thread Al Viro
On Wed, Jun 03, 2020 at 01:29:00AM -0400, Michael S. Tsirkin wrote: > On Wed, Jun 03, 2020 at 02:48:15AM +0100, Al Viro wrote: > > On Tue, Jun 02, 2020 at 04:45:05AM -0400, Michael S. Tsirkin wrote: > > > So vhost needs to poke at userspace *a lot* in a quick succession. It > > > is thus

Re: [PATCH 1/2] sched/uclamp: Add a new sysctl to control RT default boost value

2020-06-03 Thread Qais Yousef
On 06/03/20 16:59, Vincent Guittot wrote: > When I want to stress the fast path i usually use "perf bench sched pipe -T " > The tip/sched/core on my arm octo core gives the following results for > 20 iterations of perf bench sched pipe -T -l 5 > > all uclamp config disabled 50035.4(+/-

Re: [PATCH] module: make module symbols visible after init

2020-06-03 Thread Miroslav Benes
Hi, I'm confused... On Wed, 3 Jun 2020, Cheng Jian wrote: > When lookup the symbols of module by module_kallsyms_lookup_name(), > the symbols address is visible only if the module's status isn't > MODULE_STATE_UNFORMED, This is problematic. > > When complete_formation is done, the state of the

Re: [PATCH RFC] uaccess: user_access_begin_after_access_ok()

2020-06-03 Thread Linus Torvalds
[ Just a re-send without html and a few fixes for mobile editing, since that email got eaten by the mailing list Gods ] On Tue, Jun 2, 2020, 23:02 Michael S. Tsirkin wrote: > > Right and we do that, but that still sets the segment according to the > current thread's flags, right? But that

Re: [PATCH v6 01/13] tools/libperf: introduce notion of static polled file descriptors

2020-06-03 Thread Alexey Budankov
On 03.06.2020 18:53, Adrian Hunter wrote: > On 3/06/20 3:52 pm, Alexey Budankov wrote: >> >> On 03.06.2020 15:30, Hunter, Adrian wrote: >>> >>> -Original Message- From: Hunter, Adrian Sent: Wednesday, June 3, 2020 3:24 PM To: Alexey Budankov Cc: Arnaldo

Re: [PATCH v2 1/3] capabilities: Introduce CAP_CHECKPOINT_RESTORE

2020-06-03 Thread Cyrill Gorcunov
On Wed, Jun 03, 2020 at 06:23:26PM +0200, Adrian Reber wrote: ... > > /* > - * Only allow CAP_SYS_ADMIN to follow the links, due to concerns about how > the > - * symlinks may be used to bypass permissions on ancestor directories in the > - * path to the file in question. > + * Only allow

Re: headers_install builds break on a lot of targets?

2020-06-03 Thread Rich Felker
On Wed, Jun 03, 2020 at 08:49:54AM -0500, Rob Landley wrote: > The headers_install_all target got removed last year (commit f3c8d4c7a728 and > would someone like to update Documentation/kbuild/headers_install.txt which > still describes it?) > > The musl-libc maintainer is using a forked

Re: [PATCH V11 11/11] fs/xfs: Update xfs_ioctl_setattr_dax_invalidate()

2020-06-03 Thread Darrick J. Wong
On Wed, Jun 03, 2020 at 12:10:24PM +0200, Jan Kara wrote: > On Tue 02-06-20 10:23:53, Darrick J. Wong wrote: > > On Tue, Apr 28, 2020 at 01:11:38PM -0700, Darrick J. Wong wrote: > > > > -out_unlock: > > > > - xfs_iunlock(ip, XFS_MMAPLOCK_EXCL | XFS_IOLOCK_EXCL); > > > > - return error;

Re: [PATCH 0/2] firmware/psci: PSCI checker cleanup

2020-06-03 Thread Sudeep Holla
On Fri, Apr 24, 2020 at 02:56:55PM +0100, Valentin Schneider wrote: > Hi folks, > > This is a small cleanup of the PSCI checker following Peter's objections > to its homegrown do_idle() implementation. It is based on his > sched_setscheduler() unexport series at [1]. > > I've never really used

Re: [sched/fair] 0b0695f2b3: phoronix-test-suite.compress-gzip.0.seconds 19.8% regression

2020-06-03 Thread Vincent Guittot
Hi Oliver, On Tue, 2 Jun 2020 at 16:11, Oliver Sang wrote: > > On Tue, Jun 02, 2020 at 01:23:19PM +0800, Oliver Sang wrote: > > On Fri, May 29, 2020 at 07:26:01PM +0200, Vincent Guittot wrote: > > > On Mon, 25 May 2020 at 10:02, Vincent Guittot > > > wrote: > > > > > > > > > > > > We also

Re: [PATCH] scs: Report SCS usage in bytes rather than number of entries

2020-06-03 Thread Kees Cook
On Wed, Jun 03, 2020 at 04:12:17PM +0100, Will Deacon wrote: > Fix the SCS debug usage check so that we report the number of bytes > usedm, rather than the number of entries. typo: used > > Fixes: 5bbaf9d1fcb9 ("scs: Add support for stack usage debugging") > Reported-by: Sami Tolvanen >

Re: [PATCH] mm/memblock: export max_pfn for kernel modules

2020-06-03 Thread Mike Rapoport
On Thu, Jun 04, 2020 at 12:11:32AM +0800, Miles Chen wrote: > max_pfn is uesd to get the highest pfn in the system. Drivers like > drivers/iommu/mtk_iommu.c checks max_pfn to see if it should enable > its "4GB mode". > > This patch exports the max_pfn symbol, so we can build the driver as > a

Good day

2020-06-03 Thread MR JOHN KENO
Attention Beneficiary, This is to inform you that the United Nations Committee on REWARD/COMPENSATION have selected your Email I.D for the New year 2020 program. The Microsoft through a careful world wide web gathering of data made a very careful electronic base selection and your Email happen to

Re: [PATCH v3 6/6] MAINTAINERS: Add maintainers for MIPS core drivers

2020-06-03 Thread Serge Semin
Daniel, Rafael, Thomas (Gleixner), Could you take a look at the series this patch belongs to and to this patch in particular? If you are ok with this, please explicitly ack. It would be great to merge the leftover series in this merge window. -Sergey On Wed, Jun 03, 2020 at 03:03:19AM +0300,

Re: [PATCH 2/9] rcu: Fixup noinstr warnings

2020-06-03 Thread Peter Zijlstra
On Wed, Jun 03, 2020 at 09:46:00AM -0700, Paul E. McKenney wrote: > > --- a/kernel/rcu/tree.c > > +++ b/kernel/rcu/tree.c > > @@ -250,7 +250,7 @@ static noinstr void rcu_dynticks_eqs_ent > > * next idle sojourn. > > */ > > rcu_dynticks_task_trace_enter(); // Before ->dynticks

Re: [PATCH v3 35/75] x86/head/64: Build k/head64.c with -fno-stack-protector

2020-06-03 Thread Brian Gerst
On Wed, Jun 3, 2020 at 11:18 AM Joerg Roedel wrote: > > On Tue, May 19, 2020 at 09:58:18AM -0400, Brian Gerst wrote: > > On Tue, Apr 28, 2020 at 11:28 AM Joerg Roedel wrote: > > > The proper fix would be to initialize MSR_GS_BASE earlier. > > That'll mean to initialize it two times during boot,

Re: [GIT pull] timers/core for v5.8

2020-06-03 Thread Linus Torvalds
On Tue, Jun 2, 2020 at 5:09 AM Thomas Gleixner wrote: > > The truly boring timer and clocksource updates for 5.8: > > - Not a single new clocksource or clockevent driver! The diffstat proved that to be a filthy lie: > drivers/clocksource/timer-ti-dm-systimer.c | 727 >

[tip:master] BUILD SUCCESS cc7a4a02564c6cc8dc981fb0a37313830ee8c2d4

2020-06-03 Thread kernel test robot
allmodconfig powerpc allnoconfig powerpc defconfig i386 randconfig-a014-20200603 i386 randconfig-a015-20200603 i386 randconfig-a011-20200603 i386 randconfig-a016-20200603 i386

[tip:core/urgent] BUILD SUCCESS 5fdeefa053df54961c1e9b69a128ddb5185ce150

2020-06-03 Thread kernel test robot
allyesconfig powerpc rhel-kconfig powerpc allmodconfig powerpc allnoconfig powerpc defconfig i386 randconfig-a001-20200603 i386 randconfig-a006-20200603

Re: [RFC, WIP, v6 02/10] media: vidtv: implement a tuner driver

2020-06-03 Thread Daniel W. S. Almeida
Hi Shuah, thanks for reviewing this! >> From: "Daniel W. S. Almeida" > > Are you using git send-email to send patches. Why do have this > From line in here? Same comment on all other patches in this series. I am using 'git format-patch --to=[...] --cc=[...]' and then 'git send-email'. Git

Re: [GIT PULL] SELinux patches for v5.8

2020-06-03 Thread Casey Schaufler
On 6/2/2020 5:31 PM, Linus Torvalds wrote: > On Mon, Jun 1, 2020 at 6:07 PM Paul Moore wrote: >> - A number of improvements to various SELinux internal data structures >> to help improve performance. We move the role transitions into a hash >> table. In the content structure we shift from

[GIT PULL] VFIO updates for v5.8-rc1

2020-06-03 Thread Alex Williamson
Hi Linus, The following changes since commit 9cb1fd0efd195590b828b9b865421ad345a4a145: Linux 5.7-rc7 (2020-05-24 15:32:54 -0700) are available in the Git repository at: git://github.com/awilliam/linux-vfio.git tags/vfio-v5.8-rc1 for you to fetch changes up to

Re: [GIT pull] timers/core for v5.8

2020-06-03 Thread Thomas Gleixner
Linus Torvalds writes: > On Tue, Jun 2, 2020 at 5:09 AM Thomas Gleixner wrote: >> >> The truly boring timer and clocksource updates for 5.8: >> >> - Not a single new clocksource or clockevent driver! > > The diffstat proved that to be a filthy lie: > >>

Re: [PATCH 0/9] x86/entry fixes

2020-06-03 Thread Marco Elver
On Wed, 3 Jun 2020 at 18:07, Peter Zijlstra wrote: > > On Wed, Jun 03, 2020 at 04:47:54PM +0200, Marco Elver wrote: > > > This is fun: __always_inline functions inlined into > > __no_sanitize_undefined *do* get instrumented because apparently UBSan > > passes must run before the optimizer (before

Re: [PATCH 1/2] mm: cma: fix the name of CMA areas

2020-06-03 Thread Mike Kravetz
On 6/3/20 1:40 AM, Barry Song wrote: > if users give a name saved in stack, the current code will generate magic > pointer. > if users don't give a name(NULL), kasprintf() will always return NULL as > we are at the early stage. that means cma_init_reserved_mem() will return > -ENOMEM if users set

Re: [PATCH 2/2] mm: hugetlb: fix the name of hugetlb CMA

2020-06-03 Thread Mike Kravetz
On 6/3/20 1:40 AM, Barry Song wrote: > once we enable CMA_DEBUGFS, we will get the below errors: > directory 'cma-hugetlb' with parent 'cma' already present > > only the first numa node will get a directory in debugfs. > we should have different names for different CMA areas. > > Cc: Roman

Re: [PATCH v3 01/10] dmaengine: Actions: get rid of bit fields from dma descriptor

2020-06-03 Thread Amit Tomer
Hi, Thanks for having a look. On Wed, Jun 3, 2020 at 12:52 PM Manivannan Sadhasivam wrote: > Individual comments for these enums? I was expecting this comment , and thought these fields are self explanatory But if you prefer to have description about it, I would have it in next version. >

Re: [PATCH glibc 1/3] glibc: Perform rseq registration at C startup and thread creation (v20)

2020-06-03 Thread Joseph Myers
On Wed, 3 Jun 2020, Florian Weimer via Libc-alpha wrote: > I'm still waiting for feedback from other maintainers whether the level > of documentation and testing is appropriate. Looking at the documentation in the manual, it doesn't look like it has enough information for someone to use this

Re: [PATCH] clk: clk-st: Add missed return value checks in st_clk_probe()

2020-06-03 Thread Markus Elfring
> st_clk_probe() has not check for clk_hw_register_mux(), clk_hw_register_gate() > and devm_clk_hw_register_clkdev(). > Add the missed checks and return devm_clk_hw_register_clkdev()'s return value > to check errors. How do you think about another wording variant? Return values were not

v5.7: new core kernel option missing help text

2020-06-03 Thread Russell King - ARM Linux admin
Hi, A new kernel configuration option ("SCHED_THERMAL_PRESSURE") was recently added, but has no help text. This is most unhelpful when trying to configure the kernel, since one does not know what the effect of answering yes or no to this option would be. Please supply a proper help text when

Re: [PATCH][V2] input: ims-pcu: return error code rather than -ENOMEM

2020-06-03 Thread Dan Carpenter
On Wed, Jun 03, 2020 at 04:21:51PM +0100, Colin King wrote: > From: Colin Ian King > > Currently the assignment of -ENOMEM to error is redudant because error > is not being read and -ENOMEM is being hard coded as an error return. > Fix this by returning the error code in variable 'error'; this

Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders

2020-06-03 Thread Stefan Wahren
Am 02.06.20 um 17:54 schrieb Maxime Ripard: > On Wed, May 27, 2020 at 11:41:24AM -0700, Eric Anholt wrote: >> On Wed, May 27, 2020 at 8:51 AM Maxime Ripard wrote: >>> the vc4_hdmi driver has some custom structures to hold the data it needs to >>> associate with the drm_encoder and drm_connector

[PATCH] x86/cpu: Add Sapphire Rapids CPU model number

2020-06-03 Thread Tony Luck
Latest edition (039) of "Intel Architecture Instruction Set Extensions and Future Features Programming Reference" includes three new CPU model numbers. Linux already has the two Ice Lake server ones. Add the new model number for Sapphire Rapids. Signed-off-by: Tony Luck --- I'd appreciate this

[GIT PULL] First batch of KVM changes for Linux 5.8

2020-06-03 Thread Paolo Bonzini
Linus, The following changes since commit 655389433e7efec589838b400a2a652b3ffa: vmlinux.lds.h: Create section for protection against instrumentation (2020-05-19 15:47:20 +0200) are available in the Git repository at: https://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus for

Re: [PATCH 0/2] firmware/psci: PSCI checker cleanup

2020-06-03 Thread Valentin Schneider
On 03/06/20 18:05, Sudeep Holla wrote: > On Fri, Apr 24, 2020 at 02:56:55PM +0100, Valentin Schneider wrote: >> Hi folks, >> >> This is a small cleanup of the PSCI checker following Peter's objections >> to its homegrown do_idle() implementation. It is based on his >> sched_setscheduler()

Re: [PATCH net-next 0/5] hinic: add some ethtool ops support

2020-06-03 Thread David Miller
net-next is closed

Re: [RESEND PATCH v1 6/6] staging: greybus: audio: Enable GB codec, audio module compilation.

2020-06-03 Thread Vaibhav Agarwal
On Tue, Jun 02, 2020 at 03:57:15PM +0300, Dan Carpenter wrote: > On Tue, Jun 02, 2020 at 10:51:15AM +0530, Vaibhav Agarwal wrote: > > Currently, GB codec and audio module is conditionally compiled based on > > GREYBUS_AUDIO_MSM8994. However, audio module is not dependent on MSM8994 > > platform

Re: [PATCH v3] usb: host: xhci-mtk: avoid runtime suspend when removing hcd

2020-06-03 Thread Sergei Shtylyov
Hello. On 03.06.2020 16:09, Macpaul Lin wrote: When runtime suspend was enabled, runtime suspend might happened Happen. when xhci is removing hcd. This might cause kernel panic when hcd has been freed but runtime pm suspend related handle need to reference it. Signed-off-by: Macpaul

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-06-03 Thread Stephen Boyd
Quoting Sandeep Maheswaram (2020-03-31 22:15:43) > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > index 1dfd024..d33ae86 100644 > --- a/drivers/usb/dwc3/dwc3-qcom.c > +++ b/drivers/usb/dwc3/dwc3-qcom.c > @@ -76,8 +85,13 @@ struct dwc3_qcom { > enum usb_dr_mode

Re: [PATCH 2/2] coresight: tmc: Add shutdown callback for TMC ETR/ETF

2020-06-03 Thread Mathieu Poirier
On Wed, Jun 03, 2020 at 02:34:10PM +0100, Robin Murphy wrote: > On 2020-06-03 14:22, Mike Leach wrote: > > Hi Sai, > > > > On Wed, 3 Jun 2020 at 13:14, Sai Prakash Ranjan > > wrote: > > > > > > Hi Mike, > > > > > > On 2020-06-03 16:57, Mike Leach wrote: > > > > Hi, > > > > > > > > On Wed, 3

Re: [PATCH] nvme-fc: Only call nvme_cleanup_cmd() for normal operations

2020-06-03 Thread Himanshu Madhani
On 5/29/20 6:37 AM, Daniel Wagner wrote: Asynchronous event notifications do not have an request associated. When fcp_io() fails we unconditionally call nvme_cleanup_cmd() which leads to a crash. Fixes: 16686f3a6c3c ("nvme: move common call to nvme_cleanup_cmd to core layer") Cc: Max Gurtovoy

Re: [PATCH 0/4] marvell: Fix firmware filenames for sd8977/sd8997 chipsets

2020-06-03 Thread Marcel Holtmann
Hi Pali, > This patch series fixes mwifiex and btmrvl drivers to load firmware for sd8977 > and sd8997 chipsets from correct filename. > > Both Marvell distribution package and linux-firmware repository [1] contain > firmware for these chipsets in files >

Re: [GIT PULL] SELinux patches for v5.8

2020-06-03 Thread Linus Torvalds
On Wed, Jun 3, 2020 at 10:20 AM Casey Schaufler wrote: > > We could have inode->i_security be the blob, rather than a pointer to it. > That will have its own performance issues. It wouldn't actually really fix anything, because the inode is so big and sparsely accessed that it doesn't even

[PATCH] ovl: explicitly initialize error in ovl_copy_xattr()

2020-06-03 Thread glider
Under certain circumstances (we found this out running Docker on a Clang-built kernel with CONFIG_INIT_STACK_ALL) ovl_copy_xattr() may return uninitialized value of |error| from ovl_copy_xattr(). It is then returned by ovl_create() to lookup_open(), which casts it to an invalid dentry pointer,

[tip: x86/entry] x86/entry: Re-order #DB handler to avoid *SAN instrumentation

2020-06-03 Thread tip-bot2 for Peter Zijlstra
The following commit has been merged into the x86/entry branch of tip: Commit-ID: 6452aaf182a1deb9fda63754cf8e92353c5f49fd Gitweb: https://git.kernel.org/tip/6452aaf182a1deb9fda63754cf8e92353c5f49fd Author:Peter Zijlstra AuthorDate:Wed, 03 Jun 2020 13:40:20 +02:00

[tip: x86/entry] x86/entry: __always_inline debugreg for noinstr

2020-06-03 Thread tip-bot2 for Peter Zijlstra
The following commit has been merged into the x86/entry branch of tip: Commit-ID: c227bf005a079ad7af47f8df3cbb7c39cdbabc37 Gitweb: https://git.kernel.org/tip/c227bf005a079ad7af47f8df3cbb7c39cdbabc37 Author:Peter Zijlstra AuthorDate:Wed, 03 Jun 2020 13:40:17 +02:00

[tip: x86/entry] x86/entry: __always_inline irqflags for noinstr

2020-06-03 Thread tip-bot2 for Peter Zijlstra
The following commit has been merged into the x86/entry branch of tip: Commit-ID: 43cea329af80b327cf0981df87fc26ce35d858f8 Gitweb: https://git.kernel.org/tip/43cea329af80b327cf0981df87fc26ce35d858f8 Author:Peter Zijlstra AuthorDate:Wed, 03 Jun 2020 13:40:18 +02:00

[tip: x86/entry] x86/entry, cpumask: Provide non-instrumented variant of cpu_is_offline()

2020-06-03 Thread tip-bot2 for Peter Zijlstra
The following commit has been merged into the x86/entry branch of tip: Commit-ID: 02da62886d81c6683fbd6a09aec02b2c050d5827 Gitweb: https://git.kernel.org/tip/02da62886d81c6683fbd6a09aec02b2c050d5827 Author:Peter Zijlstra AuthorDate:Wed, 03 Jun 2020 13:40:23 +02:00

[tip: x86/entry] x86/entry: __always_inline arch_atomic_* for noinstr

2020-06-03 Thread tip-bot2 for Peter Zijlstra
The following commit has been merged into the x86/entry branch of tip: Commit-ID: c74809a9760f0d0c80ebe4e6ddcc9aebba9d90bc Gitweb: https://git.kernel.org/tip/c74809a9760f0d0c80ebe4e6ddcc9aebba9d90bc Author:Peter Zijlstra AuthorDate:Wed, 03 Jun 2020 13:40:19 +02:00

Re: [PATCH] Bluetooth: Terminate the link if pairing is cancelled

2020-06-03 Thread Marcel Holtmann
Hi Manish, > Based on your feedback, in the BlueZ kernel, if we plan to track whether the > link was created because of Pair Device action or not, we'll need to add a > flag in struch hci_conn and update related functions/APIs. I was wondering if > this would look like a clean fix or not. >

[tip: x86/entry] x86/entry: __always_inline CR2 for noinstr

2020-06-03 Thread tip-bot2 for Peter Zijlstra
The following commit has been merged into the x86/entry branch of tip: Commit-ID: 8c4d7f8109431652f469b116f2f4fd6526b01a14 Gitweb: https://git.kernel.org/tip/8c4d7f8109431652f469b116f2f4fd6526b01a14 Author:Peter Zijlstra AuthorDate:Wed, 03 Jun 2020 13:40:22 +02:00

[tip: x86/entry] lockdep: __always_inline more for noinstr

2020-06-03 Thread tip-bot2 for Peter Zijlstra
The following commit has been merged into the x86/entry branch of tip: Commit-ID: 87374bc31053b40d64dfe7199d830fb225694637 Gitweb: https://git.kernel.org/tip/87374bc31053b40d64dfe7199d830fb225694637 Author:Peter Zijlstra AuthorDate:Wed, 03 Jun 2020 13:40:21 +02:00

[tip: x86/entry] x86/entry: Use __irq_exit_rcu() in irq_exit()

2020-06-03 Thread tip-bot2 for Peter Zijlstra
The following commit has been merged into the x86/entry branch of tip: Commit-ID: 10396895ab36357e676b894d89f64667ce226150 Gitweb: https://git.kernel.org/tip/10396895ab36357e676b894d89f64667ce226150 Author:Peter Zijlstra AuthorDate:Wed, 03 Jun 2020 13:40:15 +02:00

Re: [PATCH] Bluetooth: Check scan state before disabling during suspend

2020-06-03 Thread Marcel Holtmann
Hi Manish, > Check current scan state by checking HCI_LE_SCAN flag and send scan > disable command only if scan is already enabled. > > Signed-off-by: Manish Mandlik > --- > > net/bluetooth/hci_request.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) patch has been applied

Re: headers_install builds break on a lot of targets?

2020-06-03 Thread Arnd Bergmann
On Wed, Jun 3, 2020 at 7:04 PM Rich Felker wrote: > On Wed, Jun 03, 2020 at 08:49:54AM -0500, Rob Landley wrote: > > make ARCH=$i distclean defconfig headers_install \ > > > > On the bright side, the resulting fruitbasket.tar.xz is 1.5 megabytes. The > > downside is I have no idea how broken

Re: [PATCH v1 2/7] Bluetooth: Add handler of MGMT_OP_READ_ADV_MONITOR_FEATURES

2020-06-03 Thread Marcel Holtmann
Hi Miao-chen, > This adds the request handler of MGMT_OP_READ_ADV_MONITOR_FEATURES > command. Since the controller-based monitoring is not yet in place, this > report only the supported features but not the enabled features. > > The following test was performed. > - Issuing btmgmt

Re: [PATCH v3] iio: amplifiers: ad8366: Change devm_gpiod_get() to optional and add the missed check

2020-06-03 Thread Markus Elfring
> Since if there is no GPIO, nothing happens, replace devm_gpiod_get() > with devm_gpiod_get_optional(). … > +++ b/drivers/iio/amplifiers/ad8366.c > @@ -262,8 +262,12 @@ static int ad8366_probe(struct spi_device *spi) … > case ID_HMC1119: > - st->reset_gpio =

Re: v5.7: new core kernel option missing help text

2020-06-03 Thread Valentin Schneider
On 03/06/20 18:31, Russell King - ARM Linux admin wrote: > Hi, > > A new kernel configuration option ("SCHED_THERMAL_PRESSURE") was > recently added, but has no help text. This is most unhelpful when > trying to configure the kernel, since one does not know what the > effect of answering yes or

Re: [PATCH] lan743x: Added fixed link and RGMII support / debugging

2020-06-03 Thread Andrew Lunn
On Wed, Jun 03, 2020 at 06:36:28PM +0200, Roelof Berg wrote: > If I find a fix, would I need to submit a delta patch (to our last one) or a > full patch ? A delta. Andrew

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-03 Thread Sudeep Holla
On Fri, May 29, 2020 at 09:37:58AM +0530, Viresh Kumar wrote: > On 28-05-20, 13:20, Rob Herring wrote: > > Whether Linux > > requires serializing mailbox accesses is a separate issue. On that side, > > it seems silly to not allow driving the h/w in the most efficient way > > possible. > > That's

Re: kobject_init_and_add is easy to misuse

2020-06-03 Thread James Bottomley
On Tue, 2020-06-02 at 21:22 -0300, Jason Gunthorpe wrote: > On Tue, Jun 02, 2020 at 02:51:10PM -0700, James Bottomley wrote: > > > My first thought was "what? I got suckered into creating a patch", > > thanks ;-) But now I look, all the error paths do unwind back to > > the initial state, so

Re: [GIT PULL] SELinux patches for v5.8

2020-06-03 Thread Casey Schaufler
On 6/3/2020 10:37 AM, Linus Torvalds wrote: > On Wed, Jun 3, 2020 at 10:20 AM Casey Schaufler > wrote: >> We could have inode->i_security be the blob, rather than a pointer to it. >> That will have its own performance issues. > It wouldn't actually really fix anything, because the inode is so

Re: [PATCH] lan743x: Added fixed link and RGMII support / debugging

2020-06-03 Thread Andrew Lunn
On Wed, Jun 03, 2020 at 06:33:28PM +0200, Roelof Berg wrote: > Ok, let's proceed :) The code runs well, dmesg looks good, ip addr shows me a > link up, speed/duplex looks ok. But it does not transfer any data. > > Debugging steps (A/B versions): > - Check clocks with oscilloscope (10/100/1000) >

[tip: x86/urgent] x86/cpu: Add Sapphire Rapids CPU model number

2020-06-03 Thread tip-bot2 for Tony Luck
The following commit has been merged into the x86/urgent branch of tip: Commit-ID: be25d1b5ea6a3a3ecbb5474e2ae8e32d2ba055ea Gitweb: https://git.kernel.org/tip/be25d1b5ea6a3a3ecbb5474e2ae8e32d2ba055ea Author:Tony Luck AuthorDate:Wed, 03 Jun 2020 10:33:52 -07:00 Committer:

Re: [PATCH 08/10] clk: qcom: Add graphics clock controller driver for SM8250

2020-06-03 Thread Bjorn Andersson
On Thu 28 May 23:56 PDT 2020, Sai Prakash Ranjan wrote: > Hi Bjorn, > > On 2020-05-29 06:41, Bjorn Andersson wrote: > > On Mon 25 May 02:47 PDT 2020, Sai Prakash Ranjan wrote: > > > > > Hi Jonathan, > > > > > > On 2020-05-25 02:36, Jonathan Marek wrote: > > > > Add support for the graphics

Re: [PATCH] rcu/performance: Fix kfree_perf_init() build warning on 32-bit kernels

2020-06-03 Thread Paul E. McKenney
On Tue, May 26, 2020 at 09:14:13PM -0400, Joel Fernandes wrote: > On Tue, May 26, 2020 at 08:27:44PM +0200, Ingo Molnar wrote: > [...] > > ./include/linux/kern_levels.h:5:18: warning: format ‘%lu’ expects argument > > of type ‘long unsigned int’, but argument 2 has type ‘unsigned int’ > >

Re: [RESEND PATCH v9 4/5] ndctl/papr_scm,uapi: Add support for PAPR nvdimm specific methods

2020-06-03 Thread Vaibhav Jain
Hi Ira, Thanks for reviewing this patch. My responses below: Ira Weiny writes: > On Tue, Jun 02, 2020 at 03:44:37PM +0530, Vaibhav Jain wrote: >> Introduce support for PAPR NVDIMM Specific Methods (PDSM) in papr_scm >> module and add the command family NVDIMM_FAMILY_PAPR to the white list >>

Re: [PATCH bpf] bpf: fix unused-var without NETDEVICES

2020-06-03 Thread Alexei Starovoitov
On Wed, Jun 03, 2020 at 11:12:01AM +0200, Matthieu Baerts wrote: > Hi Ferenc, > > On 03/06/2020 10:56, Ferenc Fejes wrote: > > Matthieu Baerts ezt írta (időpont: > > 2020. jún. 3., Sze, 10:11): > > > > > > A recent commit added new variables only used if CONFIG_NETDEVICES is > > > set. > > > >

Re: [GIT pull] x86/timers for v5.8

2020-06-03 Thread pr-tracker-bot
The pull request you sent on Wed, 03 Jun 2020 15:08:43 -: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > x86-timers-2020-06-03 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/f6aee505c71bbb035dde146caf5a6abbf3ccbe47 Thank you! -- Deet-doot-dot, I

Re: [GIT pull] timers/core for v5.8

2020-06-03 Thread pr-tracker-bot
The pull request you sent on Tue, 02 Jun 2020 12:08:10 -: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > timers-core-2020-06-02 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/dabc4df27c628866ede130a09121f255ca894d8c Thank you! -- Deet-doot-dot,

Re: [GIT pull] irq/core for v5.8

2020-06-03 Thread pr-tracker-bot
The pull request you sent on Tue, 02 Jun 2020 12:08:09 -: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq-core-2020-06-02 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/f6606d0c0010953e4c28c8662623662b5108b4ce Thank you! -- Deet-doot-dot, I am a

Re: [PATCH 0/9] x86/entry fixes

2020-06-03 Thread Peter Zijlstra
On Wed, Jun 03, 2020 at 06:07:22PM +0200, Peter Zijlstra wrote: > On Wed, Jun 03, 2020 at 04:47:54PM +0200, Marco Elver wrote: > > With that in mind, you could whitelist "__ubsan_handle"-prefixed > > functions in objtool. Given the __always_inline+noinstr+__ubsan_handle > > case is quite rare, it

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-03 Thread Sudeep Holla
On Wed, Jun 03, 2020 at 07:04:35PM +0100, Sudeep Holla wrote: > On Fri, May 29, 2020 at 09:37:58AM +0530, Viresh Kumar wrote: > > On 28-05-20, 13:20, Rob Herring wrote: > > > Whether Linux > > > requires serializing mailbox accesses is a separate issue. On that side, > > > it seems silly to not

Re: [PATCH][next] dm zoned: fix memory leak of newly allocated zone on xa_insert failure

2020-06-03 Thread Mike Snitzer
On Wed, Jun 03 2020 at 12:02pm -0400, Colin King wrote: > From: Colin Ian King > > Currently if an xa_insert fails then there is a memory lead of the > recently allocated zone object. Fix this by kfree'ing zone before > returning on the error return path. > > Addresses-Coverity: ("Resource

Re: [PATCH 08/10] clk: qcom: Add graphics clock controller driver for SM8250

2020-06-03 Thread Sai Prakash Ranjan
Hi Bjorn, On 2020-06-03 23:39, Bjorn Andersson wrote: On Thu 28 May 23:56 PDT 2020, Sai Prakash Ranjan wrote: Hi Bjorn, On 2020-05-29 06:41, Bjorn Andersson wrote: > On Mon 25 May 02:47 PDT 2020, Sai Prakash Ranjan wrote: > > > Hi Jonathan, > > > > On 2020-05-25 02:36, Jonathan Marek wrote:

[PATCH v2 0/4] selftests/livepatch: rework of test-klp-{callbacks,shadow_vars}

2020-06-03 Thread Yannick Cote
v2: - drop completion variables and flush workqueue [pmladek] - comment typo/pr_info cleanup [kbabulal/mbenes] - cleanup goto ret assignations [pmladek] - allocate pndup[]'s, leave some svar allocations to shadow_get_or_alloc() [pmladek] - change allocation order for cleaner test dmesg

[PATCH v2 1/4] selftests/livepatch: simplify test-klp-callbacks busy target tests

2020-06-03 Thread Yannick Cote
From: Joe Lawrence The test-klp-callbacks script includes a few tests which rely on kernel task timings that may not always execute as expected under system load. These may generate out of sequence kernel log messages that result in test failure. Instead of using sleep timing windows to

[PATCH v2 4/4] selftests/livepatch: fix mem leaks in test-klp-shadow-vars

2020-06-03 Thread Yannick Cote
In some cases, when an error occurs during testing and the main test routine returns, a memory leak occurs via leaving previously registered shadow variables allocated in the kernel as well as shadow_ptr list elements. From now on, in case of error, remove all allocated shadow variables and

[PATCH v2 2/4] selftests/livepatch: rework test-klp-shadow-vars

2020-06-03 Thread Yannick Cote
The initial idea was to make a change to please cppcheck and remove void pointer arithmetics found a few times: portability: 'obj' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined.

[PATCH v2 3/4] selftests/livepatch: more verification in test-klp-shadow-vars

2020-06-03 Thread Yannick Cote
This change makes the test feel more familiar with narrowing to a typical usage by operating on a number of identical structure instances and populating the same two new shadow variables symmetrically while keeping the same testing and verification criteria for the extra variables. Reviewed-by:

Re: [PATCH] media: budget-core: Improve exception handling in budget_register()

2020-06-03 Thread Markus Elfring
> Add the missed undo functions for error handling to fix it. … > +++ b/drivers/media/pci/ttpci/budget-core.c > @@ -369,20 +369,25 @@ static int budget_register(struct budget *budget) … > return 0; > + +err: > + dvb_dmxdev_release(>dmxdev); > + dvb_dmx_release(>demux); > +

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-03 Thread Sudeep Holla
Hi Bjorn, Thanks for the details response. On Mon, May 18, 2020 at 06:29:27PM -0700, Bjorn Andersson wrote: > On Thu 14 May 22:17 PDT 2020, Viresh Kumar wrote: > [...] I find this part nicely summarise your response. > > - With serialization, if we use only one channel as today at every > >

[PATCH] dmaengine: stm32-mdma: call pm_runtime_put if pm_runtime_get_sync fails

2020-06-03 Thread Navid Emamdoost
Calling pm_runtime_get_sync increments the counter even in case of failure, causing incorrect ref count. Call pm_runtime_put if pm_runtime_get_sync fails. Signed-off-by: Navid Emamdoost --- drivers/dma/stm32-mdma.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] lan743x: Added fixed link and RGMII support / debugging

2020-06-03 Thread Roelof Berg
I’m testing with Microchip Lan7430, which is an integrated circuit that contains MAC and PHY in one package. With the release kernel the hardware works fine, so the overall configuration is ok (jumpers). I will verify wether the effective RGMII and delay settings, you mention, are equal in

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-03 Thread Sudeep Holla
On Mon, May 18, 2020 at 11:05:03PM -0500, Jassi Brar wrote: > On Mon, May 18, 2020 at 10:40 PM Viresh Kumar wrote: > > > > On 18-05-20, 18:29, Bjorn Andersson wrote: > > > On Thu 14 May 22:17 PDT 2020, Viresh Kumar wrote: > > > > This stuff has been doing rounds on the mailing list since several

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-03 Thread Jassi Brar
On Wed, Jun 3, 2020 at 1:04 PM Sudeep Holla wrote: > > On Fri, May 29, 2020 at 09:37:58AM +0530, Viresh Kumar wrote: > > On 28-05-20, 13:20, Rob Herring wrote: > > > Whether Linux > > > requires serializing mailbox accesses is a separate issue. On that side, > > > it seems silly to not allow

[PATCH] engine: stm32-dma: call pm_runtime_put if pm_runtime_get_sync fails

2020-06-03 Thread Navid Emamdoost
Calling pm_runtime_get_sync increments the counter even in case of failure, causing incorrect ref count. Call pm_runtime_put if pm_runtime_get_sync fails. Signed-off-by: Navid Emamdoost --- drivers/dma/stm32-dma.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

Re: kobject_init_and_add is easy to misuse

2020-06-03 Thread Jason Gunthorpe
On Wed, Jun 03, 2020 at 11:04:35AM -0700, James Bottomley wrote: > On Tue, 2020-06-02 at 21:22 -0300, Jason Gunthorpe wrote: > > On Tue, Jun 02, 2020 at 02:51:10PM -0700, James Bottomley wrote: > > > > > My first thought was "what? I got suckered into creating a patch", > > > thanks ;-) But now

Re: [PATCH v4 1/4] riscv: Move kernel mapping to vmalloc zone

2020-06-03 Thread kernel test robot
Hi Alexandre, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on powerpc/next] [also build test WARNING on linus/master v5.7 next-20200603] [cannot apply to mpe/next atish-riscv-linux/topo_v3] [if your patch is applied to the wrong git tree, please drop us a note

RE: [PATCHES] uaccess hpsa

2020-06-03 Thread Don.Brace
-Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Al Viro Sent: Friday, May 29, 2020 6:39 PM To: Linus Torvalds Cc: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; Don Brace ; linux-s...@vger.kernel.org Subject:

[PATCH] dmaengine: tegra210-adma: fix pm_runtime_get_sync failure

2020-06-03 Thread Navid Emamdoost
Calling pm_runtime_get_sync increments the counter even in case of failure, causing incorrect ref count. Call pm_runtime_put if pm_runtime_get_sync fails. Signed-off-by: Navid Emamdoost --- drivers/dma/tegra210-adma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] usb: usbtest: fix missing kfree(dev->buf) in usbtest_disconnect

2020-06-03 Thread Alan Stern
On Wed, Jun 03, 2020 at 11:05:06AM +0800, qiang.zh...@windriver.com wrote: > From: Zqiang > > BUG: memory leak > unreferenced object 0x888055046e00 (size 256): > comm "kworker/2:9", pid 2570, jiffies 4294942129 (age 1095.500s) > hex dump (first 32 bytes): > 00 70 04 55 80 88 ff ff 18

<    3   4   5   6   7   8   9   10   11   12   >