The Jitter RNG fast noise source implemented as part of the kernel
crypto API is queried for 256 bits of entropy at the time the seed
buffer managed by the LRNG is about to be filled.
CC: "Eric W. Biederman"
CC: "Alexander E. Patrakov"
CC: "Ahmed S. Darwish"
CC: "Theodore Y. Ts'o"
CC: Willy
To support the LRNG operation which uses the Jitter RNG separately
from the kernel crypto API, at a time where potentially the regular
memory management is not yet initialized, the Jitter RNG needs to
provide a state whose memory is defined at compile time. As only once
instance will ever be
In an effort to provide a flexible implementation for a random number
generator that also delivers entropy during early boot time, allows
replacement of the deterministic random number generation mechanism,
implement the various components in separate code for easier
maintenance, and provide
In order to improve NUMA-locality when serving getrandom(2) requests,
allocate one DRNG instance per node.
The DRNG instance that is present right from the start of the kernel is
reused as the first per-NUMA-node DRNG. For all remaining online NUMA
nodes a new DRNG instance is allocated.
During
This patch allows several DRBG functions to be called by the LRNG kernel
code paths outside the drbg.c file.
CC: "Eric W. Biederman"
CC: "Alexander E. Patrakov"
CC: "Ahmed S. Darwish"
CC: "Theodore Y. Ts'o"
CC: Willy Tarreau
CC: Matthew Garrett
CC: Vito Caputo
CC: Andreas Dilger
CC: Jan
From: Joonsoo Kim
There is a well-defined standard migration target callback. Use it
directly.
Acked-by: Vlastimil Babka
Signed-off-by: Joonsoo Kim
---
mm/memory-failure.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/mm/memory-failure.c
From: Joonsoo Kim
There is a well-defined migration target allocation callback. Use it.
Acked-by: Michal Hocko
Acked-by: Vlastimil Babka
Signed-off-by: Joonsoo Kim
---
mm/internal.h | 1 -
mm/mempolicy.c | 31 ++-
mm/migrate.c | 8 ++--
3 files changed,
From: Joonsoo Kim
It's not performance sensitive function. Move it to .c. This is a
preparation step for future change.
Acked-by: Mike Kravetz
Acked-by: Michal Hocko
Reviewed-by: Vlastimil Babka
Signed-off-by: Joonsoo Kim
---
include/linux/migrate.h | 33 +
From: Joonsoo Kim
To calculate the correct node to migrate the page for hotplug, we need
to check node id of the page. Wrapper for alloc_migration_target() exists
for this purpose.
However, Vlastimil informs that all migration source pages come from
a single node. In this case, we don't need to
From: Joonsoo Kim
This patchset clean-up the migration target allocation functions.
* Changes on v5
- remove new_non_cma_page() related patches
(implementation for memalloc_nocma_{save,restore} has a critical bug that
cannot exclude CMA memory in some cases so cannot use them here. Need to
fix
From: Joonsoo Kim
For locality, it's better to migrate the page to the same node rather than
the node of the current caller's cpu.
Acked-by: Roman Gushchin
Acked-by: Michal Hocko
Reviewed-by: Vlastimil Babka
Signed-off-by: Joonsoo Kim
---
mm/page_isolation.c | 4 +++-
1 file changed, 3
From: Joonsoo Kim
new_page_nodemask is a migration callback and it tries to use a common
gfp flags for the target page allocation whether it is a base page or a
THP. The later only adds GFP_TRANSHUGE to the given mask. This results
in the allocation being slightly more aggressive than necessary
From: Joonsoo Kim
There is no difference between two migration callback functions,
alloc_huge_page_node() and alloc_huge_page_nodemask(), except
__GFP_THISNODE handling. It's redundant to have two almost similar
functions in order to handle this flag. So, this patch tries to
remove one by
From: Joonsoo Kim
There are some similar functions for migration target allocation. Since
there is no fundamental difference, it's better to keep just one rather
than keeping all variants. This patch implements base migration target
allocation function. In the following patches, variants will
From: Joonsoo Kim
There is a well-defined standard migration target callback. Use it
directly.
Acked-by: Michal Hocko
Acked-by: Vlastimil Babka
Signed-off-by: Joonsoo Kim
---
mm/page_alloc.c | 8 ++--
mm/page_isolation.c | 10 --
2 files changed, 6 insertions(+), 12
On Mon, 13 Jul 2020 07:46:35 +0200,
Vasily Khoruzhick wrote:
>
> Add hw monitor volume control for POD HD500. The same change may
> work for HD500X but I don't have it to test.
>
> Signed-off-by: Vasily Khoruzhick
> ---
> v3: - use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL
> - use
On 08-07-20, 18:58, Vinod Koul wrote:
> We get warning with W=1 build:
> drivers/phy/marvell/phy-mvebu-a3700-utmi.c:84: warning: Function
> parameter or member 'usb_misc' not described in 'mvebu_a3700_utmi'
Applied all now
--
~Vinod
On 2020-07-13 11:14 +0530, Suraj Upadhyay wrote:
> On Mon, Jul 13, 2020 at 01:59:59PM +0900, Benjamin Poirier wrote:
> > On 2020-07-11 18:16 +0530, Suraj Upadhyay wrote:
> > > The legacy API wrappers in include/linux/pci-dma-compat.h
> > > should go away as it creates unnecessary midlayering
> > >
Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.
Deterministic algorithm:
For each file:
If not .svg:
For each line:
If doesn't contain `\bxmlns\b`:
For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
On Mon, Jul 06, 2020 at 04:44:41PM +0800, Richard Zhu wrote:
> Since iMX6Q/DL PCIe has the PM limitation (ERR005723 "PCIe PCIe does
> not support L2 Power Down").
> System suspend/resume would be broken by PCIe, if PCIe is enabled.
> Only enable PCIe in the xxx-pcie.dts files to avoid the brokens
On Mon, 13 Jul 2020 08:04:22 +0200,
Jian-Hong Pan wrote:
>
> The Acer TravelMate B311R-31 laptop's audio (1025:1430) with ALC256
> cannot detect the headset microphone until
> ALC256_FIXUP_ACER_MIC_NO_PRESENCE quirk maps the NID 0x19 as the headset
> mic pin.
>
> Signed-off-by: Jian-Hong Pan
Use readl_poll_timeout() to poll register status
Cc: Florian Fainelli
Signed-off-by: Chunfeng Yun
Reviewed-by: Florian Fainelli
---
v3 changes:
1. indent code to match open parenthesis suggested by Florian
2. add Reviewed-by Florian
v2 changes, suggested by Stephen:
1. use unsigned int
On 10-07-20, 12:38, Serge Semin wrote:
> On Fri, Jul 10, 2020 at 11:45:03AM +0300, Andy Shevchenko wrote:
> > On Fri, Jul 10, 2020 at 01:45:44AM +0300, Serge Semin wrote:
> > > There are DMA devices (like ours version of Synopsys DW DMAC) which have
> > > DMA capabilities non-uniformly
On Fri, 10 Jul 2020, Matthias Brugger wrote:
>
>
> On 07/07/2020 12:30, Gene Chen wrote:
> > From: Gene Chen
> >
> > Rearrange include file.
> > Remove brackets around raw numbers.
> > Indicate sub-dev compatible name by using "-"
> > Combine mt6360 pmic/ldo resouces into mt6360 regulator
On Mon, 2020-07-13 at 08:38 +0800, Nicolas Boichat wrote:
> On Sat, Jul 11, 2020 at 2:50 PM Yong Wu wrote:
> >
> > As title.
> >
> > Signed-off-by: Yong Wu
> > ---
> > drivers/iommu/io-pgtable-arm-v7s.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
On Mon, Jul 13, 2020 at 1:02 AM syzbot
wrote:
>
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit:4437dd6e Merge tag 'io_uring-5.8-2020-07-12' of git://git...
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=17183f0b10
> kernel config:
On Mon, 2020-07-13 at 13:36 +0800, Pi-Hsun Shih wrote:
> On Sat, Jul 11, 2020 at 2:50 PM Yong Wu wrote:
> >
> > This patch adds decriptions for mt8192 IOMMU and SMI.
> >
> > mt8192 also is MTK IOMMU gen2 which uses ARM Short-Descriptor translation
> > table format. The M4U-SMI HW diagram is as
On Sun, 2020-07-12 at 20:53 -0700, Florian Fainelli wrote:
>
> On 7/12/2020 8:30 PM, Chunfeng Yun wrote:
> > Use readl_poll_timeout() to poll register status
> >
> > Cc: Florian Fainelli
> > Signed-off-by: Chunfeng Yun
> > ---
> > v2 changes, suggested by Stephen:
> > 1. use unsigned int
On Tue, Jul 07, 2020 at 06:51:00PM -0300, Fabio Estevam wrote:
> Hi Chris,
>
> On Tue, Jul 7, 2020 at 6:15 PM Chris Healy wrote:
> >
> > From: Andrey Smirnov
> >
> > Add node for CAAM device in NXP Vybrid SoC.
> >
> > Signed-off-by: Andrey Smirnov
> > Signed-off-by: Chris Healy
> >
> > v2:
>
Hi all,
Today's linux-next merge of the pidfd tree got a conflict in:
arch/riscv/Kconfig
between commit:
95ce6c73da3b ("riscv: Enable context tracking")
929f6a183839 ("riscv: Add kmemleak support")
from the risc-v tree and commit:
140c8180eb7c ("arch: remove HAVE_COPY_THREAD_TLS")
Hi Dan,
On Sun, Jul 12, 2020 at 09:26:43AM -0700, Dan Williams wrote:
> For architectures that opt into storing their numa data in memblock
> (only ARM64 currently), add a memblock generic way to interrogate that
> data for memory_add_physaddr_to_nid(). This requires ARCH_KEEP_MEMBLOCK
> to keep
Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.
Deterministic algorithm:
For each file:
If not .svg:
For each line:
If doesn't contain `\bxmlns\b`:
For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
Add the Khadas MCU node with active FAN thermal nodes for all the
Khadas VIM3 variants.
Signed-off-by: Neil Armstrong
Reviewed-by: Amit Kucheria
---
Hi Kevin,
The bindings has been reviewed and merged by Lee,
could you apply this one via the amlogic tree ?
Thanks,
Neil
On Sat, Jul 11, 2020 at 2:51 PM Yong Wu wrote:
>
> In the previous SoC, the M4U HW is in the EMI power domain which is
> always on. the latest M4U is in the display power domain which may be
> turned on/off, thus we have to add pm_runtime interface for it.
>
> we should enable its power before
Hello,
syzbot found the following crash on:
HEAD commit:a581387e Merge tag 'io_uring-5.8-2020-07-10' of git://git...
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=13e730eb10
kernel config: https://syzkaller.appspot.com/x/.config?x=66ad203c2bb6d8b
Hi Dan,
On Sun, Jul 12, 2020 at 09:26:48AM -0700, Dan Williams wrote:
> Similar to how generic memory_add_physaddr_to_nid() interrogates
> memblock data for numa information, introduce
> get_reserved_pfn_range_from_nid() to enable the same operation for
> reserved memory ranges. Example memory
Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.
Deterministic algorithm:
For each file:
If not .svg:
For each line:
If doesn't contain `\bxmlns\b`:
For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
On Tue, Jul 07, 2020 at 03:40:31PM +0800, Ran Wang wrote:
> ls1043a-rdb and ls1043a-qds board’s default HW config (such as
> pin mux selection) would not enable some USB controllers’
> data path, which causing over-current detected on those
> controllers. This will hit the case of ‘xhci driver
On Mon, 13 Jul 2020 at 03:28, Mikhail Gavrilov
wrote:
>
> Hi folks.
> While testing 5.8 RCs I founded that kernel log flooded by the message
> "WARNING: CPU: 28 PID: 211236 at fs/fuse/file.c:1684 tree
> insert+0xaf/0xc0 [fuse]" when I start podman container.
> In kernel 5.7 not has such a
When vlan_newlink call register_vlan_dev fails, it might return error
with dev->reg_state = NETREG_UNREGISTERED. The rtnl_newlink should
free the memory. But currently rtnl_newlink only free the memory which
state is NETREG_UNINITIALIZED.
BUG: memory leak
unreferenced object 0x8881051de000
Hi Enric,
On 7/9/20 6:05 PM, Enric Balletbo i Serra wrote:
> The Rockchip DMC (Dynamic Memory Interface) needs to access to the PMU
> general register files to know the DRAM type, so add a phandle to the
> syscon that manages these registers.
>
> Signed-off-by: Enric Balletbo i Serra
>
On Mon 2020-07-13 01:18:41, Marek Behun wrote:
> On Mon, 13 Jul 2020 01:15:44 +0200
> Marek Behun wrote:
>
> > On Mon, 13 Jul 2020 00:38:21 +0200
> > Ondřej Jirman wrote:
> >
> > > So after trying to use this, this seems to disallow the use of multiple HW
> > > triggers per LED. That's fine by
On Sun, Jul 12, 2020 at 10:22:50PM -0700, Joe Perches wrote:
> Right now, a little less than half of the .dts* files
> have an author or other email address in them.
>
> $ git ls-files arch/arm/boot/dts/*.dts* | wc -l
> 2105
>
> $ git grep -P --name-only '<\S+@\S+>' arch/arm/boot/dts/*.dts* | wc
Dear all,
On 7/9/20 2:45 PM, Chanwoo Choi wrote:
> Add the delayed timer to devfreq framework in order to support
> the periodical polling mode without stop caused by CPU idle state.
> Some Non-CPU device must need to monitor the device status like
> utilization regardless of CPU state.
>
> -
On 11.07.20 15:40, Shawn Guo wrote:
> On Wed, Jun 17, 2020 at 09:38:21AM +0200, Martin Kepplinger wrote:
>> Add development information for the devicetree files for hardware
>> by Purism SPC.
>>
>> Signed-off-by: Martin Kepplinger
>> ---
>> MAINTAINERS | 7 +++
>> 1 file changed, 7
syzbot has found a reproducer for the following crash on:
HEAD commit:4437dd6e Merge tag 'io_uring-5.8-2020-07-12' of git://git...
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=13a4773f10
kernel config:
From: SeongJae Park
# NOTE: this patch is based on next/master, as this is a followup of
# commit 0d8b43e5876a ("scripts/deprecated_terms: recommend
# denylist/allowlist instead of blacklist/whitelist"), which merged in
# next tree only.
Commit a5f526ecb075 ("CodingStyle: Inclusive
The commit 66d0e797bf09 ("Revert "PM / devfreq: Modify the device name
as devfreq(X) for sysfs"") roll back the device name from 'devfreqX'
to device name explained in DT. After applied commit 66d0e797bf09,
the indentation of devfreq_summary debugfs node was broken.
So, fix indentaion of
Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.
Deterministic algorithm:
For each file:
If not .svg:
For each line:
If doesn't contain `\bxmlns\b`:
For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
This patch fixes the checkpatch.pl error:
ERROR: code indent should use tabs where possible
Signed-off-by: Baidyanath Kundu
---
.../staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
When booting Linux on an Amiga with BigRAMPlus Zorro expansion board:
zorro: Address space collision on device Zorro device 12128600 (Individual
Computers) [??? 0x5000-]
This happens because the address space occupied by the BigRAMPlus Zorro
device is already in use, as it is part of
On Fri, Jul 10, 2020 at 20:37 AM Oded Gabbay wrote:
> Currently the driver halts the device CPU in the halt engines function,
> which halts all the engines of the ASIC. The problem is that if later on we
> stop the reset process (due to inability to clean memory mappings in time),
> the CPU will
On Mon, 2020-07-13 at 15:13 +0800, Shawn Guo wrote:
> On Sun, Jul 12, 2020 at 10:22:50PM -0700, Joe Perches wrote:
[]
> > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
[]
> > @@ -436,7 +436,7 @@ sub maintainers_in_file {
> >
> > return if ($file =~ m@\bMAINTAINERS$@);
>
On Sun, Jul 12, 2020 at 23:46 Oded Gabbay wrote:
> Queue index is received from the user. Therefore, we must validate it before
> using it to access the queue props array.
>
> Signed-off-by: Oded Gabbay
Reviewed-by: Tomer Tayar
On Thursday 09 July 2020 22:29:42 Andy Shevchenko wrote:
> On Wed, Jun 10, 2020 at 10:23 PM wrote:
> >
> > > -Original Message-
> > > From: Y Paritcher
> > > Sent: Wednesday, June 10, 2020 12:57 PM
> > > To: Pali Rohár
> > > Cc: linux-kernel@vger.kernel.org;
On 13/07/2020 04:54, Stephen Rothwell wrote:
> Hi all,
>
> After merging the net-next tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> net/bridge/br_netlink_tunnel.c: In function '__vlan_tunnel_handle_range':
> net/bridge/br_netlink_tunnel.c:271:26: error:
Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.
Deterministic algorithm:
For each file:
If not .svg:
For each line:
If doesn't contain `\bxmlns\b`:
For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
Den man. 13. jul. 2020 kl. 09.26 skrev Joe Perches :
>
> On Mon, 2020-07-13 at 15:13 +0800, Shawn Guo wrote:
> > On Sun, Jul 12, 2020 at 10:22:50PM -0700, Joe Perches wrote:
> []
> > > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> []
> > > @@ -436,7 +436,7 @@ sub
On 03/07/2020 16:18, Leonardo Bras wrote:
> On LoPAR "DMA Window Manipulation Calls", it's recommended to remove the
> default DMA window for the device, before attempting to configure a DDW,
> in order to make the maximum resources available for the next DDW to be
> created.
>
> This is a
On Sat, Jul 11, 2020 at 2:51 PM Yong Wu wrote:
>
> For multiple iommu_domains, we need to reserve some iova regions, so we
> will add mtk_iommu_iova_region structure. It includes the base address
> and size of the range.
> This is a preparing patch for supporting multi-domain.
>
> Signed-off-by:
On Tue, Jul 07, 2020 at 05:25:00PM -0700, Chris Healy wrote:
> Update MDIO configuration with ZII devices to fully utilize
> MDIO endpoint capabilities. All devices support 12.5MHz clock and
> don't require MDIO preable.
>
> Signed-off-by: Chris Healy
> Reviewed-by: Fabio Estevam
> ---
> v2:
>
On Mon 13-07-20 15:41:52, Joonsoo Kim wrote:
> From: Joonsoo Kim
>
> new_page_nodemask is a migration callback and it tries to use a common
> gfp flags for the target page allocation whether it is a base page or a
> THP. The later only adds GFP_TRANSHUGE to the given mask. This results
> in the
On Sat, Jul 11, 2020 at 12:49:23PM +0200, Dominique Martinet wrote:
> > >diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c
> > >index 13cd683a658ab6..1cd8ea0e493617 100644
> > >--- a/net/9p/trans_fd.c
> > >+++ b/net/9p/trans_fd.c
> > >@@ -803,20 +803,28 @@ static int p9_fd_open(struct p9_client
Hi Greg,
in my filesystem set_fs removel series I convert the seq_file interface
to be iov_iter based. It turns out debugfs needs this little patch
to proxy read_iter as well. Let me know if you are ok with me queueing
this up with the rest of the series.
Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.
Deterministic algorithm:
For each file:
If not .svg:
For each line:
If doesn't contain `\bxmlns\b`:
For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
debugfs registrations typically go through a set of proxy ops to deal
with refcounting, which need to support every method that can be
supported. Add ->read_iter to the proxy ops to prepare for seq_file to
be switch to ->read_iter.
Reported-by: Jon Hunter
Signed-off-by: Christoph Hellwig
---
Instead of a busy waiting while loop using udelay
use readl_poll_timeout function to check the condition
is met or timeout occurs in crport_handshake function.
readl_poll_timeout is called in non atomic context so
it safe to sleep until the condition is met.
Fixes: d8c80bb3b55b ("phy:
- Ursprüngliche Mail -
> Von: "richard"
> An: "linux-kernel"
> CC: t...@kernel.org, "Greg Kroah-Hartman" ,
> ebied...@xmission.com, "dan j williams"
> , "richard"
> Gesendet: Samstag, 4. Juli 2020 22:56:19
> Betreff: [PATCH] [RFC] kernfs: Allow vm_ops->close() if VMA is never split
>
On Fri, 2020-07-10 at 14:14 +0200, Matthias Brugger wrote:
>
[snip]
> > +
> > +static int get_vio_slave_num(int slave_type)
>
> I have a hard time to understand the usefullness of this, can you please
> explain.
>
The basic idea is to get total numbers of slaves. And we can use it to
scan all
This patch adds the Realtek 8822CE controller to the usb_device_id
table to support the wideband speech capability.
Reviewed-by: ala...@chromium.org
Signed-off-by: Joseph Hwang
---
Changes in v2:
- Fixed the commit subject and message body.
drivers/bluetooth/btusb.c | 4
1 file changed,
A couple of headers make no attempt to document their associated function
parameters. Others looks as if they are suffering with a little bitrot.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/fcoe/fcoe.c:654: warning: Function parameter or member 'lport'
not described in
Fixes the following W=1 kernel build warning(s):
drivers/scsi/libfc/fc_exch.c:66: warning: Function parameter or member 'left'
not described in 'fc_exch_pool'
drivers/scsi/libfc/fc_exch.c:66: warning: Function parameter or member 'right'
not described in 'fc_exch_pool'
Mostly missing or incorrect (bitrotted) function parameters.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/fcoe/fcoe_ctlr.c:139: warning: Function parameter or member
'mode' not described in 'fcoe_ctlr_init'
drivers/scsi/fcoe/fcoe_ctlr.c:604: warning: Function parameter or
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Slowly working through the SCSI related ones. There are many.
Change-log:
v1 => v2
- Collected *-by tags
- Squashed patch 13 => 11
-
Fixes the following W=1 kernel build warning(s):
drivers/scsi/qedf/qedf_io.c: In function ‘qedf_cmd_timeout’:
drivers/scsi/qedf/qedf_io.c:25:5: warning: variable ‘op’ set but not used
[-Wunused-but-set-variable]
25 | u8 op = 0;
| ^~
drivers/scsi/qedf/qedf_io.c: In function ‘qedf_map_sg’:
And a few missing/excessive parameter descriptions.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/aachba.c:358: warning: Function parameter or member 'dev'
not described in 'aac_get_config_status'
drivers/scsi/aacraid/aachba.c:358: warning: Function parameter or member
Kerneldoc function parameter references need to be in the format '@.*: ',
else the kerneldoc checker gets confused.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/qla4xxx/ql4_init.c: In function ‘ql4xxx_set_mac_number’:
drivers/scsi/qla4xxx/ql4_init.c:17:10: warning: variable
Looks like checking the 'targ' was removed in 2005.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_send_async’:
drivers/scsi/aic7xxx/aic7xxx_osm.c:1604:28: warning: variable ‘targ’ set but
not used [-Wunused-but-set-variable]
1604 |
Function parameters need to be documented with format '@.*: '.
'to' is not longer asd_start_timers()'s function parameter.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic94xx/aic94xx_hwi.c:589: warning: Function parameter or member
'asd_ha' not described in 'asd_init_ctxmem'
Most likely caused by bitrot (docs not keeping in sync with API).
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/linit.c: In function ‘aac_biosparm’:
drivers/scsi/aacraid/linit.c:368:41: warning: suggest braces around empty body
in an ‘if’ statement [-Wempty-body]
More bitrot issues with function documentation not keeping up with API changes.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/pm8001/pm8001_init.c:64: warning: cannot understand function
prototype: 'const struct pm8001_chip_info pm8001_chips[] = '
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aacraid/linit.c: In function ‘aac_biosparm’:
drivers/scsi/aacraid/linit.c:368:41: warning: suggest braces around empty body
in an ‘if’ statement [-Wempty-body]
368 | param->heads, param->sectors, num));
| ^
Cc: Adaptec OEM Raid
No attempt has been made to document any of the demoted functions here.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/qedf/qedf_debugfs.c:25: warning: Function parameter or member
'qedf' not described in 'qedf_dbg_host_init'
drivers/scsi/qedf/qedf_debugfs.c:25: warning:
Likely a result of documentation not keeping up with API updates (a.k.a.
bitrot).
Fixes the following W=1 kernel build warning(s):
drivers/scsi/bnx2fc/bnx2fc_hwi.c:493: warning: Function parameter or member
'hba' not described in 'bnx2fc_send_session_destroy_req'
Looks like the return value of readw() has never been checked.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/qedf/qedf_main.c: In function ‘__qedf_probe’:
drivers/scsi/qedf/qedf_main.c:3203:6: warning: variable ‘tmp’ set but not used
[-Wunused-but-set-variable]
Cc:
This is the only use of kerneldoc in the sourcefile and no
descriptions are provided.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic94xx/aic94xx_init.c:538: warning: Function parameter or member
'asd_ha' not described in 'asd_free_edbs'
Cc: YueHaibing
Cc: Luben Tuikov
Fixes the following W=1 kernel build warning(s):
drivers/scsi/libfc/fc_rport.c:129: warning: Function parameter or member
'port_id' not described in 'fc_rport_create'
drivers/scsi/libfc/fc_rport.c:129: warning: Excess function parameter 'ids'
description in 'fc_rport_create'
Mostly due to descriptions not keeping up with API changes.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/libfc/fc_fcp.c:299: warning: Function parameter or member
'status_code' not described in 'fc_fcp_retry_cmd'
drivers/scsi/libfc/fc_fcp.c:595: warning: Function parameter or
No attempt has been made to document either of the demoted functions here.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/bnx2fc/bnx2fc_tgt.c:442: warning: Function parameter or member
'lport' not described in 'bnx2fc_rport_event_handler'
drivers/scsi/bnx2fc/bnx2fc_tgt.c:442:
No attempt has been made to document either of the demoted functions here.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/qedf/qedf_main.c:1027: warning: Function parameter or member
'lport' not described in 'qedf_xmit'
drivers/scsi/qedf/qedf_main.c:1027: warning: Function
Either misdocumentation and/or bitrot.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/libfc/fc_lport.c:412: warning: Function parameter or member
'in_fp' not described in 'fc_lport_recv_echo_req'
drivers/scsi/libfc/fc_lport.c:412: warning: Excess function parameter 'fp'
'amount_xferred' is used, but only in certain circumstances. Place
the same stipulations on the defining/allocating of 'amount_xferred'
as is placed when using it.
We've been careful not to change any of the ordering semantics here.
Fixes the following W=1 kernel build warning(s):
Looks like none of the artifact from ahc_fetch_transinfo() are used anymore.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_linux_target_alloc’:
drivers/scsi/aic7xxx/aic7xxx_osm.c:567:30: warning: variable ‘tinfo’ set but
not used
>From bitrotted and missing function parameters to misuse of kerneldoc format.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1082: warning: Function parameter or member
'lport' not described in 'bnx2fc_update_src_mac'
Looks as though 'ahc' hasn't been used since 2005.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_linux_slave_configure’:
drivers/scsi/aic7xxx/aic7xxx_osm.c:674:20: warning: variable ‘ahc’ set but not
used [-Wunused-but-set-variable]
674
Fixes the following W=1 kernel build warning(s):
drivers/scsi/arcmsr/arcmsr_hba.c: In function ‘arcmsr_remap_pciregion’:
drivers/scsi/arcmsr/arcmsr_hba.c:286:30: warning: variable ‘flags’ set but not
used [-Wunused-but-set-variable]
286 | unsigned long addr, range, flags;
| ^
Ensure we do not copy the final one (which is not overwitten).
Fixes the following W=1 kernel build warning(s):
In file included from include/linux/bitmap.h:9,
from include/linux/nodemask.h:95,
from include/linux/mmzone.h:17,
from include/linux/gfp.h:6,
from include/linux/umh.h:4,
from
Mainly due to misdocumentation or bitrotted descriptions.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/fcoe/fcoe_transport.c:396: warning: Function parameter or member
'skb' not described in 'fcoe_check_wait_queue'
drivers/scsi/fcoe/fcoe_transport.c:447: warning: Function
According to 'include/scsi/scsi_transport_fc.h':
"Attributes are based on HBAAPI V2.0 definitions"
... so it seems sane to match the 'HBA Attribute Length' to them.
If we don't, the compiler complains that the copied data will be truncated.
Fixes the following W=1 kernel build warning(s):
This is my fault (can't even blame copy/paste).
Cc: Hannes Reinecke
Reported-by: Johannes Thumshirn
Signed-off-by: Lee Jones
---
drivers/scsi/libfc/fc_disc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/libfc/fc_disc.c b/drivers/scsi/libfc/fc_disc.c
index
1401 - 1500 of 1509 matches
Mail list logo
