Re: [PATCH v6 35/80] docs: fs: fscrypt.rst: get rid of :c:type: tags

2020-10-14 Thread Mauro Carvalho Chehab
Em Tue, 13 Oct 2020 10:25:12 -0700 Eric Biggers escreveu: > On Tue, Oct 13, 2020 at 01:53:50PM +0200, Mauro Carvalho Chehab wrote: > > The :c:type: tag has problems with Sphinx 3.x, as structs > > there should be declared with c:struct. > > > > So, remove them, relying at automarkup.py extension

Re: [PATCH v3] qla2xxx: Return EBUSY on fcport deletion

2020-10-14 Thread Daniel Wagner
Hi Finn, On Wed, Oct 14, 2020 at 11:57:04AM +1100, Finn Thain wrote: > > On Tue, 13 Oct 2020, Daniel Wagner wrote: > > How so? I am struggling to see how it could be a change in behavior. But > > then I sometimes fail at simple logic ;) > > > > Me too, so I confirmed the result by executing th

Re: [PATCH v2 4/8] dt-bindings: phy: convert HDMI PHY binding to YAML schema

2020-10-14 Thread Chunfeng Yun
On Wed, 2020-10-14 at 12:44 +0800, CK Hu wrote: > Hi, Chunfeng: > > On Tue, 2020-10-13 at 16:52 +0800, Chunfeng Yun wrote: > > Convert HDMI PHY binding to YAML schema mediatek,ufs-phy.yaml > > > > Signed-off-by: Chunfeng Yun > > --- > > v2: fix binding check warning of reg in example > > --- > >

Re: [PATCH v5 35/52] docs: fs: fscrypt.rst: get rid of :c:type: tags

2020-10-14 Thread Mauro Carvalho Chehab
Em Tue, 6 Oct 2020 12:19:53 -0700 Eric Biggers escreveu: > On Tue, Oct 06, 2020 at 04:03:32PM +0200, Mauro Carvalho Chehab wrote: > > The :c:type: tag has problems with Sphinx 3.x, as structs > > there should be declared with c:struct. > > > > So, remove them, relying at automarkup.py extension

Re: [PATCH v2 5/5] media: mt9p031: Fix corrupted frame after restarting stream

2020-10-14 Thread Stefan Riedmüller
Hi Laurent, On 05.10.20 15:08, Laurent Pinchart wrote: Hi Stefan, On Mon, Oct 05, 2020 at 11:28:21AM +0200, Stefan Riedmüller wrote: On 02.10.20 02:05, Laurent Pinchart wrote: On Wed, Sep 30, 2020 at 12:51:33PM +0200, Stefan Riedmueller wrote: From: Dirk Bender To prevent corrupted frames

Re: autofs crash with latest linux-next

2020-10-14 Thread Krzysztof Kozlowski
On Tue, Oct 13, 2020 at 09:20:12AM +0200, Christian Borntraeger wrote: > CC linux-next, Al Viro. > > On 12.10.20 09:54, Sven Schnelle wrote: > > Hi, > > > > on s390 i see the following crash with linux-next: > > > > [ 4525.432605] Unable to handle kernel pointer dereference in virtual > > kerne

[PATCH] Bluetooth: Use lock_sock() when acquiring lock in sco_conn_del

2020-10-14 Thread yanfei . xu
From: Yanfei Xu Locking slock-AF_BLUETOOTH-BTPROTO_SCO may happen in process context or BH context. If in process context, we should use lock_sock(). As blow warning, sco_conn_del() is called in process context, so let's use lock_sock() instead of bh_lock_sock().

[PATCH] mm/compaction: Remove some useless code in compact_zone()

2020-10-14 Thread yanfei . xu
From: Yanfei Xu start_pfn has been declared at the begin of compact_zone(), it's no need to declare it again. And remove an useless semicolon. Signed-off-by: Yanfei Xu --- mm/compaction.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c in

Re: [tip: objtool/core] x86/insn: Support big endian cross-compiles

2020-10-14 Thread Masami Hiramatsu
On Mon, 12 Oct 2020 10:39:49 -0500 Josh Poimboeuf wrote: > On Mon, Oct 12, 2020 at 09:12:36AM +0900, Masami Hiramatsu wrote: > > On Sat, 10 Oct 2020 12:44:15 -0500 > > Josh Poimboeuf wrote: > > > > > On Fri, Oct 09, 2020 at 10:49:21PM +0200, Borislav Petkov wrote: > > > > On Fri, Oct 09, 2020 a

[PATCH v4] qla2xxx: Return EBUSY on fcport deletion

2020-10-14 Thread Daniel Wagner
When the fcport is about to be deleted we should return EBUSY instead of ENODEV. Only for EBUSY the request will be requeued in a multipath setup. Also when the firmware has not yet started return EBUSY to avoid dropping the request. Signed-off-by: Daniel Wagner Reviewed-by: Arun Easi --- v4:

Re: [PATCH next] iommu: intel: don't dereference iommu_device if IOMMU_API is not built

2020-10-14 Thread Lu Baolu
Hi Bartosz, On 10/14/20 3:18 PM, Bartosz Golaszewski wrote: On Wed, Oct 14, 2020 at 2:49 AM Lu Baolu wrote: On 10/13/20 3:30 PM, Bartosz Golaszewski wrote: From: Bartosz Golaszewski Since commit c40c1018 ("iommu/vt-d: Gracefully handle DMAR units with no supported address widths") dmar

Re: [RFC PATCH v2] checkpatch: add shebang check to EXECUTE_PERMISSIONS

2020-10-14 Thread Joe Perches
On Wed, 2020-10-14 at 09:17 +0200, Lukas Bulwahn wrote: > $ clang-format-10 --version > Ubuntu clang-format version > 10.0.1-++20200928083909+ef32c611aa2-1~exp1~20200928185400.194 > > $ clang-format-10 --help | grep 'dry-run' > --dry-run - If set, do not actually make the forma

[PATCH v3 2/3] objtool: check: Support addition to set CFA base

2020-10-14 Thread Julien Thierry
On arm64, the compiler can set the frame pointer either with a move operation or with and add operation like: add (SP + constant), BP For a simple move operation, the CFA base is changed from SP to BP. Handle also changing the CFA base when the frame pointer is set with an addition instructio

[PATCH v3 1/3] objtool: check: Fully validate the stack frame

2020-10-14 Thread Julien Thierry
A valid stack frame should contain both the return address and the previous frame pointer value. On x86, the return value is placed on the stack by the calling instructions. On other architectures, the callee need to explicitly save the return address on the stack. Add the necessary checks to ver

[PATCH v3 0/3] objtool: Extend CFA updating/checking

2020-10-14 Thread Julien Thierry
Hi, The following patches are the result of limitation found on the CFA management code when trying to validate arm64 frames. I tried to keep things simple and not contradict current CFA management logic nor introduce too many corner cases. Changes since V2[1]: - Simplify cfa offset checking for

Re: [PATCH 1/2] arm64: dts: broadcom: remove an unused property dma-ranges

2020-10-14 Thread Arnd Bergmann
On Wed, Oct 14, 2020 at 5:15 AM Florian Fainelli wrote: > On 10/12/2020 11:06 PM, Zhen Lei wrote: > > stingray-usb.dtsi is finally included by three dts files: > > bcm958802a802x.dts, bcm958742k.dts and bcm958742t.dts. I searched all > > these three entire expanded dts files, and each of them cont

[PATCH v3 3/3] objtool: check: Make SP memory operation match PUSH/POP semantics

2020-10-14 Thread Julien Thierry
Architectures without PUSH/POP instructions will always access the stack though memory operations (SRC/DEST_INDIRECT). Make those operations have the same effect on the CFA as PUSH/POP, with no stack pointer modification. Signed-off-by: Julien Thierry --- tools/objtool/check.c | 20 +

Re: [PATCH] i2c: designware: fix slave omitted IC_INTR_STOP_DET

2020-10-14 Thread kernel test robot
umented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Michael-Wu/i2c-designware-fix-slave-omitted-IC_INTR_STOP_DET/20201014-132759 base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next config: riscv-randconfig-r03

Re: [PATCH 4.4 00/39] 4.4.239-rc1 review

2020-10-14 Thread Greg Kroah-Hartman
On Tue, Oct 13, 2020 at 08:11:55PM +0200, Pavel Machek wrote: > On Mon 2020-10-12 15:26:30, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.4.239 release. > > There are 39 patches in this series, all will be posted as a response > > to this one. If anyone has a

Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK)

2020-10-14 Thread Takashi Iwai
On Wed, 14 Oct 2020 07:54:15 +0200, Randy Dunlap wrote: > > On 10/13/20 10:16 PM, Udo van den Heuvel wrote: > > On 14-10-2020 07:07, Randy Dunlap wrote: > >> On 10/13/20 9:56 PM, Udo van den Heuvel wrote: > > > >>> I.e.: it looks like I will lose some funcionality when I disable > >>> SND_HDA_COD

RE: [PATCH] usb: host: fsl-mph-dr-of: check return of dma_set_mask()

2020-10-14 Thread Ran Wang
Hi Peter, On Sunday, October 11, 2020 7:41 AM Peter Chen wrote: > > On 20-10-10 14:03:08, Ran Wang wrote: > > fsl_usb2_device_register() should stop init if dma_set_mask() return > > error. > > > > Fixes: cae058610465 ("drivers/usb/host: fsl: Set DMA_MASK of usb > > platform device") > > Signed-o

Re: [PATCH 1/2] coresight: tmc-etf: Fix NULL ptr dereference in tmc_enable_etf_sink_perf()

2020-10-14 Thread Sai Prakash Ranjan
Hi Suzuki, On 2020-10-13 22:05, Suzuki K Poulose wrote: On 10/07/2020 02:00 PM, Sai Prakash Ranjan wrote: There was a report of NULL pointer dereference in ETF enable path for perf CS mode with PID monitoring. It is almost 100% reproducible when the process to monitor is something very active s

[PATCH v4] kthread_worker: Prevent queuing delayed work from timer_fn when it is being canceled

2020-10-14 Thread Zqiang
There is a small race window when a delayed work is being canceled and the work still might be queued from the timer_fn: CPU0CPU1 kthread_cancel_delayed_work_sync() __kthread_cancel_work_sync() __kthread_cancel_work() work->cancel

Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK)

2020-10-14 Thread Takashi Iwai
On Wed, 14 Oct 2020 09:49:49 +0200, Takashi Iwai wrote: > > On Wed, 14 Oct 2020 07:54:15 +0200, > Randy Dunlap wrote: > > > > On 10/13/20 10:16 PM, Udo van den Heuvel wrote: > > > On 14-10-2020 07:07, Randy Dunlap wrote: > > >> On 10/13/20 9:56 PM, Udo van den Heuvel wrote: > > > > > >>> I.e.: i

[PATCH] usb: gadget: function: printer: Fix usb function descriptors leak

2020-10-14 Thread Zqiang
If an error occurs after call 'usb_assign_descriptors' func, the 'usb_free_all_descriptors' need to be call to release memory space occupied by function descriptors. Signed-off-by: Zqiang --- drivers/usb/gadget/function/f_printer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/

Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK)

2020-10-14 Thread Pavel Machek
Hi! > >>> I.e.: it looks like I will lose some funcionality when I disable > >>> SND_HDA_CODEC_REALTEK. > >> > >> OK. At present you can't have it both ways, i.e., SND_HDA_CODEC_REALTEK > >> with no LEDS. That driver apparently wants LEDS. > > > > Thanks but why have I gone for years without LEDS

Re: [PATCH v2 02/24] tools: docs: memory-model: fix references for some files

2020-10-14 Thread Mauro Carvalho Chehab
Em Tue, 13 Oct 2020 18:58:40 -0700 "Paul E. McKenney" escreveu: > On Tue, Oct 13, 2020 at 12:38:36PM -0400, Alan Stern wrote: > > On Tue, Oct 13, 2020 at 09:33:54AM -0700, Paul E. McKenney wrote: > > > On Tue, Oct 13, 2020 at 02:14:29PM +0200, Mauro Carvalho Chehab wrote: > > > > - The sysfs.

RE: [PATCH 1/1] net: ftgmac100: Fix Aspeed ast2600 TX hang issue

2020-10-14 Thread Dylan Hung
Hi Joel, > -Original Message- > From: Joel Stanley [mailto:j...@jms.id.au] > Sent: Wednesday, October 14, 2020 2:41 PM > To: Dylan Hung > Cc: David S . Miller ; Jakub Kicinski > ; net...@vger.kernel.org; Linux Kernel Mailing List > ; Po-Yu Chuang ; > linux-aspeed ; OpenBMC Maillist > ; BM

Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK)

2020-10-14 Thread Pavel Machek
Hi! > > > >>> I.e.: it looks like I will lose some funcionality when I disable > > > >>> SND_HDA_CODEC_REALTEK. > > > >> > > > >> OK. At present you can't have it both ways, i.e., SND_HDA_CODEC_REALTEK > > > >> with no LEDS. That driver apparently wants LEDS. > > > > > > > > Thanks but why have I

Re: [PATCH] dt-bindings: leds: Update devicetree documents for ID_RGB

2020-10-14 Thread Leizhen (ThunderTown)
On 2020/10/14 1:50, Dan Murphy wrote: > Update the leds/common.yaml to indicate that the max color ID is 9. > Reflect the same change in the leds-class-multicolor.yaml > > Reported-by: Zhen Lei > Signed-off-by: Dan Murphy > --- > Documentation/devicetree/bindings/leds/common.yaml | 2 +

Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK)

2020-10-14 Thread Udo van den Heuvel
On 14-10-2020 09:58, Pavel Machek wrote: > Contrary to his claims, Udo very probably has LEDs in his systems... We have a visible power LED. WE have a HDD LED. The board has LEDs, yes, but the SilverStone Fortress FT02 hides them fairly well. I did not ask for LEDs nor need them this way. It's a

Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK)

2020-10-14 Thread Takashi Iwai
On Wed, 14 Oct 2020 09:58:53 +0200, Pavel Machek wrote: > > Hi! > > > > > >>> I.e.: it looks like I will lose some funcionality when I disable > > > > >>> SND_HDA_CODEC_REALTEK. > > > > >> > > > > >> OK. At present you can't have it both ways, i.e., > > > > >> SND_HDA_CODEC_REALTEK > > > > >> wi

Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK)

2020-10-14 Thread Takashi Iwai
On Wed, 14 Oct 2020 09:54:59 +0200, Pavel Machek wrote: > > Hi! > > > >>> I.e.: it looks like I will lose some funcionality when I disable > > >>> SND_HDA_CODEC_REALTEK. > > >> > > >> OK. At present you can't have it both ways, i.e., SND_HDA_CODEC_REALTEK > > >> with no LEDS. That driver apparent

Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK)

2020-10-14 Thread Pavel Machek
On Wed 2020-10-14 10:05:42, Udo van den Heuvel wrote: > On 14-10-2020 09:58, Pavel Machek wrote: > > Contrary to his claims, Udo very probably has LEDs in his systems... > > We have a visible power LED. > WE have a HDD LED. > The board has LEDs, yes, but the SilverStone Fortress FT02 hides them >

Re: [PATCH nf v2] netfilter: conntrack: connection timeout after re-register

2020-10-14 Thread Pablo Neira Ayuso
On Wed, Oct 14, 2020 at 02:06:28AM +0200, Pablo Neira Ayuso wrote: > On Fri, Oct 09, 2020 at 10:05:48PM +0200, Florian Westphal wrote: > > Jozsef Kadlecsik wrote: > > > > The "delay unregister" remark was wrt. the "all rules were deleted" > > > > case, i.e. add a "grace period" rather than acting

Re: [PATCH] usb: gadget: function: printer: Fix usb function descriptors leak

2020-10-14 Thread Greg KH
On Wed, Oct 14, 2020 at 03:55:23PM +0800, Zqiang wrote: > If an error occurs after call 'usb_assign_descriptors' func, the > 'usb_free_all_descriptors' need to be call to release memory space > occupied by function descriptors. > > Signed-off-by: Zqiang Please use your ful name for the From: and

Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK)

2020-10-14 Thread Pavel Machek
On Wed 2020-10-14 10:08:27, Takashi Iwai wrote: > On Wed, 14 Oct 2020 09:54:59 +0200, > Pavel Machek wrote: > > > > Hi! > > > > > >>> I.e.: it looks like I will lose some funcionality when I disable > > > >>> SND_HDA_CODEC_REALTEK. > > > >> > > > >> OK. At present you can't have it both ways, i.e

[PATCH RFC] drm/nouveau: fix memory leak in nvkm_iccsense_oneinit

2020-10-14 Thread Keita Suzuki
struct pw_rail_t is allocated as an array in function nvios_iccsense_parse, and stored to a struct member of local variable. However, the array is not freed when the local variable becomes invalid, and the reference is not passed on, leading to a memory leak. Fix this by freeing struct pw_rail_t w

[PATCH 3/3] Bluetooth: hci_bcm: Ignore deprecated command fail case

2020-10-14 Thread Amitesh Chandra
From: Manoj Babulal Broadcom VSC uart_clock_setting is deprecated in newer controllers. Ignore error if the controller returns invalid or bad request error code. Signed-off-by: Amitesh Chandra Signed-off-by: Manoj Babulal --- drivers/bluetooth/hci_bcm.c | 15 +-- 1 file changed, 9

[PATCH 2/3] dt-bindings: net: bluetooth: Add broadcom BCM4389 support

2020-10-14 Thread Amitesh Chandra
From: Amitesh Chandra Add bindings for BCM4389 bluetooth controller. Signed-off-by: Amitesh Chandra --- Documentation/devicetree/bindings/net/broadcom-bluetooth.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt b/Documentation

Re: [RFC PATCH v2] checkpatch: add shebang check to EXECUTE_PERMISSIONS

2020-10-14 Thread Lukas Bulwahn
On Tue, 13 Oct 2020, Ujjwal Kumar wrote: > checkpatch.pl checks for invalid EXECUTE_PERMISSIONS on source > files. The script leverages filename extensions and its path in > the repository to decide whether to allow execute permissions on > the file or not. > > Based on current check condition

Re: [PATCH v4 2/2] PCI/ERR: Split the fatal and non-fatal error recovery handling

2020-10-14 Thread Ethan Zhao
On Mon, Oct 12, 2020 at 1:10 PM wrote: > > From: Kuppuswamy Sathyanarayanan > > Commit bdb5ac85777d ("PCI/ERR: Handle fatal error recovery") > merged fatal and non-fatal error recovery paths, and also made > recovery code depend on hotplug handler for "remove affected > device + rescan" support.

Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK)

2020-10-14 Thread Takashi Iwai
On Wed, 14 Oct 2020 10:13:05 +0200, Pavel Machek wrote: > > On Wed 2020-10-14 10:08:27, Takashi Iwai wrote: > > On Wed, 14 Oct 2020 09:54:59 +0200, > > Pavel Machek wrote: > > > > > > Hi! > > > > > > > >>> I.e.: it looks like I will lose some funcionality when I disable > > > > >>> SND_HDA_CODEC

[PATCH v6 1/2] PCI/ERR: Call pci_bus_reset() before calling ->slot_reset() callback

2020-10-14 Thread Kuppuswamy Sathyanarayanan
Currently if report_error_detected() or report_mmio_enabled() functions requests PCI_ERS_RESULT_NEED_RESET, current pcie_do_recovery() implementation does not do the requested explicit device reset, but instead just calls the report_slot_reset() on all affected devices. Notifying about the reset vi

Re: [PATCH 0/2] module: some refactoring in module_sig_check()

2020-10-14 Thread Sergey Shtylyov
Hello! On 14.10.2020 1:44, Joe Perches wrote: Here are 2 patches against the 'modules-next' branch of Jessica Yu's 'linux.git' repo. I'm doing some little refactoring in module_sig_check()... [1/2] module: merge repetitive strings in module_sig_check() [2/2] module: unindent comments in modul

[PATCH v6 2/2] PCI/ERR: Split the fatal and non-fatal error recovery handling

2020-10-14 Thread Kuppuswamy Sathyanarayanan
Commit bdb5ac85777d ("PCI/ERR: Handle fatal error recovery") merged fatal and non-fatal error recovery paths, and also made recovery code depend on hotplug handler for "remove affected device + rescan" support. But this change also complicated the error recovery path and which in turn led to the fo

Re: [PATCH] kbuild: doc: describe proper script invocation

2020-10-14 Thread Lukas Bulwahn
On Wed, 14 Oct 2020, Masahiro Yamada wrote: > On Tue, Oct 13, 2020 at 11:31 PM Masahiro Yamada wrote: > > > > On Thu, Oct 1, 2020 at 4:57 PM Lukas Bulwahn > > wrote: > > > > > > During an investigation to fix up the execute bits of scripts in the > > > kernel > > > repository, Andrew Morton

Re: [PATCH v4 1/2] PCI/ERR: Call pci_bus_reset() before calling ->slot_reset() callback

2020-10-14 Thread Kuppuswamy, Sathyanarayanan
On 10/14/20 1:00 AM, Ethan Zhao wrote: Please fix the building issue. drivers/pci/pcie/err.c:144:25: error: static declaration of ‘pcie_do_fatal_recovery’ follows non-static declaration static pci_ers_result_t pcie_do_fatal_recovery(struct pci_dev *dev, ^~~

Re: [PATCH 05/14] fs: don't allow kernel reads and writes without iter ops

2020-10-14 Thread Christoph Hellwig
On Sat, Oct 10, 2020 at 01:55:24AM +, Alexander Viro wrote: > FWIW, I hadn't pushed that branch out (or merged it into #for-next yet); > for one thing, uml part (mconsole) is simply broken, for another... > IMO ##5--8 are asking for kernel_pread() and if you look at binfmt_elf.c, > you'll see e

Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK)

2020-10-14 Thread Randy Dunlap
On 10/13/20 10:16 PM, Udo van den Heuvel wrote: > On 14-10-2020 07:07, Randy Dunlap wrote: >> On 10/13/20 9:56 PM, Udo van den Heuvel wrote: > >>> I.e.: it looks like I will lose some funcionality when I disable >>> SND_HDA_CODEC_REALTEK. >> >> OK. At present you can't have it both ways, i.e., SND

[PATCH] workqueue: replace call_rcu with kfree_rcu

2020-10-14 Thread Zqiang
The pwq's rcu callback func only to release 'pwq' resources, can use 'kfree_rcu' instead of 'call_rcu' func. Signed-off-by: Zqiang --- kernel/workqueue.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index ac088ce6059b..8d4fe649

Re: For review: seccomp_user_notif(2) manual page

2020-10-14 Thread Michael Kerrisk (man-pages)
Hi Tycho, Ping on the question below! Thanks, Michael On 10/1/20 9:45 AM, Michael Kerrisk (man-pages) wrote: > On 10/1/20 1:03 AM, Tycho Andersen wrote: >> On Wed, Sep 30, 2020 at 10:34:51PM +0200, Michael Kerrisk (man-pages) wrote: >>> Hi Tycho, >>> >>> Thanks for taking time to look at the pa

[PATCH] au1100fb: Remove NULL pointer check before clk_enable/disable

2020-10-14 Thread Xu Wang
Because clk_enable, clk_disable, clk_prepare, and clk_unprepare already checked NULL clock parameter, so the additional checks are unnecessary, just remove them. Signed-off-by: Xu Wang --- drivers/video/fbdev/au1100fb.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/dr

Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK)

2020-10-14 Thread Udo van den Heuvel
On 14-10-2020 10:11, Pavel Machek wrote: >> It's a computer, not a disco-light or anything like that. > > And you probably have numlock LED. On the case? no way. It is on the keyboard, a separate device, and already has a function. We also have a caps lock LED and scroll lock LED there, with sepa

Re: [PATCH v2 0/3] Clarify abstract scale usage for power values in Energy Model, EAS and IPA

2020-10-14 Thread Daniel Lezcano
Hi Lukasz, On 09/10/2020 11:16, Lukasz Luba wrote: > Hi Rafael, > > On 10/2/20 12:44 PM, Lukasz Luba wrote: >> Hi all, >> >> The Energy Model supports power values expressed in an abstract scale. >> This has an impact on Intelligent Power Allocation (IPA) and should be >> documented properly. T

Re: [PATCH nf v2] netfilter: conntrack: connection timeout after re-register

2020-10-14 Thread Florian Westphal
Pablo Neira Ayuso wrote: > > Yes, we iterate table on re-register and modify the existing entries. > > For iptables-nft, it might be possible to avoid this deregister + > register ct hooks in the same transaction: Maybe add something like > nf_ct_netns_get_all() to bump refcounters by one _iff_ t

Re: [PATCH 3/3] pwm: Add Raspberry Pi Firmware based PWM bus

2020-10-14 Thread Uwe Kleine-König
Hello Nicolas, [Cc: += Greg as base driver maintainer] On Tue, Oct 13, 2020 at 06:50:47PM +0200, Nicolas Saenz Julienne wrote: > On Tue, 2020-10-13 at 14:17 +0200, Uwe Kleine-König wrote: > > On Tue, Oct 13, 2020 at 01:20:00PM +0200, Nicolas Saenz Julienne wrote: > > > On Mon, 2020-10-12 at 09:06

Re: [PATCH 0/3] gpiolib: cdev: allow edge event timestamps to be configured as REALTIME

2020-10-14 Thread Bartosz Golaszewski
On Wed, Oct 14, 2020 at 8:28 AM Kent Gibson wrote: > > This patch set adds the option to select CLOCK_REALTIME as the source > clock for line events. > > The first patch is the core of the change, while the remaining two update > the GPIO tools to make use of the new option. > > Kent Gibson (3): >

Re: [PATCH v6 4/4] mmc: mediatek: Add subsys clock control for MT8192 msdc

2020-10-14 Thread Matthias Brugger
On 14/10/2020 05:06, Nicolas Boichat wrote: On Wed, Oct 14, 2020 at 10:29 AM Wenbin Mei wrote: On Tue, 2020-10-13 at 17:10 +0200, Matthias Brugger wrote: On 12/10/2020 14:45, Wenbin Mei wrote: MT8192 msdc is an independent sub system, we need control more bus clocks for it. Add support f

Re: [PATCH v4 1/2] PCI/ERR: Call pci_bus_reset() before calling ->slot_reset() callback

2020-10-14 Thread Ethan Zhao
Please fix the building issue. drivers/pci/pcie/err.c:144:25: error: static declaration of ‘pcie_do_fatal_recovery’ follows non-static declaration static pci_ers_result_t pcie_do_fatal_recovery(struct pci_dev *dev, ^~ In file included from drivers/pci/

Re: [PATCH v6 4/4] mmc: mediatek: Add subsys clock control for MT8192 msdc

2020-10-14 Thread Nicolas Boichat
On Wed, Oct 14, 2020 at 3:44 PM Matthias Brugger wrote: > > > > On 14/10/2020 05:06, Nicolas Boichat wrote: > > On Wed, Oct 14, 2020 at 10:29 AM Wenbin Mei wrote: > >> > >> On Tue, 2020-10-13 at 17:10 +0200, Matthias Brugger wrote: > >>> > >>> On 12/10/2020 14:45, Wenbin Mei wrote: > MT8192

Re: [PATCH] reset: meson: make it possible to build as a module

2020-10-14 Thread Neil Armstrong
On 13/10/2020 16:57, Robin Murphy wrote: > On 2020-10-13 14:39, Neil Armstrong wrote: >> In order to reduce the kernel Image size on multi-platform distributions, >> make it possible to build the reset controller driver as a module. >> >> This partially reverts 8290924e ("reset: meson: make it expl

Re: [Virtio-fs] Unbreakable loop in fuse_fill_write_pages()

2020-10-14 Thread Dr. David Alan Gilbert
* Qian Cai (c...@redhat.com) wrote: > On Tue, 2020-10-13 at 14:58 -0400, Vivek Goyal wrote: > > > I am wondering if virtiofsd still alive and responding to requests? I > > see another task which is blocked on getdents() for more than 120s. > > > > [10580.142571][ T348] INFO: task trinity-c36:254

Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK)

2020-10-14 Thread Pavel Machek
On Wed 2020-10-14 10:22:01, Udo van den Heuvel wrote: > On 14-10-2020 10:11, Pavel Machek wrote: > >> It's a computer, not a disco-light or anything like that. > > > > And you probably have numlock LED. > > On the case? no way. > It is on the keyboard, a separate device, and already has a functio

[PATCH] usb: gadget: function: printer: Fix usb function descriptors leak

2020-10-14 Thread qiang . zhang
From: Zqiang If an error occurs after call 'usb_assign_descriptors' func, the 'usb_free_all_descriptors' need to be call to release memory space occupied by function descriptors. Signed-off-by: Zqiang --- drivers/usb/gadget/function/f_printer.c | 1 + 1 file changed, 1 insertion(+) diff --git

Linux 4.4.239

2020-10-14 Thread Greg Kroah-Hartman
I'm announcing the release of the 4.4.239 kernel. All users of the 4.4 kernel series must upgrade. The updated 4.4.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.4.y and can be browsed at the normal kernel.org git web browser:

Re: disabling CONFIG_LED_CLASS

2020-10-14 Thread Randy Dunlap
On 10/13/20 9:39 PM, Udo van den Heuvel wrote: > On 14-10-2020 06:34, Randy Dunlap wrote: >> On 10/13/20 9:29 PM, Udo van den Heuvel wrote: >>> So we still are stuck. > > (...) > > >> Please post your .config file. > > Attached to this message. > This is the version stripped from LED references

Linux 4.9.239

2020-10-14 Thread Greg Kroah-Hartman
I'm announcing the release of the 4.9.239 kernel. All users of the 4.9 kernel series must upgrade. The updated 4.9.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.9.y and can be browsed at the normal kernel.org git web browser:

Re: Linux 4.4.239

2020-10-14 Thread Greg Kroah-Hartman
diff --git a/Makefile b/Makefile index 209fe98a591c..74072b5a958b 100644 --- a/Makefile +++ b/Makefile @@ -1,6 +1,6 @@ VERSION = 4 PATCHLEVEL = 4 -SUBLEVEL = 238 +SUBLEVEL = 239 EXTRAVERSION = NAME = Blurry Fish Butt diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 04a923186081..6bb3a

Re: KASAN: slab-out-of-bounds Read in squashfs_get_id

2020-10-14 Thread Fox Chen
Hi, I found this bug was caused by either uid/gid info in superblocks or id_index_table is corrupted. The uid/gid index is larger than the size of msblk->id_table. Should I add a sanity check to squashfs_get_id?? The complete solution is to record the size of msblk->id_table in msblk and c

Re: Linux 4.9.239

2020-10-14 Thread Greg Kroah-Hartman
diff --git a/Makefile b/Makefile index 41a7d6626e35..82bb1b27d2f5 100644 --- a/Makefile +++ b/Makefile @@ -1,6 +1,6 @@ VERSION = 4 PATCHLEVEL = 9 -SUBLEVEL = 238 +SUBLEVEL = 239 EXTRAVERSION = NAME = Roaring Lionus diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 854d218ea76a..ff59a18

Linux 4.14.201

2020-10-14 Thread Greg Kroah-Hartman
I'm announcing the release of the 4.14.201 kernel. All users of the 4.14 kernel series must upgrade. The updated 4.14.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.14.y and can be browsed at the normal kernel.org git web browser

Re: Linux 4.14.201

2020-10-14 Thread Greg Kroah-Hartman
diff --git a/Makefile b/Makefile index 0fde7a0de1dd..e3e2d7fa7232 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 VERSION = 4 PATCHLEVEL = 14 -SUBLEVEL = 200 +SUBLEVEL = 201 EXTRAVERSION = NAME = Petit Gorille diff --git a/drivers/base/dd.c b/drivers/b

[PATCH v4] kthread_worker: Prevent queuing delayed work from timer_fn when it is being canceled

2020-10-14 Thread qiang . zhang
From: Zqiang There is a small race window when a delayed work is being canceled and the work still might be queued from the timer_fn: CPU0CPU1 kthread_cancel_delayed_work_sync() __kthread_cancel_work_sync() __kthread_cancel_work()

Re: [PATCH 1/1] watchdog: remove unneeded inclusion of

2020-10-14 Thread Guenter Roeck
On 10/13/20 7:14 PM, Leizhen (ThunderTown) wrote: > > > On 2020/9/8 11:34, Leizhen (ThunderTown) wrote: >> >> >> On 2020/9/8 10:40, Guenter Roeck wrote: >>> On 9/7/20 12:50 AM, Leizhen (ThunderTown) wrote: Hi, Wim Van Sebroeck, Guenter Roeck: What's your opinion? Guenter Roeck given "

Re: [PATCH 4.19 00/49] 4.19.151-rc1 review

2020-10-14 Thread Greg Kroah-Hartman
On Tue, Oct 13, 2020 at 08:11:35PM +0200, Pavel Machek wrote: > Hi! > > > This is the start of the stable review cycle for the 4.19.151 release. > > There are 49 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > >

[PATCH] workqueue: replace call_rcu with kfree_rcu

2020-10-14 Thread qiang . zhang
From: Zqiang The pwq's rcu callback func only to release 'pwq' resources, can use 'kfree_rcu' instead of 'call_rcu' func. Signed-off-by: Zqiang --- kernel/workqueue.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index ac088ce

[PATCH 0/8] Use uncached writes while clearing gigantic pages

2020-10-14 Thread Ankur Arora
This series adds clear_page_nt(), a non-temporal MOV (MOVNTI) based clear_page(). The immediate use case is to speedup creation of large (~2TB) guests VMs. Memory for these guests is allocated via huge/gigantic pages which are faulted in early. The intent behind using non-temporal writes is to mi

Re: [patch 1/2] nohz: only wakeup a single target cpu when kicking a task

2020-10-14 Thread Peter Zijlstra
On Tue, Oct 13, 2020 at 02:13:28PM -0300, Marcelo Tosatti wrote: > > Yes but if the task isn't running, run_posix_cpu_timers() doesn't have > > anything to elapse. So indeed we can spare the IPI if the task is not > > running. Provided ordering makes sure that the task sees the new dependency > >

[PATCH 2/8] x86/asm: add memset_movnti()

2020-10-14 Thread Ankur Arora
Add a MOVNTI based implementation of memset(). memset_orig() and memset_movnti() only differ in the opcode used in the inner loop, so move the memset_orig() logic into a macro, which gets expanded into memset_movq() and memset_movnti(). Signed-off-by: Ankur Arora --- arch/x86/lib/memset_64.S |

[PATCH 5/8] x86/clear_page: add clear_page_uncached()

2020-10-14 Thread Ankur Arora
Define clear_page_uncached() as an alternative_call() to clear_page_nt() if the CPU sets X86_FEATURE_NT_GOOD and fallback to clear_page() if it doesn't. Similarly define clear_page_uncached_flush() which provides an SFENCE if the CPU sets X86_FEATURE_NT_GOOD. Also, add the glue interface clear_us

Re: [PATCH 4.19 00/49] 4.19.151-rc1 review

2020-10-14 Thread Greg Kroah-Hartman
On Tue, Oct 13, 2020 at 09:40:32AM -0700, Guenter Roeck wrote: > On Mon, Oct 12, 2020 at 03:26:46PM +0200, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.19.151 release. > > There are 49 patches in this series, all will be posted as a response > > to this one.

[PATCH 3/8] perf bench: add memset_movnti()

2020-10-14 Thread Ankur Arora
Clone memset_movnti() from arch/x86/lib/memset_64.S. perf bench mem memset on -f x86-64-movnt on Intel Broadwellx, Skylakex and AMD Rome: Intel Broadwellx: $ for i in 2 8 32 128 512; do perf bench mem memset -f x86-64-movnt -s ${i}MB done # Output pruned. # Running 'mem/memset' ben

[PATCH] MAINTAINERS: Add Advantech embedded controller entry

2020-10-14 Thread Shihlun Lin
Add Advantech embedded controller entry Signed-off-by: Shihlun Lin --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6336f9314ae1..41e94692c4f8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -562,6 +562,17 @@ S: Maintained F: Doc

[PATCH 4/8] x86/asm: add clear_page_nt()

2020-10-14 Thread Ankur Arora
Add clear_page_nt() which is essentially an unrolled MOVNTI loop. The unrolling keeps the inner loop similar to memset_movnti() which can be exercised via perf bench mem memset. The caller needs to execute an SFENCE when done. MOVNTI, from the Intel SDM, Volume 2B, 4-101: "The non-temporal hint

Re: [RFC PATCH v2] checkpatch: add shebang check to EXECUTE_PERMISSIONS

2020-10-14 Thread Lukas Bulwahn
On Tue, 13 Oct 2020, Joe Perches wrote: > On Wed, 2020-10-14 at 08:47 +0200, Lukas Bulwahn wrote: > > > > On Tue, 13 Oct 2020, Joe Perches wrote: > > > > > On Wed, 2020-10-14 at 08:36 +0200, Lukas Bulwahn wrote: > > > > On Tue, 13 Oct 2020, Joe Perches wrote: > > > > > > > > > On Wed, 2020-1

[PATCH 7/8] x86/cpu/intel: enable X86_FEATURE_NT_GOOD on Intel Broadwellx

2020-10-14 Thread Ankur Arora
System: Oracle X6-2 CPU: 2 nodes * 10 cores/node * 2 threads/core Intel Xeon E5-2630 v4 (Broadwellx, 6:79:1) Memory: 256 GB evenly split between nodes Microcode:0xb2e scaling_governor: performance L3 size: 25MB intel_pstate/no_

Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK)

2020-10-14 Thread Udo van den Heuvel
On 14-10-2020 10:27, Pavel Machek wrote: >> One should have thought about stuff beforehand. > > We did. And decided this is best solution. Then the thought process went awry. >> The non-selectability is not my fault. > > It also does not affect you in any way. It does. /boot fills up even soon

[PATCH 2/2] dt-bindings: mfd: ahc1ec0.yaml: Add Advantech Embedded Controll - AHC1EC0

2020-10-14 Thread Shihlun Lin
Add DT binding schema for Advantech embedded controller AHC1EC0. Signed-off-by: Shihlun Lin --- .../devicetree/bindings/mfd/ahc1ec0.yaml | 76 +++ 1 file changed, 76 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/ahc1ec0.yaml diff --git a/Documentat

Re: [PATCH next] iommu: intel: don't dereference iommu_device if IOMMU_API is not built

2020-10-14 Thread Bartosz Golaszewski
On Wed, Oct 14, 2020 at 2:49 AM Lu Baolu wrote: > > On 10/13/20 3:30 PM, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > Since commit c40c1018 ("iommu/vt-d: Gracefully handle DMAR units > > with no supported address widths") dmar.c needs struct iommu_device to > > be selected

[PATCH 1/8] x86/cpuid: add X86_FEATURE_NT_GOOD

2020-10-14 Thread Ankur Arora
Enabled on microarchitectures with performant non-temporal MOV (MOVNTI) instruction. Signed-off-by: Ankur Arora --- arch/x86/include/asm/cpufeatures.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h index 7b0afd5e6c57..

[PATCH 8/8] x86/cpu/amd: enable X86_FEATURE_NT_GOOD on AMD Zen

2020-10-14 Thread Ankur Arora
System: Oracle E2-2C CPU: 2 nodes * 64 cores/node * 2 threads/core AMD EPYC 7742 (Rome, 23:49:0) Memory: 2048 GB evenly split between nodes Microcode:0x8301038 scaling_governor: performance L3 size: 16 * 16MB cpufreq/boost:0 P

Re: [PATCH 0/2] module: some refactoring in module_sig_check()

2020-10-14 Thread Joe Perches
On Wed, 2020-10-14 at 11:18 +0300, Sergey Shtylyov wrote: > Hello! > > On 14.10.2020 1:44, Joe Perches wrote: > > > > Here are 2 patches against the 'modules-next' branch of Jessica Yu's > > > 'linux.git' repo. > > > I'm doing some little refactoring in module_sig_check()... > > > > > > [1/2] m

[PATCH 6/8] mm, clear_huge_page: use clear_page_uncached() for gigantic pages

2020-10-14 Thread Ankur Arora
Uncached writes are suitable for circumstances where the region written to is not expected to be read again soon, or the region written to is large enough that there's no expectation that we will find the writes in the cache. Accordingly switch to using clear_page_uncached() for gigantic pages. S

Re: [PATCH v3] i2c: virtio: add a virtio i2c frontend driver

2020-10-14 Thread Jie Deng
On 2020/10/13 16:00, Jason Wang wrote: + +    virtqueue_kick(vq); + +    time_left = wait_for_completion_timeout(&vi->completion, adap->timeout); +    if (!time_left) { +    dev_err(&adap->dev, "msg[%d]: addr=0x%x timeout.\n", i, msgs[i].addr); +    break; +   

Re: [PATCH v3 10/15] phy: tegra: xusb: Add wake/sleepwalk for Tegra210

2020-10-14 Thread JC Kuo
On 9/28/20 9:40 PM, Thierry Reding wrote: > On Wed, Sep 09, 2020 at 04:10:36PM +0800, JC Kuo wrote: > [...] >> diff --git a/drivers/phy/tegra/xusb-tegra210.c >> b/drivers/phy/tegra/xusb-tegra210.c > [...] > > Could we add function pointers to struct tegra_xusb_lane_ops for all of > these? That wo

Re: disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK)

2020-10-14 Thread Pavel Machek
On Wed 2020-10-14 10:34:21, Udo van den Heuvel wrote: > On 14-10-2020 10:27, Pavel Machek wrote: > >> One should have thought about stuff beforehand. > > > > We did. And decided this is best solution. > > Then the thought process went awry. > > >> The non-selectability is not my fault. > > > >

[PATCH 2/3] mfd: ahc1ec0-hwmon: Add sub-device hwmon for Advantech embedded controller

2020-10-14 Thread Shihlun Lin
This is one of sub-device driver for Advantech embedded controller AHC1EC0. This driver provides sysfs ABI for Advantech related applications to monitor the system status. Signed-off-by: Shihlun Lin --- drivers/mfd/Kconfig |8 + drivers/mfd/Makefile|1 + drivers/mfd/ahc1e

[PATCH 1/2] mfd: ahc1ec0: Add Advantech EC include file used by dt-bindings

2020-10-14 Thread Shihlun Lin
This files defines the sud-device types and hwmon profiles support by Advantech embedded controller. Signed-off-by: Shihlun Lin --- include/dt-bindings/mfd/ahc1ec0.h | 29 + 1 file changed, 29 insertions(+) create mode 100644 include/dt-bindings/mfd/ahc1ec0.h diff -

Re: [PATCH 1/2] x86: Remove led/gpio setup from pcengines platform driver

2020-10-14 Thread Hans de Goede
Hi, On 10/13/20 11:40 PM, Ed W wrote: Hans, can I ask you to look again at the history of this please. Bearing in mind the speed kernel stuff takes to get to end users, we are talking about a very small window of userland changes here. I would vote for simplifying this module and trying to

  1   2   3   4   5   6   7   8   9   10   >