Re: [PATCH 15/16] dt-bindings: phy: cdns,dphy: make clocks optional

2021-04-06 Thread Pratyush Yadav
On 02/04/21 01:31PM, Laurent Pinchart wrote: > Hi Pratyush, > > Thank you for the patch. > > On Tue, Mar 30, 2021 at 11:03:47PM +0530, Pratyush Yadav wrote: > > The clocks are not used by the DPHY when used in Rx mode so make them > > optional. > > Isn't there a main functional clock

Re: [PATCH] KVM: x86/mmu: preserve pending TLB flush across calls to kvm_tdp_mmu_zap_sp

2021-04-06 Thread Sean Christopherson
On Tue, Apr 06, 2021, Paolo Bonzini wrote: > Right now, if a call to kvm_tdp_mmu_zap_sp returns false, the caller > will skip the TLB flush, which is wrong. There are two ways to fix > it: > > - since kvm_tdp_mmu_zap_sp will not yield and therefore will not flush > the TLB itself, we could

Re: [PATCH bpf-next 3/5] libbpf: add low level TC-BPF API

2021-04-06 Thread Kumar Kartikeya Dwivedi
On Mon, Apr 05, 2021 at 10:51:09PM IST, Andrii Nakryiko wrote: > > [...] > > if _block variant is just a special ifindex value, then it should be > fine for users to know such a detail (we can leave a comment > mentioning this specifically), especially given it's not a very > popular thing. Almost

[RFC] dt-bindings: riscv: enum for riscv,isa

2021-04-06 Thread Heinrich Schuchardt
In Documentation/devicetree/bindings/riscv/cpus.yaml I find for riscv,isa: enum: - rv64imac - rv64imafdc This implies that 'rv64imafc' or 'rv64imafdqc' would be illegal values while these combinations of extensions would be compliant with "The RISC-V Instruction Set Manual". To

Re: [PATCH v4 15/18] irqchip/apple-aic: Add support for the Apple Interrupt Controller

2021-04-06 Thread Hector Martin
On 07/04/2021 03.16, Marc Zyngier wrote: Hi Hector, On Fri, 02 Apr 2021 10:05:39 +0100, Hector Martin wrote: + /* +* In EL1 the non-redirected registers are the guest's, +* not EL2's, so remap the hwirqs to match. +*/ +

Re: [PATCH AUTOSEL 5.10 07/22] scsi: iscsi: Fix race condition between login and sync thread

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 12:24:32PM -0500, Mike Christie wrote: > On 4/5/21 11:04 AM, Sasha Levin wrote: > > From: Gulam Mohamed > > > > [ Upstream commit 9e67600ed6b8565da4b85698ec659b5879a6c1c6 ] > > > > A kernel panic was observed due to a timing issue between the sync thread > > and the

Re: [RESEND PATCH] staging: emxx_udc: Ending line with argument

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 08:34:09PM +0100, Beatriz Martins de Carvalho wrote: > Cleans up check of "Lines should not end with a '('" > with argument present in next line in file emxx_udc.c > > Signed-off-by: Beatriz Martins de Carvalho > > --- > drivers/staging/emxx_udc/emxx_udc.c | 11

include/linux/fortify-string.h:27:30: warning: '__builtin_strncpy' output truncated before terminating nul copying 11 bytes from a string of the same length

2021-04-06 Thread kernel test robot
-r025-20210406 (attached as .config) compiler: mips-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel

Re: [RFC Part1 PATCH 06/13] x86/compressed: rescinds and validate the memory used for the GHCB

2021-04-06 Thread Tom Lendacky
On 4/6/21 10:47 AM, Brijesh Singh wrote: > > On 4/6/21 5:33 AM, Borislav Petkov wrote: >> On Wed, Mar 24, 2021 at 11:44:17AM -0500, Brijesh Singh wrote: >> ... >> *Any* and *all* page state changes which fail immediately terminate a >> guest? Why? > > > The hypervisor uses the RMPUPDATE

Re: [syzbot] KASAN: use-after-free Write in sk_psock_stop

2021-04-06 Thread Cong Wang
On Tue, Apr 6, 2021 at 6:01 AM syzbot wrote: > == > BUG: KASAN: use-after-free in __lock_acquire+0x3e6f/0x54c0 > kernel/locking/lockdep.c:4770 > Read of size 8 at addr 888024f66238 by task syz-executor.1/14202 > > CPU: 0 PID:

Re: [PATCH v6 0/5] Add support for HiSilicon I2C controller

2021-04-06 Thread Wolfram Sang
On Wed, Mar 31, 2021 at 09:36:25PM +0800, Yicong Yang wrote: > Add driver and MAINTAINERS for HiSilicon I2C controller on Kunpeng SoC. Also > provide the devm_*() variants for adding the I2C adapters. Add a public > api to provide I2C frequency mode strings and convert designware driver > to use

Re: [PATCH 1/1] of: properly check for error returned by fdt_get_name()

2021-04-06 Thread Frank Rowand
On 4/6/21 2:21 PM, Rob Herring wrote: > On Sun, Apr 04, 2021 at 10:28:45PM -0500, frowand.l...@gmail.com wrote: >> From: Frank Rowand >> >> fdt_get_name() returns error values via a parameter pointer >> instead of in function return. Fix check for this error value >> in populate_node() and

Re: [PATCH v2] hwmon: (sbtsi) Don't read sensor more than once if it doesn't respond

2021-04-06 Thread Guenter Roeck
On 4/6/21 2:09 PM, Konstantin Aladyshev wrote: > Thanks for the answer! > Sorry for the confusion, by the "CPU is off" I meant "CPU is present, > but currently it is in the powered off state". > Therefore it is not possible to put these checks only in a probe > function. And I don't know either if

Re: [PATCH 2/2] perf-stat: introduce config stat.bpf-counter-events

2021-04-06 Thread Song Liu
> On Apr 6, 2021, at 7:21 AM, Jiri Olsa wrote: > > On Fri, Apr 02, 2021 at 05:29:38PM -0700, Song Liu wrote: >> Currently, to use BPF to aggregate perf event counters, the user uses >> --bpf-counters option. Enable "use bpf by default" events with a config >> option, stat.bpf-counter-events.

Re: [PATCH] mm, thp: Relax the VM_DENYWRITE constraint on file-backed THPs

2021-04-06 Thread William Kucharski
Sounds good. Reviewed-by: William Kucharski > On Apr 6, 2021, at 11:48 AM, Collin Fijalkovich > wrote: > > Instrumenting filemap_nr_thps_inc() should be sufficient for ensuring > writable file mappings will not be THP-backed. > > If filemap_nr_thps_dec() in unaccount_page_cache_page() and >

Re: [PATCH v24 25/30] x86/cet/shstk: Handle signals for shadow stack

2021-04-06 Thread Andy Lutomirski
On Thu, Apr 1, 2021 at 3:11 PM Yu-cheng Yu wrote: > > When shadow stack is enabled, a task's shadow stack states must be saved > along with the signal context and later restored in sigreturn. However, > currently there is no systematic facility for extending a signal context. > > Introduce a

[PATCH v2 8/8] KVM: SVM: Allocate SEV command structures on local stack

2021-04-06 Thread Sean Christopherson
Use the local stack to "allocate" the structures used to communicate with the PSP. The largest struct used by KVM, sev_data_launch_secret, clocks in at 52 bytes, well within the realm of reasonable stack usage. The smallest structs are a mere 4 bytes, i.e. the pointer for the allocation is

[PATCH v2 7/8] crypto: ccp: Use the stack and common buffer for INIT command

2021-04-06 Thread Sean Christopherson
Drop the dedicated init_cmd_buf and instead use a local variable. Now that the low level helper uses an internal buffer for all commands, using the stack for the upper layers is safe even when running with CONFIG_VMAP_STACK=y. Signed-off-by: Sean Christopherson --- drivers/crypto/ccp/sev-dev.c

[PATCH v2 6/8] crypto: ccp: Use the stack and common buffer for status commands

2021-04-06 Thread Sean Christopherson
Drop the dedicated status_cmd_buf and instead use a local variable for PLATFORM_STATUS. Now that the low level helper uses an internal buffer for all commands, using the stack for the upper layers is safe even when running with CONFIG_VMAP_STACK=y. Signed-off-by: Sean Christopherson ---

Re: [PATCH v3 2/5] RISC-V: Add kexec support

2021-04-06 Thread Alex Ghiti
Le 4/5/21 à 4:57 AM, Nick Kossifidis a écrit : This patch adds support for kexec on RISC-V. On SMP systems it depends on HOTPLUG_CPU in order to be able to bring up all harts after kexec. It also needs a recent OpenSBI version that supports the HSM extension. I tested it on riscv64 QEMU on

Re: [Intel-gfx] [PATCH] drm/i915/dpcd_bl: Don't try vesa interface unless specified by VBT

2021-04-06 Thread Jani Nikula
On Tue, 23 Mar 2021, Lyude Paul wrote: > On Tue, 2021-03-23 at 16:06 +0200, Jani Nikula wrote: >> On Thu, 18 Mar 2021, Lyude Paul wrote: >> > Actually-NAK this. I just realized I've been misreading the bug and that >> > this >> > doesn't actually seem to be fixed. Will resend once I figure out

Re: [PATCH v1 1/1] kernel.h: Split out panic and oops helpers

2021-04-06 Thread Kees Cook
On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote: > kernel.h is being used as a dump for all kinds of stuff for a long time. > Here is the attempt to start cleaning it up by splitting out panic and > oops helpers. > > At the same time convert users in header and lib folder to use

Re: [PATCH 14/16] dt-bindings: phy: Convert Cadence DPHY binding to YAML

2021-04-06 Thread Pratyush Yadav
On 02/04/21 01:23PM, Laurent Pinchart wrote: > Hi Pratyush, > > Thank you for the patch. > > On Tue, Mar 30, 2021 at 11:03:46PM +0530, Pratyush Yadav wrote: > > Convert Cadence DPHY binding to YAML. > > > > Signed-off-by: Pratyush Yadav > > --- > > .../devicetree/bindings/phy/cdns,dphy.txt

Re: [PATCH 11/16] dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX

2021-04-06 Thread Péter Ujfalusi
On 4/6/21 8:10 PM, Pratyush Yadav wrote: > On 06/04/21 10:25PM, Pratyush Yadav wrote: >> On 06/04/21 06:33PM, Péter Ujfalusi wrote: >>> >>> >>> On 4/6/21 6:09 PM, Pratyush Yadav wrote: On 04/04/21 04:24PM, Péter Ujfalusi wrote: > Hi Pratyush, > > On 3/30/21 8:33 PM, Pratyush

Re: [PATCH 1/4] x86/mce: Fix copyin code to return -EFAULT on machine check.

2021-04-06 Thread Borislav Petkov
On Thu, Mar 25, 2021 at 05:02:32PM -0700, Tony Luck wrote: > When copy from user fails due to a machine check on poison reading > user data it should return an error code. > > --- > > Separate patch just now, but likely needs to be combined with patches > to iteration code for bisection safety.

Re: [PATCH 02/12] ARM: davinci: Constify the software nodes

2021-04-06 Thread Wolfram Sang
On Mon, Mar 29, 2021 at 01:50:37PM +0300, Heikki Krogerus wrote: > Additional device properties are always just a part of a > software fwnode. If the device properties are constant, the > software node can also be constant. > > Signed-off-by: Heikki Krogerus > Cc: Sekhar Nori > Cc: Bartosz

Re: [PATCH 04/12] ARM: pxa: stargate2: Constify the software node

2021-04-06 Thread Wolfram Sang
On Mon, Mar 29, 2021 at 01:50:39PM +0300, Heikki Krogerus wrote: > Additional device properties are always just a part of a > software fwnode. If the device properties are constant, the > software node can also be constant. > > Signed-off-by: Heikki Krogerus > Cc: Jonathan Cameron > Cc: Daniel

Re: [PATCH 1/2] thermal: power_allocator: maintain the device statistics from going stale

2021-04-06 Thread Daniel Lezcano
On 06/04/2021 20:38, Lukasz Luba wrote: [ ... ] >> But there is still the polling delay because the governor is IPA in this >> case? There is also an additional trip-point0 which is not a target for >> a cooling device, just put there to ensure the IPA has enough data when >> reaching the second

Re: [PATCH v6 3/5] i2c: add support for HiSilicon I2C controller

2021-04-06 Thread Wolfram Sang
Only super minor stuff. Thanks to all the contributors and reviewers! > +#define HZ_PER_KHZ 1000 KHZ_PER_HZ? > + ret = devm_i2c_add_adapter(dev, adapter); > + if (ret) { > + dev_err(dev, "failed to add i2c adapter, ret = %d\n", ret); No need to print that. The core

Re: [PATCH] i2c: stm32f7: avoid ifdef CONFIG_PM_SLEEP for pm callbacks

2021-04-06 Thread Wolfram Sang
On Fri, Mar 12, 2021 at 12:53:27PM +0100, Alain Volmat wrote: > Avoid CONFIG_PM preprocessor check for pm suspend/resume > callbacks and identify the functions with __maybe_unused. > > Signed-off-by: Alain Volmat Applied to for-next, thanks! signature.asc Description: PGP signature

Re: [PATCH V4 XRT Alveo 19/20] fpga: xrt: partition isolation platform driver

2021-04-06 Thread Tom Rix
On 3/23/21 10:29 PM, Lizhi Hou wrote: Add partition isolation platform driver. partition isolation is a hardware function discovered by walking firmware metadata. A platform device node will be created for it. Partition isolation function isolate the different fpga regions Signed-off-by:

Re: [PATCH V4 XRT Alveo 04/20] fpga: xrt: xrt-lib platform driver manager

2021-04-06 Thread Max Zhen
Hi Tom, On 3/29/21 12:44 PM, Tom Rix wrote: bisectablity may be/is an issue. Moritz, building happens on the last patch, so in theory there will never be a build break needing bisection. Do we care about the misordering of serveral of these patches? The general idea about ordering of

Re: [PATCH 01/11] block: rsxx: core: Remove superfluous const qualifier

2021-04-06 Thread Bart Van Assche
On 3/12/21 2:55 AM, Lee Jones wrote: > This function returns a const string. > > The second const qualifier is not required. > > Fixes the following W=1 kernel build warning(s): > > drivers/block/rsxx/core.c:395:8: warning: type qualifiers ignored on > function return type

Re: [PATCH 03/11] block: mtip32xx: mtip32xx: Mark debugging variable 'start' as __maybe_unused

2021-04-06 Thread Bart Van Assche
On 3/12/21 2:55 AM, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/block/mtip32xx/mtip32xx.c: In function ‘mtip_standby_immediate’: > drivers/block/mtip32xx/mtip32xx.c:1216:16: warning: variable ‘start’ set but > not used [-Wunused-but-set-variable] Has it

Re: [PATCH][next] net/mlx5: Fix bit-wise and with zero

2021-04-06 Thread Laurence Oberman
On Tue, 2021-04-06 at 17:53 +0100, Colin King wrote: > From: Colin Ian King > > The bit-wise and of the action field with > MLX5_ACCEL_ESP_ACTION_DECRYPT > is incorrect as MLX5_ACCEL_ESP_ACTION_DECRYPT is zero and not > intended > to be a bit-flag. Fix this by using the == operator as was

Re: [PATCH] kunit: fix -Wunused-function warning for __kunit_fail_current_test

2021-04-06 Thread Shuah Khan
On 4/6/21 2:50 PM, Brendan Higgins wrote: On Tue, Apr 6, 2021 at 10:29 AM Daniel Latypov wrote: When CONFIG_KUNIT is not enabled, __kunit_fail_current_test() an empty static function. But GCC complains about unused static functions, *unless* they're static inline. So add inline to make GCC

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

2021-04-06 Thread Arnd Bergmann
On Tue, Apr 6, 2021 at 12:11 AM Stephen Rothwell wrote: > > Hi all, > > On Tue, 6 Apr 2021 08:11:00 +1000 Stephen Rothwell > wrote: > > > > Hi all, > > > > Commit > > > > 3b493ac0ac04 ("arm64: dts: allwinner: h6: Switch to macros for RSB > > clock/reset indices") > > > > is missing a

[PATCH 0/4] perf events vendor amd: Fixes, cleanups and updates for AMD Zen cores

2021-04-06 Thread Smita Koralahalli
This series of patches provides a fix for the broken metric and does some cleanup for AMD Zen1/Zen2 cores. Additionally, adds Zen3 events. The first patch fixes broken L2 Cache Hits from L2 HWPF recommended event. The second and third patches addresses the inconsistency by defaulting all event

Re: [PATCH v2 00/10] Initial support for Nuvoton WPCM450 BMC SoC

2021-04-06 Thread Jonathan Neuschäfer
On Tue, Apr 06, 2021 at 05:15:01PM +0200, Arnd Bergmann wrote: > On Tue, Apr 6, 2021 at 2:09 PM Jonathan Neuschäfer > wrote: > > > > This series adds basic support for the Nuvoton WPCM450 BMC SoC. It's an > > older > > SoC but still commonly found on eBay, mostly in Supermicro X9 server boards.

Re: [PATCH] inode: Remove second initialization of the bpf_preload_lock

2021-04-06 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Tue, 6 Apr 2021 00:49:04 +0500 you wrote: > bpf_preload_lock is already defined with DEFINE_MUTEX. There is no need > to initialize it again. Remove the extraneous initialization. > > Signed-off-by: Muhammad Usama Anjum

[GIT PULL v2] coresight: Add support for ETE and TRBE

2021-04-06 Thread Mathieu Poirier
The following changes since commit a354a64d91eec3e0f8ef0eed575b480fd75b999c: KVM: arm64: Disable guest access to trace filter controls (2021-03-24 17:26:38 +) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git next-ETE-TRBE for

Re: linux-next: Tree for Apr 6 (arch/x86/mm/init_64.c)

2021-04-06 Thread Randy Dunlap
spin_unlock(_mm.page_table_lock); > } > > This is what I am using for now: --- --- arch/x86/mm/init_64.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) --- linux-next-20210406.orig/

Re: Usage of CXX in tools directory

2021-04-06 Thread Nick Desaulniers
On Sun, Apr 4, 2021 at 8:00 AM Sedat Dilek wrote: > > [ Please CC me I am not subscribed to all mailing-lists ] > [ Please CC some more folks if you like ] > > Hi, > > when dealing/experimenting with BPF together with pahole/dwarves and > dwarf-v5 and clang-lto I fell over that there is usage of

Re: [PATCH v2] hwmon: (sbtsi) Don't read sensor more than once if it doesn't respond

2021-04-06 Thread Guenter Roeck
On 4/6/21 11:16 AM, Konstantin Aladyshev wrote: > SBTSI sensors don't work when the CPU is off. > In this case every 'i2c_smbus_read_byte_data' function would fail > by a timeout. > Currently temp1_max/temp1_min file reads can cause two such timeouts > for every read. > Restructure code so there

[PATCH bpf-next] libbpf: clarify flags in ringbuf helpers

2021-04-06 Thread Pedro Tammela
In 'bpf_ringbuf_reserve()' we require the flag to '0' at the moment. For 'bpf_ringbuf_{discard,submit,output}' a flag of '0' might send a notification to the process if needed. Signed-off-by: Pedro Tammela --- include/uapi/linux/bpf.h | 7 +++ tools/include/uapi/linux/bpf.h | 7

Re: [PATCH 1/3] loop: Use worker per cgroup instead of kworker

2021-04-06 Thread Dan Schatzberg
Hi Hillf, thanks for the review On Sat, Apr 03, 2021 at 10:09:02AM +0800, Hillf Danton wrote: > On Fri, 2 Apr 2021 12:16:32 Dan Schatzberg wrote: > > +queue_work: > > + if (worker) { > > + /* > > +* We need to remove from the idle list here while > > +*

Re: [PATCH] tty: use printk_safe context at tty_msg()

2021-04-06 Thread Greg Kroah-Hartman
On Wed, Apr 07, 2021 at 01:22:34AM +0900, Tetsuo Handa wrote: > On 2021/04/07 0:10, Petr Mladek wrote: > >> diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c > >> index 6d4995a5f318..d59f7873bc49 100644 > >> --- a/drivers/tty/tty_buffer.c > >> +++ b/drivers/tty/tty_buffer.c > >> @@

Re: [PATCH] fs: btrfs: Remove repeated struct declaration

2021-04-06 Thread David Sterba
On Thu, Apr 01, 2021 at 04:03:39PM +0800, Wan Jiabing wrote: > struct btrfs_inode is declared twice. One is declared at 67th line. > The blew declaration is not needed. Remove the duplicate. > struct btrfs_fs_info should be declared in the forward declarations. > Move it to the forward

Re: [PATCH] vfio: pci: Spello fix in the file vfio_pci.c

2021-04-06 Thread Alex Williamson
On Sun, 14 Mar 2021 10:59:25 +0530 Bhaskar Chowdhury wrote: > s/permision/permission/ > > Signed-off-by: Bhaskar Chowdhury > --- > drivers/vfio/pci/vfio_pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c >

Re: [PATCH 1/2] vfio/pci: remove vfio_pci_nvlink2

2021-04-06 Thread Alex Williamson
On Fri, 26 Mar 2021 07:13:10 +0100 Christoph Hellwig wrote: > This driver never had any open userspace (which for VFIO would include > VM kernel drivers) that use it, and thus should never have been added > by our normal userspace ABI rules. > > Signed-off-by: Christoph Hellwig > Acked-by:

Re: [PATCH v1] vfio/type1: Remove the almost unused check in vfio_iommu_type1_unpin_pages

2021-04-06 Thread Alex Williamson
On Tue, 6 Apr 2021 21:50:09 +0800 Shenming Lu wrote: > The check i > npage at the end of vfio_iommu_type1_unpin_pages is unused > unless npage < 0, but if npage < 0, this function will return npage, which > should return -EINVAL instead. So let's just check the parameter npage at > the start of

Re: [PATCH 0/4] vfio: fix a couple of spelling mistakes detected by codespell tool

2021-04-06 Thread Alex Williamson
On Fri, 26 Mar 2021 16:35:24 +0800 Zhen Lei wrote: > This detection and correction covers the entire driver/vfio directory. > > Zhen Lei (4): > vfio/type1: fix a couple of spelling mistakes > vfio/mdev: Fix spelling mistake "interal" -> "internal" > vfio/pci: fix a couple of spelling

Re: [PATCH 00/12] i2c: Adding support for software nodes

2021-04-06 Thread Wolfram Sang
> I think these go via I2C tree. Good, I'll apply it this weekend. Until then, let's hope we can get some more acks. signature.asc Description: PGP signature

Re: [PATCH] btrfs: Use readahead_batch_length

2021-04-06 Thread David Sterba
On Sun, Mar 21, 2021 at 09:03:11PM +, Matthew Wilcox (Oracle) wrote: > Implement readahead_batch_length() to determine the number of bytes in > the current batch of readahead pages and use it in btrfs. > > Signed-off-by: Matthew Wilcox (Oracle) Thanks, I'll take it through my tree as btrfs

Re: [PATCH 5.10 096/126] KVM: x86/mmu: Use atomic ops to set SPTEs in TDP MMU map

2021-04-06 Thread Sasha Levin
On Tue, Apr 06, 2021 at 08:28:27PM +0200, Paolo Bonzini wrote: If a patch doesn't (more or less trivially) apply, the maintainer should take action. Distro maintainers can also jump in and post the backport to subsystem mailing lists. If the stable kernel loses a patch because a maintainer

Re: [RESEND PATCH] staging: emxx_udc: Ending line with argument

2021-04-06 Thread Beatriz Martins de Carvalho
Em 06/04/21 20:36, Greg KH escreveu: On Tue, Apr 06, 2021 at 08:34:09PM +0100, Beatriz Martins de Carvalho wrote: Cleans up check of "Lines should not end with a '('" with argument present in next line in file emxx_udc.c Signed-off-by: Beatriz Martins de Carvalho ---

Re: [PATCH v11 08/13] KVM: X86: Introduce KVM_HC_PAGE_ENC_STATUS hypercall

2021-04-06 Thread Steve Rutherford
On Tue, Apr 6, 2021 at 9:08 AM Ashish Kalra wrote: > > On Tue, Apr 06, 2021 at 03:48:20PM +, Sean Christopherson wrote: > > On Mon, Apr 05, 2021, Ashish Kalra wrote: > > > From: Ashish Kalra > > > > ... > > > > > diff --git a/arch/x86/include/asm/kvm_host.h > > >

Re: [git pull] a couple of fixes in vfs.git

2021-04-06 Thread pr-tracker-bot
The pull request you sent on Tue, 6 Apr 2021 17:15:11 +: > git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git fixes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/2d743660786ec51f5c1fefd5782bbdee7b227db0 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH v2] binder: tell userspace to dump current backtrace when detecting oneway spamming

2021-04-06 Thread Todd Kjos
On Thu, Apr 1, 2021 at 1:29 AM Hang Lu wrote: > > When async binder buffer got exhausted, some normal oneway transaction > will also be discarded and finally caused system/app stop. "...be discarded and may cause system or application failures" ? > By that time, > the binder debug information

[syzbot] possible deadlock in team_device_event (2)

2021-04-06 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:bd78980b net: usb: ax88179_178a: initialize local variable.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=1043f831d0 kernel config: https://syzkaller.appspot.com/x/.config?x=7eff0f22b8563a5f

Re: [PATCH v11 08/13] KVM: X86: Introduce KVM_HC_PAGE_ENC_STATUS hypercall

2021-04-06 Thread Sean Christopherson
On Tue, Apr 06, 2021, Steve Rutherford wrote: > On Tue, Apr 6, 2021 at 9:08 AM Ashish Kalra wrote: > > I see the following in Documentation/virt/kvm/api.rst : > > .. > > .. > > /* KVM_EXIT_HYPERCALL */ > > struct { > > __u64 nr; > >

[PATCH RFC net 1/2] net: dsa: lantiq_gswip: Don't use PHY auto polling

2021-04-06 Thread Martin Blumenstingl
PHY auto polling on the GSWIP hardware can be used so link changes (speed, link up/down, etc.) can be detected automatically. Internally GSWIP reads the PHY's registers for this functionality. Based on this automatic detection GSWIP can also automatically re-configure it's port settings.

[PATCH RFC net 2/2] net: dsa: lantiq_gswip: Configure all remaining GSWIP_MII_CFG bits

2021-04-06 Thread Martin Blumenstingl
There are a few more bits in the GSWIP_MII_CFG register for which we did rely on the boot-loader (or the hardware defaults) to set them up properly. For some external RMII PHYs we need to select the GSWIP_MII_CFG_RMII_CLK bit and also we should un-set it for non-RMII PHYs. The GSWIP IP also

Re: [PATCH v3 1/2] PCI: xilinx-nwl: Enable coherent PCIe DMA traffic using CCI

2021-04-06 Thread Rob Herring
On Tue, Apr 6, 2021 at 9:20 AM Lorenzo Pieralisi wrote: > > [+ Rob, Robin] > > On Mon, Feb 22, 2021 at 02:17:31PM +0530, Bharat Kumar Gogada wrote: > > Add support for routing PCIe DMA traffic coherently when > > Cache Coherent Interconnect (CCI) is enabled in the system. > > The "dma-coherent"

[PATCH RFC net 0/2] lantiq: GSWIP: two more fixes

2021-04-06 Thread Martin Blumenstingl
Hello, after my last patch got accepted and is now in net as commit 3e6fdeb28f4c33 ("net: dsa: lantiq_gswip: Let GSWIP automatically set the xMII clock") [0] some more people from the OpenWrt community (many thanks to everyone involved) helped test the GSWIP driver: [1] It turns out that the

Re: [PATCH] kunit: fix -Wunused-function warning for __kunit_fail_current_test

2021-04-06 Thread Brendan Higgins
On Tue, Apr 6, 2021 at 10:29 AM Daniel Latypov wrote: > > When CONFIG_KUNIT is not enabled, __kunit_fail_current_test() an empty > static function. > > But GCC complains about unused static functions, *unless* they're static > inline. > So add inline to make GCC happy. > > Signed-off-by: Daniel

Re: [PATCH v2] hwmon: (sbtsi) Don't read sensor more than once if it doesn't respond

2021-04-06 Thread Konstantin Aladyshev
Thanks for the answer! Sorry for the confusion, by the "CPU is off" I meant "CPU is present, but currently it is in the powered off state". Therefore it is not possible to put these checks only in a probe function. And I don't know either if it is a good idea to cache config/min/max values. I use

[PATCH v2 3/8] crypto: ccp: Reject SEV commands with mismatching command buffer

2021-04-06 Thread Sean Christopherson
WARN on and reject SEV commands that provide a valid data pointer, but do not have a known, non-zero length. And conversely, reject commands that take a command buffer but none is provided (data is null). Aside from sanity checking input, disallowing a non-null pointer without a non-zero size

[PATCH v2 4/8] crypto: ccp: Play nice with vmalloc'd memory for SEV command structs

2021-04-06 Thread Sean Christopherson
Copy the incoming @data comman to an internal buffer so that callers can put SEV command buffers on the stack without running afoul of CONFIG_VMAP_STACK=y, i.e. without bombing on vmalloc'd pointers. As of today, the largest supported command takes a 68 byte buffer, i.e. pretty much every command

[PATCH v2 5/8] crypto: ccp: Use the stack for small SEV command buffers

2021-04-06 Thread Sean Christopherson
For commands with small input/output buffers, use the local stack to "allocate" the structures used to communicate with the PSP. Now that __sev_do_cmd_locked() gracefully handles vmalloc'd buffers, there's no reason to avoid using the stack, e.g. CONFIG_VMAP_STACK=y will just work.

[PATCH v2 1/8] crypto: ccp: Free SEV device if SEV init fails

2021-04-06 Thread Sean Christopherson
Free the SEV device if later initialization fails. The memory isn't technically leaked as it's tracked in the top-level device's devres list, but unless the top-level device is removed, the memory won't be freed and is effectively leaked. Signed-off-by: Sean Christopherson ---

[PATCH v2 2/8] crypto: ccp: Detect and reject "invalid" addresses destined for PSP

2021-04-06 Thread Sean Christopherson
Explicitly reject using pointers that are not virt_to_phys() friendly as the source for SEV commands that are sent to the PSP. The PSP works with physical addresses, and __pa()/virt_to_phys() will not return the correct address in these cases, e.g. for a vmalloc'd pointer. At best, the bogus

Re: [PATCH 1/4] hwtracing: Add trace function support for HiSilicon PCIe Tune and Trace device

2021-04-06 Thread kernel test robot
Hi Yicong, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.12-rc6 next-20210406] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented

[PATCH v2 0/8] ccp: KVM: SVM: Use stack for SEV command buffers

2021-04-06 Thread Sean Christopherson
This series teaches __sev_do_cmd_locked() to gracefully handle vmalloc'd command buffers by copying _all_ incoming data pointers to an internal buffer before sending the command to the PSP. The SEV driver and KVM are then converted to use the stack for all command buffers. Tested everything

Re: [PATCH v24 24/30] x86/cet/shstk: Introduce shadow stack token setup/verify routines

2021-04-06 Thread Andy Lutomirski
On Thu, Apr 1, 2021 at 3:12 PM Yu-cheng Yu wrote: > > A shadow stack restore token marks a restore point of the shadow stack, and > the address in a token must point directly above the token, which is within > the same shadow stack. This is distinctively different from other pointers > on the

Re: [PATCH 1/2] thermal: power_allocator: maintain the device statistics from going stale

2021-04-06 Thread Lukasz Luba
On 4/6/21 3:32 PM, Daniel Lezcano wrote: Hi Lukasz, On 06/04/2021 14:25, Lukasz Luba wrote: On 4/6/21 12:24 PM, Daniel Lezcano wrote: [snip] In your proposed code there is 'tz->last_temperature < switch_on_temp' which then return 0 immediately. So we don't poke the devices. Ah

Re: [PATCH] KVM: x86/mmu: preserve pending TLB flush across calls to kvm_tdp_mmu_zap_sp

2021-04-06 Thread Greg KH
On Tue, Apr 06, 2021 at 08:35:55PM +0200, Paolo Bonzini wrote: > On 06/04/21 20:25, Greg KH wrote: > > On Tue, Apr 06, 2021 at 12:25:50PM -0400, Paolo Bonzini wrote: > > > Right now, if a call to kvm_tdp_mmu_zap_sp returns false, the caller > > > will skip the TLB flush, which is wrong. There are

Re: [PATCH 5.10 079/126] drm/tegra: sor: Grab runtime PM reference across reset

2021-04-06 Thread Pavel Machek
Hi! > > > However, these functions alone don't provide any guarantees at the > > > system level. Drivers need to ensure that the only a single consumer has > > > access to the reset at the same time. In order for the SOR to be able to > > > exclusively access its reset, it must therefore ensure

Re: [PATCH 1/1] of: properly check for error returned by fdt_get_name()

2021-04-06 Thread Rob Herring
On Sun, 04 Apr 2021 22:28:45 -0500, frowand.l...@gmail.com wrote: > From: Frank Rowand > > fdt_get_name() returns error values via a parameter pointer > instead of in function return. Fix check for this error value > in populate_node() and callers of populate_node(). > > Chasing up the caller

Re: [PATCH 1/1] of: properly check for error returned by fdt_get_name()

2021-04-06 Thread Rob Herring
On Sun, Apr 04, 2021 at 10:28:45PM -0500, frowand.l...@gmail.com wrote: > From: Frank Rowand > > fdt_get_name() returns error values via a parameter pointer > instead of in function return. Fix check for this error value > in populate_node() and callers of populate_node(). > > Chasing up the

Re: [PATCH 05/12] ARM: s3c: mini2440: Constify the software node

2021-04-06 Thread Wolfram Sang
> Thanks for explanation. The follow up question is - can I take it > independently via ARM Samsung/S3C tree? Is it possible to just ack it, so I can take this all via I2C? Or will there be merge conflicts. I can provide an immutable branch, of course. signature.asc Description: PGP signature

Re: [PATCH net-next v2 0/2] Enable 2.5Gbps speed for stmmac

2021-04-06 Thread Andrew Lunn
> The limitation is not on the MAC, PCS or the PHY. For Intel mgbe, the > overclocking of 2.5 times clock rate to support 2.5G is only able to be > configured in the BIOS during boot time. Kernel driver has no access to > modify the clock rate for 1Gbps/2.5G mode. The way to determined the >

Re: [PATCH v3 13/25] x86/sgx: Add helpers to expose ECREATE and EINIT to KVM

2021-04-06 Thread Kai Huang
On Tue, 6 Apr 2021 19:08:58 +0200 Borislav Petkov wrote: > On Tue, Apr 06, 2021 at 09:41:52PM +1200, Kai Huang wrote: > > > Ok, I'll make the changes and you can redo the KVM rest ontop. > > > > > > > Thank you! > > I.e., something like this: Looks good. I'll update KVM part patches based on

Re: [PATCH] i2c: exynos5: correct top kerneldoc

2021-04-06 Thread Wolfram Sang
On Mon, Apr 05, 2021 at 08:14:05PM +0200, Krzysztof Kozlowski wrote: > The top comment is not a kerneldoc, as W=1 build reports: > > drivers/i2c/busses/i2c-exynos5.c:39: warning: > expecting prototype for i2c(). Prototype was for HSI2C_CTL() instead > > Signed-off-by: Krzysztof Kozlowski

[PATCH] staging: rtl8712: Use constants from

2021-04-06 Thread Christophe JAILLET
Some constants defined in wifi.h are already defined in with some other (but similar) names. Be consistent and use the ones from . The conversions made are: _SSID_IE_--> WLAN_EID_SSID _SUPPORTEDRATES_IE_ --> WLAN_EID_SUPP_RATES _DSSET_IE_ -->

[PATCH 02/11] staging: rtl8188eu: ctrl vendor req value is always 0x05

2021-04-06 Thread Martin Kaiser
The bRequest value for the vendor specific control requests sent by this driver is always 0x05. Replace the function parameter with a define. Use the same define as the rtlwifi driver. Signed-off-by: Martin Kaiser --- .../staging/rtl8188eu/os_dep/usb_ops_linux.c | 32 +++ 1

[PATCH 04/11] staging: rtl8188eu: use actual request type as parameter

2021-04-06 Thread Martin Kaiser
At the moment, usbctrl_vendorreq's requesttype parameter must be set to 1 for reading and 0 for writing. It's then converted to the actual bmRequestType for the USB control request. We can simplify the code and avoid this conversion if the caller passes the actual bmRequestType. We already have

[PATCH 05/11] staging: rtl8188eu: clean up usb_read8

2021-04-06 Thread Martin Kaiser
Remove unnecessary variable, summarize declaration and assignment. Signed-off-by: Martin Kaiser --- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c

[PATCH 07/11] staging: rtl8188eu: clean up usb_read32

2021-04-06 Thread Martin Kaiser
Remove unnecessary variable, summarize declaration and assignment. Signed-off-by: Martin Kaiser --- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c

[PATCH 06/11] staging: rtl8188eu: clean up usb_read16

2021-04-06 Thread Martin Kaiser
Remove unnecessary variable, summarize declaration and assignment. Signed-off-by: Martin Kaiser --- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c

[PATCH 08/11] staging: rtl8188eu: clean up usb_write8

2021-04-06 Thread Martin Kaiser
Remove unnecessary variable, summarize declaration and assignment. Signed-off-by: Martin Kaiser --- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c

[PATCH 10/11] staging: rtl8188eu: clean up usb_write32

2021-04-06 Thread Martin Kaiser
Remove unnecessary variable, summarize declaration and assignment. Signed-off-by: Martin Kaiser --- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c

[PATCH 09/11] staging: rtl8188eu: clean up usb_write16

2021-04-06 Thread Martin Kaiser
Remove unnecessary variable, summarize declaration and assignment. Signed-off-by: Martin Kaiser --- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c

[PATCH 03/11] staging: rtl8188eu: ctrl vendor req index is not used

2021-04-06 Thread Martin Kaiser
The index for rtl8188eu's vendor-specific control requests is not used. Remove the index parameter from usbctrl_vendorreq and pass index 0 to usb_control_msg. Signed-off-by: Martin Kaiser --- .../staging/rtl8188eu/os_dep/usb_ops_linux.c | 33 ++- 1 file changed, 10

[PATCH] inotify: fix minmax.cocci warnings

2021-04-06 Thread Julia Lawall
From: kernel test robot Opportunity for min(). Generated by: scripts/coccinelle/misc/minmax.cocci Fixes: 8636e3295ce3 ("coccinelle: misc: add minmax script") CC: Denis Efremov Reported-by: kernel test robot Signed-off-by: kernel test robot Signed-off-by: Julia Lawall --- tree:

[PATCH 11/11] staging: rtl8188eu: remove an obsolete comment

2021-04-06 Thread Martin Kaiser
This driver does not set URB_ZERO_PACKET. The rtl8188eu driver that's available from Realtek/Edimax has some commented-out code that sets zero packet. It was removed from this driver before it was imported. Signed-off-by: Martin Kaiser --- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 2

Re: [PATCH V4 XRT Alveo 20/20] fpga: xrt: Kconfig and Makefile updates for XRT drivers

2021-04-06 Thread Tom Rix
On 3/23/21 10:29 PM, Lizhi Hou wrote: Update fpga Kconfig/Makefile and add Kconfig/Makefile for new drivers. Signed-off-by: Sonal Santan Signed-off-by: Max Zhen Signed-off-by: Lizhi Hou --- MAINTAINERS| 11 +++ drivers/Makefile | 1 +

Re: [PATCH 02/11] block: drbd: drbd_interval: Demote some kernel-doc abuses and fix another header

2021-04-06 Thread Bart Van Assche
On 3/12/21 2:55 AM, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > [ ... ] Reviewed-by: Bart Van Assche

Re: [PATCH V4 XRT Alveo 12/20] fpga: xrt: VSEC platform driver

2021-04-06 Thread Lizhi Hou
On 04/02/2021 07:12 AM, Tom Rix wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. local use of 'regmap' conflicts with global meaning. reword local regmap to

Re: [PATCH 5.10 004/126] ext4: shrink race window in ext4_should_retry_alloc()

2021-04-06 Thread Eric Whitney
* Pavel Machek : > Hi! > > > From: Eric Whitney > > > A per filesystem percpu counter exported via sysfs is added to allow > > users or developers to track the number of times the retry limit is > > exceeded without resorting to debugging methods. This should provide > > some insight into

  1   2   3   4   5   6   7   8   9   10   >