Re: [PATCH] RDMA/hw/qib/qib_iba7322: remove useless function

2021-04-13 Thread Jason Gunthorpe
On Tue, Apr 13, 2021 at 05:11:03PM +0800, Jiapeng Chong wrote: > Fix the following clang warning: > > drivers/infiniband/hw/qib/qib_iba7322.c:803:19: warning: unused function > 'qib_read_ureg' [-Wunused-function]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/infi

Re: [PATCH v3 30/33] dt-bindings: media: add microchip,xisc device bindings

2021-04-13 Thread Rob Herring
On Tue, Apr 13, 2021 at 01:57:28PM +0300, Eugen Hristev wrote: > Add bindings for the Microchip eXtended Image Sensor Controller. > Based on the atmel,isc.yaml binding. > > Signed-off-by: Eugen Hristev > --- > .../bindings/media/microchip,xisc.yaml| 129 ++ > 1 file chang

Re: [PATCH v7 2/3] dt-bindings: touchscreen: Add HY46XX bindings

2021-04-13 Thread Rob Herring
On Tue, 13 Apr 2021 16:44:45 +0200, Giulio Benetti wrote: > This adds device tree bindings for the Hycon HY46XX touchscreen series. > > Signed-off-by: Giulio Benetti > --- > V1->V2: > As suggested by Rob Herring: > * fixed $id: address > * added "hycon," in front of every custom property > * chan

[PATCH v3] staging: media: zoran: reduce length of a line

2021-04-13 Thread Mitali Borkar
Reduced length of a line which exceed the 100 columns limit by splitting the line into two statements and commenting it with '*' to meet linux kernel coding style for long(multi-line) comments. Reported by checkpatch. Signed-off-by: Mitali Borkar --- Changes from v2:- Rebased this patch and made

Re: [PATCH v1 2/2] powerpc/atomics: Use immediate operand when possible

2021-04-13 Thread Christophe Leroy
Le 13/04/2021 à 00:08, Segher Boessenkool a écrit : Hi! On Thu, Apr 08, 2021 at 03:33:45PM +, Christophe Leroy wrote: +#define ATOMIC_OP(op, asm_op, dot, sign) \ static __inline__ void atomic_##op(int a, atomic_t *v) \ {

[PATCH v2 1/3] powerpc/bitops: Use immediate operand when possible

2021-04-13 Thread Christophe Leroy
Today we get the following code generation for bitops like set or clear bit: c0009fe0: 39 40 08 00 li r10,2048 c0009fe4: 7c e0 40 28 lwarx r7,0,r8 c0009fe8: 7c e7 53 78 or r7,r7,r10 c0009fec: 7c e0 41 2d stwcx. r7

[PATCH v2 2/3] powerpc/atomics: Use immediate operand when possible

2021-04-13 Thread Christophe Leroy
Today we get the following code generation for atomic operations: c001bb2c: 39 20 00 01 li r9,1 c001bb30: 7d 40 18 28 lwarx r10,0,r3 c001bb34: 7d 09 50 50 subfr8,r9,r10 c001bb38: 7d 00 19 2d stwcx. r8,0,r3

[PATCH v2 3/3] powerpc/atomics: Remove atomic_inc()/atomic_dec() and friends

2021-04-13 Thread Christophe Leroy
Now that atomic_add() and atomic_sub() handle immediate operands, atomic_inc() and atomic_dec() have no added value compared to the generic fallback which calls atomic_add(1) and atomic_sub(1). Also remove atomic_inc_not_zero() which fallsback to atomic_add_unless() which itself fallsback to atomi

Re: [PATCH] hwmon: (nct6683) remove useless function

2021-04-13 Thread Guenter Roeck
On Tue, Apr 13, 2021 at 02:02:50PM +0800, Jiapeng Chong wrote: > Fix the following clang warning: > > drivers/hwmon/nct6683.c:491:19: warning: unused function 'in_to_reg' > [-Wunused-function]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Applied. Thanks, Guenter > --- > driv

[PATCH v2 2/2] powerpc/bug: Provide better flexibility to WARN_ON/__WARN_FLAGS() with asm goto

2021-04-13 Thread Christophe Leroy
Using asm goto in __WARN_FLAGS() and WARN_ON() allows more flexibility to GCC. For that add an entry to the exception table so that program_check_exception() knowns where to resume execution after a WARNING. Here are two exemples. The first one is done on PPC32 (which benefits from the previous p

[PATCH v2 1/2] powerpc/bug: Remove specific powerpc BUG_ON() and WARN_ON() on PPC32

2021-04-13 Thread Christophe Leroy
powerpc BUG_ON() and WARN_ON() are based on using twnei instruction. For catching simple conditions like a variable having value 0, this is efficient because it does the test and the trap at the same time. But most conditions used with BUG_ON or WARN_ON are more complex and forces GCC to format th

[PATCH net-next 0/2] net: ipa: add support for the SM8350 SoC

2021-04-13 Thread Alex Elder
This small series adds IPA driver support for the Qualcomm SM8350 SoC, which implements IPA v4.9. The first patch updates the DT binding, and depends on a previous patch that has already been accepted into net-next. The second just defines the IPA v4.9 configuration data file. (Device Tree files

[PATCH net-next 2/2] net: ipa: add IPA v4.9 configuration data

2021-04-13 Thread Alex Elder
Add support for the SM8350 SoC, which includes IPA version 4.9. Signed-off-by: Alex Elder --- drivers/net/ipa/Makefile| 3 +- drivers/net/ipa/ipa_data-v4.9.c | 430 drivers/net/ipa/ipa_data.h | 1 + drivers/net/ipa/ipa_main.c | 4 + 4 file

[PATCH net-next 1/2] dt-bindings: net: qcom,ipa: add support for SM8350

2021-04-13 Thread Alex Elder
Add support for "qcom,sm8350-ipa", which uses IPA v4.9. Use "enum" rather than "oneOf/const ..." to specify compatible strings, as suggested by Rob Herring. Signed-off-by: Alex Elder --- Documentation/devicetree/bindings/net/qcom,ipa.yaml | 11 ++- 1 file changed, 6 insertions(+), 5 del

Re: [PATCH v2 1/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU

2021-04-13 Thread John Garry
On 13/04/2021 10:12, liuqi (BA) wrote: I do wonder why we even need maintain pcie_pmu->cpumask Can't we just use cpu_online_mask as appropiate instead? ? Sorry, missed it yesterday. It seems that cpumask is always same as cpu_online_mask, So do we need to reserve the cpumask sysfs interface

[PATCH v2 3/4] powerpc: Rename probe_kernel_read_inst()

2021-04-13 Thread Christophe Leroy
When probe_kernel_read_inst() was created, it was to mimic probe_kernel_read() function. Since then, probe_kernel_read() has been renamed copy_from_kernel_nofault(). Rename probe_kernel_read_inst() into copy_from_kernel_nofault_inst(). Signed-off-by: Christophe Leroy --- arch/powerpc/include/a

[PATCH v2 4/4] powerpc: Move copy_from_kernel_nofault_inst()

2021-04-13 Thread Christophe Leroy
When probe_kernel_read_inst() was created, there was no good place to put it, so a file called lib/inst.c was dedicated for it. Since then, probe_kernel_read_inst() has been renamed copy_from_kernel_nofault_inst(). And mm/maccess.h didn't exist at that time. Today, mm/maccess.h is related to copy_

[PATCH v2 2/4] powerpc: Make probe_kernel_read_inst() common to PPC32 and PPC64

2021-04-13 Thread Christophe Leroy
We have two independant versions of probe_kernel_read_inst(), one for PPC32 and one for PPC64. The PPC32 is identical to the first part of the PPC64 version. The remaining part of PPC64 version is not relevant for PPC32, but not contradictory, so we can easily have a common function with the PPC64

[PATCH v2 1/4] powerpc: Remove probe_user_read_inst()

2021-04-13 Thread Christophe Leroy
Its name comes from former probe_user_read() function. That function is now called copy_from_user_nofault(). probe_user_read_inst() uses copy_from_user_nofault() to read only a few bytes. It is suboptimal. It does the same as get_user_inst() but in addition disables page faults. But on the other

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-13 Thread Jakub Kicinski
On Tue, 13 Apr 2021 18:06:39 +0200 Thierry Reding wrote: > given where we are in the release cycle, I think it'd be best to revert > commit 9c63faaa931e ("net: stmmac: re-init rx buffers when mac resume > back") for now. > > To summarize the discussion: the patch was meant as a workaround to fix >

Re: [PATCH v2 00/16] Multigenerational LRU Framework

2021-04-13 Thread SeongJae Park
From: SeongJae Park On Tue, 13 Apr 2021 10:13:24 -0600 Jens Axboe wrote: > On 4/13/21 1:51 AM, SeongJae Park wrote: > > From: SeongJae Park > > > > Hello, > > > > > > Very interesting work, thank you for sharing this :) > > > > On Tue, 13 Apr 2021 00:56:17 -0600 Yu Zhao wrote: > > > >> W

Re: [RFC PATCH] KVM: x86: Support write protect huge pages lazily

2021-04-13 Thread Ben Gardon
On Tue, Apr 13, 2021 at 2:39 AM Keqian Zhu wrote: > > > > On 2021/4/13 1:19, Ben Gardon wrote: > > On Tue, Apr 6, 2021 at 4:42 PM Sean Christopherson > > wrote: > >> > >> +Ben > >> > >> On Tue, Apr 06, 2021, Keqian Zhu wrote: > >>> Hi Paolo, > >>> > >>> I plan to rework this patch and do full te

Re: [Outreachy kernel] [PATCH] :staging: rtl8723bs: Remove useless led_blink_hdl()

2021-04-13 Thread Fabio M. De Francesco
On Tuesday, April 13, 2021 6:27:17 PM CEST Julia Lawall wrote: > On Tue, 13 Apr 2021, Fabio M. De Francesco wrote: > > On Tuesday, April 13, 2021 6:04:16 PM CEST Julia Lawall wrote: > > > On Tue, 13 Apr 2021, Fabio M. De Francesco wrote: > > > > Removed the led_blink_hdl() function (declaration, de

Re: [syzbot] general protection fault in gadget_setup

2021-04-13 Thread Dmitry Vyukov
On Tue, Apr 13, 2021 at 6:13 PM Alan Stern wrote: > > On Tue, Apr 13, 2021 at 10:12:05AM +0200, Dmitry Vyukov wrote: > > On Tue, Apr 13, 2021 at 10:08 AM syzbot > > wrote: > > > > > > Hello, > > > > > > syzbot found the following issue on: > > > > > > HEAD commit:0f4498ce Merge tag 'for-5.12/

Re: [PATCH 2/8] MIPS: pci-rt2880: remove unneeded locks

2021-04-13 Thread Ilya Lipnitskiy
Hi Sergey, On Tue, Apr 13, 2021 at 6:40 AM Sergey Ryazanov wrote: > > On Tue, Apr 13, 2021 at 4:28 PM Sergey Ryazanov > wrote: > > On Tue, Apr 13, 2021 at 9:22 AM Ilya Lipnitskiy > > wrote: > > > Mirror pci-rt3883 fix from commit e5067c718b3a ("MIPS: pci-rt3883: > > > Remove odd locking in PCI

fs/f2fs/gc.c:622:12: warning: stack frame size of 1616 bytes in function 'get_victim_by_default'

2021-04-13 Thread kernel test robot
months ago config: powerpc64-randconfig-r014-20210413 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 9829f5e6b1bca9b61efc629770d28bb9014dec45) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin

RE: [PATCH] mmc: add quirk to disable eMMC cache for Micron eMMC v5.0 cards

2021-04-13 Thread Avri Altman
Scott hi, Can you take a look at https://lore.kernel.org/lkml/20210322133645.4901-1-avri.alt...@wdc.com/ Is there a chance that it will work for you as well? Thanks, Avri > -Original Message- > From: Scott Branden > Sent: Tuesday, 13 April 2021 18:46 > To: Ulf Hansson ; Bean Huo (beanhu

Re: [PATCH v2] firmware_loader: fix use-after-free in firmware_fallback_sysfs

2021-04-13 Thread Luis Chamberlain
On Tue, Apr 13, 2021 at 04:12:42PM +0530, Anirudh Rayabharam wrote: > The use-after-free happens when a fw_priv object has been freed but > hasn't been removed from the pending list (pending_fw_head). The next > time fw_load_sysfs_fallback tries to insert into the list, it ends up > accessing the p

Re: [PATCH 02/11] mm/page_alloc: Convert per-cpu list protection to local_lock

2021-04-13 Thread Mel Gorman
On Mon, Apr 12, 2021 at 11:47:00PM +0200, Thomas Gleixner wrote: > On Mon, Apr 12 2021 at 12:56, Mel Gorman wrote: > > On Fri, Apr 09, 2021 at 08:55:39PM +0200, Peter Zijlstra wrote: > > I'll update the changelog and comment accordingly. I'll decide later > > whether to leave it or move the locatio

Re: [GIT PULL] coresight: Fixes for ETE and TRBE

2021-04-13 Thread Marc Zyngier
Hi Mathieu, On Tue, 13 Apr 2021 17:19:52 +0100, Mathieu Poirier wrote: > > The following changes since commit 4fb13790417a7bf726f3867a5d2b9723efde488b: > > dts: bindings: Document device tree bindings for Arm TRBE (2021-04-06 > 16:05:38 -0600) > > are available in the Git repository at: >

Re: [PATCH v4][next] xfs: Replace one-element arrays with flexible-array members

2021-04-13 Thread Christoph Hellwig
On Mon, Apr 12, 2021 at 08:48:08AM -0700, Darrick J. Wong wrote: > A couple of revisions ago I specifically asked Gustavo to create these > 'silly' sizeof helpers to clean up... > > > > - (sizeof(struct xfs_efd_log_item) + > > > - (XF

Re: [PATCH] arch/arm64/kernel/traps: Use find_vma_intersection() in traps for setting si_code

2021-04-13 Thread Liam Howlett
* Catalin Marinas [210412 13:44]: > On Wed, Apr 07, 2021 at 03:11:06PM +, Liam Howlett wrote: > > find_vma() will continue to search upwards until the end of the virtual > > memory space. This means the si_code would almost never be set to > > SEGV_MAPERR even when the address falls outside o

Re: [PATCH v2 3/3] rseq: optimise rseq_get_rseq_cs() and clear_rseq_cs()

2021-04-13 Thread Mathieu Desnoyers
- On Apr 13, 2021, at 12:22 PM, Eric Dumazet eric.duma...@gmail.com wrote: > From: Eric Dumazet > > Commit ec9c82e03a74 ("rseq: uapi: Declare rseq_cs field as union, > update includes") added regressions for our servers. > > Using copy_from_user() and clear_user() for 64bit values > is subo

Re: [PATCH V3 2/8] dt-bindings: remoteproc: imx_rproc: add i.MX7ULP support

2021-04-13 Thread Mathieu Poirier
On Thu, Apr 08, 2021 at 09:54:52AM +0800, peng@oss.nxp.com wrote: > From: Peng Fan > > Add i.MX7ULP compatible. > > We use i.MX7ULP dual mode and in which case i.MX7ULP A7 core runs under > control of M4 core, M4 core starts by ROM and powers most serivces used s/serivces/services > by A7

Re: [PATCH] ASoC: cs35l35: Fix an error handling path in 'cs35l35_i2c_probe()'

2021-04-13 Thread Mark Brown
On Tue, Apr 13, 2021 at 04:02:21PM +0200, Christophe JAILLET wrote: > What do you prefer: > - you fix the subject? > - I send a v2 with a new subject? > - we leave it as-is as this patch is a no-op in the real world? So it > doesn't really mater. It's fine, I already queued it - more a note

Re: [PATCH] hrtimer: Update softirq_expires_next correctly after __hrtimer_get_next_event()

2021-04-13 Thread Maciej Żenczykowski
This patch (or at least the version of it that showed up in 5.10.24 LTS when combined with Android Common Kernel and some arm phone platform drivers) causes a roughly 60% regression (from ~5.3-6 gbps down to ~2.2gbps) on running pktgen when egressing via ncm gadget on a SuperSpeed+ 10gbps USB3 conn

Re: [syzbot] general protection fault in gadget_setup

2021-04-13 Thread Alan Stern
On Tue, Apr 13, 2021 at 06:47:47PM +0200, Dmitry Vyukov wrote: > On Tue, Apr 13, 2021 at 6:13 PM Alan Stern wrote: > > Hopefully this patch will make the race a lot more likely to occur. Is > > there any way to tell syzkaller to test it, despite the fact that > > syzkaller doesn't think it has a

Re: [PATCH] selftests/bpf: use !E instead of comparing with NULL

2021-04-13 Thread Alexei Starovoitov
On Tue, Apr 13, 2021 at 9:32 AM wrote: > > > -Original Message- > > From: Alexei Starovoitov > > > > On Tue, Apr 13, 2021 at 9:19 AM wrote: > > > > > > > -Original Message- > > > > From: Alexei Starovoitov > > > > > > > > On Tue, Apr 13, 2021 at 9:10 AM wrote: > > > > > > > > >

Re: [PATCH v2 3/3] rseq: optimise rseq_get_rseq_cs() and clear_rseq_cs()

2021-04-13 Thread Eric Dumazet
On Tue, Apr 13, 2021 at 6:54 PM Mathieu Desnoyers wrote: > > - On Apr 13, 2021, at 12:22 PM, Eric Dumazet eric.duma...@gmail.com wrote: > > > From: Eric Dumazet > > > > Commit ec9c82e03a74 ("rseq: uapi: Declare rseq_cs field as union, > > update includes") added regressions for our servers. >

Re: linux-next: Tree for Apr 9 (x86 boot problem)

2021-04-13 Thread Mike Rapoport
On Mon, Apr 12, 2021 at 11:21:48PM -0700, Randy Dunlap wrote: > On 4/12/21 11:06 PM, Mike Rapoport wrote: > > Hi Randy, > > > > On Mon, Apr 12, 2021 at 01:53:34PM -0700, Randy Dunlap wrote: > >> On 4/12/21 10:01 AM, Mike Rapoport wrote: > >>> On Mon, Apr 12, 2021 at 08:49:49AM -0700, Randy Dunlap

Re: [PATCH] drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-13 Thread Ville Syrjälä
On Tue, Apr 13, 2021 at 05:02:40PM +0800, Jisheng Zhang wrote: > I met below error during boot with i915 builtin if pass > "i915.mitigations=off": > [0.015589] Booting kernel: `off' invalid for parameter `i915.mitigations' > > The reason is slab subsystem isn't ready at that time, so kstrdup()

Re: [PATCH v7 1/7] mm,page_alloc: Bail out earlier on -ENOMEM in alloc_contig_migrate_range

2021-04-13 Thread Mike Kravetz
On 4/13/21 3:47 AM, Oscar Salvador wrote: > Currently, __alloc_contig_migrate_range can generate -EINTR, -ENOMEM or > -EBUSY, > and report them down the chain. > The problem is that when migrate_pages() reports -ENOMEM, we keep going till > we > exhaust all the try-attempts (5 at the moment) inst

Re: [PATCH v2 3/3] rseq: optimise rseq_get_rseq_cs() and clear_rseq_cs()

2021-04-13 Thread Eric Dumazet
On Tue, Apr 13, 2021 at 6:57 PM Eric Dumazet wrote: > > On Tue, Apr 13, 2021 at 6:54 PM Mathieu Desnoyers > wrote: > > > > - On Apr 13, 2021, at 12:22 PM, Eric Dumazet eric.duma...@gmail.com > > wrote: > > > > > From: Eric Dumazet > > > > > > Commit ec9c82e03a74 ("rseq: uapi: Declare rseq_c

Re: [PATCH v2] drm/bridge/sii8620: fix dependency on extcon

2021-04-13 Thread Robert Foss
Hey Randy, Thanks for looking at this! On Fri, 9 Apr 2021 at 18:38, Randy Dunlap wrote: > > On 4/8/21 6:07 AM, Robert Foss wrote: > > The DRM_SIL_SII8620 kconfig has a weak `imply` dependency > > on EXTCON, which causes issues when sii8620 is built > > as a builtin and EXTCON is built as a modul

[PATCH] efifb: Check efifb_pci_dev before using it

2021-04-13 Thread Kai-Heng Feng
On some platforms like Hyper-V and RPi4 with UEFI firmware, efifb is not a PCI device. So make sure efifb_pci_dev is found before using it. Fixes: a6c0fd3d5a8b ("efifb: Ensure graphics device for efifb stays at PCI D0") BugLink: https://bugs.launchpad.net/bugs/1922403 Signed-off-by: Kai-Heng Feng

[PATCH net-next 2/2] arm64: dts: qcom: sm8350-mtp: enable IPA

2021-04-13 Thread Alex Elder
Enable IPA for the SM8350 MTP. Signed-off-by: Alex Elder --- arch/arm64/boot/dts/qcom/sm8350-mtp.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8350-mtp.dts b/arch/arm64/boot/dts/qcom/sm8350-mtp.dts index 6ca638b4e3213..93740444dd1ea 100644 --- a/arch/a

[PATCH net-next 1/2] arm64: dts: qcom: sm8350: add IPA information

2021-04-13 Thread Alex Elder
Add IPA-related nodes and definitions to "sm8350.dtsi", which uses IPA v4.9. Signed-off-by: Alex Elder --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 51 1 file changed, 51 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm835

[PATCH net-next 0/2] arm64: dts: qcom: enable SM8350

2021-04-13 Thread Alex Elder
Add IPA-related information to "sm8350.dtsi", and enable IPA for the SM8350 MTP platform. -Alex Alex Elder (2): arm64: dts: qcom: sm8350: add IPA information arm64: dts: qcom: sm8350-mtp: enable IPA arch/arm64/boot/dts/qcom/sm8350-mtp.dts | 6 +++ ar

Re: [PATCH v2 3/3] rseq: optimise rseq_get_rseq_cs() and clear_rseq_cs()

2021-04-13 Thread Mathieu Desnoyers
- On Apr 13, 2021, at 12:57 PM, Eric Dumazet eduma...@google.com wrote: > On Tue, Apr 13, 2021 at 6:54 PM Mathieu Desnoyers > wrote: >> >> - On Apr 13, 2021, at 12:22 PM, Eric Dumazet eric.duma...@gmail.com >> wrote: >> >> > From: Eric Dumazet >> > >> > Commit ec9c82e03a74 ("rseq: uapi:

[PATCH v2] hrtimer: avoid retrigger_next_event IPI

2021-04-13 Thread Marcelo Tosatti
Setting the realtime clock triggers an IPI to all CPUs to reprogram hrtimers. However, only realtime and TAI clocks have their offsets updated (and therefore potentially require a reprogram). Check if it only has monotonic active timers, and in that case update the realtime and TAI base offse

Re: [syzbot] linux-next build error (12)

2021-04-13 Thread Dmitry Vyukov
On Mon, Mar 29, 2021 at 2:53 PM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:9d49ed9c Add linux-next specific files for 20210329 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=159b39aad0 > kernel config: https:

Re: [PATCH v2 3/3] rseq: optimise rseq_get_rseq_cs() and clear_rseq_cs()

2021-04-13 Thread Eric Dumazet
On Tue, Apr 13, 2021 at 7:01 PM Eric Dumazet wrote: > > On Tue, Apr 13, 2021 at 6:57 PM Eric Dumazet wrote: > > > > On Tue, Apr 13, 2021 at 6:54 PM Mathieu Desnoyers > > wrote: > > > > > > - On Apr 13, 2021, at 12:22 PM, Eric Dumazet eric.duma...@gmail.com > > > wrote: > > > > > > > From: E

Re: [PATCH] xen/pciback: Fix incorrect type warnings

2021-04-13 Thread Muhammad Usama Anjum
Reminder! On Mon, 2021-03-29 at 09:24 +0200, Juergen Gross wrote: > On 26.03.21 19:14, Muhammad Usama Anjum wrote: > > Correct enum pci_channel_io_normal should be used instead of putting > > integer value 1. > > > > Fix following smatch warnings: > > drivers/xen/xen-pciback/pci_stub.c:805:40: wa

Re: [syzbot] general protection fault in gadget_setup

2021-04-13 Thread Dmitry Vyukov
On Tue, Apr 13, 2021 at 6:57 PM Alan Stern wrote: > > On Tue, Apr 13, 2021 at 06:47:47PM +0200, Dmitry Vyukov wrote: > > On Tue, Apr 13, 2021 at 6:13 PM Alan Stern > > wrote: > > > Hopefully this patch will make the race a lot more likely to occur. Is > > > there any way to tell syzkaller to te

[PATCH] staging: rtl8723bs: remove sdio_drv_priv structure

2021-04-13 Thread Bryan Brattlof
The sdio_drv_priv structure is a small wrapper around sdio_driver in linux/mmc/sdio_func.h with an added drv_registered integer. drv_registered is never used anywhere in the driver and only assigned to during the sdio registering and unregistering process. We can safely remove sdio_drv_priv and us

[PATCH] dt-bindings: mailbox: ti,secure-proxy: Convert to yaml

2021-04-13 Thread Nishanth Menon
Convert the ti,secure-proxy to yaml for better checks and documentation. Differences being mostly in the examples: - I've dropped the example usage of mailbox client, it is better done in tisci node definition - Switched reg usage for address-cells and size-cells 1 - aligned with schema checks

Re: [PATCH] hrtimer: Update softirq_expires_next correctly after __hrtimer_get_next_event()

2021-04-13 Thread Greg KH
On Tue, Apr 13, 2021 at 09:55:08AM -0700, Maciej Żenczykowski wrote: > This patch (or at least the version of it that showed up in 5.10.24 > LTS when combined with Android Common Kernel and some arm phone > platform drivers) causes a roughly 60% regression (from ~5.3-6 gbps > down to ~2.2gbps) on r

Re: [PATCH] sched: remove the redundant comments

2021-04-13 Thread Dietmar Eggemann
On 13/04/2021 18:28, Steven Rostedt wrote: > On Tue, 13 Apr 2021 10:36:07 +0200 > Dietmar Eggemann wrote: [...] >> Add a >> >> Fixes: 55627e3cd22c ("sched/core: Remove rq->cpu_load[]") >> >> line. > > It's just removing a comment. Should it really need a "Fixes" tag, which > will cause many p

[PATCH v7 1/4] tools/include: Add an initial math64.h

2021-04-13 Thread Rob Herring
Add an initial math64.h similar to linux/math64.h with functions mul_u64_u64_div64() and mul_u64_u32_shr(). This isn't a direct copy of include/linux/math64.h as that doesn't define mul_u64_u64_div64(). Implementation was written by Peter Zilkstra based on linux/math64.h and div64.h[1]. The origin

[PATCH v7 0/4] libperf userspace counter access

2021-04-13 Thread Rob Herring
I'm resending just the libperf userspace counter access without the Arm bits so hopefully it can be picked up for 5.13. The Arm bits seem to be a never ending review filled with long periods of silence. :( Prior versions are here[1][2][3][4][5][6][7]. Rob [1] https://lore.kernel.org/r/20190822

[PATCH v7 4/4] libperf: Add support for user space counter access

2021-04-13 Thread Rob Herring
x86 and arm64 can both support direct access of event counters in userspace. The access sequence is less than trivial and currently exists in perf test code (tools/perf/arch/x86/tests/rdpmc.c) with copies in projects such as PAPI and libpfm4. In order to support usersapce access, an event must be

[PATCH v7 3/4] libperf: tests: Add support for verbose printing

2021-04-13 Thread Rob Herring
Add __T_VERBOSE() so tests can add verbose output. The verbose output is enabled with the '-v' command line option. Signed-off-by: Rob Herring --- v5: - Pass verbose flag to static tests - Fix getopt loop with unsigned char (arm64) v3: - New patch --- tools/lib/perf/include/internal/tests.h |

[PATCH v7 2/4] libperf: Add evsel mmap support

2021-04-13 Thread Rob Herring
In order to support usersapce access, an event must be mmapped. While there's already mmap support for evlist, the usecase is a bit different than the self monitoring with userspace access. So let's add a new perf_evsel__mmap() function to mmap an evsel. This allows implementing userspace access as

Re: Mutual debugging of 2 processes can stuck in unkillable stopped state

2021-04-13 Thread Oleg Nesterov
Hi Igor, sorry for delay... On 04/12, Igor Zhbanov wrote: > > Hi Oleg, > > So what is the cause of this problem? The cause is clear. And well known ;) And again, this has almost nothing to do with the mutual debugging. The tracee sleeps in ptrace_stop(). You send SIGKILL. This wakes the tracee

Re: [PATCH v2 7/8] cxl/port: Introduce cxl_port objects

2021-04-13 Thread Dan Williams
On Thu, Apr 8, 2021 at 7:13 PM Dan Williams wrote: > > Hi Bjorn, thanks for taking a look. > > > On Thu, Apr 8, 2021 at 3:42 PM Bjorn Helgaas wrote: > > > > [+cc Greg, Rafael, Matthew: device model questions] > > > > Hi Dan, > > > > On Thu, Apr 01, 2021 at 07:31:20AM -0700, Dan Williams wrote: >

Re: [PATCH v2 3/3] rseq: optimise rseq_get_rseq_cs() and clear_rseq_cs()

2021-04-13 Thread Mathieu Desnoyers
- On Apr 13, 2021, at 1:07 PM, Eric Dumazet eduma...@google.com wrote: > On Tue, Apr 13, 2021 at 7:01 PM Eric Dumazet wrote: >> >> On Tue, Apr 13, 2021 at 6:57 PM Eric Dumazet wrote: >> > >> > On Tue, Apr 13, 2021 at 6:54 PM Mathieu Desnoyers >> > wrote: >> > > >> > > - On Apr 13, 2021,

Re: [syzbot] WARNING in unsafe_follow_pfn

2021-04-13 Thread Dmitry Vyukov
On Thu, Apr 1, 2021 at 2:19 PM Jason Gunthorpe wrote: > > On Wed, Mar 31, 2021 at 07:29:22AM +0300, Dan Carpenter wrote: > > On Tue, Mar 30, 2021 at 07:04:30PM +0200, Paolo Bonzini wrote: > > > On 30/03/21 17:26, syzbot wrote: > > > > Hello, > > > > > > > > syzbot found the following issue on: > >

Re: [syzbot] KASAN: vmalloc-out-of-bounds Read in bpf_trace_run2

2021-04-13 Thread Dmitry Vyukov
On Thu, Apr 1, 2021 at 5:39 AM syzbot wrote: > > syzbot suspects this issue was fixed by commit: > > commit befe6d946551d65cddbd32b9cb0170b0249fd5ed > Author: Steven Rostedt (VMware) > Date: Wed Nov 18 14:34:05 2020 + > > tracepoint: Do not fail unregistering a probe due to memory failu

RE: [PATCH] selftests/bpf: use !E instead of comparing with NULL

2021-04-13 Thread Tim.Bird
> -Original Message- > From: Alexei Starovoitov > > On Tue, Apr 13, 2021 at 9:32 AM wrote: > > > > > -Original Message- > > > From: Alexei Starovoitov > > > > > > On Tue, Apr 13, 2021 at 9:19 AM wrote: > > > > > > > > > -Original Message- > > > > > From: Alexei Starovoi

[PATCH] media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer

2021-04-13 Thread Niklas Söderlund
Add basic support for Maxim MAX96712 quad GMSL2 deserializers. The driver is capable of powering on the device and configuring the MIPI CSI-2 bus in a DPHY 4-lane configuration as well as operating the internal VTG (Video Timing Generator) and VPG (Video Pattern Generator). Using these features th

Re: [PATCH-next] fs/btrfs: Fix uninitialized variable

2021-04-13 Thread Boris Burkov
On Tue, Apr 13, 2021 at 02:06:04PM +0100, Khaled ROMDHANI wrote: > The variable zone is not initialized. It > may causes a failed assertion. > > Addresses-Coverity: ("Uninitialized variables") > > Signed-off-by: Khaled ROMDHANI Reviewed-by: Boris Burkov > --- > fs/btrfs/zoned.c | 2 +- > 1 f

Re: [PATCH v2 0/3] KVM: Properly account for guest CPU time

2021-04-13 Thread Sean Christopherson
On Tue, Apr 13, 2021, Wanpeng Li wrote: > The bugzilla https://bugzilla.kernel.org/show_bug.cgi?id=209831 > reported that the guest time remains 0 when running a while true > loop in the guest. > > The commit 87fa7f3e98a131 ("x86/kvm: Move context tracking where it > belongs") moves guest_exit_irq

Subject: [PATCH v4] staging: media: zoran: add '*' in long(multi-line) comments

2021-04-13 Thread Mitali Borkar
Added '*' before every line inside long(multi-line) comments. Removed '*/' from end of the comment line and added to next line as per linux kernel coding style. Aligned '*' accordingly to make code neater. Signed-off-by: Mitali Borkar --- Changes from v3:- Rebased this patch and made changes agai

Re: [thermal] 9223d0dccb: stress-ng.msg.ops_per_sec -27.4% regression

2021-04-13 Thread Borislav Petkov
On Tue, Apr 13, 2021 at 09:58:01PM +0800, kernel test robot wrote: > Greeting, > > FYI, we noticed a -27.4% regression of stress-ng.msg.ops_per_sec due to > commit: > > > commit: 9223d0dccb8f8523754122f68316dd1a4f39f7f8 ("thermal: Move therm_throt > there from x86/mce") > https://git.kernel.or

Re: [PATCH V3 4/8] remoteproc: imx_rproc: make clk optional

2021-04-13 Thread Mathieu Poirier
On Thu, Apr 08, 2021 at 09:54:54AM +0800, peng@oss.nxp.com wrote: > From: Peng Fan > > To i.MX7ULP, M4 is the master to control everything, so it not need > clk from A7. > > Reviewed-by: Richard Zhu > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 2 +- > 1 file changed,

Re: [PATCH v3] HID: i2c-hid: Skip ELAN power-on command after reset

2021-04-13 Thread Harry Cutts
On Mon, 12 Apr 2021 at 18:20, Johnny Chuang wrote: > > Fixes: 43b7029f475e ("HID: i2c-hid: Send power-on command after reset"). > > For ELAN touchscreen, we found our boot code of IC was not flexible enough > to receive and handle this command. > Once the FW main code of our controller is crashed

Re: [PATCH 1/1] sched/fair:Reduce unnecessary check preempt in the sched tick

2021-04-13 Thread kernel test robot
Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/sched/core] [also build test WARNING on v5.12-rc7 next-20210413] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as

Re: [PATCH V3 5/8] remoteproc: imx_rproc: parse fsl,auto-boot

2021-04-13 Thread Mathieu Poirier
On Thu, Apr 08, 2021 at 09:54:55AM +0800, peng@oss.nxp.com wrote: > From: Peng Fan > > Parse fsl,auto-boot to indicate whether need remoteproc framework > auto boot or not. > > When remote processor is booted before Linux Kernel up, do not parse > fsl,auto-boot. So add an entry to store the

[syzbot] possible deadlock in del_gendisk

2021-04-13 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:e99d8a84 Add linux-next specific files for 20210409 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=13b01681d0 kernel config: https://syzkaller.appspot.com/x/.config?x=7cd69574979bfeb7 dashboard

Re: linux-next: Tree for Apr 9 (x86 boot problem)

2021-04-13 Thread Randy Dunlap
On 4/13/21 9:58 AM, Mike Rapoport wrote: > On Mon, Apr 12, 2021 at 11:21:48PM -0700, Randy Dunlap wrote: >> On 4/12/21 11:06 PM, Mike Rapoport wrote: >>> Hi Randy, >>> >>> On Mon, Apr 12, 2021 at 01:53:34PM -0700, Randy Dunlap wrote: On 4/12/21 10:01 AM, Mike Rapoport wrote: > On Mon, Apr

Re: [PATCH v2 3/3] rseq: optimise rseq_get_rseq_cs() and clear_rseq_cs()

2021-04-13 Thread Eric Dumazet
On Tue, Apr 13, 2021 at 7:20 PM Mathieu Desnoyers wrote: > > - On Apr 13, 2021, at 1:07 PM, Eric Dumazet eduma...@google.com wrote: > > > On Tue, Apr 13, 2021 at 7:01 PM Eric Dumazet wrote: > >> > >> On Tue, Apr 13, 2021 at 6:57 PM Eric Dumazet wrote: > >> > > >> > On Tue, Apr 13, 2021 at 6:

[PATCH v2 4/4] serial: stm32: add FIFO threshold configuration

2021-04-13 Thread Erwan Le Ray
From: Fabrice Gasnier Add the support for two optional DT properties, to configure RX and TX FIFO thresholds: - rx-threshold - tx-threshold This replaces hard-coded 8 bytes threshold. Keep 8 as the default value if not specified, for backward compatibility. Signed-off-by: Fabrice Gasnier Signed

[PATCH v2 1/4] dt-bindings: serial: add RX and TX FIFO properties

2021-04-13 Thread Erwan Le Ray
Add two optional DT properties to configure RX and TX FIFO thresholds: - rx-threshold - tx-threshold Signed-off-by: Erwan Le Ray diff --git a/Documentation/devicetree/bindings/serial/serial.yaml b/Documentation/devicetree/bindings/serial/serial.yaml index 65e75d040521..f368d58e8086 100644 --- a

[PATCH v2 3/4] dt-bindings: serial: 8250: update TX FIFO trigger level

2021-04-13 Thread Erwan Le Ray
Remove data type from tx-threshold trigger level as defined now as a serial generic property. Signed-off-by: Erwan Le Ray diff --git a/Documentation/devicetree/bindings/serial/8250.yaml b/Documentation/devicetree/bindings/serial/8250.yaml index c0e292cdaa6b..ff0fa9b2a390 100644 --- a/Documentat

[PATCH v2 0/4] stm32 usart add fifo threshold configuration

2021-04-13 Thread Erwan Le Ray
This series adds the support for two optional DT properties to configure RX and TX FIFO thresholds: - rx-threshold - tx-threshold This replaces hard-coded 8 bytes threshold. No functional change expected if unspecified (keep 8 as default). Changes in v2: Change added properties naming and factor

[PATCH v2 2/4] dt-bindings: serial: stm32: override FIFO threshold properties

2021-04-13 Thread Erwan Le Ray
Override rx-threshold and tx-threshold properties: - extend description - provide default and expected values Signed-off-by: Fabrice Gasnier Signed-off-by: Erwan Le Ray Changes in v2: Change added properties naming and factorize it in serial.yaml as proposed by Rob Herring. diff --git a/Docume

Re: [syzbot] possible deadlock in del_gendisk

2021-04-13 Thread Steven Rostedt
On Tue, 13 Apr 2021 10:33:19 -0700 syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:e99d8a84 Add linux-next specific files for 20210409 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=13b01681d0 > kernel config: ht

Re: [PATCH] ACPI: x86: Call acpi_boot_table_init() after acpi_table_upgrade()

2021-04-13 Thread David Hildenbrand
On 13.04.21 16:01, Rafael J. Wysocki wrote: From: Rafael J. Wysocki Commit 1a1c130ab757 ("ACPI: tables: x86: Reserve memory occupied by ACPI tables") attempted to address an issue with reserving the memory occupied by ACPI tables, but it broke the initrd-based table override mechanism relied on

Re: [syzbot] possible deadlock in del_gendisk

2021-04-13 Thread Steven Rostedt
On Tue, 13 Apr 2021 13:41:47 -0400 Steven Rostedt wrote: > As the below splats look like it has nothing to do with this patch, and > this patch will add a WARN() if there's broken logic somewhere, I bet the > bisect got confused (if it is automated and does a panic_on_warning), > because it will

Re: [PATCH] staging: media: tegra-vde: Align line break to match with the open parenthesis in file trace.h

2021-04-13 Thread Joe Perches
On Tue, 2021-04-13 at 21:35 +0530, Dwaipayan Ray wrote: > On Tue, Apr 13, 2021 at 8:59 PM Thierry Reding > wrote: > > > > On Mon, Apr 12, 2021 at 07:20:40PM -0300, Aline Santana Cordeiro wrote: > > > Align line break to match with the open parenthesis. > > > Issue detected by checkpatch.pl. > >

Re: [PATCH v3] f2fs: fix to keep isolation of atomic write

2021-04-13 Thread Jaegeuk Kim
On 04/13, Chao Yu wrote: > On 2021/4/13 11:27, Jaegeuk Kim wrote: > > On 04/12, Chao Yu wrote: > > > As Yi Chen reported, there is a potential race case described as below: > > > > > > Thread A Thread B > > > - f2fs_ioc_start_atomic_write > > > - mkwrite

Re: [PATCH 1/7] mm: memcontrol: fix page charging in page replacement

2021-04-13 Thread Roman Gushchin
On Tue, Apr 13, 2021 at 02:51:47PM +0800, Muchun Song wrote: > The pages aren't accounted at the root level, so do not charge the page > to the root memcg in page replacement. Although we do not display the > value (mem_cgroup_usage) so there shouldn't be any actual problem, but > there is a WARN_O

Re: [PATCH V3 6/8] remoteproc: imx_rproc: initial support for mutilple start/stop method

2021-04-13 Thread Mathieu Poirier
On Thu, Apr 08, 2021 at 09:54:56AM +0800, peng@oss.nxp.com wrote: > From: Peng Fan > > Add three methods IMX_RPROC_NONE(no need start/stop), IMX_RPROC_MMIO > (start/stop through mmio) and IMX_RPROC_SMC(start/stop through ARM SMCCC). > > The current SoCs supported are all using IMX_RPROC_MMIO

Re: [PATCH 2/7] mm: memcontrol: bail out early when !mm in get_mem_cgroup_from_mm

2021-04-13 Thread Roman Gushchin
On Tue, Apr 13, 2021 at 02:51:48PM +0800, Muchun Song wrote: > When mm is NULL, we do not need to hold rcu lock and call css_tryget for > the root memcg. And we also do not need to check !mm in every loop of > while. So bail out early when !mm. > > Signed-off-by: Muchun Song > Acked-by: Johannes

Re: [PATCH 3/7] mm: memcontrol: remove the pgdata parameter of mem_cgroup_page_lruvec

2021-04-13 Thread Roman Gushchin
On Tue, Apr 13, 2021 at 02:51:49PM +0800, Muchun Song wrote: > All the callers of mem_cgroup_page_lruvec() just pass page_pgdat(page) > as the 2nd parameter to it (except isolate_migratepages_block()). But > for isolate_migratepages_block(), the page_pgdat(page) is also equal > to the local variabl

Re: [PATCH] wireless/marvell/mwifiex: Fix a double free in mwifiex_send_tdls_action_frame

2021-04-13 Thread Brian Norris
Hi, On Wed, Apr 14, 2021 at 12:08:32AM +0800, lyl2...@mail.ustc.edu.cn wrote: > > Hi, > maintianers. > > Sorry to disturb you, but this patch seems to be missed more than two weeks. > Could you help to review this patch? I am sure it won't take you much time. You might take a look here: h

Re: [PATCH] arm64: kprobes: Restore local irqflag if kprobes is cancelled

2021-04-13 Thread Will Deacon
On Mon, 12 Apr 2021 17:41:01 +0800, Jisheng Zhang wrote: > If instruction being single stepped caused a page fault, the kprobes > is cancelled to let the page fault handler continue as a normal page > fault. But the local irqflags are disabled so cpu will restore pstate > with DAIF masked. After pa

Re: [PATCH V3 7/8] remoteproc: imx_rproc: support i.MX7ULP

2021-04-13 Thread Mathieu Poirier
On Thu, Apr 08, 2021 at 09:54:57AM +0800, peng@oss.nxp.com wrote: > From: Peng Fan > > i.MX7ULP A7 core runs under control of M4 core, M4 core starts by ROM > and powers most serivces used by A7 core, so A7 core has no power to > start and stop M4 core. > > Signed-off-by: Peng Fan > --- >

Re: [PATCH] dm verity: fix not aligned logical block size of RS roots IO

2021-04-13 Thread Jaegeuk Kim
On 04/12, Jaegeuk Kim wrote: > From: Jaegeuk Kim > > commit df7b59ba9245 ("dm verity: fix FEC for RS roots unaligned to block > size") > made dm_bufio->block_size 1024, if f->roots is 2. But, that gives the below > EIO > if the logical block size of the device is 4096, given > v->data_dev_bloc

Re: [PATCH 5/7] mm: memcontrol: simplify the logic of objcg pinning memcg

2021-04-13 Thread Roman Gushchin
On Tue, Apr 13, 2021 at 02:51:51PM +0800, Muchun Song wrote: > The obj_cgroup_release() and memcg_reparent_objcgs() are serialized by > the css_set_lock. We do not need to care about objcg->memcg being > released in the process of obj_cgroup_release(). So there is no need > to pin memcg before rele

<    4   5   6   7   8   9   10   11   12   13   >