Re: [PATCH RFC net-next v2] page_pool: import Jesper's page_pool benchmark

2025-06-04 Thread Ilias Apalodimas
Hi all, This is very useful. On Wed, 28 May 2025 at 16:51, Arnaldo Carvalho de Melo wrote: > > On Wed, May 28, 2025 at 11:28:54AM +0200, Toke Høiland-Jørgensen wrote: > > Mina Almasry writes: > > > On Mon, May 26, 2025 at 5:51 AM Toke Høiland-Jørgensen > > > wrote: > > >> Back when you posted

Re: [PATCH RESEND] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-04 Thread Mike Rapoport
On Wed, Jun 04, 2025 at 09:39:30AM +0200, David Hildenbrand wrote: > On 03.06.25 21:22, Lorenzo Stoakes wrote: > > The walk_page_range_novma() function is rather confusing - it supports two > > modes, one used often, the other used only for debugging. > > > > The first mode is the common case of t

Re: [PATCH RESEND] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-04 Thread David Hildenbrand
On 04.06.25 10:07, Mike Rapoport wrote: On Wed, Jun 04, 2025 at 09:39:30AM +0200, David Hildenbrand wrote: On 03.06.25 21:22, Lorenzo Stoakes wrote: The walk_page_range_novma() function is rather confusing - it supports two modes, one used often, the other used only for debugging. The first mo

Re: [PATCH] selftests/timers: Fix integer overlow errors on 32 bit systems

2025-06-04 Thread Terry Tritton
> So this seems to be undoing commit 80fa614e2fbc ("selftests: timers: > Remove local NSEC_PER_SEC and USEC_PER_SEC defines") Thanks John, I somehow missed 80fa614e2fbc and was wondering how this had got in. > Would it make more sense to fix the NSEC_PER_SEC definition in time64.h to a > LL? I wa

[GIT PULL] SPDX/LICENSES update for 6.16-rc1

2025-06-04 Thread Greg KH
The following changes since commit 0af2f6be1b4281385b618cb86ad946eded089ac8: Linux 6.15-rc1 (2025-04-06 13:11:33 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/spdx.git tags/spdx-6.16-rc1 for you to fetch changes up to 59c11a7a9a138a28c7

Re: [PATCH v4 0/7] Add managed SOFT RESERVE resource handling

2025-06-04 Thread Zhijian Li (Fujitsu)
Smita, Thanks for your awesome work. I just tested the scenarios you listed, and they work as expected. Thanks again. (Minor comments inlined) Tested-by: Li Zhijian To the CXL community, The scenarios mentioned here essentially cover what a correct firmware may provide. However, I would lik

Re: [PATCH] module: make __mod_device_table__* symbols static

2025-06-04 Thread Petr Pavlu
On 6/2/25 12:55 PM, Masahiro Yamada wrote: > The __mod_device_table__* symbols are only parsed by modpost to generate > MODULE_ALIAS() entries from MODULE_DEVICE_TABLE(). > > Therefore, these symbols do not need to be globally visible, or globally > unique. > > If they are in the global scope, we

Re: [PATCH bpf-next] selftests/bpf: Fix compile error of bin_attribute::read/write()

2025-06-04 Thread Jiri Olsa
On Wed, Jun 04, 2025 at 01:53:22PM +0800, Rong Tao wrote: > From: Rong Tao > > Since commit 97d06802d10a ("sysfs: constify bin_attribute argument of > bin_attribute::read/write()"), make bin_attribute parameter of > bin_attribute::read/write() const. hi, there's already fix for this in bpf/maste

[Question] attributes encoding in BTF

2025-06-04 Thread Alexis Lothoré
Hi all, a simpler version of this series has been merged, and so I am now taking a look at the issue I have put aside in the merged version: dealing with more specific data layout for arguments passed on stack. For example, a function can pass small structs on stack, but this need special care when

Re: [PATCH RFC net-next v2 2/3] vsock/test: Introduce get_transports()

2025-06-04 Thread Stefano Garzarella
On Wed, May 28, 2025 at 10:44:42PM +0200, Michal Luczaj wrote: Return a bitmap of registered vsock transports. As guesstimated by grepping /proc/kallsyms (CONFIG_KALLSYMS=y) for known symbols of type `struct virtio_transport`. Suggested-by: Stefano Garzarella Signed-off-by: Michal Luczaj --- t

Re: [PATCH RESEND] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-04 Thread Lorenzo Stoakes
On Wed, Jun 04, 2025 at 11:07:05AM +0300, Mike Rapoport wrote: > On Wed, Jun 04, 2025 at 09:39:30AM +0200, David Hildenbrand wrote: > > On 03.06.25 21:22, Lorenzo Stoakes wrote: > > > The walk_page_range_novma() function is rather confusing - it supports two > > > modes, one used often, the other u

Re: [PATCH RFC net-next v2 1/3] vsock/test: Introduce vsock_bind_try() helper

2025-06-04 Thread Stefano Garzarella
On Wed, May 28, 2025 at 10:44:41PM +0200, Michal Luczaj wrote: Create a socket and bind() it. If binding failed, gracefully return an error code while preserving `errno`. Base vsock_bind() on top of it. Suggested-by: Stefano Garzarella Signed-off-by: Michal Luczaj --- tools/testing/vsock/util

Re: [PATCH bpf-next] selftests/bpf: Fix compile error of bin_attribute::read/write()

2025-06-04 Thread Rong Tao
On 6/4/25 16:53, Jiri Olsa wrote: On Wed, Jun 04, 2025 at 01:53:22PM +0800, Rong Tao wrote: From: Rong Tao Since commit 97d06802d10a ("sysfs: constify bin_attribute argument of bin_attribute::read/write()"), make bin_attribute parameter of bin_attribute::read/write() const. hi, there's alre

Re: [PATCH v4 3/7] cxl/pci: Add pci_loaded tracking to mark PCI driver readiness

2025-06-04 Thread Zhijian Li (Fujitsu)
On 04/06/2025 06:19, Smita Koralahalli wrote: > Introduce a pci_loaded flag similar to mem_active, and define > mark_cxl_pci_loaded() to indicate when the PCI driver has initialized. > > This will be used by other CXL components, such as cxl_acpi and the soft > reserved resource handling logic,

Re: [QUESTION] problems report: rcu_read_unlock_special() called in irq_exit() causes dead loop

2025-06-04 Thread Joel Fernandes
On 6/3/2025 11:37 PM, Qi Xi wrote: > Hi Joel, > > The patch works as expected. Previously, the issue triggered a soft lockup > within ~10 minutes, but after applying the fix, the system ran stably for 30+ > minutes without any issues. Great to hear! Thanks for testing. I/we will roll this into a

Re: [PATCH RFC net-next v2 3/3] vsock/test: Cover more CIDs in transport_uaf test

2025-06-04 Thread Stefano Garzarella
On Wed, May 28, 2025 at 10:44:43PM +0200, Michal Luczaj wrote: Increase the coverage of test for UAF due to socket unbinding, and losing transport in general. It's a follow up to commit 301a62dfb0d0 ("vsock/test: Add test for UAF due to socket unbinding") and discussion in [1]. The idea remains

Re: [PATCH RESEND] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-04 Thread Lorenzo Stoakes
On Wed, Jun 04, 2025 at 09:39:30AM +0200, David Hildenbrand wrote: > On 03.06.25 21:22, Lorenzo Stoakes wrote: > > The walk_page_range_novma() function is rather confusing - it supports two > > modes, one used often, the other used only for debugging. > > > > The first mode is the common case of tr

Re: [PATCH v4 4/7] cxl/acpi: Add background worker to wait for cxl_pci and cxl_mem probe

2025-06-04 Thread Zhijian Li (Fujitsu)
On 04/06/2025 06:19, Smita Koralahalli wrote: > drivers/cxl/acpi.c | 23 +++ > drivers/cxl/core/suspend.c | 21 + > drivers/cxl/cxl.h | 2 ++ > 3 files changed, 46 insertions(+) > > diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.

Re: [PATCH RFC net-next v2] page_pool: import Jesper's page_pool benchmark

2025-06-04 Thread Jesper Dangaard Brouer
On 28/05/2025 21.46, Mina Almasry wrote: On Wed, May 28, 2025 at 2:28 AM Toke Høiland-Jørgensen wrote: Mina Almasry writes: On Mon, May 26, 2025 at 5:51 AM Toke Høiland-Jørgensen wrote: Fast path results: no-softirq-page_pool01 Per elem: 11 cycles(tsc) 4.368 ns ptr_ring results: no-so

Re: [PATCH v3 3/6] modpost: Make mod_device_table aliases more unique

2025-06-04 Thread Alexey Gladkov
On Tue, Jun 03, 2025 at 01:18:25AM +0900, Masahiro Yamada wrote: > > > > Before these patches this was not a problem as non-unique characters are > > > > in separate object files when the module is compiled separately. > > > > > > > > But when the modules are compiled into the kernel, there is a sy

Re: [PATCH 3/3] remoteproc: imx_rproc: Add support for i.MX95

2025-06-04 Thread Daniel Baluta
On Wed, Jun 4, 2025 at 5:37 AM Peng Fan (OSS) wrote: > > From: Peng Fan > > Add imx_rproc_cfg_imx95_m7 and address(TCM and DDR) mapping > Add i.MX95 of_device_id entry > > Signed-off-by: Peng Fan Reviewed-by: Daniel Baluta

Re: [PATCH RESEND] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-04 Thread Oscar Salvador
On Wed, Jun 04, 2025 at 10:09:05AM +0100, Lorenzo Stoakes wrote: > Nice idea to move to mm/internal.h also :) I like this... > > Will fixup on respin Dumb question but IIUC, walk_page_range_novma() will only be used by ptdump from now on, so why not stick it into mm/ptdump.c, which is where the o

Re: [PATCH RESEND] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-04 Thread Lorenzo Stoakes
On Wed, Jun 04, 2025 at 02:26:57PM +0200, Oscar Salvador wrote: > On Wed, Jun 04, 2025 at 10:09:05AM +0100, Lorenzo Stoakes wrote: > > Nice idea to move to mm/internal.h also :) I like this... > > > > Will fixup on respin > > Dumb question but IIUC, walk_page_range_novma() will only be used by > pt

Re: [PATCH 2/3] remoteproc: imx_rproc: Add support for System Manager API

2025-06-04 Thread Daniel Baluta
Hi Peng, Thanks a lot for the patches. Comments inline: On Wed, Jun 4, 2025 at 5:36 AM Peng Fan (OSS) wrote: > > From: Peng Fan > > i.MX95 features a Cortex-M33 core, six Cortex-A55 cores, and > one Cortex-M7 core. The System Control Management Interface(SCMI) > firmware runs on the M33 core. T

RE: [PATCH 2/3] remoteproc: imx_rproc: Add support for System Manager API

2025-06-04 Thread Peng Fan
> Subject: Re: [PATCH 2/3] remoteproc: imx_rproc: Add support for > System Manager API > > Hi Peng, > > Thanks a lot for the patches. Comments inline: > > On Wed, Jun 4, 2025 at 5:36 AM Peng Fan (OSS) > wrote: > > > > From: Peng Fan > > > > i.MX95 features a Cortex-M33 core, six Cortex-A55 cor

Re: [PATCH net] virtio-net: drop the multi-buffer XDP packet in zerocopy

2025-06-04 Thread Bui Quang Minh
On 6/4/25 07:37, Jason Wang wrote: On Tue, Jun 3, 2025 at 11:07 PM Bui Quang Minh wrote: In virtio-net, we have not yet supported multi-buffer XDP packet in zerocopy mode when there is a binding XDP program. However, in that case, when receiving multi-buffer XDP packet, we skip the XDP program

[PATCH v2] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-04 Thread Lorenzo Stoakes
The walk_page_range_novma() function is rather confusing - it supports two modes, one used often, the other used only for debugging. The first mode is the common case of traversal of kernel page tables, which is what nearly all callers use this for. Secondly it provides an unusual debugging inter

Re: [PATCH v2] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-04 Thread Suren Baghdasaryan
On Wed, Jun 4, 2025 at 7:21 AM Lorenzo Stoakes wrote: > > The walk_page_range_novma() function is rather confusing - it supports two > modes, one used often, the other used only for debugging. > > The first mode is the common case of traversal of kernel page tables, which > is what nearly all call

Re: [PATCH v4 4/7] cxl/acpi: Add background worker to wait for cxl_pci and cxl_mem probe

2025-06-04 Thread Dave Jiang
On 6/4/25 2:40 AM, Zhijian Li (Fujitsu) wrote: > > > On 04/06/2025 06:19, Smita Koralahalli wrote: >> drivers/cxl/acpi.c | 23 +++ >> drivers/cxl/core/suspend.c | 21 + >> drivers/cxl/cxl.h | 2 ++ >> 3 files changed, 46 insertions

[PATCH] module: Make sure relocations are applied to the per-CPU section

2025-06-04 Thread Sebastian Andrzej Siewior
The per-CPU data section is handled differently than the other sections. The memory allocations requires a special __percpu pointer and then the section is copied into the view of each CPU. Therefore the SHF_ALLOC flag is removed to ensure move_module() skips it. Later, relocations are applied and

Re: [GIT PULL] SPDX/LICENSES update for 6.16-rc1

2025-06-04 Thread pr-tracker-bot
The pull request you sent on Wed, 4 Jun 2025 10:36:44 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/spdx.git > tags/spdx-6.16-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/f5ebe7bb87e04537b37573f0a2516baa90ee23c0 Thank you! -- Deet-doot-dot, I

Re: [PATCH RESEND] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-04 Thread David Hildenbrand
On 03.06.25 21:22, Lorenzo Stoakes wrote: The walk_page_range_novma() function is rather confusing - it supports two modes, one used often, the other used only for debugging. The first mode is the common case of traversal of kernel page tables, which is what nearly all callers use this for. ..

Re: [PATCH net] virtio-net: drop the multi-buffer XDP packet in zerocopy

2025-06-04 Thread Zvi Effron
On Tue, Jun 3, 2025 at 8:09 AM Bui Quang Minh wrote: > > In virtio-net, we have not yet supported multi-buffer XDP packet in > zerocopy mode when there is a binding XDP program. However, in that > case, when receiving multi-buffer XDP packet, we skip the XDP program > and return XDP_PASS. As a res

Re: [Question] attributes encoding in BTF

2025-06-04 Thread Ihor Solodrai
On 6/4/25 2:02 AM, Alexis Lothoré wrote: Hi all, a simpler version of this series has been merged, and so I am now taking a look at the issue I have put aside in the merged version: dealing with more specific data layout for arguments passed on stack. For example, a function can pass small struc

Re: [PATCH] selftests: cachestat: add tests for mmap and /proc/cpuinfo

2025-06-04 Thread Nhat Pham
On Sat, May 24, 2025 at 1:36 AM Suresh K C wrote: > > From: Suresh K C > > Add a test case to verify cachestat behavior with memory-mapped files > using mmap(). This ensures that pages accessed via mmap are correctly > accounted for in the page cache. > > Also add a test for /proc/cpuinfo to vali

Re: [PATCH v4 4/7] cxl/acpi: Add background worker to wait for cxl_pci and cxl_mem probe

2025-06-04 Thread Koralahalli Channabasappa, Smita
On 6/3/2025 4:45 PM, Dave Jiang wrote: On 6/3/25 3:19 PM, Smita Koralahalli wrote: Introduce a waitqueue mechanism to coordinate initialization between the cxl_pci and cxl_mem drivers. Launch a background worker from cxl_acpi_probe() that waits for both drivers to complete initialization befo

[PATCH vhost] vdpa/mlx5: Fix needs_teardown flag calculation

2025-06-04 Thread Dragos Tatulea
needs_teardown is a device flag that indicates when virtual queues need to be recreated. This happens for certain configuration changes: queue size and some specific features. Currently, the needs_teardown state can be incorrectly reset by subsequent .set_vq_num() calls. For example, for 1 rx VQ w

Re: [PATCH v4 0/7] Add managed SOFT RESERVE resource handling

2025-06-04 Thread Koralahalli Channabasappa, Smita
Hi Zhijian, Thanks for testing my patches. On 6/4/2025 1:43 AM, Zhijian Li (Fujitsu) wrote: Smita, Thanks for your awesome work. I just tested the scenarios you listed, and they work as expected. Thanks again. (Minor comments inlined) Tested-by: Li Zhijian To the CXL community, The scena

Re: [PATCH RFC net-next v2 2/3] vsock/test: Introduce get_transports()

2025-06-04 Thread Michal Luczaj
On 6/4/25 11:07, Stefano Garzarella wrote: > On Wed, May 28, 2025 at 10:44:42PM +0200, Michal Luczaj wrote: >> +static int __get_transports(void) >> +{ >> +/* Order must match transports defined in util.h. >> + * man nm: "d" The symbol is in the initialized data section. >> + */ >> +

Re: [PATCH RFC net-next v2 3/3] vsock/test: Cover more CIDs in transport_uaf test

2025-06-04 Thread Michal Luczaj
On 6/4/25 11:37, Stefano Garzarella wrote: > On Wed, May 28, 2025 at 10:44:43PM +0200, Michal Luczaj wrote: >> +static bool test_stream_transport_uaf(int cid) >> { >> int sockets[MAX_PORT_RETRIES]; >> struct sockaddr_vm addr; >> -int fd, i, alen; >> +socklen_t alen; >> +int fd

Re: [PATCH v4 1/7] cxl/region: Avoid null pointer dereference in is_cxl_region()

2025-06-04 Thread Nathan Fontenot
On 6/3/2025 6:49 PM, Dave Jiang wrote: > > > On 6/3/25 3:19 PM, Smita Koralahalli wrote: >> Add a NULL check in is_cxl_region() to prevent potential null pointer >> dereference if a caller passes a NULL device. This change ensures the >> function safely returns false instead of triggering undefin

Re: [PATCH v2 0/3] KVM: arm64: selftests: arch_timer_edge_cases fixes

2025-06-04 Thread Sebastian Ott
Hi Zenghui, On Tue, 3 Jun 2025, Zenghui Yu wrote: On 2025/5/27 22:24, Sebastian Ott wrote: Some small fixes for arch_timer_edge_cases that I stumbled upon while debugging failures for this selftest on ampere-one. Changes since v1: modified patch 3 based on suggestions from Marc. I've done som

Re: [PATCH v2 0/3] KVM: arm64: selftests: arch_timer_edge_cases fixes

2025-06-04 Thread Sebastian Ott
On Wed, 4 Jun 2025, Sebastian Ott wrote: On Tue, 3 Jun 2025, Zenghui Yu wrote: On 2025/5/27 22:24, Sebastian Ott wrote: Some small fixes for arch_timer_edge_cases that I stumbled upon while debugging failures for this selftest on ampere-one. Changes since v1: modified patch 3 based on sugg

Re: [PATCH RESEND] selftests/mm/run_vmtests.sh: skip hugevm tests if write_to_hugetlbfs is missing

2025-06-04 Thread Khaled Elnaggar
On 03/06/2025 5:12 am, Andrew Morton wrote: > On Tue, 3 Jun 2025 02:22:32 +0300 Khaled Elnaggar > wrote: > >> The hugevm tests 'charge_reserved_hugetlb.sh' and >> 'hugetlb_reparenting_test.sh' >> depend on the 'write_to_hugetlbfs' binary to simulate writes to hugetlbfs >> while checking reserv

[PATCH v4 0/7] use per-vma locks for /proc/pid/maps reads and PROCMAP_QUERY

2025-06-04 Thread Suren Baghdasaryan
Reading /proc/pid/maps requires read-locking mmap_lock which prevents any other task from concurrently modifying the address space. This guarantees coherent reporting of virtual address ranges, however it can block important updates from happening. Oftentimes /proc/pid/maps readers are low priority

[PATCH v4 1/7] selftests/proc: add /proc/pid/maps tearing from vma split test

2025-06-04 Thread Suren Baghdasaryan
The /proc/pid/maps file is generated page by page, with the mmap_lock released between pages. This can lead to inconsistent reads if the underlying vmas are concurrently modified. For instance, if a vma split or merge occurs at a page boundary while /proc/pid/maps is being read, the same vma might

[PATCH v4 2/7] selftests/proc: extend /proc/pid/maps tearing test to include vma resizing

2025-06-04 Thread Suren Baghdasaryan
Test that /proc/pid/maps does not report unexpected holes in the address space when a vma at the edge of the page is being concurrently remapped. This remapping results in the vma shrinking and expanding from under the reader. We should always see either shrunk or expanded (original) version of th

[PATCH v4 3/7] selftests/proc: extend /proc/pid/maps tearing test to include vma remapping

2025-06-04 Thread Suren Baghdasaryan
Test that /proc/pid/maps does not report unexpected holes in the address space when we concurrently remap a part of a vma into the middle of another vma. This remapping results in the destination vma being split into three parts and the part in the middle being patched back from, all done concurren

[PATCH v4 4/7] selftests/proc: test PROCMAP_QUERY ioctl while vma is concurrently modified

2025-06-04 Thread Suren Baghdasaryan
Extend /proc/pid/maps tearing test to verify PROCMAP_QUERY ioctl operation correctness while the vma is being concurrently modified. Signed-off-by: Suren Baghdasaryan --- tools/testing/selftests/proc/proc-pid-vm.c | 60 ++ 1 file changed, 60 insertions(+) diff --git a/tools/

[PATCH v4 5/7] selftests/proc: add verbose more for tests to facilitate debugging

2025-06-04 Thread Suren Baghdasaryan
Add verbose mode to the proc tests to print debugging information. Usage: proc-pid-vm -v Signed-off-by: Suren Baghdasaryan --- tools/testing/selftests/proc/proc-pid-vm.c | 154 +++-- 1 file changed, 141 insertions(+), 13 deletions(-) diff --git a/tools/testing/selftests/proc/pro

[PATCH v4 6/7] mm/maps: read proc/pid/maps under per-vma lock

2025-06-04 Thread Suren Baghdasaryan
With maple_tree supporting vma tree traversal under RCU and per-vma locks, /proc/pid/maps can be read while holding individual vma locks instead of locking the entire address space. Completely lockless approach would be quite complex with the main issue being get_vma_name() using callbacks which mi

[PATCH v4 7/7] mm/maps: execute PROCMAP_QUERY ioctl under per-vma locks

2025-06-04 Thread Suren Baghdasaryan
Utilize per-vma locks to stabilize vma after lookup without taking mmap_lock during PROCMAP_QUERY ioctl execution. While we might take mmap_lock for reading during contention, we do that momentarily only to lock the vma. This change is designed to reduce mmap_lock contention and prevent PROCMAP_QUE

Re: [PATCH v2 35/62] objtool: Refactor add_jump_destinations()

2025-06-04 Thread Josh Poimboeuf
On Fri, May 23, 2025 at 07:46:19AM -0400, Joe Lawrence wrote: > > - } else if (reloc->sym->sec->idx) { > > - dest_sec = reloc->sym->sec; > > - dest_off = reloc->sym->sym.st_value + > > - arch_dest_reloc_offset(reloc_addend(r

Re: [PATCH v2 18/62] objtool: Fix x86 addend calculation

2025-06-04 Thread Josh Poimboeuf
On Mon, May 26, 2025 at 12:23:15PM +0200, Peter Zijlstra wrote: > On Fri, May 09, 2025 at 01:16:42PM -0700, Josh Poimboeuf wrote: > > On x86, arch_dest_reloc_offset() hardcodes the addend adjustment to > > four, but the actual adjustment depends on the relocation type. Fix > > that. > > > +s64 ar

Re: [PATCH v2 28/62] objtool: Fix weak symbol hole detection for .cold functions

2025-06-04 Thread Josh Poimboeuf
On Mon, May 26, 2025 at 12:38:22PM +0200, Peter Zijlstra wrote: > On Fri, May 09, 2025 at 01:16:52PM -0700, Josh Poimboeuf wrote: > > When ignore_unreachable_insn() looks for weak function holes which jump > > to their .cold functions, it assumes the parent function comes before > > the correspondi

Re: [PATCH v2 29/62] objtool: Mark prefix functions

2025-06-04 Thread Josh Poimboeuf
On Mon, May 26, 2025 at 12:43:55PM +0200, Peter Zijlstra wrote: > > +++ b/tools/objtool/elf.c > > @@ -442,6 +442,11 @@ static void elf_add_symbol(struct elf *elf, struct > > symbol *sym) > > elf_hash_add(symbol, &sym->hash, sym->idx); > > elf_hash_add(symbol_name, &sym->name_hash, str_hash

Re: [PATCH v2 32/62] objtool: Suppress section skipping warnings with --dryrun

2025-06-04 Thread Josh Poimboeuf
On Wed, May 28, 2025 at 12:34:53PM +0200, Peter Zijlstra wrote: > On Mon, May 26, 2025 at 12:52:40PM +0200, Peter Zijlstra wrote: > > On Fri, May 09, 2025 at 01:16:56PM -0700, Josh Poimboeuf wrote: > > > It's common to use --dryrun on binaries that have already been > > > processed. Don't print th

Re: [PATCH v2 42/62] kbuild,x86: Fix module permissions for __jump_table and __bug_table

2025-06-04 Thread Josh Poimboeuf
On Mon, May 26, 2025 at 01:06:34PM +0200, Peter Zijlstra wrote: > On Fri, May 09, 2025 at 01:17:06PM -0700, Josh Poimboeuf wrote: > > An upcoming patch will add the SHF_MERGE flag to x86 __jump_table and > > __bug_table so their entry sizes can be defined in inline asm. > > > > However, those sect

Re: [PATCH v2 52/62] objtool/klp: Introduce klp diff subcommand for diffing object files

2025-06-04 Thread Josh Poimboeuf
On Mon, May 26, 2025 at 08:22:59PM +0200, Peter Zijlstra wrote: > On Fri, May 09, 2025 at 01:17:16PM -0700, Josh Poimboeuf wrote: > > > Without '-ffunction-sections -fdata-sections', reliable object diffing > > would be infeasible due to toolchain limitations: > > > > - For intra-file+intra-sec

Re: [PATCH net] virtio-net: drop the multi-buffer XDP packet in zerocopy

2025-06-04 Thread Jason Wang
On Wed, Jun 4, 2025 at 10:17 PM Bui Quang Minh wrote: > > On 6/4/25 07:37, Jason Wang wrote: > > On Tue, Jun 3, 2025 at 11:07 PM Bui Quang Minh > > wrote: > >> In virtio-net, we have not yet supported multi-buffer XDP packet in > >> zerocopy mode when there is a binding XDP program. However, in

Re: [PATCH v2 32/62] objtool: Suppress section skipping warnings with --dryrun

2025-06-04 Thread Josh Poimboeuf
On Mon, May 26, 2025 at 12:52:40PM +0200, Peter Zijlstra wrote: > On Fri, May 09, 2025 at 01:16:56PM -0700, Josh Poimboeuf wrote: > > It's common to use --dryrun on binaries that have already been > > processed. Don't print the section skipping warnings in that case. > > Ah, I rather like this wa

Re: [PATCH v4 4/7] cxl/acpi: Add background worker to wait for cxl_pci and cxl_mem probe

2025-06-04 Thread Zhijian Li (Fujitsu)
On 04/06/2025 22:35, Dave Jiang wrote: >>> >>> +static DECLARE_WAIT_QUEUE_HEAD(cxl_wait_queue); >> Given that this file (suspend.c) focuses on power management functions, >> it might be more appropriate to move the wait queue declaration and its >> related changes to acpi.c in where the its c

Re: [PATCH vhost] vdpa/mlx5: Fix needs_teardown flag calculation

2025-06-04 Thread Jason Wang
On Thu, Jun 5, 2025 at 2:48 AM Dragos Tatulea wrote: > > needs_teardown is a device flag that indicates when virtual queues need > to be recreated. This happens for certain configuration changes: queue > size and some specific features. > > Currently, the needs_teardown state can be incorrectly re

Re: [PATCH v2 42/62] kbuild,x86: Fix module permissions for __jump_table and __bug_table

2025-06-04 Thread Josh Poimboeuf
On Wed, Jun 04, 2025 at 05:22:15PM -0700, Josh Poimboeuf wrote: > On Mon, May 26, 2025 at 01:06:34PM +0200, Peter Zijlstra wrote: > > On Fri, May 09, 2025 at 01:17:06PM -0700, Josh Poimboeuf wrote: > > > An upcoming patch will add the SHF_MERGE flag to x86 __jump_table and > > > __bug_table so thei

Re: [PATCH v2] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-04 Thread Oscar Salvador
On Wed, Jun 04, 2025 at 03:19:58PM +0100, Lorenzo Stoakes wrote: > The walk_page_range_novma() function is rather confusing - it supports two > modes, one used often, the other used only for debugging. > > The first mode is the common case of traversal of kernel page tables, which > is what nearly

Re: [PATCH v2] mm/pagewalk: split walk_page_range_novma() into kernel/user parts

2025-06-04 Thread Qi Zheng
On 6/4/25 10:19 PM, Lorenzo Stoakes wrote: The walk_page_range_novma() function is rather confusing - it supports two modes, one used often, the other used only for debugging. The first mode is the common case of traversal of kernel page tables, which is what nearly all callers use this for.

[PATCH v2] module: Make sure relocations are applied to the per-CPU section

2025-06-04 Thread Sebastian Andrzej Siewior
The per-CPU data section is handled differently than the other sections. The memory allocations requires a special __percpu pointer and then the section is copied into the view of each CPU. Therefore the SHF_ALLOC flag is removed to ensure move_module() skips it. Later, relocations are applied and

Re: [PATCH v2 0/3] KVM: arm64: selftests: arch_timer_edge_cases fixes

2025-06-04 Thread Marc Zyngier
On Wed, 04 Jun 2025 21:58:48 +0100, Sebastian Ott wrote: > > Hi Zenghui, > > On Tue, 3 Jun 2025, Zenghui Yu wrote: > > On 2025/5/27 22:24, Sebastian Ott wrote: > >> Some small fixes for arch_timer_edge_cases that I stumbled upon > >> while debugging failures for this selftest on ampere-one. > >>