Re: [PATCH v10.1 8/9] xfs: Implement ->notify_failure() for XFS

2022-02-14 Thread Darrick J. Wong
On Sun, Feb 13, 2022 at 09:02:24PM +0800, Shiyang Ruan wrote: > v10.1 update: > - Handle the error code returns by dax_register_holder() > - In v10.1, dax_register_holder() will hold a write lock so XFS > doesn't need to hold a lock > - Fix the mistake in failure notification over two AGs

Re: [PATCH] dax: make sure inodes are flushed before destroy cache

2022-02-14 Thread Ira Weiny
On Mon, Feb 14, 2022 at 12:09:54PM -0800, Dan Williams wrote: > On Mon, Feb 14, 2022 at 9:59 AM Ira Weiny wrote: > > > > On Fri, Feb 11, 2022 at 11:11:11PM -0800, Tong Zhang wrote: > > > A bug can be triggered by following command > > > > > > $ modprobe nd_pmem && modprobe -r nd_pmem > > > > > >

Re: [PATCH] dax: make sure inodes are flushed before destroy cache

2022-02-14 Thread Dan Williams
On Mon, Feb 14, 2022 at 9:59 AM Ira Weiny wrote: > > On Fri, Feb 11, 2022 at 11:11:11PM -0800, Tong Zhang wrote: > > A bug can be triggered by following command > > > > $ modprobe nd_pmem && modprobe -r nd_pmem > > > > [ 10.060014] BUG dax_cache (Not tainted): Objects remaining in dax_cache >

Re: [PATCH] dax: make sure inodes are flushed before destroy cache

2022-02-14 Thread Ira Weiny
On Fri, Feb 11, 2022 at 11:11:11PM -0800, Tong Zhang wrote: > A bug can be triggered by following command > > $ modprobe nd_pmem && modprobe -r nd_pmem > > [ 10.060014] BUG dax_cache (Not tainted): Objects remaining in dax_cache on > __kmem_cache_shutdown() > [ 10.060938] Slab

Re: [PATCH] dax: make sure inodes are flushed before destroy cache

2022-02-14 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig