Re: [PATCH 5.11 12/31] gpiolib: Read "gpio-line-names" from a firmware node

2021-03-19 Thread Marek Vasut
On 3/19/21 1:19 PM, Greg Kroah-Hartman wrote: From: Andy Shevchenko [ Upstream commit b41ba2ec54a70908067034f139aa23d0dd2985ce ] On STM32MP1, the GPIO banks are subnodes of pin-controller@50002000, see arch/arm/boot/dts/stm32mp151.dtsi. The driver for pin-controller@50002000 is in drivers/pinc

Re: [PATCH 5.11 12/31] gpiolib: Read "gpio-line-names" from a firmware node

2021-03-19 Thread Marek Vasut
On 3/19/21 1:36 PM, Greg Kroah-Hartman wrote: On Fri, Mar 19, 2021 at 01:27:23PM +0100, Marek Vasut wrote: On 3/19/21 1:19 PM, Greg Kroah-Hartman wrote: From: Andy Shevchenko [ Upstream commit b41ba2ec54a70908067034f139aa23d0dd2985ce ] On STM32MP1, the GPIO banks are subnodes of pin

Re: [PATCH AUTOSEL 5.10 050/217] rsi: Fix TX EAPOL packet handling against iwlwifi AP

2021-03-04 Thread Marek Vasut
On 3/4/21 9:47 PM, Sasha Levin wrote: On Tue, Mar 02, 2021 at 08:25:49PM +0100, Marek Vasut wrote: On 12/23/20 3:13 AM, Sasha Levin wrote: Hello Sasha, From: Marek Vasut [ Upstream commit 65277100caa2f2c62b6f3c4648b90d6f0435f3bc ] In case RSI9116 SDIO WiFi operates in STA mode against

Re: [PATCH v1 1/1] gpiolib: Read "gpio-line-names" from a firmware node

2021-03-05 Thread Marek Vasut
162 ("gpiolib: generalize devprop_gpiochip_set_names() for device properties") Reported-by: Marek Vasut Reported-by: Roman Guskov Signed-off-by: Andy Shevchenko Tested-by: Marek Vasut Reviewed-by: Marek Vasut Thanks static int devprop_gpiochip_set_names(struct gpio_chip *c

Re: [PATCH v1 1/1] gpiolib: Read "gpio-line-names" from a firmware node

2021-03-05 Thread Marek Vasut
On 3/5/21 1:24 PM, Andy Shevchenko wrote: On Fri, Mar 05, 2021 at 01:11:39PM +0100, Marek Vasut wrote: On 3/5/21 1:02 PM, Andy Shevchenko wrote: On STM32MP1, the GPIO banks are subnodes of pin-controller@50002000, see arch/arm/boot/dts/stm32mp151.dtsi. The driver for pin-controller@50002000 is

Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for SN65DSI83/84/85

2021-03-05 Thread Marek Vasut
On 2/14/21 6:44 PM, Jagan Teki wrote: SN65DSI83/84/85 devices are MIPI DSI to LVDS based bridge controller IC's from Texas Instruments. SN65DSI83 - Single Channel DSI to Single-link LVDS bridge SN65DSI84 - Single Channel DSI to Dual-link LVDS bridge SN65DSI85 - Dual Channel DSI to Dual-link LVDS

Re: [PATCH v3 2/2] drm: bridge: Add TI SN65DSI83/84/85 DSI to LVDS bridge

2021-03-05 Thread Marek Vasut
On 2/14/21 6:44 PM, Jagan Teki wrote: [...] +static const struct regmap_config sn65dsi_regmap_config = { + .reg_bits = 8, + .val_bits = 8, + .max_register = SN65DSI_CHA_ERR, + .name = "sn65dsi", + .cache_type = REGCACHE_RBTREE, +}; You might want to look at the d

Re: [PATCH AUTOSEL 5.10 050/217] rsi: Fix TX EAPOL packet handling against iwlwifi AP

2021-03-02 Thread Marek Vasut
On 12/23/20 3:13 AM, Sasha Levin wrote: Hello Sasha, From: Marek Vasut [ Upstream commit 65277100caa2f2c62b6f3c4648b90d6f0435f3bc ] In case RSI9116 SDIO WiFi operates in STA mode against Intel 9260 in AP mode, the association fails. The former is using wpa_supplicant during association, the

Re: [PATCH v5 00/14] Add BLK_CTL support for i.MX8MP

2021-03-03 Thread Marek Vasut
On 3/3/21 11:47 AM, Abel Vesa wrote: On 20-11-03 13:18:12, Abel Vesa wrote: The BLK_CTL according to HW design is basically the wrapper of the entire function specific group of IPs and holds GPRs that usually cannot be placed into one specific IP from that group. Some of these GPRs are used to c

Re: [PATCH 11/13] ARM: dts: stm32: fix LTDC port node on STM32 MCU ad MPU

2021-04-15 Thread Marek Vasut
On 4/15/21 12:10 PM, Alexandre Torgue wrote: Running "make dtbs_check W=1", some warnings are reported concerning LTDC port subnode: /soc/display-controller@5a001000/port: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property /soc/display-controller@5a001000/port: graph

Re: [PATCH 11/13] ARM: dts: stm32: fix LTDC port node on STM32 MCU ad MPU

2021-04-15 Thread Marek Vasut
On 4/15/21 3:34 PM, Alexandre TORGUE wrote: Hi Marek Hello Alexandre, diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts b/arch/arm/boot/dts/stm32mp157c-dk2.dts index 2bc92ef3aeb9..19ef475a48fc 100644 --- a/arch/arm/boot/dts/stm32mp157c-dk2.dts +++ b/arch/arm/boot/dts/stm32mp157c-dk2.dts @@

Re: [PATCH 11/13] ARM: dts: stm32: fix LTDC port node on STM32 MCU ad MPU

2021-04-15 Thread Marek Vasut
On 4/15/21 4:35 PM, Alexandre TORGUE wrote: On 4/15/21 4:30 PM, Marek Vasut wrote: On 4/15/21 3:34 PM, Alexandre TORGUE wrote: Hi Marek Hello Alexandre, diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts b/arch/arm/boot/dts/stm32mp157c-dk2.dts index 2bc92ef3aeb9..19ef475a48fc 100644

Re: [PATCH v1 1/1] gpiolib: Read "gpio-line-names" from a firmware node

2021-04-09 Thread Marek Vasut
On 3/15/21 6:04 PM, Andy Shevchenko wrote: On Mon, Mar 15, 2021 at 6:49 PM Bartosz Golaszewski wrote: On Mon, Mar 15, 2021 at 3:34 PM Andy Shevchenko wrote: On Mon, Mar 15, 2021 at 03:04:37PM +0100, Bartosz Golaszewski wrote: On Mon, Mar 15, 2021 at 1:50 PM Andy Shevchenko wrote: On Mon

Re: [PATCH v1 1/1] gpiolib: Read "gpio-line-names" from a firmware node

2021-04-10 Thread Marek Vasut
On 4/10/21 11:06 AM, Bartosz Golaszewski wrote: On Sat, Apr 10, 2021 at 2:46 AM Marek Vasut wrote: On 3/15/21 6:04 PM, Andy Shevchenko wrote: On Mon, Mar 15, 2021 at 6:49 PM Bartosz Golaszewski wrote: On Mon, Mar 15, 2021 at 3:34 PM Andy Shevchenko wrote: On Mon, Mar 15, 2021 at 03:04

Re: [PATCH stable] gpiolib: Read "gpio-line-names" from a firmware node

2021-04-10 Thread Marek Vasut
5000*000. To achieve the same behaviour, read property from the firmware node. Fixes: 7cba1a4d5e162 ("gpiolib: generalize devprop_gpiochip_set_names() for device properties") Cc: sta...@vger.kernel.org Reported-by: Marek Vasut Reported-by: Roman Guskov Signed-off-by: Andy Shevchenko

Re: [PATCH 02/13] PCI: rcar: Convert to MSI domains

2021-02-28 Thread Marek Vasut
and IWLwifi 6235 card, Tested-by: Marek Vasut Thanks.

Re: [Linux-stm32] [PATCH v2 00/14] Introduce STM32MP1 RCC in secured mode

2021-03-11 Thread Marek Vasut
On 3/11/21 7:10 PM, Alexandre TORGUE wrote: Hi Guys On 3/11/21 5:11 PM, Marek Vasut wrote: On 3/11/21 3:41 PM, Ahmad Fatoum wrote: Hello, Hi, On 11.03.21 15:02, Alexandre TORGUE wrote: On 3/11/21 12:43 PM, Marek Vasut wrote: On 3/11/21 9:08 AM, Alexandre TORGUE wrote: 1- Break the

Re: [PATCH 5.10 081/290] gpiolib: Read "gpio-line-names" from a firmware node

2021-03-15 Thread Marek Vasut
On 3/15/21 2:52 PM, gre...@linuxfoundation.org wrote: From: Greg Kroah-Hartman From: Andy Shevchenko commit b41ba2ec54a70908067034f139aa23d0dd2985ce upstream. On STM32MP1, the GPIO banks are subnodes of pin-controller@50002000, see arch/arm/boot/dts/stm32mp151.dtsi. The driver for pin-contro

Re: [PATCH v2 00/14] Introduce STM32MP1 RCC in secured mode

2021-03-11 Thread Marek Vasut
On 3/11/21 9:08 AM, Alexandre TORGUE wrote: Hi ALex Hello everyone, [...] Subject: Re: [PATCH v2 00/14] Introduce STM32MP1 RCC in secured mode On 1/26/21 3:01 AM, gabriel.fernan...@foss.st.com wrote: From: Gabriel Fernandez Platform STM32MP1 can be used in configuration where some clocks

Re: [PATCH v2 00/14] Introduce STM32MP1 RCC in secured mode

2021-03-11 Thread Marek Vasut
On 3/11/21 2:15 PM, Alexandre TORGUE wrote: Hi Marek Hello Alexandre, On 3/11/21 12:43 PM, Marek Vasut wrote: On 3/11/21 9:08 AM, Alexandre TORGUE wrote: Hi ALex Hello everyone, [...] Subject: Re: [PATCH v2 00/14] Introduce STM32MP1 RCC in secured mode On 1/26/21 3:01 AM

Re: [Linux-stm32] [PATCH v2 00/14] Introduce STM32MP1 RCC in secured mode

2021-03-11 Thread Marek Vasut
On 3/11/21 3:41 PM, Ahmad Fatoum wrote: Hello, Hi, On 11.03.21 15:02, Alexandre TORGUE wrote: On 3/11/21 12:43 PM, Marek Vasut wrote: On 3/11/21 9:08 AM, Alexandre TORGUE wrote: 1- Break the current ABI: as soon as those patches are merged, stm32mp157c-dk2.dtb will impose to use A tf-a

Re: [PATCH] [5.8 regression] net: ks8851: fix link error

2021-01-26 Thread Marek Vasut
On 1/25/21 1:19 PM, Arnd Bergmann wrote: From: Arnd Bergmann An object file cannot be built for both loadable module and built-in use at the same time: arm-linux-gnueabi-ld: drivers/net/ethernet/micrel/ks8851_common.o: in function `ks8851_probe_common': ks8851_common.c:(.text+0xf80): undefine

Re: [PATCH] net: ks8851: remove definition of DEBUG

2021-01-15 Thread Marek Vasut
On 1/15/21 4:31 PM, t...@redhat.com wrote: From: Tom Rix Defining DEBUG should only be done in development. So remove DEBUG. Signed-off-by: Tom Rix Reviewed-by: Marek Vasut Thanks

Re: [RFC 3/3] clk: imx: Add blk-ctl driver for i.MX8MN

2021-01-27 Thread Marek Vasut
On 10/24/20 6:20 PM, Adam Ford wrote: This driver is intended to work with the multimedia block which contains display and camera subsystems: LCDIF ISI MIPI CSI MIPI DSI Signed-off-by: Adam Ford --- drivers/clk/imx/clk-blk-ctl-imx8mn.c | 80 You seem

Re: [PATCH v8 2/2] iio: Add AS3935 lightning sensor support

2014-03-12 Thread Marek Vasut
On Wednesday, March 12, 2014 at 01:53:14 PM, Matt Ranostay wrote: > AS3935 chipset can detect lightning strikes and reports those back as > events and the estimated distance to the storm. > > Signed-off-by: Matt Ranostay Reviewed-by: Marek Vasut Best regards, Marek Vasut -- To

Re: [PATCH v2 1/2] i2c: add DMA support for freescale i2c driver

2014-03-05 Thread Marek Vasut
On Wednesday, March 05, 2014 at 07:52:31 AM, Yuan Yao wrote: > Add dma support for i2c. This function depend on DMA driver. > You can turn on it by write both the dmas and dma-name properties in dts > node. > > Signed-off-by: Yuan Yao > --- [...] > struct imx_i2c_struct { > struct i2c_ad

Re: [PATCH v2 1/2] i2c: add DMA support for freescale i2c driver

2014-03-05 Thread Marek Vasut
On Thursday, March 06, 2014 at 05:36:14 AM, Yao Yuan wrote: > On Thu, March 06, 2014 at 11:23:50 AM, Marek Vasut wrote: > > On Wednesday, March 05, 2014 at 07:52:31 AM, Yuan Yao wrote: > > > Add dma support for i2c. This function depend on DMA driver. > > > You can t

Re: [PATCH v2 1/2] i2c: add DMA support for freescale i2c driver

2014-03-06 Thread Marek Vasut
On Thursday, March 06, 2014 at 06:02:03 AM, Yao Yuan wrote: > On Thu, March 06, 2014 at 12:44:14 PM, Marek Vasut wrote: > > On Thursday, March 06, 2014 at 05:36:14 AM, Yao Yuan wrote: > > > On Thu, March 06, 2014 at 11:23:50 AM, Marek Vasut wrote: > > > > On Wednesd

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-27 Thread Marek Vasut
On Thursday, February 27, 2014 at 07:05:14 AM, Yuan Yao wrote: [...] > */ @@ -63,6 +68,9 @@ > /* Default value */ > #define IMX_I2C_BIT_RATE 10 /* 100kHz */ > > +/* enable DMA if transfer size is bigger than this threshold */ > +#define IMX_I2C_DMA_THRESHOLD16 So what's t

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-28 Thread Marek Vasut
On Friday, February 28, 2014 at 06:19:18 AM, Yao Yuan wrote: [...] > > > @@ -213,6 +238,7 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata = { > > > > > > .ndivs = ARRAY_SIZE(vf610_i2c_clk_div), > > > .i2sr_clr_opcode= I2SR_CLR_OPCODE_W1C, > > > .i2cr_ien_opcode

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-28 Thread Marek Vasut
On Friday, February 28, 2014 at 03:23:52 AM, Shawn Guo wrote: > On Fri, Feb 28, 2014 at 10:13:02AM +0800, Shawn Guo wrote: > > On Thu, Feb 27, 2014 at 09:39:35PM +0100, Marek Vasut wrote: > > > > @@ -193,6 +216,7 @@ static const struct imx_i2c_hwdata &g

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-28 Thread Marek Vasut
TX or RX. > > > > Sorry, I don't quite understand this. If you have two DMA channels, can > > you not use them both to do full-duplex SPI transfer ? > > Sorry, There are also hard for me. I don't understand what is full-duplex > for dma? Sorry, nevermin

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-28 Thread Marek Vasut
On Friday, February 28, 2014 at 11:59:25 AM, Lothar Waßmann wrote: > Hi, > > Marek Vasut wrote: > > On Friday, February 28, 2014 at 06:19:18 AM, Yao Yuan wrote: > > > > [...] > > > > > Yes, here have two dma channels, one for RX and the other one fo

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-03-03 Thread Marek Vasut
On Monday, March 03, 2014 at 11:23:33 AM, Yao Yuan wrote: > Hi, Marek > > Marek Vasut wrote: > > On Thursday, February 27, 2014 at 07:05:14 AM, Yuan Yao wrote: > > > > [...] > > > > > +static void i2c_imx_dma_free(struct imx_i2c_struct *i2c_imx) { >

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-04-04 Thread Marek Vasut
o trim the email only to the relevant parts when replying so it's easier to find your commments in the entire body of text. > > + if (!dma->chan_tx) { > > + dev_info(dev, "DMA tx channel request failed\n"); > > + ret = -ENODEV; >

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

2014-04-04 Thread Marek Vasut
-EINVAL; > + } > + > + txdesc->callback = i2c_imx_dma_callback; > + txdesc->callback_param = i2c_imx; > + dmaengine_submit(txdesc); > + dma_async_issue_pending(dma->chan_using); > + > + return 0; > +} [...] Other than those two things, Reviewed

Possible bug in firmware/Makefile

2013-11-26 Thread Marek Vasut
sue please? Is there a way to specify the extra firmware file to be built into the kernel on the kernel build command line please? Thank you very much! Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to maj

Re: [PATCH] imx-drm: parallel-display: honor 'native-mode' property when selecting video mode from DT

2014-01-13 Thread Marek Vasut
efined in > their .dts files, the patch does not change the behaviour of this > driver on the affected platforms. > > Signed-off-by: Lothar Waßmann Looks OK to me, thanks. Reviewed-by: Marek Vasut Best regards, Marek Vasut -- To unsubscribe from this list: send the line "uns

Re: [PATCH 2/3] iio: mxs-lradc: fix invalid channel number detection

2014-01-13 Thread Marek Vasut
o 15. > > Signed-off-by: Alexandre Belloni Why don't you remove the check entirely then ? Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 4/7] drivers/pci/host: don't check resource with devm_ioremap_resource

2014-01-14 Thread Marek Vasut
On Tuesday, January 14, 2014 at 12:58:55 PM, Wolfram Sang wrote: > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang True that, Acked-by: Marek Vasut > --- > > Should go via subsyst

Re: [PATCH] ARM: pxa/colibri: fix build with CONFIG_USB_OHCI_HCD=y

2013-11-07 Thread Marek Vasut
olibri-evalboard.c:68: error: implicit declaration of > function 'IOMEM' make[1]: *** [arch/arm/mach-pxa/colibri-evalboard.o] > Error 1 > make: *** [arch/arm/mach-pxa] Error 2 > > Signed-off-by: Dmitry Artamonow Acked-by: Marek Vasut Best regards, Marek Vasut -- To unsubsc

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-12 Thread Marek Vasut
"setting\n"); 372 return -EIO; 373 } btw. (idea for subsequent patch) this pch_dbg() should be fixed to be a one- liner /wrt the text so we can grep for the error messages. Such text arg should never be split in multiple lines in kernel. Best regards, Marek V

Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received

2013-11-12 Thread Marek Vasut
Dear Andreas Werner, > On Tue, Nov 12, 2013 at 07:00:59PM +0100, Marek Vasut wrote: > > Dear Andreas Werner, > > > > > Using the i2c-eg20t driver and call i2cdetect or probe on the bus, > > > the driver will print a lot of error messages if there was no ACK >

Re: [PATCH RFC 9/9] arm: imx: non-secure aliased mapping of GIC registers

2014-07-21 Thread Marek Vasut
f adding a static one ? Also, can you add a flag to the MT_DEVICE_NS that says the mapping can only ever be in L1 and never in "lower" levels of the page table ? Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

Re: [PATCH RFC 1/9] irqchip: gic: Provide support for interrupt grouping

2014-07-21 Thread Marek Vasut
gic bits here could use some clarification, possibly a comment. > + writel_relaxed(softint, > +gic_data_dist_base(&gic_data[0]) + GIC_DIST_SOFTINT); > > raw_spin_unlock_irqrestore(&irq_controller_lock, flags); > } [...] Best regards, Marek Vasut -

Re: [PATCH V3] Add support for flag status register on Micron chips.

2014-04-22 Thread Marek Vasut
FO(0x20ba21, 0, 64 * 1024, 2048, USE_FSR) }, Are you sure the n25q512a doesn't use FSR ? Do n25q512a{1,8}3 share the same IDs? [...] Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

Re: [PATCH V3] Add support for flag status register on Micron chips.

2014-04-22 Thread Marek Vasut
On Tuesday, April 22, 2014 at 08:48:21 PM, Graham Moore wrote: > On Tue, Apr 22, 2014 at 11:55 AM, Marek Vasut wrote: > > Are you sure the n25q512a doesn't use FSR ? Do n25q512a{1,8}3 share the > > same IDs? > > I looked at the datasheet and the n25q512a *does* have the

Re: [PATCH 3/3] crypto: Fix leak of struct aead_request in test_aead_speed()

2014-04-22 Thread Marek Vasut
r Reviewed-by: Marek Vasut Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/3] crypto: Fix potential leak in test_aead_speed() if aad_size is too big

2014-04-22 Thread Marek Vasut
On Monday, April 21, 2014 at 08:45:59 PM, Christian Engelmayer wrote: > Fix a potential memory leak in the error handling of test_aead_speed(). In > case the size check on the associate data length parameter fails, the > function goes through the wrong exit label. Reported by Coverity - CID > 11638

Re: [PATCH 2/3] crypto: Fix potential leak in test_aead_speed() if crypto_alloc_aead() fails

2014-04-22 Thread Marek Vasut
D 1163870. > > Signed-off-by: Christian Engelmayer Looks OK to me, thanks. Reviewed-by: Marek Vasut Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://

Re: [PATCH 1/3] crypto: Fix potential leak in test_aead_speed() if aad_size is too big

2014-04-23 Thread Marek Vasut
On Wednesday, April 23, 2014 at 07:43:35 PM, Christian Engelmayer wrote: > On Wed, 23 Apr 2014 01:33:05 +0200, Marek Vasut wrote: > > On Monday, April 21, 2014 at 08:45:59 PM, Christian Engelmayer wrote: > > > + if (aad_size >= PAGE_SIZE) { > > > > On an unre

Re: [PATCH V3] Add support for flag status register on Micron chips.

2014-04-24 Thread Marek Vasut
On Friday, April 25, 2014 at 03:34:36 AM, Huang Shijie wrote: > On Tue, Apr 22, 2014 at 09:03:16AM -0500, Graham Moore wrote: > > Some new Micron flash chips require reading the flag > > status register to determine when operations have completed. > > > > Furthermore, chips with multi-die stacks o

Re: [PATCH v7 1/2] i2c: imx: add DMA support for freescale i2c driver

2014-09-17 Thread Marek Vasut
should stop the DMA > > immediatelly if there is an error to avoid wasting resources and prevent > > possible other adverse effects. > > [Yuan Yao] > Yes, I have stopped the DMA immediately. However I keep the I2C DMA > single route. > > I don't have the ex

Re: [PATCH v7 1/2] i2c: imx: add DMA support for freescale i2c driver

2014-09-19 Thread Marek Vasut
On Thursday, September 18, 2014 at 05:46:04 PM, Yao Yuan wrote: > Marek Vasut wrote: > > On Wednesday, September 17, 2014 at 04:50:34 PM, Yao Yuan wrote: > > [...] > > > > > > > > Would that mean that the "crashed" DMA would be running unt

Re: [PATCH v2] iio: mxs-lradc: remove useless check

2014-01-18 Thread Marek Vasut
exandre Belloni > --- > drivers/staging/iio/adc/mxs-lradc.c | 4 > 1 file changed, 4 deletions(-) Changelog's missing ;-) Acked-by: Marek Vasut > diff --git a/drivers/staging/iio/adc/mxs-lradc.c > b/drivers/staging/iio/adc/mxs-lradc.c index 7fc66a6a6e36..d304156ca2f7 > 1006

Re: [PATCH 1/1] driver:mtd:spi-nor: Add Micron quad I/O support

2014-09-25 Thread Marek Vasut
t; + } > + > + if (wait_till_ready(nor)) > + return 1; Why does this not return proper error code or even better, return value from wait_till_ready() ? Other than that, there's nothing wrong with the patch I think. Best regards, Marek Vasut -- To unsubscribe f

Re: [PATCH v8 0/2] i2c: imx: add DMA support for freescale i2c driver

2014-09-25 Thread Marek Vasut
On Thursday, September 25, 2014 at 10:11:27 AM, Yuan Yao wrote: > Changed in v8: > - some minor fixes for coding style. > - unsetting I2CR_DMAEN immediatelly when failed in DMA mode. Brief skim over the patch doesn't show any dangling problems. Reviewed-by: Marek Vasut btw. the

Re: [PATCH 1/1] driver:mtd:spi-nor: Add Micron quad I/O support

2014-09-26 Thread Marek Vasut
elow method is OK? Or you can give me some suggestion. > > if (wait_till_ready(nor)) > return - EINVAL; ret = wait_till_readynor() if (ret) return ret; But all right, this means the subsystem isn't perfect. Well, others, what do you think ? Best regards, Marek Vasut -- To

Re: [PATCH 1/1 v2] driver:mtd:spi-nor: Add Micron quad I/O support

2014-09-28 Thread Marek Vasut
On Sunday, September 28, 2014 at 03:59:42 AM, bpqw wrote: > For Micron spi norflash,you can enable > Quad spi transfer by clear EVCR(Enhanced > Volatile Configuration Register) Quad I/O > protocol bit. OK, this information is nice and all, but what does this patch do? I can't learn this informat

Re: [PATCH 1/1 v2] driver:mtd:spi-nor: Add Micron quad I/O support

2014-09-29 Thread Marek Vasut
ts bit FOO in register BAR to enable 4-bit I/O if condition BAZ and QUUX are met. Then I do not even have to look at the code if I want to just get the high-level overview of what the patch does. If I want to know the details, I will look into the code. Do you know what I'm getting at ?

Re: [PATCH 1/1 v3] driver:mtd:spi-nor: Add Micron quad I/O support

2014-09-30 Thread Marek Vasut
? Brian, am I bitching too much about pointless things ? Please stop me if you think I do. [...] Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.

Re: [PATCH v7 1/2] i2c: imx: add DMA support for freescale i2c driver

2014-09-16 Thread Marek Vasut
On Wednesday, September 10, 2014 at 04:48:01 PM, Yao Yuan wrote: > On Friday, September 05, 2014 6:41 PM, Marek Vasut wrote: > > On Friday, September 05, 2014 at 12:32:40 PM, Yao Yuan wrote: > > [...] > > > > > > > +static int i2c_imx_dma_

Re: [PATCH v6] spi: spi-imx: add DMA support

2014-09-16 Thread Marek Vasut
> If not set "dma-names" in dts, spi will use PIO mode. This patch only > > validate on i.mx6, not i.mx5, but encourage ones to apply this patch > > on i.mx5 since they share the same IP. > > Adding Maerk (who I had to add to earlier versions of this patch). Looks OK

Re: [PATCH] reset: Add optional resets and stubs

2014-03-08 Thread Marek Vasut
e drivers > can be compiled with CONFIG_RESET_CONTROLLER disabled. > Also, device_reset is annotated with __must_check. Drivers ignoring the > return value should use device_reset_optional instead. > > Signed-off-by: Philipp Zabel Nice. Reviewed-by: Marek Vasut Best regards, Marek

Re: [PATCH v2 1/2] i2c: add DMA support for freescale i2c driver

2014-03-11 Thread Marek Vasut
On Tuesday, March 11, 2014 at 06:27:39 AM, Yao Yuan wrote: > On Thu, Mar 10, 2014 at 10:01:42 AM, Marek Vasut wrote: > > On Thu, Mar 06, 2014 at 12:57:42PM +0100, Marek Vasut wrote: > > > On Thursday, March 06, 2014 at 06:02:03 AM, Yao Yuan wrote: > > > > On Thu,

Re: [PATCH V3] Add support for flag status register on Micron chips.

2014-04-25 Thread Marek Vasut
On Friday, April 25, 2014 at 06:47:04 AM, Huang Shijie wrote: > On Tue, Apr 22, 2014 at 01:48:21PM -0500, Graham Moore wrote: > > On Tue, Apr 22, 2014 at 11:55 AM, Marek Vasut wrote: > > > Are you sure the n25q512a doesn't use FSR ? Do n25q512a{1,8}3 share the > > >

Re: [PATCH V3] Add support for flag status register on Micron chips.

2014-04-25 Thread Marek Vasut
On Friday, April 25, 2014 at 03:52:46 AM, Huang Shijie wrote: > On Fri, Apr 25, 2014 at 04:42:33AM +0200, Marek Vasut wrote: > > On Friday, April 25, 2014 at 03:34:36 AM, Huang Shijie wrote: > > > On Tue, Apr 22, 2014 at 09:03:16AM -0500, Graham Moore wrote: > > > &g

Re: [PATCH V3] Add support for flag status register on Micron chips.

2014-04-27 Thread Marek Vasut
On Saturday, April 26, 2014 at 05:10:13 AM, Huang Shijie wrote: > On Sat, Apr 26, 2014 at 12:12:24AM +0200, Marek Vasut wrote: > > > > > the drivers may fills this hook itself, so the cod

Re: [PATCH] staging: crypto: skein: depend upon CRYPTO

2014-04-28 Thread Marek Vasut
;& CRYPTO_SKEIN) selects > CRYPTO_HASH which has unmet direct dependencies (CRYPTO) > > Fix this in the Kconfig by depending on CRYPTO. > > Reported-by: Fengguang Wu > Signed-off-by: Jason Cooper Reviewed-by: Marek Vasut Best regards, Marek Vasut -- To unsubscribe from this lis

Re: [PATCH] Add support for flag status register on Micron chips.

2014-04-09 Thread Marek Vasut
m25p *flash) > +static int _wait_till_ready(struct m25p *flash) Please avoid using function names that start with underscore . [...] Thanks! Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] Add support for flag status register on Micron chips

2014-04-09 Thread Marek Vasut
. Can these SPI flash makers screw the design even more? OT: Why don't we have a single standard for all the SF chips which won't need all these crappy quirks :-( Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

Re: [PATCH] Add support for flag status register on Micron chips

2014-04-09 Thread Marek Vasut
On Wednesday, April 09, 2014 at 08:14:49 PM, Graham Moore wrote: > On Wed, Apr 9, 2014 at 6:09 AM, Gerhard Sittig wrote: > > On Wed, 2014-04-09 at 12:03 +0200, Marek Vasut wrote: > >> On Tuesday, April 08, 2014 at 06:12:49 PM, grmo...@altera.com wrote: > &g

Re: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

2014-03-22 Thread Marek Vasut
On Thursday, March 13, 2014 at 02:47:56 AM, Yuan Yao wrote: > Add dma support for i2c. This function depend on DMA driver. > You can turn on it by write both the dmas and dma-name properties in dts > node. > > Signed-off-by: Yuan Yao > --- > drivers/i2c/busses/i2c-imx.c | 354 > +

Re: New NAND driver

2014-03-24 Thread Marek Vasut
27;ve > split it over 47 patches for reviewing purposes. One nand driver in 47 patches ? Whoa ;-) Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at htt

Re: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

2014-03-25 Thread Marek Vasut
NULL pointer ? > > Then you won't need a separate variable, for this purpose ... right ? > > Sorry and I think what I know is just to check whether it is NULL. > Then for the second question, maybe there are some other ways, But I think > it is more tidy and easier understanding

Re: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

2014-03-25 Thread Marek Vasut
On Wednesday, March 26, 2014 at 06:56:34 AM, Yao Yuan wrote: > On Wednesday, March 26, 2014 at 11:43:27 AM, Marek Vasut wrote: > > On Wednesday, March 26, 2014 at 04:08:27 AM, Yao Yuan wrote: > > > > [...] > > > > > > > + i2c_imx-&

Re: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

2014-03-26 Thread Marek Vasut
On Wednesday, March 26, 2014 at 08:08:28 AM, Yao Yuan wrote: > On Wednesday, March 26, 2014 at 02:27:46 PM, Marek Vasut wrote: > > On Wednesday, March 26, 2014 at 06:56:34 AM, Yao Yuan wrote: > > > On Wednesday, March 26, 2014 at 11:43:27 AM, Marek Vasut wrote: > > > >

Re: [RFC PATCH 03/12] pci: host: pcie-designware: Use *base-mask* for configuring the iATU

2014-03-27 Thread Marek Vasut
slation window the > > *base* should be programmed as 0x000_. Whenever we try to write to > > say 0x2000_, it will be translated to whatever we have programmed in > > the translation window with base as 0x000_. > > > > Signed-off-by: Kishon Vijay Abraham I >

Re: [PATCH V2] Add support for flag status register on Micron chips.

2014-04-13 Thread Marek Vasut
also would avoid so many changes throughout the code. What do you think? [...] Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2] mtd: m25p80: Calculate flash block protect bits based on number of sectors

2014-04-13 Thread Marek Vasut
On Sunday, April 06, 2014 at 01:19:59 PM, Austin Boyle wrote: [...] > @@ -752,24 +773,18 @@ static int m25p80_lock(struct mtd_info *mtd, loff_t > ofs, uint64_t len) > > status_old = read_sr(flash); > > - if (offset < flash->mtd.size-(flash->mtd.size/2)) > - status_new = sta

Re: [PATCH V2] Add support for flag status register on Micron chips.

2014-04-14 Thread Marek Vasut
On Monday, April 14, 2014 at 06:19:24 PM, Graham Moore wrote: > On Sun, Apr 13, 2014 at 12:18 PM, Marek Vasut wrote: > [...] > > >> +#define OPCODE_RDFSR0x70 /* read flag status register > >> */ > > > > I know this is not your fault,

Re: [PATCH V2] Add support for flag status register on Micron chips.

2014-04-14 Thread Marek Vasut
is question here but it seemed relevant: > When such devices differ only in supply voltages (and return different > response to READ ID), > which we don't act on, is there a way to use the same string? No, they are different chips, so we must not use the same string. Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2] mtd: m25p80: Calculate flash block protect bits based on number of sectors

2014-04-16 Thread Marek Vasut
On Wednesday, April 16, 2014 at 02:26:41 PM, Austin Boyle wrote: > On Sun, 13 Apr 2014, Marek Vasut wrote: > > This portion of code looks like a duplicate of ... > > > > > + for (lock_bits = 1; lock_bits < 7; lock_bits++) { > > > + pr

Re: [PATCH v3 1/4] crypto: Add Allwinner Security System crypto accelerator

2014-06-22 Thread Marek Vasut
-- dear list, shall one use sg_page()+kmap or sg_virt()? btw. I just noticed you're just feeding the hardware FIFO in a loop with data in the scatterlists, do I understand it correctly ? The driver will consume quite a lot of CPU time to do that, can you not implement DMA here ? [...] Bes

Re: [PATCH v3 2/4] crypto: Update makefile and Kconfig for Security System

2014-06-22 Thread Marek Vasut
On Sunday, June 22, 2014 at 01:58:38 PM, Corentin LABBE wrote: > Le 14/06/2014 21:01, Marek Vasut a écrit : > > On Tuesday, June 10, 2014 at 02:43:15 PM, LABBE Corentin wrote: > >> Add necessary changes for configuring and compiling the Security System > >> driver. >

Re: [PATCH v3 1/4] crypto: Add Allwinner Security System crypto accelerator

2014-06-22 Thread Marek Vasut
On Sunday, June 22, 2014 at 02:33:35 PM, Russell King - ARM Linux wrote: > On Sun, Jun 22, 2014 at 02:23:15PM +0200, Marek Vasut wrote: > > On Sunday, June 22, 2014 at 01:58:08 PM, Corentin LABBE wrote: > > [...] > > > > > >> + * This program is free soft

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-12 Thread Marek Vasut
t; "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined! ERROR: > "devm_ioremap_resource" [drivers/input/serio/olpc_apsp.ko] undefined! > ERROR: "devm_ioremap_resource" [drivers/input/serio/arc_ps2.ko] undefined! This stuff should go through different trees, so I'

Re: [PATCH] drivers/staging/iio/adc/Kconfig: Let MXS_LRADC depend on HAS_IOMEM

2014-07-13 Thread Marek Vasut
dc/mxs-lradc.ko] > undefined! > > > Signed-off-by: Chen Gang Acked-by: Marek Vasut Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.or

Re: [PATCH v3 1/3] ima: use ahash API for file hash calculation

2014-07-09 Thread Marek Vasut
the USB cable out. Will this be able to cope with such situation, for example by switching to software operations or such in some sane way ? I presume that's the concern here. Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in t

Re: [PATCH v1 1/5] seq_file: provide an analogue of print_hex_dump()

2014-07-09 Thread Marek Vasut
On Wednesday, July 09, 2014 at 05:24:26 PM, Andy Shevchenko wrote: > The new seq_hex_dump() is a complete analogue of print_hex_dump(). > > We have few users of this functionality already. It allows to reduce their > codebase. > > Signed-off-by: Andy Shevchenko > --- > fs/seq_file.c

Re: [PATCH v3 1/3] ima: use ahash API for file hash calculation

2014-07-10 Thread Marek Vasut
On Thursday, July 10, 2014 at 01:05:39 AM, Dmitry Kasatkin wrote: > On 10 July 2014 00:00, Marek Vasut wrote: > > On Tuesday, July 08, 2014 at 10:07:16 AM, Dmitry Kasatkin wrote: > > [...] > > > >> > Right, but my concern is not about unloading the kernel module

Re: [PATCH v1 1/5] seq_file: provide an analogue of print_hex_dump()

2014-07-10 Thread Marek Vasut
On Wednesday, July 09, 2014 at 11:21:08 PM, Joe Perches wrote: > On Wed, 2014-07-09 at 22:39 +0200, Marek Vasut wrote: > > The above function looks like almost verbatim copy of print_hex_dump(). > > The only difference I can spot is that it's calling seq_printf() instead >

Re: [PATCH v3 1/3] ima: use ahash API for file hash calculation

2014-07-10 Thread Marek Vasut
> stops working mid-flight, will IMA also go bonkers or is there some > > graceful stop? > > shash fallback will be used. Ah, thank you for clearing this! Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message t

Re: [PATCH v8 0/4] arm: KGDB NMI/FIQ support

2014-07-15 Thread Marek Vasut
On Tuesday, July 15, 2014 at 11:41:25 AM, Daniel Thompson wrote: > On 14/07/14 14:51, Harro Haan wrote: > > On 10 July 2014 10:03, Daniel Thompson wrote: > >> This patchset makes it possible to use kgdb's NMI infrastructure on ARM > >> platforms. > >> > >> The patches have been previously circula

Re: [PATCH] video: fbdev: mxsfb.c: Cleaning up variable that is never used

2014-07-06 Thread Marek Vasut
ickard Strandqvist Makes perfect sense. Acked-by: Marek Vasut Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] mtd: m25p80: Calculate flash block protect bits based on number of sectors

2014-04-16 Thread Marek Vasut
structure so it can be used > in block protect bit calculation. > > From: Austin Boyle > Signed-off-by: Austin Boyle Acked-by: Marek Vasut Thanks! Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

Re: [PATCH 0/5] defconfigs: add MTD_SPI_NOR (dependency for M25P80)

2014-04-17 Thread Marek Vasut
ent cycle? Or some third option? Shouldn't the M25P80 driver just "select" the SPI NOR framework? Then you won't need the adjustment to defconfigs at all I think. Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in th

Re: [PATCH 1/5] ARM: defconfigs: add MTD_SPI_NOR (new dependency for M25P80)

2014-04-17 Thread Marek Vasut
MTD_CHAR symbol. > > Signed-off-by: Brian Norris > Cc: Russell King > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Stephen Warren > Cc: Thierry Reding > Cc: Olof Johansson > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- mxs_defc

Re: [PATCH] crypto: sha{256,512}_ssse3 - remove asmlinkage from static functions

2014-04-17 Thread Marek Vasut
only on public > objects [-Wattributes] static asmlinkage void > (*sha512_transform_asm)(const char *, u64 *, ^ > > Drop asmlinkage here to avoid such warnings. > > Also see Commit 8783dd3a37a5853689e1("irqchip: Remove asmlinkage from > static functions") > > Signe

Re: [PATCH 0/5] defconfigs: add MTD_SPI_NOR (dependency for M25P80)

2014-04-21 Thread Marek Vasut
ore they are asked about drivers which fall > under its category. > > Perhaps my usage of the word "library" in the description was a mistake, > as I don't exactly consider it like a library in the sense of many other > "select"ed libraries. It did look like

<    1   2   3   4   5   6   7   8   9   10   >