RE: [PATCH 2/3] pwm: ftm-pwm: Convert to direct regmap API usage.

> > drivers/pwm/pwm-fsl-ftm.c | 83 > > +-- > > 1 file changed, 44 insertions(+), 39 deletions(-) > > This could explain the advantages of converting to regmap. Looking at > this diffstat above, it's not immediately obvious that there's an > advantage

RE: [PATCH 1/3] pwm: ftm-pwm: Clean up the code.

> > Signed-off-by: Xiubo Li > > --- > > drivers/pwm/pwm-fsl-ftm.c | 13 ++--- > > 1 file changed, 6 insertions(+), 7 deletions(-) > > The patch description here could explain that this is in preparation for > the conversion to regmap (which I assume it is). > Please see the next versio

RE: [PATCH 3/3] pwm: ftm-pwm: Add big-endian support

> > Now for the following scenarios: > > > > SoC | CPU | FTM-PWM | 'big-endian' property is needed? > > -||-|- > > Vybird | LE| LE| No > > LS1 | LE| BE| Yes > > LS2 | LE

RE: [PATCH 0/3] FTM PWM adds regmap and endianness support.

> > Should I resend this patch series? If so, I will add some thing like the > > following: > > > > The FTM PWM driver will be used in our Vybrid, LS1 and LS2+ SoCs, and on > > Vybrid > > and LS2 SoCs, the FTM devices are in LE mode, while on LS1 SoCs it in BE > > mode. > > > > So this patch se

RE: [PATCHv2] ARM: ioremap: Fix static vm area boundary checking.

> Subject: Re: [PATCHv2] ARM: ioremap: Fix static vm area boundary checking. > > On Fri, May 16, 2014 at 1:28 AM, Nicolas Pitre > wrote: > > On Thu, 15 May 2014, Richard Lee wrote: > > > >> Static vm area boundary check: > >> > >> paddr1 --->| | > >> | | > >>

RE: [PATCHv3 3/3] clocksource: Add Freescale FlexTimer Module (FTM) timer support

> > +static void __iomem *clksrc_base; > > +static void __iomem *clkevt_base; > > +static unsigned long peroidic_cyc; > > peroidic_cyc ? Did you mean periodic_cyc ? :) > Yes, I'll fix it. Thanks, BRs Xiubo > > > -- > Linaro.org │ Open source software for ARM SoCs

RE: [PATCHv3 3/3] clocksource: Add Freescale FlexTimer Module (FTM) timer support

> Subject: Re: [PATCHv3 3/3] clocksource: Add Freescale FlexTimer Module (FTM) > timer support > > On 04/28/14 19:18, Xiubo Li wrote: > > +bool big_endian; > > + > > static? > I will fix this. Thanks, BRs Xiubo > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > host

RE: [PATCHv3 3/3] clocksource: Add Freescale FlexTimer Module (FTM) timer support

> > +#define FTM_CNTIN 0x4C > > + > > +static void __iomem *clksrc_base; > > +static void __iomem *clkevt_base; > > +static unsigned long peroidic_cyc; > > +static unsigned long ps; > > +bool big_endian; > > + > > Usually this is encaspulated in a structure. > > struct ftm_clock_device { >

RE: [PATCHv2 1/2] clocksource: fix type confusion for clocksource_mmio_readX_Y

Hi, I'd like to know the status about this patch series... :） Thanks, BRs Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Wednesday, April 23, 2014 10:12 AM > To: daniel.lezc...@linaro.org; t...@linutronix.de; linux- > ker...@vger.kernel.org > Cc: Xi

RE: [PATCH v3] arm: ioremap: Fix static vm area boundary check.

> > For each vmalloc area, there is one guard page at the end of it. > > so the vm->size = PAGE_ALIGN(offset + request size) + guard page size. > > Nope. There is no guard page for statically created vmalloc areas. > Yes, you are right, I'm thinking why the static area has no guard page? Thank

RE: [PATCHv4 2/2] regmap: add DT endianness binding support.

> Subject: Re: [PATCHv4 2/2] regmap: add DT endianness binding support. > > On Fri, May 09, 2014 at 03:04:33AM +0100, Xiubo Li wrote: > > For many drivers which will support rich endianness of CPU<-->Dev > > need define DT properties by itself without the binding support. > > > > The endianness us

RE: [PATCHv2 1/2] clocksource: fix type confusion for clocksource_mmio_readX_Y

> Subject: Re: [PATCHv2 1/2] clocksource: fix type confusion for > clocksource_mmio_readX_Y > > On 05/19/2014 04:35 AM, li.xi...@freescale.com wrote: > > Hi, > > > > I'd like to know the status about this patch series... > > :） > > I think the p

RE: [PATCHv3 3/3] clocksource: Add Freescale FlexTimer Module (FTM) timer support

> >>> +static inline u32 ftm_readl(void __iomem *addr) > >>> +{ > >>> + if (big_endian) > >> > >> I am not a big fan of addressing global variables in the functions, so > >> if you can pass the structure pointer around here and the other > >> functions instead that would be nice. > >> > >> Otherwis

RE: [PATCHv3 0/3] clocksource: Add Freescale FlexTimer Module (FTM) timer support

> > Xiubo Li (3): > >clocksource: ftm: Add FlexTimer Module (FTM) Timer devicetree > > Documentation > >ARM: dts: vf610: Add Freescale FlexTimer Module timer node. > >clocksource: Add Freescale FlexTimer Module (FTM) timer support > > > > .../devicetree/bindings/timer/fsl,ftm-tim

RE: [PATCH] regmap: irq: Fix possible ZERO_SIZE_PTR pointer dereferencing error.

> Subject: Re: [PATCH] regmap: irq: Fix possible ZERO_SIZE_PTR pointer > dereferencing error. > > On Mon, May 19, 2014 at 03:13:45PM +0800, Xiubo Li wrote: > > Since we cannot make sure the 'chip->num_regs' will always be none zero > > from the users, and then if 'chip->num_regs' equals to zero by

RE: [PATCHv2 1/3] dt/bindings: Add the DT binding documentation for endianness

> > diff --git a/Documentation/devicetree/bindings/endianness/endianness.txt > b/Documentation/devicetree/bindings/endianness/endianness.txt > > new file mode 100644 > > index 000..64f1d5e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/endianness/endianness.txt > > @@ -0,0 +1,55

RE: [PATCHv3 2/2] regmap: add DT endianness binding support.

> > + * of_regmap_endian_by_type() - Parse and lookup the endian referenced > > + * by a device node > > + * @np: pointer to clock consumer node > > This is not the clock consumer, right? > Yes, you are right. I will fix it. > > + * @type: type of consumer's endian input > > + * > > + * This

RE: [PATCHv3 0/2] add DT endianness binding support

> Subject: Re: [PATCHv3 0/2] add DT endianness binding support > > Shouldn't this go to the arm list and rmk for review, too? > Well, yes, I forgot it. Should I resend them ? Thanks, > Thanks, > Richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body o

RE: [PATCH] ASoC: cq93vc: fix cq93vc_get_regmap build error

> Subject: [PATCH] ASoC: cq93vc: fix cq93vc_get_regmap build error > > 49101a25acd69c "ASoC: cq93vc: Remove the set_cache_io() entirely from > ASoC probe" introduced the cq93vc_get_regmap function that has an > obvious build error referring to the 'codec' variable that is not > declared anywhere"

RE: [PATCHv2 0/4] FTM PWM adds regmap and endianness support.

Thierry, Ping:) > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Tuesday, April 29, 2014 11:34 AM > To: thierry.red...@gmail.com; linux-...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; Xiubo Li-B47053 > Subject: [PATCHv2 0/4] FTM PWM adds regmap and e

RE: [PATCH] ARM: ioremap: Fix static vm area boundary checking.

> Subject: [PATCH] ARM: ioremap: Fix static vm area boundary checking. > > Static vm area boundary check: > > paddr1 --->| | > | | > |---| <-\--- svm->vm->addr(is page aligned) > paddr2 --->| || > | --| <

RE: [PATCH 0/3] FTM PWM adds regmap and endianness support.

Therry, Ping :) > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Friday, March 21, 2014 12:53 PM > To: thierry.red...@gmail.com; linux-...@vger.kernel.org > Cc: broo...@kernel.org; swar...@nvidia.com; linux-kernel@vger.kernel.org; > Xiubo Li-B47053 > Subject

RE: [PATCH v4] ASoC: fsl_sai: Add clock controls for SAI

> Subject: [PATCH v4] ASoC: fsl_sai: Add clock controls for SAI > > The SAI mainly has the following clocks: > bus clock > control and configure registers and to generate synchronous > interrupts and DMA requests. > > mclk1, mclk2, mclk3 > to generate the bit clock when the recei

RE: [PATCH 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node

> Subject: Re: [PATCH 2/3] ARM: dts: vf610-twr: Add PWM0's pinctrl node > > On Thu, Mar 20, 2014 at 01:12:04PM +0800, Xiubo Li wrote: > > Signed-off-by: Xiubo Li > > Patch #2 and #3 can be reasonably merged into one. > Yes, they are. But the Patch #2 is a new one, not reviewed by Sascha Haue

RE: [PATCH 1/3] ARM: dts: vf610: Add Freescale FTM PWM node.

> Subject: Re: [PATCH 1/3] ARM: dts: vf610: Add Freescale FTM PWM node. > > On Thu, Mar 20, 2014 at 01:12:03PM +0800, Xiubo Li wrote: > > This adds devicetree node for VF610, and there are 8 channels > > supported. > > > > Signed-off-by: Xiubo Li > > Reviewed-by: Sascha Hauer > > Reviewed-by: Y

RE: [PATCHv2 2/2] of: fix of_update_property()

> Subject: Re: [PATCHv2 2/2] of: fix of_update_property() > > On Wed, 22 Jan 2014 13:57:40 +0800, Xiubo Li wrote: > > The of_update_property() is intented to update a property in a node > > and if the property does not exist, will add it. > > > > The second search of the property is possibly won'

RE: [PATCH 2/2] watchdog: imx2_wdt: Add big-endian support

> Subject: Re: [PATCH 2/2] watchdog: imx2_wdt: Add big-endian support > > On 03/25/2014 02:35 AM, Xiubo Li wrote: > > Signed-off-by: Xiubo Li > > --- > > There is no explanation for this patch in the headline. > > Ultimately there are four cases > CPU HW > little little This c

RE: [PATCH] ASoC: fsl_sai: Add isr to deal with error flag

> + regmap_read(sai->regmap, FSL_SAI_TCSR, &xcsr); > + regmap_write(sai->regmap, FSL_SAI_TCSR, xcsr); > + > + if (xcsr & FSL_SAI_CSR_WSF) > + dev_dbg(dev, "isr: Start of Tx word detected\n"); > + > + if (xcsr & FSL_SAI_CSR_SEF) > + dev_dbg(dev, "isr: Tx Frame

RE: [PATCH] ASoC: fsl_sai: Add isr to deal with error flag

> On Thu, Mar 27, 2014 at 10:13:48AM +0800, Xiubo Li-B47053 wrote: > > > + regmap_read(sai->regmap, FSL_SAI_TCSR, &xcsr); > > > + regmap_write(sai->regmap, FSL_SAI_TCSR, xcsr); > > > + > > > + if (xcsr & FSL_SAI_CSR_WSF) > > > + dev_dbg(dev, "isr: Start of Tx word detected\n"); > > > + > >

RE: [PATCH] ASoC: fsl_sai: Add isr to deal with error flag

> Subject: Re: [PATCH] ASoC: fsl_sai: Add isr to deal with error flag > > On Thu, Mar 27, 2014 at 10:53:50AM +0800, Xiubo Li-B47053 wrote: > > > On Thu, Mar 27, 2014 at 10:13:48AM +0800, Xiubo Li-B47053 wrote: > > > > > + regmap_read(sai->regmap, FSL_SAI_TCSR, &xcsr); > > > > > + regmap_w

RE: [PATCH] ASoC: fsl_sai: Add isr to deal with error flag

> > > > > > > + if (xcsr & FSL_SAI_CSR_FWF) > > > > > > > + dev_dbg(dev, "isr: Enabled transmit FIFO is empty\n"); > > > > > > > + > > > > > > > + if (xcsr & FSL_SAI_CSR_FRF) > > > > > > > + dev_dbg(dev, "isr: Transmit FIFO watermark has been > > > reached\n"); > > > > > > > + > > >

RE: [PATCH] ASoC: fsl_sai: Add isr to deal with error flag

> > So let's just ignore the clearance of these bits in isr(). > > > > + > > SAI Transmit Control Register (I2S1_TCSR) : 32 : R/W : _h > > I'm talking about FWF and FRF bits, not TCSR as a register. > > > - > > > > I have checked in the Vybrid and LS1 SoC datasheets, and they are

RE: [PATCH] clocksource: vf_pit_timer: fix pit_read_sched_clock

> > diff --git a/drivers/clocksource/vf_pit_timer.c > b/drivers/clocksource/vf_pit_timer.c > > index 02821b0..a918bc4 100644 > > --- a/drivers/clocksource/vf_pit_timer.c > > +++ b/drivers/clocksource/vf_pit_timer.c > > @@ -54,7 +54,7 @@ static inline void pit_irq_acknowledge(void) > > > > static

RE: [PATCH] clocksource: vf_pit_timer: fix pit_read_sched_clock

> > > > thanks for the patch but this has already been fixed [1] and is available in > > the timers/urgent branch. > > It's in Linus tree already and tagged for stable. > Yes, I have found it, I was developing this in the old tree... :) Thanks, BRs Xiubo -- To unsubscribe from this list: send

RE: [RFC][PATCH 3/3] clocksource: Add Freescale FlexTimer Module (FTM) timer support

[...] > > +static void ftm_set_mode(enum clock_event_mode mode, > > + struct clock_event_device *evt) > > +{ > > + switch (mode) { > > + case CLOCK_EVT_MODE_PERIODIC: > > + ftm_set_next_event(peroidic_cyc, evt); > > + break; > > + default: > > +

RE: [RFC][PATCH 1/3] ARM: dts: vf610: Add Freescale FlexTimer Module timer node.

> > --- a/arch/arm/boot/dts/vf610.dtsi > > +++ b/arch/arm/boot/dts/vf610.dtsi > > @@ -153,6 +153,19 @@ > > clock-names = "pit"; > > }; > > > > + ftm0: ftm@40038000 { > > + compatible = "fsl,vf610-ftm-timer";

RE: [RFC][PATCH 1/3] ARM: dts: vf610: Add Freescale FlexTimer Module timer node.

> Subject: Re: [RFC][PATCH 1/3] ARM: dts: vf610: Add Freescale FlexTimer Module > timer node. > > On 04/16/2014 04:19 AM, Xiubo Li wrote: > > Signed-off-by: Xiubo Li > > Cc: Shawn Guo > > Cc: Jingchang Lu > > That deserves a patch description and an update of the documentation. > Yes, I'll ad

RE: [RFC][PATCH 1/3] ARM: dts: vf610: Add Freescale FlexTimer Module timer node.

> Subject: Re: [RFC][PATCH 1/3] ARM: dts: vf610: Add Freescale FlexTimer Module > timer node. > > On Wed, Apr 16, 2014 at 10:19:45AM +0800, Xiubo Li wrote: > > Signed-off-by: Xiubo Li > > Cc: Shawn Guo > > Cc: Jingchang Lu > > --- > > arch/arm/boot/dts/vf610.dtsi | 13 + > > 1 fil

RE: [PATCHv5 2/2] dt/bindings: Add the DT binding documentation for endianness

Hi, Please ignore this V5 patch series. Thanks, BRs > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Tuesday, July 15, 2014 12:18 PM > To: broo...@kernel.org; mark.rutl...@arm.com > Cc: robh...@kernel.org; pawel.m...@arm.com; ijc+devicet...@hellion.org.uk

RE: [PATCHv6 2/2] dt/bindings: Add the DT binding documentation for endianness

> > +For one device driver, which will run in different scenarios above > > +on different SoCs using the devicetree, we need one way to simplify > > +this. > > + > > +Required properties: > > +- {big,little}-endian: these are boolean properties, if absent > > + meaning that the CPU and the Device

RE: [RFC][PATCH 1/3] ARM: dts: vf610: Add Freescale FlexTimer Module timer node.

> > + ftm0: ftm@40038000 { > > + compatible = "fsl,vf610-ftm-timer"; > > + reg = <0x40038000 0x2000>; > > + interrupts = <0 42 IRQ_TYPE_LEVEL_HIGH>; > > + clock-names = "ftm0",

RE: [RFC][PATCH 1/3] ARM: dts: vf610: Add Freescale FlexTimer Module timer node.

> Subject: Re: [RFC][PATCH 1/3] ARM: dts: vf610: Add Freescale FlexTimer Module > timer node. > > On Thu, Apr 17, 2014 at 07:49:31AM +0000, li.xi...@freescale.com wrote: > > > > + ftm0: ftm@40038000 { > > > > +

RE: [RFC][PATCH 3/3] clocksource: Add Freescale FlexTimer Module (FTM) timer support

> > Here using the FTM0 as clock event device and the FTM1 as clock > > source device. > > As it is a new driver, please add a more elaborated description of the > timer. > Please see the next version. > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include >

RE: [RFC][PATCH 3/3] clocksource: Add Freescale FlexTimer Module (FTM) timer support

> > + freq = clk_get_rate(ftm_clk); > > + > > + calc_closest_cound_cyc(freq); > > + > > + BUG_ON(ftm_clocksource_init(freq)); > > + > > + BUG_ON(ftm_clockevent_init(freq, irq)); > > +} > > +CLOCKSOURCE_OF_DECLARE(vf610, "fsl,vf610-ftm-timer", ftm_timer_init); > > > I am not a big fan of t

RE: [PATCH 0/3] clocksource: Add Freescale FlexTimer Module (FTM) timer support

@All, Please ignore this patch series, I just forgot the V2 tag, I have resent a New one. Thanks, BRs Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Monday, April 21, 2014 3:20 PM > To: daniel.lezc...@linaro.org; t...@linutronix.de; shawn@linar

RE: [PATCH] clocksource: arch_arm_timer: Fix timecounter initialization

> > drivers/clocksource/arm_arch_timer.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/clocksource/arm_arch_timer.c > b/drivers/clocksource/arm_arch_timer.c > > index 5163ec1..6c3cfd8 100644 > > --- a/drivers/clocksource/arm_arch_timer.c > > +++ b/driv

FW: [PATCHv2 1/2] watchdog: imx2_wdt: Sort the header files alphabetically

Forward to Shawn, Thanks, > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Wednesday, March 26, 2014 10:22 AM > To: w...@iguana.be; w.s...@pengutronix.de; linux-watch...@vger.kernel.org; > li...@roeck-us.net > Cc: linux-kernel@vger.kernel.org; Xiubo Li-B4705

FW: [PATCHv2 2/2] watchdog: imx2_wdt: Add big-endian support

Forward to Shawn, Thanks, > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Wednesday, March 26, 2014 10:22 AM > To: w...@iguana.be; w.s...@pengutronix.de; linux-watch...@vger.kernel.org; > li...@roeck-us.net > Cc: linux-kernel@vger.kernel.org; Xiubo Li-B4705

FW: [PATCHv2 0/2] Add big endian support

Forward to Shawn. Thanks, > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Wednesday, March 26, 2014 10:22 AM > To: w...@iguana.be; w.s...@pengutronix.de; linux-watch...@vger.kernel.org; > li...@roeck-us.net > Cc: linux-kernel@vger.kernel.org; Xiubo Li-B47053

RE: [PATCH] regmap: Add REGMAP_ENDIAN_SWAP support for values.

> Subject: Re: [PATCH] regmap: Add REGMAP_ENDIAN_SWAP support for values. > > On Thu, Mar 27, 2014 at 04:17:39PM +0800, Xiubo Li wrote: > > > And using the REGMAP_ENDIAN_BIG and REGMAP_ENDIAN_LITTLE will make > > the driver a bit more complex, and also the usage of it. > > What's the complexity

RE: [PATCH] regmap: Add REGMAP_ENDIAN_SWAP support for values.

> Subject: Re: [PATCH] regmap: Add REGMAP_ENDIAN_SWAP support for values. > > On Thu, Mar 27, 2014 at 04:17:39PM +0800, Xiubo Li wrote: > > > For the DT node, just one property like 'endian-swap' will be okey > > for cases 2 and 4. > > I'm not convinced that the cost of having to define explicit

RE: [PATCHv2 2/2] watchdog: imx2_wdt: Add big-endian support

> Subject: Re: [PATCHv2 2/2] watchdog: imx2_wdt: Add big-endian support > > On 03/25/2014 07:21 PM, Xiubo Li wrote: > > For the platforms that this IP driver now supports: > > SoCCPUWatchdog Need 'big-endian'? > > -- > > Vyb

RE: [PATCH] ASoC: fsl_sai: Fix buggy configurations in trigger()

> Subject: [PATCH] ASoC: fsl_sai: Fix buggy configurations in trigger() > > The current trigger() has two crucial problems: > 1) The DMA request enabling operations (FSL_SAI_CSR_FRDE) for Tx and Rx are >now totally exclusive: It would fail to run simultaneous Tx-Rx cases. > 2) The TERE disabli

RE: [PATCHv2 2/2] watchdog: imx2_wdt: Add big-endian support

> > It's actually the following ones first, which will support 16-bits > > Values for regmap-mmio: > > > > https://patchwork.kernel.org/patch/3896321/ > > https://patchwork.kernel.org/patch/3896331/ > > https://patchwork.kernel.org/patch/3901021/ > > > > And the then the following one, which will s

RE: linux-next: manual merge of the clockevents tree with the arm-soc tree

> Subject: linux-next: manual merge of the clockevents tree with the arm-soc > tree > > Hi Daniel, > > Today's linux-next merge of the clockevents tree got a conflict in > arch/arm/boot/dts/vf610.dtsi between commit 0517fe6aa880 ("ARM: dts: > vf610-twr: Add support for sdhc1") from the arm-soc tr

RE: [PATCHv5 0/2] imx2-wdt: Add regmap-mmio support

> > Xiubo Li (2): > > watchdog: imx2_wdt: Sort the header files alphabetically > > watchdog: imx2_wdt: convert to use regmap API. > > > > drivers/watchdog/Kconfig| 1 + > > drivers/watchdog/imx2_wdt.c | 62 +++--- > --- > > 2 files changed, 39 insertio

RE: [PATCH] watchdog: imx2_wdt: adds big endianness support.

> > @@ -201,6 +204,10 @@ static int __init imx2_wdt_probe(struct platform_device > *pdev) > > if (!wdev) > > return -ENOMEM; > > > > + big_endian = of_property_read_bool(np, "big-endian"); > > + if (big_endian) > > + imx2_wdt_regmap_config.val_format_endian = REGMAP_EN

RE: [PATCH v2 5/7] ASoC: add snd_soc_of_parse_audio_simple_widgets for DT

> > The "template-wname" includes: "Mic", "Line", "Hp", "Spk"... > > Sorry, this is nitpicking but can we have "HP" or even "Headphone" > instead of "Hp" - otherwise it looks like a typo and people might > correct it. Similarly "Speaker" might be better as "Spk". Yes, I will use them. Please s

RE: [PATCHv7 1/4] pwm: Add Freescale FTM PWM driver support

> On Tue, Dec 17, 2013 at 01:00:10PM +0100, Tomasz Figa wrote: > > On Tuesday 17 of December 2013 11:51:36 Russell King - ARM Linux wrote: > > > On Tue, Dec 17, 2013 at 12:10:22PM +0100, Thierry Reding wrote: > > > > On Fri, Dec 13, 2013 at 04:57:04PM +0800, Xiubo Li wrote: > > > > > +static inlin

RE: [PATCHv7 1/4] pwm: Add Freescale FTM PWM driver support

> On Tue, Dec 17, 2013 at 01:54:35PM +0100, Tomasz Figa wrote: > > On Tuesday 17 of December 2013 13:45:06 Thierry Reding wrote: > > > I fail to see how that would eliminate the problem with the types. > > > That said I don't actually see sparse complaining about any type > mismatches. > > > That'

RE: [PATCHv4 2/4] ARM: dts: Add Freescale SAI ALSA SoC Digital Audio Interface node for VF610.

> Subject: Re: [PATCHv4 2/4] ARM: dts: Add Freescale SAI ALSA SoC Digital Audio > Interface node for VF610. > > On Fri, Dec 20, 2013 at 09:03:05AM +0800, Xiubo Li wrote: > > This patch adds the SAI's edma mux Tx and Rx support. > > DTS changes should be merged via arm-soc. Okey, Got it. Thanks

RE: [PATCHv4 2/4] ARM: dts: Add Freescale SAI ALSA SoC Digital Audio Interface node for VF610.

Hi, Could someone help review and merge this DTS patch please ? Thanks very much! Best Regards, Xiubo > Subject: [PATCHv4 2/4] ARM: dts: Add Freescale SAI ALSA SoC Digital Audio > Interface node for VF610. > > This patch adds the SAI's edma mux Tx and Rx support. > > Signed-off-by: Xiub

RE: [PATCHv4 3/4] ARM: dts: Enable SAI ALSA SoC DAI device for Vybrid VF610 TOWER board.

Hi, Could someone help review and merge this DTS patch please ? Thanks very much! Best Regards, Xiubo > Subject: [PATCHv4 3/4] ARM: dts: Enable SAI ALSA SoC DAI device for Vybrid > VF610 TOWER board. > > This patch adds and enables the SAI device. > > Signed-off-by: Xiubo Li > --- > a

RE: [PATCH v2 7/7] ASoC: binding: for new properties documenting and usage

> > This add the following three new properties documenting and usage > > for simple card: > > > > "simple-audio-card,name", > > "simple-audio-card,widgets", > > "simple-audio-card,tdm-slot". > > name and widgets are basically fine modulo the comment about "Hp". > tdm-slot needs furthe

RE: [PATCHv9 1/4] pwm: Add Freescale FTM PWM driver support

Hi, I'd like to know the status of this patch series ? Thanks very much. -- Best Regards, Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Tuesday, January 07, 2014 4:09 PM > To: thierry.red...@gmail.com; linux-...@vger.kernel.org > Cc: linux-kernel@

RE: [PATCH 1/8] ASoC: fsl: Add VF610 soc audio card Kconfig

> Subject: Re: [PATCH 1/8] ASoC: fsl: Add VF610 soc audio card Kconfig > > On Sun, Jan 26, 2014 at 05:15:05AM +0000, li.xi...@freescale.com wrote: > > > > ...for simple card since the whole idea is to support any CODEC with the > > > same driver we should probab

RE: [PATCH] ASoC: fsl-esai: fix ESAI TDM slot setting

> > diff --git a/sound/soc/fsl/fsl_esai.h b/sound/soc/fsl/fsl_esai.h > > index 9c9f957..75e1403 100644 > > --- a/sound/soc/fsl/fsl_esai.h > > +++ b/sound/soc/fsl/fsl_esai.h > > @@ -322,7 +322,7 @@ > > #define ESAI_xSMB_xS_SHIFT 0 > > #define ESAI_xSMB_xS_WIDTH 16 > > #define ESAI_xSMB_xS_MASK

RE: [PATCH] ASoC: fsl-esai: fix ESAI TDM slot setting

Sorry, my misunderstanding about your comment. Please ignore the last mail. I will send v2 of this patch. Thanks very much. > > > diff --git a/sound/soc/fsl/fsl_esai.h b/sound/soc/fsl/fsl_esai.h > > > index 9c9f957..75e1403 100644 > > > --- a/sound/soc/fsl/fsl_esai.h > > > +++ b/sound/soc/fsl/f

RE: [PATCH] ASoC: simple-card: cleanup asoc_simple_card_parse_of() code

Hi Mark and all, Merry Christmas. > Subject: Re: [PATCH] ASoC: simple-card: cleanup asoc_simple_card_parse_of() > code > > On Fri, Dec 27, 2013 at 11:14:38AM +0800, Xiubo Li wrote: > > Since there is only one common format via "simple-audio-card,format" > > for simple card driver(CPU & CODEC DA

RE: [PATCH] ASoC: simple-card: cleanup asoc_simple_card_parse_of() code

Hi Mark, > - > .. > > /* get CPU/CODEC common format via simple-audio-card,format */ > info->daifmt = snd_soc_of_parse_daifmt(node, "simple-audio-card,") & > (SND_SOC_DAIFMT_FORMAT_MASK | SND_SOC_DAIFMT_INV_MASK); > > .. > >

RE: [PATCH] ASoC: simple-card: cleanup asoc_simple_card_parse_of() code

> Subject: Re: [PATCH] ASoC: simple-card: cleanup asoc_simple_card_parse_of() > code > > On Fri, Dec 27, 2013 at 11:14:38AM +0800, Xiubo Li wrote: > > Since there is only one common format via "simple-audio-card,format" > > for simple card driver(CPU & CODEC DAI), there is no need to do the > > I

RE: [PATCH] ASoC: fsl_sai: Fix one bug for hardware limitation.

Hi Mark, > Subject: Re: [PATCH] ASoC: fsl_sai: Fix one bug for hardware limitation. > > On Thu, Dec 26, 2013 at 10:57:22AM +0800, Xiubo Li wrote: > > This is maybe one bug or a limitation of the hardware that the {T,R}CR2's > > Synchronous Mode bits must be set as late as possible, or the SAI dev

RE: [alsa-devel] [PATCH] ASoC: simple-card: Add device's module clock selection.

> Subject: Re: [alsa-devel] [PATCH] ASoC: simple-card: Add device's module clock > selection. > > On 12/23/2013 08:25 AM, Xiubo Li wrote: > > diff --git a/a.out b/a.out > > new file mode 100644 > > index 000..e69de29 > > This patch did add a empty a.out file in the toplevel folder. > > - La

RE: [alsa-devel] [PATCH] ASoC: simple-card: Add device's module clock selection.

Hi Mark, Lars > Subject: Re: [alsa-devel] [PATCH] ASoC: simple-card: Add device's module clock > selection. > > On Wed, Jan 01, 2014 at 01:11:09PM +0100, Lars-Peter Clausen wrote: > > On 12/23/2013 08:25 AM, Xiubo Li wrote: > > > diff --git a/a.out b/a.out > > > new file mode 100644 > > > index

RE: [PATCH] ASoC: add snd_soc_of_parse_master_clkdir() for dt

> Subject: Re: [PATCH] ASoC: add snd_soc_of_parse_master_clkdir() for dt > > On Tue, Dec 31, 2013 at 04:10:44PM +0800, Xiubo Li wrote: > > > I'm not very sure whether this patch is need for dt. > > It's not clear to me - it's not adding much on top of just passing the > full property string to

RE: [PATCH] ASoC: simple-card: Add DAPM routes parse from device tree

> Subject: Re: [PATCH] ASoC: simple-card: Add DAPM routes parse from device tree > > On Mon, Dec 23, 2013 at 12:57:01PM +0800, Xiubo Li wrote: > > Parses a simple DAPM route table from device tree. > > I've applied this on the basis that it's using a generic feature and > won't do any harm but g

RE: [PATCH] ASoC: simple-card: cleanup asoc_simple_card_parse_of() code

> Subject: Re: [PATCH] ASoC: simple-card: cleanup asoc_simple_card_parse_of() > code > > On Tue, Dec 31, 2013 at 03:27:53AM +0000, li.xi...@freescale.com wrote: > > > Also, for most of the devices of the same DAI link, they use the same DAI > > formats, but I h

RE: [PATCHv8 RFC] pwm: Add Freescale FTM PWM driver support

Hi Dmitry, > Subject: Re: [PATCHv8 RFC] pwm: Add Freescale FTM PWM driver support > > Hi Xiubo, > > On Fri, Jan 03, 2014 at 01:24:21PM +0800, Xiubo Li wrote: > > + > > +static inline int fsl_pwm_calculate_default_ps(struct fsl_pwm_chip *fpc, > > + enum fs

RE: [PATCHv8 1/4] pwm: Add Freescale FTM PWM driver support

Hi Arnd, > Subject: Re: [PATCHv8 1/4] pwm: Add Freescale FTM PWM driver support > > On Thursday 02 January 2014 17:57:01 Xiubo Li wrote: > > +static inline u32 ftm_readl(bool big_endian, const void __iomem *addr) > > +{ > > + u32 val; > > + > > + val = __raw_readl(addr); > > + > > +

RE: [PATCHv8 RFC] pwm: Add Freescale FTM PWM driver support

> > > > +static inline int fsl_pwm_calculate_default_ps(struct fsl_pwm_chip > > > > *fpc, > > > > + enum fsl_pwm_clk index) > > > > +{ > > > > > > Why do you declare this (and other module-local) function as inline? > > > It is usually better let compil

RE: [PATCH v2] ASoC: soc-core: add snd_soc_of_parse_master_clkdir() for dt

Hi I would like to know the current status of this patch, and there are some other patches that for simple-card are depended on this one. Thanks, -- > This patch adds snd_soc_of_parse_master_clkdir() and supports below > style on dt: > > master-clkdir-out; > > If this property is absent 0 wil

RE: [PATCHv8 1/4] pwm: Add Freescale FTM PWM driver support

Hi Arnd, > > Adding Greg here to make sure we have a common understanding in the future. > > ioread*() was indeed introduced for devices that can be both I/O and memory > space, and is a bit slowed than readl() on architectures that don't have > memory mapped I/O space (i.e. x86). > > However,

RE: [PATCH] ASoC: simple-card: fix the DAPM routes map parsing

> > The simple-card's DAPM route maping is optional. For example, the spdif has > > no need of this. > > This doesn't seem to apply against current code, can you please check > and resend? > Yes, I will. Thanks, -- Best Regards, Xiubo-- To unsubscribe from this list: send the line "unsubscribe

RE: [PATCH] pwm: core: Use devm_kzalloc instead of kzalloc

> > Use devm_kzalloc instead of kzalloc to free automatically and make > > the cleanup paths simpler and the code slightly shorter. > [] > > diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c > [] > > @@ -245,7 +244,9 @@ int pwmchip_add(struct pwm_chip *chip) > > if (ret < 0) > >

RE: [PATCHv4 2/4] ARM: dts: Add Freescale SAI ALSA SoC Digital Audio Interface node for VF610.

Hi Shawn, > > diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi > > index e84d84c..2d6ddd0 100644 > > --- a/arch/arm/boot/dts/vf610.dtsi > > +++ b/arch/arm/boot/dts/vf610.dtsi > > @@ -166,6 +166,9 @@ > > interrupts = <0 86 0x04>; > >

RE: [PATCHv3] ASoC: fsl-sai: rename big_endian_data to is_lsb_first.

Hi all, Please ignore this patch. Have sent the wrong one. Thanks, BRs Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Monday, August 25, 2014 3:03 PM > To: broo...@kernel.org; nicoleots...@gmail.com; ti...@tabi.org; > lgirdw...@gmail.com; pe...@pe

RE: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

> -Original Message- > From: Mark Rutland [mailto:mark.rutl...@arm.com] > Sent: Tuesday, August 26, 2014 5:04 PM > To: Xiubo Li-B47053 > Cc: broo...@kernel.org; nicoleots...@gmail.com; ti...@tabi.org; > lgirdw...@gmail.com; pe...@perex.cz; ti...@suse.de; alsa-devel@alsa- > project.org;

RE: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

> Subject: Re: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of > 'big-endian-data'. > > On Tue, Aug 26, 2014 at 7:12 PM, li.xi...@freescale.com > wrote: > > > > This property used for configuring whether the LSB or the MSB i

RE: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of 'big-endian-data'.

> Subject: Re: [PATCH] ASoC: fsl-sai: using 'lsb-first' property instead of > 'big-endian-data'. > > On Tue, Aug 26, 2014 at 11:53:56PM -0700, Nicolin Chen wrote: > > > That's why I suggested previously: mention it in the commit comment. > > > People will have no idea about what's the exact reas

RE: [PATCHv2] watchdog: imx2_wdt: Convert to use regmap framework's endianness method.

vger.kernel.org; > linux- > ker...@vger.kernel.org; devicet...@vger.kernel.org > Subject: Re: [PATCHv2] watchdog: imx2_wdt: Convert to use regmap framework's > endianness method. > > On Fri, Sep 05, 2014 at 07:11:31AM +, li.xi...@freescale.com wrote: > > Hi, > &

RE: [PATCHv2 1/4] Clocksource: Flextimer: Use internal clocksource read API.

Hi Thomas, Okay. I will try to fix this. Thanks, BRs Xiubo > -Original Message- > From: Thomas Gleixner [mailto:t...@linutronix.de] > Sent: Friday, September 05, 2014 11:40 PM > To: Xiubo Li-B47053 > Cc: daniel.lezc...@linaro.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCHv2

RE: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module

Hi, > Subject: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module > > Move the ipg clock enable and disable operation to startup and shutdown, > that is only enable ipg clock when ssi is working. we don't need to enable > ipg clock in probe. > Another register accessing need the ipg

RE: [PATCHv3 2/3] ASoC: simple-card: Adjust the comments of simple card.

> Subject: Re: [PATCHv3 2/3] ASoC: simple-card: Adjust the comments of simple > card. > > On Wed, Sep 03, 2014 at 10:23:40AM +0800, Xiubo Li wrote: > > Signed-off-by: Xiubo Li > > This doesn't apply against current code. I will send one new version about this. Thanks, BRs Xiubo -- To unsubscri

RE: [PATCHv3 3/3] ASoC: simple-card: binding: update binding to support the new style.

Hi, > Subject: Re: [PATCHv3 3/3] ASoC: simple-card: binding: update binding to > support the new style. > > On 09/09/2014 03:09 PM, Mark Brown wrote: > > On Wed, Sep 03, 2014 at 10:23:41AM +0800, Xiubo Li wrote: > >> This update patch will split the DT node into old style and new style: > >> The

RE: [PATCH] regmap: fix of_regmap_get_endian()

Hi, I found this patch has some confliction with the Mark's newest Remgap-Tree's origin/topic/dt-endian branch. Javier Martinez has already fix some of these. Thanks, BRs Xiubo > -Original Message- > From: Thierry Reding [mailto:thierry.red...@gmail.com] > Sent: Tuesday, August 19, 2

RE: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA

> Subject: Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence > of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA > > On Mon, Aug 18, 2014 at 06:52:46PM +0200, Lars-Peter Clausen wrote: > > On 08/18/2014 10:38 AM, Shengjiu Wang wrote: > > >Build kernel with SND_SOC_IMC_PCM_DMA=m && SND_IMX

RE: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA

> > > Lars-Peter Clausen & Arnd > > > > > > The purpose of Arnd's patch is same with me, which is to resolve the build > > > error when SND_SOC_IMX_PCM_DMA=m & SND_SOC_FSL_SSI/SAI/ESAI/SPDIF=y, the > > > error is "undefined reference to `imx_pcm_dma_init'". > > > But Arnd's patch didn't involve thi

RE: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA

How about the following : diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index 5ae777a..d42f18c 100644 --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -15,7 +15,7 @@ config SND_SOC_FSL_ASRC config SND_SOC_FSL_SAI tristate "Synchronous Audio Interface (SAI) module s

RE: [PATCHv6 2/2] dt/bindings: Add the DT binding documentation for endianness

> Subject: Re: [PATCHv6 2/2] dt/bindings: Add the DT binding documentation for > endianness > > On Tue, Jul 15, 2014 at 12:23:03PM +0800, Xiubo Li wrote: > > Device-Tree binding for device endianness > > Index Device Endianness properties > > ---

RE: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read API.

> Subject: Re: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read > API. > > On Tue, 26 Aug 2014, Xiubo Li wrote: > > > Since the Flextimer device will be implemented in BE mode on > > LS1 SoC, and in LE mode on Vybrid, LS2 SoCs, so here we need > > the endianness judgment before d

<    1   2   3   >