and group pinmux-i2c1-pins:
>
> echo "pinmux-i2c1 pinmux-i2c1-pins" > pinmux-select
Thanks, looks almost good to me (few nit-picks below)
Reviewed-by: Andy Shevchenko
> Signed-off-by: Drew Fustini
> ---
> drivers/pinctrl/pinmux.c | 102
efirmware.org/
> - F:arch/x86/platform/sfi/
> - F:drivers/sfi/
> - F: include/linux/sfi*.h
> -
> SIMPLEFB FB DRIVER
> M:Hans de Goede
> L:linux-fb...@vger.kernel.org
--
With Best Regards,
Andy Shevchenko
On Tue, Feb 16, 2021 at 6:37 PM Bedel, Alban wrote:
> On Mon, 2021-02-15 at 14:53 +0200, Andy Shevchenko wrote:
> > Hint: don't forget to include reviewers from previous version
>
> I added you to the CC list for the new patch, did I miss someone else?
Then we are fine, thanks!
On Tue, Feb 16, 2021 at 7:05 PM Jonathan Corbet wrote:
>
> Andy Shevchenko writes:
>
> > On Tue, Feb 16, 2021 at 6:51 PM Jonathan Corbet wrote:
> >>
> >> > Mauro, can you do some test cases in your workflow against anonymous
> >> > enum in ernel
anged to
> say that; meanwhile, perhaps this one could be fixed with an action like
> s%/**%/*% ?
See above. I think regression comes from the kernel doc script,
earlier it was okay. That said, the author of kernel doc changes has
to submit a patch to amend the driver and maintainers will review it.
--
With Best Regards,
Andy Shevchenko
t; +#define GNA_STS_PCI_MMU_ERR(1 << 4)
> +#define GNA_STS_PCI_DMA_ERR(1 << 5)
> +#define GNA_STS_PCI_UNEXCOMPL_ERR (1 << 6)
> +#define GNA_STS_VA_OOR (1 << 7)
> +#define GNA_STS_PARAM_OOR (1 << 8)
> +#define GNA_STS_OUTBUF_FULL(1 << 16)
> +#define GNA_STS_SATURATE (1 << 17)
You can use _BITUL() from const.h, but it's up to you.
...
> +#define GNA_ERROR (GNA_STS_PCI_DMA_ERR | \
When definitions start on the next line it will be easier to read.
> + GNA_STS_PCI_MMU_ERR | \
> + GNA_STS_PCI_UNEXCOMPL_ERR | \
> + GNA_STS_PARAM_OOR | \
> + GNA_STS_VA_OOR)
--
With Best Regards,
Andy Shevchenko
Switch to the new style i2c-driver probe_new probe function.
Note we do not have any old style board files using this but
user still has a possibility to instantiate device from sysfs.
Signed-off-by: Andy Shevchenko
---
drivers/leds/leds-lp50xx.c | 33 -
1 file
The priv->dev is effectively the same as >client->dev.
So, drop the latter for the former.
Signed-off-by: Andy Shevchenko
---
drivers/leds/leds-lp50xx.c | 26 --
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git a/drivers/leds/leds-lp50xx.c b/dri
When requesting GPIO line the probe can be deferred.
In such case don't spam logs with an error message.
This can be achieved by switching to dev_err_probe().
Signed-off-by: Andy Shevchenko
---
drivers/leds/leds-lp50xx.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git
In the line like
u32 bar = ...;
u8 foo = (u8)(bar >> 8) & 0xff;
is no need to have neither explicit casting nor ' & 0xff' part.
Get rid of them.
Signed-off-by: Andy Shevchenko
---
drivers/leds/leds-lp50xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(
The OF is not used in the driver, thus the OF headers are not needed,
but mod_devicetable.h is missed.
Signed-off-by: Andy Shevchenko
---
drivers/leds/leds-lp50xx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c
Add missed bits.h and convert to BIT() in lp50xx_set_banks().
Signed-off-by: Andy Shevchenko
---
drivers/leds/leds-lp50xx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c
index 2b4981b5778d..0c6a5a9dd162 100644
Since GPIO is optional the API is NULL aware and will check descriptor anyway.
Remove duplicate redundant check in lp50xx_enable_disable().
Signed-off-by: Andy Shevchenko
---
drivers/leds/leds-lp50xx.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/leds/leds
pci_disable_msi(dev);
> - if (dev->msix_enabled)
> - pci_disable_msix(dev);
> + pci_free_irq_vectors(dev);
This change deserves a line in the commit message.
--
With Best Regards,
Andy Shevchenko
1, 1, PCI_IRQ_ALL_TYPES);
> if (r < 0)
> return r;
It's good, but now why do we have pci_free_irq_vectors() in the same file?
--
With Best Regards,
Andy Shevchenko
is simply a wrong statement.
--
With Best Regards,
Andy Shevchenko
When requesting optional GPIO echo line, bail out on error,
so user will know that something wrong with the existing property.
Signed-off-by: Andy Shevchenko
---
drivers/pps/clients/pps-gpio.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/pps/clients/pps
Device property API allows to gather device resources from different sources,
such as ACPI. Convert the drivers to unleash the power of device property API.
Signed-off-by: Andy Shevchenko
---
drivers/pps/clients/pps-gpio.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions
Platform data is a legacy interface to supply device properties
to the driver. In this case we even don't have in-kernel users
for it. Just remove it for good.
Signed-off-by: Andy Shevchenko
---
drivers/pps/clients/pps-gpio.c | 17 +++--
include/linux/pps-gpio.h | 19
Rearrange optional stuff in pps_gpio_setup() so it will go after mandatory one
and with reduced indentation. This will increase readability of the sources.
Signed-off-by: Andy Shevchenko
---
drivers/pps/clients/pps-gpio.c | 33 ++---
1 file changed, 18 insertions
In most parts of the code the platform device is not used.
Use struct device pointer directly to reduce code size and
increase readability.
Signed-off-by: Andy Shevchenko
---
drivers/pps/clients/pps-gpio.c | 42 +++---
1 file changed, 19 insertions(+), 23 deletions
The timer along with GPIO API are NULL-aware, there is no need to test
against existing GPIO echo line.
Signed-off-by: Andy Shevchenko
---
drivers/pps/clients/pps-gpio.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps
When GPIO APIs return -EPROBE_DEFER there is no need to print the message,
especially taking into consideration that it may repeat several times.
Use dev_err_probe() to avoid log noise in such cases.
Signed-off-by: Andy Shevchenko
---
drivers/pps/clients/pps-gpio.c | 15 ++-
1 file
Introduce module_parport_driver() helper macro to reduce boilerplate
in the existing and new code.
Signed-off-by: Andy Shevchenko
---
v2: fixed typo in the macro
include/linux/parport.h | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/include/linux/parport.h b
Switch to use module_parport_driver() to reduce boilerplate code.
Signed-off-by: Andy Shevchenko
Acked-by: Mark Brown
---
v2: added Ack (Mark), drop unneeded note from the commit message
drivers/spi/spi-lm70llp.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git
Switch to use module_parport_driver() to reduce boilerplate code.
Note, device_initcall() is a default for module_init().
Signed-off-by: Andy Shevchenko
Acked-by: Mark Brown
---
v2: added Ack (Mark)
drivers/spi/spi-butterfly.c | 13 +
1 file changed, 1 insertion(+), 12 deletions
bility(plane_state), DRM_RECT_FP_ARG(),
DRM_RECT_ARG(), rot_str);
This will show logical parts separately and clear view on what would be printed
when !fb. Also it uses seq_puts() without any needs for formatting.
--
With Best Regards,
Andy Shevchenko
be above can be replaced by pci_free_irq_vectors() to be sure that any
future change to PCI IRQ allocation APIs.
Yes, I have checked and currently the above code is equivalent to
pci_free_irq_vectors().
Dejin, please update your patch accordingly.
--
With Best Regards,
Andy Shevchenko
(patch #8) - addressed by introducing
>CONFIG_FAST_PATH;
> - split tools and kernel parts - not clear why it's better.
Because tools are user space programs and sometimes may not follow kernel
specifics, so they are different logically and changes should be separated.
> Anything else?
--
With Best Regards,
Andy Shevchenko
+Cc: Stephen
Stephen, do you have a check in Linux Next to catch the problem that
Co-developed-by is not being accompanied by a corresponding SoB?
On Tue, Feb 16, 2021 at 11:09 AM Andy Shevchenko
wrote:
>
> On Tue, Feb 16, 2021 at 9:24 AM Juergen Borleis wrote:
> >
> > From
On Tue, Feb 16, 2021 at 9:24 AM Juergen Borleis wrote:
>
> From: Steffen Trumtrar
>
> This is required to provide uuid based integrity functionality for:
> ima_policy (fsuuid option) and the 'evmctl' command ('--uuid' option).
Reviewed-by: Andy Shevchenko
One issue below has
Switch to use module_parport_driver() to reduce boilerplate code.
Note, device_initcall() is a default for module_init().
Signed-off-by: Andy Shevchenko
---
drivers/spi/spi-butterfly.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/spi/spi-butterfly.c
Introduce module_parport_driver() helper macro to reduce boilerplate
in the existing and new code.
Signed-off-by: Andy Shevchenko
---
include/linux/parport.h | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/include/linux/parport.h b/include/linux/parport.h
index
Switch to use module_parport_driver() to reduce boilerplate code.
Note, device_initcall() is a default for module_init().
Signed-off-by: Andy Shevchenko
---
drivers/spi/spi-lm70llp.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/spi/spi-lm70llp.c b
ator with %NUL to terminate first word */
*gname = '\0';
/* Drop space characters between first and second words */
gname = skip_spaces(gname + 1);
if (*gname == '\0')
return -EINVAL;
But please double check the logic.
...
> +free_buf:
exit_free_buf:
> + kfree(buf);
> +
> + return ret;
> +}
--
With Best Regards,
Andy Shevchenko
HENCE.
>
> The alternative is to leave firmwares in place with CVEs.
Good, thanks, I haven't looked into that script.
--
With Best Regards,
Andy Shevchenko
On Mon, Feb 15, 2021 at 07:26:55PM +0200, Sakari Ailus wrote:
> On Mon, Feb 15, 2021 at 03:41:14PM +0200, Andy Shevchenko wrote:
> ...
> > > + seq_printf(m, "\t\tuapi: [FB:%d] ", fb ? fb->base.id : 0);
> > > + if (fb)
> > > + seq_pri
On Mon, Feb 15, 2021 at 04:37:50PM +0200, Jani Nikula wrote:
> On Mon, 15 Feb 2021, Andy Shevchenko
> wrote:
> > We have already few similar implementation and a lot of code that can
> > benefit
> > of the yesno() helper. Consolidate yesno() helpers under string.h hood
On Mon, Feb 15, 2021 at 03:56:50PM +0200, Sakari Ailus wrote:
> On Mon, Feb 15, 2021 at 03:31:29PM +0200, Andy Shevchenko wrote:
> > On Mon, Feb 15, 2021 at 01:40:28PM +0200, Sakari Ailus wrote:
> > > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
&
nging that
> architecture looks to me to be a painful exercise.
>
> >> The approach can be easily be extended to other kinds of composite devices,
> >> eg. PCI cards or USB dongles.
> >>
> >>
> >> Yet some drawbacks of the current implementation:
> >>
> >> * individual FDT's can't be modularized yet (IMHO, we don't have DMI-based
> >>modprobing anyways)
> >
> > I think we need to use either firmware loading or udev mechanisms to
> > load the FDTs.
> >
> >> * can't reconfigure or attach to devices outside the individual DT's
> >>(eg. probed by PCI, etc)
> >
> > Not sure I follow.
> >
> > Rob
> >
>
--
With Best Regards,
Andy Shevchenko
On Tue, Feb 2, 2021 at 3:52 AM Carlis wrote:
> On Mon, 1 Feb 2021 19:40:21 +0200
> Andy Shevchenko wrote:
>
> > On Sat, Jan 30, 2021 at 8:39 AM carlis wrote:
> > > On Fri, 29 Jan 2021 16:26:12 +0200
> > > Andy Shevchenko wrote:
> > > > On Fri,
On Mon, Feb 15, 2021 at 5:13 PM Andy Shevchenko
wrote:
>
> On Mon, Feb 15, 2021 at 2:33 PM Calvin Johnson
> wrote:
> > On Mon, Feb 08, 2021 at 04:28:31PM +, Russell King - ARM Linux admin
> > wrote:
>
> ...
>
> > I think of_phy_is_fixed_link() n
ULL below.
> /* New binding */
> dn = of_get_child_by_name(np, "fixed-link");
> if (dn) {
--
With Best Regards,
Andy Shevchenko
On Mon, Feb 15, 2021 at 3:52 PM Jan Kiszka wrote:
> On 15.02.21 14:22, Andy Shevchenko wrote:
> > On Sun, Feb 14, 2021 at 10:57:46PM +0800, Dejin Zheng wrote:
> >> Call to 'pci_free_irq_vectors()' are missing both in the error handling
> >> path of the probe function,
+Cc: Sakari and printk people
On Mon, Feb 15, 2021 at 4:28 PM Christian König
wrote:
> Am 15.02.21 um 15:21 schrieb Andy Shevchenko:
> > We have already few similar implementation and a lot of code that can
> > benefit
> > of the yesno() helper. Consolidate yesno() helper
as long as it's needed. Alternative solution is
to provide the links during installation.
Btw, I haven't seen the driver change for that. Care to provide a
commit ID in upstream?
--
With Best Regards,
Andy Shevchenko
We have already an implementation and a lot of code that can benefit
of the onoff() helper. Move it under string.h hood.
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/i915_utils.h | 5 -
include/linux/string.h| 5 +
2 files changed, 5 insertions(+), 5 deletions
We have already an implementation and a lot of code that can benefit
of the enableddisabled() helper. Move it under string.h hood.
Signed-off-by: Andy Shevchenko
---
drivers/gpu/drm/i915/i915_utils.h | 5 -
include/linux/string.h| 5 +
2 files changed, 5 insertions(+), 5
We have already few similar implementation and a lot of code that can benefit
of the yesno() helper. Consolidate yesno() helpers under string.h hood.
Signed-off-by: Andy Shevchenko
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c| 6 +-
drivers/gpu/drm/i915/i915_utils.h
On Mon, Feb 15, 2021 at 01:40:30PM +0200, Sakari Ailus wrote:
> Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a
> large number of temporary variables at the same time.
What a nice clean up!
Reviewed-by: Andy Shevchenko
after addressing nit-picks below.
Sid
On Mon, Feb 15, 2021 at 01:40:29PM +0200, Sakari Ailus wrote:
> Now that we can print FourCC codes directly using printk, make use of the
> feature in V4L2 core.
Reviewed-by: Andy Shevchenko
See also below.
> Signed-off-by: Sakari Ailus
> ---
> drivers/media/v4l2-core/v4
feel free to add
Reviewed-by: From: Andy Shevchenko
after considering addressing below nit-picks.
> Suggested-by: Mauro Carvalho Chehab
> Signed-off-by: Sakari Ailus
> Reviewed-by: Petr Mladek
> Reviewed-by: Sergey Senozhatsky
> ---
> Documentation/core-api/printk-formats
On Mon, Feb 15, 2021 at 03:20:40PM +0200, Andy Shevchenko wrote:
> On Sun, Feb 14, 2021 at 02:45:29PM +0800, Dejin Zheng wrote:
> > Consolidate pci_free_irq_vectors to a single place using "goto free_irq"
> > for simplify the code.
FYI, you may rather to introduce
> allocation")
Same as per others. This does not fix anything, because there is no issue.
If you want to have it better, introduce a pcim_alloc_irq_vectors() to
show that it's managed.
--
With Best Regards,
Andy Shevchenko
; * add jan and Jarkko's review tag.
Can you read my comment to v1, please?
--
With Best Regards,
Andy Shevchenko
roduce pcim_alloc_irq_vectors() or so and do not add these
calls at all?
> Fixes: 64e02cb0bdfc7c ("spi: pca2xx-pci: Allow MSI")
No, it doesn't fix anything.
--
With Best Regards,
Andy Shevchenko
On Sun, Feb 14, 2021 at 02:45:29PM +0800, Dejin Zheng wrote:
> Consolidate pci_free_irq_vectors to a single place using "goto free_irq"
> for simplify the code.
One nit below, after addressing:
Reviewed-by: Andy Shevchenko
...
> +free_irq:
It's quite confusing name. I would
on all
> platforms; I don't know why it bothers you so much when platforms differ.
Isn't it any IRQ chip driver which may get IRQ on one or more lines
simultaneously?
The question here is can the handler be re-entrant on the same CPU in that case?
--
With Best Regards,
Andy Shevchenko
pio) OF_953X(__nrgpio, PCA_LATCH_INT | PCAL65xx_REGS)
When you change to the type, it will go accordingly. Don't add
LATCH_INT to the macro.
--
With Best Regards,
Andy Shevchenko
+Cc: Patrik (JFYI).
On Mon, Feb 15, 2021 at 12:23 PM Andy Shevchenko
wrote:
>
> On Mon, Feb 15, 2021 at 2:45 AM Stephen Rothwell
> wrote:
> >
> > Hi all,
> >
> > After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> > produced this
ore the pm
> tree (or the drivers-x86 tree). Or you need to include module.h in
> mdfld_output.c before intel_scu_ipc.h (or in intel_scu_ipc.h itself).
Thanks for the report.
I guess the DRM tree should carry this burden, or they can merge the
immutable tag themselves.
--
With Best Regards,
Andy Shevchenko
>
> Note: S_IFREG flag is added to the mode by __debugfs_create_file()
> in fs/debugfs/inode.c
I guess it also needs Suggested-by: Joe (IIRC he proposed to convert the rest).
Nevertheless,
Reviewed-by: Andy Shevchenko
Thanks!
> Suggested-by: Andy Shevchenko
> Signed-off-by: Drew Fus
Add test cases for fwnode_property_count_*() APIs.
While at it, modify the arrays of integers to be size of non-power-of-2
for better test coverage and decreasing stack usage.
Signed-off-by: Andy Shevchenko
---
drivers/base/test/property-entry-test.c | 50 +++--
1 file
On Fri, Feb 12, 2021 at 6:11 PM Rafael J. Wysocki wrote:
> On Fri, Feb 12, 2021 at 5:01 PM Andy Shevchenko
> wrote:
> > On Fri, Feb 12, 2021 at 03:31:24PM +0100, Rafael J. Wysocki wrote:
> > > On Fri, Feb 12, 2021 at 3:14 PM Andy Shevchenko
> > > wrote:
On Fri, Feb 12, 2021 at 03:31:24PM +0100, Rafael J. Wysocki wrote:
> On Fri, Feb 12, 2021 at 3:14 PM Andy Shevchenko
> wrote:
> > Refactor acpi_data_prop_read_single() for less LOCs and better maintenance.
Thanks for review, my answers below.
...
> &g
-only
subnodes")
Signed-off-by: Andy Shevchenko
---
drivers/acpi/property.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
index 2b65ad9b4c0d..ab4d7c734b0d 100644
--- a/drivers/acpi/property.c
+++ b/drivers/acpi/property.c
After the commit 3a7a2ab839ad couple of functions became a dead code.
Moreover, for all these years nobody used them. Remove.
Fixes: 3a7a2ab839ad ("ACPI / property: Extend fwnode_property_* to data-only
subnodes")
Signed-off-by: Andy Shevchenko
---
drivers/acpi/prope
There is no users outside of property.c. No need to export
acpi_node_prop_read(), hence make it static.
Fixes: 3708184afc77 ("device property: Move FW type specific functionality to
FW specific files")
Signed-off-by: Andy Shevchenko
---
drivers/acpi/property.c | 6 +++---
include/li
Refactor acpi_data_prop_read_single() for less LOCs and better maintenance.
Signed-off-by: Andy Shevchenko
---
drivers/acpi/property.c | 80 ++---
1 file changed, 34 insertions(+), 46 deletions(-)
diff --git a/drivers/acpi/property.c b/drivers/acpi
in
'acpi_graph_get_remote_endpoint'
Fixes: 0ef7478639c5 ("ACPI: property: Make the ACPI graph API private")
Signed-off-by: Andy Shevchenko
---
drivers/acpi/property.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
index ab
andle_irq() to mute
> > the warning in genirq.
>
> It seems that the other drivers just call handle_nested_irq() instead
> of generic_handle_irq().
And IIRC all of them request threaded IRQ explicitly.
--
With Best Regards,
Andy Shevchenko
ion too much as the dispatched irq handlers by
> gpiochip will run in their own threads but not in the thread of
> gpiochip's handler.
>
> so looks like this patch can improve by:
> * move other raw_spin_lock_irqsave to raw_spin_lock;
> * keep the raw_spin_lock_irqsave before generic_handle_irq() to mute
> the warning in genirq.
Isn't the idea of irqsave is to prevent dead lock from the process context when
we get interrupt on the *same* CPU?
--
With Best Regards,
Andy Shevchenko
e case
> regardless of the return pointer value if its return pointer argument
> is NULL and modify acpi_data_prop_read_single() handling that case to
> attempt to read the value of the property if the return pointer is
> NULL and return 1 if that succeeds.
Thanks, fine with me.
Reviewed-by
On Wed, Feb 10, 2021 at 04:44:34PM +0100, Rafael J. Wysocki wrote:
> On Wed, Feb 10, 2021 at 4:42 PM Andy Shevchenko
> wrote:
> > On Wed, Feb 10, 2021 at 04:01:16PM +0100, Rafael J. Wysocki wrote:
> > > On Wed, Feb 10, 2021 at 3:48 PM Andy Shevchenko
> > > wrote
Update Copyright year and drop file names from files themselves.
Signed-off-by: Andy Shevchenko
---
arch/x86/include/asm/intel-mid.h| 4 ++--
arch/x86/platform/intel-mid/intel-mid.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/include/asm/intel-mid.h
,
Note, atomisp change is tagged by Sakari on behalf of media tree maintainers.
Andy Shevchenko (9):
media: atomisp: Remove unused header
cpufreq: sfi-cpufreq: Remove driver for deprecated firmware
sfi: Remove framework for deprecated firmware
x86/PCI: Get rid of custom x86 model comparison
After the commit f1be6cdaf57c ("x86/platform/intel-mid: Make
intel_scu_device_register() static") the platform_device.h is not being
used anymore by intel-mid.h. Remove it.
Signed-off-by: Andy Shevchenko
---
arch/x86/include/asm/intel-mid.h | 1 -
1 file changed, 1 deletion(-)
sfi.h is not anyhow used by the driver. Remove it.
Signed-off-by: Andy Shevchenko
Acked-by: Sakari Ailus
Acked-by: Linus Walleij
---
drivers/staging/media/atomisp/include/linux/atomisp_platform.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/include/linux
Switch the platform code to use x86_id_table and accompanying API
instead of custom comparison against x86 CPU model.
This is one of the last users of custom API for that and following
changes will remove it for the good.
Signed-off-by: Andy Shevchenko
---
arch/x86/pci/intel_mid_pci.c | 17
SFI-based platforms are gone. So does this framework.
This removes mention of SFI through the drivers and other code as well.
Signed-off-by: Andy Shevchenko
Reviewed-by: Hans de Goede
Acked-by: Linus Walleij
---
Documentation/ABI/testing/sysfs-firmware-sfi | 15 -
Documentation/ABI/testing
Since there is no more user of this global variable and associated custom API,
we may safely drop this legacy reinvented a wheel from the kernel sources.
Signed-off-by: Andy Shevchenko
---
arch/x86/include/asm/intel-mid.h| 23 ---
arch/x86/platform/intel-mid/intel
ember 'reg'
not described in 'type1_access_ok'
Signed-off-by: Andy Shevchenko
---
arch/x86/pci/intel_mid_pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c
index 938a8b7bfe7f..8edd62206604 100644
--- a/arch/x86/pci/intel_mid_pci.c
+++ b/ar
SFI-based platforms are gone. So does this driver.
Signed-off-by: Andy Shevchenko
Acked-by: Linus Walleij
---
drivers/cpufreq/Kconfig.x86 | 10 ---
drivers/cpufreq/Makefile | 1 -
drivers/cpufreq/sfi-cpufreq.c | 127 --
3 files changed, 138 deletions
The header is used by a single user. Move header content to that user.
Signed-off-by: Andy Shevchenko
Reviewed-by: Mika Westerberg
---
arch/x86/include/asm/intel_scu_ipc.h| 2 --
arch/x86/include/asm/intel_scu_ipc_legacy.h | 18 --
arch/x86/platform/intel-mid/intel
correct length after parsing
> via sshp_parse_frame(), so we can simply use that instead.
Reviewed-by: Andy Shevchenko
> Reported-by: kernel-test-robot
> Fixes: c167b9c7e3d6 ("platform/surface: Add Surface Aggregator subsystem")
> Signed-off-by: Maximilian Luz
> ---
On Thu, Feb 11, 2021 at 12:58:48PM +0100, Maximilian Luz wrote:
> On 2/11/21 11:22 AM, Andy Shevchenko wrote:
> > On Thu, Feb 11, 2021 at 12:04:11AM +0100, Maximilian Luz wrote:
> > > The raw message frame length is unaligned and explicitly marked as
> > > little endian
On Thu, Feb 11, 2021 at 1:15 PM Enrico Weigelt, metux IT consult
wrote:
> On 10.02.21 11:30, Andy Shevchenko wrote:
> >> Use cases are boards with non-oftree firmware (ACPI, etc) where certain
> >> platform devices can't be directly enumerated via firmware. Traditionally
ntf library to check the command
> line. It also updates test_printf().
Side note to the future contributions.
> Full series:
>
> Acked-by: Marco Elver
That's what you usually add to each patch in the series individually.
You may use simple oneliner for this, i.e. `git filter-branch --msg-filter ...`
--
With Best Regards,
Andy Shevchenko
On Thu, Feb 11, 2021 at 12:04:11AM +0100, Maximilian Luz wrote:
> The raw message frame length is unaligned and explicitly marked as
> little endian. It should not be accessed without the appropriatte
> accessor functions. Fix this.
Reviewed-by: Andy Shevchenko
Though a few nit-pi
s on other platforms, so if Hans thinks it's okay to take,
Acked-by: Andy Shevchenko
> Signed-off-by: Casey Bowman
> Acked-by: Heikki Krogerus
> Acked-by: Mika Westerberg
> ---
> drivers/platform/x86/intel_scu_ipc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletio
On Wed, Feb 10, 2021 at 10:42 PM Song Bao Hua (Barry Song)
wrote:
> > -Original Message-
> > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com]
> > Sent: Thursday, February 11, 2021 3:57 AM
> > On Wed, Feb 10, 2021 at 11:50:45AM +, Song Ba
if (!gname) {
...
return -EINVAL;
}
*gname++ = '\0';
on top of the buf pointer.
> > + if (ret != 2) {
> > + dev_err(pctldev->dev, "expected format:
> > ");
> > + goto free_gname;
> > + }
--
With Best Regards,
Andy Shevchenko
you are targeting is something like dynamic debug approach where
you can choose which prints to enable/disable and what enable/disable in them.
In that case you specifically apply a command line option and enable only files
/ lines in the files.
--
With Best Regards,
Andy Shevchenko
/N" */
I would initialize with nmaskbits to be sure the value is invalid, but it will
add some code, below, so up to you, guys.
> +/*
> + * Seeing 'N' tells us to leave the value of "num" unchanged (which will
> + * be the max value for the width of the bitmap, set via DECLARE_REGION).
> + */
> static const char *bitmap_getnum(const char *str, unsigned int *num)
> {
> unsigned long long n;
> unsigned int len;
>
> + if (str[0] == 'N') /* nothing to do, just advance str */
> + return str + 1;
>
--
With Best Regards,
Andy Shevchenko
r;
> + br.r =
> + br.nbits = nmaskbits;
I thought about simply
struct bitmap_region br;
br.nbits = nmaskbits;
--
With Best Regards,
Andy Shevchenko
but it gets rid of an if (...) return...
Reviewed-by: Andy Shevchenko
> Cc: Yury Norov
> Cc: Rasmus Villemoes
> Cc: Andy Shevchenko
> Acked-by: Yury Norov
> Signed-off-by: Paul Gortmaker
> ---
> lib/bitmap.c | 19 +++
> 1 file changed, 7 insertions(+), 12 dele
On Tue, Feb 09, 2021 at 05:59:01PM -0500, Paul Gortmaker wrote:
> Add tests that specify a valid range, but one that is outside the
> width of the bitmap for which it is to be applied to. These should
> trigger an -ERANGE response from the code.
Reviewed-by: Andy Shevchenko
> Cc
ything using a CPU list.
I thought we kinda agreed that N is confusing and L is better.
N to me is equal to 32 on 32 core system as *number of cores / CPUs*. While L
sounds better as *last available CPU number*.
--
With Best Regards,
Andy Shevchenko
On Wed, Feb 10, 2021 at 04:01:16PM +0100, Rafael J. Wysocki wrote:
> On Wed, Feb 10, 2021 at 3:48 PM Andy Shevchenko
> wrote:
> > On Wed, Feb 10, 2021 at 02:48:09PM +0100, Rafael J. Wysocki wrote:
> > > On Wednesday, February 10, 2021 2:31:48 PM CET Rafael J. Wysocki wrote:
On Wed, Feb 10, 2021 at 11:50:45AM +, Song Bao Hua (Barry Song) wrote:
> > -Original Message-
> > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com]
> > Sent: Wednesday, February 10, 2021 11:51 PM
> > On Wed, Feb 10, 2021 at 5:43 AM luojiaxing wrote:
901 - 1000 of 17509 matches
Mail list logo
