| 14 +
> arch/arm/boot/dts/stih416-pinctrl.dtsi | 12 +
> drivers/mtd/devices/Kconfig |8 +
> drivers/mtd/devices/Makefile |1 +
> drivers/mtd/devices/serial_flash_cmds.h | 81 ++++
> drivers/mtd/devices/st_spi_fsm.
ad/write/read_reg/write_reg.
As it stands, the spi-nor framework cannot support the requirements of the
st_spi_fsm controller. I will go into further details on the "mtd: spi-nor"
thread.
Cheers,
Angus
--
-
Angus Clark
ST Microelectronics (R&D) Ltd.
1000 Aztec West, Bristol
On 12/10/2013 08:19 PM, Brian Norris wrote:
> On Fri, Nov 29, 2013 at 12:18:53PM +, Lee Jones wrote:
>> --- a/drivers/mtd/devices/st_spi_fsm.c
>> +static void stfsm_wait_seq(struct stfsm *fsm)
>> +{
>> +unsigned long timeo = jiffies + HZ;
>> +
>> +while (time_before(jiffies, timeo)) {
>
On 12/10/2013 09:48 PM, Brian Norris wrote:
> On Fri, Nov 29, 2013 at 12:18:57PM +, Lee Jones wrote:
>> JEDEC have helped to standardise a great deal of the commands which
>> can be issued to a Serial Flash devices. Many of the OPCODEs and all
>> of the Serial Flash Discoverable Parameters (SFD
On 12/10/2013 10:23 PM, Brian Norris wrote:
> On Tue, Dec 10, 2013 at 01:48:49PM -0800, Brian Norris wrote:
>> It doesn't look to me like the dual/quad bitfields are laid out very
>> usefully. Can't they be divided so that their bit position is more
>> meaningful?
[...]
> I realized you are packing
On 12/10/2013 10:03 PM, Brian Norris wrote:
> On Fri, Nov 29, 2013 at 12:18:58PM +, Lee Jones wrote:
>> --- a/drivers/mtd/devices/st_spi_fsm.h
>> +++ b/drivers/mtd/devices/st_spi_fsm.h
>> @@ -253,4 +253,141 @@ struct stfsm_seq {
>> } __attribute__((__packed__, aligned(4)));
>> #define STFSM_S
On 12/11/2013 01:06 AM, Brian Norris wrote:
> This process sounds very much like something that is needed for other
> controllers: a way to match controller capabilties with the opcodes
> supported by the flash.
Yes, I think this should be a primary aim of any 'spi-nor' framework".
> But it stil
On 12/17/2013 10:46 AM, Lee Jones wrote:
>> I will leave Lee to defend himself on this one ;-)
>
> No defence necessary, I think Brian's correct.
>
> NB: You might want to take a look at the 'dirty' implementation too. ;)
>
Yes, just done so :-(
Angus
--
To unsubscribe from this list: send the
Hi Lee and Brian,
I would also like to thank Brian; as always, very sensible comments.
I am tied up most of today and off work tomorrow (Christmas shopping!), but I
will set aside Friday to go through the comments in detail. I should also have
some time next week if necessary, subject to any pan
9 matches
Mail list logo
