Re: [PATCH V2 1/5] powerpc/perf: Expose processor pipeline stage cycles using PERF_SAMPLE_WEIGHT_STRUCT

2021-03-25 Thread Arnaldo
On March 25, 2021 11:38:01 AM GMT-03:00, Peter Zijlstra wrote: >On Thu, Mar 25, 2021 at 10:01:35AM -0300, Arnaldo Carvalho de Melo >wrote:. >> > > Also for CPU_FTR_ARCH_31, capture the two cycle counter >information in >> > > two 16 bit field

Re: [PATCH v2 0/3] perf-stat: share hardware PMCs with BPF

2021-03-18 Thread Arnaldo
On March 18, 2021 6:14:34 PM GMT-03:00, Jiri Olsa wrote: >On Thu, Mar 18, 2021 at 03:52:51AM +, Song Liu wrote: >> >> >> > On Mar 17, 2021, at 6:11 AM, Arnaldo Carvalho de Melo > wrote: >> > >> > Em Wed, Mar 17, 2021 at 02:29:28P

Re: [PATCH V2 3/5] tools/perf: Add powerpc support for PERF_SAMPLE_WEIGHT_STRUCT

2021-03-26 Thread Arnaldo
>+// SPDX-License-Identifier: GPL-2.0 >+#include >+#include >+#include >+ >+#include "../../../util/event.h" >+#include "../../../util/synthetic-events.h" >+#include "../../../util/machine.h" >+#include "../../../util/tool.h" >+#

Re: [PATCH] perf session: Add option to copy events when queueing

2013-10-24 Thread Arnaldo Melo
would be overwritten, something like making a range read only and then when the event would be _really_ consumed the tooling would mark it as so... Have to think about it more tho :-\ - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mes

Re: [PATCH] perf session: Add option to copy events when queueing

2013-10-24 Thread Arnaldo Melo
Em Thu, Oct 24, 2013 at 02:12:29PM +0100, David Ahern escreveu: > On 10/24/13 1:27 PM, Arnaldo Melo wrote: > The driving use case is my perf-daemon: > https://github.com/dsahern/linux/blob/perf-sched-timehist-3.11/tools/perf/schedmon.c, > line 271. > > Rather than have the p

Re: [PATCH 5/8] perf evlist: Allow reusing the side band thread for more purposes

2020-05-01 Thread Arnaldo Melo
On May 1, 2020 8:25:52 AM GMT-03:00, Jiri Olsa wrote: >On Wed, Apr 29, 2020 at 10:11:03AM -0300, Arnaldo Carvalho de Melo >wrote: >> From: Arnaldo Carvalho de Melo >> >> I.e. so far we had just one event in that side band thread, a dummy >one >> with attr.bp

Re: [PATCH -next] perf script: remove unneeded conversion to bool

2020-04-28 Thread Arnaldo Melo
On April 28, 2020 6:58:46 PM GMT-03:00, Joe Perches wrote: >On Tue, 2020-04-28 at 14:50 -0300, Arnaldo Carvalho de Melo wrote: >> Em Sun, Apr 26, 2020 at 08:31:05PM +0800, Zou Wei escreveu: >> > This issue was detected by using the Coccinelle software: >> > >&

Re: [PATCH 00/19] perf: ftrace enhancement

2020-05-10 Thread Arnaldo Melo
duces a libtracefs, that is to handle all the work needed to >interact with the tracefs directory. This will also be useful for perf >to read the event directory without having to open code that work. > >I'm all for giving perf the functionality of ftrace, but I would like >to have

Re: [PATCH v2 0/7] Copy hashmap to tools/perf/util, use in perf expr

2020-05-15 Thread arnaldo . melo
,Stephane Eranian From: Arnaldo Carvalho de Melo Message-ID: <79bcbaf7-bf5f-4556-a923-56e9d82fb...@gmail.com> On May 15, 2020 4:42:46 PM GMT-03:00, Andrii Nakryiko wrote: >On Fri, May 15, 2020 at 10:01 AM Arnaldo Carvalho de Melo > wrote: >> >> Em Fri, May 15, 2020

Re: [PATCH] perf script: Replace zero-length array with flexible-array

2020-05-11 Thread Arnaldo Melo
On May 11, 2020 2:26:20 PM GMT-03:00, "Gustavo A. R. Silva" wrote: >On Mon, May 11, 2020 at 12:48:12PM -0300, Arnaldo Carvalho de Melo >wrote: >> Em Thu, May 07, 2020 at 02:06:15PM -0500, Gustavo A. R. Silva >escreveu: >> > The current codebase makes use

Re: [PATCH] perf tools: Replace zero-length array with flexible-array

2020-05-11 Thread Arnaldo Melo
zeof operator is being incorrectly/erroneously applied to >zero-length arrays and the result is zero. Such instances may be hiding >some bugs. So, this work (flexible-array member conversions) will also >help to get completely rid of those sorts of issues. > >This issue was found with

Re: [PATCH v2] perf test shell: Fix check open filename arg using 'perf trace

2017-12-11 Thread Arnaldo de Melo
Em Fri, Dec 08, 2017 at 06:48:17PM +0100, Michael Petlan escreveu: > Hi Arnaldo, so I have tried what you've suggested and looks good. > Patch is attached. Sorry for not posting it in-text, but I need to > fix my mail client first, since it screwes some patches up due to > flowed

Re: [PATCH 31/32] perf, tools: Default to cpu// for events v3

2012-11-28 Thread Arnaldo Carvalho de Melo
or event better return -ENOMEM. > > Neither makes sense: the callers won't handle it and it's not a bug. > If you're out of memory in user space the only thing you can do is to > exit. Nope, just propagate it back and handle at the callers, the memory exhaustion may be

Re: [PATCH 2/2] perf tests: Add a test case for checking sw clock event frequency

2013-03-18 Thread Arnaldo Carvalho de Melo
x27;m moving the initialization to outside the struct named initialization block, i.e.: @@ -32,9 +32,10 @@ static int __test__sw_clock_freq(enum perf_sw_ids clock_id) .exclude_kernel = 1, .disabled = 1, .freq = 1, - .sample_freq = 1,

[PATCH 03/54] perf tools: Honor parallel jobs

2013-03-18 Thread Arnaldo Carvalho de Melo
://lkml.kernel.org/r/1361374353-30385-3-git-send-email...@alien8.de Signed-off-by: Arnaldo Carvalho de Melo --- Makefile |4 ++-- tools/scripts/Makefile.include |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 6fccf65

[PATCH 45/54] perf evsel: Cleanup perf_evsel__exit()

2013-03-18 Thread Arnaldo Carvalho de Melo
-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/evsel.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index dc16231..7fde9fb 100644 --- a/tools/perf/util/evsel.c +++ b/tools

[PATCH 48/54] perf record: Fixup return path of cmd_record()

2013-03-18 Thread Arnaldo Carvalho de Melo
/1363326533-3310-4-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-record.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 80cc3ea..9f2344a 100644 --- a/tools

[PATCH 27/54] perf annotate: Factor out struct source_line_percent

2013-03-18 Thread Arnaldo Carvalho de Melo
: http://lkml.kernel.org/r/1362462812-30885-8-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/browsers/annotate.c |2 +- tools/perf/util/annotate.c| 14 +++--- tools/perf/util/annotate.h|8 ++-- 3 files changed, 14

[GIT PULL 00/54] perf/core improvements and fixes

2013-03-18 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Hi Ingo, Please consider pulling, - Arnaldo The following changes since commit d1398ccfec56e54010476efd6a316427d29045a6: perf tools: Fix LIBNUMA build with glibc 2.12 and older. (2013-03-14 08:06:21 -0300) are available in the git repository at

[PATCH 44/54] perf tests: Test breakpoint overflow signal handler counts

2013-03-18 Thread Arnaldo Carvalho de Melo
FAILED in non verbose mode ] Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/Makefile |1 + tools/perf/tests/bp_signal_overflow.c | 126 + tools/perf/tests/builtin-test.c |4 + tools/perf/tests/tests.h |1

[PATCH 38/54] perf tools: Remove unused trace_read_data function

2013-03-18 Thread Arnaldo Carvalho de Melo
-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/trace-event-read.c | 201 1 files changed, 0 insertions(+), 201 deletions(-) diff --git a/tools/perf/util/trace-event-read.c b/tools/perf/util/trace-event-read.c index 3741572

[PATCH 53/54] perf stat: Introduce evlist methods to allocate/free the stats

2013-03-18 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Reducing the noise in the main logic. Cc: David Ahern Cc: Frederic Weisbecker Cc: Jiri Olsa Cc: Mike Galbraith Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/n/tip-o219lnci04hlilxi6711w

[PATCH 43/54] perf tests: Test breakpoint overflow signal handler

2013-03-18 Thread Arnaldo Carvalho de Melo
phane Eranian Cc: Thomas Gleixner Cc: Vince Weaver Link: http://lkml.kernel.org/r/1362940871-24486-6-git-send-email-jo...@redhat.com [ committer note: s/pr_err/pr_debug/g i.e. print just OK or FAILED in non verbose mode ] Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/Makefile |

[PATCH 12/54] tools/vm: Switch to liblk library

2013-03-18 Thread Arnaldo Carvalho de Melo
-email...@alien8.de Signed-off-by: Arnaldo Carvalho de Melo --- tools/vm/Makefile | 17 -- tools/vm/page-types.c | 85 - 2 files changed, 21 insertions(+), 81 deletions(-) diff --git a/tools/vm/Makefile b/tools/vm/Makefile index

[PATCH 47/54] perf trace: Free evlist resources properly on return path

2013-03-18 Thread Arnaldo Carvalho de Melo
/1363326533-3310-3-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-trace.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index 49fedb5..ab3ed4a 100644

[PATCH 50/54] perf tests: Fixup return path of perf record test case

2013-03-18 Thread Arnaldo Carvalho de Melo
From: Namhyung Kim Add missing perf_evlist__close() function. Signed-off-by: Namhyung Kim Cc: David Ahern Cc: Ingo Molnar Cc: Jiri Olsa Cc: Paul Mackerras Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1363326533-3310-6-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo

[PATCH 42/54] perf tools: Remove duplicated page_size definition

2013-03-18 Thread Arnaldo Carvalho de Melo
org/r/1363173585-9754-6-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/trace-event-info.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c index 3c

[PATCH 28/54] perf annotate: Support event group view for --print-line

2013-03-18 Thread Arnaldo Carvalho de Melo
: Namhyung Kim Cc: Paul Mackerras Cc: Pekka Enberg Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1362462812-30885-9-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/annotate.c | 130 +--- tools/perf/util

[PATCH 49/54] perf tests: Fixup return path of open-syscall-tp-fields test case

2013-03-18 Thread Arnaldo Carvalho de Melo
From: Namhyung Kim Add missing evlist cleanup functions. Signed-off-by: Namhyung Kim Cc: David Ahern Cc: Ingo Molnar Cc: Jiri Olsa Cc: Paul Mackerras Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1363326533-3310-5-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de

[PATCH 05/54] perf tools: Sort command-list.txt alphabetically

2013-03-18 Thread Arnaldo Carvalho de Melo
From: liguang Signed-off-by: liguang Cc: Ingo Molnar Cc: Jiri Olsa Cc: Namhyung Kim Cc: Paul Mackerras Cc: Pekka Enberg Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1361851974-25307-1-git-send-email-lig.f...@cn.fujitsu.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf

[PATCH 08/54] perf tests: Add attr record -C cpu test

2013-03-18 Thread Arnaldo Carvalho de Melo
Link: http://lkml.kernel.org/r/1361785972-7431-5-git-send-email-jo...@redhat.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/tests/attr/test-record-C0 | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) create mode 100644 tools/perf/tests/attr/test-record-C0 diff --git a/tools/

[PATCH 54/54] perf tests: Add a test case for checking sw clock event frequency

2013-03-18 Thread Arnaldo Carvalho de Melo
-email-namhy...@kernel.org [ committer note: Moved .sample_freq to outside named init block to cope with some gcc versions ] Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/Makefile |1 + tools/perf/tests/builtin-test.c |4 + tools/perf/tests/sw-clock.c | 119

[PATCH 46/54] perf evlist: Introduce perf_evlist__close()

2013-03-18 Thread Arnaldo Carvalho de Melo
From: Namhyung Kim It's a pair of perf_evlist__open(). Signed-off-by: Namhyung Kim Cc: David Ahern Cc: Ingo Molnar Cc: Jiri Olsa Cc: Paul Mackerras Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1363326533-3310-1-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carval

[PATCH 13/54] tools lib lk: Fix _FORTIFY_SOURCE builds

2013-03-18 Thread Arnaldo Carvalho de Melo
-by: Borislav Petkov Reported-by: Jiri Olsa Link: http://lkml.kernel.org/r/1362338733-8718-1-git-send-email...@alien8.de Signed-off-by: Arnaldo Carvalho de Melo --- tools/lib/lk/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/lib/lk/Makefile b/tools/lib/lk

[PATCH 51/54] perf test: Add test case for checking number of EXIT events

2013-03-18 Thread Arnaldo Carvalho de Melo
87obeljax4@sejong.aot.lge.com [ committer note: Fixup conflicts with f4c66b4 ( bp overflow tests ) ] Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/Makefile |1 + tools/perf/tests/builtin-test.c |4 + tools/perf/tests/task-exit.c| 123 +++ tools/

[PATCH 39/54] perf tools: Remove unused struct definitions

2013-03-18 Thread Arnaldo Carvalho de Melo
-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/trace-event-info.c | 12 1 files changed, 0 insertions(+), 12 deletions(-) diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c index 5c1509a..b0bbd76 100644

[PATCH 52/54] perf stat: Introduce --repeat forever

2013-03-18 Thread Arnaldo Carvalho de Melo
the loop with Ctrl+C. Signed-off-by: Frederik Deweerdt Cc: Ingo Molnar Cc: Paul Mackerras Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20130301180227.ga24...@ks398093.ip-192-95-24.net Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/Documentation/perf-stat.txt |2 +- tools

[PATCH 21/54] perf annotate: Pass evsel instead of evidx on annotation functions

2013-03-18 Thread Arnaldo Carvalho de Melo
: http://lkml.kernel.org/r/1362462812-30885-2-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-annotate.c | 16 +--- tools/perf/builtin-top.c |2 +- tools/perf/ui/browsers/annotate.c | 30

[PATCH 11/54] perf tools: Extract perf-specific stuff from debugfs.c

2013-03-18 Thread Arnaldo Carvalho de Melo
From: Borislav Petkov Move them to util.c and simplify code a bit. Signed-off-by: Borislav Petkov Cc: Ingo Molnar Cc: Steven Rostedt Link: http://lkml.kernel.org/r/1361374353-30385-6-git-send-email...@alien8.de Signed-off-by: Arnaldo Carvalho de Melo --- tools/lib/lk/debugfs.c

[PATCH 31/54] perf annotate/gtk: Support event group view on GTK

2013-03-18 Thread Arnaldo Carvalho de Melo
...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/gtk/annotate.c | 18 -- 1 files changed, 16 insertions(+), 2 deletions(-) diff --git a/tools/perf/ui/gtk/annotate.c b/tools/perf/ui/gtk/annotate.c index 6e2fc7e..f538794 100644 --- a/tools/perf/ui/gtk/annotate.c

[PATCH 26/54] perf evsel: Introduce perf_evsel__is_group_event() helper

2013-03-18 Thread Arnaldo Carvalho de Melo
group) event regardless of event group feature. Signed-off-by: Namhyung Kim Cc: Andi Kleen Cc: Ingo Molnar Cc: Jiri Olsa Cc: Paul Mackerras Cc: Pekka Enberg Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1362462812-30885-7-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de

[PATCH 41/54] perf tools: Remove unused macro definitions

2013-03-18 Thread Arnaldo Carvalho de Melo
-9754-5-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/trace-event-info.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c index 783ab51..3c452b5 1

[PATCH 40/54] perf tools: Remove unnecessary calc_data_size variable

2013-03-18 Thread Arnaldo Carvalho de Melo
Link: http://lkml.kernel.org/r/1363173585-9754-4-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/trace-event-info.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/

[PATCH 07/54] perf tests: Make attr script test event cpu

2013-03-18 Thread Arnaldo Carvalho de Melo
mhyung Kim Cc: Oleg Nesterov Cc: Paul Mackerras Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1361785972-7431-4-git-send-email-jo...@redhat.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/tests/attr.py |1 + tools/perf/tests/attr/base-record |1 + tools/perf/

[PATCH 23/54] perf annotate: Factor out disasm__calc_percent()

2013-03-18 Thread Arnaldo Carvalho de Melo
org/r/1362462812-30885-4-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/annotate.c | 49 ++- 1 files changed, 30 insertions(+), 19 deletions(-) diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annot

[PATCH 29/54] perf annotate browser: Make browser_disasm_line->percent an array

2013-03-18 Thread Arnaldo Carvalho de Melo
: Peter Zijlstra Link: http://lkml.kernel.org/r/1362462812-30885-10-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/browsers/annotate.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c

[PATCH 30/54] perf annotate browser: Use disasm__calc_percent()

2013-03-18 Thread Arnaldo Carvalho de Melo
Pekka Enberg Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1362462812-30885-11-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/browsers/annotate.c | 50 ++-- tools/perf/util/annotate.c|4 +- tools

[PATCH 33/54] perf trace: Get rid of a duplicate code

2013-03-18 Thread Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-trace.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index f0c20ef..49fedb5 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin

[PATCH 22/54] perf annotate: Add a comment on the symbol__parse_objdump_line()

2013-03-18 Thread Arnaldo Carvalho de Melo
i Olsa Cc: Paul Mackerras Cc: Pekka Enberg Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1362462812-30885-3-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/annotate.c | 20 1 files changed, 20 insertions(+), 0 deletion

[PATCH 06/54] perf tests: Make attr script verbose friendly

2013-03-18 Thread Arnaldo Carvalho de Melo
Ahern Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Oleg Nesterov Cc: Paul Mackerras Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1361785972-7431-3-git-send-email-jo...@redhat.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/tests/attr.c |9 +++-- tool

[PATCH 25/54] perf annotate: Add basic support to event group view

2013-03-18 Thread Arnaldo Carvalho de Melo
aa84: retq ... Signed-off-by: Namhyung Kim Cc: Andi Kleen Cc: Ingo Molnar Cc: Jiri Olsa Cc: Paul Mackerras Cc: Pekka Enberg Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1362462812-30885-6-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/Docume

[PATCH 04/54] perf tools: Correct Makefile.include

2013-03-18 Thread Arnaldo Carvalho de Melo
ff-by: Borislav Petkov Cc: Ingo Molnar Cc: Steven Rostedt Link: http://lkml.kernel.org/r/1361374353-30385-4-git-send-email...@alien8.de Signed-off-by: Arnaldo Carvalho de Melo --- tools/scripts/Makefile.include |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tools/sc

[PATCH 36/54] perf machine: Move machine__remove_thread and make static

2013-03-18 Thread Arnaldo Carvalho de Melo
From: David Ahern As the now only user, machine__process_exit_event, that is what tools use to process PERF_RECORD_EXIT events, is on the same object file. Signed-off-by: David Ahern Link: http://lkml.kernel.org/r/1363151248-16674-5-git-send-email-dsah...@gmail.com Signed-off-by: Arnaldo

[PATCH 37/54] perf report: Remove duplicated include

2013-03-18 Thread Arnaldo Carvalho de Melo
From: Wei Yongjun Signed-off-by: Wei Yongjun Cc: Ingo Molnar Cc: Paul Mackerras Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/CAPgLHd9=exah1hv4jevvta4tzfsjnx+8+g3zqmmukqq5qrq...@mail.gmail.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-report.c |1 - 1 files

[PATCH 24/54] perf annotate: Cleanup disasm__calc_percent()

2013-03-18 Thread Arnaldo Carvalho de Melo
hecked in every time. Signed-off-by: Namhyung Kim Cc: Andi Kleen Cc: Ingo Molnar Cc: Jiri Olsa Cc: Paul Mackerras Cc: Pekka Enberg Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1362462812-30885-5-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/

[PATCH 32/54] perf annotate browser: Support event group view on TUI

2013-03-18 Thread Arnaldo Carvalho de Melo
Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/878v5tl2vc@sejong.aot.lge.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/browsers/annotate.c | 93 +--- 1 files changed, 75 insertions(+), 18 deletions(-) diff --git a/tools/perf/ui/browsers

[PATCH 14/54] perf evlist: Remove cpus and threads arguments from perf_evlist__new()

2013-03-18 Thread Arnaldo Carvalho de Melo
http://lkml.kernel.org/r/1362987798-24969-1-git-send-email-namhy...@kernel.org [ committer note: replaced spaces with tabs in some of the affected lines ] Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-record.c |2 +- tools/perf/builtin-stat.c |

[PATCH 17/54] perf evlist: Pass struct perf_target to perf_evlist__prepare_workload()

2013-03-18 Thread Arnaldo Carvalho de Melo
4-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-record.c|3 ++- tools/perf/builtin-trace.c |3 ++- tools/perf/tests/perf-record.c |2 +- tools/perf/util/evlist.c |3 ++- tools/perf/util/evlist.h |1 + 5

[PATCH 19/54] perf evlist: Add want_signal parameter to perf_evlist__prepare_workload()

2013-03-18 Thread Arnaldo Carvalho de Melo
namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-record.c|3 ++- tools/perf/builtin-trace.c |2 +- tools/perf/tests/perf-record.c |3 ++- tools/perf/util/evlist.c |6 -- tools/perf/util/evlist.h |3 ++- 5 files change

[PATCH 09/54] perf tests: Add attr stat -C cpu test

2013-03-18 Thread Arnaldo Carvalho de Melo
Link: http://lkml.kernel.org/r/1361785972-7431-6-git-send-email-jo...@redhat.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/tests/attr/test-stat-C0 |9 + 1 files changed, 9 insertions(+), 0 deletions(-) create mode 100644 tools/perf/tests/attr/test-stat-C0 diff --git a/tools/perf/tests

[PATCH 15/54] perf evlist: Use cpu_map__nr() helper

2013-03-18 Thread Arnaldo Carvalho de Melo
...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/evlist.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index a199f18..a482547 100644 --- a/tools/perf/util/evlist.c +++ b/tools/perf/util/evlist.c

[PATCH 16/54] perf evlist: Add thread_map__nr() helper

2013-03-18 Thread Arnaldo Carvalho de Melo
/1362987798-24969-3-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-stat.c|4 ++-- tools/perf/util/evlist.c | 37 +++-- tools/perf/util/thread_map.h |5 + 3 files changed, 30 insertions(+), 16

[PATCH 18/54] perf evlist: Do not pass struct record_opts to perf_evlist__prepare_workload()

2013-03-18 Thread Arnaldo Carvalho de Melo
vid Ahern Cc: Ingo Molnar Cc: Jiri Olsa Cc: Paul Mackerras Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1362987798-24969-5-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-record.c|2 +- tools/perf/builtin-trace.c |2 +- too

[PATCH 10/54] perf tools: Introduce tools/lib/lk library

2013-03-18 Thread Arnaldo Carvalho de Melo
Rostedt Link: http://lkml.kernel.org/r/1361374353-30385-5-git-send-email...@alien8.de [ committer note: Add tools/lib/lk/ to perf's MANIFEST so that its tarballs continue to build ] Signed-off-by: Arnaldo Carvalho de Melo --- tools/Makefile | 16 - tools/lib/lk/Mak

[PATCH 20/54] perf stat: Use perf_evlist__prepare/start_workload()

2013-03-18 Thread Arnaldo Carvalho de Melo
/r/1362987798-24969-7-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-stat.c | 58 +--- 1 files changed, 7 insertions(+), 51 deletions(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c

[PATCH 01/54] perf tools: Fix build on non-glibc systems due to libio.h absence

2013-03-18 Thread Arnaldo Carvalho de Melo
: Arnaldo Carvalho de Melo --- tools/perf/arch/arm/util/dwarf-regs.c |5 + tools/perf/arch/powerpc/util/dwarf-regs.c |5 + tools/perf/arch/s390/util/dwarf-regs.c|2 +- tools/perf/arch/sh/util/dwarf-regs.c |2 +- tools/perf/arch/sparc/util/dwarf-regs.c |2

[PATCH 35/54] perf session: Remove unused perf_session__remove_thread method

2013-03-18 Thread Arnaldo Carvalho de Melo
-send-email-dsah...@gmail.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/session.c | 12 tools/perf/util/session.h |1 - 2 files changed, 0 insertions(+), 13 deletions(-) diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index bd85280..ab265c2

[PATCH 34/54] perf tools: Remove unused tracing functions

2013-03-18 Thread Arnaldo Carvalho de Melo
From: David Ahern Leftovers from before libtraceevent integration. Signed-off-by: David Ahern Link: http://lkml.kernel.org/r/1363151248-16674-3-git-send-email-dsah...@gmail.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/trace-event-parse.c | 37

[PATCH 02/54] perf tools: Remove a write-only variable in the debugfs code

2013-03-18 Thread Arnaldo Carvalho de Melo
.de Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/debugfs.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/tools/perf/util/debugfs.c b/tools/perf/util/debugfs.c index dd8b193..e55495c 100644 --- a/tools/perf/util/debugfs.c +++ b/tools/perf/util

Re: [PATCH 6/9] perf util: Get rid of malloc_or_die() in trace-event-read.c

2013-03-20 Thread Arnaldo Carvalho de Melo
ode lies at the end of the function, i.e. in source and binary code it has a lower chance of polluting brain and CPU caches, and we don't need to call N functions if we'll bail out when the one of them fails. I.e. nothing new here, just follow kernel coding style, move along :-) -

Re: Perf tool won't build without libnewt

2013-03-20 Thread Arnaldo Carvalho de Melo
0 perf report: Fix build with NO_NEWT=1 Thanks for reporting! - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 8/9] perf util: Get rid of die() calls in trace-data-read.c

2013-03-20 Thread Arnaldo Carvalho de Melo
rr(). I mean, if the old code would kill the > > process, why just keep it as a debug output? > Please see my other reply. Ditto. > Arnaldo, can you give me your direction/preference? Yeah, I think that lower levels should emit a debug if it helps developers and advanced users to re

Re: [PATCH v7 00/18] perf: add memory access sampling support

2013-02-05 Thread Arnaldo Carvalho de Melo
l, perf. > > Ok, so I have created a topic tree for this, tip:perf/x86. > > I have applied the kernel bits (with some minor renaming > > changes). Arnaldo, if you agree with the tooling bits you can > > merge that branch into your tree and apply the tooling bits from >

Re: [PATCH 2/2] perf stat: add per processor socket count aggregation

2013-02-06 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 06, 2013 at 03:46:02PM +0100, Stephane Eranian escreveu: > tools/perf/builtin-stat.c | 126 > + Added the missing 'perf stat' man page entry based on the changeset comments, - Arnaldo -- To unsubscribe from this lis

[PATCH 06/17] perf sort: Make setup_sorting returns an error code

2013-02-06 Thread Arnaldo Carvalho de Melo
ggested-by: Arnaldo Carvalho de Melo Cc: Ingo Molnar Cc: Jiri Olsa Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/r/1360130237-9963-2-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-annotate.c | 3 ++-

[PATCH 07/17] perf sort: Check return value of strdup()

2013-02-06 Thread Arnaldo Carvalho de Melo
not initialized. Signed-off-by: Namhyung Kim Acked-by: Jiri Olsa Cc: Ingo Molnar Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/r/1360130237-9963-3-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/sort

[PATCH 13/17] perf tools: Fix perf_evsel::exclude_GH handling

2013-02-06 Thread Arnaldo Carvalho de Melo
: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1359971803-2343-2-git-send-email-jo...@redhat.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/parse-events.c | 8 1 file changed, 8 deletions

[PATCH 03/17] perf evlist: Fix set event list leader

2013-02-06 Thread Arnaldo Carvalho de Melo
an upcoming patch set. Signed-off-by: Stephane Eranian Acked-by: Jiri Olsa Tested-by: Jiri Olsa Acked-by: Namhyung Kim Cc: Ingo Molnar Cc: Jiri Olsa Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20130131125437.GA3656@quad Signed-off-by: Arnaldo Carvalho de Melo --- to

[PATCH 01/17] perf hists browser: Add option for runtime switching perf data file

2013-02-06 Thread Arnaldo Carvalho de Melo
perf tree Signed-off-by: Feng Tang Cc: Andi Kleen Cc: Ingo Molnar Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1359873501-24541-1-git-send-email-feng.t...@intel.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/browsers/hists.c | 112 +

[GIT PULL 00/17] perf/core improvements and fixes

2013-02-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Hi Ingo, Please consider pulling, - Arnaldo The following changes since commit 0fbdad078a70ed72248c3d30fe32e45e83be00d1: perf/x86: Allow for architecture specific RDPMC indexes (2013-02-06 19:45:24 +0100) are available in the git repository at

[PATCH 12/17] perf perl scripts: Fix SIGALRM and pipe read race for rwtop

2013-02-06 Thread Arnaldo Carvalho de Melo
http://lkml.kernel.org/r/1360080351-3246-2-git-send-email-jo...@redhat.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/scripts/perl/rwtop.pl | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/perf/scripts/perl/rwtop.pl b/tools/perf/scripts/perl/rwtop.pl index 4bb

[PATCH 11/17] perf hists browser: Add support to display whole group data for raw columns

2013-02-06 Thread Arnaldo Carvalho de Melo
by: Jiri Olsa Acked-by: Namhyung Kim Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1359981185-16819-2-git-send-email-jo...@redhat.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui

[PATCH 08/17] perf evlist: Make event_copy local to mmaps

2013-02-06 Thread Arnaldo Carvalho de Melo
g/r/1360098762-61827-1-git-send-email-dsah...@gmail.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/perf.h| 26 -- tools/perf/util/evlist.c | 4 ++-- tools/perf/util/evlist.h | 29 - 3 files changed, 30 insertions(+), 29 deletions(-) d

[PATCH 10/17] perf stat: Add per processor socket count aggregation

2013-02-06 Thread Arnaldo Carvalho de Melo
: Added missing man page entry based on above comments ] Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/Documentation/perf-stat.txt | 9 ++- tools/perf/builtin-stat.c | 126 ++--- 2 files changed, 123 insertions(+), 12 deletions(-) diff --git a/tools

[PATCH 02/17] perf report: Enable the runtime switching of perf data file

2013-02-06 Thread Arnaldo Carvalho de Melo
Cc: Andi Kleen Cc: Ingo Molnar Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1359873501-24541-2-git-send-email-feng.t...@intel.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-report.c | 38 +++--- 1 file changed, 27 in

[PATCH 14/17] perf tests: Adding automated parsing tests for group :GH modifiers

2013-02-06 Thread Arnaldo Carvalho de Melo
; "{cycles:G,cache-misses:H}:uG" Plus fixing test__group2 test. Signed-off-by: Jiri Olsa Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1359971803-2343-3-git-send-email-jo...@redhat.com S

[PATCH 09/17] perf tools: Add cpu_map processor socket level functions

2013-02-06 Thread Arnaldo Carvalho de Melo
Eranian Cc: Andi Kleen Cc: Ingo Molnar Cc: Jiri Olsa Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1360161962-9675-2-git-send-email-eran...@google.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/cpumap.c | 54

[PATCH 05/17] perf sort: Drop ip_[lr] arguments from _sort__sym_cmp()

2013-02-06 Thread Arnaldo Carvalho de Melo
t__sym_cmp(). Signed-off-by: Namhyung Kim Acked-by: Jiri Olsa Cc: Ingo Molnar Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/r/1360130237-9963-1-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/s

[PATCH 04/17] perf tools: Check for flex and bison before continuing building

2013-02-06 Thread Arnaldo Carvalho de Melo
From: Borislav Petkov Check whether both executables are present on the system before continuing with the build instead of failing halfway, if either are missing. Signed-off-by: Borislav Petkov Link: http://lkml.kernel.org/r/1359979554-9160-1-git-send-email...@alien8.de Signed-off-by: Arnaldo

[PATCH 15/17] perf tools: Fix calloc argument ordering

2013-02-06 Thread Arnaldo Carvalho de Melo
c: Paul Mackerras Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1359594349-25912-1-git-send-email-paul.gortma...@windriver.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/callchain.c | 2 +- tools/perf/util/header.c| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --g

[PATCH 17/17] perf python: Link with sysfs.o

2013-02-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo So that we fix this regression: [root@sandy linux]# perf test -v 15 15: Try 'use perf' in python, checking link problems : --- start --- Traceback (most recent call last): File "", line 1, in ImportError: /home/acme/git/build

[PATCH 16/17] perf evlist: Pass the event_group info via perf_attr_details

2013-02-06 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo So that we avoid dragging symbol.o into the python binding. Cc: David Ahern Cc: Frederic Weisbecker Cc: Jiri Olsa Cc: Mike Galbraith Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/n/tip

Re: [PATCH 7/7] perf annotate: Make it to be able to skip unannotatable symbols

2013-02-07 Thread Arnaldo Carvalho de Melo
gt; Signed-off-by: Namhyung Kim > --- > tools/perf/builtin-annotate.c | 17 +++-- You forgot to add the entry in the man page... - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH] perf: fix bug in isupper() and islower()

2013-04-02 Thread Arnaldo Carvalho de Melo
ing this fix now, as it improves things, but this seemingly needless speciations looks insane, would be great to have at least tools/perf/ using the same stuff as its landlord, the kernel. - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCHSET 0/9] perf tools: Bug fix and cleanup for sort keys

2013-04-02 Thread Arnaldo Carvalho de Melo
Em Mon, Apr 01, 2013 at 08:35:16PM +0900, Namhyung Kim escreveu: > This is a couple of bugfix, cleanup and enhancement for sort keys. Applied 1-4. - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.ke

Re: [PATCH 03/10] perf sort: Add 'addr' sort key

2013-04-03 Thread Arnaldo Carvalho de Melo
What I expected was that the result was this: perf report --sort addr | grep -v ^# | sort -k2 -n | less And in hexadecimal, can you fix this? - Arnaldo Em Wed, Apr 03, 2013 at 09:26:12PM +0900, Namhyung Kim escreveu: > static void hists__set_unres_dso_col_len(struct hists *hists, int

Re: [PATCH 09/10] perf hist browser: Use sort__has_sym

2013-04-03 Thread Arnaldo Carvalho de Melo
lobal variable, making it impossible to use different sort orders in the same session, if we ever want to do that :-) - Arnaldo > Signed-off-by: Namhyung Kim > --- > tools/perf/ui/browsers/hists.c | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff

Re: [PATCH 10/10] perf sort: Consolidate sort_entry__setup_elide()

2013-04-03 Thread Arnaldo Carvalho de Melo
his that are clear cleanups are best positioned in the start of the patch series. - Arnaldo > Signed-off-by: Namhyung Kim > --- > tools/perf/builtin-diff.c | 4 +--- > tools/perf/builtin-report.c | 20 +--- > tools/perf/builtin-top.c| 4 +--- > to

Re: [PATCH v6 2/2] perf stat: add interval printing

2013-01-28 Thread Arnaldo Carvalho de Melo
Em Mon, Jan 28, 2013 at 11:45:56PM +0100, Stephane Eranian escreveu: > On Mon, Jan 28, 2013 at 8:21 PM, Arnaldo Carvalho de Melo > wrote: > > Em Mon, Jan 28, 2013 at 07:26:17PM +0100, Stephane Eranian escreveu: > >> On Mon, Jan 28, 2013 at 6:59 PM, Arnaldo Carvalho de Melo &

Re: [PATCH] perf evsel: Fix memory leaks on evsel->counts

2013-01-29 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 24, 2013 at 11:45:58PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Jan 25, 2013 at 10:44:44AM +0900, Namhyung Kim escreveu: > > From: Namhyung Kim > > > > The ->counts field was never freed in the current code. Add > > perf_evsel__free_counts(

  1   2   3   4   5   6   7   8   9   10   >