Re: [PATCH] add check do_direct_IO() return val

2007-07-30 Thread Badari
job10] ioengine=mmap rw=randwrite bs=1k filename=file1:file2 [job11] ioengine=mmap rw=randwrite direct=1 filename=file1:file2 Hmm.. in this config file, whats causing DIO to panic ? Which test actually passing faulty buffer ? Thanks, Badari

Re: [PATCH] add check do_direct_IO() return val

2007-07-30 Thread Badari
. looks lile my machine crashed too while running the tests. I will take a look. Thanks, Badari - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html P

Re: [PATCH] ext2 statfs improvement for block and inode free count

2007-10-16 Thread Badari
Andrew Morton wrote: On Fri, 13 Jul 2007 18:36:54 -0700 Badari Pulavarty <[EMAIL PROTECTED]> wrote: More statfs() improvements for ext2. ext2 already maintains percpu counters for free blocks and inodes. Derive free block count and inode count by summing up percpu counters, inst

Re: [PATCH] drivers/base: export (un)register_memory_notifier

2008-02-01 Thread Badari Pulavarty
em EXPORT_SYMBOL_GPL() ? Otherwise, looks good to me. I have been planning to send this as part of my next update with ppc64 arch-specific remove support and generic __remove_pages() support. If this is blocking your work, lets get this in. Acked-by: Badari Pulavarty <[EMAIL PROTECTED]> Thank

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-11 Thread Badari Pulavarty
On Mon, 2008-02-11 at 11:48 -0800, Andrew Morton wrote: > On Mon, 11 Feb 2008 09:23:18 -0800 > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > Hi Andrew, > > > > While testing hotplug memory remove against -mm, I noticed > > that unregister_mem

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-12 Thread Badari Pulavarty
On Tue, 2008-02-12 at 13:57 -0800, Dave Hansen wrote: > On Tue, 2008-02-12 at 13:56 -0800, Badari Pulavarty wrote: > > > > +static void __remove_section(struct zone *zone, unsigned long > > section_nr) > > +{ > > + if (!valid_section_nr(sectio

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-12 Thread Badari Pulavarty
On Tue, 2008-02-12 at 14:15 -0800, Dave Hansen wrote: > On Tue, 2008-02-12 at 14:07 -0800, Badari Pulavarty wrote: > > On Tue, 2008-02-12 at 13:57 -0800, Dave Hansen wrote: > > > On Tue, 2008-02-12 at 13:56 -0800, Badari Pulavarty wrote: > > > > > > > >

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-12 Thread Badari Pulavarty
On Tue, 2008-02-12 at 14:15 -0800, Dave Hansen wrote: > On Tue, 2008-02-12 at 14:07 -0800, Badari Pulavarty wrote: > > On Tue, 2008-02-12 at 13:57 -0800, Dave Hansen wrote: > > > On Tue, 2008-02-12 at 13:56 -0800, Badari Pulavarty wrote: > > > > > > > >

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-12 Thread Badari Pulavarty
On Tue, 2008-02-12 at 17:06 +0900, Yasunori Goto wrote: > > On Mon, 2008-02-11 at 11:48 -0800, Andrew Morton wrote: > > > On Mon, 11 Feb 2008 09:23:18 -0800 > > > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > > > > Hi Andrew, > > >

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-12 Thread Badari Pulavarty
On Tue, 2008-02-12 at 12:59 -0800, Dave Hansen wrote: > On Tue, 2008-02-12 at 09:22 -0800, Badari Pulavarty wrote: > > +static void __remove_section(struct zone *zone, unsigned long > > phys_start_pfn) > > +{ > > + if (!pfn_valid(phys_start_pfn)) > > +

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-13 Thread Badari Pulavarty
On Wed, 2008-02-13 at 14:09 +0900, Yasunori Goto wrote: > Thanks Badari-san. > > I understand what was occured. :-) > > > On Tue, 2008-02-12 at 13:56 -0800, Badari Pulavarty wrote: > > > > > + /* > > > > > +* Its ugly, but this is the best I

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-14 Thread Badari Pulavarty
64. But on ppc64 is contains ONLY iomem related. Paulus didn't want to export all the system memory into /proc/iomem on ppc64. So I had to workaround by providing arch-specific walk_memory_resource() function for ppc64. Thanks, Badari -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-07 Thread Badari Pulavarty
? With this change, the directories are getting removed correctly. Comments ? Thanks, Badari sysdev_unregister() should call kobject_del() to remove the object. Signed-off-by: Badari Pulavarty <[EMAIL PROTECTED]> --- drivers/base/sys.c |1 + 1 file changed, 1 insertion(+) Index: linux-

Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-07 Thread Badari Pulavarty
On Thu, 2008-02-07 at 16:38 -0800, Greg KH wrote: > On Thu, Feb 07, 2008 at 03:56:58PM -0800, Badari Pulavarty wrote: > > Hi Greg, > > > > While playing with hotplug memory remove on 2.6.24-mm1, I > > noticed that /sysfs directory entries are not getting removed.

Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-07 Thread Badari Pulavarty
On Thu, 2008-02-07 at 20:55 -0800, Greg KH wrote: > On Thu, Feb 07, 2008 at 05:25:46PM -0800, Badari Pulavarty wrote: > > On Thu, 2008-02-07 at 16:38 -0800, Greg KH wrote: > > > On Thu, Feb 07, 2008 at 03:56:58PM -0800, Badari Pulavarty wrote: > > > > Hi Greg, >

Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-08 Thread Badari Pulavarty
On Thu, 2008-02-07 at 21:41 -0800, Greg KH wrote: > On Thu, Feb 07, 2008 at 09:08:42PM -0800, Badari Pulavarty wrote: > > > > On Thu, 2008-02-07 at 20:55 -0800, Greg KH wrote: > > > On Thu, Feb 07, 2008 at 05:25:46PM -0800, Badari Pulavarty wrote: > > > > On

Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-08 Thread Badari Pulavarty
On Thu, 2008-02-07 at 20:55 -0800, Greg KH wrote: > On Thu, Feb 07, 2008 at 05:25:46PM -0800, Badari Pulavarty wrote: > > On Thu, 2008-02-07 at 16:38 -0800, Greg KH wrote: > > > On Thu, Feb 07, 2008 at 03:56:58PM -0800, Badari Pulavarty wrote: > > > > Hi Greg, >

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-11 Thread Badari Pulavarty
On Mon, 2008-02-11 at 09:54 -0800, Greg KH wrote: > On Mon, Feb 11, 2008 at 09:23:18AM -0800, Badari Pulavarty wrote: > > Hi Andrew, > > > > While testing hotplug memory remove against -mm, I noticed > > that unregister_memory() is not cleaning up /sysfs entrie

[-mm PATCH] register_memory/unregister_memory clean ups

2008-02-11 Thread Badari Pulavarty
issue. Could you please include it in -mm ? Thanks, Badari register_memory()/unregister_memory() never gets called with "root". unregister_memory() is accessing kobject_name of the object just freed up. Since no one uses the code, lets take the code out. And also, make register_memor

Re: Problem in log_do_checkpoint()?

2005-04-08 Thread Badari Pulavarty
28 8b 33 e8 cf 76 f6 ff 0f ba 2e 13 19 c0 85 c0 0f 85 3f 01 00 00 89 5c 24 04 8d 44 Thanks, Badari On Mon, 2005-04-04 at 02:04, Jan Kara wrote: > Hello, > > I've been looking through the JBD code when trying to understand the > assertion failure in log_do_checkpoint() (i

Re: [rfc patch 2/2] direct-io: remove address alignment check

2005-07-14 Thread Badari Pulavarty
s you are not relaxing it (yet).. Thanks, Badari On Wed, 2005-07-13 at 16:43 -0700, Daniel McNeil wrote: > This patch relaxes the direct i/o alignment check so that user addresses > do not have to be a multiple of the device block size. > > I've done some preliminary testing and it

Re: [rfc patch 2/2] direct-io: remove address alignment check

2005-07-14 Thread Badari Pulavarty
access to files in a given filesystem are O_DIRECT (whether they are accessing or some random program like ftp, scp, cp are acessing them). This was mainly to ensure that buffered accesses to the file doesn't polute the pagecache (while database is using O_DIRECT access). Seems like a logical request,

Re: [rfc patch 2/2] direct-io: remove address alignment check

2005-07-14 Thread Badari Pulavarty
Daniel McNeil wrote: On Thu, 2005-07-14 at 16:16, Badari Pulavarty wrote: How does your patch ensures that we meet the driver alignment restrictions ? Like you said, you need atleast "even" byte alignment for IDE etc.. And also, are there any restrictions on how much the "m

Re: [rfc patch 2/2] direct-io: remove address alignment check

2005-07-15 Thread Badari Pulavarty
On Fri, 2005-07-15 at 17:56 +0100, Joel Becker wrote: > On Thu, Jul 14, 2005 at 10:18:28PM -0700, Badari Pulavarty wrote: > > I can imagine a reason for relaxing the alignment. I keep getting asked > > whether we can do "O_DIRECT mount option". Database folks wants to >

Re: [rfc patch 2/2] direct-io: remove address alignment check

2005-07-15 Thread Badari Pulavarty
On Fri, 2005-07-15 at 17:23 +0900, Tejun Heo wrote: > Badari Pulavarty wrote: ... > >> I don't know why you wanna relax the alignment requirement, but > >> wouldn't it be easier to just write/use block-aligned allocator for > >> such buffers? It

Re: [Ext2-devel] [RFC] [PATCH 2/4]delayed allocation for ext3

2005-07-18 Thread Badari Pulavarty
NING "EXT3-fs: Ignoring delall option > > - " > > + "its supported only with writeback mode\n"); > > Should be "ignoring delalloc option". Yep. Thanks, Badari - To unsubscribe from this list: send the line "unsubs

Memory pressure handling with iSCSI

2005-07-26 Thread Badari Pulavarty
rly and making progress. (Machine doesn't respond very well for anything else, but my vmstat keeps running - 100% sys time). Thanks, Badari procs ---memory-- ---swap-- -io --system-- cpu r b swpd free buff cache si sobibo incs us sy id wa

Re: Memory pressure handling with iSCSI

2005-07-26 Thread Badari Pulavarty
On Tue, 2005-07-26 at 11:11 -0700, Andrew Morton wrote: > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > After KS & OLS discussions about memory pressure, I wanted to re-do > > iSCSI testing with "dd"s to see if we are throttling writes. > &g

Re: Memory pressure handling with iSCSI

2005-07-26 Thread Badari Pulavarty
ness and the page > will be cleaned without any I/O being performed. All the throttling > _should_ work OK in this case. But ext2 is more straightforward.) I will try ext2 next. - Badari - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body o

Re: Memory pressure handling with iSCSI

2005-07-26 Thread Badari Pulavarty
On Tue, 2005-07-26 at 15:31 -0400, Sonny Rao wrote: > On Tue, Jul 26, 2005 at 11:39:11AM -0700, Badari Pulavarty wrote: > > On Tue, 2005-07-26 at 11:11 -0700, Andrew Morton wrote: > > > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > > > > > Aft

Re: Memory pressure handling with iSCSI

2005-07-26 Thread Badari Pulavarty
On Tue, 2005-07-26 at 16:59 -0400, Rik van Riel wrote: > On Tue, 26 Jul 2005, Badari Pulavarty wrote: > > > After KS & OLS discussions about memory pressure, I wanted to re-do > > iSCSI testing with "dd"s to see if we are throttling writes. > > Could you

Re: Memory pressure handling with iSCSI

2005-07-26 Thread Badari Pulavarty
0.0194 14 handle_IRQ_event 0.1458 12 skb_clone 0.0214 12 kfree 0.0500 12 end_buffer_async_write 0.0469 11 tcp_v4_rcv 0.0041 10 test_set_

Re: Memory pressure handling with iSCSI

2005-07-26 Thread Badari Pulavarty
On Tue, 2005-07-26 at 14:24 -0700, Andrew Morton wrote: > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > ext2 is incredibly better. Machine is very responsive. > > > > OK. Please, always monitor and send /proc/meminfo. I assume that the > dirty-memory

Re: Memory pressure handling with iSCSI

2005-07-26 Thread Badari Pulavarty
On Tue, 2005-07-26 at 15:10 -0700, Andrew Morton wrote: > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > On Tue, 2005-07-26 at 14:24 -0700, Andrew Morton wrote: > > > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > > > >

Re: [RFC] [PATCH 2/4]delayed allocation for ext3

2005-07-26 Thread Badari Pulavarty
On Tue, 2005-07-26 at 15:52 -0700, Andrew Morton wrote: > Mingming Cao <[EMAIL PROTECTED]> wrote: > > > > Here is the updated patch from Badari for delayed allocation for ext3. > > Delayed allocation defers block allocation from prepare-write time to > > p

Re: Memory pressure handling with iSCSI

2005-07-26 Thread Badari Pulavarty
On Tue, 2005-07-26 at 16:07 -0700, Andrew Morton wrote: > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > Here is the data with 5 ext2 filesystems. I also collected /proc/meminfo > > every 5 seconds. As you can see, we seem to dirty 6GB of data in 20 > > secon

Re: Memory pressure handling with iSCSI

2005-07-26 Thread Badari Pulavarty
On Tue, 2005-07-26 at 17:31 -0700, Andrew Morton wrote: > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > On Tue, 2005-07-26 at 16:07 -0700, Andrew Morton wrote: > > > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > > > > >

Re: 2.6.24-rc4-mm1 kobject changes broken with hvcs driver on powerpc

2007-12-06 Thread Badari Pulavarty
ond > that point. I have not yet found time to debug it though. Are you running into same issue, I am getting on my machine ? Are you using IPR driver ? Thanks, Badari e100: Intel(R) PRO/100 Network Driver, 3.5.23-k4-NAPI e100: Copyright(c) 1999-2006 Intel Corporation ipr: IBM Power RAID SCSI

Re: 2.6.24-rc4-mm1 kobject changes broken with hvcs driver on powerpc

2007-12-06 Thread Badari Pulavarty
003f0dbd90] [c02f4bb0] .__pci_register_driver+0x5c/0xcc [c0003f0dbe20] [c0604b38] .ipr_init+0x38/0x50 [c0003f0dbea0] [c05d6428] .kernel_init+0x214/0x3ec [c0003f0dbf90] [c0026734] .kernel_thread+0x4c/0x68 Instruction dump: e8410028 3921 38210080 7d234b78 e801001

Re: 2.6.23-rc9: Oops in cache_alloc_refill() mm/slab.c

2007-10-04 Thread Badari Pulavarty
On Thu, 2007-10-04 at 18:13 +0200, Valerie Clement wrote: > While running ffsb tests on my ext4 filesystem, I got an Oops in > cache_alloc_refill(). > I turned on SLAB debugging and here is the message I got: > > slab: Internal list corruption detected in cache 'buffer_head'(30), > slabp 810

Re: 2.6.23-rc9: Oops in cache_alloc_refill() mm/slab.c

2007-10-05 Thread Badari Pulavarty
On Fri, 2007-10-05 at 15:41 +0200, Valerie Clement wrote: > Badari Pulavarty wrote: > > On Thu, 2007-10-04 at 18:13 +0200, Valerie Clement wrote: > >> While running ffsb tests on my ext4 filesystem, I got an Oops in > >> cache_alloc_refill(). > >> I turn

Re: [PATCH] dio: falling through to buffered I/O when invalidation of a page fails

2007-12-14 Thread Badari Pulavarty
ins the bhs while committing journal so > > try_to_release_page fails when jbd > > is committing the transaction. > > Yeah. It sure would be fantastic if some ext3 expert could stop this > from happening somehow. But that hasn't happened in.. uh.. Badari, for > how many y

[PATCH] 2.6.11-mm3 patch for ext3 writeback "nobh" option

2005-03-14 Thread Badari Pulavarty
Hi Andrew, Here is the 2.6.11-mm3 version of patch for adding "nobh" support for ext3 writeback mode. Can you include it in -mm ? Thanks, Badari diff -Narup -X dontdiff linux-2.6.11-mm3-org/fs/ext3/inode.c linux-2.6.11/fs/ext3/inode.c --- linux-2.6.11-mm3-org/fs/ext3/inode.c 2005-0

Re: [PATCH] 2.6.11-mm3 patch for ext3 writeback "nobh" option

2005-03-14 Thread Badari Pulavarty
On Mon, 2005-03-14 at 11:29, Arjan van de Ven wrote: > On Mon, 2005-03-14 at 11:18 -0800, Badari Pulavarty wrote: > > Hi Andrew, > > > > Here is the 2.6.11-mm3 version of patch for adding "nobh" > > support for ext3 writeback mode. > > can you explain w

Re: inode cache, dentry cache, buffer heads usage

2005-03-14 Thread Badari Pulavarty
On Thu, 2005-03-10 at 17:47, Andrew Morton wrote: > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > So, why is these slab cache are not getting purged/shrinked even > > under memory pressure ? (I have seen lowmem as low as 6MB). What > > can I do to keep

Re: [Ext2-devel] Re: inode cache, dentry cache, buffer heads usage

2005-03-14 Thread Badari Pulavarty
On Mon, 2005-03-14 at 14:11, Andrew Morton wrote: > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > On Thu, 2005-03-10 at 17:47, Andrew Morton wrote: > > > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > > > > > So,

Re: [Ext2-devel] Re: [PATCH] 2.6.11-mm3 patch for ext3 writeback "nobh" option

2005-03-15 Thread Badari Pulavarty
On Mon, 2005-03-14 at 18:09, Andrew Morton wrote: > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > Here is the 2.6.11-mm3 version of patch for adding "nobh" > > support for ext3 writeback mode. > > Care to update Documentation/filesystems/ext3.txt?

Re: [Ext2-devel] Re: inode cache, dentry cache, buffer heads usage

2005-03-15 Thread Badari Pulavarty
On Mon, 2005-03-14 at 14:41, Andrew Morton wrote: > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > On Mon, 2005-03-14 at 14:11, Andrew Morton wrote: > > > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > > > > > On Thu, 2005-03-

Re: [Ext2-devel] Re: [PATCH] 2.6.11-mm3 patch for ext3 writeback "nobh" option

2005-03-15 Thread Badari Pulavarty
On Tue, 2005-03-15 at 08:26, Arjan van de Ven wrote: > On Tue, 2005-03-15 at 08:09 -0800, Badari Pulavarty wrote: > > On Mon, 2005-03-14 at 18:09, Andrew Morton wrote: > > > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > > > > > Here is

2.6.10 kprobes/jprobes panic

2005-02-08 Thread Badari Pulavarty
Hi, I ran into this while playing with jprobes in 2.6.10. I tried to install jprobe handler on a invalid address, I get OOPS. I was hoping for a error check and a graceful exit rather than kernel Oops. Thanks, Badari plant jprobe at c01836b0, handler addr a080 Unable to

Re: 2.6.10 kprobes/jprobes panic

2005-02-09 Thread Badari Pulavarty
in my module, but I get # insmod myprobe.ko insmod: error inserting 'myprobe.ko': -1 Unknown symbol in module myprobe: Unknown symbol kallsyms_lookup_name How did you use it ? it looks like kallsyms_lookup_name() is not exported. Thats the reason why I was hardcoding addresses. # grep

Re: -rc3 leaking NOT BIO [Was: Memory leak in 2.6.11-rc1?]

2005-02-17 Thread Badari Pulavarty
eed to teach about kmem_cache_t structure to get it to compile and export kallsyms_lookup_name() symbol etc). Thanks, Badari #include #include #include #include MODULE_PARM_DESC(kmod, "\n"); int count = 0; void fastcall inst_kmem_cache_alloc(kmem_cache_t *cachep, int flags

[PATCH] 2.6.10 patch to export kallsyms_lookup_name()

2005-02-18 Thread Badari Pulavarty
Hi, Trivial patch to export kallsyms_lookup_name() for kprobe/jprobe module use. Please apply. (BTW, I personally don't care if it should be EXPORT_SYMBOL_GPL or EXPORT_SYMBOL). Thanks, Badari --- linux-2.6.10.org/kernel/kallsyms.c 2005-02-18 11:18:54.004259856 -0800 +++ linux-2

Re: [PATCH] 2.6.10 patch to export kallsyms_lookup_name()

2005-02-18 Thread Badari Pulavarty
On Fri, 2005-02-18 at 10:42, Christoph Hellwig wrote: > On Fri, Feb 18, 2005 at 10:29:08AM -0800, Badari Pulavarty wrote: > > Hi, > > > > Trivial patch to export kallsyms_lookup_name() for > > kprobe/jprobe module use. > > > > Please apply. > > >

[PATCH] Add nobh_writepage() support

2005-02-18 Thread Badari Pulavarty
) support for writeback mode and to add "nobh" support for ext3 writeback mode - which are based on some of this work (These are already discussed on ext2-devel). And also, this needs some airtime in -mm tree before hitting mainline. Thanks, Badari Signed-off-by: Badari Pulavarty <[EMA

[RFC][PATCH] 2.6.10 "nobh" support for ext3 writeback mode

2005-02-25 Thread Badari Pulavarty
"nobh" support. Better ideas ? calling ->prepare_write() to update the page doesn't seem to work due to journaling violations. BTW, this patch depends on my earlier patch which adds "nobh_writepage()" (currently in 2.6.11-rc4-mm1). Thanks, Badari Signed-off-by: Badar

[PATCH] 2.6.11-mm1 "nobh" support for ext3 writeback mode

2005-03-04 Thread Badari Pulavarty
Hi Andrew, Here is the 2.6.11-mm1 patch to add "nobh" support to ext3 writeback mode. Can you please add this to -mm ? BTW, this patch depends on add-writepage patch, which is in -mm tree. Thanks, Badari diff -Naurp -Xdontdiff linux-2.6.11/fs/ext3/inode.c linux-2.6.11.new/fs/ex

Re: [PATCH] 2.6.11-mm1 "nobh" support for ext3 writeback mode

2005-03-04 Thread Badari Pulavarty
On Fri, 2005-03-04 at 16:23, Andrew Morton wrote: > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > @@ -1646,13 +1659,34 @@ static int ext3_block_truncate_page(hand > > unsigned blocksize, iblock, length, pos; > > struct inode *inode = mapping->

Re: [PATCH] 2.6.11-mm1 "nobh" support for ext3 writeback mode

2005-03-04 Thread Badari Pulavarty
ill back > off. Still, it feels a bit flakey. > > And we're not supposed to take lock_page() inside journal_start, because > that's a ranking violation. Probably i_sem will prevent an actual deadlock > occurring, however. > Here is the new patch to deal with locking

Re: [PATCH] 2.6.11-mm1 "nobh" support for ext3 writeback mode

2005-03-04 Thread Badari Pulavarty
On Fri, 2005-03-04 at 16:45, Andrew Morton wrote: > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > > What's all this doing? (It needs comments please - it's very unobvious). > > > > All its trying to do is - to make sure the page is uptodate

Re: [PATCH] 2.6.11-mm1 "nobh" support for ext3 writeback mode

2005-03-04 Thread Badari Pulavarty
On Fri, 2005-03-04 at 16:45, Andrew Morton wrote: > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > > What's all this doing? (It needs comments please - it's very unobvious). > > > > All its trying to do is - to make sure the page is uptodate

Re: [Ext2-devel] [RFC] ext3/jbd race: releasing in-use journal_heads

2005-03-04 Thread Badari Pulavarty
0x1378/0x155c [jbd] lr: d00a7cd0: .journal_commit_transaction+0x1374/0x155c [jbd] sp: c0001fcc3af0 msr: 80029032 current = 0xc0002fd86b30 paca= 0xc03de000 pid = 272, comm = kjournald enter ? for help Thanks, Badari On Fri, 2005-03-04 at 11:54,

[PATCH] 2.6.11-mm1 ext3 writepages support for writeback mode

2005-03-04 Thread Badari Pulavarty
Hi Andrew, Here is the 2.6.11-mm1 patch for adding writepages support for ext3 writeback mode. Could you include it in -mm tree ? Thanks, Badari diff -Naurp -X dontdiff linux-2.6.11/fs/ext3/inode.c linux-2.6.11.new/fs/ext3/inode.c --- linux-2.6.11/fs/ext3/inode.c 2005-03-01 23:38:13.0

Re: [PATCH] 2.6.11-mm1 ext3 writepages support for writeback mode

2005-03-04 Thread Badari Pulavarty
On Fri, 2005-03-04 at 15:43, Andrew Morton wrote: > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > Hi Andrew, > > > > Here is the 2.6.11-mm1 patch for adding writepages support > > for ext3 writeback mode. Could you include it in -mm tree ? > >

Re: [PATCH] 2.6.11-mm1 "nobh" support for ext3 writeback mode

2005-03-05 Thread Badari Pulavarty
Andrew Morton wrote: Badari Pulavarty <[EMAIL PROTECTED]> wrote: iblock = index << (PAGE_CACHE_SHIFT - inode->i_sb->s_blocksize_bits); It would still be nice to add a comment in here... + if (test_opt(inode->i_sb, NOBH) && !page_has_buffers(page)) { + if (!Pag

Re: [PATCH] 2.6.10 - direct-io async short read bug

2005-03-08 Thread Badari Pulavarty
st - dio->block_in_file) << > blkbits); > > > can you spot what is going wrong here that we have to try and > workaround this later ? Andrew, please don't apply the original patch. We shouldn't even attempt to submit

Re: [PATCH] 2.6.10 - direct-io async short read bug

2005-03-08 Thread Badari Pulavarty
Anyway, here is ugly version of the patch - which will limit the IO size to filesize and uses lower blocksizes to read the file (since the filesize is only 3K, it would go down to 512 byte blocksize). Thanks, Badari --- fs/direct-io.c.org 2005-03-08 09:53:31.823761712 -0800 +++ fs/direct-io.c

Re: [PATCH] 2.6.10 - direct-io async short read bug

2005-03-08 Thread Badari Pulavarty
On Tue, 2005-03-08 at 15:27, Daniel McNeil wrote: > On Tue, 2005-03-08 at 11:18, Badari Pulavarty wrote: > > > Andrew, please don't apply the original patch. We shouldn't even attempt > > > to submit IO beyond the filesize. We should truncate the IO request to >

Re: [PATCH] 2.6.10 - direct-io async short read bug

2005-03-09 Thread Badari Pulavarty
On Tue, 2005-03-08 at 17:44, Daniel McNeil wrote: > On Tue, 2005-03-08 at 11:18, Badari Pulavarty wrote: > > > Andrew, please don't apply the original patch. We shouldn't even attempt > > > to submit IO beyond the filesize. We should truncate the IO request to >

Re: [PATCH] rwsem: Make rwsems use interrupt disabling spinlocks

2005-03-09 Thread Badari Pulavarty
Your patch seems to have helped. I don't see the Oops anymore - my tests are still running (past 1 hour - it used to panic in 10 min). Thanks, Badari On Wed, 2005-03-09 at 04:12, David Howells wrote: > The attached patch makes read/write semaphores use interrupt disabling > spin

[PATCH] 2.6.11-mm2 "nobh" support for ext3 writeback mode

2005-03-09 Thread Badari Pulavarty
Hi Andrew, Here is the simplified version of "nobh" support patch for ext3 writeback mode. I took out all the complicated logic and fallback to creating buffers in ext3_truncate_block_page() if needed. Looks sane ? Can you include it in -mm tree ? Thanks, Badari Signed-off-

inode cache, dentry cache, buffer heads usage

2005-03-09 Thread Badari Pulavarty
cache + bufferheads + Buffers. So we did 2:2 split - but it improved thing, but again run into same issues. So, why is these slab cache are not getting purged/shrinked even under memory pressure ? (I have seen lowmem as low as 6MB). What can I do to keep the machine healthy ? Thanks, Badari Meminfo

Re: [PATCH] rwsem: Make rwsems use interrupt disabling spinlocks

2005-03-09 Thread Badari Pulavarty
Hi, I am not sure if this is related to your patch. But I ran into BUG() with sysrq-t with your patch. Thanks, Badari BUG: soft lockup detected on CPU#1! Modules linked in: joydev sg st floppy usbserial parport_pc lp parport ipv6 ohci_hcd i2c_amd756 i2c_core

Re: [PATCH] rwsem: Make rwsems use interrupt disabling spinlocks

2005-03-09 Thread Badari Pulavarty
RES SHR S %CPU %MEMTIME+ COMMAND 15425 root 16 0 000 Z 99.8 0.0 172:17.98 aio-stress 15803 root 16 0 4048 1116 820 R 0.3 0.0 0:00.51 top Thanks, Badari On Wed, 2005-03-09 at 09:35, Badari Pulavarty wrote: > Your patch seems to have helped. I don&#x

Re: [PATCH] 2.6.10 - direct-io async short read bug

2005-03-09 Thread Badari Pulavarty
that gunk with an expanding truncate and > mmap() anyway. > Rest of the sector or rest of the block ? Are you implying that, we already do this, so there is no problem reading beyond EOF to user buffer ? Or we need to zero out the userbuffer beyond EOF ? Thanks, Badari - To

Re: inode cache, dentry cache, buffer heads usage

2005-03-09 Thread Badari Pulavarty
On Wed, 2005-03-09 at 13:27, Dipankar Sarma wrote: > On Wed, Mar 09, 2005 at 10:55:58AM -0800, Badari Pulavarty wrote: > > Hi, > > > > We have a 8-way P-III, 16GB RAM running 2.6.8-1. We use this as > > our server to keep source code, cscopes and do the builds. > >

Re: [PATCH] 2.6.10 - direct-io async short read bug

2005-03-09 Thread Badari Pulavarty
On Wed, 2005-03-09 at 14:39, Andrew Morton wrote: > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > On Wed, 2005-03-09 at 11:53, Andrew Morton wrote: > > > Suparna Bhattacharya <[EMAIL PROTECTED]> wrote: > > > > > > > > >

Re: [Ext2-devel] Re: OOM problems on 2.6.12-rc1 with many fsx tests

2005-03-23 Thread Badari Pulavarty
Andrew Morton wrote: "Martin J. Bligh" <[EMAIL PROTECTED]> wrote: Nothing beats poking around in a dead machine's guts with kgdb though. Everyone his taste. But I was surprised by SwapTotal: 1052216 kB SwapFree: 1045984 kB Strange that processes are killed while lots of swap is available.

Re: [Ext2-devel] Re: OOM problems on 2.6.12-rc1 with many fsx tests

2005-03-25 Thread Badari Pulavarty
which > filesystems it affects, whether it happens on UP&&!PREEMPT, etc. Not a > quick process. I reproduced *similar* issue with 2.6.11. The reason I say similar, is there is no OOM kill, but very low free memory and machine doesn't respond at all. (I booted my machine with 256M m

Re: [Ext2-devel] Re: OOM problems on 2.6.12-rc1 with many fsx tests

2005-03-25 Thread Badari Pulavarty
x27;m surprised it lasts 9hrs before it breaks. > > In the past I've done tests like.. > > for i in `seq 1 100` > do > fsx foo$i & > done > > to make each process use a different test file. > No. We are doing on different files - Mingming cut and pasted

Re: [Ext2-devel] Re: OOM problems on 2.6.12-rc1 with many fsx tests

2005-03-27 Thread Badari Pulavarty
Mingming Cao wrote: On Sat, 2005-03-26 at 16:23 -0800, Mingming Cao wrote: On Fri, 2005-03-25 at 14:11 -0800, Badari Pulavarty wrote: On Fri, 2005-03-25 at 13:56, Andrew Morton wrote: Mingming Cao <[EMAIL PROTECTED]> wrote: I run into OOM problem again on 2.6.12-rc1. I run some(20) fsx te

Re: [Ext2-devel] Re: OOM problems on 2.6.12-rc1 with many fsx tests

2005-03-27 Thread Badari Pulavarty
Badari Pulavarty wrote: Mingming Cao wrote: On Sat, 2005-03-26 at 16:23 -0800, Mingming Cao wrote: On Fri, 2005-03-25 at 14:11 -0800, Badari Pulavarty wrote: On Fri, 2005-03-25 at 13:56, Andrew Morton wrote: Mingming Cao <[EMAIL PROTECTED]> wrote: I run into OOM problem again on 2.6.12-rc1.

2.6.10-mm1 hang

2005-01-19 Thread Badari Pulavarty
o more new logins, console froze, doesn't respond to sysrq. I wasn't expecting a system hang. Why ? Ideas ? Here is the code. Thanks, Badari #include #include #include spinlock_t mylock = SPIN_LOCK_UNLOCKED; static int __init panic_init(void) { spin_lock_irq(&mylock);

Re: 2.6.10-mm1 hang

2005-01-19 Thread Badari Pulavarty
On Wed, 2005-01-19 at 14:01, linux-os wrote: > On Wed, 19 Jan 2005, Andrew Morton wrote: > > > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > >> > >> I was playing with kexec+kdump and ran into this on 2.6.10-mm1. > >> I have seen similar behaviour o

Re: 2.6.10-mm1 hang

2005-01-20 Thread Badari Pulavarty
. You may be right on other CPUs stuck on IPI. Thanks, Badari On Wed, 2005-01-19 at 13:31, Andrew Morton wrote: > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > I was playing with kexec+kdump and ran into this on 2.6.10-mm1. > > I have seen similar behaviour

Re: [PATCH] Add IORESOUCE_BUSY flag for System RAM (Re: [Question] How to represent SYSTEM_RAM in kerenel/resouce.c)

2007-11-01 Thread Badari Pulavarty
; > if (request_resource(&iomem_resource, res) < 0) { > printk("System RAM resource %llx - %llx cannot be added\n", > (unsigned long long)res->start, (unsigned long long)res->end); > Not quite.. You need following patch on

Re: [PATCH] hugetlbfs read() support

2007-07-20 Thread Badari Pulavarty
On Fri, 2007-07-20 at 14:29 +1000, Nick Piggin wrote: > Andrew Morton wrote: > > On Thu, 19 Jul 2007 08:51:49 -0700 Badari Pulavarty <[EMAIL PROTECTED]> > > wrote: > > > > > >>>>+ } > >>>>+ > >>>>+

Re: [PATCH] add check do_direct_IO() return val

2007-07-30 Thread Badari Pulavarty
. Which is still many weeks away so there > is > plenty of time to prepare something which was carefully reviewed and > well-tested, > thanks. I am also taking a look at it right now. Unfortunately, I don't think fix is that simple - since we need to return success, in case of a parti

Re: [PATCH] add check do_direct_IO() return val

2007-07-30 Thread Badari Pulavarty
e done. Thanks, Badari - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] add check do_direct_IO() return val

2007-07-30 Thread Badari Pulavarty
On Mon, 2007-07-30 at 16:38 -0700, Zach Brown wrote: > On Jul 30, 2007, at 2:58 PM, Badari Pulavarty wrote: > > > On Mon, 2007-07-30 at 14:45 -0700, Zach Brown wrote: > >>> I am also taking a look at it right now. > >> > >> Are we having a race to w

Re: [PATCH] add check do_direct_IO() return val

2007-07-30 Thread Badari Pulavarty
On Mon, 2007-07-30 at 16:38 -0700, Zach Brown wrote: > On Jul 30, 2007, at 2:58 PM, Badari Pulavarty wrote: > > > On Mon, 2007-07-30 at 14:45 -0700, Zach Brown wrote: > >>> I am also taking a look at it right now. > >> > >> Are we having a race to w

Re: [PATCH] add check do_direct_IO() return val

2007-07-31 Thread Badari Pulavarty
IO size < blocksize case). It checks if the buffer is newly allocation by doing buffer_new(bh). map_bh is NOT initialized and never went through get_block() code. So, its possible to pass the check and end up submitting a page wrongly and causing the oops. Fix is to initialize the buffer

Re: [PATCH] add check do_direct_IO() return val

2007-07-31 Thread Badari Pulavarty
On Tue, 2007-07-31 at 15:34 -0700, Andrew Morton wrote: > On Tue, 31 Jul 2007 15:25:11 -0700 > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > + dio->map_bh.b_state = 0; > > ho hum, thanks. > > We zero out so many fields in there now that a kzalloc() mig

Re: 2.6.23-git11 compile issues

2007-10-17 Thread Badari Pulavarty
On Wed, 2007-10-17 at 18:38 +0300, Ismail Dönmez wrote: > Wednesday 17 October 2007 Tarihinde 18:33:18 yazmıştı: > > Known issue ? > > > > > > Thanks, > > Badari > > > > CHK include/linux/version.h > > CHK include/linux/utsrelease.h

[PATCH] ip_gra_reasm() should set "err" incase of skb_clone() failure

2007-10-17 Thread Badari Pulavarty
Simple error handling fix (against 2.26.23-git12). Thanks, Badari Need to initialize "err" in case of skb_clone() failure. net/ipv4/ip_fragment.c: In function `ip_defrag': net/ipv4/ip_fragment.c:540: warning: `err' might be used uninitialized in this function Signed-off-

[PATCH] Move _rtc_time() routines under CONFIG_ADB_CUDA

2007-10-17 Thread Badari Pulavarty
Fix to clean up compile warnings (against 2.6.23-git12) Thanks, Badari to_rtc_time() and from_rtc_time() seems to be used only if CONFIG_ADB_CUDA defined. Moving them under that ifdef. arch/powerpc/platforms/powermac/time.c:88: warning: `to_rtc_time' defined but not used arch/powerpc/plat

[PATCH] vortex_up should initialize "err"

2007-10-17 Thread Badari Pulavarty
Simple compile warning fix. (against 2.6.23-git12) Thanks, Badari vortex_up() should initialize 'err' for a successful return. drivers/net/3c59x.c: In function `vortex_up': drivers/net/3c59x.c:1494: warning: `err' might be used uninitialized in this function Signed-off-

Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - build fails on powerpc

2007-11-06 Thread Badari Pulavarty
gt; > The above patch causes the build failure, because the from_rtc_time() and > to_rtc_time() are > moved under the ifdef CONFIG_ADB_CUDA, but they are begin called in the > pmu_set_rtc_time() and > pmac_get_rtc_time() under CONFIG_ADB_PMU. Yes. My fault. This patch needs to be dropp

Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - build failure - rpadlpar_sysfs

2007-11-06 Thread Badari Pulavarty
; make[2]: *** [drivers/pci/hotplug] Error 2 > make[1]: *** [drivers/pci] Error 2 > make: *** [drivers] Error 2 > > The patch, > gregkh-driver-kset-convert-pci-hotplug-to-use-kset_create_and_register.patch > is causing the build failure. Here is the fix (against 24-rc1 mm-broke

Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded

2007-11-06 Thread Badari Pulavarty
t-in.o(.toc+0x1548): undefined reference to `devices_subsys' make: *** [.tmp_vmlinux1] Error 1 Here is the patch, Is this correct usage ? Thanks, Badari --- arch/powerpc/kernel/vio.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6.24-rc1/ar

  1   2   3   >