Re: [PATCH 11/18] thermal: exynos: add exynos*_tmu_set_[trip,hyst]() helpers

2018-05-02 Thread Bartlomiej Zolnierkiewicz
On Tuesday, May 01, 2018 11:55:40 AM Daniel Lezcano wrote: > On Thu, Apr 26, 2018 at 01:51:26PM +0200, Bartlomiej Zolnierkiewicz wrote: > > Add exynos*_tmu_set_[trip,hyst]() helpers and convert > > all ->tmu_initialize implementations accordingly. > > > > Signed-off

Re: [PATCH 11/18] thermal: exynos: add exynos*_tmu_set_[trip,hyst]() helpers

2018-05-02 Thread Bartlomiej Zolnierkiewicz
On Tuesday, May 01, 2018 11:55:40 AM Daniel Lezcano wrote: > On Thu, Apr 26, 2018 at 01:51:26PM +0200, Bartlomiej Zolnierkiewicz wrote: > > Add exynos*_tmu_set_[trip,hyst]() helpers and convert > > all ->tmu_initialize implementations accordingly. > > > > Signed-off

Re: [PATCH 06/18] thermal: exynos: fix trips limit checking in get_th_reg()

2018-05-02 Thread Bartlomiej Zolnierkiewicz
On Tuesday, May 01, 2018 11:39:14 AM Daniel Lezcano wrote: > On Mon, Apr 30, 2018 at 05:48:29PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On Monday, April 30, 2018 05:34:31 PM Daniel Lezcano wrote: > > > On Thu, Apr 26, 2018 at 01:51:21PM +0200, Bartlomiej Zo

Re: [PATCH 06/18] thermal: exynos: fix trips limit checking in get_th_reg()

2018-05-02 Thread Bartlomiej Zolnierkiewicz
On Tuesday, May 01, 2018 11:39:14 AM Daniel Lezcano wrote: > On Mon, Apr 30, 2018 at 05:48:29PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On Monday, April 30, 2018 05:34:31 PM Daniel Lezcano wrote: > > > On Thu, Apr 26, 2018 at 01:51:21PM +0200, Bartlomiej Zo

Re: [PATCH 03/18] thermal: exynos: always check for critical trip points existence

2018-05-02 Thread Bartlomiej Zolnierkiewicz
On Tuesday, May 01, 2018 11:00:18 AM Daniel Lezcano wrote: > On Mon, Apr 30, 2018 at 05:24:15PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On Monday, April 30, 2018 04:44:50 PM Daniel Lezcano wrote: > > > On Thu, Apr 26, 2018 at 01:51:18PM +0200, Bartlomiej Zolnierkiewicz wrot

Re: [PATCH 03/18] thermal: exynos: always check for critical trip points existence

2018-05-02 Thread Bartlomiej Zolnierkiewicz
On Tuesday, May 01, 2018 11:00:18 AM Daniel Lezcano wrote: > On Mon, Apr 30, 2018 at 05:24:15PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On Monday, April 30, 2018 04:44:50 PM Daniel Lezcano wrote: > > > On Thu, Apr 26, 2018 at 01:51:18PM +0200, Bartlomiej Zolnierkiewicz wrot

Re: [PATCH 06/18] thermal: exynos: fix trips limit checking in get_th_reg()

2018-04-30 Thread Bartlomiej Zolnierkiewicz
On Monday, April 30, 2018 05:34:31 PM Daniel Lezcano wrote: > On Thu, Apr 26, 2018 at 01:51:21PM +0200, Bartlomiej Zolnierkiewicz wrote: > > of_thermal_get_ntrips() may return value bigger than supported > > by a given SoC (i.e. on Exynos5422/5800) > > Can you elaborate a

Re: [PATCH 06/18] thermal: exynos: fix trips limit checking in get_th_reg()

2018-04-30 Thread Bartlomiej Zolnierkiewicz
On Monday, April 30, 2018 05:34:31 PM Daniel Lezcano wrote: > On Thu, Apr 26, 2018 at 01:51:21PM +0200, Bartlomiej Zolnierkiewicz wrote: > > of_thermal_get_ntrips() may return value bigger than supported > > by a given SoC (i.e. on Exynos5422/5800) > > Can you elaborate a

Re: [PATCH] video: fbdev: omap2: remove rfbi

2018-04-30 Thread Bartlomiej Zolnierkiewicz
On Friday, April 27, 2018 09:25:37 PM Aaro Koskinen wrote: > Hi, > > On Fri, Apr 27, 2018 at 05:09:14PM +0200, Bartlomiej Zolnierkiewicz wrote: > > omapfb equivalent of drm's commit aa61321d4c08 ("drm/omap: remove rfbi"): > > > > The RFBI driver has n

Re: [PATCH] video: fbdev: omap2: remove rfbi

2018-04-30 Thread Bartlomiej Zolnierkiewicz
On Friday, April 27, 2018 09:25:37 PM Aaro Koskinen wrote: > Hi, > > On Fri, Apr 27, 2018 at 05:09:14PM +0200, Bartlomiej Zolnierkiewicz wrote: > > omapfb equivalent of drm's commit aa61321d4c08 ("drm/omap: remove rfbi"): > > > > The RFBI driver has n

Re: [PATCH 03/18] thermal: exynos: always check for critical trip points existence

2018-04-30 Thread Bartlomiej Zolnierkiewicz
On Monday, April 30, 2018 04:44:50 PM Daniel Lezcano wrote: > On Thu, Apr 26, 2018 at 01:51:18PM +0200, Bartlomiej Zolnierkiewicz wrote: > > * Check for critical trip point existence in exynos_tmu_initialize() > > so it is checked on all SoCs (except Exynos5433 for now). &

Re: [PATCH 03/18] thermal: exynos: always check for critical trip points existence

2018-04-30 Thread Bartlomiej Zolnierkiewicz
On Monday, April 30, 2018 04:44:50 PM Daniel Lezcano wrote: > On Thu, Apr 26, 2018 at 01:51:18PM +0200, Bartlomiej Zolnierkiewicz wrote: > > * Check for critical trip point existence in exynos_tmu_initialize() > > so it is checked on all SoCs (except Exynos5433 for now). &

Re: [PATCH 01/18] thermal: exynos: fix setting rising_threshold for Exynos5433

2018-04-30 Thread Bartlomiej Zolnierkiewicz
On Monday, April 30, 2018 04:36:56 PM Daniel Lezcano wrote: > On Thu, Apr 26, 2018 at 01:51:16PM +0200, Bartlomiej Zolnierkiewicz wrote: > > Add missing clearing of the previous value when setting rising > > temperature threshold. > > > > Signed-off-by: Bartlomie

Re: [PATCH 01/18] thermal: exynos: fix setting rising_threshold for Exynos5433

2018-04-30 Thread Bartlomiej Zolnierkiewicz
On Monday, April 30, 2018 04:36:56 PM Daniel Lezcano wrote: > On Thu, Apr 26, 2018 at 01:51:16PM +0200, Bartlomiej Zolnierkiewicz wrote: > > Add missing clearing of the previous value when setting rising > > temperature threshold. > > > > Signed-off-by

Re: [PATCH] video: fbdev: omap2: remove rfbi

2018-04-27 Thread Bartlomiej Zolnierkiewicz
On Friday, April 27, 2018 08:47:14 PM Aaro Koskinen wrote: > Hi, > > On Fri, Apr 27, 2018 at 05:09:14PM +0200, Bartlomiej Zolnierkiewicz wrote: > > omapfb equivalent of drm's commit aa61321d4c08 ("drm/omap: remove rfbi"): > > > > The RFBI driver has n

Re: [PATCH] video: fbdev: omap2: remove rfbi

2018-04-27 Thread Bartlomiej Zolnierkiewicz
On Friday, April 27, 2018 08:47:14 PM Aaro Koskinen wrote: > Hi, > > On Fri, Apr 27, 2018 at 05:09:14PM +0200, Bartlomiej Zolnierkiewicz wrote: > > omapfb equivalent of drm's commit aa61321d4c08 ("drm/omap: remove rfbi"): > > > > The RFBI driver has n

[PATCH] video: fbdev: omap2: remove rfbi

2018-04-27 Thread Bartlomiej Zolnierkiewicz
Cc: Tomi Valkeinen <tomi.valkei...@ti.com> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/video/fbdev/omap2/omapfb/dss/Kconfig | 13 drivers/video/fbdev/omap2/omapfb/dss/Makefile |1 driv

[PATCH] video: fbdev: omap2: remove rfbi

2018-04-27 Thread Bartlomiej Zolnierkiewicz
Cc: Tomi Valkeinen Cc: Laurent Pinchart Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/omap2/omapfb/dss/Kconfig | 13 drivers/video/fbdev/omap2/omapfb/dss/Makefile |1 drivers/video/fbdev/omap2/omapfb/dss/core.c |6 drivers/video/fbdev/omap2/omapfb/dss/dss.h|4

[PATCH 3/3] video: fbdev: remove unused sh_mobile_meram driver

2018-04-27 Thread Bartlomiej Zolnierkiewicz
...@glider.be> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/video/fbdev/Kconfig | 12 - drivers/video/fbdev/Makefile | 1 - drivers/video/fbdev/sh_mobile_meram.c | 754 -- include/video/sh_mobile_meram.h

[PATCH 3/3] video: fbdev: remove unused sh_mobile_meram driver

2018-04-27 Thread Bartlomiej Zolnierkiewicz
Since commit a521422ea4ae ("ARM: shmobile: mackerel: Remove Legacy C board code") MERAM functionality is unused. Remove it. Cc: Simon Horman Cc: Laurent Pinchart Cc: Geert Uytterhoeven Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/Kconfig | 12 - dri

[PATCH 2/3] drm: shmobile: remove unused MERAM support

2018-04-27 Thread Bartlomiej Zolnierkiewicz
...@glider.be> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/gpu/drm/shmobile/Kconfig | 1 - drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 42 -- drivers/gpu/drm/shmobile/shmob_drm_crtc.h | 1 - drivers/gpu/drm/shmobile/shmo

[PATCH 1/3] video: fbdev: sh_mobile_lcdcfb: remove unused MERAM support

2018-04-27 Thread Bartlomiej Zolnierkiewicz
...@glider.be> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/video/fbdev/Kconfig| 1 - drivers/video/fbdev/sh_mobile_lcdcfb.c | 63 +- drivers/video/fbdev/sh_mobile_lcdcfb.h | 1 - include/video/sh_mobile_lcdc.h

[PATCH 2/3] drm: shmobile: remove unused MERAM support

2018-04-27 Thread Bartlomiej Zolnierkiewicz
Since commit a521422ea4ae ("ARM: shmobile: mackerel: Remove Legacy C board code") MERAM functionality is unused. Remove it. Cc: Simon Horman Cc: Laurent Pinchart Cc: Geert Uytterhoeven Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/gpu/drm/shmobile/Kconfig | 1

[PATCH 1/3] video: fbdev: sh_mobile_lcdcfb: remove unused MERAM support

2018-04-27 Thread Bartlomiej Zolnierkiewicz
Since commit a521422ea4ae ("ARM: shmobile: mackerel: Remove Legacy C board code") MERAM functionality is unused. Remove it. Cc: Simon Horman Cc: Laurent Pinchart Cc: Geert Uytterhoeven Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/Kconfig| 1 - dri

[PATCH 0/3] fbdev/drm: sh_mobile: remove unused MERAM support

2018-04-27 Thread Bartlomiej Zolnierkiewicz
both upstream (v4.18) I will apply patch #3 to fbdev tree. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics Bartlomiej Zolnierkiewicz (3): video: fbdev: sh_mobile_lcdcfb: remove unused MERAM support drm: shmobile: remove unused MERAM support video: f

[PATCH 0/3] fbdev/drm: sh_mobile: remove unused MERAM support

2018-04-27 Thread Bartlomiej Zolnierkiewicz
both upstream (v4.18) I will apply patch #3 to fbdev tree. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics Bartlomiej Zolnierkiewicz (3): video: fbdev: sh_mobile_lcdcfb: remove unused MERAM support drm: shmobile: remove unused MERAM support video: f

[PATCH] video: fbdev: remove unused auo_k190xfb drivers

2018-04-27 Thread Bartlomiej Zolnierkiewicz
uot;video: auo_k190x: add driver for AUO-K1901 variant") They never had any in-kernel user so just remove them (since they are platform drivers they need corresponding platform devices to be registered by kernel and it has never happened). Cc: Heiko Stübner <he...@sntech.de> Signed-off-by:

[PATCH] video: fbdev: remove unused auo_k190xfb drivers

2018-04-27 Thread Bartlomiej Zolnierkiewicz
uot;video: auo_k190x: add driver for AUO-K1901 variant") They never had any in-kernel user so just remove them (since they are platform drivers they need corresponding platform devices to be registered by kernel and it has never happened). Cc: Heiko Stübner Signed-off-by: Bartlomiej Zolnierkie

[PATCH 02/18] thermal: exynos: always check for trips points existence

2018-04-26 Thread Bartlomiej Zolnierkiewicz
h_reg(). Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c ind

[PATCH 02/18] thermal: exynos: always check for trips points existence

2018-04-26 Thread Bartlomiej Zolnierkiewicz
h_reg(). Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 523d26e..9e040eb 100644 -

[PATCH 05/18] thermal: exynos: use sanitize_temp_error() in exynos7_tmu_initialize()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Fix sanitize_temp_error() to handle Exynos7 SoCs and then use it in exynos7_tmu_initialize(). There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 13 ++---

[PATCH 05/18] thermal: exynos: use sanitize_temp_error() in exynos7_tmu_initialize()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Fix sanitize_temp_error() to handle Exynos7 SoCs and then use it in exynos7_tmu_initialize(). There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 13 ++--- 1 file changed, 6 insertions(+), 7

[PATCH 06/18] thermal: exynos: fix trips limit checking in get_th_reg()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
of_thermal_get_ntrips() may return value bigger than supported by a given SoC (i.e. on Exynos5422/5800) so fix the code to not iterate the loop for i values >= data->ntrip. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <

[PATCH 01/18] thermal: exynos: fix setting rising_threshold for Exynos5433

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Add missing clearing of the previous value when setting rising temperature threshold. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/d

[PATCH 01/18] thermal: exynos: fix setting rising_threshold for Exynos5433

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Add missing clearing of the previous value when setting rising temperature threshold. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung

[PATCH 06/18] thermal: exynos: fix trips limit checking in get_th_reg()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
of_thermal_get_ntrips() may return value bigger than supported by a given SoC (i.e. on Exynos5422/5800) so fix the code to not iterate the loop for i values >= data->ntrip. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/t

[PATCH 07/18] thermal: exynos: remove threshold_code checking from exynos4210_tmu_initialize()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
On Exynos4210 one-point trimming is always used and data->temp_error1 is equal to 75. Therefore temp_to_code() will never return negative value for the reference temperature conversion. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiew

[PATCH 07/18] thermal: exynos: remove threshold_code checking from exynos4210_tmu_initialize()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
On Exynos4210 one-point trimming is always used and data->temp_error1 is equal to 75. Therefore temp_to_code() will never return negative value for the reference temperature conversion. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiew

[PATCH 08/18] thermal: exynos: make ->tmu_initialize method void

2018-04-26 Thread Bartlomiej Zolnierkiewicz
All implementations of ->tmu_initialize always return 0 so make the method void and convert all implementations accordingly. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/exy

[PATCH 08/18] thermal: exynos: make ->tmu_initialize method void

2018-04-26 Thread Bartlomiej Zolnierkiewicz
All implementations of ->tmu_initialize always return 0 so make the method void and convert all implementations accordingly. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c |

[PATCH 14/18] thermal: exynos: move trips setting to exynos_tmu_initialize()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
ed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 88 +++- 1 file changed, 37 insertions(+), 51 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c i

[PATCH 14/18] thermal: exynos: move trips setting to exynos_tmu_initialize()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
ed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 88 +++- 1 file changed, 37 insertions(+), 51 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 571511f..244aaf6

[PATCH 10/18] thermal: exynos: move IRQs clearing to exynos_tmu_initialize()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Move ->tmu_clear_irqs call from ->tmu_initialize method to exynos_tmu_initialize(). There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 12 +++- 1 fil

[PATCH 10/18] thermal: exynos: move IRQs clearing to exynos_tmu_initialize()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Move ->tmu_clear_irqs call from ->tmu_initialize method to exynos_tmu_initialize(). There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 12 +++- 1 file changed, 3 insertions(+), 9 del

[PATCH 11/18] thermal: exynos: add exynos*_tmu_set_[trip,hyst]() helpers

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Add exynos*_tmu_set_[trip,hyst]() helpers and convert all ->tmu_initialize implementations accordingly. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 282 +-- 1 file changed, 140 insertion

[PATCH 11/18] thermal: exynos: add exynos*_tmu_set_[trip,hyst]() helpers

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Add exynos*_tmu_set_[trip,hyst]() helpers and convert all ->tmu_initialize implementations accordingly. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 282 +-- 1 file changed, 140 insertions(+), 142 deletions(-) diff --

[PATCH 16/18] thermal: exynos: cleanup code for enabling threshold interrupts

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Cleanup code for enabling threshold interrupts in ->tmu_control method implementations. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/exynos_tm

[PATCH 16/18] thermal: exynos: cleanup code for enabling threshold interrupts

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Cleanup code for enabling threshold interrupts in ->tmu_control method implementations. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 101 --- 1 file changed,

[PATCH 12/18] thermal: exynos: do not use trips structure directly in ->tmu_initialize

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Use ->get_trip_[temp,hyst] methods instead of using trips structure directly in all ->tmu_initialize method implementations. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/

[PATCH 13/18] thermal: exynos: set trips in ascending order in exynos7_tmu_initialize()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Set trips in ascending order in exynos7_tmu_initialize() (it should make no difference in driver operation). This prepares the driver code to moving trips setting from ->tmu_initialize method to exynos_tmu_initialize(). Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsu

[PATCH 12/18] thermal: exynos: do not use trips structure directly in ->tmu_initialize

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Use ->get_trip_[temp,hyst] methods instead of using trips structure directly in all ->tmu_initialize method implementations. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 18 ---

[PATCH 13/18] thermal: exynos: set trips in ascending order in exynos7_tmu_initialize()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Set trips in ascending order in exynos7_tmu_initialize() (it should make no difference in driver operation). This prepares the driver code to moving trips setting from ->tmu_initialize method to exynos_tmu_initialize(). Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/sams

[PATCH 15/18] thermal: exynos: check return values of ->get_trip_[temp,hyst] methods

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Check return values of ->get_trip_[temp,hyst] methods in exynos_tmu_initialize(). Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/therma

[PATCH 17/18] thermal: exynos: remove unused defines for Exynos5433

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Remove unused defines for Exynos5433. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/thermal/s

[PATCH 15/18] thermal: exynos: check return values of ->get_trip_[temp,hyst] methods

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Check return values of ->get_trip_[temp,hyst] methods in exynos_tmu_initialize(). Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/driv

[PATCH 17/18] thermal: exynos: remove unused defines for Exynos5433

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Remove unused defines for Exynos5433. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal

[PATCH 18/18] thermal: exynos: remove trip reporting to user-space

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Remove trip reporting to user-space - I'm not aware of any user-space program which relies on it and there is a thermal user-space governor which does it in proper way nowadays. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/exynos_tmu.

[PATCH 03/18] thermal: exynos: always check for critical trip points existence

2018-04-26 Thread Bartlomiej Zolnierkiewicz
s4412_tmu_initialize(). Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tm

[PATCH 18/18] thermal: exynos: remove trip reporting to user-space

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Remove trip reporting to user-space - I'm not aware of any user-space program which relies on it and there is a thermal user-space governor which does it in proper way nowadays. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 30

[PATCH 03/18] thermal: exynos: always check for critical trip points existence

2018-04-26 Thread Bartlomiej Zolnierkiewicz
s4412_tmu_initialize(). Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 9e040eb..a0c1604

[PATCH 00/18] thermal: exynos: further fixes and cleanups

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Exynos4210 based Trats board and Exynos5422 based Odroid-XU3 Lite board. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics Bartlomiej Zolnierkiewicz (18): thermal: exynos: fix setting rising_threshold for Exynos5433 thermal: exynos: always che

[PATCH 04/18] thermal: exynos: check STATUS register in exynos_tmu_initialize()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
STATUS register is present on all SoCs so move its checking into exynos_tmu_initialize(). There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/exynos_tmu.

[PATCH 09/18] thermal: exynos: clear IRQs later in exynos4412_tmu_initialize()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Clear IRQs after enabling thermal tripping (it should make no difference in driver operation). This prepares the driver code to moving IRQs clearing call from ->tmu_initialize method to exynos_tmu_initialize(). Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> ---

[PATCH 09/18] thermal: exynos: clear IRQs later in exynos4412_tmu_initialize()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Clear IRQs after enabling thermal tripping (it should make no difference in driver operation). This prepares the driver code to moving IRQs clearing call from ->tmu_initialize method to exynos_tmu_initialize(). Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tm

[PATCH 00/18] thermal: exynos: further fixes and cleanups

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Exynos4210 based Trats board and Exynos5422 based Odroid-XU3 Lite board. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics Bartlomiej Zolnierkiewicz (18): thermal: exynos: fix setting rising_threshold for Exynos5433 thermal: exynos: always che

[PATCH 04/18] thermal: exynos: check STATUS register in exynos_tmu_initialize()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
STATUS register is present on all SoCs so move its checking into exynos_tmu_initialize(). There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 45 +++- 1 file changed, 13

[PATCH] thermal: samsung: Remove support for Exynos5440

2018-04-26 Thread Bartlomiej Zolnierkiewicz
ed-off-by: Krzysztof Kozlowski <k...@kernel.org> [b.zolnierkie: ported over driver changes] Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- Eduardo, here is a version which applies on top of pending Exynos thermal changes (https://lkml.org/lkml/2018/4/16/256

[PATCH] thermal: samsung: Remove support for Exynos5440

2018-04-26 Thread Bartlomiej Zolnierkiewicz
Kozlowski [b.zolnierkie: ported over driver changes] Signed-off-by: Bartlomiej Zolnierkiewicz --- Eduardo, here is a version which applies on top of pending Exynos thermal changes (https://lkml.org/lkml/2018/4/16/256). Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 14 drivers

Re: [PATCH 2/3] video: omap: Improve a size determination in omapfb_do_probe()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
ator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Patch queued for 4.18,

Re: [PATCH 2/3] video: omap: Improve a size determination in omapfb_do_probe()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
ding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH 2/4] video: sm501fb: Improve a size determination in sm501fb_probe()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
ator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Hand applied and q

Re: [PATCH 2/4] video: sm501fb: Improve a size determination in sm501fb_probe()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
ding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Hand applied and queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH 2/2] video: fbdev-MMP: Improve a size determination in path_init()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
ator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Patch queued for 4.18,

Re: [PATCH 2/2] video: fbdev-MMP: Improve a size determination in path_init()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
ding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH 1/2] video: fbdev-MMP: Delete an error message for a failed memory allocation in two functions

2018-04-26 Thread Bartlomiej Zolnierkiewicz
by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> I've done requested audit regarding multiple fb devices support myself now and it is okay to apply this patch. Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewic

Re: [PATCH 1/2] video: fbdev-MMP: Delete an error message for a failed memory allocation in two functions

2018-04-26 Thread Bartlomiej Zolnierkiewicz
t; Signed-off-by: Markus Elfring I've done requested audit regarding multiple fb devices support myself now and it is okay to apply this patch. Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH] video: auo_k190x: Delete an error message for a failed memory allocation in auok190x_common_probe()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> I've done requested audit regarding multiple fb devices support myself now and it is okay to apply this patch. Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewic

Re: [PATCH] video: auo_k190x: Delete an error message for a failed memory allocation in auok190x_common_probe()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
t; Signed-off-by: Markus Elfring I've done requested audit regarding multiple fb devices support myself now and it is okay to apply this patch. Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH] video: sh_mobile_meram: Delete an error message for a failed memory allocation in sh_mobile_meram_probe()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> I've done requested audit regarding multiple fb devices support myself now and it is okay to apply this patch. Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewic

Re: [PATCH] video: sh_mobile_meram: Delete an error message for a failed memory allocation in sh_mobile_meram_probe()

2018-04-26 Thread Bartlomiej Zolnierkiewicz
t; Signed-off-by: Markus Elfring I've done requested audit regarding multiple fb devices support myself now and it is okay to apply this patch. Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH] video: sh_mobile_lcdcfb: Delete an error message for a failed memory allocation in two functions

2018-04-26 Thread Bartlomiej Zolnierkiewicz
by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> I've done requested audit regarding multiple fb devices support myself now and it is okay to apply this patch. Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewic

Re: [PATCH] video: sh_mobile_lcdcfb: Delete an error message for a failed memory allocation in two functions

2018-04-26 Thread Bartlomiej Zolnierkiewicz
t; Signed-off-by: Markus Elfring I've done requested audit regarding multiple fb devices support myself now and it is okay to apply this patch. Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [RFC 06/10] thermal: samsung: Remove support for Exynos5440

2018-04-25 Thread Bartlomiej Zolnierkiewicz
y: Krzysztof Kozlowski <k...@kernel.org> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [RFC 06/10] thermal: samsung: Remove support for Exynos5440

2018-04-25 Thread Bartlomiej Zolnierkiewicz
y: Krzysztof Kozlowski Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH 58/61] video: fbdev: omap2: omapfb: displays: simplify getting .drvdata

2018-04-24 Thread Bartlomiej Zolnierkiewicz
nks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH 58/61] video: fbdev: omap2: omapfb: displays: simplify getting .drvdata

2018-04-24 Thread Bartlomiej Zolnierkiewicz
On Thursday, April 19, 2018 04:06:28 PM Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewi

Re: [PATCH 57/61] video: fbdev: simplify getting .drvdata

2018-04-24 Thread Bartlomiej Zolnierkiewicz
nks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH 57/61] video: fbdev: simplify getting .drvdata

2018-04-24 Thread Bartlomiej Zolnierkiewicz
On Thursday, April 19, 2018 04:06:27 PM Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewi

Re: [PATCH] video: fbdev: aty: radeon_pm: Replace mdelay with msleep in radeonfb_pci_suspend

2018-04-24 Thread Bartlomiej Zolnierkiewicz
ually check it. > > Signed-off-by: Jia-Ju Bai <baijiaju1...@gmail.com> Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH] video: fbdev: aty: radeon_pm: Replace mdelay with msleep in radeonfb_pci_suspend

2018-04-24 Thread Bartlomiej Zolnierkiewicz
ually check it. > > Signed-off-by: Jia-Ju Bai Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH] video: fbdev: aty: aty128fb: Replace mdelay with msleep in aty128_set_suspend

2018-04-24 Thread Bartlomiej Zolnierkiewicz
found by a static analysis tool named DCNS written by myself. > And I also manually check it. > > Signed-off-by: Jia-Ju Bai <baijiaju1...@gmail.com> Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH] video: fbdev: aty: aty128fb: Replace mdelay with msleep in aty128_set_suspend

2018-04-24 Thread Bartlomiej Zolnierkiewicz
found by a static analysis tool named DCNS written by myself. > And I also manually check it. > > Signed-off-by: Jia-Ju Bai Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH] video: fbdev: savage: Replace mdelay with usleep_range in savage_init_hw

2018-04-24 Thread Bartlomiej Zolnierkiewicz
() to busily wait. > This is not necessary and can be replaced with usleep_range to > avoid busy waiting. > > This is found by a static analysis tool named DCNS written by myself. > And I also manually check it. > > Signed-off-by: Jia-Ju Bai <baijiaju1...@gmail.com> Patch queued

Re: [PATCH] video: fbdev: savage: Replace mdelay with usleep_range in savage_init_hw

2018-04-24 Thread Bartlomiej Zolnierkiewicz
() to busily wait. > This is not necessary and can be replaced with usleep_range to > avoid busy waiting. > > This is found by a static analysis tool named DCNS written by myself. > And I also manually check it. > > Signed-off-by: Jia-Ju Bai Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH 10/15] ata: pata_pxa: remove the dmaengine compat need

2018-04-24 Thread Bartlomiej Zolnierkiewicz
; > priority are not needed anymore. > > > > This patch simplifies the dma resource acquisition, using the more > > generic function dma_request_slave_channel(). > > > > Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> > > Bartlomiej, could I have

Re: [PATCH 10/15] ata: pata_pxa: remove the dmaengine compat need

2018-04-24 Thread Bartlomiej Zolnierkiewicz
more. > > > > This patch simplifies the dma resource acquisition, using the more > > generic function dma_request_slave_channel(). > > > > Signed-off-by: Robert Jarzmik > > Bartlomiej, could I have your ack please ? Sure. Acked-by: Bartlomiej Zolnierki

Re: [GIT PULL V3] Thermal SoC management updates for v4.17-rc1

2018-04-19 Thread Bartlomiej Zolnierkiewicz
you to fetch changes up to > > > 15a32df1918259be6c23fc36014fc26ee66c836c: > > > > > > Â dt-bindings: thermal: Remove "cooling-{min|max}-level" properties > > > (2018-04-14 09:37:55 -0700) > > > > > This pull request does not catch this merge window. >

Re: [GIT PULL V3] Thermal SoC management updates for v4.17-rc1

2018-04-19 Thread Bartlomiej Zolnierkiewicz
you to fetch changes up to > > > 15a32df1918259be6c23fc36014fc26ee66c836c: > > > > > > Â dt-bindings: thermal: Remove "cooling-{min|max}-level" properties > > > (2018-04-14 09:37:55 -0700) > > > > > This pull request does not catch this merge window. >

Re: [PATCH 12/14] thermal: exynos: remove separate exynos_tmu.h header file

2018-04-16 Thread Bartlomiej Zolnierkiewicz
On Monday, April 16, 2018 03:24:57 PM Daniel Lezcano wrote: > On 16/04/2018 12:12, Bartlomiej Zolnierkiewicz wrote: > > exynos_tmu.h is used only by exynos_tmu.c so there is no need > > for a separate include file. > > > > There should be no functional c

Re: [PATCH 12/14] thermal: exynos: remove separate exynos_tmu.h header file

2018-04-16 Thread Bartlomiej Zolnierkiewicz
On Monday, April 16, 2018 03:24:57 PM Daniel Lezcano wrote: > On 16/04/2018 12:12, Bartlomiej Zolnierkiewicz wrote: > > exynos_tmu.h is used only by exynos_tmu.c so there is no need > > for a separate include file. > > > > There should be no functional c

<    1   2   3   4   5   6   7   8   9   10   >