[GIT PULL] Btrfs

2015-11-06 Thread Chris Mason
out of dev_replace lock range Shan Hai (1) commits (+0/-3): btrfs/file.c: remove an unsed varialbe first_index Chris Mason (1) commits (+3/-5): btrfs: fix use after free iterating extrefs Robin Ruede (1) commits (+8/-2): btrfs: fix resending received snapshot with parent Geliang Tang (1) commits

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-16 Thread Chris Mason
On Mon, Sep 14, 2015 at 01:06:25PM -0700, Linus Torvalds wrote: > On Sun, Sep 13, 2015 at 4:12 PM, Dave Chinner wrote: > > > > Really need to run these numbers on slower disks where block layer > > merging makes a difference to performance. > > Yeah. We've seen plugging and io schedulers not

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-16 Thread Chris Mason
On Wed, Sep 16, 2015 at 09:58:06PM +0200, Jan Kara wrote: > On Wed 16-09-15 11:16:21, Chris Mason wrote: > > Short version, Linus' patch still gives bigger IOs and similar perf to > > Dave's original. I should have done the blktrace runs for 60 seconds > > instead of 30, I su

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-16 Thread Chris Mason
On Thu, Sep 17, 2015 at 10:37:38AM +1000, Dave Chinner wrote: > [cc Tejun] > > On Thu, Sep 17, 2015 at 08:07:04AM +1000, Dave Chinner wrote: > > On Wed, Sep 16, 2015 at 04:00:12PM -0400, Chris Mason wrote: > > > On Wed, Sep 16, 2015 at 09:58:06PM +0200, Jan Kara wrote: &g

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-17 Thread Chris Mason
On Thu, Sep 17, 2015 at 02:30:08PM +1000, Dave Chinner wrote: > On Wed, Sep 16, 2015 at 11:48:59PM -0400, Chris Mason wrote: > > On Thu, Sep 17, 2015 at 10:37:38AM +1000, Dave Chinner wrote: > > > [cc Tejun] > > > > > > On Thu, Sep 17, 2015 at

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-17 Thread Chris Mason
On Thu, Sep 17, 2015 at 12:39:51PM -0700, Linus Torvalds wrote: > On Wed, Sep 16, 2015 at 7:14 PM, Dave Chinner wrote: > >> > >> Dave, if you're testing my current -git, the other performance issue > >> might still be the spinlock thing. > > > > I have the fix as the first commit in my local tree

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-17 Thread Chris Mason
On Thu, Sep 17, 2015 at 04:08:19PM -0700, Linus Torvalds wrote: > On Thu, Sep 17, 2015 at 3:42 PM, Chris Mason wrote: > > > > Playing around with the plug a little, most of the unplugs are coming > > from the cond_resched_lock(). Not really sure why we are doing the > &g

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-18 Thread Chris Mason
On Thu, Sep 17, 2015 at 11:04:03PM -0700, Linus Torvalds wrote: > On Thu, Sep 17, 2015 at 10:40 PM, Dave Chinner wrote: > > > > Ok, makes sense - the plug is not being flushed as we switch away, > > but Chris' patch makes it do that. > > Yup. Huh, that does make much more sense, thanks Linus.

Re: [PATCH/RFC] make btrfs subvol mounts appear in /proc/mounts

2015-11-02 Thread Chris Mason
On Mon, Nov 02, 2015 at 03:50:12PM -0500, J. Bruce Fields wrote: > On Wed, Oct 28, 2015 at 07:25:10AM +0900, Neil Brown wrote: > > > > If you create a subvolume in btrfs and access it (by name) without > > mounting it, then the subvolume looks like a separate mount to some > > extent, returning a

Re: ext4: performance regression introduced by the cgroup writeback support

2015-09-23 Thread Chris Mason
On Wed, Sep 23, 2015 at 01:49:31PM +, Dexuan Cui wrote: > Hi all, > Since some point between July and Sep, I have been suffered from a strange > "very slow write" issue and on Sep 9 I reported it to LKML (but got no > reply): https://lkml.org/lkml/2015/9/9/290 > > The issue is: under high

Re: [PATCH 2/2] ext4: implement cgroup writeback support

2015-09-23 Thread Chris Mason
On Wed, Sep 23, 2015 at 03:49:12PM +0300, Artem Bityutskiy wrote: > On Tue, 2015-07-21 at 23:56 -0400, Theodore Ts'o wrote: > > > v2: Updated for MS_CGROUPWB -> SB_I_CGROUPWB. > > > > > > Signed-off-by: Tejun Heo > > > Cc: "Theodore Ts'o" > > > Cc: Andreas Dilger > > > Cc:

Re: [PATCH 2/2] ext4: implement cgroup writeback support

2015-09-23 Thread Chris Mason
On Wed, Sep 23, 2015 at 08:41:25PM +0300, Artem Bityutskiy wrote: >Hi > >$ sync >$ reboot If this is case, it should be possible to reproduce with: cp a bunch of stuff to /ext4 unmount /ext4 mount ext4 compare data If you're not getting a clean unmount of the test FS during the

[GIT PULL] Btrfs

2015-09-25 Thread Chris Mason
Hi Linus, My for-linus-4.3 branch has a few fixes: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.3 This is an assorted set I've been queuing up: Jeff Mahoney tracked down a tricky one where we ended up starting IO on the wrong mapping for special files in

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-12 Thread Chris Mason
On Sat, Sep 12, 2015 at 04:29:06PM -0700, Linus Torvalds wrote: > On Sat, Sep 12, 2015 at 4:00 PM, Chris Mason wrote: > > > > I did the plain revert as well, just to have a baseline. > > Ahh, I ended up not expecting you to get this done until after rc1 was > out, s

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-13 Thread Chris Mason
On Sat, Sep 12, 2015 at 07:46:32PM -0400, Chris Mason wrote: > I don't think the XFS numbers can be trusted too much since it was > basically bottlenecked behind that single pegged CPU. It was bouncing > around and I couldn't quite track it down to a process name (or perf > profil

[GIT PULL] Btrfs

2016-02-12 Thread Chris Mason
Hi Linus, Please pull my for-linus-4.5 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.5 This has a few fixes from Filipe, along with a readdir fix from Dave that we've been testing for some time. Filipe Manana (4) commits (+115/-68): Btrfs: remove

[GIT PULL] Btrfs

2016-02-19 Thread Chris Mason
Hi Linus, My for-linus-4.5 branch has a btrfs DIO error passing fix. I know how much you love DIO, so I'm going to suggest against reading it. We'll follow up with a patch to drop the error arg from dio_end_io in the next merge window.

[GIT PULL] Btrfs

2015-12-18 Thread Chris Mason
Hi Linus, A couple of small fixes in my for-linus-4.4 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.4 Chris Mason (2) commits (+19/-7): Btrfs: check for empty bitmap list in setup_cluster_bitmaps (+5/-3) Btrfs: check prepare_uptodate_page

Re: [PATCH RESEND] btrfs:Fix incorrect return statement if failure occurs in the function btrfs_mark_extent_written

2015-12-30 Thread Chris Mason
On Tue, Dec 29, 2015 at 08:20:47PM -0500, Nicholas Krause wrote: > This fixes the incorrect return statement if failure occurs by > returning 0 rather then the variable ret which may hold a error > code to signal when a failure has occurred in the function > btrfs_mark_extent_written to its

Re: [PATCH RESEND 2/2] btrfs:Fix error handling in the function btrfs_dev_replace_kthread

2015-12-30 Thread Chris Mason
On Tue, Dec 29, 2015 at 08:10:07PM -0500, Nicholas Krause wrote: > This fixes error handling in the function btrfs_dev_replace_kthread > by checking if the call to the function btrfs_dev_replace_continue_on_mount > has failed and if so return the error code to this function's caller in > order to

Re: new oops in 4.4.0-rc4

2015-12-11 Thread Chris Mason
On Thu, Dec 10, 2015 at 10:36:17AM -0600, Jon Christopherson wrote: > Hello, > > I noticed this new oops since running 4.4.0-rc4. Happens shortly after boot > and pretty much kills the system: > > > [ 177.774250] [ cut here ] > >[ 177.774256] kernel BUG at

[PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR

2015-12-12 Thread Chris Mason
-by: Dave Jones , Reported-by: Jon Christopherson Signed-off-by: Chris Mason diff --git a/kernel/sched/wait.c b/kernel/sched/wait.c index f10bd87..12f69df 100644 --- a/kernel/sched/wait.c +++ b/kernel/sched/wait.c @@ -434,6 +434,8 @@ __wait_on_bit_lock(wait_queue_head_t *wq, struct wait_bit_queue *q

Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR

2015-12-12 Thread Chris Mason
On Sat, Dec 12, 2015 at 11:41:26AM -0800, Linus Torvalds wrote: > On Sat, Dec 12, 2015 at 10:33 AM, Linus Torvalds > wrote: > > > > Peter, did that patch also handle just plain "lock_page()" case? > > Looking more at it, I think this all goes back to commit 743162013d40 > ("sched: Remove

Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR

2015-12-13 Thread Chris Mason
On Sun, Dec 13, 2015 at 10:50:01AM +0100, Peter Zijlstra wrote: > On Sat, Dec 12, 2015 at 11:41:26AM -0800, Linus Torvalds wrote: > > It looks like PeterZ's pending patch should fix this, by passing in > > the proper TASK_UNINTERRUPTIBLE to the bit_wait_io function, and going > > back to

[GIT PULL] Btrfs

2016-01-22 Thread Chris Mason
Hi Linus, Please pull my for-linus-4.5 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.5 These are mostly fixes that we've been testing, but also we grabbed and tested a few small cleanups that had been on the list for a while. Zhao Lei's patchset also

[GIT PULL] Btrfs

2013-06-13 Thread Chris Mason
Hi Linus, Please pull my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus This is an assortment of crash fixes: Josef Bacik (3) commits (+9/-8): Btrfs: don't delete fs_roots until after we cleanup the transaction (+1/-1) Btrfs: init

[GIT PULL] Btrfs

2013-07-09 Thread Chris Mason
Hi Linus, This Btrfs pull is available in two flavors: First, my for-linus branch has it against all the btrfs pulls from 3.10: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Or, with a merge commit on top of 3.10 (master branch):

[GIT PULL] Btrfs

2013-10-05 Thread Chris Mason
Hi Linus, Please pull my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus I've merged my for-linus up to 3.12-rc3 because the top commit is only meant for 3.12. The rest of the fixes are also available in my master branch on top of my last 3.11

[GIT PULL] Btrfs

2014-04-26 Thread Chris Mason
/-2): btrfs: fix use-after-free in mount_subvol() Chris Mason (1) commits (+5/-0): Btrfs: limit the path size in send to PATH_MAX Qu Wenruo (1) commits (+1/-1): btrfs: Change the hole range to a more accurate value. David Sterba (1) commits (+5/-5): btrfs: replace error code from

Re: btrfs: lock inversion between delayed_node->mutex and found->groups_sem

2014-04-07 Thread Chris Mason
On 04/07/2014 12:54 PM, David Sterba wrote: On Fri, Apr 04, 2014 at 05:15:23PM -0400, Sasha Levin wrote: On 03/26/2014 01:01 PM, Jeff Mahoney wrote: On 3/17/14, 9:05 AM, David Sterba wrote: On Fri, Mar 14, 2014 at 08:12:16PM -0400, Sasha Levin wrote: While fuzzing with trinity inside a KVM

Re: btrfs: lock inversion between delayed_node->mutex and found->groups_sem

2014-04-07 Thread Chris Mason
On 04/07/2014 02:03 PM, Sasha Levin wrote: On 04/07/2014 01:17 PM, Chris Mason wrote: On 04/07/2014 12:54 PM, David Sterba wrote: On Fri, Apr 04, 2014 at 05:15:23PM -0400, Sasha Levin wrote: On 03/26/2014 01:01 PM, Jeff Mahoney wrote: On 3/17/14, 9:05 AM, David Sterba wrote: On Fri, Mar

[GIT PULL] Btrfs part two

2014-04-11 Thread Chris Mason
arg for btrfs resize Harald Hoyer (1) commits (+22/-0): btrfs: allow mounting btrfs subvolumes with different ro/rw options Chris Mason (1) commits (+3/-2): Btrfs: fix EINVAL checks in btrfs_clone Qu Wenruo (1) commits (+4/-1): btrfs: Change the expanding write sequence to fix snapshot

<    11   12   13   14   15   16