Re: [GIT PULL] Btrfs

2015-05-26 Thread Chris Mason
On 05/26/2015 08:33 AM, Josh Boyer wrote: > On Fri, May 22, 2015 at 9:14 PM, Chris Mason wrote: >> Hi Linus, >> >> My for-linus-4.1 branch has three more fixes: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git >> for-linus-4.1 >&

[GIT PULL] Btrfs fixes

2015-05-15 Thread Chris Mason
Hi Linus, I have a few more fixes in my for-linus-4.1 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.1 The first commit is a fix from Filipe for a very old extent buffer reuse race that triggered a BUG_ON. It hasn't come up often, I looked through old l

Re: btrfs: kernel BUG at mm/page-writeback.c:2286!

2015-05-19 Thread Chris Mason
On 05/19/2015 03:55 AM, Govindarajulu Varadarajan wrote: > Hi all > > I am seeing the following crash on my btrfs filesystem with nfs export. > If I disable the nfs share and reboot, I do not hit the crash. Look like > the crash happens on btrfs with nfs export. > > Is this a known issue? Has any

Re: btrfs: kernel BUG at mm/page-writeback.c:2286!

2015-05-19 Thread Chris Mason
On 05/19/2015 09:54 AM, Piotr Szymaniak wrote: > On Tue, May 19, 2015 at 09:43:10AM -0400, Chris Mason wrote: >> On 05/19/2015 03:55 AM, Govindarajulu Varadarajan wrote: >>> 2286--->BUG_ON(!PageLocked(page)); >>> >>> [ 166.769868] BTRFS info (device sdf):

[GIT PULL] Btrfs fix

2015-05-08 Thread Chris Mason
Hi Linus, When an arm user reported crashes near page_address(page) in my new code, it became clear that I can't be trusted with GFP masks. Filipe beat me to the patch, and I'll just be in the corner with my dunce cap on. git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-l

[GIT PULL] Btrfs fixes

2015-05-01 Thread Chris Mason
cache writeout and bg deletion (+27/-17) Btrfs: fix deadlock when starting writeback of bg caches (+1/-1) Yang Dongsheng (1) commits (+14/-9): Btrfs: fill ->last_trans for delayed inode in btrfs_fill_inode. Chris Mason (1) commits (+1/-2): Btrfs: don't check for dela

Re: frequent lockups in 3.18rc4

2014-12-19 Thread Chris Mason
On Thu, Dec 18, 2014 at 10:58 PM, Dave Jones wrote: On Thu, Dec 18, 2014 at 07:49:41PM -0800, Linus Torvalds wrote: > And when spinlocks start getting contention, *nested* spinlocks > really really hurt. And you've got all the spinlock debugging on etc, > don't you? Yeah, though rememb

[GIT PULL] Btrfs pull part two

2014-12-19 Thread Chris Mason
Hi Linus, Please pull my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus It has part two of our merge window patches. These are all from Filipe, and fix some really hard to find races that can cause corruptions. Most of them involved block group

Re: frequent lockups in 3.18rc4

2014-12-19 Thread Chris Mason
On Fri, Dec 19, 2014 at 9:55 AM, Dave Jones wrote: On Thu, Dec 18, 2014 at 08:48:24PM -0800, Linus Torvalds wrote: > On Thu, Dec 18, 2014 at 8:03 PM, Dave Jones wrote: > > > > So the only thing that was on that could cause spinlock overhead > > was DEBUG_SPINLOCK (and LOCK_STAT, though

Re: [PATCH v2 3/3] X86: Add a thread cpu time implementation to vDSO

2014-12-19 Thread Chris Mason
On Fri, Dec 19, 2014 at 11:48 AM, Andy Lutomirski wrote: On Fri, Dec 19, 2014 at 3:23 AM, Peter Zijlstra wrote: On Thu, Dec 18, 2014 at 04:22:59PM -0800, Andy Lutomirski wrote: Bad news: this patch is incorrect, I think. Take a look at update_rq_clock -- it does fancy things involving

Re: frequent lockups in 3.18rc4

2014-12-19 Thread Chris Mason
On Fri, Dec 19, 2014 at 11:15:21AM -0800, Linus Torvalds wrote: > Here's another pattern. In your latest thing, every single time that > CPU1 is waiting for some other CPU to pick up the IPI, we have CPU0 > doing this: > > [24998.060963] NMI backtrace for cpu 0 > [24998.061989] CPU: 0 PID: 2940 Co

Re: frequent lockups in 3.18rc4

2014-12-19 Thread Chris Mason
On Fri, Dec 19, 2014 at 6:22 PM, Thomas Gleixner wrote: On Fri, 19 Dec 2014, Chris Mason wrote: On Fri, Dec 19, 2014 at 11:15:21AM -0800, Linus Torvalds wrote: > Here's another pattern. In your latest thing, every single time that > CPU1 is waiting for some other CPU to pick

[GIT PULL] Btrfs

2015-02-25 Thread Chris Mason
Hi Linus, I'm still testing more fixes, but I wanted to get out the fix for the btrfs raid5/6 memory corruption I mentioned in my merge window pull. Please pull my for-linus: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Chris Mason (1) commits (

Re: [PATCH 5/7] btrfs: add support for write stream IDs

2015-03-25 Thread Chris Mason
On Wed, Mar 25, 2015 at 11:07 AM, Jens Axboe wrote: Both buffered and O_DIRECT. Looks good, thanks Jens. Acked-by: Chris Mason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo inf

[GIT PULL] Btrfs

2015-03-06 Thread Chris Mason
Hi Linus, My for-linus branch has some btrfs fixes: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus I did rebase a patch out of the queue last night after tracking down some problems Dave Sterba was seeing during xfstests (the top three are obviously rebased). It w

[GIT PULL] Btrfs fix

2015-02-06 Thread Chris Mason
Hi Linus, Forrest Liu tracked down a missing blk_finish_plug in the btrfs logging code. This isn't a new bug, and it's hard to hit. But, it's safe enough for inclusion now, and in my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus I missed the cc:

Re: __might_sleep() warnings on v3.19-rc6

2015-02-05 Thread Chris Mason
On Sat, Jan 31, 2015 at 07:43:15PM -0800, Fengguang Wu wrote: > Hi all, > > I see 2 __might_sleep() warnings on when running LKP tests on > v3.19-rc6, one related to raid5 and another related to btrfs. > > They might be exposed by this patch. > FSUse%Count SizeFiles/sec Ap

Re: [PATCH] Btrfs:__add_inode_ref: out of bounds memory read when looking for extended ref.

2015-03-03 Thread Chris Mason
On Tue, Mar 3, 2015 at 9:38 AM, David Sterba wrote: Adding linux-btrfs to CC On Thu, Feb 26, 2015 at 05:00:37PM +0100, Quentin Casasnovas wrote: Improper arithmetics when calculting the address of the extended ref could lead to an out of bounds memory read and kernel panic. Signed-off-b

Re: [PATCH] Btrfs:__add_inode_ref: out of bounds memory read when looking for extended ref.

2015-03-03 Thread Chris Mason
On Tue, Mar 3, 2015 at 10:31 AM, Quentin Casasnovas wrote: Improper arithmetics when calculting the address of the extended ref could lead to an out of bounds memory read and kernel panic. Signed-off-by: Quentin Casasnovas --- fs/btrfs/tree-log.c | 2 +- 1 file changed, 1 insertion(+), 1

[GIT PULL] Btrfs fix

2015-01-30 Thread Chris Mason
Hi Linus, We have one more fix for btrfs in my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus This was a bug in the new raid5/6 scrubbing support. Gui Hecheng (1) commits (+2/-0): btrfs: fix raid56 scrub failed in xfstests btrfs/072 Total: (

Re: [PATCH 3/3] X86: Add a thread cpu time implementation to vDSO

2014-12-15 Thread Chris Mason
On Thu, Dec 11, 2014 at 1:36 AM, Ingo Molnar wrote: * Andy Lutomirski wrote: On Wed, Dec 10, 2014 at 2:56 PM, Shaohua Li wrote: > On Wed, Dec 10, 2014 at 02:13:23PM -0800, Andy Lutomirski wrote: >> On Wed, Dec 10, 2014 at 1:57 PM, Shaohua Li wrote: >> > On Wed, Dec 10, 2014 at 11:10:

Re: frequent lockups in 3.18rc4

2014-12-18 Thread Chris Mason
On Thu, Dec 18, 2014 at 12:13 AM, Dave Jones wrote: On Mon, Dec 15, 2014 at 03:46:41PM -0800, Linus Torvalds wrote: > On Mon, Dec 15, 2014 at 10:21 AM, Linus Torvalds > wrote: > > > > So let's just fix it. Here's a completely untested patch. > > So after looking at this more, I'm actual

[GIT PULL] Btrfs

2015-02-19 Thread Chris Mason
Hi Linus, Please pull my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus This was held up a little trying to track down a use-after-free in btrfs raid5/6. It's not clear yet if this is just made easier to trigger with this pull or if its a new bug

Re: frequent lockups in 3.18rc4

2014-12-11 Thread Chris Mason
On Thu, Dec 11, 2014 at 4:52 PM, Sasha Levin wrote: On 12/11/2014 04:49 PM, Linus Torvalds wrote: On Thu, Dec 11, 2014 at 6:54 AM, Dave Jones wrote: > > So either one of those 'good's actually wasn't, or I'm just cursed. Even if there was a good that wasn't, that last "bad" (6f929b4e5a

[GIT PULL] Btrfs for 3.19-rc

2014-12-12 Thread Chris Mason
Btrfs: fix allocationg memory failure for btrfsic_state structure (+11/-5) Btrfs: fix incorrect compression ratio detection (+8/-8) Chris Mason (1) commits (+1/-0): Btrfs: include vmalloc.h in check-integrity.c Gui Hecheng (1) commits (+60/-30): btrfs: fix dead lock while running replace and

Re: [GIT PULL] Btrfs for 3.19-rc

2014-12-12 Thread Chris Mason
On Fri, Dec 12, 2014 at 2:24 PM, Linus Torvalds wrote: On Fri, Dec 12, 2014 at 11:07 AM, Chris Mason wrote: From a feature point of view, most of the code here comes from Miao Xie and others at Fujitsu to implement scrubbing and replacing devices on raid56. This has been in

Re: Bug Fixed?

2014-12-12 Thread Chris Mason
On Fri, Dec 12, 2014 at 12:59 PM, nick wrote: Greetings Chris and Josef, I am wondering if the bug at this URL, https://urldefense.proofpoint.com/v1/url?u=https://bugzilla.kernel.org/show_bug.cgi?id%3D82251&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=6%2FL0lzzDhu0Y1hL9xm%2BQyA%3D%3D%0A&m=LzvRKZOlBaBg

Re: [PATCH 2/2] block: create ioctl to discard-or-zeroout a range of blocks

2016-03-15 Thread Chris Mason
On Tue, Mar 15, 2016 at 07:30:14PM -0500, Eric Sandeen wrote: > On 3/15/16 7:06 PM, Linus Torvalds wrote: > > On Tue, Mar 15, 2016 at 4:52 PM, Dave Chinner wrote: > >> > > >> > It is pretty clear that the onus is on the patch submitter to > >> > provide justification for inclusion, not for the rev

Re: [PATCH 2/2] block: create ioctl to discard-or-zeroout a range of blocks

2016-03-19 Thread Chris Mason
On Thu, Mar 17, 2016 at 10:47:29AM -0700, Linus Torvalds wrote: > On Wed, Mar 16, 2016 at 10:18 PM, Gregory Farnum wrote: > > > > So we've not asked for NO_HIDE_STALE on the mailing lists, but I think > > it was one of the problems Sage had using xfs in his BlueStore > > implementation and was a b

Re: [PATCH 2/2] block: create ioctl to discard-or-zeroout a range of blocks

2016-03-19 Thread Chris Mason
On Tue, Mar 15, 2016 at 05:51:17PM -0700, Chris Mason wrote: > On Tue, Mar 15, 2016 at 07:30:14PM -0500, Eric Sandeen wrote: > > On 3/15/16 7:06 PM, Linus Torvalds wrote: > > > On Tue, Mar 15, 2016 at 4:52 PM, Dave Chinner wrote: > > >> > > > >> >

Re: [PATCH RFC] select_idle_sibling experiments

2016-04-07 Thread Chris Mason
On Tue, Apr 05, 2016 at 02:08:22PM -0400, Chris Mason wrote: > Hi everyone, > > We're porting the fb kernel up to 4.5, and one of our last few out-of-tree > patches is a hack to try harder to find idle cpus when waking up tasks. > This helps in pretty much every workload we

[GIT PULL] Btrfs

2016-04-08 Thread Chris Mason
Hi Linus We have some fixes queued up in my for-linus-4.6 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.6 These are bug fixes, including a really old fsync bug, and a few trace points to help us track down problems in the quota code. Mark Fasheh (2) co

Re: [PATCH RFC] select_idle_sibling experiments

2016-04-09 Thread Chris Mason
On Wed, Apr 06, 2016 at 09:27:24AM +0200, Mike Galbraith wrote: > > On Tue, 2016-04-05 at 14:08 -0400, Chris Mason wrote: > > > Now, on to the patch. I pushed some code around and narrowed the > > problem down to select_idle_sibling() We have cores going into and out &g

sched: tweak select_idle_sibling to look for idle threads

2016-04-09 Thread Chris Mason
th someone else. Benchmarks in production show overall capacity going up between 2-5% depending on the metric. Credits to Arun Sharma for initial versions of this patch. Signed-off-by: Chris Mason diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 56b7d4b..2c47240 100644 --- a/ke

Re: sched: tweak select_idle_sibling to look for idle threads

2016-04-10 Thread Chris Mason
On Sun, Apr 10, 2016 at 12:04:21PM +0200, Mike Galbraith wrote: > On Sat, 2016-04-09 at 15:05 -0400, Chris Mason wrote: > > > This does preserve the existing logic to prefer idle cores over idle > > CPU threads, and includes some tests to try and avoid the idle scan when >

Re: sched: tweak select_idle_sibling to look for idle threads

2016-04-10 Thread Chris Mason
On Sun, Apr 10, 2016 at 12:04:21PM +0200, Mike Galbraith wrote: > On Sat, 2016-04-09 at 15:05 -0400, Chris Mason wrote: > > > This does preserve the existing logic to prefer idle cores over idle > > CPU threads, and includes some tests to try and avoid the idle scan when >

[PATCH RFC] select_idle_sibling experiments

2016-04-05 Thread Chris Mason
goto done; -next: - sg = sg->next; - } while (sg != sd->groups); + } } done: return target; -------- /* * schbench.c * * Copyright (C) 2016 Facebook * Chris Mason * * GPLv2, portions copied from t

Re: [PATCH RFC] select_idle_sibling experiments

2016-04-05 Thread Chris Mason
On Tue, Apr 05, 2016 at 02:43:09PM -0400, Bastien Bastien Philbert wrote: > On Tue, Apr 5, 2016 at 2:08 PM, Chris Mason wrote: [ ... ] > > > > I tried a few variations on select_idle_sibling() that preserved the > > underlying goal of returning idle cores before idle SMT th

Re: [PATCH] [RFC] fix potential access after free: return value of blk_check_plugged() must be used schedule() safe

2016-04-05 Thread Chris Mason
On Tue, Apr 05, 2016 at 03:36:57PM +0200, Lars Ellenberg wrote: > blk_check_plugged() will return a pointer > to an object linked on current->plug->cb_list. > > That list may "at any time" be implicitly cleared by > blk_flush_plug_list() > flush_plug_callbacks() > either as a result of blk_finish

Re: [PATCH RFC] select_idle_sibling experiments

2016-04-05 Thread Chris Mason
On Tue, Apr 05, 2016 at 09:03:02PM +0100, Matt Fleming wrote: > On Tue, 05 Apr, at 02:08:22PM, Chris Mason wrote: > > > > I started with a small-ish program to benchmark wakeup latencies. The > > basic idea is a bunch of worker threads who sit around and burn CPU. > >

Re: [PATCH RFC] select_idle_sibling experiments

2016-04-06 Thread Chris Mason
On Wed, Apr 06, 2016 at 09:27:24AM +0200, Mike Galbraith wrote: > > On Tue, 2016-04-05 at 14:08 -0400, Chris Mason wrote: > > > Now, on to the patch. I pushed some code around and narrowed the > > problem down to select_idle_sibling() We have cores going into and out &g

Re: New TAB chair announcement

2016-04-19 Thread Chris Mason
On Mon, Apr 18, 2016 at 04:34:52AM -0700, Grant Likely wrote: > I'm pleased to announce that at last weeks Technical Advisory Board > meeting, the TAB elected Chris Mason as the chair* and re-elected Jon > Corbet as vice-chair. > > Chris & Jon, congratulations to you. I&

[GIT PULL] Btrfs

2016-04-01 Thread Chris Mason
Hi Linus, My for-linus-4.6 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.6 Has a few fixes Dave Sterba had queued up. These are all pretty small, but since they were tested I decided against waiting for more: Alex Lyakas (2) commits (+18/-10): btr

Re: sched: tweak select_idle_sibling to look for idle threads

2016-04-11 Thread Chris Mason
On Mon, Apr 11, 2016 at 06:54:21AM +0200, Mike Galbraith wrote: > On Sun, 2016-04-10 at 15:55 -0400, Chris Mason wrote: > > On Sun, Apr 10, 2016 at 12:04:21PM +0200, Mike Galbraith wrote: > > > On Sat, 2016-04-09 at 15:05 -0400, Chris Mason wrote: > > > > > &g

Re: sched: tweak select_idle_sibling to look for idle threads

2016-04-12 Thread Chris Mason
On Tue, Apr 12, 2016 at 06:44:08AM +0200, Mike Galbraith wrote: > On Mon, 2016-04-11 at 20:30 -0400, Chris Mason wrote: > > On Mon, Apr 11, 2016 at 06:54:21AM +0200, Mike Galbraith wrote: > > > > > Ok, I was able to reproduce this by stuffing tbench_srv and tbench on

Re: sched: tweak select_idle_sibling to look for idle threads

2016-04-12 Thread Chris Mason
On Tue, Apr 12, 2016 at 08:16:17PM +0200, Mike Galbraith wrote: > On Tue, 2016-04-12 at 09:27 -0400, Chris Mason wrote: > > I > > can always add the tunable to flip things on/off but I'd prefer that we > > find a good set of defaults, mostly so the FB production runtim

Re: sched: tweak select_idle_sibling to look for idle threads

2016-04-13 Thread Chris Mason
On Wed, Apr 13, 2016 at 05:18:51AM +0200, Mike Galbraith wrote: > On Tue, 2016-04-12 at 16:07 -0400, Chris Mason wrote: > > > I think that if we're worried about the cost of the idle scan for this > > workload, find_idlest_group() is either going to hurt much more, or not

Re: sched: tweak select_idle_sibling to look for idle threads

2016-04-13 Thread Chris Mason
On Wed, Apr 13, 2016 at 04:22:58PM +0200, Mike Galbraith wrote: > On Wed, 2016-04-13 at 09:44 -0400, Chris Mason wrote: > > > So you're interested in numbers where we pass the wake_wide decision > > into select_idle_sibling(), and then use that instead of (or

Re: [PATCH RFC] select_idle_sibling experiments

2016-04-13 Thread Chris Mason
On Wed, Apr 13, 2016 at 05:40:20AM +0200, Mike Galbraith wrote: > On Tue, 2016-04-12 at 22:45 +0100, Matt Fleming wrote: > > On Sat, 09 Apr, at 01:30:34PM, Chris Mason wrote: > > > > > > [ nohz throttling patch ] > > > > > > I tested the nohz throt

[GIT PULL] Btrfs

2015-11-06 Thread Chris Mason
(+4/-4): Btrfs: move kobj stuff out of dev_replace lock range Shan Hai (1) commits (+0/-3): btrfs/file.c: remove an unsed varialbe first_index Chris Mason (1) commits (+3/-5): btrfs: fix use after free iterating extrefs Robin Ruede (1) commits (+8/-2): btrfs: fix resending received snapsho

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-16 Thread Chris Mason
On Mon, Sep 14, 2015 at 01:06:25PM -0700, Linus Torvalds wrote: > On Sun, Sep 13, 2015 at 4:12 PM, Dave Chinner wrote: > > > > Really need to run these numbers on slower disks where block layer > > merging makes a difference to performance. > > Yeah. We've seen plugging and io schedulers not make

Re: [PATCH] fs-writeback: drop wb->list_lock during blk_finish_plug()

2015-09-16 Thread Chris Mason
On Wed, Sep 16, 2015 at 09:58:06PM +0200, Jan Kara wrote: > On Wed 16-09-15 11:16:21, Chris Mason wrote: > > Short version, Linus' patch still gives bigger IOs and similar perf to > > Dave's original. I should have done the blktrace runs for 60 seconds > > instead o

[GIT PULL] Btrfs

2015-10-09 Thread Chris Mason
Hi Linus, I have a few fixes in my for-linus-4.3 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.3 These are small and assorted. Neil's is the oldest, I dropped the ball thinking he was going to send it in. Filipe Manana (3) commits (+26/-12): Btrfs

Re: [PATCH/RFC] make btrfs subvol mounts appear in /proc/mounts

2015-11-02 Thread Chris Mason
On Mon, Nov 02, 2015 at 03:50:12PM -0500, J. Bruce Fields wrote: > On Wed, Oct 28, 2015 at 07:25:10AM +0900, Neil Brown wrote: > > > > If you create a subvolume in btrfs and access it (by name) without > > mounting it, then the subvolume looks like a separate mount to some > > extent, returning a

Re: linux-next: Signed-off-by missing for commits in the net-next tree

2019-08-16 Thread Chris Mason
On 16 Aug 2019, at 5:15, Andy Grover wrote: > On 8/16/19 3:06 PM, Gerd Rausch wrote: >> Hi, >> >> Just added the e-mail addresses I found using a simple "google >> search", >> in order to reach out to the original authors of these commits: >> C

Re: linux-next: cleanup the btrfs trees

2019-10-21 Thread Chris Mason
On 19 Oct 2019, at 23:47, Stephen Rothwell wrote: > Hi all, > > The btrfs tree > (git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git#next) > has not bee updated in more than a year, so I have removed it and then > renamed the btrfs-kdave tree to btrfs. I hope this is OK and if an

Re: [PATCH 1/2] Revert "mm: don't reclaim inodes with many attached pages"

2019-01-30 Thread Chris Mason
On 29 Jan 2019, at 23:17, Dave Chinner wrote: > From: Dave Chinner > > This reverts commit a76cf1a474d7dbcd9336b5f5afb0162baa142cf0. > > This change causes serious changes to page cache and inode cache > behaviour and balance, resulting in major performance regressions > when combining worklao

Re: [PATCH] fs,xfs: fix missed wakeup on l_flush_wait

2019-05-08 Thread Chris Mason
it the lost wakeup in prod. I could search through all the related hung task timeouts, but they are probably all stuck in blkmq. Acked-but-I'm-still-blaming-Jens-by: Chris Mason -chris

Re: [Regression 4.7-rc1] btrfs: bugfix: handle FS_IOC32_{GETFLAGS,SETFLAGS,GETVERSION} in btrfs_ioctl

2017-01-06 Thread Chris Mason
On 01/06/2017 12:22 PM, Joseph Salisbury wrote: Hi Luke, A kernel bug report was opened against Ubuntu [0]. This bug was fixed by the following commit in v4.7-rc1: commit 4c63c2454eff996c5e27991221106eb511f7db38 Author: Luke Dashjr Date: Thu Oct 29 08:22:21 2015 + btrfs: bugfix:

[GIT PULL] Btrfs fixes

2017-01-13 Thread Chris Mason
Hi Linus, Dave Sterba queued up a few fixes for btrfs. I have them in my for-linus-4.10 branch: These are all over the place. The tracepoint part of the pull fixes a crash and adds a little more information to two tracepoints, while the rest are good old fashioned fixes. git://git.kernel.org/p

[GIT PULL] Btrfs

2017-01-27 Thread Chris Mason
Hi Linus, My for-linus-4.10 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.10 Has some fixes that we've collected from the list. We still have one more pending to nail down a regression in lzo compression, but I wanted to get this batch out the door.

Re: [PATCH] Fix sysrq emergency thaw

2016-07-19 Thread Chris Mason
eb Author: Christoph Hellwig Date: Mon Aug 3 23:28:35 2009 +0200 freeze_bdev: grab active reference to frozen superblocks Then you can add: Reviewed-by: Chris Mason Thanks! -chris

Re: bio linked list corruption.

2016-10-26 Thread Chris Mason
On 10/26/2016 03:06 PM, Linus Torvalds wrote: > On Wed, Oct 26, 2016 at 11:42 AM, Dave Jones wrote: >> >> The stacks show nearly all of them are stuck in sync_inodes_sb > > That's just wb_wait_for_completion(), and it means that some IO isn't > completing. > > There's also a lot of processes w

Re: bio linked list corruption.

2016-10-26 Thread Chris Mason
On 10/26/2016 04:00 PM, Chris Mason wrote: > > > On 10/26/2016 03:06 PM, Linus Torvalds wrote: >> On Wed, Oct 26, 2016 at 11:42 AM, Dave Jones wrote: >>> >>> The stacks show nearly all of them are stuck in sync_inodes_sb >> >> That's just w

Re: bio linked list corruption.

2016-10-26 Thread Chris Mason
On Wed, Oct 26, 2016 at 03:07:10PM -0700, Linus Torvalds wrote: On Wed, Oct 26, 2016 at 1:00 PM, Chris Mason wrote: Today I turned off every CONFIG_DEBUG_* except for list debugging, and ran dbench 2048: [ 2759.118711] WARNING: CPU: 2 PID: 31039 at lib/list_debug.c:33 __list_add+0xbe/0xd0

Re: bio linked list corruption.

2016-10-26 Thread Chris Mason
On Wed, Oct 26, 2016 at 05:03:45PM -0600, Jens Axboe wrote: On 10/26/2016 04:58 PM, Linus Torvalds wrote: On Wed, Oct 26, 2016 at 3:51 PM, Linus Torvalds wrote: Dave: it might be a good idea to split that "WARN_ON_ONCE()" in blk_mq_merge_queue_io() into two I did that myself too, since Dave

Re: bio linked list corruption.

2016-10-26 Thread Chris Mason
On Wed, Oct 26, 2016 at 05:20:01PM -0600, Jens Axboe wrote: On 10/26/2016 05:08 PM, Linus Torvalds wrote: On Wed, Oct 26, 2016 at 4:03 PM, Jens Axboe wrote: Actually, I think I see what might trigger it. You are on nvme, iirc, and that has a deep queue. Yes. I have long since moved on from

Re: bio linked list corruption.

2016-10-27 Thread Chris Mason
On 10/26/2016 08:00 PM, Jens Axboe wrote: > On 10/26/2016 05:47 PM, Dave Jones wrote: >> On Wed, Oct 26, 2016 at 07:38:08PM -0400, Chris Mason wrote: >> >> > >-hctx->queued++; >> > >-data->hctx = hctx; >> > >-

[GIT PULL] Btrfs

2016-10-28 Thread Chris Mason
'm no longer able to trigger problems. Filipe is fixing a difficult old bug between snapshots, balance and send. Dave is cooking a few more for the next rc, but these are tested and ready: Chris Mason (1) commits (+6/-14): btrfs: fix races on root_log_ctx lists Filipe Manana (1) commi

Linux Foundation Technical Advisory Board Elections updates and location

2016-10-28 Thread Chris Mason
The nominees so far: Josh Triplett Rik van Riel Dave Taht Chris Mason Dan Williams Steve Rostedt is maintaining a list of the nominees and their statements at the URL below. He promises to stay at the keyboard and keep updating it until 12pm EDT Oct 30th: https://goo.gl/xlAoJl The election

Re: btrfs btree_ctree_super fault

2016-11-08 Thread Chris Mason
On 11/08/2016 09:59 AM, Dave Jones wrote: On Sun, Nov 06, 2016 at 11:55:39AM -0500, Dave Jones wrote: > > > On Mon, Oct 31, 2016 at 01:44:55PM -0600, Chris Mason wrote: > > On Mon, Oct 31, 2016 at 12:35:16PM -0700, Linus Torvalds wrote: > > >On Mon, Oct 31, 2016

Re: [PATCH] btrfs: let btrfs_delete_unused_bgs() to clean relocated bgs

2016-10-10 Thread Chris Mason
On 09/02/2016 03:46 AM, Naohiro Aota wrote: Currently, btrfs_relocate_chunk() is removing relocated BG by itself. But the work can be done by btrfs_delete_unused_bgs() (and it's better since it trim the BG). Let's dedupe the code. While btrfs_delete_unused_bgs() is already hitting the relocated

Re: btrfs bio linked list corruption.

2016-10-11 Thread Chris Mason
On 10/11/2016 11:19 AM, Dave Jones wrote: On Tue, Oct 11, 2016 at 04:11:39PM +0100, Al Viro wrote: > On Tue, Oct 11, 2016 at 10:45:08AM -0400, Dave Jones wrote: > > This is from Linus' current tree, with Al's iovec fixups on top. > > Those iovec fixups are in the current tree... ah yeah, g

[GIT PULL] Btrfs

2016-10-11 Thread Chris Mason
(1) commits (+20/-6): btrfs: fix a possible umount deadlock Lu Fengqi (1) commits (+369/-10): btrfs: fix check_shared for fiemap ioctl Chris Mason (1) commits (+15/-11): Revert "btrfs: let btrfs_delete_unused_bgs() to clean relocated bgs" Masahiro Yamada (1) commits (+8/-28)

Re: btrfs bio linked list corruption.

2016-10-11 Thread Chris Mason
On 10/11/2016 10:45 AM, Dave Jones wrote: > This is from Linus' current tree, with Al's iovec fixups on top. > > [ cut here ] > WARNING: CPU: 1 PID: 3673 at lib/list_debug.c:33 __list_add+0x89/0xb0 > list_add corruption. prev->next should be next (e8806648), but w

Re: btrfs bio linked list corruption.

2016-10-12 Thread Chris Mason
On 10/12/2016 10:40 AM, Dave Jones wrote: On Wed, Oct 12, 2016 at 09:47:17AM -0400, Dave Jones wrote: > On Tue, Oct 11, 2016 at 11:54:09AM -0400, Chris Mason wrote: > > > > > > On 10/11/2016 10:45 AM, Dave Jones wrote: > > > This is from Linus' curr

Re: bio linked list corruption.

2016-10-21 Thread Chris Mason
On 10/21/2016 04:02 PM, Dave Jones wrote: On Thu, Oct 20, 2016 at 04:23:32PM -0700, Andy Lutomirski wrote: > On Thu, Oct 20, 2016 at 4:03 PM, Dave Jones wrote: > > On Thu, Oct 20, 2016 at 04:01:12PM -0700, Andy Lutomirski wrote: > > > On Thu, Oct 20, 2016 at 3:50 PM, Dave Jones wrote: >

Re: bio linked list corruption.

2016-10-21 Thread Chris Mason
On 10/21/2016 04:23 PM, Dave Jones wrote: On Fri, Oct 21, 2016 at 04:17:48PM -0400, Chris Mason wrote: > > BTRFS warning (device sda3): csum failed ino 130654 off 0 csum 2566472073 expected csum 3008371513 > > BTRFS warning (device sda3): csum failed ino 131057 off 4096 csum

Re: bio linked list corruption.

2016-10-23 Thread Chris Mason
On 10/22/2016 11:20 AM, Dave Jones wrote: On Fri, Oct 21, 2016 at 04:02:45PM -0400, Dave Jones wrote: > > It could be worth trying this, too: > > > > https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commit/?h=x86/vmap_stack&id=174531fef4e8 > > > > It occurred to me that t

Re: btrfs btree_ctree_super fault

2016-11-10 Thread Chris Mason
On 11/10/2016 09:35 AM, Dave Jones wrote: On Tue, Nov 08, 2016 at 10:08:04AM -0500, Chris Mason wrote: > > And another new one: > > > > kernel BUG at fs/btrfs/ctree.c:3172! > > > > Call Trace: > > [] __btrfs_drop_extents+0xb00/0xe30 [btrfs] > >

Re: btrfs: still lockdep splat for 4.9-rc5+ (btrfs_log_inode)

2016-11-26 Thread Chris Mason
On Fri, Nov 25, 2016 at 10:03:25AM +0100, Christian Borntraeger wrote: FWIW, I still see the lockdep splat in btrfs in 4.9-rc5+ Filipe reworked the code to avoid taking the same lock twice. As far as I can tell, this just needs some annotation. -chris

Re: [PATCH 26/60] btrfs: set NO_MP for request queues behind BTRFS

2016-10-31 Thread Chris Mason
On Mon, Oct 31, 2016 at 08:36:44AM -0700, Christoph Hellwig wrote: On Sat, Oct 29, 2016 at 04:08:25PM +0800, Ming Lei wrote: There are lots of direct access to .bi_vcnt & .bi_io_vec of bio, and it isn't ready to support multipage bvecs for BTRFS, so set NO_MP for these request queues. For one

Re: bio linked list corruption.

2016-10-31 Thread Chris Mason
On Mon, Oct 31, 2016 at 12:35:16PM -0700, Linus Torvalds wrote: On Mon, Oct 31, 2016 at 11:55 AM, Dave Jones wrote: BUG: Bad page state in process kworker/u8:12 pfn:4e0e39 page:ea0013838e40 count:0 mapcount:0 mapping:8804a20310e0 index:0x100c flags: 0x400c(referenced|uptod

Re: OOM: Better, but still there on

2016-12-21 Thread Chris Mason
On Wed, Dec 21, 2016 at 12:16:53PM +0100, Michal Hocko wrote: On Wed 21-12-16 20:00:38, Tetsuo Handa wrote: One thing to note here, when we are talking about 32b kernel, things have changed in 4.8 when we moved from the zone based to node based reclaim (see b2e18757f2c9 ("mm, vmscan: begin recla

Re: bio linked list corruption.

2016-10-24 Thread Chris Mason
On 10/24/2016 12:40 AM, Dave Jones wrote: On Sun, Oct 23, 2016 at 05:32:21PM -0400, Chris Mason wrote: > > > On 10/22/2016 11:20 AM, Dave Jones wrote: > > On Fri, Oct 21, 2016 at 04:02:45PM -0400, Dave Jones wrote: > > > > > > I

Reminder: Linux Foundation Technical Advisory Board Elections and Nomination process

2016-10-24 Thread Chris Mason
tworks and mailing lists, so get your nomination in early). Chris Mason, TAB Chair [1] TAB members sit for a term of two years, and half of the board is up for election every year. Five of the seats are up for election now. The other five are halfway through their term and will be up for election next year.

Re: bio linked list corruption.

2016-10-24 Thread Chris Mason
On 10/24/2016 05:50 PM, Linus Torvalds wrote: On Mon, Oct 24, 2016 at 2:17 PM, Linus Torvalds wrote: The vmalloc/vfree code itself is a bit scary. In particular, we have a rather insane model of TLB flushing. We leave the virtual area on a lazy purge-list, and we delay flushing the TLB and act

Re: [PATCH] btrfs: limit async_work allocation and worker func duration

2016-12-13 Thread Chris Mason
On 12/12/2016 03:35 PM, Maxim Patlasov wrote: On 12/12/2016 06:54 AM, David Sterba wrote: As far as we don't have any NO_THRESHOLD users of btrfs_workqueue_normal_congested for now, I tend to think it's better to add a descriptive comment and simply return "false" from btrfs_workqueue_normal_con

[GIT PULL] Btrfs

2016-12-16 Thread Chris Mason
ady calculated value in btrfs_should_throttle_delayed_refs() (+1/-1) btrfs: add necessary comments about tickets_id (+4/-0) btrfs: improve delayed refs iterations (+37/-6) Liu Bo (2) commits (+12/-6): Btrfs: adjust len of writes if following a preallocated extent (+5/-3) Btrfs: fi

Re: OOM: Better, but still there on 4.9

2016-12-16 Thread Chris Mason
On 12/16/2016 02:39 AM, Michal Hocko wrote: [CC linux-mm and btrfs guys] On Thu 15-12-16 23:57:04, Nils Holland wrote: [...] Of course, none of this are workloads that are new / special in any way - prior to 4.8, I never experienced any issues doing the exact same things. Dec 15 19:02:16 teela

Re: OOM: Better, but still there on 4.9

2016-12-16 Thread Chris Mason
On 12/16/2016 02:39 AM, Michal Hocko wrote: [CC linux-mm and btrfs guys] On Thu 15-12-16 23:57:04, Nils Holland wrote: [...] Of course, none of this are workloads that are new / special in any way - prior to 4.8, I never experienced any issues doing the exact same things. Dec 15 19:02:16 teela

Re: OOM: Better, but still there on 4.9

2016-12-16 Thread Chris Mason
On 12/16/2016 05:14 PM, Michal Hocko wrote: On Fri 16-12-16 13:15:18, Chris Mason wrote: On 12/16/2016 02:39 AM, Michal Hocko wrote: [...] I believe the right way to go around this is to pursue what I've started in [1]. I will try to prepare something for testing today for you. Stay

[GIT PULL] Btrfs

2017-03-23 Thread Chris Mason
Hi Linus We have a small set of fixes for the next RC: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.11 Zygo tracked down a very old bug with inline compressed extents. I didn't tag this one for stable because I want to do individual tested backports. It's a

[GIT PULL] Btrfs

2016-06-18 Thread Chris Mason
Hi Linus, My for-linus-4.7 branch has a few fixes: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.7 The most user visible change here is a fix for our recent superblock validation checks that were causing problems on non-4k pagesized systems. David Sterba (2) c

Re: [Ksummit-discuss] Results: Linux Foundation Technical Advisory Board Election 2016

2016-11-03 Thread Chris Mason
, H. Peter Anvin, Chris Mason and the Linux Foundation staff who helped handle the election logistics. With 108 ballots cast, the top 5 candidates received: The next highest voted candidate received 44 votes. Full results are available on request. Just curious, is there any particular reason to

Re: Linux Foundation Technical Advisory Board Elections updates and location

2016-11-03 Thread Chris Mason
On Thu, Nov 03, 2016 at 10:19:50AM -0700, Randy Dunlap wrote: On 10/28/16 16:13, Frank Rowand wrote: Hi Chris, It's time for the annual question of: where do I find the TAB minutes? I was sure I had a bookmark of the link, but I seem to have misplaced it. Thanks, Frank and the answer is ?

Re: [Ksummit-discuss] Results: Linux Foundation Technical Advisory Board Election 2016

2016-11-04 Thread Chris Mason
On Thu, Nov 03, 2016 at 08:38:44PM +0200, Laurent Pinchart wrote: Hi Chris, On Thursday 03 Nov 2016 10:47:03 Chris Mason wrote: On Thu, Nov 03, 2016 at 06:06:35PM +0200, Laurent Pinchart wrote: > On Thursday 03 Nov 2016 11:39:51 Steven Rostedt wrote: >> The TAB elections are now

[GIT PULL] Btrfs

2016-11-04 Thread Chris Mason
Hi Linus, My for-linus-4.9 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.9 Has some fixes that Dave Sterba collected. We held off on these last week because I was focused on the memory corruption testing. I had asked you about pulling this directly f

[GIT PULL] Btrfs

2017-03-02 Thread Chris Mason
Hi Linus, My for-linus-4.11 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.11 Has Btrfs round two. These are mostly a continuation of Dave Sterba's collection of cleanups, but Filipe also has some bug fixes and performance improvements. Nikolay Boriso

Re: [PATCH] jump_label: Fix anonymous union initialization

2017-03-02 Thread Chris Mason
asm get added into 4.5? Did someone backport it to the gcc 4.4 compilers? I believe 4.5 handles anonymous unions. Since the broken commit went through my tree, I'll take this patch. I'm getting ready for another git pull request to Linus. Compiled-by: Chris Mason -chris

<    2   3   4   5   6   7   8   >