Re: [PATCH] serial: imx: enable IMX21_UCR3_RXDMUXSEL for non-dte-mode

2018-05-02 Thread Chris Ruehl
Hi Greg, On Friday, April 20, 2018 02:13 PM, Uwe Kleine-König wrote: Hello Chris, On Fri, Apr 20, 2018 at 09:07:59AM +0800, Chris Ruehl wrote: Fix a problem introduced with commit e61c38d85b73 ("serial: imx: setup DCEDTE early and ensure DCD and RI irqs to be off") result in non dt

Re: [PATCH v6 2/2] devicetree: hwmon: shtc1: Add sensirion,shtc1.yaml

2020-08-06 Thread Chris Ruehl
Rob, sorry for late reply, I have my head in setup production install the dt-schema and rerun the check, with 2020-6 no warnings lets fix it. Chris On 13/7/2020 11:00 pm, Rob Herring wrote: On Sun, 12 Jul 2020 12:44:10 +0800, Chris Ruehl wrote: Add documentation for the newly added DTS

[PATCH v7 0/2] shtc1: add support for device tree bindings

2020-08-07 Thread Chris Ruehl
Add support for DTS bindings to the shtc driver The patches add the compatible table and of_property_read_bool to the shtc1.c. Newly created Yaml document has been released to the Documentation/devicetree/hwmon/sensirion,shtc1.yaml Signed-off-by: Chris Ruehl --- Version 7 make

[PATCH v7 1/2] hwmon: shtc1: add support for device tree bindings

2020-08-07 Thread Chris Ruehl
Add support for DTS bindings for the sensirion shtc1,shtw1 and shtc3. Signed-off-by: Chris Ruehl Reviewed-by: Guenter Roeck --- drivers/hwmon/shtc1.c | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/shtc1.c b/drivers/hwmon/shtc1.c

[PATCH v7 2/2] devicetree: hwmon: shtc1: add sensirion,shtc1.yaml

2020-08-07 Thread Chris Ruehl
Add documentation for the newly added DTS support in the shtc1 driver. To align with the drivers logic to have high precision by default a boolean sensirion,low_precision is used to switch to low precision. Signed-off-by: Chris Ruehl --- .../bindings/hwmon/sensirion,shtc1.yaml | 59

Re: [PATCH v5 3/3] iio/dac: convert ltc2632.txt to lltc,ltc2632.yaml

2020-08-09 Thread Chris Ruehl
Rob, On 30/4/2020 11:24 pm, Rob Herring wrote: On Mon, Apr 20, 2020 at 12:26:08PM +0800, Chris Ruehl wrote: Conversion of the ltc2632 to yaml format and name the file 'lltc,ltc2632.yaml'. Signed-off-by: Chris Ruehl --- v5: correct require section set maintainer of analog.com

[PATCH] iio/dac: convert ltc2632.txt to lltc,ltc2632.yaml

2020-08-09 Thread Chris Ruehl
Conversion of the ltc2632 to yaml format and name the file to 'lltc,ltc2632.yaml'. Signed-off-by: Chris Ruehl --- v6: Remove tab and drop unused label Related patches already in linux-next. [PATCH v5 1/3] iio: documentation ltc2632_chip_info add num_channels linux-n

Re: [PATCH 0/6] mmc: core: hs400(es) fix probe/init

2020-12-11 Thread Chris Ruehl
No Comments ? Chris On 8/12/2020 2:18 pm, Chris Ruehl wrote: Fix the probe if hs400-1_8v / hs400-1_2v is used in the dts and mmc-hs400-enhanced-strobe isn't set. That was the first attemped, but it turns out that some more cleanups and simplifications can be done. * move mmc_select_hs400

Re: [PATCH 2/3] mmc: core: make hs400 independent from hs200 init

2020-12-07 Thread Chris Ruehl
On 3/12/2020 5:33 pm, Chris Ruehl wrote: Move mmc_select_hs400() out from hs200 init path and make hs400 independent. The patch makes quite some changes and needs to be reviewed carefully. In function mmc_select_timing() call for mmc_select_hs400(). HS400 requires a host bus with of 8bit

[PATCH 6/6] mmc: core: with mmc-hs400-1_8(2)v not add MMC_CAP2_HS200* to host->caps2

2020-12-07 Thread Chris Ruehl
When set mmc-hs400-1_8(2)v in dts, hs200 capabilities are not checked in the mmc logic. Thus cleanup and remove MMC_CAP2_HS200_1_8V_SDR / MMC_CAP2_HS200_1_2V_SDR from host->caps2. Signed-off-by: Chris Ruehl --- drivers/mmc/core/host.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[PATCH 0/6] mmc: core: hs400(es) fix probe/init

2020-12-07 Thread Chris Ruehl
ect_hs400() independent and move it out of the hs200. Run hs400 tuning inside mmc_select_hs400(); * merge hs400 with hs400es function * remove mmc_select_hs400es function * remove mmc_hs200_tuning() * cleanup host->caps2 for hs400-1_8(2)v Signed-off-by: Chris Ruehl --- Replace patch set [PA

[PATCH 1/6] mmc: core: prepare hs400 update, code order

2020-12-07 Thread Chris Ruehl
This patch didn't change functionality just move mmc_select_hs400() and mmc_hs200_to_hs400() between mmc_select_hs400es() and mmc_select_hs200. fix checkpatch --script warings. Signed-off-by: Chris Ruehl --- drivers/mmc/core/mmc.c | 184 - 1 file ch

[PATCH 3/6] mmc: core: add enhanced strobe to mmc_select_hs400()

2020-12-07 Thread Chris Ruehl
can be removed. Signed-off-by: Chris Ruehl --- drivers/mmc/core/mmc.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index e7b4de3d4f47..84c09d9e0317 100644 --- a/drivers/mmc/core/mmc.c +++ b/drivers/mmc

[PATCH 2/6] mmc: core: make hs400 independent from hs200 init

2020-12-07 Thread Chris Ruehl
0 MiB, chardev (242:0) Tested with rk3399 customized board. Signed-off-by: Chris Ruehl --- drivers/mmc/core/mmc.c | 61 +++--- 1 file changed, 52 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index 5477786aded8..e

[PATCH 4/6] mmc: core: remove mmc_select_hs400es()

2020-12-07 Thread Chris Ruehl
Enhanced strobe function had been merged in mmc_select_hs400(); mmc_select_hs400es() is obsolate and removed. Signed-off-by: Chris Ruehl --- drivers/mmc/core/mmc.c | 94 -- 1 file changed, 94 deletions(-) diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc

[PATCH 5/6] mmc: core: simplify hs200 tuning

2020-12-07 Thread Chris Ruehl
Since the host->ops->prepare_hs400_tuning had been moved to mmc_select_hs400() the tuning for hs200 can simplify and the function mmc_hs200_tuning() can be removed. Signed-off-by: Chris Ruehl --- drivers/mmc/core/mmc.c | 22 +- 1 file changed, 1 insertion(+), 21 del

[PATCH v2] phy: rockchip-emmc: emmc_phy_init() always return 0

2020-12-08 Thread Chris Ruehl
trl_frqsel based on card clock Signed-off-by: Chris Ruehl --- drivers/phy/rockchip/phy-rockchip-emmc.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-emmc.c b/drivers/phy/rockchip/phy-rockchip-emmc.c index 48e2d75b1004..a23034416

[PATCH v3] phy: rockchip-emmc: emmc_phy_init() always return 0

2020-12-10 Thread Chris Ruehl
trl_frqsel based on card clock Signed-off-by: Chris Ruehl Reviewed-by: Douglas Anderson --- v3 - IS_ERROR() already return false if rk_phy->emmcclk == NULL add Reviewed tag v2 - use clk_get_optional drivers/phy/rockchip/phy-rockchip-emmc.c | 8 +--- 1 file changed, 5 insertions(+)

[PATCH] phy: rockchip-emmc: emmc_phy_init() always return 0

2020-11-30 Thread Chris Ruehl
rockchip_emmc_phy_init() return variable is not set with the error value if clk_get() failed. The debug message print 0 on error and the function always return 0. Fix it using PTR_ERR(). Fixes: 52c0624a10cce phy: rockchip-emmc: Set phyctrl_frqsel based on card clock Signed-off-by: Chris Ruehl

Re: [PATCH] mmc: core: MMC_CAP2_HS200_1_8V_SDR with mmc-hs400-1_8v

2020-12-01 Thread Chris Ruehl
core: add DT bindings for eMMC HS400 1.8/1.2V Signed-off-by: Chris Ruehl Acked-by: Avri Altman -- GTSYS Limited RFID Technology 9/F, Unit E, R07, Kwai Shing Industrial Building Phase 2, 42-46 Tai Lin Pai Road, Kwai Chung, N.T., Hong Kong Tel (852) 9079 9521 Disclaimer: https://www.gtsys.com

Re: [PATCH] phy: rockchip-emmc: emmc_phy_init() always return 0

2020-12-03 Thread Chris Ruehl
Hi, On 2/12/2020 4:36 pm, Chris Ruehl wrote: On 2/12/2020 12:05 am, Doug Anderson wrote: Hi, On Mon, Nov 30, 2020 at 7:10 PM Chris Ruehl wrote: rockchip_emmc_phy_init() return variable is not set with the error value if clk_get() failed. The debug message print 0 on error and the function

[PATCH 0/2] phy: rockchip: set otapdlysec for in dts

2020-12-02 Thread Chris Ruehl
This patchset add support to set output-tapdelay-selec via dt property 2 files modified: drivers/phy/rockchip/phy-rockchip-emmc.c Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt Signed-off-by: Chris Ruehl ---

[PATCH 1/2] phy: rockchip-emmc: output tap delay dt property

2020-12-02 Thread Chris Ruehl
s, the old default 0x4 applies. Tested with our customized rk3399 to tune the eMMC. Signed-off-by: Chris Ruehl --- drivers/phy/rockchip/phy-rockchip-emmc.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/phy/rockchip/phy-rockchip-emmc.c b/drivers/phy/ro

[PATCH 2/2] devicetree: phy: rockchip-emmc add output-tapdelay-select

2020-12-02 Thread Chris Ruehl
Update the rockchip-emmc-phy.txt and add the u32 property 'output-tapdelay-select'. This allow to set the otapdlysec register. Tested with our customized rk3399 board to tune eMMC. Signed-off-by: Chris Ruehl --- Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 3 +

Re: [PATCH] phy: rockchip-emmc: emmc_phy_init() always return 0

2020-12-02 Thread Chris Ruehl
On 2/12/2020 12:05 am, Doug Anderson wrote: Hi, On Mon, Nov 30, 2020 at 7:10 PM Chris Ruehl wrote: rockchip_emmc_phy_init() return variable is not set with the error value if clk_get() failed. The debug message print 0 on error and the function always return 0. Fix it using PTR_ERR

[PATCH 2/3] mmc: core: make hs400 independent from hs200 init

2020-12-03 Thread Chris Ruehl
0 MiB, chardev (242:0) Tested with rk3399 customized board. Note: We had 20% failure rate in the current production "not boot" or "reboot issues" this patch solved it. Some boards had been cooled down to -20C have boot failures, after apply the patch they pass the QC. Sign

[PATCH 3/3] mmc: core: MMC_CAP2_HS200_1_8V_SDR with mmc-hs400-1_8v

2020-12-03 Thread Chris Ruehl
-by: Chris Ruehl --- drivers/mmc/core/host.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c index 96b2ca1f1b06..46fde60a2372 100644 --- a/drivers/mmc/core/host.c +++ b/drivers/mmc/core/host.c @@ -295,9 +295,9 @@ int mmc_of_pa

[PATCH 0/3] mmc: core: hs400 fix probe errors

2020-12-03 Thread Chris Ruehl
gt;caps2 when mmc-hs400-1_8v or mmc-hs400-1_2v is used in the dts. Signed-off-by: Chris Ruehl ---

[PATCH 1/3] mmc: core: prepare hs400 update, code order

2020-12-03 Thread Chris Ruehl
This patch didn't change functionality just move mmc_select_hs400() and mmc_hs200_to_hs400() between mmc_select_hs400es() and mmc_select_hs200 and fix checkpatch --script warings. Signed-off-by: Chris Ruehl --- drivers/mmc/core/mmc.c | 184 - 1

[PATCH 0/3] rockchip: emmc: rk3399 add vendor prefix

2020-12-13 Thread Chris Ruehl
This patchset follow up with commit Following the reference in vendor-prefixes.yaml, update implementation, devicetree binding dtsi and documentation for the phy-rockchip-emmc. Signed-off-by: Chris Ruehl --- Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 19

[PATCH 1/3] phy: rockchip: emmc, add vendor prefix to optional dts properties

2020-12-13 Thread Chris Ruehl
Update the implementation add "rockchip," vendor prefix for the optional dts properties. Prefix referred from vendor-prefixes.yaml Signed-off-by: Chris Ruehl --- drivers/phy/rockchip/phy-rockchip-emmc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/d

[PATCH 2/3] devicetree: dtsi: rk3399.dtsi, add "rockchip," vendor prefix

2020-12-13 Thread Chris Ruehl
Update rk3399.dtsi with the vendor prefix referred in vendor-prefixes.yaml. Optional property: rockchip,drive-impedance-ohm Signed-off-by: Chris Ruehl --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip

[PATCH 3/3] devicetree: dtsi: rk3399-puma.dtsi, add "rockchip," vendor prefix

2020-12-13 Thread Chris Ruehl
Update rk3399-puma.dtsi with the vendor prefix referred in vendor-prefixes.yaml. Optional property: rockchip,drive-impedance-ohm Signed-off-by: Chris Ruehl --- arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts

Re: [PATCH 0/3] rockchip: emmc: rk3399 add vendor prefix

2020-12-13 Thread Chris Ruehl
On 14/12/2020 10:47 am, Chris Ruehl wrote: This patchset follow up with commit Following the reference in vendor-prefixes.yaml, update implementation, devicetree binding dtsi and documentation for the phy-rockchip-emmc. Signed-off-by: Chris Ruehl --- Documentation/devicetree/bindings/phy

[PATCH v1 0/4] rockchip: emmc: rk3399 add vendor prefix

2020-12-13 Thread Chris Ruehl
This patchset follow up with commit 8b5c2b45b8f0a and a8cef928276bb Following the reference in vendor-prefixes.yaml, update implementation, devicetree binding dtsi and documentation for the phy-rockchip-emmc. Signed-off-by: Chris Ruehl --- Documentation/devicetree/bindings/phy/rockchip-emmc

[PATCH v1 1/4] devicetree: phy: rockchip-emmc optional add vendor prefix

2020-12-13 Thread Chris Ruehl
Update the documentation and add the vendor prefix to the optional properties referred in vendor-prefixes.yaml. Signed-off-by: Chris Ruehl --- .../bindings/phy/rockchip-emmc-phy.txt| 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/Documentation

[PATCH v1 4/4] devicetree: dtsi: rk3399-puma.dtsi, add "rockchip," vendor prefix

2020-12-13 Thread Chris Ruehl
Update rk3399-puma.dtsi with the vendor prefix referred in vendor-prefixes.yaml. Optional property: rockchip,drive-impedance-ohm Signed-off-by: Chris Ruehl --- arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts

[PATCH v1 2/4] phy: rockchip: emmc, add vendor prefix to optional dts properties

2020-12-13 Thread Chris Ruehl
Update the implementation add "rockchip," vendor prefix for the optional dts properties. Prefix referred from vendor-prefixes.yaml Signed-off-by: Chris Ruehl --- drivers/phy/rockchip/phy-rockchip-emmc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/d

[PATCH v1 3/4] devicetree: dtsi: rk3399.dtsi, add "rockchip," vendor prefix

2020-12-13 Thread Chris Ruehl
Update rk3399.dtsi with the vendor prefix referred in vendor-prefixes.yaml. Optional property: rockchip,drive-impedance-ohm Signed-off-by: Chris Ruehl --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip

[PATCH v2 1/2] devicetree: phy: rockchip-emmc optional add vendor prefix

2020-12-14 Thread Chris Ruehl
Update the documentation and add the vendor prefix to the optional properties referred in vendor-prefixes.yaml. Follow up with commit 8b5c2b45b8f0a ("phy: rockchip: set pulldown for strobe line in dts") commit a8cef928276bb ("phy: rockchip-emmc: output tap delay dt property")

[PATCH v2 2/2] phy: rockchip: emmc, add vendor prefix to dts properties

2020-12-14 Thread Chris Ruehl
put tap delay dt property") Signed-off-by: Chris Ruehl --- drivers/phy/rockchip/phy-rockchip-emmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-emmc.c b/drivers/phy/rockchip/phy-rockchip-emmc.c index 1e424f263e7a..860b2fbbb092 100

[PATCH v2 0/2] rockchip: emmc: rk3399 add vendor prefix

2020-12-14 Thread Chris Ruehl
lay dt property") Signed-off-by: Chris Ruehl --- v2 drop changes for ABI property driver-impedence-ohm no modification needed for dtsi files add commits follow up in commit messages Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 10 +- drivers/phy/rockchip

[PATCH 1/2] phy: rockchip: set pulldown for strobe line in dts

2020-11-26 Thread Chris Ruehl
had been tested with our rk3399 customized board. Signed-off-by: Chris Ruehl --- drivers/phy/rockchip/phy-rockchip-emmc.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/phy/rockchip/phy-rockchip-emmc.c b/drivers/phy/rockchip/phy-rockchip-emmc.c index 2dc19ddd120f

[PATCH 2/2] mmc: core: MMC_CAP2_HS200_1_8V_SDR with mmc-hs400-1_8v

2020-11-26 Thread Chris Ruehl
1.8/1.2V Signed-off-by: Chris Ruehl --- drivers/mmc/core/host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c index 96b2ca1f1b06..f55113e24c68 100644 --- a/drivers/mmc/core/host.c +++ b/drivers/mmc/core/host.c @@ -295,7 +295

[PATCH] mmc: core: MMC_CAP2_HS200_1_8V_SDR with mmc-hs400-1_8v

2020-11-26 Thread Chris Ruehl
1.8/1.2V Signed-off-by: Chris Ruehl --- drivers/mmc/core/host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c index 96b2ca1f1b06..f55113e24c68 100644 --- a/drivers/mmc/core/host.c +++ b/drivers/mmc/core/host.c @@ -295,7 +295

[PATCH v2 2/2] devicetree: phy: rockchip-emmc: pulldown property

2020-11-28 Thread Chris Ruehl
Update the documentation and add the bool property enable-strobe-pulldown used to enable the internal pull-down for the strobe line. Signed-off-by: Chris Ruehl --- Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation

[PATCH v2 1/2] phy: rockchip: set pulldown for strobe line in dts

2020-11-28 Thread Chris Ruehl
had been tested with our rk3399 customized board. Signed-off-by: Chris Ruehl --- drivers/phy/rockchip/phy-rockchip-emmc.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/phy/rockchip/phy-rockchip-emmc.c b/drivers/phy/rockchip/phy-rockchip-emmc.c index 2dc19ddd120f

[PATCH v2] phy: rockchip: set pulldown for strobe line in dts

2020-11-28 Thread Chris Ruehl
This patchset add support to set the strobe line pulldown via dt property 2 files modified: drivers/phy/rockchip/phy-rockchip-emmc.c Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt Signed-off-by: Chris Ruehl --- v2: - Fix issues show with checkpatch --strict - Add patch to update

Re: [PATCH] imx27: pinctrl: fix wrong offset to ICONFB

2014-01-21 Thread Chris Ruehl
Hi Markus, On Tuesday, January 21, 2014 06:24 PM, Markus Pargmann wrote: Hi, On Thu, Jan 16, 2014 at 09:18:23AM +0800, Chris Ruehl wrote: The offset to ICONFB was incorrect, this patch set the correct value 0x14. dev_dbg in function imx1_write_2bit print the wrong address and had been moved

[PATCH 2/2 v2] imx27: pinctrl: fix offset calculation in imx_read_2bit

2014-01-21 Thread Chris Ruehl
The offset for the 2bit register calculate wrong, this patch fixes the problem. The debugfs printout for oconf, iconfa, iconfb now shows the real values. Signed-off-by: Chris Ruehl --- drivers/pinctrl/pinctrl-imx1-core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 1/2 v2] imx27: pinctrl: fix wrong offset to ICONFB

2014-01-21 Thread Chris Ruehl
The offset to ICONFB was incorrect, this patch set the correct value 0x14. dev_dbg in function imx1_write_2bit print the wrong address and had been moved after address calculation. Signed-off-by: Chris Ruehl --- drivers/pinctrl/pinctrl-imx1-core.c |8 1 file changed, 4 insertions

[PATCH 1/2] net: dm9000: Read GPR, modify and write

2014-01-21 Thread Chris Ruehl
The GPR register should be read, modified and write to activate the PHY. A simple write 0 to the GPR might override other register values with needs to keep. Some codestyle fixes (mostly leading spaces) Signed-off-by: Chris Ruehl --- drivers/net/ethernet/davicom/dm9000.c | 23

[PATCH 2/2] net: dm9000: Only call PHY reset for TYPE-B on shutdown

2014-01-21 Thread Chris Ruehl
Unconditional call of PHY reset can triggers a fault to detect the link for DM9000A on reboot, only a hard reset can solve it. This patch check the version of the chip and call the PHY reset only for the B version of the chip. Signed-off-by: Chris Ruehl --- drivers/net/ethernet/davicom/dm9000.c

Re: [PATCH 1/2] net: dm9000: Read GPR, modify and write

2014-01-21 Thread Chris Ruehl
On Wednesday, January 22, 2014 03:15 PM, David Miller wrote: Please do not mix coding style and functional changes. Please resubmit this entire series once you have addressed all feedback. Thank you. Thanks for the advice. I will do. Chris -- To unsubscribe from this list: send the line "unsu

Re: Regression on next-20140116 [Was: [PATCH 3/3 v4] usb: chipidea: hw_phymode_configure moved before ci_usb_phy_init]

2014-01-22 Thread Chris Ruehl
On Thursday, January 23, 2014 09:22 AM, Peter Chen wrote: On Wed, Jan 22, 2014 at 10:41:33PM +0100, Uwe Kleine-König wrote: Hello, On Wed, Jan 22, 2014 at 10:49:51AM +0100, Uwe Kleine-König wrote: On Tue, Dec 03, 2013 at 04:01:50PM +0800, Chris Ruehl wrote: usb: chipidea

[PATCH 1/3] usb: chipidea: Reallocate regmap only if lpm is detected

2013-11-28 Thread Chris Ruehl
Signed-off-by: Chris Ruehl --- drivers/usb/chipidea/core.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 5d8981c..5075407 100644 --- a/drivers/usb/chipidea/core.c +++ b/drivers/usb/chipidea/core.c

[PATCH 2/3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-28 Thread Chris Ruehl
* init the sts flag to 0 (missed) * set the sts flag only if not 0 Signed-off-by: Chris Ruehl --- drivers/usb/chipidea/core.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 5075407..1a6010e 100644

[PATCH 3/3] usb: chipidea: hw_phymode_configure moved before ci_usb_phy_init

2013-11-28 Thread Chris Ruehl
hw_phymode_configure configures the PORTSC registers and allow the following phy_inits to operate on the right parameters. This fix a problem where the UPLI (ISP1504) could not detected, because the Viewport was not available and returns 0's only. Signed-off-by: Chris Ruehl --- driver

Re: [PATCH 3/3] usb: chipidea: hw_phymode_configure moved before ci_usb_phy_init

2013-11-28 Thread Chris Ruehl
Hi Fabio On Friday, November 29, 2013 10:14 AM, Fabio Estevam wrote: Hi Chris, On Fri, Nov 29, 2013 at 12:08 AM, Chris Ruehl wrote: hw_phymode_configure configures the PORTSC registers and allow the following phy_inits to operate on the right parameters. This fix a problem where the UPLI

Re: [PATCH 2/3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-28 Thread Chris Ruehl
, in the switch statement sts is set to 1 therefore I think its used. case USBPHY_INTERFACE_MODE_SERIAL: portsc = PORTSC_PTS(PTS_SERIAL); lpm = DEVLC_PTS(PTS_SERIAL); sts = 1; break; Regards Chris Signed-off-by: Chris

[PATCH 2/3 v2] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-28 Thread Chris Ruehl
usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag * init the sts flag to 0 (missed) * set the sts flag only if not 0 Signed-off-by: Chris Ruehl --- drivers/usb/chipidea/core.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/usb

[PATCH 1/3 v2] usb: chipidea: Reallocate regmap only if lpm is detected

2013-11-28 Thread Chris Ruehl
usb: chipidea: Reallocate regmap only if lpm is detected The regmap only needs to reallocate if the hw_read on the CAP register shows lpm is used. Therefore the if() statement check the change. Signed-off-by: Chris Ruehl --- drivers/usb/chipidea/core.c |3 ++- 1 file changed, 2 insertions

[PATCH 3/3 v2] usb: chipidea: hw_phymode_configure moved before ci_usb_phy_init

2013-11-28 Thread Chris Ruehl
returns 0's only. Signed-off-by: Chris Ruehl Acked-by: Peter Chen --- drivers/usb/chipidea/core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 1a6010e..f915538 100644 --- a/drivers/usb/chipidea/c

Re: [PATCH 2/3 v2] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-29 Thread Chris Ruehl
On Saturday, November 30, 2013 02:28 AM, Michael Grzeschik wrote: On Fri, Nov 29, 2013 at 03:19:45PM +0800, Chris Ruehl wrote: usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag * init the sts flag to 0 (missed) * set the sts flag only if not 0 Signed-off-by: Chris Ruehl

Re: [PATCH 2/3 v2] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-29 Thread Chris Ruehl
On Saturday, November 30, 2013 02:28 AM, Michael Grzeschik wrote: On Fri, Nov 29, 2013 at 03:19:45PM +0800, Chris Ruehl wrote: usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag * init the sts flag to 0 (missed) * set the sts flag only if not 0 Signed-off-by: Chris Ruehl

Re: [PATCH 2/3 v2] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-29 Thread Chris Ruehl
On Saturday, November 30, 2013 02:28 AM, Michael Grzeschik wrote: On Fri, Nov 29, 2013 at 03:19:45PM +0800, Chris Ruehl wrote: usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag * init the sts flag to 0 (missed) * set the sts flag only if not 0 Signed-off-by: Chris Ruehl

[PATCH 2/3 v3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-29 Thread Chris Ruehl
usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag * init the sts flag to 0 (missed) * Set PORTCS_STS only if VUSB_HS_PHY_TYPE > 1 otherwise the register is ReadOnly * Set/Reset correct BIT(28)/BIT(29) for STS Signed-off-by: Chris Ruehl --- drivers/usb/chipidea/cor

[PATCH 3/3 v3] usb: chipidea: hw_phymode_configure moved before ci_usb_phy_init

2013-11-29 Thread Chris Ruehl
register reads return 0's only. Signed-off-by: Chris Ruehl Acked-by: Peter Chen --- drivers/usb/chipidea/core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 2c634c1..50231f6 100644 --- a/driver

[PATCH 1/3 v3] usb: chipidea: Reallocate regmap only if lpm is detected

2013-11-29 Thread Chris Ruehl
usb: chipidea: Reallocate regmap only if lpm is detected The regmap only needs to reallocate if the hw_read on the CAP register shows lpm is used. Therefore the if() statement check the change. Signed-off-by: Chris Ruehl Acked-by: Peter Chen --- drivers/usb/chipidea/core.c |3 ++- 1 file

Re: [PATCH 2/3 v3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-12-01 Thread Chris Ruehl
STS Signed-off-by: Chris Ruehl --- drivers/usb/chipidea/core.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 5075407..2c634c1 100644 --- a/drivers/usb/chipidea/core.c +++ b/drivers/

Re: [PATCH 2/3 v3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-12-01 Thread Chris Ruehl
Hi On Sunday, December 01, 2013 01:28 AM, Sergei Shtylyov wrote: Hello. On 30-11-2013 7:51, Chris Ruehl wrote: usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag * init the sts flag to 0 (missed) * Set PORTCS_STS only if VUSB_HS_PHY_TYPE > 1 otherwise the register

Re: [PATCH 2/3 v3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-12-01 Thread Chris Ruehl
On Monday, December 02, 2013 01:10 PM, Peter Chen wrote: If you have a look into the function hw_write() you will see that there is no effect if hw_write(...,sts) is called with sts=0/1, because the mask will cut off all bits beside BIT(29). Yes, it is my careless. I thought sts is PORTCS_

[PATCH 3/3] usb: phy-generic: Add ULPI VBUS support

2013-12-01 Thread Chris Ruehl
p;gpio1 31 1>; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_usbphy0 &pinctrl_usbotg1>; ulpi_set_vbus = <0x0f>; }; Please refer to the phy-bindings.txt for the value of ulpi_set_vbus commit with this patch. Signed-off-by: Chris Ruehl --- .../devicetree/

[PATCH 2/3] usb: phy-ulpi: Add EXTVBUSIND,CHRGVBUS flag support

2013-12-01 Thread Chris Ruehl
usb: phy-ulpi: Add EXTVBUSIND,CHRGVBUS flag support ULPI like ISP1504 support external vbus power indication used in combination with vbus switches mic2075. Signed-off-by: Chris Ruehl --- drivers/usb/phy/phy-ulpi.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git

[PATCH 1/3] usb: phy-generic: Add GPIO based ChipSelect

2013-12-01 Thread Chris Ruehl
;; pinctrl-0 = <&pinctrl_usbphy2>; }; Signed-off-by: Chris Ruehl --- drivers/usb/phy/phy-generic.c | 31 +++ drivers/usb/phy/phy-generic.h |2 ++ 2 files changed, 33 insertions(+) diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic

[PATCH] usb: phy-generic, phy-ulpi patch set

2013-12-01 Thread Chris Ruehl
* EXTVBUSIND * CHRGVBUS of the ULPI. Signed-off-by: Chris Ruehl --- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FA

Re: [PATCH 3/3] usb: phy-generic: Add ULPI VBUS support

2013-12-02 Thread Chris Ruehl
On Tuesday, December 03, 2013 02:22 AM, Mark Rutland wrote: On Mon, Dec 02, 2013 at 07:05:19AM +, Chris Ruehl wrote: usb: phy-generic: Add ULPI VBUS support Some platforms need to set the VBUS parameters of the ULPI like ISP1504 which interact with overcurrent protection and power switch

Re: [PATCH 3/3] usb: phy-generic: Add ULPI VBUS support

2013-12-02 Thread Chris Ruehl
On Tuesday, December 03, 2013 02:22 AM, Mark Rutland wrote: On Mon, Dec 02, 2013 at 07:05:19AM +, Chris Ruehl wrote: usb: phy-generic: Add ULPI VBUS support Some platforms need to set the VBUS parameters of the ULPI like ISP1504 which interact with overcurrent protection and power switch

[PATCH 1/3 v4] usb: chipidea: Reallocate regmap only if lpm is detected

2013-12-03 Thread Chris Ruehl
usb: chipidea: Reallocate regmap only if lpm is detected The regmap only needs to reallocate if the hw_read on the CAP register shows lpm is used. Therefore the if() statement check the change. Signed-off-by: Chris Ruehl Acked-by: Peter Chen --- drivers/usb/chipidea/core.c |7 ++- 1

[PATCH 2/3 v4] Fix Internal error: : 808 [#1] ARM related to STS flag

2013-12-03 Thread Chris Ruehl
Fix Internal error: : 808 [#1] ARM related to STS flag * init the sts flag to 0 (missed) * fix write the real bit not sts value * Set PORTCS_STS and DEVLC_STS only if sts = 1 (prefered solution by Mr. Peter Chen, Maintainer of ChipIdea subsystem) Signed-off-by: Chris Ruehl --- drivers/usb

[PATCH 3/3 v4] usb: chipidea: hw_phymode_configure moved before ci_usb_phy_init

2013-12-03 Thread Chris Ruehl
read the viewport return 0's only. Signed-off-by: Chris Ruehl Acked-by: Peter Chen --- drivers/usb/chipidea/core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 2834801..43897dd 100644 --- a/driver

Re: [PATCH 1/3 v4] usb: chipidea: Reallocate regmap only if lpm is detected

2013-12-03 Thread Chris Ruehl
@@ -642,6 +643,10 @@ static int ci_hdrc_probe(struct platform_device *pdev) : CI_ROLE_GADGET; } + /* only update vbus status for peripheral */ + if (ci->role == CI_ROLE_GADGET) + ci_handle_vbus_change(ci); + This change seems unrelated t

[PATCH 3/3 v5] usb: chipidea: put hw_phymode_configure before ci_usb_phy_init

2013-12-03 Thread Chris Ruehl
read the viewport return 0's only. Signed-off-by: Chris Ruehl Acked-by: Peter Chen --- drivers/usb/chipidea/core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 2834801..43897dd 100644 --- a/driver

[PATCH 2/3 v5] Fix Internal error: : 808 [#1] ARM related to STS flag

2013-12-03 Thread Chris Ruehl
Fix Internal error: : 808 [#1] ARM related to STS flag * init the sts flag to 0 (missed) * fix write the real bit not sts value * Set PORTCS_STS and DEVLC_STS only if sts = 1 (prefered solution by Mr. Peter Chen, Maintainer of ChipIdea subsystem) Signed-off-by: Chris Ruehl --- drivers/usb

[PATCH 1/3 v5] usb: chipidea: Reallocate regmap only if lpm is detected

2013-12-03 Thread Chris Ruehl
usb: chipidea: Reallocate regmap only if lpm is detected The regmap only needs to reallocate if the hw_read on the CAP register shows lpm is used. Therefore the if() statement check the change. Signed-off-by: Chris Ruehl Acked-by: Peter Chen --- drivers/usb/chipidea/core.c |7 ++- 1

[PATCH 7/7] usb: phy-tegra-usb.c: wrong pointer check for remap UTMI

2013-12-03 Thread Chris Ruehl
usb: phy-tegra-usb.c: wrong pointer check for remap UTMI A wrong pointer was used to test the result of devm_ioremap() Signed-off-by: Chris Ruehl Acked-by: Venu Byravarasu --- drivers/usb/phy/phy-tegra-usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb

Re: [PATCH 7/7] usb: phy-tegra-usb.c: wrong pointer check for remap UTMI

2013-12-03 Thread Chris Ruehl
Sorry for the noise, it should be [PATCH] only .. I will resend it. On Wednesday, December 04, 2013 10:00 AM, Chris Ruehl wrote: usb: phy-tegra-usb.c: wrong pointer check for remap UTMI A wrong pointer was used to test the result of devm_ioremap() Signed-off-by: Chris Ruehl Acked-by: Venu

[PATCH] usb: phy-tegra-usb.c: wrong pointer check for remap UTMI

2013-12-03 Thread Chris Ruehl
usb: phy-tegra-usb.c: wrong pointer check for remap UTMI A wrong pointer was used to test the result of devm_ioremap() Signed-off-by: Chris Ruehl Acked-by: Venu Byravarasu --- drivers/usb/phy/phy-tegra-usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb

Re: [PATCH 3/3] usb: phy-generic: Add ULPI VBUS support

2013-12-03 Thread Chris Ruehl
On Tuesday, December 03, 2013 04:15 PM, Heikki Krogerus wrote: On Mon, Dec 02, 2013 at 03:05:19PM +0800, Chris Ruehl wrote: @@ -154,6 +164,27 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_gen_xceiv *nop, { int err; + if (nop->ulpi_vbus&

[PATCH] imx27: pinctrl: fix wrong offset to ICONFB

2014-01-15 Thread Chris Ruehl
The offset to ICONFB was incorrect, this patch set the correct value 0x14. dev_dbg in function imx1_write_2bit print the wrong address and had been moved after address calculation. Signed-off-by: Chris Ruehl --- drivers/pinctrl/pinctrl-imx1-core.c |8 1 file changed, 4 insertions

[PATCH 2/2] mxcmmc: Internal error: Oops: 17 [#1] ARM from sg->offset

2014-01-15 Thread Chris Ruehl
amp; 3 || sg->length < 512) { 351host->do_dma = 0; 352return 0; 353} 354 } Signed-off-by: Chris Ruehl --- drivers/mmc/host/mxcmmc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/mxcmmc.c b/dr

Re: [PATCH 3/3] usb: phy-generic: Add ULPI VBUS support

2013-12-04 Thread Chris Ruehl
On Wednesday, December 04, 2013 05:49 PM, Heikki Krogerus wrote: Hi Chris, On Wed, Dec 04, 2013 at 03:16:21PM +0800, Chris Ruehl wrote: On Tuesday, December 03, 2013 04:15 PM, Heikki Krogerus wrote: On Mon, Dec 02, 2013 at 03:05:19PM +0800, Chris Ruehl wrote: @@ -154,6 +164,27 @@ int

Re: [PATCH 1/3] usb: phy-generic: Add GPIO based ChipSelect

2013-12-08 Thread Chris Ruehl
On Saturday, December 07, 2013 04:24 AM, Felipe Balbi wrote: Hi, On Mon, Dec 02, 2013 at 03:05:17PM +0800, Chris Ruehl wrote: @@ -231,27 +249,40 @@ static int usb_phy_gen_xceiv_probe(struct platform_device *pdev) return -ENOMEM; nop->reset_active_low = t

Re: [PATCH 1/3] usb: phy-generic: Add GPIO based ChipSelect

2013-12-08 Thread Chris Ruehl
On Monday, December 09, 2013 12:07 PM, Felipe Balbi wrote: Hi, On Mon, Dec 09, 2013 at 09:45:30AM +0800, Chris Ruehl wrote: On Saturday, December 07, 2013 04:24 AM, Felipe Balbi wrote: Hi, On Mon, Dec 02, 2013 at 03:05:17PM +0800, Chris Ruehl wrote: @@ -231,27 +249,40 @@ static int

Re: [PATCH] serial: imx: enable IMX21_UCR3_RXDMUXSEL for non-dte-mode

2018-05-03 Thread Chris Ruehl
The IMX serial driver is broken in the 4.9.x tree since 4.9.89. Uwe's patch 6df765dca378bddf994cfd2044acafa501bd800f please apply to clear the situation. I know you very busy! - It's best to email sta...@vger.kernel.org for stuff like this, as I almost missed it... Now queued up. greg k-h

[PATCH] serial: imx: enable IMX21_UCR3_RXDMUXSEL for non-dte-mode

2018-04-19 Thread Chris Ruehl
Fix a problem introduced with commit e61c38d85b73 ("serial: imx: setup DCEDTE early and ensure DCD and RI irqs to be off") result in non dte-mode imx-uart fail receive data. By add back IMX21_UCR3_RXDMUXSEL the serial port works as expected. Signed-off-by: Chris Ruehl --- drivers/

Re: [PATCH] serial: imx: enable IMX21_UCR3_RXDMUXSEL for non-dte-mode

2018-04-20 Thread Chris Ruehl
On Friday, April 20, 2018 02:13 PM, Uwe Kleine-König wrote: Hello Chris, On Fri, Apr 20, 2018 at 09:07:59AM +0800, Chris Ruehl wrote: Fix a problem introduced with commit e61c38d85b73 ("serial: imx: setup DCEDTE early and ensure DCD and RI irqs to be off") result in non dte-mode imx

[PATCH] shtc1: add support for device tree bindings

2020-07-02 Thread Chris Ruehl
Add support for DTS bindings to the shtc driver The patches add the compatible table and of_property_read* to the shtc1.c. Newly created Yaml document has been released to the Documentation/devicetree/hwmon/sensirion,shtc1.yaml Signed-off-by: Chris Ruehl --- Version 1

[PATCH 2/2] devicetree: hwmon: shtc1: Add sensirion,shtc1.yaml

2020-07-02 Thread Chris Ruehl
Add documentation for the newly added DTS support in the shtc1 driver. Signed-off-by: Chris Ruehl --- .../bindings/hwmon/sensirion,shtc1.yaml | 53 +++ 1 file changed, 53 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml diff

[PATCH 1/2] hwmon: shtc1: add support for device tree bindings

2020-07-02 Thread Chris Ruehl
Add support for DTS bindings to the shtc driver, use CONFIG_OF to compile in the code if needed. Signed-off-by: Chris Ruehl --- drivers/hwmon/shtc1.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/hwmon/shtc1.c b/drivers/hwmon/shtc1.c index

  1   2   >