Re: BUG: scheduling while atomic: ifup-bonding/3711/0x00000002 -- V3.6.7

2012-11-27 Thread Cong Wang
Cc netdev... On Wed, Nov 28, 2012 at 4:37 AM, Linda Walsh wrote: > > > Is this a known problem / bug, or should I file a bug on it? It doesn't > cause a complete failure, and it happens multiple times (~28 times > in 2.5 days?... so maybe 10x/day?) about 8 start with ifup, and the rest > start

Re: No sysfs directory for openvswitch module when built-in

2013-02-05 Thread Cong Wang
On Tue, Feb 5, 2013 at 2:08 PM, Ben Pfaff wrote: > Stephen Hemminger writes: > >> On Tue, 29 Jan 2013 22:15:18 +0800 >> Cong Wang wrote: >> >>> Hello, Rusty, Jesse, >>> >>> I met an interesting problem when I compile openvswitch module as a >

Re: [PATCH 0/2] fix kernel crash with macvtap on top of LRO

2013-02-06 Thread Cong Wang
On 02/07/2013 07:02 AM, Michael S. Tsirkin wrote: At the moment, macvtap crashes are observed if macvtap is attached to an interface with LRO enabled. The crash in question is BUG() in macvtap_skb_to_vnet_hdr. This happens because several drivers set gso_size but not gso_type in incoming skbs. Th

Re: net: rcu warnings in ip6fl_get_first

2013-02-07 Thread Cong Wang
["Followup-To:" header set to gmane.linux.network.] On Thu, 07 Feb 2013 at 19:32 GMT, Sasha Levin wrote: > Hi guys, > > I got the following while fuzzing with trinity inside a KVM tools guest: > > [ 51.680236] === > [ 51.681914] [ INFO: suspicious RCU usage. ] > [

Re: net: rcu warnings in ip6fl_get_first

2013-02-07 Thread Cong Wang
On Thu, 07 Feb 2013 at 19:32 GMT, Sasha Levin wrote: > Hi guys, > > I got the following while fuzzing with trinity inside a KVM tools guest: > > [ 51.680236] === > [ 51.681914] [ INFO: suspicious RCU usage. ] > [ 51.683610] 3.8.0-rc6-next-20130206-sasha-00028-g832

Re: linux-next: manual merge of the akpm tree with the net-next tree

2013-02-19 Thread Cong Wang
On 02/20/2013 02:02 PM, Stephen Rothwell wrote: Hi Andrew, Today's linux-next merge of the akpm tree got a conflict in net/core/dev.c between commit 900ff8c63214 ("net: move procfs code to net/core/net-procfs.c") from the net-next tree and commit "hlist: drop the node parameter from iterators" f

Re: [PATCH] Add feature-removal-schedule.txt removal to feature-removal-schedule.txt

2012-08-28 Thread Cong Wang
On Tue, Aug 28, 2012 at 2:22 AM, Steven Rostedt wrote: > The file feature-removal-schedule.txt is ignored by most people except > for people that add to it. It's more of a global TODO list for > developers than being anything useful by anyone. > > Add a feature removal of removing the feature-remo

Re: [PATCH 1/3] proc: return -ENOMEM when inode allocation failed

2012-09-03 Thread Cong Wang
On 09/03/2012 10:14 PM, yan wrote: Signed-off-by: yan Please provide a changelog to explain why we need this patch. --- fs/proc/generic.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/generic.c b/fs/proc/generic.c index b3647fe..9e8f631 100644 --- a/fs/pr

Re: need help on development of linux kernel

2012-09-04 Thread Cong Wang
On 08/30/2012 12:15 PM, Sachin Agarwalla wrote: Dear Sir/Madam, I have some questions on development of linux kernel as follows:- 1.I want to know the location of files in linux kernel source code that contains timer initialization and scheduler part. Scheduler source code is in kernel/sche

Re: linux page table

2012-09-04 Thread Cong Wang
On 09/03/2012 02:26 AM, Jiri Kosina wrote: On Sun, 2 Sep 2012, Xin Tong wrote: 3. can two different processes have their CR3 being the same value even though they have different first level page tables ? Yes, if they are created by clone(CLONE_VM). In such case they share the same mm_struct,

Re: [PATCH 1/3] proc: return -ENOMEM when inode allocation failed

2012-09-05 Thread Cong Wang
On 09/04/2012 05:22 PM, yan yan wrote: 2012/9/4 Cong Wang : On 09/03/2012 10:14 PM, yan wrote: Signed-off-by: yan Please provide a changelog to explain why we need this patch. I think the title is self explained. --- fs/proc/generic.c |2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] fs: prevent double-free on an error path in core dumper

2012-09-11 Thread Cong Wang
On Tue, 2012-09-11 at 17:59 +0200, Oleg Nesterov wrote: > But, again, the caller does free_note_info(), so why > elf_note_info_init() > tries to handle the kmalloc failures? Afaics, we can simplify the code > and fix the bug. > > What do you think about the patch below? Looks reasonable and neat

Re: Question on /proc/cpuinfo

2012-09-14 Thread Cong Wang
On 09/14/2012 07:18 AM, JA Magallón wrote: Hi... Probably it is a stupid question, but... I wan to count the number of processors, cores and threads on a linux system. I do it by reading /proc/cpuinfo. ... Since when is it safe to read things the modern way (kernel version ?). Is there a bet

Re: [PATCH RFC] pkt_sched: enable QFQ to support TSO/GSO

2012-11-05 Thread Cong Wang
comment to >> the function slot_insert. >> >> [1] http://marc.info/?l=linux-netdev&m=134968777902077&w=2 >> [2] http://marc.info/?l=linux-netdev&m=135096573507936&w=2 >> [3] http://marc.info/?l=linux-netdev&m=134902691421670&w=2 >> >>

Re: [RFC PATCH] netconsole.txt: "nc" needs "-p" to specify the listening port

2012-07-27 Thread Cong Wang
On Fri, Jul 27, 2012 at 2:35 PM, Dirk Gouders wrote: > Hi Jesse, > > I would like to ask you to check if the documentation of "nc" in > netconsole.txt is still correct. I tried two different netcat packages > and both require "-p" to specify the listening port. I am wondering if > that changed a

[PATCH 4/7] bridge: call NETDEV_RELEASE notifier in br_del_if()

2012-07-27 Thread Cong Wang
When a bridge interface deletes its underlying ports, it should notify netconsole too, like what bonding interface does. Cc: "David S. Miller" Signed-off-by: Cong Wang --- net/bridge/br_if.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/bridge/br_

[PATCH 3/7] netconsole: do not release spin_lock before calling __netpoll_cleanup

2012-07-27 Thread Cong Wang
With the previous patch applied, __netpoll_cleanup() is non-block now, so we don't need to release the spin_lock before calling it. Cc: "David S. Miller" Signed-off-by: Cong Wang --- drivers/net/netconsole.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff

[PATCH 1/7] netpoll: use GFP_ATOMIC in slave_enable_netpoll() and __netpoll_setup()

2012-07-27 Thread Cong Wang
slave_enable_netpoll() and __netpoll_setup() may be called with read_lock() held, so should use GFP_ATOMIC to allocate memory. Cc: "David S. Miller" Reported-by: Dan Carpenter Signed-off-by: Cong Wang --- drivers/net/bonding/bond_main.c |2 +- net/core/netpoll.c |

[PATCH 5/7] netpoll: take rcu_read_lock_bh() in netpoll_rx()

2012-07-27 Thread Cong Wang
In __netpoll_rx(), it dereferences ->npinfo without rcu_dereference_bh(), this patch fixes it by using the 'npinfo' passed from netpoll_rx() where it is already dereferenced with rcu_dereference_bh(). Cc: "David S. Miller" Signed-off-by: Cong Wang --- include/linux/net

[PATCH 7/7] netpoll: take rcu_read_lock_bh() in netpoll_send_skb_on_dev()

2012-07-27 Thread Cong Wang
to dereference ->npinfo. 3. Rename arp_reply() to netpoll_arp_reply(), the former is too generic. Cc: "David S. Miller" Signed-off-by: Cong Wang --- net/core/netpoll.c | 31 +-- 1 files changed, 17 insertions(+), 14 deletions(-) diff --git a/net/core/ne

[PATCH 6/7] netpoll: use netpoll_rx_on() in netpoll_rx()

2012-07-27 Thread Cong Wang
The logic of the code is same, just call netpoll_rx_on(). Cc: "David S. Miller" Signed-off-by: Cong Wang --- include/linux/netpoll.h | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/include/linux/netpoll.h b/include/linux/netpoll.h ind

[PATCH 2/7] netpoll: make __netpoll_cleanup non-block

2012-07-27 Thread Cong Wang
Like the previous patch, slave_disable_netpoll() and __netpoll_cleanup() may be called with read_lock() held too, so we should make them non-block, by moving the cleanup and kfree() to call_rcu_bh() callbacks. Cc: "David S. Miller" Signed-off-by: Cong Wang --- drivers/net/bonding/b

[GIT PULL] kmap_atomic final cleanups for 3.6

2012-07-27 Thread Cong Wang
hanks! Cong Wang (14): jbd2: remove the second argument of kmap_atomic frv: remove the second parameter of kmap_atomic_primary() tile: remove usage of enum km_type highmem: remove the deprecated form of kmap_atomic arm: remove km_type definitions powerpc: remove km_type definitions frv: r

Re: [PATCH 2/7] netpoll: make __netpoll_cleanup non-block

2012-07-29 Thread Cong Wang
On Fri, 2012-07-27 at 14:40 -0400, Neil Horman wrote: > Here, and above I see you using an rcu_head to defer cleanup, until after all > pointer uses are dropped, but I don't see any modification of code points that > dereference any struct netpoll pointers to include > rcu_read_lock()/rcu_read_unlo

Re: [PATCH 4/7] bridge: call NETDEV_RELEASE notifier in br_del_if()

2012-07-29 Thread Cong Wang
On Fri, 2012-07-27 at 08:50 -0700, Stephen Hemminger wrote: > On Fri, 27 Jul 2012 23:38:01 +0800 > Cong Wang wrote: > > > When a bridge interface deletes its underlying ports, it should > > notify netconsole too, like what bonding interface does. > > > > Cc: &qu

Re: [PATCH RFC] pkt_sched: enable QFQ to support TSO/GSO

2012-10-29 Thread Cong Wang
ed-off-by: Paolo Valente Please respect people who helps you to test it: Tested-by: Cong Wang I tested it again just in case... By the way, one nit below: + if (unlikely(cl->lmax < qdisc_pkt_len(skb))) { + pr_notice("qfq: increasing maxpkt from %u to %u for clas

Re: [PATCH RFC] pkt_sched: enable QFQ to support TSO/GSO

2012-10-29 Thread Cong Wang
On 10/29/2012 07:24 PM, Paolo Valente wrote: Il 29/10/2012 12:08, Cong Wang ha scritto: Please respect people who helps you to test it: Tested-by: Cong Wang Oops, really sorry about that. I did not mean to hide your contribution. I am just not familiar with the process. No problem

Re: [PATCH] bonding: fix bond 6 mode change MAC of arp reply from vif to cause Domu's network unreachable intermittently

2012-10-29 Thread Cong Wang
On Tue, 30 Oct 2012 at 02:47 GMT, Zheng Li wrote: > + struct slave *tmp_slave = NULL; > + int i = 0, found_mac = 0; > + bond_for_each_slave(bond, tmp_slave, i) { > + if (ether_addr_equal_64bits(arp->mac_src, >

Re: 3.11-rc7:BUG: soft lockup

2013-08-30 Thread Cong Wang
Cc'ing netdev On Fri, Aug 30, 2013 at 4:20 PM, Baoquan He wrote: > Hi, > > I tried the 3.11.0-rc7+ on x86_64, and after bootup, the soft lockup bug > happened. > > [ 48.895000] BUG: soft lockup - CPU#1 stuck for 22s! [ebtables:444] > [ 48.901191] Modules linked in: bnep(F) bluetooth(F) ebtabl

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2013-09-02 Thread Cong Wang
On Mon, 2013-09-02 at 19:11 +1000, Stephen Rothwell wrote: > Hi all, > > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/net/vxlan.c: In function 'vxlan6_xmit_skb': > drivers/net/vxlan.c:1441:3: error: implicit declaration of function

Re: kexec/kdump kernel fails to start

2012-09-05 Thread Cong Wang
On Wed, Sep 5, 2012 at 1:32 AM, Flavio Leitner wrote: > Hi folks, > > I have system that no longer boots kdump kernel. Basically, > > # echo c > /proc/sysrq-trigger > > to dump a vmcore doesn't work. It just hangs after showing the usual > panic messages. I've bisected the problem and the commit i

Re: [PATCH] Add feature-removal-schedule.txt removal to feature-removal-schedule.txt

2012-09-06 Thread Cong Wang
On Tue, Sep 4, 2012 at 11:39 PM, Steven Rostedt wrote: > On Wed, 2012-08-29 at 09:28 +0800, Cong Wang wrote: >> On Tue, Aug 28, 2012 at 2:22 AM, Steven Rostedt wrote: >> > The file feature-removal-schedule.txt is ignored by most people except >> > for people that add t

Re: F_DUPFD_CLOEXEC broken in 3.7.0

2012-10-09 Thread Cong Wang
On Tue, Oct 9, 2012 at 6:05 AM, Richard W.M. Jones wrote: > Let's move this to LKML ... > > On Mon, Oct 08, 2012 at 10:53:25PM +0100, Richard W.M. Jones wrote: >> On Mon, Oct 08, 2012 at 10:50:30PM +0100, Richard W.M. Jones wrote: >> [.. discussion on gnulib test-cloexec test snipped ..] >> > I'm

Re: [PATCH net-next? V2] pktgen: Use simpler test for non-zero ipv6 address

2012-10-10 Thread Cong Wang
On Thu, Oct 11, 2012 at 3:23 AM, Joe Perches wrote: > Reduces object size and should be slightly faster. > > allyesconfig: > $ size net/core/pktgen.o* >textdata bss dec hex filename > 522844321 11840 68445 10b5d net/core/pktgen.o.new > 523104293 11848 6845

Re: kexec/kdump kernel fails to start

2012-10-18 Thread Cong Wang
; bd2753b2dda7bb43c7468826de75f49c6a7e8965 > So we need revert both of these two commits. > > Tested kdump on physical and virutual machines. Looks good to me, Acked-by: Cong Wang Thanks for the fix! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in t

Re: Quick question: Maintainers for scripts

2012-10-21 Thread Cong Wang
On Mon, Oct 22, 2012 at 6:35 AM, Cruz Julian Bishop wrote: > Hi everyone, > > I was just wondering - Since (last time I looked, anyway), > /scripts/* has no maintainer, who would I send patches to? > > Would I just send them to the mailing list, or is there a > sort of catch-all maintainer for thi

Re: [PATCH] net: core: fix unused variable sparse warning

2012-12-06 Thread Cong Wang
On Fri, 07 Dec 2012 at 00:06 GMT, Cong Ding wrote: > the variables zero and unres_qlen_max are only used when CONFIG_SYSCTL is > defined, otherwise it causes the following sparse warning when we turn on > CONFIG_SYSCTL. > commit b93196dc5af7729ff7cc50d3d322ab1a364aa14f Author: Con

Re: [PATCH] fb: Rework locking to fix lock ordering on takeover

2012-12-25 Thread Cong Wang
On Wed, Dec 26, 2012 at 12:08 AM, Sasha Levin wrote: > On Tue, Dec 18, 2012 at 10:20 AM, Josh Boyer wrote: >> On Wed, Nov 21, 2012 at 7:53 AM, Alan Cox wrote: >>> On Wed, 21 Nov 2012 07:45:45 -0500 >>> Josh Boyer wrote: >>> On Fri, Nov 16, 2012 at 2:27 PM, Alan Cox wrote: > > [T

Re: [3.8-rc1] Networking problems after pulling-in net.git#master

2012-12-23 Thread Cong Wang
On Sun, Dec 23, 2012 at 9:19 PM, Sedat Dilek wrote: > > The culprit commit here seems to be... > > commit 9650388b5c56578fdccc79c57a8c82fb92b8e7f1 > Author: Eric Dumazet > Date: Fri Dec 21 07:32:10 2012 + > > ipv4: arp: fix a lockdep splat in arp_solicit() Can you try the following one

Re: [3.8-rc1] Networking problems after pulling-in net.git#master

2012-12-23 Thread Cong Wang
On Sun, Dec 23, 2012 at 10:14 PM, Sedat Dilek wrote: > > [ CCing Eric ] > > YES, thie fixes my problem. > But your patch was somehow malformed, so I attached mine. > Thanks for testing! I knew it as I replied in wed Gmail. :) I will send a normal patch with your Reported-by and Tested-by. -- To

Re: [3.8-rc1] Networking problems after pulling-in net.git#master

2012-12-23 Thread Cong Wang
On Sun, Dec 23, 2012 at 10:10 PM, Julian Anastasov wrote: >> - memset(dst_ha, 0, dev->addr_len); >> + memcpy(dst_ha, dev->broadcast, MAX_ADDR_LEN); > > Use dev->addr_len instead of MAX_ADDR_LEN or > better provide NULL ptr to arp_send as before the > "ipv4: arp:

Re: [netlink] WARNING: at mm/vmalloc.c:1487 __vunmap()

2013-06-14 Thread Cong Wang
On Sat, Jun 15, 2013 at 6:01 AM, Fengguang Wu wrote: > Greetings, > > I got the below dmesg and the first bad commit is > > commit c05cdb1b864f548c0c3d8ae3b51264e6739a69b1 > Author: Pablo Neira Ayuso > Date: Mon Jun 3 09:46:28 2013 + > > netlink: allow large data transfers from user-spa

Re: [netlink] WARNING: at mm/vmalloc.c:1487 __vunmap()

2013-06-14 Thread Cong Wang
On Sat, Jun 15, 2013 at 1:57 PM, Cong Wang wrote: > > Hi, Fengguang, > > Could you try the following quick fix? > > diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c > index 8978755..d8c6c03 100644 > --- a/net/netlink/af_netlink.c > +++ b/net/netlink/af_n

Re: [PATCH net/3.9] ipv6: ndisc: fix ndisc_send_redirect writing to the wrong skb

2013-05-30 Thread Cong Wang
tthias Schiffer Good catch! Reviewed-by: Cong Wang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v7 net-next 4/5] ixgbe: Add support for ndo_ll_poll

2013-05-30 Thread Cong Wang
On Thu, May 30, 2013 at 7:41 PM, Eliezer Tamir wrote: > +#else /* CONFIG_NET_LL_RX_POLL */ > +static inline void ixgbe_qv_init_lock(struct ixgbe_q_vector *q_vector) > +{ > +} > + > +static inline int ixgbe_qv_lock_napi(struct ixgbe_q_vector *q_vector) > +{ > + return true; > +} > + > +s

Re: 'rmmod -f ipv6': BUG: unable to handle kernel paging request

2013-07-04 Thread Cong Wang
On Fri, Jul 5, 2013 at 5:29 AM, David Miller wrote: > From: Linus Lüssing > Date: Thu, 4 Jul 2013 23:04:34 +0200 > >> When trying to perform a forceful unload of an ipv6 kernel module >> on a 3.10 kernel then I'm getting a kernel panic with the attached >> trace. >> >> Is this supposed to happen

Re: KVM VM shutdown triggers BUG from network bridge code in 3.9.9

2013-07-05 Thread Cong Wang
On Fri, 05 Jul 2013 at 04:30 GMT, Robert Hancock wrote: > I've run into a problem after updating to Fedora 19 where if I shut down > a Windows 7 KVM virtual machine, the machine hits a kernel panic. There > are a few reports of this on 3.9.8 and 3.9.9 kernels here: > > https://bugzilla.redhat.co

[RFC Patch net-next 5/5] nfs,cifs: abstract generic inet_addr_equal_strict()

2013-06-26 Thread Cong Wang
Signed-off-by: Cong Wang --- fs/cifs/connect.c | 38 - fs/dlm/lowcomms.c | 24 ++- fs/nfs/client.c| 94 ++- fs/nfs/nfs4filelayoutdev.c | 37 ++--- fs/nfs/super.c | 31

[RFC Patch net-next 1/5] net: introduce generic union inet_addr

2013-06-26 Thread Cong Wang
Cc: Daniel Borkmann Signed-off-by: Cong Wang --- Documentation/printk-formats.txt |9 + drivers/net/netconsole.c | 22 ++--- include/linux/netpoll.h |9 +- include/net/inet_addr.h | 62 ++ lib/vsprintf.c

[RFC Patch net-next 2/5] net: introduce generic inet_pton()

2013-06-26 Thread Cong Wang
Signed-off-by: Cong Wang --- include/net/inet_addr.h | 20 net/core/netpoll.c | 24 ++-- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/include/net/inet_addr.h b/include/net/inet_addr.h index 66a16fe..1379287 100644 --- a

[RFC Patch net-next 4/5] sunrpc: use generic union inet_addr

2013-06-26 Thread Cong Wang
Signed-off-by: Cong Wang --- include/linux/sunrpc/addr.h | 119 +++ include/net/inet_addr.h | 56 2 files changed, 64 insertions(+), 111 deletions(-) diff --git a/include/linux/sunrpc/addr.h b/include/linux/sunrpc/addr.h index

[RFC Patch net-next 3/5] inetpeer: use generic union inet_addr

2013-06-26 Thread Cong Wang
Signed-off-by: Cong Wang --- include/net/inetpeer.h | 29 +-- net/ipv4/inetpeer.c| 35 +++--- net/ipv4/tcp_metrics.c | 92 3 files changed, 68 insertions(+), 88 deletions(-) diff --git a/include/net/inetpeer.h b

Re: [RFC Patch net-next 2/5] net: introduce generic inet_pton()

2013-07-01 Thread Cong Wang
On Thu, 2013-06-27 at 16:32 +0100, Ben Hutchings wrote: > The return values for this are awful. I think the return value should > be 0 for success or -EINVAL on error. > > The caller can then check addr->sa.sa_family if they want to know the > address family immediately. Indeed, I will fix it.

Re: [RFC Patch net-next 2/5] net: introduce generic inet_pton()

2013-07-01 Thread Cong Wang
On Thu, 2013-06-27 at 14:51 -0700, Stephen Hemminger wrote: > > > > +static inline int inet_pton(const char *str, union inet_addr *addr) > > +{ > > > > A couple of comments: > 1. No reason for this to be inline Okay, I will move them into net/core/utils.c. > 2. If function has same name as use

Re: [RFC Patch net-next 4/5] sunrpc: use generic union inet_addr

2013-07-01 Thread Cong Wang
On Thu, 2013-06-27 at 16:37 +0100, Ben Hutchings wrote: > Most of the other functions work on IPv6 addresses without > CONFIG_IPV6; > why should this be different? Save few cycles for !CONFIG_IPV6? :-/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

Re: [RFC Patch net-next 4/5] sunrpc: use generic union inet_addr

2013-07-01 Thread Cong Wang
On Thu, 2013-06-27 at 16:36 +0100, Ben Hutchings wrote: > On Thu, 2013-06-27 at 14:43 +0800, Cong Wang wrote: > [...] > > -/** > > - * rpc_cmp_addr - compare the address portion of two sockaddrs. > > - * @sap1: first sockaddr > > - * @sap2: second sockaddr > >

Re: [RFC Patch net-next 3/5] inetpeer: use generic union inet_addr

2013-07-01 Thread Cong Wang
On Thu, 2013-06-27 at 01:01 -0700, Eric Dumazet wrote: > On Thu, 2013-06-27 at 14:43 +0800, Cong Wang wrote: > > struct inet_peer { > > /* group together avl_left,avl_right,v4daddr to speedup lookups */ > > struct inet_peer __rcu *avl_left, *avl_right; > &g

Re: [PATCH] bond: Don't set skb->queue_mapping in netpoll.

2013-08-15 Thread Cong Wang
On Thu, 2013-08-15 at 16:36 +0800, Tao Ma wrote: > From: Tao Ma > > When we are using netpoll, we don't go through the normal > transmit process. In this case, bond_select_queue is not called > and qdisc_skb_cb(skb)->slave_dev_queue_mapping isn't set. > Yes? In netpoll_send_skb_on_dev() we hav

[Patch net-next v3 2/9] net: rename '%pIS' to '%pIA' for union inet_addr

2013-08-19 Thread Cong Wang
From: Cong Wang The "%pIS" specifier is for struct Sockaddr, since now we have union inet_addr, rename it to '%pIA' so that it can accept union inet_addr*. But struct sockaddr * can still safely passed to '%pIA', since it is a union of it. Cc: Daniel Borkmann Cc:

[Patch net-next v3 7/9] fs: use generic union inet_addr and helper functions

2013-08-19 Thread Cong Wang
From: Cong Wang nfs and cifs define some helper functions for sockaddr, they can use the generic functions for union inet_addr/struct sockaddr too. Since some dlm code needs to compare ->sin_port, introduce a generic function inet_addr_equal_strict() for it. Cc: Steve French Cc: Christ

[Patch net-next v3 9/9] selinux: use generic union inet_addr

2013-08-19 Thread Cong Wang
From: Cong Wang selinux has some similar definition like union inet_addr, it can re-use the generic union inet_addr too. Cc: James Morris Cc: Stephen Smalley Cc: Eric Paris Cc: Paul Moore Cc: linux-kernel@vger.kernel.org Cc: linux-security-mod...@vger.kernel.org Signed-off-by: Cong Wang

Re: PROBLEM: 3.11.0-rc2+ lost of connectivity

2013-08-01 Thread Cong Wang
On Thu, 01 Aug 2013 at 14:34 GMT, Sebastiano Spicuglia wrote: > > The machine suddenly stops to be connected to the network. > Running "ifdown eth0" "ifup eth0" the network starts to work > again for few minutes and then the failure happens again. > It is not even possible to ping the machine. >

[Patch net-next v2 8/8] selinux: use generic union inet_addr

2013-08-02 Thread Cong Wang
From: Cong Wang selinux has some similar definition like union inet_addr, it can re-use the generic union inet_addr too. Cc: James Morris Cc: Stephen Smalley Cc: Eric Paris Cc: Paul Moore Cc: linux-kernel@vger.kernel.org Cc: linux-security-mod...@vger.kernel.org Signed-off-by: Cong Wang

[Patch net-next v2 6/8] fs: use generic union inet_addr and helper functions

2013-08-02 Thread Cong Wang
From: Cong Wang nfs and cifs define some helper functions for sockaddr, they can use the generic functions for union inet_addr too. Since some dlm code needs to compare ->sin_port, introduce a generic function inet_addr_equal_strict() for it. Cc: Steve French Cc: Christine Caulfield

[Patch net-next v2 1/8] net: introduce generic union inet_addr

2013-08-02 Thread Cong Wang
From: Cong Wang Introduce a generic IP address type, union inet_addr, so that subsystems don't have to use their own definitions. Because netpoll already defines union inet_addr, just move it to global. Some of the helper functions will be used by VXLAN IPv6 code too. This patch also reuse

Re: [Patch net-next v2 1/8] net: introduce generic union inet_addr

2013-08-04 Thread Cong Wang
On Fri, 2013-08-02 at 14:50 -0700, David Miller wrote: > From: Cong Wang > Date: Fri, 2 Aug 2013 15:14:27 +0800 > > > From: Cong Wang > > > > Introduce a generic IP address type, union inet_addr, so that > > subsystems don't have to use their own de

Re: [Cluster-devel] [Patch net-next v2 6/8] fs: use generic union inet_addr and helper functions

2013-08-04 Thread Cong Wang
On Fri, 2013-08-02 at 03:31 -0700, Christoph Hellwig wrote: > On Fri, Aug 02, 2013 at 03:14:32PM +0800, Cong Wang wrote: > > From: Cong Wang > > > > nfs and cifs define some helper functions for sockaddr, > > they can use the generic functions for union inet_addr t

Re: [Patch net-next v3 9/9] selinux: use generic union inet_addr

2013-08-20 Thread Cong Wang
On Mon, 2013-08-19 at 14:42 -0700, Casey Schaufler wrote: > > Well, they certainly don't appear to add any value on their own. > I also generally oppose doing clever things with data structures. If you want to implement same thing for 5+ times, yes, it has no value for you. Enjoy the following c

Re: [Patch net-next v3 9/9] selinux: use generic union inet_addr

2013-08-21 Thread Cong Wang
On Tue, 2013-08-20 at 07:28 -0700, Casey Schaufler wrote: > > I do use and enjoy all of these implementations! Thank you > for the fine implementations. In the end, if you're maintaining > the code it's your call. I question change that does not have > an obvious purpose because statistically ever

[Patch net-next 1/7] net: introduce generic union inet_addr

2013-07-22 Thread Cong Wang
From: Cong Wang Introduce a generic IP address type, union inet_addr, so that subsystems don't have to use their own definitions. Because netpoll already defines union inet_addr, just move it to global. Some of the helper functions will be used by VXLAN IPv6 code too. This patch also reuse

[Patch net-next 5/7] fs: use generic union inet_addr and help functions

2013-07-22 Thread Cong Wang
From: Cong Wang nfs and cifs define some helper functions for sockaddr, they can use the generic functions for union inet_addr too. Since some dlm code needs to compare ->sin_port, introduce a generic function inet_addr_equal_strict() for it. Cc: Steve French Cc: Christine Caulfield

[Patch net-next 7/7] selinux: use generic union inet_addr

2013-07-22 Thread Cong Wang
From: Cong Wang selinux has some similar definition like union inet_addr, it can re-use the generic union inet_addr too. Cc: James Morris Cc: Stephen Smalley Cc: Eric Paris Cc: Paul Moore Cc: linux-kernel@vger.kernel.org Cc: linux-security-mod...@vger.kernel.org Signed-off-by: Cong Wang

Re: [Patch net-next 7/7] selinux: use generic union inet_addr

2013-07-22 Thread Cong Wang
On Mon, 2013-07-22 at 16:36 -0400, Paul Moore wrote: > > These changes are going to affect Smack as well. You either need to respin > this patch to include all of the LSMs (Smack should be the only other > affected > LSM) or add a new patch to the patchset. > Yeah, I will include the Smack p

Re: [RFC PATCH - diffstat only] include/net: Remove extern from function prototypes

2013-07-24 Thread Cong Wang
On Tue, 23 Jul 2013 at 17:58 GMT, Joe Perches wrote: > Function prototypes don't need to be declared > extern in .h files. It's assumed by the compiler > and is as unnecessary as using auto is when > declaring automatic/local variables in a block. > Since we all know this, why bother it? Having

Re: [RFC PATCH 1/5] net: implement support for low latency socket polling

2013-03-03 Thread Cong Wang
On Wed, 27 Feb 2013 at 17:55 GMT, Eliezer Tamir wrote: > +static inline void skb_mark_ll(struct napi_struct *napi, struct sk_buff *skb) > +{ > + skb->dev_ref = napi; > +} > + > +static inline void sk_mark_ll(struct sock *sk, struct sk_buff *skb) > +{ > + if (skb->dev_ref) > +

Re: [RFC PATCH 0/5] net: low latency Ethernet device polling

2013-03-03 Thread Cong Wang
On 02/28/2013 01:55 AM, Eliezer Tamir wrote: Open issues: 1. Find a way to avoid the need to change the sk and skb structs. One big disadvantage of how we do this right now is that when a device is removed, it's hard to prevent it from getting polled by a socket which holds a stale reference. 2

Re: BUG: IPv4: Attempt to release TCP socket in state 1

2013-03-04 Thread Cong Wang
(Cc'ing the right netdev mailing list...) On 03/05/2013 08:01 AM, dormando wrote: Hi! I have a (core lockup?) with 3.7.6+ and 3.8.2 which appears to be under ixgbe. The machine appears to still be up but network stays in a severely hobbled state. Either lagging or not responding to the network

Re: [Patch] quota: do not leak info to user-space

2013-05-13 Thread Cong Wang
On Mon, 2013-05-13 at 12:18 +0200, Jan Kara wrote: > On Mon 13-05-13 12:04:23, Jan Kara wrote: > > On Fri 10-05-13 17:24:33, Cong Wang wrote: > > > From: Cong Wang > > > > > > There is a hole in struct fs_quota_stat, so we have to > > > zero the st

[Patch] block: do not leak info to user-space

2013-05-10 Thread Cong Wang
From: Cong Wang There is a hole in struct hd_geometry, so we have to zero the struct on stack before copying it to user-space. Cc: Jens Axboe Signed-off-by: Cong Wang --- diff --git a/block/compat_ioctl.c b/block/compat_ioctl.c index 7c668c8..7e5d474 100644 --- a/block/compat_ioctl.c +++ b

[Patch] quota: do not leak info to user-space

2013-05-10 Thread Cong Wang
From: Cong Wang There is a hole in struct fs_quota_stat, so we have to zero the struct on stack before copying it to user-space. Cc: Jan Kara Signed-off-by: Cong Wang --- diff --git a/fs/quota/quota.c b/fs/quota/quota.c index c7314f1..2b0c182 100644 --- a/fs/quota/quota.c +++ b/fs/quota

Re: [patch] net, ipv4: fix link error when CONFIG_IPV6 is a module

2013-04-28 Thread Cong Wang
On Mon, Apr 29, 2013 at 5:08 AM, David Rientjes wrote: > -#if IS_ENABLED(CONFIG_IPV6) > +#if IS_BUILTIN(CONFIG_IPV6) This is not a right fix. We had a right one: [PATCH net-next v3] ipv6: Kill ipv6 dependency of icmpv6_send() http://marc.info/?l=linux-netdev&m=136692412322576&w=2 -- To unsubscri

Re: [PATCH net v2 2/3] unix/dgram: fix peeking with an offset larger than data in queue

2013-04-29 Thread Cong Wang
On Fri, 26 Apr 2013 at 18:35 GMT, Benjamin Poirier wrote: > struct sk_buff *__skb_recv_datagram(struct sock *sk, unsigned int flags, > - int *peeked, int *off, int *err) > + int *peeked, int *_off, int *err) > { > - struct sk_bu

Re: linux-next: removal of some trees

2012-08-02 Thread Cong Wang
On 08/02/2012 06:41 AM, Stephen Rothwell wrote: Hi Ben, Since I haven't been able to fetch these trees for quite some time and I haven't heard from you about them, I am removing the following trees from linux-next. If/When you have time to maintain these trees again, we can add them back withou

Re: [RFC] netconsole.txt: "nc" needs "-p" to specify the listening port

2012-08-02 Thread Cong Wang
On Fri, Aug 3, 2012 at 4:39 AM, Dirk Gouders wrote: > > From d756d2750e4cf07d3c0942dc3c491d57631d4338 Mon Sep 17 00:00:00 2001 > From: Dirk Gouders > Date: Thu, 2 Aug 2012 22:20:16 +0200 > Subject: [PATCH] netconsole.txt: revision of examples for the receiver of > kernel messages > > There are a

Re: [PATCH 1/7] netpoll: use GFP_ATOMIC in slave_enable_netpoll() and __netpoll_setup()

2012-08-03 Thread Cong Wang
On Fri, 2012-08-03 at 11:17 +0200, Eric Dumazet wrote: > On Fri, 2012-07-27 at 23:37 +0800, Cong Wang wrote: > > slave_enable_netpoll() and __netpoll_setup() may be called > > with read_lock() held, so should use GFP_ATOMIC to allocate > > memory. > > > > Cc: &

Re: [PATCH 1/7] netpoll: use GFP_ATOMIC in slave_enable_netpoll() and __netpoll_setup()

2012-08-06 Thread Cong Wang
On Fri, 2012-08-03 at 12:10 +0200, Eric Dumazet wrote: > > I did this , just take it ;) Do we have to pass gfp to ->ndo_netpoll_setup() too? It seems no, so far I don't think we have to do that. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

[Patch] string: do not export memweight() to userspace

2012-08-06 Thread Cong Wang
From: WANG Cong This patch fixes the following warning: usr/include/linux/string.h:8: userspace cannot reference function or variable defined in the kernel Cc: Akinobu Mita Signed-off-by: WANG Cong --- diff --git a/include/linux/string.h b/include/linux/string.h index ffe0442..b917881 10064

Re: [PATCH 1/7] netpoll: use GFP_ATOMIC in slave_enable_netpoll() and __netpoll_setup()

2012-08-06 Thread Cong Wang
On Mon, 2012-08-06 at 11:44 +0200, Eric Dumazet wrote: > On Mon, 2012-08-06 at 17:08 +0800, Cong Wang wrote: > > On Fri, 2012-08-03 at 12:10 +0200, Eric Dumazet wrote: > > > > > > I did this , just take it ;) > > > > Do we have to pass gfp to ->ndo_netp

Re: [Patch] block: remove the deprecated ub driver

2012-08-25 Thread Cong Wang
On Sun, Aug 26, 2012 at 1:37 AM, Sebastian Andrzej Siewior wrote: > On Sat, Aug 25, 2012 at 11:51:23PM +0800, Cong Wang wrote: >> From: Cong Wang >> >> It is scheduled to be removed in 3.6. > > This should go via Greg and linux-usb and you should put Pete Zaitcev o

Re: [PATCH] fix ZOMBIE state bug in PPPOE driver

2012-09-16 Thread Cong Wang
On Sun, Sep 16, 2012 at 10:30 AM, Xiaodong Xu wrote: > Hi All, > > I found a bug in kernel PPPOE driver. > When PPPOE is running over a virtual ethernet interface (e.g., a > bonding interface) and the user tries to delete the interface in case > the PPPOE state is ZOMBIE, the kernel will loop infi

Re: [PATCH] kernel_notifier: register conditional raw notifier

2012-08-08 Thread Cong Wang
On 08/08/2012 06:57 PM, Jenny TC wrote: Introduce a new API raw_notifier_chain_cond_register to add a notifier to a raw notifier chain, only if notifier not already present in the chain. Forgot its declaration? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

Re: [RFC] netconsole.txt: "nc" needs "-p" to specify the listening port

2012-08-08 Thread Cong Wang
On 08/03/2012 02:33 PM, Dirk Gouders wrote: From b3aec70d785d338b1b643fece6606cd32addaf0c Mon Sep 17 00:00:00 2001 From: Dirk Gouders Date: Thu, 2 Aug 2012 22:20:16 +0200 Subject: [PATCH] netconsole.txt: revision of examples for the receiver of kernel messages There are at least 4 implementa

Re: [patch net-next 01/16] net: introduce upper device lists

2012-08-14 Thread Cong Wang
On 08/13/2012 11:27 PM, Jiri Pirko wrote: This lists are supposed to serve for storing pointers to all upper devices. Eventually it will replace dev->master pointer which is used for bonding, bridge, team but it cannot be used for vlan, macvlan where there might be multiple "masters" present. Ne

Re: x86/mm: Limit 2/4M size calculation to x86_32

2012-07-24 Thread Cong Wang
able space), but it looks a bit > like it currently would overdo things for 64bit. > I only noticed while bisecting for the reason I could not make a crash > kernel boot (which ended up on this patch). > > Signed-off-by: Stefan Bader > Cc: WANG Cong > Cc: Yinghai Lu > Cc

Re: [PATCH] x86: revert "x86: Fix S4 regression"

2012-07-24 Thread Cong Wang
On Mon, 2012-07-23 at 20:22 +0900, Takao Indoh wrote: > (2012/07/23 19:00), Dave Young wrote: > > On 07/17/2012 11:15 AM, Takao Indoh wrote: > > > >> Hi Cong, > >> > >> When I tested kdump with 3.5.0-rc6 kernel, I found a problem of kdump > >> kernel's panic in find_early_table_space(). > >> > >>

Re: [PATCH] mm: Warn about costly page allocation

2012-07-09 Thread Cong Wang
On Mon, 09 Jul 2012 at 08:46 GMT, Minchan Kim wrote: >> >> WARN_ON_ONCE would tell you what is trying to satisfy the allocation. > > Do you mean that it would be better to use WARN_ON_ONCE rather than raw > printk? > If so, I would like to insist raw printk because WARN_ON_ONCE could be > disab

Re: [PATCH] mm: Warn about costly page allocation

2012-07-10 Thread Cong Wang
On Mon, Jul 9, 2012 at 10:12 PM, Minchan Kim wrote: > > Embedded can use CONFIG_PRINTK and !CONFIG_BUG for size optimization > and printk(pr_xxx) + dump_stack is common technic used in all over kernel > sources. Do you have any reason you don't like it? > No, I am just feeling like it is a kind o

Re: [PATCH 2/2] Made core dump functionality optional

2012-07-12 Thread Cong Wang
On Thu, 2012-07-12 at 13:22 -0700, Alex Kelly wrote: > Sorry it took me so long to reply to this: > > 1. *Should* I change the option to CONFIG_CORE_DUMP ? I agree with Josh > that in terms of the existing codebase, either way makes sense, but I'll > defer to your judgment if you think I should ch

Re: the patch "bridge: export multicast database via netlink" broke kernel 3.8 uapi (was: Re: [libvirt] if_bridge.h: include in6.h for struct in6_addr use)

2013-01-15 Thread Cong Wang
es/libvir-list/2013-January/msg00930.html > > https://bugzilla.redhat.com/show_bug.cgi?id=895141 > > > Yep, > > and the commit breaking uapi headers is by using "struct in6_addr ip6" is: > > > From ee07c6e7a6f8a25c18f0a6b18152fbd7499245f6 Mon Sep 17 00

Re: the patch "bridge: export multicast database via netlink" broke kernel 3.8 uapi

2013-01-15 Thread Cong Wang
On Tue, 2013-01-15 at 12:55 +0200, Thomas Backlund wrote: > > as it seemed to fix the libvirt case > > but then asked it to be ignored after I tried to build connman, > and hit this conflict with glibc-2.17: > > In file included from /usr/include/arpa/inet.h:22:0, > from ./incl

  1   2   3   4   5   6   7   8   9   >