[PATCH v2 2/4] mac80211: set NET_NAME_USER for user-space created ifs

2014-03-16 Thread David Herrmann
rename dynamically created wifi devices (like wifi P2P devices). Cc: Johannes Berg Signed-off-by: David Herrmann Acked-by: Tom Gundersen --- net/mac80211/cfg.c | 2 +- net/mac80211/ieee80211_i.h | 1 + net/mac80211/iface.c | 2 ++ net/mac80211/main.c| 2 +- 4 files changed, 5

[PATCH v2 4/4] brcmfmac: set NET_NAME_USER for P2P ifs

2014-03-16 Thread David Herrmann
Netdevs created via nl80211 (currently only P2P ifs) have names provided by user-space. Therefore, set the naming-policy to NET_NAME_USER so it is correctly shown in sysfs. Signed-off-by: David Herrmann Acked-by: Arend van Spriel Acked-by: Tom Gundersen --- drivers/net/wireless/brcm80211

Re: [PATCH v2 1/4] net: add name_assign_type netdev attribute

2014-03-16 Thread David Herrmann
Hi On Sun, Mar 16, 2014 at 8:17 PM, Ben Hutchings wrote: > On Sun, 2014-03-16 at 18:21 +0100, David Herrmann wrote: > [...] >> --- a/include/linux/netdevice.h >> +++ b/include/linux/netdevice.h >> @@ -74,6 +74,11 @@ void netdev_set_default_ethtool_ops(struct net_devi

Re: [PATCH 00/11] SimpleDRM & Sysfb

2014-03-06 Thread David Herrmann
Hi Tomi On Mon, Mar 3, 2014 at 12:22 PM, Tomi Valkeinen wrote: > On 03/03/14 13:09, David Herrmann wrote: > >>> What do you think, would it be possible to keep the sysfb stuff in >>> arch/x86, and still be able to do the rest of the stuff here? And then >>>

[RFC] drm: add kernel-log renderer

2014-03-06 Thread David Herrmann
disable CONFIG_FB, CONFIG_VT and CONFIG_FRAMEBUFFER_CONSOLE. Combined with a proper user-space system-console, you will end up with more features, less bugs and definitely some happy kernel maintainers. Signed-off-by: David Herrmann --- drivers/gpu/drm/Kconfig |6 + drivers/gpu/drm/Makefil

Re: [RFC] drm: add kernel-log renderer

2014-03-06 Thread David Herrmann
Hi On Thu, Mar 6, 2014 at 10:56 PM, Bruno Prémont wrote: > Hi David, > > On Thu, 06 March 2014 David Herrmann wrote: >> On modern linux user-space, the VT subsystem is no longer needed for >> system consoles. Although most DEs will fail if VTs are disabled, there >> a

[PATCH v3] tty: Set correct tty name in 'active' sysfs attribute

2014-02-27 Thread David Herrmann
resolve tty0, though. Hence, treat it special and don't call into the VT layer to resolve it (plymouth is known to depend on it). Cc: Lennart Poettering Cc: Kay Sievers Cc: Greg Kroah-Hartman Cc: Jiri Slaby Signed-off-by: Werner Fink Signed-off-by: Hannes Reinecke Signed-off-by: David He

Re: [PATCHv3] tty: Set correct tty name in 'active' sysfs attribute

2014-02-27 Thread David Herrmann
Hi On Thu, Feb 27, 2014 at 12:16 PM, Kay Sievers wrote: > On Tue, Feb 25, 2014 at 10:38 AM, David Herrmann > wrote: >> On Tue, Feb 25, 2014 at 8:51 AM, Hannes Reinecke wrote: > >>> Positive? >>> I thought this was precisely the problem, ->device() changing

[PATCH 0/4] Provide netdev naming-policy via sysfs

2014-02-27 Thread David Herrmann
y, this field allows to detect whether a netdev has been manually renamed, which is quite useful for debugging and during crash-recovery. Thanks David David Herrmann (4): net: add name_assign_type netdev attribute mac80211: set NET_NAME_USER for user-space created ifs ath6kl: set NET_NAME_US

[PATCH 1/4] net: add name_assign_type netdev attribute

2014-02-27 Thread David Herrmann
nverted net-dev types. Signed-off-by: David Herrmann --- include/linux/netdevice.h | 6 ++ net/core/dev.c| 7 +++ net/core/net-sysfs.c | 2 ++ net/core/rtnetlink.c | 2 ++ 4 files changed, 17 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux/ne

[PATCH 4/4] brcmfmac: set NET_NAME_USER for P2P ifs

2014-02-27 Thread David Herrmann
Netdevs created via nl80211 (currently only P2P ifs) have names provided by user-space. Therefore, set the naming-policy to NET_NAME_USER so it is correctly shown in sysfs. Cc: Arend van Spriel Signed-off-by: David Herrmann --- drivers/net/wireless/brcm80211/brcmfmac/p2p.c | 1 + 1 file

[PATCH 2/4] mac80211: set NET_NAME_USER for user-space created ifs

2014-02-27 Thread David Herrmann
-off-by: David Herrmann --- net/mac80211/iface.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c index ce1c443..35561bd 100644 --- a/net/mac80211/iface.c +++ b/net/mac80211/iface.c @@ -1620,6 +1620,7 @@ int ieee80211_if_add(struct ieee80211_local

[PATCH 3/4] ath6kl: set NET_NAME_USER for P2P ifs

2014-02-27 Thread David Herrmann
P2P netdevs and other devices that are created via nl80211 from user-space have a name provided by user-space. Therefore, set NET_NAME_USER so this is correctly shown in sysfs. Cc: Kalle Valo Signed-off-by: David Herrmann --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 5 - drivers/net

Re: [PATCH 2/4] mac80211: set NET_NAME_USER for user-space created ifs

2014-02-27 Thread David Herrmann
Hi On Thu, Feb 27, 2014 at 3:53 PM, Johannes Berg wrote: > Given the premise of your patches, > >> +++ b/net/mac80211/iface.c >> @@ -1620,6 +1620,7 @@ int ieee80211_if_add(struct ieee80211_local *local, >> const char *name, >> + IEEE80211_ENCRYPT_HEADROOM; >

Re: [PATCH 2/4] mac80211: set NET_NAME_USER for user-space created ifs

2014-02-27 Thread David Herrmann
Hi On Thu, Feb 27, 2014 at 5:18 PM, Johannes Berg wrote: > On Thu, 2014-02-27 at 15:56 +0100, David Herrmann wrote: > >> >> +++ b/net/mac80211/iface.c >> >> @@ -1620,6 +1620,7 @@ int ieee80211_if_add(struct ieee80211_local *

Re: [PATCH 00/11] SimpleDRM & Sysfb

2014-03-03 Thread David Herrmann
Hi On Mon, Mar 3, 2014 at 11:12 AM, Tomi Valkeinen wrote: > Hi, > > On 23/01/14 16:14, David Herrmann wrote: >> Hi >> >> Another round of SimpleDRM patches. I somehow lost track of the last ones >> and as >> this is a major rewrite, I'll just sta

Re: [PATCH 00/11] SimpleDRM & Sysfb

2014-03-03 Thread David Herrmann
Hi On Mon, Mar 3, 2014 at 11:45 AM, Tomi Valkeinen wrote: > On 03/03/14 12:29, David Herrmann wrote: > >>> What's the status with this one? Headed for 3.15? >>> >>> Are the SimpleDRM and sysfb linked somehow? (I.e. do they need to be in >>> the sa

[PATCH] fs: fix i_writecount on shmem and friends

2014-03-03 Thread David Herrmann
epoll). Cc: Al Viro Cc: David Howells Cc: Oleg Nesterov Cc: Signed-off-by: David Herrmann --- fs/file_table.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/fs/file_table.c b/fs/file_table.c index 5fff903..e3c8dd0 100644 --- a/fs/file_table.

[PATCH v3 1/4] net: add name_assign_type netdev attribute

2014-03-17 Thread David Herrmann
nverted net-dev types. Signed-off-by: David Herrmann Acked-by: Tom Gundersen --- v3: - move constants to uapi header (suggested by Ben) include/linux/netdevice.h | 1 + include/uapi/linux/netdevice.h | 4 net/core/dev.c | 7 +++ net/core/net-sysfs.c |

[PATCH v4 1/4] net: add name_assign_type netdev attribute

2014-03-17 Thread David Herrmann
nverted net-dev types. Signed-off-by: David Herrmann Acked-by: Tom Gundersen --- v3: - move constants to uapi header (Ben Hutchings) v4: - avoid padding after "name_assign_type" by moving it around (David Laight) include/linux/netdevice.h | 2 ++ include/uapi/linux/netdevice.h

[PATCH v4 0/4] Provide netdev naming-policy via sysfs

2014-03-17 Thread David Herrmann
he initrd and udev only runs in the real root. Detecting renames avoids overwriting custom user provided names. Thanks David David Herrmann (4): net: add name_assign_type netdev attribute mac80211: set NET_NAME_USER for user-space created ifs ath6kl: set NET_NAME_USER for P2P ifs brcmfmac:

[PATCH v4 4/4] brcmfmac: set NET_NAME_USER for P2P ifs

2014-03-17 Thread David Herrmann
Netdevs created via nl80211 (currently only P2P ifs) have names provided by user-space. Therefore, set the naming-policy to NET_NAME_USER so it is correctly shown in sysfs. Signed-off-by: David Herrmann Acked-by: Arend van Spriel Acked-by: Tom Gundersen --- drivers/net/wireless/brcm80211

[PATCH v4 3/4] ath6kl: set NET_NAME_USER for P2P ifs

2014-03-17 Thread David Herrmann
P2P netdevs and other devices that are created via nl80211 from user-space have a name provided by user-space. Therefore, set NET_NAME_USER so this is correctly shown in sysfs. Signed-off-by: David Herrmann Acked-by: Kalle Valo Acked-by: Tom Gundersen --- drivers/net/wireless/ath/ath6kl

[PATCH v4 2/4] mac80211: set NET_NAME_USER for user-space created ifs

2014-03-17 Thread David Herrmann
rename dynamically created wifi devices (like wifi P2P devices). Cc: Johannes Berg Signed-off-by: David Herrmann Acked-by: Tom Gundersen --- net/mac80211/cfg.c | 2 +- net/mac80211/ieee80211_i.h | 1 + net/mac80211/iface.c | 2 ++ net/mac80211/main.c| 2 +- 4 files changed, 5

[PATCH v4 1/4] net: add name_assign_type netdev attribute

2014-03-17 Thread David Herrmann
nverted net-dev types. Signed-off-by: David Herrmann Acked-by: Tom Gundersen --- v3: - move api constants to uapi header (Ben Hutchings) v4: - move name_assign_type so we avoid needless padding (David Laight) include/linux/netdevice.h | 2 ++ include/uapi/linux/netdevice.h | 4

[PATCH man-pages 6/6] memfd_create.2: add memfd_create() man-page

2014-03-19 Thread David Herrmann
The memfd_create() syscall creates anonymous files similar to O_TMPFILE but does not require an active mount-point. Signed-off-by: David Herrmann --- man2/memfd_create.2 | 110 1 file changed, 110 insertions(+) create mode 100644 man2

[PATCH man-pages 5/6] fcntl.2: document SHMEM_SET/GET_SEALS commands

2014-03-19 Thread David Herrmann
The SHMEM_GET_SEALS and SHMEM_SET_SEALS commands allow retrieving and modifying the active set of seals on a file. They're only supported on selected file-systems (currently shmfs) and are linux-only. Signed-off-by: David Herrmann --- man2/fcntl.2

[PATCH 2/6] shm: add sealing API

2014-03-19 Thread David Herrmann
sers (just like mandatory locking). Signed-off-by: David Herrmann --- fs/fcntl.c | 12 ++- include/linux/shmem_fs.h | 17 include/uapi/linux/fcntl.h | 13 +++ mm/shmem.c | 200 - 4 files changed, 236 insertions(+), 6 d

[PATCH 0/6] File Sealing & memfd_create()

2014-03-19 Thread David Herrmann
independent, but the described use-cases would greatly benefit from the combination of both. Hence, I merged them into the same series. Please also note that this series is based on earlier works (ashmem, memfd, shmgetfd, ..) and unifies these attempts. Comments welcome! Thanks David David Her

[PATCH 4/6] selftests: add memfd_create() + sealing tests

2014-03-19 Thread David Herrmann
Some basic tests to verify sealing on memfds works as expected and guarantees the advertised semantics. Signed-off-by: David Herrmann --- tools/testing/selftests/Makefile | 1 + tools/testing/selftests/memfd/.gitignore | 2 + tools/testing/selftests/memfd/Makefile | 29

[PATCH 3/6] shm: add memfd_create() syscall

2014-03-19 Thread David Herrmann
ompared to O_TMPFILE, it does not require a tmpfs mount-point and is not subject to quotas and alike. Signed-off-by: David Herrmann --- arch/x86/syscalls/syscall_32.tbl | 1 + arch/x86/syscalls/syscall_64.tbl | 1 + include/linux/syscalls.h | 1 + include/uapi/linux/memfd.h | 9

[PATCH 1/6] fs: fix i_writecount on shmem and friends

2014-03-19 Thread David Herrmann
doesn't use alloc_file() (and thus not affected by this bug), it's rather unlikely that this is a serious issue. But stuff like anon_inode shares a *single* inode across a huge set of interfaces. If any of these is broken like pipe(), it will affect all of these (ranging from dma-buf t

Re: [PATCH 0/6] File Sealing & memfd_create()

2014-03-20 Thread David Herrmann
Hi On Thu, Mar 20, 2014 at 4:49 AM, Linus Torvalds wrote: > Is there really any use-case where the sealer isn't also the same > thing that *created* the file in the first place? Because I would be a > ton happier with the notion that you can only seal things that you > yourself created. At that p

Re: [PATCH] fs: fix i_writecount on shmem and friends

2014-03-20 Thread David Herrmann
Hi On Thu, Mar 13, 2014 at 1:37 AM, Al Viro wrote: > We do, but how do you get anything even attempt deny_write_access() on > those? And what would the semantics of that be, anyway? I just discovered /proc/self/map_files/ (only enabled with CONFIG_CHECKPOINT_RESTORE). Attached is an example to

Re: [PATCH 3/6] shm: add memfd_create() syscall

2014-03-20 Thread David Herrmann
Hi On Thu, Mar 20, 2014 at 10:01 AM, Pavel Emelyanov wrote: > On 03/20/2014 12:47 PM, Cyrill Gorcunov wrote: >> If I'm not mistaken in something obvious, this looks similar to >> /proc/pid/map_files >> feature, Pavel? > > It is, but the map_files will work "in the opposite direction" :) In the m

Re: [PATCH 0/6] File Sealing & memfd_create()

2014-03-20 Thread David Herrmann
Hi On Thu, Mar 20, 2014 at 3:41 PM, One Thousand Gnomes wrote: > I think you want two things at minimum > > owner to seal > root can always override Why should root be allowed to override? > I would query the name too. Right now your assumption is 'shmem only' but > that might change with other

Re: [PATCH 0/6] File Sealing & memfd_create()

2014-03-20 Thread David Herrmann
Hi On Thu, Mar 20, 2014 at 4:32 PM, wrote: > Why not make sealing an attribute of the "struct file", and enforce it > at the VFS layer? That way all file system objects would have access > to sealing interface, and for memfd_shmem, you can't get another > struct file pointing at the object, the

Re: [PATCH v2 0/9] HID: spring cleanup v2

2014-02-12 Thread David Herrmann
Hi On Wed, Feb 5, 2014 at 10:33 PM, Benjamin Tissoires wrote: > Hi guys, > > well, here comes the promised v2 of the ll_transport cleanup. > > As I said, I removed patches which need some more work, and kept only the > trivial ones. I also added David's documentation, which gives us a net > diffe

Re: [PATCH 01/14] HID: uHID: remove duplicated code

2014-02-12 Thread David Herrmann
; + return uhid_hid_output_raw(hid, buf, count, HID_OUTPUT_REPORT); Took me a while to see that we have: HID_OUTPUT_REPORT UHID_OUTPUT_REPORT .. gnah! I should have named the uhid stuff better.. anyhow, patch looks good: Reviewed-by: David Herrmann Thanks David > } > > static

Re: [PATCH 03/14] HID: core: implement generic .request()

2014-02-12 Thread David Herrmann
report->type, reqtype); > + if (ret < 0) { > + dbg_hid("unable to complete request: %d\n", ret); > + goto out; > + } > + > + if (reqtype == HID_REQ_GET_REPORT) > + hid_input_report(hid, report-&g

Re: [PATCH 02/14] HID: uHID: implement .raw_request

2014-02-12 Thread David Herrmann
ORT functionality */ > + return -ENOSYS; Looks good. I will try to implement it today and send a patch. Reviewed-by: David Herrmann Thanks David > + default: > + return -EIO; > + } > +} > + > static struct hid_ll_driver uhid_hid_drive

Re: [PATCH 04/14] HID: i2c-hid: implement ll_driver transport-layer callbacks

2014-02-12 Thread David Herrmann
nt, unsigned char report_type) > +{ > + struct i2c_client *client = hid->driver_data; > + struct i2c_hid *ihid = i2c_get_clientdata(client); > + bool data = true; /* SET_REPORT */ > + > + if (report_type == HID_OUTPUT_REPORT) > +

Re: [PATCH 05/14] HID: i2c-hid: use generic .request() implementation

2014-02-12 Thread David Herrmann
- int ret; > - int len = i2c_hid_get_report_length(rep) - 2; > - > - buf = kzalloc(len, GFP_KERNEL); Haven't you recently fixed this to use hid_alloc_buffer()? Anyhow, patch obviously looks good: Reviewed-by: David Herrmann Thanks David > - if (!buf) >

Re: [PATCH 06/14] HID: usbhid: change return error of usbhid_output_report

2014-02-12 Thread David Herrmann
Hi On Mon, Feb 10, 2014 at 6:58 PM, Benjamin Tissoires wrote: > If there is no urbout when sending a output report, ENOSYS (Function > not implemented) is a better error than EIO (I/O error). Reviewed-by: David Herrmann Thanks David > Signed-off-by: Benjamin Tissoires > --- &g

Re: [PATCH 07/14] HID: input: hid-input remove hid_output_raw_report call

2014-02-12 Thread David Herrmann
Hi On Mon, Feb 10, 2014 at 6:58 PM, Benjamin Tissoires wrote: > hid_output_raw_report() is not a ll_driver callback and should not be used. > To keep the same code path than before, we are forced to play with the > different hid_hw_* calls: if the usb or i2c device does not support > direct outpu

Re: [PATCH 08/14] HID: logitech-dj: remove hid_output_raw_report call

2014-02-12 Thread David Herrmann
Hi On Mon, Feb 10, 2014 at 6:58 PM, Benjamin Tissoires wrote: > hid-input do not use anymore hid_output_raw_report() to set the LEDs. > Use the correct implementation now and make them working again. Looks good. Reviewed-by: David Herrmann Thanks David > Signed-off-by: Benjamin

Re: [PATCH 10/14] HID: wiimote: replace hid_output_raw_report with hid_hw_output_report for output requests

2014-02-12 Thread David Herrmann
Hi On Mon, Feb 10, 2014 at 6:58 PM, Benjamin Tissoires wrote: > For BT transport layer, > ret = hid_output_raw_report(A, B, C, HID_OUTPUT_REPORT); > is equivalent to > ret = hid_hw_output_report(A, B, C); > > So use the new API where available Reviewed-by: David Herrm

Re: [PATCH 11/14] HID: sony: remove hid_output_raw_report calls

2014-02-12 Thread David Herrmann
Hi On Mon, Feb 10, 2014 at 6:58 PM, Benjamin Tissoires wrote: > We can not directly change the underlying struct hid_ll_driver here > as we did for hdev->hid_output_raw_report. > So allocate a struct ll_driver, and replace the old one when removing > the device. > To get a fully functional driver

Re: [PATCH 12/14] HID: hidraw: replace hid_output_raw_report() calls by appropriates ones

2014-02-12 Thread David Herrmann
s look quite ugly now. I'd prefer consistency here, so either keep the jump or fix the error-path above, too. Otherwise looks good. Reviewed-by: David Herrmann Thanks David > > if (count > HID_MAX_BUFFER_SIZE) { > hid_warn(dev, "pid %d passed

Re: [PATCH 13/14] HID: remove hid_output_raw_report

2014-02-12 Thread David Herrmann
Hi On Mon, Feb 10, 2014 at 6:58 PM, Benjamin Tissoires wrote: > hid_output_raw_report() is not used anymore, delete it. yippieh! Reviewed-by: David Herrmann Thanks David > Signed-off-by: Benjamin Tissoires > --- > drivers/hid/i2c-hid/i2c-hid.c | 14 -- > dri

Re: [PATCH 14/14] HID: core: check parameters when sending/receiving data from the device

2014-02-12 Thread David Herrmann
Hi On Mon, Feb 10, 2014 at 6:58 PM, Benjamin Tissoires wrote: > It is better to check them soon enough before triggering any kernel panic. Reviewed-by: David Herrmann Thanks David > Signed-off-by: Benjamin Tissoires > --- > drivers/hid/i2c-hid/i2c-hid.c | 2 +- > incl

Re: [PATCH 05/13] drm: provide device-refcount

2014-02-12 Thread David Herrmann
Hi On Wed, Feb 12, 2014 at 5:40 PM, Greg KH wrote: > On Wed, Feb 12, 2014 at 05:26:57PM +0100, Daniel Vetter wrote: >> On Wed, Feb 12, 2014 at 3:44 PM, David Herrmann >> wrote: >> >>> +/** >> >>> + * drm_dev_ref - Take reference of a DRM device &g

Re: [PATCH 3.11 085/121] tty: Set correct tty name in 'active' sysfs attribute

2014-02-21 Thread David Herrmann
Hi On Fri, Feb 21, 2014 at 3:46 PM, Josh Boyer wrote: > On Fri, Feb 21, 2014 at 9:37 AM, Ray Strode wrote: >> Hi, >> >> This broke plymouth, i think. Plymouth used the herustic: >> "/sys/class/tty/console/active contains something other than tty0" to >> mean "probably has serial consoles, force

[PATCH v3 1/3] drm: add pseudo filesystem for shared inodes

2014-01-23 Thread David Herrmann
However, most of this information is currently hidden and it's not clear whether this address_space is suitable for driver access. Thus, unless linux allows anonymous address_space objects or driver-core provides a public inode per device, we're left with our own private internal mount poin

[PATCH v3 3/3] drm: init TTM dev_mapping in ttm_bo_device_init()

2014-01-23 Thread David Herrmann
ve Airlie Cc: Ben Skeggs Cc: Maarten Lankhorst Cc: Alex Deucher Cc: Thomas Hellstrom Signed-off-by: David Herrmann --- drivers/gpu/drm/ast/ast_ttm.c | 5 +++-- drivers/gpu/drm/cirrus/cirrus_ttm.c| 5 +++-- drivers/gpu/drm/mgag200/mgag200_ttm.c | 5 +++-- drivers/gpu/drm/nouveau/

[PATCH v3 2/3] drm: use anon-inode instead of relying on cdevs

2014-01-23 Thread David Herrmann
yed initialization causes ugly conditions all over the place: if (dev->dev_mapping) do_sth(); To avoid delayed initialization and to stop reusing the inode of the char-dev, we allocate an anonymous inode for each DRM device and reset filp->f_mapping to it on ->open(). Signed-o

[PATCH 05/11] x86: sysfb: store apertures in simplefb platform-data

2014-01-23 Thread David Herrmann
y embed it. Thus, we have to use a "apert_buf" buffer with enough room for one "struct aperture". Signed-off-by: David Herrmann --- arch/x86/include/asm/sysfb.h | 6 +-- arch/x86/kernel/sysfb.c| 2 +- arch/x86/kern

[PATCH 11/11] x86/sysfb: allow sysfb+simpledrm combination

2014-01-23 Thread David Herrmann
We used to protect X86_SYSFB by depending on FB_SIMPLE so users don't accidentally end up without a kernel console. Now that DRM_SIMPLEDRM also provides a simple-framebuffer driver, we can whitelist this driver, too. --- arch/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 03/11] fbdev: efifb: add dev->remove() callback

2014-01-23 Thread David Herrmann
and unregister efifb. Signed-off-by: David Herrmann --- drivers/video/efifb.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c index cd7c0df..ae9618f 100644 --- a/drivers/video/efifb.c +++ b/drivers/video/efifb.c @@ -73,7 +7

[PATCH 07/11] drm: mgag200: remove redundant fbdev removal

2014-01-23 Thread David Herrmann
sfb-devices, too. Signed-off-by: David Herrmann --- drivers/gpu/drm/mgag200/mgag200_main.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_main.c index 26868e5..0ee093c 100644 --- a/drivers/gpu/drm/mgag200/mgag200_mai

[PATCH 09/11] drm: add SimpleDRM driver

2014-01-23 Thread David Herrmann
is allowed (compared to earlier version of this driver) to avoid security issues. Furthermore, this way we can support arbitrary modes as long as we have a convertion-helper. Signed-off-by: David Herrmann --- MAINTAINERS | 8 + drivers/gpu/drm/Kconfig

[PATCH 04/11] fbdev: vesafb: add dev->remove() callback

2014-01-23 Thread David Herrmann
and unregister vesafb. Signed-off-by: David Herrmann --- drivers/video/vesafb.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/video/vesafb.c b/drivers/video/vesafb.c index 1c7da3b..6170e7f 100644 --- a/drivers/video/vesafb.c +++ b/drivers/video/vesaf

[PATCH 06/11] video: sysfb: add generic firmware-fb interface

2014-01-23 Thread David Herrmann
ly, a short documentation of the different existing firmware-fbs and handover-mechanisms is put into Documentation/firmware-fbs.txt. Compared to remove_conflicting_framebuffers(), the sysfb interface is independent of FBDEV. Thus, we can use it for DRM-only handovers. Signed-off-by: David Her

[PATCH 00/11] SimpleDRM & Sysfb

2014-01-23 Thread David Herrmann
overhead to paper of lazy user-space. I have tested this with all hardware that I have at home, with a lot hand-over combinations (with/without SYSFB, with efifb/vesafb/simplefb, with SimpleDRM, ...) and all worked great so far. Comments welcome! David David Herrmann (11): x86: sysfb: fool-pr

[PATCH 08/11] drm/i915: remove sysfbs early

2014-01-23 Thread David Herrmann
out to be not as easy as you might think, so lets just evict all sysfbs for now before loading i915. A proper fix would be to make DRM code allow parallel device probing. That's not going to happen soon, so be safe and make i915 evict all sysfbs. Signed-off-by: David Herrmann --- drivers/gpu/

[PATCH 10/11] drm: simpledrm: add fbdev fallback support

2014-01-23 Thread David Herrmann
Create a simple fbdev device during SimpleDRM setup so legacy user-space and fbcon can use it. Signed-off-by: David Herrmann --- drivers/gpu/drm/simpledrm/Kconfig | 11 +++ drivers/gpu/drm/simpledrm/Makefile | 1 + drivers/gpu/drm/simpledrm/simpledrm.c | 13

[PATCH 01/11] x86: sysfb: fool-proof CONFIG_X86_SYSFB

2014-01-23 Thread David Herrmann
this is still ongoing, there's no need for non-developers to care for X86_SYSFB so we can safely hide it behind FB_SIMPLE. Signed-off-by: David Herrmann --- arch/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 0952ecd..098228e 100644

[PATCH 02/11] x86: sysfb: remove sysfb when probing real hw

2014-01-23 Thread David Herrmann
good to go. simplefb is unregistered by sysfb_unregister() now, so no reason to keep the apertures (on non-x86, there currently is no handover from simplefb, so we're fine. If it's added, they need to provide something like sysfb_unregister() too) Signed-off-by: David Herrmann R

Re: [PATCH v4 1/2] input/uinput: replace breaks by goto out in uinput_ioctl_handler

2014-01-23 Thread David Herrmann
Hi Benjamin On Wed, Jan 22, 2014 at 6:23 PM, Benjamin Tissoires wrote: > From: Benjamin Tisssoires > > The current implementation prevents us to add variable-length ioctl. > Use a bunch of gotos instead of break to allow us to do so. > > No functional changes. Looks good.

Re: [PATCH v4 2/2] input/uinput: add UI_GET_SYSNAME ioctl to retrieve the sysfs path

2014-01-23 Thread David Herrmann
t; + if (maxlen == 0) > + return -EINVAL; > + > + len = strlen(str) + 1; > + if (len > maxlen) > + len = maxlen; > + > + ret = copy_to_user(dest, str, len); Technically you could use "len - 1" here, but it's

Re: [PATCH 02/11] x86: sysfb: remove sysfb when probing real hw

2014-01-23 Thread David Herrmann
Hi On Thu, Jan 23, 2014 at 5:51 PM, Ingo Molnar wrote: > > Just a couple of small nits: > > * David Herrmann wrote: > >> --- a/arch/x86/kernel/sysfb.c >> +++ b/arch/x86/kernel/sysfb.c >> @@ -33,11 +33,76 @@ >> #include >> #include >>

Re: [PATCH 02/11] x86: sysfb: remove sysfb when probing real hw

2014-01-23 Thread David Herrmann
Hi On Thu, Jan 23, 2014 at 6:14 PM, Ingo Molnar wrote: > > * David Herrmann wrote: > >> >> +#ifdef CONFIG_X86_SYSFB >> >> +# include >> >> +#endif >> > >> > I guess a single space is sufficient? >> > >> > Bet

[PATCH v6 4/4] brcmfmac: set NET_NAME_USER for P2P ifs

2014-04-02 Thread David Herrmann
Netdevs created via nl80211 (currently only P2P ifs) have names provided by user-space. Therefore, set the naming-policy to NET_NAME_USER so it is correctly shown in sysfs. Signed-off-by: David Herrmann Acked-by: Arend van Spriel Acked-by: Tom Gundersen Acked-by: Kay Sievers --- drivers/net

[PATCH v6 3/4] ath6kl: set NET_NAME_USER for P2P ifs

2014-04-02 Thread David Herrmann
P2P netdevs and other devices that are created via nl80211 from user-space have a name provided by user-space. Therefore, set NET_NAME_USER so this is correctly shown in sysfs. Signed-off-by: David Herrmann Acked-by: Kalle Valo Acked-by: Tom Gundersen Acked-by: Kay Sievers --- drivers/net

[PATCH v6 1/4] net: add name_assign_type netdev attribute

2014-04-02 Thread David Herrmann
nverted net-dev types. Signed-off-by: David Herrmann Acked-by: Tom Gundersen Acked-by: Kay Sievers --- include/linux/netdevice.h | 2 ++ include/uapi/linux/netdevice.h | 4 net/core/dev.c | 7 +++ net/core/net-sysfs.c | 2 ++ net/core/rtnetlink.c

[PATCH v6 0/4] Provide netdev naming-policy via sysfs

2014-04-02 Thread David Herrmann
/1673169 David Herrmann (4): net: add name_assign_type netdev attribute mac80211: set NET_NAME_USER for user-space created ifs ath6kl: set NET_NAME_USER for P2P ifs brcmfmac: set NET_NAME_USER for P2P ifs drivers/net/wireless/ath/ath6kl/cfg80211.c| 5 - drivers/net/wireless/ath

[PATCH v6 2/4] mac80211: set NET_NAME_USER for user-space created ifs

2014-04-02 Thread David Herrmann
rename dynamically created wifi devices (like wifi P2P devices). Cc: Johannes Berg Signed-off-by: David Herrmann Acked-by: Tom Gundersen Acked-by: Kay Sievers --- net/mac80211/cfg.c | 2 +- net/mac80211/ieee80211_i.h | 1 + net/mac80211/iface.c | 2 ++ net/mac80211/main.c| 2

Re: [PATCH 3/6] shm: add memfd_create() syscall

2014-04-02 Thread David Herrmann
Hi On Wed, Apr 2, 2014 at 3:38 PM, Konstantin Khlebnikov wrote: > On Wed, Mar 19, 2014 at 11:06 PM, David Herrmann > wrote: >> memfd_create() is similar to mmap(MAP_ANON), but returns a file-descriptor >> that you can pass to mmap(). It explicitly allows sealing and >>

Re: Things I wish I'd known about Inotify

2014-04-04 Thread David Herrmann
Hi On Thu, Apr 3, 2014 at 8:34 AM, Michael Kerrisk (man-pages) wrote: > With that in mind, I've drafted some substantial additions to the > inotify(7) man page. I would be very happy if folk on the "To:" list > could comment on the text below, since I believe you all have a lot of > practical exp

Re: Things I wish I'd known about Inotify

2014-04-04 Thread David Herrmann
Hi On Fri, Apr 4, 2014 at 3:00 PM, David Herrmann wrote: > 1) > IN_IGNORED is async and _immediate_ in case a file got deleted. So if > you use watch-descriptors as keys for your objects, an _already_ used > key might be returned by inotify_add_watch() if an IN_IGNORED is > que

Re: [PATCH] HID: input: fix input sysfs path for hid devices

2014-01-08 Thread David Herrmann
Hi Jiri On Fri, Dec 20, 2013 at 11:36 PM, Jiri Kosina wrote: > On Thu, 19 Dec 2013, David Herrmann wrote: > >> wrote: >> > we used to set the parent of the input device as the parent of >> > the hid bus. This was introduced when we created hid as a real

Re: [PATCH] HID: input: fix input sysfs path for hid devices

2014-01-08 Thread David Herrmann
Hi On Wed, Jan 8, 2014 at 5:26 PM, Jiri Kosina wrote: > On Wed, 8 Jan 2014, David Herrmann wrote: > >> >> > I think this is valuable because it will give a better understanding of >> >> > the >> >> > actual mapping hardware/inputs. Lik

Re: [drm] BUG: spinlock lockup suspected on CPU#0, swapper/0/1

2014-01-14 Thread David Herrmann
Hi On Tue, Jan 14, 2014 at 2:45 PM, Fengguang Wu wrote: > Hi David, > > I'm not sure if this is a good bisect because the errors are noisy, > however it's good to inform you of this possibility. > > First bad commit may be a3483353c ("drm: check for !kdev in > drm_unplug_minor()") To be honest,

Re: [PATCH v3] efifb: prevent null-deref when iterating dmi_list

2013-10-19 Thread David Herrmann
ping On Wed, Oct 2, 2013 at 6:43 PM, David Herrmann wrote: > From: James Bates > > The dmi_list array is initialized using gnu designated initializers, and > therefore may contain fewer explicitly defined entries as there are > elements in it. This is because the enum above with

Re: [PATCH 1/2] simplefb: fix unmapping fb during destruction

2013-10-30 Thread David Herrmann
Hi Tomi Could we get this in -next before the merge-window starts? Stephen already ack'ed it. Thanks David On Wed, Oct 2, 2013 at 6:23 PM, David Herrmann wrote: > Hi > > On Wed, Oct 2, 2013 at 6:16 PM, Stephen Warren wrote: >> On 10/02/2013 08:58 AM, David Herrmann wrot

Re: [PATCH 2/2] simplefb: use write-combined remapping

2013-10-30 Thread David Herrmann
Hi Tomi Ping? Thanks David On Wed, Oct 2, 2013 at 4:58 PM, David Herrmann wrote: > Framebuffers shouldn't be cached and it is usually very uncommon to read > them. Therefore, use ioremap_wc() to get significant speed improvements on > systems which provide it. On all other system

Re: [PATCH v2] efifb: prevent null-deref when iterating dmi_list

2013-10-31 Thread David Herrmann
Hi On Thu, Oct 31, 2013 at 11:45 AM, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 18:40 Wed 02 Oct , David Herrmann wrote: >> The dmi_list array is initialized using gnu designated initializers, and >> therefore may contain fewer explicitly defined entries as there are &g

Re: [PATCH v2] efifb: prevent null-deref when iterating dmi_list

2013-11-01 Thread David Herrmann
Hi On Fri, Nov 1, 2013 at 12:10 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 17:17 Thu 31 Oct , David Herrmann wrote: >> Hi >> >> On Thu, Oct 31, 2013 at 11:45 AM, Jean-Christophe PLAGNIOL-VILLARD >> wrote: >> > On 18:40 Wed 02 Oct , David Herrman

Re: [PATCH] Input: fix typos in Documentation/input/gamepad.txt

2013-12-16 Thread David Herrmann
Hi On Mon, Dec 16, 2013 at 1:34 PM, Antonio Ospite wrote: > Fix some typos and while at it also use "PS" as the name for the central > "HOME" button on Sony controllers, this is how Sony itself calls it. Thanks, looks good. Any news regarding the absolute DPad? R

[PATCH 4/4] Input: add motion-tracking ABS_* bits and docs

2013-12-17 Thread David Herrmann
, ABS_X/Y are already used by analog sticks, so need separate definitions, anyway. Signed-off-by: David Herrmann --- Documentation/input/gamepad.txt | 7 ++ Documentation/input/motion-tracking.txt | 149 include/linux/mod_devicetable.h | 2

[PATCH 1/4] Input: uinput: add full absinfo support

2013-12-17 Thread David Herrmann
port, we cannot simply add new fields, as we cannot deduce the structure size from the user-space given size. Thus, we need the "version" field to allow changing the object and properly detecting it in our write() handler. Signed-off-by: David Herrmann --- drivers/input/mis

[PATCH 0/4] Input: ABS2 and friends

2013-12-17 Thread David Herrmann
e ABS values in the new range Note that I have patches pending which make use of the new ABS values, but I'd like to get this reduced series in first. Thanks David David Herrmann (4): Input: uinput: add full absinfo support Input: introduce ABS_MAX2/CNT2 and friends Input: remove ambigio

[PATCH 2/4] Input: introduce ABS_MAX2/CNT2 and friends

2013-12-17 Thread David Herrmann
els. Note that we also need to increase EV_VERSION so user-space can reliably know whether ABS2 is supported. Unfortunately, we return EINVAL instead of ENOSYS for unknown evdev ioctls so it's nearly impossible to catch reliably without EVIOCGVERSION. Signed-off-by: David Herrmann --- dri

Re: [PATCH v3 1/7] mm: allow drivers to prevent new writable mappings

2014-07-19 Thread David Herrmann
Hi Hugh On Wed, Jul 9, 2014 at 10:55 AM, Hugh Dickins wrote: > On Fri, 13 Jun 2014, David Herrmann wrote: > >> The i_mmap_writable field counts existing writable mappings of an >> address_space. To allow drivers to prevent new writable mappings, make >> this counte

Re: [PATCH v3 2/7] shm: add sealing API

2014-07-19 Thread David Herrmann
Hi Hugh On Wed, Jul 16, 2014 at 12:06 PM, Hugh Dickins wrote: > On Fri, 13 Jun 2014, David Herrmann wrote: > >> If two processes share a common memory region, they usually want some >> guarantees to allow safe access. This often includes: >> - one side cannot overwr

Re: [PATCH v3 3/7] shm: add memfd_create() syscall

2014-07-19 Thread David Herrmann
Hi On Wed, Jul 16, 2014 at 12:07 PM, Hugh Dickins wrote: > On Fri, 13 Jun 2014, David Herrmann wrote: > >> memfd_create() is similar to mmap(MAP_ANON), but returns a file-descriptor >> that you can pass to mmap(). It can support sealing and avoids any >> connection to u

Re: [PATCH v3 4/7] selftests: add memfd_create() + sealing tests

2014-07-19 Thread David Herrmann
Hi On Wed, Jul 16, 2014 at 12:07 PM, Hugh Dickins wrote: > On Fri, 13 Jun 2014, David Herrmann wrote: > >> Some basic tests to verify sealing on memfds works as expected and >> guarantees the advertised semantics. >> >> Signed-off-by: David Herrmann > > Thank

Re: [PATCH v3 5/7] selftests: add memfd/sealing page-pinning tests

2014-07-19 Thread David Herrmann
Hi On Wed, Jul 16, 2014 at 12:08 PM, Hugh Dickins wrote: > On Fri, 13 Jun 2014, David Herrmann wrote: > >> Setting SEAL_WRITE is not possible if there're pending GUP users. This >> commit adds selftests for memfd+sealing that use FUSE to create pending >> page-ref

Re: [RFC v3 6/7] shm: wait for pins to be released when sealing

2014-07-19 Thread David Herrmann
Hi On Wed, Jul 16, 2014 at 12:09 PM, Hugh Dickins wrote: > On Fri, 13 Jun 2014, David Herrmann wrote: > >> We currently fail setting SEAL_WRITE in case there're pending page >> references. This patch extends the pin-tests to wait up to 150ms for all >> references to

Re: [RFC v3 7/7] shm: isolate pinned pages when sealing files

2014-07-19 Thread David Herrmann
Hi On Wed, Jul 9, 2014 at 10:57 AM, Hugh Dickins wrote: > On Fri, 13 Jun 2014, David Herrmann wrote: > >> When setting SEAL_WRITE, we must make sure nobody has a writable reference >> to the pages (via GUP or similar). We currently check references and wait >> some tim

<    1   2   3   4   5   6   7   8   9   >