Re: "tuntap: multiqueue support" causes udev fork bombs

2012-11-28 Thread David Miller
Please DO NOT quote a huge email, just to give a small reply to the discussion. It is never appropriate. Doing so wastes bandwidth for every single person on the list. Just quote enough context, and in the case you really could have quoted nothing at all and everyone would have understood you.

Re: [PATCH] pkt_sched: QFQ Plus: fair-queueing service at DRR cost

2012-11-28 Thread David Miller
From: Paolo Valente Date: Fri, 23 Nov 2012 22:03:19 +0100 > This patch turns QFQ into QFQ+, a variant of QFQ that provides the > following two benefits: 1) QFQ+ is faster than QFQ, 2) differently > from QFQ, QFQ+ correctly schedules also non-leaves classes in a > hierarchical setting. A detailed

Re: [PATCH] vhost-blk: Add vhost-blk support v5

2012-11-28 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 26 Nov 2012 17:14:16 +0200 > On Mon, Nov 19, 2012 at 10:26:41PM +0200, Michael S. Tsirkin wrote: >> > >> > Userspace bits: >> > - >> > 1) LKVM >> > The latest vhost-blk userspace bits for kvm tool can be found here: >> > g...@gith

Re: [PATCH] vhost: fix length for cross region descriptor

2012-11-28 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 26 Nov 2012 17:57:27 +0200 > If a single descriptor crosses a region, the > second chunk length should be decremented > by size translated so far, instead it includes > the full descriptor length. > > Signed-off-by: Michael S. Tsirkin Applied, thanks. -- T

Re: [PATCH 1/2] ewrk3: silence GCC warning

2012-11-28 Thread David Miller
From: Paul Bolle Date: Tue, 27 Nov 2012 10:47:17 +0100 > Building ewrk3.o triggers this GCC warning: > drivers/net/ethernet/dec/ewrk3.c: In function '__check_irq': > drivers/net/ethernet/dec/ewrk3.c:1915:1: warning: return from > incompatible pointer type [enabled by default] > > This c

Re: [PATCH 2/2] ewrk3: remove outdated comment

2012-11-28 Thread David Miller
From: Paul Bolle Date: Tue, 27 Nov 2012 10:48:34 +0100 > Remove an outdated comment, that should have been removed in the > patch named "MODULE_PARM conversions" from early 2005. > > Signed-off-by: Paul Bolle Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: [PATCH] br2684: don't send frames on not-ready vcc

2012-11-28 Thread David Miller
From: David Woodhouse Date: Tue, 27 Nov 2012 23:28:36 + > + if (test_bit(ATM_VF_RELEASED, &atmvcc->flags) > + || test_bit(ATM_VF_CLOSE, &atmvcc->flags) > + || !test_bit(ATM_VF_READY, &atmvcc->flags)) { Please: if (X || Y || Z) not:

Re: [PATCH] br2684: don't send frames on not-ready vcc

2012-11-28 Thread David Miller
From: David Woodhouse Date: Wed, 28 Nov 2012 17:01:10 + > On Wed, 2012-11-28 at 11:41 -0500, David Miller wrote: >> >> Please: >> >> if (X || >> Y || >> Z) >> >> not: >> >> if (X >

Re: [PATCH] br2684: don't send frames on not-ready vcc

2012-11-28 Thread David Miller
From: David Woodhouse Date: Wed, 28 Nov 2012 17:09:15 + > And then I'll either send an explicit pull request, or submit it as > patches ― whichever you prefer. The canonical thing is to do both, send the pull request in the "[PATCH 0/N]" email, and then the patches so everyone can see the fi

[GIT] Networking

2012-11-28 Thread David Miller
Some more fixes trickled in over the past few days: 1) PIM device names can overflow the IFNAMSIZ buffer unless we properly limit the allowed indexes, fix from Eric Dumazet. 2) Under heavy load we can OOPS in icmp reply processing due to an unchecked inet_putpeer() call. Fix from Neal Car

Re: [PULL] vhost: tcm_vhost fixes for 3.9

2013-03-18 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 18 Mar 2013 13:20:03 +0200 > The following changes since commit 8c6216d7f118a128678270824b6a1286a63863ca: > > Revert "ip_gre: make ipgre_tunnel_xmit() not parse network header as IP > unconditionally" (2013-03-16 23:00:41 -0400) > > are available in the

Re: [PATCH] net: Fix a comment typo

2013-03-18 Thread David Miller
From: Kusanagi Kouichi Date: Mon, 18 Mar 2013 21:59:52 +0900 > Signed-off-by: Kusanagi Kouichi Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.

Re: [PATCH] macvlan: Remove an unnecessary goto

2013-03-18 Thread David Miller
From: Kusanagi Kouichi Date: Mon, 18 Mar 2013 22:03:39 +0900 > Use else instead. > > Signed-off-by: Kusanagi Kouichi The code is not in any way more readable with your changes. I'm not applying this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

Re: [PATCH V3 4/7] PHYLIB: queue work on any cpu

2013-03-18 Thread David Miller
From: Viresh Kumar Date: Mon, 18 Mar 2013 20:53:26 +0530 > Phylib uses workqueues for multiple purposes. There is no real dependency of > scheduling these on the cpu which scheduled them. > > On a idle system, it is observed that and idle cpu wakes up many times just to > service this work. It w

Re: [PATCH] bluetooth: use PTR_RET instead of IS_ERR + PTR_ERR

2013-03-18 Thread David Miller
From: Silviu Popescu Date: Mon, 18 Mar 2013 20:05:42 +0200 >>> + return PTR_RET(bt_class) .. > That being said, I'd like to understand a bit better what exactly I messed up. There's no semicolon at the end of the return statement. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PULL] vhost: tcm_vhost fixes for 3.9

2013-03-18 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 18 Mar 2013 21:54:43 +0200 > On Mon, Mar 18, 2013 at 01:01:36PM -0400, David Miller wrote: >> From: "Michael S. Tsirkin" >> Date: Mon, 18 Mar 2013 13:20:03 +0200 >> >> > The following changes since com

Re: [PATCH] use xfrm direction when lookup policy

2013-03-19 Thread David Miller
From: Baker Zhang Date: Tue, 19 Mar 2013 20:39:46 +0800 > +static inline int flow_to_policy_dir(int dir) Please do not use inline in foo.c files, just let the compiler decide whether inlining is a good idea or not. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [PATCH 0/4] Misc MRF24J40 Fixes

2013-03-19 Thread David Miller
From: Alan Ott Date: Mon, 18 Mar 2013 18:06:39 -0400 > These are fairly straight-forward. All applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.o

Re: [PATCH] use xfrm direction when lookup policy

2013-03-19 Thread David Miller
From: Baker Zhang Date: Tue, 19 Mar 2013 22:24:30 +0800 > because xfrm policy direction has same value with corresponding > flow direction, so this problem is covered. > > In xfrm_lookup and __xfrm_policy_check, flow_cache_lookup is used to > accelerate the lookup. > > Flow direction is given t

Re: [PATCH] sparc: remove unused "config BITS"

2013-03-19 Thread David Miller
From: Paul Bolle Date: Tue, 19 Mar 2013 16:58:47 +0100 > sparc's asm/module.h got removed in commit > 786d35d45cc40b2a51a18f73e14e135d47fdced7 ("Make most arch asm/module.h > files use asm-generic/module.h"). That removed the only two uses of this > Kconfig symbol. So we can remove its entry too.

Re: [PATCH] ixp4xx_eth: set the device dma_coherent_mask

2013-03-19 Thread David Miller
From: Christophe Aeschlimann Date: Tue, 19 Mar 2013 16:59:25 +0100 > Without the mask it is impossible to take the network interface up > since it returns the following error: > >> net eth1: coherent DMA mask is unset >> ifconfig: SIOCSIFFLAGS: Cannot allocate memory > > Tested on an out-of-tre

[GIT] Networking

2013-03-19 Thread David Miller
1) Fix ARM BPF JIT handling of negative 'k' values, from Chen Gang. 2) Insufficient space reserved for bridge netlink values, fix from Stephen Hemminger. 3) Some dst_neigh_lookup*() callers don't interpret error pointer correctly, fix from Zhouyi Zhou. 4) Fix transport match in SCTP activ

Re: [PATCH] sparc: delete "if !ULTRA_HAS_POPULATION_COUNT"

2013-03-19 Thread David Miller
From: Paul Bolle Date: Tue, 12 Mar 2013 21:35:19 +0100 > Commit 2d78d4beb64eb07d50665432867971c481192ebf ("[PATCH] bitops: > sparc64: use generic bitops") made the default of GENERIC_HWEIGHT depend > on !ULTRA_HAS_POPULATION_COUNT. But since there's no Kconfig symbol with > that name, this always

Re: [PATCH] sparc: remove unused "config BITS"

2013-03-19 Thread David Miller
From: Paul Bolle Date: Tue, 19 Mar 2013 18:06:47 +0100 > On Tue, 2013-03-19 at 12:33 -0400, David Miller wrote: >> We use this in the Makefile fragments, you cannot remove it. > > From arch/sparc/Makefile: > ifeq ($(CONFIG_SPARC32),y) > [...] > > [...]

Re: [PATCH] sparc: remove unused "config BITS"

2013-03-19 Thread David Miller
From: Sam Ravnborg Date: Tue, 19 Mar 2013 21:14:54 +0100 > On Tue, Mar 19, 2013 at 06:06:47PM +0100, Paul Bolle wrote: >> On Tue, 2013-03-19 at 12:33 -0400, David Miller wrote: >> > We use this in the Makefile fragments, you cannot remove it. >> >> >From

Re: [PATCH] sparc: remove unused "config BITS"

2013-03-19 Thread David Miller
From: Paul Bolle Date: Tue, 19 Mar 2013 21:26:08 +0100 > On Tue, 2013-03-19 at 21:14 +0100, Sam Ravnborg wrote: >> On Tue, Mar 19, 2013 at 06:06:47PM +0100, Paul Bolle wrote: >> > So $(BITS) is set depending on whether CONFIG_SPARC32 is set or not. >> > Using $(BITS) in sparc's Makefiles is not u

[GIT] Sparc

2013-03-19 Thread David Miller
Just some minor fixups, a sunsu console setup panic cure, and recognition of a Fujitsu sun4v cpu. Please pull, thanks a lot! The following changes since commit b0af9cd9aab60ceb17d3ebabb9fdf4ff0a99cf50: Merge tag 'lzo-update-signature-20130226' of git://github.com/markus-oberhumer/linux (2013

Re: [PATCH] dynticks: avoid flow_cache_flush() interrupting every core

2013-03-20 Thread David Miller
From: Chris Metcalf Date: Tue, 19 Mar 2013 17:35:58 -0400 > Previously, if you did an "ifconfig down" or similar on one core, and > the kernel had CONFIG_XFRM enabled, every core would be interrupted to > check its percpu flow list for items that could be garbage collected. > > With this change,

Re: [PATCH] net/irda: add missing error path release_sock call

2013-03-20 Thread David Miller
From: Kees Cook Date: Wed, 20 Mar 2013 08:19:24 -0700 > This makes sure that release_sock is called for all error conditions in > irda_getsockopt. > > Signed-off-by: Kees Cook > Reported-by: Brad Spengler Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kern

Re: [PATCH v2 1/1] connector: Added coredumping event to the process connector

2013-03-20 Thread David Miller
From: Jesper Derehag Date: Wed, 20 Mar 2013 07:50:05 +0100 > Process connector can now also detect coredumping events. > Main aim of patch is get notified at start of coredumping, instead of having > to wait for it to finish and then being notified through EXIT event. > Could be used for instanc

Re: [PATCH] dynticks: avoid flow_cache_flush() interrupting every core

2013-03-20 Thread David Miller
From: Frederic Weisbecker Date: Wed, 20 Mar 2013 17:37:04 +0100 > 2013/3/20 David Miller : >> From: Chris Metcalf >> Date: Tue, 19 Mar 2013 17:35:58 -0400 >> >>> Previously, if you did an "ifconfig down" or similar on one core, and >>> the ke

Re: [PATCH] net: fix psock_fanout selftest bind error message

2013-03-20 Thread David Miller
From: Daniel Baluta Date: Wed, 20 Mar 2013 19:28:56 +0200 > Signed-off-by: Daniel Baluta Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-inf

Re: [PATCH] net: fix psock_fanout selftest bind error message

2013-03-20 Thread David Miller
Please, in the future, post networking patches to net...@vger.kernel.org rather than lkml. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Pl

Re: [patch 2/5] sparse-vmemmap: specify vmemmap population range in bytes

2013-03-20 Thread David Miller
From: Johannes Weiner Date: Wed, 20 Mar 2013 14:03:29 -0400 > The sparse code, when asking the architecture to populate the vmemmap, > specifies the section range as a starting page and a number of pages. > > This is an awkward interface, because none of the arch-specific code > actually thinks

Re: [PATCH] TTY: serial, stop accessing potential NULLs

2013-03-20 Thread David Miller
rupts were unbound or > otherwise stopped. But this is not the case for consoles for these > drivers, as was pointed out by David Miller. > > Now, this patch re-introduces the checks (at this point we check > port->state, not the tty proper, as we do not care about tty pointers >

Re: pull request: wireless 2013-03-20

2013-03-20 Thread David Miller
From: "John W. Linville" Date: Wed, 20 Mar 2013 15:11:08 -0400 > I present to you another batch of fixes intended for the 3.9 stream... > > On the bluetooth bits, Gustavo says: > > "I put together 3 fixes intended for 3.9, there are support for two > new devices and a NULL dereference fix in th

Re: [PATCH] net: fix *_DIAG_MAX constants

2013-03-21 Thread David Miller
From: Thomas Graf Date: Thu, 21 Mar 2013 14:42:18 + > On 03/21/13 at 06:18pm, Andrey Vagin wrote: >> Follow the common pattern and define *_DIAG_MAX like: >> >> [...] >> __XXX_DIAG_MAX, >> }; >> >> Because everyone is used to do: >> >> struct nlattr *attrs[XXX_DIAG_

Re: [PATCH] net: remove redundant ifdef CONFIG_CGROUPS

2013-03-21 Thread David Miller
From: Li Zefan Date: Thu, 21 Mar 2013 10:54:51 +0800 > The cgroup code has been surrounded by ifdef CONFIG_NET_CLS_CGROUP > and CONFIG_NETPRIO_CGROUP. > > Signed-off-by: Li Zefan Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messag

Re: [BUGFIX PATCH] net: ethernet: cpsw: fix erroneous condition in error check

2013-03-21 Thread David Miller
From: Mugunthan V N Date: Thu, 21 Mar 2013 18:02:21 +0530 > On 3/21/2013 5:50 PM, Lothar Waßmann wrote: >> The error check in cpsw_probe_dt() has an '&&' where an '||' is >> meant to be. This causes a NULL pointer dereference when incomplet DT >> data is passed to the driver ('phy_id' property fo

Re: [PATCH 1/3] net: fix *_DIAG_MAX constants

2013-03-21 Thread David Miller
From: Andrey Vagin Date: Thu, 21 Mar 2013 20:33:46 +0400 > Follow the common pattern and define *_DIAG_MAX like: > > [...] > __XXX_DIAG_MAX, > }; > > Because everyone is used to do: > > struct nlattr *attrs[XXX_DIAG_MAX+1]; > > nla_parse([...], XXX_DIAG_MAX, [.

Re: [PATCH 2/3] net: prepare netlink code for netlink diag

2013-03-21 Thread David Miller
From: Andrey Vagin Date: Thu, 21 Mar 2013 20:33:47 +0400 > Move a few declarations in a header. > > Acked-by: Pavel Emelyanov > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Pablo Neira Ayuso > Cc: "Eric W. Biederman" > Cc: Gao feng > Cc: Thomas Graf > Signed-off-by: Andrey Vagin Appli

Re: [PATCH 3/3] netlink: Diag core and basic socket info dumping (v2)

2013-03-21 Thread David Miller
From: Andrey Vagin Date: Thu, 21 Mar 2013 20:33:48 +0400 > The netlink_diag can be built as a module, just like it's done in > unix sockets. > > The core dumping message carries the basic info about netlink sockets: > family, type and protocol, portis, dst_group, dst_portid, state. > > Groups c

Re: [PATCH] stmmac: don't return zero on failure path in stmmac_pci_probe()

2013-02-03 Thread David Miller
From: Alexey Khoroshilov Date: Sat, 2 Feb 2013 02:09:19 +0400 > If stmmac_dvr_probe() fails in stmmac_pci_probe(), it breaks off > initialization, > deallocates all resources, but returns zero. > The patch adds -ENODEV as return value in this case. > > Found by Linux Driver Verification projec

Re: [PATCH next] OF: convert devtree lock from rw_lock to raw spinlock

2013-02-04 Thread David Miller
From: Paul Gortmaker Date: Mon, 4 Feb 2013 11:05:21 -0500 > From: Thomas Gleixner > > With the locking cleanup in place (from "OF: Fixup resursive > locking code paths"), we can now do the conversion from the > rw_lock to a raw spinlock as required for preempt-rt. > > The previous cleanup and

Re: [PATCH 0/8] drivers/net: Remove unnecessary alloc/OOM messages

2013-02-04 Thread David Miller
From: Joe Perches Date: Sun, 3 Feb 2013 19:28:07 -0800 > Remove all the OOM messages that follow kernel alloc > failures as there is already a generic equivalent to > these messages in the mm subsystem. > > Joe Perches (8): > caif: Remove unnecessary alloc/OOM messages > can: Remove unneces

Re: [PATCH] net: mac80211/cfg.c: fix error using of sizeof()

2013-02-06 Thread David Miller
From: Cong Ding Date: Wed, 6 Feb 2013 17:23:45 +0100 > Using 'sizeof' on array given as function argument returns size of a pointer > rather than the size of array. > > Signed-off-by: Cong Ding > --- > net/mac80211/cfg.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff -

Re: linux-next: build failure after merge of the final tree

2013-02-06 Thread David Miller
From: Greg Kroah-Hartman Date: Wed, 6 Feb 2013 09:52:05 -0800 > Sorry for missing this one, the fix looks correct to me, I'll queue it > up in my tree, or it can go through David's. It should go via your tree, my tree didn't add this regression. -- To unsubscribe from this list: send the line "u

Re: pull request: wireless 2013-02-06

2013-02-06 Thread David Miller
From: "John W. Linville" Date: Wed, 6 Feb 2013 14:34:23 -0500 > Please consider this pull request for the 3.8 stream... > > Included is a bluetooth pull. Gustavo says: > > "Two simple fixes for 3.8. One of the patches fixes a situation > where the connection wasn't terminated if a timeout ocur

Re: [PATCH] net: core: Remove unnecessary alloc/OOM messages

2013-02-06 Thread David Miller
From: Joe Perches Date: Mon, 04 Feb 2013 18:48:16 -0800 > alloc failures already get standardized OOM > messages and a dump_stack. > > Signed-off-by: Joe Perches Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kerne

Re: [PATCH 1/5] r8169: Remove firmware code

2013-02-06 Thread David Miller
Francois please review this series, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 10/15] drivers/net,AT91RM9200: add missing GENERIC_HARDIRQS dependency

2013-02-06 Thread David Miller
From: Heiko Carstens Date: Wed, 6 Feb 2013 17:23:58 +0100 > The AT91RM9200 driver call devm_request_irq() and therefore should > depend on GENERIC_HARDIRQS to prevent link/compile errors on plaforms > without GENERIC_HARDIRQS. > > Cc: "David S. Miller" > Signed-off-by: Heiko Carstens Acked-b

Re: [PATCH 0/2] fix kernel crash with macvtap on top of LRO

2013-02-07 Thread David Miller
From: Ben Hutchings Date: Thu, 7 Feb 2013 16:20:46 + > If the consensus is still that we must preserve packets exactly (aside > from the usual modifications by IP routers) then LRO should be disabled > on all devices for which forwarding is enabled. I believe this is still undoubtedly the co

Re: [PATCH] tcp: sysctl to disable TCP simultaneous connect

2013-02-07 Thread David Miller
Sorry I'm not applying this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] tcp: sysctl to disable TCP simultaneous connect

2013-02-07 Thread David Miller
From: Kees Cook Date: Thu, 7 Feb 2013 10:44:02 -0800 > David: I know you aren't a fan of this patch, but I'd like to try to > convince you. :) This leaves the feature enabled and add a toggle for > systems (like Chrome OS) that don't want to risk this DoS at all. > There are so very many other to

Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-02-07 Thread David Miller
From: Ben Hutchings Date: Thu, 7 Feb 2013 20:02:55 + > On Thu, 2013-02-07 at 21:39 +0800, Freddy Xin wrote: >> From: Freddy Xin >> >> This is a resubmission. >> Added "const" to ethtool_ops structure and fixed the coding style of >> AX88179_BULKIN_SIZE array. >> Fixed the issue that the de

Re: splice() giving unexpected EOF in 3.7.3 and 3.8-rc4+

2013-02-07 Thread David Miller
From: Eric Wong Date: Fri, 8 Feb 2013 02:39:46 + > David Miller wrote: >> From: Eric Dumazet >> Date: Fri, 18 Jan 2013 22:13:16 -0800 >> >> > On Fri, 2013-01-18 at 21:54 -0800, Eric Dumazet wrote: >> > >> >> >> >> Hmm,

Re: [PATCH] linux-3.8-rc6 Fix Missing Allocation Failure Checks

2013-02-08 Thread David Miller
From: syrine tlili Date: Fri, 8 Feb 2013 15:35:52 +0100 > --- linux-3.8-rc6-vanilla/arch/x86/platform/efi/efi.c 2013-02-01 > 02:08:14.0 +0100 Your email client corrupted the patch by breaking up long lines amongst other things. Please read Documentation/email-clients.txt to learn how to

Re: [PATCH] atm/iphase: rename fregt_t -> ffreg_t

2013-02-08 Thread David Miller
From: chas williams - CONTRACTOR Date: Fri, 8 Feb 2013 09:58:42 -0500 > On Fri, 8 Feb 2013 11:19:11 +0100 > Heiko Carstens wrote: > >> We have conflicting type qualifiers for "freg_t" in s390's ptrace.h and the >> iphase atm device driver, which causes the compile error below. >> Unfortunately

Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-02-08 Thread David Miller
From: "David Laight" Date: Fri, 8 Feb 2013 10:23:08 - > It is much better to define constants for the bit values and > explicitly mask them as required. Yes, __be32/__le32 along with bit define macros is the only reasonable way to do this kind of stuff. -- To unsubscribe from this list: send

[GIT] Networking

2013-02-08 Thread David Miller
1) Revert iwlwifi reclaimed packet tracking, it causes problems for a bunch of folks. From Emmanuel Grumbach. 2) Work limiting code in brcmsmac wifi driver can clear tx status without processing the event. From Arend van Spriel. 3) rtlwifi USB driver processes wrong SKB, fix from Larry F

Re: [GIT] Networking

2013-02-08 Thread David Miller
From: Linus Torvalds Date: Sat, 9 Feb 2013 08:00:39 +1100 > However, there's still the r8169 regressions (see the emails with the > subject "regression: NETDEV WATCHDOG: eth0 (r8169): transmit queue 0 > timed out"). It's bisected, and a revert is reported to fix things. > It's not in this pull re

Re: [PATCH] drivers: net: Remove remaining alloc/OOM messages

2013-02-08 Thread David Miller
From: Joe Perches Date: Thu, 07 Feb 2013 13:46:27 -0800 > alloc failures already get standardized OOM > messages and a dump_stack. > > For the affected mallocs around these OOM messages: > > Converted kmallocs with multiplies to kmalloc_array. > Converted a kmalloc/memcpy to kmemdup. > Removed

Re: [Pv-drivers] [PATCH 0/1] VM Sockets for Linux upstreaming

2013-02-08 Thread David Miller
From: Dmitry Torokhov Date: Fri, 8 Feb 2013 17:20:44 -0800 > Hi David, > > On Wed, Feb 06, 2013 at 04:23:55PM -0800, Andy King wrote: >> In an effort to improve the out-of-the-box experience with Linux kernels for >> VMware users, VMware is working on readying the VM Sockets (VSOCK, formerly >>

Re: [PATCH 04/16] sparc idle: rename pm_idle to sparc_idle

2013-02-10 Thread David Miller
From: Len Brown Date: Sun, 10 Feb 2013 00:58:11 -0500 > From: Len Brown > > (pm_idle)() is being removed from linux/pm.h > because Linux does not have such a cross-architecture concept. > > sparc uses an idle function pointer in its architecture > specific code. So we re-name sparc use of pm_

Re: [GIT] Networking

2013-02-10 Thread David Miller
From: Francois Romieu Date: Fri, 8 Feb 2013 23:50:26 +0100 > Linus Torvalds : > [...] >> However, there's still the r8169 regressions (see the emails with the >> subject "regression: NETDEV WATCHDOG: eth0 (r8169): transmit queue 0 >> timed out"). It's bisected, and a revert is reported to fix th

Re: [PATCH 0/1] VM Sockets for Linux upstreaming

2013-02-10 Thread David Miller
From: Andy King Date: Wed, 6 Feb 2013 16:23:55 -0800 > In an effort to improve the out-of-the-box experience with Linux kernels for > VMware users, VMware is working on readying the VM Sockets (VSOCK, formerly > VMCI Sockets) (vsock) kernel module for inclusion in the Linux kernel. The > purpose

Re: [PATCHv2-net-3.8 0/3] fix kernel crash with macvtap on top of LRO

2013-02-10 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 7 Feb 2013 15:12:56 +0200 > At the moment, macvtap crashes are observed if macvtap is attached > to an interface with LRO enabled. > The crash in question is BUG() in macvtap_skb_to_vnet_hdr. > This happens because several drivers set gso_size but not gso_typ

Re: [PATCH 0/2] fix kernel crash with macvtap on top of LRO

2013-02-10 Thread David Miller
From: Ben Hutchings Date: Thu, 7 Feb 2013 22:31:35 + > On Thu, 2013-02-07 at 23:33 +0200, Michael S. Tsirkin wrote: >> We might want to add code to forward LRO status from macvlan >> (not macvtap) back to the lowerdev, so that setting up forwarding >> from macvlan disables LRO on the lowerdev

Re: [PATCH net-next] net neighbour,decnet: Ensure to align device private data on preferred alignment.

2013-02-10 Thread David Miller
From: YOSHIFUJI Hideaki Date: Sun, 10 Feb 2013 02:00:59 +0900 > To allow both of protocol-specific data and device-specific data > attached with neighbour entry, and to eliminate size calculation > cost when allocating entry, sizeof protocol-speicic data must be > multiple of NEIGH_PRIV_ALIGN. O

Re: [PATCH] sun.com documentation fixes

2013-02-11 Thread David Miller
From: Christian Kujau Date: Mon, 11 Feb 2013 03:52:49 -0800 (PST) > > After I came across a help text for SUNGEM mentioning a broken sun.com > URL, I felt like fixing those up, as they are now pointing to oracle.com > URLs. > > Signed-off-by: Christian Kujau Acked-by: David S. Miller -- To

Re: [PATCH 185/222] tcp: fix MSG_SENDPAGE_NOTLAST logic

2013-02-11 Thread David Miller
From: Ben Hutchings Date: Fri, 01 Feb 2013 18:40:57 +0100 > On Wed, 2013-01-16 at 13:56 -0200, Herton Ronaldo Krzesinski wrote: >> 3.5.7.3 -stable review patch. If anyone has any objections, please let me >> know. >> >> -- >> >> From: Eric Dumazet >> >> commit ae62ca7b03217b

Re: [PATCH] ieee802154/at231rf230: deadlock in at86rf230_xmit

2013-02-12 Thread David Miller
linux-kernel is not the correct mailing list to post networking patches, net...@vger.kernel.org is, thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-i

Re: pull request: wireless 2013-02-12

2013-02-12 Thread David Miller
From: "John W. Linville" Date: Tue, 12 Feb 2013 11:03:16 -0500 > Here is another handful of late-breaking fixes intended for the 3.8 > stream... Hopefully the will still make it! :-) > > There are three mac80211 fixes pulled from Johannes: > > "Here are three fixes still for the 3.8 stream, th

Re: [PATCH] net: ethernet: ti: remove redundant NULL check.

2013-02-12 Thread David Miller
From: Cyril Roelandt Date: Tue, 12 Feb 2013 22:54:46 +0100 > cpdma_chan_destroy() on a NULL pointer is a no-op, so the NULL check in > cpdma_ctlr_destroy() can safely be removed. > > Signed-off-by: Cyril Roelandt ... > @@ -450,8 +450,7 @@ int cpdma_ctlr_destroy(struct cpdma_ctlr *ctlr) >

Re: [PATCH] net: ethernet: ti: remove redundant NULL check.

2013-02-12 Thread David Miller
From: Cyril Roelandt Date: Tue, 12 Feb 2013 23:54:41 +0100 > Ok, I resent, though I forgot to add "v2". Don't worry about that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ker

Re: Freescale FEC: fall back to random address

2013-04-02 Thread David Miller
From: Frank Li Date: Tue, 2 Apr 2013 21:23:17 +0800 > David will merge it Someone needs to make a clean resubmission of it though, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] of_net.h: Provide dummy functions if OF_NET is not configured

2013-04-02 Thread David Miller
From: Rob Herring Date: Mon, 01 Apr 2013 14:14:10 -0500 > On 04/01/2013 02:01 PM, Guenter Roeck wrote: >> On Mon, Apr 01, 2013 at 01:44:24PM -0500, Rob Herring wrote: >>> On 04/01/2013 01:19 PM, Guenter Roeck wrote: of_get_mac_address() and of_get_phy_mode() are only provided if OF_NET

Re: [PATCH] VSOCK: Handle changes to the VMCI context ID.

2013-04-02 Thread David Miller
From: Reilly Grant Date: Mon, 1 Apr 2013 11:41:52 -0700 > The VMCI context ID of a virtual machine may change at any time. There > is a VMCI event which signals this but datagrams may be processed before > this is handled. It is therefore necessary to be flexible about the > destination context

Re: [PATCH 0/5] Provide empty functions if OF_NET is not configured

2013-04-02 Thread David Miller
From: Guenter Roeck Date: Tue, 2 Apr 2013 12:35:06 -0700 > Provide empty functions for of_get_phy_mode() and of_get_mac_address() > if OF_NET is not configured. Modify affected drivers to rely on the > now available functions. All applied, but please post your patches against the appropriate tr

[GIT] Networking

2013-04-02 Thread David Miller
1) Fix VSOCK layer handling of context ID changes, from Reilly Grant. 2) Now that we have a synchronize_net() in netdev_rx_handler_unregister(), we can't let any call sites hold locks. Unfortunately bonding does, so we have to drop the rwlock there a little bit earlier, fix from Veacesl

Re: [PATCH net-next 5/7] r8169: add a new chip for RTL8111G

2013-04-02 Thread David Miller
From: Francois Romieu Date: Wed, 3 Apr 2013 01:20:08 +0200 > hayeswang : >> Francois Romieu [mailto:rom...@fr.zoreil.com] > [...] >> > There is close to zero added value for this stuff in the kernel. >> > You may as well move it completely into the firmware. >> >> Do you mean all of the phy se

Re: [Linux-zigbee-devel] [PATCH 1/6] mac802154: Immediately retry sending failed packets

2013-04-02 Thread David Miller
From: Alan Ott Date: Tue, 02 Apr 2013 21:24:59 -0400 > I like it for a couple of reasons. > 1. Most supported devices have only single packet output buffer, so > blocking in the driver is the most straight-forward way to handle it. > The alternative is to make each driver have a workqueue for xmi

Re: [Linux-zigbee-devel] [PATCH 1/6] mac802154: Immediately retry sending failed packets

2013-04-02 Thread David Miller
From: Alan Ott Date: Tue, 02 Apr 2013 21:59:37 -0400 > On 04/02/2013 09:56 PM, David Miller wrote: >> From: Alan Ott >> Date: Tue, 02 Apr 2013 21:24:59 -0400 >> >>> I like it for a couple of reasons. >>> 1. Most supported devices have only single packe

Re: [Linux-zigbee-devel] [PATCH 1/6] mac802154: Immediately retry sending failed packets

2013-04-02 Thread David Miller
From: Alan Ott Date: Tue, 02 Apr 2013 22:25:28 -0400 > The workqueue in mac802154 is only needed because the current mac802154 > xmit() function is designed to be blocking and synchronous. > > Prior to my patch (#3/6), that very same workqueue would actually queue > up packets (without bound). T

Re: [PATCH v4 0/6] Generic PHY Framework

2013-04-02 Thread David Miller
From: Kishon Vijay Abraham I Date: Wed, 3 Apr 2013 11:29:53 +0530 > Hi, > > On Friday 29 March 2013 12:01 AM, David Miller wrote: >> >> You really need to CC: net...@vger.kernel.org rather than me >> explicitly >> on this patch set. > > I was CC'

Re: [PATCH v4 0/6] Generic PHY Framework

2013-04-03 Thread David Miller
From: Kishon Vijay Abraham I Date: Wed, 3 Apr 2013 12:05:30 +0530 > This patch series is about drivers/phy which will be used for now by > usb, sata and maybe some video PHY's. Network itself has a > comprehensive PHY in drivers/net/phy which we'd like to merge it with > drivers/phy so that we ha

Re: af_unix udev startup regression

2013-04-04 Thread David Miller
From: Linus Torvalds Date: Thu, 4 Apr 2013 11:03:28 -0700 > [ Fixed odd legacy subject line that has nothing to do with the actual bug ] > > Hmm. Can you double-check and verify that reverting that commit makes > things work again for you? > > Also, what's your distribution and setup? I'd like

Re: pull request: wireless 2013-04-03

2013-04-04 Thread David Miller
From: "John W. Linville" Date: Wed, 3 Apr 2013 14:16:48 -0400 > Here are some more fixes intended for the 3.9 stream... Pulled, thanks John. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at ht

Re: [PATCH v2] r8169: fix auto speed down issue

2013-04-04 Thread David Miller
From: Francois Romieu Date: Tue, 2 Apr 2013 23:37:36 +0200 > Hayes Wang : >> It would cause no link after suspending or shutdowning when the >> nic changes the speed to 10M and connects to a link partner which >> forces the speed to 100M. >> >> Check the link partner ability to determine which

Re: [PATCH v2 net-next 1/8] r8169: Remove firmware code

2013-04-04 Thread David Miller
Francois what is the status of this patch set? I see there is still some discussion about dependencies between patch #5 and #6, is that resolved? If so, should I just apply this series as-is? Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mes

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-04 Thread David Miller
From: Sven Joachim Date: Wed, 03 Apr 2013 13:41:32 +0200 > On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: > >> 3.8-stable review patch. If anyone has any objections, please let me know. > > I'm seeing several complaints from udevd at boot in both 3.8.6-rc1 and > 3.9-rc5: "udevd[56]: send

Re: [PATCH 1/2] Revert "af_unix: dont send SCM_CREDENTIAL when dest socket is NULL"

2013-04-04 Thread David Miller
From: ebied...@xmission.com (Eric W. Biederman) Date: Wed, 03 Apr 2013 19:13:35 -0700 > > This reverts commit 14134f6584212d585b310ce95428014b653dfaf6. > > The problem that the above patch was meant to address is that af_unix > messages are not being coallesced because we are sending unnecesarry

Re: [PATCH 2/2] af_unix: If we don't care about credentials coallesce all messages

2013-04-04 Thread David Miller
From: ebied...@xmission.com (Eric W. Biederman) Date: Wed, 03 Apr 2013 19:14:47 -0700 > > It was reported that the following LSB test case failed > https://lsbbugs.linuxfoundation.org/attachment.cgi?id=2144 because we > were not coallescing unix stream messages when the application was > expectin

Re: [PATCH 3/2] scm: Stop passing struct cred

2013-04-04 Thread David Miller
From: ebied...@xmission.com (Eric W. Biederman) Date: Wed, 03 Apr 2013 20:28:16 -0700 > > Now that uids and gids are completely encapsulated in kuid_t > and kgid_t we no longer need to pass struct cred which allowed > us to test both the uid and the user namespace for equality. > > Passing struc

Re: [PATCH v2 net-next] drivers/net: Enable IOMMU pass through for be2net

2013-04-05 Thread David Miller
From: Ivan Vecera Date: Fri, 05 Apr 2013 09:51:24 +0200 > Dave, I'd like to ask when do you plan to apply this patch? I'm waiting for the be2net driver maintainers to integrate it and resend it to me, they're usually very good about that. -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH] myri_sbus: remove firmware

2013-04-05 Thread David Miller
From: Paul Bolle Date: Fri, 05 Apr 2013 16:23:02 +0200 > Support for MyriCOM Gigabit Ethernet cards was removed in v3.1. Remove > the firmware too. > > Signed-off-by: Paul Bolle Acked-by: David S. Miller -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

[GIT] Networking

2013-04-05 Thread David Miller
1) Fix erroneous sock_orphan() leading to crashes and double kfree_skb() in NFC protocol. From Thierry Escande and Samuel Ortiz. 2) Fix use after free in remain-on-channel mac80211 code, from Johannes Berg. 3) nf_reset() needs to reset the NF tracing cookie, otherwise we can leak it fr

Re: [RFC PATCH v4 linux-next] et131x: Promote staging et131x driver to drivers/net

2013-01-28 Thread David Miller
From: Mark Einon Date: Wed, 23 Jan 2013 16:24:38 + > +endif # NET_VENDOR_AGERE > + Trailing empty line, delete it. > @@ -0,0 +1,6 @@ > +# > +# Makefile for the Agere ET-131x ethernet driver > +# > + > +obj-$(CONFIG_ET131X) += et131x.o > + Likewise, get rid of this trailing empty line. > +

Re: Web10g TCP statistics patch - mainlining into kernel?

2013-01-29 Thread David Miller
From: Ben Hutchings Date: Tue, 29 Jan 2013 17:49:15 + > On Fri, 2013-01-25 at 13:31 -0500, Valdis Kletnieks wrote: > [...] >> it's a zero-hit thing for people who don't choose to configure >> it into their kernel. > [...] > > People with high-overhead changes always say this, but before long

Re: [PATCHv2] tun: fix carrier on/off status

2013-01-29 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 28 Jan 2013 12:38:02 +0200 > Commit c8d68e6be1c3b242f1c598595830890b65cea64a removed carrier off call > from tun_detach since it's now called on queue disable and not only on > tun close. This confuses userspace which used this flag to detect a > free tun. T

  1   2   3   4   5   6   7   8   9   10   >