[PATCH 1/5] ARM: bcm2835: Define standard pinctrl groups in the gpio node.

2016-02-26 Thread Eric Anholt
ps we want enabled. Signed-off-by: Eric Anholt <e...@anholt.net> --- arch/arm/boot/dts/bcm283x.dtsi | 170 + 1 file changed, 170 insertions(+) diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi index 8aaf193..e91198e 10064

Re: [GIT PULL] bcm2835 DT changes for 4.6

2016-02-12 Thread Eric Anholt
Florian Fainelli <f.faine...@gmail.com> writes: > On 10/02/2016 10:51, Eric Anholt wrote: >> Martin Sperl <mar...@sperl.org> writes: >> >>>> On 09.02.2016, at 01:32, Eric Anholt <e...@anholt.net> wrote: >>>> >>>> Hi Florian.

Re: [PATCH 2/3] drm/vc4: Enable runtime PM.

2016-02-16 Thread Eric Anholt
Eric Anholt <e...@anholt.net> writes: > +#ifdef CONFIG_PM_SLEEP > +static int vc4_v3d_runtime_suspend(struct device *dev) > +{ > + struct vc4_v3d *v3d = dev_get_drvdata(dev); > + struct vc4_dev *vc4 = v3d->vc4; > + > + vc4_irq_uninstall(v

[PATCH 3/6] drm/vc4: Add another reg to HDMI debug dumping.

2016-02-16 Thread Eric Anholt
This is also involved in the HDMI setup sequence so it's nice to see it. Signed-off-by: Eric Anholt <e...@anholt.net> --- This patch and the next one I'd target for -next, since they aren't functional fixes. drivers/gpu/drm/vc4/vc4_hdmi.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 4/6] drm/vc4: Fix the name of the VSYNCD_EVEN register.

2016-02-16 Thread Eric Anholt
It's used for delaying vsync in interlaced mode. Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/gpu/drm/vc4/vc4_crtc.c | 2 +- drivers/gpu/drm/vc4/vc4_regs.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/d

drm/vc4: Modesetting fixes

2016-02-16 Thread Eric Anholt
This series fixes the highest priority problems reported from the driver getting enabled in Raspbian: modesetting on HDMI was broken if you weren't at the same resolution that the firmware had set up, or if the firmware hadn't set up HDMI at all.

[PATCH 2/6] drm/vc4: Bring HDMI up from power off if necessary.

2016-02-16 Thread Eric Anholt
If the firmware hadn't brought up HDMI for us, we need to do its power-on reset sequence (reset HD and and clear its STANDBY bits, reset HDMI, and leave the PHY disabled). Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/gpu/drm/vc4/vc4_hdmi.c | 29 - d

[PATCH 6/6] drm/vc4: Initialize scaler DISPBKGND on modeset.

2016-02-16 Thread Eric Anholt
We weren't updating the interlaced bit, so we'd scan out incorrectly if the firmware had brought up the TV encoder and we were switching to HDMI. Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/gpu/drm/vc4/vc4_crtc.c | 6 ++ drivers/gpu/drm/vc4/vc4_regs.h | 14 +++

[PATCH 5/6] drm/vc4: Fix setting of vertical timings in the CRTC.

2016-02-16 Thread Eric Anholt
It looks like when I went to add the interlaced bits, I just took the existing PV_VERT* block and indented it, instead of copy and pasting it first. Without this, changing resolution never worked. Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/gpu/drm/vc4/vc4_crtc.c | 10 +++

[PATCH 1/6] drm/vc4: Fix a framebuffer reference leak on async flip interrupt.

2016-02-16 Thread Eric Anholt
We'd need X to queue up an async pageflip while another is outstanding, and then take a SIGIO. I think X actually avoids sending out the next pageflip while one's already queued, but I'm not sure. Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/gpu/drm/vc4/vc4_crtc.c | 1 +

[GIT PULL 2/2] bcm2835 changes to DT for 4.6

2016-02-17 Thread Eric Anholt
The following changes since commit 92e963f50fc74041b5e9e744c330dca48e04f08d: Linux 4.5-rc1 (2016-01-24 13:06:47 -0800) are available in the git repository at: g...@github.com:anholt/linux.git bcm2835-dt-next-2016-02-17 for you to fetch changes up to

Re: [GIT PULL] bcm2835 DT changes for 4.6

2016-02-17 Thread Eric Anholt
Florian Fainelli <f.faine...@gmail.com> writes: > On 12/02/2016 16:53, Eric Anholt wrote: >> Florian Fainelli <f.faine...@gmail.com> writes: >> >>> On 10/02/2016 10:51, Eric Anholt wrote: >>>> Martin Sperl <mar...@sperl.org> write

[GIT PULL 1/2] bcm2835 changes to defconfigs for 4.6

2016-02-17 Thread Eric Anholt
The following changes since commit 92e963f50fc74041b5e9e744c330dca48e04f08d: Linux 4.5-rc1 (2016-01-24 13:06:47 -0800) are available in the git repository at: g...@github.com:anholt/linux.git bcm2835-defconfig-next-2016-02-17 for you to fetch changes up to

[GIT PULL] drm/vc4: changes for drm-next.

2016-02-17 Thread Eric Anholt
: Add support for YUV planes. (2016-02-16 11:24:08 -0800) This pull request brings in overlay plane support for vc4. Eric Anholt (10): drm/vc4: Improve comments

[GIT PULL] drm/vc4: changes for drm-fixes

2016-02-17 Thread Eric Anholt
integration due to build breakage) and waits for idle in the presence of signals (which X likes to do a lot). Eric Anholt (8): drm/vc4: Validate that WAIT_BO padding is cleared. drm/vc4: Fix the clear color for the first

[PATCH] i2c: bcm2835: Don't complain on -EPROBE_DEFER from getting our clock

2016-02-18 Thread Eric Anholt
Fixes dmesg spam when we just need to wait a moment for the clock driver to probe. Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/i2c/busses/i2c-bcm2835.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/buss

[PATCH 2/2] clk: bcm2835: Reuse CLK_DIVIDER_MAX_AT_ZERO for recalc_rate()

2016-02-15 Thread Eric Anholt
We were rolling this ourselves, but clk-divider can do it now. Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/clk/bcm/clk-bcm2835.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c

[PATCH 1/2] clk: bcm2835: Fix setting of PLL divider clock rates

2016-02-15 Thread Eric Anholt
monitor (everything except 720x400). Cc: sta...@vger.kernel.org Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/clk/bcm/clk-bcm2835.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c index 0

Re: [PATCH v5 01/13] mmc: sdhci-bcm2835: use sdhci_pltfm_init for private allocation

2016-02-16 Thread Eric Anholt
this allocation. > > Signed-off-by: Jisheng Zhang <jszh...@marvell.com> > Acked-by: Arnd Bergmann <a...@arndb.de> > Acked-by: Adrian Hunter <adrian.hun...@intel.com> Acked-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature

[PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull" parsing

2016-02-29 Thread Eric Anholt
From: Phil Elwell <p...@raspberrypi.org> The DT bindings for pinctrl-bcm2835 allow both the function and pull to contain either one entry or one per pin. However, an error in the DT parsing can cause failures if the number of pulls differs from the number of functions. Signed-off-by: Eric

[PATCH 0/2] drm/vc4: Fixes for Raspberry Pi 3

2016-02-29 Thread Eric Anholt
These are for fixing the vc4 driver on the Pi 3. Note that patch 2 will also be necessary for fixing HPD on the Pi2, which we've been carrying downstream patches to work around until now. Eric Anholt (2): drm/vc4: Let gpiolib know that we're OK with sleeping for HPD. drm/vc4: Respect

[PATCH 2/2] drm/vc4: Respect GPIO_ACTIVE_LOW on HDMI HPD if set in the devicetree.

2016-02-29 Thread Eric Anholt
The original Raspberry Pi had the GPIO active high, but the later models are active low. The DT GPIO bindings allow specifying the active flag, except that it doesn't get propagated to the gpiodesc, so you have to handle it yourself. Signed-off-by: Eric Anholt <e...@anholt.net> --- drive

[PATCH 1/2] drm/vc4: Let gpiolib know that we're OK with sleeping for HPD.

2016-02-29 Thread Eric Anholt
Fixes an error thrown every few seconds when we poll HPD when it's on a I2C to GPIO expander. Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/d

[PATCH 5/5] ARM: bcm2835: Add the DPI hardware to the device tree.

2016-03-18 Thread Eric Anholt
It's currently marked disabled, as it's not useful without a panel associated with it and the GPIO pins routed to ALT2. Signed-off-by: Eric Anholt <e...@anholt.net> --- arch/arm/boot/dts/bcm283x.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/bcm283

Re: [patch] drm/vc4: Return -EFAULT on copy_from_user() failure

2016-03-13 Thread Eric Anholt
Dan Carpenter writes: > The copy_from_user() function returns the number of bytes not copied but > we want to return a negative error code. > > Fixes: 463873d57014 ('drm/vc4: Add an API for creating GPU shaders in GEM > BOs.') > Signed-off-by: Dan Carpenter

[GIT PULL] drm-vc4-next for 4.6

2016-03-14 Thread Eric Anholt
for the Pi2/3. Dan Carpenter (1): drm/vc4: Return -EFAULT on copy_from_user() failure Eric Anholt (4): drm/vc4: Let gpiolib know that we're OK with sleeping for HPD. drm/vc4: Respect GPIO_ACTIVE_LOW on HDMI HPD if set

[GIT PULL] bcm2835 clk changes for 4.6 maybe

2016-03-19 Thread Eric Anholt
This is late, so feel free to drop it, but I figured I'd send it to you in case you were still open to merges. I've pounded on it a bit today (modesets to all sorts of resolutions on HDMI, used it for testing the DPI panel support that I'm hoping to have for 4.7, and did a whole lot of browsing

[PATCH 1/5] of: Add vendor prefix for On Tat Industrial Company.

2016-03-18 Thread Eric Anholt
This is the vendor for a 7" DPI panel sold by Adafruit which I'd like to describe in DT. Signed-off-by: Eric Anholt <e...@anholt.net> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bind

[PATCH 4/5] drm/vc4: Add DPI driver

2016-03-18 Thread Eric Anholt
The DPI interface involves taking a ton of our GPIOs to be used as outputs, and routing display signals over them in parallel. Signed-off-by: Eric Anholt <e...@anholt.net> --- .../devicetree/bindings/display/brcm,bcm-vc4.txt | 67 +++ drivers/gpu/drm/vc4/Kconfig

[PATCH 0/5] drm/vc4: DPI panel support

2016-03-18 Thread Eric Anholt
In preparation for working on DSI panel support, I wrote the much simpler support for DPI panels. I've tested it on the 7" DPI panel from Adafruit, with panel-simple support included here. Eric Anholt (5): of: Add vendor prefix for On Tat Industrial Company. panel-simple: Add the 7

[PATCH 2/5] panel-simple: Add the 7" DPI panel from Adafruit.

2016-03-18 Thread Eric Anholt
This is a basic TFT panel with a 40-pin FPC connector on it. The specification doesn't define timings, but the Adafruit instructions were setting up 800x480 CVT. Signed-off-by: Eric Anholt <e...@anholt.net> --- .../bindings/display/panel/ontat,yx700wv03.txt | 7 + drivers/gpu/drm

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

2016-03-18 Thread Eric Anholt
Stefan Wahren writes: > Hi Eric, > hi Martin, > >> John Youn hat am 16. März 2016 um 19:28 geschrieben: >> >> >> On 3/10/2016 11:14 AM, John Youn wrote: >> > On 3/9/2016 11:06 AM, Doug Anderson wrote: >> >> Stefan, >> >> >> >> On Wed, Mar 9, 2016

[PATCH 3/5] drm: Add an encoder and connector type enum for DPI.

2016-03-18 Thread Eric Anholt
ll for the user (who, if anything, knows their product is a DPI kippah/panel combo), and actually doesn't have to exist (one could connect the 28 GPIOs directly to something else). Simply "DPI" seems like a good compromise name to distinguish from the HDMI, DSI, and TV connectors . Signed-off-by

Re: [PATCH 4/4] irqchip: bcm2836: Use a more generic memory barrier call

2016-04-10 Thread Eric Anholt
Stephen Warren <swar...@wwwdotorg.org> writes: > On 04/08/2016 12:20 PM, Eric Anholt wrote: >> Stephen Warren <swar...@wwwdotorg.org> writes: >> >>> On 04/04/2016 09:44 PM, Eric Anholt wrote: >>>> dsb() requires an argument on arm64, so we needed

Re: [PATCH 4/4] irqchip: bcm2836: Use a more generic memory barrier call

2016-04-08 Thread Eric Anholt
Stephen Warren <swar...@wwwdotorg.org> writes: > On 04/04/2016 09:44 PM, Eric Anholt wrote: >> dsb() requires an argument on arm64, so we needed to add "sy". >> Instead, take this opportunity to switch to the same smp_wmb() call >> that gic uses for its IPIs

Re: [PATCH 2/2] clk: bcm2835: Fix PLL poweron

2016-04-08 Thread Eric Anholt
Stefan Wahren <stefan.wah...@i2se.com> writes: > Hi Eric, > >> Eric Anholt <e...@anholt.net> hat am 5. April 2016 um 05:20 geschrieben: >> >> >> In poweroff, we set the reset bit and the power down bit, but only >> managed to unset the reset

[PATCH 7/8] dmaengine: bcm2835: add slave_sg support to bcm2835-dma

2016-03-19 Thread Eric Anholt
Tested using: * Hifiberry I2S card (using cyclic DMA) * fb_st7735r SPI-framebuffer (using slave_sg DMA via spi-bcm2835) playing BigBuckBunny for audio and video. Signed-off-by: Martin Sperl <ker...@martin.sperl.org> Reviewed-by: Eric Anholt <e...@anholt.net> Signed-off-by: Eric Anhol

[PATCH 4/8] dmaengine: bcm2835: move cyclic member from bcm2835_chan into bcm2835_desc

2016-03-19 Thread Eric Anholt
From: Martin Sperl <ker...@martin.sperl.org> In preparation to consolidating code we move the cyclic member into the bcm_2835_desc structure. Signed-off-by: Martin Sperl <ker...@martin.sperl.org> Reviewed-by: Eric Anholt <e...@anholt.net> Signed-off-by: Eric Anholt <e...@anh

[PATCH 5/8] dmaengine: bcm2835: move controlblock chain generation into separate method

2016-03-19 Thread Eric Anholt
method bcm2835_dma_create_cb_chain. Signed-off-by: Martin Sperl <ker...@martin.sperl.org> Reviewed-by: Eric Anholt <e...@anholt.net> Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/dma/bcm2835-dma.c | 294 +++--- 1 file changed, 198 insertions(+), 96

[PATCH 1/8] dmaengine: bcm2835: set residue_granularity field

2016-03-19 Thread Eric Anholt
ed-off-by: Matthias Reichl <h...@horus.com> Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Signed-off-by: Martin Sperl <ker...@martin.sperl.org> Reviewed-by: Eric Anholt <e...@anholt.net> Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/dma/bcm2835-dma.c | 1 +

[PATCH 6/8] dmaengine: bcm2835: limit max length based on channel type

2016-03-19 Thread Eric Anholt
veral sources/target DREQS that are 32 bit wide we need to have the transfer to be a multiple of 4 as this would break the transfer otherwise. This is why the limit of (64K - 4) was chosen over the alternative of (64K - 4K). Signed-off-by: Martin Sperl <ker...@martin.sperl.org> Reviewed-by: Eric

[PATCH 0/8 v4] bcm2835 DMA slave support

2016-03-19 Thread Eric Anholt
Here's the series for DMA slave and memcpy support for 2835, with the DT changes to enable the remaining channels dropped out while that goes through review. I had to do some minor conflict resolution, but it was pretty mechanical, and I tested again with dmatest on the last patch. Martin Sperl

[PATCH 2/8] dmaengine: bcm2835: remove unnecessary masking of dma channels

2016-03-20 Thread Eric Anholt
cetree in the default property "brcm,dma-channel-mask = <0x7f35>;" So we can remove the whole masking of DMA channels. Signed-off-by: Martin Sperl <ker...@martin.sperl.org> Reviewed-by: Eric Anholt <e...@anholt.net> Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers

[PATCH 8/8] dmaengine: bcm2835: add dma_memcopy support to bcm2835-dma

2016-03-19 Thread Eric Anholt
From: Martin Sperl <ker...@martin.sperl.org> Also added check for an error condition in bcm2835_dma_create_cb_chain that showed up during development of this patch. Tested using dmatest for all enabled channels. Signed-off-by: Martin Sperl <ker...@martin.sperl.org> Reviewed-by: Er

[PATCH 3/8] dmaengine: bcm2835: add additional defines for DMA-registers

2016-03-19 Thread Eric Anholt
From: Martin Sperl <ker...@martin.sperl.org> Add additional defines describing the DMA registers as well as adding some more documentation to those registers. Signed-off-by: Martin Sperl <ker...@martin.sperl.org> Reviewed-by: Eric Anholt <e...@anholt.net> Signed-off-

[PATCH 4/5] drm/vc4: Add DPI driver

2016-03-24 Thread Eric Anholt
The DPI interface involves taking a ton of our GPIOs to be used as outputs, and routing display signals over them in parallel. v2: Use display_info.bus_formats[] to replace our custom DT properties. Signed-off-by: Eric Anholt <e...@anholt.net> --- .../devicetree/bindings/display/br

[PATCH 1/5] of: Add vendor prefix for On Tat Industrial Company.

2016-03-24 Thread Eric Anholt
This is the vendor for a 7" DPI panel sold by Adafruit which I'd like to describe in DT. Signed-off-by: Eric Anholt <e...@anholt.net> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 inserti

[PATCH 0/5 v2] drm/vc4: DPI panel support

2016-03-24 Thread Eric Anholt
This is round 2 of the DPI panel support for vc4. This time the custom properties are dropped in favor of connector->display_info.bus_formats[]. Testable tree is at: https://github.com/anholt/linux/tree/drm-vc4-dpi-boot Eric Anholt (5): of: Add vendor prefix for On Tat Industrial Comp

[PATCH 3/5] drm: Add an encoder and connector type enum for DPI.

2016-03-24 Thread Eric Anholt
ll for the user (who, if anything, knows their product is a DPI kippah/panel combo), and actually doesn't have to exist (one could connect the 28 GPIOs directly to something else). Simply "DPI" seems like a good compromise name to distinguish from the HDMI, DSI, and TV connectors . Signed-off-by

[PATCH 2/5] panel-simple: Add the 7" DPI panel from Adafruit.

2016-03-24 Thread Eric Anholt
This is a basic TFT panel with a 40-pin FPC connector on it. The specification doesn't define timings, but the Adafruit instructions were setting up 800x480 CVT. v2: Add .bus_format and vsync/hsync flags. Signed-off-by: Eric Anholt <e...@anholt.net> Acked-by: Rob Herring <r...@k

[PATCH 5/5] ARM: bcm2835: Add the DPI hardware to the device tree.

2016-03-24 Thread Eric Anholt
It's currently marked disabled, as it's not useful without a panel associated with it and the GPIO pins routed to ALT2. Signed-off-by: Eric Anholt <e...@anholt.net> --- arch/arm/boot/dts/bcm283x.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/bcm283

Re: [PATCH 4/5] drm/vc4: Add DPI driver

2016-03-24 Thread Eric Anholt
Rob Herring <r...@kernel.org> writes: > On Fri, Mar 18, 2016 at 07:42:45PM -0700, Eric Anholt wrote: >> The DPI interface involves taking a ton of our GPIOs to be used as >> outputs, and routing display signals over them in parallel. >> >> Signed-off

Re: [PATCH 3/3] ARM: bcm2835: Add VC4 to the device tree.

2016-03-08 Thread Eric Anholt
Stephen Warren <swar...@wwwdotorg.org> writes: > On 03/04/2016 01:32 PM, Eric Anholt wrote: >> VC4 is the GPU (display and 3D) present on the 283x. > >> diff --git a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts >> b/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts >

[GIT PULL] drm-vc4-fixes-2016-03-03

2016-03-03 Thread Eric Anholt
) This pull request fixes the major VC4 HDMI modesetting bugs found when the first wave of users showed up in Raspbian. Eric Anholt (6): drm/vc4: Fix a framebuffer reference leak on async flip

Re: [PATCH 1/5] ARM: bcm2835: Define standard pinctrl groups in the gpio node.

2016-03-03 Thread Eric Anholt
Stephen Warren <swar...@wwwdotorg.org> writes: > On 02/26/2016 11:19 AM, Eric Anholt wrote: >> The BCM2835-ARM-Peripherals.pdf documentation specifies what the >> function selects do for the pins, and there are a bunch of obvious >> groupings to be made. With t

Re: [PATCH 2/5] ARM: bcm2835: Replace alt0/i2s_alt[02] with standard groups.

2016-03-03 Thread Eric Anholt
Stephen Warren <swar...@wwwdotorg.org> writes: > On 02/26/2016 11:19 AM, Eric Anholt wrote: >> Since all of these pins were documented, we can use their names to >> explain what's going on. > >> diff --git a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts >> b/arch

[PATCH 1/2] dt-bindings: Add root properties for Raspberry Pi 3

2016-03-04 Thread Eric Anholt
Signed-off-by: Eric Anholt <e...@anholt.net> --- Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt

[PATCH 2/2] ARM: bcm2835: Add devicetree for the Raspberry Pi 3.

2016-03-04 Thread Eric Anholt
For now this doesn't support the new hardware present on the Pi 3 (BT, wifi, GPIO expander). Since the GPIO expander isn't supported, we also don't have the LEDs like the other board files do. Signed-off-by: Eric Anholt <e...@anholt.net> --- arch/arm/boot/dts/Makefile| 3 +-

Re: [PATCH 2/2] ARM: bcm2835: Add devicetree for the Raspberry Pi 3.

2016-03-04 Thread Eric Anholt
Mark Rutland <mark.rutl...@arm.com> writes: > On Fri, Mar 04, 2016 at 10:39:29AM -0800, Eric Anholt wrote: >> For now this doesn't support the new hardware present on the Pi 3 (BT, >> wifi, GPIO expander). Since the GPIO expander isn't supported, we >> also don't h

[PATCH 2/3] drm/vc4: Recognize a more specific compatible string for V3D.

2016-03-04 Thread Eric Anholt
. Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/gpu/drm/vc4/vc4_v3d.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c index 31de5d1..e6d3c60 100644 --- a/drivers/gpu/drm/vc4/vc4_v3d.c +++ b/drivers/gpu/drm/vc4/vc4

[PATCH 3/3] ARM: bcm2835: Add VC4 to the device tree.

2016-03-04 Thread Eric Anholt
VC4 is the GPU (display and 3D) present on the 283x. Signed-off-by: Eric Anholt <e...@anholt.net> --- v2: Sort by register address, mark HDMI as disabled by default in the SoC file and enable it from -rpi. v3: Add references to the pixel/HSM clocks for HDMI. Rename compatibility s

[PATCH 0/3] ARM: bcm2835: Include VC4 GPU in the DT

2016-03-04 Thread Eric Anholt
This has been floating around out of tree, and the Pi Foundation is including a variant of it in the device tree overlay in its firmware update system. Eric Anholt (3): dt-bindings: Add binding docs for V3D. drm/vc4: Recognize a more specific compatible string for V3D. ARM: bcm2835: Add VC4

[PATCH 1/3] dt-bindings: Add binding docs for V3D.

2016-03-04 Thread Eric Anholt
This was missed in the upstreaming process. Signed-off-by: Eric Anholt <e...@anholt.net> --- Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt b/Documen

Re: [PATCH 02/41] clk: bcm: Remove CLK_IS_ROOT

2016-03-02 Thread Eric Anholt
Stephen Boyd <sb...@codeaurora.org> writes: > This flag is a no-op now. Remove usage of the flag. I like that this flag is going away. It's a nice cleanup. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature

Re: [PATCH 2/2] ARM: bcm2835: Add devicetree for the Raspberry Pi 3.

2016-03-04 Thread Eric Anholt
Mark Rutland <mark.rutl...@arm.com> writes: > On Fri, Mar 04, 2016 at 10:55:03AM -0800, Eric Anholt wrote: >> Mark Rutland <mark.rutl...@arm.com> writes: >> >> > On Fri, Mar 04, 2016 at 10:39:29AM -0800, Eric Anholt wrote: >> >> For now this does

Re: [PATCH 2/3] ARM: multi_v7_defconfig: Switch BCM2835 to sdhci-iproc.c for MMC

2016-04-01 Thread Eric Anholt
Stephen Warren <swar...@wwwdotorg.org> writes: > On 03/31/2016 06:28 PM, Eric Anholt wrote: >> This approximately triples write performance for the SD card. My card >> is too full of important data to collect very reliable numbers, but I >> see 271.361% +/- 166.742%

[PATCH 1/2] clk: bcm2835: Fix compiler warnings on 64-bit builds

2016-04-04 Thread Eric Anholt
Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/clk/bcm/clk-bcm2835.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c index 4c0f1b5..87616de 100644 --- a/drivers/clk/bcm/clk-bcm2835.c +++ b/d

[PATCH] drm/vc4: Fix NULL deref in HDMI init error path

2016-04-04 Thread Eric Anholt
If you make it here other than through err_destroy_encoder, vc4->hdmi is still NULL. Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/v

[PATCH 0/2] minor bcm2835 clock fixes

2016-04-04 Thread Eric Anholt
). Eric Anholt (2): clk: bcm2835: Fix compiler warnings on 64-bit builds clk: bcm2835: Fix PLL poweron drivers/clk/bcm/clk-bcm2835.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) -- 2.7.0

[PATCH 2/2] clk: bcm2835: Fix PLL poweron

2016-04-04 Thread Eric Anholt
In poweroff, we set the reset bit and the power down bit, but only managed to unset the reset bit for poweron. This meant that if HDMI did -EPROBE_DEFER after it had grabbed its clocks, we'd power down the PLLH (that had been on at boot time) and never recover. Signed-off-by: Eric Anholt &l

[PATCH 0/4] irqchip: bcm2835: arm64 port

2016-04-04 Thread Eric Anholt
Here's the series for irqchip-bcm283x on arm64 for the Pi3. Since I'd like to land Makefile changes that would enable building irqchip-bcm283x on arm64, it would be nice if I had either a stable branch to merge from, or an ack to merge them through the arm64 tree. Eric Anholt (4): irqchip

[PATCH 2/4] irqchip: bcm2836: Drop smp_set_ops on arm64 builds

2016-04-04 Thread Eric Anholt
For arm64, the bootloader will instead be implementing the spin-table enable method. Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/irqchip/irq-bcm2836.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-b

[PATCH 3/4] irqchip: bcm2836: Fix compiler warning on 64-bit build

2016-04-04 Thread Eric Anholt
Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/irqchip/irq-bcm2836.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c index 4ae9f76..ee62413 100644 --- a/drivers/irqchip/irq-bcm2836.c +++ b/drivers/i

[PATCH 1/4] irqchip: bcm2835: Avoid arch/arm-specific handle_IRQ

2016-04-04 Thread Eric Anholt
This is equivalent and works for arm64 as well. Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/irqchip/irq-bcm2835.c | 3 +-- drivers/irqchip/irq-bcm2836.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-bcm2835.c b/drivers/irqchip/irq-b

[PATCH 4/4] irqchip: bcm2836: Use a more generic memory barrier call

2016-04-04 Thread Eric Anholt
Signed-off-by: Eric Anholt <e...@anholt.net> --- drivers/irqchip/irq-bcm2836.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c index ee62413..a99b630 100644 --- a/drivers/irqchip/irq-bcm2836.c +++ b/drivers/irqch

[PATCH 4/4] ARM: bcm2835: Enable NFS root support.

2016-03-31 Thread Eric Anholt
This is also present in multi_v7_defconfig, and means that I can test the pi1 with the 2835 defconfig in my normal environment. Signed-off-by: Eric Anholt <e...@anholt.net> --- arch/arm/configs/bcm2835_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/c

[PATCH 3/4] ARM: bcm2835: Enable the VC4 graphics driver in the defconfig

2016-03-31 Thread Eric Anholt
Combined with the queued DT changes, we now get HDMI and 3D support. Signed-off-by: Eric Anholt <e...@anholt.net> --- arch/arm/configs/bcm2835_defconfig | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm/configs/bcm2835_defconfig b/arch/arm/c

[PATCH 1/3] ARM: multi_v7_defconfig: Add more BCM2835 support

2016-03-31 Thread Eric Anholt
The WDT is required for reboot and I2S is used for audio devices on the P5 header (or BT audio on the Pi3). Signed-off-by: Eric Anholt <e...@anholt.net> --- arch/arm/configs/multi_v7_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/ar

[PATCH 2/3] ARM: multi_v7_defconfig: Switch BCM2835 to sdhci-iproc.c for MMC

2016-03-31 Thread Eric Anholt
to be unaffected. Signed-off-by: Eric Anholt <e...@anholt.net> --- arch/arm/configs/multi_v7_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 43a8ce0..a913520 100644 --- a/arch/arm/c

[PATCH 3/3] ARM: multi_v7_defconfig: Build in DWC2 USB support

2016-03-31 Thread Eric Anholt
This allows the Raspberry Pi 2 to be network booted from the defconfig. Signed-off-by: Eric Anholt <e...@anholt.net> --- arch/arm/configs/multi_v7_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/c

[PATCH 1/4] ARM: bcm2835: Switch BCM2835 to sdhci-iproc.c for MMC

2016-03-31 Thread Eric Anholt
to be unaffected. Signed-off-by: Eric Anholt <e...@anholt.net> --- arch/arm/configs/bcm2835_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/configs/bcm2835_defconfig b/arch/arm/configs/bcm2835_defconfig index 1ef69fc..1617fd2 100644 --- a/arch/arm/c

[PATCH 2/4] ARM: bcm2835: Enable CONFIG_PM.

2016-03-31 Thread Eric Anholt
The power domain driver we've enabled doesn't actually do anything without it, and we need it to do its job for VC4 to initialize successfully. Signed-off-by: Eric Anholt <e...@anholt.net> --- arch/arm/configs/bcm2835_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/c

Re: [GIT PULL] bcm2835 clk changes for 4.6 maybe

2016-03-29 Thread Eric Anholt
Stephen Boyd <sb...@codeaurora.org> writes: > On 03/17, Eric Anholt wrote: >> This is late, so feel free to drop it, but I figured I'd send it to >> you in case you were still open to merges. I've pounded on it a bit >> today (modesets to all sorts of resolutions on H

[GIT PULL 1/2] bcm2835 DT changes for 4.7

2016-04-20 Thread Eric Anholt
was suggested by the simplefb maintainer as the solution agreed upon at ELCE 2014, and was acked by the DRM maintainer for merging through this tree. Eric Anholt (2): drm/vc4: Kick out the simplefb framebuffer before we set up KMS

[GIT PULL 2/2] bcm2835 defconfig changes for 4.7

2016-04-20 Thread Eric Anholt
-0700) This pull request brings in changes for bcm2835_defconfig and multi_v7_defconfig in 4.7. Eric Anholt (7): ARM: multi_v7_defconfig: Add more BCM2835 support

[PATCH] drm/vc4: Add support for gamma ramps.

2016-04-20 Thread Eric Anholt
We could possibly save a bit of power by not requesting gamma conversion when the ramp happens to be 1:1, but at least if all the CRTCs are off the SRAM will be disabled. This should fix brightness sliders in a lot of fullscreen games. Signed-off-by: Eric Anholt <e...@anholt.net> --- d

Re: [PATCH 2/2] ASoC: bcm2835: Add S16_LE support via packed DMA transfers

2016-04-27 Thread Eric Anholt
Matthias Reichl <h...@horus.com> writes: > The bcm2835-i2s driver already has support for the S16_LE format but > that format hasn't been made available because dmaengine_pcm didn't > support packed data transfers. Acked-by: Eric Anholt <e...@anholt.net> signature

Re: [PATCH 2/4] hwrng: bcm2835: Support Broadcom NSP SoC rng

2016-05-23 Thread Eric Anholt
the register to the same value on the Pi, even though the firmware has presumably been setting it for us already. However, this patch is still correct and I'm fine with it, so it's: Acked-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature

Re: [PATCH 1/4] dt-bindings: rng: Northstar Plus SoC rng bindings

2016-05-23 Thread Eric Anholt
Yendapally Reddy Dhananjaya Reddy <yendapally.re...@broadcom.com> writes: > Document the bindings used by Northstar Plus(NSP) SoC random number > generator. > > Signed-off-by: Yendapally Reddy Dhananjaya Reddy > <yendapally.re...@broadcom.com> Acked-by: E

Re: [PATCH 4/4] hwrng: bcm2835: Read as much data as available

2016-05-23 Thread Eric Anholt
num_words = (readl(rng_base + RNG_STATUS) >> 24); Optional cleanup: here and in the return statement, drop the extra parenthesis. Functionality-wise, this patch looks great to me, and should make the driver more efficient. With at least the binary operators change done, it will be: Reviewed-by: Eric Anholt <e...@anholt.net> Thanks! signature.asc Description: PGP signature

Re: [PATCH 3/3] clk: bcm2835: Skip PLLC clocks when deciding on a new clock parent

2016-05-11 Thread Eric Anholt
Stephen Boyd <sb...@codeaurora.org> writes: > On 05/09, Eric Anholt wrote: >> If the firmware had set up a clock to source from PLLC, go along with >> it. But if we're looking for a new parent, we don't want to switch it >> to PLLC because the firmware will force

Re: [PATCH 0/4] add minimal bcm2835-sdram driver

2016-05-12 Thread Eric Anholt
ker...@martin.sperl.org writes: > From: Martin Sperl > > As the sdram clock is a critical clock to the system > the minimal bcm2835-sdram driver claims (and enables) > this clock and also exposes the corresponding sdram > registers via debugfs. I don't think this is a

Re: [PATCH 0/3] clk: bcm2835: critical clocks and parent selection

2016-05-12 Thread Eric Anholt
Martin Sperl <ker...@martin.sperl.org> writes: >> On 10.05.2016, at 19:37, Eric Anholt <e...@anholt.net> wrote: >> >> Martin Sperl <ker...@martin.sperl.org> writes: >>> and also hsm (probably hardware security module): >>> root@raspcm:~# cat

Re: [PATCH 0/3] clk: bcm2835: critical clocks and parent selection

2016-05-12 Thread Eric Anholt
Martin Sperl <ker...@martin.sperl.org> writes: > On 10.05.2016, at 21:58, Martin Sperl <ker...@martin.sperl.org> wrote: >> >> >> >>> On 10.05.2016, at 19:37, Eric Anholt <e...@anholt.net> wrote: >>> >>> Martin Sperl <ker...@

[GIT PULL] drm-vc4-next-2016-05-13

2016-05-13 Thread Eric Anholt
Here are a few late bugfixes for vc4. I figure it's best to bring them in through -next since 4.6 is about done. I've based them late in your -next branch to avoid needing conflict resolution. The following changes since commit bafb86f5bc3173479002555dea7f31d943b12332: Merge tag 'v4.6-rc7'

Re: [PATCH v2] drm/vc4: Return -EBUSY if there's already a pending flip event.

2016-05-03 Thread Eric Anholt
robert.f...@collabora.com writes: > From: Robert Foss > > As per the documentation in drm_crtc.h, atomic_commit should return > -EBUSY if an asycnhronous update is requested and there is an earlier > update pending. > > Note: docs cited here are drm_crtc.h, and the

Re: [PATCH 2/2] clk: bcm2835: Skip PLLC clocks when deciding on a new clock parent

2016-05-02 Thread Eric Anholt
Martin Sperl <ker...@martin.sperl.org> writes: >> On 26.04.2016, at 21:39, Eric Anholt <e...@anholt.net> wrote: >> >> If the firmware had set up a clock to source from PLLC, go along with >> it. But if we're looking for a new parent, we don't want to switc

Re: [PATCH v2] drm/vc4: Return -EBUSY if there's already a pending flip event.

2016-05-10 Thread Eric Anholt
Robert Foss <robert.f...@collabora.com> writes: > On 2016-05-03 03:22 PM, Eric Anholt wrote: >> robert.f...@collabora.com writes: >> >>> From: Robert Foss <robert.f...@collabora.com> >>> >>> As per the documentation in drm_crtc.h, atomic_com

Re: [PATCH 0/3] clk: bcm2835: critical clocks and parent selection

2016-05-10 Thread Eric Anholt
Martin Sperl <ker...@martin.sperl.org> writes: > On 10.05.2016 03:01, Eric Anholt wrote: >> With the new patch 2 inserted between my previous pair, I think this >> should cover Martin's bugs with clock disabling. >> >> I tested patch 2 to be important on the d

Re: [PATCH] drm/vc4: Return -EBUSY if there's already a pending flip event.

2016-05-02 Thread Eric Anholt
robert.f...@collabora.com writes: > From: Robert Foss > > As per the docs, atomic_commit should return -EBUSY "if an asycnhronous > update is requested and there is an earlier update pending". Note: docs cited here are drm_crtc.h, and the whole quote is: *

<    1   2   3   4   5   6   7   8   9   10   >