[PATCH 3/3 v2] ARM: bcm2835: Add the mailbox to the device tree

2015-05-05 Thread Eric Anholt
Signed-off-by: Eric Anholt Acked-by: Lee Jones Acked-by: Stephen Warren --- v2: Update for #mbox-cells 0 change in the driver. arch/arm/boot/dts/bcm2835.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi index

[PATCH 1/3 v6] dt/bindings: Add binding for the BCM2835 mailbox driver

2015-05-05 Thread Eric Anholt
From: Lubomir Rintel This patch was split out of Lubomir's original mailbox patch by Eric Anholt, and the required properties documentation and examples have been filled out more completely and updated for the driver being changed to expose a single channel. Signed-off-by: Lubomir R

[PATCH 2/3 v8] mailbox: Enable BCM2835 mailbox support

2015-05-05 Thread Eric Anholt
The driver was originally submitted by Lubomir, based on the out-of-tree 2708 mailbox driver. Eric Anholt fixed it up for upstreaming, with the major functional change being that it now has no notion of multiple channels (since that is a firmware-dependent concept) and instead the raspberrypi-fir

Re: [PATCH 2/3 v2] ARM: bcm2835: Add the Raspberry Pi firmware driver

2015-05-18 Thread Eric Anholt
Noralf Trønnes writes: > Den 13.05.2015 21:00, skrev Eric Anholt: >> This gives us a function for making mailbox property channel requests >> of the firmware, which is most notable in that it will let us get and >> set clock rates. >> &g

[PATCH 1/3 v3] dt/bindings: Add binding for the Raspberry Pi firmware driver

2015-05-18 Thread Eric Anholt
This driver will provide support for calls into the firmware that will be used by other drivers like cpufreq and vc4. --- v2: Improve commit message, point to mailbox.txt for how mboxes work. v3: Use Lee's suggestion for mailbox phandle docs, fix spelling of "raspberry". .../devicetree/bindi

[PATCH 2/3 v3] ARM: bcm2835: Add the Raspberry Pi firmware driver

2015-05-18 Thread Eric Anholt
This gives us a function for making mailbox property channel requests of the firmware, which is most notable in that it will let us get and set clock rates. Signed-off-by: Eric Anholt --- v2: Drop power-domains stuff for now since we don't have the driver core support to make it u

Raspberry Pi DT clocks series

2015-05-18 Thread Eric Anholt
Here's a series to add a real clock provider on Raspberry Pi. Previously, we've been using a mix of fixed clocks from clk-bcm2835.c (though some of them failed to get used by their intended consumers), and fixed-clock nodes in the DT. This driver gives us the ability to enable/disable our clocks,

[PATCH 2/7] ARM: bcm2835: Add a Raspberry Pi-specific clock driver.

2015-05-18 Thread Eric Anholt
n the firmware driver isn't supported yet, but it also avoids issues with disabling "unused" clocks due to them not yet being connected to their consumers in the DT. Signed-off-by: Eric Anholt --- drivers/clk/Makefile | 1 + drivers/clk/clk-raspber

[PATCH 7/7] ARM: bcm2835: Tie SPI clock to the core clock rate.

2015-05-18 Thread Eric Anholt
We were previously using a fixed clock declared in the 2835 DT, but it's actually the core clock, and it might not be the same if you had adjusted it using the firmware's config.txt. Signed-off-by: Eric Anholt --- This is the only patch in the series I haven't really tested, sin

[PATCH 4/7] ARM: bcm2835: Drop never-used clock-frequency property of uart0.

2015-05-18 Thread Eric Anholt
This appears to have been copy-and-paste from another serial driver's DT. The driver has never used this value -- instead, the pl011 driver is getting the fixed 20201000.uart clock from clk-bcm2835.c. Signed-off-by: Eric Anholt --- arch/arm/boot/dts/bcm2835.dtsi | 1 - 1 file chang

[PATCH 3/7] ARM: bcm2835: Add DT for the firmware clocks driver.

2015-05-18 Thread Eric Anholt
Signed-off-by: Eric Anholt --- arch/arm/boot/dts/bcm2835-rpi.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi index ace33f6..ac5f84c 100644 --- a/arch/arm/boot/dts/bcm2835-rpi.dtsi +++ b/arch/arm/boot/dts

[PATCH 1/7] dt/bindings: Add binding for the Raspberry Pi clock provider

2015-05-18 Thread Eric Anholt
The hardware clocks are not controllable by the ARM, so we have to make requests to the firmware to do so from the VPU side. This will let us replace fixed clocks in our DT with actual clock control (and correct frequency information). Signed-off-by: Eric Anholt --- .../bindings/clock

[PATCH 5/7] ARM: bcm2835: Drop the fixed sys_pclk.

2015-05-18 Thread Eric Anholt
Nothing uses it, and I can't find any evidence that anything ever has. Signed-off-by: Eric Anholt --- drivers/clk/clk-bcm2835.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/clk/clk-bcm2835.c b/drivers/clk/clk-bcm2835.c index 6b950ca..dd295e4 100644 --- a/drivers/cl

[PATCH 6/7] ARM: bcm2835: Use the RPi firmware clocks for uart.

2015-05-18 Thread Eric Anholt
This gets us a correct apb_pclk, which previously was accidentally using the "20201000.uart" clock from clk-bcm2835.c, due to the fallback clk_get_sys() path. Signed-off-by: Eric Anholt --- arch/arm/boot/dts/bcm2835-rpi.dtsi | 7 +++ arch/arm/boot/dts/bcm2835.dtsi | 2 +

Re: [PATCH] ARM: bcm2835: Use 0x4 prefix for DMA bus addresses to SDRAM.

2015-05-13 Thread Eric Anholt
Lee Jones writes: > On Tue, 05 May 2015, Eric Anholt wrote: > >> Stephen Warren writes: >> >> > On 05/04/2015 01:33 PM, Eric Anholt wrote: >> >> There exists a tiny MMU, configurable only by the VC (running the >> >> closed firmware),

[PATCH 1/3 v2] dt/bindings: Add binding for the Raspberry Pi firmware driver

2015-05-13 Thread Eric Anholt
This driver will provide support for calls into the firmware that will be used by other drivers like cpufreq and vc4. Signed-off-by: Eric Anholt --- v2: Improve commit message, point to mailbox.txt for how mboxes work. .../devicetree/bindings/arm/bcm/raspberrypi,firmware.txt | 16

[PATCH 3/3 v2] ARM: bcm2835: Add the firmware driver information to the RPi DT

2015-05-13 Thread Eric Anholt
Signed-off-by: Eric Anholt Acked-by: Lee Jones (previous version with pm-domains) --- v2: Drop pm-domains stuff since I've dropped it from the firmware driver for now, until we get drivers/base fixed. arch/arm/boot/dts/bcm2835-rpi.dtsi | 7 +++ 1 file changed, 7 insertions(+)

RPi firmware driver v2

2015-05-13 Thread Eric Anholt
Here's a new version of the firmware driver. This series applies on top of for-rpi-next from Lee Jones's tree: git://git.kernel.org/pub/scm/linux/kernel/git/rpi/linux-rpi.git But it won't actually probe without merging in mailbox-for-next: https://git.linaro.org/landing-teams/working/fujitsu/in

[PATCH 2/3 v2] ARM: bcm2835: Add the Raspberry Pi firmware driver

2015-05-13 Thread Eric Anholt
This gives us a function for making mailbox property channel requests of the firmware, which is most notable in that it will let us get and set clock rates. Signed-off-by: Eric Anholt --- v2: Drop power-domains stuff for now since we don't have the driver core support to make it u

[PATCH] mailbox/bcm2835: Fix mailbox full detection.

2015-05-13 Thread Eric Anholt
and under a mutex. Suggested-by: Phil Elwell Signed-off-by: Eric Anholt --- This is a port of a patch by Noralf from the downstream Raspberry Pi tree. Noralf said he didn't want attribution on this patch, even if it looks a lot like his. drivers/mailbox/bcm2835-mailbox.c | 3 ++- 1

Re: [PATCH 1/3 v2] dt/bindings: Add binding for the Raspberry Pi firmware driver

2015-05-14 Thread Eric Anholt
Lee Jones writes: > On Wed, 13 May 2015, Eric Anholt wrote: > >> This driver will provide support for calls into the firmware that will >> be used by other drivers like cpufreq and vc4. >> >> Signed-off-by: Eric Anholt >> --- >> >> v2: Impr

[PATCH] PM / Domains: If an OF node is found but no device probed yet, defer.

2015-03-11 Thread Eric Anholt
If we've declared a power domain in the OF, and the OF node is found but the requested domain hasn't been registered on it yet, then we probably have just tried to probe before the power domain driver has. Defer our device's probe until it shows up. Signed-off-by: Eric Anholt

Re: [PATCH] PM / Domains: If an OF node is found but no device probed yet, defer.

2015-03-12 Thread Eric Anholt
Geert Uytterhoeven writes: > On Wed, Mar 11, 2015 at 11:08 PM, Rafael J. Wysocki > wrote: >> More CCes. >> >> On Wednesday, March 11, 2015 08:27:28 AM Eric Anholt wrote: >>> If we've declared a power domain in the OF, and the OF node is found >>>

Re: [PATCH] PM / Domains: If an OF node is found but no device probed yet, defer.

2015-03-18 Thread Eric Anholt
Ulf Hansson writes: > On 13 March 2015 at 19:01, Kevin Hilman wrote: >> Geert Uytterhoeven writes: >> >>> On Wed, Mar 11, 2015 at 11:08 PM, Rafael J. Wysocki >>> wrote: >>>> More CCes. >>>> >>>> On Wednesday, March 11

[GIT PULL 2/2] bcm2835 defconfig changes for 4.7

2016-04-20 Thread Eric Anholt
-0700) This pull request brings in changes for bcm2835_defconfig and multi_v7_defconfig in 4.7. Eric Anholt (7): ARM: multi_v7_defconfig: Add more BCM2835 support

[GIT PULL 1/2] bcm2835 DT changes for 4.7

2016-04-20 Thread Eric Anholt
suggested by the simplefb maintainer as the solution agreed upon at ELCE 2014, and was acked by the DRM maintainer for merging through this tree. Eric Anholt (2): drm/vc4: Kick out the simplefb framebuffer before we set up KMS

[PATCH] drm/vc4: Add support for gamma ramps.

2016-04-20 Thread Eric Anholt
We could possibly save a bit of power by not requesting gamma conversion when the ramp happens to be 1:1, but at least if all the CRTCs are off the SRAM will be disabled. This should fix brightness sliders in a lot of fullscreen games. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4

[PATCH] drm/vc4: Add missing render node support

2016-04-20 Thread Eric Anholt
There shouldn't be any other driver support necessary, since none of the driver-specific ioctls ever required auth, and none of them deal with modesetting. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/dr

Re: [PATCH 3/3] ARM: bcm2835: Add VC4 to the device tree.

2016-03-08 Thread Eric Anholt
Stephen Warren writes: > On 03/04/2016 01:32 PM, Eric Anholt wrote: >> VC4 is the GPU (display and 3D) present on the 283x. > >> diff --git a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts >> b/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts > >> +&hdmi { >>

[PATCH 1/5] of: Add vendor prefix for On Tat Industrial Company.

2016-03-18 Thread Eric Anholt
This is the vendor for a 7" DPI panel sold by Adafruit which I'd like to describe in DT. Signed-off-by: Eric Anholt --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefi

[PATCH 4/5] drm/vc4: Add DPI driver

2016-03-18 Thread Eric Anholt
The DPI interface involves taking a ton of our GPIOs to be used as outputs, and routing display signals over them in parallel. Signed-off-by: Eric Anholt --- .../devicetree/bindings/display/brcm,bcm-vc4.txt | 67 +++ drivers/gpu/drm/vc4/Kconfig| 1 + drivers/gpu/drm

[PATCH 0/5] drm/vc4: DPI panel support

2016-03-18 Thread Eric Anholt
In preparation for working on DSI panel support, I wrote the much simpler support for DPI panels. I've tested it on the 7" DPI panel from Adafruit, with panel-simple support included here. Eric Anholt (5): of: Add vendor prefix for On Tat Industrial Company. panel-simple: Add

[PATCH 2/5] panel-simple: Add the 7" DPI panel from Adafruit.

2016-03-18 Thread Eric Anholt
This is a basic TFT panel with a 40-pin FPC connector on it. The specification doesn't define timings, but the Adafruit instructions were setting up 800x480 CVT. Signed-off-by: Eric Anholt --- .../bindings/display/panel/ontat,yx700wv03.txt | 7 + drivers/gpu/drm/panel/panel-sim

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

2016-03-18 Thread Eric Anholt
Stefan Wahren writes: > Hi Eric, > hi Martin, > >> John Youn hat am 16. März 2016 um 19:28 geschrieben: >> >> >> On 3/10/2016 11:14 AM, John Youn wrote: >> > On 3/9/2016 11:06 AM, Doug Anderson wrote: >> >> Stefan, >> >> >> >> On Wed, Mar 9, 2016 at 11:01 AM, Stefan Wahren >> >> wrote: >> >>> >

[PATCH 3/5] drm: Add an encoder and connector type enum for DPI.

2016-03-18 Thread Eric Anholt
ain things as well for the user (who, if anything, knows their product is a DPI kippah/panel combo), and actually doesn't have to exist (one could connect the 28 GPIOs directly to something else). Simply "DPI" seems like a good compromise name to distinguish from the HDMI, DSI, and TV con

[PATCH 5/5] ARM: bcm2835: Add the DPI hardware to the device tree.

2016-03-18 Thread Eric Anholt
It's currently marked disabled, as it's not useful without a panel associated with it and the GPIO pins routed to ALT2. Signed-off-by: Eric Anholt --- arch/arm/boot/dts/bcm283x.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arc

[GIT PULL] bcm2835 clk changes for 4.6 maybe

2016-03-19 Thread Eric Anholt
This is late, so feel free to drop it, but I figured I'd send it to you in case you were still open to merges. I've pounded on it a bit today (modesets to all sorts of resolutions on HDMI, used it for testing the DPI panel support that I'm hoping to have for 4.7, and did a whole lot of browsing of

[PATCH 5/8] dmaengine: bcm2835: move controlblock chain generation into separate method

2016-03-19 Thread Eric Anholt
: Martin Sperl Reviewed-by: Eric Anholt Signed-off-by: Eric Anholt --- drivers/dma/bcm2835-dma.c | 294 +++--- 1 file changed, 198 insertions(+), 96 deletions(-) diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c index b3bc382..4db0e23

[PATCH 7/8] dmaengine: bcm2835: add slave_sg support to bcm2835-dma

2016-03-19 Thread Eric Anholt
card (using cyclic DMA) * fb_st7735r SPI-framebuffer (using slave_sg DMA via spi-bcm2835) playing BigBuckBunny for audio and video. Signed-off-by: Martin Sperl Reviewed-by: Eric Anholt Signed-off-by: Eric Anholt --- drivers/dma/bcm2835-dma.c | 113

[PATCH 4/8] dmaengine: bcm2835: move cyclic member from bcm2835_chan into bcm2835_desc

2016-03-19 Thread Eric Anholt
From: Martin Sperl In preparation to consolidating code we move the cyclic member into the bcm_2835_desc structure. Signed-off-by: Martin Sperl Reviewed-by: Eric Anholt Signed-off-by: Eric Anholt --- drivers/dma/bcm2835-dma.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 6/8] dmaengine: bcm2835: limit max length based on channel type

2016-03-19 Thread Eric Anholt
32 bit wide we need to have the transfer to be a multiple of 4 as this would break the transfer otherwise. This is why the limit of (64K - 4) was chosen over the alternative of (64K - 4K). Signed-off-by: Martin Sperl Reviewed-by: Eric Anholt Signed-off-by: Eric Anholt --- drivers/dm

Re: [PATCH 4/4] irqchip: bcm2836: Use a more generic memory barrier call

2016-04-08 Thread Eric Anholt
Stephen Warren writes: > On 04/04/2016 09:44 PM, Eric Anholt wrote: >> dsb() requires an argument on arm64, so we needed to add "sy". >> Instead, take this opportunity to switch to the same smp_wmb() call >> that gic uses for its IPIs. This is a less strong barri

Re: [PATCH 2/2] clk: bcm2835: Fix PLL poweron

2016-04-08 Thread Eric Anholt
Stefan Wahren writes: > Hi Eric, > >> Eric Anholt hat am 5. April 2016 um 05:20 geschrieben: >> >> >> In poweroff, we set the reset bit and the power down bit, but only >> managed to unset the reset bit for poweron. This meant that if HDMI >> did -EP

Re: [PATCH 4/4] irqchip: bcm2836: Use a more generic memory barrier call

2016-04-10 Thread Eric Anholt
Stephen Warren writes: > On 04/08/2016 12:20 PM, Eric Anholt wrote: >> Stephen Warren writes: >> >>> On 04/04/2016 09:44 PM, Eric Anholt wrote: >>>> dsb() requires an argument on arm64, so we needed to add "sy". >>>> Instead, take this

[PATCH 1/2] clk: bcm2835: Fix compiler warnings on 64-bit builds

2016-04-04 Thread Eric Anholt
Signed-off-by: Eric Anholt --- drivers/clk/bcm/clk-bcm2835.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c index 4c0f1b5..87616de 100644 --- a/drivers/clk/bcm/clk-bcm2835.c +++ b/drivers/clk/bcm/clk

[PATCH 0/2] minor bcm2835 clock fixes

2016-04-04 Thread Eric Anholt
to trigger). Eric Anholt (2): clk: bcm2835: Fix compiler warnings on 64-bit builds clk: bcm2835: Fix PLL poweron drivers/clk/bcm/clk-bcm2835.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) -- 2.7.0

[PATCH 2/2] clk: bcm2835: Fix PLL poweron

2016-04-04 Thread Eric Anholt
In poweroff, we set the reset bit and the power down bit, but only managed to unset the reset bit for poweron. This meant that if HDMI did -EPROBE_DEFER after it had grabbed its clocks, we'd power down the PLLH (that had been on at boot time) and never recover. Signed-off-by: Eric Anhol

[PATCH 2/4] irqchip: bcm2836: Drop smp_set_ops on arm64 builds

2016-04-04 Thread Eric Anholt
For arm64, the bootloader will instead be implementing the spin-table enable method. Signed-off-by: Eric Anholt --- drivers/irqchip/irq-bcm2836.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c index 233ccdd

[PATCH 3/4] irqchip: bcm2836: Fix compiler warning on 64-bit build

2016-04-04 Thread Eric Anholt
Signed-off-by: Eric Anholt --- drivers/irqchip/irq-bcm2836.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c index 4ae9f76..ee62413 100644 --- a/drivers/irqchip/irq-bcm2836.c +++ b/drivers/irqchip/irq-bcm2836.c

[PATCH 1/4] irqchip: bcm2835: Avoid arch/arm-specific handle_IRQ

2016-04-04 Thread Eric Anholt
This is equivalent and works for arm64 as well. Signed-off-by: Eric Anholt --- drivers/irqchip/irq-bcm2835.c | 3 +-- drivers/irqchip/irq-bcm2836.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-bcm2835.c b/drivers/irqchip/irq-bcm2835.c index bf9cc5f

[PATCH 4/4] irqchip: bcm2836: Use a more generic memory barrier call

2016-04-04 Thread Eric Anholt
Signed-off-by: Eric Anholt --- drivers/irqchip/irq-bcm2836.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c index ee62413..a99b630 100644 --- a/drivers/irqchip/irq-bcm2836.c +++ b/drivers/irqchip/irq-bcm2836.c @@ -19

[PATCH 0/4] irqchip: bcm2835: arm64 port

2016-04-04 Thread Eric Anholt
Here's the series for irqchip-bcm283x on arm64 for the Pi3. Since I'd like to land Makefile changes that would enable building irqchip-bcm283x on arm64, it would be nice if I had either a stable branch to merge from, or an ack to merge them through the arm64 tree. Eric Anholt (4):

Re: [PATCH v2 1/2] clk: bcm2835: Fix compiler warnings on 64-bit builds

2016-04-18 Thread Eric Anholt
Stephen Boyd writes: > On 04/13, Eric Anholt wrote: >> Signed-off-by: Eric Anholt >> --- > > Acked-by: Stephen Boyd > > Or can I merge this? It wasn't addressed To: me so who knows. Yeah, please merge it. signature.asc Description: PGP signature

Re: [PATCH] mmc: bcm2835: fix platform_no_drv_owner.cocci warnings

2016-04-19 Thread Eric Anholt
Julia Lawall writes: > Remove .owner field if calls are used which set it automatically > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Acked-by: Eric Anholt signature.asc Description: PGP signature

[PATCH] drm/vc4: Kick out the simplefb framebuffer before we set up KMS.

2016-04-19 Thread Eric Anholt
If we don't, then simplefb stays loaded on /dev/fb0 even though scanout isn't happening from simplefb's memory area any more, and you end up with no console. Signed-off-by: Eric Anholt --- Dave: It would be nice if I could merge this patch through bcm2835-dt-next, where I'

Re: [GIT PULL] bcm2835 clk changes for 4.6 maybe

2016-03-29 Thread Eric Anholt
Stephen Boyd writes: > On 03/17, Eric Anholt wrote: >> This is late, so feel free to drop it, but I figured I'd send it to >> you in case you were still open to merges. I've pounded on it a bit >> today (modesets to all sorts of resolutions on HDMI, used it for &

[PATCH 2/3] ARM: multi_v7_defconfig: Switch BCM2835 to sdhci-iproc.c for MMC

2016-03-31 Thread Eric Anholt
ce appears to be unaffected. Signed-off-by: Eric Anholt --- arch/arm/configs/multi_v7_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 43a8ce0..a913520 100644 --- a/arch/arm/configs/multi_v7_defconfig +++

[PATCH 3/3] ARM: multi_v7_defconfig: Build in DWC2 USB support

2016-03-31 Thread Eric Anholt
This allows the Raspberry Pi 2 to be network booted from the defconfig. Signed-off-by: Eric Anholt --- arch/arm/configs/multi_v7_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index a913520

[PATCH 1/3] ARM: multi_v7_defconfig: Add more BCM2835 support

2016-03-31 Thread Eric Anholt
The WDT is required for reboot and I2S is used for audio devices on the P5 header (or BT audio on the Pi3). Signed-off-by: Eric Anholt --- arch/arm/configs/multi_v7_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs

[PATCH 4/4] ARM: bcm2835: Enable NFS root support.

2016-03-31 Thread Eric Anholt
This is also present in multi_v7_defconfig, and means that I can test the pi1 with the 2835 defconfig in my normal environment. Signed-off-by: Eric Anholt --- arch/arm/configs/bcm2835_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/configs/bcm2835_defconfig b/arch/arm

[PATCH 3/4] ARM: bcm2835: Enable the VC4 graphics driver in the defconfig

2016-03-31 Thread Eric Anholt
Combined with the queued DT changes, we now get HDMI and 3D support. Signed-off-by: Eric Anholt --- arch/arm/configs/bcm2835_defconfig | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm/configs/bcm2835_defconfig b/arch/arm/configs/bcm2835_defconfig index 1192a6f

[PATCH 1/4] ARM: bcm2835: Switch BCM2835 to sdhci-iproc.c for MMC

2016-03-31 Thread Eric Anholt
ce appears to be unaffected. Signed-off-by: Eric Anholt --- arch/arm/configs/bcm2835_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/configs/bcm2835_defconfig b/arch/arm/configs/bcm2835_defconfig index 1ef69fc..1617fd2 100644 --- a/arch/arm/configs/bcm2835

[PATCH 2/4] ARM: bcm2835: Enable CONFIG_PM.

2016-03-31 Thread Eric Anholt
The power domain driver we've enabled doesn't actually do anything without it, and we need it to do its job for VC4 to initialize successfully. Signed-off-by: Eric Anholt --- arch/arm/configs/bcm2835_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/a

Re: [PATCH 2/3] ARM: multi_v7_defconfig: Switch BCM2835 to sdhci-iproc.c for MMC

2016-04-01 Thread Eric Anholt
Stephen Warren writes: > On 03/31/2016 06:28 PM, Eric Anholt wrote: >> This approximately triples write performance for the SD card. My card >> is too full of important data to collect very reliable numbers, but I >> see 271.361% +/- 166.742% improvement (n=3 before, 6

[PATCH] drm/vc4: Fix NULL deref in HDMI init error path

2016-04-04 Thread Eric Anholt
If you make it here other than through err_destroy_encoder, vc4->hdmi is still NULL. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index d8b8

Re: [PATCH 1/2] clk: bcm2835: Support for clock parent selection

2015-11-04 Thread Eric Anholt
Remi Pommarel writes: > Some bcm2835 clocks used by hardware (like "PWM" or "H264") can have multiple > parents. These clocks divide the rate of one parent which can be selected by > setting the proper bits in their clock control register. > > Previously all these parents where handled by a mux c

Re: [PATCH 2/2] clk: bcm2835: Add PWM clock support

2015-11-04 Thread Eric Anholt
Remi Pommarel writes: > Register the pwm clock for bcm2835. > This patch also adds the ability to set a clock default rate. I don't think we should be setting a default clock rate. That should be up to the thing that uses the clock. If we need a standard rate set on all Raspberry Pis, other th

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-09-14 Thread Eric Anholt
Russell King - ARM Linux writes: > On Sun, Sep 13, 2015 at 09:24:48PM +0200, Noralf Trønnes wrote: >> >> Den 22.07.2015 23:32, skrev Eric Anholt: >> >Noralf Trønnes writes: >> > >> >>Add a duplicate irq range with an offset on the hwirq's so th

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-09-16 Thread Eric Anholt
Russell King - ARM Linux writes: > On Mon, Sep 14, 2015 at 07:33:09AM -0700, Eric Anholt wrote: >> So, while FIQ isn't used in upstream, I think it's worthwhile to merge. >> It is another step to bringing the downstream developers into the fold. > > I want to se

[PATCH 3/4] drm: Move exynos "match_add all devices matching my drivers" to core.

2015-09-16 Thread Eric Anholt
This is a really nice way to handle the component setup. The subsystem driver knows that it's got a bunch of component drivers, and for any devices that matched its component drivers, it wants all of those to bind to it as master. Signed-off-by: Eric Anholt --- drivers/gp

drm: Platform helpers for exynos-style component registration.

2015-09-16 Thread Eric Anholt
I had previously modeled vc4 off of msm's component driver registration, but on further investigation exynos has an even cleaner way of doing it. Here's a series to turn exynos's style into core helpers, and use it from msm. The patches are build tested, but I don't have either of the platforms t

[PATCH 4/4] drm/msm: Use exynos's model for handling component driver matching.

2015-09-16 Thread Eric Anholt
This eliminates the need for the "connectors" and "gpus" nodes in the devicetree, which we were doing nothing connector- or gpu-specific with. Signed-off-by: Eric Anholt --- drivers/gpu/drm/msm/msm_drv.c | 65 +-- include/drm/drmP.h

[PATCH 2/4] drm/msm: Use drm_platform_register/unregister_drivers().

2015-09-16 Thread Eric Anholt
This matches how exynos handles the registration of its component drivers. Signed-off-by: Eric Anholt --- drivers/gpu/drm/msm/adreno/adreno_device.c | 12 +--- drivers/gpu/drm/msm/dsi/dsi.c | 16 +--- drivers/gpu/drm/msm/dsi/dsi.h | 2 -- drivers

[PATCH 1/4] drm: Put platform driver registration/unregistration loops in core.

2015-09-16 Thread Eric Anholt
This is mostly just a move of the code from exynos, with a slight reformat. I wanted to do a similar thing for vc4, and msm looks like a good candidate as well. Signed-off-by: Eric Anholt --- drivers/gpu/drm/Makefile| 3 ++- drivers/gpu/drm/drm_platform_helpers.c | 45

Re: [PATCH] irqchip: bcm2835: Add FIQ support

2015-09-16 Thread Eric Anholt
Russell King - ARM Linux writes: > On Wed, Sep 16, 2015 at 10:02:32AM -0400, Eric Anholt wrote: >> Russell King - ARM Linux writes: >> >> > On Mon, Sep 14, 2015 at 07:33:09AM -0700, Eric Anholt wrote: >> >> So, while FIQ isn't used in upstream, I th

[PATCH v6] clk: bcm2835: Add support for programming the audio domain clocks.

2015-10-08 Thread Eric Anholt
e() results would be incorrect, but that's no worse than our current state where we used fixed clocks. The existing fixed clocks in the code are left in place to provide backwards compatibility with old device tree files. Signed-off-by: Eric Anholt Tested-by: Martin Sperl --- v2: Fix o

Re: [PATCH v5] clk: bcm2835: Add support for programming the audio domain clocks.

2015-10-08 Thread Eric Anholt
Stephen Boyd writes: > On 10/06, Eric Anholt wrote: >> diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c >> index dd295e4..b4d4421 100644 >> --- a/drivers/clk/bcm/clk-bcm2835.c >> +++ b/drivers/clk/bcm/clk-bcm2835.c >> @@ -17,10 +17,

Re: [PATCH v6] clk: bcm2835: Add support for programming the audio domain clocks.

2015-10-08 Thread Eric Anholt
Stephen Boyd writes: > Please drop the full-stop from your subject lines. > > On 10/08, Eric Anholt wrote: >> This adds support for enabling, disabling, and setting the rate of the >> audio domain clocks. It will be necessary for setting the pixel clock >> for HDMI i

[PATCH v7] clk: bcm2835: Add support for programming the audio domain clocks

2015-10-08 Thread Eric Anholt
e() results would be incorrect, but that's no worse than our current state where we used fixed clocks. The existing fixed clocks in the code are left in place to provide backwards compatibility with old device tree files. Signed-off-by: Eric Anholt Tested-by: Martin Sperl --- v2: Fix o

[PATCH v3 2/7] MAINTAINERS: Add myself for the new VC4 (RPi GPU) graphics driver.

2015-10-09 Thread Eric Anholt
Signed-off-by: Eric Anholt --- v2: Mark it Supported, not Maintained. MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7ba7ab7..e331e46 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3653,6 +3653,12 @@ S: Maintained F: drivers/gpu

bcm2835 (Raspberry Pi) KMS driver

2015-10-09 Thread Eric Anholt
This is a respin of the Raspberry Pi KMS series. Now that we've got a real clock driver, I can actually set new video modes. Also in this version, most of the custom DT stuff from before is gone, thanks to finding exynos's platform_driver component matching code (I have sent separate patches to d

[PATCH v3 6/7] ARM: bcm2835: Add the DDC I2C controller to the device tree.

2015-10-09 Thread Eric Anholt
We need to use it for getting video modes over HDMI. Signed-off-by: Eric Anholt Acked-by: Stephen Warren --- v2: Mark it as disabled by default, and enable it in bcm2835-rpi. arch/arm/boot/dts/bcm2835-rpi.dtsi | 4 arch/arm/boot/dts/bcm2835.dtsi | 10 ++ 2 files changed, 14

[PATCH v3 3/7] drm/vc4: Add KMS support for Raspberry Pi.

2015-10-09 Thread Eric Anholt
This is enough for fbcon and bringing up X using xf86-video-modesetting. It doesn't support the 3D accelerator or power management yet. Signed-off-by: Eric Anholt Acked-by: Daniel Vetter --- v2: Drop FB_HELPER select thanks to Archit's patches. Do manual init ordering instea

[PATCH v3 7/7] ARM: bcm2835: Add VC4 to the device tree.

2015-10-09 Thread Eric Anholt
VC4 is the GPU (display and 3D) present on the 2835. Signed-off-by: Eric Anholt --- v2: Sort by register address, mark HDMI as disabled by default in the SoC file and enable it from -rpi. v3: Add references to the pixel/HSM clocks for HDMI. Rename compatibility strings and clean up

[PATCH v3 5/7] drm/vc4: Allow vblank to be disabled

2015-10-09 Thread Eric Anholt
From: Derek Foreman Signed-off-by: Derek Foreman Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_kms.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c index ee3e004..2e5597d 100644 --- a/drivers/gpu/drm/vc4/vc4_kms.c

[PATCH v3 1/7] drm/vc4: Add devicetree bindings for VC4.

2015-10-09 Thread Eric Anholt
VC4 is the GPU (display and 3D) subsystem present on the 2835 and some other Broadcom SoCs. This binding follows the model of msm, imx, sti, and others, where there is a subsystem node for the whole GPU, with nodes for the individual HW components within it. Signed-off-by: Eric Anholt --- v2

[PATCH v3 4/7] drm/vc4: Use the fbdev_cma helpers

2015-10-09 Thread Eric Anholt
From: Derek Foreman Keep the fbdev_cma pointer around so we can use it on hotplog and close to ensure the frame buffer console is in a useful state. Signed-off-by: Derek Foreman Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_drv.c | 14 ++ drivers/gpu/drm/vc4/vc4_drv.h

Re: [PATCH v3 2/7] MAINTAINERS: Add myself for the new VC4 (RPi GPU) graphics driver.

2015-10-09 Thread Eric Anholt
Emil Velikov writes: > Hi Eric, > > On 9 October 2015 at 22:27, Eric Anholt wrote: >> Signed-off-by: Eric Anholt >> --- >> >> v2: Mark it Supported, not Maintained. >> >> MAINTAINERS | 6 ++ >> 1 file changed, 6 insertions(+) >> &

Re: [PATCH 1/2] clk: bcm2835: Support for clock parent selection

2015-11-09 Thread Eric Anholt
Remi Pommarel writes: > Hi, > > On Wed, Nov 04, 2015 at 06:03:31PM -0800, Eric Anholt wrote: > > [...] > >> >> It looks like you've dropped the use of the divisor off of the PLL >> channel when setting a rate. That seems bad for all the other clocks in

Re: [PATCH -next] drm/vc4: Add dependency on HAVE_DMA_ATTRS, and select DRM_GEM_CMA_HELPER

2015-11-02 Thread Eric Anholt
drm_gem_cma_prime_vmap" [drivers/gpu/drm/vc4/vc4.ko] undefined! > ERROR: "drm_gem_cma_dumb_map_offset" [drivers/gpu/drm/vc4/vc4.ko] undefined! > ERROR: "drm_gem_cma_create" [drivers/gpu/drm/drm_kms_helper.ko] undefined! > ERROR: "drm_gem_cma_describe" [dr

Re: [PATCH] drm/msm: Check for powered down HW in the devfreq callbacks

2020-05-01 Thread Eric Anholt
On Fri, May 1, 2020 at 11:26 AM Jordan Crouse wrote: > > Writing to the devfreq sysfs nodes while the GPU is powered down can > result in a system crash (on a5xx) or a nasty GMU error (on a6xx): > > $ /sys/class/devfreq/500.gpu# echo 5 > min_freq > [ 104.841625] platform 506a000.gm

Re: [PATCH v2] drm/msm: Check for powered down HW in the devfreq callbacks

2020-05-01 Thread Eric Anholt
ck for the suspend state and blindly call into the devfreq > callbacks that end up triggering hardware reads in the GPU driver. > > Call pm_runtime_get_if_in_use() in the gpu_busy() and gpu_set_freq() > callbacks to skip the hardware access if it isn't active. > >

Re: [PATCH v5 0/3] drm/vc4: Add a load tracker

2019-02-20 Thread Eric Anholt
for avoiding underrun reports when reconfiguring the > pipeline. It is now based on detection instead of delaying the underrun > interrupt unmasking. > > It can be tested with a dedicated IGT GPU Tools series: > VC4 load tracker testing Series is: Reviewed-by: Eric Anholt Thanks for

[PATCH v2 2/2] soc: bcm: bcm2835-pm: Fix error paths of initialization.

2019-02-20 Thread Eric Anholt
;clk when no clk is present in the DT. Signed-off-by: Eric Anholt Fixes: 670c672608a1 ("soc: bcm: bcm2835-pm: Add support for power domains under a new binding.") --- drivers/soc/bcm/bcm2835-power.c | 35 - 1 file changed, 30 insertions(+), 5 deletions(-)

Re: [PATCH 2/2] soc: bcm: bcm2835-pm: Fix error paths of initialization.

2019-02-20 Thread Eric Anholt
Florian Fainelli writes: > On 2/13/19 2:33 PM, Stefan Wahren wrote: >> >>> Eric Anholt hat am 13. Februar 2019 um 19:28 geschrieben: >>> >>> >>> Stefan Wahren writes: >>> >>>> Hi Eric, >>>> >>>> Am 13

[PATCH v2 1/2] soc: bcm: bcm2835-pm: Fix PM_IMAGE_PERI power domain support.

2019-02-20 Thread Eric Anholt
We don't have ASB master/slave regs for this domain, so just skip that step. Signed-off-by: Eric Anholt Fixes: 670c672608a1 ("soc: bcm: bcm2835-pm: Add support for power domains under a new binding.") --- drivers/soc/bcm/bcm2835-power.c | 14 -- 1 file changed, 12 i

[PATCH 4/7] drm/vc4: Use drm_printer for the debugfs and runtime bo stats output.

2019-02-20 Thread Eric Anholt
Now I can extend the stats without more copy and pasting between the two. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_bo.c | 48 +++- 1 file changed, 14 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4

[PATCH 1/7] drm: Add a helper function for printing a debugfs_regset32.

2019-02-20 Thread Eric Anholt
The debugfs_regset32 is nice to use for reducing boilerplate in dumping a bunch of regs in debugfs, but we also want to be able to print to dmesg them at runtime for driver debugging. drm_printer lets us format debugfs and the printk the same way. Signed-off-by: Eric Anholt --- drivers/gpu/drm

[PATCH 2/7] drm/vc4: Use drm_print_regset32() for our debug register dumping.

2019-02-20 Thread Eric Anholt
This removes a bunch of duplicated boilerplate for the debugfs vs runtime printk debug dumping. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_crtc.c | 68 ++--- drivers/gpu/drm/vc4/vc4_dpi.c | 23 ++--- drivers/gpu/drm/vc4/vc4_drv.h | 7 ++ drivers/gpu/drm/vc4/vc4_dsi.c

[PATCH 5/7] drm/vc4: Disable V3D interactions if the v3d component didn't probe.

2019-02-20 Thread Eric Anholt
One might want to use the VC4 display stack without using Mesa. Similar to the debugfs fixes for not having all of the possible display bits enabled, make sure you can't oops in vc4 if v3d isn't enabled. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_drv.c | 11 ++

<    1   2   3   4   5   6   7   8   9   10   >