[PATCH v2 1/3] clk: bcm2835: Don't rate change PLLs on behalf of DSI PLL dividers.

2017-01-17 Thread Eric Anholt
. We *do* want PLLH to change so that PLLH_AUX can be exactly the value we want, though. Thus, we need to have a per-divider policy of whether to pass rate changes up. Signed-off-by: Eric Anholt --- drivers/clk/bcm/clk-bcm2835.c | 42 -- 1 file changed, 28

[PATCH v2 3/3] clk: bcm2835: Add leaf clock measurement support, disabled by default

2017-01-17 Thread Eric Anholt
This proved incredibly useful during debugging of the DSI driver, to see if our clocks were running at rate we requested. Let's leave it here for the next person interacting with clocks on the platform (and so that hopefully we can just hook it up to debugfs some day). Signed-off-by: Eric A

Re: [PATCH 05/62] watchdog: bcm2835_wdt: Convert to use device managed functions and other improvements

2017-01-13 Thread Eric Anholt
own function with call to watchdog_stop_on_reboot() I'm trusting you here that this last change is right. All the rest of it looks good: Acked-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH 6/6] staging: bcm2835-v4l2: Apply spelling fixes from checkpatch.

2017-01-30 Thread Eric Anholt
Joe Perches writes: > On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote: >> Generated with checkpatch.pl --fix-inplace and git add -p out of the >> results. > > Maybe another. > >> diff --git a/drivers/staging/media/platform/bcm2835/mmal-vchiq.c >> b/dr

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-31 Thread Eric Anholt
Thierry Reding writes: > [ Unknown signature status ] > On Tue, Jan 31, 2017 at 09:38:53AM -0500, Sean Paul wrote: >> On Tue, Jan 31, 2017 at 09:54:49AM +0100, Thierry Reding wrote: >> > On Tue, Jan 31, 2017 at 09:01:07AM +0900, Inki Dae wrote: >> > > >> > > >> > > 2017년 01월 24일 10:50에 Hoegeun

Re: [PATCH 6/6] staging: bcm2835-v4l2: Apply spelling fixes from checkpatch.

2017-01-31 Thread Eric Anholt
Joe Perches writes: > On Mon, 2017-01-30 at 12:05 -0800, Eric Anholt wrote: >> Joe Perches writes: >> >> > On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote: >> > > Generated with checkpatch.pl --fix-inplace and git add -p out of the >

Re: [PATCH 1/4] dt-bindings: Add binding for brcm,bcm2835-sdhost.

2017-01-31 Thread Eric Anholt
Stefan Wahren writes: >> Gerd Hoffmann hat am 27. Januar 2017 um 12:36 >> geschrieben: >> >> >> From: Eric Anholt >> >> This is the other SD controller on the platform, which can be swapped >> to the role of SD card host using pin muxin

[GIT PULL] bcm2835-dt-next-2017-01-31

2017-01-31 Thread Eric Anholt
ARM: dts: bcm283x: Enable the VEC IP on all RaspberryPi boards Eric Anholt (5): clk: bcm2835: Don't rate change PLLs on behalf of DSI PLL dividers. clk: bcm2835: Register the DSI0/DSI1 pixel clocks. clk: bcm2835: Add leaf clock measurement support, disabled by default

[PATCH 2/2 v2] drm/vc4: Add DSI driver

2017-01-31 Thread Eric Anholt
st, but it does put a lot of the register definitions and code in place. v2: Use the clk_hw interfaces, don't set CLK_IS_BASIC (from review by Stephen Boyd) Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/Kconfig |2 + drivers/gpu/drm/vc4/Makefile |1 + driv

[PATCH 2/2 v2] drm/vc4: Add DSI driver

2017-01-31 Thread Eric Anholt
st, but it does put a lot of the register definitions and code in place. v2: Use the clk_hw interfaces, don't set CLK_IS_BASIC (from review by Stephen Boyd) Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/Kconfig |2 + drivers/gpu/drm/vc4/Makefile |1 + driv

[PATCH] MAINTAINERS: Update for the current location of the bcm2835 tree.

2017-01-31 Thread Eric Anholt
I've been maintaining the bcm2835 branches here for a year or so. Signed-off-by: Eric Anholt --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 844835563ef8..64b281a7ff09 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2

Re: [PATCH 05/11] drm/vc4: Add support for feeding DSI encoders from the pixel valve.

2017-01-31 Thread Eric Anholt
Daniel Vetter writes: > On Wed, Dec 14, 2016 at 11:46:15AM -0800, Eric Anholt wrote: >> We have to set a different pixel format, which tells the hardware to >> use the pix_width field that's fed in sideband from the DSI encoder to >> divide the "pixel" cloc

Re: [RESENT PATCH] ARM: bcm2835: Add devicetree for the Raspberry Pi 3, for arm (32)

2017-01-31 Thread Eric Anholt
Eric Anholt writes: > [ Unknown signature status ] > Gerd Hoffmann writes: > >> Signed-off-by: Gerd Hoffmann >> --- >> arch/arm/boot/dts/Makefile | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/M

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-31 Thread Eric Anholt
Thierry Reding writes: > [ Unknown signature status ] > On Tue, Jan 31, 2017 at 10:15:10AM -0800, Eric Anholt wrote: >> Thierry Reding writes: >> >> > [ Unknown signature status ] >> > On Tue, Jan 31, 2017 at 09:38:53AM -0500, Sean Paul wrote: >> &

[GIT PULL] drm-vc4-fixes-2017-01-23 for 4.10

2017-01-23 Thread Eric Anholt
:01 +1100) This pull request brings in a few little error checking fixes and one slow memory leak fix. Dan Carpenter (1): drm/vc4: fix a bounds check Eric Anholt

[PATCH 2/2] drm/vc4: Add DSI driver

2017-01-23 Thread Eric Anholt
st, but it does put a lot of the register definitions and code in place. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/Kconfig |2 + drivers/gpu/drm/vc4/Makefile |1 + drivers/gpu/drm/vc4/vc4_debugfs.c |1 + drivers/gpu/drm/vc4/vc4_drv.c |1 + drivers/gpu/drm/vc4

[PATCH 0/2] drm/vc4: DSI display output support

2017-01-23 Thread Eric Anholt
This is a resend from a month ago of just two of the patches (several are accepted at this point) from the DSI series, hoping to collect an ack from DT. Ccing the clock folks as well, since this ends up being a clock provider. Eric Anholt (2): dt-bindings: Document the VC4 DSI module nodes

[PATCH 1/2] dt-bindings: Document the VC4 DSI module nodes.

2017-01-23 Thread Eric Anholt
These are part of the vc4 display pipeline. Signed-off-by: Eric Anholt --- .../devicetree/bindings/display/brcm,bcm-vc4.txt | 35 ++ 1 file changed, 35 insertions(+) diff --git a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt b/Documentation/devicetree

Re: [RESENT PATCH] ARM: bcm2835: Add devicetree for the Raspberry Pi 3, for arm (32)

2017-01-21 Thread Eric Anholt
./../arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dtb > dtb-$(CONFIG_ARCH_BCM_5301X) += \ > bcm4708-asus-rt-ac56u.dtb \ > bcm4708-asus-rt-ac68u.dtb \ This would be really nice to have. Acked-by: Eric Anholt ARM upstream folks, do you have any issues with this? signature.asc Description: PGP signature

[PATCH 6/6] staging: bcm2835-v4l2: Apply spelling fixes from checkpatch.

2017-01-27 Thread Eric Anholt
Generated with checkpatch.pl --fix-inplace and git add -p out of the results. Signed-off-by: Eric Anholt --- drivers/staging/media/platform/bcm2835/bcm2835-camera.c | 6 +++--- drivers/staging/media/platform/bcm2835/mmal-vchiq.c | 12 ++-- 2 files changed, 9 insertions(+), 9

[PATCH 2/6] staging: bcm2835-v4l2: Update the driver to the current VCHI API.

2017-01-27 Thread Eric Anholt
49bec49fd7f2 ("staging: vc04_services: remove vchiq_copy_from_user") removed the flags/msg_handle arguments, which were unused, and pushed the implementation of copying using memcpy vs copy_from_user to the caller. Signed-off-by: Eric Anholt --- drivers/staging/media/platform/bc

[PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-01-27 Thread Eric Anholt
he driver to the current VCHI API" patch will conflict with the outstanding "Add vchi_queue_kernel_message and vchi_queue_user_message" series, but the fix should be pretty obvious when that lands. I built this against 4.10-rc1, but a merge with staging-next was clean and still built fine

[PATCH 4/6] staging: bcm2835-v4l2: Add a TODO file for improvements we need.

2017-01-27 Thread Eric Anholt
Signed-off-by: Eric Anholt --- drivers/staging/media/platform/bcm2835/TODO | 39 + 1 file changed, 39 insertions(+) create mode 100644 drivers/staging/media/platform/bcm2835/TODO diff --git a/drivers/staging/media/platform/bcm2835/TODO b/drivers/staging/media

[PATCH 3/6] staging: bcm2835-v4l2: Add a build system for the module.

2017-01-27 Thread Eric Anholt
This is derived from the downstream tree's build system, but with just a single Kconfig option. For now the driver only builds on 32-bit arm -- the aarch64 build breaks due to the driver using arm-specific cache flushing functions. Signed-off-by: Eric Anholt --- drivers/staging/media/Kc

[PATCH 5/6] staging: bcm2835-v4l2: Apply many whitespace fixes from checkpatch.

2017-01-27 Thread Eric Anholt
: Eric Anholt --- .../media/platform/bcm2835/bcm2835-camera.c| 90 drivers/staging/media/platform/bcm2835/controls.c | 236 ++--- .../staging/media/platform/bcm2835/mmal-vchiq.c| 13 +- 3 files changed, 167 insertions(+), 172 deletions(-) diff --git a

Re: [PATCH 1/2] dt-bindings: Document the VC4 DSI module nodes.

2017-01-27 Thread Eric Anholt
Rob Herring writes: > Need to cc DT list if you want it in my queue. > > On Mon, Jan 23, 2017 at 6:38 PM, Eric Anholt wrote: >> These are part of the vc4 display pipeline. >> >> Signed-off-by: Eric Anholt >> --- >> .../devicetree/b

Re: [PATCH 2/3] watchdog: bcm2835_wdt: remove redundant ->set_timeout callback

2016-07-15 Thread Eric Anholt
Rasmus Villemoes writes: > bcm2835_wdt_set_timeout does exactly what the watchdog framework does > in the absence of a ->set_timeout callback (see watchdog_set_timeout > in watchdog_dev.c), so remove it. These first two patches are: Acked-by: Eric Anholt signature.asc Desc

Re: [PATCH 3/7] drm/vc4: Add a bitmap of branch targets during shader validation.

2016-07-15 Thread Eric Anholt
Eric Anholt writes: > This isn't used yet, it's just a first step toward loop validation. > During the main parsing of instructions, we need to know when we hit a > new basic block so that we can reset validated state. > > Signed-off-by: Eric Anholt >

[GIT PULL] drm-vc4-next-2016-07-15 (loops)

2016-07-15 Thread Eric Anholt
s in vc4 shader validation for branching, allowing GLSL shaders with non-unrolled loops. -------- Eric Anholt (7): drm/vc4: Add a getparam ioctl for getting the V3D identity regs. drm/vc4: Move validation's current/max ip into t

Re: [PATCH 27/32] gpio: Add support for the FXL6408 GPIO expander.

2016-06-09 Thread Eric Anholt
Linus Walleij writes: > On Wed, Jun 1, 2016 at 11:43 PM, Gerd Hoffmann wrote: > >> +#define FXL6408_OUTPUT 0x05 >> +/* Bits here make the output High-Z, instead of the OUTPUT value. */ >> +#define FXL6408_OUTPUT_HIGH_Z 0x07 > (...) >> + /* Disable High-Z of outputs

Re: [PATCH v2 1/9] pinctrl: walk into bcm subdir unconditionally

2016-06-09 Thread Eric Anholt
;s ACK? It looks like this is the only instance of filtering the directory on CONFIG_ARCH_BCM, so regardless of the patch 4 resolution, Acked-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH v2 4/9] arm64: Add platform selection for BCM2835.

2016-06-09 Thread Eric Anholt
Catalin Marinas writes: > On Sat, Jun 04, 2016 at 12:55:15PM -0700, Eric Anholt wrote: >> Catalin Marinas writes: >> > On Fri, Jun 03, 2016 at 08:18:23AM +0200, Gerd Hoffmann wrote: >> >> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platform

Re: [PATCH 1/2] soc: raspberrypi-power: add CONFIG_OF dependency

2016-07-06 Thread Eric Anholt
t; There is no need to select PM_GENERIC_DOMAINS_OF if OF is set, so we can > replace the 'select' with a dependency. > > Signed-off-by: Arnd Bergmann Acked-by: Eric Anholt I'm guessing you'll take this patch directly. signature.asc Description: PGP signature

Re: [PATCH 7/7] gpu: drm: vc4_hdmi: add missing of_node_put after calling of_parse_phandle

2016-07-07 Thread Eric Anholt
Peter Chen writes: > of_node_put needs to be called when the device node which is got > from of_parse_phandle has finished using. > > Cc: Eric Anholt > Signed-off-by: Peter Chen Applied this to drm-vc4-next. Thanks! signature.asc Description: PGP signature

Re: [PATCH v2 1/9] pinctrl: walk into bcm subdir unconditionally

2016-06-14 Thread Eric Anholt
Linus Walleij writes: > On Fri, Jun 3, 2016 at 8:18 AM, Gerd Hoffmann wrote: > >> There is no ARCH_BCM on arm64, and we need pinctrl-bcm2835 for the rpi3. >> >> Signed-off-by: Gerd Hoffmann > > I see I got an identical patch from Florian Fainelli and applied it. > Sorry for my clashes, confusio

Re: [PATCH v2 4/9] arm64: Add platform selection for BCM2835.

2016-06-14 Thread Eric Anholt
Catalin Marinas writes: > On Thu, Jun 09, 2016 at 05:21:35PM -0700, Eric Anholt wrote: >> Catalin Marinas writes: >> > On Sat, Jun 04, 2016 at 12:55:15PM -0700, Eric Anholt wrote: >> >> Catalin Marinas writes: >> >> > On Fri, Jun 03,

Re: [PATCH v2 4/9] arm64: Add platform selection for BCM2835.

2016-06-15 Thread Eric Anholt
Catalin Marinas writes: > On Tue, Jun 14, 2016 at 11:48:54PM -0700, Eric Anholt wrote: >> Catalin Marinas writes: >> >> > On Thu, Jun 09, 2016 at 05:21:35PM -0700, Eric Anholt wrote: >> >> Catalin Marinas writes: >> >> > On Sat,

[PATCH 1/7 v3] drm/vc4: Add a getparam ioctl for getting the V3D identity regs.

2016-07-14 Thread Eric Anholt
Clark in review) Signed-off-by: Eric Anholt Acked-by: Daniel Vetter (v2) Reviewed-by: Rob Clark (v3, over irc) --- drivers/gpu/drm/vc4/vc4_drv.c | 42 ++ include/uapi/drm/vc4_drm.h| 12 2 files changed, 54 insertions(+) diff --git a/dr

[PATCH 6/6] drm/vc4: Fix oops when userspace hands in a bad BO.

2016-07-26 Thread Eric Anholt
We'd end up NULL pointer dereferencing because we didn't take the error path out in the parent. Fixes igt vc4_lookup_fail test. Signed-off-by: Eric Anholt Fixes: d5b1a78a772f ("drm/vc4: Add support for drawing 3D frames.") Cc: sta...@vger.kernel.org --- drivers/gpu/drm/vc4

[PATCH 5/6] drm/vc4: Fix overflow mem unreferencing when the binner runs dry.

2016-07-26 Thread Eric Anholt
x27;s currently running in the binner", but since the bin/render submission split, we may end up with the binner completing and having no new job while the renderer is still processing. So, if we don't find a bin job at all, look at the highest-seqno (last) render job to attach our overflow

[PATCH 2/6] drm/vc4: Use drm_malloc_ab to fix large rendering jobs.

2016-07-26 Thread Eric Anholt
If you exceeded the size that kmalloc would return, you'd get a dmesg warning and an error from the job submit. We can handle much larger allocations with vmalloc, and drm_malloc_ab makes that decision. Fixes failure in piglit's scissor-many. Signed-off-by: Eric Anholt --- drivers/g

[PATCH 3/6] drm/vc4: Fix handling of a pm_runtime_get_sync() success case.

2016-07-26 Thread Eric Anholt
If the device was already up, a 1 is returned instead of 0. We were erroring out, leading the 3D driver to sometimes fail at screen initialization (generally with ENOENT returned to it). Signed-off-by: Eric Anholt Fixes: af713795c59f ("drm/vc4: Add a getparam ioctl for getting the V3D ide

[PATCH 0/6] vc4 miscellaneous v3d fixes

2016-07-26 Thread Eric Anholt
Here are a bunch of miscellaneous fixes for 3D I've come up with while doing a bunch of piglit runs. One has a new IGT test sent out, and I've got a test almost ready for large CLs. Eric Anholt (6): drm/vc4: Use drm_free_large() on handles to match its allocation. drm/vc4: Use drm

[PATCH 1/6] drm/vc4: Use drm_free_large() on handles to match its allocation.

2016-07-26 Thread Eric Anholt
If you managed to exceed the limit to switch to vmalloc, we'd use the wrong free. Signed-off-by: Eric Anholt Fixes: d5b1a78a772f ("drm/vc4: Add support for drawing 3D frames.") Cc: sta...@vger.kernel.org --- drivers/gpu/drm/vc4/vc4_gem.c | 2 +- 1 file changed, 1 insertion

[PATCH 4/6] drm/vc4: Free hang state before destroying BO cache.

2016-07-26 Thread Eric Anholt
The BO cache will complain if BOs are still allocated when we try to destroy it (since freeing those BOs would try to hit the cache). You could hit this if you were to unload the module after a GPU hang. Signed-off-by: Eric Anholt Fixes: 214613656b51 ("drm/vc4: Add an interface for capt

Re: [PATCH 5/6] drm/vc4: Fix overflow mem unreferencing when the binner runs dry.

2016-07-26 Thread Eric Anholt
Rob Clark writes: > On Tue, Jul 26, 2016 at 4:47 PM, Eric Anholt wrote: >> Overflow memory handling is tricky: While it's still referenced by the >> BPO registers, we want to keep it from being freed. When we are >> putting a new set of overflow memory in the regis

Re: [PATCH 5/6] drm/vc4: Fix overflow mem unreferencing when the binner runs dry.

2016-07-26 Thread Eric Anholt
Rob Clark writes: > On Tue, Jul 26, 2016 at 7:11 PM, Eric Anholt wrote: >> Rob Clark writes: >> >>> On Tue, Jul 26, 2016 at 4:47 PM, Eric Anholt wrote: >>>> Overflow memory handling is tricky: While it's still referenced by the >>>> BPO reg

[GIT PULL 0/3] BCM2835 pull requests for 4.8

2016-07-03 Thread Eric Anholt
It looks like we didn't get an updated defconfig patch while I was gone, so I'm sending my pull requests for Pi3 and ethernet in the DT now (the same stuff that's been in -next the whole time). I think it's still worth it to have Pi3 present in 4.8, even if we don't have the defconfig in place yet

[GIT PULL 3/3] bcm2835-arm64-next-2016-07-03

2016-07-03 Thread Eric Anholt
-0700) This pull request brings in the build support for the Raspberry Pi arm64 port. Alexander Graf (1): arm64: Allow for different DMA and CPU bus offsets Eric

[GIT PULL 1/3] bcm2835-dt-next-2016-07-03

2016-07-03 Thread Eric Anholt
Linux 4.7-rc1 (2016-05-29 09:29:24 -0700) are available in the git repository at: https://github.com/anholt/linux tags/bcm2835-dt-next-2016-07-03 for you to fetch changes up to 6a93792774fc72861b7e8efaa3545a88272b4413: ARM: bcm2835: dt: Add the ethernet to the device trees (2016-05-31 10:

[GIT PULL 2/3] bcm2835-dt-64-next-2016-07-03

2016-07-03 Thread Eric Anholt
dress. Eric Anholt (3): dt-bindings: Add root properties for Raspberry Pi 3 ARM: bcm2835: Add devicetree for the Raspberry Pi 3. Merge tag 'bcm2835-dt-ethernet' into HEAD Gerd Hoffmann (1): ARM: bcm2837: dt: Add the ethernet to t

Re: [PATCH] i2c: bcm2835: Set up the clock stretching timeout at boot.

2016-07-03 Thread Eric Anholt
Wolfram Sang writes: >> +/* >> + * SMBUS says "Devices participating in a transfer will >> + * timeout when any clock low exceeds the value of >> + * T_TIMEOUT,MIN of 25 ms." >> + */ > > SMBus has that timeout, but I2C doesn't. How about disabling the timeout > simply? Or usin

[PATCH 6/7] drm/vc4: Fix definition of QPU_R_MS_REV_FLAGS

2016-07-04 Thread Eric Anholt
We don't use it in shader validation currently, so it had no effect, but best to fix it anyway in case we do some day. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_qpu_defines.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_qpu_defi

[PATCH 2/7] drm/vc4: Move validation's current/max ip into the validation struct.

2016-07-04 Thread Eric Anholt
Reduces the argument count for some of the functions, and will be used more with the upcoming looping support. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_validate_shaders.c | 54 +- 1 file changed, 30 insertions(+), 24 deletions(-) diff --git a/drivers

[PATCH 7/7] drm/vc4: Fix a "the the" typo in a comment.

2016-07-04 Thread Eric Anholt
Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_validate_shaders.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_validate_shaders.c b/drivers/gpu/drm/vc4/vc4_validate_shaders.c index 302ce68e24cd..d126145c60ca 100644 --- a/drivers/gpu/drm/vc4

[PATCH 3/7] drm/vc4: Add a bitmap of branch targets during shader validation.

2016-07-04 Thread Eric Anholt
This isn't used yet, it's just a first step toward loop validation. During the main parsing of instructions, we need to know when we hit a new basic block so that we can reset validated state. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_qpu_defines.h | 12 +++ drive

[PATCH 0/7] drm/vc4: loops and getparam support.

2016-07-04 Thread Eric Anholt
ps and I'll try to get an identity getparam patch sent out tomorrow. Eric Anholt (7): drm/vc4: Add a getparam ioctl for getting the V3D identity regs. drm/vc4: Move validation's current/max ip into the validation struct. drm/vc4: Add a bitmap of branch targets during shader validatio

[PATCH 5/7] drm/vc4: Add a getparam to signal support for branches.

2016-07-04 Thread Eric Anholt
Userspace needs to know if it can create shaders that do branching. Otherwise, for backwards compatibility with old kernels it needs to lower if statements to conditional assignments. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_drv.c | 3 +++ include/uapi/drm/vc4_drm.h| 1 + 2

[PATCH 4/7] drm/vc4: Add support for branching in shader validation.

2016-07-04 Thread Eric Anholt
nd at draw call time fix up the uniform stream to have the address of the start of the shader's uniforms at that location. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_drv.h | 3 + drivers/gpu/drm/vc4/vc4_qpu_defines.h | 3 + drivers/gpu/drm/vc4/vc4_validate.

[PATCH 1/7] drm/vc4: Add a getparam ioctl for getting the V3D identity regs.

2016-07-04 Thread Eric Anholt
As I extend the driver to support different V3D revisions, userspace needs to know what version it's targeting. This is most easily detected using the V3D identity registers. Signed-off-by: Eric Anholt --- drivers/gpu/drm/vc4/vc4_drv.c | 25 + include/uapi/drm/vc4_

Re: [PATCH 7/7] gpu: drm: vc4_hdmi: add missing of_node_put after calling of_parse_phandle

2016-07-05 Thread Eric Anholt
Peter Chen writes: > of_node_put needs to be called when the device node which is got > from of_parse_phandle has finished using. > > Cc: Eric Anholt > Signed-off-by: Peter Chen > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 13 +++-- > 1 file changed, 7 in

[PATCH v3 0/4] clk: bcm2835: critical clocks and parent selection

2016-06-01 Thread Eric Anholt
fixes are all suitable for 4.7. Eric Anholt (4): clk: bcm2835: Mark the VPU clock as critical clk: bcm2835: Mark GPIO clocks enabled at boot as critical clk: bcm2835: Mark the CM SDRAM clock's parent as critical clk: bcm2835: Skip PLLC clocks when deciding on a new clock parent driv

[PATCH v3 2/4] clk: bcm2835: Mark GPIO clocks enabled at boot as critical

2016-06-01 Thread Eric Anholt
x27;s refcount going to 0. Signed-off-by: Eric Anholt --- v3: Only mark critical if it's on at boot. drivers/clk/bcm/clk-bcm2835.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c index d9db03cb3fd8..40

[PATCH v3 1/4] clk: bcm2835: Mark the VPU clock as critical

2016-06-01 Thread Eric Anholt
The VPU clock is also the clock for our AXI bus, so we really can't disable it. This might have happened during boot if, for example, uart1 (aux_uart clock) probed and was then disabled before the other consumers of the VPU clock had probed. Signed-off-by: Eric Anholt --- v2: Rewrite to

[PATCH v3 3/4] clk: bcm2835: Mark the CM SDRAM clock's parent as critical

2016-06-01 Thread Eric Anholt
choose SDRAM's parent for some other clock, then disable that clock. Signed-off-by: Eric Anholt --- drivers/clk/bcm/clk-bcm2835.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c index 400615b

[PATCH v3 4/4] clk: bcm2835: Skip PLLC clocks when deciding on a new clock parent

2016-06-01 Thread Eric Anholt
ication to Linux. On my system, this moves the Linux-enabled HDMI state machine and DSI1 escape clock over to plld_per from pllc_per. EMMC still ends up on pllc_per, because the firmware had set it up to use that. Signed-off-by: Eric Anholt Fixes: 41691b8862e2 ("clk: bcm2835: Add support for

[PATCH] drm/panel: Remove the get_timings() function.

2016-06-01 Thread Eric Anholt
It appears to have no callers. Signed-off-by: Eric Anholt --- drivers/gpu/drm/panel/panel-simple.c | 18 -- include/drm/drm_panel.h | 4 2 files changed, 22 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c

[PATCH] i2c: bcm2835: Set up the clock stretching timeout at boot.

2016-06-01 Thread Eric Anholt
ff-by: Eric Anholt --- drivers/i2c/busses/i2c-bcm2835.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c index 818b051d25e6..1348f224013d 100644 --- a/drivers/i2c/busses/i2c-bcm2835.c +++ b/drivers/i2c/busse

Re: [PATCH 09/32] bcm2837-rpi-3-b.dts for 32bit arm

2016-06-01 Thread Eric Anholt
Arnd Bergmann writes: > On Wednesday, June 1, 2016 11:43:18 PM CEST Gerd Hoffmann wrote: >> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts >> b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts >> new file mode 100644 >> index 000..36178a6 >> --- /dev/null >> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.

[PATCH] drm/vc4: Fix ioctl permissions for render nodes.

2016-06-01 Thread Eric Anholt
-by: Herve Jourdain Signed-off-by: Eric Anholt Fixes: 0cd3e2747662 ("drm/vc4: Add missing render node support") --- drivers/gpu/drm/vc4/vc4_drv.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.

Re: [PATCH] i2c: bcm2835: Set up the clock stretching timeout at boot.

2016-06-02 Thread Eric Anholt
Stefan Wahren writes: > Hi Eric, > > Am 02.06.2016 um 00:07 schrieb Eric Anholt: >> The register at poweron contains 0x40, which at our typical 100khz bus >> rate means .64ms instead of the desired 25ms. >> >> Fixes many clock stretching timeouts when talking

Re: [PATCH 03/32] irqchip: bcm2835: Avoid arch/arm-specific handle_IRQ.

2016-06-02 Thread Eric Anholt
Jason Cooper writes: > Hey Gerd, > > On Wed, Jun 01, 2016 at 11:43:12PM +0200, Gerd Hoffmann wrote: >> From: Eric Anholt >> >> This is equivalent and works for arm64 as well. >> >> Signed-off-by: Eric Anholt >> --- > > I don't min

Re: [PATCH 21/32] mmc: bcm2835-sdhost: Add new driver for the internal SD controller.

2016-06-02 Thread Eric Anholt
Arnd Bergmann writes: > On Wednesday, June 1, 2016 11:43:30 PM CEST Gerd Hoffmann wrote: >> +/* Parse OF address directly to get the physical address for >> + * DMA to our registers. >> + */ >> +host->phys_addr = be32_to_cpup(of_get_address(pdev->dev.of_node, 0, >> +

Re: [PATCH 32/32] mmc: bcm2835: Import bcm2835-mmc and switch to it

2016-06-02 Thread Eric Anholt
Stefan Wahren writes: > Hi Gerd, > > Am 01.06.2016 um 23:43 schrieb Gerd Hoffmann: >> From: Eric Anholt >> >> With this we can get wifi (brcmfmac) to probe. Without it we're stuck >> with timeouts from sdio.c when it tries to set the bus width to 4. >

Re: [PATCH 04/34] clk: bcm2835: Migrate to clk_hw based registration and OF APIs

2016-06-02 Thread Eric Anholt
Stephen Boyd writes: > Now that we have clk_hw based provider APIs to register clks, we > can get rid of struct clk pointers while registering clks in > these drivers, allowing us to move closer to a clear split of > consumer and provider clk APIs. This looks good, but it'll conflict with the fi

Re: [PATCH 10/32] don't force serial pins to uart0

2016-06-02 Thread Eric Anholt
Arnd Bergmann writes: > On Wednesday, June 1, 2016 11:43:19 PM CEST Gerd Hoffmann wrote: >> From: Eric Anholt >> >> --- >> > > No signoff or description? This commit should not have been sent out as is. Gerd took a bunch of messy commits from my trees that

Re: [PATCH 32/32] mmc: bcm2835: Import bcm2835-mmc and switch to it

2016-06-02 Thread Eric Anholt
Stefan Wahren writes: > Hi Eric, > >> Eric Anholt hat am 2. Juni 2016 um 20:18 geschrieben: >> >> >> Stefan Wahren writes: >> >> > Hi Gerd, >> > >> > Am 01.06.2016 um 23:43 schrieb Gerd Hoffmann: >> >> From: Eric Anh

[PATCH v2 RESEND] irqchip: bcm2835: Avoid arch/arm-specific handle_IRQ

2016-05-31 Thread Eric Anholt
This is equivalent and works for arm64 as well. Signed-off-by: Eric Anholt Acked-by: Stephen Warren --- Patch 1 of the arm64 series was left out of the 4.7 pull request. Would it be possible to merge this through the SOC tree? Otherwise I would need a stable branch to merge from you, so that

Re: [PATCH v2] staging: vc04_services: Replace dmac_map_area with dmac_map_sg

2016-10-26 Thread Eric Anholt
; vchiq_test -b 512 1 4372us/iter 4616us/iter 4123us Reviewed-by: Eric Anholt Nice work! More portability and better performance at the same time. A possible future improvement would be to track the pagelist, num_pages, and pagelist_size in a struct in the bulk->remote_d

[PATCH] irq-bcm2836: Prevent spurious interrupts, and trap them early

2016-10-27 Thread Eric Anholt
reasons, though, so trap them early. Signed-off-by: Phil Elwell Signed-off-by: Eric Anholt --- Phil, your patch didn't apply because it looks like you pasted into gmail (tabs got converted to spaces). git-send-email can avoid that. I've pulled it out of the rpi tree and applied the

[PATCH] irq-bcm2836: Prevent spurious interrupts, and trap them early

2016-10-27 Thread Eric Anholt
reasons, though, so trap them early. Signed-off-by: Phil Elwell Signed-off-by: Eric Anholt --- Phil, your patch didn't apply because it looks like you pasted into gmail (tabs got converted to spaces). git-send-email can avoid that. I've pulled it out of the rpi tree and applied the

[PATCH v3] ARM: bcm2835: Add names for the Raspberry Pi GPIO lines

2016-10-27 Thread Eric Anholt
ckets for "is pinmuxed", which didn't seem to clarify, and were ambiguous for things like the SPI_*-labeled pins which may or may not actually be pinmuxed to SPI. Signed-off-by: Linus Walleij Signed-off-by: Eric Anholt --- arch/arm/boot/dts/bcm2835-rpi-a-plus.dts | 65 +

[PATCH v2] irqchip/bcm2836: Prevent spurious interrupts

2016-10-27 Thread Eric Anholt
From: Phil Elwell The old arch-specific IRQ macros included a dsb to ensure the write to clear the mailbox interrupt completed before returning from the interrupt. The BCM2836 irqchip driver needs the same precaution to avoid spurious interrupts. Signed-off-by: Phil Elwell Signed-off-by: Eric

Re: [PATCH] irq-bcm2836: Prevent spurious interrupts, and trap them early

2016-10-27 Thread Eric Anholt
Eric Anholt writes: > From: Phil Elwell > > The old arch-specific IRQ macros included a dsb to ensure the > write to clear the mailbox interrupt completed before returning > from the interrupt. The BCM2836 irqchip driver needs the same > precaution to avoid spurious interr

Re: [PATCH v2] irqchip/bcm2836: Prevent spurious interrupts

2016-10-28 Thread Eric Anholt
Thomas Gleixner writes: > On Thu, 27 Oct 2016, Eric Anholt wrote: > >> From: Phil Elwell >> >> The old arch-specific IRQ macros included a dsb to ensure the >> write to clear the mailbox interrupt completed before returning >> from the interrupt. The B

Re: [PATCH v2] staging: vc04_services: setup DMA and coherent mask

2016-11-07 Thread Eric Anholt
Michael Zoran writes: > VCHI messages between the CPU and firmware use 32-bit > bus addresses. Explicitly set the DMA mask and coherent > on all platforms. Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [PATCH v2] staging: vc04_services: add vchiq_pagelist_info structure

2016-11-07 Thread Eric Anholt
o understand and maintain. > > Tests Run(Both Pass): > vchiq_test -p 1 > vchiq_test -f 10 Looks good, and it's a nice cleanup. Thanks! Reviewed-by: Eric Anholt I had one style note, which was that you're using an int and 0/1 for a boolean value, but we like to use proper bo

[GIT PULL] drm-vc4-next-2016-11-16

2016-11-16 Thread Eric Anholt
() Eric Anholt (3): drm/vc4: Fix termination of the initial scan for branch targets. drm/vc4: Add support for rendering with ETC1 textures. drm/vc4: Use runtime autosuspend to avoid thrashing V3D power state. Jonas Pfeil (1): drm/vc4: Add fragment shader threading support

Re: [PATCH V2 0/2] ARM: bcm2835: Fix names for the Raspberry Pi GPIO lines

2016-11-16 Thread Eric Anholt
Stefan Wahren writes: > This patch series should fix and extend the patch V4 "ARM: bcm2835: Add names > for the Raspberry Pi GPIO lines" from Linus Walleij and Eric Anholt. > > Changes in V2: > - fix URL to firmware DT blob > - drop dtsi file since Model A+ and Z

Re: [PATCH 1/2] staging: vc04_services: remove duplicate mutex_lock_interruptible

2016-11-16 Thread Eric Anholt
Arnd Bergmann writes: > The driver tries to redefine mutex_lock_interruptible as an open-coded > mutex_lock_killable, but that definition clashes with the normal > mutex_lock_interruptible definition when CONFIG_DEBUG_LOCK_ALLOC > is set: These two are: Acked-by: Eric Anholt s

[PATCH libdrm] vc4: Add new GETPARAMs that have been merged to drm-next.

2016-11-16 Thread Eric Anholt
Signed-off-by: Eric Anholt --- include/drm/vc4_drm.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/vc4_drm.h b/include/drm/vc4_drm.h index 919eecea7626..319881d8e5ca 100644 --- a/include/drm/vc4_drm.h +++ b/include/drm/vc4_drm.h @@ -286,6 +286,8 @@ struct

[PATCH] drm/vc4: Fix memory leak of the CRTC state.

2016-10-10 Thread Eric Anholt
The underscores variant frees the pointers inside, while the no-underscores variant calls underscores and then frees the struct. Signed-off-by: Eric Anholt Fixes: d8dbf44f13b9 ("drm/vc4: Make the CRTCs cooperate on allocating display lists.") Cc: sta...@vger.kernel.org --- drivers/g

Re: [RFC PATCH 00/11] Introduce writeback connectors

2016-10-11 Thread Eric Anholt
Brian Starkey writes: > Hi, > > This RFC series introduces a new connector type: > DRM_MODE_CONNECTOR_WRITEBACK > It is a follow-on from a previous discussion: [1] > > Writeback connectors are used to expose the memory writeback engines > found in some display controllers, which can write a CRTC

Re: [RFC PATCH 00/11] Introduce writeback connectors

2016-10-13 Thread Eric Anholt
Brian Starkey writes: > Hi Eric, > > On Tue, Oct 11, 2016 at 12:01:14PM -0700, Eric Anholt wrote: >>Brian Starkey writes: >> >>> Hi, >>> >>> This RFC series introduces a new connector type: >>> DRM_MODE_CONNECTOR_WRITEBACK >>> I

[GIT PULL] drm-vc4-next-2016-10-06

2016-10-06 Thread Eric Anholt
8:28 -0700) This pull request brings in several fixes for drm-next, mostly for HDMI. ---- Eric Anholt (7): drm/vc4: Fix races when the CS reads from render targets. drm/vc4: Enable limited range RGB output on HDMI with

Re: [PATCH 1/4] staging/vchi: Convert to current get_user_pages() arguments.

2016-10-07 Thread Eric Anholt
Greg Kroah-Hartman writes: > On Mon, Oct 03, 2016 at 11:52:06AM -0700, Eric Anholt wrote: >> Signed-off-by: Eric Anholt > > In the future, it's good to put at least some changelog text in here. I > normally do not accept patches without it. But I'll take these tw

Re: [PATCH 2/2] pinctrl: bcm2835: Return pins to inputs when freed

2016-11-14 Thread Eric Anholt
Linus Walleij writes: > From: Phil Elwell > > When dynamically unloading overlays, it is important that freed pins are > restored to being inputs to prevent functions from being enabled in > multiple places at once. > > Cc: Stefan Wahren > Cc: Eric Anholt > Cc: Step

Re: [PATCH 1/2] pinctrl: bcm2835: Fix ints for GPIOs 28-31 & 46-53

2016-11-14 Thread Eric Anholt
o split out a function to process the interrupts for a single GPIO >> bank. >> >> Cc: Stefan Wahren >> Cc: Eric Anholt >> Cc: Stephen Warren >> Signed-off-by: Phil Elwell >> Signed-off-by: Linus Walleij >> --- >

Re: [PATCH] ARM64: dts: bcm2837-rpi-3-b: remove incorrect pwr LED

2016-11-14 Thread Eric Anholt
Stefan Wahren writes: > Hi Eric, > > [add Gerd to CC] > >> Eric Anholt hat am 11. November 2016 um 18:38 geschrieben: >> >> >> From: Andrea Merello >> >> We are incorrectly defining the pwr LED, attaching it to a gpio line >> that is w

Re: [PATCH 2/2] ARM: bcm2835: Add names for the Raspberry Pi Zero GPIO lines

2016-11-15 Thread Eric Anholt
Stefan Wahren writes: > This adds the GPIO names for the Raspberry Pi Zero. Since there are no > schematics for the RPi Zero use the same as the Model A+. These look good to me. I don't have a Zero schematic, but I compared to dt-blob. I've pulled these two to -next. signature.asc Description

<    3   4   5   6   7   8   9   10   11   12   >