Re: [RFC 15/23] usb: musb: raw read and write endian fix

2013-11-25 Thread Felipe Balbi
Hi, On Mon, Nov 25, 2013 at 04:07:49PM -0600, Felipe Balbi wrote: On Sat, Nov 16, 2013 at 02:01:18AM +0200, Taras Kondratiuk wrote: From: Victor Kamensky victor.kamen...@linaro.org All OMAP IP blocks expect LE data, but CPU may operate in BE mode. Need to use endian neutral functions

Re: [PATCH RFC] gpio: omap: refresh the patch “gpio: omap: be more aggressive with pm_runtime” against v3.12-rc5

2013-11-26 Thread Felipe Balbi
Hi Chao, On Mon, Nov 25, 2013 at 09:30:46PM -0600, Chao Xu wrote: Refresh the patch “gpio: omap: be more aggressive with pm_runtime” by Felipe Balbi against v3.12-rc5. Add version checking so that the aggressive pm_runtime only applies to omap4 devices. Tested with pandaboard rev a2 through

Re: [PATCH] phy: kconfig: add depends on USB_SUPPORT to OMAP_USB2 and TWL4030_USB

2013-11-26 Thread Felipe Balbi
On Tue, Nov 26, 2013 at 03:31:55PM +0530, Kishon Vijay Abraham I wrote: Fixes warning: (OMAP_USB2 TWL4030_USB) selects USB_PHY which has unmet direct dependencies (USB_SUPPORT) that shows up while disabling USB_SUPPORT from menuconfig. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com

Re: [PATCH v4 00/15] usb: phy: msm: Fixes, cleanups and DT support

2013-11-26 Thread Felipe Balbi
Hi, On Tue, Nov 12, 2013 at 04:51:35PM +0200, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com Hi, Patches have been tested on top of Stephen's clock controller patches[1] and recent fixes for chipidea msm glue layer driver posted here[2]. Hardware platform AP8074

Re: BUG: usb: obex in g_nokia.ko causing kernel panic

2013-11-26 Thread Felipe Balbi
Hi, On Tue, Nov 19, 2013 at 11:51:12AM +0100, Pali Rohár wrote: Hi! For a long time (since 3.5 or 3.8? - I do not remember) obex subdriver in g_nokia usb gadget module causing kernel panic after module is loaded on Nokia N900. I do not know where is problem and due to immediatelly kernel

Re: BUG: usb: obex in g_nokia.ko causing kernel panic

2013-11-26 Thread Felipe Balbi
Hi, On Tue, Nov 26, 2013 at 06:28:05PM +0100, Pali Rohár wrote: [ snip ] (above dump is from 3.12-rc5 kernel) looks like it's trying to do i2c transfers from atomic. But why only when obex is enabled ? Makes no sense. What do you have on userland ? Is there anything trying to access

Re: [PATCH] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-11-26 Thread Felipe Balbi
On Mon, Oct 28, 2013 at 01:59:02PM +0100, Andreas Larsson wrote: On 2013-10-01 16:19, Felipe Balbi wrote: +static void gr_finish_request(struct gr_ep *ep, struct gr_request *req, + int status) +{ + struct gr_udc *dev; + + list_del_init(req-queue); + + if (likely(req

Re: BUG: usb: obex in g_nokia.ko causing kernel panic

2013-11-26 Thread Felipe Balbi
Hi, On Tue, Nov 26, 2013 at 07:06:43PM +0100, Pavel Machek wrote: For a long time (since 3.5 or 3.8? - I do not remember) obex subdriver in g_nokia usb gadget module causing kernel panic after module is loaded on Nokia N900. I do not know where is problem and due to immediatelly

Re: BUG: usb: obex in g_nokia.ko causing kernel panic

2013-11-26 Thread Felipe Balbi
Hi, On Tue, Nov 26, 2013 at 07:10:08PM +0100, Pali Rohár wrote: (above dump is from 3.12-rc5 kernel) looks like it's trying to do i2c transfers from atomic. But why only when obex is enabled ? Makes no sense. What do you have on userland ? Is there anything trying to

Re: BUG: usb: obex in g_nokia.ko causing kernel panic

2013-11-26 Thread Felipe Balbi
Hi, On Tue, Nov 26, 2013 at 12:59:13PM -0600, Felipe Balbi wrote: diff --git a/drivers/usb/gadget/f_obex.c b/drivers/usb/gadget/f_obex.c index ad39f1d..4af2f06 100644 --- a/drivers/usb/gadget/f_obex.c +++ b/drivers/usb/gadget/f_obex.c @@ -267,10 +267,12 @@ static void obex_connect

Re: [PATCH V2] gpio: omap: refresh patch be more aggressive with pm_runtime against v3.12-rc5

2013-11-26 Thread Felipe Balbi
Hi, On Tue, Nov 26, 2013 at 04:46:44PM -0600, Chao Xu wrote: From: Felipe Balbi ba...@ti.com try to keep gpio block suspended as much as possible. Tested with pandaboard and a sysfs exported gpio. Signed-off-by: Felipe Balbi balbi at ti.com [caesarxuc...@gmail.com : Refreshed against

Re: BUG: usb: obex in g_nokia.ko causing kernel panic

2013-11-27 Thread Felipe Balbi
Hi, On Wed, Nov 27, 2013 at 05:40:42PM +0100, Pali Rohár wrote: @@ -282,10 +284,12 @@ static void obex_disconnect(struct gserial *g) if (!obex-can_activate) return; +#if 0 status = usb_function_deactivate(g-func); if

[PATCH 05/13] mfd: menelaus: use for_each_set_bit()

2013-11-27 Thread Felipe Balbi
that macro just helps removing some extra line of code and hides ffs() calls. while at that, also fix a variable shadowing bug where 'int irq' was being redeclared inside inner loop while it was also argument to interrupt handler. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd

[PATCH 03/13] mfd: menelaus: convert to threaded irq

2013-11-27 Thread Felipe Balbi
we don't need that extra workqueue when we have generic threaded irq handlers support. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 29 - 1 file changed, 4 insertions(+), 25 deletions(-) diff --git a/drivers/mfd/menelaus.c b/drivers/mfd

[PATCH 13/13] mfd: menelaus: remove unnecessary definition

2013-11-27 Thread Felipe Balbi
menelaus_i2c_driver isn't referenced on probe, just remove that unnecessary line. No functional changes. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c index e7006e4..376f01d

[PATCH 12/13] mfd: menelaus: switch all children to threaded_irq

2013-11-27 Thread Felipe Balbi
now that we have our own irq_chip, all children can use traditional request_threaded_irq(). While at that, also remove so functions which became unused. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 161 +++-- 1 file changed

[PATCH 09/13] mfd: menelaus: pass menelaus_chip pointer to get/set voltage

2013-11-27 Thread Felipe Balbi
those functions are static and can easily receive a menelaus_chip pointer argument. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 50 +++--- 1 file changed, 27 insertions(+), 23 deletions(-) diff --git a/drivers/mfd/menelaus.c

[PATCH 04/13] mfd: menelaus: remove unnecessary loop

2013-11-27 Thread Felipe Balbi
we can let irqs refire and give the scheduler a chance to choose when we should be scheduled. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 43 +++ 1 file changed, 19 insertions(+), 24 deletions(-) diff --git a/drivers/mfd

[PATCH 08/13] mfd: menelaus: pass menelaus_chip pointer to add/remove irq functions

2013-11-27 Thread Felipe Balbi
those functions are static and can receive a menelaus_chip pointer very easily. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 57 ++ 1 file changed, 30 insertions(+), 27 deletions(-) diff --git a/drivers/mfd/menelaus.c b

[PATCH 11/13] mfd: menelaus: start to use irqdomain

2013-11-27 Thread Felipe Balbi
introduce an irq_chip and irq_domain for menelaus driver. Following patches will convert uses to traditional request_threaded_irq(). Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 109 + 1 file changed, 109 insertions

[PATCH 07/13] mfd: menelaus: limit the usage of the_menelaus

2013-11-27 Thread Felipe Balbi
pass a menelaus_chip pointer as argument to most functions so we can minimize the usage of the global the_menelaus pointer. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 265 ++--- 1 file changed, 142 insertions(+), 123

[PATCH 10/13] mfd: menelaus: pass menelaus_chip argument to menelaus - time helpers

2013-11-27 Thread Felipe Balbi
time_to_menelaus() and menelaus_to_time() are static and can easily receive a struct menelaus_chip pointer argument. After this patch, the_menelaus is only used on exported functions which are currently being used by board-n8x0.c. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd

[PATCH 06/13] mfd: menelaus: pass menelaus pointer as argument to enable/disable irq

2013-11-27 Thread Felipe Balbi
we want to, eventually, get rid of the global the_menelaus pointer, so let's start passing menelaus as argument to some function calls and slowly phase out the_menelaus global pointer. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 48

[PATCH 02/13] mfd: menelaus: switch over to module_i2c_driver

2013-11-27 Thread Felipe Balbi
just a macro to remove some boilerplate code, no functional changes. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c index 975ff9e

[PATCH 00/13] mfd: menelaus: a few cleanups

2013-11-27 Thread Felipe Balbi
few cleanups on the old menelaus driver. I don't have HW to test these patches, maybe Aaro can help here ? cheers Felipe Balbi (13): mfd: menelaus: drop __exit section annotation mfd: menelaus: switch over to module_i2c_driver mfd: menelaus: convert to threaded irq mfd: menelaus: remove

[PATCH 01/13] mfd: menelaus: drop __exit section annotation

2013-11-27 Thread Felipe Balbi
we could build that as a driver. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c index ad25bfa..975ff9e 100644 --- a/drivers/mfd/menelaus.c +++ b/drivers

Re: [PATCH 00/13] mfd: menelaus: a few cleanups

2013-11-27 Thread Felipe Balbi
Hi, On Wed, Nov 27, 2013 at 10:02:47PM +0200, Aaro Koskinen wrote: On Wed, Nov 27, 2013 at 01:06:44PM -0600, Felipe Balbi wrote: few cleanups on the old menelaus driver. I don't have HW to test these patches, maybe Aaro can help here ? Hmm, I got: [1.33] Unable to handle kernel

Re: [PATCH 00/13] mfd: menelaus: a few cleanups

2013-11-27 Thread Felipe Balbi
Hi, On Wed, Nov 27, 2013 at 10:46:21PM +0200, Aaro Koskinen wrote: Hi, On Wed, Nov 27, 2013 at 02:11:49PM -0600, Felipe Balbi wrote: On Wed, Nov 27, 2013 at 10:02:47PM +0200, Aaro Koskinen wrote: On Wed, Nov 27, 2013 at 01:06:44PM -0600, Felipe Balbi wrote: few cleanups on the old

Re: [PATCH 2/5] usb: gadget: s3c-hsotg: support configurable UTMI PHY width

2013-10-11 Thread Felipe Balbi
Hi, On Thu, Oct 10, 2013 at 11:21:30PM -0400, Matt Porter wrote: On 10/10/2013 03:07 PM, Matt Porter wrote: On 10/10/2013 01:57 PM, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Thursday, October 10, 2013 10:46 AM On Thu, Oct 10, 2013 at 12:54:40PM -0400, Matt Porter

Re: [PATCH v3] USB: gadget: s3c-hsotg: add isochronous transfers support

2013-10-11 Thread Felipe Balbi
Hi, On Fri, Oct 11, 2013 at 08:23:35AM +0200, Robert Baldyga wrote: Hello, On 10/10/2013 06:04 PM, Felipe Balbi wrote: Hi, On Wed, Oct 09, 2013 at 08:41:57AM +0200, Robert Baldyga wrote: @@ -2616,14 +2630,19 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep

Re: [PATCH v4 01/17] ARM: at91: move at91_pmc.h to include/linux/clk/at91_pmc.h

2013-10-11 Thread Felipe Balbi
in clk drivers. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com for drivers/usb/gadget: Acked-by: Felipe Balbi ba...@ti.com -- balbi signature.asc Description: Digital signature

Re: USB regression in v3.12-rc4

2013-10-14 Thread Felipe Balbi
connected to the host. musb_g_reset() already takes care of it. Signed-off-by: Bin Liu b-...@ti.com Signed-off-by: Felipe Balbi ba...@ti.com Reverting that commit from v3.12-rc4 will fix the issue. Based on the commit log this is not fixing any real issue, so I wonder why

Re: [PATCH v3 01/13] usb: phy: msm: Move mach depndend code to platform data

2013-10-14 Thread Felipe Balbi
dwal...@fifo99.com Cc: Felipe Balbi ba...@ti.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com --- arch/arm/mach-msm/board-msm7x30.c | 35 +++ arch/arm/mach-msm/board-qsd8x50.c | 35

Re: [PATCH v3 02/13] usb: phy: msm: Move global regulators variables to driver state

2013-10-14 Thread Felipe Balbi
On Mon, Oct 14, 2013 at 06:24:29PM +0300, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com this one looks good. -- balbi signature.asc Description: Digital signature

Re: [PATCH v3 12/13] usb: phy: msm: Properly check core interrupt number

2013-10-14 Thread Felipe Balbi
On Mon, Oct 14, 2013 at 06:24:39PM +0300, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com IRQ with number 0 is valid case, so check for negative not entirelly correct... IRQ 0 isn't supposed to be used as a linux IRQ number IIRC. numbers instead. Signed-off-by: Ivan T.

Re: [PATCH v2 2/2] phy: omap-usb2: Adapt phy-omap-usb2 for AM437x

2013-10-15 Thread Felipe Balbi
Hi, On Tue, Oct 15, 2013 at 12:23:45PM +0530, George Cherian wrote: This patch adds a compatible for AM437x ti,am43xx-usb2 to reuse the same phy-omap-usb2 driver. it does more than just adding a new compatible flag. diff --git a/drivers/phy/phy-omap-usb2.c b/drivers/phy/phy-omap-usb2.c

Re: [PATCH v3 2/2] phy: omap-usb2: Adapt phy-omap-usb2 for AM437x

2013-10-15 Thread Felipe Balbi
On Tue, Oct 15, 2013 at 04:07:43PM +0530, George Cherian wrote: This patch adds a compatible for AM437x ti,am43xx-usb2 to reuse the same phy-omap-usb2 driver. Also updated the documentation to add the new compatible. Signed-off-by: George Cherian george.cher...@ti.com I commented on

Re: [PATCH 2/7] usb: dwc3: adapt dwc3 core to use Generic PHY Framework

2013-10-15 Thread Felipe Balbi
On Tue, Oct 15, 2013 at 11:01:16AM +0530, Kishon Vijay Abraham I wrote: Hi Roger, On Monday 14 October 2013 03:51 PM, Roger Quadros wrote: +Vivek On 10/14/2013 12:26 PM, Kishon Vijay Abraham I wrote: Hi Roger, On Friday 11 October 2013 08:39 PM, Roger Quadros wrote: Hi, On

Re: [PATCH 2/7] usb: dwc3: adapt dwc3 core to use Generic PHY Framework

2013-10-15 Thread Felipe Balbi
Hi, On Mon, Oct 14, 2013 at 01:21:29PM +0300, Roger Quadros wrote: +Vivek On 10/14/2013 12:26 PM, Kishon Vijay Abraham I wrote: Hi Roger, On Friday 11 October 2013 08:39 PM, Roger Quadros wrote: Hi, On 09/02/2013 06:43 PM, Kishon Vijay Abraham I wrote: Adapted dwc3 core to use

Re: [PATCH 2/7] usb: dwc3: adapt dwc3 core to use Generic PHY Framework

2013-10-15 Thread Felipe Balbi
On Tue, Oct 15, 2013 at 10:57:16AM +0300, Roger Quadros wrote: On 10/15/2013 08:31 AM, Kishon Vijay Abraham I wrote: Hi Roger, On Monday 14 October 2013 03:51 PM, Roger Quadros wrote: +Vivek On 10/14/2013 12:26 PM, Kishon Vijay Abraham I wrote: Hi Roger, On Friday 11 October

Re: [PATCH 2/7] usb: dwc3: adapt dwc3 core to use Generic PHY Framework

2013-10-15 Thread Felipe Balbi
979b84f96e4b7559b596b2933ae198aba267f260 Author: Felipe Balbi ba...@ti.com Date: Sun Jun 30 18:39:23 2013 +0300 usb: dwc3: core: make USB3 PHY optional If we want a port to work at any speed lower than Superspeed, it makes no sense to even initialize/power up the USB3 transceiver

Re: [PATCH] phy: omap: Adapt phy-omap-usb2 for AM437x

2013-10-15 Thread Felipe Balbi
Hi, On Tue, Oct 15, 2013 at 12:35:12PM +0530, George Cherian wrote: Hi Mark, Fixed all your comments and already sent a V2. On 10/14/2013 8:03 PM, Mark Rutland wrote: On Mon, Oct 14, 2013 at 01:43:23PM +0100, George Cherian wrote: This patch adds a compatible for AM437x ti,am43xx-usb2

Re: [PATCH 2/7] usb: dwc3: adapt dwc3 core to use Generic PHY Framework

2013-10-15 Thread Felipe Balbi
Hi, On Tue, Oct 15, 2013 at 04:48:51PM +0300, Roger Quadros wrote: On 10/15/2013 04:19 PM, Felipe Balbi wrote: Hi, On Tue, Oct 15, 2013 at 03:10:42PM +0300, Roger Quadros wrote: @@ -665,6 +669,9 @@ struct dwc3 { struct usb_phy *usb2_phy; struct usb_phy

Re: [PATCH 2/7] usb: dwc3: adapt dwc3 core to use Generic PHY Framework

2013-10-15 Thread Felipe Balbi
On Tue, Oct 15, 2013 at 05:03:50PM +0300, Roger Quadros wrote: On 10/15/2013 04:56 PM, Felipe Balbi wrote: Hi, On Tue, Oct 15, 2013 at 04:48:51PM +0300, Roger Quadros wrote: On 10/15/2013 04:19 PM, Felipe Balbi wrote: Hi, On Tue, Oct 15, 2013 at 03:10:42PM +0300, Roger Quadros

Re: [PATCH] clk: add flags to distinguish xtal clocks

2013-11-11 Thread Felipe Balbi
Hi, On Sun, Nov 10, 2013 at 12:37:16PM +0100, Maxime Ripard wrote: Hi Felipe, On Fri, Nov 08, 2013 at 12:00:48PM -0600, Felipe Balbi wrote: From: Luciano Coelho l...@coelho.fi Add a flag that indicate whether the clock is a crystal or not. Additionally, parse a new device tree

Re: [PATCH] clk: add flags to distinguish xtal clocks

2013-11-11 Thread Felipe Balbi
Hi, On Mon, Nov 11, 2013 at 09:27:58AM -0700, Stephen Warren wrote: On 11/08/2013 11:00 AM, Felipe Balbi wrote: From: Luciano Coelho l...@coelho.fi Add a flag that indicate whether the clock is a crystal or not. Additionally, parse a new device tree binding in clk-fixed-rate to set

Re: [PATCH] usb: phy: remove dead code

2013-11-12 Thread Felipe Balbi
On Sun, Nov 10, 2013 at 07:37:37PM +0100, Michal Nazarewicz wrote: From: Michal Nazarewicz min...@mina86.com no SoB, cannot apply. I already had this patch in my tree but didn't send it. I'm fine with using yours but I need SoB and commit log. -- balbi signature.asc Description: Digital

Re: [PATCH V2] ARM: OMAP2+: omap_device: maintain sane runtime pm status around suspend/resume

2013-11-13 Thread Felipe Balbi
Hi, On Tue, Nov 12, 2013 at 05:08:30PM -0600, Nishanth Menon wrote: diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c index b69dd9a..f97b34b 100644 --- a/arch/arm/mach-omap2/omap_device.c +++ b/arch/arm/mach-omap2/omap_device.c @@ -621,6 +621,7 @@ static

Re: [PATCH V2] ARM: OMAP2+: omap_device: maintain sane runtime pm status around suspend/resume

2013-11-13 Thread Felipe Balbi
On Wed, Nov 13, 2013 at 08:56:06AM -0600, Nishanth Menon wrote: On 11/13/2013 06:51 AM, Felipe Balbi wrote: Hi, On Tue, Nov 12, 2013 at 05:08:30PM -0600, Nishanth Menon wrote: diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c index b69dd9a..f97b34b

Re: [PATCH V3] ARM: OMAP2+: omap_device: maintain sane runtime pm status around suspend/resume

2013-11-14 Thread Felipe Balbi
)); if you want to print the device name, how about dev_WARN() ? no strong feelings though: Reviewed-by: Felipe Balbi ba...@ti.com -- balbi signature.asc Description: Digital signature

Re: [RFC 14/23] USB: ehci-omap: raw read and write endian fix

2013-11-18 Thread Felipe Balbi
-by: Victor Kamensky victor.kamen...@linaro.org Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org Acked-by: Felipe Balbi ba...@ti.com --- drivers/usb/host/ehci-omap.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb

commit c368e5fc2a190923b786f2de3e79430ea3566a25 regresses MMC

2013-11-20 Thread Felipe Balbi
807bb4e91eea46390f184b737f7f8dc634e62a01 Mon Sep 17 00:00:00 2001 From: Felipe Balbi ba...@ti.com Date: Wed, 20 Nov 2013 11:52:33 -0600 Subject: [PATCH] regulator: core: fix regulator_list_voltage() commit c368e5f (regulator: fixed: get rid of {get|list}_voltage()) caused a regression for any MMC

Re: commit c368e5fc2a190923b786f2de3e79430ea3566a25 regresses MMC

2013-11-20 Thread Felipe Balbi
Hi, On Wed, Nov 20, 2013 at 08:34:00PM +, Mark Brown wrote: On Wed, Nov 20, 2013 at 11:58:14AM -0600, Felipe Balbi wrote: commit c368e5fc2a190923b786f2de3e79430ea3566a25 (regulator: fixed: get rid of {get|list}_voltage()) regresses any MMC host controller which uses fixed regulator

Re: commit c368e5fc2a190923b786f2de3e79430ea3566a25 regresses MMC

2013-11-20 Thread Felipe Balbi
On Wed, Nov 20, 2013 at 02:51:43PM -0600, Felipe Balbi wrote: Hi, On Wed, Nov 20, 2013 at 08:34:00PM +, Mark Brown wrote: On Wed, Nov 20, 2013 at 11:58:14AM -0600, Felipe Balbi wrote: commit c368e5fc2a190923b786f2de3e79430ea3566a25 (regulator: fixed: get rid of {get|list

[PATCH v2 06/15] mfd: menelaus: Pass menelaus pointer as argument to enable/disable irq

2013-12-02 Thread Felipe Balbi
we want to, eventually, get rid of the global the_menelaus pointer, so let's start passing menelaus as argument to some function calls and slowly phase out the_menelaus global pointer. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 48

[PATCH v2 11/15] mfd: menelaus: Start to use irqdomain

2013-12-02 Thread Felipe Balbi
introduce an irq_chip and irq_domain for menelaus driver. Following patches will convert uses to traditional request_threaded_irq(). while at that, some better error handling had to be added, so we could free irq descs we allocated. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd

[PATCH v2 04/15] mfd: menelaus: Remove unnecessary loop

2013-12-02 Thread Felipe Balbi
we can let irqs refire and give the scheduler a chance to choose when we should be scheduled. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 43 +++ 1 file changed, 19 insertions(+), 24 deletions(-) diff --git a/drivers/mfd

[PATCH v2 15/15] mfd: menelaus: Use devm_request_threaded_irq()

2013-12-02 Thread Felipe Balbi
by using devm_request_threaded_irq() we can drop a few extra lines of code and rely on device managed resources layer to free our IRQ for us. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git

[PATCH v2 14/15] mfd: menelaus: IRQ is a requirement

2013-12-02 Thread Felipe Balbi
this driver needs IRQ to work, if client-irq isn't set properly, we won't work. Remove check around request_threaded_irq(). Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/mfd

[PATCH v2 13/15] mfd: menelaus: Remove unnecessary definition

2013-12-02 Thread Felipe Balbi
menelaus_i2c_driver isn't referenced on probe, just remove that unnecessary line. No functional changes. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c index 74eae19..c0219b7

[PATCH v2 03/15] mfd: menelaus: Convert to threaded irq

2013-12-02 Thread Felipe Balbi
we don't need that extra workqueue when we have generic threaded irq handlers support. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 29 - 1 file changed, 4 insertions(+), 25 deletions(-) diff --git a/drivers/mfd/menelaus.c b/drivers/mfd

[PATCH v2 10/15] mfd: menelaus: Pass menelaus_chip argument to menelaus - time helpers

2013-12-02 Thread Felipe Balbi
time_to_menelaus() and menelaus_to_time() are static and can easily receive a struct menelaus_chip pointer argument. After this patch, the_menelaus is only used on exported functions which are currently being used by board-n8x0.c. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd

[PATCH v2 02/15] mfd: menelaus: Switch over to module_i2c_driver

2013-12-02 Thread Felipe Balbi
just a macro to remove some boilerplate code, no functional changes. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c index 975ff9e

[PATCH v2 08/15] mfd: menelaus: Pass menelaus_chip pointer to add/remove irq functions

2013-12-02 Thread Felipe Balbi
those functions are static and can receive a menelaus_chip pointer very easily. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 57 ++ 1 file changed, 30 insertions(+), 27 deletions(-) diff --git a/drivers/mfd/menelaus.c b

[PATCH v2 07/15] mfd: menelaus: Limit the usage of the_menelaus

2013-12-02 Thread Felipe Balbi
pass a menelaus_chip pointer as argument to most functions so we can minimize the usage of the global the_menelaus pointer. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 265 ++--- 1 file changed, 142 insertions(+), 123

[PATCH v2 05/15] mfd: menelaus: Use for_each_set_bit()

2013-12-02 Thread Felipe Balbi
that macro just helps removing some extra line of code and hides ffs() calls. while at that, also fix a variable shadowing bug where 'int irq' was being redeclared inside inner loop while it was also argument to interrupt handler. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd

[PATCH v2 09/15] mfd: menelaus: Pass menelaus_chip pointer to get/set voltage

2013-12-02 Thread Felipe Balbi
those functions are static and can easily receive a menelaus_chip pointer argument. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 50 +++--- 1 file changed, 27 insertions(+), 23 deletions(-) diff --git a/drivers/mfd/menelaus.c

[PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

2013-12-02 Thread Felipe Balbi
we could build that as a driver. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c index ad25bfa..975ff9e 100644 --- a/drivers/mfd/menelaus.c +++ b/drivers

[PATCH v2 12/15] mfd: menelaus: Switch all children to threaded_irq

2013-12-02 Thread Felipe Balbi
now that we have our own irq_chip, all children can use traditional request_threaded_irq(). While at that, also remove so functions which became unused. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 161 +++-- 1 file changed

[PATCH] arm: boot: dts: build keystone devicetree blob

2014-03-12 Thread Felipe Balbi
Currently, even when building keystone only kernel builds, DTB won't get build because we lack a Makefile rule to get it compiled. This patch adds that rule so mainline kernel users have a chance to use up-to-date DTB on keystone 2 platforms. Signed-off-by: Felipe Balbi ba...@ti.com --- note

Re: [PATCH] arm: boot: dts: build keystone devicetree blob

2014-03-12 Thread Felipe Balbi
On Thu, Mar 13, 2014 at 12:35:41AM +0800, Santosh Shilimkar wrote: On Wednesday 12 March 2014 11:48 PM, Felipe Balbi wrote: Currently, even when building keystone only kernel builds, DTB won't get build because we lack a Makefile rule to get it compiled. This patch adds that rule so

Re: [PATCH v4 0/5] Add USB nodes for am43xx epos and gp evm

2014-03-13 Thread Felipe Balbi
On Thu, Mar 13, 2014 at 08:41:11PM +0530, George Cherian wrote: The patch series adds USB dt nodes for am43xx epos and gp evm Boot tested with linux-next + Tony's omap-for-v3.15/dt Changes from v1 - v2 * Reorder doc: Add ti,am437x-dwc3 comaptible for dwc3 glue * Address v1

Re: [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY

2014-03-13 Thread Felipe Balbi
phy reference in Generic PHY APIs stubs in the same way as it was done by the patch 04c2facad8fee66c981a51852806d8923336f362 drivers: phy: Make NULL a valid phy reference. CC: Kishon Vijay Abraham I kis...@ti.com CC: Felipe Balbi ba...@ti.com CC: Santosh Shilimkar santosh.shilim...@ti.com

Re: [PATCH] USB: Gadget: fsl driver pullup fix

2014-03-13 Thread Felipe Balbi
Hi, On Thu, Mar 13, 2014 at 06:40:55PM +0530, Suresh Gupta wrote: Attached is a small fix for the fsl usb gadget driver. This fix the driver in a way that the usb device will be only pulled up on requests like other usb gadget drivers do. This is necessary, because the device information is

Re: [PATCH] USB : Gadget: fsl: add information message

2014-03-13 Thread Felipe Balbi
On Thu, Mar 13, 2014 at 06:41:50PM +0530, Suresh Gupta wrote: Message helps to understand that the Freescale Gadget driver is up without any error. why this tab ? Signed-off-by: Suresh Gupta suresh.gu...@freescale.com --- drivers/usb/gadget/fsl_udc_core.c | 1 + 1 file

Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id

2014-03-13 Thread Felipe Balbi
On Thu, Mar 13, 2014 at 07:35:31PM +0530, Suresh Gupta wrote: From: Suresh Gupta b42...@freescale.com Add FSL USB Gadget entry in platform device id table why this tab ? Signed-off-by: Suresh Gupta b42...@freescale.com --- drivers/usb/gadget/fsl_udc_core.c | 2 ++ 1 file changed,

Re: [PATCH] usb: gadget: fsl: Set dma_ops for FSL USB Gadget Device

2014-03-13 Thread Felipe Balbi
Hi, On Thu, Mar 13, 2014 at 07:37:12PM +0530, Suresh Gupta wrote: From: Suresh Gupta b42...@freescale.com return -ENOLOG Signed-off-by: Suresh Gupta b42...@freescale.com --- drivers/usb/gadget/fsl_udc_core.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY

2014-03-13 Thread Felipe Balbi
Hi, On Thu, Mar 13, 2014 at 10:20:24AM -0500, Felipe Balbi wrote: On Thu, Mar 13, 2014 at 01:11:13PM +0200, Grygorii Strashko wrote: This fixes a regression on Keystone 2 platforms caused by patch 57303488cd37da58263e842de134dc65f7c626d5 usb: dwc3: adapt dwc3 core to use Generic PHY

Re: [PATCH 7/8] ARM: dts: dra7: Add USB related nodes

2014-03-14 Thread Felipe Balbi
On Fri, Mar 14, 2014 at 05:34:29PM +0200, Roger Quadros wrote: On 03/14/2014 04:54 PM, Kishon Vijay Abraham I wrote: On Friday 14 March 2014 05:41 PM, Roger Quadros wrote: On 03/14/2014 12:38 PM, Kishon Vijay Abraham I wrote: Hi Roger, On Friday 07 March 2014 06:39 PM, Roger

Re: [PATCH] USB: Gadget: fsl driver pullup fix

2014-03-14 Thread Felipe Balbi
Hi, (first of all, please fix your email client, we need the quotation marks. See Documentation/email-clients.txt) On Fri, Mar 14, 2014 at 08:53:24PM +, suresh.gu...@freescale.com wrote: On Thu, Mar 13, 2014 at 06:40:55PM +0530, Suresh Gupta wrote: Attached is a small fix for the fsl

Re: [PATCH] USB : Gadget: fsl: add information message

2014-03-14 Thread Felipe Balbi
On Fri, Mar 14, 2014 at 08:52:49PM +, suresh.gu...@freescale.com wrote: Hi, -Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Thursday, March 13, 2014 8:56 PM To: Gupta Suresh-B42813 Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-...@vger.kernel.org

Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id

2014-03-14 Thread Felipe Balbi
On Fri, Mar 14, 2014 at 08:52:19PM +, suresh.gu...@freescale.com wrote: Hi, Thanks for reviewing my patches. Please find my comments inline -Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Thursday, March 13, 2014 8:56 PM To: Gupta Suresh-B42813 Cc: ba

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-02-24 Thread Felipe Balbi
/2014 11:46 AM, Kishon Vijay Abraham I wrote: On Wednesday 29 January 2014 08:17 PM, Heikki Krogerus wrote: Hi, On Tue, Jan 28, 2014 at 10:30:36AM -0600, Felipe Balbi wrote: On Tue, Jan 28, 2014 at 05:32:30PM +0200, Heikki Krogerus wrote: On Mon, Jan 27, 2014 at 10:05:20AM -0600, Felipe

Re: [Patch v7 2/2] dmaengine: add Qualcomm BAM dma driver

2014-02-24 Thread Felipe Balbi
Hi, On Mon, Feb 24, 2014 at 05:11:40PM -0600, Andy Gross wrote: diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 605b016..f87cef9 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -401,4 +401,13 @@ config DMATEST config DMA_ENGINE_RAID bool +config

Re: [Patch v7 2/2] dmaengine: add Qualcomm BAM dma driver

2014-02-24 Thread Felipe Balbi
On Tue, Feb 25, 2014 at 12:05:00PM +0900, Mark Brown wrote: On Mon, Feb 24, 2014 at 06:09:13PM -0600, Felipe Balbi wrote: + depends on ARCH_QCOM || (COMPILE_TEST OF ARM) do you really want to make it depend on ARM even when COMPILE_TEST=y ? writel_relaxed() is unfortunately

[PATCH] mmc: host: dw: fix possible build error

2014-02-25 Thread Felipe Balbi
) ^ Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mmc/host/dw_mmc-k3.c | 2 ++ drivers/mmc/host/dw_mmc.h| 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c index f567c21..650f9cc 100644 --- a/drivers/mmc/host

Re: [PATCH 1/6] usb: gadget: gr_udc: Make struct platform_device variable name clearer

2014-02-25 Thread Felipe Balbi
On Mon, Feb 24, 2014 at 08:40:17AM +0100, Andreas Larsson wrote: On 2014-02-18 16:52, Felipe Balbi wrote: On Thu, Jan 09, 2014 at 11:54:13AM +0100, Andreas Larsson wrote: Rename struct platform_device pointers from ofdev to pdev for clarity. Suggested by Mark Rutland. Signed-off-by: Andreas

Re: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-25 Thread Felipe Balbi
Hi, On Tue, Feb 25, 2014 at 07:46:08AM +, Peter Chen wrote: Hardware zlt will try to send the zero length packet automatically when the data transferd is multiple times of max packet, this will cause issues on Windows. So let's disable HW zlt by default.

Re: [PATCH 3/3] usb: phy: msm: use ASSIGN_*_PM_OPS variants

2014-02-25 Thread Felipe Balbi
, msm_otg_runtime_resume, + msm_otg_runtime_idle) if the patch introducing assign_if() gets accepted, I'm ok with this patch. Acked-by: Felipe Balbi ba...@ti.com -- balbi signature.asc Description: Digital signature

Re: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-26 Thread Felipe Balbi
Hi, On Tue, Feb 25, 2014 at 05:48:17PM -0800, Neil Zhang wrote: Hardware zlt will try to send the zero length packet automatically when the data transferd is multiple times of max packet, this will cause issues on Windows. So let's disable HW zlt by default.

Re: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-26 Thread Felipe Balbi
On Wed, Feb 26, 2014 at 02:36:19AM +, Peter Chen wrote: easy to be found. Chipidea bug too? Does it follow ch 8.5.3.2 Variable-length Data Stage, USB 2.0 spec? wait, this is a chipidea core ? Why aren't you guys using the chipidea driver yet ? You need to

Re: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-26 Thread Felipe Balbi
On Wed, Feb 26, 2014 at 02:36:19AM +, Peter Chen wrote: easy to be found. Chipidea bug too? Does it follow ch 8.5.3.2 Variable-length Data Stage, USB 2.0 spec? wait, this is a chipidea core ? Why aren't you guys using the chipidea driver yet ? You need to

Re: [PATCH v2 3/8] Input: pixcir_i2c_ts: Get rid of pdata-attb_read_val()

2014-02-26 Thread Felipe Balbi
On Wed, Feb 26, 2014 at 05:28:01PM +0200, Roger Quadros wrote: Get rid of the attb_read_val() platform hook. Instead, read the ATTB gpio directly from the driver. Fail if valid ATTB gpio is not provided by patform data. s/patform/platform/ -- balbi signature.asc Description: Digital

Re: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-27 Thread Felipe Balbi
On Thu, Feb 27, 2014 at 03:30:03AM +, Peter Chen wrote: Chipidea bug too? Does it follow ch 8.5.3.2 Variable-length Data Stage, USB 2.0 spec? wait, this is a chipidea core ? Why aren't you guys using the chipidea driver yet ? You need to switch over to

Re: [RFC PATCH 1/6] PM / Voltagedomain: Add generic clk notifier handler for regulator based dynamic voltage scaling

2014-02-27 Thread Felipe Balbi
Hi, On Wed, Feb 26, 2014 at 08:34:55PM -0600, Nishanth Menon wrote: On 14:56-20140225, Nishanth Menon wrote: On 02/24/2014 11:51 PM, Mike Turquette wrote: Quoting Nishanth Menon (2014-02-18 12:32:18) [...] I'm not sure about trying to capture the voltdm as a core concept. It feels a

Re: [PATCH v12 1/4] PHY: Add function set_speed to generic PHY framework

2014-02-27 Thread Felipe Balbi
Hi, On Thu, Feb 27, 2014 at 11:14:05AM -0700, Loc Ho wrote: This patch adds function set_speed to the generic PHY framework operation structure. This function can be called to instruct the PHY underlying layer at specified lane to configure for specified speed in hertz. why ? looks like

Re: [PATCH v12 3/4] PHY: add APM X-Gene SoC 15Gbps Multi-purpose PHY driver

2014-02-27 Thread Felipe Balbi
Hi, On Thu, Feb 27, 2014 at 11:14:07AM -0700, Loc Ho wrote: +/* + * This function is used to configure the PHY to operation as either SATA Gen1 + * or Gen2 speed. + */ +static void xgene_phy_sata_force_gen(struct xgene_phy_ctx *ctx, + int lane, int gen)

Re: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-27 Thread Felipe Balbi
On Thu, Feb 27, 2014 at 03:05:14PM -0300, Fabio Estevam wrote: On Thu, Feb 27, 2014 at 12:30 AM, Peter Chen peter.c...@freescale.com wrote: btw, when can I remove fsl_udc_core.c from the tree ? Freescale has other processor group (PowerPC, etc) has used this code now. Not only

Re: [PATCH v12 1/4] PHY: Add function set_speed to generic PHY framework

2014-02-27 Thread Felipe Balbi
Hi, On Thu, Feb 27, 2014 at 11:57:44AM -0800, Loc Ho wrote: On Thu, Feb 27, 2014 at 11:14:05AM -0700, Loc Ho wrote: This patch adds function set_speed to the generic PHY framework operation structure. This function can be called to instruct the PHY underlying layer at specified lane to

Re: [PATCH v12 1/4] PHY: Add function set_speed to generic PHY framework

2014-02-27 Thread Felipe Balbi
Hi, On Thu, Feb 27, 2014 at 01:09:57PM -0800, Loc Ho wrote: This patch adds function set_speed to the generic PHY framework operation structure. This function can be called to instruct the PHY underlying layer at specified lane to configure for specified speed in hertz. why

<    5   6   7   8   9   10   11   12   13   14   >