Re: [PATCH v2 1/2] nohz: add tick_nohz_full_clear_cpus() and _set_cpus() APIs

2015-04-06 Thread Frederic Weisbecker
On Mon, Apr 06, 2015 at 02:16:44PM -0400, cmetc...@ezchip.com wrote: > From: Chris Metcalf > > The "clear" API is useful, for example, to modify a cpumask to avoid > the nohz cores so that interrupts aren't sent to them. > > Likewise the "set" API is useful to modify a cpumask indicating some >

Re: [PATCH 2/4] context_tracking: Inherit TIF_NOHZ through forks instead of context switches

2015-04-21 Thread Frederic Weisbecker
On Tue, Apr 21, 2015 at 05:26:00PM +0200, Peter Zijlstra wrote: > On Tue, Apr 21, 2015 at 02:23:07PM +0200, Frederic Weisbecker wrote: > > +void __init context_tracking_cpu_set(int cpu) > > { > > + static __initdata bool initialized = false; > > + struct task_stru

Re: [PATCH 2/4] context_tracking: Inherit TIF_NOHZ through forks instead of context switches

2015-04-21 Thread Frederic Weisbecker
On Tue, Apr 21, 2015 at 10:52:18PM +0200, Peter Zijlstra wrote: > On Tue, Apr 21, 2015 at 06:51:54PM +0200, Frederic Weisbecker wrote: > > On Tue, Apr 21, 2015 at 05:26:00PM +0200, Peter Zijlstra wrote: > > > On Tue, Apr 21, 2015 at 02:23:07PM +0200, Frederic Weisbecker wrote: &g

Re: [patch 18/39] tick: sched: Force tick interrupt and get rid of softirq magic

2015-04-22 Thread Frederic Weisbecker
t; to raise the softirq which only serves the purpose of getting the > machine out of the inner idle loop. > > Signed-off-by: Thomas Gleixner > Cc: John Stultz > Cc: Preeti U Murthy > Cc: Marcelo Tosatti > Cc: Frederic Weisbecker > &

Re: [PATCH 2/4] context_tracking: Inherit TIF_NOHZ through forks instead of context switches

2015-04-22 Thread Frederic Weisbecker
On Wed, Apr 22, 2015 at 05:35:53PM +0200, Peter Zijlstra wrote: > On Tue, Apr 21, 2015 at 11:06:04PM +0200, Frederic Weisbecker wrote: > > > > Because I need the tick nohz intialization to be after irq initialization > > (init_IRQ()), > > which it depends on. >

Re: [PATCH 3/3 V7] workqueue: Allow modifying low level unbound workqueue cpumask

2015-04-22 Thread Frederic Weisbecker
On Wed, Apr 22, 2015 at 03:39:35PM -0400, Tejun Heo wrote: > Hello, > > Generally looks good to me. Some minor things below. > > On Tue, Apr 07, 2015 at 07:26:37PM +0800, Lai Jiangshan wrote: > > diff --git a/kernel/workqueue.c b/kernel/workqueue.c > > index cbccf5d..557612e 100644 > > --- a/ker

Re: [patch 18/39] tick: sched: Force tick interrupt and get rid of softirq magic

2015-04-23 Thread Frederic Weisbecker
On Wed, Apr 22, 2015 at 04:32:11PM +0200, Thomas Gleixner wrote: > On Wed, 22 Apr 2015, Frederic Weisbecker wrote: > > But the reprogramming happens only under "if ((long)delta_jiffies >= 1)". > > Probably this condition should go away as well. > > Errm

Re: [patch 18/39] tick: sched: Force tick interrupt and get rid of softirq magic

2015-04-23 Thread Frederic Weisbecker
On Thu, Apr 23, 2015 at 03:07:59PM +0200, Thomas Gleixner wrote: > On Thu, 23 Apr 2015, Frederic Weisbecker wrote: > > On Wed, Apr 22, 2015 at 04:32:11PM +0200, Thomas Gleixner wrote: > > > On Wed, 22 Apr 2015, Frederic Weisbecker wrote: > > > > But the reprogramming

[PATCH 0/4] nohz: A few improvements v3

2015-04-24 Thread Frederic Weisbecker
nticks.git nohz/core HEAD: 3c2b3b78a1cca2865a932d0265690997db9706b1 Thanks, Frederic --- Chris Metcalf (2): nohz: Add tick_nohz_full_add_cpus_to() API nohz: Set isolcpus when nohz_full is set Frederic Weisbecker (2): context_tracking: Protect against recursion contex

[PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-04-24 Thread Frederic Weisbecker
defsky Cc: Mike Galbraith Cc: Ingo Molnar Cc: Rik van Riel Signed-off-by: Frederic Weisbecker --- kernel/sched/core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 6f149f8..e95b4d8 100644 --- a/kernel/sched/core.c +++ b/kernel/sc

[PATCH 3/4] nohz: Add tick_nohz_full_add_cpus_to() API

2015-04-24 Thread Frederic Weisbecker
. Wysocki Cc: Martin Schwidefsky Cc: Ingo Molnar Link: http://lkml.kernel.org/r/1429024675-18938-1-git-send-email-cmetc...@ezchip.com Signed-off-by: Frederic Weisbecker --- include/linux/tick.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/linux/tick.h b/include/linux/tick.h

[PATCH 2/4] context_tracking: Inherit TIF_NOHZ through forks instead of context switches

2015-04-24 Thread Frederic Weisbecker
Oleg Nesterov Reviewed-by: Rik van Riel Signed-off-by: Frederic Weisbecker Cc: Thomas Gleixner Cc: Peter Zijlstra Cc: Rik van Riel Cc: Paul E. McKenney Cc: Ingo Molnar Cc: Dave Jones Cc: Oleg Nesterov --- include/linux/context_tracking.h | 10 - include/linux/sched.h

[PATCH 1/4] context_tracking: Protect against recursion

2015-04-24 Thread Frederic Weisbecker
Riel Acked-by: Peter Zijlstra (Intel) Signed-off-by: Frederic Weisbecker Cc: Thomas Gleixner Cc: Peter Zijlstra Cc: Rik van Riel Cc: Paul E. McKenney Cc: Ingo Molnar Cc: Dave Jones Cc: Oleg Nesterov --- include/linux/context_tracking_state.h | 1 + kernel/context_tracking.c

Re: [PATCH v7 1/2] nohz: add tick_nohz_full_add_cpus_to() and _remove_cpus_from() APIs

2015-04-13 Thread Frederic Weisbecker
On Fri, Apr 10, 2015 at 04:53:51PM -0400, Chris Metcalf wrote: > The "removes_cpus_from" API is useful, for example, to modify a cpumask > to avoid the nohz cores so that interrupts aren't sent to them. > > Likewise the "add_cpus_to" API is useful to modify a cpumask indicating > some special nohz

Re: [PATCH v7 2/2] nohz: set isolcpus when nohz_full is set

2015-04-13 Thread Frederic Weisbecker
On Fri, Apr 10, 2015 at 04:53:52PM -0400, Chris Metcalf wrote: > nohz_full is only useful with isolcpus also set, since otherwise the > scheduler has to run periodically to try to determine whether to steal > work from other cores. > > Accordingly, when booting with nohz_full=xxx on the command li

Re: [PATCH] smpboot: allow excluding cpus from the smpboot threads

2015-04-14 Thread Frederic Weisbecker
On Mon, Apr 13, 2015 at 12:06:50PM -0400, Chris Metcalf wrote: > Also, I want to ask Linus to pull the tile-specific changes for nohz_full > for the tile architecture. This includes a copy of the change to add the > tick_nohz_full_add_cpus_to() and tick_nohz_full_remove_cpus_from() > routines here

Re: [PATCH v8 2/2] nohz: set isolcpus when nohz_full is set

2015-04-14 Thread Frederic Weisbecker
on the command line, we > should act as if isolcpus=xxx was also set, and set (or extend) the > isolcpus set to include the nohz_full cpus. > > Acked-by: Frederic Weisbecker No need to put my ack, since I'll add my Signed-off-by when I apply the patches. Note this won't go t

Re: [PATCH v7 1/2] nohz: add tick_nohz_full_add_cpus_to() and _remove_cpus_from() APIs

2015-04-14 Thread Frederic Weisbecker
On Mon, Apr 13, 2015 at 08:49:20PM -0400, Chris Metcalf wrote: > On 4/13/2015 8:33 PM, Frederic Weisbecker wrote: > >On Fri, Apr 10, 2015 at 04:53:51PM -0400, Chris Metcalf wrote: > >>The "removes_cpus_from" API is useful, for example, to modify a cpumask > &g

Re: [PATCH 2/3] sched, timer: Use atomics for thread_group_cputimer to improve scalability

2015-04-15 Thread Frederic Weisbecker
On Tue, Apr 14, 2015 at 04:09:45PM -0700, Jason Low wrote: > While running a database workload, we found a scalability issue with itimers. > > Much of the problem was caused by the thread_group_cputimer spinlock. > Each time we account for group system/user time, we need to obtain a > thread_group

Re: [patch 17/39] tick: sched: Remove hrtimer_active() checks

2015-04-16 Thread Frederic Weisbecker
; Cc: Marcelo Tosatti Reviewed-by: Frederic Weisbecker -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v8 1/3] smpboot: allow excluding cpus from the smpboot threads

2015-04-16 Thread Frederic Weisbecker
On Tue, Apr 14, 2015 at 03:37:31PM -0400, Chris Metcalf wrote: > diff --git a/kernel/smpboot.c b/kernel/smpboot.c > index c697f73d82d6..c5d53a335387 100644 > --- a/kernel/smpboot.c > +++ b/kernel/smpboot.c > @@ -92,6 +92,9 @@ enum { > HP_THREAD_PARKED, > }; > > +/* Statically allocated and

Re: [PATCH v8 1/3] smpboot: allow excluding cpus from the smpboot threads

2015-04-16 Thread Frederic Weisbecker
On Thu, Apr 16, 2015 at 11:50:06AM -0400, Chris Metcalf wrote: > On 4/16/2015 11:28 AM, Frederic Weisbecker wrote: > >>+ /* Unpark any threads that were voluntarily parked. */ > >>>+ if (ht->cpumask) { > >>>+ cpumask_andnot(

Re: full no_hz: how works arch_irq_work_raise() with tick off on generic implementation

2015-03-09 Thread Frederic Weisbecker
On Mon, Mar 09, 2015 at 03:09:17PM +0100, Sebastian Andrzej Siewior wrote: > I just stumbled over this in -RT. The code: > > 87 bool irq_work_queue(struct irq_work *work) > 88 { > … > 96 /* If the work is "lazy", handle it from next tick if any */ > 97 if (work->flags & IRQ_WOR

[PATCH 7/7] kvm,rcu,nohz: use RCU extended quiescent state when running KVM guest

2015-03-10 Thread Frederic Weisbecker
. McKenney Signed-off-by: Rik van Riel Cc: Paul E. McKenney Cc: Andy Lutomirski Cc: Will deacon Cc: Marcelo Tosatti Cc: Christian Borntraeger Cc: Luiz Capitulino Cc: Paolo Bonzini Signed-off-by: Frederic Weisbecker --- include/linux/context_tracking.h | 6 ++ include/linux

[GIT PULL] nohz: Enable full dynticks on guest mode

2015-03-10 Thread Frederic Weisbecker
guest context_tracking: Add stub context_tracking_is_enabled context_tracking: Run vtime_user_enter/exit only when state == CONTEXT_USER context_tracking: Export context_tracking_user_enter/exit kvm,rcu,nohz: use RCU extended quiescent state when running KVM guest Fre

[PATCH 2/7] context_tracking: Rename context symbols to prepare for transition state

2015-03-10 Thread Frederic Weisbecker
lo Bonzini Signed-off-by: Frederic Weisbecker --- arch/x86/kernel/traps.c| 2 +- include/linux/context_tracking.h | 2 +- include/linux/context_tracking_state.h | 6 +++--- kernel/context_tracking.c | 8 kernel/sched/core.c| 2 +- 5 fil

[PATCH 5/7] context_tracking: Run vtime_user_enter/exit only when state == CONTEXT_USER

2015-03-10 Thread Frederic Weisbecker
c: Christian Borntraeger Cc: Luiz Capitulino Cc: Paolo Bonzini Signed-off-by: Frederic Weisbecker --- kernel/context_tracking.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c index 17715d8..a2c

[PATCH 3/7] context_tracking: Generalize context tracking APIs to support user and guest

2015-03-10 Thread Frederic Weisbecker
er code, and cannot easily use C enum parameters. Reviewed-by: Paul E. McKenney Signed-off-by: Rik van Riel Cc: Paul E. McKenney Cc: Andy Lutomirski Cc: Will deacon Cc: Marcelo Tosatti Cc: Christian Borntraeger Cc: Luiz Capitulino Cc: Paolo Bonzini Signed-off-by: Frederic Weisbecker --- i

[PATCH 6/7] context_tracking: Export context_tracking_user_enter/exit

2015-03-10 Thread Frederic Weisbecker
Signed-off-by: Frederic Weisbecker --- kernel/context_tracking.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c index a2c0866..72d59a1 100644 --- a/kernel/context_tracking.c +++ b/kernel/context_tracking.c @@ -108,6 +108,7 @@ void

[PATCH 4/7] context_tracking: Add stub context_tracking_is_enabled

2015-03-10 Thread Frederic Weisbecker
E. McKenney Cc: Andy Lutomirski Cc: Will deacon Cc: Marcelo Tosatti Cc: Christian Borntraeger Cc: Luiz Capitulino Cc: Paolo Bonzini Signed-off-by: Frederic Weisbecker --- include/linux/context_tracking_state.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux

[PATCH 1/7] ppc: Remove unused cpp symbols in kvm headers

2015-03-10 Thread Frederic Weisbecker
These don't seem to be used anywhere. Acked-by: Rik van Riel Cc: Benjamin Herrenschmidt Cc: Alexander Graf Cc: Paul E. McKenney Cc: Andy Lutomirski Cc: Will deacon Cc: Marcelo Tosatti Cc: Christian Borntraeger Cc: Luiz Capitulino Cc: Paolo Bonzini Signed-off-by: Frederic Weisb

Re: [PATCH 1/2] show isolated cpus in sysfs

2015-04-24 Thread Frederic Weisbecker
On Fri, Apr 24, 2015 at 03:24:27PM -0400, r...@redhat.com wrote: > From: Rik van Riel > > After system bootup, there is no totally reliable way to see > which CPUs are isolated, because the kernel may modify the > CPUs specified on the isolcpus= kernel command line option. > > Export the CPU lis

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-04-25 Thread Frederic Weisbecker
On Fri, Apr 24, 2015 at 04:07:52PM -0400, Gene Heskett wrote: > On Friday 24 April 2015 11:58:31 Frederic Weisbecker wrote: > > From: Chris Metcalf > > > > nohz_full is only useful with isolcpus also set, since otherwise the > > scheduler has to run periodically to

Re: kernel/timer: avoid spurious ksoftirqd wakeups

2015-04-06 Thread Frederic Weisbecker
On Thu, Apr 02, 2015 at 06:08:09PM -0300, Marcelo Tosatti wrote: > On Thu, Apr 02, 2015 at 04:59:40PM +0200, Frederic Weisbecker wrote: > > On Wed, Apr 01, 2015 at 10:44:55PM -0300, Marcelo Tosatti wrote: > > > > > > It is only necessary to raise timer softirq >

Re: kernel/timer: avoid spurious ksoftirqd wakeups

2015-04-07 Thread Frederic Weisbecker
On Mon, Apr 06, 2015 at 08:51:26PM -0300, Marcelo Tosatti wrote: > On Tue, Apr 07, 2015 at 01:34:15AM +0200, Frederic Weisbecker wrote: > > Yeah, it would be nice to make sure that the cause of these softirqs isn't > > mistakenly ignored. > > And also I want to be sure

Re: kernel/timer: avoid spurious ksoftirqd wakeups (v2)

2015-04-07 Thread Frederic Weisbecker
On Tue, Apr 07, 2015 at 11:10:49PM +0200, Thomas Gleixner wrote: > On Mon, 6 Apr 2015, Marcelo Tosatti wrote: > > It is only necessary to raise timer softirq > > in case there are active timers. > > Depends. See below. > > > Limit the ksoftirqd wakeup to that case. > > > > Fixes a latency spike

Re: [PATCH v2 2/2] nohz: make nohz_full imply isolcpus

2015-04-07 Thread Frederic Weisbecker
On Mon, Apr 06, 2015 at 02:16:45PM -0400, cmetc...@ezchip.com wrote: > From: Chris Metcalf > > It's not clear that nohz_full is useful without isolcpus also > set, since otherwise the scheduler has to run periodically to > try to determine whether to steal work from other cores. > > Signed-off-b

Re: [PATCH v5 1/2] smpboot: allow excluding cpus from the smpboot threads

2015-04-08 Thread Frederic Weisbecker
On Mon, Apr 06, 2015 at 03:45:55PM -0400, cmetc...@ezchip.com wrote: > From: Chris Metcalf > > This change allows some cores to be excluded from running the > smp_hotplug_thread tasks. The motivating example for this is > the watchdog threads, which by default we don't want to run > on any enabl

Re: [PATCH v5 2/2] watchdog: add watchdog_exclude sysctl to assist nohz

2015-04-08 Thread Frederic Weisbecker
On Mon, Apr 06, 2015 at 03:45:56PM -0400, cmetc...@ezchip.com wrote: > From: Chris Metcalf > > Change the default behavior of watchdog so it only runs on the > housekeeping cores when nohz_full is enabled at build and boot time. > > Allow modifying the set of cores the watchdog is currently runn

Re: [PATCH v2 2/2] nohz: make nohz_full imply isolcpus

2015-04-08 Thread Frederic Weisbecker
On Wed, Apr 08, 2015 at 11:21:56AM -0400, Chris Metcalf wrote: > On 04/08/2015 10:26 AM, Peter Zijlstra wrote: > >On Wed, Apr 08, 2015 at 10:04:43AM -0400, Chris Metcalf wrote: > >>On 04/08/2015 05:41 AM, Peter Zijlstra wrote: > >>>On Mon, Apr 06, 2015 at 02:16:45PM -0400, cmetc...@ezchip.com wrote

Re: [PATCH v5 1/2] smpboot: allow excluding cpus from the smpboot threads

2015-04-08 Thread Frederic Weisbecker
On Wed, Apr 08, 2015 at 10:06:44AM -0400, Chris Metcalf wrote: > On 04/08/2015 09:28 AM, Frederic Weisbecker wrote: > >On Mon, Apr 06, 2015 at 03:45:55PM -0400, cmetc...@ezchip.com wrote: > >>From: Chris Metcalf > >> > >>This change allows some c

Re: [PATCH v10 1/3] smpboot: allow excluding cpus from the smpboot threads

2015-05-01 Thread Frederic Weisbecker
On Thu, Apr 30, 2015 at 03:39:24PM -0400, Chris Metcalf wrote: > This change allows some cores to be excluded from running the > smp_hotplug_thread tasks. The following commit to update > kernel/watchdog.c to use this functionality is the motivating > example, and more information on the motivatio

Re: [PATCH v10 1/3] smpboot: allow excluding cpus from the smpboot threads

2015-05-01 Thread Frederic Weisbecker
On Fri, May 01, 2015 at 03:57:51PM -0400, Chris Metcalf wrote: > On 05/01/2015 04:53 AM, Frederic Weisbecker wrote: > >>+ /* Unpark any threads that were voluntarily parked. */ > >>+ for_each_cpu_not(cpu, &ht->cpumask) { > >>+ if (cpu_online(c

[PATCH 3/4] nohz: Add tick_nohz_full_add_cpus_to() API

2015-04-21 Thread Frederic Weisbecker
. Wysocki Cc: Martin Schwidefsky Cc: Ingo Molnar Link: http://lkml.kernel.org/r/1429024675-18938-1-git-send-email-cmetc...@ezchip.com Signed-off-by: Frederic Weisbecker --- include/linux/tick.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/linux/tick.h b/include/linux/tick.h

[PATCH 0/4] nohz: A few improvements v2

2015-04-21 Thread Frederic Weisbecker
Metcalf (2): nohz: Add tick_nohz_full_add_cpus_to() API nohz: Set isolcpus when nohz_full is set Frederic Weisbecker (2): context_tracking: Protect against recursion context_tracking: Inherit TIF_NOHZ through forks instead of context switches include/linux/context_

[PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-04-21 Thread Frederic Weisbecker
, and set (or extend) the isolcpus set to include the nohz_full cpus. Acked-by: Frederic Weisbecker Acked-by: Mike Galbraith Acked-by: Rik van Riel Acked-by: Peter Zijlstra (Intel) Signed-off-by: Chris Metcalf Cc: Peter Zijlstra (Intel) Cc: Paul E. McKenney Cc: Rafael J. Wysocki Cc: Martin

[PATCH 2/4] context_tracking: Inherit TIF_NOHZ through forks instead of context switches

2015-04-21 Thread Frederic Weisbecker
Oleg Nesterov Reviewed-by: Rik van Riel Signed-off-by: Frederic Weisbecker Cc: Thomas Gleixner Cc: Peter Zijlstra Cc: Rik van Riel Cc: Paul E. McKenney Cc: Ingo Molnar Cc: Dave Jones Cc: Oleg Nesterov --- include/linux/context_tracking.h | 10 kernel/context_tracking.c

[PATCH 1/4] context_tracking: Protect against recursion

2015-04-21 Thread Frederic Weisbecker
Riel Signed-off-by: Frederic Weisbecker Cc: Thomas Gleixner Cc: Peter Zijlstra Cc: Rik van Riel Cc: Paul E. McKenney Cc: Ingo Molnar Cc: Dave Jones Cc: Oleg Nesterov --- include/linux/context_tracking_state.h | 1 + kernel/context_tracking.c | 30

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-21 Thread Frederic Weisbecker
On Thu, May 21, 2015 at 05:57:59AM -0700, Paul E. McKenney wrote: > On Thu, May 21, 2015 at 05:42:46PM +0530, Afzal Mohammed wrote: > > Hi, > > > > On Wed, May 20, 2015 at 02:00:26PM -0700, Paul E. McKenney wrote: > > > > > > > Given that kernel initiated association to isolcpus, a user turning >

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-21 Thread Frederic Weisbecker
On Thu, May 21, 2015 at 07:14:09AM -0700, Paul E. McKenney wrote: > On Thu, May 21, 2015 at 06:59:05PM +0530, Afzal Mohammed wrote: > > Hi, > > > > On Thu, May 21, 2015 at 03:06:23PM +0200, Frederic Weisbecker wrote: > > > On Thu, May 21, 2015 at 05:57:59AM

Re: [PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-22 Thread Frederic Weisbecker
On Thu, May 21, 2015 at 08:59:38PM +0200, Mike Galbraith wrote: > I think it's a mistake to make any rash assumption and/or mandate that > the user WILL use nohz_full CPUs immediately, or even at all for that > matter. nohz_full currently is nothing but a CPU attribute, period, > nothing more, not

[PATCH 3/4] nohz: Add tick_nohz_full_add_cpus_to() API

2015-05-06 Thread Frederic Weisbecker
. Wysocki Cc: Martin Schwidefsky Cc: Ingo Molnar Link: http://lkml.kernel.org/r/1429024675-18938-1-git-send-email-cmetc...@ezchip.com Signed-off-by: Frederic Weisbecker --- include/linux/tick.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/linux/tick.h b/include/linux/tick.h

[GIT PULL] nohz: A few improvements v4

2015-05-06 Thread Frederic Weisbecker
: Add tick_nohz_full_add_cpus_to() API nohz: Set isolcpus when nohz_full is set Frederic Weisbecker (2): context_tracking: Protect against recursion context_tracking: Inherit TIF_NOHZ through forks instead of context switches include/linux/context_tracking.h | 10 - include/

[PATCH 1/4] context_tracking: Protect against recursion

2015-05-06 Thread Frederic Weisbecker
Riel Acked-by: Peter Zijlstra (Intel) Signed-off-by: Frederic Weisbecker Cc: Thomas Gleixner Cc: Peter Zijlstra Cc: Rik van Riel Cc: Paul E. McKenney Cc: Ingo Molnar Cc: Dave Jones Cc: Oleg Nesterov --- include/linux/context_tracking_state.h | 1 + kernel/context_tracking.c

[PATCH 2/4] context_tracking: Inherit TIF_NOHZ through forks instead of context switches

2015-05-06 Thread Frederic Weisbecker
Oleg Nesterov Reviewed-by: Rik van Riel Signed-off-by: Frederic Weisbecker Cc: Thomas Gleixner Cc: Peter Zijlstra Cc: Rik van Riel Cc: Paul E. McKenney Cc: Ingo Molnar Cc: Dave Jones Cc: Oleg Nesterov --- include/linux/context_tracking.h | 10 - include/linux/sched.h

[PATCH 4/4] nohz: Set isolcpus when nohz_full is set

2015-05-06 Thread Frederic Weisbecker
defsky Cc: Mike Galbraith Cc: Ingo Molnar Cc: Rik van Riel Signed-off-by: Frederic Weisbecker --- kernel/sched/core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 6f149f8..e95b4d8 100644 --- a/kernel/sched/core.c +++ b/kernel/sc

Re: question about RCU dynticks_nesting

2015-05-06 Thread Frederic Weisbecker
On Mon, May 04, 2015 at 04:53:16PM -0400, Rik van Riel wrote: > On 05/04/2015 04:38 PM, Paul E. McKenney wrote: > > On Mon, May 04, 2015 at 04:13:50PM -0400, Rik van Riel wrote: > >> On 05/04/2015 04:02 PM, Paul E. McKenney wrote: > > >>> Hmmm... But didn't earlier performance measurements show t

[PATCH 3/7] preempt: Rename PREEMPT_CHECK_OFFSET to PREEMPT_DISABLE_OFFSET

2015-05-11 Thread Frederic Weisbecker
"CHECK" suggests it's only used as a comparison mask. But now it's used further as a config-conditional preempt disabler offset. Lets disambiguate this name. Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Linus Torvalds Signed-off-by: Frederic Weisbecker

[PATCH 6/7] preempt: Fix out of date comment

2015-05-11 Thread Frederic Weisbecker
Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Linus Torvalds Signed-off-by: Frederic Weisbecker --- include/linux/preempt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/preempt.h b/include/linux/preempt.h index 45da394..4057696 100644 --- a

[RFC PATCH 0/7] preempt: A few headers cleanups and preempt_schedule*() optimizations

2015-05-11 Thread Frederic Weisbecker
-dynticks.git sched/preempt HEAD: c8bda0e6afc163e7e2804d30b9e4301652dc679c Thanks, Frederic --- Frederic Weisbecker (7): preempt: Merge preempt_mask.h into preempt.h preempt: Rearrange a few symbols after headers merge preempt: Rename PREEMPT_CHECK_OFFSET to

[PATCH 2/7] preempt: Rearrange a few symbols after headers merge

2015-05-11 Thread Frederic Weisbecker
Adjust a few comments, and further integrate a few definitions after the dumb headers copy. Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Linus Torvalds Signed-off-by: Frederic Weisbecker --- include/linux/preempt.h | 34 +++--- 1 file changed, 15

[PATCH 4/7] preempt: Disable preemption from preempt_schedule*() callers

2015-05-11 Thread Frederic Weisbecker
: Thomas Gleixner Cc: Linus Torvalds Signed-off-by: Frederic Weisbecker --- include/linux/preempt.h | 12 kernel/sched/core.c | 20 ++-- 2 files changed, 18 insertions(+), 14 deletions(-) diff --git a/include/linux/preempt.h b/include/linux/preempt.h index 4689ef2

[PATCH 7/7] preempt: Remove PREEMPT_ACTIVE unmasking off in_atomic()

2015-05-11 Thread Frederic Weisbecker
Now that PREEMPT_ACTIVE implies PREEMPT_DISABLE_OFFSET, ignoring PREEMPT_ACTIVE from in_atomic() check isn't useful anymore. Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Linus Torvalds Signed-off-by: Frederic Weisbecker --- include/linux/preempt.h | 2 +- 1 file chang

[PATCH 1/7] preempt: Merge preempt_mask.h into preempt.h

2015-05-11 Thread Frederic Weisbecker
gments are performed in a subsequent patch to ease review. Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Linus Torvalds Signed-off-by: Frederic Weisbecker --- arch/m68k/include/asm/irqflags.h | 3 - include/linux/bottom_half.h | 1 - include/linux/hardirq.h | 2 +- inc

[PATCH 5/7] sched: Pull preemption disablement duty up to __schedule() callers

2015-05-11 Thread Frederic Weisbecker
: Peter Zijlstra Cc: Thomas Gleixner Cc: Linus Torvalds Signed-off-by: Frederic Weisbecker --- kernel/sched/core.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 182127a..b23def2 100644 --- a/kernel/sched/core.c +++ b

Re: [PATCH 0/6] support "dataplane" mode for nohz_full

2015-05-11 Thread Frederic Weisbecker
On Mon, May 11, 2015 at 08:57:59AM -0400, Steven Rostedt wrote: > > NO_HZ_LEAVE_ME_THE_FSCK_ALONE! > > > On Sat, 9 May 2015 09:05:38 +0200 > Ingo Molnar wrote: > > > So I think we should either rename NO_HZ_FULL to NO_HZ_PURE, or keep > > it at NO_HZ_FULL: because the intention of NO_HZ_FULL

Re: [PATCH 5/7] sched: Pull preemption disablement duty up to __schedule() callers

2015-05-11 Thread Frederic Weisbecker
On Mon, May 11, 2015 at 05:52:13PM +0200, Peter Zijlstra wrote: > On Mon, May 11, 2015 at 05:08:22PM +0200, Frederic Weisbecker wrote: > > +++ b/kernel/sched/core.c > > @@ -2723,9 +2723,7 @@ again: > > * - return from syscall or exception to user-space > >

Re: [PATCH 0/6] support "dataplane" mode for nohz_full

2015-05-11 Thread Frederic Weisbecker
On Mon, May 11, 2015 at 10:27:44AM -0700, Andrew Morton wrote: > On Mon, 11 May 2015 10:19:16 -0700 "Paul E. McKenney" > wrote: > > > On Mon, May 11, 2015 at 08:57:59AM -0400, Steven Rostedt wrote: > > > > > > NO_HZ_LEAVE_ME_THE_FSCK_ALONE! > > > > NO_HZ_OVERFLOWING? > > Actually, "NO_HZ" sho

[PATCH 0/6] preempt: A few headers cleanups and preempt_schedule*() optimizations v2

2015-05-12 Thread Frederic Weisbecker
, Frederic --- Frederic Weisbecker (6): preempt: Merge preempt_mask.h into preempt.h preempt: Rearrange a few symbols after headers merge preempt: Rename PREEMPT_CHECK_OFFSET to PREEMPT_DISABLE_OFFSET sched: Optimize preemption operations on __schedule() callers

[PATCH 6/6] preempt: Remove PREEMPT_ACTIVE unmasking off in_atomic()

2015-05-12 Thread Frederic Weisbecker
Now that PREEMPT_ACTIVE implies PREEMPT_DISABLE_OFFSET, ignoring PREEMPT_ACTIVE from in_atomic() check isn't useful anymore. Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Linus Torvalds Signed-off-by: Frederic Weisbecker --- include/linux/preempt.h | 2 +- 1 file chang

[PATCH 4/6] sched: Optimize preemption operations on __schedule() callers

2015-05-12 Thread Frederic Weisbecker
order to optimize preempt_count() operations in a single place. Suggested-by: Linus Torvalds Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Linus Torvalds Signed-off-by: Frederic Weisbecker --- include/linux/preempt.h | 12 kernel/sched/core.c | 29

[PATCH 3/6] preempt: Rename PREEMPT_CHECK_OFFSET to PREEMPT_DISABLE_OFFSET

2015-05-12 Thread Frederic Weisbecker
"CHECK" suggests it's only used as a comparison mask. But now it's used further as a config-conditional preempt disabler offset. Lets disambiguate this name. Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Linus Torvalds Signed-off-by: Frederic Weisbecker

[PATCH 2/6] preempt: Rearrange a few symbols after headers merge

2015-05-12 Thread Frederic Weisbecker
Adjust a few comments, and further integrate a few definitions after the dumb headers copy. Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Linus Torvalds Signed-off-by: Frederic Weisbecker --- include/linux/preempt.h | 34 +++--- 1 file changed, 15

[PATCH 1/6] preempt: Merge preempt_mask.h into preempt.h

2015-05-12 Thread Frederic Weisbecker
gments are performed in a subsequent patch to ease review. Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Linus Torvalds Signed-off-by: Frederic Weisbecker --- arch/m68k/include/asm/irqflags.h | 3 - include/linux/bottom_half.h | 1 - include/linux/hardirq.h | 2 +- inc

[PATCH 5/6] preempt: Fix out of date comment

2015-05-12 Thread Frederic Weisbecker
Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Linus Torvalds Signed-off-by: Frederic Weisbecker --- include/linux/preempt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/preempt.h b/include/linux/preempt.h index 45da394..4057696 100644 --- a

Re: CONFIG_ISOLATION=y (was: [PATCH 0/6] support "dataplane" mode for nohz_full)

2015-05-12 Thread Frederic Weisbecker
On Tue, May 12, 2015 at 02:34:40PM +0200, Ingo Molnar wrote: > > * Peter Zijlstra wrote: > > > On Tue, May 12, 2015 at 11:10:32AM +0200, Ingo Molnar wrote: > > > > > > So I'd vote for Frederic's CONFIG_ISOLATION=y, mostly because this > > > is a high level kernel feature, so it won't conflict

Re: [PATCH tip/core/rcu 15/24] rcu: Directly drive RCU_USER_QS from Kconfig

2015-05-12 Thread Frederic Weisbecker
r. This commit therefore directly drives > the value of RCU_USER_QS via NO_HZ_FULL's "select" statement. > > Reported-by: Ingo Molnar > Signed-off-by: Paul E. McKenney > Cc: Frederic Weisbecker ACK. And we should remove it completely and use NO_HZ_FULL instead. The

Re: [PATCH tip/core/rcu 15/24] rcu: Directly drive RCU_USER_QS from Kconfig

2015-05-13 Thread Frederic Weisbecker
On Wed, May 13, 2015 at 10:45:05AM -0700, Paul E. McKenney wrote: > On Wed, May 13, 2015 at 02:37:52AM +0200, Frederic Weisbecker wrote: > > On Tue, May 12, 2015 at 03:30:45PM -0700, Paul E. McKenney wrote: > > > From: "Paul E. McKenney" > > > > > >

Re: [PATCH 1/4] context_tracking: Protect against recursion

2015-05-07 Thread Frederic Weisbecker
On Thu, May 07, 2015 at 11:58:32AM +0200, Ingo Molnar wrote: > > * Frederic Weisbecker wrote: > > > @@ -75,6 +94,11 @@ void context_tracking_enter(enum ctx_state state) > > WARN_ON_ONCE(!current->mm); > > > > local_irq_save(flags); > >

Re: [PATCH 3/3] context_tracking,x86: remove extraneous irq disable & enable from context tracking on syscall entry

2015-05-07 Thread Frederic Weisbecker
On Thu, May 07, 2015 at 12:48:45PM +0200, Ingo Molnar wrote: > > * Rik van Riel wrote: > > > > If, on the other hand, you're just going to remotely sample the > > > in-memory context, that sounds good. > > > > It's the latter. > > > > If you look at /proc//{stack,syscall,wchan} and other file

Re: [PATCH v5 2/2] watchdog: add watchdog_exclude sysctl to assist nohz

2015-04-08 Thread Frederic Weisbecker
On Wed, Apr 08, 2015 at 03:21:00PM -0400, Chris Metcalf wrote: > On 04/08/2015 10:01 AM, Frederic Weisbecker wrote: > >How about creating smpboot_update_mask_percpu_thread() and handle it from > >smpboot, > >this way future evolutions of smpboot won't overlook th

Re: [PATCH v2 2/2] nohz: make nohz_full imply isolcpus

2015-04-09 Thread Frederic Weisbecker
On Thu, Apr 09, 2015 at 08:02:28AM -0400, Chris Metcalf wrote: > On 4/9/2015 4:29 AM, Peter Zijlstra wrote: > >On Wed, Apr 08, 2015 at 02:12:34PM -0400, Chris Metcalf wrote: > > > >>>But you're doing the reverse! You're setting nohz_full for isolcpus, not > >>>limiting the nohz_full mask to isolcpu

Re: [PATCH] smpboot: allow excluding cpus from the smpboot threads

2015-04-12 Thread Frederic Weisbecker
On Fri, Apr 10, 2015 at 12:33:38PM -0400, Chris Metcalf wrote: > On 04/09/2015 09:58 PM, Frederic Weisbecker wrote: > >On Thu, Apr 09, 2015 at 04:29:01PM -0400, Chris Metcalf wrote: > >>--- a/include/linux/smpboot.h > >>+++ b/include/linux/smpboot.h > >>@@ -27,6

Re: [PATCH] smpboot: allow excluding cpus from the smpboot threads

2015-04-13 Thread Frederic Weisbecker
On Mon, Apr 13, 2015 at 12:06:50PM -0400, Chris Metcalf wrote: > >>The problem with the code you provided, as I see it, is that the cpumask > >>field being kept in the struct smp_hotplug_thread is awkward to > >>initialize while keeping the default that it doesn't have to be mentioned > >>in the in

Re: [GIT PULL] nohz: Enable full dynticks on guest mode

2015-03-16 Thread Frederic Weisbecker
On Tue, Mar 10, 2015 at 03:37:11PM +0100, Frederic Weisbecker wrote: > Ingo, > > Please pull the nohz/guest branch that can be found at: > > git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git > nohz/guest > > This is

Re: [PATCH 3/4] workqueue: Create low-level unbound workqueues cpumask

2015-03-16 Thread Frederic Weisbecker
On Mon, Mar 16, 2015 at 10:12:12AM -0700, Kevin Hilman wrote: > Lai Jiangshan writes: > > > On 03/14/2015 07:49 AM, Kevin Hilman wrote: > >> Lai Jiangshan writes: > >> > >>> From: Frederic Weisbecker > >>> > >>> Create a cpu

[RFC PATCH 05/30] s390: Translate cputime magic constants to macros

2014-11-28 Thread Frederic Weisbecker
: Frederic Weisbecker --- arch/s390/include/asm/cputime.h | 47 + 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/arch/s390/include/asm/cputime.h b/arch/s390/include/asm/cputime.h index f8c1969..820b38a 100644 --- a/arch/s390/include/asm

[RFC PATCH 02/30] time: Introduce jiffies64_to_nsecs()

2014-11-28 Thread Frederic Weisbecker
: Frederic Weisbecker --- include/linux/jiffies.h | 2 ++ kernel/time/time.c | 10 ++ kernel/time/timeconst.bc | 6 ++ 3 files changed, 18 insertions(+) diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h index c367cbd..1161e5c 100644 --- a/include/linux/jiffies.h +++ b

[RFC PATCH 23/30] cputime: Convert irq_time_accounting to use u64_stats_sync

2014-11-28 Thread Frederic Weisbecker
: Tony Luck Cc: Wu Fengguang Signed-off-by: Frederic Weisbecker --- kernel/sched/cputime.c | 24 +--- kernel/sched/sched.h | 47 +-- 2 files changed, 22 insertions(+), 49 deletions(-) diff --git a/kernel/sched/cputime.c b/kernel

[RFC PATCH 15/30] isdn: Convert obsolete cputime type to nsecs

2014-11-28 Thread Frederic Weisbecker
display the nanosec value and stick with that. Cc: Benjamin Herrenschmidt Cc: Heiko Carstens Cc: Ingo Molnar Cc: Martin Schwidefsky Cc: Oleg Nesterov Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Rik van Riel Cc: Thomas Gleixner Cc: Tony Luck Cc: Wu Fengguang Signed-off-by: Frederic

[RFC PATCH 18/30] delaycct: Convert obsolete cputime type to nsecs

2014-11-28 Thread Frederic Weisbecker
Cc: Benjamin Herrenschmidt Cc: Heiko Carstens Cc: Ingo Molnar Cc: Martin Schwidefsky Cc: Oleg Nesterov Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Rik van Riel Cc: Thomas Gleixner Cc: Tony Luck Cc: Wu Fengguang Signed-off-by: Frederic Weisbecker --- kernel/delayacct.c | 10 +- 1

[RFC PATCH 24/30] cputime: Increment kcpustat directly on irqtime account

2014-11-28 Thread Frederic Weisbecker
: Paul Mackerras Cc: Peter Zijlstra Cc: Rik van Riel Cc: Thomas Gleixner Cc: Tony Luck Cc: Wu Fengguang Signed-off-by: Frederic Weisbecker --- kernel/sched/cputime.c | 48 kernel/sched/sched.h | 1 + 2 files changed, 21 insertions(+), 28

[RFC PATCH 20/30] signal: Convert obsolete cputime type to nsecs

2014-11-28 Thread Frederic Weisbecker
Cc: Benjamin Herrenschmidt Cc: Heiko Carstens Cc: Ingo Molnar Cc: Martin Schwidefsky Cc: Oleg Nesterov Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Rik van Riel Cc: Thomas Gleixner Cc: Tony Luck Cc: Wu Fengguang Signed-off-by: Frederic Weisbecker --- kernel/signal.c | 16

[RFC PATCH 11/30] cputime: Special API to return old-typed cputime

2014-11-28 Thread Frederic Weisbecker
: Ingo Molnar Cc: Martin Schwidefsky Cc: Oleg Nesterov Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Rik van Riel Cc: Thomas Gleixner Cc: Tony Luck Cc: Wu Fengguang Signed-off-by: Frederic Weisbecker --- arch/alpha/kernel/osf_sys.c| 2 +- arch/x86/kernel/apm_32.c | 2 +- drivers/isdn

[RFC PATCH 29/30] cputime: Push time to account_guest_time() in nanosecs

2014-11-28 Thread Frederic Weisbecker
Cc: Benjamin Herrenschmidt Cc: Heiko Carstens Cc: Ingo Molnar Cc: Martin Schwidefsky Cc: Oleg Nesterov Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Rik van Riel Cc: Thomas Gleixner Cc: Tony Luck Cc: Wu Fengguang Signed-off-by: Frederic Weisbecker --- kernel/sched/cputime.c | 24

[RFC PATCH 13/30] alpha: Convert obsolete cputime_t to nsecs

2014-11-28 Thread Frederic Weisbecker
Cc: Benjamin Herrenschmidt Cc: Heiko Carstens Cc: Ingo Molnar Cc: Martin Schwidefsky Cc: Oleg Nesterov Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Rik van Riel Cc: Thomas Gleixner Cc: Tony Luck Cc: Wu Fengguang Signed-off-by: Frederic Weisbecker --- arch/alpha/kernel/osf_sys.c | 8

[RFC PATCH 16/30] binfmt: Convert obsolete cputime type to nsecs

2014-11-28 Thread Frederic Weisbecker
Cc: Benjamin Herrenschmidt Cc: Heiko Carstens Cc: Ingo Molnar Cc: Martin Schwidefsky Cc: Oleg Nesterov Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Rik van Riel Cc: Thomas Gleixner Cc: Tony Luck Cc: Wu Fengguang Signed-off-by: Frederic Weisbecker --- fs/binfmt_elf.c| 26

[RFC PATCH 26/30] cputime: Push time to account_user_time() in nanosecs

2014-11-28 Thread Frederic Weisbecker
Cc: Benjamin Herrenschmidt Cc: Heiko Carstens Cc: Ingo Molnar Cc: Martin Schwidefsky Cc: Oleg Nesterov Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Rik van Riel Cc: Thomas Gleixner Cc: Tony Luck Cc: Wu Fengguang Signed-off-by: Frederic Weisbecker --- arch/ia64/kernel/time.c | 5

[RFC PATCH 27/30] cputime: Push time to account_steal_time() in nanosecs

2014-11-28 Thread Frederic Weisbecker
Cc: Benjamin Herrenschmidt Cc: Heiko Carstens Cc: Ingo Molnar Cc: Martin Schwidefsky Cc: Oleg Nesterov Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Rik van Riel Cc: Thomas Gleixner Cc: Tony Luck Cc: Wu Fengguang Signed-off-by: Frederic Weisbecker --- arch/powerpc/kernel/time.c | 2

[RFC PATCH 30/30] cputime: Push time to account_system_time() in nanosecs

2014-11-28 Thread Frederic Weisbecker
Cc: Benjamin Herrenschmidt Cc: Heiko Carstens Cc: Ingo Molnar Cc: Martin Schwidefsky Cc: Oleg Nesterov Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Rik van Riel Cc: Thomas Gleixner Cc: Tony Luck Cc: Wu Fengguang Signed-off-by: Frederic Weisbecker --- arch/ia64/kernel/time.c | 2

<    17   18   19   20   21   22   23   24   25   26   >