On Sat, May 26, 2007 at 05:00:39PM -0700, David Miller wrote:
> From: Grant Grundler <[EMAIL PROTECTED]>
> Date: Sat, 26 May 2007 17:55:15 -0600
>
> > MSI (and MSI-X) vectors are required to be exclusive.
> > I submitted that change to pci.txt last year:
> >
On Sun, May 27, 2007 at 05:01:02AM +0400, Manu Abraham wrote:
> David Miller wrote:
> > True, on sparc64 PCI-E controllers, for example, the MSI vector is
> > received by the PCI-E host controller, and the host controller turns
> > this into a cpu format interrupt packet for the system bus.
>
>
On Sun, May 27, 2007 at 06:03:29PM -0700, Roland Dreier wrote:
...
> > I can imagine many systems where the cpu simply doesn't have enough
> > interrupt pins to uniquely identify every possible MSI interrupt
> > source.
>
> I have a hard time imagining a PCI host bus controller that converts
>
On Sun, Aug 12, 2007 at 10:54:49AM -0400, Mathieu Desnoyers wrote:
> Use the new generic cmpxchg_local (disables interrupt). Also use the generic
> cmpxchg as fallback if SMP is not set.
Mathieu,
thanks for adding __cmpxchg_local to parisc but why do we need it?
By definition, atomic
On Fri, Aug 24, 2007 at 11:02:32AM -0700, [EMAIL PROTECTED] wrote:
>
> On Altix, DMA may be reordered within the NUMA interconnect.
> This can be a problem with Infiniband, where DMA to Completion
> Queues can race with data DMA. This patchset allows a driver
> to associate a memory region
hould be made aware of the other.
Patch+log entry appended below. Please sign-off if that's ok with you.
thanks,
grant
Diff+Commit entry against 2.6.22.5:
local_t is a variant of atomic_t and has related ops to match.
Add reference for local_t documentation to atomic_ops.txt.
Signed-off-by:
he idea, but suggest a small modification. See
> below.
Looks fine to me. Add your "Signed-off-by" and submit to DaveM
since he seems to be the maintainer of atomic_ops.txt.
cheers,
grant
>
> >
> > thanks,
> > grant
> >
> > Diff+Commit entry against
On Sat, Aug 25, 2007 at 07:55:56PM -0600, Matthew Wilcox wrote:
>
> This patch, loosely based on a patch from Robert Hancock, which was in
> turn based on a patch from Jesse Barnes, fixes a boot-time hang on my
> shiny new PC. The 'conflict' mentioned in the patch in my case happens
> to be
On Tue, Aug 28, 2007 at 11:59:08AM -0600, Grant Grundler wrote:
> On Sat, Aug 25, 2007 at 07:55:56PM -0600, Matthew Wilcox wrote:
> >
> > This patch, loosely based on a patch from Robert Hancock, which was in
> > turn based on a patch from Jesse Barnes, fixes a boot-time han
[davem: patch for you at the bottom to Documentation/atomic_ops.txt ]
On Tue, Aug 28, 2007 at 02:38:35PM -0400, Mathieu Desnoyers wrote:
> * Grant Grundler ([EMAIL PROTECTED]) wrote:
> > On Tue, Aug 28, 2007 at 07:50:18AM -0400, Mathieu Desnoyers wrote:
...
> > > So I do
On Wed, Aug 29, 2007 at 08:19:53AM -0400, Mathieu Desnoyers wrote:
> local_t Documentation update 2
>
> Grant Grundler was asking for more detail about correct usage of local atomic
> operations and suggested adding the resulting summary to local_ops.txt.
>
> "Pleas
On Thu, Aug 30, 2007 at 03:46:56PM -0700, Jason Gaston wrote:
> This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's.
>
> Signed-off-by: ?Jason Gaston <[EMAIL PROTECTED]>
>
> --- linux-2.6.23-rc4/arch/i386/pci/irq.c.orig 2007-08-27 18:32:35.0
> -0700
> +++
with your suggestion above.
Patch below adds another "!= NULL".
thanks
grant
Signed-off-by: Grant Grundler <[EMAIL PROTECTED]>
diff --git a/arch/parisc/kernel/smp.c b/arch/parisc/kernel/smp.c
index 04c7e1d..c9ce659 100644
--- a/arch/parisc/kernel/smp.c
+++ b/arch/parisc/kernel/smp.
On Mon, Jul 30, 2007 at 03:31:58PM -0400, Kyle McMartin wrote:
> On Mon, Jul 30, 2007 at 01:04:13PM -0600, Valerie Henson wrote:
> > The Tulip network driver needs a new maintainer! I no longer have
> > time to maintain the Tulip network driver and I'm stepping down. Jeff
> > Garzik would be
On Wed, Aug 08, 2007 at 05:28:46PM -0700, Joe Perches wrote:
> Some uses of printk are missing KERN_ on the second
> and subsequent lines.
Nice! Thanks!
ACK the three parisc-linux bits.
thanks,
grant
>
> For instance:
>
> printk(KERN_INFO "line1: %d\nline2: %d\n", val1, val2);
>
> Line1 is
On Wed, Aug 08, 2007 at 12:56:41AM +0200, Rafael J. Wysocki wrote:
...
> > Apologies, I missed this. I'll look to our new tulip maintainer to
> > queue your resent patch, or at least ACK it...
>
> OK
>
> Below is the updated version. It's functionally equivalent to the previous
> one.
ACK.
On Wed, Aug 01, 2007 at 04:55:00PM +0200, Michal Piotrowski wrote:
> Hi,
>
> Coding style fix
Acked-by: Grant Grundler <[EMAIL PROTECTED]>
thanks,
grant
>
> Regards,
> Michal
>
> --
> LOG
> http://www.stardust.webpages.pl/log/
>
> Signed-o
On Thu, Aug 02, 2007 at 09:43:29AM -0700, Greg KH wrote:
...
> It wasn't just MIPS. IBM has a very popular blade system that has huge
> issues with this, and I think there are some other IBM systems based on
> the same BIOS that also do bad things if we don't grab the USB
> controller away from
[+jejb to cc]
On Tue, Sep 25, 2007 at 04:58:43PM -0700, [EMAIL PROTECTED] wrote:
> This is a followup to http://lkml.org/lkml/2007/8/24/280
>
> Despite Grant's desire for a more elegant solution, there's
> not much new here. I moved the API change from pci.h to
> dma-mapping.h and removed the
On Thu, Sep 27, 2007 at 06:13:02PM -0700, [EMAIL PROTECTED] wrote:
>
> Document dma_flags_set_dmabarrier().
>
> Signed-off-by: Arthur Kepner <[EMAIL PROTECTED]>
This looks really good!
thanks,
grant
Acked-by: Grant Grundler <[EMAIL PROTECTED]>
>
On Wed, Nov 14, 2007 at 07:16:18PM +1100, Benjamin Herrenschmidt wrote:
> > We already have that "something": pci_enable_device().
> > The guest OS "Arch" code can then do the reassignment.
> > See "3.1 Enable the PCI device" in Documentation/pci.txt.
>
> No, that can't be done there because that
On Wed, Oct 24, 2007 at 11:17:40AM +0200, John Sigler wrote:
...
> I've tested with a vanilla 2.6.22.10 kernel (no PREEMPT_RT patch).
> That system also locks up and remains completely unresponsive (I can't open
> new ssh sessions, the system won't answer ICMP echo requests).
>
> How do driver
On Thu, Nov 08, 2007 at 05:24:00PM -0600, Linas Vepstas wrote:
...
> > E.g. 4 port Gige card could directly support the host and 3 guests with
> > somewhat
> > lower risk of tromping on each other's MMIO space.
> >
> > If Xen is cooperative, this seems a bit paranoid. I don't recall ever
> >
On Wed, Nov 14, 2007 at 08:17:33AM +1100, Benjamin Herrenschmidt wrote:
...
> Though he's trying to fix a real issue, his patch is not the right
> approach imho.
>
> A better approach would be to have a mechanism to be triggered by the
> hypervisor administration tools that will attempt to
On Sun, Oct 28, 2007 at 01:03:36PM -0700, Greg KH wrote:
> On Sun, Oct 28, 2007 at 03:53:20PM -0400, Barak Fargoun wrote:
...
> > About your question: today, some of the hypervisors are using linux
> > kernel as their domain-0 (e.g. Xen). In order to implement direct
> > hardware access for these
Ping?
Adding linux-iommu ML.
thanks,
grant
On Tue, Jul 2, 2013 at 9:08 AM, Grant Grundler wrote:
> exynos_sysmmu_set_prefbuf() is not called any where.
>
> Signed-off-by: Grant Grundler
> ---
> drivers/iommu/exynos-iommu.c | 44
>
Hi Marek,
On Tue, Aug 6, 2013 at 6:17 AM, Marek Szyprowski
wrote:
...
> IMHO it is much better to have a simple driver, which binds to a single
> IOMMU controller and leave it to the driver whether to have a same virtual
> address
> space for all parts of FIMC-IS or MFC submodules/memory ports
On Mon, Jul 15, 2013 at 5:20 AM, Cho KyongHo wrote:
...
>> > Cho,
>> > Of the above patches, nearly all have been applied to chromeos-3.8
>> > (kernel-next git tree) by Doug Anderson and others.
>> >
>> > AFAICT, the only ones not applied are:
>> >[v7,3/9] iommu/exynos: fix page table
On Mon, Jul 15, 2013 at 4:21 AM, Cho KyongHo wrote:
...
>> Maybe you could add LV1TABLE_SIZE define and use it here (there is
>> already a LV2TABLE_SIZE define)?
>
> Yes. But, LV2TABLE_SIZE is used in more places than one.
> I do not feel that it is needed to define LV1TABLE_SIZE for the single
On Wed, Aug 14, 2013 at 3:49 AM, Joerg Roedel wrote:
> On Thu, Aug 08, 2013 at 11:28:44AM -0700, Grant Grundler wrote:
>> I can't speak to the previous BUG_ON(). I believe the EADDRESSINUSE
>> failures could be either WARN_ON or BUG_ON. This condition is
>> clearly a bug
On Mon, Jul 29, 2013 at 2:18 AM, Cho KyongHo wrote:
...
>> > @@ -908,7 +916,7 @@ static int lv2set_page(unsigned long *pent,
>> > phys_addr_t paddr, size_t size,
>> > int i;
>> > for (i = 0; i < SPAGES_PER_LPAGE; i++, pent++) {
>> > if
On Wed, Aug 7, 2013 at 5:07 AM, Cho KyongHo wrote:
...
>> I don't understand how this is possible. Can someone explain this
>> better in the IOMMU documentation please?
>
> System MMU is dedicated to a master H/W such as FIMD and FIMC.
Sory - Exynos 5250 documentation I have (confidential
Tomasz,
On Thu, Aug 8, 2013 at 6:54 AM, Tomasz Figa wrote:
...
>> + BUG_ON(lv1ent_section(sent));
>
> Is this condition really a critical one, to the point that the system
> should not continue execution?
>
...
>> if (lv1ent_page(sent)) {
>> - if (*pgcnt != NUM_LV2ENTRIES)
On Tue, Jul 23, 2013 at 4:46 PM, David Miller wrote:
...
> A quick scan shows that smsc75xx, smsc95xx, and ax88179_178a all have
> this problem.
>
> Instead of the patch starting this thread, I'd like to see one that
> hits all three drivers and removes all SG and TSO features bits from
> both
On Tue, Jul 23, 2013 at 7:29 PM, Grant Grundler wrote:
> On Tue, Jul 23, 2013 at 4:46 PM, David Miller wrote:
> ...
>> A quick scan shows that smsc75xx, smsc95xx, and ax88179_178a all have
>> this problem.
>>
>> Instead of the patch starting this thread, I'd li
nmapped area.
>
> Signed-off-by: Cho KyongHo
Tested-by: Grant Grundler
I'm convinced this is a critical fix to apply. Any time we touch the
IOMMU Page Table, we need to flush so the change is immediately
visible to the IOMMU.
thanks,
grant
> ---
> drivers/iommu/exynos-iommu.c |2
On Fri, Jul 26, 2013 at 4:27 AM, Cho KyongHo wrote:
> This prevents allocating lv2 page table for the lv1 page table entry
> that already has 1MB page mapping. In addition some BUG_ON() is
> changed to WARN_ON().
>
> Signed-off-by: Cho KyongHo
Reviewed-by: Grant Grundler
In re
On Fri, Jul 26, 2013 at 4:30 AM, Cho KyongHo wrote:
> Since acquiring read_lock is not more frequent than write_lock, it is
> not beneficial to use rwlock, this commit changes rwlock to spinlock.
>
> Signed-off-by: Cho KyongHo
Reviewed-by: Grant Grundler
cheers,
grant
> ---
&
On Fri, Jul 26, 2013 at 4:29 AM, Cho KyongHo wrote:
> This commit removes custom fault handler. The device drivers that
> need to register fault handler can register
> with iommu_set_fault_handler().
>
> Signed-off-by: Cho KyongHo
Reviewed-by: Grant Grundler
cheers
grant
&
en iommu_domain even though it is already attached to the same
> iommu_domain.
>
> Signed-off-by: Cho KyongHo
Reviewed-by: Grant Grundler
cheers,
grant
> ---
> drivers/iommu/exynos-iommu.c | 13 +++--
> 1 files changed, 7 insertions(+), 6 deletions(-)
>
> diff -
gt; initialized(enabled).
>
> Signed-off-by: Cho KyongHo
Reviewed-by: Grant Grundler
BTW, cscope doesn't find any callers of exynos_sysmmu_enable().
Want to submit another patch to remove it?
(Note I'm talking about exynos_sysmmu_enable() without "__" prefix).
cheers,
grant
On Fri, Jul 26, 2013 at 4:28 AM, Cho KyongHo wrote:
> Signed-off-by: Cho KyongHo
> ---
> .../bindings/iommu/samsung,exynos4210-sysmmu.txt | 103 +++
> arch/arm/boot/dts/exynos4.dtsi | 122
> arch/arm/boot/dts/exynos4210.dtsi | 25 ++
>
with the required quirks in general (lightly tested).
o "parrot" (Acer C7 Chromebook) which uses the SDHCI_QUIRK2_BROKEN_UHS
quirk: disables ADMA mode, and adds a delay after power.
Signed-off-by: Stephen Hurd
Signed-off-by: Grant Grundler
---
drivers/mmc/host/sdhci-
e case that REMOTE_WAKEUP feature doesn't
>> be set when system suspend. In this case, the PHY power will not be turned
>> on again when system resume, so the HW reset must be added in the resume
>> function.
>>
>> Signed-off-by: Freddy Xin
>> Tested-by: Grant G
age entries
> in exynos_iommu_unmap(). Missing cache flush of removed page table
> entries can cause missing page fault interrupt when a master IP
> accesses an unmapped area.
>
> Reviewed-by: Tomasz Figa
> Tested-by: Grant Grundler
> Signed-off-by: Cho KyongHo
> ---
>
On Thu, Mar 13, 2014 at 10:13 PM, Cho KyongHo wrote:
> This commit introduces sysmmu_pte_t for page table entries and
> sysmmu_iova_t vor I/O virtual address that is manipulated by
> exynos-iommu driver. The purpose of the typedef is to remove
> dependencies to the driver code from the change of
On Wed, Mar 19, 2014 at 6:12 AM, Tomasz Figa wrote:
...
> No. Proper Linux drivers must support deferred probing mechanism and there
> should be no assumptions about probing orders. Using other initcall level
> than module_initcall for particular drivers is strongly discouraged.
That's true for
On Wed, Mar 19, 2014 at 6:12 AM, Tomasz Figa wrote:
...
>> Device driver is not only for the scholarship but also for the real use.
>
> Huh? I'm not sure what kind of comment is this.
I'm guessing Cho meant: "This isn't an academic exercise - I have a
real use case that requires reference
On Wed, Mar 19, 2014 at 10:30 AM, Tomasz Figa wrote:
...
> As I said, AFAIK the trend is to get rid of ordering by initcalls and make
> sure that drivers can handle missing dependencies properly, even for
> "services" such as DMA, GPIO, clocks and so on, which after all are provided
> by normal
ttp://coccinelle.lip6.fr/)
>
> //
> @@
> statement S;
> @@
>
> - if (!netdev_priv(...)) S
> //
>
> Signed-off-by: Julia Lawall
Acked-by: Grant Grundler
cheers,
grant
>
> ---
> drivers/net/ethernet/dec/tulip/uli526x.c |6 --
> 1 file changed,
thout holding this
semaphore.
apologies,
grant
On Thu, Sep 26, 2013 at 12:22 PM, Grant Grundler wrote:
> Races between host->areq being NULL or not are resulting in mmcqd
> hung_task panics. Like this one:
>
> <3>[ 240.501202] INFO: task mmcqd/1:85 blocked for more than 120 se
struct mmc_queue defines issue_fn as an indirect function call.
issue_fn field only gets set to mmc_blk_issue_rq and only gets
invoked immediately after calling blk_fetch_request().
Don't bother with indirect function call - it's pointless and just
obfuscates the code.
Signed-off-by: Grant
cscsope says there are no callers for mmc_try_claim_host in the kernel.
No reason to keep it.
Signed-off-by: Grant Grundler
---
drivers/mmc/core/core.c | 25 -
include/linux/mmc/core.h | 1 -
2 files changed, 26 deletions(-)
diff --git a/drivers/mmc/core/core.c b
On Fri, Sep 20, 2013 at 12:35 AM, Ulf Hansson wrote:
> On 20 September 2013 03:21, Grant Grundler wrote:
>> cscsope says there are no callers for mmc_try_claim_host in the kernel.
>> No reason to keep it.
>>
>> Signed-off-by: Grant Grundler
>
> Acked-by: Ulf H
hael Opdenacker
Acked-by: Grant Grundler
thanks,
grant
> ---
> drivers/net/ethernet/dec/tulip/de4x5.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/de4x5.c
> b/drivers/net/ethernet/dec/tulip/de4x5.c
> index 2db6c57
On Mon, Jul 22, 2013 at 10:07 AM, Eric Dumazet wrote:
...
> I guess that if a driver does not advertise NETIF_F_SG, this
> skb_linearize() call is not needed : All frames reaching your xmit
> function should already be linear
As Ben Hutchings pointed out, hw_features is still setting this...but
Replace "data" with a more descriptive name.
Using a local variable (ie a register) makes explicit what the
compiler is doing under the covers anyway: the function is
dereferencing one pointer value the whole time.
Signed-off-by: Grant Grundler
---
drivers/mmc/core/c
Following 7 patches are mostly cleanup with one key patch around host->areq
locking. The host->areq locking problem description is here:
http://www.spinics.net/lists/linux-mmc/msg21644.html
I do believe this preposed host->areq locking patch is a complete fix.
But it appears to fix the
This is an intermediate step to fixing the locking around the
access to host->areq. Reduce the number of "if (saved_areq) vs
"if (areq)" tests in the main code path since I'm going to add
references to "host->lock" in the next patch.
Signed-off-by: Grant Grundle
-by: Grant Grundler
---
drivers/mmc/card/block.c| 8
drivers/mmc/card/mmc_test.c | 4 ++--
drivers/mmc/core/core.c | 23 +++
include/linux/mmc/core.h| 2 +-
4 files changed, 18 insertions(+), 19 deletions(-)
diff --git a/drivers/mmc/card/block.c b/drivers
In case threads "race" to harvest async req completions, just return.
Signed-off-by: Grant Grundler
---
drivers/mmc/core/core.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index deb0ee5..36cfe91 100644
--- a/drivers/mmc/c
Don't replicate how the *error is returned by mmc_start_req().
Signed-off-by: Grant Grundler
---
drivers/mmc/core/core.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index 4d5de98..deb0ee5 100644
--- a/drivers/mmc
numjobs=2 --bs=4k --norandommap \
--ioengine=psync --direct=0 --filename=/dev/mmcblk0p5
I believe the key parameters are "--numjobs=2" (or more) and "randwrite"
workload. Then the completions are happening around the same time as
mmc_start_req() is r
Just making it more obvious 'err' refers to the status of the in flight
request (aka saved_areq) and not the new async request we might start.
Signed-off-by: Grant Grundler
---
drivers/mmc/core/core.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers
Argh...too much wordsmithing...
On Thu, Sep 26, 2013 at 12:22 PM, Grant Grundler wrote:
> Following 7 patches are mostly cleanup with one key patch around host->areq
> locking. The host->areq locking problem description is here:
> http://www.spinics.net/lists/linux-mm
On Wed, Sep 25, 2013 at 7:37 PM, Chris Ball wrote:
> Hi,
>
> On Wed, Sep 25 2013, Chris Ball wrote:
>> Hi,
>>
>> On Fri, Sep 20 2013, Ulf Hansson wrote:
>>> On 19 September 2013 19:20, Grant Grundler wrote:
>>>> struct mmc_queue defines issue_fn a
On Thu, Sep 26, 2013 at 2:56 PM, Grant Grundler wrote:
> On Wed, Sep 25, 2013 at 7:37 PM, Chris Ball wrote:
>> Hi,
>>
>> On Wed, Sep 25 2013, Chris Ball wrote:
>>> Hi,
>>>
>>> On Fri, Sep 20 2013, Ulf Hansson wrote:
>>>> On 19 Septemb
On Thu, May 30, 2013 at 3:27 AM, Yijing Wang wrote:
> Pci_enable_device() will set device power state to D0,
> so it's no need to do it again in tulip_init_one().
>
> Signed-off-by: Yijing Wang
Ack-by: Grant Grundler
thanks!
grant
> ---
> drivers/net/ethernet/dec/tulip/t
; Signed-off-by: Peter Huewe
LGTM
Reviewed-by: Grant Grundler
thanks,
grant
> ---
> drivers/net/ethernet/dec/tulip/xircom_cb.c | 14 +-
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/xircom_cb.c
> b/drivers/net/
Last year Seungwon Jeon (Samsung) fixed a bug in CLKDIV computation.
But when debugging a related issue (http://crbug.com/221828) I found
the code unreadable. This rewrite simplifies the computation and
explains each step.
Signed-off-by: Grant Grundler
---
Tested on Samsung Series 3 Chromebook
I've attached the test program I wrote to compare the different
flavors of CLKDIV computation: old (3.4 kernel), current upstream, and
my rewrite.
thanks
grant
On Tue, Mar 26, 2013 at 3:50 PM, Grant Grundler wrote:
> Last year Seungwon Jeon (Samsung) fixed a bug in CLKDIV computat
Sorry - please ignore the previous version. Did not include a
copyright (implied to be mine...but it's not) nor license.
Same thing but with proper attribution.
cheers,
grant
On Tue, Mar 26, 2013 at 3:53 PM, Grant Grundler wrote:
> I've attached the test program I wrote to comp
On Wed, Mar 27, 2013 at 5:25 AM, Seungwon Jeon wrote:
> On Wednesday, March 27, 2013, Grant Grundler wrote:
>> Last year Seungwon Jeon (Samsung) fixed a bug in CLKDIV computation.
> For easily identifying, it would be good to point the commit id and subject.
commit id will
On Wed, Mar 27, 2013 at 8:07 AM, Doug Anderson wrote:
> Grant,
>
> Thanks for posting! See below...
thanks for reviewing/feedback! :)
> On Tue, Mar 26, 2013 at 3:50 PM, Grant Grundler wrote:
>> Last year Seungwon Jeon (Samsung) fixed a bug in CLKDIV computation.
>
Hi Chris,
On Wed, Mar 27, 2013 at 10:58 AM, Chris Ball wrote:
> Hi Grant,
...
> Please use the following (standard) syntax in the commit message:
>
> Commit e419990b5e8 ("mmc: dw_mmc: correct the calculation for CLKDIV")
> fixed a bug in CLKDIV computation. [..]
Ok - I didn't know that was
When backporting Commit e419990b5e8 ("mmc: dw_mmc: correct the
calculation for CLKDIV") to 3.4 kernel and debugging
a FW issue, I found the code unreadable. This rewrite simplifies
the computation and explains each step.
Signed-off-by: Grant Grundler
---
V2: rewrote commit msg pe
On Tuesday, December 25, 2012 6:00:01 PM UTC-8, Cho KyongHo wrote:
> This commit adds cache flush for removed small page and large page
> entries in exynos_iommu_unmap(). Missing cache flush of removed
> page table entries can cause missing page fault interrupt when a
> master IP accesses an
-linux-arm (wrong email address - sorry)
On Mon, Jul 1, 2013 at 6:49 PM, Grant Grundler wrote:
> On Tuesday, December 25, 2012 6:00:01 PM UTC-8, Cho KyongHo wrote:
>> This commit adds cache flush for removed small page and large page
>> entries in exynos_iommu_unmap(). Miss
exynos_sysmmu_set_prefbuf() is not called any where.
Signed-off-by: Grant Grundler
---
drivers/iommu/exynos-iommu.c | 44
1 file changed, 44 deletions(-)
diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
index 3f32d64..0740189
Ping?
On Mon, Jul 1, 2013 at 6:49 PM, Grant Grundler wrote:
> On Tuesday, December 25, 2012 6:00:01 PM UTC-8, Cho KyongHo wrote:
>> This commit adds cache flush for removed small page and large page
>> entries in exynos_iommu_unmap(). Missing cache flush of removed
>> p
On Tue, Mar 4, 2014 at 4:01 AM, Hayes Wang wrote:
> Reset and reinitialize the device when the tx timeout occurs.
Hayes,
I believe this patch was dropped after the series was split.
Can you please repost this patch by itself?
(and fix the "function" typo in the patch header)
>
> Signed-off-by:
Hi Ondrej,
On Sat, Jun 21, 2014 at 1:29 PM, Ondrej Zary wrote:
> Poll link status every 2 seconds instead of 60 for ADMtek Comet chips.
Why use 2 seconds for the polling interval?
I'm sure you have a good reason for this and it should be in the
commit message or as a comment in the code.
I
On Wed, May 21, 2014 at 2:32 AM, Arnd Bergmann wrote:
> On Wednesday 21 May 2014 11:02:45 Thierry Reding wrote:
>> On Wed, May 21, 2014 at 10:54:42AM +0200, Arnd Bergmann wrote:
>>
>> > Right. As long as we always unmap the buffers from the IOMMU after they
>> > have stopped being in use, it's
>
> Signed-off-by: Grant Grundler
> Reviewed-by: Douglas Anderson
> Signed-off-by: David S. Miller
> [krzk: Rebase on v4.4]
> Signed-off-by: Krzysztof Kozlowski
thanks krzk!
FTR, to support RTL8153B (HW ID 0x6010), the follow patch series to
bring r8152 v1.09.9 driver from 4.14 ke
On Thu, Apr 26, 2018 at 12:56 AM, Krzysztof Kozlowski wrote:
> On Thu, Apr 26, 2018 at 2:40 AM, Grant Grundler wrote:
>> On Wed, Apr 25, 2018 at 2:54 AM, Krzysztof Kozlowski
>> wrote:
>>>
>>> commit 90841047a01b452cc8c3f9b990698b264143334a upstream
>>>
On Sun, Oct 1, 2017 at 10:39 PM, David Miller wrote:
> From: Grant Grundler
> Date: Thu, 28 Sep 2017 11:35:00 -0700
>
>> This linksys dongle by default comes up in cdc_ether mode.
>> This patch allows r8152 to claim the device:
>>Bus 002 Device 002: ID 13b1:00
This linksys dongle by default comes up in cdc_ether mode.
This patch allows r8152 to claim the device:
Bus 002 Device 002: ID 13b1:0041 Linksys
Signed-off-by: Grant Grundler
---
drivers/net/usb/cdc_ether.c | 10 ++
drivers/net/usb/r8152.c | 2 ++
2 files changed, 12 insertions
This Linksys dongle by default comes up in cdc_ether mode.
This patch allows r8152 to claim the device:
Bus 002 Device 002: ID 13b1:0041 Linksys
Signed-off-by: Grant Grundler
---
drivers/net/usb/r8152.c | 2 ++
1 file changed, 2 insertions(+)
This was tested on chromeos-3.14, chromeos-3.18
On Fri, Jul 14, 2017 at 2:11 AM, Jani Nikula
wrote:
> On Thu, 13 Jul 2017, Stéphane Marchesin wrote:
>> So, if you think this is wrong, can you fix this warning in a way that
>> you'd like?
>
> As I replied previously [1], with more background, fixing the warnings
> properly, in a way that
On Fri, Jul 14, 2017 at 2:35 PM, Daniel Vetter wrote:
> On Fri, Jul 14, 2017 at 7:32 PM, Grant Grundler wrote:
>> On Fri, Jul 14, 2017 at 2:11 AM, Jani Nikula
>> wrote:
>>> On Thu, 13 Jul 2017, Stéphane Marchesin
>>> wrote:
>>>> So, if you
Several error paths in bind/probe code will only emit
output using dev_dbg. But if we are going to fail the
bind/probe, emit related output with "err" priority.
Signed-off-by: Grant Grundler
---
drivers/net/usb/cdc_ncm.c | 10 +-
1 file changed, 5 insertions(+), 5 deletion
ink
...
Chrome OS cannot support RTL8156 until this is fixed.
Signed-off-by: Grant Grundler
---
drivers/net/usb/cdc_ncm.c | 12 +++-
include/linux/usb/usbnet.h | 2 ++
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
in
Errors in protocol should be logged when the driver aborts operations.
If the driver can carry on and "humor" the device, then emitting
the message as debug output level is fine.
Signed-off-by: Grant Grundler
---
drivers/net/usb/usbnet.c | 2 +-
1 file changed, 1 insertion(+),
On Tue, Jan 19, 2021 at 9:46 PM Jakub Kicinski wrote:
>
> On Fri, 15 Jan 2021 21:26:23 -0800 Grant Grundler wrote:
> > RTL8156 sends notifications about every 32ms.
> > Only display/log notifications when something changes.
> >
> > This issue has been repor
On Wed, Jan 20, 2021 at 12:55 AM Grant Grundler wrote:
>
> On Tue, Jan 19, 2021 at 9:46 PM Jakub Kicinski wrote:
> >
> > On Fri, 15 Jan 2021 21:26:23 -0800 Grant Grundler wrote:
> > > RTL8156 sends notifications about every 32ms.
> > > Only display/log
ink
...
Chrome OS cannot support RTL8156 until this is fixed.
Signed-off-by: Grant Grundler
---
drivers/net/usb/cdc_ncm.c | 12 +++-
include/linux/usb/usbnet.h | 2 ++
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
in
On Wed, Jan 20, 2021 at 1:05 AM Jakub Kicinski wrote:
>
> On Wed, 20 Jan 2021 00:59:17 + Grant Grundler wrote:
> > > > Thanks for the patch, this looks like an improvement over:
> > > >
> > > > 59b4a8fa27f5 ("CDC-NCM: remove "connected&q
+nic_swsd [adding per Realtek developer team request]
On Sat, Jan 16, 2021 at 5:26 AM Grant Grundler wrote:
>
> Several error paths in bind/probe code will only emit
> output using dev_dbg. But if we are going to fail the
> bind/probe, emit related output with "err" pr
+nic_swsd [adding per Realtek developer team request]
On Sat, Jan 16, 2021 at 5:27 AM Grant Grundler wrote:
>
> Errors in protocol should be logged when the driver aborts operations.
> If the driver can carry on and "humor" the device, then emitting
> the message as debu
+nic_swsd [adding per Realtek developer team request]
On Sat, Jan 16, 2021 at 5:27 AM Grant Grundler wrote:
>
> RTL8156 sends notifications about every 32ms.
> Only display/log notifications when something changes.
>
> This issue has been reported by others:
> https://
401 - 500 of 626 matches
Mail list logo
