Re: [PATCH 3.17-rc5 ] scripts/sortextable: Suppress warning: ‘relocs_size’ may be used uninitialized

2014-09-18 Thread Jamie Iles
6:3: warning: ‘relocs_size’ may be used uninitialized > in this function [-Wmaybe-uninitialized] >memset(relocs, 0, relocs_size); >^ > scripts/sortextable.h:106:6: note: ‘relocs_size’ was declared here > int relocs_size; > ^ > > gcc 4.9.1 > > Cc: Andrew

[PATCH] hid: Add custom driver for Lenovo ThinkPad Compact Bluetooth Keyboard

2014-03-25 Thread Jamie Lentin
This keyboard requires some custom mappings for all keys to be available, and the Fn-lock toggle needs to be controlled in software. Signed-off-by: Jamie Lentin --- I assume that Linux users want Fn-Lock enabled by default, so they can get at the function keys. If this is an incorrect assumption

Re: [PATCH] hwrng: remove unbuildable picoxcell TRNG

2014-04-15 Thread Jamie Iles
> tree. This means this driver has never been buildable. Let's remove it. > It can be re-added if its dependencies are actually part of the tree. > > Signed-off-by: Paul Bolle I wish I had the bandwidth to get this properly supported, but this seems sensible to me. Acked-b

Re: [PATCH v5 0/4] HID: lenovo: Add support for Lenovo Compact Keyboard

2014-07-26 Thread Jamie Lentin
On Fri, 25 Jul 2014, Antonio Ospite wrote: On Wed, 23 Jul 2014 23:30:44 +0100 Jamie Lentin wrote: This patchset follows on from my previous attempts to add support for these keyboards from Lenovo. Antonio, I've used cptkbd_data and left data_pointer for now. It'd be an easy patch

[PATCH v6 3/4] HID: lenovo: Don't call function in condition, show error codes

2014-07-26 Thread Jamie Lentin
Signed-off-by: Jamie Lentin --- drivers/hid/hid-lenovo.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c index a56b9e7..f96bf09 100644 --- a/drivers/hid/hid-lenovo.c +++ b/drivers/hid/hid-lenovo.c @@ -350,6 +350,7

[PATCH v4 4/4] Add support for Compact (Bluetooth|USB) keyboard with Trackpoint

2014-07-13 Thread Jamie Lentin
Signed-off-by: Jamie Lentin --- Documentation/ABI/testing/sysfs-driver-hid-lenovo | 12 ++ drivers/hid/Kconfig | 2 + drivers/hid/hid-core.c| 2 + drivers/hid/hid-ids.h | 2 + drivers/hid/hid-lenovo.c

[PATCH v4 2/4] Make all base functions switch depending on product ID

2014-07-13 Thread Jamie Lentin
Signed-off-by: Jamie Lentin --- drivers/hid/hid-lenovo.c | 45 ++--- 1 file changed, 38 insertions(+), 7 deletions(-) diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c index 0320b96..d11e337 100644 --- a/drivers/hid/hid-lenovo.c +++ b

[PATCH v4 3/4] Style fixes

2014-07-13 Thread Jamie Lentin
Signed-off-by: Jamie Lentin --- drivers/hid/hid-lenovo.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c index d11e337..a1a693c 100644 --- a/drivers/hid/hid-lenovo.c +++ b/drivers/hid/hid-lenovo.c @@ -349,7 +349,7

[PATCH v4 1/4] Rename hid-lenovo-tpkbd to hid-lenovo

2014-07-13 Thread Jamie Lentin
Rename module and all functions within so we can add support for other keyboards in the same file. Rename the _tp postfix to _tpkbd, to signify functions relevant to the TP USB keyboard. Signed-off-by: Jamie Lentin --- ...er-hid-lenovo-tpkbd => sysfs-driver-hid-lenovo} | 0 drivers/

[PATCH v4 0/4] Add support for Lenovo Compact Keyboard

2014-07-13 Thread Jamie Lentin
Keyboard with Trackpoint. Cheers, Jamie Lentin (4): Rename hid-lenovo-tpkbd to hid-lenovo Make all base functions switch depending on product ID Style fixes Add support for Compact (Bluetooth|USB) keyboard with Trackpoint ...er-hid-lenovo-tpkbd => sysfs-driver-hid-lenovo} | 12 + dr

Can I use DEVICE_INT_ATTR() so that probing and removing sysfs enteries happens automatically?

2014-07-07 Thread Jamie Risk
TR()' macro (for 'device_(show|store)_int()' utility) the attribute appears in sysfs, but accesses cause an OOPs: 'device_show_int()' is called via 'drv_attr_show()' with an inappropriate signature. Whats a correct/corrected approach? - Jamie -- To unsubscribe

Re: [PATCH 08/16] MAINTAINERS: Update picoxcell patterns

2014-07-08 Thread Jamie Iles
Thanks Joe! On Thu, Jul 03, 2014 at 03:07:52PM -0700, Joe Perches wrote: > Fix the picoxcell patterns, add the dts directory too. > > Signed-off-by: Joe Perches > cc: Jamie Iles Acked-by: Jamie Iles Jamie -- To unsubscribe from this list: send the line "unsubscribe linux-ke

[RESEND PATCH] hid: Add custom driver for Lenovo ThinkPad Compact Bluetooth Keyboard

2014-04-17 Thread Jamie Lentin
This keyboard requires some custom mappings for all keys to be available, and the Fn-lock toggle needs to be controlled in software. Signed-off-by: Jamie Lentin --- Apologies for nagging, but anyone got any feedback on this? I don't think there's anything massively contentious, but h

[PATCH v5 3/4] HID: lenovo: Style fixes

2014-07-23 Thread Jamie Lentin
Signed-off-by: Jamie Lentin --- drivers/hid/hid-lenovo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c index a56b9e7..6d55939 100644 --- a/drivers/hid/hid-lenovo.c +++ b/drivers/hid/hid-lenovo.c @@ -350,6 +350,7

[PATCH v5 2/4] HID: lenovo: Prepare support for adding other devices

2014-07-23 Thread Jamie Lentin
Ensure all tpkbd specifics are within a postfixed function, the main functions for the driver should just switch to the appropriate function depending on product ID. Given this, we can add extra devices by including extra postfixed functions. Signed-off-by: Jamie Lentin --- drivers/hid/hid

[PATCH v5 1/4] HID: lenovo: Rename hid-lenovo-tpkbd to hid-lenovo

2014-07-23 Thread Jamie Lentin
Rename module and all functions within so we can add support for other keyboards in the same file. Rename the _tp postfix to _tpkbd, to signify functions relevant to the TP USB keyboard. Signed-off-by: Jamie Lentin --- ...er-hid-lenovo-tpkbd => sysfs-driver-hid-lenovo} | 0 drivers/

[PATCH v5 0/4] HID: lenovo: Add support for Lenovo Compact Keyboard

2014-07-23 Thread Jamie Lentin
ith Bluetooth and USB variants of the Compact Keyboard with Trackpoint. Cheers, Jamie Lentin (4): HID: lenovo: Rename hid-lenovo-tpkbd to hid-lenovo HID: lenovo: Prepare support for adding other devices HID: lenovo: Style fixes HID: lenovo: Add support for Compact (BT|USB) keyboard ...er

[PATCH v5 4/4] HID: lenovo: Add support for Compact (BT|USB) keyboard

2014-07-23 Thread Jamie Lentin
Add support for both ThinkPad Compact Bluetooth Keyboard with TrackPoint and ThinkPad Compact USB Keyboard with TrackPoint. Signed-off-by: Jamie Lentin --- Documentation/ABI/testing/sysfs-driver-hid-lenovo | 12 ++ drivers/hid/Kconfig | 2 + drivers/hid/hid

[PATCH v2 1/2] Loosen seams to allow support of other keyboards

2014-06-10 Thread Jamie Lentin
Signed-off-by: Jamie Lentin --- drivers/hid/hid-lenovo-tpkbd.c | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/drivers/hid/hid-lenovo-tpkbd.c b/drivers/hid/hid-lenovo-tpkbd.c index 2d25b6c..3bec9f5 100644 --- a/drivers/hid/hid-lenovo-tpkbd.c

[PATCH v2 0/2] Add support for Lenovo Compact Keyboard

2014-06-10 Thread Jamie Lentin
I suspect in reality so long as Fn-Lock is left on nobody will really care what the Fn-Lock key does :) Applies and tested against 3.14.5. Cheers, [1] https://lkml.org/lkml/2014/3/25/535 Jamie Lentin (2): Loosen seams to allow support of other keyboards Add support for Compact (Bluetooth|USB

[PATCH v2 2/2] Add support for Compact (Bluetooth|USB) keyboard with Trackpoint

2014-06-10 Thread Jamie Lentin
Signed-off-by: Jamie Lentin --- drivers/hid/hid-core.c | 2 + drivers/hid/hid-ids.h | 2 + drivers/hid/hid-lenovo-tpkbd.c | 203 + include/linux/hid.h| 1 + 4 files changed, 208 insertions(+) diff --git a/drivers/hid/hid

Re: [PATCH v2 2/2] Add support for Compact (Bluetooth|USB) keyboard with Trackpoint

2014-06-12 Thread Jamie Lentin
On Wed, 11 Jun 2014, Antonio Ospite wrote: On Tue, 10 Jun 2014 23:24:54 +0100 Jamie Lentin wrote: Signed-off-by: Jamie Lentin Some minor comments here too. Thankyou for taking the time over both sets! All comments make sense. --- drivers/hid/hid-core.c | 2 + drivers/hid

Re: [PATCH 1/3] gpio: dwapb: drop irq_setup_generic_chip()

2014-03-31 Thread Jamie Iles
On Tue, Mar 25, 2014 at 09:37:50PM +0100, Linus Walleij wrote: > Aha Jamie not even on the original thread. Here. > > On Tue, Mar 25, 2014 at 9:37 PM, Linus Walleij > wrote: > > On Thu, Mar 20, 2014 at 8:55 PM, Sebastian Andrzej Siewior > > wrote: > > > &

Re: [PATCH] hid: Add custom driver for Lenovo ThinkPad Compact Bluetooth Keyboard

2014-05-20 Thread Jamie Lentin
On Tue, 20 May 2014, Jiri Kosina wrote: On Tue, 25 Mar 2014, Jamie Lentin wrote: This keyboard requires some custom mappings for all keys to be available, and the Fn-lock toggle needs to be controlled in software. Signed-off-by: Jamie Lentin --- I assume that Linux users want Fn-Lock

Re: [PATCH v3] gpio: dwapb: use a second irq chip

2014-05-27 Thread Jamie Iles
ntime two users > where one is using edge and the other level. > > Acked-by: Alan Tull > Signed-off-by: Sebastian Andrzej Siewior Acked-by: Jamie Iles -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.o

[PATCH v3 2/2] Add support for Compact (Bluetooth|USB) keyboard with Trackpoint

2014-06-15 Thread Jamie Lentin
Signed-off-by: Jamie Lentin --- drivers/hid/Kconfig | 2 + drivers/hid/hid-core.c | 2 + drivers/hid/hid-ids.h| 2 + drivers/hid/hid-lenovo.c | 202 +++ include/linux/hid.h | 1 + 5 files changed, 209 insertions(+) diff --git a

[PATCH v3 0/2] Add support for Lenovo Compact Keyboard

2014-06-15 Thread Jamie Lentin
USB variants of the Compact Keyboard with Trackpoint, as well as the original Thinkpad USB keyboard (thanks to Alexander Clouter). Cheers, Jamie Lentin (2): Rename hid-lenovo-tpkbd to hid-lenovo, so we can add other keyboards Add support for Compact (Bluetooth|USB) keyboard with Trackpoint dri

[PATCH v3 1/2] Rename hid-lenovo-tpkbd to hid-lenovo, so we can add other keyboards

2014-06-15 Thread Jamie Lentin
Signed-off-by: Jamie Lentin --- drivers/hid/Kconfig | 14 +- drivers/hid/Makefile | 2 +- drivers/hid/hid-core.c | 2 +- drivers/hid/{hid-lenovo-tpkbd.c => hid-lenovo.c} | 233 +-- 4 fi

Re: [PATCH v8] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2013-12-05 Thread Jamie Iles
Hi Alan, One minor comment below, otherwise looks great! Signed-off-by: Jamie Iles Thanks, Jamie On Tue, Dec 03, 2013 at 10:41:16AM -0600, Alan Tull wrote: > diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c > new file mode 100644 > index 000..e6dc61f > -

[PATCH] mm: vmscan: count only dirty pages as congested

2014-10-15 Thread Jamie Liu
they count for nr_dirty. Signed-off-by: Jamie Liu --- mm/vmscan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index dcb4707..ad9cd9f 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -875,7 +875,8 @@ static unsigned long shrink_page_list(struct list

Re: [PATCH] mm: vmscan: count only dirty pages as congested

2014-10-15 Thread Jamie Liu
gestion, and vice versa; which is both counterintuitive and counterproductive. On Wed, Oct 15, 2014 at 1:05 PM, Andrew Morton wrote: > On Wed, 15 Oct 2014 12:58:35 -0700 Jamie Liu wrote: > >> shrink_page_list() counts all pages with a mapping, including clean >> pages, toward nr_

[PATCH 0/2] HID: lenovo: Small fixups for compact keyboards

2014-11-09 Thread Jamie Lentin
is is currently solvable. The first 2 I will sort out once enough free time appears, if you would prefer a single large patchset, feel free to ignore this and wait for a bigger patchset. Many thanks, [0] https://lkml.org/lkml/2014/7/23/702 Jamie Lentin (2): HID: lenovo: Move USB KEY_FILE to 0

[PATCH 2/2] HID: lenovo: Don't set EV_REP to avoid repeating mice buttons

2014-11-09 Thread Jamie Lentin
On the USB keyboard, the VENDOR hotkeys share the same device as the mouse. Setting EV_REP also affects mouse buttons, so leave it off. The bluetooth keyboard still has autorepeating mouse buttons, as it only has one device and is set by the KEYBOARD pages. Signed-off-by: Jamie Lentin

[PATCH 1/2] HID: lenovo: Move USB KEY_FILE to 0x00f9 to prevent scancode clash

2014-11-09 Thread Jamie Lentin
The bluetooth keyboard also generates 0x00fa when the middle button is pressed. Move the made-up report out of the way so we don't trigger KEY_FILE when middle button is pressed Signed-off-by: Jamie Lentin --- drivers/hid/hid-lenovo.c | 12 ++-- 1 file changed, 6 insertions(

v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-04-30 Thread Jamie Heilman
o the crypto layer) For some reason after this commit my system keyring always ends up empty. I use the deb-pkg make target. My kernel config can be found at http://audible.transient.net/~jamie/k/modsign.config-4.6.0-rc5-guest Let me know if you need anything else. -- Jamie He

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Jamie Heilman
32081403f1709a312c302a06035504030c234275696c642074696d65206175746f67656e657261746564206b65726e656c206b6579" X.509: Request for key 'ex:008a32081403f1709a312c302a06035504030c234275696c642074696d65206175746f67656e657261746564206b65726e656c206b6579' err -11 full dmesg at http://audible.transient.net/~jamie/k/modsign.dmesg-debugging -- Jamie Heilman http://audible.transient.net/~jamie/

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Jamie Heilman
Herbert Xu wrote: > On Sat, Apr 30, 2016 at 08:32:48AM +0000, Jamie Heilman wrote: > > I usually build my kernels to require module signatures and use > > automatic signing. As of v4.6-rc1 I'm getting this on boot: > > > > Problem loading in-kernel X.509 certifica

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Jamie Heilman
Tadeusz Struk wrote: > Could you please check if this one fixes the problem for you: > https://patchwork.kernel.org/patch/8766361/ That patch is already present by 4.6-rc5 and the problem still exists, so no, it doesn't. -- Jamie Heilman http://audible.transient.net/~jamie/

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Jamie Heilman
David Howells wrote: > (cc'ing Tadeusz as he did the pkcs1 padding function) > > Jamie Heilman wrote: > > > > > Problem loading in-kernel X.509 certificate (-2) > > > > > > ENOENT? Hmmm... The only place that is generated is in the crypto la

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Jamie Heilman
Tadeusz Struk wrote: > On 05/03/2016 07:26 PM, Jamie Heilman wrote: > >>> Alrighty, presumably relevant bits: > >>> > > > >>> > > X.509: Cert Issuer: Build time autogenerated kernel key > >>> > > X.509: Cert Subject: Bu

[PATCH] thunderbolt: Add missing blank lines after declarations

2014-12-03 Thread Jamie Lawler
Hi, I've attached a patch that fixes the lack of blank lines after 9 declarations within drivers/thunderbolt/ctl.c. ctl.c now passes checkpatch.pl Regards, Jamie Lawler Signed-off-by: Jamie Lawler --- drivers/thunderbolt/ctl.c | 9 + 1 file changed, 9 insertions(+) diff --

[PATCH] Staging: octeon: Added several blank lines after declarations

2014-12-03 Thread Jamie Lawler
Hi, I've added blank lines after several declarations that were previously missing them, reducing the number of warnings from checkpatch.pl. Regards, Jamie Lawler Signed-off-by: Jamie Lawler --- drivers/staging/octeon/ethernet-rx.c | 4 drivers/staging/octeon/ethernet-tx.c

Re: [PATCH] Staging: octeon: Added several blank lines after declarations

2014-12-03 Thread Jamie Lawler
Thanks Aaro, I will do that now. Jamie On 3 December 2014 at 22:13, Aaro Koskinen wrote: > Hi, > > On Wed, Dec 03, 2014 at 09:43:51PM +0000, Jamie Lawler wrote: >> --- a/drivers/staging/octeon/ethernet-rx.c >> +++ b/drivers/staging/octeon/ethernet-rx.c >> @

[PATCH] Staging: octeon: Added blank lines after declarations

2014-12-03 Thread Jamie Lawler
Hi, There are 2 missing blank lines after declarations in octeon/ethernet-rx.c. I have added them per the coding style. Regards, Jamie Lawler Signed-off-by: Jamie Lawler --- drivers/staging/octeon/ethernet-rx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/octeon

regression bisected; KVM: entry failed, hardware error 0x80000021

2014-12-21 Thread Jamie Heilman
in so far that I can run kvm again without the aforementioned error, but I haven't tested it thoroughly beyond that. Let me know if you need more information or testing. -- Jamie Heilman http://audible.transient.net/~jamie/ -- To unsubscribe from this list: send the line

Re: regression bisected; KVM: entry failed, hardware error 0x80000021

2014-12-22 Thread Jamie Heilman
Chen, Tiejun wrote: > On 2014/12/21 20:46, Jamie Heilman wrote: > >With v3.19-rc1 when I run qemu-system-x86_64 -machine pc,accel=kvm I > >get: > > > >KVM: entry failed, hardware error 0x8021 > > Looks some MSR writing issues such a failed entry. > >

Re: regression bisected; KVM: entry failed, hardware error 0x80000021

2014-12-22 Thread Jamie Heilman
Chen, Tiejun wrote: > On 2014/12/23 9:50, Chen, Tiejun wrote: > >On 2014/12/22 17:23, Jamie Heilman wrote: > >>Chen, Tiejun wrote: > >>>On 2014/12/21 20:46, Jamie Heilman wrote: > >>>>With v3.19-rc1 when I run qemu-system-x86_64 -machine pc,accel=kv

[PATCH 0/2] HID: lenovo: Extra features for compact keyboards

2014-12-16 Thread Jamie Lentin
Jamie Lentin (2): HID: lenovo: Add sensitivity control to compact keyboards HID: lenovo: Use native middle-button mode for compact keyboards drivers/hid/hid-lenovo.c | 79 +++- 1 file changed, 78 insertions(+), 1 deletion(-) -- 2.1.3 -- To

[PATCH 1/2] HID: lenovo: Add sensitivity control to compact keyboards

2014-12-16 Thread Jamie Lentin
The trackpoint sensitivity can also be controlled, expose this via sysfs. Signed-off-by: Jamie Lentin --- drivers/hid/hid-lenovo.c | 42 +- 1 file changed, 41 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c

[PATCH 2/2] HID: lenovo: Use native middle-button mode for compact keyboards

2014-12-16 Thread Jamie Lentin
vent comes after the wheel events. Signed-off-by: Jamie Lentin --- drivers/hid/hid-lenovo.c | 37 + 1 file changed, 37 insertions(+) diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c index 0f35a76..c4c3f09 100644 --- a/drivers/hid/hid-lenovo.c +

[PATCH] /arch/microblaze/kernel/entry.S kernel 3.14 Fix crash when calling invalid syscall ID

2015-02-23 Thread Jamie Garside
code, but a glance over the git logs shows this file has not been changed in the past two years, hence this patch should be safe for the most recent kernel version. Thanks, Jamie -- Jamie Garside Department of Computer Science University of York United Kingdom Disclaimer: http://www.york.ac.uk/

[PATCH] Fixed Microblaze syscall error recovery for invalid syscall IDs.

2015-02-23 Thread jamie . garside
From: Jamie Garside This patch fixes two bugs in the Microblaze syscall trap handler when an invalid syscall ID is used. First, the range check on line 351 only checks for syscall IDs greater than __NR_syscalls. A negative syscall ID (either passed to `syscall()` or as returned by

Re: [PATCH 5/7] crypto: picoxcell: check return value of sg_nents_for_len

2015-11-06 Thread Jamie Iles
orentin Acked-by: Jamie Iles thanks for doing this! Jamie -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 0/2] This patch introduces a feature to force gpio-poweroff module

2019-09-30 Thread Jamie Lentin
vicetree/bindings/power/power-controller.txt https://elixir.bootlin.com/linux/latest/source/drivers/mfd/max77620.c#L566 ...maybe that can be added to the devices getting in the way? Cheers, [0] https://elixir.bootlin.com/linux/latest/source/drivers/watchdog/bcm2835_wdt.c#L152 (chosen at random) Andrew -- Jamie Lentin

Re: [PATCH 0/3] crypto: picoxcell - Cleanups removing non-DT code

2017-01-07 Thread Jamie Iles
crypto: picoxcell - Remove spacc_is_compatible() wrapper function > > drivers/crypto/Kconfig| 2 +- > drivers/crypto/picoxcell_crypto.c | 28 +++----- > 2 files changed, 4 insertions(+), 26 deletions(-) Acked-by: Jamie Iles Thanks, Jamie

[PATCH v0 00/10] Convert Netgear WNR854T to devicetree

2016-07-16 Thread Jamie Lentin
ollowing patch: https://github.com/lentinj/linux/commit/d6b7b4695b7dcbf36d0663aea9cb4ecd65a1ada8 ...but this is probably a matter for another thread. Cheers, [0] http://thread.gmane.org/gmane.linux.network/120616/focus=121320 [1] https://github.com/lentinj/linux/commit/a4bceebb08ecdc25a4d49e23f2abad2148

[PATCH v0 07/10] arm: orion5x: Remove old non-DT-based WNR854T support

2016-07-16 Thread Jamie Lentin
Signed-off-by: Jamie Lentin --- arch/arm/mach-orion5x/Makefile| 1 - arch/arm/mach-orion5x/wnr854t-setup.c | 185 -- 2 files changed, 186 deletions(-) delete mode 100644 arch/arm/mach-orion5x/wnr854t-setup.c diff --git a/arch/arm/mach-orion5x/Makefile

[PATCH v0 03/10] arm: orion5x: Add clk support for mv88f5181

2016-07-16 Thread Jamie Lentin
Referring to values in the u-boot port, add support for the mv88f5181 Signed-off-by: Jamie Lentin --- .../devicetree/bindings/clock/mvebu-core-clock.txt | 1 + drivers/clk/mvebu/orion.c | 70 ++ 2 files changed, 71 insertions(+) diff --git a

[PATCH v0 09/10] net: phy: Re-attempt custom DT configuration after configuration

2016-07-16 Thread Jamie Lentin
marvell,reg-init is generally used to apply a custom LED configuration on boot. However this is then blatted in m88e1121_config_aneg when the interface is brought up. Re-apply any custom configuration afterwards, to keep custom LED configuration. Signed-off-by: Jamie Lentin --- drivers/net/phy

[PATCH v0 02/10] arm: orion5x: Add documentation for SoC and board bindings

2016-07-16 Thread Jamie Lentin
Copy the format for kirkwood/dove to orion5x Signed-off-by: Jamie Lentin --- .../bindings/arm/marvell/marvell,orion5x.txt | 23 ++ 1 file changed, 23 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/marvell/marvell,orion5x.txt diff --git a

[PATCH v0 05/10] arm: orion5x: Add DT include for mv88f5181

2016-07-16 Thread Jamie Lentin
Signed-off-by: Jamie Lentin --- .../bindings/arm/marvell/marvell,orion5x.txt | 1 + arch/arm/boot/dts/orion5x-mv88f5181.dtsi | 35 ++ 2 files changed, 36 insertions(+) create mode 100644 arch/arm/boot/dts/orion5x-mv88f5181.dtsi diff --git a/Documentation

[PATCH v0 01/10] arm: orion5x: Add required properties for orion-wdt to DT node

2016-07-16 Thread Jamie Lentin
orion-wdt refuses to start without these properties defined, so lift definitions out of kirkwood/dove.dtsi Signed-off-by: Jamie Lentin --- arch/arm/boot/dts/orion5x.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/orion5x.dtsi b/arch/arm/boot/dts

[PATCH v0 08/10] net: phy: Try looking for a phy-handle property to find the OF node

2016-07-16 Thread Jamie Lentin
If PHY is registered via. a DSA switch, the MDIO bus the phy is on does not exist in devicetree, but there may be a reference to the PHY node on the physical MDIO bus to use. Signed-off-by: Jamie Lentin --- drivers/net/phy/marvell.c | 22 -- 1 file changed, 16 insertions

[PATCH v0 04/10] arm: orion5x: Generalise mv88f5181l pinctrl support for 88f5181

2016-07-16 Thread Jamie Lentin
As far as I'm aware the mv88f5181-b1 and mv88f5181l are the same at the pinctrl level, so re-use the definitions for both. Signed-off-by: Jamie Lentin --- .../bindings/pinctrl/marvell,orion-pinctrl.txt | 4 ++-- drivers/pinctrl/mvebu/pinctrl-orion.c

[PATCH v0 06/10] arm: orion5x: Add DT-based support for Netgear WNR854T

2016-07-16 Thread Jamie Lentin
This is a router based on the mv88f5181 chipset. http://www.netgear.com/support/product/WNR854T.aspx http://wiki.openwrt.org/toh/netgear/wnr854t Signed-off-by: Jamie Lentin --- .../bindings/arm/marvell/marvell,orion5x.txt | 1 + arch/arm/boot/dts/Makefile | 1

[PATCH v0 10/10] arm: orion5x: Configure Netgear WNR854T network port LEDs

2016-07-16 Thread Jamie Lentin
The default bootloader leaves the LEDs orange, and the 88E1121R driver applies it's own inappropriate configuration. Configure as per manual, i.e. orange = 100 / green = 1000 / blink = activity Signed-off-by: Jamie Lentin --- arch/arm/boot/dts/orion5x-netgear-wnr854t.dts

Re: [PATCH v0 06/10] arm: orion5x: Add DT-based support for Netgear WNR854T

2016-07-17 Thread Jamie Lentin
On Sat, 16 Jul 2016, Arnd Bergmann wrote: On Saturday, July 16, 2016 3:29:04 PM CEST Jamie Lentin wrote: + +#define WNR854T_PCI_SLOT0_OFFS 7 +#define WNR854T_PCI_SLOT0_IRQ_PIN 4 + +static void __init wnr854t_pci_preinit(void) +{ + int pin; + + /* +* Configure PCI GPIO

Re: [PATCH v0 06/10] arm: orion5x: Add DT-based support for Netgear WNR854T

2016-07-19 Thread Jamie Lentin
On Sun, 17 Jul 2016, Rob Herring wrote: On Sat, Jul 16, 2016 at 03:29:04PM +0100, Jamie Lentin wrote: This is a router based on the mv88f5181 chipset. http://www.netgear.com/support/product/WNR854T.aspx http://wiki.openwrt.org/toh/netgear/wnr854t Signed-off-by: Jamie Lentin

Re: [PATCH v0 06/10] arm: orion5x: Add DT-based support for Netgear WNR854T

2016-07-19 Thread Jamie Lentin
we already have some Orion5x converted to DT, and that use PCI: board-rd88f5182.c is an example. So we could very well take Jamie patches as-is, and move later to a DT-representation for PCI/PCIe. Ah, I thought all the DT users were moved to mach-mvebu. I agree this new patch isn't introducing

[PATCH] ixgbe: Remove out-of-tree references

2016-11-07 Thread Jamie Bainbridge
The module parameters FdirMode, FdirPballoc, AtrSampleRate, or Node are not available in the in-kernel driver, only in Intel's out-of-tree SourceForge driver. Remove these from the kernel documentation. Remove reference to Intel affinity script. Move max_vfs to tidy up. Signed-off-by:

[PATCH] signal: protect SIGNAL_UNKILLABLE from unintentional clearing.

2016-11-16 Thread Jamie Iles
pond to future SIGSTOP signals rather than ignoring them. Instead of direct assignment to struct signal_struct::flags, provide accessors that protect SIGNAL_UNKILLABLE. Cc: Alexander Viro Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Andrew Morton Cc: Oleg Nesterov Signed-off-by: Jamie Iles ---

Re: [PATCH] signal: protect SIGNAL_UNKILLABLE from unintentional clearing.

2016-11-28 Thread Jamie Iles
Hi Oleg, On Thu, Nov 17, 2016 at 08:04:20PM +0100, Oleg Nesterov wrote: > On 11/16, Jamie Iles wrote: > > > > This can result in init becoming stoppable/killable after tracing. For > > example, running: > > > > while true; do kill -STOP 1; done & >

[PATCHv2] signal: protect SIGNAL_UNKILLABLE from unintentional clearing.

2017-01-04 Thread Jamie Iles
pond to future SIGSTOP signals rather than ignoring them. Make sure that when setting SIGNAL_STOP_CONTINUED/SIGNAL_STOP_STOPPED that we don't clear SIGNAL_UNKILLABLE. Cc: Alexander Viro Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Andrew Morton Cc: Oleg Nesterov Signed-off-by: Jamie Iles --

Re: [PATCH] signal: protect SIGNAL_UNKILLABLE from unintentional clearing.

2016-11-29 Thread Jamie Iles
Hi Oleg, On Tue, Nov 29, 2016 at 03:06:00PM +0100, Oleg Nesterov wrote: > Jamie, > > I am really sorry for the huge delay. No problem! > On 11/16, Jamie Iles wrote: > > > > Since 00cd5c37af (ptrace: permit ptracing of /sbin/init) we can now > > trace init

Re: [PATCH] gpio: dwapb: Add support for next generation of X-Gene SoC

2017-02-15 Thread Jamie Iles
Hi Hoan, On Tue, Feb 14, 2017 at 05:22:09PM -0800, Hoan Tran wrote: > Hi Linus, Jamie and all, > > Do you have any comments on this patch? I think that the CONFIG_ACPI ifdef can be removed to clean it up - acpi_match_device() returns NULL for !CONFIG_ACPI. Other than that, looks g

Re: [PATCH] gpio: dwapb: Add support for next generation of X-Gene SoC

2017-02-13 Thread Jamie Iles
; > This patch modifies DW GPIO driver to accommodate the difference > > in a few register addresses. > > > > Signed-off-by: Hoan Tran > > On next iteration please include Jamie Iles, Weike Chen and Sebastian > Andrzej Siewior. > They all provided substantial

Re: [PATCH v2] gpio: dwapb: Add support for next generation of X-Gene SoC

2017-02-17 Thread Jamie Iles
egister addresses. > > Signed-off-by: Hoan Tran Reviewed-by: Jamie Iles

[PATCH 1/3] HID: lenovo: Use constants for axes names

2015-08-11 Thread Jamie Lentin
Signed-off-by: Jamie Lentin --- drivers/hid/hid-lenovo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c index c4c3f09..65df414 100644 --- a/drivers/hid/hid-lenovo.c +++ b/drivers/hid/hid-lenovo.c @@ -117,10 +117,10

[PATCH 0/3] HID: lenovo: Improve wheel emulation

2015-08-11 Thread Jamie Lentin
tab as well as scrolling, for example. This means you can no longer long-middle-click, but I don't think this is likely to upset users as much as the current behaviour. Tested against 4.1.2 with both Bluetooth and USB compact keyboards. Cheers, Jamie Lentin (3): HID: lenovo: Use constant

[PATCH 3/3] HID: lenovo: Hide middle-button press until release

2015-08-11 Thread Jamie Lentin
Don't relay a middle button press to userspace until release, and then only if there was no scroll events inbetween. This is closer to what Xorg's wheel emulation does, and avoids spurious middle-click pastes. Signed-off-by: Jamie Lentin --- drivers/hid/hid-len

[PATCH 2/3] HID: lenovo: Add missing return-value check

2015-08-11 Thread Jamie Lentin
Signed-off-by: Jamie Lentin --- drivers/hid/hid-lenovo.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c index 65df414..265bfe2 100644 --- a/drivers/hid/hid-lenovo.c +++ b/drivers/hid/hid-lenovo.c @@ -178,9 +178,12

Re: [PATCH] drivers: crypto: picoxcell_crypto: Fix potential race condition bug

2020-08-13 Thread Jamie Iles
ich updates engine->stat_irq_thresh, > therefore initialize it before creating the file in probe function. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Madhuparna Bhowmik Acked-by: Jamie Iles Thanks!

Re: [PATCH 10/24] x86/resctrl: Move the schema names into struct resctrl_schema

2020-11-10 Thread Jamie Iles
s->conf_type = resctrl_to_arch_res(r)->conf_type; > > + ret = snprintf(s->name, sizeof(s->name), r->name); > + if (ret >= sizeof(s->name)) { > + kfree(s); > + return -EINVAL; > + } > + How about: + ret = strscpy(s->name, r->name, sizeof(s->name)); + if (ret < 0)) { + kfree(s); + return -EINVAL; + } So that there isn't a non-constant format specifier that'll trip Coverity+friends up later? Thanks, Jamie

Re: [PATCH] kvm: x86/mmu: Fix is_tdp_mmu_check when using PAE

2020-11-11 Thread Jamie Heilman
gt; + * and the root HPA will not have a shadow page associated with it. > + */ > + if (!sp) > + return false; > + > return sp->tdp_mmu_page && sp->root_count; > } > > -- > 2.29.2.222.g5d2a92d10f8-goog > -- Jamie Heilman http://audible.transient.net/~jamie/

Re: [PATCH 00/24] x86/resctrl: Merge the CDP resources

2020-11-13 Thread Jamie Iles
by the end of the series. > > This series is a little rough around the monitors, would a fake > struct resctrl_schema for the monitors simplify things, or be a source > of bugs? > > This series is based on v5.10-rc1, and can be retrieved from: > git://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git > mpam/resctrl_merge_cdp/v1 > > Parts were previously posted as an RFC here: > https://lore.kernel.org/lkml/20200214182947.39194-1-james.mo...@arm.com/ Reviewed-by: Jamie Iles Jamie

null pointer deref in kvm

2020-11-09 Thread Jamie Heilman
you need anything else. -- Jamie Heilman http://audible.transient.net/~jamie/ # # Automatically generated file; DO NOT EDIT. # Linux/x86 5.10.0-rc2 Kernel Configuration # CONFIG_CC_VERSION_TEXT="gcc (Debian 10.2.0-16) 10.2.0" CONFIG_CC_IS_GCC=y CONFIG_GCC_VERSION=1

Re: [PATCH] ARM: dts: picoxcell: drop unused reg-io-width from DW APB GPIO controller

2020-09-18 Thread Jamie Iles
aml: gpio@2: > 'reg-io-width' does not match any of the regexes: > '^gpio-(port|controller)@[0-9a-f]+$', 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski Acked-by: Jamie Iles Thanks!

SIGNAL_UNKILLABLE and init again

2017-04-25 Thread Jamie Iles
gt;signal->flags &= ~SIGNAL_UNKILLABLE; ret = specific_send_sig_info(sig, info, t); spin_unlock_irqrestore(&t->sighand->siglock, flags); make any sense? It does address the issue that I'm seeing, but are there any downsides to doing so? Thanks, Jamie

Re: SIGNAL_UNKILLABLE and init again

2017-04-27 Thread Jamie Iles
On Wed, Apr 26, 2017 at 05:18:58PM +0200, Oleg Nesterov wrote: > Hi Jamie, > > On 04/25, Jamie Iles wrote: > > > > Hi Oleg, > > > > I'm back looking at SIGNAL_UNKILLABLE and debugging child reapers again, > > and the current issue is when running cod

Re: [PATCH] gpio: dwapb: Add wakeup source support

2017-09-12 Thread Jamie Iles
Hi Linus, On Tue, Sep 12, 2017 at 11:47:52AM +0200, Linus Walleij wrote: > Jamie, do you consider yourself maintainer? If not > would someone else using this driver please step up? I don't think I'm best suited to the job - I don't actually have access to the docs for this

[PATCH] signal: don't remove SIGNAL_UNKILLABLE for traced tasks.

2017-05-04 Thread Jamie Iles
fine, but then once debugging has finished, the init process is left killable which is unlikely what the user expects, resulting in either an accidentally killed init or an init that stops reaping zombies. Cc: Andrew Morton Cc: Oleg Nesterov Signed-off-by: Jamie Iles --- kernel/signal.c | 6

Re: [PATCH] signal: don't remove SIGNAL_UNKILLABLE for traced tasks.

2017-05-05 Thread Jamie Iles
is "clear > SIGNAL_UNKILLABLE" logic in force_sig_info() altogether. No problem, I sent the patch to keep it on my own radar :) Jamie

Re: [PATCH] signal: don't remove SIGNAL_UNKILLABLE for traced tasks.

2017-06-08 Thread Jamie Iles
Hi Oleg, On Fri, May 05, 2017 at 06:26:07PM +0200, Oleg Nesterov wrote: > Hi Jamie, > > I am sorry for being slow... yes, probably we should start with this > simple change, and perhaps we do not really need anything else. But > let me think about this till Monday, perhaps we

Re: SIGNAL_UNKILLABLE and init again

2017-08-14 Thread Jamie Iles
Hi Oleg, On Thu, Apr 27, 2017 at 01:16:51PM +0100, Jamie Iles wrote: > On Wed, Apr 26, 2017 at 05:18:58PM +0200, Oleg Nesterov wrote: > > Hi Jamie, > > > > On 04/25, Jamie Iles wrote: > > > > > > Hi Oleg, > > > > > > I'm back

[PATCH] signal: don't remove SIGNAL_UNKILLABLE for traced tasks.

2017-08-15 Thread Jamie Iles
fine, but then once debugging has finished, the init process is left killable which is unlikely what the user expects, resulting in either an accidentally killed init or an init that stops reaping zombies. Cc: Andrew Morton Cc: Oleg Nesterov Signed-off-by: Jamie Iles --- kernel/signal.c | 6

[PATCH v2] drm/udl: Ensure channel is selected before using the device.

2016-08-22 Thread Jamie Lentin
Lift configuration command from udlfb. This appears to be essential for at least a Rextron VCUD-60, without which no URB communication occurs. Signed-off-by: Jamie Lentin --- udl_encoder_commit() is too late to do this set up in it seems. This setup doesn't need to be performed again af

[PATCH] drm/udl: Ensure channel is selected before using the device.

2016-08-14 Thread Jamie Lentin
on Linux 4.7.0 Signed-off-by: Jamie Lentin --- This ended up in udl_connector_init() since the name suggests it has something to do with configuring which output to use, although a quick search through other displaylink drivers didn't shed any light on what the bytes in set_def_chn actually

Re: [PATCH net v2] selftests: forwarding: Avoid false MDB delete/flush failures

2024-09-20 Thread Jamie Bainbridge
On Fri, 20 Sept 2024 at 00:56, Ido Schimmel wrote: > > Hi, > > Thanks for the patch and sorry for the late reply (was OOO). > > On Mon, Sep 16, 2024 at 07:49:05PM +1000, Jamie Bainbridge wrote: > > Running this test on a small system produces different failures every >

<    1   2   3   4   5