Re: [PATCH net-2.6.25 1/8] Create ipv4_is_type(__be32 addr) functions

2007-12-17 Thread Jan Engelhardt
On Dec 13 2007 15:38, Joe Perches wrote: Change IPV4 specific macros LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions ipv4_is_type(__be32 addr) Adds type safety and arguably some readability. Changes since last submission: Removed ipv4_addr_octets function Used

Re: [PATCH] x86_64: fix problems due to use of outb to port 80 on some AMD64x2 laptops, etc.

2007-12-17 Thread Jan Engelhardt
On Dec 14 2007 14:13, H. Peter Anvin wrote: ?? Just initialize bogomips to 6GHz equivalent... and we are fine until 6GHz cpus come out. How long will that take to boot on a 386? Load it up in bochs and have look at the wallclock. I think that is a good estimate when you have no real 386

Re: [PATCH] x86_64: fix problems due to use of outb to port 80 on some AMD64x2 laptops, etc.

2007-12-17 Thread Jan Engelhardt
On Dec 15 2007 17:46, Alan Cox wrote: My understanding is that the linux starts in real mode, and uses the BIOS for such things as reading the very first image. Not always. We may enter from 32bit in some cases, and we may also not have a PC BIOS in the first place. Computers without a

Re: [PATCH net-2.6.25 1/8] Create ipv4_is_type(__be32 addr) functions

2007-12-17 Thread Jan Engelhardt
On Dec 17 2007 14:43, David Miller wrote: On Dec 13 2007 15:38, Joe Perches wrote: +static inline bool ipv4_is_private_10(__be32 addr) +{ + return (addr htonl(0xff00)) == htonl(0x0a00); +} What are these functions needed for, even? There does not seem to be any code (at least

Re: After many hours all outbound connections get stuck in SYN_SENT

2007-12-17 Thread Jan Engelhardt
On Dec 14 2007 15:39, James Nichols wrote: However, after approximately 38 hours of operation, all outbound connection attempts get stuck in the SYN_SENT state. It happens instantaneously, where I go from the baseline of about 60-80 sockets in SYN_SENT to a count of 200 (corresponding to the #

Re: [PATCH 2/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-17 Thread Jan Engelhardt
On Dec 16 2007 18:50, Paul Mundt wrote: On Sun, Dec 16, 2007 at 12:21:21AM +, Adrian McMenamin wrote: +/* GD Rom registers */ +#define GDROM_BASE_REG 0xA05F7000 +#define GDROM_ALTSTATUS_REG GDROM_BASE_REG + 0x18 +#define GDROM_DATA_REG GDROM_BASE_REG + 0x80 +#define GDROM_ERROR_REG

Re: [PATCH] [RFC] be more verbose when probing EDD

2007-12-17 Thread Jan Engelhardt
On Dec 16 2007 20:18, Alan Cox wrote: Why tax other people with a warning/hang etc. in printk when the problem is very unlikely on their systems? I think there is sense in it if you do it subtly differently. printk(.. if this hangs do ... \r); edd_stuff(); printk(

Re: [PATCH] Avoid overflows in kernel/time.c (version 3)

2007-12-17 Thread Jan Engelhardt
On Dec 17 2007 13:53, H. Peter Anvin wrote: index 000..fd46b3d --- /dev/null +++ b/kernel/timeconst.pl Could this live in scripts/ too? (And use CodingStyle?) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH] Avoid overflows in kernel/time.c (version 3)

2007-12-18 Thread Jan Engelhardt
On Dec 17 2007 15:33, H. Peter Anvin wrote: Could this live in scripts/ too? (And use CodingStyle?) Why should it live in scripts/ rather than where it is used? scripts/ is used either for global scripts or scripts which are used manually. Other scripts are not centralized there.

Re: About mounting the sysfs

2007-12-18 Thread Jan Engelhardt
On Dec 18 2007 15:10, wit wrote: 1. What is the d_alloc_root used for? Actually, the question should be: why we have to call d_alloc_root. I think the root already has its dentry, It does not. why we have to allocate another while we mounting a file system? 2. Why we call d_alloc_root to

Do not reset xfsquota flags on quotaless ro mount

2007-12-18 Thread Jan Engelhardt
Hi, In https://bugzilla.novell.com/show_bug.cgi?id=345338 it is claimed that resetting the quota flags in the mounting sequence rw,ro,rw is a bug, but I would say this is not the case, as quota is metadata, and the log is replayed in ro mode even for other filesystems. Yet, it is still not nice,

Re: Do not reset xfsquota flags on quotaless ro mount

2007-12-18 Thread Jan Engelhardt
On Dec 19 2007 01:38, David Chinner wrote: In https://bugzilla.novell.com/show_bug.cgi?id=345338 it is claimed that resetting the quota flags in the mounting sequence rw,ro,rw is a bug, but I would say this is not the case, You mounted without quotas in the middle step, thereby invalidating

Re: After many hours all outbound connections get stuck in SYN_SENT

2007-12-18 Thread Jan Engelhardt
On Dec 18 2007 10:34, James Nichols wrote: It's very challenging for me to upgrade the kernel as this is a production system and I need to run on whatever the latest RedHat supports for support contract reasons. I probably could do it if there are specific fixes that there is reason to believe

Re: After many hours all outbound connections get stuck in SYN_SENT

2007-12-18 Thread Jan Engelhardt
On Dec 18 2007 11:45, James Nichols wrote: Well you could still blame Java. I am sure that if you program was C, the problem could be narrowed down much easier. That may very well be true, but I can't rewrite the whole 500K line application in C at this point. Plus, it's a web app which

Re: After many hours all outbound connections get stuck in SYN_SENT

2007-12-18 Thread Jan Engelhardt
On Dec 18 2007 13:09, James Nichols wrote: Well you could still blame Java. I am sure that if you program was C, the problem could be narrowed down much easier. That may very well be true, but I can't rewrite the whole 500K line application in C at this point. Plus, it's a web app which

Re: After many hours all outbound connections get stuck in SYN_SENT

2007-12-18 Thread Jan Engelhardt
On Dec 18 2007 13:21, James Nichols wrote: Well you could still blame Java. I am sure that if you program was C, the problem could be narrowed down much easier. I'm curious to know how this problem would be easier to narrow down if it were written in C. It depends on the developers

Re: After many hours all outbound connections get stuck in SYN_SENT

2007-12-18 Thread Jan Engelhardt
On Dec 18 2007 21:37, Eric Dumazet wrote: If turning off tcp_sack makes the problem go away, why dont you turn it off all the time ? That would just be workaround. I welcome the efforts to track this; not all users have the time to do so. Disabling tcp_sack also disabled it kernel-wide,

Re: After many hours all outbound connections get stuck in SYN_SENT

2007-12-19 Thread Jan Engelhardt
On Dec 19 2007 12:43, James Nichols wrote: On 12/19/07, Eric Dumazet [EMAIL PROTECTED] wrote: James Nichols a écrit : So you see outgoing SYN packets, but no SYN replies coming from the remote peer ? (you mention ACKS, but the first packet received from the remote peer should be a

RE: ARP Bug?

2007-12-19 Thread Jan Engelhardt
On Dec 19 2007 09:47, Peters, Gordon wrote: Call me crazy, For top-posting, yes. :) but if I have 2 NICs in a system and all the traffic is going through one of them and then that one NIC cable gets pulled, the other NIC, that half of the traffic should have been going through in the first

Re: kobject_add failed for tts/0 (-13)-EACCES

2007-12-19 Thread Jan Engelhardt
On Dec 19 2007 20:25, Jiri Slaby wrote: On 12/18/2007 06:39 AM, ManojKwal wrote: io scheduler cfq registered serial_dtsp_init() serial_dtsp_probe() dtsp_uart.0: tts/0 at MMIO 0x2020 (irq = 2) is a ttyS kobject_add failed for tts/0 (-13) [c001d918] (dump_stack+0x0/0x14) from [c00c9d74]

Re: Trying to convert old modules to newer kernels

2007-12-19 Thread Jan Engelhardt
On Dec 19 2007 15:10, linux-os (Dick Johnson) wrote: I got rid of __init and anything else that I thought could cause the fault, I anticipate the day removing __init causes a breakage, heh. I mean, if all in-tree modules and LDD3 use it, it can't be wrong, can it? plus got rid of all the

Re: Trying to convert old modules to newer kernels

2007-12-19 Thread Jan Engelhardt
On Dec 19 2007 16:10, linux-os (Dick Johnson) wrote: I anticipate the day removing __init causes a breakage, heh. I mean, if all in-tree modules and LDD3 use it, it can't be wrong, can it? plus got rid of all the code! static int32_t startup() I noticed that. Where's your void gone? :-)

Re: [PATCH] Allow Kconfig to set default mmap_min_addr protection

2007-12-19 Thread Jan Engelhardt
On Dec 19 2007 16:59, Eric Paris wrote: +config SECURITY_DEFAULT_MMAP_MIN_ADDR +int Low address space to protect from user allocation Hm, should not this be 'hex'? +depends on SECURITY +default 0 +help -- To unsubscribe from this list: send the line unsubscribe

Re: [RFC] kobject/kset/ktype documentation and example code updated

2007-12-20 Thread Jan Engelhardt
On Dec 19 2007 16:30, Greg KH wrote: See the example module, samples/kobject/kobject-example.c for an implementation of a simple kobject and attributes. Should mention here that if simple types are enough and a callback function is not needed, a module_param() could be used instead. As a kset

Re: After many hours all outbound connections get stuck in SYN_SENT

2007-12-20 Thread Jan Engelhardt
On Dec 20 2007 23:05, Ilpo Järvinen wrote: Given the fact that I've had this problem for so long, over a variety of networking hardware vendors and colo-facilities, this really sounds good to me. It will be challenging for me to justify a kernel core dump, but a simple patch to dump the

Re: Trailing periods in kernel messages

2007-12-21 Thread Jan Engelhardt
On Dec 20 2007 18:15, Andrew Morton wrote: No-period is a kernel idiom, produces perfectly readable output, I have never ever heard of anyone expressing the least concern over a lack of dots at the end of their printks and 91% of kernel code agrees. Let's check out some real-world messages,

Re: Trailing periods in kernel messages

2007-12-21 Thread Jan Engelhardt
On Dec 21 2007 17:56, Herbert Xu wrote: I do not believe opinions are relevant here. Relevant would be cites from respected style guides (Fowlers, Oxford Guide To Style et al.) to show they do not need a full stop. I've not found one, but I am open to references. Well from where I come

Re: Trailing periods in kernel messages

2007-12-21 Thread Jan Engelhardt
On Dec 21 2007 19:41, Herbert Xu wrote: On Fri, Dec 21, 2007 at 11:10:38AM +0100, Jan Engelhardt wrote: [XFS] Initialise current offset in xfs_file_readdir correctly The reason is that it lacks a subject. current offset is your subject. In my school we were taught that current offset

Re: Trying to convert old modules to newer kernels

2007-12-21 Thread Jan Engelhardt
On Dec 21 2007 12:08, James Courtier-Dutton wrote: That being said, I don't think sse and mmx are available in kernel space, so I would have suggested doing all the grunt work in userspace would be better for this persons application so that he could use sse and mmx etc. They are available,

Re: [RFC] USB Kconfig: Declutter USB Kconfig Menu

2007-12-21 Thread Jan Engelhardt
On Dec 21 2007 16:30, Al Boldi wrote: The current USB Kconfig menu is rather cluttered and unorganized. Propose new layout as follows: Yes, this has been done before in a lot of places, and attempts to clean up more menus is always welcome. Try to use 'menuconfig' objects so people can

Re: [PATCH] Allow Kconfig to set default mmap_min_addr protection

2007-12-21 Thread Jan Engelhardt
On Dec 21 2007 15:31, Eric Paris wrote: On Thu, 2007-12-20 at 00:29 +0100, Jan Engelhardt wrote: On Dec 19 2007 16:59, Eric Paris wrote: +config SECURITY_DEFAULT_MMAP_MIN_ADDR +int Low address space to protect from user allocation Hm, should not this be 'hex'? I guess it could

Re: [PATCH] Allow Kconfig to set default mmap_min_addr protection

2007-12-21 Thread Jan Engelhardt
On Dec 21 2007 14:35, Greg KH wrote: I guess it could be, but the input for /proc/sys/vm/mmap_min_addr is base 10 as well sysfs is autobase, i.e. echo 0xb000 /sys/foo will Do The Right Thing. yes but if you cat /proc/sys/vm/mmap_min_addr, it returns in base 10. sysfs should

Re: [PATCH] Allow Kconfig to set default mmap_min_addr protection

2007-12-21 Thread Jan Engelhardt
On Dec 21 2007 22:16, Willy Tarreau wrote: Hi Jan, +config SECURITY_DEFAULT_MMAP_MIN_ADDR +int Low address space to protect from user allocation Hm, should not this be 'hex'? I guess it could be, but the input for /proc/sys/vm/mmap_min_addr is base 10 as well sysfs is

Re: [PATCH] USB Kconfig: Reorganize USB Kconfig Menu

2007-12-23 Thread Jan Engelhardt
On Dec 23 2007 14:49, Al Boldi wrote: --- 23.a/drivers/usb/Kconfig +++ 23.b/drivers/usb/Kconfig @@ -2,8 +2,8 @@ # USB device configuration # -menuconfig USB_SUPPORT - bool USB support +config USB_SUPPORT + bool depends on HAS_IOMEM default y ---help--- With

Re: [PATCH] USB Kconfig: Reorganize USB Kconfig Menu

2007-12-23 Thread Jan Engelhardt
On Dec 23 2007 16:15, Al Boldi wrote: -menuconfig USB_SUPPORT - bool USB support +config USB_SUPPORT + bool depends on HAS_IOMEM default y ---help--- With this patch, is USB_SUPPORT still needed? It is not visible (anymore), always is y and no other options select/depend

Re: [PATCH] USB Kconfig: Reorganize USB Kconfig Menu

2007-12-23 Thread Jan Engelhardt
On Dec 23 2007 16:25, Jan Engelhardt wrote: On Dec 23 2007 16:15, Al Boldi wrote: -menuconfig USB_SUPPORT - bool USB support +config USB_SUPPORT + bool depends on HAS_IOMEM default y ---help--- With this patch, is USB_SUPPORT still needed? It is not visible (anymore), always

Re: Out of tree module using LSM

2007-11-29 Thread Jan Engelhardt
On Nov 29 2007 11:27, Jon Masters wrote: They (virus protection folks) generally think they want to intercept various system calls, such as open() and block until they have performed a scan operation on the file. I explained the mmap issue [...] If open and close was everything, then that would

Re: Out of tree module using LSM

2007-11-29 Thread Jan Engelhardt
On Nov 29 2007 08:47, Greg KH wrote: On Thu, Nov 29, 2007 at 11:36:12AM -0500, Jon Masters wrote: On Wed, 2007-11-28 at 17:07 -0800, Greg KH wrote: The easiest way is as Al described above, just have the userspace program that wrote the file to disk, check it then. But the problem is

Re: [RFC v2] Documentation about unaligned memory access

2007-11-29 Thread Jan Engelhardt
On Nov 29 2007 12:04, Kyle McMartin wrote: For example, if you had 4GB of virtual memory, picture it as an array of bytes, u8 memory[4096 * (1024 * 1024)];/* 4G bytes */ uint8_t memory[4096UL * 1024 * 1024]; Aligned accesses would be accessing this array in this manner,

Re: [PATCH] Reduce stack used by lib/hexdump.c

2007-11-29 Thread Jan Engelhardt
On Nov 29 2007 13:02, Randy Dunlap wrote: @@ -140,13 +140,20 @@ EXPORT_SYMBOL(hex_dump_to_buffer); * Example output using %DUMP_PREFIX_ADDRESS and 4-byte mode: * 88089af0: 73727170 77767574 7b7a7978 7f7e7d7c pqrstuvwxyz{|}~. */ + +#define HEX_LINE_SIZE 200 + void

[PATCH] Fix forgotten module release in xt_CONNMARK and xt_CONNSECMARK

2007-11-29 Thread Jan Engelhardt
, but (incorrectly) forgets to release the L3 conntrack module. Same for xt_CONNSECMARK. Fix is to move the call to acquire the L3 module after the basic constraint checks. Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] --- net/netfilter/xt_CONNMARK.c| 10 +- net/netfilter/xt_CONNSECMARK.c | 10

Re: RFC - organize include/linux/kernel.h, add include/linux/logging.h

2007-11-30 Thread Jan Engelhardt
On Nov 30 2007 10:04, Joe Perches wrote: There are many private logging definitions that could be consolidated in generic way. Things like: #define MY_PRINTK(fmt, arg) print(PFX fmt, ##arg) cheers, Joe While you are at that, PFX should probably be KBUILD_MODNAME, for simplicity. Then

Re: Kernel Development Objective-C

2007-11-30 Thread Jan Engelhardt
On Nov 30 2007 11:20, Xavier Bestel wrote: On Fri, 2007-11-30 at 19:09 +0900, KOSAKI Motohiro wrote: Has Objective-C ever been considered for kernel development? Why not C# instead ? Why not Haskell nor Erlang instead ? :-D I heard of a bash compiler. That would enable development

Re: Kernel 2.6.23.9 + mdadm 2.6.2-2 + Auto rebuild RAID1?

2007-12-01 Thread Jan Engelhardt
On Dec 1 2007 06:19, Justin Piszcz wrote: RAID1, 0.90.03 superblocks (in order to be compatible with LILO, if you use 1.x superblocks with LILO you can't boot) Says who? (Don't use LILO ;-) , and then: /dev/sda1+sdb1 - /dev/md0 - swap /dev/sda2+sdb2 - /dev/md1 - /boot (ext3)

Re: Kernel 2.6.23.9 / P35 Chipset + WD 750GB Drives (reset port)

2007-12-01 Thread Jan Engelhardt
On Dec 1 2007 06:26, Justin Piszcz wrote: I ran the following: dd if=/dev/zero of=/dev/sdc dd if=/dev/zero of=/dev/sdd dd if=/dev/zero of=/dev/sde (as it is always a very good idea to do this with any new disk) Why would you care about what's on the disk? fdisk, mkfs and the day-to-day

Re: Kernel 2.6.23.9 + mdadm 2.6.2-2 + Auto rebuild RAID1?

2007-12-01 Thread Jan Engelhardt
On Dec 1 2007 07:12, Justin Piszcz wrote: On Sat, 1 Dec 2007, Jan Engelhardt wrote: On Dec 1 2007 06:19, Justin Piszcz wrote: RAID1, 0.90.03 superblocks (in order to be compatible with LILO, if you use 1.x superblocks with LILO you can't boot) Says who? (Don't use LILO ;-) I like LILO

Re: Out of tree module using LSM

2007-12-02 Thread Jan Engelhardt
On Dec 2 2007 22:56, Pavel Machek wrote: We probably want to hear related usages as well - what *besides* A/V would be interested? Indexing services? Indexing services would probably benefit much more from a recursive-aware inotify, though that has its own sort of problems to solve first.

Re: cgit for kernel.org

2007-12-03 Thread Jan Engelhardt
On Dec 3 2007 12:04, Peter Stahlir wrote: I suggest setting up cgit for kernel.org cgit is a fast web interface for git. It is located at http://hjemli.net/git/cgit/ I tried it at http://cgit.freedesktop.org/ and it feels much snappier than gitweb. cgit looks so bare. -- To unsubscribe

Re: [PATCH] Avoid overflows in kernel/time.c

2007-12-03 Thread Jan Engelhardt
On Nov 29 2007 19:54, H. Peter Anvin wrote: Arjan van de Ven wrote: Anyway, I don't think compiling bc is hard on anything which has a C compiler. alternative is to just also ship the precomputed values ;-) Oh, come on... it's not like bc is some obscure thing. It's a POSIX

Re: cgit for kernel.org

2007-12-03 Thread Jan Engelhardt
On Dec 3 2007 15:47, Stefan Richter wrote: Jan Engelhardt wrote: On Dec 3 2007 12:04, Peter Stahlir wrote: I suggest setting up cgit for kernel.org cgit is a fast web interface for git. It is located at http://hjemli.net/git/cgit/ I tried it at http://cgit.freedesktop.org/ and it feels much

Re: overdue items in feature-removal-schedule

2007-12-03 Thread Jan Engelhardt
On Dec 3 2007 11:58, Erez Zadok wrote: What: remove EXPORT_SYMBOL(kernel_thread) When: August 2006 One feature (removal of sys_sysctl) is listed for September 2010: are we really able to predict the future with this much accuracy? When, if at all, will those future/overdue features be

Re: [WATCHDOG] HP ProLiant WatchDog driver

2007-12-06 Thread Jan Engelhardt
On Dec 4 2007 19:43, Wim Van Sebroeck wrote: @@ -69,6 +69,8 @@ obj-$(CONFIG_WAFER_WDT) += wafer5823wdt.o obj-$(CONFIG_I6300ESB_WDT) += i6300esb.o obj-$(CONFIG_ITCO_WDT) += iTCO_wdt.o iTCO_vendor_support.o obj-$(CONFIG_IT8712F_WDT) += it8712f_wdt.o +CFLAGS_hpwdt.o += -O

Re: Allow (O=...) from file

2007-12-06 Thread Jan Engelhardt
On Dec 4 2007 21:04, Jay Cliburn wrote: This piece of the top-level Makefile in current git causes an out-of-tree driver Makefile to fail. 101 ifdef O 102 ifeq ($(origin O), command line) 103 KBUILD_OUTPUT := $(O) 104 endif 105 endif Should not it just use the usual boilerplate? kdir

Re: Patch submission question [not in the FAQ]

2007-12-06 Thread Jan Engelhardt
On Dec 5 2007 03:36, Gabriele Gorla wrote: @@ -392,6 +392,8 @@ typedef struct TAG_TW_Passthru unsigned char padding[12]; } TW_Passthru; +#pragma pack() + typedef struct TAG_TW_Device_Extension { u32 base_addr; unsigned long

Re: Kernel 2.6.23.9 + mdadm 2.6.2-2 + Auto rebuild RAID1?

2007-12-06 Thread Jan Engelhardt
On Dec 5 2007 19:29, Nix wrote: On Dec 1 2007 06:19, Justin Piszcz wrote: RAID1, 0.90.03 superblocks (in order to be compatible with LILO, if you use 1.x superblocks with LILO you can't boot) Says who? (Don't use LILO ;-) Well, your kernels must be on a 0.90-superblocked RAID-0 or RAID-1

Re: Kernel 2.6.23.9 + mdadm 2.6.2-2 + Auto rebuild RAID1?

2007-12-07 Thread Jan Engelhardt
On Dec 7 2007 07:30, Nix wrote: On 6 Dec 2007, Jan Engelhardt verbalised: On Dec 5 2007 19:29, Nix wrote: On Dec 1 2007 06:19, Justin Piszcz wrote: RAID1, 0.90.03 superblocks (in order to be compatible with LILO, if you use 1.x superblocks with LILO you can't boot) Says who? (Don't use

netconsole=y and rtl8139=m

2007-11-19 Thread Jan Engelhardt
Hi, I get this during boot: [ 40.821740] netconsole: eth1 doesn't exist, aborting. Given that CONFIG_NETCONSOLE=y and CONFIG_8139TOO=m, I can imagine. Is there a way to get this working without making 8139TOO=y or NETCONSOLE=m? thanks, Jan - To unsubscribe from this list: send the line

Re: netconsole=y and rtl8139=m

2007-11-20 Thread Jan Engelhardt
On Nov 20 2007 02:57, Mike Frysinger wrote: On Nov 20, 2007 2:17 AM, Jan Engelhardt [EMAIL PROTECTED] wrote: I get this during boot: [ 40.821740] netconsole: eth1 doesn't exist, aborting. Given that CONFIG_NETCONSOLE=y and CONFIG_8139TOO=m, I can imagine. Is there a way to get

VIA spurious hang on 2.6.23.1

2007-11-20 Thread Jan Engelhardt
Hi, I've got some semi-embedded device here, a plain consumer-grade x86 with a VIA Nehemiah/Eden C7. After a while it just locks up, but neither is that deterministic nor does it give out kernel messages. CPU Frequency Scaling (which has been known to be a problem with this CPU) is already

Re: mmap dirty limits on 32 bit kernels (Was: [BUG] New Kernel Bugs)

2007-11-21 Thread Jan Engelhardt
On Thu, 15 Nov 2007 13:47:54 -0800 (PST) Linus Torvalds wrote: But quite frankly, I refuse to even care about anything past that. If you have 12G (or heaven forbid, even more) in your machine, and you can't be bothered to just upgrade to a 64-bit CPU, then quite frankly, *I* personally can't

Re: [PATCH 9/9] Clean up open coded inode dirty checks

2007-11-23 Thread Jan Engelhardt
On Nov 23 2007 11:47, Joe Perches wrote: On Fri, 2007-11-23 at 19:16 +0100, Jan Engelhardt wrote: static inline bool xfs_inode_clean(const struct xfs_inode *ip) { if (ip-i_itemp == NULL) return true; if (!(ip-i_itemp-ili_format.ilf_fields XFS_ILOG_ALL) ip

Re: [PATCH 9/9] Clean up open coded inode dirty checks

2007-11-23 Thread Jan Engelhardt
On Nov 23 2007 18:02, Christoph Hellwig wrote: +STATIC_INLINE int xfs_inode_clean(xfs_inode_t *ip) +{ +return (((ip-i_itemp == NULL) || +!(ip-i_itemp-ili_format.ilf_fields XFS_ILOG_ALL)) +(ip-i_update_core == 0)); +} Can we please get rid of this useless

Re: [RFC] Documentation about unaligned memory access

2007-11-23 Thread Jan Engelhardt
On Nov 23 2007 00:15, Daniel Drake wrote: What's the definition of an unaligned access? = Unaligned memory accesses occur when you try to read N bytes of data starting from an address that is not evenly divisible by N (i.e. addr % N != 0). For

Re: can support for rpm-based package building just be dropped?

2007-11-26 Thread Jan Engelhardt
On Nov 26 2007 06:58, Ray Lee wrote: On Nov 26, 2007 12:54 AM, Robert P. J. Day [EMAIL PROTECTED] wrote: on current systems, rpm no longer has build capability and will fail thusly: rpm --target i386 -ta ../kernel-2.6.24rc3g2ffbb837dirty.tar.gz --target: unknown option so it would make

Re: can support for rpm-based package building just be dropped?

2007-11-26 Thread Jan Engelhardt
On Nov 26 2007 10:53, Robert P. J. Day wrote: Only on current machines. You'd break building kernel RPMs on older systems that don't have rpmbuild installed. Those old machines probably do not even run a distro-fabricated gcc that would compile a git head kernel. well, in a nutshell, the

Re: can support for rpm-based package building just be dropped?

2007-11-26 Thread Jan Engelhardt
On Nov 26 2007 11:13, Robert P. J. Day wrote: Only on current machines. You'd break building kernel RPMs on older systems that don't have rpmbuild installed. Those old machines probably do not even run a distro-fabricated gcc that would compile a git head kernel. well, in a nutshell,

Re: git guidance

2007-11-27 Thread Jan Engelhardt
On Nov 27 2007 23:33, Tilman Schmidt wrote: It didn't work too well. The first result was one of maximal embarrassment: I produced a patch that didn't even compile when applied to the official tree. This shouldn't happen with git, right? Well, it did. So now I'm back to keeping a virgin kernel

Re: Out of tree module using LSM

2007-11-28 Thread Jan Engelhardt
On Nov 28 2007 18:22, [EMAIL PROTECTED] wrote: Talpa is modular itself being composed of a set of kernel modules of which not all are loaded simultaneously. Where possible LSM can be used and _no_ messing with syscall table will take place. Unfortunately where another LSM user is present that

Re: Out of tree module using LSM

2007-11-28 Thread Jan Engelhardt
On Nov 28 2007 16:38, Greg KH wrote: And if we are talking about the situation when files are written to in controlled way (i.e. we are not concerned with malware running on the box in question and just want to stop it from passing through mailsewer, etc.), then there's no damn need to play

Re: void* arithmnetic

2007-11-28 Thread Jan Engelhardt
On Nov 29 2007 01:05, J.A. Magallón wrote: Since begin of the ages the build of the nvidia driver says things like this: Explicitly adding -Wpointer-arith to ones own Makefile is like admitting the code might be problematic. :- I think sizeof(void *) == 1 is taken as granted as sizeof(int) =

Re: [PATCH 01/42] Unionfs: filesystems documentation index

2007-12-10 Thread Jan Engelhardt
On Dec 9 2007 21:41, Erez Zadok wrote: Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- Documentation/filesystems/00-INDEX |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) This is not CVS, you are allowed to have multiple files in a changeset :-) Perhaps fold 1-7. -- To unsubscribe

Re: [RFT] Port 0x80 I/O speed

2007-12-12 Thread Jan Engelhardt
On Dec 12 2007 00:31, Rene Herman wrote: Would some people on x86 (both 32 and 64) be kind enough to compile and run the attached program? This is about testing how long I/O port access to port 0x80 takes. It measures in CPU cycles so CPU speed is crucial in reporting. Transmeta TM5800

Re: [RFT] Port 0x80 I/O speed

2007-12-12 Thread Jan Engelhardt
On Dec 13 2007 00:54, Jan Engelhardt wrote: Transmeta TM5800 CPU with nominal frequency 933 MHz, but it has a hardware(!) 'ondemand' governor over the range of frequencies that the user allowed scaling over, irrespective of the software governor. (That is, if the CPU can do 300,533 and 933 MHz

Re: [PATCH 01/42] Unionfs: filesystems documentation index

2007-12-13 Thread Jan Engelhardt
On Dec 13 2007 10:06, Erez Zadok wrote: In message [EMAIL PROTECTED], Jan Engelhardt writes: On Dec 9 2007 21:41, Erez Zadok wrote: Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- Documentation/filesystems/00-INDEX |2 ++ 1 files changed, 2 insertions(+), 0 deletions

Re: ARP Bug?

2007-12-14 Thread Jan Engelhardt
On Dec 14 2007 17:11, Gosney, JeremiX wrote: Subject: ARP Bug? We've noticed the 2.6-based Linux systems in our test lab are experiencing some ARP flux-like symptoms. The systems reply with eth0's hardware address to all ARP requests, If you have the same subnet on multiple interfaces, only

Re: [2.6.24-rc5-mm1] Why CONFIG_BLK_DEV_RAM=m makes \\\#ifdef CONFIG_BLK_DEV_RAM\\\ false?

2007-12-15 Thread Jan Engelhardt
On Dec 14 2007 15:15, Tetsuo Handa wrote: Hello. Randy Dunlap [EMAIL PROTECTED] wrote: I don't think that this is a change from the recent past. Oh, it is my mistake. I found that choosing CONFIG_BLK_DEV_RAM=m makes impossible to pass an initrd image since populate_rootfs() in

Re: [PATCH][RFC] dynamic pipe resizing

2007-12-15 Thread Jan Engelhardt
On Aug 24 2007 10:52, Jens Axboe wrote: Subject: [PATCH][RFC] dynamic pipe resizing Hi, Dabbling around with splice a bit, I added some code to change the size of a pipe. Currently it's hardcoded as 16 pages, with this patch you can shrink (if you wanted) or grow (the likely scenario) if you

Re: [PATCH 1/3] arch/x86: Use offsetof

2007-12-26 Thread Jan Engelhardt
On Dec 26 2007 17:01, H. Peter Anvin wrote: @@ -215,7 +215,9 @@ asmlinkage int sys_vm86old(struct pt_reg ret = -EFAULT; if (tmp) goto out; - memset(info.vm86plus, 0, (int)info.regs32 - (int)info.vm86plus); + memset(info.vm86plus, 0, + offsetof(struct

Re: [patch 00/60] 2.6.23-stable review

2007-12-27 Thread Jan Engelhardt
On Dec 27 2007 11:11, Jan Evert van Grootheest wrote: The subject of the individual patches are in the email thread that is attached to this announcement, so it should be quite simple to get this information by just looking in your mail reader :) Also, it would be hard to do this, unless

Re: [PATCH 1/1] mxser, remove it

2007-12-28 Thread Jan Engelhardt
On Dec 28 2007 11:09, Jiri Slaby wrote: +struct mxser_cardinfo { + unsigned int nports; + char *name; + unsigned int flags; +}; const char *name. Maybe name could also be put at the front to get closer struct packing on 64-bit? +static int mxvar_baud_table[] = { + 0, 50,

Re: [PATCH RESEND] max3100 driver

2007-12-28 Thread Jan Engelhardt
On Dec 28 2007 14:01, [EMAIL PROTECTED] wrote: + + * The initial minor number is 128 to prevent clashes with ttyS: + * mknod /dev/ttyMAX0 c 4 128 + */ [4:128] is taken by ttyS64. Please look into Documentation/devices.txt. +struct max3100_port_s { + struct uart_port port; + struct

Re: kbuild: modules_install regression ? - depmod

2007-12-28 Thread Jan Engelhardt
[Adding jcm to Cc] On Dec 28 2007 16:08, [EMAIL PROTECTED] wrote: i have the same issue, but with 2.6.24-rc6 on a box with 512MB RAM System is openSUSE 10.3 on make modules_install , depmod reproduceably dies with out of memory error when it is ~800MB VSZ and ~350MB RSS this happens on

Re: RFC: permit link(2) to work across --bind mounts ?

2007-12-28 Thread Jan Engelhardt
On Dec 28 2007 18:53, dean gaudet wrote: p.s. in retrospect i probably could have arranged it more like this: mount /dev/md1 $tmpmntpoint mount --bind $tmpmntpoint/var /var mount --bind $tmpmntpoint/home /home umount $tmpmntpoint except i can't easily specify that in fstab... and

Re: RFC: permit link(2) to work across --bind mounts ?

2007-12-28 Thread Jan Engelhardt
On Dec 28 2007 22:02, dean gaudet wrote: i was trying to come up with a userland-only change in mount(8) which would behave like so: # mount --subtree var /dev/md1 /var internally mount does: - mount /dev/md1 /tmpmnt - mount --bind /tmpmnt/var /var - umount /tmpmnt # mount --subtree

Re: kbuild: modules_install regression ? - depmod

2007-12-29 Thread Jan Engelhardt
On Dec 29 2007 14:30, [EMAIL PROTECTED] wrote: On Dec 28 2007 16:08, [EMAIL PROTECTED] wrote: i have the same issue, but with 2.6.24-rc6 on a box with 512MB RAM System is openSUSE 10.3 If you enable CONFIG_DEBUG_INFO, don't be surprised. oh yes, that`s it! apparently

Re: kbuild: modules_install regression ? - depmod

2007-12-29 Thread Jan Engelhardt
On Dec 29 2007 16:51, [EMAIL PROTECTED] wrote: Erm... same system here - $ gzip -cd /proc/config.gz | grep DEBUG_INFO # CONFIG_DEBUG_INFO is not set I think you managed to snafu something during building. mhh - i have kernel-default-2.6.22.13-0.3 kernel (didn`t touch that since online

Re: allmodconfig: udev won`t start due to CONFIG_UNIX=m

2007-12-30 Thread Jan Engelhardt
On Dec 30 2007 21:11, [EMAIL PROTECTED] wrote: i build a kernel with allmodconfig and didn`t get my system to boot with that. after some investigation i found that it was due to udev: udevd[1226]: init_udev_socket: error getting socket: Address family not supported by protocol this was

Re: RAID timeout parameter accessibility request

2007-12-30 Thread Jan Engelhardt
On Dec 30 2007 23:42, Jose de la Mancha wrote: SHORT QUESTION : In a Debian-controlled RAID array, is there a parameter that handles the timeout before a non-responding drive is dropped from the array ? Can this timeout become user-adjustable in a future build ? Not sure about Debian, but

Re: [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support

2007-12-30 Thread Jan Engelhardt
On Dec 31 2007 00:01, Carlos Corbacho wrote: On Monday 24 December 2007 03:06:37 [EMAIL PROTECTED] wrote: From: Alex Dubov [EMAIL PROTECTED] Sony MemoryStick cards are used in many products manufactured by Sony. They are available both as storage and as IO expansion cards. Currently, only

Re: Updated Kernel Hacker's guide to git

2007-12-30 Thread Jan Engelhardt
On Dec 23 2007 06:13, Jeff Garzik wrote: Another year, another update! :) The kernel hacker's guide to git has received some updates: http://linux.yyz.us/git-howto.html It says Don't forget to download tags from time to time. git pull only downloads sha1-indexed object data, and

Re: [PATCH] Force UNIX domain sockets to be built in

2007-12-31 Thread Jan Engelhardt
On Dec 31 2007 16:19, Bodo Eggert wrote: Adrian Bunk wrote: The only advantage I see is that the kernel image you have to flash can be made smaller - with the disadvantage that the running kernel is bigger by more than 10%. If you don't believe me, try it yourself: Build all drivers

Re: [PATCH] Force UNIX domain sockets to be built in

2007-12-31 Thread Jan Engelhardt
On Dec 31 2007 18:43, Patrick Mau wrote: May I ask something that might be obvious for most of the development community: Modules have to be loaded in seperate pages, right ? That seems to be the case, judging from /proc/modules always ending in 000, meaning each module is aligned at 0x1000

Re: semi-regular plea for stable device mapping

2008-01-01 Thread Jan Engelhardt
On Jan 1 2008 10:54, Gene Heskett wrote: BUT! This defeats a fix I've had in my modprobe.conf for over a year now that gave the LVM stuff a stable major device # of 238, and now my LVM major is back to whatever mood the kernel is in, in this particular bootup case to #253. It may now be

Re: [2.6 patch] the scheduled 'time' option removal

2008-01-01 Thread Jan Engelhardt
On Jan 1 2008 15:46, Adrian Bunk wrote: index 20c4c8b..93aac19 100644 --- a/Documentation/feature-removal-schedule.txt +++ b/Documentation/feature-removal-schedule.txt @@ -233,10 +233,2 @@ Who: Jean Delvare [EMAIL PROTECTED] --- - -What: 'time' kernel boot parameter

Re: [2.6 patch] remove CONFIG_EXPERIMENTAL

2008-01-01 Thread Jan Engelhardt
On Jan 1 2008 14:30, Alan Cox wrote: * Adrian Bunk [EMAIL PROTECTED] wrote: This patch removes the EXPERIMENTAL option and all dependencies on EXPERIMENTAL since they are pointless. agreed. CONFIG_BROKEN has real use - but CONFIG_EXPERIMENTAL is pretty pointless in the 90-days kernel

Re: The perfect patch - Posting a patch series (was Re: [PATCH 06/12] pci : Use mutex instead of semaphore in driver core)

2008-01-02 Thread Jan Engelhardt
On Jan 2 2008 12:14, Stefan Richter wrote: There is nothing wrong with a 0/n posting per se. But whenever you write a 0/n posting, ask yourself: - Isn't the information I provide here necessary to keep around by somebody who takes my patch series into his quilt series or into his

Re: [PATCH] Allow Kconfig to set default mmap_min_addr protection

2008-01-02 Thread Jan Engelhardt
On Jan 2 2008 12:09, Eric Paris wrote: So in the end we are all happy with the original patch I sent? No objections at least :) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH] Use __u64 in aligned_u64's definition

2008-01-02 Thread Jan Engelhardt
Hi Linus, please cherrypick 35f2e577e432b28969710bc1fd4d9a4c0875f81b from the git://computergmbh.de/linux repository from the netfilter branch (or use patch below). thanks, Jan == commit 35f2e577e432b28969710bc1fd4d9a4c0875f81b Author: Jan Engelhardt [EMAIL PROTECTED] Date: Wed Jan

Re: [PATCH] Use __u64 in aligned_u64's definition

2008-01-02 Thread Jan Engelhardt
On Jan 2 2008 12:52, Linus Torvalds wrote: On Wed, 2 Jan 2008, Jan Engelhardt wrote: please cherrypick 35f2e577e432b28969710bc1fd4d9a4c0875f81b from the git://computergmbh.de/linux repository from the netfilter branch (or use patch below). Umm. This is missing an explanation of what exactly

Re: [PATCH] Use __u64 in aligned_u64's definition

2008-01-02 Thread Jan Engelhardt
On Jan 2 2008 13:42, Linus Torvalds wrote: On Wed, 2 Jan 2008, Jan Engelhardt wrote: A cleanup. Or perhaps a precautionary change, should unsigned long long ever become something that is not 64-bit. It was intended for 2.6.25 actually. You don't take patches this early, do you? Yeah, no, I

<    1   2   3   4   5   6   7   8   9   10   >