[PATCH 1/4] printk: Remove separate printk_sched buffers and use printk buf instead

2013-11-07 Thread Jan Kara
, or hold the logbuf_lock. By moving things around a little, the console_sem can be released without ever holding the logbuf_lock, and we can safely have printk_sched() use the printk buffer directly. Signed-off-by: Steven Rostedt rost...@goodmis.org Signed-off-by: Jan Kara j...@suse.cz --- kernel/printk

[PATCH 0/4 v6] Avoid softlockups in console_unlock()

2013-11-07 Thread Jan Kara
Hello, This is the next iteration of my printk patchset. Since v5 I've made the limit for printing configurable via kernel parameter and let it default to 0. So unless user sets printk.offload_chars on kernel command line, there will be no difference to current printk behavior. Summary:

[PATCH 2/4] irq_work: Provide a irq work that can be processed on any cpu

2013-11-07 Thread Jan Kara
. Signed-off-by: Jan Kara j...@suse.cz --- include/linux/irq_work.h | 2 ++ kernel/irq_work.c| 41 + 2 files changed, 27 insertions(+), 16 deletions(-) diff --git a/include/linux/irq_work.h b/include/linux/irq_work.h index 66017028dcb3

[PATCH 4/4] printk: Use unbound irq work for printing and waking

2013-11-07 Thread Jan Kara
/ wakeup work thus lowering the latency of printing and better distributing the printing work over cpus. Reviewed-by: Steven Rostedt rost...@goodmis.org Signed-off-by: Jan Kara j...@suse.cz --- kernel/printk/printk.c | 47 ++- 1 file changed, 26

[PATCH 3/4] printk: Defer printing to irq work when we printed too much

2013-11-07 Thread Jan Kara
on high resolution time being available and with interrupts disabled jiffies are not updated. User can tune the value X via printk.offload_chars kernel parameter. Reviewed-by: Steven Rostedt rost...@goodmis.org Signed-off-by: Jan Kara j...@suse.cz --- Documentation/kernel-parameters.txt | 17

Re: [PATCH v2 01/11] rbtree: Fix rbtree_postorder_for_each_entry_safe() iterator

2013-11-07 Thread Jan Kara
-- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/4] irq_work: Provide a irq work that can be processed on any cpu

2013-11-07 Thread Jan Kara
On Thu 07-11-13 23:13:39, Frederic Weisbecker wrote: 2013/11/7 Jan Kara j...@suse.cz: Provide new irq work flag - IRQ_WORK_UNBOUND - meaning that can be processed on any cpu. This flag implies IRQ_WORK_LAZY so that things are simple and we don't have to pick any particular cpu to do

Re: [BUG][ext2] XIP does not work on ext2

2013-11-07 Thread Jan Kara
On Thu 07-11-13 13:50:09, Andiry Xu wrote: On Thu, Nov 7, 2013 at 1:07 PM, Jan Kara j...@suse.cz wrote: On Thu 07-11-13 12:14:13, Andiry Xu wrote: On Wed, Nov 6, 2013 at 1:18 PM, Jan Kara j...@suse.cz wrote: On Tue 05-11-13 17:28:35, Andiry Xu wrote: Do you know the reason why write

Re: [PATCH 2/4] irq_work: Provide a irq work that can be processed on any cpu

2013-11-07 Thread Jan Kara
On Thu 07-11-13 23:23:14, Frederic Weisbecker wrote: On Thu, Nov 07, 2013 at 11:19:04PM +0100, Jan Kara wrote: On Thu 07-11-13 23:13:39, Frederic Weisbecker wrote: But then, who's going to process that work if every CPUs is idle? Have a look into irq_work_queue

Re: [PATCH 3/4] printk: Defer printing to irq work when we printed too much

2013-11-07 Thread Jan Kara
On Thu 07-11-13 23:43:52, Frederic Weisbecker wrote: 2013/11/7 Jan Kara j...@suse.cz: A CPU can be caught in console_unlock() for a long time (tens of seconds are reported by our customers) when other CPUs are using printk heavily and serial console makes printing slow. Despite serial

Re: [PATCH 2/4] irq_work: Provide a irq work that can be processed on any cpu

2013-11-07 Thread Jan Kara
On Thu 07-11-13 23:54:10, Frederic Weisbecker wrote: On Thu, Nov 07, 2013 at 11:50:34PM +0100, Jan Kara wrote: On Thu 07-11-13 23:23:14, Frederic Weisbecker wrote: On Thu, Nov 07, 2013 at 11:19:04PM +0100, Jan Kara wrote: On Thu 07-11-13 23:13:39, Frederic Weisbecker wrote

Re: [PATCH v2] ext4: Fix reading of extended tv_sec (bug 23732)

2013-11-07 Thread Jan Kara
On Thu 07-11-13 17:54:24, David Turner wrote: On Thu, 2013-11-07 at 17:03 +0100, Jan Kara wrote: So I'm somewhat wondering: Previously we decoded tv_nsec regardless of tv_sec size. After your patch we do it only if sizeof(time-tv_sec) 4. Is this an intended change? Why is it OK

Re: [PATCH 2/4] irq_work: Provide a irq work that can be processed on any cpu

2013-11-08 Thread Jan Kara
On Thu 07-11-13 18:31:42, Steven Rostedt wrote: On Fri, 8 Nov 2013 00:01:11 +0100 Jan Kara j...@suse.cz wrote: On Thu 07-11-13 23:54:10, Frederic Weisbecker wrote: So if the current CPU can handle it, what is the problem? I hope this gets cleared out in my other email. But to make

Re: [PATCH 3/4] printk: Defer printing to irq work when we printed too much

2013-11-08 Thread Jan Kara
that safely. So, you're right after all. Yeah, we've been there (that was actually my initial proposal). But Andrew and Steven (rightfully) objected and suggested irq_work should be used instead. Honza -- Jan Kara j...@suse.cz SUSE Labs, CR

Re: [PATCH 4/7] ext4: rename: create ext4_renament structure for local vars

2013-10-02 Thread Jan Kara
); } retval = 0; end_rename: - brelse(dir_bh); - brelse(old_bh); - brelse(new_bh); + brelse(old.dir_bh); + brelse(old.bh); + brelse(new.bh); if (handle) ext4_journal_stop(handle); return retval; -- 1.8.1.4 -- Jan Kara j...@suse.cz

Re: [PATCH 5/7] ext4: rename: move EMLINK check up

2013-10-02 Thread Jan Kara
. Signed-off-by: Miklos Szeredi mszer...@suse.cz This looks good. You can add: Reviewed-by: Jan Kara j...@suse.cz Honza --- fs/ext4/namei.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/ext4

Re: [PATCH 6/7] ext4: rename: split out helper functions

2013-10-02 Thread Jan Kara
easier to follow. The patch looks good to me. You can add: Reviewed-by: Jan Kara j...@suse.cz Honza Signed-off-by: Miklos Szeredi mszer...@suse.cz --- fs/ext4/namei.c | 199

Re: [PATCH 3/7] vfs: add renameat2 syscall and cross-rename

2013-10-02 Thread Jan Kara
to the next hole */ #define SEEK_MAX SEEK_HOLE +#define RENAME_EXCHANGE (1 0)/* Exchange source and dest */ + struct fstrim_range { __u64 start; __u64 len; -- 1.8.1.4 -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line

Re: [RFC] extending splice for copy offloading

2013-10-02 Thread Jan Kara
Honza -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

[PATCH 05/26] omap3isp: Make isp_video_buffer_prepare_user() use get_user_pages_fast()

2013-10-02 Thread Jan Kara
CC: Laurent Pinchart laurent.pinch...@ideasonboard.com CC: linux-me...@vger.kernel.org Signed-off-by: Jan Kara j...@suse.cz --- drivers/media/platform/omap3isp/ispqueue.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/media/platform/omap3isp/ispqueue.c b

[PATCH 02/26] ia64: Use get_user_pages_fast() in err_inject.c

2013-10-02 Thread Jan Kara
Convert get_user_pages() call to get_user_pages_fast(). This actually fixes an apparent bug where get_user_pages() has been called without mmap_sem for an arbitrary user-provided address. CC: Tony Luck tony.l...@intel.com CC: linux-i...@vger.kernel.org Signed-off-by: Jan Kara j...@suse.cz

[PATCH 03/26] dma: Use get_user_pages_fast() in dma_pin_iovec_pages()

2013-10-02 Thread Jan Kara
CC: Dan Williams dan.j.willi...@intel.com Signed-off-by: Jan Kara j...@suse.cz --- drivers/dma/iovlock.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/dma/iovlock.c b/drivers/dma/iovlock.c index bb48a57c2fc1..8b16332da8a9 100644 --- a/drivers/dma

[PATCH 21/26] ib: Convert ipath_get_user_pages() to get_user_pages_unlocked()

2013-10-02 Thread Jan Kara
Marciniszyn infinip...@intel.com CC: Roland Dreier rol...@kernel.org CC: linux-r...@vger.kernel.org Signed-off-by: Jan Kara j...@suse.cz --- drivers/infiniband/hw/ipath/ipath_user_pages.c | 62 +++--- 1 file changed, 27 insertions(+), 35 deletions(-) diff --git a/drivers/infiniband

[PATCH 01/26] cris: Convert cryptocop to use get_user_pages_fast()

2013-10-02 Thread Jan Kara
CC: linux-cris-ker...@axis.com CC: Mikael Starvik star...@axis.com CC: Jesper Nilsson jesper.nils...@axis.com Signed-off-by: Jan Kara j...@suse.cz --- arch/cris/arch-v32/drivers/cryptocop.c | 35 ++ 1 file changed, 10 insertions(+), 25 deletions(-) diff --git

[PATCH 25/26] ib: Convert mthca_map_user_db() to use get_user_pages_fast()

2013-10-02 Thread Jan Kara
Function mthca_map_user_db() appears to call get_user_pages() without holding mmap_sem. Fix the bug by using get_user_pages_fast() instead which also takes care of the locking. CC: Roland Dreier rol...@kernel.org CC: linux-r...@vger.kernel.org Signed-off-by: Jan Kara j...@suse.cz --- drivers

[PATCH 04/26] drm: Convert via driver to use get_user_pages_fast()

2013-10-02 Thread Jan Kara
CC: David Airlie airl...@linux.ie CC: dri-de...@lists.freedesktop.org Signed-off-by: Jan Kara j...@suse.cz --- drivers/gpu/drm/via/via_dmablit.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/via/via_dmablit.c b/drivers/gpu/drm/via/via_dmablit.c

[PATCH 26/26] aio: Remove useless get_user_pages() call

2013-10-02 Thread Jan Kara
...@vger.kernel.org CC: linux-...@kvack.org CC: Alexander Viro v...@zeniv.linux.org.uk CC: Benjamin LaHaise b...@kvack.org Signed-off-by: Jan Kara j...@suse.cz --- fs/aio.c | 48 +--- 1 file changed, 17 insertions(+), 31 deletions(-) diff --git a/fs/aio.c b/fs/aio.c index

[PATCH 14/26] nfs: Convert direct IO to use get_user_pages_fast()

2013-10-02 Thread Jan Kara
CC: Trond Myklebust trond.mykleb...@netapp.com CC: linux-...@vger.kernel.org Signed-off-by: Jan Kara j...@suse.cz --- fs/nfs/direct.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c index 91ff089d3412..1aaf4aa2b3d7 100644 --- a/fs

[PATCH 24/26] ib: Convert qib_user_sdma_pin_pages() to use get_user_pages_unlocked()

2013-10-02 Thread Jan Kara
...@kernel.org CC: linux-r...@vger.kernel.org Signed-off-by: Jan Kara j...@suse.cz --- drivers/infiniband/hw/qib/qib_user_sdma.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_user_sdma.c b/drivers/infiniband/hw/qib/qib_user_sdma.c index

[PATCH 12/26] pvr2fb: Convert pvr2fb_write() to use get_user_pages_fast()

2013-10-02 Thread Jan Kara
CC: linux-fb...@vger.kernel.org CC: Tomi Valkeinen tomi.valkei...@ti.com CC: Jean-Christophe Plagniol-Villard plagn...@jcrosoft.com Signed-off-by: Jan Kara j...@suse.cz --- drivers/video/pvr2fb.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/video/pvr2fb.c b

[PATCH 22/26] ib: Convert ipath_user_sdma_pin_pages() to use get_user_pages_unlocked()

2013-10-02 Thread Jan Kara
Dreier rol...@kernel.org CC: linux-r...@vger.kernel.org Signed-off-by: Jan Kara j...@suse.cz --- drivers/infiniband/hw/ipath/ipath_user_sdma.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/hw/ipath/ipath_user_sdma.c b/drivers/infiniband/hw/ipath

[PATCH 15/26] ceph: Convert ceph_get_direct_page_vector() to get_user_pages_fast()

2013-10-02 Thread Jan Kara
CC: Sage Weil s...@inktank.com CC: ceph-de...@vger.kernel.org Signed-off-by: Jan Kara j...@suse.cz --- net/ceph/pagevec.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/ceph/pagevec.c b/net/ceph/pagevec.c index 815a2249cfa9..1b1ac7887767 100644 --- a/net/ceph

[PATCH 23/26] ib: Convert qib_get_user_pages() to get_user_pages_unlocked()

2013-10-02 Thread Jan Kara
Marciniszyn infinip...@intel.com CC: Roland Dreier rol...@kernel.org CC: linux-r...@vger.kernel.org Signed-off-by: Jan Kara j...@suse.cz --- drivers/infiniband/hw/qib/qib_user_pages.c | 62 +- 1 file changed, 26 insertions(+), 36 deletions(-) diff --git a/drivers/infiniband

[PATCH 20/26] ib: Convert ib_umem_get() to get_user_pages_unlocked()

2013-10-02 Thread Jan Kara
: linux-r...@vger.kernel.org Signed-off-by: Jan Kara j...@suse.cz --- drivers/infiniband/core/umem.c | 41 + 1 file changed, 17 insertions(+), 24 deletions(-) diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c index a84112322071

[PATCH 13/26] fsl_hypervisor: Convert ioctl_memcpy() to use get_user_pages_fast()

2013-10-02 Thread Jan Kara
CC: Timur Tabi ti...@freescale.com Signed-off-by: Jan Kara j...@suse.cz --- drivers/virt/fsl_hypervisor.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/virt/fsl_hypervisor.c b/drivers/virt/fsl_hypervisor.c index d294f67d6f84..791a46a5dd2a 100644

[PATCH 16/26] mm: Provide get_user_pages_unlocked()

2013-10-02 Thread Jan Kara
Provide a wrapper for get_user_pages() which takes care of acquiring and releasing mmap_sem. Using this function reduces amount of places in which we deal with mmap_sem. Signed-off-by: Jan Kara j...@suse.cz --- include/linux/mm.h | 14 ++ 1 file changed, 14 insertions(+) diff --git

[PATCH 17/26] kvm: Use get_user_pages_unlocked() in async_pf_execute()

2013-10-02 Thread Jan Kara
CC: Gleb Natapov g...@redhat.com CC: Paolo Bonzini pbonz...@redhat.com CC: k...@vger.kernel.org Signed-off-by: Jan Kara j...@suse.cz --- virt/kvm/async_pf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/virt/kvm/async_pf.c b/virt/kvm/async_pf.c index 8a39dda7a325

[PATCH 10/26] lustre: Convert ll_get_user_pages() to use get_user_pages_fast()

2013-10-02 Thread Jan Kara
CC: Greg Kroah-Hartman g...@kroah.com CC: Peng Tao tao.p...@emc.com CC: Andreas Dilger andreas.dil...@intel.com CC: hpdd-disc...@lists.01.org Signed-off-by: Jan Kara j...@suse.cz --- drivers/staging/lustre/lustre/llite/rw26.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff

[PATCH 19/26] ivtv: Convert driver to use get_user_pages_unlocked()

2013-10-02 Thread Jan Kara
CC: Andy Walls awa...@md.metrocast.net CC: linux-me...@vger.kernel.org Signed-off-by: Jan Kara j...@suse.cz --- drivers/media/pci/ivtv/ivtv-udma.c | 6 ++ drivers/media/pci/ivtv/ivtv-yuv.c | 12 ++-- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/media/pci

[PATCH 09/26] crystalhd: Convert crystalhd_map_dio() to use get_user_pages_fast()

2013-10-02 Thread Jan Kara
CC: Naren Sankar nsan...@broadcom.com CC: Jarod Wilson ja...@wilsonet.com CC: Scott Davilla davi...@4pi.com CC: Manu Abraham abraham.m...@gmail.com Signed-off-by: Jan Kara j...@suse.cz --- drivers/staging/crystalhd/crystalhd_misc.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff

[PATCH 06/26] vmw_vmci: Convert driver to use get_user_pages_fast()

2013-10-02 Thread Jan Kara
Signed-off-by: Jan Kara j...@suse.cz --- drivers/misc/vmw_vmci/vmci_host.c | 6 +- drivers/misc/vmw_vmci/vmci_queue_pair.c | 21 ++--- 2 files changed, 7 insertions(+), 20 deletions(-) diff --git a/drivers/misc/vmw_vmci/vmci_host.c b/drivers/misc/vmw_vmci/vmci_host.c

[PATCH 11/26] sep: Convert sep_lock_user_pages() to get_user_pages_fast()

2013-10-02 Thread Jan Kara
CC: Greg Kroah-Hartman gre...@linuxfoundation.org CC: Mark Allyn mark.a.al...@intel.com CC: Jayant Mangalampalli jayant.mangalampa...@intel.com Signed-off-by: Jan Kara j...@suse.cz --- drivers/staging/sep/sep_main.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git

[PATCH 08/26] ced1401: Convert driver to use get_user_pages_fast()

2013-10-02 Thread Jan Kara
CC: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Jan Kara j...@suse.cz --- drivers/staging/ced1401/ced_ioc.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c index 2dbaf39e2fc2

[PATCH 18/26] mm: Convert process_vm_rw_pages() to use get_user_pages_unlocked()

2013-10-02 Thread Jan Kara
Signed-off-by: Jan Kara j...@suse.cz --- mm/process_vm_access.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/mm/process_vm_access.c b/mm/process_vm_access.c index fd26d0433509..c1bc47d8ed90 100644 --- a/mm/process_vm_access.c +++ b/mm/process_vm_access.c @@ -64,12

[PATCH 07/26] st: Convert sgl_map_user_pages() to use get_user_pages_fast()

2013-10-02 Thread Jan Kara
CC: linux-s...@vger.kernel.org CC: Kai Makisara kai.makis...@kolumbus.fi Signed-off-by: Jan Kara j...@suse.cz --- drivers/scsi/st.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c index ff44b3c2cff2..ba11299c3740 100644

Re: [PATCH 23/26] ib: Convert qib_get_user_pages() to get_user_pages_unlocked()

2013-10-02 Thread Jan Kara
in the commit message text Sure will do. Thanks the quick reply and for comments. Honza -Original Message- From: Jan Kara [mailto:j...@suse.cz] Sent: Wednesday, October 02, 2013 10:28 AM To: LKML Cc: linux

Re: [PATCH 23/26] ib: Convert qib_get_user_pages() to get_user_pages_unlocked()

2013-10-02 Thread Jan Kara
as get_user_pages() locking doesn't leak into IB drivers :) Honza -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 18/26] mm: Convert process_vm_rw_pages() to use get_user_pages_unlocked()

2013-10-02 Thread Jan Kara
On Wed 02-10-13 12:32:33, KOSAKI Motohiro wrote: (10/2/13 10:27 AM), Jan Kara wrote: Signed-off-by: Jan Kara j...@suse.cz --- mm/process_vm_access.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/mm/process_vm_access.c b/mm/process_vm_access.c index

Re: [PATCH 16/26] mm: Provide get_user_pages_unlocked()

2013-10-02 Thread Jan Kara
On Wed 02-10-13 12:28:11, KOSAKI Motohiro wrote: (10/2/13 10:27 AM), Jan Kara wrote: Provide a wrapper for get_user_pages() which takes care of acquiring and releasing mmap_sem. Using this function reduces amount of places in which we deal with mmap_sem. Signed-off-by: Jan Kara j

Re: [PATCH 05/26] omap3isp: Make isp_video_buffer_prepare_user() use get_user_pages_fast()

2013-10-02 Thread Jan Kara
On Wed 02-10-13 21:41:10, Laurent Pinchart wrote: Hi Jan, Thank you for the patch. On Wednesday 02 October 2013 16:27:46 Jan Kara wrote: CC: Laurent Pinchart laurent.pinch...@ideasonboard.com CC: linux-me...@vger.kernel.org Signed-off-by: Jan Kara j...@suse.cz Acked-by: Laurent

Re: [PATCH 23/26] ib: Convert qib_get_user_pages() to get_user_pages_unlocked()

2013-10-04 Thread Jan Kara
of the wrapper so that there is only one set of mmap_sem transactions? I'm sorry, I don't understand what you mean here... Honza -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux

Re: Debugging system freezes on filesystem writes

2013-09-13 Thread Jan Kara
On Fri 13-09-13 09:35:05, Marcus Sundman wrote: On 12.09.2013 23:46, Jan Kara wrote: On Thu 12-09-13 20:59:07, Marcus Sundman wrote: On 12.09.2013 19:35, Jan Kara wrote: On Thu 12-09-13 18:08:13, Marcus Sundman wrote: And can I somehow reset whatever it is that is making it worse so

BLK_TN_PROCESS events not delivered for all devices

2013-09-16 Thread Jan Kara
expensive... Honza -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: BLK_TN_PROCESS events not delivered for all devices

2013-09-17 Thread Jan Kara
On Tue 17-09-13 08:29:07, Jens Axboe wrote: On 09/16/2013 03:23 AM, Jan Kara wrote: Hi, I've been looking into a problem where BLK_TN_PROCESS events are not delivered to all devices which are being traced. This results in process name being (null) when trace for a single device

[PATCH] blktrace: Send BLK_TN_PROCESS events to all running traces

2013-09-17 Thread Jan Kara
sent to other devices. Thus blkparse doesn't display command name when parsing some blktrace files. Fix the problem by sending BLK_TN_PROCESS event to all traced devices when a task interacts with any of them. Signed-off-by: Jan Kara j...@suse.cz --- include/linux/blktrace_api.h | 2 ++ kernel

Re: BLK_TN_PROCESS events not delivered for all devices

2013-09-17 Thread Jan Kara
On Tue 17-09-13 12:23:33, Jens Axboe wrote: On 09/17/2013 11:10 AM, Jan Kara wrote: On Tue 17-09-13 08:29:07, Jens Axboe wrote: On 09/16/2013 03:23 AM, Jan Kara wrote: Hi, I've been looking into a problem where BLK_TN_PROCESS events are not delivered to all devices which are being

Re: doing lots of disk writes causes oom killer to kill processes

2013-09-17 Thread Jan Kara
bdflushd or what it was called. I emulate it with { while true ; do sleep 5; sync ; done } The system performance suddenly increases - to the awesome Debian stable levels. Honza -- Jan Kara j...@suse.cz SUSE Labs, CR

Re: still running into WARNING: CPU: at fs/ext4/inode.c:230 ext4_evict_inode+0x4a6/0x4e0

2013-10-16 Thread Jan Kara
] __fput+0x188/0x270 [8117f73e] fput+0xe/0x10 [8106d0bf] task_work_run+0x8f/0xf0 [81003a84] do_notify_resume+0x84/0x90 [8155d9da] int_signal+0x12/0x17 ---[ end trace ea7184a5fb48e185 ]--- Thanks, Davidlohr -- Jan Kara j...@suse.cz SUSE Labs, CR

Re: still running into WARNING: CPU: at fs/ext4/inode.c:230 ext4_evict_inode+0x4a6/0x4e0

2013-10-16 Thread Jan Kara
On Wed 16-10-13 08:56:07, Davidlohr Bueso wrote: On Wed, 2013-10-16 at 14:50 +0200, Jan Kara wrote: On Tue 15-10-13 19:02:04, Davidlohr Bueso wrote: Hello Jan, Just wanted to let you know I hit this[1] again on Linus' latest. The setup/workload is *identical* to the reported one

Re: [PATCH 23/26] ib: Convert qib_get_user_pages() to get_user_pages_unlocked()

2013-10-16 Thread Jan Kara
On Tue 08-10-13 21:06:04, Jan Kara wrote: On Mon 07-10-13 19:26:04, Jan Kara wrote: On Mon 07-10-13 15:38:24, Marciniszyn, Mike wrote: This patch and the sibling ipath patch will nominally take the mmap_sem twice where the old routine only took it once. This is a performance

Re: [PATCH] udf: fix for pathetic mount times in case of invalid file system

2013-10-17 Thread Jan Kara
); } else { -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: 3.11.4: kernel BUG at fs/buffer.c:1268

2013-10-17 Thread Jan Kara
[280344.108415] ---[ end trace 68f14daef5901df3 ]--- [280344.108416] Fixing recursive fault but reboot is needed! -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] mm: Check for NULL return values from allocating functions

2013-10-18 Thread Jan Kara
-bi_sector = bh-b_blocknr * (bh-b_size 9); bio-bi_bdev = bh-b_bdev; -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v2] udf: fix for pathetic mount times in case of invalid file system

2013-10-18 Thread Jan Kara
Signed-off-by: Peter A. Felvegi pets...@gmail.com --- The fix was developed for 3.9.4, and applies to 3.12-rc3, too. patch v2: edited the code so that added/changed lines are not longer than 80 chars. sending the patch as an attachment, as gmail messes it up otherwise. -- Jan Kara j

Re: recursive locking (coredump/vfs_write)

2013-11-22 Thread Jan Kara
majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- Jan Kara j...@suse.cz SUSE Labs, CR From b7d1b0a12722eb6a5cb25cc614fae26ddf652c02 Mon Sep 17 00:00:00 2001 From: Jan Kara j...@suse.cz Date: Fri, 22 Nov 2013 21:59:24 +0100 Subject

Re: recursive locking (coredump/vfs_write)

2013-11-24 Thread Jan Kara
On Fri 22-11-13 23:52:18, Al Viro wrote: On Fri, Nov 22, 2013 at 10:11:56PM +0100, Jan Kara wrote: Hi, On Wed 13-11-13 16:11:47, Dave Jones wrote: here's another one.. = [ INFO: possible recursive locking detected ] 3.12.0

Re: [PATCH 3/4] printk: Defer printing to irq work when we printed too much

2013-11-25 Thread Jan Kara
On Fri 22-11-13 15:27:11, Andrew Morton wrote: On Fri, 8 Nov 2013 11:21:13 +0100 Jan Kara j...@suse.cz wrote: On Fri 08-11-13 00:46:49, Frederic Weisbecker wrote: On Thu, Nov 07, 2013 at 06:37:17PM -0500, Steven Rostedt wrote: On Fri, 8 Nov 2013 00:21:51 +0100 Frederic Weisbecker

Re: [PATCH 11/11] ext4: add cross rename support

2013-11-26 Thread Jan Kara
obvious by computing old_link_cnt_update, new_link_cnt_update - how link counts of parent dirs should be updated (-1, 0, +1) and then do the checks and updates based on this in one place. Honza -- Jan Kara j...@suse.cz SUSE Labs, CR

Re: [PATCH 08/11] ext4: rename: create ext4_renament structure for local vars

2013-11-26 Thread Jan Kara
. Not sure if it is worth an extra patch or if you just fold it here... Otherwise the patch looks good. You can add: Reviewed-by: Jan Kara j...@suse.cz Honza -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list

Re: [PATCH 0/3] Extended file stat functions [ver #2]

2013-11-26 Thread Jan Kara
something with a 4Gb+ blocksize? (4) Should the inode number and data version number fields be 128-bit? -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: CONFIG_EXT4_USE_FOR_EXT23 no space left on device

2013-11-27 Thread Jan Kara
in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: CONFIG_EXT4_USE_FOR_EXT23 no space left on device

2013-11-28 Thread Jan Kara
On Thu 28-11-13 11:15:57, Geert Uytterhoeven wrote: On Wed, Nov 27, 2013 at 11:23 PM, Jan Kara j...@suse.cz wrote: On Wed 27-11-13 16:50:14, Geert Uytterhoeven wrote: To reduce kernel size, I disabled both CONFIG_EXT2_FS and CONFIG_EXT3_FS, and enabled CONFIG_EXT4_USE_FOR_EXT23

Re: [PATCH 0/3] Extended file stat functions [ver #2]

2013-11-28 Thread Jan Kara
On Thu 28-11-13 13:07:24, David Howells wrote: Jan Kara j...@suse.cz wrote: unsigned long long st_blocks; When we are doing this, can we please also change 'st_blocks' to 'st_bytes'? We track space usage in kernel in bytes for a long time so it would be nice

Re: 3.11.4: kernel BUG at fs/buffer.c:1268

2013-11-28 Thread Jan Kara
, block_group); percpu_counter_add(sbi-s_freeclusters_counter, count_clusters); + might_sleep(); if (sbi-s_log_groups_per_flex) { ext4_group_t flex_group = ext4_flex_group(sbi, block_group); -- Jan Kara j...@suse.cz SUSE Labs, CR From

Re: still running into WARNING: CPU: at fs/ext4/inode.c:230 ext4_evict_inode+0x4a6/0x4e0

2013-11-28 Thread Jan Kara
On Wed 16-10-13 20:38:07, Jan Kara wrote: On Wed 16-10-13 08:56:07, Davidlohr Bueso wrote: On Wed, 2013-10-16 at 14:50 +0200, Jan Kara wrote: On Tue 15-10-13 19:02:04, Davidlohr Bueso wrote: Hello Jan, Just wanted to let you know I hit this[1] again on Linus' latest

Re: PROBLEM: udf mount takes forever to fail + proposed solution

2013-10-11 Thread Jan Kara
! Honza -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: PROBLEM: udf mount takes forever to fail + proposed solution

2013-10-14 Thread Jan Kara
only guess which limit to pick... If using fixed strings won't work out, using a limit like 100 sectors would probably be the next best solution for me. Honza On 11 October 2013 17:18, Jan Kara j...@suse.cz wrote: Hello, On Thu

Re: Warning when calling radix_tree_insert on 3.12-rc4

2013-10-14 Thread Jan Kara
5e4c0d974139a98741b829b27cf38dc8f9284490 lib/radix-tree.c: make radix_tree_node_alloc() work correctly within interrupt. I'll revert the commit, and see if the warning disappears. In the meantime, can you look into fixing this? Thanks, Sarah Sharp -- Jan Kara j...@suse.cz SUSE Labs, CR

Re: [PATCH v2] writeback: fix negative bdi max pause

2013-10-14 Thread Jan Kara
failed to protect it falling under 0. Fix all of them by using unsigned long throughout the function. Reported-by: Toralf Förster toralf.foers...@gmx.de Tested-by: Toralf Förster toralf.foers...@gmx.de Cc: sta...@vger.kernel.org Cc: Jan Kara j...@suse.cz Cc: Richard Weinberger rich...@nod.at

Re: [PATCH] ext4: fix checking on nr_to_write

2013-10-14 Thread Jan Kara
nr_to_write won't become negative. Cc: Ted Tso ty...@mit.edu Cc: Jan Kara j...@suse.cz Cc: linux-e...@vger.kernel.org Cc: linux-fsde...@vger.kernel.org linux-fsde...@vger.kernel.org Signed-off-by: Ming Lei ming@canonical.com --- fs/ext4/inode.c | 20 ++-- 1 file

Re: [PATCH] ext4: fix checking on nr_to_write

2013-10-14 Thread Jan Kara
On Mon 14-10-13 21:50:54, Ming Lei wrote: On Mon, Oct 14, 2013 at 8:58 PM, Jan Kara j...@suse.cz wrote: Umm, I guess I see what are you pointing at. Thanks for catching that. mpage_process_page_bufs() always adds a buffer to mpd even if nr_to_write is already = 0. But I would somewhat

Re: Warning when calling radix_tree_insert on 3.12-rc4

2013-10-14 Thread Jan Kara
On Mon 14-10-13 11:17:21, Sarah Sharp wrote: On Mon, Oct 14, 2013 at 02:30:34PM +0200, Jan Kara wrote: Hello Sarah, On Fri 11-10-13 15:13:15, Sarah Sharp wrote: I'm testing out some changes to the xHCI USB host controller driver (which uses a radix tree when a UAS device

Re: [PATCH] blktrace: Send BLK_TN_PROCESS events to all running traces

2013-10-15 Thread Jan Kara
On Mon 23-09-13 13:37:23, Jan Kara wrote: On Tue 17-09-13 22:30:31, Jan Kara wrote: Currently each task sends BLK_TN_PROCESS event to the first traced device it interacts with after a new trace is started. When there are several traced devices and the task accesses more devices, this logic

Re: [patch 0/8] mm: thrash detection-based file cache sizing v5

2013-10-15 Thread Jan Kara
;) Honza -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH] ext4: fix checking on nr_to_write

2013-10-15 Thread Jan Kara
++; } pagevec_release(pvec); cond_resched(); Thanks, -- Ming Lei -- Jan Kara j...@suse.cz SUSE Labs, CR From 2ea950d5d601fd1236065f3fe87a9383d78d3785 Mon Sep 17 00:00:00 2001 From: Ming Lei ming@canonical.com Date: Tue, 15 Oct 2013 12:30:50 +0200 Subject: [PATCH

Re: [PATCH] ext4: fix checking on nr_to_write

2013-10-15 Thread Jan Kara
-next_page if the current page won't be processed. Thanks, -- Ming Lei -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] inode: For readonly filesystem, func file_update_time should return -EROFS rather than zero.

2013-10-15 Thread Jan Kara
rather than zero. The patch looks good to me so feel free to add Reviewed-by: Jan Kara j...@suse.cz Just the reasoning in the changelog doesn't look completely correct - we are free to succeed doing write to a FMODE_WRITE file descriptor even if the filesystem below it decided to declare game

Re: [BUG][ext2] XIP does not work on ext2

2013-11-11 Thread Jan Kara
On Fri 08-11-13 16:28:15, Andiry Xu wrote: On Thu, Nov 7, 2013 at 2:45 PM, Andiry Xu and...@gmail.com wrote: On Thu, Nov 7, 2013 at 2:20 PM, Jan Kara j...@suse.cz wrote: On Thu 07-11-13 13:50:09, Andiry Xu wrote: On Thu, Nov 7, 2013 at 1:07 PM, Jan Kara j...@suse.cz wrote: On Thu 07-11

[GIT PULL] ext[23], udf quota fix

2013-11-11 Thread Jan Kara
is 7ba3ec5749dd. The full shortlog is: Dan Carpenter (1): quota: info leak in quota_getquota() Eric Sandeen (1): ext3: Count journal as bsddf overhead in ext3_statfs Jan Kara (2): jbd: Revert jbd: remove dependency on __GFP_NOFAIL ext2: Fix fs corruption in ext2_get_xip_mem

Re: Disabling in-memory write cache for x86-64 in Linux II

2013-11-11 Thread Jan Kara
On Mon 11-11-13 14:22:11, Dave Chinner wrote: On Thu, Nov 07, 2013 at 02:48:06PM +0100, Jan Kara wrote: On Tue 05-11-13 15:12:45, Dave Chinner wrote: On Mon, Nov 04, 2013 at 05:50:13PM -0700, Andreas Dilger wrote: Realistically, there is no one right answer for all combinations

Re: [PATCH 3/4] printk: Defer printing to irq work when we printed too much

2013-11-11 Thread Jan Kara
. Reviewed-by: Steven Rostedt rost...@goodmis.org Signed-off-by: Jan Kara j...@suse.cz When a message takes tens of seconds to be printed, it usually means we are in trouble somehow :) I wonder what printk source can trigger such a high volume. Machines with tens

Re: 3.12 BUG() on ext4, kernel crash on nbd-client when nbd server rebooting

2013-11-12 Thread Jan Kara
in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: 3.12 BUG() on ext4, kernel crash on nbd-client when nbd server rebooting

2013-11-13 Thread Jan Kara
On Wed 13-11-13 05:59:11, Denys Fedoryshchenko wrote: Hi On 2013-11-12 23:46, Jan Kara wrote: Hello, On Tue 12-11-13 16:34:07, Denys Fedoryshchenko wrote: I just did some fault testing for test nbd setup, and found that if i reboot nbd server i will get immediately BUG() message on nbd

Re: [PATCH] jbd: Lower severity of aborted journal from EMERG to CRIT

2013-11-21 Thread Jan Kara
On Tue 19-11-13 02:26:30, Christoph Hellwig wrote: On Mon, Nov 18, 2013 at 05:45:33PM +0100, Jan Kara wrote: dead. If it was an important filesystem in your system, the whole system is unusable. In kernel, we don't know whether the filesystem was important or not. So KERN_EMERG isn't

Re: why does index in truncate_inode_pages_range() grows so much ?

2013-12-03 Thread Jan Kara
also 'start' variable and in case 'index' is suspiciously large, print also 'i' and some info about the page pvec[i] page (page-index, page-flags, page-mapping-host-i_sb-s_id, page-mapping-host-i_ino)? Honza -- Jan Kara j...@suse.cz

Re: [PATCH 1/1] fs/isofs/inode.c add __init to init_inodecache()

2014-03-12 Thread Jan Kara
in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- Jan Kara j...@suse.cz SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

[PATCH 5/6] printk: Hand over printing to console if printing too long

2014-03-13 Thread Jan Kara
CPU notices kthread got scheduled and is spinning on console_sem, it drops console_sem and exits console_unlock(). kthread then takes over printing instead. This way no CPU should spend printing too long even if there is heavy printk traffic. Signed-off-by: Jan Kara j...@suse.cz --- Documentation

[PATCH 6/6] kernel: Avoid softlockups in stop_machine() during heavy printing

2014-03-13 Thread Jan Kara
to be empty before starting to stop CPUs. In theory a burst of new messages can be appended to the printk buffer before CPUs enter multi_cpu_stop() so this isn't a 100% solution but it works OK in practice and I'm not aware of a reasonably simple better solution. Signed-off-by: Jan Kara j...@suse.cz

[PATCH 1/6] printk: Remove outdated comment

2014-03-13 Thread Jan Kara
()) was indeed using lockbuf_lock to avoid races between trylock on console_sem in printk() and unlock of console_sem. However these days the interlocking is gone and the races are avoided by rechecking logbuf state after releasing console_sem. Signed-off-by: Jan Kara j...@suse.cz --- kernel

[PATCH 0/6 v2] printk: Cleanups and softlockup avoidance

2014-03-13 Thread Jan Kara
Hello, this is another piece of the printk softlockup saga series. Let me first remind the problem: Currently, console_unlock() prints messages from kernel printk buffer to console while the buffer is non-empty. When serial console is attached, printing is slow and thus other CPUs in the

<    4   5   6   7   8   9   10   11   12   13   >