[PATCH 02/14] [ISDN] Hisax: eliminate many unnecessary references to CardType[]

2008-02-14 Thread Jeff Garzik
reatly reducing external references to hisax global CardType[]. This will be of value once the ISDN drivers are converted to the ISA/PCI/PNP hotplug APIs. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/isdn/hisax/asuscom.c |5 + drivers/isdn/hisax/avm_a1

[PATCH 01/14] [ISDN] HiSax: modularize card setup

2008-02-14 Thread Jeff Garzik
Now that the previous no-behavior-change code movement patches have occurred, we can easily replace the big per-card "call the setup function for " switch statement with a function pointer. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/isdn/hisax/co

[PATCH 00/14] [ISDN] HiSax hotplug conversion

2008-02-14 Thread Jeff Garzik
This is a refresh of an on-going work-in-progress: convert the last remaining users of pci_find_device() to the ISA/PCI/etc. hotplug APIs now in standard use. After SCSI's gdth, ISDN's HiSax suite of drivers are just about the last place using the older API. A few rough edges remain, and I'm n

Re: [PATCH 00/14] [ISDN] HiSax hotplug conversion

2008-02-15 Thread Jeff Garzik
Sam Ravnborg wrote: On Tue, Jul 17, 2007 at 11:04:04PM -0400, Jeff Garzik wrote: This is a refresh of an on-going work-in-progress: convert the last remaining users of pci_find_device() to the ISA/PCI/etc. hotplug APIs now in standard use. After SCSI's gdth, ISDN's HiSax suite of d

[git patches] net driver fixes

2008-02-15 Thread Jeff Garzik
Process note: 'upstream-davem' continues the git history that began the previous push. This sometimes happens when I continue to commit locally, working in parallel while waiting for changes to hit Linus upstream. As current net-2.6.git appears to have the same commit ids that I submitted in the

Re: [PATCH] gdth: convert to PCI hotplug API

2008-02-15 Thread Jeff Garzik
James Bottomley wrote: diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index c825239..1b53e92 100644 --- a/drivers/scsi/gdth.c +++ b/drivers/scsi/gdth.c @@ -595,85 +595,107 @@ static int __init gdth_search_isa(ulong32 bios_adr) #endif /* CONFIG_ISA */ #ifdef CONFIG_PCI -static void gd

Re: [PATCH 01/11] ata: fix sparse warning in ata_piix.c

2008-02-15 Thread Jeff Garzik
Harvey Harrison wrote: drivers/ata/ata_piix.c:1655:8: warning: symbol 'rc' shadows an earlier one drivers/ata/ata_piix.c:1616:6: originally declared here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/ata/ata_piix.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) a

Re: [libata-dev #upstream-fixes] pata_legacy: don't call ata_host_detach() after initialization failure

2008-02-15 Thread Jeff Garzik
Tejun Heo wrote: ata_host_detach() detaches an attached port and shouldn't be called on a port which hasn't been attached yet. pata_legacy incorrectly calls ata_host_detach() on unattached port after initialization failure causing oops. Fix it. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> Cc:

Re: [PATCH 06/11] ata: sparse fixes for pata_amd.c

2008-02-15 Thread Jeff Garzik
Harvey Harrison wrote: drop return statement. drivers/ata/pata_amd.c:149:2: warning: returning void-valued expression Commit ce54d1616302117fa98513ae916bbe1c02ea pata_amd: update mode selection for NV PATAs added the initializer for nv_mode_filter but missed deleting the previously set mod

[git patches] libata fixes

2008-02-15 Thread Jeff Garzik
Got another couple sata_mv fixes pending too... coming soon. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/ata_piix.c |2 +- drivers/ata/libata-core.c |1

Re: [git patches] net driver fixes

2008-02-15 Thread Jeff Garzik
David Miller wrote: From: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri, 15 Feb 2008 11:03:14 -0500 Please pull from 'upstream-davem' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-davem Pulled and pushed out. As I mentioned to John Linvil

Re: pci_device_id definition cleanups

2008-02-15 Thread Jeff Garzik
Greg KH wrote: On Sat, Feb 16, 2008 at 12:21:40AM +0100, Jonas Bonn wrote: I've done some work on cleaning up the definitions of pci_device_id to make them "static const" (where possible) and to make sure they go into __devinitconst. There are about 350 changes of the type shown in the diff at

[PATCH 1/2] SCSI/gdth: PCI probe cleanups, prep for PCI hotplug API conversion

2008-02-15 Thread Jeff Garzik
rq instead - Eliminate assign-only gdth_pci_str::io_mm Note: If the indentation seems weird, that's because a line was converted from spaces to tabs, when it was modified. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- NOTE: this patch series supercedes the previous "gdth: conve

[PATCH 2/2 v2] SCSI/gdth: convert to PCI hotplug API

2008-02-15 Thread Jeff Garzik
Version 2: - rediff'd against latest kernel (fix akpm-noticed conflicts) - remove PCI device sort, which greatly simplifies PCI probe, permitting direct, per-HBA function calls rather than an indirect route to the same end result. - remove need for pcistr[] Signed-off-by: Jeff G

[PATCH 00/14] [ISDN] convert HiSax to hotplug APIs

2008-02-16 Thread Jeff Garzik
This is the next revision of the ISDN hotplug conversion patches. Changes since last version: - handled ml comments - checkpatch fixes - moved proto.h addition into correct changeset - separated some bug fixes out from the diva changeset, into their own changeset. Work remaining: - convert els

[PATCH 01/14] [ISDN] HiSax: modularization prep

2008-02-16 Thread Jeff Garzik
Pass a function pointer into the core HiSax probe function checkcard(), in order to facilitate modular drivers passing in their own setup routines. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/isdn/hisax/config.c| 14 +- drivers/isdn/hisax/hisax_cfg.h |2

[PATCH 02/14] [ISDN] Hisax: eliminate many unnecessary references to CardType[]

2008-02-16 Thread Jeff Garzik
reatly reducing external references to hisax global CardType[]. This will be of value once the ISDN drivers are converted to the ISA/PCI/PNP hotplug APIs. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/isdn/hisax/asuscom.c |5 + drivers/isdn/hisax/avm_a1

[PATCH 04/14] [ISDN] HiSax bkm_a4t: convert to PCI hotplug API

2008-02-16 Thread Jeff Garzik
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/isdn/hisax/Kconfig |4 +- drivers/isdn/hisax/Makefile |3 +- drivers/isdn/hisax/bkm_a4t.c | 115 -- drivers/isdn/hisax/config.c | 27 -- 4 files changed, 92 insertions(

Re: [PATCH v3 0/7] ZPODD patches for scsi tree

2012-07-26 Thread Jeff Garzik
On 07/26/2012 06:05 AM, Aaron Lu wrote: v3: Rebase on top of scsi-misc tree; Add the sr related patches previously in Jeff's libata tree; Re-organize the sr patches. A problem for now: for patch scsi: sr: support zero power ODD(ZPODD) I can't set a flag in libata-acpi.c since a related function i

Re: [PATCH v2 0/2] ata: MODE SELECT implementation

2012-07-26 Thread Jeff Garzik
On 07/26/2012 03:25 AM, Paolo Bonzini wrote: Il 05/07/2012 11:40, Paolo Bonzini ha scritto: This is a revised version of the MODE SELECT implementation from yesterday, augmented with support for changeable parameter requests in MODE SENSE. Paolo Bonzini (2): ata: support MODE SENSE request f

Re: [PATCH v3 0/7] ZPODD patches for scsi tree

2012-07-26 Thread Jeff Garzik
On 07/26/2012 10:41 AM, Aaron Lu wrote: On Thu, Jul 26, 2012 at 09:43:37AM -0400, Jeff Garzik wrote: On 07/26/2012 06:05 AM, Aaron Lu wrote: I can't set a flag in libata-acpi.c since a related function is missing in scsi-misc tree. Will fix this when 3.6-rc1 released. What does this

Re: Andre Hedrick (anhedric) has died

2012-07-26 Thread Jeff Garzik
On 07/20/2012 12:39 AM, Nate Lawson wrote: Dear Linux hackers, Sorry for the intrusion on this technical list. I wanted to let Andre's fellow Linux developers know that he died this past weekend. For those that don't know him, Andre was an active developer for the ATA driver a while back. I h

An Andre To Remember

2012-07-27 Thread Jeff Garzik
Visit a dairy. Climb a rock. Seek life. Life is so much more than code. Rest in peace Andre, Jeff Garzik friend and libata author PS. Remembering Andre website: http://hedrick4419.blogspot.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&quo

Re: [PATCH] NVMe: Add a character device for each nvme device

2012-07-27 Thread Jeff Garzik
On 07/27/2012 02:12 PM, Matthew Wilcox wrote: On Fri, Jul 27, 2012 at 10:44:18AM -0600, Keith Busch wrote: Registers a character device for the nvme module and creates character files as /dev/nvmeN for each nvme device probed, where N is the device instance. The character devices support nvme ad

Re: [PATCH] NVMe: Add a character device for each nvme device

2012-07-27 Thread Jeff Garzik
On 07/27/2012 04:26 PM, Matthew Wilcox wrote: Maybe we should design such a mechanism, but maybe we shouldn't ... as we find common things to do, we tend to move those to sysfs, not ioctls, and the kinds of commands that are being sent here are essentially vendor-specific NVMe commands; it's not

[SCSI PATCH] sd: max-retries becomes configurable

2012-09-24 Thread Jeff Garzik
drivers/scsi/sd.c |4 drivers/scsi/sd.h |2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 4df73e5..d15074b 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -92,6 +92,10 @@ MODULE_ALIAS_SCSI_DEVICE(TYPE_DISK); M

Re: [PATCH] ahci: add a boot option to enable promise ahci

2012-09-24 Thread Jeff Garzik
On 09/23/2012 10:34 PM, Tony Hung - PTT 洪瑞嶸 wrote: > linux-3.2.0/drivers/ata/ahci.c: In function 'hptiop_host_request_callback': > > Use min_t(size_t, ...) to fix. > > Signed-off-by: Tony Hung > --- > > diff --git a/linux-3.2.0/drivers/ata/ahci.c b/linux-3.2.0/drivers/ata/ahci.c > --- a/linux-3

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-24 Thread Jeff Garzik
On 09/25/2012 12:06 AM, James Bottomley wrote: On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote: drivers/scsi/sd.c |4 drivers/scsi/sd.h |2 +- 2 files changed, 5 insertions(+), 1 deletion(-) I'm not opposed in principle to doing this (except that it should be a

Re: TPMs and random numbers

2013-09-11 Thread Jeff Garzik
On Wed, Sep 11, 2013 at 2:45 PM, Theodore Ts'o wrote: > We should definitely do this. If the TPM driver could fetch some > randomness and then call add_device_randomness() to feed this into the > random driver's entropy pool when it initializes itself, that would be > ***really*** cool. rngd al

Re: TPMs and random numbers

2013-09-12 Thread Jeff Garzik
On Thu, Sep 12, 2013 at 5:57 PM, Jörn Engel wrote: > On Wed, 11 September 2013 14:47:04 -0400, David Safford wrote: >> But I also think that the existing (certified) TPMs are good enough >> for direct use. > That is equivalent to trusting the TPM chip not to be malicious. It Indeed. While it n

Re: Storage related regression in linux-next 20120824

2012-09-09 Thread Jeff Garzik
starts up. That needs to modify initrd file. So it is inconvenient for administrator who needs to manage a huge number of servers. Signed-off-by: Zheng Liu Signed-off-by: Jeff Garzik diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 5eee1c1..c3fbdca 1

Re: [RFC][PATCH] libata: enable SATA disk fua detection on default

2012-09-09 Thread Jeff Garzik
On 09/09/2012 04:34 PM, Arvydas Sidorenko wrote: Meanwhile there already has a number of SATA disks that have supported this feature. So I think maybe we can enable it. Regards, Zheng Blindly enabling FUA by default in my opinion is not a good idea at all. I believe the focus should be on det

Re: Storage related regression in linux-next 20120824

2012-09-09 Thread Jeff Garzik
On 09/09/2012 04:36 PM, Hugh Dickins wrote: On Sun, Sep 9, 2012 at 1:28 PM, Jeff Garzik wrote: I'll send Linus a patch to disable. Thanks, but no, the change in question hasn't reached Linus yet, it's just a linux-next or mmotm thing - isn't it? Yep, libata-dev#upstream

Re: [PATCH] ata_piix: re-oder code and remove prototypes

2012-12-03 Thread Jeff Garzik
On 11/30/2012 05:56 AM, Bartlomiej Zolnierkiewicz wrote: From: Bartlomiej Zolnierkiewicz Subject: [PATCH] ata_piix: re-oder code and remove prototypes Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Kyungmin Park --- Jeff, please apply. Thanks! drivers/ata/ata_piix.c | 419 +

Re: [PATCH v4 -tip 3/3] AHCI: Support multiple MSIs

2012-12-03 Thread Jeff Garzik
|6 +++ drivers/ata/libahci.c | 118 ++--- 3 files changed, 207 insertions(+), 10 deletions(-) Acked-by: Jeff Garzik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.

Re: [PATCH] ata_piix: re-oder code and remove prototypes

2012-12-03 Thread Jeff Garzik
On 12/03/2012 02:29 PM, Sergei Shtylyov wrote: Hello. On 11/30/2012 01:56 PM, Bartlomiej Zolnierkiewicz wrote: From: Bartlomiej Zolnierkiewicz Subject: [PATCH] ata_piix: re-oder code and remove prototypes You meant "re-order", I think. Signed-off-by: Bartlomiej Zolnierkiewicz Signed-

Re: [PATCH 2/8] aoe: provide ATA identify device content to user on request

2012-11-08 Thread Jeff Garzik
On 11/08/2012 11:32 AM, Ed Cashin wrote: This patch makes the aoe driver follow expected behavior when the user uses ioctl to get the ATA device identify information. Signed-off-by: Ed Cashin --- drivers/block/aoe/aoe.h|1 + drivers/block/aoe/aoeblk.c | 30 +

Re: [PATCH] pata_cs5536: add quirk for broken udma

2012-11-15 Thread Jeff Garzik
On 11/15/2012 05:03 PM, Christian Gmeiner wrote: I am working on a device which uses the cs5536 pata driver. There are some broken hardware revisions out in the field, which can be detected via DMI. On older versions with an embedded BIOS I used libata.dma=0 to disable dma completely. Now we are

Re: [patch,v3 06/10] ata: use scsi_host_alloc_node

2012-11-15 Thread Jeff Garzik
On 11/09/2012 02:18 PM, Jeff Moyer wrote: Signed-off-by: Jeff Moyer --- drivers/ata/libata-scsi.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) Acked-by: Jeff Garzik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [PATCH] ata: pata_arasan: Initialize cf clock to 166MHz

2012-11-15 Thread Jeff Garzik
On 11/08/2012 10:09 AM, Viresh Kumar wrote: From: Vipul Kumar Samar PATA arasan driver expects the clock to be set to 166 MHz for proper functioning. This patch sets clk to 166 MHz in probe. Signed-off-by: Vipul Kumar Samar Signed-off-by: Viresh Kumar --- drivers/ata/pata_arasan_cf.c | 6

Re: [PATCH 7/8] ata: highbank: mark ahci_highbank_probe as __devinit

2012-11-15 Thread Jeff Garzik
valid then annotate the variable with __init* or __refdata (see linux/init.h) or name the variable: *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console Signed-off-by: Arnd Bergmann Cc: Mark Langsdorf Cc: Rob Herring Cc: Jeff Garzik --- drivers/ata/sata_highbank.c |2 +- 1

Re: [PATCH 1/5] ata: suspend/resume callbacks should be conditionally compiled on CONFIG_PM_SLEEP

2012-11-15 Thread Jeff Garzik
d-function] Because SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) Only references the callbacks on CONFIG_PM_SLEEP (instead of CONFIG_PM). Cc: Jeff Garzik Cc: Viresh Kumar Cc: linux-...@vger.kernel.org Signed-off-by: Yuanhan Liu Signed-off-by: Fengguang Wu --- drivers/ata/ahci_platform.c |2 +- drivers/

Re: ata4.00: failed to get Identify Device Data, Emask 0x1

2012-11-16 Thread Jeff Garzik
On 11/16/2012 11:02 AM, Huang, Shane wrote: I tried word 78 bit 5(Hardware Feature Control) which does not work, it is 0 on my HDD sample with log 30h page 08h and DevSlp supported. Seems that word 78 bit 5 is only the sufficient condition, not the essential condition. Do you guys have suggestio

[git patches] libata fixes

2012-11-16 Thread Jeff Garzik
If you were going to shoot me for not sending these earlier, you would be right. -rc6 beat me by ~2 hours it seems, and they really should have gone out to libata-dev.git and you long before that. These have been in libata-dev.git for a day or so (unfortunately linux-next is on vacation). The m

[git patches] libata minor updates

2013-03-22 Thread Jeff Garzik
Please pull b186affe0c9d39e4d3152cd34bffea8fe1fa17f4 from git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git tags/upstream-linus to receive the following updates: drivers/ata/Kconfig | 13 +++-- drivers/ata/ahci.c| 2 ++ drivers/ata/ata_piix.c

Re: [PATCH] libata-acpi.c: fix copy and paste mistake in ata_acpi_register_power_resource

2013-03-04 Thread Jeff Garzik
On 03/01/2013 06:16 AM, Sander Eikelenboom wrote: Fix a copy and paste mistake introduced in: commit bc9b6407bd6df3ab7189e5622816bbc11ae9d2d8 "ACPI / PM: Rework the handling of devices depending on power resources" Signed-off-by: Sander Eikelenboom --- drivers/ata/libata-acpi.c |2 +- 1

Re: [PATCH 1/1] ahci: Add Device IDs for Intel Wellsburg PCH

2013-03-04 Thread Jeff Garzik
On 02/21/2013 02:08 PM, James Ralston wrote: This patch adds the RAID-mode SATA Device IDs for the Intel Wellsburg PCH Signed-off-by: James Ralston --- drivers/ata/ahci.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) applied [manually] -- To unsubscribe from this list: sen

Re: [PATCH] ata_piix: Add MODULE_PARM_DESC to prefer_ms_hyperv

2013-03-04 Thread Jeff Garzik
On 02/21/2013 02:01 PM, Rado Vrbovsky wrote: From: Andrew Brownfield In reference to the commit cd006086fa5d91414d8ff9ff2b78fbb593878e3c "ata_piix: defer disks to the Hyper-V drivers by default", this trivial patch adds a description to prefer_ms_hyperv. [rvrbo...@redhat.com: MODULE_PARM_DESC(

Re: [PATCH v2] [libata] Avoid specialized TLA's in ZPODD's Kconfig

2013-03-04 Thread Jeff Garzik
On 03/02/2013 12:00 AM, Aaron Lu wrote: ODD is not a common TLA for non-ATA people so they will get confused by its meaning when they are configuring the kernel. This patch fixed this problem by using ODD only after stating what it is. Signed-off-by: Aaron Lu --- v2: Add a space before open par

Re: [PATCH libata/for-3.10-fixes] libata: update "Maintained by:" tags

2013-05-14 Thread Jeff Garzik
On Tue, May 14, 2013 at 2:15 PM, Tejun Heo wrote: > (Removed Linus from cc) > > The following patch has been applied to libata/for-3.10-fixes. Will > push out to Linus with the next batch of updates. > > Thanks! > > From 8c3d3d4b12bf8de8c59fe1eb1bf866a8676ca309 Mon Sep 17 00:00:00 2001 > From: Te

[git patches] libata fixes

2013-04-08 Thread Jeff Garzik
The HDIO_DRIVE_* fix is really the biggie. Please pull 6d3bfc7be6f80d0c6ee6800d58d573343bf6e260 from git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git tags/upstream-linus to receive the following updates: drivers/ata/ata_piix.c| 14 +- drivers/ata/libata-co

Re: [PATCH] AHCI: Make distinct names for ports in /proc/interrupts

2013-04-30 Thread Jeff Garzik
On 04/29/2013 06:12 AM, Alexander Gordeev wrote: Currently all interrupts assigned to AHCI ports show up in '/proc/interrupts' as 'ahci'. This fix adds port numbers as suffixes and hence makes the descriptions distinct. Reported-by: Jan Beulich Signed-off-by: Alexander Gordeev --- drivers/at

[git patches] libata updates

2013-04-30 Thread Jeff Garzik
Summary: 1) More ACPI fixes, cleanups 2) Minor cleanups for sata_highbank, pata_at32, pata_octeon_cf, sata_rcar 3) pata_legacy: small bug found in opti chipset code (untested fix, due to ancient h/w) 4) sata_fsl: RX water mark config knob, some h/w needs it 5) pata_imx: cleanups, Device

Re: [PATCH] sata_highbank: Rename proc_name to the module name

2013-04-30 Thread Jeff Garzik
On 04/30/2013 12:57 PM, Robert Richter wrote: From: Robert Richter mkinitrd looks at /sys/class/scsi_host/host$hostnum/proc_name to find the module name of a disk driver. Current name is "highbank-ahci" but the module is "sata_highbank". Rename it to match the module name. Cc: Rob Herring Cc:

libata maintainership change

2013-05-03 Thread Jeff Garzik
Linux has really found its groove. When I first got involved in Linux, there was no PCI API (now called the hotplug or device API), and patch submission was a moderately painful process of throwing spaghetti at a wall: sending and resending, with both Linus and maintainers having to manually

Re: [GIT PULL] libata maintainership update

2013-05-07 Thread Jeff Garzik
lude/uapi/linux/phantom.h SERIAL ATA (SATA) SUBSYSTEM -M: Jeff Garzik +M: Tejun Heo L:linux-...@vger.kernel.org T:git git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git S:Supported You probably also want to change * the git tree URL quoted above *

Re: [PATCH] drivers: ata: rcar: use devm_ioremap_resource()

2013-04-12 Thread Jeff Garzik
On 04/12/2013 02:51 AM, Silviu-Mihai Popescu wrote: Convert use of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling. This was found with coccinelle. Signed-off-by: Silviu-Mihai Popescu --- drivers/ata/sata_rcar.c |6

Re: [PATCH v4 4/7] scsi: sr: block events when runtime suspended

2012-08-03 Thread Jeff Garzik
On 08/03/2012 05:50 AM, Aaron Lu wrote: Hello, Not sure if I should use EXPORT_SYMBOL or EXPORT_SYMBOL_GPL, any comments? Typically you follow the pattern of similar exports in the file (or in the API, if no others are in the file). Jeff -- To unsubscribe from this list: send t

Re: [PATCH v6 12/13] block: Add bio_clone_bioset(), bio_clone_kmalloc()

2012-08-22 Thread Jeff Garzik
bio_clone_kmalloc() as wrappers around it, making use of the functionality the last patch adedd. This will also help in a later patch changing how bio cloning works. Signed-off-by: Kent Overstreet CC: Jens Axboe CC: NeilBrown CC: Alasdair Kergon CC: Boaz Harrosh CC: Jeff Garzik --- block/blk-core.c

Re: [GIT PULL] tpmdd: TPM drivers, tpm-rng and fixes

2012-08-22 Thread Jeff Garzik
On 08/22/2012 05:52 PM, Kent Yoder wrote: Hi James, The following changes since commit 51b743fe87d7fb3dba7a2ff4a1fe23bb65dc2245: Merge tag 'v3.6-rc2' into next (2012-08-17 20:42:30 +1000) are available in the git repository at: git://github.com/shpedoikal/linux.git v3.6-rc2-tpmdd Ne

[git patches] libata fixes

2012-08-25 Thread Jeff Garzik
Arnd Hannemann (1): pata_atiixp: override cable detection on MSI E350DM-E33 James Ralston (2): ahci: Add Device IDs for Intel Lynx Point-LP PCH ata_piix: Add Device IDs for Intel Lynx Point-LP PCH Jeff Garzik (1): [libata] new quirk, lift bridge limits for Buffalo

Re: Storage related regression in linux-next 20120824

2012-08-27 Thread Jeff Garzik
On Mon, Aug 27, 2012 at 4:59 AM, Arvydas Sidorenko wrote: > linux-next 20120824 introduced regression on Mac mini 2011 - /root partition > gets mounted as read-only and it stays so even when trying to reboot into > previously working kernel. In order to make it work on older kernel again > `fsck`

Re: linux-next: Tree for Sept 14 (sata_highhbank)

2012-09-14 Thread Jeff Garzik
On Fri, Sep 14, 2012 at 11:02 PM, Mark Langsdorf wrote: > Fix patch follows. Do I need to submit it as a separate patch or is this > sufficient? You appear to have submitted it as a separate patch just now ;p Will queue and push to libata-dev.git#upstream (and thus linux-next) Jeff -- To

[PATCH 03/14] [ISDN] Ready HiSax driver for modularization

2008-02-16 Thread Jeff Garzik
* move netjet, isac, arcofi, hscx common sub-modules to new libhisax.ko * export several symbols that are used by external drivers * move DEFAULT_PROTO* deterination to shareable header file * add hotplug and PCI-remove APIs Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/isdn

[PATCH 05/14] [ISDN] HiSax enternow: convert to PCI hotplug API

2008-02-16 Thread Jeff Garzik
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/isdn/hisax/Kconfig|4 +- drivers/isdn/hisax/Makefile |3 +- drivers/isdn/hisax/config.c | 11 + drivers/isdn/hisax/enternow_pci.c | 93 ++--- 4 files chang

[PATCH 07/14] [ISDN] HiSax nj_s, nj_u: convert to PCI hotplug API

2008-02-16 Thread Jeff Garzik
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/isdn/hisax/Kconfig |8 ++-- drivers/isdn/hisax/Makefile |6 ++- drivers/isdn/hisax/config.c | 41 ++ drivers/isdn/hisax/nj_s.c | 100 +++ drivers/isdn/hisax/

[PATCH 06/14] [ISDN] HiSax hfc_pci, w6692: convert to PCI hotplug API

2008-02-16 Thread Jeff Garzik
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/isdn/hisax/Kconfig |8 +- drivers/isdn/hisax/Makefile |4 +- drivers/isdn/hisax/config.c | 66 +-- drivers/isdn/hisax/hfc_pci.c | 142 -- drivers/isdn/hisax/w

[PATCH 08/14] [ISDN] HiSax telespci: convert to PCI hotplug API

2008-02-16 Thread Jeff Garzik
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/isdn/hisax/Kconfig|4 +- drivers/isdn/hisax/Makefile |2 +- drivers/isdn/hisax/config.c | 21 + drivers/isdn/hisax/telespci.c | 95 - 4 files changed, 81 inse

[PATCH 09/14] [ISDN] HiSax avm_pci: convert to modern PCI/ISA/PNP probing

2008-02-16 Thread Jeff Garzik
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/isdn/hisax/Kconfig |4 +- drivers/isdn/hisax/Makefile |2 +- drivers/isdn/hisax/avm_pci.c | 322 ++ drivers/isdn/hisax/config.c | 22 +--- 4 files changed, 235 insertions(+

[PATCH 10/14] [ISDN] HiSax gazel: convert to modern ISA/PCI probing

2008-02-16 Thread Jeff Garzik
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/isdn/hisax/Kconfig |3 +- drivers/isdn/hisax/Makefile |2 +- drivers/isdn/hisax/config.c | 25 + drivers/isdn/hisax/gazel.c | 248 -- 4 files changed, 194 insertions(

[PATCH 11/14] [ISDN] HiSax niccy: convert to modern ISA/PNP/PCI probing

2008-02-16 Thread Jeff Garzik
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/isdn/hisax/Kconfig |3 +- drivers/isdn/hisax/Makefile |2 +- drivers/isdn/hisax/config.c | 26 +--- drivers/isdn/hisax/niccy.c | 460 +++ 4 files changed, 334 insertions(+

[PATCH 12/14] [ISDN] HiSax avm_pci, niccy: minor PNP fixes and cleanups

2008-02-16 Thread Jeff Garzik
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/isdn/hisax/avm_pci.c |9 ++--- drivers/isdn/hisax/niccy.c |2 ++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/isdn/hisax/avm_pci.c b/drivers/isdn/hisax/avm_pci.c index 69f8389..0b420aa 100644

[PATCH 13/14] [ISDN] HiSax diva: convert to modern ISA/PNP/PCI probing

2008-02-16 Thread Jeff Garzik
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/isdn/hisax/Kconfig |3 +- drivers/isdn/hisax/Makefile |3 +- drivers/isdn/hisax/config.c | 27 +--- drivers/isdn/hisax/diva.c | 453 ++- 4 files changed, 283 insertions(+

[PATCH 14/14] [ISDN] HiSax bkm_a8: convert to PCI hotplug API

2008-02-16 Thread Jeff Garzik
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/isdn/hisax/Kconfig |4 +- drivers/isdn/hisax/Makefile |2 +- drivers/isdn/hisax/bkm_a8.c | 186 +- drivers/isdn/hisax/config.c | 48 +--- 4 files changed, 133 insertions(+

Re: 2.6.25-rc1/2 CD/DVD burning broken

2008-02-16 Thread Jeff Garzik
Andreas Schwab wrote: Since commit aaa04c28cb9a1efd42541fdb7ab648231c2a2263 [blk_end_request: changing ide-cd (take 4)] I cannot burn any CD/DVD any more, getting the following error from wodim: Errno: 0 (Success), write_g1 scsi sendcmd: no error CDB: 2A 00 00 00 00 00 00 00 1F 00 status: 0x2 (

Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device

2008-02-17 Thread Jeff Garzik
Boaz Harrosh wrote: On Sat, Feb 16 2008 at 18:37 +0200, Matthew Wilcox <[EMAIL PROTECTED]> wrote: On Wed, Feb 13, 2008 at 10:57:37AM +0200, Boaz Harrosh wrote: I still don't have a card for testing myself. Again anyone wants to send me a card. Intel people anybody home? Apparently Intel sold t

Re: Plans for mISDN? Was: [PATCH 00/14] [ISDN] ...

2008-02-18 Thread Jeff Garzik
Andi Kleen wrote: Merging essentially untested patches does not seem like a good strategy. Agreed. I don't want my stuff going in without knowing it works. And there is definitely still a large ISDN user base too. This is what I'm curious about. My personal guess is that there is a lot

Re: [BUG] Linux 2.6.25-rc2 - Kernel Ooops while running dbench

2008-02-18 Thread Jeff Garzik
Two x86-64 boxes here lock up here on 2.6.25-rc2, shortly after boot. One running Fedora 8 + X (GNOME) and one a headless file server. configs and lspci attached. Unable to capture any splatter so far. Bisecting... 00:00.0 Host bridge: Intel Corporation 82955X Memory Controller Hub 00:01.0 P

Re: random wedges with 2.6.25-rc*

2008-02-19 Thread Jeff Garzik
Pierre Ossman wrote: Somewhere post 2.6.24, the kernel started getting very temperamentful. I experience random hangs and wedges very often. Primarily, the udev startup locks up. If I abort it, it just locks up on more or less every action after that. Some quick debugging showed that I had a w

Re: [PATCH 0/8] AMD opteron mm config numa etc

2008-02-19 Thread Jeff Garzik
Yinghai Lu wrote: please check some amd opteron related mmconf and numa patches could make up for system that system have acpi problem or still can mmconf and numa when acpi=off ACK for my parts (stuff associated with PCI domain support on x86) Jeff -- To unsubscribe from this lis

Re: linux-next: Tree for Feb 20

2008-02-19 Thread Jeff Garzik
Greg KH wrote: On Wed, Feb 20, 2008 at 04:34:57PM +1100, Stephen Rothwell wrote: Hi all, I have created today's linux-next tree at git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git. You can see which trees have been included by looking in the Next/Trees file in the source. Ther

Re: [PATCH] ehea: add kdump support

2008-02-20 Thread Jeff Garzik
Thomas Klein wrote: This patch adds kdump support to the ehea driver. As the firmware doesn't free resource handles automatically, the driver has to run an as simple as possible free resource function in case of a crash shutdown. The function iterates over two arrays freeing all resource handles

Re: [PATCH] drivers/net/cs89x0.c: compilation warning fix

2008-02-20 Thread Jeff Garzik
Leonardo Potenza wrote: From: Leonardo Potenza <[EMAIL PROTECTED]> Suppress the warning message about the 'netcard_portlist' defined but not used. Signed-off-by: Leonardo Potenza <[EMAIL PROTECTED]> --- When building cs89x0 as a module, the following warning message is generated: drivers/net/c

Re: [PATCH] tlan: add static to function definitions

2008-02-20 Thread Jeff Garzik
Harvey Harrison wrote: The forward declarations were already marked static, make the definitions be static as well. Fixes the sparse warnings as well. drivers/net/tlan.c:1403:5: warning: symbol 'TLan_HandleInvalid' was not declared. Should it be static? drivers/net/tlan.c:1435:5: warning: symb

Re: [2.6 patch] net/phy/mdio_bus.c: fix a check-after-use

2008-02-20 Thread Jeff Garzik
Adrian Bunk wrote: This patch fixes a check-after-use spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 6beeb3ac577d74d72b2f91bd654eecb904c3c17e diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 6e9f619..963630c 100644 --- a/drivers/ne

XFS makefile-2.6 lives on

2008-02-20 Thread Jeff Garzik
In current upstream, fs/xfs/Makefile-linux-2.6 is zero bytes, which means 'make distclean' deletes, and git promptly (and properly) squawks about a working tree/index difference. Would somebody please delete this file? Thanks, Jeff -- To unsubscribe from this list: send the line "un

Re: [PATCH] Add PCI_DEVICE_TABLE macro

2008-02-20 Thread Jeff Garzik
Greg KH wrote: On Mon, Feb 18, 2008 at 08:34:42AM +0100, Jonas Bonn wrote: And again, what does this buy us? Clarity and simplicity, I hope... there are a bunch of definitions scattered about the kernel that omit the __devinitdata modifier despite the documentation stating that it should alway

Re: [PATCH 11/11v2] ata: fix sparse warnings in pata_legacy.c

2008-02-20 Thread Jeff Garzik
Harvey Harrison wrote: Use ld_qdi and ld_winbond to avoid shadowing static int variables qdi and winbond. The ld_ prefix refers to legacy_data. drivers/ata/pata_legacy.c:777:21: warning: symbol 'qdi' shadows an earlier one drivers/ata/pata_legacy.c:128:12: originally declared here drivers/ata/p

Re: [PATCH] libata: Register for dock events when the drive is inside a dock station

2008-02-20 Thread Jeff Garzik
Holger Macht wrote: On Thu 14. Feb - 13:40:48, Holger Macht wrote: If a device/bay is inside a docking station, we need to register for dock events additionally to bay events. If a dock event occurs, the dock driver will call the appropriate handler (ata_acpi_ap_notify() or ata_acpi_dev_notify()

Re: [PATCH] ata: replace macro with static inline in libata.h

2008-02-20 Thread Jeff Garzik
ned-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Andrew, here is a patch that drastically reduces the number of sparse warnings in libata. Alan Cox has suggested a clamp_t macro be added to kernel.h instead to avoid this issue. I don't believe Jeff Garzik has given an opinion yet (other

[git patches] libata fixes

2008-02-20 Thread Jeff Garzik
Note: Tejun's change is a feature addition, but one that is IMO important for debugging and serious-bug workarounds. It's self-contained and should not affect anyone not using the new parm. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-de

[git patches] net driver fixes

2008-02-20 Thread Jeff Garzik
Note: this is based off of Linus's latest commit (5d9c4a7de64d398604a978d267a6987f1f4025b7), since all my previous submissions are now upstream (thanks!). Please pull from 'upstream-davem' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-davem to receive t

Re: [bug] Re: [PATCH 4/12] riscom8: fix SMP brokenness

2008-02-20 Thread Jeff Garzik
Ingo Molnar wrote: * Jeff Garzik <[EMAIL PROTECTED]> wrote: After analyzing the elements that save_flags/cli/sti/restore_flags were protecting, convert their usages to a global spinlock (the easiest and most obvious next-step). There were some usages of flags being intentionally

Re: [git patches] net driver updates

2008-02-20 Thread Jeff Garzik
Divy Le Ray wrote: Jeff Garzik wrote: Mostly fixes, a few cleanups (generally assisting fixes), and an exception for PS3 wireless because it had been posted, reviewed and acked for a while, just not committed. Please pull from 'upstream-davem' branch of master.kernel.org:/pub/scm/li

Re: power_state: get rid of write-only variable in SATA

2008-02-21 Thread Jeff Garzik
Pavel Machek wrote: power_state is scheduled for removal, and libata uses it in write-only mode. Remove it. Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index b4985bc..a31572d 100644 --- a/drivers/ata/libata-core.c +++ b/driv

Re: Merging of completely unreviewed drivers

2008-02-21 Thread Jeff Garzik
Krzysztof Halasa wrote: Jeff Garzik <[EMAIL PROTECTED]> writes: If a driver is full of lines of length >80, that's a problem. I'm not sure. We all have more than 80-chars wide displays for years, don't we? The Every time this discussion comes up, people point out

Re: [GIT PULL] XFS update for 2.6.25-rc3

2008-02-21 Thread Jeff Garzik
Lachlan McIlroy wrote: Remove empty file fs/xfs/Makefile-linux-2.6. Already in the upstream kernel... commit 1803f3389b7ac9ed33ea561b3b94e22e2864a95d Author: Linus Torvalds <[EMAIL PROTECTED]> Date: Wed Feb 20 19:55:09 2008 -0800 Remove empty file remnants that were left in the tr

Re: [GIT PULL] Update LZO compression

2012-08-16 Thread Jeff Garzik
On 08/16/2012 02:27 AM, Markus F.X.J. Oberhumer wrote: On 2012-08-15 16:45, Johannes Stezenbach wrote: On Wed, Aug 15, 2012 at 02:02:43PM +0200, Markus F.X.J. Oberhumer wrote: On 2012-08-14 14:39, Johannes Stezenbach wrote: On Tue, Aug 14, 2012 at 01:44:02AM +0200, Markus F.X.J. Oberhumer wrot

Re: [patch] [SCSI] mvsas: fix a && vs & bug

2012-08-16 Thread Jeff Garzik
On 08/16/2012 07:04 AM, Dan Carpenter wrote: The "1 << (slot_idx % 32)" condition is always true. The intent was to test a bit field here using bitwise AND. We do the test correctly a few lines later in the do while loop. Signed-off-by: Dan Carpenter Acked-by: Jeff

Re: [PATCH 0/5] x86, MSI, AHCI: Support multiple MSIs

2012-08-16 Thread Jeff Garzik
On 08/16/2012 10:45 AM, Alexander Gordeev wrote: Currently multiple MSI mode is limited to a single vector per device (at least on x86 and PPC). This series breathes life into pci_enable_msi_block() and makes it possible to set interrupt affinity for multiple IRQs, similarly to MSI-X. Yet, only f

<    1   2   3   4   5   6   7   8   9   10   >