Re: [RFT 06/25] ARM: dts: s5pv210: move fixed clocks under root node

2020-09-07 Thread Jonathan Bakker
Works for me on the Galaxy S. Tested-by: Jonathan Bakker Thanks, Jonathan On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote: > The fixed clocks are kept under dedicated 'external-clocks' node, thus a > fake 'reg' was added. This is not correct with dtschema as fixe

Re: [RFT 07/25] ARM: dts: s5pv210: move PMU node out of clock controller

2020-09-07 Thread Jonathan Bakker
Works for me on the Galaxy S. Tested-by: Jonathan Bakker Thanks, Jonathan On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote: > The Power Management Unit (PMU) is a separate device which has little > common with clock controller. Moving it to one level up (from clock > controller chi

Re: [RFT 08/25] ARM: dts: s5pv210: remove dedicated 'audio-subsystem' node

2020-09-07 Thread Jonathan Bakker
Audio still works for me on the Galaxy S. Tested-by: Jonathan Bakker Thanks, Jonathan On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote: > The 'audio-subsystem' node is an artificial creation, not representing > real hardware. The hardware is described by its nodes - AUDSS cl

Re: [RFT 24/25] ARM: dts: s5pv210: align SPI GPIO node name with dtschema in Aries

2020-09-07 Thread Jonathan Bakker
Works for me on the Galaxy S. Tested-by: Jonathan Bakker Thanks, Jonathan On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote: > The device tree schema expects SPI controller to be named "spi", > otherwise dtbs_check complain with a warning like: > > spi-gpio-0: $n

Re: [RFT 09/25] ARM: dts: s5pv210: fix number of I2S DAI cells

2020-09-07 Thread Jonathan Bakker
Sadly, this is causing issues for me. The machine driver is no longer probing correctly on the Galaxy S. The failing call in sound/soc/samsung/aries_wm8994.c is /* Set CPU of_node for BT DAI */ aries_dai[2].cpus->of_node = of_parse_phandle(cpu, "sound-dai

Re: [PATCH 11/25] ARM: dts: s5pv210: add RTC 32 KHz clock in Aries family

2020-09-07 Thread Jonathan Bakker
Hi Krzysztof, On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote: > The S3C RTC requires 32768 Hz clock as input which is provided by PMIC. > However there is no such clock provider but rather a regulator driver > which registers the clock as a regulator. This is an old driver which > will not be

Re: [RFT 25/25] ARM: dts: s5pv210: align DMA channels with dtschema

2020-09-07 Thread Jonathan Bakker
Initial testing on both an i9000 and an SGH-T959P are showing that the audio has stopped working with this. I'm not 100% convinced as I've had DMA issues in the past. However trying to play something just results in a hang after 1.5s while it works just fine without this patch. Thanks, Jonathan

Re: [RFT 25/25] ARM: dts: s5pv210: align DMA channels with dtschema

2020-09-07 Thread Jonathan Bakker
Ah, I figured out why the dma stopped working. In s5pv210-aries.dtsi the dma's for i2s0 are overriden to use pdma0 instead of pdma1. That also needs changing for this to work properly. Thanks, Jonathan On 2020-09-07 5:17 p.m., Jonathan Bakker wrote: > Initial testing on both an i900

Re: [PATCH 10/11] media: exynos4-is: Prevent duplicate call to media_pipeline_stop

2020-07-24 Thread Jonathan Bakker
Hi Tomasz, On 2020-07-20 6:10 a.m., Tomasz Figa wrote: > On Sat, Jul 11, 2020 at 8:17 PM Jonathan Bakker wrote: >> >> Hi Tomasz, >> >> On 2020-07-07 11:44 a.m., Tomasz Figa wrote: >>> Hi Jonathan, >>> >>> On Sat, Apr 25, 2020 at 07:26:49PM

Re: [PATCH 03/11] media: exynos4-is: Fix nullptr when no CSIS device present

2020-07-11 Thread Jonathan Bakker
Hi Sylwester and Tomasz, On 2020-07-08 8:11 a.m., Sylwester Nawrocki wrote: > Hi, > > On 07.07.2020 19:55, Tomasz Figa wrote: >> On Sat, Apr 25, 2020 at 07:26:42PM -0700, Jonathan Bakker wrote: >>> Not all devices use the CSIS device, some may use the FIMC directly in

Re: [PATCH 04/11] media: exynos4-is: Correct missing entity function initialization

2020-07-11 Thread Jonathan Bakker
Hi Sylwester and Tomasz, On 2020-07-08 8:34 a.m., Sylwester Nawrocki wrote: > Hi, > > On 07.07.2020 20:09, Tomasz Figa wrote: >> On Sat, Apr 25, 2020 at 07:26:43PM -0700, Jonathan Bakker wrote: >>> Commit bae4500399c4 ("[media] exynos4-is: Add missing entity functi

Re: [PATCH 06/11] media: exynos4-is: Properly set JPEG options when not using CSIS

2020-07-11 Thread Jonathan Bakker
Hi Sylwester and Tomasz, On 2020-07-08 8:45 a.m., Sylwester Nawrocki wrote: > Hi, > > On 07.07.2020 20:23, Tomasz Figa wrote: >> On Sat, Apr 25, 2020 at 07:26:45PM -0700, Jonathan Bakker wrote: >>> Commit ee7160e57c98 ("[media] s5p-fimc: Add support for JPEG capture

Re: [PATCH 07/11] media: exynos4-is: Add support for multiple sensors on one port

2020-07-11 Thread Jonathan Bakker
Hi Tomasz, On 2020-07-07 11:36 a.m., Tomasz Figa wrote: > On Sat, Apr 25, 2020 at 07:26:46PM -0700, Jonathan Bakker wrote: >> On some devices, there may be multiple camera sensors attached >> to the same port. Make sure we probe all of them, not just the >> first one

Re: [PATCH 10/11] media: exynos4-is: Prevent duplicate call to media_pipeline_stop

2020-07-11 Thread Jonathan Bakker
Hi Tomasz, On 2020-07-07 11:44 a.m., Tomasz Figa wrote: > Hi Jonathan, > > On Sat, Apr 25, 2020 at 07:26:49PM -0700, Jonathan Bakker wrote: >> media_pipeline_stop can be called from both release and streamoff, >> so make sure they're both protected under the streaming f

Re: [PATCH 11/11] media: exynos4-is: Correct parallel port probing

2020-07-11 Thread Jonathan Bakker
Hi Sylwester, On 2020-07-08 9:15 a.m., Sylwester Nawrocki wrote: > Hi, > > On 26.04.2020 04:26, Jonathan Bakker wrote: >> According to the binding doc[1], port A should be reg = 0 >> and port B reg = 1. Unfortunately, the driver was treating 0 >> as invalid and 1 a

Re: [PATCH 05/11] media: exynos4-is: Improve support for sensors with multiple pads

2020-07-11 Thread Jonathan Bakker
Hi Tomasz, On 2020-07-07 11:13 a.m., Tomasz Figa wrote: > Hi Jonathan, > > On Sat, Apr 25, 2020 at 07:26:44PM -0700, Jonathan Bakker wrote: >> Commit 1c9f5bd7cb8a ("[media] s5p-fimc: Add support for sensors with >> multiple pads") caught the case where

Re: [PATCH 2/5] input: misc: bma150: Conditionally disable bma023 support

2020-05-06 Thread Jonathan Bakker
Hi Linus, On 2020-05-06 5:46 a.m., Linus Walleij wrote: > On Sun, May 3, 2020 at 7:22 PM Jonathan Bakker wrote: > >> The bma180 IIO driver has been extended for support for bma023. >> However, this could cause conflicts with this driver. Since some >> setups may dep

Re: [PATCH 0/5] iio: accel: Add bma023 support to bma180

2020-05-06 Thread Jonathan Bakker
Hi Linus, On 2020-05-06 5:47 a.m., Linus Walleij wrote: > On Sun, May 3, 2020 at 7:22 PM Jonathan Bakker wrote: > >> This patchset adds support for the bma023 three axis accelerometer >> to the bma180 IIO driver. The bma023 is found on several ~2010 >> phones, includin

Re: [PATCH] tty: serial: samsung: Correct clock selection logic

2020-05-11 Thread Jonathan Bakker
Hi Krzysztof, On 2020-05-11 3:08 a.m., Krzysztof Kozlowski wrote: > On Fri, May 08, 2020 at 06:34:33PM -0700, Jonathan Bakker wrote: >> Some variants of the samsung tty driver can pick which clock >> to use for their baud rate generation. In the DT conversion, >> a default

Re: [PATCH 2/5] input: misc: bma150: Conditionally disable bma023 support

2020-05-08 Thread Jonathan Bakker
H Dmitry, On 2020-05-06 9:23 p.m., Dmitry Torokhov wrote: > On Wed, May 06, 2020 at 08:46:12PM -0700, Jonathan Bakker wrote: >> Hi Linus, >> >> On 2020-05-06 5:46 a.m., Linus Walleij wrote: >>> On Sun, May 3, 2020 at 7:22 PM Jonathan Bakker wrote: >>> >&

Re: [PATCH 0/2] iio: adc: Add a current from voltage driver

2020-05-16 Thread Jonathan Bakker
Oops, sorry about that, you're absolutely right. The current-sense-shunt part of iio-rescale is exactly what I was looking for. Thanks, Jonathan On 2020-05-15 11:28 p.m., Lars-Peter Clausen wrote: > On 5/16/20 4:26 AM, Jonathan Bakker wrote: >> In the discussion around adding the

[PATCH 1/2] dt-bindings: mfd: max8998: Document charger regulator

2020-05-16 Thread Jonathan Bakker
max8998 has a current regulator for control of its charging current. Document it. Signed-off-by: Jonathan Bakker --- Documentation/devicetree/bindings/mfd/max8998.txt | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/max8998.txt b/Documentation

[PATCH 2/2] regulator: max8998: Add charger regulator

2020-05-16 Thread Jonathan Bakker
have been extracted from a downstream driver for the SGH-T959V. Signed-off-by: Jonathan Bakker --- drivers/regulator/max8998.c | 105 include/linux/mfd/max8998.h | 1 + 2 files changed, 106 insertions(+) diff --git a/drivers/regulator/max8998.c b/drivers

[PATCH] power: supply: max8998_charger: Correct ONLINE and add STATUS props

2020-05-16 Thread Jonathan Bakker
. Signed-off-by: Jonathan Bakker --- drivers/power/supply/max8998_charger.c | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/drivers/power/supply/max8998_charger.c b/drivers/power/supply/max8998_charger.c index 9a926c7c0f22..c26023b19f26 100644 --- a

Re: [PATCH 2/2] regulator: max8998: Add charger regulator

2020-05-17 Thread Jonathan Bakker
lore.kernel.org/lkml/20110709030853.ga23...@opensource.wolfsonmicro.com/ On 2020-05-16 12:47 p.m., Jonathan Bakker wrote: > The max8998 has a current regulator for charging control. The > charger driver in drivers/power/supply/max8998_charger.c has a > comment in it stating that 'charger control is done b

<    1   2