ng forever to have them acked I deciced
> to fix the warnings in the current kernel.
>
> This for no other reason than to get the noise level down.
>
> Andrew - I expect you to pick them up in -mm and forward to Linus.
>
Yes these fixes should go in, Acked.
--
Karsten Keil
SuSE
Am 25.07.2013 00:05, schrieb Greg Kroah-Hartman:
> The dev_attrs field of struct class is going away soon, dev_groups
> should be used instead. This converts the mISDN class code to use the
> correct field.
>
> Cc: Karsten Keil
> Signed-off-by: Greg Kroah-Hartman
Acke
Am 03.08.2012 09:32, schrieb Fengguang Wu:
> On Thu, Aug 02, 2012 at 04:21:56PM -0700, David Miller wrote:
>> From: Fengguang Wu
>> Date: Thu, 2 Aug 2012 19:05:43 +0800
>>
>>> Fix a buffer overflow bug by removing the revision transform code.
>>>
>>> [ 22.016214] isdnloop-ISDN-driver Rev 1.11.6.
race conditions.
The new design only has one core module and hardware specific modules
with a very simple interface.
The interface to the userspace are sockets (one per channel).
--
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, H
Hi,
seems that somehow isdn.h changes get lost during the merge.
Following patch fix this and some other minor things.
--
Karsten Keil
SuSE Labs
ISDN development
diff -urN linux-2.4.4p5.org/drivers/isdn/hisax/md5sums.asc
linux/drivers/isdn/hisax/md5sums.asc
--- linux-2.4.4p5.org/drivers
On Fri, Apr 20, 2001 at 08:17:09PM +0200, Hans-Joachim Baader wrote:
> Hi,
>
> in case it isn't already known:
>
> isdn_net.c: In function `isdn_ciscohdlck_dev_ioctl':
> isdn_net.c:1455: structure has no member named `cisco_keepalive_period'
>
Fix was poste
'm not really worried about
> this, but I thought I'd report it anyway since 'someone more
> knowledgeable than me (TM)' might find it important...
Not a real problem (only cosmetics) and a patch is pending.
--
Karsten Keil
SuSE Labs
ISDN development
-
To unsubscribe f
e IRQs.
> What I wonder is why linux outputs a line like this (with noapic):
> <4>Intel MultiProcessor Specification v1.1
> <4>Virtual Wire compatibility mode.
>
> although the board seems to be capable of MPS 1.4 (as there is a Bios
> option "MPS 1.4 for sin
uot;unsubscribe linux-kernel" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Karsten Keil
SuSE Labs
ISDN development
-
To unsubscribe from this list: send the li
kups stored on blocks:
32768, 98304, 163840
Don't miss the -n option !!!
e2fsck -b 32768 /dev/sdb3
Here are also some howtos related to restoring data and undelete files.
--
Karsten Keil
SuSE Labs
ISDN development
-
To unsubscribe from this list: send the line "unsubscrib
l: ISDN subsystem Rev: 1.111/1.93/1.135/1.77/1.21/1.5
> Oct 1 23:49:14 penny kernel: Uniform Multi-Platform E-IDE driver Revision: 6.31
>
> Is there something that is changed and that I should know ?
>
Nothing so far I know, seems HiSax was not selected or compiled as module.
t's wrong with it?
Nothing. Only the HFC-PCI part in hisax has such a table yet, all other
card drivers in hisax don't have one at the moment.
--
Karsten Keil
SuSE Labs
ISDN development
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of
On Tue, Apr 19, 2005 at 02:46:58AM +0200, Adrian Bunk wrote:
> This patch makes some needlessly global code static.
>
Yes, OK.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: Karsten Keil <[EMAIL PROTECTED]>
drivers/isdn/hardware/eicon/dadapter.c |2 +-
Hi,
We do not longer use DLT_LINUX_SLL for activ/pass filters but
DLT_PPP_WITHDIRECTION
witch need 1 as outbound flag.
Please apply.
Signed-off-by: Karsten Keil <[EMAIL PROTECTED]>
diff -urN linux-2.6.12-rc2.org/drivers/isdn/i4l/isdn_ppp.c
linux-2.6.12-rc2/drivers/isdn/i4l/isdn
On Thu, Apr 21, 2005 at 03:17:21PM +0200, Patrick McHardy wrote:
> Karsten Keil wrote:
> >Hi,
> >
> >We do not longer use DLT_LINUX_SLL for activ/pass filters but
> >DLT_PPP_WITHDIRECTION
> >witch need 1 as outbound flag.
> >Please apply.
>
>
(KERN_NOTICE "capifs: Rev %s\n", rev);
--
Karsten Keil
SuSE Labs
ISDN development
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
in this function
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
Signed-off-by: Karsten Keil <[EMAIL PROTECTED]>
---
drivers/isdn/i4l/isdn_v110.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.13-orig/drivers/isdn/i4l/isdn_v110.c 2005-08-29
01:4
Fix against access random data bytes outside the
dev->chanmap array. Thanks to Oliver Neukum for
pointing me to this issue.
Patch is against 2.6.23-rc9-git6
Signed-off-by: Karsten Keil <[EMAIL PROTECTED]>
---
drivers/isdn/i4l/isdn_common.c |5 +++--
1 files changed, 3 inserti
off-by: Miklos Szeredi <[EMAIL PROTECTED]>
Acked-by: Karsten Keil <[EMAIL PROTECTED]>
> ---
>
> Index: linux/drivers/isdn/capi/capifs.c
> ===
> --- linux.orig/drivers/isdn/capi/capifs.c 2007-10-09 22:31:38.
turn code changes
in 2.6.10, it now always returns 0 (if no error), but < 2.6.10 did return
the number of detected devices, which was tested in this driver.
This is fixed since last week in our CVS.
--
Karsten Keil
SuSE Labs
ISDN development
-
To unsubscribe from this list: send the line "uns
p' defined but not used
> Please apply.
>
Agree.
Signed-off-by: Karsten Keil <[EMAIL PROTECTED]>
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
--- linux-2.6.11-rc2-bk7-orig/drivers/isdn/hisax/hisax_fcpcipnp.c
2005-01-22 21:59:37.0 +0100
+++ linux-2.6.11-rc2-b
off-by: Karsten Keil <[EMAIL PROTECTED]>
diff -ur linux-2.6.11-rc2.org/drivers/isdn/hisax/isdnhdlc.c
linux-2.6.11-rc2/drivers/isdn/hisax/isdnhdlc.c
--- linux-2.6.11-rc2.org/drivers/isdn/hisax/isdnhdlc.c 2004-11-23
15:53:25.0 +0100
+++ linux-2.6.11-rc2/drivers/isdn/hisax/isdnhdlc.c 20
f a worry, but it
> > appears that everything will work OK.
> >
> > That being said, I'd prefer that this come in via the ISDN team, after
> > having been tested please.
>
> I believe last update from ISDN team was 13 months ago. :-(
You are wrong. Last update was f
ssue here.
>
I also prefer the old code, since it make clear, that you must be careful
here, since the function can be called with already freed db->dict, and for
me this version is not better readable as the old one.
--
Karsten Keil
SuSE Labs
ISDN development
-
To unsubscribe from this list
pci_module_init(&tpam_driver);
> + ret = pci_register_driver(&tpam_driver);
> if (ret)
> return ret;
> printk(KERN_INFO "TurboPAM: %d card%s found, driver loaded.\n",
Note:
All changes to code drivers/isdn/tpam are obsolate, since the co
h to remove tpam to Andrew?
>
:-) already done few houres ago (against -mm2)
--
Karsten Keil
SuSE Labs
ISDN development
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
with md5sums was not updated in the isdn driver.
--
Karsten Keil
SuSE Labs
ISDN development
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.htm
and do not look at code style
yet.
> - conversion to proper pci API
??? the driver is not PCI related at all
--
Karsten Keil
SuSE Labs
ISDN development
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTE
On Mon, Jan 24, 2005 at 11:26:03PM +, Christoph Hellwig wrote:
> On Mon, Jan 24, 2005 at 09:36:24PM +0100, Karsten Keil wrote:
> > > - conversion to proper pci API
> >
> > ??? the driver is not PCI related at all
>
> Sorry, this was actually a comment for i4l-
io((void*)(sc_adapter[card]->rambase + dest_rem), src, n);
> spin_unlock_irqrestore(&sc_adapter[card]->lock, flags);
> pr_debug("%s: set page to %#x\n",sc_adapter[card]->devicename,
> ((sc_adapter[card]->shmem_magic + ch *
> SRAM_PAGESIZ
* change #warning to a code comment
* add comment and special ifdef'd 64-bit code for a situation where
we must store a pointer into a CAPI field 'Data', which is fixed by
the interface at 32 bits.
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
Acked-by: Karsten K
ll
> better than crashing the whole system.
>
> (ps. please Cc me on replies from the isdn4linux list since I'm not
> subscribed
> there)
>
>
> Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
Acked-by: Karsten Keil <[EMAIL PROTECTED]>
> ---
>
&g
def.contr); in line 823 returns NULL, then
> we'll be dereferencing a NULL pointer in the very next line.
>
> (Found by Coverity checker as bug #402)
>
>
> Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
Acked-by: Karsten Keil <[EMAIL PROTECTED]>
> ---
&g
On Sun, Jul 29, 2007 at 11:41:05PM +0200, Matthias Kaehlcke wrote:
> The ISDN subsystem common functions use a semaphore as mutex. Use the
> mutex API instead of the (binary) semaphore.
>
> Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]>
>
Acked-by: Karsten K
;
> 407: if (Read_hfc(cs, HFCSX_INT_S2)) ;
> 1246: if (Read_hfc(cs, HFCSX_INT_S1)) ;
> --
These are workaround to not get compiler warnings about ignored return
values I got some time ago under some architecture.
--
Karsten Keil
SuSE Labs
ISDN and VOIP developm
One call was missing in the previous patch.
Signed-off-by: Karsten Keil <[EMAIL PROTECTED]>
---
drivers/isdn/hardware/avm/c4.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/isdn/hardware/avm/c4.c b/drivers/isdn/hardware/avm/c4.c
index 4c6ef91..d69c05e
This fix the hard freeze debuged for AVM C4 cards using
the b1dma interface.
Signed-off-by: Karsten Keil <[EMAIL PROTECTED]>
---
drivers/isdn/hardware/avm/b1dma.c | 28 +++-
1 files changed, 19 insertions(+), 9 deletions(-)
diff --git a/drivers/isdn/hardwa
This fix the hard freeze debuged for AVM C4 cards
for the AVM T1 cards.
Signed-off-by: Karsten Keil <[EMAIL PROTECTED]>
---
drivers/isdn/hardware/avm/t1isa.c | 28
1 files changed, 12 insertions(+), 16 deletions(-)
diff --git a/drivers/isdn/hardware/avm/t1is
ilable.
* no need to use 'irq' function arg, its stored in a data struct already
Acked-by: Karsten Keil <[EMAIL PROTECTED]>
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
drivers/isdn/act2000/act2000_isa.c | 12
1 file changed,
Acked-by: Karsten Keil <[EMAIL PROTECTED]>
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
drivers/isdn/sc/init.c |3 ++-
drivers/isdn/sc/interrupt.c | 17 ++---
2 files changed, 4 insertions(+), 16 deletions(-)
ebf0fb18d5c19bb0201912850d14a9fda292ee0e
diff --
pr_debug("%s: set page to %#x\n",sc_adapter[card]->devicename,
> ((sc_adapter[card]->shmem_magic + ch *
> SRAM_PAGESIZE)>>14)|0x80);
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of
nccip->ncci, /* adr */
> - (u32) skb->data, /* Data */
> + (unsigned long) skb->data, /* Data */
> skb->len, /* DataLength */
> datahandle, /* DataHandle */
.
>
> Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
> ---
> drivers/isdn/capi/capidrv.c |3 ++-
Acked.
--
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB
16746 (AG Nuernberg)
-
To unsubscribe from thi
that gets copied
> into -mm for testing, though some changes have been there longer than
> others.
>
> All these changes are code movement changes, without any changes to the
> logic -- even the existing whitespace funnies were kept in many cases.
>
> Would you mind pulling these,
called routines, so the additional
performance penalty is minimal.
Signed-off-by: Karsten Keil <[EMAIL PROTECTED]>
Signed-off-by: Rainer Brestan <[EMAIL PROTECTED]>
Signed-off-by: Ralf Schlatterbeck <[EMAIL PROTECTED]>
---
drivers/isdn/hardware/avm/c4.c | 16
1
.
Signed-off-by: Karsten Keil <[EMAIL PROTECTED]>
---
drivers/isdn/hardware/avm/b1.c | 28 +---
1 files changed, 13 insertions(+), 15 deletions(-)
diff --git a/drivers/isdn/hardware/avm/b1.c b/drivers/isdn/hardware/avm/b1.c
index 7a69a18..4484a64 100644
--- a/driver
tire part of the tree can just be junked. but if
> it's sticking around, it should probably be fixed.
>
Yes thanks for discover this. Since the code only affect the
analyse of the AOC info which is pure information only without real
function it was not detected before.
--
Karste
t if
> it's still in actual use, then it really should be re-labelled from
> "obsolete" to "deprecated," no?
>
Good point.
--
Karsten Keil
SuSE Labs
ISDN development
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Tue, Jan 16, 2007 at 11:53:19AM +0200, Ahmed S. Darwish wrote:
> Hi all,
>
> A trivial patch to use ARRAY_SIZE macro defined in kernel.h instead
> of reimplementing it.
>
> Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]>
Acked-by: Karsten Keil <[EMAIL PRO
x27; variables with %p,
> rather than using incorrect casts that throw warnings
>
> Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
>
Acked-by: Karsten keil <[EMAIL PROTECTED]>
> diff --git a/drivers/isdn/hisax/diva.c b/drivers/isdn/hisax/diva.c
> index 3dacfff..
On Sat, Nov 25, 2006 at 08:15:04PM +0100, Adrian Bunk wrote:
> HISAX_AMD7930 was never anywhere near to being working, and this doesn't
> seem to change in the forseeable future.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
>
Acked-by: Karsten Keil <[EMAIL
replaces various array size calculations in drivers/isdn/hisax
done using sizeof with the ARRAY_SIZE macro.
Signed-off-by: Karsten Keil <[EMAIL PROTECTED]>
Signed-off-by: Andi Drebes <[EMAIL PROTECTED]>
---
drivers/isdn/hisax/callc.c |4 +--
drivers/isdn/hisax/isdnl1.c
Replacing pci_find_device with pci_get_device in the
drivers/isdn subtree.
Signed-off-by: Karsten Keil <[EMAIL PROTECTED]>
Signed-off-by: Surya Prabhakar <[EMAIL PROTECTED]>
---
drivers/isdn/hisax/avm_pci.c | 19 ++
drivers/isdn/hisax/bkm_a4t.c | 15 +
I noticed that CLIR (aka "hide your calling number") in isdn_tty is broken:
The at-command parser filters out the required "R" (e.g. ATDR089123456)
It's been broken for a *very* long time.
Signed-off-by: Karsten Keil <[EMAIL PROTECTED]>
Signed-off-by: M
-comment "CAPI subsystem"
> -
> config ISDN_CAPI
> - tristate "CAPI2.0 support"
> + tristate "CAPI 2.0 subsystem"
> help
> This provides the CAPI (Common ISDN Application Programming
> Interface, a standard making it easy fo
3,7 +1133,7 @@ static struct InformationElement we_0[] =
> {WE0_userInfo, "User Info", general}
> };
>
> -#define WE_0_LEN (sizeof(we_0) / sizeof(struct InformationElement))
> +#define WE_0_LEN ARRAY_SIZE(we_0)
>
> static struct InformationElement we_6[] =
> {
>
The similar code exists here and is called capi_driver_get_idx().
Use generic helpers now and remember to convert list_head to
struct capi_driver in .show callback.
Acked-by: Karsten Keil <[EMAIL PROTECTED]>
Signed-off-by: Pavel Emelianov <[EMAIL PROTECTED]>
---
diff --git a/drive
fications, like s/kmalloc/kzalloc/, use of gfp_mask,
> and the allocation of cs->rcvbuf was moved up to be with the rest of the
> memory allocations.
>
> Further changes will be checked into this git branch:
>
> The 'isdn-pci' branch of
> git://git.kernel.org/pub/
On Tue, May 22, 2007 at 12:46:16PM -0400, Jeff Garzik wrote:
> Karsten Keil wrote:
> >So what is the reason to do this now, does this block some changes in
> >other places ? I did not change this code for long time because I know
> >that this is a nightmare, the cod
);
> return -ENOMEM;
> @@ -1576,7 +1576,7 @@ static void __exit capi_exit(void)
> {
> proc_exit();
>
> - class_device_destroy(capi_class, MKDEV(capi_major, 0));
> + device_destroy(capi_class, MKDEV(capi_major, 0));
> class_destroy(capi_class);
On Fri, Aug 24, 2007 at 02:09:34AM +0200, Jesper Juhl wrote:
> vmalloc() returns a void pointer - no need to cast the return value.
>
> Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
Acked-by: Karsten Keil <[EMAIL PROTECTED]>
> ---
> drivers/isdn/i4l/isdn_bsdcomp.c |
[PATCH] isdn/sc: remove unused REQUEST_IRQ and unnecessary
REQUEST_IRQ is never used, so delete it. In the process get rid of the
macro FREE_IRQ which makes the code unnecessarily difficult to read.
Signed-off-by: Fernando Luis Vazquez Cao <[EMAIL PROTECTED]>
Acked-by: Karsten Keil &
Am 26.02.2014 12:01, schrieb Arnd Bergmann:
> It's been a while since the first submission of these patches,
> but a lot of them have made it into linux-next already, so here
> is the stuff that is not merged yet, hopefully addressing all
> the comments.
>
> Geert and Michael: the I was expecting
Am 22.11.2013 08:29, schrieb Takashi Iwai:
> At Fri, 22 Nov 2013 00:49:54 +0100,
> Vincent Stehlé wrote:
>>
>> Teles PCI and HFC PCI-bus refuse to build on big-endian ARM; disable them in
>> Kconfig.
>>
>> Signed-off-by: Vincent Stehlé
>> Cc: Karsten Kei
Am 08.02.2015 um 20:47 schrieb Tilman Schmidt:
> Am 07.02.2015 um 21:43 schrieb Paul Bolle:
>> On Sat, 2015-02-07 at 11:19 -0800, Joe Perches wrote:
>>> Does anyone still use these cards?
>
>> 0) Good question.
>
> I very much doubt it. It was an ISA card, not even PnP. I'd imagine
> any systems
65 matches
Mail list logo
