Re: [PATCH] gpio: New driver for GPO emulation using PWM generators

2012-11-28 Thread Lars-Peter Clausen
On 11/28/2012 09:54 AM, Peter Ujfalusi wrote: > Hi Grant, Lars, Thierry, > > On 11/26/2012 04:46 PM, Grant Likely wrote: >> You're effectively asking the pwm layer to behave like a gpio (which >> is completely reasonable). Having a completely separate translation node >> really doesn't make sense

Re: [PATCH v2] IIO ADC support for AD7923

2013-02-12 Thread Lars-Peter Clausen
On 02/12/2013 06:10 PM, Christophe Leroy wrote: > This patch adds support for Analog Devices AD7923 ADC in the IIO Subsystem. > > Signed-off-by: Patrick Vasseur > Signed-off-by: Christophe Leroy Looks good to me except for one small, but important issue. [...] > diff -urN linux-next-e347c98/dr

Re: [PATCH 2/2] dma: pl330: Use the generic of_dma_xlate_by_chan_id

2013-04-02 Thread Lars-Peter Clausen
On 04/02/2013 11:12 AM, PADMAVATHI VENNA wrote: > Hi Lars, > > --- Original Message --- > Sender : Lars-Peter Clausen > Date : Apr 02, 2013 16:33 (GMT+09:00) > Title : Re: [PATCH 2/2] dma: pl330: Use the generic of_dma_xlate_by_chan_id > > On 04/02/2013 08:27 AM

Re: [PATCH] sound: soc: tegra: do not provide PAUSE/RESUME in hardware info

2013-04-03 Thread Lars-Peter Clausen
On 04/03/2013 11:19 AM, Laxman Dewangan wrote: > Tegra PCM driver uses the dmaengine based DMA driver and Tegra DMA > driver does not support the pause/resume functionality as hardware > does not support it. > > ALSA driver support the sw based pause/resume functionality if hardware > does not sup

Re: [RFC: PATCH 2/2] iio: adc: exynos_adc: Handle timeout and race conditions

2013-04-05 Thread Lars-Peter Clausen
On 04/03/2013 07:06 PM, Doug Anderson wrote: > Lars, > > On Sat, Mar 16, 2013 at 7:41 AM, Lars-Peter Clausen wrote: >> I think you still need the mutex for serialization, otherwise the requests >> would just cancel each other out. Btw. what happens if you start a conversio

Re: [RFC: PATCH 2/2] iio: adc: exynos_adc: Handle timeout and race conditions

2013-04-05 Thread Lars-Peter Clausen
On 04/05/2013 04:56 PM, Doug Anderson wrote: > Lars, > > On Fri, Apr 5, 2013 at 1:53 AM, Lars-Peter Clausen wrote: >> Since we sleep inside the protected section we need to use a mutex. > > Ah, good point. > >> It's not the timeout case I'm worried abou

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-24 Thread Lars-Peter Clausen
On 01/24/2013 01:42 AM, Doug Anderson wrote: > Lars, > > On Wed, Jan 23, 2013 at 4:52 AM, Lars-Peter Clausen wrote: >>> Few doubts regarding the mappings and child device handling. >>> Kindly, suggest me better methods. >> >> The patch looks mostly good n

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-24 Thread Lars-Peter Clausen
On 01/24/2013 03:20 PM, Naveen Krishna Ch wrote: > On 24 January 2013 15:24, Lars-Peter Clausen wrote: >> >> On 01/24/2013 01:42 AM, Doug Anderson wrote: >>> Lars, >>> >>> On Wed, Jan 23, 2013 at 4:52 AM, Lars-Peter Clausen wrote: >>>>> Fe

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-24 Thread Lars-Peter Clausen
On 01/24/2013 05:12 PM, Doug Anderson wrote: > Lars, > > Thank you for your comments / thoughts... > Hi, > > On Thu, Jan 24, 2013 at 1:54 AM, Lars-Peter Clausen wrote: >> adc: adc@12D1 { >> >> #io-channel-cells = <1>; >>

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-24 Thread Lars-Peter Clausen
On 01/24/2013 08:15 PM, Tomasz Figa wrote: > Hi, > > On Thursday 24 of January 2013 19:19:57 Lars-Peter Clausen wrote: >> On 01/24/2013 05:12 PM, Doug Anderson wrote: >>> Lars, >>> >>> Thank you for your comments / thoughts... >> >> Hi, >

Re: [PATCH v5] iio: Add OF support

2013-02-25 Thread Lars-Peter Clausen
; to get it accepted, please let me know. > Was kind of hoping for a few ack/ reviewed by comments! Missed current merge > window so I will pick it up for start of next cycle and assume silence means > everyone else is happy! The latest version looked good to me, you can add my: Reviewed-

[PATCH] mfd:adp5520: Restore mode bits on resume

2013-02-19 Thread Lars-Peter Clausen
The adp5520 unfortunately also clears the BL_EN bit when the nSTNDBY bit is cleared. So we need to make sure to restore it during resume if it was set before suspend. Cc: sta...@vger.kernel.org Signed-off-by: Lars-Peter Clausen --- drivers/mfd/adp5520.c | 8 ++-- 1 file changed, 6

Re: [PATCH] dma: timb_dma: Fix compiler warning

2013-02-19 Thread Lars-Peter Clausen
On 02/18/2013 08:59 PM, maxin.j...@gmail.com wrote: > From: "Maxin B. John" > > Fix this compiler warning: > warning: 'td_remove' defined but not used [-Wunused-function] > > Signed-off-by: Maxin B. John > --- > drivers/dma/timb_dma.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-

[PATCH] backlight: adp8860/adp8870: Fix resume

2013-02-19 Thread Lars-Peter Clausen
Clearing the NSTBY bit in the control register also automatically clears the BLEN bit. So we need to make sure to set it again during resume, otherwise the backlight will stay off. Cc: sta...@vger.kernel.org Signed-off-by: Lars-Peter Clausen --- drivers/video/backlight/adp8860_bl.c | 2

Re: [PATCH 05/16] blackfin idle: delete pm_idle

2013-02-20 Thread Lars-Peter Clausen
On 02/20/2013 08:52 PM, Rafael J. Wysocki wrote: > On Monday, February 18, 2013 05:28:19 PM Lars-Peter Clausen wrote: >> On 02/10/2013 06:58 AM, Len Brown wrote: >>> From: Len Brown >>> >>> pm_idle is dead code on blackfin. >>> >>

Re: [PATCH 05/16] blackfin idle: delete pm_idle

2013-02-20 Thread Lars-Peter Clausen
On 02/20/2013 08:59 PM, Rafael J. Wysocki wrote: > On Wednesday, February 20, 2013 08:53:38 PM Lars-Peter Clausen wrote: >> On 02/20/2013 08:52 PM, Rafael J. Wysocki wrote: >>> On Monday, February 18, 2013 05:28:19 PM Lars-Peter Clausen wrote: >>>> On 02/10/

[PATCH] blackfin idle: Fix compile error

2013-02-21 Thread Lars-Peter Clausen
ocess.c:83: error: (Each undeclared identifier is reported only once arch/blackfin/kernel/process.c:83: error: for each function it appears in.) arch/blackfin/kernel/process.c:88: error: implicit declaration of function ‘idle’ This patch fixes it. Signed-off-by: Lars-Peter Clausen

[PATCH] microblaze idle: Fix compile error

2013-02-21 Thread Lars-Peter Clausen
arch/microblaze/kernel/process.c:100: error: (Each undeclared identifier is reported only once arch/microblaze/kernel/process.c:100: error: for each function it appears in.) arch/microblaze/kernel/process.c:106: error: implicit declaration of function 'idle' This pa

Re: [PATCH 09/16] ia64 idle: delete pm_idle

2013-02-21 Thread Lars-Peter Clausen
On 02/10/2013 06:58 AM, Len Brown wrote: > From: Len Brown > > pm_idle() on ia64 was a synonym for default_idle(). > So simply invoke default_idle() directly. > > Signed-off-by: Len Brown > Cc: linux-i...@vger.kernel.org > --- > arch/ia64/kernel/process.c | 3 --- > arch/ia64/kernel/setup.c

Re: [PATCH] backlight: da903x_bl: switch to using SIMPLE_DEV_PM_OPS

2013-03-12 Thread Lars-Peter Clausen
On 03/12/2013 06:48 AM, Jingoo Han wrote: > This reduces #ifdefs in the code. Also, CONFIG_PM_SLEEP is used > to avoid warnings of unused functions if CONFIG_PM_SLEEP is not > defined. > > Signed-off-by: Jingoo Han I think you can eliminate the suspend/resume functions all together by using the

[PATCH] regmap: Fix regcache-rbtree sync

2013-03-13 Thread Lars-Peter Clausen
upply ranges to the sync operations"). Cc: sta...@vger.kernel.org Signed-off-by: Lars-Peter Clausen --- drivers/base/regmap/regcache-rbtree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/regmap/regcache-rbtree.c b/drivers/base/regmap/regcache-rbtree.c ind

Re: [PATCH v3] iio: adc: exynos5_adc: fix compilation warnings

2013-03-13 Thread Lars-Peter Clausen
On 03/13/2013 07:01 PM, Doug Anderson wrote: > Naveen, > > On Tue, Mar 12, 2013 at 9:48 PM, Naveen Krishna Chatradhi > wrote: >> Doug, There was a comment from Lars regarding the match not >> being NULL, if driver depends on CONFIG_OF. So, i've removed >> the NULL check in v2 of this patch. >>

Re: [PATCH v3] iio: adc: exynos5_adc: fix compilation warnings

2013-03-13 Thread Lars-Peter Clausen
On 03/13/2013 07:23 PM, Doug Anderson wrote: > Lars, > > On Wed, Mar 13, 2013 at 11:11 AM, Lars-Peter Clausen wrote: >> Agreed. Adding the dependency on OF in Kconfig should be all that is needed. > > I think changing the timeout from 'unsigned long' to '

Re: [PATCH v3] iio: adc: exynos5_adc: fix compilation warnings

2013-03-13 Thread Lars-Peter Clausen
On 03/13/2013 07:35 PM, Lars-Peter Clausen wrote: > On 03/13/2013 07:23 PM, Doug Anderson wrote: >> Lars, >> >> On Wed, Mar 13, 2013 at 11:11 AM, Lars-Peter Clausen wrote: >>> Agreed. Adding the dependency on OF in Kconfig should be all that is needed. >>

Re: [RFC: PATCH 2/2] iio: adc: exynos_adc: Handle timeout and race conditions

2013-03-15 Thread Lars-Peter Clausen
derson > Cc: Lars-Peter Clausen > --- > Discussion thread for this patch can be found at > http://www.gossamer-threads.com/lists/linux/kernel/1693284?page=last > > I've not seen any reference to spin lock usage in IIO. > Kindly, suggest me if there is a better way to avoi

Re: [RFC: PATCH 2/2] iio: adc: exynos_adc: Handle timeout and race conditions

2013-03-16 Thread Lars-Peter Clausen
On 03/16/2013 01:37 AM, Doug Anderson wrote: > On Fri, Mar 15, 2013 at 2:53 PM, Lars-Peter Clausen wrote: >> What exactly is the spinlock protecting against here? Concurrent runs of >> exynos_adc_isr? This is probably not issue in the first place. >> >> What you want

Re: [PATCH v3] hwmon: add Maxim MAX197 support

2012-09-01 Thread Lars-Peter Clausen
On 08/31/2012 06:04 PM, Guenter Roeck wrote: > On Thu, Aug 30, 2012 at 09:42:57PM -0400, Vivien Didelot wrote: >> The MAX197 is an A/D converter, made by Maxim. This driver currently >> supports the MAX197, and MAX199. They are both 8-Channel, Multi-Range, >> 5V, 12-Bit DAS with 8+4 Bus Interface a

Re: [PATCH 3/3] pwm: Add Ingenic JZ4740 support

2012-09-02 Thread Lars-Peter Clausen
0.c > new file mode 100644 > index 000..db29b37 > --- /dev/null > +++ b/drivers/pwm/pwm-jz4740.c > @@ -0,0 +1,205 @@ > +/* > + * Copyright (C) 2010, Lars-Peter Clausen > + * JZ4740 platform PWM support > + * > + * This program is free software; you can redist

Re: [PATCH 2/3] MIPS: JZ4740: Export timer API

2012-09-02 Thread Lars-Peter Clausen
+ writew(ctrl, jz4740_timer_base + JZ_REG_TIMER_CTRL(timer)); > +} > +EXPORT_SYMBOL_GPL(jz4740_timer_set_ctrl); > + > +uint16_t jz4740_timer_get_ctrl(unsigned int timer) > +{ > + return readw(jz4740_timer_base + JZ_REG_TIMER_CTRL(timer)); > +} > +EXPORT_SYMBOL_GPL(j

Re: [PATCH 1/3] MIPS: JZ4740: Break circular header dependency

2012-09-02 Thread Lars-Peter Clausen
ile mode 100644 > index f75e39d..000 > --- a/arch/mips/jz4740/irq.h > +++ /dev/null > @@ -1,23 +0,0 @@ > -/* > - * Copyright (C) 2010, Lars-Peter Clausen > - * > - * This program is free software; you can redistribute it and/or modify it > - * under the terms of the GNU Genera

Re: [PATCH 3/5] drivers/video/jz4740_fb.c: use devm_ functions

2012-09-02 Thread Lars-Peter Clausen
On 08/23/2012 10:41 PM, Florian Tobias Schandinat wrote: > On 08/03/2012 03:40 PM, Damien Cassou wrote: >> From: Damien Cassou >> >> The various devm_ functions allocate memory that is released when a driver >> detaches. This patch uses these functions for data that is allocated in the >> probe fu

Re: [PATCH 3/3] pwm: Add Ingenic JZ4740 support

2012-09-02 Thread Lars-Peter Clausen
On 09/02/2012 09:59 PM, Thierry Reding wrote: >>> + is_enabled = jz4740_timer_is_enabled(pwm->hwpwm); >>> + if (is_enabled) >>> + pwm_disable(pwm); >> >> I think this should be jz4740_pwm_disable >> >>> + >>> + jz4740_timer_set_count(pwm->hwpwm, 0); >>> + jz4740_timer_set_duty(pwm

Re: [PATCH 2/3] MIPS: JZ4740: Export timer API

2012-09-02 Thread Lars-Peter Clausen
On 09/02/2012 10:21 PM, Thierry Reding wrote: > On Sun, Sep 02, 2012 at 04:45:43PM +0200, Lars-Peter Clausen wrote: >> On 09/02/2012 11:52 AM, Thierry Reding wrote: >>> This is a prerequisite for allowing the PWM driver to be converted to >>> the PWM framework. >

Re: [PATCH 4/4] drivers/mtd/nand/mpc5121_nfc.c: some devm_ cleanups

2012-09-04 Thread Lars-Peter Clausen
On 09/04/2012 10:42 AM, Artem Bityutskiy wrote: > Aiaiai! :-) [1] [2] > > I've build-tested this using aiaiai and it reports that this change breaks > the build: > > dedekind@blue:~/git/maintaining$ ./verify ../l2-mtd/ mpc5121_nfc < > ~/tmp/julia2.mbox > Tested the patch(es) on top of the foll

Re: [PATCH] [RFC]power: battery: Generic battery driver using IIO

2012-09-11 Thread Lars-Peter Clausen
On 09/10/2012 05:40 PM, anish kumar wrote: > From: anish kumar > > This is the cleaned up code after the valuable inputs from > the Jonathan, Lars and Anton. > > I have tried to accomodate all the concerns however please > let me know incase something is missed out. > > Signed-off-by: anish kum

Re: [PATCH] clk: Make the managed clk functions generically available

2012-09-11 Thread Lars-Peter Clausen
On 09/10/2012 02:39 AM, Russell King - ARM Linux wrote: > On Mon, Sep 10, 2012 at 08:20:21AM +0800, Mark Brown wrote: >>[...] >> OK, that's what I'd thought was going on - it was the fact that you'd >> just acked the patch rather than asked for it to go to the patch tracker >> or something which ma

Re: [PATCH v2 3/3] pwm: Add Ingenic JZ4740 support

2012-09-11 Thread Lars-Peter Clausen
On 09/11/2012 07:02 AM, Thierry Reding wrote: > On Mon, Sep 10, 2012 at 11:51:48PM +0200, Lars-Peter Clausen wrote: >> On 09/10/2012 02:05 PM, Thierry Reding wrote: >>> This commit moves the driver to drivers/pwm and converts it to the new >>> PWM framework. >>&g

Re: [PATCH v2 0/3] MIPS: JZ4740: Move PWM driver to PWM framework

2012-09-11 Thread Lars-Peter Clausen
On 09/10/2012 07:30 PM, Thierry Reding wrote: > On Mon, Sep 10, 2012 at 05:20:34PM +0200, Lars-Peter Clausen wrote: >> On 09/10/2012 02:05 PM, Thierry Reding wrote: >>> Hi, >>> >> >> [...] > >> Patch 1 should go through the MIPS tree, but I still

Re: [PATCH] clk: Make the managed clk functions generically available

2012-09-12 Thread Lars-Peter Clausen
On 09/12/2012 03:32 AM, Greg Ungerer wrote: > On 12/09/12 00:50, Artem Bityutskiy wrote: >> On Tue, 2012-09-11 at 16:44 +0200, Lars-Peter Clausen wrote: >>> On 09/10/2012 02:39 AM, Russell King - ARM Linux wrote: >>>> On Mon, Sep 10, 2012 at 08:20:21AM +0800, Mark Bro

Re: [PATCH v3 4/5] IIO : ADC: tiadc: Add support of TI's ADC driver

2012-09-13 Thread Lars-Peter Clausen
On 09/13/2012 12:40 PM, Patil, Rachna wrote: > This patch adds support for TI's ADC driver. > This is a multifunctional device. > Analog input lines are provided on which > voltage measurements can be carried out. > You can have upto 8 input lines. > Hi, couple of minor issues inline. > Signed-

Re: [PATCH v3 5/5] MFD: ti_tscadc: add suspend/resume functionality

2012-09-13 Thread Lars-Peter Clausen
On 09/13/2012 12:40 PM, Patil, Rachna wrote: > This patch adds support for suspend/resume of > TSC/ADC MFDevice. > > Signed-off-by: Patil, Rachna > --- > Changes in v2: > Added this patch newly in this patch series. > > Changes in v3: > No changes. > > drivers/iio/adc/ti_adc.c

Re: [PATCH v2 03/15] dmaengine: Add no_wakeup parameter to dmaengine_prep_dma_cyclic()

2012-09-13 Thread Lars-Peter Clausen
On 09/13/2012 03:37 PM, Peter Ujfalusi wrote: > The dmaengine_prep_dma_cyclic() function primarily used by audio for cyclic > transfer required by ALSA. > With this new parameter it is going to be possible to enable the > SNDRV_PCM_INFO_NO_PERIOD_WAKEUP mode on platforms where it is possible. > Thi

Re: [PATCH v2 03/15] dmaengine: Add no_wakeup parameter to dmaengine_prep_dma_cyclic()

2012-09-14 Thread Lars-Peter Clausen
On 09/14/2012 05:26 AM, Vinod Koul wrote: > On Thu, 2012-09-13 at 17:27 +0200, Lars-Peter Clausen wrote: >> Hi, >> >> Hm... Do you think it would work as well if we implement this by >> setting the >> callback for the descriptor to NULL? If the callback is NULL the

Re: [PATCH v5] iio: adc: add new lp8788 adc driver

2012-09-14 Thread Lars-Peter Clausen
On 09/14/2012 02:33 AM, Kim, Milo wrote: >> Hi, >> >> One issue and a couple of nitpicks inline. > > I really appreciate it. > Please see my questions below. > >>> + switch (mask) { >>> + case IIO_CHAN_INFO_RAW: >>> + ret = lp8788_get_adc_result(adc, id, val) ? -EIO : >> IIO_VAL_INT

Re: [PATCH] pwm: Get rid of HAVE_PWM

2012-10-04 Thread Lars-Peter Clausen
On 10/04/2012 08:06 AM, Thierry Reding wrote: > [...] > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 331d574..b38f23d 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -219,7 +219,8 @@ config MACH_JZ4740 > select GENERIC_GPIO > select ARCH_REQUIRE_GPIOLIB >

Re: [PATCH] pwm: Get rid of HAVE_PWM

2012-10-04 Thread Lars-Peter Clausen
On 10/04/2012 08:29 PM, Thierry Reding wrote: > On Thu, Oct 04, 2012 at 05:00:23PM +0200, Lars-Peter Clausen wrote: >> On 10/04/2012 08:06 AM, Thierry Reding wrote: >>> [...] >>> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig >>> index 331d574..b38f23

Re: [PATCH 1/3] ti_adc: Update with IIO map interface

2012-10-31 Thread Lars-Peter Clausen
On 11/01/2012 04:24 PM, Pantelis Antoniou wrote: > Add an IIO map interface that consumers can use. Hi, Looks like you overlooked the review comments I had inline last time. I've put them in again, see below. > > Signed-off-by: Pantelis Antoniou > --- > drivers/iio/adc/ti_am335x_adc.c | 60 >

Re: [PATCH 1/3] ti_adc: Update with IIO map interface

2012-10-31 Thread Lars-Peter Clausen
On 10/31/2012 06:55 PM, Pantelis Antoniou wrote: > [...] >>> } >>> >>> indio_dev->channels = chan_array; >>> + indio_dev->num_channels = channels; >>> + >>> + size = (channels + 1) * sizeof(struct iio_map); >>> + adc_dev->map = kzalloc(size, GFP_KERNEL); >>> + if (adc_dev->map == NU

Re: [PATCH 1/3] ti_adc: Update with IIO map interface

2012-10-31 Thread Lars-Peter Clausen
On 10/31/2012 07:12 PM, Pantelis Antoniou wrote: > > On Oct 31, 2012, at 8:07 PM, Lars-Peter Clausen wrote: > >> On 10/31/2012 06:55 PM, Pantelis Antoniou wrote: >>> [...] >>>>> } >>>>> >>>>> indio_dev->channels = chan

Re: [PATCH 1/3] ti_adc: Update with IIO map interface

2012-10-31 Thread Lars-Peter Clausen
On 10/31/2012 07:43 PM, Pantelis Antoniou wrote: > > On Oct 31, 2012, at 8:36 PM, Lars-Peter Clausen wrote: > >> On 10/31/2012 07:12 PM, Pantelis Antoniou wrote: >>> >>> On Oct 31, 2012, at 8:07 PM, Lars-Peter Clausen wrote: >>> >>&g

[PATCH 2/5] asm-generic/mmu.h: Add support for FDPIC

2012-11-01 Thread Lars-Peter Clausen
architectures. Signed-off-by: Lars-Peter Clausen --- include/asm-generic/mmu.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/asm-generic/mmu.h b/include/asm-generic/mmu.h index a67ae0a9..0ed3f1c 100644 --- a/include/asm-generic/mmu.h +++ b/include/asm-generic

[PATCH 3/5] h8300: Use generic asm/mmu.h

2012-11-01 Thread Lars-Peter Clausen
h8300's asm/mmu.h is basically identical to asm-generic/mmu.h, so use it instead of the custom version. Signed-off-by: Lars-Peter Clausen --- Note, due to lack of toolchain, etc this patch is completely untested. --- arch/h8300/include/asm/Kbuild |1 + arch/h8300/include/asm/mmu.h |

[PATCH 1/5] asm-generic/mmu.h: Remove unused vmlist field from mm_context_t

2012-11-01 Thread Lars-Peter Clausen
Nothing is using the vmlist field in mm_context_t anymore. It has been removed from the non-generic versions over 3 years ago 8feae1311 ("NOMMU: Make VMAs per MM as for MMU-mode linux"). Signed-off-by: Lars-Peter Clausen --- include/asm-generic/mmu.h |1 - 1 files changed, 0

[PATCH 5/5] xtensa: Use generic asm/mmu.h for nommu

2012-11-01 Thread Lars-Peter Clausen
The nommu portion of mmu.h of the extensa platform is basically the same as the asm-generic mmu.h. So use it instead. Signed-off-by: Lars-Peter Clausen --- Note, due to lack of toolchain, etc this patch is completely untested. --- arch/xtensa/include/asm/mmu.h |2 +- arch/xtensa/include

[PATCH 4/5] c6x: Use generic asm/mmu.h

2012-11-01 Thread Lars-Peter Clausen
c6x's asm/mmu.h is basically identical to asm-generic/mmu.h, so use it instead of the custom version. Signed-off-by: Lars-Peter Clausen --- Note, due to lack of toolchain, etc this patch is completely untested. --- arch/c6x/include/asm/Kbuild |1 + arch/c6x/include/asm/mmu.h |

Re: [PATCH 7/8] serial: xilinx_uartps: get clock rate info from dts

2012-11-02 Thread Lars-Peter Clausen
On 10/31/2012 08:28 PM, Josh Cartwright wrote: > Add support for specifying clock information for the uart clk via the > device tree. This eliminates the need to hardcode rates in the device > tree. > > Signed-off-by: Josh Cartwright > --- > arch/arm/boot/dts/zynq-7000.dtsi | 4 ++-- > drive

Re: [PATCH 5/8] ARM: zynq: add COMMON_CLK support

2012-11-02 Thread Lars-Peter Clausen
On 10/31/2012 07:58 PM, Josh Cartwright wrote: > [...] > +#define PERIPH_CLK_CTRL_SRC(x) (periph_clk_parent_map[((x)&3)>>4]) > +#define PERIPH_CLK_CTRL_DIV(x) (((x)&0x3F00)>>8) A few more spaces wouldn't hurt ;) > [...] > +static void __init zynq_periph_clk_setup(struct device_node *n

Re: [PATCH 5/8] ARM: zynq: add COMMON_CLK support

2012-11-02 Thread Lars-Peter Clausen
On 11/02/2012 02:38 PM, Josh Cartwright wrote: > Thanks for the review. > > On Fri, Nov 02, 2012 at 10:33:44AM +0100, Lars-Peter Clausen wrote: >> On 10/31/2012 07:58 PM, Josh Cartwright wrote: >>> [...] >>> +#define PERIPH_CLK_CTRL_SRC(x) (periph_clk_par

Re: [alsa-devel] [PATCH 5/9] ASoC: Only compile adav80x codec when a bus is defined

2012-11-04 Thread Lars-Peter Clausen
On 11/03/2012 11:02 PM, Lee Jones wrote: > If !CONFIG_SPI and !CONFIG_I2C* then there is no point adding support > for the adav80x codec as it relies on a bus to operate. This patch > fixes the build warnings below when SPI and I2C are not specified in > the configuration. > > sound/soc/codecs/ada

Re: [PATCH v3 5/5] iio: adc: add viperboard adc driver

2012-11-05 Thread Lars-Peter Clausen
On 11/05/2012 03:48 PM, Lars Poeschel wrote: > From: Lars Poeschel > > This adds the mfd cell to use the adc part of the Nano River Technologies > viperboard. > > Signed-off-by: Lars Poeschel Looks good to me. Reviewed-by: Lars-Peter Clausen If you happen to resend the s

Re: [PATCH] drivers/iio/adc/at91_adc.c: use devm_ functions

2012-07-31 Thread Lars-Peter Clausen
Hi, On 07/31/2012 12:09 PM, Julia Lawall wrote: > From: Julia Lawall > @@ -720,20 +698,14 @@ error_ret: > static int __devexit at91_adc_remove(struct platform_device *pdev) > { > struct iio_dev *idev = platform_get_drvdata(pdev); > - struct resource *res = platform_get_resource(pdev,

Re: NULL pointer dereference in iio_buffer_register()

2012-07-31 Thread Lars-Peter Clausen
On 07/31/2012 12:31 PM, Fengguang Wu wrote: >> [7.623739] BUG: unable to handle kernel NULL pointer dereference at >> 00b0 > > I managed to root cause it: > > [2.108085] BUG: unable to handle kernel NULL pointer dereference > at 0060 > [2.112015] EIP:

Re: NULL pointer dereference in iio_buffer_register()

2012-07-31 Thread Lars-Peter Clausen
On 07/31/2012 02:55 PM, Fengguang Wu wrote: >>> The panic happens while trying to dereference the NULL indio_dev->buffer: >>> >>> 266 int iio_buffer_register(struct iio_dev *indio_dev, >>> 267 const struct iio_chan_spec *channels, >>> 268

Re: [PATCH] drivers/iio/adc/at91_adc.c: use devm_ functions

2012-07-31 Thread Lars-Peter Clausen
On 07/31/2012 03:54 PM, Julia Lawall wrote: > > > On Tue, 31 Jul 2012, Lars-Peter Clausen wrote: > >> Hi, >> >> On 07/31/2012 12:09 PM, Julia Lawall wrote: >>> From: Julia Lawall >>> @@ -720,20 +698,14 @@ error_ret: >>> static i

Re: OOPS/panic in iio_dummy (v3.6-rc6-176-gabef3bd)

2012-09-22 Thread Lars-Peter Clausen
On 09/22/2012 04:13 AM, Peter Hüwe wrote: > Hi, > > loading iio_dummy results in kernel panic as the call to > iio_buffer_register in iio_dummy_probe is performed with indio_dev->buffer == > NULL and thus the access to indio_dev->buffer->attrs results in this > oops/panic. > > Thanks, > Peter

Re: [PATCH] ti_tscadc: Match mfd sub devices to regmap interface

2012-10-30 Thread Lars-Peter Clausen
On 10/31/2012 04:55 PM, Pantelis Antoniou wrote: > The MFD parent device now uses a regmap, instead of direct > memory access. Use the same method in the sub devices to avoid > nasty surprises. > > Also rework the channel initialization of tiadc a bit. Those two bits are not even closely related,

Re: [PATCH] ti_tscadc: Update with IIO map interface & deal with partial activation

2012-10-30 Thread Lars-Peter Clausen
On 10/31/2012 04:55 PM, Pantelis Antoniou wrote: > Add an IIO map interface that consumers can use. > Also make sure the mfd device doesn't activate a driver which > the configuration doesn't require. Same here, two completely different changes in the same patch. > > Signed-off-by: Pantelis Anto

Re: [PATCH] ti_tscadc: Match mfd sub devices to regmap interface

2012-10-31 Thread Lars-Peter Clausen
On 10/31/2012 05:41 AM, Russ Dill wrote: > On Wed, Oct 31, 2012 at 8:55 AM, Pantelis Antoniou > wrote: >> The MFD parent device now uses a regmap, instead of direct >> memory access. Use the same method in the sub devices to avoid >> nasty surprises. >> >> Also rework the channel initialization of

[PATCH] regcache-rbtree: Fix reg_stride != 1

2013-08-27 Thread Lars-Peter Clausen
e' in regcache_rbtree_sync() to 'start' to avoid confusion with 'base_reg'. Signed-off-by: Lars-Peter Clausen --- drivers/base/regmap/regcache-rbtree.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/base/regmap/reg

[PATCH resend] dma: pl330: Fix handling of TERMINATE_ALL while processing completed descriptors

2013-08-27 Thread Lars-Peter Clausen
ack to the descriptor pool. This makes sure that none of the descripts finds its way back into the work list and also that we do not call any futher complete callbacks after dmaengine_terminate_all() has been called. Signed-off-by: Lars-Peter Clausen --- drivers/dma/pl3

[PATCH] regmap: debugfs: Fix continued read from registers file

2013-08-28 Thread Lars-Peter Clausen
incorrect output from the registers file for all reads except at position 0. The issue can easily be reproduced by doing small reads the registers file, e.g. `dd if=registers bs=10 count=5`. Signed-off-by: Lars-Peter Clausen --- drivers/base/regmap/regmap-debugfs.c | 4 ++-- 1 file changed, 2

[PATCH 3/3] regmap: rbtree: Make cache_present bitmap per node

2013-08-28 Thread Lars-Peter Clausen
is optional and if NULL the core assumes that all registers are set. The rbtree cache also needs to implement its own drop callback instead of relying on the core to handle this. Signed-off-by: Lars-Peter Clausen --- drivers/base/regmap/internal.h| 14 +- drivers/base/regmap/regcache

[PATCH 2/3] regmap: rbtree: Reduce number of nodes, take 2

2013-08-28 Thread Lars-Peter Clausen
in the node's cache compared to allocating a new node. Signed-off-by: Lars-Peter Clausen --- drivers/base/regmap/regcache-rbtree.c | 53 --- 1 file changed, 36 insertions(+), 17 deletions(-) diff --git a/drivers/base/regmap/regcache-rbtree.c b/drivers/base

[PATCH 1/3] regmap: rbtree: Simplify adjacent node lookup

2013-08-28 Thread Lars-Peter Clausen
ether the register comes before the first register or after the last register of the node. Signed-off-by: Lars-Peter Clausen --- drivers/base/regmap/regcache-rbtree.c | 39 +-- 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/drivers/base/regmap/reg

[PATCH v2 2/3] regmap: rbtree: Reduce number of nodes, take 2

2013-08-29 Thread Lars-Peter Clausen
4. If we find a node that falls within this range it is cheaper or as expensive to add the register to the existing node and have a couple of unused registers in the node's cache compared to allocating a new node. Signed-off-by: Lars-Peter Clausen --- Changes since v1: * Repair commit me

[PATCH v2 1/3] regmap: rbtree: Simplify adjacent node look-up

2013-08-29 Thread Lars-Peter Clausen
ether the register comes before the first register or after the last register of the node. Signed-off-by: Lars-Peter Clausen --- No changes since v1. --- drivers/base/regmap/regcache-rbtree.c | 39 +-- 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/dr

[PATCH v2 3/3] regmap: rbtree: Make cache_present bitmap per node

2013-08-29 Thread Lars-Peter Clausen
. The parameter is optional and if NULL the core assumes that all registers are set. The rbtree cache also needs to implement its own drop callback instead of relying on the core to handle this. Signed-off-by: Lars-Peter Clausen --- No changes since v1 --- drivers/base/regmap/internal.h

Re: [PATCH 1/3] spi: Add a spi_w8r16be() helper

2013-10-03 Thread Lars-Peter Clausen
On 09/29/2013 02:30 PM, Mark Brown wrote: > On Fri, Sep 27, 2013 at 10:01:36PM +0200, Lars-Peter Clausen wrote: >> On 09/27/2013 09:22 PM, Mark Brown wrote: > >>> Indeed. I don't think that's terribly well thought through though, >>> especially not now we

Re: [PATCH] staging:iio: fix wrong usage of dev_set_name()

2013-10-03 Thread Lars-Peter Clausen
On 10/03/2013 04:57 PM, Sangjung Woo wrote: > The second parameter of dev_set_name() is format string. In order to > avoid any potential accidents such as segmentation fault, basic format > parameter "%s" should be used in this case. Since "iio_evgen" is a constant string there is really no need f

Re: [PATCH v2 2/3] i2c: xilinx: Set tx direction in write operation

2013-10-04 Thread Lars-Peter Clausen
On 10/04/2013 01:55 PM, Wolfram Sang wrote: > On Fri, Oct 04, 2013 at 11:53:49AM +0200, Michal Simek wrote: >> On 10/04/2013 07:46 AM, Wolfram Sang wrote: >>> + cr = xiic_getreg32(i2c, XIIC_CR_REG_OFFSET); + cr |= XIIC_CR_DIR_IS_TX_MASK; + xiic_setreg32(i2c, XIIC_CR_REG_OFFSET, cr

Re: [PATCH v2 2/3] i2c: xilinx: Set tx direction in write operation

2013-10-04 Thread Lars-Peter Clausen
On 10/04/2013 03:09 PM, Michal Simek wrote: > > > On 10/04/2013 02:12 PM, Lars-Peter Clausen wrote: >> On 10/04/2013 01:55 PM, Wolfram Sang wrote: >>> On Fri, Oct 04, 2013 at 11:53:49AM +0200, Michal Simek wrote: >>>> On 10/04/2013 07:46 AM, Wolfram

Re: [PATCH] IIO AD7923 iio_consumer support

2013-10-05 Thread Lars-Peter Clausen
On 10/05/2013 10:21 AM, Christophe Leroy wrote: > This patch adds support for iio_consumer to Analog Devices AD7923 ADC driver. > > Signed-off-by: Christophe Leroy > Verified-by: Patrick Vasseur > > diff -urN a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c > --- a/drivers/iio/adc/ad7923.c

Re: [PATCH] IIO AD7923 iio_consumer support

2013-10-05 Thread Lars-Peter Clausen
On 10/05/2013 11:18 AM, leroy christophe wrote: > > Le 05/10/2013 10:41, Lars-Peter Clausen a écrit : >> On 10/05/2013 10:21 AM, Christophe Leroy wrote: >>> +.consumer_channel = "channel_0", >>> +.adc_channel_label = "0", >

Re: [PATCH] IIO AD7923 iio_consumer support

2013-10-05 Thread Lars-Peter Clausen
On 10/05/2013 11:39 AM, leroy christophe wrote: > > Le 05/10/2013 11:35, Lars-Peter Clausen a écrit : >> On 10/05/2013 11:18 AM, leroy christophe wrote: >>> Le 05/10/2013 10:41, Lars-Peter Clausen a écrit : >>>> On 10/05/2013 10:21 AM, Christophe Leroy wrote:

Re: [RFC] dmaengine: add dma_slave_get_caps api

2013-07-08 Thread Lars-Peter Clausen
On 07/08/2013 10:54 AM, Vinod Koul wrote: > add new device callback .device_slave_caps api which can be used by clients to > query the dma channel capablties before they program the channel. This can > help > is removing errors during the channel programming. Also add helper > dma_slave_get_caps A

Re: [RFC] dmaengine: add dma_slave_get_caps api

2013-07-08 Thread Lars-Peter Clausen
On 07/08/2013 03:40 PM, Vinod Koul wrote: > On Mon, Jul 08, 2013 at 02:01:35PM +0200, Lars-Peter Clausen wrote: >> On 07/08/2013 10:54 AM, Vinod Koul wrote: >>> +/* struct dma_slave_caps - expose capabilities of a slave channel only >>> + * >>> + * @src_addr_wid

Re: [alsa-devel] [PATCH v2 1/5] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards

2013-07-08 Thread Lars-Peter Clausen
On 07/08/2013 03:29 PM, Richard Genoud wrote: [...] > +/* > + * Logic for a wm8731 as connected on a at91sam9x5 based board. > + */ > +static int at91sam9x5ek_wm8731_init(struct snd_soc_pcm_runtime *rtd) > +{ [...] > + codec_dai->driver->playback.rates &= SNDRV_PCM_RATE_8000 | > + S

Re: [RFC] dmaengine: add dma_slave_get_caps api

2013-07-08 Thread Lars-Peter Clausen
On 07/08/2013 04:03 PM, Vinod Koul wrote: > On Mon, Jul 08, 2013 at 04:28:29PM +0200, Lars-Peter Clausen wrote: >> On 07/08/2013 03:40 PM, Vinod Koul wrote: >>> On Mon, Jul 08, 2013 at 02:01:35PM +0200, Lars-Peter Clausen wrote: >>>> On 07/08/2013 10:54 AM, Vino

Re: [Cocci] [PATCH] invoke arguments the right way in coccinelle script

2013-07-09 Thread Lars-Peter Clausen
On 07/09/2013 05:21 PM, Cristian Bercaru wrote: > Because the command line arguments were invoked incorrectly > 'make coccicheck' failed to run 'irqf_oneshot.cocci' and all tests that > followed. Fixed that. > > Signed-off-by: Cristian Bercaru Time to update your coccinelle installation ;) --no

Re: [RFC] iio: mxs-lradc: compute temperature from channel 8 and 9

2013-07-12 Thread Lars-Peter Clausen
gt; Signed-off-by: Alexandre Belloni > > I didn't get any review on that patch. I know it will already conflict > with what Hector has been working on but would that be the good way to go ? Yes, looks good to me. If you don't make any other fixes than resolving the conflict yo

Re: [PATCH] iio: add APDS9300 ambilent light sensor driver

2013-07-12 Thread Lars-Peter Clausen
On 07/10/2013 03:08 PM, Oleksandr Kravchenko wrote: > From: Oleksandr Kravchenko > > This patch adds IIO driver for APDS9300 ambilent light sensor (ALS). s/ambilent/ambient/ > http://www.avagotech.com/docs/AV02-1077EN > > The driver allows to read raw data from ADC registers or calculate > lux

Re: [PATCH v3 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver

2013-07-12 Thread Lars-Peter Clausen
A couple of comments inline. On 07/12/2013 09:18 AM, Oleksandr Kozaruk wrote: diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index ab0767e6..87d699e 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig @@ -157,4 +157,12 @@ config VIPERBOARD_ADC Say yes he

Re: [PATCH 14/38] iio: accel: st: Append _accel to accelerator sensor device names

2013-09-16 Thread Lars-Peter Clausen
On 09/14/2013 02:27 PM, Jonathan Cameron wrote: > On 09/14/13 13:14, Jonathan Cameron wrote: >> On 09/10/13 13:49, Lee Jones wrote: >>> Some of ST's sensors are appended with their sensor type and some >>> are not. For consistency we're extending the same naming convention >>> throughout. >>> >>> S

[PATCH] kfifo: kfifo_copy_{to,from}_user: Fix copied bytes calculation

2013-09-16 Thread Lars-Peter Clausen
'copied' and 'len' are in bytes, while 'ret' is in elements, so we need to multiply 'ret' with the size of one element to get the correct result. Signed-off-by: Lars-Peter Clausen --- lib/kfifo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH 14/38] iio: accel: st: Append _accel to accelerator sensor device names

2013-09-16 Thread Lars-Peter Clausen
On 09/16/2013 11:21 AM, Denis CIOCCA wrote: > Hi Lars, >> On 09/14/2013 02:27 PM, Jonathan Cameron wrote: >>> On 09/14/13 13:14, Jonathan Cameron wrote: On 09/10/13 13:49, Lee Jones wrote: > Some of ST's sensors are appended with their sensor type and some > are not. For consistency we

Re: [PATCH 14/38] iio: accel: st: Append _accel to accelerator sensor device names

2013-09-16 Thread Lars-Peter Clausen
On 09/16/2013 03:31 PM, Lee Jones wrote: >> Honestly I don't care either way on these, but consistency would definitely >> be good so applied to the togreg branch of iio.git > > For clarification, is togreg due for the v3.12 merge window or will be > get a settling period in -next? > Well everyt

Re: [PATCH 0/2] vsprintf: ignore %n again

2013-09-16 Thread Lars-Peter Clausen
On 09/16/2013 05:55 PM, Al Viro wrote: > On Mon, Sep 16, 2013 at 12:43:55AM -0700, Kees Cook wrote: >> Whether seq_printf should return void or error, %n still needs to be removed. >> As such, instead of changing the seq_file structure and adding instructions >> to all callers of seq_printf, just e

Re: [PATCH 11/11] iio: pressure-core: st: Provide correct regulator support

2013-09-04 Thread Lars-Peter Clausen
On 09/04/2013 03:11 PM, Mark Rutland wrote: > Hi Lee, > > On Wed, Sep 04, 2013 at 10:31:43AM +0100, Lee Jones wrote: >> The power to some of the sensors are controlled by regulators. In most >> cases these are 'always on', but if not they will fail to work until >> the regulator is enabled using t

Re: [PATCH 27/38] iio: pressure-core: st: Give some indication if device probing was successful

2013-09-11 Thread Lars-Peter Clausen
On 09/11/2013 09:10 AM, Lee Jones wrote: On Tue, 10 Sep 2013, Jonathan Cameron wrote: Lee Jones wrote: At the moment the driver is silent in some error cases and if successful. Prior to this patch there was no clear way to know if the driver succeeded or not without looking deep into sysfs. S

Re: [PATCH 1/2] i2c-mux-gpio: test if the gpio can sleep

2013-10-10 Thread Lars-Peter Clausen
On 10/10/2013 10:39 AM, Ionut Nicu wrote: > Some gpio chips may have get/set operations that > can sleep. For this type of chips we must use the > _cansleep() version of gpio_set_value. > > Signed-off-by: Ionut Nicu > --- > drivers/i2c/muxes/i2c-mux-gpio.c | 11 --- > 1 files changed,

  1   2   3   4   5   6   7   8   9   10   >